platform/upstream/elementary.git
7 years agoentry: fix cursor position initialization issues when theme is changed 64/165264/1 tizen_3.0
Youngbok Shin [Wed, 27 Dec 2017 10:28:31 +0000 (19:28 +0900)]
entry: fix cursor position initialization issues when theme is changed

The issue was caused by the following patch.
"elm_entry: Save cursor position before entry text clear"

It needed to get cursor position at the text_set function to avoid
cursor position issue by delaying signal callback functions.
So, we can't remove the patch. In the theme_apply, we need to handle
cursor position more carefully to fix this side effect.

@tizen_fix

Change-Id: Id63aa401ba2572559bc241f54350b781c72f5092

7 years agoentry: disable text selection by user interaction if elm_entry_select_allow_set(... 94/163794/4
Youngbok Shin [Wed, 13 Dec 2017 10:29:47 +0000 (19:29 +0900)]
entry: disable text selection by user interaction if elm_entry_select_allow_set() is called with EINA_FALSE

@tizen_fix

Change-Id: I86a2bc892f8de66c3d59b270f6146f03ac225506

7 years agoatspi: not accept redundant leaf object 79/163279/1
Shinwoo Kim [Fri, 8 Dec 2017 07:54:54 +0000 (16:54 +0900)]
atspi: not accept redundant leaf object

An object which role is ELM_ATSPI_ROLE_REDUNDANT_OBJECT, has been acceptable
so far regardless its children. So it was possible to find its children.
But it does not make sense to accept ELM_ATSPI_ROLE_REDUNDANT_OBJECT object if
it does not have children.

There was an issue on Browser application because we accepted REDUNDANT leaf
object. There is a button which role is ELM_ATSPI_ROLE_REDUNDANT_OBJECT, this
button would be used for conveying focus event to embedded web page.
The button was accepted, so it was not possible grab an object on web page.

Please refer to following part of accessibility tree. It is not possible to
get Elm_Atspi_Ewk_Wrapper, if Elm_Button is accepted for "GetNavigableAtPoint"

Elm_Layout
     - Elm_Button [redundant object][0,148,1080,1604]
     - Elm_Atspi_Ewk_Wrapper [embedded][0,148,1080,1604]

Change-Id: I355a913314d0132e0b0e0f7779e1d7c0b66b25db

7 years agoatspi: do not accept ELM_ATSPI_ROLE_IMAGE_MAP 95/162195/1
Shinwoo Kim [Wed, 29 Nov 2017 12:14:19 +0000 (21:14 +0900)]
atspi: do not accept ELM_ATSPI_ROLE_IMAGE_MAP

There are two widgets using ELM_ATSPI_ROLE_IMAGE_MAP role.
One is elm_mapbuf which does not have to grab highlight.
It does not make sense because the elm_mapbuf only works for its content.
The other is elm_map. So far the elm_map does not have to grab highlight, and
it seems that the ELM_ATSPI_ROLE_IMAGE_MAP is improper role for elm_map.
We have to find proper role for elm_map when it is neccesary to grab highlight.
So this patch set would be reasonable.

Change-Id: I8fc82c8f278b12f1e6367f4e40bf6b37c44b1481

7 years agoelm_widget.c: Removed unnecessary attributes delete code, As attributes_clear API... 74/161074/2
Shilpa Singh [Tue, 21 Nov 2017 09:10:35 +0000 (14:40 +0530)]
elm_widget.c: Removed unnecessary attributes delete code, As attributes_clear API is already being called.

Change-Id: I3737086c02c2aaa9733789717af0763e64629188

7 years agoelm_index: Send selected signal to atspi client 67/160467/2
Shilpa Singh [Thu, 16 Nov 2017 08:28:10 +0000 (13:58 +0530)]
elm_index: Send selected signal to atspi client

Change-Id: I129b40861f4101fb10715fb89d38ef49945f4e42

7 years agoatspi: Use bottom up approach for PAGE_TAB 24/160424/1
Shinwoo Kim [Mon, 6 Nov 2017 12:04:13 +0000 (21:04 +0900)]
atspi: Use bottom up approach for PAGE_TAB

The naviframe item is elm_layout, and its atspi role is ELM_ATSPI_ROLE_PAGE_TAB.
The screen-reader could ask an object at point by using the naviframe item as a
root object. In this case, elementary did not us bottom up approach.
For the consistency, and to make it work better, This patch set is using the
bottom up approach for the naviframe item.

Change-Id: Icfe0791e340dac0c3998b56217fab8c34922cc5b

7 years agoatspi: use correct object for highlight_grabbing 98/158598/1
Shinwoo Kim [Tue, 31 Oct 2017 10:54:04 +0000 (19:54 +0900)]
atspi: use correct object for highlight_grabbing

elm_object_accessibility_highlight_set is using VIEW object as a "target"
object for the ELM_WIDGET_ITEM_CLASS object. And the "target" object is used
for all highlight related lines in the elm_win including highlight_grabbing.

So when the elm_widget sets highlight_grabbing for the ELM_WIDGET_ITEM_CLASS
object, the VIEW object should be used.

Change-Id: I6bd1e40e69883e81f968ea82a6a48be9204206d2

7 years agoatspi: fix name, description callback issue 18/156818/2
Shinwoo Kim [Fri, 20 Oct 2017 05:51:28 +0000 (14:51 +0900)]
atspi: fix name, description callback issue

The accessible name, description callback did not work for the naviframe item.
Because the naviframe item has used VIEW object for its accessible object.
If user calls elm_atspi_accessible_name_cb_set(naviframe_item, cb, data),
then the callback cb should set to VIEW object, not naviframe item, because
atspi_accessible_name_get is using the VIEW object.

Change-Id: I8b0d25d36b8e66a45a3757efa900ff9082d6fbf3

7 years agoatspi: fix translation domain for naviframe item 67/156767/2
Shinwoo Kim [Fri, 20 Oct 2017 01:12:19 +0000 (10:12 +0900)]
atspi: fix translation domain for naviframe item

The naviframe item have used its VIEW object for accessible name and
description. But the naviframe item did not care about the translation
domain. So there was a translation problem.

Change-Id: I3163f4b078a62c82686806f265487c9a3082abc9

7 years agoatspi : Do not send signal, if current object and highlight object are same 15/156815/4
JunsuChoi [Fri, 20 Oct 2017 05:28:18 +0000 (14:28 +0900)]
atspi : Do not send signal, if current object and highlight object are same

Change-Id: I56b3522a2e4c42dc2000c252a2a35fdad4788674

7 years ago[Accessibility]: Access frame going behind popup issue fix when popup is created... 06/156506/2
Shilpa Singh [Wed, 18 Oct 2017 13:31:04 +0000 (19:01 +0530)]
[Accessibility]: Access frame going behind popup issue fix when popup is created in transition,finished callback.

Change-Id: I4e4bdf9c7ce6bd9528311319119c5f8c9e287d17

7 years agoatspi: not use destructed eo object 85/155785/1 accepted/tizen_3.0_common accepted/tizen_3.0_mobile accepted/tizen_3.0_tv accepted/tizen_3.0_wearable accepted/tizen/3.0/common/20171026.152903 accepted/tizen/3.0/mobile/20171026.010137 accepted/tizen/3.0/tv/20171026.010214 accepted/tizen/3.0/wearable/20171026.010238 submit/tizen_3.0/20171019.130042
Shinwoo Kim [Mon, 16 Oct 2017 06:58:56 +0000 (15:58 +0900)]
atspi: not use destructed eo object

It is possible to access destructed eo object using ATSPI interface.
The following sequence is possilbe, because AT-client such as screen-reader
does not know whether a widget object deleted or not.

1. _elm_radio_evas_object_smart_del
2. _elm_radio_elm_interface_atspi_accessible_state_set_get

So before using eo interface, we have to check if the eo object is vlid or
not using eo_destructed_is.

Change-Id: I7ffaf7bd905dcc2ef5770d9c1cef9de52ec77322

7 years agoatspi : Do not center align when genlist item is highlighted in wearable profile 58/154658/7
JunsuChoi [Wed, 11 Oct 2017 03:21:55 +0000 (12:21 +0900)]
atspi : Do not center align when genlist item is highlighted in wearable profile

Change-Id: Ia727191474485e89aac55a654db9a0dffc3aec54

7 years agoatspi : During the highlight grab, out signal is not sent. 54/154654/3
JunsuChoi [Wed, 11 Oct 2017 03:12:45 +0000 (12:12 +0900)]
atspi : During the highlight grab, out signal is not sent.

   There is an action that takes time to complete
   the highlight grab, such as scroll bring in.
   So the highlight box can be outside the screen.
   After the highlight grab process is completed,
   will check the highlight box status.

Change-Id: I539e17f9685d9d7540ffd95b987e809161a0480f

7 years agoatspi : Change default label append of popup from show_finish_cb to on_show 40/155340/2
JunsuChoi [Fri, 13 Oct 2017 03:13:31 +0000 (12:13 +0900)]
atspi : Change default label append of popup from show_finish_cb to on_show

   show_finish_cb is called after animation of popup has finished.
   default label time limit for screen-readers is 0.3 seconds.
   Default label does not work if animation does not finish in 0.3 seconds
   So change it so that it can be processed by smart show.

Change-Id: Ib2e41e223634a728f4953e60dec3967ff251bc7a

7 years agoatspi: set elm_access layer to MAX 63/153663/2
Shinwoo Kim [Fri, 29 Sep 2017 05:28:21 +0000 (14:28 +0900)]
atspi: set elm_access layer to MAX

Set access object layer to max, because the highlight frame could be covered
by other object which has higher layer.

Change-Id: I16e54469f0c749fb2caab6da9ea68b8dc97d9b02

7 years agoelementary: atspi - fix dbus abort 64/153464/4
Shinwoo Kim [Thu, 28 Sep 2017 11:45:07 +0000 (20:45 +0900)]
elementary: atspi - fix dbus abort

This patch set fix following abort occured on dbus side.

(gdb) bt
0   __GI_raise (sig=sig@entry=6)
1   __GI_abort ()
2   _dbus_abort ()
3   _dbus_warn_check_failed
4   dbus_message_iter_append_basic
5   append_basic
6   eldbus_message_iter_basic_append
7   _bridge_signal_send
8   _text_text_removed_send
9   _bridge_accessible_event_dispatch
10  _elm_interface_atspi_accessible_event_emit
11  elm_interface_atspi_accessible_event_emit
12  _entry_changed_user_signal_cb

(gdb) f 12
(gdb) p *$1
$2 = {change = {insert = {content = 0x0, pos = 0, plain_length = 1},
                del = {content = 0x0, start = 0, end = 1}},
      insert = 0 '\000', merge = 0 '\000'}

The following patch set would fix the root cause of this problem.
https://phab.enlightenment.org/D5240

Change-Id: I00d36b818749693194a69c10bd80353e47796238

7 years agoatspi: Improves how to find the can_highlight of the widget. 80/153780/3
JunsuChoi [Fri, 29 Sep 2017 11:55:32 +0000 (20:55 +0900)]
atspi: Improves how to find the can_highlight of the widget.

   Returns EINA_FALSE if any of parents is EINA_FALSE
   when determining can_highlight.
   To determine can_highlight for the parent of an object,
   we try to find the parent of the parent again.
   As it repeats, it traverses as much as depth size factorial (d!)
   However, if any of the parent of the object has can_highlight of the widget data is EINA_FALSE,
   it is eventually EINA_FALSE

Change-Id: I3c7102ad12fe04488a1604e306f0699f1cb14691

7 years agoRevert "atspi: Improves how to find the can_highlight of the widget." 73/153773/1
JunsuChoi [Fri, 29 Sep 2017 11:43:01 +0000 (20:43 +0900)]
Revert "atspi: Improves how to find the can_highlight of the widget."

This reverts commit a527c41d22ac4144a9834385441b9657831b8dd3.

Change-Id: Ic6f95f41a74f3fe07ebb3e210317a2e8f1cf75fe

7 years agoatspi: Improves how to find the can_highlight of the widget. 52/153752/2
JunsuChoi [Fri, 29 Sep 2017 09:11:36 +0000 (18:11 +0900)]
atspi: Improves how to find the can_highlight of the widget.

   Returns EINA_FALSE if any of parents is EINA_FALSE
   when determining can_highlight.
   To determine can_highlight for the parent of an object,
   we try to find the parent of the parent again.
   As it repeats, it traverses as much as depth size factorial (d!)
   However, if any of the parent of the object has can_highlight of the widget data is EINA_FALSE,
   it is eventually EINA_FALSE

Change-Id: I82faab2e974801039c4c7c7d003f68314f7c9d4c

7 years agoatspi : Remove role check when getting an accessible object to a point. 35/153635/1
JunsuChoi [Fri, 29 Sep 2017 04:10:39 +0000 (13:10 +0900)]
atspi : Remove role check when getting an accessible object to a point.

Change-Id: Ib0165ec6f31e0e9e5942fe224696485b9ad0c5aa

7 years agoelm_need_efret() - improve error handling according to coverity 72/153272/1
Hosang Kim [Thu, 28 Sep 2017 07:05:21 +0000 (16:05 +0900)]
elm_need_efret() - improve error handling according to coverity

fix CID 1360466, CID 1353589

we don't actually chekc if efreet inits right with elm_need_efreet()
as we just assume it inits (And there pretty much is no case where it
will not), but make coverity happy and check.

@fix
Change-Id: Ieb37ab35a6ebc3a7e30b9fd5be6bb0e5b06aa64f

7 years agoelm dbus menu - handle return value of eldbus_message_iter_arguments_get 52/153252/1
Hosang Kim [Thu, 28 Sep 2017 06:40:44 +0000 (15:40 +0900)]
elm dbus menu - handle return value of eldbus_message_iter_arguments_get

handle possible error return of eldbus_message_iter_arguments_get()
according to coverity CID 1353591. this should fix that.

Change-Id: I213f644c6450e550f5a26fd9a0c11a707d71f94a

7 years agoadd color for build message(error:red, warning:ylw) 45/152245/2
JunsuChoi [Mon, 25 Sep 2017 10:28:02 +0000 (19:28 +0900)]
add color for build message(error:red, warning:ylw)

Change-Id: I96ee17c396cb743b880da74722a841324599df82

7 years agoatspi: use detail value of window activated signal 11/152311/3
Shinwoo Kim [Mon, 25 Sep 2017 13:57:02 +0000 (22:57 +0900)]
atspi: use detail value of window activated signal

The detail value of window activated signal is using for following cases

(1) support "default_label" attribute of window
(2) notify existing keyboard window.
The keyboard window would exist always, once it shows.
So if screen-reader turns off, and turn on again, there was no ATSPI signal.
We are using 'activate' signal for this case to get the reference of
keyboard window. And we are using detail value to reduce a call of IPC.

Change-Id: I11db347b89f283ad2ab7fd5378ca123948dbbaf5

7 years agoatspi: win overrides atspi component get interface 12/152012/3
Shinwoo Kim [Sat, 23 Sep 2017 13:34:52 +0000 (22:34 +0900)]
atspi: win overrides atspi component get interface

(1) The efl_ui_win overrides _elm_interface_atspi_component_extents_get to give
correct value if screen_coord is EINA_FALSE which means relative position.
The efl_ui_win has given its object geometry value + ecore evas geometry value.
The object geometry value was equal to the ecore evas geometry value, so the
relative position was not correct(twice of ecore evas geometry value).

(2) Allow ELM_ROLE_INPUT_METHOD_WINDOW to send signal

Change-Id: I1b6832e960b3123d2a817d6253313447bc31af08

7 years agoatspi: make datetime itself unacceptable object 75/152875/1
Shinwoo Kim [Wed, 27 Sep 2017 09:30:06 +0000 (18:30 +0900)]
atspi: make datetime itself unacceptable object

This depends on UI definition. The datetime itself does not have highlight.
Only each part objects such as inc/dec button, year, month, and day in it.

Change-Id: I6a14dec2a24ee280ad19fa885acec0992acc9400

7 years agoatspi: block event which is not interested in 08/152008/2
Shinwoo Kim [Sat, 23 Sep 2017 08:42:55 +0000 (17:42 +0900)]
atspi: block event which is not interested in

The following ATSPI dbus signal is not interested in.
Moreover the following ATSPI dbus signal occurs a lot at init time.
This could cause a performance issue.

 - 'ChildrenChanged' with added child
 - 'ChildrenChanged' with deleted child
 - 'AddAccessible'
 - 'RemoveAccessible'

Change-Id: Iebfb4ef75b5f32bf025e275dd9b548bd3581b2de

7 years agoelm image: Fix async open to avoid multiple mmap 40/151540/2
jiin.moon [Wed, 20 Sep 2017 10:18:07 +0000 (19:18 +0900)]
elm image: Fix async open to avoid multiple mmap

 From cb3b4cc8d7794bea575a85325c8a58f25f0507b2 Mon Sep 17 00:00:00 2001
 From: Jean-Philippe Andre <jp.andre@samsung.com>
 Date: Fri, 15 Sep 2017 14:39:14 +0900
 Subject: [PATCH] elm image: Fix async open to avoid multiple mmap

 Reported by @jiin.moon:

 In case of async_open for an elm_image, we try and open a file in a
 thread, then map it and populate a bit, as this may take some time
 (blocking I/O). This creates a mmap with eina_file_map_new. But later
 evas image loaders will (usually) try and map the entire file with
 eina_file_map_all() which creates another mmap. Since the size is
 different (32Kb first then all) the returned map might be different
 (it's up to the kernel to decide at this point).

 So, in order to avoid having multiple maps on the same file, and try to
 reduce the peak memory usage, we should prefer using the same map all
 the time, i.e. the global one returned by eina_file_map_all().

 This patch relies on the previous patch in eina_file which fixes
 eina_file_map_populate() for the global map.

 @fix

Change-Id: If27d42b89269493ac2425737198338689687459d

7 years agonaviframe: Fix to finish transition for newly pushed item 07/152407/2
Jaehyun Cho [Wed, 6 Sep 2017 11:04:41 +0000 (20:04 +0900)]
naviframe: Fix to finish transition for newly pushed item

Suppose naviframe top item is "A" and a new item "B" is newly pushed.
In this case, if "A" is deleted by elm_object_item_del() before
transition for "B" is started, then signal for "B" is also not sent and
"B" does not become visible.

The above issue happened if the transition effect was implemented by
using deferred signals (i.e. "pushed,deferred" and "popped,deferred").

To resolve the above issue, the signal only for the deleted item is not
sent.

Suppose naviframe top item is "A" and a new item "B" is newly pushed.
In this case, if "B" is deleted by elm_object_item_del() before
transition for "B" is started, then signal for "A" is still sent and "A"
becomes invisible.

To resolve the above issue, if the deleted item is the top item and it
is in the middle of item push, then all the signals related to the
deleted item are not sent.

Change-Id: I33c9f5039a8d3a3e5c60259a14edae395503ddd8

7 years agoatspi: fix infinite loop issue 43/151143/2
Shinwoo Kim [Wed, 20 Sep 2017 04:14:27 +0000 (13:14 +0900)]
atspi: fix infinite loop issue

It is possilbe to get a target object as a return value of get_object_at_point.
In this case _elm_widget_elm_interface_atspi_component_accessible_at_point_get
works again with the target which is same with root object.

[Enhanced]
- We do not have to go parent if the bottom up logic meets root object.
- Visiblity of panel is always true. So we are checking its SHOWING state.
  If the panel is not SHOWING, remove it from valid children list.

Change-Id: I2edeefdc9a0c5955f1c28926321b74424c71bc40

7 years agoatspi: support "default_label" attribute of window 29/151629/2
Shinwoo Kim [Thu, 21 Sep 2017 07:40:49 +0000 (16:40 +0900)]
atspi: support "default_label" attribute of window

Wearable profile application does not want to use default label functionality
because it is hard to meet application UI definition.
So if the window has attribute "default_label" key, and its "disabled" value,
then screen-reader does not read out default label, and does not clear
currently highlight object.

Application should append attribute as below.

elm_atspi_accessible_attribute_append(window, "default_label", "disabled");

This patch set works with following patch set.

https://review.tizen.org/gerrit/151570 (screen-reader)

Change-Id: I354c6ecf30db3a0011658d69577ad384fcb900db

7 years agoatspi: Handle default label object on toolkit side 65/151065/2
Shinwoo Kim [Tue, 19 Sep 2017 11:28:12 +0000 (20:28 +0900)]
atspi: Handle default label object on toolkit side

There are unexpected difficult cases to make default label work correctly.
The following would be the case.

(top of accessible tree) - (bottom side)
PageTab1 - Panel1 - PageTab2 - Panel2  -  PageTab3 - Panel3(currently showing)

Application could make as below:
PageTab1 - Panel1 - PageTab3 - Panel3  -  PageTab2 - Panel2(currently showing)

or following tree would normally be possilbe:
PageTab1 - Panel1 - PageTab2 - Panel2(currently showing)

There are much of complicated case over there.
So we are handling the default label object stack on toolkit(Elementary) side.

Please refer to following patch set:
https://review.tizen.org/gerrit/#/c/151025/ (at-spi2-core)
https://review.tizen.org/gerrit/#/c/151030/ (screen-reader)

Change-Id: I0834f9d0625f4e787d6315ce4858bdec4a67ab18

7 years agoFix build error 45/151045/1
Shinwoo Kim [Tue, 19 Sep 2017 12:01:52 +0000 (21:01 +0900)]
Fix build error

Change-Id: Ia48d74c62ea87f056e01eac83edb6f4eb20ce5d3

7 years agoatspi: enhance line related to highlight frame 90/150490/2
Shinwoo Kim [Sat, 16 Sep 2017 08:09:33 +0000 (17:09 +0900)]
atspi: enhance line related to highlight frame

1. Before elm_widget_theme_object_set for a11y highlight frame was called in
 _elm_win_accessibility_highlight_show which is called in highlighted object
 move, resize callback.

2. Before evas_object_smart_changed was not called even though a11y highlight
 frame is added as a smart member of highlighted object.

※ Refer to commit: c3b5da9 (atspi: make highlight frame be a smart member)

Change-Id: I1f5dc367d2fc5565d61ae12d44fb1e8a49eeb979

7 years agoatspi: clear current highlighted object 02/150402/1
Shinwoo Kim [Fri, 15 Sep 2017 10:14:19 +0000 (19:14 +0900)]
atspi: clear current highlighted object

The _elm_win_screen_reader does not clear current highlighted object when the
screen reader is disabled. It tried to clear window highlight even though the
window does not have highlight.

Change-Id: Icc5de54361852c0210c0640f2801483f6a2c6468

7 years agoatspi: enhance _accessible_at_point_get 05/149905/1
Shinwoo Kim [Wed, 13 Sep 2017 12:34:44 +0000 (21:34 +0900)]
atspi: enhance _accessible_at_point_get

The _elm_widget_elm_interface_atspi_component_accessible_at_point_get is
seaching accessible object from bottom of tree.

If elm_popup, or elm_panel comes as a root object, then
the _elm_widget_elm_interface_atspi_component_accessible_at_point_get does not
search from bottom of tree.

To make seach logic consistent, we are using bottom-up approach first for both
elm_popup and elm_panel from this patch.

Change-Id: I2a31725e8ff69455b836d6f888e0b42695ad2af5

7 years agoatspi : Add check for chain end object with attribute 21/149721/1
JunsuChoi [Wed, 13 Sep 2017 03:04:42 +0000 (12:04 +0900)]
atspi : Add check for chain end object with attribute

   When searching for a neighbor object,
   check whether there is an "relation_chain_end" attribute.
   If it does, it returns the current object.

Change-Id: Ib6b21e833f35070ca10f7c863eff66482cbe4af0

7 years agoatspi: enhance _accessible_at_point_top_down_get 27/149327/1
Shinwoo Kim [Tue, 12 Sep 2017 05:44:39 +0000 (14:44 +0900)]
atspi: enhance _accessible_at_point_top_down_get

If there is only one valid child at point, then return it.
The evas_tree_objects_at_xy_get could not find proper object,
if application does not have well aligned objects.

This could be a role of application, but this patch set could solve somehow.

Change-Id: I6326a23b88904f6003a99e8b17885452890c7222

7 years agoatspi: enhance po file to translate "Alert" 82/148882/2
Shinwoo Kim [Mon, 11 Sep 2017 05:33:41 +0000 (14:33 +0900)]
atspi: enhance po file to translate "Alert"

There was no information to translate "Alert".

Change-Id: I339548b707d2d34df77dcc36774d0a4665854e63

7 years agoatspi: follow edje_entry logic to send anchor name 75/148875/2
Shinwoo Kim [Mon, 11 Sep 2017 05:29:46 +0000 (14:29 +0900)]
atspi: follow edje_entry logic to send anchor name

The edje_entry has logic remove unnecessary character.
The elm_entry is following the logic to give correct information.

Change-Id: I55114193d9b23117ddc8b9863c2b14741f42a215

7 years agoatspi : Fix "bring_in" of the genlist item in wearable profile 68/148668/2
JunsuChoi [Fri, 8 Sep 2017 08:51:15 +0000 (17:51 +0900)]
atspi : Fix "bring_in" of the genlist item in wearable profile

Change-Id: I31499becfd6b292df919f7aebf3647dd9d44bde2

7 years agoatspi: emit signal after atspi bridge is connected 69/148769/1
Shinwoo Kim [Sun, 10 Sep 2017 00:50:21 +0000 (09:50 +0900)]
atspi: emit signal after atspi bridge is connected

This patch set emitting popup SHOWING signal, and window ACTIVE signal after
the atspi bridge is connectted.

The SHOWING signal of popup does not work properly, if the popup shows before
the atspi bridge is not connected. In this case, the screen-reader cannot read
popup information. So the SHOWING signal should be emitted after the connection
is established.

The ACTIVE signal does not work properly in the following case.
There are two windows show in one process at the same time. In this case,
the ACTIVE signal was not emitted because window_activated_broadcast_needed is
set to EINA_FALSE. This would be a bug.

Change-Id: Ieb1883c94c2570fdb92b9770a1c20e7d95c27a60

7 years agoatspi: remove unacceptable leaf node 11/148711/1
Shinwoo Kim [Fri, 8 Sep 2017 07:46:32 +0000 (16:46 +0900)]
atspi: remove unacceptable leaf node

An object could have children which have same position.
In this case, if first child of this object is not acceptable leaf node, then
there is no chance to find second child object.

Change-Id: If6887dc04bce4590ab4123cb79914172b5a4ca48

7 years agoelm_color_class: add missing return value 22/148622/1
Jaeun Choi [Fri, 8 Sep 2017 07:15:41 +0000 (16:15 +0900)]
elm_color_class: add missing return value

Change-Id: Id86fdceec488e5cf1b9263690faadce543155abb

7 years agoatspi: remove memory leak 55/148055/2
Shinwoo Kim [Wed, 6 Sep 2017 11:09:26 +0000 (20:09 +0900)]
atspi: remove memory leak

The _elm_util_mkup_to_text gives alloacated plain text.
This plain text should be freed.

Change-Id: I4fe6443a2be78a80b00e79925b9ac968e489df76

7 years agoatspi: use entry text and parent accessible name 83/147783/2
Shinwoo Kim [Tue, 5 Sep 2017 13:42:50 +0000 (22:42 +0900)]
atspi: use entry text and parent accessible name

(1) The entry is using entry text for its accessible name.
(2) It is possible to overwrite default accessible name of entry by using
parent accessible name.

Change-Id: I29cdfe0fd6c517d9611ad46996eebe40c7be27e9

7 years agoatspi: find valid child of list item 66/147766/3
Shinwoo Kim [Tue, 5 Sep 2017 11:53:29 +0000 (20:53 +0900)]
atspi: find valid child of list item

This patch set is solving following case.
If genlist item uses evas_object_image_source_set to show item itself, then
evas_tree_objects_at_xy_get does not return below objects of image source.
So content objects of genlist item could not become cadicdates for
elm_interface_atspi_component_accessible_at_point_get.

@tizen_fix

Change-Id: I44e52b48054cf80fd102131c7f199a6b62a0464d

7 years agoatspi: use elm_entry to call smart callback 63/147563/3
Shinwoo Kim [Tue, 5 Sep 2017 02:13:28 +0000 (11:13 +0900)]
atspi: use elm_entry to call smart callback

This patch set is using elm_entry to call "anchor,clicked" smart callback.
The elm_access for anchor has been used so far, so the "anchor,clicked" smart
callback did not work.

Change-Id: If09400e78a9fc488e307fd46e67b39bf6beeca19

7 years agointerface_scrollable: modify not to compensate scroller if manual_render is set 78/147878/2
Wonki Kim [Wed, 6 Sep 2017 03:02:19 +0000 (12:02 +0900)]
interface_scrollable: modify not to compensate scroller if manual_render is set

when scroller is not stable such as a situation of resizing, page_show api work improperly
so that there was compensate logic to fix that issue.

however, when manual render mode is set, the logic work improperly.
this patch disable compensate logic if manual_render is set

@tizen_fix

Change-Id: Ibd06a13565d181145869ee076f91e574abba7772
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
7 years agoatspi: Fix build fail by using wrong variables 92/147892/1
JunsuChoi [Wed, 6 Sep 2017 03:22:32 +0000 (12:22 +0900)]
atspi: Fix build fail by using wrong variables

Change-Id: I717abf2816ebc59dcd340b838308542ea33d7a5f

7 years ago[atspi][panel] Adds accessibility support for the panel widget. 47/147647/3
JunsuChoi [Wed, 9 Aug 2017 07:41:47 +0000 (16:41 +0900)]
[atspi][panel] Adds accessibility support for the panel widget.

   Panel handles similar popups.
   When open or close it sends signal to screen-reader.

Change-Id: Ie0d8e122810e2de23f14321d0211be7b0efd8cad

7 years agoelm_panel: set content as a sub object of panel object 59/147659/1
Jaeun Choi [Tue, 5 Sep 2017 07:14:37 +0000 (16:14 +0900)]
elm_panel: set content as a sub object of panel object

since sd->bx is not an elm object, it is excluded from parent-child tree.
in case of a non-scrollable panel, the content needs to be attached to the tree
as a child of panel object directly.

Change-Id: I32b65fc2e2b213e510c3060ac877a4361653191a
origin: upstream (61381f6e3584118a70565eea79c355dd049b9e28)

7 years ago[ATSPI] Add to find genlist item using proxy image 73/147473/2
JunsuChoi [Thu, 31 Aug 2017 05:56:37 +0000 (14:56 +0900)]
[ATSPI] Add to find genlist item using proxy image

   In a wearable profile, genlist displays the item using a proxy image.
   When a screen-reader finds an object in the top_down, it can not find the item.
   because, found item is proxy image.
   So, using evas_object_image_source_get and gets item view object from proxy image.

Change-Id: I8fde784c71a7ec72add3996db006ba8ff059db66

7 years agoatspi: make highlight frame be a smart member 67/147167/2
Shinwoo Kim [Fri, 1 Sep 2017 07:35:55 +0000 (16:35 +0900)]
atspi: make highlight frame be a smart member

Make highlight frame object be a smart member of target object.
There are two cases covered by this commit.

1. ctxpopup of copy & paste module.
The ctxpopup item has higher object layer than highlight frame object.
In this case, the highlight frame is covered by the ctxpopup item.

2. genlist item proxy object.
The genlist item shows its proxy object(handled by evas_object_image_source*).
In this case, the highlight frame has improper position, and size.

Change-Id: I2b6470a8a695ea3739ddf80832e837dbd2c0d1f8

7 years agodocs: fix wrong descrpition in elm_progressbar API reference doxygen. 85/145385/1 accepted/tizen_3.0_ivi accepted/tizen/3.0/common/20170828.112436 accepted/tizen/3.0/ivi/20170826.020737 accepted/tizen/3.0/mobile/20170826.020706 accepted/tizen/3.0/wearable/20170826.020722 submit/tizen_3.0/20170825.055425
Bowon Ryu [Tue, 22 Aug 2017 07:13:16 +0000 (16:13 +0900)]
docs: fix wrong descrpition in elm_progressbar API reference doxygen.

unit format default is NULL in Tizen.
so delete the description.

Change-Id: Ie308f428f69a5432e64092e6f7c9f8b22d154495
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
7 years agoDatetime: Prevent null pointer reference. 69/144869/1
Woochan Lee [Fri, 18 Aug 2017 07:02:49 +0000 (16:02 +0900)]
Datetime: Prevent null pointer reference.

When _elm_datetime_items_get() calling with only time format after datetime creation.
The location has been swapped. so some of sorted_field index address gets a invalid
address. then it makes a crash.

@tizen_fix

Change-Id: I8e073237793d6af46a726be6cd51827f14c15661

7 years agoadd @endif tag for elm_win_window_id_get documentation 13/144813/2
Taehyub Kim [Fri, 18 Aug 2017 05:21:33 +0000 (14:21 +0900)]
add @endif tag for elm_win_window_id_get documentation

Change-Id: Iaf28c7250a457f12ff3fe58a9cc0ca694e6ad22b

7 years agomake elm_win_window_get API public 92/144792/2
Taehyub Kim [Fri, 18 Aug 2017 03:17:01 +0000 (12:17 +0900)]
make elm_win_window_get API public

Change-Id: Ie051cc269d79294eb693804aed6765844b1403ab

7 years agogenlist: process item block positioning before relative item deleted 96/144596/1
SangHyeon Jade Lee [Thu, 17 Aug 2017 06:14:46 +0000 (15:14 +0900)]
genlist: process item block positioning before relative item deleted

Change-Id: Iac552c946bd37e0abf551c1c74a6a08a3c6a5acc
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
7 years agoglview: fix a condition that is identical to previous 30/144230/2
Daekwang Ryu [Wed, 16 Aug 2017 02:47:23 +0000 (11:47 +0900)]
glview: fix a condition that is identical to previous

Change-Id: Ib41f90c406d83ce10851441280e3c2652e701ea4

7 years agoelm_conform: Prevent infinite trial of connection to the indicator 73/144473/4
Wonki Kim [Thu, 17 Aug 2017 01:49:40 +0000 (10:49 +0900)]
elm_conform: Prevent infinite trial of connection to the indicator

Even if there isn't a indicator at all,
the conformant tries to connect to the indicator server INFINITELY.
Therefore that makes wasting of computing power.

This patch prevents the trials to save computing power.

@tizen_fix

Change-Id: I2ec5034bae969f13f49babbf3900aaa74390a471
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
7 years agoFix 'scrollto animator' reaching destination 00/144400/2
Wonki Kim [Wed, 16 Aug 2017 11:52:26 +0000 (20:52 +0900)]
Fix 'scrollto animator' reaching destination

Scrollto animator could never reach destination if animator is generated
while animator is running because animation duration is fixed.

This patch reduces animation duration on the above situation.

@tizen_fix

Change-Id: Id4b3588814c038750e40edefb18a46607db694ec
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
7 years agoelc_naviframe: set focus to new view immediately only for item push 62/143762/1 accepted/tizen/3.0/common/20170816.145158 accepted/tizen/3.0/ivi/20170816.131253 accepted/tizen/3.0/mobile/20170816.131228 accepted/tizen/3.0/tv/20170816.131138 accepted/tizen/3.0/wearable/20170816.131152 submit/tizen_3.0/20170816.054926
Jaehyun Cho [Fri, 11 Aug 2017 07:06:48 +0000 (16:06 +0900)]
elc_naviframe: set focus to new view immediately only for item push

Set focus to new item view immediately when new item is pushed to show
keypad fast. Otherwise, focus of new item view is set late and keypad is
shown late.

Setting focus to item view immediately is applied to item push only.
Because if this concept is applied to item pop, then the following focus
issue happens.

Reproduction path of the item pop focus issue
1. Naviframe first item view consists of two objects.
   Focus is in the second object of the first item view.
2. Naviframe push happens. (now two item views)
3. Popup appears and it gets the focus.
4. Popup button click pops the second naviframe item.
5. Focus goes to the naviframe and focus_next happens.
6. Focus is set to the first object of the first item view.
   (not to the second object of the first item view)

Change-Id: I1940831dbd9ce0cf8efcd6b2172203fa1ee277fc

7 years agoCast to double before division during region/coord calculation. 85/143685/2
Sungtaek Hong [Fri, 11 Aug 2017 02:59:34 +0000 (11:59 +0900)]
Cast to double before division during region/coord calculation.

int var devided by int is cast to double after devision.
This might cause wrong calculation result.

Change-Id: I32128f81cbfa78b1e42b3c03fa18e664e31732ef
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
7 years agoRevert "interface_scrollable: Fix not hold the flag on mouse down" 16/143716/1
Wonki Kim [Fri, 11 Aug 2017 05:15:41 +0000 (14:15 +0900)]
Revert "interface_scrollable: Fix not hold the flag on mouse down"

This reverts commit 440af9fe33efbdeae3087d7cf343603fcd814438.

Change-Id: Ibe1a3c190d60dcd5324c4c8c8c477f95dc8e5a80
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
7 years agotest_gesture_layer3: fix typo 23/143023/2
Jaeun Choi [Tue, 8 Aug 2017 07:48:58 +0000 (16:48 +0900)]
test_gesture_layer3: fix typo

this typo was detected by SVACE

Change-Id: I3e32a058a0ddf7f4f22bac1106dc05698ff185a6
origin: upstream (52368bf463c2b5ea7b69e15a7e34b1ea13258ca1)

7 years agotest_gesture_layer: fix typo 98/142998/2
Jaeun Choi [Tue, 8 Aug 2017 06:43:15 +0000 (15:43 +0900)]
test_gesture_layer: fix typo

this typo was detected by SVACE

Change-Id: I6b005aede302598dfe1f4af7fb38199dc4371b12
origin: upstream (a9fdcc4cc2f5567fbc05ae418c4e3a4d13286f45)

7 years agoelm_color_class: add null checking after memory allocation 41/143241/2
Jaeun Choi [Wed, 9 Aug 2017 07:16:35 +0000 (16:16 +0900)]
elm_color_class: add null checking after memory allocation

origin: upstream (15bbf4712ee1e9356fa975de6f2861bc5ce3076a)

Change-Id: Id9b82282635f8b722f6d282f3d0e84ee98aafdb0

7 years agoelm_dbus_menu: add null checking after memory allocation 43/143243/2
Jaeun Choi [Wed, 9 Aug 2017 07:21:03 +0000 (16:21 +0900)]
elm_dbus_menu: add null checking after memory allocation

Change-Id: I43d0a47eb8d382007b6a9ed1d877415ad37ed52d
origin: upstream (0927221c1a0e26b7fe006eb3110ca2bffd671b89)

7 years agoelm_gesture_layer: add null checking after memory allocation 48/143248/2
Jaeun Choi [Wed, 9 Aug 2017 07:28:42 +0000 (16:28 +0900)]
elm_gesture_layer: add null checking after memory allocation

Change-Id: Ib504732e21203c414bb1e58936788e84da23cba9
origin: upstream (41ea255002d93d285da331e2452488c8f6088f1f)

7 years agoelm_gesture_layer_extra_gestures: add null checking after memory allocation 54/143254/2
Jaeun Choi [Wed, 9 Aug 2017 07:32:36 +0000 (16:32 +0900)]
elm_gesture_layer_extra_gestures: add null checking after memory allocation

Change-Id: Ifc32e16b0489685d154b35c2d3f7a4cd71409e14
origin: upstream (db33efb79238f5843251795ff193773bd36c83b1)

7 years agoelm_prefs_data: add null checking after memory allocation 57/143257/2
Jaeun Choi [Wed, 9 Aug 2017 07:36:13 +0000 (16:36 +0900)]
elm_prefs_data: add null checking after memory allocation

Change-Id: Ia14b6585a030fe598a9e09dc16ddc27dd1d789df
origin: upstream (38abae53c0a5aca320984475c82fc6f6f5ae048b)

7 years agotest_gesture_layer: add null checking after memory allocation 59/143259/2
Jaeun Choi [Wed, 9 Aug 2017 07:39:54 +0000 (16:39 +0900)]
test_gesture_layer: add null checking after memory allocation

Change-Id: Id45ecd0d3ebc4d49cab51f36f319feb813d2d828
origin: upstream (6641c07262085faf062679a21659ff7b45b05a67)

7 years agotest_gesture_layer2: add null checking after memory allocation 62/143262/2
Jaeun Choi [Wed, 9 Aug 2017 07:43:27 +0000 (16:43 +0900)]
test_gesture_layer2: add null checking after memory allocation

Change-Id: Ic733f8e173d1a0ca4c90479961b05fb27f8b3b4b
origin: upstream (530455fcee4767ce17ba56200b13dc688b64857a)

7 years agotest_gesture_layer3: add null checking after memory allocation 77/143277/2
Jaeun Choi [Wed, 9 Aug 2017 07:49:15 +0000 (16:49 +0900)]
test_gesture_layer3: add null checking after memory allocation

Change-Id: I0d189511e9c65496d23a7799631f37513f16c690
origin: upstream (c311dc638b8358f27664fba3985d9212748cf92a)

7 years agotizen_vector: Fixed the integer division issue. 45/143645/1
smohanty [Fri, 11 Aug 2017 00:14:08 +0000 (09:14 +0900)]
tizen_vector: Fixed the integer division issue.

Change-Id: Ib17b7a440cdc5807059774ddd0031e17b42be400

7 years agogenlist : fix re-calculate on language changed 13/143513/2
SangHyeon Jade Lee [Thu, 10 Aug 2017 07:37:04 +0000 (16:37 +0900)]
genlist : fix re-calculate on language changed

Change-Id: I3a599c45228e652624d38fa8f73db45de084c35e
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
7 years agoelc_naviframe: Use tizen_effect_cancel from naviframe_effect module 69/143469/1
Jaehyun Cho [Wed, 9 Aug 2017 13:37:26 +0000 (22:37 +0900)]
elc_naviframe: Use tizen_effect_cancel from naviframe_effect module

Use tizen_effect_cancel API from naviframe_effect module to cancel push
effect when a newly pushed item is deleted before the push effect is
started.

Change-Id: Ia3d89bda1b4f128a80c1cf78e3ac33e34c564dc2

7 years agoelc_naviframe: Fix to handle item deletion right after item push 68/143468/1
Jaehyun Cho [Wed, 9 Aug 2017 14:32:35 +0000 (23:32 +0900)]
elc_naviframe: Fix to handle item deletion right after item push

If an item is deleted right after the item is newly pushed, the push
transition should not happen for both the new item and the current item.

Change-Id: Iba5b9547aae8b3916e76d9e7af3e9250229c563b

7 years agogengrid: fix wrong access info returns in access info set 89/142989/2 accepted/tizen/3.0/common/20170810.121236 accepted/tizen/3.0/ivi/20170810.094018 accepted/tizen/3.0/mobile/20170810.094107 accepted/tizen/3.0/tv/20170810.094001 accepted/tizen/3.0/wearable/20170810.093938 submit/tizen_3.0/20170810.044042
SangHyeon Jade Lee [Wed, 2 Aug 2017 10:31:10 +0000 (19:31 +0900)]
gengrid: fix wrong access info returns in access info set

Change-Id: I66478fee1468c1f57cddbf7ba9fd8c98344de161
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
7 years agogengrid: fix integer division type casting warning 88/142988/1
SangHyeon Jade Lee [Wed, 2 Aug 2017 10:50:20 +0000 (19:50 +0900)]
gengrid: fix integer division type casting warning

Change-Id: I1c7db5310a4edb16f4fda13e2ce19c71e8389741
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
7 years agoAdd null check for svace issues 40/142940/1
JunsuChoi [Tue, 8 Aug 2017 01:17:39 +0000 (10:17 +0900)]
Add null check for svace issues

   Add null check because alloc function could return null

Change-Id: Ife8a3cc2cf48ba176e7e94c50c7d78bb2329fc6b

7 years agoRevert "Fix Svace issuese." 75/142875/2
woochan lee [Mon, 7 Aug 2017 11:29:03 +0000 (11:29 +0000)]
Revert "Fix Svace issuese."

This reverts commit 621f22ab071e439c69907b4c818d2cbacf5b845b.

Change-Id: Ib856a08d49734e68704e02a61729dff8bc2338b4

7 years agoRevert "Fix Svace issue." 73/142873/1
woochan lee [Mon, 7 Aug 2017 11:28:48 +0000 (11:28 +0000)]
Revert "Fix Svace issue."

This reverts commit 7883b1a651b9417e68df248ace56ce9fdab77a9a.

Change-Id: I894925b109b1834a907caa8aa256be560dd2f1ac

7 years agoFix Svace issue. 17/142817/2
Woochan Lee [Mon, 7 Aug 2017 08:31:04 +0000 (17:31 +0900)]
Fix Svace issue.

Change-Id: I5559eabddbb9bb3034ba9eea8fec1aadb2f6d3d8

7 years agoFix Svace issuese. 74/142774/1
Woochan Lee [Mon, 7 Aug 2017 08:07:00 +0000 (17:07 +0900)]
Fix Svace issuese.

Change-Id: I9a2f66edbe51908735315fbf859dc1a0d7641252

7 years agoDatetime: Apply UI Mirroring for Tizen 3.0 62/142762/2
Woochan Lee [Mon, 7 Aug 2017 07:42:35 +0000 (16:42 +0900)]
Datetime: Apply UI Mirroring for Tizen 3.0

The datetime is not including UI Mirroring feature.

Change-Id: Iacdf0bf589e328a7ef3902555e92d11f505492ff

7 years agolabel: set duration/speed for text marquee using internal functions 78/142578/2
Youngbok Shin [Fri, 4 Aug 2017 02:59:29 +0000 (11:59 +0900)]
label: set duration/speed for text marquee using internal functions

@tizen_feature

Change-Id: I3746364acd1818a9f0766ce18e029c8a3f70dc0d

7 years agoatspi: do not accept invisible object 45/142245/2
Shinwoo Kim [Thu, 3 Aug 2017 06:46:25 +0000 (15:46 +0900)]
atspi: do not accept invisible object

Issue:
If an object is child of scrollable parent, then the object is accepted even
though the object is invisible.

Solution:
Do not accept invisible object.

Change-Id: I0492eb9f5f265211521f066acd6f56d9c24356c0

7 years agoatspi: enhance elm_atspi_gesture_cb_set document 29/142229/3
Shinwoo Kim [Thu, 3 Aug 2017 06:24:31 +0000 (15:24 +0900)]
atspi: enhance elm_atspi_gesture_cb_set document

Change-Id: I887c08230b1de0404357d1b3717f4b3e14c08365

7 years agoatspi: handle "gesture_required" attribute 10/142110/3
Shinwoo Kim [Wed, 2 Aug 2017 12:15:56 +0000 (21:15 +0900)]
atspi: handle "gesture_required" attribute

The elementary sends the "detail2" information highlight based on the attribute
"gesture_required" when an object grabs.

If an object has attribute key "gesture_required", and "scroll" for its value,
then the "detail2" is 1. Otherwise, the "detail2" is 0.

The screen-reader AT client calls "ObjectNeedsScrollGesture" method of
e-mod-tizen-screen-reader window manager module with object geometry value,
if the "detail2" is 1. Otherwise, the object geometry value is not used.

The e-mod-tizen-screen-reader window manager module will send mouse event
based on the object geometry.

Application side could use this feature setting attribute as below:
 - elm_atspi_accessible_attribute_append(btn, "gesture_required", "scroll");

This patch set depends on:
https://review.tizen.org/gerrit/#/c/142108/ (screen-reader)
https://review.tizen.org/gerrit/#/c/142107/ (e-mod-tizen-screen-reader)

Change-Id: I0b731ce947be569b2d782fdc21f18c79ffebf70e

7 years agocursor: remove a warning message from a unused static variable 43/142443/1
Youngbok Shin [Fri, 4 Aug 2017 02:45:14 +0000 (11:45 +0900)]
cursor: remove a warning message from a unused static variable

@tizen_fix

Change-Id: Icfcaf6e0c92aa259afae816313eb29550456d9f8
(cherry picked from commit 8187228fbf2d278779c09366bc12939e563224c8)

7 years agoentry: remove a warning message caused by unused parameter for cbhm 69/142269/1
Youngbok Shin [Thu, 3 Aug 2017 07:39:18 +0000 (16:39 +0900)]
entry: remove a warning message caused by unused parameter for cbhm

@tizen_fix

Change-Id: Ib1f61049b4c7fc075ac9764642eca0a9e7cb358e
(cherry picked from commit 2d18f914a1731a051e1818b1b890f6500a6878c4)

7 years agoentry: remove unused label for goto 90/142090/1 accepted/tizen/3.0/common/20170804.064005 accepted/tizen/3.0/ivi/20170804.014724 accepted/tizen/3.0/mobile/20170804.014642 accepted/tizen/3.0/tv/20170804.014658 accepted/tizen/3.0/wearable/20170804.014708 submit/tizen_3.0/20170803.051832
Youngbok Shin [Wed, 2 Aug 2017 10:57:05 +0000 (19:57 +0900)]
entry: remove unused label for goto

@tizen_fix

Change-Id: I7ea5763432b9118eb7e33f20419be2e25ccf7a9f
(cherry picked from commit 4efc635dc647d5e43a9e0170f41502a23438aeb5)

7 years agoatspi: suppress warning message 84/141984/2
Shinwoo Kim [Wed, 2 Aug 2017 06:51:25 +0000 (15:51 +0900)]
atspi: suppress warning message

The following is warning message.

In function '_elm_genlist_elm_widget_screen_reader':
warning: declaration of 'l' shadows a previous local [-Wshadow]
              Eina_List *l;
                         ^
note: shadowed declaration is here
    Eina_List *l;

Change-Id: I8af5c5e4a49219bebccd2a51ddc0ddfc853f447f

7 years agoatspi: access overrides Accessible.state_set.get 79/141779/3
Shinwoo Kim [Tue, 1 Aug 2017 10:22:03 +0000 (19:22 +0900)]
atspi: access overrides Accessible.state_set.get

The elm_access a widget makes primitive object accessible. If a primitive
object is not visible, then the elm_access should NOT have state VISIBLE and
SHOWING. From now the elm_access is checking visibility of primitive object.

Change-Id: I27c2f29d3346e03329784872281e4734ec753160

7 years agointerface_scrollable: Modify to cast values between double and int explicitly 20/142020/2
Wonki Kim [Wed, 2 Aug 2017 08:10:49 +0000 (17:10 +0900)]
interface_scrollable: Modify to cast values between double and int explicitly

this commit modify code to cast double and int variables explicitly

Change-Id: I6dc51d60ade454c773308eb778a74c8117ac8fd9
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
7 years agoelm_config: Fix potentional error 19/142019/2
Wonki Kim [Wed, 2 Aug 2017 08:09:14 +0000 (17:09 +0900)]
elm_config: Fix potentional error

Change-Id: I6f3a7e1035f7c329f8ee347b4235cbbcfa30400f
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>