summary |
shortlog | log |
commit |
commitdiff |
tree
first ⋅ prev ⋅ next
hj kim [Tue, 21 Apr 2020 08:16:22 +0000 (17:16 +0900)]
Use mm_util_encode_to_jpeg_memory() instead of old deprecated mm_util_jpeg_encode_to_memory()
Change-Id: I90bf45f3f995cf12281aa6a352f3f57fe1ded9a4
Jeongmo Yang [Wed, 18 Mar 2020 02:56:51 +0000 (11:56 +0900)]
Replace GstCameraControlClass by GstCameraControlInterface
[Version] 0.0.9
[Profile] Common
[Issue Type] Update
Change-Id: I6d29814574987673b7978eba96c00edf84e0ab6e
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Jeongmo Yang [Wed, 16 Jan 2019 04:36:32 +0000 (13:36 +0900)]
Merge branch 'tizen_5.0' into tizen
Change-Id: I86f225ae7a7eb7b63f919a6d508da7d1c7038d8e
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Jeongmo Yang [Wed, 16 Jan 2019 04:35:14 +0000 (13:35 +0900)]
Fix Svace issue - UNCHECKED_FUNC_RES.LIB.STRICT
[Version] 0.0.8
[Profile] Common
[Issue Type] Bug fix
[Dependency module] N/A
Change-Id: Iabbf108a374f2af1e239a417332dfe16f56f3874
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Jeongmo Yang [Mon, 2 Apr 2018 10:53:47 +0000 (19:53 +0900)]
Fix coverity issue - Unchecked return value
[Version] 0.0.7
[Profile] Common
[Issue Type] Coverity
[Dependency module] N/A
Change-Id: Ice9210907be9cd712917eb62b80223ffa65c7c07
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Jeongmo Yang [Mon, 12 Feb 2018 08:43:11 +0000 (17:43 +0900)]
Update enum for refactorying of libmm-utility
[Version] 0.0.6
[Profile] Common
[Issue Type] Update
Change-Id: Ie6a6eb6cb7a7e0400d3d7a06ccc752df01e9b58e
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Jeongmo Yang [Thu, 8 Feb 2018 07:53:41 +0000 (16:53 +0900)]
Fix Svace issue - [WGID:309008] MEMORY_LEAK.EX
[Version] 0.0.5
[Profile] Common
[Issue Type] Svace issue
[Dependency module] N/A
Change-Id: I36b1cf4a200e620fc3bba3027fc340c74b308574
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Sylwester Nawrocki [Thu, 11 Jan 2018 17:15:39 +0000 (18:15 +0100)]
Use V4L2 control ID definitions from kernel header
Use V4L2 control ID definitions from the kernel header rather than
redefining control IDs locally.
Change-Id: Id154b911857836e0b0fcec050de7b19f6db73597
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 11 Jan 2018 17:06:08 +0000 (18:06 +0100)]
Simplify _camerasrc_primary_set_metadata() function
fcount and timestamp arguments were always set to 0 and are now removed.
While at it remove commented out code.
Change-Id: Id99ca5a2da181472d129edcad939b05b554aeac1
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 11 Jan 2018 16:47:14 +0000 (17:47 +0100)]
Fix sensor metadata setting in the ISP thread function
Use proper function for the front camera.
Change-Id: I2076518de49e98c48eb5e72fba7cdb5e04d73b7d
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 11 Jan 2018 12:41:24 +0000 (13:41 +0100)]
Get rid of remaining hard coded V4L2 control IDs
The constant names taken from include/uapi/linux/videodev2_exynos_camera.h
kernel header.
Change-Id: I511583d9944123317a49eb1930b670b43768b5a7
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 11 Jan 2018 12:28:38 +0000 (13:28 +0100)]
Improve V4L2_CID_IS_FORCE_DONE control handling
V4L2_CID_IS_FORCE_DONE control is now set before stream off for both
front and rear camera (3AA0 and 3AA1).
A hard coded control ID is replaced with local constant, this should
likely be corrected further by properly using control definitions from
the include/uapi/linux/videodev2_exynos_camera.h kernel header.
Change-Id: Ifba693e609a12c6625dc40fc66568a2299793d69
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 11 Jan 2018 10:18:44 +0000 (11:18 +0100)]
Add NULL buffer test in gst_camera_buffer_finalize() callback
Change-Id: I6f9f7905a9427904f7ae4d13f08971599795ca6d
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 11 Jan 2018 10:17:07 +0000 (11:17 +0100)]
Change level of some traces in camerasrc_destroy_buffer()
These are debug level logs rather than warning so we use camsrc_info()
macro instead. These logs probably should be removed altogether.
Change-Id: Ic7966f0cd53884cec27f8e70775dc63c93fe3ad9
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 11 Jan 2018 10:11:22 +0000 (11:11 +0100)]
Make the code more explicit in gst_camerasrc_capture_stop()
This doesn't introduce any functional changes, we just simplify the code
and make it more explicit by removing local variables.
Change-Id: I331624f59c4fa2723b1de28db3b9b28d8dac18a8
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 11 Jan 2018 10:08:34 +0000 (11:08 +0100)]
Remove unneeded assignments of local variable at end of some functions
These assignment have no effect as the local variables are not used after
the assignment.
Change-Id: I7c3a1599b2aad131299a5d49164b8db9d49d03ac
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 11 Jan 2018 10:04:58 +0000 (11:04 +0100)]
Remove unneeded return; statement at end of functions
These return statements are redundant and we can make the code a little bit
simpler and easier to follow by removing them.
Change-Id: I4cb5e8c68671c16fa6072adaad56546fe0615c04
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 11 Jan 2018 10:00:31 +0000 (11:00 +0100)]
Remove unused debug code (__print_timestamp())
This time measurement code has been added for debugging, is now not used
so can be removed.
Change-Id: Id0883370873c72653b9955c8fcf984e439bbde51
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 11 Jan 2018 09:56:14 +0000 (10:56 +0100)]
Remove unneeded _camerasrc_release_device_buffer() call
p->buffer_3aa_out is only used for the primary camera, the
_camerasrc_release_device_buffer() function has always been called with
p->buffer_3aa_out == NULL and thus had no effect, so remove this redundant call.
Change-Id: I342f41da448b2fa86f55a8940d1a773be855ce97
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 11 Jan 2018 09:45:23 +0000 (10:45 +0100)]
Ensure there is no attempts to close incorrect file descriptor
When destroying the camerasrc plugin instance there was incorrectly called
close() on fd_3aa0c and fd_3aa0 which was not initially set to an invalid
value and value of those fields was 0 at that time. This resulted to closing
stdin stream of the camera application, leading to errors when sending message
from the muse daemon like:
E/MUSED_CAMERA( 1332): muse_camera_dispatcher.c: __camera_dispatcher_send_msg(73)
> sending message[{ "api": 0, "api_class": 0, "ret": 0, "get_type": 5,
"get_index": -1, "handle": -
219114416 }] failed. errno 25
Finally starting camera application was failing with en error:
D/TIZEN_N_CAMERA( 1273): camera.c: camera_create(2425) > cb info : 42
...
E/TIZEN_N_CAMERA( 1273): camera.c: _camera_client_wait_for_cb_return(529) > api 0 was TIMED OUT!
E/TIZEN_N_CAMERA( 1273): camera.c: _camera_client_wait_for_cb_return(542) > api 0 : error 0xffffffda
D/TIZEN_N_CAMERA( 1273): camera.c: _camera_client_callback_destroy(2167) > msg_recv thread[0xaad46b50] destroy
Fix this by initializing all camerasrc_handle_t::fd_* members to an invalid
value so there is no attempts to close an incorrect file descriptor.
Change-Id: I7bbce271f4b5eb535ce632e23390fea8298b7a3b
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Fri, 15 Dec 2017 16:06:10 +0000 (17:06 +0100)]
Replace hard coded V4L2 control ID with V4L2_CID_IS_S_STREAM
Change-Id: I044167d03c4f7f8cb2382c3282f658f7867fd399
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Fri, 15 Dec 2017 13:42:06 +0000 (14:42 +0100)]
Remove duplicated code from __camerasrc_close_device() function
Change-Id: I4fc647fe2e802e551a44351e516c2a2deb7a90d6
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 14 Dec 2017 16:00:29 +0000 (17:00 +0100)]
Remove unneeded local 'err' variables
Change-Id: Ibe91cc97d492ba5b6372a194fce39a6293111309
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 14 Dec 2017 16:06:04 +0000 (17:06 +0100)]
Move some DQBUF calls to camerasrc_stop_stream() function
_camerasrc_ioctl_dqbuf() calls are moved out from the thread function where
they are not reachable when thread is canceled through pthread_cancel().
Change-Id: I416c6c48050dd7c3ec8c73e9664c4830965bcf99
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 14 Dec 2017 15:55:15 +0000 (16:55 +0100)]
Fix driver close sequence for front camera
Ensure VIDIOC_S_CTRL calls are done only where required for specific
FIMC-IS pipeline.
Change-Id: I966ad7e68c0d19239ce437ca5b2cc40df836cd52
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Mon, 27 Nov 2017 15:58:26 +0000 (16:58 +0100)]
Remove unused first_frame field of struct _camerasrc_handle_t
Change-Id: I30dd4f3154e22e83d5c4d7f23b89f1047976c9c7
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Mon, 27 Nov 2017 15:57:22 +0000 (16:57 +0100)]
Corrections of the ISP thread cancellation sequence
With only pthread_setcancelstate(), pthread_cancel() the front camera ISP
thread exit sequence might take too long so the isp_thread_cancel flag is used.
Change-Id: I2246d871f226611aeace387155b9ec33a75860ce
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Mon, 27 Nov 2017 11:06:53 +0000 (12:06 +0100)]
Rename _camerasrc_set_shot_meta functions
No functional changes. Make it clear which function applies to which
camera. Eventually these functions should be split/removed.
Change-Id: I12b12635d9c8c60e4e54c7ca261f3bdd7f9f8c69
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Mon, 27 Nov 2017 11:26:33 +0000 (12:26 +0100)]
Replace malloc() + memset() with calloc()
Also unneeded casting from void * is removed.
Change-Id: I462ea5b5f42be44c59f956bbd2c4f0ebc78ffc27
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Mon, 27 Nov 2017 14:36:34 +0000 (15:36 +0100)]
Make sure plane_num, handle_num fields of MMVideoBuffer are initialized
This fixes waylandsink error with SN21 format
W/GST_LOG ( 1154): gstinfo.c: gst_debug_log_default(1052) > 0:00:01.
595899459
1154 0x55654ba280 ERROR waylandsink gstwaylandsink.c:2141:
gst_wayland_sink_create_wlbuffer_with_previous_plugin_tbm: could not create wl_buffer
Change-Id: Icb2a40de3b64b14d337bdd0280f311e5a9c7a13e
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 23 Nov 2017 18:17:15 +0000 (19:17 +0100)]
Remove isp_buf_count variable
isp_buf_count was used only for debugging.
Change-Id: Iae9d1f7081cceedc2a8052a743e53f6b6e61ca9f
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 23 Nov 2017 18:11:15 +0000 (19:11 +0100)]
Reduce number of conditional operators
This fixes SVACE warning:
Line 2390: if (!(p->format_scp.pix_format == CAMERASRC_PIX_YUV422P ||
(CODE_SMELL/Warning) Reduce the number of conditional operators (8
Change-Id: I28e530831224916af6ba983c54973b9b16b8c216
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 23 Nov 2017 17:56:14 +0000 (18:56 +0100)]
Remove unused S_FMT_COUNT, BUF_LEN constants
Change-Id: I6747b2b31ba208b1f18299e6207f00db59285cf7
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Thu, 23 Nov 2017 17:47:12 +0000 (18:47 +0100)]
Initialize number of buffers in camerasrc_set_format()
Number of 3AA0C buffers is decreased to 0 as the 3AA0C DMA output
is currently not used.
Change-Id: If6f592e9dd083f261220b5e56ddd403554aa01c5
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Sylwester Nawrocki [Fri, 30 Jun 2017 08:58:22 +0000 (10:58 +0200)]
Rear camera fixes
- Added separate thread for the Sensor/3AA/ISP pipeline
- Added poll() call before SCP buffer dequeueing
- Added copying of metadata from 3AA output to ISP output
buffers
- Added high FPS/low resolution start sequence for rear
camera (currently commented out)
- Removed unused code, rear camera close sequence improvement
The front and the rear camera are working properly, front camera
currently needs 'sync=no' option to gst-launch to avoid low frame
rate.
Length of SCP buffer queue for front camera has been decreased
to minimize lagging.
TODO:
- ioctl locking needs to be revisited,
- buffer sizes in camerasrc_create_buffer() need to be corrected
- proper error handling within the ISP thread needs to be added
Change-Id: If6c8631c93ba6130a07360404df12d5466a20aca
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Jeongmo Yang [Wed, 24 May 2017 05:40:15 +0000 (14:40 +0900)]
Support rear camera for test
[Version] 0.0.2
[Profile] Common
[Issue Type] Update
[Dependency module] N/A
[Test] [M(T) - Boot=(OK), sdb=(OK), Home=(OK), Touch=(OK), Version=tizen-unified_20170515.1]
Change-Id: I62d41d1886426a201fae294e103ca2b718420fa5
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Jeongmo Yang [Tue, 10 Oct 2017 04:39:54 +0000 (13:39 +0900)]
Fix coverity issue
1. Bad bit shift operation : camerasrc.c at line 159
2. Buffer not null terminated : gstcamerasrc.c at line 3136
3. Unused value : gstcamerasrc.c at line 1483
[Version] 0.0.4
[Profile] Common
[Issue Type] Coverity
[Dependency module] N/A
Change-Id: Iafc38c95359da15accfee3300c73b5f19b53e4ee
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Youngjae Shin [Fri, 8 Sep 2017 06:49:08 +0000 (15:49 +0900)]
remove build warning
Change-Id: I42261b1ed8019f83db90e022957953fb9a49c858
Jeongmo Yang [Thu, 22 Jun 2017 07:52:58 +0000 (16:52 +0900)]
Correct license
- Remove Apache-2.0 license and related file
[Version] 0.0.2
[Profile] Common
[Issue Type] Update
[Dependency module] N/A
Change-Id: I6802a1ff895eb973e0c262f20296aba3f0c51775
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Jeongmo Yang [Thu, 20 Apr 2017 01:22:32 +0000 (10:22 +0900)]
Fix Svace issues
[Version] 0.0.1-2
[Profile] Common
[Issue Type] Bug fix
Change-Id: Iba31ce0ce32aa5eac95beaa29b4986fe1189fb37
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
MyungJoo Ham [Wed, 11 Jan 2017 03:14:53 +0000 (12:14 +0900)]
Remove Respotory Dependency
- This is for Tizen 4.0 Only.
: In Tizen 4.0, we are going to unify the repositories as well.
- If you do not want to include this in TM1, you don't need to do
anything. It is already excluded from its meta data.
Change-Id: I01d90ede7d17d0ae19ad701428fcb52d5e2763c4
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Seung-Woo Kim [Wed, 10 Aug 2016 09:15:44 +0000 (18:15 +0900)]
packaging: replace kernel-haeder pakcage name
Change-Id: I5013c5ef8d411f21ae0ac68fa0b2d69a9bbabac1
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Jeongmo Yang [Mon, 28 Mar 2016 02:43:34 +0000 (19:43 -0700)]
Merge "Let vendorSpecific2[0] field be configured by the driver" into tizen
Jeongmo Yang [Tue, 22 Mar 2016 08:14:11 +0000 (17:14 +0900)]
Exclude build in target-TM1 repository
Change-Id: Ia2d81bc4d4b5095823938121185eb857acc5f1ed
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
Sylwester Nawrocki [Mon, 29 Feb 2016 11:06:45 +0000 (12:06 +0100)]
Let vendorSpecific2[0] field be configured by the driver
Since kernel commit
3e6e3e729baf712772eea9ebeea1f1474cc88c35
"fimc-is: Add setting of vendorSpecific2[0] metadata structure field"
vendorSpecific2[0] metadata structure field is being configured
by the fimc-is driver. We are leaving it cleared now so Draco
and Dracor boards can be properly supported.
Change-Id: I1d94aaeb01ce1858ffe1d097ad9c0987ebc926b9
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Jeongmo Yang [Thu, 27 Aug 2015 08:16:01 +0000 (17:16 +0900)]
Initial release
Change-Id: Ie94ff53813ecc79a84ebfc1a3da887758bb3af5e
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
KyungMi Lee [Thu, 27 Aug 2015 04:12:40 +0000 (21:12 -0700)]
Initial empty repository