platform/core/system/dlog.git
13 months agoMT readers sandbox/mbloch/broken-stuff
Michal Bloch [Thu, 28 Sep 2023 19:14:19 +0000 (21:14 +0200)]
MT readers

13 months agoDead reader storage: only keep reader threads
Michal Bloch [Thu, 28 Sep 2023 18:53:00 +0000 (20:53 +0200)]
Dead reader storage: only keep reader threads

13 months agoRemove some pointless yet racy code
Michal Bloch [Thu, 28 Sep 2023 18:21:05 +0000 (20:21 +0200)]
Remove some pointless yet racy code

13 months agoFix persistent readers being unthreaded
Michal Bloch [Thu, 28 Sep 2023 18:27:03 +0000 (20:27 +0200)]
Fix persistent readers being unthreaded

13 months agoLet memory readers go through dead reader storage
Michal Bloch [Thu, 28 Sep 2023 18:22:25 +0000 (20:22 +0200)]
Let memory readers go through dead reader storage

13 months agoPerform signal-related cleanup on exit
Michal Bloch [Thu, 28 Sep 2023 17:51:48 +0000 (19:51 +0200)]
Perform signal-related cleanup on exit

13 months agoExtract signal handling into two functions
Michal Bloch [Thu, 28 Sep 2023 17:50:41 +0000 (19:50 +0200)]
Extract signal handling into two functions

13 months agoFix a race condition 32/299432/1
Michal Bloch [Mon, 25 Sep 2023 11:58:32 +0000 (13:58 +0200)]
Fix a race condition

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b059

13 months agoRelease 8.0.4 05/298805/2 accepted/tizen/8.0/unified/20231005.093742 accepted/tizen/unified/20230919.091740
Michal Bloch [Wed, 13 Sep 2023 17:52:08 +0000 (19:52 +0200)]
Release 8.0.4

* allow multi-threading the pipe daemon.
  Needs optimisations but is a good start.

* optimize zero-copy backend monitoring.

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b058

13 months agoMake multithreading optional 04/298804/2
Michal Bloch [Wed, 13 Sep 2023 12:45:59 +0000 (14:45 +0200)]
Make multithreading optional

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b056

13 months agodlog_logger: multithread pipe & memory readers 02/296202/3
Michal Bloch [Tue, 18 Jul 2023 13:51:52 +0000 (15:51 +0200)]
dlog_logger: multithread pipe & memory readers

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b004

13 months agoAvoid a race condition 03/298803/2
Michal Bloch [Wed, 6 Sep 2023 14:51:31 +0000 (16:51 +0200)]
Avoid a race condition

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b055

13 months agoAdd locks to log storages 78/292778/4
Michal Bloch [Fri, 12 May 2023 11:17:22 +0000 (13:17 +0200)]
Add locks to log storages

Change-Id: Ic4ed88e4ee90b750b9bda57b3297b70350237f51

13 months agodlog_logger: add Dead Reader Storage 01/296201/3
Michal Bloch [Thu, 20 Jul 2023 12:17:26 +0000 (14:17 +0200)]
dlog_logger: add Dead Reader Storage

It's there, 'cause storing dead readers is now the server's business, that's why!

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b005

13 months agoUnify starting a reader 00/296200/3
Michal Bloch [Tue, 18 Jul 2023 14:11:02 +0000 (16:11 +0200)]
Unify starting a reader

The same function now either adds the reader to server
or, if so defined, runs a standalone thread.

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b001

13 months agoOnly read the logs that could have changed 98/298798/2
Mateusz Majewski [Wed, 13 Sep 2023 13:40:10 +0000 (15:40 +0200)]
Only read the logs that could have changed

This uses the new support for change bitmaps that is implemented in the
zlogger kernel module.

Change-Id: I6d4c9301003c7e436d9bddf7085fb1704f812674

13 months agoDisable some dynamic tests on the zero-copy backend 66/298666/2
Mateusz Majewski [Tue, 12 Sep 2023 07:09:09 +0000 (09:09 +0200)]
Disable some dynamic tests on the zero-copy backend

They have never passed there anyway.

Change-Id: I7680db2f787a5dc6645708997f07ffb775e57efb

14 months agoAdd zero-copy option to test usage message 65/298665/1
Mateusz Majewski [Tue, 12 Sep 2023 07:08:51 +0000 (09:08 +0200)]
Add zero-copy option to test usage message

Change-Id: I86edcbfa01883dcecd7e5944ee6c61941d226147

14 months agoRemove ISU package requirement from the spec 84/298384/1 accepted/tizen/unified/20230913.091605
Mateusz Moscicki [Wed, 6 Sep 2023 08:28:57 +0000 (10:28 +0200)]
Remove ISU package requirement from the spec

Change-Id: I879c1d17db6a42d86e1632ec47cf737cb6706ecf

14 months agoIncrease coverage even further. 72/298272/2 accepted/tizen/unified/20230906.014618
Michal Bloch [Mon, 4 Sep 2023 12:46:56 +0000 (14:46 +0200)]
Increase coverage even further.

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b024

14 months agoExpand the backend comparison table 71/298271/1
Michal Bloch [Mon, 4 Sep 2023 14:56:29 +0000 (16:56 +0200)]
Expand the backend comparison table

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b023

14 months agoImprove the libdlogutil coverage test 46/298046/1 accepted/tizen/unified/20230831.081046
Michal Bloch [Wed, 30 Aug 2023 12:51:13 +0000 (14:51 +0200)]
Improve the libdlogutil coverage test

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b022

14 months agoExclude more code from coverage testing. 45/298045/1
Michal Bloch [Wed, 30 Aug 2023 10:55:17 +0000 (12:55 +0200)]
Exclude more code from coverage testing.

 * work around poorly designed coverage testing setup (see logprint.c)
 * exclude things that aren't in the public API

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b021

14 months agoRelease 8.0.3 49/297849/4 accepted/tizen/unified/20230828.102413
Michal Bloch [Fri, 25 Aug 2023 12:07:49 +0000 (14:07 +0200)]
Release 8.0.3

Coverage tests improvements

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b015

14 months agoExclude some inaccessible code 65/297865/2
Michal Bloch [Fri, 25 Aug 2023 14:27:40 +0000 (16:27 +0200)]
Exclude some inaccessible code

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b019

14 months agoAdd more dlogutil coverage tests 64/297864/2
Michal Bloch [Fri, 25 Aug 2023 14:15:23 +0000 (16:15 +0200)]
Add more dlogutil coverage tests

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b018

14 months agoFix a warning message 63/297863/1
Michal Bloch [Fri, 25 Aug 2023 14:13:50 +0000 (16:13 +0200)]
Fix a warning message

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b017

14 months agoImprove type safety + microoptimize 62/297862/2
Michal Bloch [Fri, 25 Aug 2023 12:39:41 +0000 (14:39 +0200)]
Improve type safety + microoptimize

Don't use the pointer to a member to write to the whole object.
Only write to a member of that member.

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b016

14 months agoAdd CAPI coverage tests 48/297848/2
Michal Bloch [Thu, 24 Aug 2023 19:21:15 +0000 (21:21 +0200)]
Add CAPI coverage tests

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b014

14 months agoGather public API coverage 13/297813/1
Michal Bloch [Wed, 23 Aug 2023 13:25:44 +0000 (15:25 +0200)]
Gather public API coverage

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b013

14 months agoRelease 8.0.2 accepted/tizen/unified/20230821.162303
Michal Bloch [Fri, 18 Aug 2023 12:09:41 +0000 (14:09 +0200)]
Release 8.0.2

Coverage stats + preparation for MT

14 months agoExclude some files from coverage 07/297307/1
Michal Bloch [Wed, 16 Aug 2023 19:08:45 +0000 (21:08 +0200)]
Exclude some files from coverage

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b012

14 months agoAdd "coverage tests" 06/297306/1
Michal Bloch [Fri, 11 Aug 2023 17:25:56 +0000 (19:25 +0200)]
Add "coverage tests"

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b011

15 months agolog storage: leave no dangling pointers, even if unused 06/297206/1
Michal Bloch [Thu, 3 Aug 2023 19:45:20 +0000 (21:45 +0200)]
log storage: leave no dangling pointers, even if unused

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b010

15 months agoCommonize reader_free_foreach 53/296153/2
Michal Bloch [Thu, 20 Jul 2023 12:20:00 +0000 (14:20 +0200)]
Commonize reader_free_foreach

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b000

15 months agoRemove log storage peeking 49/295949/3
Michal Bloch [Mon, 17 Jul 2023 15:10:22 +0000 (17:10 +0200)]
Remove log storage peeking

Not thread safe, won't be used with threads.

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b764

15 months agodlog_logger: unify reader servicing 42/292642/4
Michal Bloch [Tue, 9 May 2023 15:09:26 +0000 (17:09 +0200)]
dlog_logger: unify reader servicing

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b760
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
15 months agodlog_logger: add a ghetto vtable to readers 75/292475/4
Michal Bloch [Mon, 8 May 2023 11:39:49 +0000 (13:39 +0200)]
dlog_logger: add a ghetto vtable to readers

Change-Id: I3b9ee496a24f6e22f87a544fcf2beac1c1ccf01e
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
15 months agodlog_logger: commonize reader threading facilities 74/292474/4
Michal Bloch [Fri, 5 May 2023 18:47:36 +0000 (20:47 +0200)]
dlog_logger: commonize reader threading facilities

Change-Id: I1e48836dd71094512f8364c0d361dc131b178bf1
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
15 months agoGet rid of AL reader source FD entity 73/292473/4
Michal Bloch [Fri, 5 May 2023 18:48:03 +0000 (20:48 +0200)]
Get rid of AL reader source FD entity

We poll manually now.

Change-Id: I3df12aa9af47e58f92bd545d3fbc779b05d927f0
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
15 months agoFix a null dereference 09/297009/1 accepted/tizen/unified/20230818.054520
Michal Bloch [Tue, 8 Aug 2023 15:05:36 +0000 (17:05 +0200)]
Fix a null dereference

Change-Id: I798ac2334b123255bdb5afc19208e1eba412b4ee

15 months agoReplace prefix 'libsys' with 'syscommon' 65/296265/2
Youngjae Cho [Mon, 24 Jul 2023 11:58:24 +0000 (20:58 +0900)]
Replace prefix 'libsys' with 'syscommon'

The libsyscommon prototype has changed to have prefix 'syscommon'.
Although this patch has no effect, followed the libsyscommon as it
is literally a function of the libsyscommon. This association would
help to address the workaround later.

Change-Id: I798ac2334b123255bdb5afc19208e1eba412b4ef
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
15 months agoFix pipe reader log selection logic 48/295948/2
Michal Bloch [Mon, 17 Jul 2023 15:10:03 +0000 (17:10 +0200)]
Fix pipe reader log selection logic

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b763

15 months agoStorage returns entry into buffer 47/295947/2
Michal Bloch [Mon, 17 Jul 2023 15:09:52 +0000 (17:09 +0200)]
Storage returns entry into buffer

In preparation for thread-safety (can't return
a pointer since the pointee can die).

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b762

15 months agoFix order dependency of some compression tests 46/295946/2
Michal Bloch [Mon, 17 Jul 2023 15:09:46 +0000 (17:09 +0200)]
Fix order dependency of some compression tests

Change-Id: I4c546d8e3479b7498c9ed2def85b7f710672b761

16 months agoExtract common parts of util req handling 21/292121/4
Michal Bloch [Wed, 26 Apr 2023 16:08:10 +0000 (18:08 +0200)]
Extract common parts of util req handling

Change-Id: I8cec8a8c8f20724714b149354baea1fb3f94df16
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
16 months agoImprove commentary a bit 20/292120/2
Michal Bloch [Wed, 26 Apr 2023 15:05:02 +0000 (17:05 +0200)]
Improve commentary a bit

Change-Id: I91f26aae5fc34fe399ee948b8c8ca5630a5a654f
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
16 months agoAddendum c0b7aa712756fc0c6eab600b022c66ca684d6de3 49/295549/1 accepted/tizen/unified/20230712.040728
Michal Bloch [Mon, 10 Jul 2023 17:12:59 +0000 (19:12 +0200)]
Addendum c0b7aa712756fc0c6eab600b022c66ca684d6de3

Change-Id: I15d5fac23d1feb37d9fa699df7b973442eb0deb6

16 months agoRelease 8.0.1 37/295537/4
Karol Lewandowski [Mon, 10 Jul 2023 11:58:08 +0000 (13:58 +0200)]
Release 8.0.1

Change-Id: I15d5fac23d1feb37d9fa699df7b973442eb0deb5

16 months agoAdd ISU Package 53/292953/9
Mateusz Moscicki [Tue, 16 May 2023 08:35:56 +0000 (10:35 +0200)]
Add ISU Package

Change-Id: Ia0c6b6de39194c8e8522888c683904b762a6116c

16 months agoDrop dynamic filters configure option 45/295545/2
Karol Lewandowski [Mon, 10 Jul 2023 14:48:20 +0000 (16:48 +0200)]
Drop dynamic filters configure option

Change-Id: If58d71553306651b4fa1c353d6558c349d6f6c33

16 months agoconfigure: XO is long gone, long live Tizen 36/295536/3
Karol Lewandowski [Mon, 10 Jul 2023 11:50:44 +0000 (13:50 +0200)]
configure: XO is long gone, long live Tizen

This commit drops legacy configure options, including XO.

Change-Id: I35108361cc1f260e1fa3715f1d23f939f0b7a051

16 months agopackaging: Make vconf usage optional and disable it by default 35/295535/3
Karol Lewandowski [Mon, 10 Jul 2023 11:32:03 +0000 (13:32 +0200)]
packaging: Make vconf usage optional and disable it by default

vconf is used for low-memory notification, but vconf also uses dlog so adding it here
causes build loop:

   glib2->libdbuspolicy->libcynara-commons->dlog->buxton2->glib2

This commit keeps the feature but disables it by default.

Change-Id: I108f3bb5bbed1a4816bfb8ea8b125c8149a09ded

16 months agopackaging: Drop uneeded pkgconfig(vconf) for logger binary package 34/295534/1
Karol Lewandowski [Mon, 10 Jul 2023 11:40:16 +0000 (13:40 +0200)]
packaging: Drop uneeded pkgconfig(vconf) for logger binary package

pkgconfig() is for build deps, it's strictly unnecessary for dlog_logger binary package.

Change-Id: Ic014f07b5986ee7b448820d4788ffa257ab6944e

16 months agoFix the stdout redirection block 87/295287/1
Michal Bloch [Mon, 3 Jul 2023 14:51:16 +0000 (16:51 +0200)]
Fix the stdout redirection block

Change-Id: I38d80a33a8af0093eea3c59766c423c9148f1788

16 months agoRelease 8.0.0 65/295165/1
Michal Bloch [Mon, 3 Jul 2023 09:19:45 +0000 (11:19 +0200)]
Release 8.0.0

Add low-memory compression size reduction and stdout disabling.

Change-Id: I38d80a33a8af0093eea3c59766c423c9148f17c7

16 months agoMake logger resize storage when system is low on memory 64/295164/1
Antoni [Fri, 12 May 2023 14:11:45 +0000 (16:11 +0200)]
Make logger resize storage when system is low on memory

Logger registers for the wait on a vconf signal.

Change-Id: I38d80a33a8af0093eea3c59766c423c9148f17c3

16 months agodlog_logger: add log compressed storage resize to logctl options 37/288937/11
Marek Szulc [Fri, 12 May 2023 12:24:29 +0000 (14:24 +0200)]
dlog_logger: add log compressed storage resize to logctl options

Change-Id: I8a43bcb73fec343eb47e894c2fdcea6b15ddd38b

16 months agoAdd stdout redirection defaults to `dlog.conf` 85/294785/1 accepted/tizen/unified/20230706.152117
Michal Bloch [Fri, 23 Jun 2023 15:45:32 +0000 (17:45 +0200)]
Add stdout redirection defaults to `dlog.conf`

For discoverability.

Change-Id: I592a75d36a2915bf786ae54cc94591d606fa01c2

16 months agoDisallow redirecting to stdout based on config keys 94/294294/4
Antoni [Thu, 15 Jun 2023 19:58:06 +0000 (21:58 +0200)]
Disallow redirecting to stdout based on config keys

Change-Id: I592a75d36a2915bf786ae54cc94591d606fa01c1

16 months agoFix a scandirat failure in tests 84/294284/1 tizen_dev accepted/tizen/unified/dev/20230726.115320
Michal Bloch [Wed, 14 Jun 2023 16:33:06 +0000 (18:33 +0200)]
Fix a scandirat failure in tests

scandirat would return EOVERFLOW.

Change-Id: I9b26e20b3d81595dcbd09dd0584c23a37ff68599

16 months agoFix snprintf(3) format truncation bug reported by gcc 13 34/294234/1
Łukasz Stelmach [Wed, 14 Jun 2023 14:28:26 +0000 (16:28 +0200)]
Fix snprintf(3) format truncation bug reported by gcc 13

src/tests/deduplicate_test.c: In function 'test_advanced_many_millisec':
src/tests/deduplicate_test.c:331:54: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=]
  331 |                         snprintf(msg, sizeof msg, "%d", index);
      |                                                      ^
src/tests/deduplicate_test.c:331:25: note: 'snprintf' output between 2 and 5 bytes into a destination of size 4
  331 |                         snprintf(msg, sizeof msg, "%d", index);
      |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Change-Id: I9b26e20b3d81595dcbf09dd0584c23a37ff68599
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
17 months agoRemove dlog_print_{dotnet,native} information from the header 78/293178/1 accepted/tizen/unified/20230609.163732
Chanwoo Choi [Mon, 22 May 2023 06:19:33 +0000 (15:19 +0900)]
Remove dlog_print_{dotnet,native} information from the header

dlog.h header file is published by Tizen rootstrap in order to keep
the ABI compatibility. It should only contain the published
information. So that remove dlog_print_{dotnet,native} information
from the header

Change-Id: I91588df23017864fbc767a3c1bb2bebd48c71cf1
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
18 months agoRelease 7.5.5 89/291889/2 accepted/tizen/unified/20230427.041611
Michal Bloch [Mon, 24 Apr 2023 13:27:52 +0000 (15:27 +0200)]
Release 7.5.5

Fixes a race condition that could result in unsorted logs.

Change-Id: Ia21ef08956cff695c9402ad1a63ca87ea121e82c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
18 months ago"""Fix""" an integration test 88/291888/2
Michal Bloch [Mon, 24 Apr 2023 13:16:04 +0000 (15:16 +0200)]
"""Fix""" an integration test

Change-Id: Iecc09484a4a8945b63828a54dc7e5b40cb9db16d
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
18 months agolibdlogutil: printing buffers get aliased 38/291738/3
Michal Bloch [Thu, 20 Apr 2023 20:21:57 +0000 (22:21 +0200)]
libdlogutil: printing buffers get aliased

Change-Id: I7b12fe7ab7cef14479cb09f6335eef54b6b131af
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
18 months agolibdlogutil: pipe requests aliased buffers 37/291737/3
Michal Bloch [Thu, 20 Apr 2023 18:33:55 +0000 (20:33 +0200)]
libdlogutil: pipe requests aliased buffers

Change-Id: I74dd76cf99c40355676a36dd7a5bea7e2c4a67af
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
18 months agoAlow multiplexing from writer-made readers 36/291736/2
Michal Bloch [Tue, 18 Apr 2023 13:43:50 +0000 (15:43 +0200)]
Alow multiplexing from writer-made readers

Change-Id: I0ab35b82c7c4e04909e4a011eee7ce4e99915562
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
18 months agolibdlogutil: pipe request sends buffer info 35/291735/2
Michal Bloch [Thu, 20 Apr 2023 17:23:40 +0000 (19:23 +0200)]
libdlogutil: pipe request sends buffer info

Change-Id: I980216d0f31f5192526507896ef91e96a26e3c25
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
18 months agolibdlogutil: minor refactor 34/291734/2
Michal Bloch [Thu, 20 Apr 2023 14:31:03 +0000 (16:31 +0200)]
libdlogutil: minor refactor

Change-Id: Ib46e7040b9d045f245839aa266562f6dbd1a39c3

18 months agolibdlogutil: extract op set check 33/291733/2
Michal Bloch [Thu, 20 Apr 2023 13:57:10 +0000 (15:57 +0200)]
libdlogutil: extract op set check

Change-Id: I3dfed3f6c298c594af2f41e98c95c347f99dd39c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
18 months agolibdlogutil: extract buffer checks 32/291732/2
Michal Bloch [Tue, 18 Apr 2023 16:19:56 +0000 (18:19 +0200)]
libdlogutil: extract buffer checks

Delete tests because they can't read the config.

Change-Id: I3803b86ad0efc5e2b7e6c3e407b2ccd9fc6ebadf
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
18 months agodlog_logger: allow multiplexing pipe storage readers 69/291569/3
Michal Bloch [Mon, 17 Apr 2023 14:10:26 +0000 (16:10 +0200)]
dlog_logger: allow multiplexing pipe storage readers

Change-Id: I634643dbc26f7f4a8fec2d0e86e12cd16e75bf6c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
18 months agoreader_pipe: get rid of dump/monitor flags 68/291568/2
Michal Bloch [Thu, 13 Apr 2023 13:42:14 +0000 (15:42 +0200)]
reader_pipe: get rid of dump/monitor flags

Only pass them to the storage reader

Change-Id: If7186778b234fa9e8a6a258474652e79a0eeb52f

18 months agodlog_logger: clear drained dumping storage readers 52/291352/3
Michal Bloch [Thu, 6 Apr 2023 15:32:23 +0000 (17:32 +0200)]
dlog_logger: clear drained dumping storage readers

Change-Id: I27316b35c3e06862953bae7ebe3541fc60d32b5c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
18 months agoGeneral pyramidity reduction 51/291351/2
Michal Bloch [Tue, 4 Apr 2023 14:46:01 +0000 (16:46 +0200)]
General pyramidity reduction

40 levels of indentation look down upon you

Change-Id: I8178af8fd23b70337a189677d11a2fc1f767b7fd
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
18 months agodlog_logger: commonize adding server readers 50/291350/2
Michal Bloch [Tue, 4 Apr 2023 12:29:01 +0000 (14:29 +0200)]
dlog_logger: commonize adding server readers

Change-Id: Iac10a724188d407f2298515959096a34b8061ba5
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
18 months agodlog_logger: remove log_buffer ptr from pipe readers 49/291349/2
Michal Bloch [Tue, 4 Apr 2023 10:42:08 +0000 (12:42 +0200)]
dlog_logger: remove log_buffer ptr from pipe readers

Change-Id: I4a40704234e2f964b5961966b147c4711799011e

18 months agodlog_logger: server has just one nominal sorting 48/291348/2
Michal Bloch [Mon, 3 Apr 2023 14:04:16 +0000 (16:04 +0200)]
dlog_logger: server has just one nominal sorting

Change-Id: I926417dbbd46f55bc27887ffbd3a67de5c68b19e
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
19 months agoStorage readers: add `is_finished` for dumping readers 79/291279/1
Michal Bloch [Wed, 5 Apr 2023 12:42:50 +0000 (14:42 +0200)]
Storage readers: add `is_finished` for dumping readers

Both `log_compressed_storage` and regular uncompressed `log_storage`

Change-Id: Ia7265a91eb10350fa5269fe98e94780301687eea
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
19 months agoFix single-log dumping readers 78/291278/1
Michal Bloch [Wed, 5 Apr 2023 14:11:11 +0000 (16:11 +0200)]
Fix single-log dumping readers

Change-Id: I1a0326ff43130646affa211ed117bc6f5041f3af

19 months agodlog_logger: multiplex pipe storage readers (nominally) 77/291277/1
Michal Bloch [Wed, 29 Mar 2023 12:28:12 +0000 (14:28 +0200)]
dlog_logger: multiplex pipe storage readers (nominally)

There's still just one storage reader per pipe reader,
but it's now easy to add more.

Change-Id: I58b677dc0b1989c635207d345540bfad94a2dec2
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
19 months agoAdd log storage peeking 82/290682/2
Michal Bloch [Thu, 30 Mar 2023 11:41:32 +0000 (13:41 +0200)]
Add log storage peeking

Allows to "peek" at an entry without consuming it.

This is needed to be able to choose the best
storage to consume an entry from in the planned
multi-storage reader system.

Change-Id: Id62c6ff2cc4dac5d0fa925d6e01048da50bb2454
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
19 months agodlog_logger: pipe reader buffer param now a bitmask 57/290557/1
Michal Bloch [Fri, 24 Mar 2023 16:25:48 +0000 (17:25 +0100)]
dlog_logger: pipe reader buffer param now a bitmask

Internally only, no logic change. Multiple buffers are still rejected.

Change-Id: I556f91cb1346d80c0b8f04b70deca5875f32d417
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
19 months agodlog_logger: unify reader book-keeping 56/290556/1
Michal Bloch [Fri, 24 Mar 2023 17:46:20 +0000 (18:46 +0100)]
dlog_logger: unify reader book-keeping

Change-Id: I31d02853f4023b123f16e8469741fd62cba8d201
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
19 months agodlog_logger: get rid of Android Logger throttling 53/289853/3
Michal Bloch [Tue, 14 Mar 2023 16:33:56 +0000 (17:33 +0100)]
dlog_logger: get rid of Android Logger throttling

No longer needed now that each reader has its own thread,
since it won't starve other threads.

Change-Id: I90477fcd1510b9447027fc0f1bcfd67b45305514
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
19 months agoRelease 7.5.4 64/290364/1 accepted/tizen/unified/20230329.013219
Michal Bloch [Thu, 23 Mar 2023 15:36:24 +0000 (16:36 +0100)]
Release 7.5.4

Hide csharp API and add daemon multi-threading

Change-Id: I3e5557083ba2551d76a57080539de7e5491590cd

19 months agodlog_logger: simplify reader_logger 45/290145/2
Michal Bloch [Thu, 16 Mar 2023 12:22:01 +0000 (13:22 +0100)]
dlog_logger: simplify reader_logger

No longer uses the server abstraction

Change-Id: I6d60f6bd96c6f6c6460b418489cf39d9bac749b8
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
19 months agoHide dlog_print_{dotnet,native} from the header 25/289925/1
Michal Bloch [Wed, 15 Mar 2023 13:41:12 +0000 (14:41 +0100)]
Hide dlog_print_{dotnet,native} from the header

Change-Id: Ibcd9b7c2c7aaa0a96faaaf6cac4f870dc6d3434f
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
20 months agounit tests: fix a minor leak 01/289701/1
Michal Bloch [Mon, 13 Mar 2023 16:40:17 +0000 (17:40 +0100)]
unit tests: fix a minor leak

Change-Id: I021efcad0ee56fee4a1af8be568635a45ab6df7c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
20 months agolog-redirect: don't put enormous vars on the stack 00/289700/1
Michal Bloch [Mon, 13 Mar 2023 14:25:32 +0000 (15:25 +0100)]
log-redirect: don't put enormous vars on the stack

Change-Id: I3e6df1c687d7d379f13078dbca7450cda34a97d5

20 months agodlog_logger: multi-thread logger readers 78/285378/7
Michal Bloch [Fri, 10 Feb 2023 17:39:40 +0000 (18:39 +0100)]
dlog_logger: multi-thread logger readers

Each Android Logger reader now has its own thread.
This means the daemon now has up to 5 threads, which
will make it more responsive and less likely to starve.

Future commits will introduce similar treatment for
pipe and memory readers if this change proves itself.

Change-Id: I197bf2905449109bdd7a497a571c89c366608b06
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
20 months agodlog_logger: add a dedicated signal handler thread 10/289210/6
Michal Bloch [Tue, 7 Mar 2023 16:14:56 +0000 (17:14 +0100)]
dlog_logger: add a dedicated signal handler thread

Change-Id: I026304f8023bd236d30f30bb356ccb99adbc4d52
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
20 months agodlog_logger: add a function for resizing log_compressed_storage 15/288915/11
Marek Szulc [Fri, 24 Feb 2023 09:29:03 +0000 (10:29 +0100)]
dlog_logger: add a function for resizing log_compressed_storage

Change-Id: I1a2631ac944ef7d1384245464c9a194e3eab535f

20 months agodlog_logger: build with -pthread 30/285130/8
Michal Bloch [Tue, 6 Dec 2022 13:25:01 +0000 (14:25 +0100)]
dlog_logger: build with -pthread

In preparation for multi-threading changes.
Also affects a dlog_logger-adjacent unit test.

Change-Id: I1aabef4640e96978c4b3f54d041048a42d44f7f3

20 months agodlog_logger: remove useless 'exiting' state 87/289087/1
Michal Bloch [Tue, 28 Feb 2023 17:57:38 +0000 (18:57 +0100)]
dlog_logger: remove useless 'exiting' state

Change-Id: I45da2cbfec8fd0243c2e6bd9636559220709fda7
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
20 months agodlog_logger: flush readers on free 86/289086/1
Michal Bloch [Tue, 28 Feb 2023 18:04:08 +0000 (19:04 +0100)]
dlog_logger: flush readers on free

Change-Id: Ie0c431a107900843474e9b0f0557a23fc0eb3254

20 months agotests: less confusing logic 45/289045/2
Michal Bloch [Mon, 27 Feb 2023 16:04:57 +0000 (17:04 +0100)]
tests: less confusing logic

No logic change, but it no longer looks like the test
is somehow obtaining logs that got cleared earlier.

Change-Id: I0c9293d13dd948ec3f41236212d5d774431e5f9d
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
20 months agodlog_logger: extract some struct logger functions 41/289041/2
Michal Bloch [Fri, 24 Feb 2023 21:18:55 +0000 (22:18 +0100)]
dlog_logger: extract some struct logger functions

No logic change, just moving code around.

Change-Id: Ie1f95a4661c71839f75dedebf93eac4f94177d87
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
20 months agoRelease 7.5.3 96/288696/1 accepted/tizen/unified/20230222.161514
Michal Bloch [Tue, 21 Feb 2023 14:03:29 +0000 (15:03 +0100)]
Release 7.5.3

 * add extra 'dotnet' and 'native' sinks
 * preparatory refactoring for daemon multithreading
 * assorted fixes

Change-Id: Id24ada5453ccc43c793f3527e7d1f328a9b558cf
Signed-off-by: Michal Bloch <m.bloch@samsung.com>