Inki Dae [Thu, 10 Dec 2020 05:51:53 +0000 (14:51 +0900)]
packaging: Fix package version
Change-Id: I42f57f57c448b53d66ce55802223a589f110623e
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Inki Dae [Fri, 11 Sep 2020 00:27:15 +0000 (09:27 +0900)]
packaging: Change arch name for aarch64
This patch changes arch name for aarch64 from arm64-v8.2-a to
arm64-v8a to fix a issue - illegal instruction - on RPI4 board.
Change-Id: I5f9871b5de21fd7601bd9557e270ed4fa2edc7c6
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Inki Dae [Thu, 10 Sep 2020 05:15:25 +0000 (14:15 +0900)]
packaging: Fix read failure to Security manifest file
Change-Id: I711c913c4a28ec29bb8fb3794eb94c266611709c
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Inki Dae [Mon, 27 Jul 2020 04:50:18 +0000 (13:50 +0900)]
packaging: Fix spec file for v20.05 support
Change-Id: I2aec3ec498d70061e2a42b8d1acffd069eb22ca9
Signed-off-by: Inki Dae <inki.dae@samsung.com>
Parichay Kapoor [Tue, 31 Dec 2019 08:29:39 +0000 (17:29 +0900)]
Dist: updated install files
Updated the files to installed based on opencl or neon support
Change-Id: Ic76c61107591c7c7e8afb98a71408c5325baa0c4
Signed-off-by: Parichay Kapoor <pk.kapoor@samsung.com>
MyungJoo Ham [Fri, 29 Nov 2019 03:56:25 +0000 (12:56 +0900)]
Dist/Tizen: remove libarmcl-release
There is no one using that obsoleted names.
To avoid "have choice for" problem, remove it.
Change-Id: Id253bd42b5f6a331fdfcd022cdb9ec4691cec923
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
MyungJoo Ham [Tue, 26 Nov 2019 01:09:34 +0000 (10:09 +0900)]
Dist/Tizen: spec file clean-up
1. Do not use "release" postfix for the main library package.
2. Do not use -n if you are going to have the main name as prefix.
3. Cleaned up and added missing internal dependencies
Change-Id: Ic9adef91725b2f73a19b0a5d89ac8480643859da
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
MyungJoo Ham [Wed, 25 Sep 2019 01:26:29 +0000 (10:26 +0900)]
Fix dependency error
Libarmcl's main package is libarmcl-release, not libarmcl.
Change-Id: I960f7c17121320e82efe72a0c991aac3afac5905
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
MyungJoo Ham [Tue, 24 Sep 2019 04:48:04 +0000 (13:48 +0900)]
Fix packaging error
This fixes:
=== the following packages failed to build due to missing build dependencies (1) ===
nnstreamer:
have choice for libarm_compute.so()(64bit) needed by nnfw-devel: libarmcl-devel libarmcl-release
have choice for libarm_compute_core.so()(64bit) needed by nnfw-devel: libarmcl-devel libarmcl-release
have choice for libarm_compute.so()(64bit) needed by nnfw: libarmcl-devel libarmcl-release
have choice for libarm_compute_core.so()(64bit) needed by nnfw: libarmcl-devel libarmcl-release
by
- Make files exclusively installed between subpackages (release and devel)
- Add dependency between relead and devel.
Change-Id: I1b738124c9d62c663e99316eba68cbcda7cd033f
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Inki Dae [Wed, 6 Mar 2019 01:14:53 +0000 (10:14 +0900)]
packaging: add gbs build support for Tizen
Change-Id: I961315e7bb17e071deae469fc26b3a151eb1b0e4
Signed-off-by: Inki Dae <inki.dae@samsung.com>
morgolock [Fri, 27 Nov 2020 10:50:41 +0000 (10:50 +0000)]
Updated the errata.
Change-Id: Iff0d4408d6893ec5812c96f4138154257404af5a
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4594
Reviewed-by: SiCong Li <sicong.li@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
(cherry picked from commit
ccff409625cbc721e5fc227b3617ebca01c9f47e)
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4599
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Tested-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Giorgio Arena [Wed, 25 Nov 2020 11:51:30 +0000 (11:51 +0000)]
COMPMID-4025 [Nightly failure] Fix FP16 CLWidthConcatenateLayer mismatches
Change-Id: I62e09682fe42c17227208387135ff2a165357335
Signed-off-by: Giorgio Arena <giorgio.arena@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4553
Reviewed-by: Pablo Marquez Tello <pablo.tello@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
(cherry picked from commit
c90fcfe90721ecc4cf1045b60bf1c933cb4823f6)
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4177
Tested-by: Michele Di Giorgio <michele.digiorgio@arm.com>
morgolock [Tue, 24 Nov 2020 13:54:19 +0000 (13:54 +0000)]
Updated doxygen documention.
Change-Id: Ia996e490f8348c9cf9161d6d450cba066a17c0a3
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4540
Reviewed-by: SiCong Li <sicong.li@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
(cherry picked from commit
70b1eb8ca43a784afa49f9d6405fdb960184fab3)
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4176
Tested-by: Georgios Pinitas <georgios.pinitas@arm.com>
Manuel Bottini [Tue, 24 Nov 2020 13:04:19 +0000 (13:04 +0000)]
COMPMID-4020: Nightly failure - Few CL DirectConvolutionLayer QASYM8 mismatches
Change-Id: I6653d39346fc4f5394b28b86345ade9c5b43e99c
Signed-off-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4173
Tested-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Reviewed-by: Pablo Marquez Tello <pablo.tello@arm.com>
Giorgio Arena [Tue, 24 Nov 2020 11:42:44 +0000 (11:42 +0000)]
COMPMID-4022 Nightly failure: CL LogicalNot -45 error clCreateKernel
Change-Id: I62dab54582a677753bd9337f6a7db265e57d330d
Signed-off-by: Giorgio Arena <giorgio.arena@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4536
Reviewed-by: Pablo Marquez Tello <pablo.tello@arm.com>
Reviewed-by: Sheri Zhang <sheri.zhang@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
(cherry picked from commit
baeef3d25545257db80d126fbb5624ceb22ba660)
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4174
Tested-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Michele Di Giorgio [Mon, 23 Nov 2020 15:05:12 +0000 (15:05 +0000)]
Fix output address calculation in GEMM OpenCL kernels
Resolves COMPMID-3977
Change-Id: I222e0d1726993e54699646323820fc4ae53ab520
Signed-off-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4530
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
(cherry picked from commit
5fa963fbbc00c716e120287051747b144e2d784c)
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4171
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Tested-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Gian Marco Iodice [Mon, 23 Nov 2020 16:10:27 +0000 (16:10 +0000)]
COMPMID-4018: Fix heuristic fallback for CLGEMMReshapedRHSOnly for
Mali-G52
- Missing fallback in case of export to cl_image
Change-Id: I5bb3013fd1350628f16e4709c4bb31999fece22d
Signed-off-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4531
Reviewed-by: Pablo Marquez Tello <pablo.tello@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
(cherry picked from commit
8919a1a849e425aefcd09c5db5f6f9f2e403d4e9)
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4170
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Manuel Bottini [Thu, 19 Nov 2020 12:12:06 +0000 (12:12 +0000)]
COMPMID-3987: Nightly failure - Android builds failing in dataset and validation
Removing warnings from vector library in GCC 7.1+
Removing warning in wanted switch cases fall throughs
GCAccessor moving constructor removed
Removing parentheses equality checks in stb_image
Small fixes in GEMM test suite
Change-Id: I8ba8e3fa20b45c32e5b6219473e0f33ab787ca30
Signed-off-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4483
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Pablo Marquez Tello <pablo.tello@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
(cherry picked from commit
827817e627acfdc50c3a8ed748932e5893cc8a18)
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4172
Tested-by: Georgios Pinitas <georgios.pinitas@arm.com>
morgolock [Mon, 23 Nov 2020 15:39:23 +0000 (15:39 +0000)]
Update release repository pin
Change-Id: I679b66b97d0e32a5b39c2a53944c00743106dc82
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4529
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Tested-by: Michele Di Giorgio <michele.digiorgio@arm.com>
morgolock [Mon, 23 Nov 2020 14:44:14 +0000 (14:44 +0000)]
Add deprecation notice for OpenGLES and CV functions to README
Change-Id: Ifb0f8f2c1347963fcb14e3bdab69f90dafb1d822
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4527
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Tested-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Georgios Pinitas [Tue, 17 Nov 2020 18:46:40 +0000 (18:46 +0000)]
Update tuning numbers for A55 for both fp16 and fp32
Resolves: COMPMID-3974
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: I6d5189e44ebeda1575a80dd14ec3a09c75f68e03
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4521
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
(cherry picked from commit
40943df83026b66356f24e30f31f78c8b9e59c92)
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4169
Tested-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Gian Marco Iodice [Wed, 18 Nov 2020 13:35:21 +0000 (13:35 +0000)]
COMPMID-3980: Fix F16 regression on Mali-G76
- The issue was related to the wrong N0 used in CLGEMMReshaped heuristic
Change-Id: Iecb010f0de383169c9fb8543faf15b2f93ba2ed8
Signed-off-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4464
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
(cherry picked from commit
f1f61444429447e207e6f145b9d9645d0216dede)
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4167
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Tested-by: Michele Di Giorgio <michele.digiorgio@arm.com>
morgolock [Fri, 20 Nov 2020 14:44:22 +0000 (14:44 +0000)]
Update functions list in Doxygen
Change-Id: Ic9ccfed8eb3c02eabb65aeea2c09f9636df25e6d
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4520
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
(cherry picked from commit
fbcf65ceab2280d3952beff40c349b3143e08476)
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4166
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Tested-by: Michele Di Giorgio <michele.digiorgio@arm.com>
morgolock [Fri, 20 Nov 2020 10:10:12 +0000 (10:10 +0000)]
Update release version in Doxygen
Change-Id: I44e87c966e7001e4bf83baf80405b1ef5c26c2a9
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4505
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Tested-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Georgios Pinitas [Sat, 21 Nov 2020 02:49:11 +0000 (02:49 +0000)]
Initialize unitialized M parameter in NEGEMMAssemblyDispatch
Resolves: COMPMID-3991
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: I353ad84833ce25e1adadb980f46b95de63dd6c62
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4522
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
(cherry picked from commit
71696baa30fd2cb9ac7493937e65abfb16daa16e)
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4168
Tested-by: Michele Di Giorgio <michele.digiorgio@arm.com>
morgolock [Fri, 20 Nov 2020 11:03:33 +0000 (11:03 +0000)]
Update Release Notes 20.11
Change-Id: I0ca2928783d24a8fddd01f15ade796149be3434f
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4165
Reviewed-by: SiCong Li <sicong.li@arm.com>
Tested-by: Georgios Pinitas <georgios.pinitas@arm.com>
morgolock [Thu, 19 Nov 2020 18:42:37 +0000 (18:42 +0000)]
Update Release VERSION in SConscript
Change-Id: Ifed2048b2554e55216152ff9487ee4182735f049
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4489
Reviewed-by: SiCong Li <sicong.li@arm.com>
Tested-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
morgolock [Thu, 19 Nov 2020 15:27:30 +0000 (15:27 +0000)]
Updated release soname
Change-Id: I34f94ad6a792bba56643062b2469b0765d19c85e
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://eu-gerrit-1.euhpc.arm.com/c/VisualCompute/ComputeLibrary/+/278330
Tested-by: bsgcomp <bsgcomp@arm.com>
Reviewed-by: Michele DiGiorgio <michele.digiorgio@arm.com>
Comments-Addressed: bsgcomp <bsgcomp@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4487
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Tested-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
morgolock [Wed, 18 Nov 2020 14:20:00 +0000 (14:20 +0000)]
Remove 3dparty folder and submodule
Change-Id: I6d74f2fc7437c23574eb8e12af52594e66e30027
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4467
Reviewed-by: SiCong Li <sicong.li@arm.com>
Tested-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
morgolock [Thu, 19 Nov 2020 10:07:14 +0000 (10:07 +0000)]
COMPMID-3984: Deprecate GLES functions.
Change-Id: I6f58c56d24e12f5691aec2376ad8d4bed064473b
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4163
Reviewed-by: SiCong Li <sicong.li@arm.com>
Tested-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
morgolock [Thu, 19 Nov 2020 14:38:22 +0000 (14:38 +0000)]
Remove INTERNAL_ONLY
Change-Id: I39f0296fdb8c9be36c2775fab9b91ef22db7b136
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4479
Reviewed-by: SiCong Li <sicong.li@arm.com>
Tested-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Gian Marco Iodice [Wed, 18 Nov 2020 14:56:09 +0000 (14:56 +0000)]
COMPMID-3981: Fix missing fallback for export to cl_image
- Fix missing fallback in the CLGEMMReshaped heuristic on Mali-G77
Change-Id: I0a243c7ed153216966d0809a3b3348f030a845eb
Signed-off-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4463
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
(cherry picked from commit
8b84aaa4db093ac08efa96c2cbf766e800465529)
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4162
Reviewed-by: SiCong Li <sicong.li@arm.com>
Sang-Hoon Park [Fri, 13 Nov 2020 13:44:13 +0000 (13:44 +0000)]
COMPMID-3961: Add Logical OR/AND/NOT operator on CL
Change-Id: I612aeed6affa17624fb9044964dd59c41a5c9888
Signed-off-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4448
Reviewed-by: Pablo Marquez Tello <pablo.tello@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Manuel Bottini [Tue, 17 Nov 2020 12:30:38 +0000 (12:30 +0000)]
COMPMID-3971: Nightly failure - CL LaplacianPyramid mismatches
Change-Id: I8b7dee38d30a7aeb1770cf1cf592c2b5e3d3f93d
Signed-off-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4441
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Pablo Marquez Tello <pablo.tello@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Sheri Zhang [Mon, 16 Nov 2020 21:17:28 +0000 (21:17 +0000)]
COMPMID-3972: ExportToCLImage test failure
Signed-off-by: Sheri Zhang <sheri.zhang@arm.com>
Change-Id: I09d203c8c29935cbd08effc50de7a383d7a99bf3
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4437
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Pablo Marquez Tello <pablo.tello@arm.com>
SiCong Li [Tue, 17 Nov 2020 14:09:01 +0000 (14:09 +0000)]
COMPMID-3979 Sanitise Padding Removal epic
* Add missing padding immutability asserts in all relevant CL kernels
* Remove unnecessary zero padding validation tests.
Change-Id: If93f9ccbc988e0286f5e7b135f812141476d5da0
Signed-off-by: SiCong Li <sicong.li@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4446
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Manuel Bottini [Tue, 17 Nov 2020 13:53:13 +0000 (13:53 +0000)]
COMPMID-3978: Nighlty failure NEON Activation Layer mismatches on android armv7a
Change-Id: I7b0228c9c76bf545dcdda90f873fd93caf487793
Signed-off-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4445
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michalis Spyrou <michalis.spyrou@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Georgios Pinitas [Fri, 13 Nov 2020 11:38:58 +0000 (11:38 +0000)]
COMPMID-3962: Add Logical And, Or, Not support on NEON
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: Iabcd94d1ed6fe8bb27ce93924c35e25f48f39cf1
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4438
Reviewed-by: James Conroy <james.conroy@arm.com>
Reviewed-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Reviewed-by: Michalis Spyrou <michalis.spyrou@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
morgolock [Tue, 17 Nov 2020 09:37:37 +0000 (09:37 +0000)]
COMPMID-3771: Fixed implicit-fallthrough warning
Disabled the warning in the Android.bp. When we move to C++17
we can enable it again and use [[fallthrough]] instead.
Change-Id: I96372d286e1c18f58c704bede131a8eb19cdcb56
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4436
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Sheri Zhang <sheri.zhang@arm.com>
Gian Marco Iodice [Sun, 15 Nov 2020 16:06:10 +0000 (16:06 +0000)]
COMPMID-3975: Update CLGEMM heuristic for Mali-G52 F16
- Update the GEMM heuristic for Mali-G52
- Fix the GEMV heuristic on Mali-G76
Change-Id: I895153d02d09e73c51ecf158e2ae43f81f6d7b05
Signed-off-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4425
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Georgios Pinitas [Mon, 16 Nov 2020 16:34:06 +0000 (16:34 +0000)]
COMPMID-3970: Failure when building with GCC < 6
Address pre-N4387 tuple usage
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: Iefe6e08e27b8fe1e688d2ff9db8cb7e172b568f3
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4429
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Michele Di Giorgio [Mon, 16 Nov 2020 13:10:07 +0000 (13:10 +0000)]
COMPMID-3973: CTS failure in QASYMM8_SIGNED Depthwise and Fully connected when fusing Bounded ReLU in Android R GpuAcc
Change-Id: I6cfee002846d0c84de7e0a5f141dfc4807b93b33
Signed-off-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4421
Reviewed-by: TeresaARM <teresa.charlinreyes@arm.com>
Reviewed-by: Pablo Marquez Tello <pablo.tello@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Georgios Pinitas [Sun, 15 Nov 2020 04:12:37 +0000 (04:12 +0000)]
COMPMID-3967: Fix NEColorConvert segfault
Force odd tensor shape adjustment in case of multi-planar images
to closest even towards infinity instead of zero.
This avoids issues when width or height are 1, which used to round down
to zero.
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: Ia52380ae8941ed83128fb8a2351d7a2e9f4421d9
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4412
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Georgios Pinitas [Fri, 13 Nov 2020 14:03:07 +0000 (14:03 +0000)]
COMPMID-3599: Disable direct gemm convolution testing for armv7 for 8bit
NEGEMMConv2d does not support armv7 kernels for uint8/int8 input.
Restrict int8/uint8 testing to aarch64 only.
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: I3ccbed64b3c7c834f9f9377f48c427f1139d6a26
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4405
Reviewed-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Manuel Bottini [Wed, 11 Nov 2020 15:05:29 +0000 (15:05 +0000)]
COMPMID-3956: Nightly CL failure on G71 with error code -7
Change-Id: Iba02375df47d227feca07cc0215e3389e7c55ade
Signed-off-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4401
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Gian Marco Iodice [Tue, 10 Nov 2020 10:41:37 +0000 (10:41 +0000)]
COMPMID-3959: Update Mali-G52 heuristic for CLGEMM - F32
- Add heuristic in CLGEMMKernelSelection
- Add heuristic in CLGEMMReshapedRHSOnly
- Add heuristic in CLGEMMReshaped
Change-Id: Ibaa13398f7a5976418a0ab1b6696ace09cc480fa
Signed-off-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4366
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: SiCong Li <sicong.li@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Sang-Hoon Park [Thu, 12 Nov 2020 17:41:32 +0000 (17:41 +0000)]
COMPMID-3851: Fix regression on NEDepthwiseConvolutionLayerNativeKernel
The exit condition of some for loops in quantized version
of the kernel with depth_multiplier=1 is decided
during compilation to fix performance issue.
Change-Id: I849b3d63b2a2cf5eb374ae681898ae1c296fb4fe
Signed-off-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4392
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Georgios Pinitas [Wed, 11 Nov 2020 21:05:24 +0000 (21:05 +0000)]
COMPMID-3852: Fix NEReduction window
ReductionOperations splits the kernel for scheduling on the X
dimension when reduction axis is > 0.
By setting the execution window to be unit one in the X dimension the
execution was always restricted to a single thread.
Alters the window to enable multi-threading
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: Idcbe2b78957678310bb8e895969f01de972d3667
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4389
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Georgios Pinitas [Thu, 12 Nov 2020 15:05:01 +0000 (15:05 +0000)]
COMPMID-3960: Mismatch on NEArithmeticSubtraction
Corner-case failure when both input shapes had unit shape on the X axis.
Broadcasting was enabled leading to invalid window execution.
Check is updated to cross-validate the presence of broadcasting by
checking the X dimension in both input shapes.
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: I0b79542279e8d155d2661fddff9691d94a1f6855
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4391
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Georgios Pinitas [Mon, 2 Nov 2020 01:37:17 +0000 (01:37 +0000)]
COMPMID-3776: Indirect GEMM
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: I51a1b0f098bc3a8c408c50c92221e4df3061e12c
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4343
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Sheri Zhang [Mon, 26 Oct 2020 15:46:37 +0000 (15:46 +0000)]
COMPMID-3881: Update remove OpenCL padding 20.11 documentation
Signed-off-by: Sheri Zhang <sheri.zhang@arm.com>
Change-Id: Id6768534c762d8c29a9e1de745a711fa718761cf
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4286
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Giorgio Arena [Mon, 26 Oct 2020 15:04:08 +0000 (15:04 +0000)]
COMPMID-3735 Remove OpenCL padding: CLSoftmaxLayerKernel
- Renamed SELECT_DATA_TYPE to SELECT_VEC_DATA_TYPE to reflect its usage with vectors. SELECT_DATA_TYPE(dt) will now return the primitive data type
- Changed the interface of VEC_OFFS and V_OFFS in order to receive the primitive data type as a parameter rather than its vector form
- Performed a general cleanup of the kernels, such as creating macro for sum and max reduces, remove reduntant macros, defines, variables, calculations, etc...
- Using VEC_SIZE and VEC_SIZE_LEFTOVER in every kernel in order to allow computation for smaller shapes without adding paddings
- Removed the actual padding from the kernel and adjusting its calculations accordingly. Added asserts for padding removal checks. Removed invalid Validate tests.
Change-Id: If5ccbd5d34e255d38c7f6bfe8740e2b80b28e264
Signed-off-by: Giorgio Arena <giorgio.arena@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4277
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: SiCong Li <sicong.li@arm.com>
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
morgolock [Fri, 6 Nov 2020 10:40:12 +0000 (10:40 +0000)]
COMPMID-3957: Deprecate CV functions in CL backend.
Change-Id: Ic3deac8d6ce128312f49aa1ddf9f508d05d1b7a2
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4368
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Sheri Zhang <sheri.zhang@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Georgios Pinitas [Wed, 11 Nov 2020 10:54:52 +0000 (10:54 +0000)]
COMPMID-3701: Avoid macro clashing
Prefix macros in Version.h with ARM_COMPUTE_ and undef if not needed.
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: Ie9607f6655550519863be55ec34490f45ccfa55e
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4379
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Georgios Pinitas [Tue, 10 Nov 2020 16:42:30 +0000 (16:42 +0000)]
COMPMID-3792: Graph examples crash on bare-metal
Restricts check of empty windows to 1D splits.
This avoids out-of-bounds access when the GEMM2D Interleaved kernel
is picked where the split dimension specified is MAX_UINT32.
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: I65f42a0cda7b2f1ae65f29c665c2734fbc825214
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4367
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Sang-Hoon Park [Tue, 10 Nov 2020 09:55:03 +0000 (09:55 +0000)]
COMPMID-3630: Fix nightly build regarding move constructor
Fix failusre caused by FFT1D function.
Change-Id: I4c93d9082c1c1995225bdffc4138cfab93b261c1
Signed-off-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4359
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Manuel Bottini <manuel.bottini@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
morgolock [Fri, 6 Nov 2020 08:59:45 +0000 (08:59 +0000)]
COMPMID-3957: Deprecate neon CV functions.
Change-Id: Idfc215c4f95472e2e61d2972cfd5d33786cc088e
Signed-off-by: morgolock <pablo.tello@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4341
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Reviewed-by: Sheri Zhang <sheri.zhang@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Sang-Hoon Park [Tue, 10 Nov 2020 09:52:34 +0000 (09:52 +0000)]
COMPMID-3958: Fix build error with Werror=1
Remove unused variable in anonymouse namespace.
Change-Id: Id9775cd7982f2a2ebf68f20e0c4e33013c3382a0
Signed-off-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4361
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Sheri Zhang [Thu, 5 Nov 2020 10:43:37 +0000 (10:43 +0000)]
COMPMID-3887: NEGEMMConvolutionLayer hangs up on num_threads>18
When store the Tensor shape information, the size was clamped to 32bit, which cause the memory allocated is not big enough.
Signed-off-by: Sheri Zhang <sheri.zhang@arm.com>
Change-Id: I9f7dfcd5595a143b0ed4f6973e20bcd9d776b673
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4331
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Sang-Hoon Park [Wed, 4 Nov 2020 17:32:38 +0000 (17:32 +0000)]
COMPMID-3639: Fix script to generate *Kernels.h
Change-Id: Ie44fc807fe8d7ad04a97f0ea4f611b60cb8e0716
Signed-off-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4325
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Sheri Zhang [Mon, 9 Nov 2020 15:12:32 +0000 (15:12 +0000)]
COMPMID-3852: Fix complex multiplication remove padding performance regression
Signed-off-by: Sheri Zhang <sheri.zhang@arm.com>
Change-Id: I2605baba63c9cca0370328860313b8ec09e04fb6
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4355
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Sheri Zhang [Tue, 22 Sep 2020 14:51:37 +0000 (15:51 +0100)]
COMPMID-2808: Add support for QASYMM8_SIGNED in NEROIAlignLayer
Signed-off-by: Sheri Zhang <sheri.zhang@arm.com>
Change-Id: Id4f4c96e1823a4b27886fee9baf70847172e619c
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4335
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Sang-Hoon Park [Mon, 9 Nov 2020 10:14:03 +0000 (10:14 +0000)]
COMPMID-3639: Fix nightly regarding move constructor
Change-Id: I853248450f4a1d12cfa5ca291a7a2d2729c5204c
Signed-off-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4352
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
SiCong Li [Sun, 8 Nov 2020 22:11:01 +0000 (22:11 +0000)]
COMPMID-3951 LargeGraph_FLOAT32_Rank4_25 CTS failures in Android Q in CL Fix 2
* Select between the 2 reshaped rhs only kernels at run time
Signed-off-by: SiCong Li <sicong.li@arm.com>
Change-Id: Iae6bcc5379d6d84b5538feccf255cbed43fe64c0
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4348
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Michalis Spyrou [Fri, 6 Nov 2020 18:51:05 +0000 (18:51 +0000)]
COMPMID-3599: Remove symlink deletion
This creates problems on older scons versions
as it removes graph.so library from the build
folder
Signed-off-by: Michalis Spyrou <michalis.spyrou@arm.com>
Change-Id: I0af027a50ffbd4a16b6ad227ea956beb01832f31
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4346
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
SiCong Li [Sun, 8 Nov 2020 21:58:01 +0000 (21:58 +0000)]
COMPMID-3951 LargeGraph_FLOAT32_Rank4_25 CTS failures in Android Q in CL Fix1
* Fix CLSpaceToBatchLayerKernel and NESpaceToBatchLayerKernel validation
errors by using the correctly calculated output tensor shape
Signed-off-by: SiCong Li <sicong.li@arm.com>
Change-Id: I21d61f870e6a23a2e38dcb95c939b0bf08082b6f
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4347
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-by: TeresaARM <teresa.charlinreyes@arm.com>
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
SiCong Li [Thu, 5 Nov 2020 09:18:11 +0000 (09:18 +0000)]
COMPMID-3730: Remove CLGEMMMatrixMultiplyKernel Patch2
Change-Id: I56137938c9ebe1a5aeeaa750b39fcfc6818016f1
Signed-off-by: SiCong Li <sicong.li@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4332
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Sang-Hoon Park [Wed, 21 Oct 2020 14:58:54 +0000 (15:58 +0100)]
COMPMID-3639: (3RDPARTY_UPDATE) Move CL kernels to src
Change-Id: I10d27db788e5086adae1841e3e2441cd9b76ef84
Signed-off-by: Sang-Hoon Park <sang-hoon.park@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4310
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Georgios Pinitas [Thu, 5 Nov 2020 20:06:49 +0000 (20:06 +0000)]
COMPMID-3850: NEPooling regression for NHWC
Expand left-over loop to handle multiples of 8 for quantized data type
during MaxPooling.
Signed-off-by: Georgios Pinitas <georgios.pinitas@arm.com>
Change-Id: I1304d174c45d2c98247470ac8b4bb6752bbc03a6
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4339
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
SiCong Li [Wed, 28 Oct 2020 14:19:28 +0000 (14:19 +0000)]
COMPMID-3730 Remove padding from CLGEMMMatrixMultiplyKernel Patch1
* Remove default definition for STORE_BLOCK_BOUNDARY_AWARE to avoid elusive bugs
* Clean up gemm_mm_interleaved* and gemm_mm_floating_point* kernels
* Relocate to gemm_v1.cl to avoid clashing with new kernels
* Rename compile time arguments to conform with the established
terminology(MNKB), and to facilitate the use of STORE_BLOCK_BOUNDARY_AWARE
Change-Id: Ia85c746b2536cad87257a79685b459b5d2f9a1be
Signed-off-by: SiCong Li <sicong.li@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4329
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Michalis Spyrou [Wed, 4 Nov 2020 18:55:34 +0000 (18:55 +0000)]
COMPMID-3953: Move assignment operator failures on android
Signed-off-by: Michalis Spyrou <michalis.spyrou@arm.com>
Change-Id: Id37d90e29749c50eb58084ae9a1ef78e84dbdcd7
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4326
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Michele Di Giorgio [Wed, 4 Nov 2020 14:30:48 +0000 (14:30 +0000)]
COMPMID-3599: Remove arm_compute/core/NEON from Android.bp script
NEON core is now all is src.
Change-Id: I6ff87706e1dc4d31faf68c60ec30c54f1e92b0fb
Signed-off-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4324
Reviewed-by: Michalis Spyrou <michalis.spyrou@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Michele Di Giorgio [Wed, 4 Nov 2020 12:18:38 +0000 (12:18 +0000)]
COMPMID-3599: Fix rotate condition in concatenate_width_x4
Correct copy-paste error introduced in previous fix.
Change-Id: I8a82a5a9acd9afbe30c760faf78d87818510642b
Signed-off-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4323
Reviewed-by: Michalis Spyrou <michalis.spyrou@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Michalis Spyrou [Tue, 3 Nov 2020 17:00:04 +0000 (17:00 +0000)]
COMPMID-3941: QLSTM unittests failing in CpuAcc
Add missing datatype in driver go script.
Signed-off-by: Michalis Spyrou <michalis.spyrou@arm.com>
Change-Id: Iadba43c62f762e959937301749c2aa813be86674
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4315
Reviewed-by: Giorgio Arena <giorgio.arena@arm.com>
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Michalis Spyrou [Tue, 20 Oct 2020 23:04:14 +0000 (00:04 +0100)]
COMPMID-3638: Move NEON kernels
Signed-off-by: Michalis Spyrou <michalis.spyrou@arm.com>
Change-Id: Ieed3e4bc8be7fef80c90c5094599b477a56fc473
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4285
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Sheri Zhang [Mon, 2 Nov 2020 17:54:14 +0000 (17:54 +0000)]
COMPMID-3851: Fix output quantization info for SoftmaxLayerNode
Signed-off-by: Sheri Zhang <sheri.zhang@arm.com>
Change-Id: I74b9495dcfcee619fda6f781845711c71eaaa5a6
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4306
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Michele Di Giorgio [Tue, 3 Nov 2020 10:52:02 +0000 (10:52 +0000)]
COMPMID-3931: Concat quant8 unittests, android VTS and CTS tests failing
Change-Id: Ib9a31b861f95caec72a1aa02dbe3c2b46ed25efc
Signed-off-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4309
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michalis Spyrou <michalis.spyrou@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Gian Marco Iodice [Mon, 2 Nov 2020 15:43:57 +0000 (15:43 +0000)]
COMPMID-3939: Update GEMM heuristic Mali-G77
- Update heuristic for GEMM reshaped RHS only
- Fix left-over block size in CLGEMMMatrixMultiplyReshapedOlyRHSKernel
Change-Id: I34c738821ed2e4a537da4a15058eec164cb6b61f
Signed-off-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4305
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Manuel Bottini [Thu, 29 Oct 2020 13:51:23 +0000 (13:51 +0000)]
COMPMID-3721: Remove OpenCL padding CLGEMMLowpMatrixMultiplyReshapedOnlyRHSKernel
Change-Id: I45d26d5f565f9a55f6b5e8d7652b14283ae616f7
Signed-off-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4299
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Michele Di Giorgio [Wed, 28 Oct 2020 17:27:14 +0000 (17:27 +0000)]
COMPMID-3599: Remove directory structure from tests documentation
Relevant descriptions are moved to the ComputeLibrary.dir file so that
they can be shown under the `Files` tab.
Change-Id: I8e9b22c90d452e9fbb509460db28ad9cf87c9fa0
Signed-off-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4303
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Michele Di Giorgio [Thu, 29 Oct 2020 15:32:45 +0000 (15:32 +0000)]
COMPMID-3926: Floor CTS failing in Neon
Depending n the value of `len`, the left-over loop might end up
writing/reading out-of-bounds, therefore corrupting the memory.
Change-Id: I1b0bb300f3e5ea668b585266e1aa6af7f93a5d1e
Signed-off-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4290
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Gian Marco Iodice [Thu, 29 Oct 2020 13:36:50 +0000 (13:36 +0000)]
COMPMID-3930: Update CLGEMM heuristic for fp16. Mali-G76
- Since the GEMM kernel can now work without padding, the heuristic
requires to be fine-tuned to exploit this feature
- The heuristic affects Mali-G76 FP16 only
Change-Id: Ia430627f02131ad956ce2219b80c83c8e7cabaf2
Signed-off-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4284
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-by: SiCong Li <sicong.li@arm.com>
Michalis Spyrou [Mon, 19 Oct 2020 11:41:30 +0000 (12:41 +0100)]
COMPMID-3853: Decouple NEActivationLayer
Decouple datatypes and remove Activation template.
Binary size dropped by 25Kb.
Signed-off-by: Michalis Spyrou <michalis.spyrou@arm.com>
Change-Id: I32c207db124895fee25b56437f9495403315b867
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4217
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Michele Di Giorgio [Tue, 27 Oct 2020 12:44:17 +0000 (12:44 +0000)]
COMPMID-3928: Fix output conversion in gemmlowp_mm_native
This patch solves the following issues that arose from nightly tests:
- The accumulated result of gemmlowp_mm_native can be either uint or
int and in order to be stored in memory we need to convert it to int.
- The RHS matrix still needs padding on the X dimension. Hence, revert
few changes to add the necessary padding elements.
- Replace zero padding validation tests with assertion in the configure
method of the kernel.
Change-Id: Ib6614a91bd0e98f2b850f52eef14d4fbf55517c8
Signed-off-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4259
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Michalis Spyrou [Wed, 28 Oct 2020 19:23:09 +0000 (19:23 +0000)]
COMPMID-3929: Add method to get CL program binaries
Signed-off-by: Michalis Spyrou <michalis.spyrou@arm.com>
Change-Id: I437ba17ff713c003a1edf7efa9d07049f1af305e
Reviewed-on: https://eu-gerrit-1.euhpc.arm.com/c/VisualCompute/ComputeLibrary/+/272734
Tested-by: bsgcomp <bsgcomp@arm.com>
Reviewed-by: Manuel Bottini <manuel.bottini@arm.com>
Comments-Addressed: bsgcomp <bsgcomp@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4283
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Manuel Bottini [Tue, 13 Oct 2020 09:25:31 +0000 (10:25 +0100)]
COMPMID-3827: Resize CTS failing in Neon after removing padding
Change-Id: I7cf27272e4e6e82b36a31a80ed47ae38fbbf9129
Signed-off-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4269
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Manuel Bottini [Wed, 28 Oct 2020 12:08:06 +0000 (12:08 +0000)]
COMPMID-3742: Remove OpenCL padding CLWinogradFilterTransformKernel
Change-Id: Ifcb4bfb357f342c8f45665e089d22677e6f8fe36
Signed-off-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4275
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Manuel Bottini [Wed, 21 Oct 2020 11:34:38 +0000 (12:34 +0100)]
COMPMID-3720: Remove OpenCL padding CLGEMMLowpMatrixMultiplyReshapedKernel
Change-Id: Ie70ba877f0356661a055f026124904bbf2181a33
Signed-off-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4251
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Reviewed-by: SiCong Li <sicong.li@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Sheri Zhang [Wed, 28 Oct 2020 14:01:55 +0000 (14:01 +0000)]
COMPMID-3706: Add padding assert for kernels that don't have padding
Signed-off-by: Sheri Zhang <sheri.zhang@arm.com>
Change-Id: I0a3f0a989a4db9a2abc9c89429e94af4c6b6b366
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4274
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Sheri Zhang [Tue, 27 Oct 2020 10:19:41 +0000 (10:19 +0000)]
COMPMID-3737: Remove OpenCL padding: CLWidthConcatenate2TensorsKernel
Remove padding from CLWidthConcatenate2TensorsKernel
Remove padding from CLWidthConcatenate4TensorsKernel
Change-Id: I2142618e87bf11f831fe3b9375c4a7efda8d3a21
Signed-off-by: Sheri Zhang <sheri.zhang@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4266
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Sheri Zhang [Wed, 14 Oct 2020 12:34:54 +0000 (13:34 +0100)]
COMPMID-3710: Remove OpenCL padding: CLDepthConvertLayerKernel
Signed-off-by: Sheri Zhang <sheri.zhang@arm.com>
Change-Id: Iee1d4655012ce4cb699535697aeefec673f0bc63
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4157
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Sheri Zhang [Tue, 27 Oct 2020 00:24:07 +0000 (00:24 +0000)]
COMPMID-3793: Remove OpenCL padding: CLWidthConcatenateLayerKernel
Signed-off-by: Sheri Zhang <sheri.zhang@arm.com>
Change-Id: I705044a9429bb9a08268368b09463c2af85616d5
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4253
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Manuel Bottini <manuel.bottini@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Giorgio Arena [Tue, 27 Oct 2020 11:16:57 +0000 (11:16 +0000)]
COMPMID-3927 CTS failure for OpenCL ElementwiseOperation
Change-Id: I1a82315dfa9b021f72e0b687da658e2e02c9bb34
Signed-off-by: Giorgio Arena <giorgio.arena@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4257
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Gian Marco Iodice [Thu, 22 Oct 2020 15:37:12 +0000 (16:37 +0100)]
COMPMID-3925: Dispatch CLGEMM with no padding y requirement
- Add has_pad_y flag in GEMMKernelInfo
- Skip reinterpret as 3D in CLGEMMMatrixMultiplyReshapedOnlyRHSKernel if
has_pad_y = false
- Add test to validate CLGEMMMatrixMultiplyReshapedOnlyRHSkernel with
had_pad_y = false/true
- Configure two variants of CLGEMMMatrixMultiplyReshapedOnlyRHSKernel to
run with has_pad_y = false/true in CLGEMM
- Check if the lhs/dst tensors have pad y. If not, run
CLGEMMMatrixMultiplyReshapedOnlyRHSKernel without padding requirement
Change-Id: I68bb43389789736d676b899ac7c77fd9138babaf
Signed-off-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4248
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Georgios Pinitas <georgios.pinitas@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Gian Marco Iodice [Tue, 20 Oct 2020 08:14:45 +0000 (09:14 +0100)]
COMPMID-3741: Remove OpenCL padding: CLWinogradOutputTransformKernel
- Refactor the OpenCL kernels for Winograd output transform NHWC to
avoid padding requirement
- The kernel adopt the reverse store approach to avoid out-of-bound
writes
Change-Id: If9aad20354ff2146f57ead07ba0aaadb3df919f9
Signed-off-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4222
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Giorgio Arena <giorgio.arena@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Giorgio Arena [Fri, 23 Oct 2020 13:24:26 +0000 (14:24 +0100)]
COMPMID-3731 Remove OpenCL padding: CLHeightConcatenateLayerKernel
Signed-off-by: Giorgio Arena <giorgio.arena@arm.com>
Change-Id: I004128fdcc1207c25d2b959f17f04f9e1a8b4cb5
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4247
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Giorgio Arena [Fri, 23 Oct 2020 12:14:26 +0000 (13:14 +0100)]
COMPMID-3880 Nightly failure 947: hikey960 mismatches CL PoolingLayer FP32
Signed-off-by: Giorgio Arena <giorgio.arena@arm.com>
Change-Id: I448f2b52e2089da1b859301eade7b988d816a816
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4245
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Gian Marco Iodice <gianmarco.iodice@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Manuel Bottini [Thu, 22 Oct 2020 17:01:41 +0000 (18:01 +0100)]
COMPMID-3888: AddBroadcast1ElementUint8 test failing
Change-Id: Id68d1d02a05025098bc87e080909e9efbf2e7820
Signed-off-by: Manuel Bottini <manuel.bottini@arm.com>
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4238
Reviewed-by: Giorgio Arena <giorgio.arena@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
SiCong Li [Wed, 14 Oct 2020 16:00:56 +0000 (17:00 +0100)]
COMPMID-3708 Remove OpenCL padding: CLCopyKernel [Patch2]
* Remove the user-supplied padding from CLCopyKernel
Note that this padding is different from the internal "padding" in the
original task, as it is user-supplied instead of internal.
This user-supplied padding interface is removed simply because it has
been replaced by a more capable CLPadLayerKernel, and is not used
anywhere else.
Signed-off-by: SiCong Li <sicong.li@arm.com>
Change-Id: Ib53e76efd7d043ee79dcd47ca734c6dc685da43e
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4194
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Giorgio Arena [Thu, 22 Oct 2020 13:29:50 +0000 (14:29 +0100)]
COMPMID-3713 Remove OpenCL padding: CLDepthwiseConvolutionLayerNativeKernel
Signed-off-by: Giorgio Arena <giorgio.arena@arm.com>
Change-Id: Ic43aba8a6a0a106fc4c1f665ff5cc3ccb31f403d
Reviewed-on: https://review.mlplatform.org/c/ml/ComputeLibrary/+/4235
Comments-Addressed: Arm Jenkins <bsgcomp@arm.com>
Tested-by: Arm Jenkins <bsgcomp@arm.com>
Reviewed-by: Michele Di Giorgio <michele.digiorgio@arm.com>
projects / platform / upstream / armcl.git / log