tools/mic.git
11 years agoupdate release notes release-0.20
Gui Chen [Mon, 8 Jul 2013 06:06:32 +0000 (02:06 -0400)]
update release notes

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agobump up to 0.20 0.20
Gui Chen [Fri, 5 Jul 2013 10:51:36 +0000 (06:51 -0400)]
bump up to 0.20

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agobump up to 0.20-0.rc1
Gui Chen [Thu, 4 Jul 2013 02:15:12 +0000 (22:15 -0400)]
bump up to 0.20-0.rc1

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agoliveusb: fix vfat UUID
Artem Bityutskiy [Mon, 1 Jul 2013 12:25:41 +0000 (15:25 +0300)]
liveusb: fix vfat UUID

Commit '3577b518715c29175c5f517c6f3cf7a70b0e3d39' fixed the UUID string for
raw images, but broke it for liveusb images. And this patch fixes the issue by
making the liveusb code stop adding a dash to the UUID, because now the dash is
there, just like in UUID of ext4.

Change-Id: Ibfccdf204b301808ef63589dbc3934e517a0212d
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agobump up to 0.20-0.rc0
Gui Chen [Mon, 1 Jul 2013 09:50:52 +0000 (05:50 -0400)]
bump up to 0.20-0.rc0

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agoimplement '--check-pkgs' to check if packages included in image
Gui Chen [Thu, 27 Jun 2013 07:41:59 +0000 (03:41 -0400)]
implement '--check-pkgs' to check if packages included in image

check the given package list, if it will be installed, remove it
from the checking list. when check done, it proves some given
packages won't be installed to the image, mic should abort

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agointroduce '--check-pkgs' to check packages included
Gui Chen [Thu, 27 Jun 2013 07:04:27 +0000 (03:04 -0400)]
introduce '--check-pkgs' to check packages included

in some situation like pre-release image, they expect mic
not going on if there are some packages not going to include
in the image

Example: --check-pkgs=eglibc,bash
if either of eglibc and bash will not be present in the image,
mic should not go on the image creation

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agoraw: support the 'fstab' installerfw attribute
Artem Bityutskiy [Thu, 27 Jun 2013 04:35:55 +0000 (07:35 +0300)]
raw: support the 'fstab' installerfw attribute

Similarly to the 'extlinux' attribute of the 'installerfw' KS command, start
supporitng the 'fstab' attribute. This means, for example, if the KS file has
this command:

installerfw "extlinux,fstab"

then MIC will not install/configure extlinux, and it will not generate
/etc/fstab. Instead, installer framework scripts will do that.

I've added the support only to raw images, since installerfw "extlinux" is
allso supported only by raw images. The liveusb support can be added later. I
do not do this because I cannot test liveusb images at this point, so I am
afraid of breaking it.

Change-Id: Ic6bb7241783aeff571956762a42665fcd8881e3f
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agobaseimager: export partition device node
Artem Bityutskiy [Thu, 27 Jun 2013 03:56:29 +0000 (06:56 +0300)]
baseimager: export partition device node

Also export the device node name for each partition. This will be helpful when
we start generating fstab entries in the installer framework scripts.

In MIC environment, the device node name is easily constructed from the disk
name.  The disk name compes from the KS file from the --ondisk option of the
'part' command. And --ondisk is a mandatory argument.

In other installer environments, the disk names may be very different.

Change-Id: Idafce950e511f4a7693e17be10e69fbb1e7d00d8
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agoraw: export file-system UUIDs
Artem Bityutskiy [Thu, 27 Jun 2013 03:49:41 +0000 (06:49 +0300)]
raw: export file-system UUIDs

This will be useful when we want to create fstab entries ourselfs by using the
installer framework.

Change-Id: Ibc425517888d45a86b73e8c73abba5639eb7e093
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agoVfatDiskMount: fix vfat UUID string
Artem Bityutskiy [Wed, 26 Jun 2013 14:28:13 +0000 (17:28 +0300)]
VfatDiskMount: fix vfat UUID string

The right format for the UUID string for vfat in Linux is 'XXXX-XXXX'. This is
how it can be used in fstab, for example (UUID='XXXX-XXXX'). Also, Linux udev
creates /dev/disk/by-uuid/XXXX-XXXX entries for vfat volumes.

The problem in VfatDiskMount is that it provides it in the 'XXXXXXXX' form
(without dash). However, mkfs.vfat does not like the dash, and this is why we
did not have it, I guess.

This patch fixes the situation and makes VfatDiskMount class expose UUID in a
fstab-friendly format. This makes --fstab-entry=uuid option also work for VFAT
volumes (I tested this).

Change-Id: I1d676e3707ef1777df910273381fe4437b415f41
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agoRevert "VfatDiskMount: do not initialize uuid"
Artem Bityutskiy [Wed, 26 Jun 2013 14:21:54 +0000 (17:21 +0300)]
Revert "VfatDiskMount: do not initialize uuid"

This reverts commit 83410bc120b1f214401517f00da86c53e9f3d1b2.

This patch is actually wrong. I discovered that FATFS actually _does_ support
UUID, it is just shorted - it is a 32-bit integer, but has to have the
'XXXX-XXXX' format for fstab.

Let's revert this patch and fix the problem properly.

Change-Id: I1d2019f2f93094d8e222b926ac2519e8e9b9c0b5
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agobaseimager: export INSTALLERFW_MOUNT_PREFIX
Artem Bityutskiy [Wed, 26 Jun 2013 09:15:28 +0000 (12:15 +0300)]
baseimager: export INSTALLERFW_MOUNT_PREFIX

The installer framework scripts sometimes need to know the real current path
where the partitions are mounted. In MIC environment, the real path is the same
as the mountpoint, except when we are not in chroot, in which case the real
path has a prefix. Export this information in the 'INSTALLERFW_MOUNT_PREFIX'
variable.

In other environments, like pc-installer, the current path may be different,
and pc-installer will export it in 'INSTALLERFW_MOUNT_PREFIX'.

This will allow us writing configuration scripts which will work in both MIC
and pc-installer environments.

Change-Id: Ia867685acb43836c7086b062e2f34908f378f355
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agobaseimager: move environment variable definitions
Artem Bityutskiy [Wed, 26 Jun 2013 09:08:49 +0000 (12:08 +0300)]
baseimager: move environment variable definitions

It is cleaner to have a single place where we define all the environement
variables. Move a couple of historical variables to the
'_get_post_scripts_env()' function.

Change-Id: I58e5d2dbe4477effccf254c48a1f74ccad484c8c
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agoRevert "baseimager: add a couple of more installer FW variables"
Artem Bityutskiy [Wed, 26 Jun 2013 08:36:27 +0000 (11:36 +0300)]
Revert "baseimager: add a couple of more installer FW variables"

A better solution is invented.

This reverts commit be0a53342bec78025413dbbd0bf4de5d9c8b454f.

11 years agobaseimager: add a couple of more installer FW variables
Artem Bityutskiy [Wed, 26 Jun 2013 05:25:38 +0000 (08:25 +0300)]
baseimager: add a couple of more installer FW variables

Add two more installer framework variables:

INSTALLERFW_ROOT_PART_NUM and INSTALLERFW_BOOT_PART_NUM

which define the boot and root parition numbers.

Change-Id: I6b717d3051faa23edb58b44265b3eae3aab2a63e
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agofix rpm header not including 'VCS' tag
Gui Chen [Tue, 25 Jun 2013 09:19:54 +0000 (05:19 -0400)]
fix rpm header not including 'VCS' tag

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agoExtDiskMount: fix the UUID feature for extX
Artem Bityutskiy [Mon, 24 Jun 2013 10:12:42 +0000 (13:12 +0300)]
ExtDiskMount: fix the UUID feature for extX

The current implementation of ExtDiskMount is strange. Instead of generating a
random UUID and then ask mkfs.extX to use that UUID, it run mkfs.extX without
-U, let's mkfs.extX generate a random UUID, and then uses e2fsdump and parses
its output.

This is not very logical, and this also does not work with the version of
mkfs that we use at the moment.

Change the logic and simply use mkfs.extX -U.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agoVfatDiskMount: do not initialize uuid
Artem Bityutskiy [Mon, 24 Jun 2013 08:30:31 +0000 (11:30 +0300)]
VfatDiskMount: do not initialize uuid

Do not try to be too smart and initialize UUID to a time-stamp. This UUID is
later on used form mounting in /etc/fstab (UUID=...), and of course this fails
for VFAT because VfatDiskMount provides a fake UUID.

Instead, make VfatDiskMount provide no UUID at all.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agobaseimager: export a number of helful environment variables
Artem Bityutskiy [Fri, 21 Jun 2013 06:02:04 +0000 (09:02 +0300)]
baseimager: export a number of helful environment variables

Make the MIC export a number of environment variables for the %post section of
the KickStart file.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agopartitionedfs: preserve the KS partition number
Artem Bityutskiy [Mon, 24 Jun 2013 06:09:29 +0000 (09:09 +0300)]
partitionedfs: preserve the KS partition number

The 'add_partition()' function takes partition from the KS file and processes
them. A commentary in 'add_partition()' says: "partitions have to be added in
the first-to-last order", so the order is important.

The order number is basically the partition entry number in the KS file.
Unfortunately, it is lost once the partition is added, and later on it is not
easy to match a partition from the KS file to the processed partition.

This patch teaches 'add_partition()' to preserve the KS file partition number
for later use. The new key 'ks_pnum' will be useful in the next patch, when we
export information about partitions and we want it to be in the KS file order.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agoraw: add an option to avoid installing extlinux
Artem Bityutskiy [Thu, 20 Jun 2013 13:58:27 +0000 (16:58 +0300)]
raw: add an option to avoid installing extlinux

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agokickstart: add the installerfw KS command
Gui Chen [Tue, 25 Jun 2013 07:44:18 +0000 (03:44 -0400)]
kickstart: add the installerfw KS command

This command will be used in the KS file and it will specify the list legacy
MIC features which have to be disabled. Instead of these feature, the general
installer framework infrastructure mechanisms will be used.

The first option will be "extlinux" which will disable the legacy extlinux
installation feature. At some point, installerfw=all will be supported,
it will disable all the legacy features (for keyboard, fstab, users, etc).

Along with the option, introduce a helper function which checks if a the
installer framework has to be used for a feature. Usage example:

if use_installerfw(ks, "extlinux"):
    # do not execute MIC's built-in extlinux installation code
else:
    # the compatibility legacy mode

original written by Artem
Artem: added the use_installerfw() function.

Signed-off-by: Gui Chen <gui.chen@intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agoShow stdout and stderr log of post script using msger
Yeongil Jang [Thu, 10 Jan 2013 12:42:21 +0000 (21:42 +0900)]
Show stdout and stderr log of post script using msger

 - Msger can't show and recode stdout and stderr log of post script
 because subprocess excuted post script with sys.stdout and sys.stderr.
 Then mic get the log using subprocess pipe and show log using msger.

Signed-off-by: Yeongil Jang <yg0577.jang@samsung.com>
11 years agoReverted c619010d3b5efa9dc0ebec7839b73cbcd59edcb2
Ed Bartosh [Sun, 16 Jun 2013 13:39:40 +0000 (16:39 +0300)]
Reverted c619010d3b5efa9dc0ebec7839b73cbcd59edcb2

Reverted wrong implementation of getting default architecture. It was
caused inconsitent determination of arch. Different arch was determined
for different orders of repos in .ks file. As a result of wrong
determination of architecture there are image creation failures for the
configurations, where arch was determined incorrectly.

Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
11 years agoMerge branch 'release-0.19' into devel
Gui Chen [Mon, 20 May 2013 05:55:04 +0000 (01:55 -0400)]
Merge branch 'release-0.19' into devel

11 years agobump up to release 0.19 0.19
Gui Chen [Mon, 20 May 2013 05:44:17 +0000 (01:44 -0400)]
bump up to release 0.19

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agobump up to 0.19-0.rc2
Gui Chen [Fri, 17 May 2013 05:44:34 +0000 (01:44 -0400)]
bump up to 0.19-0.rc2

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agofix empty value in max built-in
Gui Chen [Fri, 17 May 2013 06:00:07 +0000 (02:00 -0400)]
fix empty value in max built-in

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agotry to wait for mapping device mapper
Gui Chen [Fri, 17 May 2013 05:40:23 +0000 (01:40 -0400)]
try to wait for mapping device mapper

a delay for setup multipath device will throw error:
/dev/loop0X: No such file or directory

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agogpt_parser: bugfix: correctly update alternate GPT header
Artem Bityutskiy [Thu, 16 May 2013 10:44:02 +0000 (13:44 +0300)]
gpt_parser: bugfix: correctly update alternate GPT header

This patch is a bug-fix which fixes the --part-type option.

The sysmptom of the issue was the following warning from kpartx:

GPT: partition_entry_array_crc32 values don't match: 0xa24d9e34 != 0xc4e77ef0
GPT: Use GNU Parted to correct GPT errors.

The reason of the issue was that we did not update the alternate partition
array. The root-cause is that we cannot rely on the 'offs' element of the
partition entry dictionary because it points to the primary prition array
offset, while we needed the alternate. Instead, we have to calculate the offset
ourselves.

Change-Id: Iec35ebefa28ba8f7a65c414177c909747b6512ed
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: bugfix: correctly update alternate GPT header
Artem Bityutskiy [Thu, 16 May 2013 10:44:02 +0000 (13:44 +0300)]
gpt_parser: bugfix: correctly update alternate GPT header

This patch is a bug-fix which fixes the --part-type option.

The sysmptom of the issue was the following warning from kpartx:

GPT: partition_entry_array_crc32 values don't match: 0xa24d9e34 != 0xc4e77ef0
GPT: Use GNU Parted to correct GPT errors.

The reason of the issue was that we did not update the alternate partition
array. The root-cause is that we cannot rely on the 'offs' element of the
partition entry dictionary because it points to the primary prition array
offset, while we needed the alternate. Instead, we have to calculate the offset
ourselves.

Change-Id: Iec35ebefa28ba8f7a65c414177c909747b6512ed
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agobump up to 0.19-0.rc1
Gui Chen [Thu, 16 May 2013 06:59:52 +0000 (02:59 -0400)]
bump up to 0.19-0.rc1

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agoupdate release date
Gui Chen [Thu, 16 May 2013 06:55:37 +0000 (02:55 -0400)]
update release date

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agofix OSError caused by symlink removing
Gui Chen [Thu, 16 May 2013 06:46:03 +0000 (02:46 -0400)]
fix OSError caused by symlink removing

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agobump up to 0.19-0.rc
Gui Chen [Thu, 16 May 2013 02:44:11 +0000 (22:44 -0400)]
bump up to 0.19-0.rc

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agofix symlink bind mount dirname
Gui Chen [Thu, 16 May 2013 01:58:41 +0000 (21:58 -0400)]
fix symlink bind mount dirname

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agofix relative symbolic link in bind mount
Gui Chen [Wed, 15 May 2013 12:11:36 +0000 (08:11 -0400)]
fix relative symbolic link in bind mount

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agotypo fix
Gui Chen [Wed, 15 May 2013 11:07:37 +0000 (07:07 -0400)]
typo fix

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agofix '/var/lock' non-existent throw traceback
Gui Chen [Wed, 15 May 2013 07:18:22 +0000 (03:18 -0400)]
fix '/var/lock' non-existent throw traceback

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agofix symlink bind mount left issue
Gui Chen [Wed, 15 May 2013 07:08:09 +0000 (03:08 -0400)]
fix symlink bind mount left issue

when bind mount point is symbolic link,
the umount will make it left when clean up

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agoraw: use bmap creation code from bmap-tools
Artem Bityutskiy [Tue, 7 May 2013 06:42:12 +0000 (09:42 +0300)]
raw: use bmap creation code from bmap-tools

This patch copies the bmap creation code from the bmap-tools project to mic.
Hopefully, at some point we can just make mic package depend on bmap-tools and
directly invoke bmap creation functions from bmap-tools. However, mid
maintainers have issues with this at this point, so we just copy the code.

Unlike the old mic implementation which uses FIBMAP ioctl, bmap-tools use the
FIEMAP ioctl, which is better and also works on btrfs.

Change-Id: I8807ac32d3fcb31e9d410250348318fd04a63275
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agomisc: add get_block_size helper function
Artem Bityutskiy [Tue, 7 May 2013 07:02:19 +0000 (10:02 +0300)]
misc: add get_block_size helper function

It returns file-system block size.

Change-Id: Idc512a90c58d76925e46f3bd3782093f2c102d5e
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agofix some depends and add tizen requires
Gui Chen [Thu, 2 May 2013 10:33:05 +0000 (06:33 -0400)]
fix some depends and add tizen requires

tizen-python-zypp is provided by 'python-zypp' maintained
by tizen tools, the provide is different with upstream

Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agogpt_parser: update class commentary
Artem Bityutskiy [Fri, 19 Apr 2013 13:29:38 +0000 (16:29 +0300)]
gpt_parser: update class commentary

We now support CRC checking and partition table changing, so update
commentaries.

Change-Id: Id3acd1699d2da2752d6d05c4400404361a3e5634
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agopartitinedfs.py: implement the --part-type option
Artem Bityutskiy [Thu, 11 Apr 2013 12:01:07 +0000 (15:01 +0300)]
partitinedfs.py: implement the --part-type option

Implement the --part-type option for GPT partitions. In case of MBR partitions
- just error out and say that the option is not implemented, but if someone
needs it for the MBR case in the future - it may be implemented.

Change-Id: I7f45db71df85bd36850d1379a38a84fe73532de6
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agopartition.py: add --part-type option
Artem Bityutskiy [Thu, 11 Apr 2013 11:33:08 +0000 (14:33 +0300)]
partition.py: add --part-type option

Add a kickstart file partition option for specifying partition type. In case of
GPT partitions, this is an UUID which is stored at offset 0 of the partition
entry in the partition table. In case of MBR partitions, this will be the
1-byte partition type which is stored at offset 4 of the partition entry in the
partition table.

Change-Id: I8d03c2414b8e8c555b18f9f94f60a9e0f7742536
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: add parition modification functinality
Artem Bityutskiy [Thu, 11 Apr 2013 10:56:37 +0000 (13:56 +0300)]
gpt_parser: add parition modification functinality

Add a 'change_partition()' method which allows changing partition records.

Change-Id: I29c103f856a51aab4ce11d60126128e3770906be
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: introduce more useful dict keys
Artem Bityutskiy [Thu, 11 Apr 2013 10:19:55 +0000 (13:19 +0300)]
gpt_parser: introduce more useful dict keys

Add some more useful information to the GPT header and partition entry
dictionaries.

Change-Id: I5ab5ff309d8a926c317d1bf22d2797e0f08539f2
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: rename the parts_cnt dict key
Artem Bityutskiy [Thu, 11 Apr 2013 10:05:08 +0000 (13:05 +0300)]
gpt_parser: rename the parts_cnt dict key

The 'parts_cnt' header dictionary key is named poorly because this is actually
the number of available partition table entries, not the number of partitions.
Thus, rename it to 'entries_cnt'.

Change-Id: I565ac7b700ab5ae3b1bb7c8aa503585465588db9
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: implement partition table CRC checking
Artem Bityutskiy [Thu, 11 Apr 2013 09:33:09 +0000 (12:33 +0300)]
gpt_parser: implement partition table CRC checking

Introduce a new helper function for checking partition table CRC32 checksum and
use it in 'get_partitions()' to validate the table.

Change-Id: I1bba90d174a5e146403c1eeff6188426ab7066a2
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: improve naming some more
Artem Bityutskiy [Thu, 11 Apr 2013 09:19:57 +0000 (12:19 +0300)]
gpt_parser: improve naming some more

Use "raw_" prefix for the on-disk data to make the code more readable.

Change-Id: I644f6250ddc3f6483910b94242f06c49c64b5e75
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: add 'primary' dictionary key
Artem Bityutskiy [Thu, 11 Apr 2013 09:17:15 +0000 (12:17 +0300)]
gpt_parser: add 'primary' dictionary key

Add another key to the GPT header and parition record dictionaries to indicate
whether it belongs to the primary or to the backup parition.

Change-Id: I0292badb61cf279a0fd9ac8c1f5bad47c05c1537
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: return a dict from get_partitions
Artem Bityutskiy [Wed, 10 Apr 2013 11:27:16 +0000 (14:27 +0300)]
gpt_parser: return a dict from get_partitions

This makes the code more redable.

Change-Id: I1b41de463d108937ace8b9ce46f08deb0a4d6081
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: return a dict from read_headers
Artem Bityutskiy [Wed, 10 Apr 2013 11:12:53 +0000 (14:12 +0300)]
gpt_parser: return a dict from read_headers

Use a dictionary instead of a tuple because it makes it possible to write more
readable code. Indeed, header['hdr_crc'] is more readable than header[3].

Change-Id: Ia488d61580a9b1d848421a6abc462870418daa34
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: spelling fixes
Artem Bityutskiy [Wed, 10 Apr 2013 08:50:35 +0000 (11:50 +0300)]
gpt_parser: spelling fixes

A couple of spelling fixes.

Change-Id: I7807b071af34ce360bc274d9d0ffa8a7fd12a00b
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: use _read_disk helper in get_partitions
Artem Bityutskiy [Wed, 10 Apr 2013 08:47:41 +0000 (11:47 +0300)]
gpt_parser: use _read_disk helper in get_partitions

Use the helper which we just introduced, because it does errors checking. Also,
introduce a helper _GPT_ENTRY_SIZE constant.

Change-Id: I496933f46292f31987ff37fdc9dabc8c5bd150c6
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: introduce a helpful _GPT_HEADER_SIZE constant
Artem Bityutskiy [Wed, 10 Apr 2013 08:38:13 +0000 (11:38 +0300)]
gpt_parser: introduce a helpful _GPT_HEADER_SIZE constant

Change-Id: Ieaf8a4f916dde383cfeb8a7191cce7bcc72617c3
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: introduce a _disk_read helper
Artem Bityutskiy [Wed, 10 Apr 2013 08:36:05 +0000 (11:36 +0300)]
gpt_parser: introduce a _disk_read helper

It is useful because we can encapsulate all the error checking
in a single function.

Change-Id: I0aac2d2223bc75113b43994db39df71f2ed7cf89
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: add an index element to the partition record
Artem Bityutskiy [Wed, 10 Apr 2013 07:36:17 +0000 (10:36 +0300)]
gpt_parser: add an index element to the partition record

Add an 'index' element to the partition record returned by the
'get_partitions()' method. This is very useful to have when one wants
to change a partition record, which will be implemented in one of the
following patches.

Change-Id: I04b560a7d1e8a97470eea5c221cba7d3e039a501
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parse: use _ prefix for private class members
Artem Bityutskiy [Wed, 10 Apr 2013 07:20:29 +0000 (10:20 +0300)]
gpt_parse: use _ prefix for private class members

Change-Id: Iaccffd75f77bbca172d9a328a9fba42c4e25ad57
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: add backup partition table reading support
Artem Bityutskiy [Wed, 10 Apr 2013 06:58:38 +0000 (09:58 +0300)]
gpt_parser: add backup partition table reading support

Change-Id: I6c1aeda0b54dc5f3e4b3c1bfe69b4d005231c1e0
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: harmonize naming a bit
Artem Bityutskiy [Thu, 11 Apr 2013 06:04:28 +0000 (09:04 +0300)]
gpt_parser: harmonize naming a bit

Use 'raw_hdr' for raw header and 'header' for the header dictionary. This makes
the code easier to read because you always know what you deal with from the
variable name.

Change-Id: Iae0420ec149861067a455bb62276cb50fc6ba719
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: add backup GPT header reading support
Artem Bityutskiy [Wed, 10 Apr 2013 06:51:01 +0000 (09:51 +0300)]
gpt_parser: add backup GPT header reading support

Change-Id: Ie496acd5b8020a2a48a4c905be2467dda338cf12
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: move the GPT header validation to a separate function
Artem Bityutskiy [Wed, 10 Apr 2013 06:29:07 +0000 (09:29 +0300)]
gpt_parser: move the GPT header validation to a separate function

Change-Id: I5d6b088ee8d41bed77f576f39c529914c581eef5
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: validate GPT header CRC32
Artem Bityutskiy [Wed, 10 Apr 2013 06:03:46 +0000 (09:03 +0300)]
gpt_parser: validate GPT header CRC32

Change-Id: I2837d64600876b3fcca187dd112db4590eb96ffe
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: validate header size
Artem Bityutskiy [Tue, 9 Apr 2013 14:48:25 +0000 (17:48 +0300)]
gpt_parser: validate header size

Change-Id: I7cb08dff3421f3390525c0fc4c5188d15ce90e53
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: validate GPT header revision
Artem Bityutskiy [Tue, 9 Apr 2013 13:24:41 +0000 (16:24 +0300)]
gpt_parser: validate GPT header revision

We only support revision 1.0.

Change-Id: If44c27053186e77329681bdda387dc0f6d92c893
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agogpt_parser: use _ for private variables
Artem Bityutskiy [Tue, 9 Apr 2013 12:34:00 +0000 (15:34 +0300)]
gpt_parser: use _ for private variables

The standard convention in python that all the internal variables in a module
start with an underscore symbol.

Change-Id: I38e4ed6d9fc749c43f8c4909320b0415ba3ebba9
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@intel.com>
11 years agofix bug autologinuser always set
Gui Chen [Wed, 10 Apr 2013 09:01:52 +0000 (17:01 +0800)]
fix bug autologinuser always set

Change-Id: I6510aa3de76d9d1d929ca1ad4ccef45a9afcb06a
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agobump up to release 0.18 0.18
Gui Chen [Tue, 2 Apr 2013 09:23:23 +0000 (17:23 +0800)]
bump up to release 0.18

Change-Id: Ia71f0f26a6cbf7e413939780e3a4131307a295a6
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agofix attachment packages swig attr lost
Gui Chen [Tue, 2 Apr 2013 09:52:20 +0000 (17:52 +0800)]
fix attachment packages swig attr lost

Change-Id: Idaeabdd0c340f6f9f8f5eddae6eb17478115d11c
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agofix conflict variable in cmpEVR and priority condition
Gui Chen [Tue, 2 Apr 2013 05:58:06 +0000 (13:58 +0800)]
fix conflict variable in cmpEVR and priority condition

Change-Id: Icd9b2eeac10e5f8265445d96cc9ceb1a5116d158
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agocondider repo priority while sorting packages
Zhang Qiang [Tue, 2 Apr 2013 10:22:47 +0000 (18:22 +0800)]
condider repo priority while sorting packages

standard criterion:
 - arch compatibility with highest priority
 - repo priority
 - package version have lowest priority

Change-Id: I86dcb35a568ddc0162e6145b6871dc2502c3d24f

11 years agobump up to version 0.18-rc0
Gui Chen [Sun, 31 Mar 2013 02:47:43 +0000 (10:47 +0800)]
bump up to version 0.18-rc0

Change-Id: Id94de376e152927ac4df1d0b2587129df5df64dd
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agomount tmpdir as tmpfs to accelerate performance
Gui Chen [Mon, 25 Mar 2013 03:19:21 +0000 (11:19 +0800)]
mount tmpdir as tmpfs to accelerate performance

use --tmpfs to enable this experimental feature

Change-Id: I5fb8e60a24236f7e6cab624a137c3ddb3d03f7d9
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agostrip slash after release option
Gui Chen [Mon, 25 Mar 2013 01:56:41 +0000 (09:56 +0800)]
strip slash after release option

Change-Id: I8746aaafb9d130a514ee623e62432bc0a3a6d343
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agogenerate bmap file outside __imgdir
Gui Chen [Sun, 24 Mar 2013 06:59:09 +0000 (14:59 +0800)]
generate bmap file outside __imgdir

Change-Id: I8d2759a861619f3767f95c6be73fba0c8e457638
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agochange naming for release option
Gui Chen [Sun, 24 Mar 2013 06:58:03 +0000 (14:58 +0800)]
change naming for release option

move snapshot id forward

Change-Id: I537c938c562dd4933e422698bdc84b94cacb8fb5
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agoupdate AUTHORS
Gui Chen [Thu, 21 Mar 2013 06:44:30 +0000 (14:44 +0800)]
update AUTHORS

Change-Id: Iadf5be8daf386c777e7b73b2ff317cacd44ab0b8
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agofix debuginfo rpm swig attr lost
Gui Chen [Tue, 19 Mar 2013 09:03:11 +0000 (17:03 +0800)]
fix debuginfo rpm swig attr lost

when adding debuginfo rpm, the PoolItem doesn't
convert to Solvable

Change-Id: I221760667217421235849536def6bbcfd94199c2
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agoPrint warning when failed to temp ks in normalize_ksfile().
Huang Hao [Mon, 11 Mar 2013 05:48:33 +0000 (13:48 +0800)]
Print warning when failed to temp ks in normalize_ksfile().

* print waring message in try/except block
* add doc string
* remove dir argument to tempfile.mkstemp, since its default
strategy is better than hardcode "/tmp"
* rename _clrtempks to remove_temp_ks and move it behind
* remove the code that check file existence, since it will be
always checked by confmgr.__set_ksconf

Change-Id: Ic4c6125f18eb9e9dda8faa7bc687f97b178b1cea

11 years agoRemove useless try and reraise blocks.
Huang Hao [Mon, 11 Mar 2013 10:42:25 +0000 (18:42 +0800)]
Remove useless try and reraise blocks.

These code catch all exceptions and simply reraise them, which is
equivalent to not writing the try block. So just remove them to
cleanup.

Change-Id: I965356746a5b349458205de9c5a1d6bf97bf8d93

11 years agoChange default mutable arguments of Mic_RepoData.__init__.
Huang Hao [Wed, 6 Mar 2013 04:06:07 +0000 (12:06 +0800)]
Change default mutable arguments of Mic_RepoData.__init__.

Only pass arguments includepkgs, excludepkgs, baseurl,
mirrorlist, name to super __init__ if they are not false.
If they are not present the super __init__ will choose proper
default values for those arguments.

W0102: 26,4:Mic_RepoData.__init__: Dangerous default value [] as argument
W0102: 26,4:Mic_RepoData.__init__: Dangerous default value [] as argument

Change-Id: I56db875ee3d42213726a147a46f9d2e998025cce

11 years agoChange default parameters from mutable type into immutable.
Huang Hao [Wed, 6 Mar 2013 05:35:24 +0000 (13:35 +0800)]
Change default parameters from mutable type into immutable.

Get ride of these pylint warnings:

W0102:190,0:cleanup_chrootenv: Dangerous default value [] as argument
W0102: 47,4:ImagerPlugin.check_image_exists: Dangerous default value [] as argument
W0102:109,8:read_kickstart.KSHandlers.__init__: Dangerous default value {} as argument
W0102:708,0:get_repos: Dangerous default value {} as argument
W0102:772,0:get_attachment: Dangerous default value [] as argument
W0102:775,0:get_pre_packages: Dangerous default value [] as argument
W0102:778,0:get_packages: Dangerous default value [] as argument
W0102:781,0:get_groups: Dangerous default value [] as argument
W0102:784,0:get_excluded: Dangerous default value [] as argument
W0102:787,0:get_partitions: Dangerous default value [] as argument
W0102:877,4:BaseImageCreator.install: Dangerous default value {} as argument
W0102:210,4:Bootstrap.create: Dangerous default value [] as argument

Change-Id: Icc04896829ecfb0e2542f4d4755f4adb07b01319

11 years agoFix an issue with building the man page
Patrick McCarty [Mon, 11 Mar 2013 20:18:05 +0000 (13:18 -0700)]
Fix an issue with building the man page

If the python-docutils package is available in a distro, then make sure
a BuildRequires is added for it.

Change-Id: Ic404fe4ed94bd40aa63139bec3c12b1bcdd59640

11 years agoRefactor function safecopy().
Huang Hao [Wed, 6 Mar 2013 03:04:37 +0000 (11:04 +0800)]
Refactor function safecopy().

* Change ignore_ptns from [] to (). A mutable default value isn't
as expected when invoke in the second time.
>>> def safecopy(ignore_ptns=[]):
...     ignore_ptns += ['*.pyc']
...     print ignore_ptns
...
>>> safecopy()
['*.pyc']
>>> safecopy()
['*.pyc', '*.pyc']

* Add a list into ignore_ptns rather than a string
>>> l = []
>>> l += os.path.basename('/usr/bin')
>>> l
['b', 'i', 'n']

* Include all exception classes by (), otherwise it will catch
OSError and assign this exception instance to a local variable
named IOError.
* Move shutil.ignore_patterns() out of try block since it can
never throw OSError nor IOError.
* Remove useless try/except/raise block which catches every
error but reraise it. It's the same as without this try block.

Change-Id: I8837169bbf4acbadf4a2cfd8ac999d371831d86a

11 years agoReraise exception in bootstrap_mic() but keep original traceback.
Huang Hao [Thu, 28 Feb 2013 12:51:44 +0000 (20:51 +0800)]
Reraise exception in bootstrap_mic() but keep original traceback.

When exception occurs, we could add additional information but
should keep the original traceback. Otherwise traceback shows up
in console will be the second one, which hide the true exception.

A bare "raise" statement is a special syntax to reraise the
original exception, which will also keep its traceback.

Please Refer PEP3134 for more details.

Change-Id: I420399061de89b911cecd5da60fde0023f1893ac

11 years agoRefactor get_mic_binpath() to avoid catch all exceptions.
Huang Hao [Wed, 6 Mar 2013 06:05:20 +0000 (14:05 +0800)]
Refactor get_mic_binpath() to avoid catch all exceptions.

Catch the specific exceptions it cares about, and reduce "try"
block to minimal, otherwise some other errors will be hidden.

Change-Id: Icbef03eef1591ba44466d5634943db5b8c86bdc4

11 years agoUniform import statements to absolute import.
Huang Hao [Thu, 28 Feb 2013 06:22:33 +0000 (14:22 +0800)]
Uniform import statements to absolute import.

Change all relative imports into absolute since mixing them is bad.
Refer PEP8 for more details.

Change-Id: I39fdbe056cb0d76c5ed5812c4f69e74ce8837924

11 years agoMerge branch 'release-0.17' into devel
Gui Chen [Mon, 4 Mar 2013 02:21:53 +0000 (10:21 +0800)]
Merge branch 'release-0.17' into devel

11 years agobe compatible with python-zypp built with swig 2.0
Gui Chen [Sun, 3 Mar 2013 07:18:09 +0000 (15:18 +0800)]
be compatible with python-zypp built with swig 2.0

differences in python-zypp between swig 1.3 and swig 2.0 built
make the original code not work, this patch trys to fix this
compatiblity issue

Change-Id: Ie0a16182463886e9cf89f6fa1c63756e4d50c02d
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agoFix import error of kickstart.custom_commands
Huang Hao [Thu, 28 Feb 2013 06:06:02 +0000 (14:06 +0800)]
Fix import error of kickstart.custom_commands

Names listed in __all__ don't exist.

>>> from mic.kickstart.custom_commands import *
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'module' object has no attribute 'Mic_Desktop'

Change-Id: Ie9ea1cccacb5fb9faaabc1951c513425c377d549

11 years agobump up to release 0.17 0.17
Gui Chen [Thu, 28 Feb 2013 06:26:36 +0000 (14:26 +0800)]
bump up to release 0.17

Change-Id: I172034cdb2397059331e741f4aea8e1776b1f636
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agoKeep error info from exception URLGrabError.
Huang Hao [Thu, 28 Feb 2013 03:37:19 +0000 (11:37 +0800)]
Keep error info from exception URLGrabError.

The origianl URLGrabError exception contains useful information
describing detail of the error, such as errno and http error
code.

However in some situation it doesn't include url address. So append
it if not appear.

Examples of console output before:
    Error <creator>: URLGrabber error: https://xxxx
    Error <creator>: URLGrabber error: https://xxxx

We can't find out difference from those two message.
After:
    Error <creator>: [Errno 14] HTTP Error 401 : https://xxxx
    Error <creator>: [Errno 14] problem making ssl connection on https://xxxx

Change-Id: I3f153e4caf8bbfcbac56ca22118733de7c5a3e66

11 years agoGive reason when failed to load plugin module.
Huang Hao [Thu, 28 Feb 2013 05:41:35 +0000 (13:41 +0800)]
Give reason when failed to load plugin module.

It will be helpful to solve problems.

Change-Id: I02f36706c67cfb9fedc9029ea5a177aa85c2ac61

11 years agobump up to 0.17-rc1
Gui Chen [Wed, 27 Feb 2013 07:31:15 +0000 (15:31 +0800)]
bump up to 0.17-rc1

Change-Id: I1caaf24953b5f6650e02dca2a44dcf53106b79b2
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agoupdate changelog files
Gui Chen [Wed, 27 Feb 2013 06:59:00 +0000 (14:59 +0800)]
update changelog files

correct indent and update date

Change-Id: I76d193ddbb4a2556181ac40699138df8d0ef1867
Signed-off-by: Gui Chen <gui.chen@intel.com>
11 years agoFix bad indentations.
Huang Hao [Wed, 27 Feb 2013 07:10:35 +0000 (15:10 +0800)]
Fix bad indentations.

Change-Id: I6a1b15a130576c87a85db864ec3997b7c3005f05

11 years agoupdate depends for ubuntu
Gui Chen [Wed, 27 Feb 2013 05:58:42 +0000 (13:58 +0800)]
update depends for ubuntu

Change-Id: I7c213ffbb8d04f7c7dfac6d0c27be21e8e060908
Signed-off-by: Gui Chen <gui.chen@intel.com>