Lim DoHyung [Wed, 26 Oct 2016 10:55:57 +0000 (19:55 +0900)]
Implement showing PWA popup when site is visited over 3 times.
[Issue] N/A
[Problem] For popup could show condition that connecting over 3 count.
manifest have not site case, next patch I will update.
[Solution] I have extract frequency value in history DB,
and when value over 3 count, I could show popup.
[Verify] When 3 count connect, popup show and normal create shortcut.
Change-Id: I21ab0e32144207fe93c1a35d6dc2381d903c97a0
Signed-off-by: Lim DoHyung <delight.lim@samsung.com>
m.kawonczyk [Wed, 26 Oct 2016 13:05:53 +0000 (15:05 +0200)]
Dummy button should be invisible to accessibility
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2381
[Problem] Dummy button captures highlight while navigating on
web component.
[Solution] Change dummy button accessible role to REDUNDANT_
OBJECT and dissable option of being highlighted.
[Verify] Open browser, open accessibility. Try navigating
between browser elements (such us URI bar) and
webview.
Change-Id: Idf45a1b31795ef46558a13724dece6fe27abb742
HyeKyoung Hwang [Fri, 28 Oct 2016 08:16:55 +0000 (17:16 +0900)]
Fix the translation issue
Change-Id: I7750a5974f4fbacaea543ac11a789196d91c8550
Signed-off-by: HyeKyoung Hwang <cookie@samsung.com>
Kamil Nowac [Wed, 26 Oct 2016 06:57:26 +0000 (08:57 +0200)]
Fix checkbuttons in Settings
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2352
[Problem] Checkbuttons are not working properly
[Solution] Changed mechanics
[Verify] As in the issue
Change-Id: I218f6741644b0535286f0c2c5b4e40afd06f0056
HyeKyoung Hwang [Tue, 25 Oct 2016 07:34:46 +0000 (16:34 +0900)]
In the SecretMode tab gmail, naver.com can't log in
[ Problem]In the Secret Mode, gmail ,naver.com can't log in
[ Cause] In the SecretMode, ewk_cookie_manager_accept_policy_set() set
by EWK_COOKIE_ACCEPT_POLICY_NEVER
[ Soultion] In the Chrome Browser also accept the cookie by default.
So Chrome can log in the gmail
When the terminated the secret mode,
the Engine will be delete the cookie
Signed-off-by: HyeKyoung Hwang <cookie@samsung.com>
Change-Id: I64218c8ec7f65b68f4538e76884e021d46f64e45
Signed-off-by: HyeKyoung Hwang <cookie@samsung.com>
Dariusz Frankiewicz [Wed, 26 Oct 2016 09:13:16 +0000 (11:13 +0200)]
Fix problem with https sites in QuickAccess
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2373
[Problem] Https sites added to QuickAccess have bad url.
[Cause] Bad string compare.
[Solution] Fix string compare.
[Verify] Add some https pages to QuickAccess and next try to load them.
Change-Id: I524e562651f890d5deb3a57d2d3164d639f214ac
Kamil Nowac [Mon, 24 Oct 2016 06:58:46 +0000 (08:58 +0200)]
Blank page after removal of the tab
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2328
[Problem] As in the issue
[Solution] Added signal
[Verify] As in the issue
After return to the webview page should not be blank
Change-Id: Ib0f108f59096d9458c18c2a59484239bc034325d
Maciej Skrzypkowski [Wed, 26 Oct 2016 07:23:16 +0000 (09:23 +0200)]
fixup! QuickAccess fixes and refactoring - rotation
Corrected rotation, page switched to quick access view
from most visited while rotating device.
Change-Id: Ida1806d31ce27aad87490d8aa8c83c3acc7db92f
min7.choi [Wed, 26 Oct 2016 03:39:06 +0000 (12:39 +0900)]
Add download popup for bt tethering state
Change-Id: I5269f0c42a73e81434b074dce719b806ae747ff2
Signed-off-by: min7.choi <min7.choi@samsung.com>
HyeKyoung Hwang [Tue, 25 Oct 2016 04:42:37 +0000 (13:42 +0900)]
[ PWA ] Launching according to manifest properties
Change-Id: Ie8f77f740936df069f85e51063b7d1bacd826791
Signed-off-by: HyeKyoung Hwang <cookie@samsung.com>
Maciej Skrzypkowski [Tue, 25 Oct 2016 11:36:52 +0000 (13:36 +0200)]
Download files in secret mode
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2348
[Problem] In secret mode there was no download callback connected
to the context.
[Solution] Added connection in WebEngineService::addTab
[Verify] Open tab in secret mode go to page www.google.com/imghp
search for some images, press long on image,
choose "save to disk", check if file is downloaded on the disk
Change-Id: I03a98c34ee467d8b356afd8561b740529903d97d
m.kawonczyk [Mon, 24 Oct 2016 10:11:28 +0000 (12:11 +0200)]
fixup! QuickAccess fixes and refactoring - index
Added Index to the bottom of the View.
Change-Id: Ifd3847ad94fb927a771ae0c4a057278b56a2a7aa
m.kawonczyk [Mon, 24 Oct 2016 08:24:22 +0000 (10:24 +0200)]
SIP is displayed when tried to scroll down webpage after loading
[Issue] http://suprem.sec.samsung.net/jira/browse/TSAM-6900
[Problem] Dummy button was not focused on load finish.
[Solution] Focus dummy button in addition to webview after load finish.
[Verify] Open browser, go to PC version naver.com. Reload page. Try
scrolling down. SIP should not be displayed.
Change-Id: I98aeae5769399e742d4e078f7d489e01345e62ec
m.kawonczyk [Tue, 25 Oct 2016 11:14:03 +0000 (13:14 +0200)]
Dummy Button was focused in QuickAccess
[Issue] N/A
[Problem] Dummy button was focused in QuickAccess.
[Solution] Disable Dummy button in QuickAccess.
[Verify] Open browser, go to website. Check if dummy button
is working properly. Go to QuickAccess. Check if
dummy button is focused and unfocused (logs).
Change-Id: Iced1a3d88bc83054134d26bdd8086423eb74ef0d
Dariusz Frankiewicz [Fri, 21 Oct 2016 09:48:40 +0000 (11:48 +0200)]
Add new style for QuickAccess button ADD
[Issue] N/A
[Problem] Bad style for ADD QuickAccess button
[Solution] Implement new style
Change-Id: I2622ffaf744e97bb1da25a9987fd296d6f9f1159
Kamil Nowac [Mon, 24 Oct 2016 10:16:45 +0000 (12:16 +0200)]
Fix APP_CONTROL_OPERATION_SEARCH
[Issue] http://suprem.sec.samsung.net/jira/browse/TSAM-9176
[Problem] Open blank page
[Solution] Change behaviour for operation search
[Verify] As in the issue
Change-Id: Ia5a62f0d05157c9523d3b79fc74d10df6d7a3bf1
Dariusz Frankiewicz [Thu, 20 Oct 2016 07:33:29 +0000 (09:33 +0200)]
Implement QuickAccess favicons from database
[Issue] N/A
[Problem] QuickAccess favicons are not working.
[Solution] Add storing favicons in database.
[Verify] Try add some pages to quickaccess and check if they have favicons.
Change-Id: Id8f3920283678998f264d5684ac62bdd3cc28de5
Kamil Nowac [Mon, 24 Oct 2016 13:31:59 +0000 (15:31 +0200)]
Always go to the PWA webview
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2330
[Problem] Does not go always to the webpageui
[Solution] Added condition
[Verify] The browser app -> Tab Manager window -> Home Key ->
Launch PWA
View should open in WebPageUI and not in tab manager
view.
Change-Id: I94e7f1f9257f82c411a0fb4c773e148197b2f016
Dariusz Frankiewicz [Mon, 24 Oct 2016 13:09:29 +0000 (15:09 +0200)]
Fix crash while deleting QuickAccess items
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2342
[Problem] While we try to delete QuickAcces items browser crash.
[Verify] Open QuickAccess edit mode and try to delete some items.
Change-Id: Idbec282c004474e8d14212f04e187002e5a784b6
Lim DoHyung [Wed, 19 Oct 2016 07:39:12 +0000 (16:39 +0900)]
2nd PWA code added. icon download logic and libsoup using make to shortcut..
Change-Id: Iccc93caee38320d5e12887be09fae1c28c0d3091
Signed-off-by: Lim DoHyung <delight.lim@samsung.com>
Kamil Nowac [Thu, 20 Oct 2016 10:34:18 +0000 (12:34 +0200)]
Open PWA as Secret tab
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2330
[Problem] PWA are not separated from normal tabs
[Solution] Changed state of the pwa
[Verify] 1. Open normal browser with a tab
tab should be stored normally
2. Press home, and open pwa
pwa should be stored with secret mode tabs
3. press home and open browser with browser icon
pwa should not be visible as normal tab
4. kill browser with task manager
open browser normally -> tabs should be restored
open pwa -> only opened tab should be in tabs manager
[Remarks] pwa must not be in fullscreen display mode to test it
Change-Id: I62469a518d48ba60a05cc00cfe28e3b772b2e917
Kamil Nowac [Fri, 21 Oct 2016 10:00:41 +0000 (12:00 +0200)]
Bring back arrow icons in History
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2343
[Problem] No icons, to much removed files in
https://review.tizen.org/gerrit/#/c/91026/2
[Solution] Restored edc files
[Verify] As in the issue
Change-Id: I113bdfe832c0de77aaa4e530d0e64a3a21988ed1
m.kawonczyk [Wed, 19 Oct 2016 14:16:52 +0000 (16:16 +0200)]
QuickAccess fixes and refactoring
[Issue] N/A
[Problem] QuickAccess was wrongly managed - too many database queries.
[Solution] Refactoring.
[Verify] Open browser, go to QuickAccess, rotate in most visited and
quick access. Go to EditQuickAccess and DeleteMostVisited,
try rotating. Go back to QuickAccess and MostVisited,
check if everything works as intended.
Change-Id: I46770b970fa7da704d4d31426ee5e45b0765881a
Kamil Nowac [Wed, 19 Oct 2016 12:34:06 +0000 (14:34 +0200)]
Fix PWA launching
[Issue] N/A
[Problem] PWA launch to the quick access
[Solution] Moved function
[Verify] Launch pwa from the shortcut
App should launch in the main screen
Change-Id: Ica42e2e2bb4badee4a8bfb096b4cb1ce18fef826
Maciej Skrzypkowski [Tue, 18 Oct 2016 07:44:39 +0000 (09:44 +0200)]
Certificate popup landscape - proper size
[Issue] http://suprem.sec.samsung.net/jira/browse/TSAM-8772
http://suprem.sec.samsung.net/jira/browse/TSAM-8776
[Problem] Certificate didn't resize properly.
[Solution] Corrected EDC relatives.
[Verify] Open certifiacate popup in portrait, rotate, rotate
again. Browser shouldn't crash, certifiacate should
close on "OK" click and resize properly.
The same repeat for landscape view.
Change-Id: Ia5fa3d91352542705f0762c407a54787c13d8b80
Kamil Nowac [Mon, 17 Oct 2016 10:53:32 +0000 (12:53 +0200)]
Find on page does not open after tab close
[Issue] N/A
[Problem] Signals are not disconnected on tab close
[Solution] Disconnect signals on tab closing
[Verify] 1. Open any page
2. Select word and open find on page from
context menu
-> Find on page should open
3. Go to tabs manager and close tab
4. Repeat steps 1 and 2
-> Find on page should open
Change-Id: I462177d564e65e025b103389c9b417dfc18de2af
Kamil Nowac [Tue, 18 Oct 2016 07:17:38 +0000 (09:17 +0200)]
Buildbreak fix for PWA
[Issue] N/A
[Problem] Build break
[Solution] added mutable keyword in lambda,
old ewk api usage removed, removed function
[Verify] Browser should build with PWA flag
Change-Id: I134a8adeb98de269d7aafcfd2752344fabe1d94b
m.kawonczyk [Thu, 13 Oct 2016 13:46:54 +0000 (15:46 +0200)]
Menu Tree fixes
[Issue] N/A
[Problem] Wrong texts.
[Solution] Change text.
[Verify] Open browser, go to bookmarks, press menu, create folder.
Cancel/Create button should be visible. Go to share,
Cancel/Done should be visible on Naviframe. Go to History,
Menu key, Remove. Cancel/Done should be visible on
Naviframe.
Change-Id: I0aaff1197fcea818c26c11e434837c3c783e0f12
Dariusz Frankiewicz [Wed, 5 Oct 2016 14:38:34 +0000 (16:38 +0200)]
QuickAccess database implementation
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2246
[Problem] QuickAccess used bookmarks instead of it's own elements.
[Solution] Implement QuickAccess database and switch bindings from
bookmarks to new mechanism.
[Verify] Try to add and delete some QuickAccess items.
Change-Id: I3e115cf1f840540519ceac5579b047fcca0d79e1
Signed-off-by: Dariusz Frankiewicz <d.frankiewic@samsung.com>
m.kawonczyk [Fri, 14 Oct 2016 13:49:28 +0000 (15:49 +0200)]
QuickAccessEdit mode white background.
[Issue] N/A
[Problem] There was no background under gengrids.
[Solution] Add white background.
[Verify] Open browser, go to QuickAccessEdit. There
should be white background.
Change-Id: Ic94bd4839f15bc11306021d0dcdc0b2fca8e22d3
Kamil Nowac [Fri, 14 Oct 2016 10:34:12 +0000 (12:34 +0200)]
Fix menu tree in settings
[Issue] N/A
[Problem] Some thinks does not match menu tree tests
[Solution] Added translations, modified Autofill forms
[Verify] Menu tree in settings should match tests
Change-Id: Ifd8d7cbf20d8de75a9afd10144fc69ad4d61daae
m.kawonczyk [Wed, 12 Oct 2016 12:11:00 +0000 (14:11 +0200)]
Indicator and Notification bar not visible.
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2245
[Problem] Indicator with background wasn't visible.
[Solution] Created custom conformant that enables visible bg
in scrollable indicator mode. Added background.
[Verify] Open browser, try showing indicator (scroll down
on top of the browser). Indicator should become
visible. Scroll down again. Notification bar should
become visible.
Change-Id: Idde83c578c32b84c7ec11341058f5456c82049aa
HyeKyoung Hwang [Thu, 13 Oct 2016 09:26:19 +0000 (18:26 +0900)]
Text selection back key issue
[Issue] http://suprem.sec.samsung.net/jira/browse/TSAM-8681
[Problem] When the Back key twice select, ewk_view_text_selection_clear(m_ewkView); is return True even if the text selection was removed as to first back key
[Solution] The text selection is clear by webview
Change-Id: Id027fcb5790e530641c556889ef2639789a30bee
Signed-off-by: HyeKyoung Hwang <cookie@samsung.com>
Maciej Skrzypkowski [Wed, 12 Oct 2016 14:05:39 +0000 (16:05 +0200)]
Switch WebPageUI to QuickAccess if there is no tabs
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2275
[Problem] After closing all tabs and pressing back key
empty web page was shown.
[Solution] Switch to QuickAccess and update tabs number
on tab close.
[Verify] Open few tabs, clase them, press back key
QuickAccess should be opened, tabs number should
be proper.
Change-Id: I54e45a79a010140d5abb46130771aea526425b91
HyeKyoung Hwang [Wed, 12 Oct 2016 02:27:44 +0000 (11:27 +0900)]
Change the chromium-efl ewk_header
Change-Id: Ie65399c25cf25cb8e665ed43d738c221ff9b73cd
Signed-off-by: HyeKyoung Hwang <cookie@samsung.com>
m.kawonczyk [Tue, 11 Oct 2016 10:02:32 +0000 (12:02 +0200)]
Flushing memory after changing views
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2192
[Problem] Memory in cache was not flushed after being used.
[Solution] Flush cache when view is changed.
[Verify] Browser should work as normal. Memory usage should
lower.
Change-Id: I82434b765f4539b01ed070c64d8b748e7a999c0a
Maciej Skrzypkowski [Wed, 12 Oct 2016 07:49:51 +0000 (09:49 +0200)]
Removed improper usage of shared_ptr
[Issue] N/A
[Problem] Shared_ptr to this.
[Solution] Changed to raw pointer.
[Verify] Open an close few tabs.
Change-Id: Idb0a056c51322bb6569303cd18c1d6856353defd
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Wed, 12 Oct 2016 07:25:17 +0000 (09:25 +0200)]
fixup! Prevent memory leaks in settings and view manager
Change-Id: I1b45f15e922f464641f80a9641858fc13efdd309
Kamil Nowac [Fri, 7 Oct 2016 08:22:54 +0000 (10:22 +0200)]
Performance optimisation
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2109
[Problem] Slow launching time
[Solution] Service initialization moved afer resume callback
[Verify] Open browser. Time between first log and
resume event should be much lower than before.
Change-Id: Iab6e69844de0199bb85b810cebfe8c7d9403d99a
Maciej Skrzypkowski [Tue, 11 Oct 2016 08:57:24 +0000 (10:57 +0200)]
Prevent from connecting multiple identical signals in WebEngine
[Issue] N/A
[Problem] There was multiple connection of the same signals
which caused calling many times callbacks like
loadFinished.
[Solution] Removed connecting signals again in SimpleUI,
added check in WebEngine. Additional refactoring
in SimpleUI to simplify opening URLs and
closing views.
[Verify] Open web page, check if loadFinish, loadStop, reload,
loadStarted singals are called once during page load.
Open diffrent views and close them, browser should
work fine.
Change-Id: I744616432a8c225a5fe96f98de687a6322e9b34f
Kamil Nowac [Mon, 10 Oct 2016 06:53:11 +0000 (08:53 +0200)]
Find on page does not hide on fullscreen
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2257
[Problem] As in the title
[Solution] Added signal
[Verify] - Open youtube.com. open find on page. go to fullscreen
in portrait mode. rotate while in fullscreen to
landscape mode.
find on page should not be visible.
- turn off fullscreen mode
find on page should be visible
Change-Id: Ic6a3295ac11811fc6f2e45e5a4b30c2c51e6eb4d
Maciej Skrzypkowski [Fri, 7 Oct 2016 13:39:34 +0000 (15:39 +0200)]
Prevent small swipe gestures in TabUI
[Issue] N/A
[Problem] Sometimes clicks on tabs in TabUI were detected
as swipe gestures and tabs were deleted.
[Solution] Added additonal swipe thresholds.
[Verify] Add few tabs, check if they are deleted while
clicking and scrolling up/down, check if
swipe left/right deletes them.
Change-Id: Ib5f4d8ee868097c631ca7543b878fa0dc0e3378f
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
m.kawonczyk [Thu, 6 Oct 2016 13:44:26 +0000 (15:44 +0200)]
Prevent memory leaks in NaviframeWrapper. Remove unneded TabUI filling.
[Issue] N/A
[Problem] Evas objects where not properly deleted. TabUI was filled
twice.
[Solution] Delete evas objects.
[Verify] Browser should work as usual
Change-Id: I6a306cbdf8f4a94cab6c8b40a1ad97ded924af87
Kamil Nowac [Wed, 5 Oct 2016 08:10:49 +0000 (10:10 +0200)]
Prevent memory leaks in settings and view manager
[Issue] N/A
[Problem] Not deleted objects and no smart pointers
[Solution] Delete objects and add smart pointers
[Verify] Browser should work as usual
Change-Id: Ic432bdbd971fbac366d4fe6ae6a6442965597d52
Maciej Skrzypkowski [Wed, 5 Oct 2016 13:51:31 +0000 (15:51 +0200)]
SimpleUI::rotationType memory leak corrected
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2192
[Problem] Undeleted alocated memory
[Solution] Changed to simple variable
[Verify] Run and rotate device
Change-Id: I703960cc863b8704c72896c899df7dcb65a2ec4e
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
HyeKyoung Hwang [Fri, 7 Oct 2016 01:36:38 +0000 (10:36 +0900)]
screen not staying alive while video is playing in fullscreen after 15 secs
[ Problem ]http://suprem.sec.samsung.net/jira/browse/TSAM-6875
[ Soultion]There is no <privilege>http://tizen.org/privilege/display</privilege> So add the privilege
[ Verify ] Check the youtube.com
Change-Id: I53311aa5e57cf97f56532e69a7b5c24d586b3abd
Signed-off-by: HyeKyoung Hwang <cookie@samsung.com>
m.kawonczyk [Wed, 5 Oct 2016 10:07:25 +0000 (12:07 +0200)]
Remove unused files and edc
[Issue] N/A
[Problem] Those classes are unused.
[Solution] Removed.
[Verify] Build and run.
Change-Id: Ia3d7f100698b07337b1b8fa7299d6e86d88a3cee
Maciej Skrzypkowski [Tue, 4 Oct 2016 14:06:30 +0000 (16:06 +0200)]
Remove unused classes
[Issue] N/A
[Problem] Those classes are unused.
[Solution] Removed.
[Verify] Build and run.
Change-Id: I9f347a5e3d42294cbf75079eccd26a3b285dc61d
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Kamil Nowac [Fri, 30 Sep 2016 12:49:21 +0000 (14:49 +0200)]
Refactor popups to use the default API
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2231
[Problem] We do not use default styles
[Solution] Refactoring in popups
[Verify] Test popups described in the Issue
Popups should use default styles
Change-Id: If973eb4cfdc59cd2deda71ff8fcd5f8851a936c9
Maciej Skrzypkowski [Tue, 4 Oct 2016 08:52:40 +0000 (10:52 +0200)]
Revert deleting webview title callback
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2242
[Problem] Title was not changed
[Solution] Reverted mistakenly deleted callback in WebView
[Verify] Open few tabs, check their titles in tab manager.
Check if proper title is set while adding bookmark.
Change-Id: Idecf175f502c8fa47610a044cb847bff1a3b90f8
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Dariusz Frankiewicz [Mon, 3 Oct 2016 13:45:03 +0000 (15:45 +0200)]
Disable "Add to Quick Access" option when page already exist on QA list.
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2088
[Problem] More menu option "Add to Quick Access" is always available,
even if page exist already in Quick Access.
[Solution] Show option only when page is not in Quick Access list.
[Verify] Open more menu on some page which is already in Quick Access
and check if option "Add to Quick Access" is hidden.
Change-Id: I71c617a4d3786ed8c7c28d69a0bff66a96e8f269
Dariusz Frankiewicz [Wed, 28 Sep 2016 14:20:12 +0000 (16:20 +0200)]
Most visited delete mode implementation
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2115
[Problem] Most visited delete mode is not implemented.
[Solution] Implement delete mode.
[Verify] Open most visited delet mode and check if it works correctly.
Change-Id: I9a423e7805c7e912ac65373e14f4af7493fb2172
m.kawonczyk [Mon, 3 Oct 2016 08:32:43 +0000 (10:32 +0200)]
The dummy button
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2222
[Problem] The dummy button is needed by webview for focus
managment.
[Solution] Add #ifdefed the dummy button feature.
[Verify] Open any webpage, dlogutil browser. Check if the
dummy button is properly focused/unfocused and if
webview focus is ok.
Change-Id: Ibc434ae269f8233c84ae0bcb1115ca2c76657cbb
Maciej Skrzypkowski [Mon, 3 Oct 2016 12:29:55 +0000 (14:29 +0200)]
Removed wrong used shared_ptrs
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2227
[Problem] Shared pointers maintained memory which was not owned
by them.
[Solution] Removed wrong usage.
[Verify] Add few bookmarks, check if browser crashes. Previously
it crashed in second try.
Change-Id: I86b14fac31d2af9ccc99e2bea209df9a1c63f4f4
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Mon, 3 Oct 2016 08:57:59 +0000 (10:57 +0200)]
Dimmed backward and forward buttons
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2215
[Problem] Buttons were not dimmed when there was no backward or
forward page
[Solution] Added new buttons color, added coloring buttons
based on viewed screen
[Verify] Open webpage, check buttons, go to another page
backward button should become active. Switch to
other tab, switch to secret mode, check if
buttons activate and deactivate properly.
Change-Id: I482ffb3786a7ca2aebaaaa47192190d680c643c1
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
m.kawonczyk [Fri, 30 Sep 2016 09:25:42 +0000 (11:25 +0200)]
White patch is displayed while rotating device
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2216
[Problem] White patch is displayed while rotating device
[Solution] Manually invoke rotation when browsing websites when
browser receives "rotate,prepared" callback from
webview.
[Verify] Open any website, rotate device. Rotation should be
smooth. Then use other views and check if rotations
works as intended.
Change-Id: I66ae5684ae70f51dc1e40da556930abb39e24ad4
m.kawonczyk [Wed, 28 Sep 2016 09:56:12 +0000 (11:56 +0200)]
Open the new window -> Back key. WebView is not visible
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2170
[Problem] WebView isnt visible when you open new window and
press back key.
[Solution] Call SwitchViewToWebPage when tab was closed.
[Verify] Open google.com, wait untill website is fully loaded.
Longpress on any link, click open in new tab. Press
back button. Google should be visible.
Change-Id: Ifd511a7523ba3c424c210ccfd6843c0089f6daab
m.kawonczyk [Fri, 30 Sep 2016 07:35:57 +0000 (09:35 +0200)]
Bookmarks -> Share is not working
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2078
[Problem] Share in Bookmarks Manager is not working.
[Solution] Added Share functionality.
[Verify] Try Sharing bookmark.
Change-Id: Ia7a289ba3f5b66eef03b923c63536774d5e4d3ad
Kamil Nowac [Wed, 28 Sep 2016 08:18:12 +0000 (10:18 +0200)]
Add User Agent selection
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2203
[Problem] User Agent selection needed for testing
[Solution] Added view
[Verify] Settings->Developer mode->Select user agent
User agent string should change
Change-Id: Ia2bf5b43525e0a7588bd489515117cb92b9ff3f9
Maciej Skrzypkowski [Wed, 28 Sep 2016 14:27:25 +0000 (16:27 +0200)]
Quick Access button
[Issue] N/A
[Problem] Wrong style of QA button
[Solution] Add new button style
[Verify] Open quick access, add few sites, check if it's
equal to guidelines.
Change-Id: I6540884a26fda80b27c52447cf78316c033892f9
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Kamil Nowac [Tue, 27 Sep 2016 06:04:28 +0000 (08:04 +0200)]
Fix potential memory leaks and little refactoring
[Issue] N/A
[Problem] Potential memory leaks
[Solution] Use smart pointers and free objects allocated
with operator new
[Verify] Build browser. Browser should work normally.
Change-Id: Iaca59983481ce993abe7ccf7639c08d56f63d573
Kamil Nowac [Mon, 19 Sep 2016 13:46:40 +0000 (15:46 +0200)]
Refactoring and optimization
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2109
[Problem] Too slow loading time
[Solution] Refactoring
[Verify] Open dlogutil. Open browser.
Time between the first browser log and
app_resume log should be shorter than
without this change.
Change-Id: I57439f0959efbfc06910b6f3a7abe33b90b3633e
Lim DoHyung [Mon, 26 Sep 2016 04:03:45 +0000 (13:03 +0900)]
PWA useless function and logic modify to browser code.
Change-Id: I8e164705a1825e51bf26a9a03be2f7db9b98bcac
Signed-off-by: Lim DoHyung <delight.lim@samsung.com>
m.kawonczyk [Fri, 23 Sep 2016 12:59:17 +0000 (14:59 +0200)]
Restore focus to ewk_view on load,finished
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2190
[Problem] WebView is not getting focus by default after
application start.
[Solution] Call ewk_view_focus_set on load,finish callback
[Verify] Open google.com, wait untill website is fully loaded.
Cursor should be visible in google entry.
Change-Id: I04c6b79125c0b46b42c64621402436a4f438131a
Dariusz Frankiewicz [Thu, 22 Sep 2016 11:44:53 +0000 (13:44 +0200)]
Ifdef remaining PWA code.
Change-Id: I4fbd3889f729d3eaa4dca982beec3fa2f7370904
Maciej Skrzypkowski [Wed, 21 Sep 2016 10:15:25 +0000 (12:15 +0200)]
Secret mode - colors of toolbar buttons
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-1897
[Problem] There was no bright color of icons for secret mode
[Solution] Added ToolbarButton which has proper
states for secret and normal mode
[Verify] Switch between secret and normal mode,
check if icons on main page change.
Change-Id: Ie84d85c882e4d3ec7683b19d5482b2ba141027a7
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Kamil Nowac [Wed, 21 Sep 2016 13:25:08 +0000 (15:25 +0200)]
Autofill profile does not update on creation and on reset
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2046
[Problem] As in the title
[Solution] Added signal
[Verify] Create profile ->
Profile name should be updated
Reset autofill data ->
Profile name should be updated and
all fields of form should be cleared
Change-Id: I31786adf0a0c444c2d6459485959e8c66123cf91
Dariusz Frankiewicz [Tue, 20 Sep 2016 12:28:31 +0000 (14:28 +0200)]
QuickAccess edit mode implementation
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2102
http://suprem.sec.samsung.net/jira/browse/TWF-2117
[Problem] Editing quick access wasn't implemented.
[Solution] Implement edit mode and fix problem with X button.
[Verify] Open quick access edit from more menu and try to
delete some items.
Change-Id: I61990ecd076c19ad8f013fb02d9422b6a092dac4
Kamil Nowac [Tue, 13 Sep 2016 08:56:06 +0000 (10:56 +0200)]
Fix MoreMenu options for QuickAccess and MostVisited
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2105
[Problem] Bad options in context menu
[Solution] Removed bad options, added new ones
[Verify] Open QuickAccess/MostVisited and press more menu
Options should match guidelines
Change-Id: I94cdaeeb3b26b147ddf700f8dd6a2a40d7962aa3
Lim DoHyung [Mon, 19 Sep 2016 10:48:19 +0000 (19:48 +0900)]
1st PWA shortcut create logic added.
Change-Id: I05bc23183397dc1adb04616811b9d9a387100d28
Signed-off-by: Lim DoHyung <delight.lim@samsung.com>
Maciej Skrzypkowski [Tue, 20 Sep 2016 08:50:31 +0000 (10:50 +0200)]
Merge branch 'tizen' into newux_tizen
Change-Id: I660eddacbf8bdaa7a1d442f8e951bf4cbacca721
Kamil Nowac [Wed, 14 Sep 2016 13:37:09 +0000 (15:37 +0200)]
Add favicon to tabs
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-1870
[Problem] No favicons in tabs
[Solution] Added saving tabs to database
[Verify] Open few tabs with opened pages
tabs should have favicons in upper right corner
Change-Id: I67a8ae334cc7c823f5ac66376fefd619e9a83524
HyeKyoung Hwang [Tue, 20 Sep 2016 01:14:09 +0000 (10:14 +0900)]
Remove the Manager website data
[ Problem] http://suprem.sec.samsung.net/jira/browse/TWF-2106
[ Solution] Don't supprt the Manager website data so remove it
[ Verify] Check it in the Setting menu
Change-Id: Ie38fe2ad1c318d492b01caae93bbaf546cbb30df
Signed-off-by: HyeKyoung Hwang <cookie@samsung.com>
HyeKyoung Hwang [Tue, 13 Sep 2016 09:18:56 +0000 (18:18 +0900)]
Context menu issue
[ Issue ] http://suprem.sec.samsung.net/jira/browse/TWF-2110
[ Problem ] There is different the UX Guide
Change-Id: I905e6fe5334710370904965b409604df9ad0bd46
Signed-off-by: HyeKyoung Hwang <cookie@samsung.com>
HyeKyoung Hwang [Mon, 19 Sep 2016 07:22:56 +0000 (16:22 +0900)]
Remove the settings->Privacy ->suggestion list
[ Problem ] http://suprem.sec.samsung.net/jira/browse/TWF-2106
Settings Suggestion list is not working
[Soultion] It don't support it so remove it
Change-Id: I7934a8f8847246f0ca49c6909e76633946f78dd5
Signed-off-by: HyeKyoung Hwang <cookie@samsung.com>
m.kawonczyk [Fri, 16 Sep 2016 14:14:44 +0000 (16:14 +0200)]
Tabs -> remove Sync open page from menu option
[Issue] N/A
[Problem] Sync open page option was visible after menu key
[Solution] Remove it.
[Verify] Open TabUI, press menu. Sync open page should not be
visible.
Change-Id: If6cd46e2a3eaf95c14b408c3b359754bade4e974
m.kawonczyk [Mon, 1 Aug 2016 08:25:16 +0000 (10:25 +0200)]
[Cherry-pick] Improve performance
[Issue] N/A
[Problem] Performance slowed down by 100ms.
[Solution] Moved initialization of the download control to the
lazy loading function.
[Verify] Open browser and dlogutil. Check it time is improved
and if download is working as intended.
Change-Id: Id3c898f7e2e489e26f0acae4e1f59def8f2fb64b
Kamil Nowac [Thu, 15 Sep 2016 06:24:54 +0000 (08:24 +0200)]
Add toast popup on bookmark removal
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-1839
[Problem] No toast popup informing about bookmark deletion
[Solution] Added popup
[Verify] Add bookmark and remove it
Poopup should be shown
Change-Id: I4d41b8b50a93d99254c4e46ba0ad74460e095595
Kamil Nowac [Thu, 15 Sep 2016 13:06:53 +0000 (15:06 +0200)]
Fix swapped autofill forms fields for new ui
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2112
[Problem] Swapped fields
[Solution] Replaced functions
[Verify] As in the issue
Change-Id: I56ac5506eca020a189093a84bb62be25eb154125
Maciej Skrzypkowski [Thu, 15 Sep 2016 09:04:57 +0000 (11:04 +0200)]
Secret mode initial popup
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-1897
[Problem] There was no popup when first time secret mode wihout
password chosen
[Solution] Added popup
[Verify] delete /home/owner/apps_rw/org.tizen.browser/data/.browser.settings.db
open browser, set secret mode without password, popup should be shown
Change-Id: Icb6d10c87fd42815b680dbd8e02f445b1b9551d3
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Kamil Nowac [Mon, 12 Sep 2016 13:11:42 +0000 (15:11 +0200)]
Further improvements in autofill forms
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2046
[Problem] Profile name was not updated
[Solution] Changed the way of getting the id, and
added variable for actual name
[Verify] Add autofill profile and save it
It should be visible in the list
and should be editable
Change-Id: I651e88e6292dc93e969a8690a75a59d225ffa1f0
Maciej Skrzypkowski [Thu, 15 Sep 2016 06:53:05 +0000 (08:53 +0200)]
Hide history in secret mode
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2107
[Problem] In Bookmarks view toolbar wasn't hide for secret mode.
[Solution] Added hiding of toolbar
[Verify] Open bookmarks in secret and normal mode, check if toolbar
is properly hidden
Change-Id: I1ae6bef53733bcfc468b65fb31777c2d4b43fb67
Signed-off-by: Maciej Skrzypkowski <m.skrzypkows@samsung.com>
Maciej Skrzypkowski [Wed, 14 Sep 2016 10:28:25 +0000 (12:28 +0200)]
Secret Mode password verification
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-1897
[Problem] There was no option to enter secret mode with password.
[Solution] Added password confirmation and modify options.
[Verify] Browser->Tabs->Enable Secret->Set passowrd
exit secret mode and enter again with password
In Tabs open Secret mode security option from context menu,
try changing and turning off password, try turning password
again on, check Enable secret option without password
Change-Id: If05fd27b59460e78f8340ae3427ecb5a5d19b82b
m.kawonczyk [Thu, 8 Sep 2016 13:05:59 +0000 (15:05 +0200)]
The Dummy Button removal
[Issue] N/A
[Problem] WebView team managed to extract Evas_Object from
ewk_view smart object. This object can be focused
and unfocused, so The Dummy Button - proxy widget is
not needed anymore
[Solution] Delete The Dummy Button, add support for extracted
Evas_Object.
[Verify] Open any website, check if focus is working as
intended.
Change-Id: Ie2ea78ce536aebb64d802401ae767d672544a70c
Kamil Nowac [Tue, 13 Sep 2016 07:33:56 +0000 (09:33 +0200)]
Fix save content on sd card removal
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2108
[Problem] Popup does not close
[Solution] Close popup on sdcard removal signal
Disable option on genlist population
[Verify] Open save content popup -> remove sd card
Popup should close
Change-Id: I83280a4ff5b85ef1a10ff874d039d21befe4cb68
Kamil Nowac [Thu, 8 Sep 2016 12:06:37 +0000 (14:06 +0200)]
Hide UI when in fullscreen mode
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2076
[Problem] UI visible in fullscreen mode
[Solution] Hide UI
[Verify] Open any movie on youtube in fullscreen mode
UI should hide.
Change-Id: Ie0598ca9e45dacc1c0ca5cf3e5dc3e0846a6657b
Dariusz Frankiewicz [Mon, 12 Sep 2016 13:59:46 +0000 (15:59 +0200)]
Add http prefix to quickaccess url and remove it from title.
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2098
[Problem] Manually added url without http prefix cannot be loaded.
[Solution] Add http prefix to url in quickaccess. Also removed this
prefix from label on quickaccess items.
[Verify] Add some page witout http and try to load it.
Change-Id: I9d1e50799d296a0c24e9d99240ca75d5a5d3a3e5
Kamil Nowac [Fri, 9 Sep 2016 07:56:46 +0000 (09:56 +0200)]
Fix current page selection in Settings Homepage
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2079
[Problem] As in the task
[Solution] Added comparison between current page and selected
[Verify] Settings -> Homepage -> Select the Current page ->
-> Back key -> Homepage
Current page should be selected
Change-Id: I8dd37678bd9c529ca0b13f330e7571f2422c4605
Kamil Nowac [Fri, 9 Sep 2016 09:26:51 +0000 (11:26 +0200)]
Fix opening of the new page
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2077
[Problem] Always goes to quick access
[Solution] open page based on selected homepage
[Verify] Select options from Settings Homepage ->
Open new tab.
Should open view according to the previous
selection
Change-Id: I607f82749d02216d961cf60ba74f6106438109e7
HyeKyoung Hwang [Mon, 12 Sep 2016 10:44:33 +0000 (19:44 +0900)]
Fix the tranlsation issue (po file)
[ Issue ] http://suprem.sec.samsung.net/jira/browse/TWF-209
[ Problem ] There is missing .po file, so it dislay by "IDS_"
Change-Id: I4b74865f8cdc2b8f97dfcdaac8afaed2d3d1a5e1
Signed-off-by: HyeKyoung Hwang <cookie@samsung.com>
Dariusz Frankiewicz [Mon, 5 Sep 2016 14:08:26 +0000 (16:08 +0200)]
Progressive web app launching mechanism
[Issue] N/A
[Problem] Not implemented PWA launching
[Solution] Implement launching browser when browser_shortcut:// url prefix
is passed by app_control. Implement PWA parameters parsing and
launching browser with fullscreen webpage and with locked rotation.
[Verify] Browser should launch by PWA shortct icon.
Change-Id: Ib4a95128ffd82cfa10358ad08dd9e102173a8867
HyeKyoung Hwang [Fri, 9 Sep 2016 09:53:43 +0000 (18:53 +0900)]
elm_access_info_set() is not public API.
So change to public API by elm_atspi_accessible_name_set
Change-Id: I79de78a6f8ff659bb079092982d2f7ad66c3b378
Signed-off-by: HyeKyoung Hwang <cookie@samsung.com>
Dariusz Frankiewicz [Thu, 8 Sep 2016 16:19:42 +0000 (18:19 +0200)]
Implement adding and editing quick access items.
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-1800
[Problem] There is no posiibility to add and edit quick access items.
[Solution] Implement missing functionallity.
[Verify] Try to add some quica acces items and remove them.
Change-Id: I8b1dc6a7a9125e2f1ff8190f1d7153101829edac
m.kawonczyk [Fri, 9 Sep 2016 07:33:20 +0000 (09:33 +0200)]
Add images needed for QuickAccess
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-1800
[Problem] There is no images needed by QuickAccess
[Solution] Add those images to images_mob folder
[Verify] Open QuickAccess, check if everything works as
intended.
Change-Id: I2db49051f0948c2501f7eeb94b2eedfe055b054e
Kamil Nowac [Wed, 7 Sep 2016 12:07:35 +0000 (14:07 +0200)]
Correct translation machanism in Settings
[Issue] N/A
[Problem] Bad mechanism
[Solution] Corrected mechanism
[Verify] Open settings. Homepage should be
translated.
Change-Id: I455cf3d54b1b04559cf7fb99efc87f516b7c25c2
Kamil Nowac [Wed, 7 Sep 2016 11:13:17 +0000 (13:13 +0200)]
Autofill create fix
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2046
[Problem] Not visible view
[Solution] Changed edj location and some other
small changes
[Verify] Go to the Autofill forms create list
It should be visible
Change-Id: Ie74430bef4a29d316c58becf20ddc4b541d02fe7
Kamil Nowac [Tue, 6 Sep 2016 13:29:33 +0000 (15:29 +0200)]
Hide bottom bar on IME open event
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-1799
[Problem] Bottom bar is always shown
[Solution] Added hide event
[Verify] Open IME -> bottom bar should be invisible
Close IME -> bottom bar should be visible
Change-Id: Id39347c0d0ba24920c758fcd2b9482956a93d9df
m.kawonczyk [Tue, 6 Sep 2016 08:05:48 +0000 (10:05 +0200)]
Tab Manager -> Close all is not working
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-2045
[Problem] Gengrid items where not deleted.
[Solution] Delete gengrid items, update gengrid.
[Verify] Open tabs, press close all.
Change-Id: Ia3ddbff7c70bcb224d68e15b19921dce8c3fbe99
m.kawonczyk [Mon, 5 Sep 2016 13:42:27 +0000 (15:42 +0200)]
[Porting_2.4_UI_to_3.0] TabUI - secret mode items style
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-1897
[Problem] Tab items didn't change colors when secret mode was
enabled.
[Solution] Add realized callback, added new descriptions in edc.
[Verify] Open tab manager in secret mode, add tabs. Check if
everything works as intended.
Change-Id: If29c50ee9d0036e6bcb7ea637ffc3a0473f6cced
Kamil Nowac [Wed, 31 Aug 2016 11:17:04 +0000 (13:17 +0200)]
Add naviframe-like style to Settings
[Issue] http://suprem.sec.samsung.net/jira/browse/TWF-1811
[Problem] Old style
[Solution] Added naviframe-like style
[Verify] Style should match guidelines
Change-Id: I62ae9859c1171e3e9eaca740b4e5d3a08e117a43