platform/core/security/webauthn.git
6 months agoRelease version 1.0.8 07/316207/1 accepted/tizen_7.0_unified accepted/tizen_8.0_unified accepted/tizen_9.0_unified accepted/tizen_unified accepted/tizen_unified_x accepted/tizen_unified_x_asan tizen_7.0 tizen_8.0 tizen_9.0 accepted/tizen/7.0/unified/20241213.012521 accepted/tizen/8.0/unified/20241217.171848 accepted/tizen/9.0/unified/20241212.163803 accepted/tizen/unified/20241212.185746 accepted/tizen/unified/x/20241218.032625 accepted/tizen/unified/x/asan/20241224.004349
Krzysztof Malysa [Tue, 10 Dec 2024 16:11:34 +0000 (17:11 +0100)]
Release version 1.0.8

Change-Id: Ie2e2294e11c2b4c05084235567cd960115f75266

6 months agoAdd test for buffer overflow 05/316205/3
Krzysztof Malysa [Wed, 11 Dec 2024 14:04:36 +0000 (15:04 +0100)]
Add test for buffer overflow

Change-Id: Iaeeb5cbfb4e73eb15c0c4f47a25d9e2a503c1bce

6 months agoFix buffer overflow in receving message from server 36/316136/2
Krzysztof Malysa [Tue, 10 Dec 2024 16:09:09 +0000 (17:09 +0100)]
Fix buffer overflow in receving message from server

Change-Id: I423599fdd9b1dde27335a9f87d65a85794c802e1

6 months agoRemove unnecessary shared_ptr 38/316038/1
Krzysztof Malysa [Mon, 9 Dec 2024 14:18:00 +0000 (15:18 +0100)]
Remove unnecessary shared_ptr

Change-Id: Iacd2ab49b089cd21c30d3f725b3966e15f901b94

6 months agoIncrease code coverage 58/320658/4
Jakub Wlostowski [Wed, 20 Nov 2024 10:58:29 +0000 (11:58 +0100)]
Increase code coverage

Change-Id: I5b5963b189c2b97e3699213bba6d540bebb3f717

6 months agoEnhance API descriptions 09/319209/5
Filip Skrzeczkowski [Thu, 17 Oct 2024 10:23:47 +0000 (12:23 +0200)]
Enhance API descriptions

Change-Id: I788d46c490f7851da5faf88212bd43d267beab75

6 months agoFix Jenkins tests classification 41/320341/1
Jakub Wlostowski [Wed, 13 Nov 2024 13:46:09 +0000 (14:46 +0100)]
Fix Jenkins tests classification

Change-Id: I7d1b72a9f5f8f44cd74ad1907781eb804bb0735b

7 months agoRelease version 1.0.7 88/319688/1 accepted/tizen/7.0/unified/20241111.164447 accepted/tizen/8.0/unified/20241111.162210 accepted/tizen/9.0/unified/20241112.020129 accepted/tizen/unified/20241105.042059
Krzysztof Jackiewicz [Wed, 30 Oct 2024 08:14:40 +0000 (09:14 +0100)]
Release version 1.0.7

Change-Id: I23260d87e335a26ef7652a311554f7e7ba0ee633

7 months agoFix use after free/realloc 98/319598/1
Krzysztof Jackiewicz [Mon, 28 Oct 2024 08:13:02 +0000 (09:13 +0100)]
Fix use after free/realloc

Change-Id: Ia1c287de4add32e372d7213f0abd656d7ddb8ba5

7 months agoRemove unused code 52/319152/1
Krzysztof Jackiewicz [Wed, 16 Oct 2024 07:27:56 +0000 (09:27 +0200)]
Remove unused code

Change-Id: I9a80b733501470176a65209dbae9e6f6f6dd42cd

7 months agoFix (mostly) UBSAN found issues 29/319129/1 accepted/tizen_unified_toolchain accepted/tizen/9.0/unified/20241030.234657 accepted/tizen/unified/20241016.160102 accepted/tizen/unified/toolchain/20241022.122433 accepted/tizen/unified/toolchain/20241022.122909 accepted/tizen/unified/x/20241017.030747 accepted/tizen/unified/x/asan/20241022.113447 tizen_9.0_m2_release
Krzysztof Malysa [Tue, 15 Oct 2024 13:32:18 +0000 (15:32 +0200)]
Fix (mostly) UBSAN found issues

Change-Id: I25f714a654642c8c95bc02a881ec8543b913b9bd

7 months agoRefactoring serialization to avoid strict aliasing violation 66/315766/5
Dongsun Lee [Tue, 30 Jul 2024 03:43:16 +0000 (12:43 +0900)]
Refactoring serialization to avoid strict aliasing violation

Change-Id: I5319c060c61459c97a0bef24ee52020cf2b101bf

7 months agoFix memory issues 28/319128/1
Krzysztof Malysa [Tue, 15 Oct 2024 13:29:41 +0000 (15:29 +0200)]
Fix memory issues

All were found using ASAN and UBSAN.

Change-Id: I9c7016cd8df4751083eb280f1dfb22bd28b53fe6

8 months agoDisable MC/GA_valid_request_and_cancel_P test on emulator 06/318606/2
Daniel Kita [Thu, 3 Oct 2024 07:58:55 +0000 (09:58 +0200)]
Disable MC/GA_valid_request_and_cancel_P test on emulator

No waiting for communication with the device
causes response callback to be called immediately
which makes wauthn_cancel() return
WAUTHN_ERROR_NOT_ALLOWED

Change-Id: Ic5478534f8327f4ed5de40eb21b07f2df22debb5

8 months agoReplace __gcov_flush by __gcov_dump and __gcov_reset 40/318540/2
Dongsun Lee [Wed, 2 Oct 2024 02:13:31 +0000 (11:13 +0900)]
Replace __gcov_flush by __gcov_dump and __gcov_reset

Change-Id: Idab5e5e1a863e078cf547db197517f2e3adb92a1

8 months agoAdd explanation for userId contents 82/318582/1
Daniel Kita [Wed, 2 Oct 2024 11:46:42 +0000 (13:46 +0200)]
Add explanation for userId contents

Change-Id: If18f24bd58603ed5c27dfdc38bd2bfa35226cc3f

8 months agoRelease version 1.0.6 48/318448/1
Yonggoo Kang [Mon, 30 Sep 2024 03:17:33 +0000 (12:17 +0900)]
Release version 1.0.6

Change-Id: Ic9eb82c6a985f4a123b23bbfd997cb53b86f50e1

8 months agoPrevent run server without filelock 92/318192/2
Yonggoo Kang [Wed, 25 Sep 2024 10:15:24 +0000 (19:15 +0900)]
Prevent run server without filelock

Before this patch, the webauthn-server can be launched when flock() is failed.

Change-Id: I2d15f79ceb1ffdb40c5c82146a6437163b7cb546

8 months agoAdd exclude credentials option 95/316895/13
Daniel Kita [Fri, 30 Aug 2024 06:39:38 +0000 (08:39 +0200)]
Add exclude credentials option

-Exclude credentials support
-Linked data matching available for every created user

Change-Id: I5bf793981a7564ae19c8d2b40de2f15d842536bf

8 months agoMove Closing QR viewer into response callbacks 49/317849/1
Yonggoo Kang [Thu, 19 Sep 2024 09:42:42 +0000 (18:42 +0900)]
Move Closing QR viewer into response callbacks

By this patch, the viewer will be closed at early and after returned any error.

Change-Id: I8f519155209f3546763b3fde68204de0617e103c

8 months agoRemove unnecessary chsmack command 47/317847/1
Yonggoo Kang [Thu, 19 Sep 2024 09:24:12 +0000 (18:24 +0900)]
Remove unnecessary chsmack command

Change-Id: Ie511984edf6ffa383507c74a0eb010a0061d6514

9 months agoFix pointed variable going out of scope 48/316948/1
Krzysztof Jackiewicz [Fri, 30 Aug 2024 14:44:50 +0000 (16:44 +0200)]
Fix pointed variable going out of scope

Change-Id: I4111c441ffb33626d71d3a6eef0196dfdde38567

9 months agoRelease version 1.0.5 81/316881/1 accepted/tizen_unified_dev accepted/tizen/unified/20240902.161249 accepted/tizen/unified/dev/20240903.220505 accepted/tizen/unified/toolchain/20241004.101610 accepted/tizen/unified/x/20240903.023150 accepted/tizen/unified/x/asan/20241013.235929
Yonggoo Kang [Fri, 30 Aug 2024 03:01:09 +0000 (12:01 +0900)]
Release version 1.0.5

Change-Id: Ied598bc17a0b2851f1008be805979d6676601b5b

9 months agoResolve using invalid iterator 57/316857/3
Yonggoo Kang [Thu, 29 Aug 2024 11:27:19 +0000 (20:27 +0900)]
Resolve using invalid iterator

- it->second.id is invalid if the it equal to contents->createdCredDescs.end()
- CID 1789324 from coverity check

Change-Id: I7dace1a8728521416d38bce2db01810ee84d7f77

9 months agoResolve using of auto that causes a copy 56/316856/2
Yonggoo Kang [Thu, 29 Aug 2024 11:15:08 +0000 (20:15 +0900)]
Resolve using of auto that causes a copy

- Avoid unnecessary object copies can affect performance
- CID 1789326 from coverity check

Change-Id: I74ea483e117009b7c2a6960e68edb07134a72b7a

9 months agoInitialize pointers 55/316855/1
Yonggoo Kang [Thu, 29 Aug 2024 11:12:40 +0000 (20:12 +0900)]
Initialize pointers

- CID 1787951 and 1787954 from coverity check

Change-Id: I9e37807c0e08263c8f6b01275675c5d3f262fb73

9 months agoRelease version 1.0.4 45/316845/1 accepted/tizen/unified/20240830.010912 accepted/tizen/unified/dev/20240901.214726 accepted/tizen/unified/x/20240830.014039
Yonggoo Kang [Thu, 29 Aug 2024 07:57:46 +0000 (16:57 +0900)]
Release version 1.0.4

Change-Id: Ie96ffe3d38b3133e0b4bbd1404df7abe25014b84

9 months agoAdd array header to resolve CTAD failed on debug mode 42/316842/1
Yonggoo Kang [Thu, 29 Aug 2024 07:33:40 +0000 (16:33 +0900)]
Add array header to resolve CTAD failed on debug mode

When build with debug_mode for tizen_x,
class template argument deduction(CTAD) has failed.
To resolve this, fix to use the array from array header.

Change-Id: I1a120f5572607e16bb92d8a0f717f80606bd3f60

9 months agoFix operator bug 34/316834/4
Yonggoo Kang [Thu, 29 Aug 2024 06:19:38 +0000 (15:19 +0900)]
Fix operator bug

This bug is found when build to tizen_x by -Werror=unused-result flag.

Change-Id: Ie1bab1a28f897231d3292f95ad2b4075dd101a0e

9 months agoRelease version 1.0.3 65/316765/1 accepted/tizen/unified/20240829.091421
Dongsun Lee [Wed, 28 Aug 2024 01:44:50 +0000 (10:44 +0900)]
Release version 1.0.3

Change-Id: I30a3df92e8fee0ae16b12ae86c1f31609cdd5478

9 months agoRelax parameter check for pointer of {pointer, size} 06/316706/4
Yonggoo Kang [Tue, 27 Aug 2024 06:20:50 +0000 (15:20 +0900)]
Relax parameter check for pointer of {pointer, size}

If a pointer of {pointer, size} is not NULL,
webauthn expects the pointer->pointer is not NULL and the pointer->size is not 0.
But webauthn allows the pointer is NULL and size is 0.

Change-Id: I732f550cec586d11f38d22ef4cd6fad830956000

9 months agoRelease version 1.0.2 56/316656/1
Krzysztof Jackiewicz [Mon, 26 Aug 2024 09:00:51 +0000 (11:00 +0200)]
Release version 1.0.2

Change-Id: I20c107ace8b86588d419bccca824833d4cb95e3e

9 months agoAdd quotation mark for check spaces 79/316379/4
Yonggoo Kang [Tue, 20 Aug 2024 10:56:51 +0000 (19:56 +0900)]
Add quotation mark for check spaces

Change-Id: Iad0049756e3f9dc3e67700d66cedc80c293309db

9 months agoFix return value in GenerateQRCode 17/316017/2
Daniel Kita [Mon, 12 Aug 2024 11:23:45 +0000 (13:23 +0200)]
Fix return value in GenerateQRCode

Change-Id: I86e469724b148d0307a039f17402603e75ebaf19

9 months agoEnable unfixed userId and allowCredential for test 32/315832/14
Yonggoo Kang [Thu, 8 Aug 2024 05:55:36 +0000 (14:55 +0900)]
Enable unfixed userId and allowCredential for test

- Replace userId from fixed value to input value
- Replace error value to string for log
- Minor fix with log
- Save created credential descriptors in memory
- Enable unfixed allowCredential option for authentication
- Deny requests with username as blank for registration
- Add testMsg to UI for display error information
- Add created usernames to UI
- Modify position and size of some UI components

Change-Id: If5d672adf9dc0fa5a420b2cb37e258dc182d999c

9 months agoChange log level from warning to debug 34/316334/4
Yonggoo Kang [Mon, 19 Aug 2024 12:16:47 +0000 (21:16 +0900)]
Change log level from warning to debug

Change-Id: I99cfc4274dfa413b5f81f2bc7f2abef5d18a9327

9 months agoFix log level from error to warn for normal cases 68/316368/4
Yonggoo Kang [Tue, 20 Aug 2024 08:16:16 +0000 (17:16 +0900)]
Fix log level from error to warn for normal cases

Change-Id: I9b3bb092355696a2f4f65fd18f3471e870c07ae5

9 months agoReinforce parameter check logic and unittests 33/315633/13
Yonggoo Kang [Mon, 5 Aug 2024 12:59:14 +0000 (21:59 +0900)]
Reinforce parameter check logic and unittests

- Update parameter check logic
- nullptr, invalid string, invalid setting
- Ingore some unknown enum values
- Modify some test-common data
- Update Webauthn API tests and add some positive cases

Change-Id: I4f568b99339fff278eb00797aae77d73ba3e6c80

9 months agoResolve data race condition on manual tests 20/315920/6
Yonggoo Kang [Fri, 9 Aug 2024 10:37:50 +0000 (19:37 +0900)]
Resolve data race condition on manual tests

Change-Id: I11525e5aa6248f3b3f9ea4afac6648324fc9a336

10 months agoModify waiting information log 86/315886/3
Yonggoo Kang [Fri, 9 Aug 2024 01:33:35 +0000 (10:33 +0900)]
Modify waiting information log

Change-Id: I07caef28e3efa1134d15753edd37e3fc7c6b3220

10 months agoSkip feature check in emulator builds 86/315786/3
Krzysztof Jackiewicz [Wed, 7 Aug 2024 15:31:56 +0000 (17:31 +0200)]
Skip feature check in emulator builds

Change-Id: Id4c93e8177301680e9428408a9d4514ec003c771

10 months agoImplement privilege tests 54/315154/12
Krzysztof Jackiewicz [Mon, 8 Jul 2024 08:54:53 +0000 (10:54 +0200)]
Implement privilege tests

Change-Id: I7c7cd37fbc9cd47ad1e429997d057ac167e84ac8

10 months agoImplement privilege check 67/314067/13
Krzysztof Jackiewicz [Thu, 4 Jul 2024 09:58:44 +0000 (11:58 +0200)]
Implement privilege check

Use synchronous cynara API under assumption that only one request is
allowed at a time and we don't have to worry about multiple clients
being delayed by cynara calls.

Change-Id: I06edbf8f0b9139e392fb319b3df5f6ef048e7d1c

10 months agoFix feature check in wauthn_cancel() 85/315785/1
Krzysztof Jackiewicz [Wed, 7 Aug 2024 15:31:23 +0000 (17:31 +0200)]
Fix feature check in wauthn_cancel()

Change-Id: Ia918f03902cd87994952feb312b9bc216df247ef

10 months agoFix feature check logic 69/315569/5
Krzysztof Jackiewicz [Fri, 2 Aug 2024 11:32:53 +0000 (13:32 +0200)]
Fix feature check logic

The check_network_features() was unused when feature check was disabled which
led to a build break it this configuration.

Keep the NO_FEATURE_CHECK ifdef in a single place for clarity.

Return either WAUTHN_ERROR_NOT_SUPPORTED or WAUTHN_ERROR_NONE.

Switch to bool return values to simplify the code.

Change-Id: I0e514a1b6e43970907734fcb0eaf0344cb5f509e

10 months agoAdd manual test 33/308433/45
Daniel Kita [Mon, 25 Mar 2024 08:53:07 +0000 (09:53 +0100)]
Add manual test

Change-Id: I1282040fb96617ccc3c42879cbf637c938ee351d

10 months agoUpdate log level and messages for checking features 53/315353/2
Yonggoo Kang [Tue, 30 Jul 2024 12:45:28 +0000 (21:45 +0900)]
Update log level and messages for checking features

Change-Id: I0d1e780adf8df4184053e7ddb16358461ca572b4

10 months agoUpdate manual tests and logs 49/315349/1
Yonggoo Kang [Tue, 30 Jul 2024 11:52:53 +0000 (20:52 +0900)]
Update manual tests and logs

- Update check logic for terminate
- Set timeout to make time out error while waiting for update_linked_data callback
- Add LogInfo to main points
- Minor fix

Change-Id: I745305b2f26d495038c92a7c7208c331035395ee

10 months agoFix alignment issue during (de)serialization 06/315006/5 accepted/tizen/7.0/unified/20240801.153013 accepted/tizen/8.0/unified/20240802.160812 accepted/tizen/unified/20240801.150140 accepted/tizen/unified/dev/20240805.054442 accepted/tizen/unified/toolchain/20240812.132354 accepted/tizen/unified/x/20240802.020158 accepted/tizen/unified/x/asan/20240813.230649
Dongsun Lee [Wed, 24 Jul 2024 05:19:20 +0000 (14:19 +0900)]
Fix alignment issue during (de)serialization

- A SIGBUS happened due to not-algined wauthn_const_buffer_s
- To fix this, a padding is added during serialization.

Change-Id: Ib872cd7e39b43061fcd0fdcf83715e7ecef50e4e

10 months agoFix documentation formatting 42/315142/1
Krzysztof Jackiewicz [Thu, 25 Jul 2024 11:00:24 +0000 (13:00 +0200)]
Fix documentation formatting

Change requested during Native API Reference preparation.

Change-Id: I1b4218bd966019495dcd026412ebb5616e4a4420

10 months agoReplace to absolute path for chsmack 05/314905/2
Yonggoo Kang [Tue, 23 Jul 2024 06:17:02 +0000 (15:17 +0900)]
Replace to absolute path for chsmack

Change-Id: Idf47621eccd84dc4922599509a8fc5e87dd2052d

10 months agoBump major version 15/314915/2 accepted/tizen/7.0/unified/20240730.133852 accepted/tizen/8.0/unified/20240730.132253 accepted/tizen/unified/20240726.010951 accepted/tizen/unified/dev/20240729.000832 accepted/tizen/unified/x/20240801.044207
Krzysztof Jackiewicz [Tue, 23 Jul 2024 06:56:32 +0000 (08:56 +0200)]
Bump major version

This is due to backward incompatible changes in the API.

Also:
* Fix the pc files and include versioning in them.
* Fix cmake warning

Change-Id: If0229cb0e8d54ed57604377ed9386d651eacd5ba

10 months agoFix ACR related issues 47/310547/22
Krzysztof Jackiewicz [Tue, 30 Apr 2024 19:51:34 +0000 (21:51 +0200)]
Fix ACR related issues

* Fix issues reported by review script
https://github.sec.samsung.net/RPO7-TIZEN/tizen-native-api-review-script/
* Fix issues reported in ACR review comments
https://jira.sec.samsung.net/browse/ACR-1843
* Add known causes of errors
* Add privileges & features
* Add unconcactable authenticator error
* Update tests
* Check features (but add option to disable it for emulator builds)

Change-Id: Idcd751571fd92bce3c5cf1c3e8906dc3a77f317a

10 months agoFix nullptr dereference 65/314765/3
Krzysztof Malysa [Thu, 18 Jul 2024 13:45:03 +0000 (15:45 +0200)]
Fix nullptr dereference

If the callbacks structure is freed/reused before the last call to
callbacks->linked_data_callback there would be a use-after-free.

This patch fixes this by coping the callbacks structure to the thread
context so it can be used safely without imposing restrictions on the
lifetime of the callbacks structure on the user.

Change-Id: I20c6ef9f142f9163e0fa16adb042bd13e9e65e12

10 months agoAdd Log for debug 97/314697/3
Yonggoo Kang [Wed, 17 Jul 2024 13:58:34 +0000 (22:58 +0900)]
Add Log for debug

- Add Request log for API parameters
- Add LinkedData log for reponse
- minor fix

Change-Id: Ibcd140a5f743a72e34fd5e6f0a59f8ad28359f72

12 months agoAutomate code coverage measurement 49/312649/3 accepted/tizen/unified/20240620.050722 accepted/tizen/unified/20240621.010432 accepted/tizen/unified/dev/20240701.072857 accepted/tizen/unified/toolchain/20240624.121359 accepted/tizen/unified/x/20240624.031926 accepted/tizen/unified/x/asan/20240625.092220
Dariusz Michaluk [Wed, 12 Jun 2024 12:50:15 +0000 (14:50 +0200)]
Automate code coverage measurement

To gather unit tests coverage report:
- build with: --define "gcov 1",
- instal webauthn-gcov rpm,
- run webauthn-coverage.sh script.

Change-Id: I9d3cdb38733a412e64bcfea9924b9292d43d633a

12 months agoAdd webauthn-image-viewer 27/312027/4 accepted/tizen/7.0/unified/20240605.045128 accepted/tizen/8.0/unified/20240604.163225 accepted/tizen/8.0/unified/20240604.163336 accepted/tizen/unified/20240604.160835 accepted/tizen/unified/dev/20240620.000208 accepted/tizen/unified/x/20240605.012728
Dongsun Lee [Mon, 3 Jun 2024 03:54:06 +0000 (12:54 +0900)]
Add webauthn-image-viewer

The image-viewer application is not supported in VD products

Change-Id: I0027b45ca15c431813cbc1689ddcd186818acc22

12 months agoAdd missing header file to libwebauth-client-devel 15/311915/1 accepted/tizen/unified/20240603.032345
Dongsun Lee [Thu, 30 May 2024 09:09:41 +0000 (18:09 +0900)]
Add missing header file to libwebauth-client-devel

Change-Id: I8e626cef2aea4c8e62cce5fef239ea1f1f8e5aad

12 months agoFix waiting conditions for update linked data 03/311803/2
Yonggoo Kang [Tue, 28 May 2024 07:07:44 +0000 (16:07 +0900)]
Fix waiting conditions for update linked data

Change-Id: I7857495d8b5c223f8f24ab8b2e9cf55dc6c87142

12 months agoResolve DEREF_OF_NULL.RET.ALLOC.MINOR issue 00/311700/2
Yonggoo Kang [Fri, 24 May 2024 05:18:56 +0000 (14:18 +0900)]
Resolve DEREF_OF_NULL.RET.ALLOC.MINOR issue

Change-Id: I4a1318c4462408a420ce0b225b45cbe3f178a271

12 months agoSupport update_linked_data callback and apply manual test 99/311699/1
Yonggoo Kang [Fri, 24 May 2024 04:50:22 +0000 (13:50 +0900)]
Support update_linked_data callback and apply manual test

Change-Id: I8ebfce98fa4d4c0c491ab62e91b755aab10243fb

13 months agoRemove unnecessary prints in unittests 67/310867/1 accepted/tizen/unified/20240520.131855 accepted/tizen/unified/x/20240521.022219
Yonggoo Kang [Thu, 9 May 2024 06:34:45 +0000 (15:34 +0900)]
Remove unnecessary prints in unittests

Change-Id: Iab2be919c3fd0339c6410314725c3f3091a4b632

13 months agoRename unit-tests to unittests for coverage naming rule 25/310625/2 accepted/tizen/unified/20240503.115804 accepted/tizen/unified/toolchain/20240508.012344 accepted/tizen/unified/x/20240507.050952
Yonggoo Kang [Fri, 3 May 2024 02:43:35 +0000 (11:43 +0900)]
Rename unit-tests to unittests for coverage naming rule

Change-Id: Ib0a43a3a7a64d9d32fbdf57f413eff1536053342

13 months agoEdit LICENSE with 2023 - 2024 20/310320/3 accepted/tizen/unified/toolchain/20240507.011845 accepted/tizen/unified/x/20240430.094747
Yonggoo Kang [Thu, 25 Apr 2024 08:51:50 +0000 (17:51 +0900)]
Edit LICENSE with 2023 - 2024

- Minor fix on Heading comments

Change-Id: Id503ad08bfaead3a301211e93e87b92ecf8fef4f

13 months agoAdd build flags for PIE 04/310404/1 accepted/tizen/7.0/unified/20240502.113454 accepted/tizen/8.0/unified/20240502.163823 accepted/tizen/unified/20240430.020645
Dongsun Lee [Fri, 26 Apr 2024 09:48:26 +0000 (18:48 +0900)]
Add build flags for PIE

Change-Id: Iffaac9946139daa0bfd2da41f20ed45b048e4d10

13 months agoSetup for automatic coverage measurement accepted/tizen/7.0/unified/20240429.105738 accepted/tizen/8.0/unified/20240429.063534
Yonggoo Kang [Wed, 24 Apr 2024 05:02:43 +0000 (14:02 +0900)]
Setup for automatic coverage measurement

- Setup automatic coverage measurement by run-unittest.sh
- Merge coverage data with webauthn-server daemon

Change-Id: I1d903ed1d8ce06f0e8b72ec31dc20d5836f9019c

13 months agoAdd unit tests for utils
Yonggoo Kang [Tue, 23 Apr 2024 03:39:48 +0000 (12:39 +0900)]
Add unit tests for utils

Change-Id: Ia838f962ee2ffa783f99dbe0d1fbadb46ca2db83

13 months agoMove SocketManager's exception to exception header
Yonggoo Kang [Tue, 23 Apr 2024 03:39:22 +0000 (12:39 +0900)]
Move SocketManager's exception to exception header

Change-Id: I01cd901b9dfe94b0f72f119dc2a848bf56f97450

13 months agoUpdate remarks of wauthn_cb_update_linked_data callback 47/309747/4
Dongsun Lee [Tue, 16 Apr 2024 07:24:35 +0000 (16:24 +0900)]
Update remarks of wauthn_cb_update_linked_data callback

Change-Id: I9b4872796bada4443b7c44dddc91c276b7a179df

13 months agoChange since_tizen from 9.0 to 7.0 93/310093/2
Dongsun Lee [Mon, 22 Apr 2024 09:28:55 +0000 (18:28 +0900)]
Change since_tizen from 9.0 to 7.0

The DA uses tizen 7.0 this year. So we need to support tizen 7.0, too.

Change-Id: Ib7b22c7e9e24b86db8a51d6e27229614b92959ae

13 months agoLimit permissions of the lock file for non-owner 31/309931/1 accepted/tizen/unified/20240423.164622
Yonggoo Kang [Thu, 18 Apr 2024 07:53:28 +0000 (16:53 +0900)]
Limit permissions of the lock file for non-owner

Change-Id: I230ba7b9467c04e83f5cf48630055b174faded1f

13 months agoMitigate possibility of DoS attack from throwing bad_alloc 02/309902/1
Yonggoo Kang [Thu, 18 Apr 2024 05:33:57 +0000 (14:33 +0900)]
Mitigate possibility of DoS attack from throwing bad_alloc

Change-Id: I5c45e0a2e11915f5a4388ec4d960fa1051b7eb20

13 months agoIntegration manual test with webautn-ble for state-assisted transaction 51/309851/2
Yonggoo Kang [Wed, 17 Apr 2024 09:11:25 +0000 (18:11 +0900)]
Integration manual test with webautn-ble for state-assisted transaction

- Support manual test for state-assisted transactions.
- INCLUDED:
  The webauthn call the update_linked_data callback manually after call response callback.
  It will be removed with the webauthn-ble support the update callback.

Change-Id: I723f02b6c0ada491d05b3f8bae416ea79cd148b2

13 months agoUpdate the callback logic for handle the wauthn_cb_update_linked_data 97/309697/9
Yonggoo Kang [Mon, 15 Apr 2024 16:21:04 +0000 (01:21 +0900)]
Update the callback logic for handle the wauthn_cb_update_linked_data

 - Add wauthn_cb_update_linked_data related logic and unittests
 - Fix bug on the __checkValidity() about valid range
 - Move UnsetBusy() into the Response Callback
 - Minor fix about naming
 - Ready for manual test with the added callback

Change-Id: I31794d5e6c9036f142ae8aaf0b58552e59c98546

13 months agoadd wauthn_cb_update_linked_data to support 2 min wait 35/309635/12
Dongsun Lee [Mon, 15 Apr 2024 01:11:30 +0000 (10:11 +0900)]
add wauthn_cb_update_linked_data to support 2 min wait

Change-Id: Ic6f6600f2ba1abf597fd7d14216c2580029f65fd

13 months agoadd identity_key to wauthn_hybrid_linked_data_s 34/309634/5
Dongsun Lee [Mon, 15 Apr 2024 01:09:57 +0000 (10:09 +0900)]
add identity_key to wauthn_hybrid_linked_data_s

Change-Id: I82b82e8f9feaf08dc8d54c51cf78e808721dedbc

14 months agoIntegration manual test with webautn-ble for QR initiated transaction 57/309457/2
Yonggoo Kang [Thu, 11 Apr 2024 04:40:27 +0000 (13:40 +0900)]
Integration manual test with webautn-ble for QR initiated transaction

Change-Id: If380da9e8a855089f8d5cd26ac26fe444785f2a9

14 months agoSplit initialization from constructor of ClientRequest 90/308990/1
Yonggoo Kang [Wed, 3 Apr 2024 09:01:47 +0000 (18:01 +0900)]
Split initialization from constructor of ClientRequest

Change-Id: I0d82a955f0dc88e9317bcc74fe82e09b138f6882

14 months agoFix typos 75/308575/4
Krzysztof Malysa [Wed, 27 Mar 2024 18:11:38 +0000 (19:11 +0100)]
Fix typos

Change-Id: Ib135c77a6f900ae1b24471dc28c2fdddc6d6146e

14 months agoAdd tests for cancel API and ClientRequest classes 47/308547/1
Yonggoo Kang [Wed, 27 Mar 2024 08:10:08 +0000 (17:10 +0900)]
Add tests for cancel API and ClientRequest classes

Change-Id: Id09b9e92a10b06662a556ade657aa2172828280c

14 months agoHandle not supported client's api call when shared library does not linked 44/308544/3
Yonggoo Kang [Wed, 27 Mar 2024 07:45:51 +0000 (16:45 +0900)]
Handle not supported client's api call when shared library does not linked

- Patch for the Change 308485
- Remove throwing exception in the constructor of DLLoader
- Add funtions for check if the webauthn-ble shared lib is linked
- Minor fix

Change-Id: I46a2d98e5808741334f388ed5163b2804ea09bca

14 months agoRemove unnecessary README.md file for now 31/308531/1
Yonggoo Kang [Wed, 27 Mar 2024 05:57:08 +0000 (14:57 +0900)]
Remove unnecessary README.md file for now

Change-Id: Ifb2a1e6e36e4ccdbb12cde9f1da5b013aaf1729a

14 months agoMove some implementation from header to cpp 97/308497/1
Yonggoo Kang [Tue, 26 Mar 2024 11:11:57 +0000 (20:11 +0900)]
Move some implementation from header to cpp

- Patch for the comment on the change-id 308437

Change-Id: I670332d39aa606f270792cc35b16da153a480fb8

14 months agoMake exception type for invalid shared library 85/308485/1
Yonggoo Kang [Tue, 26 Mar 2024 08:55:43 +0000 (17:55 +0900)]
Make exception type for invalid shared library

Change-Id: If79f76ffb5ea1abab8ff80f80037c57ad2b9002b

14 months agoMove common data and functions into TestCommon 77/308477/1
Yonggoo Kang [Tue, 26 Mar 2024 08:16:42 +0000 (17:16 +0900)]
Move common data and functions into TestCommon

Change-Id: I272698f8191d8dd1fa1be219494edfd17591c857

14 months agoMake abstraction of ClientRequest, DLLoader, Service 37/308437/1
Yonggoo Kang [Mon, 25 Mar 2024 13:23:25 +0000 (22:23 +0900)]
Make abstraction of ClientRequest, DLLoader, Service

- Enable to test each class
- Add m_notifyMe fd to notify to stop main loop
- Modify unittests to WebAuthn API
- Add unittests to ClientRequest
- Add unittests to DLLoader
- Add unittests to SocketManager

Change-Id: I721e08bae1515ac95f91aed4e2751acd7ea61bcb

14 months agoAdd references and decritpions to API 52/308352/2
Dongsun Lee [Thu, 21 Mar 2024 07:58:19 +0000 (16:58 +0900)]
Add references and decritpions to API

Change-Id: Ifee871537be2642236244788b4a2d4ca76c41da3

14 months agoRemove challenge from API 31/308331/1
Dongsun Lee [Thu, 21 Mar 2024 09:44:57 +0000 (18:44 +0900)]
Remove challenge from API

Change-Id: If2d938965c210d19c0c0029ca5ed7f36fd0254e3

14 months agoRemove json_data from API 10/308310/2
Dongsun Lee [Thu, 21 Mar 2024 07:59:32 +0000 (16:59 +0900)]
Remove json_data from API

Change-Id: Ibc9199bbd076e9ac05119c1f9b342b2ee92b761d

14 months agoRemove unused WEBAUTHN_MAX_USER_ID_LENGTH from API 75/308175/2
Dongsun Lee [Tue, 19 Mar 2024 04:47:43 +0000 (13:47 +0900)]
Remove unused WEBAUTHN_MAX_USER_ID_LENGTH from API

Change-Id: Ie81fb9ab1d0ce4ff4c97948a30bfd890f8637fa7

14 months agoremove is_conditional_mediation_available from API 68/308168/1
Dongsun Lee [Tue, 19 Mar 2024 03:01:01 +0000 (12:01 +0900)]
remove is_conditional_mediation_available from API

Change-Id: I78addbf3907abbda9fa9b8006da498b1a75a3c1a

14 months agoRefine FileLocker and add unittests 65/308065/1
Yonggoo Kang [Fri, 15 Mar 2024 12:19:34 +0000 (21:19 +0900)]
Refine FileLocker and add unittests

- Move Exception for FileLocker to exception.h
- Add lockFile parameter into constructor of ServiceFileLocker
- Change throwing exception to logging error
- Add unittests for FileLocker
- Move the FILE_LOCKER to header

Change-Id: I4c7883d1558e20d2d63c05732a4d2feb4810d3d3

14 months agoRemove sleep on unittest 63/308063/1
Yonggoo Kang [Fri, 15 Mar 2024 12:09:40 +0000 (21:09 +0900)]
Remove sleep on unittest

- The webauthn-server need to be stopped by manual or script before pull gcda files

Change-Id: I8c49b8233d638ecee18bc69b0134bc5c33286f81

14 months agoFix typo 62/308062/1
Yonggoo Kang [Fri, 15 Mar 2024 12:07:48 +0000 (21:07 +0900)]
Fix typo

Change-Id: Ibf9a488e90d343417f881e7d680a17743c673b46

14 months agoRemove unused util function 61/308061/1
Yonggoo Kang [Fri, 15 Mar 2024 12:06:48 +0000 (21:06 +0900)]
Remove unused util function

Change-Id: I3bfa17afaaf6fc39efc7e9ad3e99c35aa8460198

14 months agoRefine QRCallback logic of request on server side 57/308057/2
Yonggoo Kang [Fri, 15 Mar 2024 11:25:21 +0000 (20:25 +0900)]
Refine QRCallback logic of request on server side

- Prevent to access to nullptr
- Remove unnecessary exception types
- Remove duplicated code block
- Move the result log from GetUserData() to outside

Change-Id: If654b9bd568cf088df94ec55f51489ef579be381

14 months agoFix minor 47/307947/3
Yonggoo Kang [Thu, 14 Mar 2024 12:00:20 +0000 (21:00 +0900)]
Fix minor

- Fix typo
- Add a missing header
- Remove unnecessary newlines

Change-Id: Id9b5f287a4dbdca9b997fcfb6241a07b783772fd

14 months agoRemove repeated condition 46/307946/3
Yonggoo Kang [Thu, 14 Mar 2024 11:57:38 +0000 (20:57 +0900)]
Remove repeated condition

Change-Id: I93fe37003d075fa04fb4d90f1dbf1a8fdc7de1bb

14 months agoCheck user_data first and remove unnecessary logic of tail 45/307945/3
Yonggoo Kang [Thu, 14 Mar 2024 11:52:55 +0000 (20:52 +0900)]
Check user_data first and remove unnecessary logic of tail

Change-Id: I2a2b17ef2174c9077f8db34f8835dc01c3fe805b

14 months agoEnable gcov 12/307912/3
Yonggoo Kang [Thu, 14 Mar 2024 07:03:40 +0000 (16:03 +0900)]
Enable gcov

 - Add settings
 - Change filename tests/main.cpp to unittests.cpp to distinguish it from server/main.cpp

Change-Id: I60a32e2eb1a347987bfde1e2a5aacd151dac3a7e