platform/core/api/media-controller.git
2 months agoBug fix. disable product_tv as default 39/322339/1 accepted/tizen_unified accepted/tizen_unified_x tizen accepted/tizen/unified/20250409.021040 accepted/tizen/unified/x/20250409.035023
Jiyong [Tue, 8 Apr 2025 00:15:02 +0000 (09:15 +0900)]
Bug fix. disable product_tv as default

Change-Id: I07ba95262a2fa7eb96d71f76f356b65a130f788f

5 months agoCreate a file to verify controller daemon has run 17/317217/4 accepted/tizen_unified_x_asan accepted/tizen/unified/20241231.131846 accepted/tizen/unified/x/20250101.065006 accepted/tizen/unified/x/asan/20250113.002101
hjkim [Fri, 27 Dec 2024 05:10:08 +0000 (14:10 +0900)]
Create a file to verify controller daemon has run

create tmp/media_controller_launch and remain additional message when socket connection failed.

Change-Id: I8b324119f9a2f944f7db85cea3f4a885af20fc27

5 months agoBug fix. insecure strncmp 06/316806/1 accepted/tizen/unified/20241219.032735 accepted/tizen/unified/x/20241219.100942
Jiyong [Wed, 18 Dec 2024 06:45:43 +0000 (15:45 +0900)]
Bug fix. insecure strncmp

 - fix svace issue (LIB.INSECURE_STRNCMP)

The problem that such using checks only prefix of string because null-terminator is not checked.
It may be source of vulnarability when using for compariso passwords.
Correct pattern should use strlen(arg) + 1.

Change-Id: Ic9ac12468a6c81901e1c169097109e47a4c496fa

5 months agoAdd more info to debug message 02/316702/3
hjkim [Tue, 17 Dec 2024 07:05:58 +0000 (16:05 +0900)]
Add more info to debug message

Change-Id: Iba87610cd54d189598e263960bb4c947a6ba6b1d

6 months agoAdd OS upgrade script for TV 25/321125/2 accepted/tizen/unified/20241130.125032 accepted/tizen/unified/x/20241218.032638 accepted/tizen/unified/x/asan/20241224.004401
Jiyong [Thu, 28 Nov 2024 01:11:50 +0000 (10:11 +0900)]
Add OS upgrade script for TV

Change-Id: I58c094dadc787c72431087cb9225e19d5911e1e8

8 months agoImprove API description 68/318068/9 accepted/tizen_unified_toolchain accepted/tizen/9.0/unified/20241030.232427 accepted/tizen/unified/20240930.083339 accepted/tizen/unified/toolchain/20241004.101636 accepted/tizen/unified/x/20240930.134644 accepted/tizen/unified/x/asan/20241013.235955 tizen_9.0_m2_release
hjkim [Tue, 24 Sep 2024 07:50:49 +0000 (16:50 +0900)]
Improve API description

Change-Id: Ieae51c84ef95a6f93cfe004c9f96b4b7d540334a

8 months agoCode clean up regarding the return value 52/318052/2
hjkim [Tue, 24 Sep 2024 05:19:51 +0000 (14:19 +0900)]
Code clean up regarding the return value

Change-Id: Ic33390455a90e7649a6d00a5b0870ac99452495f

9 months agofix doxygen header issues 55/317655/1 accepted/tizen_unified_dev accepted/tizen/unified/20240919.163723 accepted/tizen/unified/dev/20240920.060412 accepted/tizen/unified/x/20240920.053150
hjkim [Fri, 13 Sep 2024 02:07:16 +0000 (11:07 +0900)]
fix doxygen header issues

Change-Id: Icd85f2a213fc6e6891f562c87243b90a6b9874d3

11 months agoBug fix. insecure strncmp 77/314377/1 accepted/tizen/unified/20240712.160044 accepted/tizen/unified/dev/20240715.080531 accepted/tizen/unified/toolchain/20240812.132506 accepted/tizen/unified/x/20240715.042457 accepted/tizen/unified/x/asan/20240813.230759
Jiyong [Thu, 11 Jul 2024 03:50:44 +0000 (12:50 +0900)]
Bug fix. insecure strncmp

 - fix svace issue (LIB.INSECURE_STRNCMP)

The problem that such using checks only prefix of string because null-terminator is not checked.
It may be source of vulnarability when using for compariso passwords.
Correct pattern should use strlen(arg) + 1.

Change-Id: I3fd5a9e785e5f87a53b23909ddc01963dbd8916d

12 months agomedia_controller_util refactoring 78/312578/2 accepted/tizen/unified/20240614.084852 accepted/tizen/unified/dev/20240620.004048 accepted/tizen/unified/toolchain/20240624.121419 accepted/tizen/unified/x/20240614.160418 accepted/tizen/unified/x/asan/20240625.092247
Minje Ahn [Wed, 12 Jun 2024 01:28:15 +0000 (10:28 +0900)]
media_controller_util refactoring

1. Checked only an app name not a full interface name.
2. Changed the substitution pattern from 'APPID_SEP' to '__'.
3. Used g_autofree.
4. Used g_uuid_string_random() instead. (Remove uuid dependency)

Change-Id: I54adcf7461dbe25482fedf2b442a1a8fb8498a27
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
12 months agoRemove unnecessary executable permissions 71/312471/2 accepted/tizen/unified/20240612.100030 accepted/tizen/unified/x/20240612.110502
Seungbae Shin [Mon, 10 Jun 2024 12:08:28 +0000 (21:08 +0900)]
Remove unnecessary executable permissions

Change-Id: I8985201af0205bafb8c56c16fd3071542cec9339

12 months agoUse g_auto(GStrv) 25/312525/1
Minje Ahn [Tue, 11 Jun 2024 06:39:20 +0000 (15:39 +0900)]
Use g_auto(GStrv)

Change-Id: I5a805f1614e1fc95b26ec47a6500f660eed8d3b2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
12 months agoAdd sql_autoptr type 19/312519/1
Minje Ahn [Tue, 11 Jun 2024 05:09:48 +0000 (14:09 +0900)]
Add sql_autoptr type

sql_autoptr:
__attribute__((cleanup(sqlite3_free))) char *

Change-Id: I7e29854976027ab2da2d18dd3ba0e2ca4c6d8ed7
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
12 months agoRemove meaningless code 08/312508/1
Minje Ahn [Tue, 11 Jun 2024 02:11:19 +0000 (11:11 +0900)]
Remove meaningless code

This code is meaningless for the following reasons:
  1. If there is no db file, media_db_connect() creates one.
  2. 'pragma integrity_check' is a command for checking consistency of db.
     Therefore, it is independent of file size.

Change-Id: If906853134116965691bc3998cd8f2262cb5f219
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
12 months agoUse sqlite3_str instead of gslist 33/312433/1
Minje Ahn [Mon, 10 Jun 2024 06:12:16 +0000 (15:12 +0900)]
Use sqlite3_str instead of gslist

sqlite3_str makes playlist-related operations simpler.

Change-Id: Id46dfd03371b766e34f2b0e086582b89e93d5514
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
12 months agoRemove unused variable 96/312396/1 accepted/tizen/unified/20240611.122520 accepted/tizen/unified/x/20240612.025912
Minje Ahn [Mon, 10 Jun 2024 00:47:07 +0000 (09:47 +0900)]
Remove unused variable

Change-Id: Ie854d36934ea750a7ad626c2d076dca648d05088
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
12 months agoUse sqlite APIs directly 26/311426/2
Minje Ahn [Tue, 21 May 2024 03:56:44 +0000 (12:56 +0900)]
Use sqlite APIs directly

sqlite APIs already checked input value.
So no need macro.

Change-Id: I662a6a5a04ba9d98ac66fdb52ec8f310eb568438
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
12 months agoRemove db upgrade function 20/311420/2
Minje Ahn [Tue, 21 May 2024 02:07:36 +0000 (11:07 +0900)]
Remove db upgrade function

DB upgrade functions is for tizen 5.0.
No longer in use.

Change-Id: I9b3d249852b07356f18840872ce0c4ee41b073c6
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
13 months agoRemove unused code 12/310612/2 accepted/tizen/unified/20240503.115801 accepted/tizen/unified/toolchain/20240508.012328 accepted/tizen/unified/x/20240507.050955
Jiyong [Thu, 2 May 2024 22:45:26 +0000 (07:45 +0900)]
Remove unused code

Change-Id: I7245d218329b50d757e651c069021b8210a477ee

13 months agoFix memory leak for 'path' 64/310564/4
Jiyong [Thu, 2 May 2024 03:32:08 +0000 (12:32 +0900)]
Fix memory leak for 'path'

Change-Id: I086221beb8558d7bce5b0bc348e96e1a6b46f0c9

13 months agoChange version of so files for compatibility 25/310425/1 accepted/tizen/unified/20240502.044652 accepted/tizen/unified/toolchain/20240507.011802 accepted/tizen/unified/x/20240503.091131
Jiyong [Mon, 29 Apr 2024 01:28:37 +0000 (10:28 +0900)]
Change version of so files for compatibility

- The prebuilt binary which has dependency of this package will be failed
  while loading this shared library by different so name if version of so file is 1.0.0.
  (new:libcapi-media-controller.so.1 vs old:libcapi-media-controller.so.0)

Change-Id: I801c2e5459e03b6b1872e97614d422fb6032edd2

13 months agoRelease version 1.0.0 13/310213/3
Jiyong [Wed, 24 Apr 2024 06:20:59 +0000 (15:20 +0900)]
Release version 1.0.0

Change-Id: I4c7e1142e0d78551758323e33e83eb6224c7bf35

13 months agoCode cleanup for socket functions 00/310200/3 accepted/tizen/unified/20240426.035448 accepted/tizen/unified/x/20240430.094806
Jiyong [Wed, 24 Apr 2024 03:51:44 +0000 (12:51 +0900)]
Code cleanup for socket functions

 - Remove uncalled timeout_sec
 - Replace return value to socket fd

Change-Id: Ibedbae3cc6d31a8e460964969ae8ac2ade5bb53a

13 months agoRemove unnecessary socket activation code 89/310189/5
Jiyong [Wed, 24 Apr 2024 02:26:23 +0000 (11:26 +0900)]
Remove unnecessary socket activation code

Change-Id: I6343c90e712ea4356c9d9c57ac9a022fe50e9641

13 months agoModify to limit the size of message for socket ipc 86/309886/9 accepted/tizen/unified/20240424.063525 accepted/tizen/unified/x/20240425.051112
Jiyong [Wed, 17 Apr 2024 23:47:42 +0000 (08:47 +0900)]
Modify to limit the size of message for socket ipc

[Problem]
  DoS is available by calling g_malloc0 with too big msg_size value.

[Solution]
  The size of messages with socket has been limited to 10kbytes and
  large messages will be sent as file.

Change-Id: Ie2cf9f4f3a3ec111fcf220724427f29b5157729a

14 months agocheck parameter before using strlen() 14/308514/5 accepted/tizen/unified/20240415.170316 accepted/tizen/unified/x/20240416.023013
hjkim [Wed, 27 Mar 2024 01:35:58 +0000 (10:35 +0900)]
check parameter before using strlen()

Change-Id: Ideff7dbf3212c09653a3262f06b52a147eeece70

15 months agoRemove unused codes 29/307529/1 accepted/tizen/unified/20240313.133525 accepted/tizen/unified/20240313.135013 accepted/tizen/unified/x/20240314.073242
Jiyong [Tue, 12 Mar 2024 00:12:09 +0000 (09:12 +0900)]
Remove unused codes

Change-Id: I3ec6840dafb808932244c58ca33c1b1603e50f67

15 months agoBug fix of getting signal name 00/307400/1 accepted/tizen/unified/20240308.174154 accepted/tizen/unified/x/20240311.100025
hjkim [Fri, 8 Mar 2024 04:56:30 +0000 (13:56 +0900)]
Bug fix of getting signal name

Change-Id: I6f643fafed6f4469998d91b8d841ed4de73b2de9

15 months ago[ACR-1825]Remove deprecated APIs 79/305679/7
hjkim [Tue, 6 Feb 2024 07:27:57 +0000 (16:27 +0900)]
[ACR-1825]Remove deprecated APIs

//media_controller_client.h

typedef void (*mc_shuffle_ability_updated_cb)(const char *server_name, mc_ability_support_e support, void *user_data)
typedef void (*mc_repeat_ability_updated_cb)(const char *server_name, mc_ability_support_e support, void *user_data)

int mc_client_set_shuffle_ability_updated_cb(mc_client_h client, mc_shuffle_ability_updated_cb callback, void *user_data)
int mc_client_unset_shuffle_ability_updated_cb(mc_client_h client)
int mc_client_set_repeat_ability_updated_cb(mc_client_h client, mc_repeat_ability_updated_cb callback, void *user_data)
int mc_client_unset_repeat_ability_updated_cb(mc_client_h client)
int mc_client_get_playlist_item_index(mc_playback_h playback, char **index)
int mc_client_get_server_shuffle_ability_support(mc_client_h client, const char *server_name, mc_ability_support_e *support)
int mc_client_get_server_repeat_ability_support(mc_client_h client, const char *server_name, mc_ability_support_e *support)
int mc_client_foreach_server_playlist(mc_client_h client, const char *server_name, mc_playlist_cb callback, void *user_data)

//media_controller_server.h
int mc_server_set_playlist_item_index(mc_server_h server, const char *index)
int mc_server_foreach_playlist(mc_server_h server, mc_playlist_cb callback, void *user_data)
int mc_server_set_shuffle_ability(mc_server_h server, mc_ability_support_e support)
int mc_server_set_repeat_ability(mc_server_h server, mc_ability_support_e support)

//media_controller_type.h
MC_SUBSCRIPTION_TYPE_SHUFFLE_ABILITY
MC_SUBSCRIPTION_TYPE_REPEAT_ABILITY

Change-Id: Ib6a513ac1becb5b172b9022a10e8ee473aca3f60

15 months agoImprove handle creation performance 24/306024/2 accepted/tizen/unified/20240222.012638 accepted/tizen/unified/toolchain/20240311.065130 accepted/tizen/unified/x/20240222.211059
Jiyong [Thu, 15 Feb 2024 07:40:28 +0000 (16:40 +0900)]
Improve handle creation performance

- reduce sleep time 200ms -> 10ms

Change-Id: Ie82869950491143d662c2f2e915941206b86be33

15 months agoFix build error if build conf is not defined 61/305961/1 accepted/tizen/unified/20240215.130030 accepted/tizen/unified/x/20240219.013843
Jiyong [Wed, 14 Feb 2024 07:24:39 +0000 (16:24 +0900)]
Fix build error if build conf is not defined

Change-Id: Ifd2d0d3c096cb355965845917881c6cab8b5f090

16 months agoRemove useless '#' for functions in document 18/305718/3 accepted/tizen/unified/20240212.170157 accepted/tizen/unified/x/20240214.051936
hjkim [Wed, 7 Feb 2024 01:02:45 +0000 (10:02 +0900)]
Remove useless '#' for functions in document

Change-Id: Ic543e65d1f1cb248ba326e7d47a14ead7a6fbefc

16 months agoEnable on-demand with socket activation for sec_buildconf_optimized_memory 03/305303/5
Jiyong [Wed, 31 Jan 2024 05:47:30 +0000 (14:47 +0900)]
Enable on-demand with socket activation for sec_buildconf_optimized_memory

Change-Id: I0f9be5e23da8a14609afbb579c0665474727273f

16 months agoAdd null check for 'sql_str' 46/305146/2 accepted/tizen/unified/20240131.175410 accepted/tizen/unified/x/20240205.063843
Jiyong [Mon, 29 Jan 2024 08:41:52 +0000 (17:41 +0900)]
Add null check for 'sql_str'

Change-Id: I24f8434bc24cfca802ada8c2c998a75532cca4c2

18 months agoRemove profile tag 00/302300/1 accepted/tizen_unified_riscv accepted/tizen/unified/20231206.151816 accepted/tizen/unified/riscv/20231211.234026
minje.ahn [Tue, 5 Dec 2023 07:43:28 +0000 (16:43 +0900)]
Remove profile tag

Change-Id: I02b8ec8af626e41b4540bf513d21550886c5c7ae
Signed-off-by: minje.ahn <minje.ahn@samsung.com>
22 months agoBug fix. Command or event was not delivered sometimes 20/296520/1 accepted/tizen/8.0/unified/20231005.092726 accepted/tizen/unified/20230801.174236 tizen_8.0_m2_release
jiyong.min [Mon, 31 Jul 2023 06:51:38 +0000 (15:51 +0900)]
Bug fix. Command or event was not delivered sometimes

[Cause]
All the same items were removed from command list for single sending command.

[Solution]
It is changed to remove one item from command list.

Change-Id: Ic6fea259cdb225aad8a0d267ea419ba026ed53f0

23 months agoFixed the build error using gcc 13 29/295029/6 accepted/tizen/unified/20230703.093346 accepted/tizen/unified/dev/20230726.115748
jiyong.min [Fri, 30 Jun 2023 05:34:56 +0000 (14:34 +0900)]
Fixed the build error using gcc 13

Change-Id: Ie340fcdbeea839853e882c374ca0184ab6b2caca

2 years agoRemove unnecessary 'oldname' 69/290969/1 accepted/tizen/unified/20230406.165745
jiyong.min [Thu, 6 Apr 2023 00:45:10 +0000 (09:45 +0900)]
Remove unnecessary 'oldname'

Change-Id: I5dd7ca4116a40165769f1027fd19226b0e779153

2 years agoRemove unnecessary database check 03/290903/1
jiyong.min [Tue, 4 Apr 2023 23:41:26 +0000 (08:41 +0900)]
Remove unnecessary database check

The mediacontroller resets all tables except the latest server.
If not exists, it will be created.
Therefore, there is no problem when the size is 0.
It is unnecessary behavior.

Change-Id: Icd91f352715cbed9c8499fce4cb5373762162845

2 years agoApply mutex when access connected application list. 44/288344/4 accepted/tizen/unified/20230227.042008
hj kim [Wed, 15 Feb 2023 09:28:39 +0000 (18:28 +0900)]
Apply mutex when access connected application list.

aul_listen_app_dead_signal() is called in the main thread, and try to acess connected application list.
it can cause a problem.

Change-Id: Ia637c5f4440f25214866e922974e818fc54c9e25

2 years agoRemove useless structures and use queue directly in socket 95/288095/8
hj kim [Fri, 10 Feb 2023 09:27:57 +0000 (18:27 +0900)]
Remove useless structures and use queue directly in socket

Change-Id: I4c2cede650d9c822446d8bba1cacaaac64b67e74

2 years agoSeparate GSource from mc_manage_queue_t 92/288092/6
hj kim [Fri, 10 Feb 2023 08:50:43 +0000 (17:50 +0900)]
Separate GSource from mc_manage_queue_t

Change-Id: Ib6654861abb1d47dd36ce2556d7bfce125e69fbc

2 years agoSeparate connected app list from mc_service_t 64/288064/4
hj kim [Fri, 10 Feb 2023 02:04:49 +0000 (11:04 +0900)]
Separate connected app list from mc_service_t

Connected App list does not have to work with request list,
and since it is together, it delivers unnecessary data.

Change-Id: I7d8b1155d6dc400490589fadb00f0ca3819a040d

2 years agoModify code to initialize data when it is needed 62/288062/1
hj kim [Fri, 10 Feb 2023 01:21:32 +0000 (10:21 +0900)]
Modify code to initialize data when it is needed

Change-Id: Ifa177aec2203c11f85b2d3ed66c1b2860a40452c

2 years agoFix typecast issue of 'socklen_t' 60/283260/2 accepted/tizen/unified/20221103.165747
jiyong.min [Fri, 21 Oct 2022 05:26:48 +0000 (14:26 +0900)]
Fix typecast issue of 'socklen_t'

Change-Id: I6a2d38b71793785e4d755d660154ad8bf59515c6

2 years agoFix media-controller-add.post file permission error 76/283076/1
jiyong.min [Tue, 18 Oct 2022 01:15:25 +0000 (10:15 +0900)]
Fix media-controller-add.post file permission error

 - Permission was not changed to 755 and can't be executed.

Change-Id: I1889a1738d44b71bca061aec5b79b34acc72a37b

2 years agoAdd to create the empty db file 72/282972/2
jiyong.min [Fri, 14 Oct 2022 04:48:15 +0000 (13:48 +0900)]
Add to create the empty db file

 - On auto coverage tests, db is created as system smack label.
   So we add to create the empty db file as user smack label.

Change-Id: I1acb74576a9d4998d486733440041ca5b03ba0c3

3 years agospec: Change the installation path of gcov object 24/275524/1 accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/hotfix/20221116.104713 accepted/tizen/unified/20220528.144421 submit/tizen/20220526.064806 tizen_7.0_m2_release
jiyong.min [Thu, 26 May 2022 04:42:53 +0000 (13:42 +0900)]
spec: Change the installation path of gcov object

Change-Id: I5f1fadd2ebc4dd088467567e1f87b3831d925beb

3 years agoRemove TIZEN_FEATURE_COMPATIBILITY code 72/273172/1 accepted/tizen/unified/20220421.065408 submit/tizen/20220418.052811 submit/tizen/20220418.220359
Minje Ahn [Thu, 31 Mar 2022 06:30:07 +0000 (15:30 +0900)]
Remove TIZEN_FEATURE_COMPATIBILITY code

Change-Id: I8ee137bbfd2be518652d81b07d494780160ce92f
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agofix 'GSource *timer_src' memory leak and code refactoring for timer 26/272326/2 accepted/tizen/unified/20220321.141205 submit/tizen/20220321.013712
jiyong.min [Mon, 14 Mar 2022 01:20:34 +0000 (10:20 +0900)]
fix 'GSource *timer_src' memory leak and code refactoring for timer

Change-Id: I222811faca43a3a2b29327bb46b324eb49106887

3 years agoChange gcov object install path 76/269876/1 accepted/tizen/unified/20220128.144439 submit/tizen/20220124.032604
Jiyong Min [Fri, 21 Jan 2022 07:33:05 +0000 (16:33 +0900)]
Change gcov object install path

Change-Id: Ib48788cdc9ecadf8c4bafe3a787331df86724960

3 years agobug fix. unsafe sign extension of expression 'nsec_t' with 'unsigned long' 11/262611/1 accepted/tizen/6.5/unified/20211028.100227 accepted/tizen/unified/20210818.124613 submit/tizen/20210817.013507 submit/tizen/20210817.050956 submit/tizen_6.5/20211028.161801 tizen_6.5.m2_release
Jiyong Min [Wed, 11 Aug 2021 07:53:35 +0000 (16:53 +0900)]
bug fix. unsafe sign extension of expression 'nsec_t' with 'unsigned long'

 - fix Svace issue

Change-Id: I976dc88152471c5cedddc7138780d5a560528c6e

4 years agoBug fix. read memory after free 85/259085/2 accepted/tizen/unified/20210611.013550 submit/tizen/20210610.063803
Jiyong Min [Tue, 1 Jun 2021 04:45:54 +0000 (13:45 +0900)]
Bug fix. read memory after free

 - fix coverity issue
  'iter' pointer variable is used after free.
  After the 'iter' was freed using 'g_list_free_full', it is used in 'iter = g_list_next(iter)'.

Change-Id: I70115a6197b7d02ad9afb64376c920a3ea7fcb03

4 years agoRevert "Bug fix. read memory after free"
Jiyong Min [Tue, 1 Jun 2021 04:43:06 +0000 (13:43 +0900)]
Revert "Bug fix. read memory after free"

This reverts commit d051edd9b2ce8b58e82f90a5defcc3e1800966cd.

4 years agoBug fix. read memory after free
Jiyong Min [Tue, 1 Jun 2021 01:40:59 +0000 (10:40 +0900)]
Bug fix. read memory after free

 - fix coverity issue
  'iter' pointer variable is used after free.
  After the 'iter' was freed using 'g_list_free_full',
  it is used in 'iter = g_list_next()'.

Change-Id: I156290288f182326d0d44ef120f9d1347adc4150

4 years agoFix typo (subtite -> subtitle) 49/258049/2 accepted/tizen/unified/20210510.100648 submit/tizen/20210510.072803
backto.kim [Mon, 10 May 2021 02:56:41 +0000 (11:56 +0900)]
Fix typo (subtite -> subtitle)

Change-Id: I159ea077cf79e4a1b3ceca2f51cfd8db35233116

4 years agoFixed the length of bundle_key to 3-digit 65/257665/2 accepted/tizen/unified/20210430.052702 submit/tizen/20210429.234105
jiyong.min [Thu, 29 Apr 2021 06:25:27 +0000 (15:25 +0900)]
Fixed the length of bundle_key to 3-digit

[Problem]
 Playlist is sorted to 1 - 10 - 11 - ... - 2 - 3(character sorting),
 but wanted to be sorted like 1 - 2 - 3 - ... - 10 - 11.
[Cause]
 The bundle_key is character, the length of bundle_key doesn't affects sorting.
[Solution]
 Fixed the length of bundle_key to 3-digit(3-character).

Change-Id: I16b3b59f213f368c9f8203b15acd44b6d370b2c1

4 years agoRelease version 0.2.25 65/257065/2
jiyong.min [Mon, 19 Apr 2021 06:25:04 +0000 (15:25 +0900)]
Release version 0.2.25

Change-Id: I417f15d060a668876ae166a45e3549d16e4a5d10

4 years agoModify the query of getting playlist's item to order by ROWID 64/257064/2
jiyong.min [Mon, 19 Apr 2021 06:21:46 +0000 (15:21 +0900)]
Modify the query of getting playlist's item to order by ROWID

[Problem]
 Playlist is sorted by item index. Playlist should not be sorted.
[Cause]
 The database sort the data by item index.
[Solution]
 Modify the query to order by ROWID.

Change-Id: Ie9e21861bf425ee99aae6a16f6d383dce5ea4b79

4 years agoAdd new key for the bundle of playlist 63/257063/2
jiyong.min [Mon, 19 Apr 2021 06:13:33 +0000 (15:13 +0900)]
Add new key for the bundle of playlist

[Problem]
 Playlist is sorted by item index. Playlist should not be sorted.
[Cause]
 The bundle is parcelable data, the data is sorted by a key.
 And playlist use the item index as the key of bundle.
 Therefore playlist is sorted by the item index.
[Solution]
 Add new dummy key. So it is no longer sorted by item index.

Change-Id: I0cce605dcecdfff9f76a5a51b04e2fff8386ca22

4 years agoRelease version 0.2.24 53/255653/6 accepted/tizen/unified/20210324.124253 submit/tizen/20210324.015805
jiyong.min [Mon, 22 Mar 2021 06:40:53 +0000 (15:40 +0900)]
Release version 0.2.24

Change-Id: I6f8ce3bc3de37beea8d879ba990a40d43f2e5ce2

4 years agoAdd retry logic when the database locked 52/255652/7
jiyong.min [Mon, 22 Mar 2021 06:35:08 +0000 (15:35 +0900)]
Add retry logic when the database locked

Change-Id: I3f8f6cb05f6f0b53758836aa6ed522b1fafa54bc

4 years agoChange systemd-devel package name 52/252852/1 accepted/tizen/unified/20210209.124430 submit/tizen/20210208.015104
INSUN PYO [Wed, 3 Feb 2021 00:58:30 +0000 (09:58 +0900)]
Change systemd-devel package name

Change-Id: Ic198c4446203cca6d386f972139085f3ab877798

4 years agoUpdate test codes 39/249839/3 accepted/tizen/unified/20201224.151547 submit/tizen/20201218.042524
hj kim [Thu, 17 Dec 2020 05:08:20 +0000 (14:08 +0900)]
Update test codes

Destroy client when quit the program

Change-Id: I60c18d185ca7b5e5b9accca09ff82851f6983a12

4 years agoAdd new msg to check service launch status 91/249591/8
hj kim [Tue, 15 Dec 2020 07:42:16 +0000 (16:42 +0900)]
Add new msg to check service launch status

Change-Id: I9c7148c34e90e5537913b0507e849eaa30d3e2b4

4 years agoUpdate code to reduce complexity 81/249581/3
hj kim [Tue, 15 Dec 2020 06:45:35 +0000 (15:45 +0900)]
Update code to reduce complexity

Change-Id: I7f2327939287fced4d0b2da1dba6d17d8fd7ebee

4 years agoFix wrong messages 68/249568/3
hj kim [Tue, 15 Dec 2020 05:18:31 +0000 (14:18 +0900)]
Fix wrong messages

Change-Id: I9cdcf62e7eee1844edf0da0fed5ca34db7a2769f

4 years agoReduce DB locking time 99/245199/15 accepted/tizen_6.0_unified_hotfix tizen_6.0_hotfix accepted/tizen/6.0/unified/20201030.122552 accepted/tizen/6.0/unified/hotfix/20201103.004858 accepted/tizen/6.0/unified/hotfix/20201103.052243 accepted/tizen/unified/20201009.090838 submit/tizen/20201008.053624 submit/tizen_6.0/20201029.205102 submit/tizen_6.0_hotfix/20201102.192502 submit/tizen_6.0_hotfix/20201103.114802 tizen_6.0.m2_release
hj kim [Mon, 5 Oct 2020 09:08:56 +0000 (18:08 +0900)]
Reduce DB locking time

foreach functions invoke callback while reading DB. It means that the DB is locked.
But sometimes applications do unexpected things in callback and it could cause a long DB lock and
prevent other apps from accessing the DB.
Therefore, saving items to the internal list and unlock the DB quickly.

Change-Id: Ideb57e53a77fa3ace74cec512ca4f3adcf149549

4 years agoFix document issue 28/245328/1
hj kim [Wed, 7 Oct 2020 06:57:43 +0000 (15:57 +0900)]
Fix document issue

Change-Id: Id86ea1d723f5cabb9cbe9483adda148af2e37b5d

4 years agoImprove __mc_service_process() 03/245303/5
hj kim [Wed, 7 Oct 2020 02:12:45 +0000 (11:12 +0900)]
Improve __mc_service_process()

Change-Id: I911f68d4782eab29ec4088d709dcdfc34422f69e

4 years agoReinforce message for debugging 10/245310/2
hj kim [Wed, 7 Oct 2020 03:56:00 +0000 (12:56 +0900)]
Reinforce message for debugging

Change-Id: I3f72dba1c9392a0e5f1545cb2bd2f371dc2e1c0c

4 years agoBug fix of sending wrong message 69/245269/5
hj kim [Tue, 6 Oct 2020 08:14:57 +0000 (17:14 +0900)]
Bug fix of sending wrong message

and change variable from int to unsigned int.
because g_queue_get_length() returns unsigned int.

Change-Id: Iecf364312b725e89ab405ca7e0ad504f09dafab4

4 years agoremove from the connection list when fail to DB updating 57/245157/6
hj kim [Mon, 5 Oct 2020 02:53:29 +0000 (11:53 +0900)]
remove from the connection list when fail to DB updating

Change-Id: I0ebc9bc99b281e084186f8bea0218f19ee73eb2b

4 years agoUse proper variable name 62/245262/4
hj kim [Tue, 6 Oct 2020 06:43:46 +0000 (15:43 +0900)]
Use proper variable name

Change-Id: I8554da73108c1b37afd2ce4b72c3124479e4ecc0

4 years agoImprove __mc_service_remove_connection() 55/245255/4
hj kim [Tue, 6 Oct 2020 05:54:50 +0000 (14:54 +0900)]
Improve __mc_service_remove_connection()

Change-Id: I65f5117b11532ed10acc51ac9a911c559145315a

4 years agoUpdate log level to get log for product 22/244922/7
hj kim [Mon, 28 Sep 2020 01:24:31 +0000 (10:24 +0900)]
Update log level to get log for product

Change-Id: I9cd72229a715f872af7090b71d6a08a04aeb9a05

4 years agofix memory leak for playlist_name 33/244833/1 accepted/tizen/unified/20200925.140231 submit/tizen/20200924.055537
jiyong.min [Thu, 24 Sep 2020 22:26:23 +0000 (07:26 +0900)]
fix memory leak for playlist_name

Change-Id: If662b1a103947c0138b6b515f4d5bf381b239b6a

4 years agoFix resource leak 32/244132/3 accepted/tizen/unified/20200917.055750 submit/tizen/20200916.012329 submit/tizen/20200917.004955
hj kim [Tue, 15 Sep 2020 07:48:44 +0000 (16:48 +0900)]
Fix resource leak

Change-Id: I0bfc4257fa11566103d0b4d8068ee986779f2890

4 years agoFix doxygen error 66/242066/2 accepted/tizen/unified/20200826.133143 submit/tizen/20200820.234531
hj kim [Mon, 24 Aug 2020 02:37:35 +0000 (11:37 +0900)]
Fix doxygen error

Change-Id: Id7c8cec3f416a9a73193b2f62ac10ebca9620cdf

4 years agoModify to prevent reuse of values from released handles 22/241322/3 accepted/tizen/unified/20200820.133526 submit/tizen/20200820.043357
jiyong.min [Wed, 19 Aug 2020 06:44:20 +0000 (15:44 +0900)]
Modify to prevent reuse of values from released handles

Change-Id: I38d37136f45e50d7c5557dea55d097a1d67ad91e

4 years agoMerge "Fix typo" into tizen accepted/tizen/unified/20200729.165651 submit/tizen/20200728.044745
Jiyong Min [Tue, 28 Jul 2020 04:47:49 +0000 (04:47 +0000)]
Merge "Fix typo" into tizen

4 years agoFix typo 77/239577/2
jiyong.min [Tue, 28 Jul 2020 01:39:05 +0000 (10:39 +0900)]
Fix typo

Change-Id: I00a62ecbe966cfcabafcb4f8b36cb15230318439

4 years agoAdd static keyword and apply tizen coding rule 42/239242/3
hj kim [Thu, 23 Jul 2020 05:01:47 +0000 (14:01 +0900)]
Add static keyword and apply tizen coding rule

Change-Id: Idd2c7aea4fe8d0ebe5b03d153a214efef4135c74

4 years agoRelease version 0.2.18 03/239103/3 accepted/tizen/unified/20200723.161255 submit/tizen/20200722.020114
jiyong.min [Wed, 22 Jul 2020 00:36:53 +0000 (09:36 +0900)]
Release version 0.2.18

Change-Id: I8d672125d14401c28fbaf70a5f08ac292d03c85e

4 years agoFix double free if goto ERROR 02/239102/3
jiyong.min [Wed, 22 Jul 2020 00:22:48 +0000 (09:22 +0900)]
Fix double free if goto ERROR

Change-Id: I6dec59425e7b3851c989112970fb83a30b90b74a

4 years agoFix double free in loop 01/239101/3
jiyong.min [Wed, 22 Jul 2020 00:16:49 +0000 (09:16 +0900)]
Fix double free in loop

Change-Id: I30a6a9f06458c1c08c11d60ec2897dbfe0f6f798

4 years agoFix 'sql_str' memory leak if 'handle' is null or 'sql_str' is empty string 96/239096/3
jiyong.min [Tue, 21 Jul 2020 23:23:40 +0000 (08:23 +0900)]
Fix 'sql_str' memory leak if 'handle' is null or 'sql_str' is empty string

Change-Id: I00febeb6285b7b37c6ae3dbb991f75dcb05d7dd3

4 years agoFix memory leak if 'latest_server_name' is empty string. 95/239095/3
jiyong.min [Tue, 21 Jul 2020 23:05:17 +0000 (08:05 +0900)]
Fix memory leak if 'latest_server_name' is empty string.

Change-Id: I9f3af6da75af0d5c77efe2c3c7d7cd0e41aada74

4 years agoFix incorrect return value 94/239094/1
jiyong.min [Tue, 21 Jul 2020 23:02:20 +0000 (08:02 +0900)]
Fix incorrect return value

Change-Id: I42af141f7f28fe201a544bb5545168310f46b8c3

4 years agoFix bug that API return invalid parameter for added enum 61/238761/1 accepted/tizen/unified/20200722.144620 submit/tizen/20200721.000647
jiyong.min [Fri, 17 Jul 2020 06:01:55 +0000 (15:01 +0900)]
Fix bug that API return invalid parameter for added enum

Change-Id: I9268809c25ad1de446988705f1b0c15713580aab

4 years agoFix wrong debug message 43/237743/1 accepted/tizen/unified/20200709.164618 submit/tizen/20200709.014949
hj kim [Fri, 3 Jul 2020 07:27:40 +0000 (16:27 +0900)]
Fix wrong debug message

Change-Id: I8191d32383bd99c3df17483b7998ff33680a39e1

4 years agoFix integer overflow for 'mc_result_code_e' 09/237709/2 submit/tizen/20200702.014328 submit/tizen/20200703.072353
jiyong.min [Fri, 3 Jul 2020 00:45:25 +0000 (09:45 +0900)]
Fix integer overflow for 'mc_result_code_e'

  - 'mc_result_code_e' enum is used as INT parameter in previous functions.
    Because 0xFFFFFFFF make integer overflow, result_code can be tainted value.
    So it is changed to INT_MAX value.

Change-Id: Ifd8b27ceed31dd55e3e106f1d7a78587354149e5

4 years agoAdded checking valid display mode 44/236844/5 accepted/tizen/unified/20200624.130217 submit/tizen/20200623.070108
jiyong.min [Fri, 19 Jun 2020 02:42:18 +0000 (11:42 +0900)]
Added checking valid display mode

Change-Id: I82e2f5688ae7ff54aade4047a19cb49ce93e569a

4 years agoFix typo 62/236862/2
hj kim [Tue, 23 Jun 2020 02:26:39 +0000 (11:26 +0900)]
Fix typo

Change-Id: I6e938c1866a4a09a7d3654c236e80e6ddb7fc5fe

4 years agoadd user_data_free_func for 'g_dbus_connection_signal_subscribe' 56/236556/2
jiyong.min [Thu, 18 Jun 2020 05:36:44 +0000 (14:36 +0900)]
add user_data_free_func for 'g_dbus_connection_signal_subscribe'

  - user_data 'listener' is potentially used in a different thread after user_data has been released
    in another thread.
    so, user_data should be passed to user_data_free_func of 'g_dbus_connection_signal_subscribe'.

Change-Id: I0f7dfc9f338857b6dc0691fc0cd08d0ffa0917fe

4 years agoRelease version 0.2.16 52/236552/1 accepted/tizen/unified/20200619.004556 submit/tizen/20200618.061012
jiyong.min [Thu, 18 Jun 2020 05:35:36 +0000 (14:35 +0900)]
Release version 0.2.16

Change-Id: I26e44e22c7974c217145408ab131af9fd4864f9e

4 years ago[ACR-1561] Add new result code and playback states 52/234352/22
jiyong.min [Mon, 25 May 2020 05:40:07 +0000 (14:40 +0900)]
[ACR-1561] Add new result code and playback states

Change-Id: I793466c7ea94a6d719fdf8a4ff38329c6d1ad9ef

5 years agoRelease version 0.2.15 83/235383/2 accepted/tizen/unified/20200608.144732 submit/tizen/20200608.024241
jiyong.min [Thu, 4 Jun 2020 06:56:26 +0000 (15:56 +0900)]
Release version 0.2.15

Change-Id: I85fdf4b4c2188b290fce9165ed2ca0ebc62cb423

5 years agoChanges dbus user_data from the listener list to a listener 82/235382/2
jiyong.min [Thu, 4 Jun 2020 06:49:12 +0000 (15:49 +0900)]
Changes dbus user_data from the listener list to a listener

  - We can specify listener for the dbus signal.
    So it is not neccesary to send whole listener list.

Change-Id: Ia27233c64a897f88933ed2cbb4d97bef6fc81c1e

5 years agoCode cleanup for replacing client handle with receiver 81/235381/2
jiyong.min [Thu, 4 Jun 2020 06:17:28 +0000 (15:17 +0900)]
Code cleanup for replacing client handle with receiver

Change-Id: I52c5cc26eda57cad43f0ef37106c5eece1e79cfe