duna.oh [Mon, 30 Sep 2024 09:00:19 +0000 (18:00 +0900)]
Use secure_getenv when available to fix untrusted source issue
Change-Id: I8c0fb08450eee9a0895fbf2437c2dd525075ef2f
duna.oh [Fri, 30 Aug 2024 09:41:01 +0000 (18:41 +0900)]
udev-seat: Replace strncmp with streq for safety
Change-Id: I80c8e93473571e99e34529ead31bd557a8d20495
JinWang An [Wed, 31 Jan 2024 07:30:07 +0000 (16:30 +0900)]
Fix std=c++14 for gtest 1.14.0 version upgrade
Change-Id: I129e8645cb5d1bda47146eed399b7ba7419561fb
Signed-off-by: JinWang An <jinwang.an@samsung.com>
Jihoon Kim [Wed, 17 Jan 2024 04:28:50 +0000 (13:28 +0900)]
Fix issues detected by static analysis tool
Change-Id: I91bedb9b89b4c6238f5c8b146ad7aa06e372d40d
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Tue, 23 May 2023 04:39:40 +0000 (13:39 +0900)]
Fix coding style
Change-Id: I5bfd5e9070a5d4bff5efd662ef8480856008fad0
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Thu, 4 Jan 2024 02:02:25 +0000 (11:02 +0900)]
update upstream branch
Change-Id: Icf35927803d59aff22084aef446e4c16cb8d1eda
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Thu, 4 Jan 2024 00:42:09 +0000 (09:42 +0900)]
packaging: Bump up to 1.24.0
Change-Id: I018bde400e3cbc7b76aa2e91334bbb5e9f00e45c
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Inhong Han [Fri, 11 Aug 2023 06:34:39 +0000 (15:34 +0900)]
Fix issue detected by static analysis tool
Change-Id: I8278954b483c0f7b848c3aa3468d14790605c147
duna.oh [Thu, 20 Jul 2023 07:03:37 +0000 (16:03 +0900)]
libinput.c: add logs for debugging in TIZEN
Change-Id: I0f5ad0fccf0c952af03e5ab4c829001f31312235
Jihoon Kim [Mon, 17 Jul 2023 09:56:53 +0000 (18:56 +0900)]
Fix issue detected by static analysis tool
Change-Id: If1b4102aabdb428771b2afc958af259cda8fb3b7
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Mon, 17 Jul 2023 04:56:38 +0000 (13:56 +0900)]
Fix issue detected by static analysis tool
Change-Id: I4dbabe8feab7a260260998f3f98fb9f532dc2fbd
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
duna.oh [Fri, 27 Jan 2023 05:37:22 +0000 (14:37 +0900)]
packaging: Bump up to 1.22.0
duna.oh [Tue, 14 Feb 2023 08:37:36 +0000 (17:37 +0900)]
haltest: fix haltest ro run properly
- keyboard devices can have either ID_INPUT_KEY OR ID_INPUT_KEYBOARD
- keyboard_events
: retrieve which keycode is available for the device and
generate key event using available keycode
- touch_events
: retrieve the ABS_MT_POSITION's resolution/max data from the device and
validate touch events using these data
duna.oh [Fri, 27 Jan 2023 07:26:43 +0000 (16:26 +0900)]
evdev: resolve memory leak
duna.oh [Tue, 12 Jul 2022 06:17:52 +0000 (15:17 +0900)]
evdev: A joystick could be ignored before opening input device
add checking if the builtin property 'ID_INPUT_JOYSTICK' is set.
Because 'LIBINPUT_IGNORE_DEVICE' is usually set by udev rule,
it may not be determined until the udev rule is parsed.
A joystick is not supported in libinput for now.
Change-Id: I19cc67538dd1ccc6f1c6f2a2dccbb96d344d40ac
Duna Oh [Tue, 8 Feb 2022 06:39:18 +0000 (15:39 +0900)]
tablet: Fix divide by zero error. 'count' could be zero
Duna Oh [Mon, 7 Feb 2022 16:31:41 +0000 (01:31 +0900)]
packagin: Bump up to 1.17.0
dyamy-lee [Mon, 26 Apr 2021 06:13:30 +0000 (15:13 +0900)]
Checking return value
When using return value from other function, it is usually checked for it.
Change-Id: I071942d9885500ce37adf08f89788d59d031d458
dyamy-lee [Mon, 26 Apr 2021 05:05:42 +0000 (14:05 +0900)]
Add Initialization of variable
Add initialization for uninitialized pointer field.
Add initialization for uninitialized value of struct field.
Change-Id: I2faf84800bf54abdff4f18a1d920b1a162a07ad0
dyamy-lee [Mon, 26 Apr 2021 05:03:27 +0000 (14:03 +0900)]
Resolve a resource leak
fd going out of scope leaks the handle. So, it add close(fd) when it unfortunately return.
Change-Id: I00caca9166b30575503efbb41522bc2d5be8c2c4
dyamy-lee [Wed, 21 Apr 2021 08:01:49 +0000 (17:01 +0900)]
Implements TouchEventCheckTest for libinput haltests
It's same way of checking MouseEventCheckTest.
For test, get lists of libinput devices and check validation of created touch event.
Only different thing with others is check it is mult touch support.
It supports multi touch, it generates libiput touch event and saves sequencely. For example, touch down, move, up.
It checkes devices capability which is touch, and checkes matching of events. If one of them checked successfully same events as created events, other touch devices can be skipped.
Change-Id: I0a60e675c14714c67debd0cfaac3c9ed80a1dc03
dyamy-lee [Wed, 21 Apr 2021 07:48:43 +0000 (16:48 +0900)]
Implements KeyboardEventCheckTest for libinput haltests
It's same way of checking MouseEventCheckTest.
For test, get lists of libinput devices and check validation of created keyboard event.
It generates libinput keyboard event and saves sequencely. For example, key down, up, key down up.
It checkes devices capability which is keyboard, and checkes matching of events. If one of them checked successfully same events as created events, other keyboard devices can be skipped.
Change-Id: I8d20d9c324331c759bcce8a14096819b681e36ff
dyamy-lee [Wed, 21 Apr 2021 07:36:59 +0000 (16:36 +0900)]
Implements MouseEventCheckTest for libinput haltests
For test, get lists of libinput devices and check validation of created mouse event.
It generates libinput mouse event and saves sequencely. For example, mouse left button down, move, up.
It checkes devices capability which is mouse, and checkes matching of events. If one of them checked successfully same events as created events, other mouse devices can be skipped.
Change-Id: Ifa06d24d0796eb3b207dc30f13b924af1804a3e1
dyamy-lee [Wed, 21 Apr 2021 07:08:45 +0000 (16:08 +0900)]
Add testing get libinput devices list for libinput haltests
For saving libinput devices list, create struct about device info(Capability, path) and function for handling libinput add event.
It only saves real devices. It means, it skips uinput device and checks property of udev device.
Change-Id: Ibf42abe728c550e40da13897c02b8abdc7235baa
dyamy-lee [Wed, 21 Apr 2021 06:44:40 +0000 (15:44 +0900)]
Add SetUp/TearDown in libinput haltests
Every test creates libinput and udev, and removes them. So, executing common logic as using SetUp/TearDown.
Change-Id: I445db460c282a6f929ac8db5a70c0aa67302f32a
dyamy-lee [Wed, 21 Apr 2021 06:35:11 +0000 (15:35 +0900)]
Add libinput haltests frame
It generate the libinput haltests rpm package successfullty for testing input devices in hal by adding build configuration and packaging configuration.
It test udev create, first. And it will be implement each device types test later.
Change-Id: I86312d798503b1816c2826df35590031d1d2305a
jeon [Wed, 6 Jan 2021 06:50:29 +0000 (15:50 +0900)]
packaging: Bump up to 1.16.1
Change-Id: Iae16b868b7d372db197e3e4197d7d6f22f37b345
INSUN PYO [Mon, 16 Nov 2020 04:57:44 +0000 (13:57 +0900)]
Fix indentation
Change-Id: I957b966407ec281bb7b91cd7ed2dc49e8a3c3802
Sung-Jin Park [Tue, 27 Oct 2020 12:07:50 +0000 (21:07 +0900)]
udev-seat: skip addition of unconfigured device by event source
Change-Id: Id7f36e62ca6f566d8b2023daa39480c6d6a9a568
Signed-off-by: Sung-Jin Park <sj76.park@samsung.com>
jeon [Wed, 17 Jun 2020 12:57:18 +0000 (21:57 +0900)]
flush touch aux events without normal touch events
Change-Id: I1a249c253a0f760b523c56cd73d3daa76a2eac0b
jeon [Thu, 12 Mar 2020 11:55:44 +0000 (20:55 +0900)]
libinput: remove build warnings
- if ENABLE_QUIRKS is not enabled,
these variables are not used.
Change-Id: Ie909526d2dc18b47d8b527a141ea59092bb8ade2
jeon [Thu, 12 Mar 2020 10:44:25 +0000 (19:44 +0900)]
udev-seat: fix a memory leak
Change-Id: Ic6aff8a80c272da3510d611c0fc31f4ace73fbaf
jeon [Thu, 12 Mar 2020 10:18:00 +0000 (19:18 +0900)]
quirks: add an option to enable/disable quirks
Change-Id: I75aef0d1b1f98b4e2491c9197d1cf8ad54c59341
jeon [Tue, 18 Feb 2020 11:35:25 +0000 (20:35 +0900)]
packaging: Bump up to 1.15.0
jeon [Thu, 9 Jan 2020 08:38:16 +0000 (17:38 +0900)]
evdev: fix a memory leak
Change-Id: Id19e03cb517286e2b7e2c127a162195f3c65726b
jeon [Fri, 3 May 2019 11:20:25 +0000 (20:20 +0900)]
evdev: filtering a BTN_TOOL_FINGER like a BTN_TOUCH
Change-Id: Iebf445657df1c3028d816f3d5ca5a925a2c571f5
JengHyun Kang [Fri, 12 Oct 2018 07:00:46 +0000 (16:00 +0900)]
evdev: free aux_data struct in fallback destroy function
Change-Id: Ief8b7ed7bf1aea714e635ca2661450b519012015
Sung-Jin Park [Mon, 20 Aug 2018 07:21:43 +0000 (16:21 +0900)]
udev-seat: add apis to set udev monitor's event source and buffer size
Change-Id: Ib41e5421c174e2d5cc26bc19f077a045ad7a2e19
Signed-off-by: Sung-Jin Park <sj76.park@samsung.com>
Sung-Jin Park [Mon, 20 Aug 2018 05:18:06 +0000 (14:18 +0900)]
udev-seat: remove unused environment variable
Change-Id: I97fa9f2fe29875dcefa3f642f6ecad695d11c555
Signed-off-by: Sung-Jin Park <sj76.park@samsung.com>
JengHyun Kang [Fri, 6 Jul 2018 06:19:48 +0000 (15:19 +0900)]
evdev: support ABS_MT_PRESSURE events
Change-Id: I9f7a4d4f6b463a396a3848059990b1a1f2174d23
Sung-Jin Park [Wed, 21 Mar 2018 08:49:30 +0000 (17:49 +0900)]
libinput-udev: fix not to install udev rules and utils
Change-Id: Ied11493e151a17407c79cd7d88fb84c2132f3ec9
Signed-off-by: Sung-Jin Park <sj76.park@samsung.com>
Sung-Jin Park [Fri, 22 Dec 2017 02:58:49 +0000 (11:58 +0900)]
udev-seat: add LIBINPUT_UDEV_SKIP_INITIAL_ENUMERATION env to enable skip udev enumeration
Change-Id: Id88d21e8d4c40d7d5a85fb68c4bbaef4dc56e7d0
Signed-off-by: Sung-Jin Park <sj76.park@samsung.com>
Sung-Jin Park [Mon, 13 Nov 2017 05:10:53 +0000 (14:10 +0900)]
libinput-util: fix logical error regarding comparison of a long variable with its maximum/minimum value
Change-Id: I9d6451a645476efb85477e6e4a9807ea136c05b4
Signed-off-by: Sung-Jin Park <sj76.park@samsung.com>
Sung-Jin Park [Mon, 13 Nov 2017 06:39:40 +0000 (15:39 +0900)]
evdev: fix integer division problem by casting one of two integers as double
Change-Id: Ice7caf41c4834b625825335c37e14266c31f5cc4
Signed-off-by: Sung-Jin Park <sj76.park@samsung.com>
JengHyun Kang [Wed, 25 Oct 2017 08:02:39 +0000 (17:02 +0900)]
fix build warnings
JengHyun Kang [Tue, 24 Oct 2017 07:39:33 +0000 (16:39 +0900)]
packaging: Bump up to 1.8.0
Change-Id: I4530bc57d1cbc9d9441f95e2e68c944ad7210794
JengHyun Kang [Tue, 5 Sep 2017 12:54:07 +0000 (21:54 +0900)]
evdev: check a null list
Change-Id: Ic281e4ff5f266bff9638f204964cc2503c7d90c8
Sung-Jin Park [Fri, 11 Aug 2017 07:34:55 +0000 (16:34 +0900)]
libinput-device-group: apply ASLR
Change-Id: I517dde04ad048cace459d23f3df63d8deb26c5c6
Signed-off-by: Sung-Jin Park <sj76.park@samsung.com>
JengHyun Kang [Wed, 7 Jun 2017 11:20:56 +0000 (20:20 +0900)]
evdev: casting unsigned int to int to compare value
Change-Id: I3c1a3da814b89af44e3d6e93bbad2cc7c2535b70
JengHyun Kang [Wed, 7 Jun 2017 11:10:07 +0000 (20:10 +0900)]
evdev: free aux_data list when device is destroy
Change-Id: I76f8df6b8fed1d01540c1430247ffc00dc28dfc5
Sung-Jin Park [Tue, 30 May 2017 06:53:19 +0000 (15:53 +0900)]
evdev: remove unreachable code and add exception handling code for aux_data_list
Change-Id: I7e2a936cece97d7a8ecce90fa261976514e35371
Signed-off-by: Sung-Jin Park <sj76.park@samsung.com>
JengHyun Kang [Tue, 25 Apr 2017 09:51:02 +0000 (18:51 +0900)]
support a AUX code events generated from EV_ABS
Change-Id: I144282f5ddc330eb77b73b3da5a36cedb6af069f
JengHyun Kang [Mon, 17 Apr 2017 09:54:11 +0000 (18:54 +0900)]
Import opensource codes for security issue. - evdev: user safe_atod to convert the matrix values
Change-Id: I140c95ca030822bf6345b09d16d445af0aebd9e5
Sung-Jin Park [Wed, 22 Mar 2017 05:27:02 +0000 (14:27 +0900)]
packaging: update packaging file to install license file via %license macro
Change-Id: I65ccb6a6357abf1a9ea060ca8c1eb3abf077d955
Signed-off-by: Sung-Jin Park <sj76.park@samsung.com>
JengHyun Kang [Fri, 9 Dec 2016 02:51:58 +0000 (11:51 +0900)]
Ignore joystick devices if LIBINPUT_IGNORE_JOYSTICK env is 1
Change-Id: I56d9cc833acad212e3d8071a79adf27bc29c19ca
JengHyun Kang [Mon, 22 Aug 2016 07:54:29 +0000 (16:54 +0900)]
evdev: Do not open the already opened device
Change-Id: I96ba5287f28dfa301628232a5a6a02f1baf1c7a2
Lisa kim [Fri, 29 Jul 2016 06:55:54 +0000 (15:55 +0900)]
Set receive buffer size from UDEV_MONITOR_BUFFER_SIZE env
Change-Id: I6adaa345ad4df6f1c3c26811b569cb0998bf0bc8
Signed-off-by: Lisa kim <hj0530.kim@samsung.com>
JengHyun Kang [Tue, 12 Jul 2016 08:52:27 +0000 (17:52 +0900)]
Call a input_set_default_property() in evdev_device_create if this function is exist
Change-Id: Ib47c6115248204d9ff63ced802c557b1bf5ad5f5
JengHyun Kang [Tue, 12 Jul 2016 02:14:03 +0000 (11:14 +0900)]
svace: Modify a strerror function to strerror_r to gurantee threads safety.
Change-Id: Iacd31adb29bb284f93aa04597d5c6ca364e0616b
Duna Oh [Mon, 18 Apr 2016 13:56:59 +0000 (22:56 +0900)]
Add a device only when the device is not created by libinput_path
Signed-off-by: Duna Oh <duna.oh@samsung.com>
Change-Id: Ic9d444cbf0d8ab95293e3770a91e31e83f405d60
JengHyun Kang [Thu, 24 Mar 2016 11:50:02 +0000 (20:50 +0900)]
Add a new API to return wheel click angle value
Change-Id: Ic45f60fd95ab7835fa92064c9badb46fe9164695
Sung-Jin Park [Fri, 11 Mar 2016 02:50:46 +0000 (11:50 +0900)]
Apply directory macros
Change-Id: I9b419f585ef8b1832fcc114720fc572869771ce3
JengHyun Kang [Fri, 26 Feb 2016 08:40:45 +0000 (17:40 +0900)]
Modify a ttrace macro name TRACE_BEGIN to TRACE_INPUT_BEGIN
Change-Id: I2559a8156056fcbd359008e0da59615ff7270c7d
JengHyun Kang [Wed, 24 Feb 2016 05:03:27 +0000 (14:03 +0900)]
Remove unnecessary ttrace and add ttrace logs to another point
Change-Id: I21c3d60d357c46df968437e22f45dcf12455ff6c
JengHyun Kang [Thu, 11 Feb 2016 06:44:36 +0000 (15:44 +0900)]
Add ttrace
Change-Id: I82a316d226c967a396f6ce5671feeafbfb37bd0f
JengHyun Kang [Thu, 7 Jan 2016 08:23:24 +0000 (17:23 +0900)]
Add a patch for support extra touch events.
- libinput commit name: add orientation and size of touch point and pressure to the API
Change-Id: Icfd09c132b51bf15837f11bdd662181e666960b5
Mun, Gwan-gyeong [Tue, 4 Aug 2015 08:03:30 +0000 (17:03 +0900)]
Add manifest for security domain policy
Change-Id: I70e41f3e4ad12035ff513fc2a322bedbaf87dd49
Gwanglim Lee [Mon, 11 May 2015 05:27:56 +0000 (14:27 +0900)]
packaging: correct installation path of udev rule files on 64bit arch
Change-Id: I26ae6192c393516e18d72b1fedc0aa1c412f164b
Philippe Coval [Mon, 23 Feb 2015 09:05:08 +0000 (10:05 +0100)]
packaging: Bump to 0.11.0
Change-Id: I68ab7b18613657814e6535261ac85fad4019122a
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Manuel Bachmann [Sat, 14 Feb 2015 15:10:57 +0000 (16:10 +0100)]
packaging: Bump to 0.8.0
Change-Id: I661837a5368f60aeeb0760c1f419fd3c457faf31
Signed-off-by: Manuel Bachmann <manuel.bachmann@open.eurogiciel.org>
Philippe Coval [Tue, 4 Nov 2014 15:31:28 +0000 (16:31 +0100)]
packaging: Bump to 0.6.0
Change-Id: Id66ecfc8dec24521687a572b699d0606b29ff4dc
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Philippe Coval [Thu, 14 Aug 2014 12:46:53 +0000 (14:46 +0200)]
packaging: Bump to 0.5.0
Change-Id: Icc00f5164583a5657e7699a686c76e49698093f2
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Philippe Coval [Thu, 14 Aug 2014 12:46:23 +0000 (14:46 +0200)]
packaging: use upstream tags
Change-Id: Ia5af4a9a3294e3359dd67f635be1c0e97a416387
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Philippe Coval [Fri, 28 Feb 2014 15:46:59 +0000 (16:46 +0100)]
packaging: Initial packaging on 0.1.0 for Tizen
Change-Id: I682fc2715f9f8a60046c5c9297b7d96173131aeb
Signed-off-by: Philippe Coval <philippe.coval@open.eurogiciel.org>
Peter Hutterer [Fri, 25 Aug 2023 03:02:58 +0000 (13:02 +1000)]
libinput 1.24.0
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Bjørn Forsman [Thu, 24 Aug 2023 17:20:47 +0000 (19:20 +0200)]
quirks: Add Wacom Bamboo Fun Pen
We must disable ABS_DISTANCE or else the automatic pressure offset
calculation doesn't work for this device.
Signed-off-by: Bjørn Forsman <bjorn.forsman@gmail.com>
Bjørn Forsman [Sat, 17 Dec 2022 16:52:39 +0000 (17:52 +0100)]
tablet: increase pressure offset limit from 20% to 50%
detect_pressure_offset() currently rejects offsets that are greater than
20%. My graphics tablet (Wacom Bamboo Fun) is about 30%. The pen tip is
2 mm. Wacom recommends replacing at 1 mm, which means this isn't worn
out yet and we should instead increase the limit to make these devices
usable.
Without this change a "pen down" event happens simultaneously with the
pen being detected -- about 1 cm above the surface -- and producing
libinput pressure of about 0.30. This means you start drawing "in the
air", without knowing up front where the cursor is going to be.
Signed-off-by: Bjørn Forsman <bjorn.forsman@gmail.com>
Yinon Burgansky [Wed, 16 Aug 2023 17:13:39 +0000 (20:13 +0300)]
docs: improve custom pointer acceleration documentation.
- Explain calculation made by the driver.
- Provide detailed example with a plot for a custom function.
- Fix inaccurate explanation of unit values.
Signed-off-by: Yinon Burgansky <yinonburgansky@gmail.com>
Peter Hutterer [Tue, 8 Aug 2023 17:25:48 +0000 (20:25 +0300)]
quirks: add quirk for the RazerBlade152023 keyboard
Autogenerated from our razer-quirks-lister.py tool
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
José Expósito [Mon, 31 Jul 2023 15:16:42 +0000 (17:16 +0200)]
quirks: Add Lenovo Legion 7i 4090 keyboard quirks
Disable while typing is not working because the keyboard uses the USB
bus.
Add the `AttrKeyboardIntegration=internal` quirk to fix it.
Fixes https://gitlab.freedesktop.org/libinput/libinput/-/issues/911
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
José Expósito [Mon, 31 Jul 2023 11:24:57 +0000 (13:24 +0200)]
quirks: AddHP Spectre x360 15 ModelTabletModeNoSuspend keyboard quirk
The HP stream x360's embedded-controller filters out events form its
builtin keyboard when in tablet-mode itself; and it has a volume up/down
on the side.
Do not suspend the keyboard when in tablet-mode so that the volume
up/down button keeps working when in tablet-mode.
Add a ModelTabletModeNoSuspend quirk so that the home button keeps
working when in tablet-mode.
This can safely be done since the rest of the keyboard gets disabled by
the embedded-controller for us.
Fixes https://gitlab.freedesktop.org/libinput/libinput/-/issues/920
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
Llerraf Gnem [Wed, 26 Jul 2023 16:41:34 +0000 (11:41 -0500)]
docs: fix "See also" link in libinput_config_accel_profile
Used to be to libinput_device_config_accel_set_points, corrected to
libinput_config_accel_set_points
Peter Hutterer [Thu, 20 Jul 2023 04:01:25 +0000 (14:01 +1000)]
Drop the Signed-off-by requirement
We've had this for roughly 10y now and it's value is dubious. Most of
xorg no longer requires, mesa accepts but doesn't require it, most of GNOME
doesn't accept it and neither does systemd.
Let's drop the requirement.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 19 Jul 2023 04:16:45 +0000 (14:16 +1000)]
Fix a few gcc analyzer complaints in util-strings.*
Sprinkle a few asserts into the various string helpers for where our
arguments must not be NULL.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 18 Jul 2023 06:04:51 +0000 (16:04 +1000)]
Fix a gcc analyzer complaint
Doesn't trigger here since we never call it with NULL but let's make
sure anyway.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 14 Jul 2023 02:57:58 +0000 (12:57 +1000)]
test: expand the tablet mode switch test to check for fake key releases
If a key is still down when the tablet mode switch goes on, make sure we
release the key before the switch goes in effect.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 4 Jul 2023 03:52:44 +0000 (13:52 +1000)]
Add a triage policy for kernel bugs
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 4 Jul 2023 02:14:04 +0000 (12:14 +1000)]
Add triage policies for merge requests
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 23 Jun 2023 04:29:49 +0000 (14:29 +1000)]
doc/user: quirks are available, not supported
This is a bit nitpicky but let's call the current quirks merely
"available" rather than "supported" since quirks should never be seen as
supported API.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 13 Jun 2023 03:12:53 +0000 (13:12 +1000)]
tablet: apply pressure offset handling for non-distance tablets
Previously we only applied pressure offset handling for tablets that
supported ABS_DISTANCE. Detecting a pressure offset when the tool
doesn't actually touch the surface is easy after all.
But tablets without distance handling may also have a pressure offset,
so let's try to detect this. This is obviously harder since the pen will
always touch the tablet's surface whenever it is in proximity and thus
will always have *some* pressure applied to it.
The process here is to merely observe the minimum pressure value during
the first two strokes of the pen. On the third prox in, that minimum
pressure value is taken as the offset. If the pressure drops below the
offset, the offset is adjusted downwards [1] so over time we'll
get closer to the pen's real offset.
[1] this is already done for distance tablets too
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Wed, 14 Jun 2023 00:59:02 +0000 (10:59 +1000)]
tablet: split proximity and axis update handling
Let's make this two conditions, this is too confusing to read otherwise.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 13 Jun 2023 02:49:05 +0000 (12:49 +1000)]
tablet: split detecting and updating the pressure offset
detect_pressure_offset() would previously update an existing offset but
otherwise skip most of the work for any event other than proximity-in
events. This was too hidden, let's split this into two functions - one
to update an existing offset and another one to detect a new offset.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 13 Jun 2023 00:56:10 +0000 (10:56 +1000)]
tablet: move setting the pressure offset into a helper function
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 13 Jun 2023 23:16:27 +0000 (09:16 +1000)]
doc/user: update the udev rule to handle bind/unbind events
Summary: we expect add, change or remove but kernel 4.12 added bind and
unbind. These events were previously discarded by udevd. Our rules should
handle any event *but* remove, so update as suggested in the announce email
linked below.
For a longer explanation, see the system 247rc2 announcement
https://lists.freedesktop.org/archives/systemd-devel/2020-November/045570.ht
See
cd37dcfa66d59ecbdf787ee1aa34bb65f2a38b6d where we did this already
for the udev rules we use ourselves.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 13 Jun 2023 05:22:26 +0000 (15:22 +1000)]
test: check that the pressure offset is reduced during motion events too
Ensure that if we do get pressure < offset that that offset is reduced
to the current pressure value.
The implementation for this is arguably buggy, reducing the pressure
means we get a tip up event since we now reach 0% of pressure. Arguably
we should enforce the tip staying down and releasing it later but since
this should typically never happen more than once per tool per context
and working around this is a lot of effort, we live with it.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 13 Jun 2023 04:43:48 +0000 (14:43 +1000)]
test: check the tablet pressure values with a helper function
Makes the code a bit easier to read. Adds precision to some tests,
slightly loosens precision in some other tests but that shouldn't matter
here.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Tue, 13 Jun 2023 03:48:03 +0000 (13:48 +1000)]
test: remove a confusing comment
We don't actually increase the pressure here, so let's not say we do
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 12 Jun 2023 03:41:53 +0000 (13:41 +1000)]
doc/user: move ignoring devices to separate page
This is way too hidden to the point where i couldn't find it for quite a
while despite knowing it exists. Move it to an entry under
troubleshooting.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Mon, 12 Jun 2023 03:31:02 +0000 (13:31 +1000)]
CODING_STYLE: drop the unintended real name policy
This was never intended as a true real name policy (and we never
actually interpreted it that way), its purpose is to identify users
and avoid commits from 12345@example.com.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Peter Hutterer [Fri, 9 Jun 2023 02:50:57 +0000 (12:50 +1000)]
man: hide debug-gui from the libinput.man page if disabled
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>