platform/upstream/connman.git
4 weeks agoFix PASSED_TO_PROC_AFTER_FREE.EX 81/319081/1 accepted/tizen_9.0_unified accepted/tizen_unified accepted/tizen_unified_toolchain accepted/tizen_unified_x accepted/tizen_unified_x_asan tizen tizen_9.0 accepted/tizen/9.0/unified/20241030.233541 accepted/tizen/unified/20241017.114727 accepted/tizen/unified/toolchain/20241022.122721 accepted/tizen/unified/toolchain/20241022.123118 accepted/tizen/unified/x/20241017.170418 accepted/tizen/unified/x/asan/20241022.113609 tizen_9.0_m2_release
Jaehyun Kim [Tue, 15 Oct 2024 03:17:17 +0000 (12:17 +0900)]
Fix PASSED_TO_PROC_AFTER_FREE.EX

Pointer 'scan_data' and 'scan_data_local' are passed to print_scan_freqs()
after the referenced memory was deallocated in set_band_freqs().

Change-Id: I683bb5ec2874716f94cc50c9a8f7b8149bd368db
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
7 weeks agoFix dereference after free in wifi band selection 72/318072/1 accepted/tizen/unified/20240925.010014 accepted/tizen/unified/toolchain/20241004.102229 accepted/tizen/unified/x/20240925.015954 accepted/tizen/unified/x/asan/20241014.000635
Jaehyun Kim [Tue, 24 Sep 2024 08:19:37 +0000 (17:19 +0900)]
Fix dereference after free in wifi band selection

Change-Id: I12475b502523ce860ede27eb00fff4c9e6c801d6
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 months agoAdd missing security type to agent request code 74/317574/1
Jaehyun Kim [Thu, 12 Sep 2024 02:27:07 +0000 (11:27 +0900)]
Add missing security type to agent request code

Change-Id: I203b51601797c634649199984f33a4c6c2f3c2ca
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 months agoCheck wpa_supplicant service when requesting network remove 19/317519/1
Jaehyun Kim [Wed, 11 Sep 2024 07:32:15 +0000 (16:32 +0900)]
Check wpa_supplicant service when requesting network remove

Change-Id: I70caeb5153f3bb0c8093ca9ef9b23adde35d50fb
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 months agoFix NULL pointer dereference 68/317368/1
Jaehyun Kim [Mon, 9 Sep 2024 12:04:18 +0000 (21:04 +0900)]
Fix NULL pointer dereference

Change-Id: Ib3f4732f7051d71179bff436feb9dffec08cb160
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 months agoMerge "Add support for VSIE from DHCP Ack packet" into tizen accepted/tizen_unified_dev accepted/tizen/unified/20240909.154243 accepted/tizen/unified/dev/20240910.111621 accepted/tizen/unified/x/20240910.014319
Jaehyun Kim [Mon, 9 Sep 2024 06:34:26 +0000 (06:34 +0000)]
Merge "Add support for VSIE from DHCP Ack packet" into tizen

2 months agodhcp: clear c_gateway and c_prefixlen before remove 94/316994/2 accepted/tizen/unified/20240904.172719 accepted/tizen/unified/x/20240905.023715
Seung-Woo Kim [Mon, 2 Sep 2024 12:41:07 +0000 (21:41 +0900)]
dhcp: clear c_gateway and c_prefixlen before remove

Before calling __connman_ipconfig_address_remove(), for specific
ipconfig->method cases, clear c_gateway and c_prefixlen to
prevent use-after-free.

Fixes: d593e995c7c7 ("dhcp: Remove old IP and gateway address")

Change-Id: Ifd171e9f9ce2a77a88953ca9ca8b6dbfec46744b
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
2 months agoAdd support for VSIE from DHCP Ack packet 99/316899/1
Jaehyun Kim [Fri, 30 Aug 2024 08:08:20 +0000 (17:08 +0900)]
Add support for VSIE from DHCP Ack packet

Change-Id: I3c5ff2fd98ef20b7deaf897f8f2741cc52ac9317
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 months agoFix memory leak during the cleanup process 78/316778/1 accepted/tizen/unified/20240829.153516 accepted/tizen/unified/dev/20240901.214807 accepted/tizen/unified/x/20240830.014108
Jaehyun Kim [Wed, 28 Aug 2024 04:37:53 +0000 (13:37 +0900)]
Fix memory leak during the cleanup process

Change-Id: I4d654211a0da8e9509b5ab1f16cbfc05e8db532b
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 months agoSupport Wi-Fi band selection for scanning 56/316356/3
Jaehyun Kim [Tue, 20 Aug 2024 05:27:33 +0000 (14:27 +0900)]
Support Wi-Fi band selection for scanning

Change-Id: I6215077d2cb467df4e56039491146062f9aca6e9
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 months agoChange the User-Agent field to Tizen 09/314309/1 accepted/tizen/unified/20240711.011516 accepted/tizen/unified/dev/20240711.085747 accepted/tizen/unified/toolchain/20240812.133553 accepted/tizen/unified/x/20240711.084640 accepted/tizen/unified/x/asan/20240813.232044
Jaehyun Kim [Wed, 10 Jul 2024 05:10:49 +0000 (14:10 +0900)]
Change the User-Agent field to Tizen

Change-Id: I0ef6e3d6972253346e962e59cdd665be9fa3f2ab
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 months agoFix unintentional reconnection on disconnect request 51/313851/1 accepted/tizen/unified/20240705.163314 accepted/tizen/unified/dev/20240708.053948 accepted/tizen/unified/x/20240708.014854
Jaehyun Kim [Tue, 2 Jul 2024 13:09:41 +0000 (22:09 +0900)]
Fix unintentional reconnection on disconnect request

If the connection is canceled due to a disconnect request
during a connection attempt, depending on the connection progress,
it may be judged as a connection failure and reconnection may be attempted
with another BSSID within the same SSID group.
However, if a disconnect request is received, reconnection should not be attempted,
so the related code has been modified to skip it.

Change-Id: I02e355a8ec504f319cf377fab07ac84e34b5fd94
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 months agoMerge "Fix crash caused by decryption response delay" into tizen accepted/tizen/unified/20240611.122656 accepted/tizen/unified/dev/20240620.010627 accepted/tizen/unified/toolchain/20240624.121746 accepted/tizen/unified/x/20240612.030026 accepted/tizen/unified/x/asan/20240625.093046
Jaehyun Kim [Wed, 22 May 2024 03:58:37 +0000 (03:58 +0000)]
Merge "Fix crash caused by decryption response delay" into tizen

5 months agoMerge "Fix crash issue when sending DHCP_FAIL signal" into tizen
Jaehyun Kim [Wed, 22 May 2024 03:58:13 +0000 (03:58 +0000)]
Merge "Fix crash issue when sending DHCP_FAIL signal" into tizen

5 months agoFix crash caused by decryption response delay 51/311451/1
Jaehyun Kim [Tue, 21 May 2024 09:09:30 +0000 (18:09 +0900)]
Fix crash caused by decryption response delay

If the interface is removed due to Wi-Fi being disabled
after a decryption request but before a response is received,
the problem occurs when the removed interface is referenced
in the reply callback.
Accordingly, it has been modified to cancel/ignore
the reply callback when WiFi is disabled.

Change-Id: Ic7effd691d066a4219f06a3ed937d5f5c6125a98
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 months agoMerge "Fix SIGSEV on freeing server domains list" into tizen
Jaehyun Kim [Fri, 17 May 2024 06:35:06 +0000 (06:35 +0000)]
Merge "Fix SIGSEV on freeing server domains list" into tizen

5 months agoFix crash issue when sending DHCP_FAIL signal 46/311446/1
Jaehyun Kim [Fri, 17 May 2024 05:34:25 +0000 (14:34 +0900)]
Fix crash issue when sending DHCP_FAIL signal

Change-Id: I8b0dfe83c9ed9d1d7b2fc118f88af5e99d77234b
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 months agoFix resource leak 61/310961/1 accepted/tizen/unified/20240513.053357 accepted/tizen/unified/x/20240514.011853
Jaehyun Kim [Fri, 10 May 2024 08:23:32 +0000 (17:23 +0900)]
Fix resource leak

Change-Id: I8da4750132045813c3c3ff79580f2394592ab91f
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 months agoFix SIGSEV on freeing server domains list 57/310857/4
Daniil Ruban [Thu, 9 May 2024 05:00:42 +0000 (07:00 +0200)]
Fix SIGSEV on freeing server domains list

- Fix changes freeing server domain list to use 'g_list_free_full' instead of for-loop

Change-Id: I0e54a96ed29505bbb1537f6779095d32314be075
Signed-off-by: Daniil Ruban <intx82@gmail.com>
6 months agoSet security value appropriate in WPA3/WPA2 mode 14/310714/1
Jaehyun Kim [Tue, 7 May 2024 06:58:17 +0000 (15:58 +0900)]
Set security value appropriate in WPA3/WPA2 mode

In mixed mode, check keymgmt_capa
and set the security value appropriate for the supported type.

Change-Id: I57c845f7b582b3f8fa0cb19513b4194ca075b4fc
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 months agoRemove WPA2 and WPA3 service together 36/310236/2 accepted/tizen/unified/20240508.124544 accepted/tizen/unified/20240508.150732 accepted/tizen/unified/toolchain/20240513.061333 accepted/tizen/unified/x/20240509.044739
Jaehyun Kim [Wed, 24 Apr 2024 08:27:27 +0000 (17:27 +0900)]
Remove WPA2 and WPA3 service together

Change-Id: I8ca4010821194027d95d1b99a9f468b464381a32
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
7 months agoSupport roaming from WPA2 to WPA3 02/309402/1
Jaehyun Kim [Tue, 9 Apr 2024 11:51:22 +0000 (20:51 +0900)]
Support roaming from WPA2 to WPA3

When the AP is switched from WPA2 to WPA3,
it will automatically reconnect if it is the same SSID.

Change-Id: I7d56d56dffe70e1b6513e1d8eadca7daea1714f1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
7 months agodnsproxy: safely access server_list_sec for removing a list node 92/309392/1 accepted/tizen/unified/20240411.142644 accepted/tizen/unified/x/20240412.023931
Seung-Woo Kim [Tue, 9 Apr 2024 08:03:48 +0000 (17:03 +0900)]
dnsproxy: safely access server_list_sec for removing a list node

Safely access g_list, server_list_sec, by finding the next list
node before removing a list node from g_slist with g_list_remove().

Change-Id: Ia60a129605b53995726c98b945936d2b87dcb97a
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
8 months agoIgnore network devices used by NBD 83/304783/5
Łukasz Stelmach [Tue, 23 Jan 2024 14:03:21 +0000 (15:03 +0100)]
Ignore network devices used by NBD

Add support for ignoring devices used by NBD to mount root the same way
ConnMan ignores devices used for NFS roots. nbdroot= nbddev= parameters
are used by Debian and Tizen initramfs scripts to configure NBD for
mounting as root device.

Change-Id: Ic30ca3110553c0646c3edb2d87a1ea8e8917b370
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
Forwarded: https://lore.kernel.org/connman/20240308143630.2195695-1-l.stelmach@samsung.com/

8 months agoFix the use of uninitialized values 22/307122/1 accepted/tizen/unified/20240307.171927 accepted/tizen/unified/x/20240311.100407
Jaehyun Kim [Tue, 5 Mar 2024 06:21:54 +0000 (15:21 +0900)]
Fix the use of uninitialized values

Change-Id: I8fa0a53426959b76fa1bb3c9f14af731b0834067
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
9 months agoAdd a missing dbus rule for DHCP state getter 32/304432/1 accepted/tizen/unified/20240119.154736 accepted/tizen/unified/toolchain/20240311.065934 accepted/tizen/unified/x/20240205.064206
Jaehyun Kim [Wed, 17 Jan 2024 08:02:12 +0000 (17:02 +0900)]
Add a missing dbus rule for DHCP state getter

Change-Id: I2e5bb536fbbeb9db670115eaac6d3792889c40c1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
9 months agoAdd a missing dbus rule for Clock interface 25/304325/1
Jaehyun Kim [Tue, 16 Jan 2024 05:14:31 +0000 (14:14 +0900)]
Add a missing dbus rule for Clock interface

Change-Id: I89517116d534248f53c85c46de7dff00e65287a8
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
10 months agoMerge "Add ApSelectionMethod config option" into tizen
Jaehyun Kim [Fri, 12 Jan 2024 06:46:18 +0000 (06:46 +0000)]
Merge "Add ApSelectionMethod config option" into tizen

10 months agoSend power off before DeviceDetected signal 77/303677/1
Jaehyun Kim [Wed, 3 Jan 2024 09:25:09 +0000 (18:25 +0900)]
Send power off before DeviceDetected signal

When the wifi module is removed,
the removed device detected signal is sent before the power off signal,
so there are cases where the power off signal is ignored
on the receiving side.

To solve this issue,
it has been modified to send the power off signal first.

Change-Id: I574bf39ac55b3c8f4555eefeb598c8d28d1a8885
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
11 months agoAdd privileges to Get/SetProperty of Technology interface 02/301602/2
Seonah Moon [Mon, 20 Nov 2023 11:38:53 +0000 (20:38 +0900)]
Add privileges to Get/SetProperty of Technology interface

Change-Id: I9943176b2df289443fd8f4898ae11212c58b2a06

12 months agoAdd ApSelectionMethod config option 37/300437/2
Jaehyun Kim [Wed, 25 Oct 2023 03:16:28 +0000 (12:16 +0900)]
Add ApSelectionMethod config option

Global config option, which allow to select the AP selection method
to use when connecting to an AP.
Existing AP selection methods have also been modified to use this option.

Change-Id: I2e3be557ac0567507f5a098205d788c5f47b2700
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
12 months agoFix memory leak 04/300204/1
Anjali Nijhara [Wed, 18 Oct 2023 10:28:01 +0000 (15:58 +0530)]
Fix memory leak

Change-Id: I6c90014c1b2ee873d2fcb425f7bfff29e55d2224

12 months agoinet: use correct type for IPv6 address 51/300051/1 accepted/tizen/unified/20231024.032139
Jaehyun Kim [Mon, 16 Oct 2023 07:54:12 +0000 (16:54 +0900)]
inet: use correct type for IPv6 address

Real types must be in_addr for AF_INET and in6_addr for AF_INET6.

Change-Id: I5183cd171e465def63fc42c0da819c342f6768e6
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
13 months agoSupport 6GHz band in wifi roaming 92/299092/1 accepted/tizen/8.0/unified/20231005.094732 accepted/tizen/unified/20230920.161454 tizen_8.0_m2_release
Jaehyun Kim [Tue, 19 Sep 2023 12:09:56 +0000 (21:09 +0900)]
Support 6GHz band in wifi roaming

Change-Id: I226f1cd43c171ef15f3ab7caff9c429f120e46bd
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
13 months agoFix dereference after null check 10/299010/1 accepted/tizen/unified/20230919.091816
Jaehyun Kim [Mon, 18 Sep 2023 07:27:06 +0000 (16:27 +0900)]
Fix dereference after null check

Change-Id: I7d5b8fbfffeb7dcc00ac0a40a0979201ce3139eb
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
14 months agoMerge "Add dbus rule for manager interface" into tizen accepted/tizen/unified/20230913.172628
Jaehyun Kim [Wed, 13 Sep 2023 09:28:11 +0000 (09:28 +0000)]
Merge "Add dbus rule for manager interface" into tizen

14 months agoMerge "Added dbus method to get whether 6GHz band is supported" into tizen
Jaehyun Kim [Wed, 13 Sep 2023 09:27:33 +0000 (09:27 +0000)]
Merge "Added dbus method to get whether 6GHz band is supported" into tizen

14 months agoMerge "Add some missing code for SAE support" into tizen
Jaehyun Kim [Wed, 13 Sep 2023 09:27:21 +0000 (09:27 +0000)]
Merge "Add some missing code for SAE support" into tizen

14 months agoMerge "Update ssid frequency only from best bss signal" into tizen
Jaehyun Kim [Wed, 13 Sep 2023 09:27:13 +0000 (09:27 +0000)]
Merge "Update ssid frequency only from best bss signal" into tizen

14 months agoAdded dbus method to get whether 6GHz band is supported 78/298678/2
Jaehyun Kim [Tue, 12 Sep 2023 07:24:59 +0000 (16:24 +0900)]
Added dbus method to get whether 6GHz band is supported

Change-Id: Ic7655ec24fa978f7225c0ccd767fb4aa93feb562
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
14 months agoAdd dbus rule for manager interface 51/298651/1
Anjali Nijhara [Tue, 12 Sep 2023 05:48:41 +0000 (11:18 +0530)]
Add dbus rule for manager interface

Change-Id: I8360b558ca431bdaa5abfe2bc25537149ef31efd

14 months agoAdd some missing code for SAE support 37/298637/1
Jaehyun Kim [Tue, 12 Sep 2023 04:38:04 +0000 (13:38 +0900)]
Add some missing code for SAE support

Change-Id: Ie47f2e19a0a2762d36d01e9373c2bd9c8ecc8053
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
14 months agoAdd connman ISU package 21/294521/11
Adam Michalski [Wed, 7 Jun 2023 08:01:34 +0000 (10:01 +0200)]
Add connman ISU package

This commit adds Individual Service Upgrade (ISU) feature to connman package.
When installed it will allow to upgrade this service using the ISU mechanism,
without the need to perform a full OS Upgrade.

This commit adds necessary configuration to create upgrade packages of the
needed format. ISU framework itself is maintained and installed separately.

Change-Id: I75eb0fa2592b2d2541f1d0df05fce96ce6c0cc62

14 months agoUpdate ssid frequency only from best bss signal 59/298459/3
Jaehyun Kim [Thu, 7 Sep 2023 07:37:12 +0000 (16:37 +0900)]
Update ssid frequency only from best bss signal

Only changes to the best bssid update the frequency of the ssid network info.
If not, the bssid and frequency of the actual connection target may not match.

Change-Id: Ic02dc87526b2526eaf340f00fdbb1cbe0f31c172
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
14 months agofix dereferencing Issue 31/297631/1
Anjali Nijhara [Tue, 22 Aug 2023 05:58:44 +0000 (11:28 +0530)]
fix dereferencing Issue

Change-Id: I93cd72ce9e6b08d33397275feb4b8bf4ecb585c1

14 months agoRefactor Code 28/297628/1
Anjali Nijhara [Tue, 22 Aug 2023 05:22:58 +0000 (10:52 +0530)]
Refactor Code

Change-Id: Icb3ce5439ec50b7e365cc3ca697c82e2eeab6358

14 months agoMerge "Add macros for DHCP_FAIL and DHCP_STARTED" into tizen
Jaehyun Kim [Fri, 18 Aug 2023 04:49:09 +0000 (04:49 +0000)]
Merge "Add macros for DHCP_FAIL and DHCP_STARTED" into tizen

14 months agoMerge "Remove redundant code" into tizen
Jaehyun Kim [Fri, 18 Aug 2023 04:43:38 +0000 (04:43 +0000)]
Merge "Remove redundant code" into tizen

14 months agoMerge "Use estimated throughput for wifi roaming" into tizen
Jaehyun Kim [Fri, 18 Aug 2023 04:43:36 +0000 (04:43 +0000)]
Merge "Use estimated throughput for wifi roaming" into tizen

15 months agoAdd macros for DHCP_FAIL and DHCP_STARTED 18/296718/1
Anjali Nijhara [Thu, 3 Aug 2023 10:11:52 +0000 (15:41 +0530)]
Add macros for DHCP_FAIL and DHCP_STARTED

Change-Id: I32319cdca722f80d8b978f11b458f52a08de6473

15 months agoRemove redundant code 29/296429/1
Jaehyun Kim [Thu, 27 Jul 2023 08:49:58 +0000 (17:49 +0900)]
Remove redundant code

Change-Id: I1f50f164dbf4177c8947a0850b16fdd17a6f1b01
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
15 months agoMerge "Fix coverity Issue CID-1693301" into tizen accepted/tizen/unified/20230727.055136
Jaehyun Kim [Wed, 26 Jul 2023 05:45:49 +0000 (05:45 +0000)]
Merge "Fix coverity Issue CID-1693301" into tizen

15 months agoFix coverity Issue CID-1693301 95/296195/2
Anjali Nijhara [Fri, 21 Jul 2023 11:06:39 +0000 (16:36 +0530)]
Fix coverity Issue CID-1693301

Change-Id: Ia75402b4de99b31523f571a6200c8e4bc2210ef6

15 months agoFix coverity Issue CID-1692262 17/296217/2
Anjali Nijhara [Mon, 24 Jul 2023 03:54:44 +0000 (09:24 +0530)]
Fix coverity Issue CID-1692262

Change-Id: Ia45533390db7c75d1b8604059d8f1d1b26e0fe14

15 months agoUse estimated throughput for wifi roaming 77/295977/3
Jaehyun Kim [Tue, 18 Jul 2023 04:21:45 +0000 (13:21 +0900)]
Use estimated throughput for wifi roaming

Added setting options for minimum roaming conditions,
and use estimated throughput for AP-to-AP comparisons.

Change-Id: Ie4eb5930a0511e252f16169c31b439c9f37cba33
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
16 months agoMerge "Merge tag 'upstream/1.41' into tizen" into tizen accepted/tizen/unified/20230705.063745
Jaehyun Kim [Mon, 3 Jul 2023 12:32:07 +0000 (12:32 +0000)]
Merge "Merge tag 'upstream/1.41' into tizen" into tizen

16 months agoAdd default NTP server in "/var/lib/connman/settings" file 34/294434/1 accepted/tizen/unified/20230628.023643
Anjali Nijhara [Mon, 19 Jun 2023 08:02:04 +0000 (13:32 +0530)]
Add default NTP server in "/var/lib/connman/settings" file

Change-Id: I57035ce418730c570f562ec690db7f278f0cc0e7

17 months agoDo not include related code if INS is not enabled 17/293817/1 accepted/tizen/unified/20230616.172359
Jaehyun Kim [Mon, 5 Jun 2023 14:40:19 +0000 (23:40 +0900)]
Do not include related code if INS is not enabled

Change-Id: I40240a9c01a5e278c7d48ae104a8d7c0c9f7b282
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
17 months agoAdd a dbus method for DHCP status 99/293799/1
Jaehyun Kim [Mon, 5 Jun 2023 07:19:22 +0000 (16:19 +0900)]
Add a dbus method for DHCP status

Change-Id: Ibb590f234c4db807add7cd5edf7a83c081579618
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
17 months agoDo not create config file for ext properties 20/293420/1
Jaehyun Kim [Fri, 26 May 2023 08:38:24 +0000 (17:38 +0900)]
Do not create config file for ext properties

If the service config file does not exist when saving the extended
properties, creating a new config file will create a file
containing only the extended properties.
This is obviously an invalid file and should be handled with
an ERROR in such case.

Change-Id: Ia34da215e1b8a704d16cda572df1acd6d037b3e9
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
17 months agoclock: Fix TimeserverSynced property updation 05/293405/1
Jaehyun Kim [Fri, 26 May 2023 04:27:35 +0000 (13:27 +0900)]
clock: Fix TimeserverSynced property updation

Change-Id: I3c66fcf7c639d6a12bbba3e57c153a9c9c712e16
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
19 months agoFix crash issue when passphrase decryption fails 53/290753/2
Jaehyun Kim [Fri, 31 Mar 2023 13:38:29 +0000 (22:38 +0900)]
Fix crash issue when passphrase decryption fails

If the decryption request is successful
and there is an error in response,
memory is not allocated to the data->sid->passphrase.
However, even in this case, it is freed and it cause a crash.
So it has been modified to free only when memory is allocated.

In addition to this, there are other variables
that have similar problems,
so the related codes have also been modified.

Change-Id: If83febbccfcff82cf83279f7186df73aaee0854c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
20 months agoMerge tag 'upstream/1.41' into tizen 15/289915/1
Anjali Nijhara [Wed, 15 Mar 2023 09:24:24 +0000 (14:54 +0530)]
Merge tag 'upstream/1.41' into tizen

Change-Id: I7e90773484901c50e61d243f97d916f5588da9c5

20 months agoImported Upstream version 1.41 86/289886/1 upstream/1.41
Anjali Nijhara [Wed, 15 Mar 2023 06:29:53 +0000 (11:59 +0530)]
Imported Upstream version 1.41

Change-Id: Ida2a62a81c771f833353d1a9a77604e6f2b06b88

20 months agoDA: Fix Profile Save Issue in case of Association Failed 94/289094/3 accepted/tizen/unified/20230315.093511
Anjali Nijhara [Wed, 1 Mar 2023 04:40:44 +0000 (10:10 +0530)]
DA: Fix Profile Save Issue in case of Association Failed

Change-Id: I00ddc53353782da130d58c613fda66ee99694865

22 months agoAdd a dbus signal and a property for DHCP status 58/286658/1 accepted/tizen/7.0/unified/20230118.093741
Jaehyun Kim [Wed, 11 Jan 2023 09:28:18 +0000 (18:28 +0900)]
Add a dbus signal and a property for DHCP status

Signal for DHCP start point has been added.
And the interface name is also delivered to distinguish devices.

Change-Id: I30ac4a48309c5324efb66a36c9dd431e0c847f5e
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
22 months agoUpdate client help description for nameservers 38/286238/1
Jaehyun Kim [Mon, 2 Jan 2023 09:46:59 +0000 (18:46 +0900)]
Update client help description for nameservers

Nameserver configuration method can be changed via connmanctl,
but there is no such information in help description.
So help description for nameservers is updated.

Change-Id: I446daa5ed19fbfecc8b58387f37e81a894579bc7
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
22 months agoAdd a missing dbus rule for Manager interface 04/285804/1 accepted/tizen/7.0/unified/20221226.020029
Jaehyun Kim [Tue, 20 Dec 2022 10:30:53 +0000 (19:30 +0900)]
Add a missing dbus rule for Manager interface

Change-Id: Id2ce7ea7bbfa0e1da35ae6d40264ea21712fb55d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
23 months agoDA: Modify DHCP request retries count 98/285398/1 accepted/tizen/7.0/unified/20221216.024728
Jaehyun Kim [Mon, 12 Dec 2022 06:18:05 +0000 (15:18 +0900)]
DA: Modify DHCP request retries count

Change-Id: Ib8a332412a954992d20d5f9db3fcd9d0f23eb9e4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
23 months agoDA: Fix build warnings 95/285395/2
Jaehyun Kim [Mon, 12 Dec 2022 06:00:59 +0000 (15:00 +0900)]
DA: Fix build warnings

Change-Id: I7034b55da0b5c364ec5dbbc0395465e700dc3f75
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
23 months agoAdd exception handling for null best_bss 84/285384/1
Jaehyun Kim [Mon, 12 Dec 2022 01:44:25 +0000 (10:44 +0900)]
Add exception handling for null best_bss

Change-Id: Idfed20c90265d4e3df4cd2011a46ff52a72f2872
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
23 months agoSupport PSK_SHA256 for ieee80211w 58/285158/1 accepted/tizen/7.0/unified/20221209.015645
Jaehyun Kim [Wed, 7 Dec 2022 04:25:30 +0000 (13:25 +0900)]
Support PSK_SHA256 for ieee80211w

Change-Id: I4017d2b245a9a5a65fcbbd4ca6c31f45e98b77f2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoDA: Reduce debug log 32/283632/1 accepted/tizen/7.0/unified/20221206.171101
Jaehyun Kim [Mon, 31 Oct 2022 14:10:18 +0000 (23:10 +0900)]
DA: Reduce debug log

Don't print service sorting.

Change-Id: I23eab48c293b850a710596b220997afee54bca3d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoDA: Skip initializing failed_bssids list when eapol failure case 31/283631/1
Jaehyun Kim [Mon, 31 Oct 2022 14:00:17 +0000 (23:00 +0900)]
DA: Skip initializing failed_bssids list when eapol failure case

This modification is to prevent attempts to connect to only one bssid continuously
during an eapol failure in a multi bssid environment.

Change-Id: I2f5d0dea895f0f3b39bd0e0b15c59db391973b10
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoDA: Fix crash issue 30/283630/1
Jaehyun Kim [Mon, 31 Oct 2022 13:32:57 +0000 (22:32 +0900)]
DA: Fix crash issue

Change-Id: Ic46cbf033a7f9ff1b5149b9fceb08bb3cfe2a97a
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoDA: Standard error for customer self-diagnosis 29/283629/1
Jaehyun Kim [Mon, 31 Oct 2022 13:28:44 +0000 (22:28 +0900)]
DA: Standard error for customer self-diagnosis

Change-Id: Ie222bb43c0128362324db57554fb9bba3fa7f140
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoDA: Modify INS score source code 28/283628/1
Jaehyun Kim [Mon, 31 Oct 2022 13:03:14 +0000 (22:03 +0900)]
DA: Modify INS score source code

1. Modify wrong INS source code & add debug log
2. If INS score is same, align according to the signal strength.

Change-Id: I7dc469ab13c5dbf6bbae020ba711e5f15acd1fb4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoDA: Change connection error type AUTH_FAILED to INVALID_KEY in case of SAE 27/283627/1
Jaehyun Kim [Mon, 31 Oct 2022 12:19:41 +0000 (21:19 +0900)]
DA: Change connection error type AUTH_FAILED to INVALID_KEY in case of SAE

Change connman_service_error type from CONNMAN_SERVICE_ERROR_AUTH_FAILED
to CONNMAN_SERVICE_ERROR_INVALID_KEY in case of SAE security type.

Change-Id: Ia276f8da2d83e845b7431a1b89d27fe939d01536
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoDA: Set ignore field as true when assoc fails 26/283626/1
Jaehyun Kim [Mon, 31 Oct 2022 12:14:22 +0000 (21:14 +0900)]
DA: Set ignore field as true when assoc fails

Change-Id: Icec37d4758a2637acb8b1c3586c1900747d806f4
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoDA: Add exception check for time logic 24/283624/1
Jaehyun Kim [Mon, 31 Oct 2022 11:46:26 +0000 (20:46 +0900)]
DA: Add exception check for time logic

1. Ignore next time server if current time server string is empty.
2. Check time_updates_config before set time.

Change-Id: Ifd617686b9eb25d75350d0af3a0f592c7d85ffed
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoDA: Add DHCP state notify function 20/283620/2
Jaehyun Kim [Mon, 31 Oct 2022 11:07:34 +0000 (20:07 +0900)]
DA: Add DHCP state notify function

Change-Id: Ie4408b5db690133c74f05dcf3fb94b5dd8eee4df
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoRemove useless network path of the wifi interface when removing network 69/283569/1
Jaehyun Kim [Sat, 29 Oct 2022 05:33:50 +0000 (14:33 +0900)]
Remove useless network path of the wifi interface when removing network

When removing a network, if the network path of the interface is not NULL
and has the same information as the network to be removed, it need to be removed.

Otherwise, when a connection to the same network is attempted later,
the connection may not work normally.

Change-Id: Ia1702c05bb19c581b31070fbc7741a846d87a6ee
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoCheck dbus path before constructing AddNetwork message 71/282371/1 accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/20221110.061230 accepted/tizen/7.0/unified/hotfix/20221116.110650 accepted/tizen/unified/20221005.023218 tizen_7.0_m2_release
Jaehyun Kim [Fri, 30 Sep 2022 09:01:12 +0000 (18:01 +0900)]
Check dbus path before constructing AddNetwork message

>0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
>1  0xb6bf0788 in __GI_abort () at abort.c:79
>2  0xb6e63a9c in _dbus_abort () at dbus-sysdeps.c:93
>3  0xb6e58278 in _dbus_warn_check_failed (format=0xb6e69e1c "arguments to %s() were incorrect, assertion \"%s\" failed in file %s line %d.\nThis is normally a bug in some application using the D-Bus library.\n") at dbus-internals.c:281
>4  0xb6e58980 in _dbus_warn_return_if_fail (function=<optimized out>, assertion=<optimized out>, file=<optimized out>, line=line@entry=1582) at dbus-internals.c:936
>5  0xb6e47c7c in dbus_message_new_method_call (destination=0x51a004 "fi.w1.wpa_supplicant1", path=path@entry=0x6bebf8 "", iface=iface@entry=0x519fa8 "fi.w1.wpa_supplicant1.Interface", method=method@entry=0x51a4c8 "AddNetwork") at dbus-message.c:1582
>6  0x004bdbda in supplicant_dbus_method_call (path=0x6bebf8 "", interface=0x519fa8 "fi.w1.wpa_supplicant1.Interface", method=0x51a4c8 "AddNetwork", setup=0x4baf7d <interface_add_network_params>, function=0x4b985d <interface_add_network_result>, user_data=user_data@entry=0x6d05f0, caller=0x6d9900) at gsupplicant/dbus.c:508
>7  0x004b64d8 in decryption_request_reply (call=0x6b25c0, user_data=0x6d05f0) at gsupplicant/supplicant.c:7653
...

Change-Id: Ib65368a6a43c81376ae65bd5338d796bc7ad755c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoSupport ft-psk and ft-sae connection 98/281498/2 accepted/tizen/unified/20220923.052717
Jaehyun Kim [Mon, 19 Sep 2022 12:49:30 +0000 (21:49 +0900)]
Support ft-psk and ft-sae connection

Change-Id: I05d8d3934a8a75c874b41cb44654b7bc61b34060
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoFix dereferencing issues 17/281417/1 accepted/tizen/unified/20220920.110641
Jaehyun Kim [Fri, 16 Sep 2022 14:13:01 +0000 (23:13 +0900)]
Fix dereferencing issues

Change-Id: I8ec97355b5ebf673d792339a7d0a2911392d6a89
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoFix crash when disabling connected wifi 35/280835/1 accepted/tizen/unified/20220908.172942
Jaehyun Kim [Mon, 5 Sep 2022 12:39:51 +0000 (21:39 +0900)]
Fix crash when disabling connected wifi

This issue is caused by trying to access invalid
connman_network when wifi is disabled.
In this case, there is no need to reset the value.

Change-Id: I3137ba91a11086ae5e8f8f976dc52f84d62d4975
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoMaintain connection status when wifi roaming 36/280036/1 submit/tizen/20220829.114301 submit/tizen/20220902.085939
Jaehyun Kim [Mon, 22 Aug 2022 17:15:07 +0000 (02:15 +0900)]
Maintain connection status when wifi roaming

When wifi roaming, the current connection status is maintained.
If the network is changed, the connection status is reset.

Change-Id: I2680030c849c712b7d7dc68f70397514484a7fc3
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoCheck dbus path before constructing a new message 67/279067/3 accepted/tizen/unified/20220802.144710 submit/tizen/20220802.050734
Jaehyun Kim [Mon, 1 Aug 2022 11:34:24 +0000 (20:34 +0900)]
Check dbus path before constructing a new message

>0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50 --> glibc (rpm)
>1  0xf7248780 in __GI_abort () at abort.c:79 --> glibc (rpm)
>2  0xf74ba7ac in _dbus_abort () at dbus-sysdeps.c:93 --> dbus-libs (rpm)
>3  0xf74af0d0 in _dbus_warn_check_failed (format=0xf74c05fc "arguments to %s() were incorrect, assertion \"%s\" failed in file %s line %d.\nThis is normally a bug in some application using the D-Bus library.\n") at dbus-internals.c:281 --> dbus-libs (rpm)
>4  0xf74af7d8 in _dbus_warn_return_if_fail (function=<optimized out>, assertion=<optimized out>, file=<optimized out>, line=line@entry=1582) at dbus-internals.c:936 --> dbus-libs (rpm)
>5  0xf749eba0 in dbus_message_new_method_call (destination=0xaacc16a4 "fi.w1.wpa_supplicant1", path=path@entry=0xac126b78 "", iface=iface@entry=0xaacc1648 "fi.w1.wpa_supplicant1.Interface", method=method@entry=0xaacc1b40 "AddNetwork") at dbus-message.c:1582 --> dbus-libs (rpm)
>6  0xaac671d8 in supplicant_dbus_method_call (path=0xac126b78 "", interface=0xaacc1648 "fi.w1.wpa_supplicant1.Interface", method=0xaacc1b40 "AddNetwork", setup=0xaac64605 <interface_add_network_params>, function=0xaac62fb1 <interface_add_network_result>, user_data=user_data@entry=0xac125138, caller=0xac13ef30) at gsupplicant/dbus.c:505 --> connman (rpm)
>7  0xaac5faee in decryption_request_reply (call=0xac12b080, user_data=0xac125138) at gsupplicant/supplicant.c:7629 --> connman (rpm)

Change-Id: I87558f1894607bea53ecf7b3602f16d1e5aae5ac
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoFix derefrencing of invalid pointer 93/275893/1 accepted/tizen/unified/20220620.131713 submit/tizen/20220617.053331
Jaehyun Kim [Sun, 5 Jun 2022 11:39:41 +0000 (20:39 +0900)]
Fix derefrencing of invalid pointer

Change-Id: I1414eb584a0644423aef07511f68c0be4b63c911
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoTry to connect to another bssid in AUTH or ASSOCICATED failure case 90/275890/2
Jaehyun Kim [Sat, 4 Jun 2022 14:55:17 +0000 (23:55 +0900)]
Try to connect to another bssid in AUTH or ASSOCICATED failure case

When attempting to connect to an AP with multiple bssids,
if it fails in the AUTHENTICATING or ASSOCIATED state,
the connection continues to be attempted with the same bssid.
In this case, it has been modified to try to connect to another bssid.

Change-Id: Ied521e01c71e8c6c916d56dc825578d8edd20e0c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agowispr: Prevent use-after-free from __connman_wispr_stop() 63/275463/2 accepted/tizen/unified/20220530.140608 submit/tizen/20220527.121228
Seung-Woo Kim [Tue, 24 May 2022 09:59:21 +0000 (18:59 +0900)]
wispr: Prevent use-after-free from __connman_wispr_stop()

From __connman_wispr_stop(), list element wispr_portal freed by
g_hash_table_remove() is accessed. Prevent the use-after-free by
accessing the list element before free.

Change-Id: I17fdb38c1d9a0f8dd2980c33d3f78f319f504ed6

2 years agoFix memory leak when loading global settings 49/275449/2
Jaehyun Kim [Wed, 25 May 2022 04:24:41 +0000 (13:24 +0900)]
Fix memory leak when loading global settings

Change-Id: Ie7d00c2f856d2d6d8e7ea86d17c013e787259680
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoReinitialize the va_list when reusing it 32/274932/1 accepted/tizen/unified/20220524.050402 submit/tizen/20220517.032302
Jaehyun Kim [Thu, 12 May 2022 07:59:13 +0000 (16:59 +0900)]
Reinitialize the va_list when reusing it

Change-Id: I4ae7c752c09f328cba522b25f8acb05e80425cef
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoAdd main.conf for robot profile 13/273813/1 accepted/tizen/unified/20220415.130340 submit/tizen/20220414.094032
Jaehyun Kim [Thu, 14 Apr 2022 04:25:20 +0000 (13:25 +0900)]
Add main.conf for robot profile

Change-Id: Ifa2f0c8ab1bbb5925bc468206ed0fe0c8b743489
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
2 years agoFix EAP-TLS Wi-Fi connection issue 66/272466/1
Niraj Kumar Goit [Thu, 17 Mar 2022 06:48:56 +0000 (12:18 +0530)]
Fix EAP-TLS Wi-Fi connection issue

Change-Id: I70fd374d89488e1d30f489356a5d8a4041c5f491
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoFix wifi connection issue post invalid-key error occurs. 14/272314/2 accepted/tizen/unified/20220315.132317 submit/tizen/20220314.173759
Anjali Nijhara [Mon, 14 Mar 2022 11:10:24 +0000 (16:40 +0530)]
Fix wifi connection issue post invalid-key error occurs.

Change-Id: I7a9c7184502a3a74a8be6e92be7c08d41b878612

2 years agoModified vpn/vpn-dbus.conf file 16/271916/1 submit/tizen/20220304.063107 submit/tizen/20220310.020044
Anjali Nijhara [Thu, 3 Mar 2022 06:33:03 +0000 (12:03 +0530)]
Modified vpn/vpn-dbus.conf file

Change-Id: Ic2dbd5445cf89d8ad7e54787d14f4ff690b9c89c
Signed-off-by: Anjali Nijhara <a.nijhara@samsung.com>
2 years agoMerge tag 'upstream/1.40' into tizen. 79/271279/4 submit/tizen/20220224.061208
Niraj Kumar Goit [Thu, 17 Feb 2022 16:13:13 +0000 (21:43 +0530)]
Merge tag 'upstream/1.40' into tizen.

Change-Id: I4ed89827d776db6eeec11878bc1cd0cd6c5e1e80
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Signed-off-by: Anjali Nijhara <a.nijhara@samsung.com>
2 years agoImported Upstream version 1.40 64/271064/1 upstream/1.40
Niraj Kumar Goit [Tue, 15 Feb 2022 04:53:07 +0000 (10:23 +0530)]
Imported Upstream version 1.40

Change-Id: Id3e405d088ee3fb19fd0ca049e1cb7f812b40fca
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
2 years agoAdd support to get PMF information 31/271031/1 accepted/tizen/unified/20220216.175734 submit/tizen/20220215.060643
Jaehyun Kim [Mon, 14 Feb 2022 10:16:29 +0000 (19:16 +0900)]
Add support to get PMF information

Change-Id: I7286c346750504175e24cbb569404e586b309a85
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>