platform/core/connectivity/bluetooth-frwk.git
5 weeks agoFix coverity issue (resource leak) 22/323822/1 accepted/tizen_unified accepted/tizen_unified_x tizen accepted/tizen/unified/20250509.015130 accepted/tizen/unified/x/20250509.034525
Wootak Jung [Thu, 8 May 2025 01:06:55 +0000 (10:06 +0900)]
Fix coverity issue (resource leak)

Change-Id: Ie4e63c621ff0bbe4d1e985c5aaf8430dae8c00cb
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
6 weeks agoFix check logic for terminated app names 68/323368/1
Wootak Jung [Mon, 28 Apr 2025 01:39:11 +0000 (10:39 +0900)]
Fix check logic for terminated app names

If the registered name is :1.32 and the terminated app name is :1.329,
it should return mismatched.

Change-Id: If37e63346fcfb752a5859e4d6b887aaa5c5204f2
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
7 weeks agoFix the EIR manufacturer data length issue 14/323014/1
Wootak Jung [Tue, 22 Apr 2025 01:20:20 +0000 (10:20 +0900)]
Fix the EIR manufacturer data length issue

max length should be 240 not 31

Change-Id: I81fac2df62443b32845f50036ec52f9a5049a077

2 months agoFix crash issue when bond fails 56/322256/1 accepted/tizen/unified/20250410.082844 accepted/tizen/unified/x/20250410.094253
Wootak Jung [Mon, 7 Apr 2025 05:27:24 +0000 (14:27 +0900)]
Fix crash issue when bond fails

Change-Id: I7fa055f3c6e341abbe77bf762a8a36aedb727aeb
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
2 months agoAdd new DA model types 18/321618/1
Wootak Jung [Tue, 25 Mar 2025 06:03:21 +0000 (15:03 +0900)]
Add new DA model types

- Water Purifier(AI Home)
- Wine Cellar(AI Vision)

Change-Id: I210972e037903c589e22f1364e9951cae6c179e9
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
2 months agoFix issue where StartNotify method comes before gatt connected 11/321311/1 accepted/tizen/unified/20250320.120245 accepted/tizen/unified/x/20250320.221634
Sohyeon Choi [Tue, 18 Mar 2025 05:27:42 +0000 (14:27 +0900)]
Fix issue where StartNotify method comes before gatt connected

Change-Id: I1ecbb81d92473145f16a081b08564772363d2e31
Signed-off-by: Sohyeon Choi <shss.choi@samsung.com>
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
2 months agoFix auto-pair-blacklist file size continuing to grow when bond fails 84/321284/1
Wootak Jung [Tue, 18 Mar 2025 08:24:50 +0000 (17:24 +0900)]
Fix auto-pair-blacklist file size continuing to grow when bond fails

Change-Id: Ida1339cb7053055edcf03a736c00a0a51347a142
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
3 months agoFix memory leak issue 79/320579/1 accepted/tizen/unified/20250306.045603 accepted/tizen/unified/x/20250306.064051
Wootak Jung [Wed, 5 Mar 2025 04:18:16 +0000 (13:18 +0900)]
Fix memory leak issue

Change-Id: I2fdf8d9c06458c47ae81e52fd88eceb32e98aac7
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
3 months agoFix the wrong log messages 78/320578/1
Wootak Jung [Fri, 10 Jan 2025 02:09:03 +0000 (11:09 +0900)]
Fix the wrong log messages

Change-Id: I190554ab351ddeb34a2cd51d546506717fa699bb
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
3 months agoFix memory leak when creating method node 77/320577/1
Wootak Jung [Tue, 24 Dec 2024 00:49:53 +0000 (09:49 +0900)]
Fix memory leak when creating method node

Change-Id: I5f3b52867c4bd420603ead98ce668dfd16ae701f

3 months agoget device type instead of model name to check DA devices 76/320576/1
Sohyeon Choi [Mon, 23 Dec 2024 02:22:21 +0000 (11:22 +0900)]
get device type instead of model name to check DA devices

Change-Id: Iea47c7e3021278b7ba7acd2b2499a066acceea6f
Signed-off-by: Sohyeon Choi <shss.choi@samsung.com>
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
4 months agoFix SVACE issue 47/318747/1 accepted/tizen/unified/20250226.044804 accepted/tizen/unified/x/20250226.132026
Anuj Jain [Thu, 23 Jan 2025 06:27:56 +0000 (11:57 +0530)]
Fix SVACE issue

This patch fixes SVACE issue: 224708

Change-Id: I0d291117a4f37bec0839a6961db47fae1e962629
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
5 months agoFix blocking issue when calling recvmsg 99/317599/1
Wootak Jung [Mon, 6 Jan 2025 00:03:19 +0000 (09:03 +0900)]
Fix blocking issue when calling recvmsg

Change-Id: Iaf09449b3015e91af585e0156280ae23365ee667
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
5 months agoAdd the exception handle logic for socket fd is -1 63/317563/1 accepted/tizen_unified_x_asan accepted/tizen/unified/20250106.154425 accepted/tizen/unified/x/20250106.211619 accepted/tizen/unified/x/asan/20250113.002000
Dohyun Pyun [Mon, 30 Dec 2024 01:19:21 +0000 (10:19 +0900)]
Add the exception handle logic for socket fd is -1

Change-Id: I5e682c59687a7d6661ace45998d02107399abd5a
Signed-off-by: Dohyun Pyun <dh79.pyun@samsung.com>
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
5 months agoIncrease the version to 10.0 30/316830/1 accepted/tizen/unified/20241224.130050 accepted/tizen/unified/x/20241224.221615
Wootak Jung [Wed, 18 Dec 2024 08:48:29 +0000 (17:48 +0900)]
Increase the version to 10.0

Change-Id: I3706d6539f7305fe32e48bf13bd30266af568d02
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
5 months agoFix issue where WriteValue/AcquireNotify method comes before gatt connected #2 97/316797/1
Wootak Jung [Mon, 16 Dec 2024 01:25:41 +0000 (10:25 +0900)]
Fix issue where WriteValue/AcquireNotify method comes before gatt connected #2

Change-Id: Ic4e5866054e6df682a8be09401675bc294339ed8
Signed-off-by: Sohyeon Choi <shss.choi@samsung.com>
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
5 months agoFix scan filter issue for manufacturer data 96/316796/1
Wootak Jung [Mon, 16 Dec 2024 01:23:29 +0000 (10:23 +0900)]
Fix scan filter issue for manufacturer data

Change-Id: I0f2e509f6d2bd1a7e284a9df6356eff45e2cfa1e
Signed-off-by: Sohyeon Choi <shss.choi@samsung.com>
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
5 months agoFix BT_BOND_DEVICE_BY_TYPE request timeout issue 95/316795/1
Wootak Jung [Thu, 28 Nov 2024 23:55:45 +0000 (08:55 +0900)]
Fix BT_BOND_DEVICE_BY_TYPE request timeout issue

Change-Id: If416aa7756f76136f041c8f13300bf9c6f278680
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
5 months agoFix bt_gatt_server_register_service() fail issue 94/316794/1
Wootak Jung [Fri, 29 Nov 2024 00:28:50 +0000 (09:28 +0900)]
Fix bt_gatt_server_register_service() fail issue

Failed to register GATT service in two processes

Change-Id: I910fa460ff7d0e32416144778e6501077b3b65d4
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
5 months agoFix issue where pb get size fail event does not occur 93/316793/1
Wootak Jung [Fri, 8 Nov 2024 04:51:40 +0000 (13:51 +0900)]
Fix issue where pb get size fail event does not occur

Change-Id: I86aebb41b4fffca9ecdcc8815ec5c63ba86c4e8b
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
5 months agoAdd new DA model name 92/316792/1
Wootak Jung [Thu, 10 Oct 2024 07:42:50 +0000 (16:42 +0900)]
Add new DA model name

AI Home*

Change-Id: If2ffbe081ad74c9bd6d005420e25b9a968157184

5 months agoFix app crash issue when notification register fails 91/316791/1
Wootak Jung [Thu, 8 Aug 2024 06:50:55 +0000 (15:50 +0900)]
Fix app crash issue when notification register fails

Change-Id: I9ac5e5d10fc63b0db41ad0a7c5e327286ffdb729
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
6 months agoChange LOG_TAG to be shorter 78/315578/2
Wootak Jung [Tue, 3 Dec 2024 07:49:45 +0000 (16:49 +0900)]
Change LOG_TAG to be shorter

Change-Id: Ic1d6bc76e385f7c32319ac4d8f03ef619799fd53
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
7 months agoFix memory crash issue 81/319581/1
Wootak Jung [Mon, 28 Oct 2024 05:06:49 +0000 (14:06 +0900)]
Fix memory crash issue

Need to get the next pointer before removing glist data

Change-Id: I78102f17032b937c48a38603d7ffd74b794bf8e6
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
8 months agoDisable mesh functionality to remove ell dependency in movable project 54/318554/2 accepted/tizen_9.0_unified accepted/tizen_unified_toolchain tizen_9.0 accepted/tizen/9.0/unified/20241030.232630 accepted/tizen/unified/20241013.144702 accepted/tizen/unified/toolchain/20241022.122325 accepted/tizen/unified/toolchain/20241022.122814 accepted/tizen/unified/x/20241014.022516 accepted/tizen/unified/x/asan/20241022.113305 tizen_9.0_m2_release
Wootak Jung [Wed, 2 Oct 2024 07:03:27 +0000 (16:03 +0900)]
Disable mesh functionality to remove ell dependency in movable project

Change-Id: I6fc0d44910683c29cacee54d967ca007e29421a9
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
8 months agoFix svace issue 49/318549/1 accepted/tizen/unified/20241004.041947 accepted/tizen/unified/x/20241006.082040 accepted/tizen/unified/x/asan/20241013.235623
Wootak Jung [Wed, 2 Oct 2024 06:23:44 +0000 (15:23 +0900)]
Fix svace issue

Change-Id: Iccc16729492c2c2ebe48700f9092d21589bddac5
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
8 months agoFix svace issue 46/318546/2
Wootak Jung [Wed, 2 Oct 2024 04:35:10 +0000 (13:35 +0900)]
Fix svace issue

Issue ID: 247545

Change-Id: I4f468d82c45c4c985f03594d0784a418ad2a0c0f
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
8 months agoFix issue of not receiving signal changed events 33/318533/1
Wootak Jung [Wed, 2 Oct 2024 00:49:11 +0000 (09:49 +0900)]
Fix issue of not receiving signal changed events

sender should be NULL or org.freedesktop.DBus

signal time=5562.046279 sender=org.freedesktop.DBus -> destination=(null destination)
 serial=24 path=/org/freedesktop/DBus; interface=org.freedesktop.DBus; member=NameOwnerChanged
   string "org.bluez"
   string ":1.116"
   string ""

Change-Id: I7ca6ca160b3c1019ac1c5610cc4bcc1e8bf09877
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
9 months agoThis patch fixes SVACE issue. 58/317358/3
Sameer Kumar [Mon, 9 Sep 2024 09:30:43 +0000 (15:00 +0530)]
This patch fixes SVACE issue.

Issue ID: 244574

Change-Id: I9be2a7bd1713c49e2f9d977c18760b883a0a87c4
Signed-off-by: Sameer Kumar <sameer.kumar@samsung.com>
10 months agoModify disconnection reason in connection change callback 65/315765/1 accepted/tizen_unified_dev accepted/tizen/unified/20240829.153507 accepted/tizen/unified/dev/20240901.214653 accepted/tizen/unified/toolchain/20241004.101315 accepted/tizen/unified/x/20240830.014057
Sameer Kumar [Wed, 7 Aug 2024 06:52:43 +0000 (12:22 +0530)]
Modify disconnection reason in connection change callback

This patch alligns OAL layer disconnection reason with HAL layer disconnection reason.

Change-Id: I6b20fc208e45622db3bdb20780afe6e2acd624d0
Signed-off-by: Sameer Kumar <sameer.kumar@samsung.com>
10 months agoThis patch fixes SVACE issue. 89/315289/5
Sameer Kumar [Mon, 29 Jul 2024 11:32:26 +0000 (17:02 +0530)]
This patch fixes SVACE issue.

Issue ID:
213496
213568
213587

Change-Id: Icdfd28fd629b061eb48c9f08530fc1ba4ee3dad1
Signed-off-by: Sameer Kumar <sameer.kumar@samsung.com>
11 months agoRemove mobile number from log 44/313744/1 accepted/tizen/unified/20240703.100015 accepted/tizen/unified/dev/20240704.065615 accepted/tizen/unified/toolchain/20240812.131651 accepted/tizen/unified/x/20240704.022901 accepted/tizen/unified/x/asan/20240813.225926
Sameer Kumar [Mon, 10 Jun 2024 06:34:52 +0000 (12:04 +0530)]
Remove mobile number from log

This patch removes mobile number from logs to meet security
compliance.

Change-Id: Ia15b188b2583b5682c707be7fb61a0f8313dd582
Signed-off-by: Sameer Kumar <sameer.kumar@samsung.com>
11 months agoAdd new DA model names 43/313743/1
Wootak Jung [Tue, 4 Jun 2024 07:17:43 +0000 (16:17 +0900)]
Add new DA model names

AI Home Smart EHS
Smart Oven
Smart AC
AI Vision Refrigerator

Change-Id: I713489129445143e5038b72224a887cd43f37eea
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
11 months agoFix issue where WriteValue/AcquireNotify method comes before gatt connected 42/313742/1
Wootak Jung [Thu, 30 May 2024 10:12:23 +0000 (19:12 +0900)]
Fix issue where WriteValue/AcquireNotify method comes before gatt connected

Change-Id: I090e863e8c78623e7437deba118df9940dbfaaed
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
11 months agoModify to connect only one AVRCP device 41/313741/1
Wootak Jung [Tue, 30 Apr 2024 05:19:17 +0000 (14:19 +0900)]
Modify to connect only one AVRCP device

Change-Id: I8667c617d5c48fc8fd04acd311d6c00def74e1e4
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
11 months agoFix issue where response was not delivered when HF connect failed 40/313740/1
Wootak Jung [Mon, 22 Apr 2024 08:21:33 +0000 (17:21 +0900)]
Fix issue where response was not delivered when HF connect failed

Fix issue of sending wrong address

Change-Id: Id274007eaba5e2d7b4fb17fe64de588edf74c952
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
12 months agoGet local IRK value 16/311716/5
Sameer Kumar [Fri, 24 May 2024 10:32:37 +0000 (16:02 +0530)]
Get local IRK value

This patch adds support to get local IRK value.

To avoid any conflicts this patch should be merged with bluez
patch: (Change-Id: Iae9293c6d93688d8b9a6672bdaf2261c41668a9f)

Change-Id: Iac2edded057054a98aa3855fe0eb2c97e9346a62
Signed-off-by: Sameer Kumar <sameer.kumar@samsung.com>
13 months agoFix issue where server mtu changed callback ws not called 81/311081/1
Wootak Jung [Tue, 14 May 2024 01:41:13 +0000 (10:41 +0900)]
Fix issue where server mtu changed callback ws not called

Change-Id: Icd5e011505ae0eb15ef02c410a97712302b3bb3b
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
13 months agoAdd cap_net_raw capability to bt-core 77/310777/1 accepted/tizen/unified/20240509.124636 accepted/tizen/unified/dev/20240620.005327 accepted/tizen/unified/toolchain/20240513.061256 accepted/tizen/unified/x/20240510.061416 accepted/tizen/unified/x/asan/20240625.091924
Wootak Jung [Wed, 8 May 2024 05:02:18 +0000 (14:02 +0900)]
Add cap_net_raw capability to bt-core

cap_net_raw is required to use bluetooth socket

Change-Id: Ia752e5796ced4d4ec4641a466b7c25b8da83b187
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
13 months agoFix issue where wrong manager_id was unregistered 29/309829/1
Wootak Jung [Tue, 26 Mar 2024 06:18:38 +0000 (15:18 +0900)]
Fix issue where wrong manager_id was unregistered

app_path and manager_id must match and be unregistered

Change-Id: Id0da7b762e25f1b77f6fb36d4ad76272141ed2ed
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
13 months agoFix gatt_server_add_service fail issue 28/309828/1
Wootak Jung [Tue, 26 Mar 2024 06:04:27 +0000 (15:04 +0900)]
Fix gatt_server_add_service fail issue

Even if all servers are not removed, the interface of object manager must be unregistered.

Change-Id: I2723ad4ee057b0fd80c975eb5ced836944f6b0e0
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
13 months agoFix issue where gatt service can not be found #2 26/309826/1
Wootak Jung [Mon, 15 Apr 2024 08:32:32 +0000 (17:32 +0900)]
Fix issue where gatt service can not be found #2

Change-Id: I66fbfe0aaca4d00d8a7b8abf720b042b0b77e547
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
13 months agoFix issue where gatt service can not be found 25/309825/1
Wootak Jung [Fri, 12 Apr 2024 05:49:00 +0000 (14:49 +0900)]
Fix issue where gatt service can not be found

Fix issue where the inst id was set incorrectly for handle exceeding 255.

Change-Id: If1bb2aa943ac1855ff51fadd18389d992bb4f1e9
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
13 months agoFix WriteValue timeout issue 24/309824/1
Wootak Jung [Sun, 7 Apr 2024 23:18:17 +0000 (08:18 +0900)]
Fix WriteValue timeout issue

Apr 04 16:11:51.062065 Samsung-FamilyHub bluetoothd[6483]: src/gatt-database.c:pending_write_new() ### op 0xabccb558 attrib 0xabccd568 queue 0xabccf2e0 id 1
Apr 04 16:11:51.062329 Samsung-FamilyHub bluetoothd[6483]: src/gatt-database.c:send_write() ### op 0xabccb558 attrib 0xabccd568
// timeout occurs if no reply
Apr 04 16:16:51.064207 Samsung-FamilyHub bluetoothd[6483]: src/gatt-database.c:pending_op_free() op 0xabccb558

g_dbus_method_invocation_return_value:
 * if (error != NULL)
 *   g_dbus_method_invocation_return_gerror (invocation, error);
 * else
 *   g_dbus_method_invocation_return_value (invocation,
 *                                          g_variant_new ("(s)", result_string));
 *
 * // Do not free @invocation here; returning a value does that
 * ]|
 *
 * This method will take ownership of @invocation. See
 * #GDBusInterfaceVTable for more information about the ownership of
 * @invocation.

GDBusInterfaceVTable:
Ownership of the GDBusMethodInvocation object passed to the method_call() function
is transferred to your handler; you must call one of the methods of GDBusMethodInvocation
to return a reply (possibly empty), or an error.
These functions also take ownership of the passed-in invocation object,
so unless the invocation object has otherwise been referenced, it will be then be freed.

Change-Id: I389475519d912044bff5d98ceffa8064ec9012d3
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
13 months agoAdd the timeout to reset the pending info 23/309823/1
Dohyun Pyun [Fri, 29 Mar 2024 01:25:09 +0000 (10:25 +0900)]
Add the timeout to reset the pending info

Change-Id: Id67b0f10b038c462dc8e9e2793f567da14c23a01

13 months agoAdd shutdown logic before close 22/309822/1
Wootak Jung [Fri, 29 Mar 2024 01:35:20 +0000 (10:35 +0900)]
Add shutdown logic before close

Change-Id: I4e671a0add6a55b80712cb3f07d4bd490e986fc7
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
13 months agoHandle connection failed event during le coc connection request 21/309821/1
Anuj Jain [Wed, 27 Mar 2024 10:29:34 +0000 (15:59 +0530)]
Handle connection failed event during le coc connection request

This patch ensures connection fail event passed to application
in case of connection connection failure during connect request.

This patch should be merged after bluez patch
(Change-Id: Id4cf266603e64eab8685325f218b1180c9c5b125)
to avoid any conflicts.

Change-Id: I6a2a043e0d2077b45a1da316c193a2a53b4bbae1
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
13 months agoFix issue of waiting infinitely for a response when requesting a bond 14/309714/1
Wootak Jung [Tue, 16 Apr 2024 02:44:09 +0000 (11:44 +0900)]
Fix issue of waiting infinitely for a response when requesting a bond

Adjust bond timeout to 50 seconds

Change-Id: Iadf87c1df6b516eaeb560d29bb21965df3d1b86d
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
14 months agoFix issue where the previous trigger_bond_info was deleted when requesting bond 55/309255/1
Wootak Jung [Mon, 8 Apr 2024 04:40:59 +0000 (13:40 +0900)]
Fix issue where the previous trigger_bond_info was deleted when requesting bond

Change-Id: Ifd6a8522a1bd57571933ecdba36f7249b376645e
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
14 months agoModify the log level 81/308681/2 accepted/tizen/unified/20240404.164416 accepted/tizen/unified/x/20240408.053710
Wootak Jung [Thu, 28 Mar 2024 23:25:24 +0000 (08:25 +0900)]
Modify the log level

When the app terminates, name will be printed as info level

Change-Id: I4bb71fee958bd973d44bc35acd03fb0d4c1f463c
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
15 months agoAdd DA logic to fix le scan fail issue 05/307005/1 accepted/tizen/unified/20240308.173931 accepted/tizen/unified/x/20240311.095859
Wootak Jung [Wed, 28 Feb 2024 02:30:20 +0000 (11:30 +0900)]
Add DA logic to fix le scan fail issue

Change-Id: Ibbc873d83e16fe85778e46290cec95f79dfa24f4
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
15 months agoAdd function to check whether PBAP profile is connected 02/307002/1
Wootak Jung [Tue, 27 Feb 2024 01:31:54 +0000 (10:31 +0900)]
Add function to check whether PBAP profile is connected

Change-Id: I85ac7a4e666e694917afad0583758e62eeeb7e63
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
15 months agoRemove unnecessary log 01/307001/1
Wootak Jung [Tue, 27 Feb 2024 01:30:21 +0000 (10:30 +0900)]
Remove unnecessary log

Change-Id: I15e7002a89c4bff6a021683f9b918ea5ba820cdc
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
15 months agoFix crash issue that occurred when disabling BT during scanning 00/307000/1
Wootak Jung [Wed, 7 Feb 2024 04:48:14 +0000 (13:48 +0900)]
Fix crash issue that occurred when disabling BT during scanning

All timeout callbacks for scan results should be removed.

0: 0x0000007f9da8bb5c in __bt_hal_send_le_scan_result_event (adv_info=adv_info@entry=0x55a81a9240)
   at /usr/src/debug/bluetooth-frwk-0.7.0-1.aarch64/bt-oal/bluez_hal/src/bt-hal-gatt.c:465 --> bluetooth-frwk-oal (rpm)
1: 0x0000007f9da8bbcc in __bt_hal_adv_scan_req_timeout_cb (user_data=0x55a81a9240, user_data@entry=<error reading variable: value has been optimized out>)
   at /usr/src/debug/bluetooth-frwk-0.7.0-1.aarch64/bt-oal/bluez_hal/src/bt-hal-gatt.c:756 --> bluetooth-frwk-oal (rpm)

Change-Id: Ifc8d42a31f6d70687423abe43335165edea62726
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
15 months agoChange visibility settings for DA devices 99/306999/1
Sohyeon Choi [Tue, 23 Jan 2024 09:35:00 +0000 (18:35 +0900)]
Change visibility settings for DA devices

Change-Id: I10d20fe86e2f2f6c6b27c358e4f6c08af2ffcc6a
Signed-off-by: Sohyeon Choi <shss.choi@samsung.com>
15 months agoAdd new L2CAP socket API to get the maximum buffer size 40/306740/1
Wootak Jung [Tue, 27 Feb 2024 04:51:09 +0000 (13:51 +0900)]
Add new L2CAP socket API to get the maximum buffer size

Change-Id: Id530fded18e3803f5a26064ca5233ed45da9f4e5
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
16 months agoFix issue where ACL was not disconnected even though the coc disconnect request was... 55/305755/1 accepted/tizen/unified/20240216.161315 accepted/tizen/unified/toolchain/20240311.065309 accepted/tizen/unified/x/20240220.145928
Wootak Jung [Wed, 7 Feb 2024 07:36:27 +0000 (16:36 +0900)]
Fix issue where ACL was not disconnected even though the coc disconnect request was processed

Modified to shutdown before fd close

Change-Id: I3ac11f324012d2a3e6292f434e58c4f66f48b552
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
16 months agoFix to reallocate fd when gatt write fails 39/305539/1
Wootak Jung [Thu, 1 Feb 2024 06:16:04 +0000 (15:16 +0900)]
Fix to reallocate fd when gatt write fails

Change-Id: Ic9e2cf70d022c1d0f66b45587f08b382cd425421
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
16 months agoAdd DA logic so that A2DP connection is only possible for one device 38/305538/1
Wootak Jung [Wed, 24 Jan 2024 03:56:37 +0000 (12:56 +0900)]
Add DA logic so that A2DP connection is only possible for one device

A2DP and HFP can only be connected to the same device.

Change-Id: I600ffc9d7dd753f6bd9a070f8616d893b832d4bb
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
16 months agoModify duty cycle of scan mode 60/303560/3 accepted/tizen_unified_riscv accepted/tizen/unified/20240117.163234 accepted/tizen/unified/riscv/20240118.054531
Wootak Jung [Tue, 2 Jan 2024 06:59:28 +0000 (15:59 +0900)]
Modify duty cycle of scan mode

Change-Id: Ic536778c1f03e8697bd4b141fb8aa98f39c44e33
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
16 months agoFix issue where state is not restored when adv operation fails 54/304254/1
Wootak Jung [Fri, 5 Jan 2024 08:20:58 +0000 (17:20 +0900)]
Fix issue where state is not restored when adv operation fails

This patch reverts the iOS GM support patch below.

commit 0d9d2326e4bcc54a2a979eaad6ebec69fb9747dd
Author: Wootak Jung <wootak.jung@samsung.com>
Date:   Tue Dec 17 08:59:17 2019 +0900

    Fix iOS GM connection issue

Change-Id: I6ab48c90e5b4a57457c8ea04c570c1592ab5d234
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
17 months agoFix issue where state is not restored when adv operation fails 13/304013/1
Wootak Jung [Fri, 5 Jan 2024 08:20:58 +0000 (17:20 +0900)]
Fix issue where state is not restored when adv operation fails

Change-Id: I72428877125969a9dd682d6a2124775e45f258a4
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
17 months agoFix issue where conn info could not be found 50/303750/1
Wootak Jung [Wed, 3 Jan 2024 00:11:39 +0000 (09:11 +0900)]
Fix issue where conn info could not be found

Branch logic is required because remote device management method is
different depending on the stack.

In the case of bluez, it is managed by remote address,
so if you distinguish it by instance ID, conn info may not be found.

In the case of bluedroid, it is managed by conn ID,
so you need to find conn info using remote address + instance ID.

Change-Id: Ieea79d1b86ff72dc3490a68fdfb50de934b4d04d
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
17 months agoRemove A2DP related logic for Fhub only 03/303503/1
Wootak Jung [Wed, 27 Dec 2023 22:46:27 +0000 (07:46 +0900)]
Remove A2DP related logic for Fhub only

Change-Id: I231596417f1827eeb4eb0866f0e505adbec1ea37
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
17 months agoRemove inefficient log 95/303395/1
Wootak Jung [Wed, 27 Dec 2023 00:43:38 +0000 (09:43 +0900)]
Remove inefficient log

12-20 21:56:15.976-0500 I/BLUETOOTH_FRWK_API (P20017, T20017): bt-gatt-service.c: bluetooth_gatt_write_channel_watch_cb(393) > +
12-20 21:56:15.976-0500 I/BLUETOOTH_FRWK_API (P 6345, T 6345): bt-gatt-service.c: bluetooth_gatt_write_channel_watch_cb(393) > +
12-20 21:56:15.976-0500 I/BLUETOOTH_FRWK_API (P20017, T20017): bt-gatt-service.c: bluetooth_gatt_write_channel_watch_cb(393) > +
12-20 21:56:15.976-0500 I/BLUETOOTH_FRWK_API (P 6345, T 6345): bt-gatt-service.c: bluetooth_gatt_write_channel_watch_cb(393) > +
12-20 21:56:15.976-0500 I/BLUETOOTH_FRWK_API (P20017, T20017): bt-gatt-service.c: bluetooth_gatt_write_channel_watch_cb(393) > +

Change-Id: Ie8d440160a6d5ea445d9c67a70e2a6dc4879db50
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
17 months agoMerge "Bluetooth: Increase write data limit in l2cap connection." into tizen
Wootak Jung [Wed, 27 Dec 2023 04:26:27 +0000 (04:26 +0000)]
Merge "Bluetooth: Increase write data limit in l2cap connection." into tizen

17 months agoBluetooth: Increase write data limit in l2cap connection. 59/303059/2
Harsh Jain [Tue, 19 Dec 2023 10:57:50 +0000 (16:27 +0530)]
Bluetooth: Increase write data limit in l2cap connection.

This patch increases write limit in l2cap connection
from 672 Bytes to 4096 Bytes.

Change-Id: I7a294036ae963ef1a08b31113674317d388e2a18
Signed-off-by: Harsh Jain <jain.harsh@samsung.com>
18 months agoFix issue where adv_handle of incorrect instance was modified 72/302672/1 accepted/tizen/unified/20231219.160420 accepted/tizen/unified/riscv/20231226.210826
Wootak Jung [Mon, 11 Dec 2023 06:05:14 +0000 (15:05 +0900)]
Fix issue where adv_handle of incorrect instance was modified

Reproduction steps:
1) bt_adapter_le_create_advertiser()     // ADV 1 create
2) bt_adapter_le_start_advertising_new() // ADV 1 start
3) bt_adapter_le_create_advertiser()     // ADV 2 create
4) bt_adapter_le_start_advertising_new() // ADV 2 start
5) register GATT Service                 // register gatt service
6) bt_gatt_server_start()                // GATT Server Start
7) bt_adapter_le_stop_advertising()      // ADV 1 stop
8) bt_adapter_le_destroy_advertiser()    // ADV 1 destroy --> RESOURCE_BUSY

Change-Id: I3ce3847b4a4acb478869c66fda8ce55e0dcdf212
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
18 months agoMerge "Add support for A2DP source and sink both role" into tizen
Wootak Jung [Mon, 11 Dec 2023 04:57:30 +0000 (04:57 +0000)]
Merge "Add support for A2DP source and sink both role" into tizen

18 months agoAdd new DA model name 01/302501/1
Wootak Jung [Fri, 8 Dec 2023 00:40:27 +0000 (09:40 +0900)]
Add new DA model name

AI Hub Smart EHS

Change-Id: I3614aefa19af5b719f96c85572e228b9c9c52865
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
18 months agoFix missing response issue of getting bonded device and devices. 56/301956/1
Harsh Jain [Tue, 28 Nov 2023 10:50:26 +0000 (16:20 +0530)]
Fix missing response issue of getting bonded device and devices.

Response is missing if the request of getting bonded device and devices is coming
while bonded_list_retrieved not set.

Change-Id: I0abd411ba3acdf59518b54293f8d34663de52a0c
Signed-off-by: Harsh Jain <jain.harsh@samsung.com>
18 months agoAdd new DA model names 99/301899/1
Wootak Jung [Mon, 27 Nov 2023 00:34:32 +0000 (09:34 +0900)]
Add new DA model names

Bespoke Washer
Bespoke Dryer
Appliance Emulator

Change-Id: Ib23d5aea9b222d53606ea916ae6c6931ee54296b
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
18 months agoFix memory leak when scanning 84/301784/1 accepted/tizen/unified/20231127.164946
Wootak Jung [Wed, 22 Nov 2023 01:29:51 +0000 (10:29 +0900)]
Fix memory leak when scanning

Change-Id: I312e57b2f8a066f1085813103cd942fea1135a3e
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
18 months agoAdd support for A2DP source and sink both role 58/301358/2
Wootak Jung [Wed, 15 Nov 2023 02:28:51 +0000 (11:28 +0900)]
Add support for A2DP source and sink both role

Change-Id: I8638a5ae3728d3f4fceac03b1403b0c38d8f351a
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
18 months agoAdd logic to start hf-agent when bt is enabled in DA devices 33/301433/1
Wootak Jung [Wed, 15 Nov 2023 01:18:21 +0000 (10:18 +0900)]
Add logic to start hf-agent when bt is enabled in DA devices

When restarting the bluetooth adapter, hf-agent does not restart after termination.

Change-Id: Ie67312a778582e396d80f8816b03e9b5c215fc5f
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
19 months agoRevert "Integrate list of client/server info to conn info list" 06/300906/1
Wootak Jung [Mon, 6 Nov 2023 00:35:21 +0000 (09:35 +0900)]
Revert "Integrate list of client/server info to conn info list"

This reverts commit f693e2270a04917b1004cb8c7504d55aa94badfd.

Change-Id: Ifd9a5b0f429fe68e0fefead057e11eb76d6e4e2a
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
19 months agoRevert "Integrate gatt connection info" 05/300905/1
Wootak Jung [Mon, 6 Nov 2023 00:34:45 +0000 (09:34 +0900)]
Revert "Integrate gatt connection info"

This reverts commit 837896a29835d78365a7e1d852de09e1821635bc.

Change-Id: I1179a05fb78b678aabfe0a8528090b4f4dc900ff
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
19 months agoIncrease the version to 9.0 99/300899/1
Wootak Jung [Mon, 6 Nov 2023 00:18:16 +0000 (09:18 +0900)]
Increase the version to 9.0

Change-Id: Id9f25c114f621b4b305bd73e7c0fccaa866c981b
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
19 months agoChange the L2CAP LE buffer size to 0xFFFF 52/300752/3 accepted/tizen/unified/20231106.171621
Wootak Jung [Thu, 2 Nov 2023 00:31:19 +0000 (09:31 +0900)]
Change the L2CAP LE buffer size to 0xFFFF

Change-Id: Id0ba8ef701c58a380566c87763c76fd91057c388
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
19 months agoHandle MTU change request when client disconnected 76/300276/1
Anuj Jain [Thu, 19 Oct 2023 14:29:57 +0000 (19:59 +0530)]
Handle MTU change request when client disconnected

This patch fixes no error signal being sent to application upon
invocation of "bt_gatt_client_request_att_mtu_change" even
when GATT client is disconnected.

Change-Id: I101e4f76f8e09826a461e772a68d0f206979d745
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
20 months agoFix LegacyManufacturerData parsing issue 59/299859/3
Wootak Jung [Wed, 11 Oct 2023 03:13:28 +0000 (12:13 +0900)]
Fix LegacyManufacturerData parsing issue

LegacyManufacturerDataLen is stored as uint16 not uint32
LegacyManufacturerData should be stored with HAL_PROP_DEVICE_MANUFACTURER_DATA
not HAL_PROP_DEVICE_BLE_ADV_DATA

Change-Id: I6cb7fe979b7c85190383ff318a127b75a4b4357a
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
20 months agoFix uuid duplication issue 79/299579/1
Wootak Jung [Thu, 5 Oct 2023 04:44:30 +0000 (13:44 +0900)]
Fix uuid duplication issue

Same uuids are in used if client instance register request is coming
right before server instance initialized

Change-Id: I93438ae0cadbceefc6c819454bfec3776e40ddb6
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
20 months agoFix build error 08/299008/1 accepted/tizen/8.0/unified/20231005.093200 accepted/tizen/unified/20230919.091745 tizen_8.0_m2_release
Wootak Jung [Mon, 18 Sep 2023 07:14:45 +0000 (16:14 +0900)]
Fix build error

Change-Id: I13e1794f9dba5db1854949d5e92b67372435682c
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
20 months agoFix svace issues 06/299006/1
Wootak Jung [Mon, 18 Sep 2023 06:50:50 +0000 (15:50 +0900)]
Fix svace issues

Change-Id: Ice542283c92665482bcc3db18b9f3866b0dbea7e
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
21 months agoFix buffer overflow potential issue 18/298818/1 accepted/tizen/unified/20230915.160539
Wootak Jung [Thu, 14 Sep 2023 01:50:45 +0000 (10:50 +0900)]
Fix buffer overflow potential issue

Change-Id: I01528d16207f5f06599ac556ffaad402d59ff5db
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
21 months agoMerge "Fix Coverity Issue" into tizen accepted/tizen/unified/20230911.091133
Ayush Garg [Thu, 7 Sep 2023 07:06:04 +0000 (07:06 +0000)]
Merge "Fix Coverity Issue" into tizen

21 months agoFix Coverity Issue 46/298446/1
Anuj Kumar Singh [Thu, 7 Sep 2023 05:32:06 +0000 (11:02 +0530)]
Fix Coverity Issue

This patch fix the below coverity issue:
CID-1706415

Change-Id: I53383e3a78cfeef03b279c49ad9c4c8f31c95fa8
Signed-off-by: Anuj Kumar Singh <anujk.singh@samsung.com>
21 months agoMerge "handling a2dp/avrcp auth request according to A2DP role" into tizen
Wootak Jung [Thu, 7 Sep 2023 03:20:07 +0000 (03:20 +0000)]
Merge "handling a2dp/avrcp auth request according to A2DP role" into tizen

21 months agohandling a2dp/avrcp auth request according to A2DP role 35/298135/1
Sohyeon Choi [Thu, 31 Aug 2023 09:52:09 +0000 (18:52 +0900)]
handling a2dp/avrcp auth request according to A2DP role

Change-Id: I2ded461a380514756fa1cf570a7f9a908a2b2b4c

21 months agoBT 5.0: Add APIs to support set/read PHYs 05/298105/1
Ayush Garg [Thu, 31 Aug 2023 14:54:37 +0000 (20:24 +0530)]
BT 5.0: Add APIs to support set/read PHYs

This patch adds support for the following APIs:
1. bluetooth_gatt_server_read_phy()
2. bluetooth_gatt_server_set_phy()
3. bluetooth_gatt_client_read_phy()
4. bluetooth_gatt_client_set_phy()

Change-Id: I641f95954ed88b419bf208a346a8c16c95e4b474
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
21 months agoMerge "BT 5.0 : Support for Extended Advertisement" into tizen accepted/tizen/unified/20230830.170540
Ayush Garg [Thu, 24 Aug 2023 17:21:54 +0000 (17:21 +0000)]
Merge "BT 5.0 : Support for Extended Advertisement" into tizen

21 months agoMerge "BT 5.0 : Support for extended Scanning" into tizen
Ayush Garg [Thu, 24 Aug 2023 17:21:31 +0000 (17:21 +0000)]
Merge "BT 5.0 : Support for extended Scanning" into tizen

21 months agoFix 31bytes adv data not setting issue 29/297629/1
Wootak Jung [Tue, 22 Aug 2023 05:34:29 +0000 (14:34 +0900)]
Fix 31bytes adv data not setting issue

31bytes should be permitted

Change-Id: I762e88860eff11704cc3c5a98bf3963f2518966d
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
21 months agoBT 5.0 : Support for Extended Advertisement 15/297615/2
Anuj Jain [Mon, 21 Aug 2023 12:26:06 +0000 (17:56 +0530)]
BT 5.0 : Support for Extended Advertisement

This patch provides initial support for extended advertisement.

As there is no support for Extended advertisement on bluez layer
therefore this feature is currently disabled.

Change-Id: Ic38a433b6438cc81606f120fe96190a301877389
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
21 months agoBT 5.0 : Support for extended Scanning 48/296648/4
Anuj Jain [Tue, 1 Aug 2023 13:59:00 +0000 (19:29 +0530)]
BT 5.0 : Support for extended Scanning

This patch provides initial support for extended scanning.

As there is no support for Extended scanning on bluez layer
therefore this feature is currently disabled.

Change-Id: Ia6ca9fe5e404fddb4e50644ceaf588d0bba5b495
Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
21 months agoBT 5.0: Add APIs to check Extended feature support 75/297375/2
Ayush Garg [Thu, 17 Aug 2023 08:58:55 +0000 (14:28 +0530)]
BT 5.0: Add APIs to check Extended feature support

This patch adds support for the following APIs:
1. bluetooth_is_le_extended_advertising_supported()
2. bluetooth_is_le_extended_scan_supported()
3. bluetooth_le_get_maximum_advertising_data_length()

Change-Id: Ic018cde08d33de319894add49eaa8501075e61e1
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>
22 months agoAdd new DA model names 57/296857/1 accepted/tizen/unified/20230808.074040
Wootak Jung [Mon, 7 Aug 2023 00:25:48 +0000 (09:25 +0900)]
Add new DA model names

Change-Id: I54289d0b4ee140c26bc493ab00e0220286f48710
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
22 months agoIncrease the version to 8.0 90/296790/1
Wootak Jung [Fri, 4 Aug 2023 08:19:17 +0000 (17:19 +0900)]
Increase the version to 8.0

Change-Id: I742ecd44c009d8429642f5b9a0b2974cdc955b88
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
22 months agoAdd skip logic for hal_bluetooth_stop error 62/296062/1 accepted/tizen/unified/20230725.013000
Wootak Jung [Wed, 19 Jul 2023 06:07:52 +0000 (15:07 +0900)]
Add skip logic for hal_bluetooth_stop error

Change-Id: If54d0275ff109de0b2da9ad8ff2abcd6de3ef8ec
Signed-off-by: Wootak Jung <wootak.jung@samsung.com>
23 months agoMerge "Fixed the build error using gcc 13" into tizen accepted/tizen/unified/20230718.162153 accepted/tizen/unified/dev/20230726.115849
Pyun DoHyun [Fri, 30 Jun 2023 05:22:25 +0000 (05:22 +0000)]
Merge "Fixed the build error using gcc 13" into tizen