Youngcheol Kang [Fri, 17 Jun 2016 02:18:57 +0000 (11:18 +0900)]
fixup! Changed the library type to the shared library from static library
This patch removes the code which provide the libv8.so
in devel package, because it makes the problem in OBS system.
Also the name of package config is changed to the v8.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-1510
Change-Id: I31a8ca221c472f235b4e0ec324d2a3a498a17b21
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngcheol Kang [Thu, 16 Jun 2016 11:46:33 +0000 (20:46 +0900)]
Changed the library type to the shared library from static library
In order to reduce binary size and memory, this patch changes
the library type to the shared library from the static library.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-1510
Change-Id: I1e3c3b86e92dc80faa5edb491968776993e67076
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngcheol Kang [Wed, 15 Jun 2016 05:45:48 +0000 (14:45 +0900)]
Apply the libdir in pkgconfig by architectures
The path where the library is installed is different
in 32bit and 64bit architectures.
- 32bit : /usr/lib/
- 64bit : /usr/lib64/
This patch changes the libdir path according to the achitectures.
Also it can fix the build problem in 64bit arch.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-1478
Change-Id: Id36196c21eaed2e6776ed94539b480b992859dc3
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngsoo Choi [Wed, 25 May 2016 06:21:47 +0000 (15:21 +0900)]
Make binutils-gold package available for all architectures
This CL makes the binutils-gold package guardless to use
gold linker for all architectures in gbs build.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-1300
Change-Id: Ib8522c145b8261eced2cca861514a9fbe25cd756
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Tue, 24 May 2016 07:59:26 +0000 (16:59 +0900)]
Refactor ninja
This CL refactors ninja script to use proper binary
for specific architecture build.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-1292
Change-Id: I28f6c136a47b7334cb9f9bef7e47041fefdc7ee7
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Tue, 24 May 2016 05:50:41 +0000 (14:50 +0900)]
Support obs build
The obs build for upstream does not include packaging folder in build.
So, v8.pc and v8.manifest moved to outside of packaging folder.
There's kind of bug while patching source in gbs build.
The permission of excutable binaries is getting changed to '-rw-r--r--'.
So, this CL makes them excutable by using command chmod.
The option '--incremental' is removed from gbs build in utility script file
to make same environment with obs build.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-1289
Change-Id: I2be33c2f31246f0236d6533ae86919fa1824f90c
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Tue, 24 May 2016 01:35:32 +0000 (10:35 +0900)]
Refactor build configuration
1) Remove unused git package
2) Add build output in .gitignore
Change-Id: I25af73ec947fd52898161c2872f81fceb7c0c640
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Wed, 11 May 2016 11:05:03 +0000 (20:05 +0900)]
[standalone v8] Add third party library gyp
For standalone v8 build, third party library gyp is needed.
The source comes from git repository :
https://chromium.googlesource.com/external/gyp.git
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-1149
Change-Id: I722e9da60033d4f68e68d0a8a96ba7ca2923c9fd
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Mon, 23 May 2016 07:52:05 +0000 (16:52 +0900)]
Revert "Make a command 'git submodule' work in spec file"
This reverts commit
d5270085726338b2e3320b7402420ce9dba764b1.
The command '$git submodule' is not available on obs server.
Change-Id: I00ce70b562c81e37b72691cc1c735625bdaee9c1
Youngsoo Choi [Thu, 19 May 2016 05:36:08 +0000 (14:36 +0900)]
fixup! [standalone v8] Support gbs build for generating v8 rpm package
The out folder patch is fixed from 'out/Release' to '%{OUTPUT_FOLDER}'
for supporting both debug and release modes. And license information is added.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-1131
Change-Id: I171c2bee83d2b4f4476d9ada91b6f3a91e12d951
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Thu, 19 May 2016 05:20:21 +0000 (14:20 +0900)]
Make a command 'git submodule' work in spec file
V8 needs third party moudle for standalone build.
But, a command 'git submodule' has not worked in spec file because
there's no certification to download source from remote git repository.
So, thiis CL tries to disable the verification.
Note that the setting only works on virtual build system so it doesn't harm.
Also, HQ proxy can be set by using |$ ./build/build_{profile}.sh --hq-proxy|.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-1230
Change-Id: I979a99cc6083b03fd91ba62d83320cf996537b52
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngcheol Kang [Fri, 3 Jun 2016 08:57:31 +0000 (17:57 +0900)]
[standalone v8] Support gbs build for generating v8 rpm package
This CL supports gbs build for generating v8 rpm package
with armv7l, aarhc64, and i586(emulator) architectures
on tv, mobile, ivi, and common profiles.
1) The v8 needs to be packed as rpm package by using v8.spec.
And v8 static library information comes from command
|$ pkg-config --libs v8|.
2) Utility script build_{profile}.sh is provided
and building test is disabled by default via the script.
3) The ninja binaries are added to support various
architectures.
4) On tizen, the option '-m32', and '-m64' are not supported.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-1131
Change-Id: I483617532179f54da8ef99aed5918b447e56eb47
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
errong.leng [Wed, 27 Apr 2016 08:43:36 +0000 (16:43 +0800)]
Support set time offset for HBBTV
It is required for HbbTV to run Ligada tests.
However Ligada tests rely on stream time that
can be old, like 2011. Ligada tests compare
time offset via Javascript codes(new Date()).
So the time offset has to be applied on render
process side. Ligada tests also use the time
offset for certificates expiration validating.
BUG : http://107.108.218.239/bugzilla/show_bug.cgi?id=16087
Reviewed by: Eun Namgung, Lukasz Bialek
Change-Id: I09d4ba6f1647ac5c76d2511b3ac9ee592099e56f
Signed-off-by: errong.leng <errong.leng@samsung.com>
Siba Samal [Tue, 23 Feb 2016 12:46:57 +0000 (18:16 +0530)]
Improve ArrayJoin() performance for length=1 arrays
The purpose of this patch is to speed up Javascript Array Join when the
array length is 1. This change will improve BrowserMark 2.1 AngularJS
benchmark score by 4%.
Benchmark : Browsermark (http://web.basemark.com/)
Before Patch Score : 1053 (Z3 Device)
After Patch Score : 1086 (Z3 Device)
Original Patch by Stefan Karlsson
gerrit: http://165.213.202.130/gerrit/#/c/109145/
Reviewed by: DaeHyun Ko, venu musham
Change-Id: Ic9cf9c8badc4628094d096256fc4c7aeb60ded5d
Signed-off-by: Siba Samal <siba.samal@samsung.com>
chevalam.s [Fri, 8 Jan 2016 11:42:49 +0000 (17:12 +0530)]
Revert "[heap] Move RegExpResultCache out of the heap."
This reverts commit
24ef80dc93deba21256e9c270683f47036c9b32d.
Review URL of reverted commit: https://codereview.chromium.org/
1306053003
Reviewed by: DaeHyun Ko, venu musham
Change-Id: Iaa2a52163c58c1821e44a1e3e2aea2fa5e88def2
Signed-off-by: chevalam.s <chevalam.s@samsung.com>
SeungSeop Park [Thu, 21 Jan 2016 07:12:35 +0000 (16:12 +0900)]
fixup! [PDNCF] Fix 'maybe-uninitialized' warning in GCC compiler
Following error in building content_shell with clang++ in desktop:
> ../../v8/src/date.h:157:32: error: unknown warning group
> '-Wmaybe-uninitialized', ignored [-Werror,-Wunknown-pragmas]
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=15496
Reviewed by: Antonio Gomes, mohan reddy
Change-Id: Ibdb15c053532bb0daca5a60fd6e24731a14be755
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
p.pajak [Wed, 30 Dec 2015 10:41:13 +0000 (11:41 +0100)]
fixup! [M40 Merge] [MEM OPT] Grow semispace by N pages
Remove redundant logging from |NewSpace::Grow()|
Reviewed by: Grzegorz Czajkowski, SeungSeop Park
Change-Id: I41be276f146214257e3c101ec385f254d274f19b
Signed-off-by: p.pajak <p.pajak@samsung.com>
SeungSeop Park [Thu, 14 Jan 2016 04:29:25 +0000 (13:29 +0900)]
[PDNCF] Fix 'maybe-uninitialized' warning in GCC compiler
Added GCC pragma to suppress the warning.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=15562
Reviewed by: Antonio Gomes, Min-Soo Koo
Change-Id: I4f5cefc61df0ca7273ff8b0ce3caed1c0c15e4a2
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
kriti.s [Thu, 3 Dec 2015 06:12:21 +0000 (11:42 +0530)]
[M40 Merge][MEM OPT] Shrink v8 new space to initial capacity in NewSpace::Shrink
Shrink v8 new space to initial capacity when NewSpace::Shrink is called.
Runtime flag: --js-flags="--shrink-new-space-to-initial-capacity=1"
Below are the memory reading with and without patch for sunspider.
Without patch(PSS)- 552781
WIth patch(PSS)- 535521
M40 patch: http://suprem.sec.samsung.net/gerrit/#/c/34431/
Signed-off-by: kriti.s <kriti.s@samsung.com>
Change-Id: Ia6ea517a631a2763118a9321b0d2cb7ba8327612
kriti.s [Thu, 3 Dec 2015 06:38:09 +0000 (12:08 +0530)]
[M40 Merge] [MEM OPT] Grow semispace by N pages
Runtime option:
--js-flags="--custom-semi-space-growth=1 --grow-semi-space-by-n-pages=0"
M40 patch: http://suprem.sec.samsung.net/gerrit/#/c/32705/
Below are the memory reading with and without patch for sunspider.
Without patch(PSS)- 552781
WIth patch(PSS)- 535521
Change-Id: I36270bbaee2a32a7d99fef6d494b06ca1342b824
Signed-off-by: kriti.s <kriti.s@samsung.com>
kriti.s [Thu, 3 Dec 2015 05:41:54 +0000 (11:11 +0530)]
[M42 Merge] Revert "Tune crankshaft flags to better suit ARM"
This reverts commit
971fca052e66e678708a89a5c4b845489c0666d9
V8 java script benchmark regression (HawkP - Tizen 3.0)
Before this revert : 5741, 5787
After this revert : 6204, 6288
Other JS KPIs remain unchanged.
M42 Patch: http://suprem.sec.samsung.net/gerrit/#/c/54116
Reviewed by: DaeHyun Ko, Siba Samal
Change-Id: I10bb42f6071d96f826c070feb70b0e07b584b9cf
Signed-off-by: kriti.s <kriti.s@samsung.com>
chevalam.s [Wed, 9 Dec 2015 13:34:06 +0000 (19:04 +0530)]
Force to set the optimization level(O3) for v8
Currently,chromium-efl's optimization level is -Os for reducing
binary footprint. This patch forces to set optimization level(O3)
only for v8 side.
With this change, JS benchmark scores are better than before on
Tizen 3.0 Note 4.
Octane : 5642 -> 5760 (higher is better)
Sunspider : 979 -> 787.3 (smaller is better)
PSS for naver.com : 43.29MB -> 41.18MB
m40 commit: http://165.213.202.130/gerrit/#/c/76463/
Reviewed by: Antonio Gomes, venu musham
Reviewed by: KwangHyuk Kim, Siba Samal, venu musham
Change-Id: I315f2ba7088fe26fc54e4cd4253dc26b1b36be64
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
Signed-off-by: chevalam.s <chevalam.s@samsung.com>
Dongwoo Joshua Im [Tue, 7 Jul 2015 07:35:38 +0000 (16:35 +0900)]
Touch PRESUBMIT.py to run presubmit locally
It seems we need to touch some to run presubmit for v8,
including remove ownership/authorship check.
Also, make not print CppLint message which is too big and not really needed.
But, still, we use cpplint-cache.
Reviewed by: Dong-Gwan Kim, anujk sharma, mohan reddy, Kangil Han
Change-Id: I85f4c378b53f1caddf7855ff6b8e4e7e38793d8f
Signed-off-by: Dongwoo Joshua Im <dw.im@samsung.com>
Ahmed Bangash [Wed, 10 Dec 2014 09:36:14 +0000 (09:36 +0000)]
Integrate INLINE_MATH_MIN_MAX.
This patch will improve cases where JavaScript library call to min and
max are called through variables.
A micro benchmark showed approximately 870% improvement.
(Please see bug report for full source.)
Browsermark Scalable Solutions Knockout will show an improvement of ~1%.
The score without the patch was 2272.9, and 2295.9 after.
Patch by Stefan Karlsson.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=9736
Reviewed by: Viatcheslav Ostapenko, Laszlo Gombos, Heejin Chung, Kangil Han
Change-Id: I148416ee7584c5ff9b7d0e1c3232dd1fb6986e62
Signed-off-by: Ahmed Bangash <a.bangash@samsung.com>
a.bangash [Mon, 1 Jun 2015 13:25:48 +0000 (14:25 +0100)]
Improve VisitLoopBody() performance.
The purpose of this patch is to reduce stack checks. This patch will
improve Kraken 1.1 ai-astar score by 6%.
Patch by Stefan Karlsson.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13128
Reviewed by: Viatcheslav Ostapenko, Heejin Chung, Kangil Han
Change-Id: I0deae5c77ab1692d9bc7a5dca60e0b98ee3287c8
Signed-off-by: a.bangash <a.bangash@samsung.com>
a.bangash [Fri, 29 May 2015 13:36:44 +0000 (14:36 +0100)]
Improve ArrayJoin() performance for length=1 arrays.
The purpose of this patch is to speed up Javascript Array Join when the
array length is 1. This change will improve BrowserMark 2.1 AngularJS
benchmark score by 4%.
Patch by Stefan Karlsson.
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=13112
Reviewed by: Laszlo Gombos, Heejin Chung, mohan reddy
Change-Id: Id8a307bf398dc5fcf6527fda75db61aaed690eb4
Signed-off-by: a.bangash <a.bangash@samsung.com>
Petka Antonov [Tue, 9 Dec 2014 16:45:24 +0000 (18:45 +0200)]
Port 'Don't generate code for document.all check in typeofisandbranch' to M40
Original description
For compatibility with old websites that call
`typeof document.all == "undefined"`, V8 generates code
to check if the typeof operand is document.all, in all
cases (typeof document.all must give "undefined", not
"object").
However, in the benchmark typeof check it can be seen
that the expression cannot be document.all, so generation
of this code can be avoided.
Gives roughly a 4-5% improvement to the Array_Blur score
on Note 3 Android 4.4.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=1533
Reviewed by: Heejin Chung, Kangil Han, Viatcheslav Ostapenko
Change-Id: I9f3353eba583ad1fa1c38797140e81a60463ff07
Signed-off-by: Petka Antonov <p.antonov@partner.samsung.com>
Antonio Gomes [Tue, 23 Dec 2014 22:34:59 +0000 (14:34 -0800)]
[PossiblyDoNotCarryForward] [Tizen] Make it possible to run libchromium-efl.so with glibc 2.13
Chromium.org requires GCC 4.8 (or new enough Clang) to build latest sourcebase.
Because of that, the default compiler version available in
the latest development toolchain was overridden by prebuilt GCC 4.8 and
compatible packages, including glibc 2.18 (from TV toolchain).
On our mobile target (currently Tizen 2.3), we have available gblic
2.13, which contains some backward incompatible symbols in comparison to
glibc 2.18. To fix that, we deploy a newer glibc in a custom location.
This patch gets rid of the need of this custom glibc deployment,
by not using the glibc 2.16 (or higher) symbol named getauxval,
from <sys/auxv.h>. We fallback to the fallback implementation
based on /proc/self/auxv analyzes.
The following runtime error is fixed:
(/lib/libc.so.6: version `GLIBC_2.16' not found (required by
/usr/lib/libchromium-efl.so)).
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9995
Reviewed by: Laszlo Gombos, Viatcheslav Ostapenko, SeungSeop Park
Change-Id: I56d21f3559a8b4bd3943fc262ec19df0e9b1e26e
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Petka Antonov [Fri, 28 Nov 2014 15:39:22 +0000 (17:39 +0200)]
Tune crankshaft flags to better suit ARM
Due to ARM's smaller cache size when compared to desktop,
the same inlining thresholds shouldn't be used for both.
BrowserMark2 Array_Blur was used to tune the values for
maximum benefit and score improves by 22%. Doesn't seem to
have an effect on other benchmarks.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=1522
Reviewed by: Heejin Chung, Kangil Han, Balazs Kelemen
Change-Id: I7f2b0eefa906bc00261c308f8de2d14ad7857b46
Signed-off-by: Petka Antonov <p.antonov@partner.samsung.com>
v8-autoroll@chromium.org [Thu, 1 Oct 2015 18:25:18 +0000 (11:25 -0700)]
Version 4.7.83
Extend Annex B 3.3 sloppy-mode block-scoped hoisting to scripts, eval (issue 4441).
Performance and stability improvements on all platforms.
Cr-Commit-Position: refs/heads/4.7.83@{#1}
Cr-Branched-From:
ed906a91000e2531f619d582cb56b6141968a3fe-refs/heads/master@{#31038}
v8-autoroll [Thu, 1 Oct 2015 03:24:01 +0000 (20:24 -0700)]
Update V8 DEPS.
Rolling v8/buildtools to
0c88009d5c50b9f21b6f8849db08abfb9eb29f1e
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/
1381873002
Cr-Commit-Position: refs/heads/master@{#31038}
littledan [Wed, 30 Sep 2015 23:48:26 +0000 (16:48 -0700)]
Extend Annex B 3.3 sloppy-mode block-scoped hoisting to scripts, eval
The ES2015 spec is missing an extension of sloppy-mode block-scoped function
behavior to the global scope in scripts, as well as to eval. This patch
brings that hoisting to those two areas. The behavior is not perfectly
spec-compliant since properties created on the global scope should be
set as enumerable even if they are non-enumerable previously, but the
attributes will not be modified if the property already exists under
this patch.
BUG=v8:4441
LOG=Y
R=adamk
TEST=reddit comment functionality seems to be fixed
Review URL: https://codereview.chromium.org/
1376623002
Cr-Commit-Position: refs/heads/master@{#31037}
mbrandy [Wed, 30 Sep 2015 21:14:02 +0000 (14:14 -0700)]
PPC: Full code shouldn't embed the type feedback vector.
Port
c90c60ba2689fb524a1526503c9c87f534cf58fb
Original commit message:
Make sure to always reference it indirectly. This allows us to make the vector
native-context dependent should we wish.
R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1381803002
Cr-Commit-Position: refs/heads/master@{#31036}
mbrandy [Wed, 30 Sep 2015 21:10:23 +0000 (14:10 -0700)]
PPC: Introduce LiteralsArray to hide it's implementation.
Port
d8cdd6956a04cfcf03159ef7802c44838eee3146
Original commit message:
The LiteralsArray will soon hold a type feedback vector. Code treats it as an
ordinary fixed array, and needs to stop that.
R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1373823003
Cr-Commit-Position: refs/heads/master@{#31035}
mbrandy [Wed, 30 Sep 2015 21:09:16 +0000 (14:09 -0700)]
PPC: [es6] Fix invalid ToString in implementation of ToName.
Port
09626525fea63396c8a200deb9081d6dd1034d57
R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1377133005
Cr-Commit-Position: refs/heads/master@{#31034}
mbrandy [Wed, 30 Sep 2015 21:07:13 +0000 (14:07 -0700)]
PPC: [turbofan] Call ArgumentsAccessStub to materialize arguments.
Port
9b12ec9ac2aff2978d05df775ce621ba4d90cbe8
Original commit message:
This lowers JSCreateArgument nodes to call the ArgumentsAccessStub for
help with materializing arguments objects when possible. Along the way
this changes the calling convention of said stub to take parameters in
registers instead of on the stack.
R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=
Review URL: https://codereview.chromium.org/
1376303002
Cr-Commit-Position: refs/heads/master@{#31033}
adamk [Wed, 30 Sep 2015 20:22:23 +0000 (13:22 -0700)]
Two minor cleanups in pattern rewriter
- No need to call AsVariableProxy() on a VariableProxy
- Reduce AST visitor boilerplate using pre-existing macro
(and re-alphabetize the list of non-patterns).
R=littledan@chromium.org
Review URL: https://codereview.chromium.org/
1376633005
Cr-Commit-Position: refs/heads/master@{#31032}
adamk [Wed, 30 Sep 2015 19:49:46 +0000 (12:49 -0700)]
Remove --harmony-arrow-functions flag
Arrow functions have been enabled by default since the 4.5 branch.
Review URL: https://codereview.chromium.org/
1373633002
Cr-Commit-Position: refs/heads/master@{#31031}
adamk [Wed, 30 Sep 2015 19:19:57 +0000 (12:19 -0700)]
[es6] Function constructor-created functions should be named "anonymous"
Besides matching the spec, this matches the behavior of Firefox and Edge.
BUG=v8:3699
LOG=n
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/
1377603006
Cr-Commit-Position: refs/heads/master@{#31030}
adamk [Wed, 30 Sep 2015 19:17:23 +0000 (12:17 -0700)]
Revert "Stage sloppy block-scoped functions (Annex B 3.3)"
The current implemention breaks sloppy mode code that uses function
declarations inside blocks at top-level. Work is ongoing on a patch
to fix this issue, but in the meantime it seems reasonable to move
the feature out of staging.
Manual revert of commit
6e07f5a75ba2c949ac96efabd5248c76b9957112.
R=littledan@chromium.org
BUG=chromium:535836
LOG=y
Review URL: https://codereview.chromium.org/
1375213005
Cr-Commit-Position: refs/heads/master@{#31029}
kozyatinskiy [Wed, 30 Sep 2015 17:24:25 +0000 (10:24 -0700)]
[V8] Add name of function for function's closure scope
Added ScopeDetails.name field for closure scopes. It contains function's debug name of current context of scope.
BUG=493156
LOG=Y
R=yurys@chromium.org,yangguo@chromium.org
Review URL: https://codereview.chromium.org/
1375813002
Cr-Commit-Position: refs/heads/master@{#31028}
mbrandy [Wed, 30 Sep 2015 17:01:01 +0000 (10:01 -0700)]
PPC: [es6] Introduce spec compliant IsConstructor.
Port
8fe3ac07014ce5891be0a1cbd8019e9f3b02ff0b
Original commit message:
There was already a bit on the Map named "function with prototype",
which basically meant that the Map was a map for a JSFunction that could
be used as a constructor. Now this CL generalizes that bit to
IsConstructor, which says that whatever (Heap)Object you are looking at
can be used as a constructor (i.e. the bit is also set for bound
functions that can be used as constructors and proxies that have a
[[Construct]] internal method).
This way we have a single chokepoint for IsConstructor checking, which
allows us to get rid of the various ways in which we tried to guess
whether something could be used as a constructor or not.
Drive-by-fix: Renamed IsConstructor on FunctionKind to
IsClassConstructor to resolve the weird name clash, and the
IsClassConstructor name also matches the spec.
R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=v8:4413, v8:4430
LOG=n
Review URL: https://codereview.chromium.org/
1382673002
Cr-Commit-Position: refs/heads/master@{#31027}
mbrandy [Wed, 30 Sep 2015 16:29:52 +0000 (09:29 -0700)]
PPC: [runtime] Remove weird pushing of something on StackOverflow.
Port
556b522ac62414c87d05f5d6bab33f6b6cab9b13
Original commit message:
We somehow try to push some stuff on the stack when we detect a stack
overflow, that we don't need. Even worse we might access outside the
valid stack bounds. Since we don't need this, it's gone.
R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=chromium:534881
LOG=n
Review URL: https://codereview.chromium.org/
1382633002
Cr-Commit-Position: refs/heads/master@{#31026}
mbrandy [Wed, 30 Sep 2015 16:28:41 +0000 (09:28 -0700)]
PPC: [builtin] Refactor Invoke to deal with any kind of callable.
Port
634d1d86d8e98584097c6cb548a68ecf705c44f7
Original commit message:
Now both Execution::Call and Execution::New can deal with any
kind of target and will raise a proper exception if the target is not
callable (which is not yet spec compliant for New, as we would
have to check IsConstructor instead, which we don't have yet).
Now we no longer need to do any of these weird call/construct
delegate gymnastics in C++, and we finally have a single true
bottleneck for Call/Construct abstract operations in the code
base, with only a few special handlings left in the compilers to
optimize the JSFunction case.
R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com
BUG=v8:4430, v8:4413
LOG=n
Review URL: https://codereview.chromium.org/
1374683006
Cr-Commit-Position: refs/heads/master@{#31025}
jkummerow [Wed, 30 Sep 2015 15:00:23 +0000 (08:00 -0700)]
Teach JSReceiver::GetKeys() how to include symbols
No users of that functionality yet, those will come separately.
Review URL: https://codereview.chromium.org/
1375003002
Cr-Commit-Position: refs/heads/master@{#31024}
jkummerow [Wed, 30 Sep 2015 14:51:45 +0000 (07:51 -0700)]
Add LookupIterator constructor for arbitrary Object keys
Continuing unification of properties/elements handling, the new
LookupIterator::PropertyOrElement(..., Handle<Object> key, ...) takes
any Object and does the required ToPrimitive/ToName/ToArrayIndex
conversions on it.
Review URL: https://codereview.chromium.org/
1375943002
Cr-Commit-Position: refs/heads/master@{#31023}
neis [Wed, 30 Sep 2015 14:43:14 +0000 (07:43 -0700)]
Reland "Clean up rewriter" (issue
1362333002).
R=rossberg
BUG=
Review URL: https://codereview.chromium.org/
1383553002
Cr-Commit-Position: refs/heads/master@{#31022}
neis [Wed, 30 Sep 2015 14:22:57 +0000 (07:22 -0700)]
Make AstPrinter print position information.
R=rossberg
BUG=
Review URL: https://codereview.chromium.org/
1377833002
Cr-Commit-Position: refs/heads/master@{#31021}
machenbach [Wed, 30 Sep 2015 13:48:08 +0000 (06:48 -0700)]
[swarming] Only isolate d8 with target toolset.
BUG=chromium:535160,chromium:537247
LOG=n
Review URL: https://codereview.chromium.org/
1383473002
Cr-Commit-Position: refs/heads/master@{#31020}
mstarzinger [Wed, 30 Sep 2015 13:46:56 +0000 (06:46 -0700)]
[presubmit] Enable readability/namespace linter checking.
This enables linter checking for "readability/namespace" violations
during presubmit and instead marks the few known exceptions that we
allow explicitly.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
1371083003
Cr-Commit-Position: refs/heads/master@{#31019}
cbruni [Wed, 30 Sep 2015 12:49:07 +0000 (05:49 -0700)]
JSObject::GetEnumProperty cleanup
BUG=
Committed: https://crrev.com/
a00d47c802f93cf9835eafce4c9da2dd10b44f6a
Cr-Commit-Position: refs/heads/master@{#30946}
Review URL: https://codereview.chromium.org/
1363293002
Cr-Commit-Position: refs/heads/master@{#31018}
mstarzinger [Wed, 30 Sep 2015 08:23:55 +0000 (01:23 -0700)]
[heap] Less aggressive inlining of IncrementalMarking code.
This moves some methods of IncrementalMarking from the inlined header
into the compilation unit. The methods in question are either not hot
or are being called through a non-inline function already.
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/
1380523002
Cr-Commit-Position: refs/heads/master@{#31017}
ofrobots [Wed, 30 Sep 2015 06:02:14 +0000 (23:02 -0700)]
remove unused Debug::has_break_points_
Previous debug refactoring changes removed uses of has_break_points_, but
omitted removing the field itself. This is not necessary anymore.
R=yangguo@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
1382443002
Cr-Commit-Position: refs/heads/master@{#31016}
chunyang.dai [Wed, 30 Sep 2015 05:37:28 +0000 (22:37 -0700)]
X87: Introduce LiteralsArray to hide it's implementation.
port
d8cdd6956a04cfcf03159ef7802c44838eee3146 (r31000).
original commit message:
The LiteralsArray will soon hold a type feedback vector. Code treats it as an
ordinary fixed array, and needs to stop that.
BUG=
Review URL: https://codereview.chromium.org/
1378793003
Cr-Commit-Position: refs/heads/master@{#31015}
v8-autoroll@chromium.org [Wed, 30 Sep 2015 17:55:14 +0000 (10:55 -0700)]
Version 4.7.80
Performance and stability improvements on all platforms.
Cr-Commit-Position: refs/heads/4.7.80@{#1}
Cr-Branched-From:
f3c89267db0fc6120d95046c3ff35a35ca34614f-refs/heads/master@{#31014}
v8-autoroll [Wed, 30 Sep 2015 03:24:42 +0000 (20:24 -0700)]
Update V8 DEPS.
Rolling v8/tools/clang to
0150e39a3112dbc7e4c7a3ab25276b8d7781f3b6
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/
1375053003
Cr-Commit-Position: refs/heads/master@{#31014}
akos.palfi [Tue, 29 Sep 2015 22:10:13 +0000 (15:10 -0700)]
GYP: Don't pass -Wno-format-pedantic to GCC.
This flag is not understood correctly by GCC and breaks the GCC ARM and MIPS optdebug builds.
Patch from Brendan Kirby <brendan.kirby@imgtec.com>
BUG=
Review URL: https://codereview.chromium.org/
1369273003
Cr-Commit-Position: refs/heads/master@{#31013}
mlippautz [Tue, 29 Sep 2015 19:17:23 +0000 (12:17 -0700)]
[api] Avoid recursive GCs through reaching external allocation limit
See bug description.
BUG=chromium:536231
LOG=N
Review URL: https://codereview.chromium.org/
1378693002
Cr-Commit-Position: refs/heads/master@{#31012}
dusan.m.milosavljevic [Tue, 29 Sep 2015 17:23:44 +0000 (10:23 -0700)]
MIPS64: Add big-endian support for mips64.
TEST=
BUG=
Review URL: https://codereview.chromium.org/
1334793004
Cr-Commit-Position: refs/heads/master@{#31011}
mstarzinger [Tue, 29 Sep 2015 16:59:01 +0000 (09:59 -0700)]
[heap] No leakage of incremental-marking.h outside of heap.
This prevents the internal incremental-marking.h to be usable outisde
of the "heap" directory. The logic inside that component is only useful
within the GC and is now properly encapsulated.
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/
1374203002
Cr-Commit-Position: refs/heads/master@{#31010}
mstarzinger [Tue, 29 Sep 2015 15:53:08 +0000 (08:53 -0700)]
[turbofan] Pass scope infos as static operator parameters.
This changes the operators for JSCreate[Block|Script]Context to take
their ScopeInfo as a static parameter as opposed to a value input and
in turn allows for easier access to that parameter during lowerings.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1379593002
Cr-Commit-Position: refs/heads/master@{#31009}
jacob.bramley [Tue, 29 Sep 2015 15:11:18 +0000 (08:11 -0700)]
[arm] Fix a double-register push operation.
It is not safe to access memory below sp, and this is also forbidden by
the ABI. When pushing, we must either use an atomic operation (such as
vstm+db_w) or move sp before writing the data.
This patch fixes one stack access, and also adds vpush and vpop helpers
to simplify similar code.
BUG=
Review URL: https://codereview.chromium.org/
1378563002
Cr-Commit-Position: refs/heads/master@{#31008}
mstarzinger [Tue, 29 Sep 2015 14:42:42 +0000 (07:42 -0700)]
[turbofan] Remove obsolete helpers from graph verifier.
The NodeProperties helpers are here to stay and won't go away anytime
soon. This removes a TODO from the graph verifier in that regard.
R=jarin@chromium.org
Review URL: https://codereview.chromium.org/
1375923002
Cr-Commit-Position: refs/heads/master@{#31007}
jarin [Tue, 29 Sep 2015 14:38:56 +0000 (07:38 -0700)]
[turbofan] Make string comparisons effectful.
BUG=v8:4446
LOG=n
Review URL: https://codereview.chromium.org/
1369313004
Cr-Commit-Position: refs/heads/master@{#31006}
jarin [Tue, 29 Sep 2015 13:51:25 +0000 (06:51 -0700)]
[turbofan] Make Strict(Not)Equal, TypeOf, ToBoolean, UnaryNot effectful.
This is necessary because these operators can read heap (equality can actually write heap when flattening strings).
BUG=v8:4446
LOG=n
Review URL: https://codereview.chromium.org/
1374683002
Cr-Commit-Position: refs/heads/master@{#31005}
mlippautz [Tue, 29 Sep 2015 13:07:24 +0000 (06:07 -0700)]
[heap] Remove NewSpace::set_top and the corresponding hack
- Remove the hack the resets the new space top pointer from SeqString::Truncate.
- Remove NewSpace::set_top completely as there are no callers (and there should
be no!)
R=hpayer@chromium.org
BUG=chromium:536163
LOG=N
Review URL: https://codereview.chromium.org/
1376753002
Cr-Commit-Position: refs/heads/master@{#31004}
ishell [Tue, 29 Sep 2015 12:22:39 +0000 (05:22 -0700)]
AST pretty printer fix.
It was broken by https://codereview.chromium.org/
1376443002.
Review URL: https://codereview.chromium.org/
1374923002
Cr-Commit-Position: refs/heads/master@{#31003}
vogelheim [Tue, 29 Sep 2015 11:15:59 +0000 (04:15 -0700)]
Allow JavaScript accessors on API objects.
(This is somewhat experimental; hence protected by #ifdef.)
R=epertoso@chromium.org, jochen@chromium.org
BUG=chromium:508898
LOG=N
Review URL: https://codereview.chromium.org/
1367953002
Cr-Commit-Position: refs/heads/master@{#31002}
hablich [Tue, 29 Sep 2015 10:16:48 +0000 (03:16 -0700)]
[Docs] Fix formatting errors in migrated content
NOTRY=true
NOPRESUBMIT=true
R=machenbach@chromium.org
Review URL: https://codereview.chromium.org/
1373223003
Cr-Commit-Position: refs/heads/master@{#31001}
mvstanton [Tue, 29 Sep 2015 10:15:31 +0000 (03:15 -0700)]
Introduce LiteralsArray to hide it's implementation.
The LiteralsArray will soon hold a type feedback vector. Code treats it as an
ordinary fixed array, and needs to stop that.
BUG=
Review URL: https://codereview.chromium.org/
1374723002
Cr-Commit-Position: refs/heads/master@{#31000}
hablich [Tue, 29 Sep 2015 09:38:04 +0000 (02:38 -0700)]
[Docs] Adding information about general triaging
R=machenbach@chromium.org
NOPRESUBMIT=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1375533003
Cr-Commit-Position: refs/heads/master@{#30999}
hpayer [Tue, 29 Sep 2015 09:08:10 +0000 (02:08 -0700)]
[heap] Reland Remove retry space from AllocateRaw.
BUG=
Review URL: https://codereview.chromium.org/
1374163002
Cr-Commit-Position: refs/heads/master@{#30998}
cbruni [Tue, 29 Sep 2015 08:41:26 +0000 (01:41 -0700)]
[cctest] adding --help option to output basic information about cctest
[run-tests.py]
- adding more detailed information about the flags
- show more detailed error message on failing Popen commands
BUG=
Review URL: https://codereview.chromium.org/
1369343002
Cr-Commit-Position: refs/heads/master@{#30997}
yurys [Tue, 29 Sep 2015 08:18:57 +0000 (01:18 -0700)]
Tell MSAN that profiler doesn't expect sp to point at initialized memory
BUG=v8:4444,v8:4151
LOG=N
Review URL: https://codereview.chromium.org/
1371253002
Cr-Commit-Position: refs/heads/master@{#30996}
mstarzinger [Tue, 29 Sep 2015 08:08:14 +0000 (01:08 -0700)]
[heap] Cleanup string factory methods a bit.
This is mostly removing dead code and also dropping MUST_USE_RESULT
annotations from methods that cannot throw an exception anyways.
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/
1370153002
Cr-Commit-Position: refs/heads/master@{#30995}
jacob.bramley [Tue, 29 Sep 2015 07:48:43 +0000 (00:48 -0700)]
Fix Frame::AlignSavedCalleeRegisterSlots
The return value is expected to be the number of padding slots added to the frame. However, the original logic would return -1 if padding was required, so insufficient stack space would be reserved.
This function now returns either 0 or 1, as the existing calling code expects.
BUG=
Review URL: https://codereview.chromium.org/
1369303002
Cr-Commit-Position: refs/heads/master@{#30994}
bmeurer [Tue, 29 Sep 2015 07:41:03 +0000 (00:41 -0700)]
[es6] Introduce %ToInteger and %ToLength.
This adds ES6 compliant Object::ToInteger, Object::ToInt32,
Object::ToUint32 and Object::ToLength, and replaces the old
Execution wrappers of those abstract operations (which were
not using the correct ToPrimitive).
This also introduces proper %ToInteger and %ToLength runtime
entries, with a fast path %_ToInteger supported in fullcodegen
and Crankshaft (for now). Internal JavaScript code should use
TO_INTEGER and TO_LENGTH respectively.
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_layout_dbg,v8_linux_nosnap_dbg
BUG=v8:4307
LOG=n
Review URL: https://codereview.chromium.org/
1378533002
Cr-Commit-Position: refs/heads/master@{#30993}
machenbach [Tue, 29 Sep 2015 04:53:06 +0000 (21:53 -0700)]
Revert of Clean up rewriter. (patchset #3 id:40001 of https://codereview.chromium.org/
1362333002/ )
Reason for revert:
[Sheriff] Seems to break layout tests:
http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/2073
https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64/2073/layout-test-results/results.html
Please request rebaseline upstream first.
Original issue's description:
> Clean up rewriter.
>
> The main changes are:
> - Fix treatment of loops, which was incorrect and sometimes resulted in
> the wrong completion value.
> - Get rid of unnecessary variables.
>
> This is in preparation of implementing ES6 completion semantics.
>
> R=rossberg
> BUG=
>
> Committed: https://crrev.com/
b466dc14791844b7ae6d1e9ebd00a778965c206d
> Cr-Commit-Position: refs/heads/master@{#30981}
TBR=rossberg@chromium.org,neis@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1379513002
Cr-Commit-Position: refs/heads/master@{#30992}
bmeurer [Tue, 29 Sep 2015 04:39:51 +0000 (21:39 -0700)]
Revert of [heap] Remove retry space from AllocateRaw. (patchset #3 id:40001 of https://codereview.chromium.org/
1370123002/ )
Reason for revert:
Breaks arm64 nosnap simulator (bogus cctest?): https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%201/builds/2934/steps/Bisect%
202786ceec.Retry/logs/IncrementalWriteBarri..
Original issue's description:
> [heap] Remove retry space from AllocateRaw.
>
> BUG=
>
> Committed: https://crrev.com/
2786ceec1eb491494d24d29a59eefbe3b6704be2
> Cr-Commit-Position: refs/heads/master@{#30984}
TBR=mstarzinger@chromium.org,hpayer@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/
1379493003
Cr-Commit-Position: refs/heads/master@{#30991}
mtrofin [Tue, 29 Sep 2015 03:46:53 +0000 (20:46 -0700)]
[turbofan] Greedy: smarter last resort splitting.
When all heuristics fail, we run a "last resort" heuristic. Before, it was
splitting at the first found splittable position either before or after a
use position. That turns out to be too naive: it may split in loops, when
alternative split positions exist outside loops.
This change chooses a "before" use case location that is outside the
loop.
Review URL: https://codereview.chromium.org/
1372213005
Cr-Commit-Position: refs/heads/master@{#30990}
v8-autoroll [Tue, 29 Sep 2015 03:23:41 +0000 (20:23 -0700)]
Update V8 DEPS.
Rolling v8/buildtools to
e7111440c07a883b82ffbbe6d26c744dfc6c9673
TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org
Review URL: https://codereview.chromium.org/
1374833002
Cr-Commit-Position: refs/heads/master@{#30989}
chunyang.dai [Tue, 29 Sep 2015 02:20:47 +0000 (19:20 -0700)]
X87: [es6] Fix invalid ToString in implementation of ToName.
port
09626525fea63396c8a200deb9081d6dd1034d57 (r30957).
original commit message:
BUG=
Review URL: https://codereview.chromium.org/
1370283003
Cr-Commit-Position: refs/heads/master@{#30988}
alph [Mon, 28 Sep 2015 19:34:08 +0000 (12:34 -0700)]
Move heap and CPU profilers into a dedicated directory.
Drive-by: remove unnecessary includes.
Review URL: https://codereview.chromium.org/
1356223004
Cr-Commit-Position: refs/heads/master@{#30987}
oth [Mon, 28 Sep 2015 19:14:16 +0000 (12:14 -0700)]
[Interpreter] Add tests for adding strings and heap number arithmetic.
BUG=v8:4280
LOG=N
Review URL: https://codereview.chromium.org/
1374613002
Cr-Commit-Position: refs/heads/master@{#30986}
mstarzinger [Mon, 28 Sep 2015 18:08:17 +0000 (11:08 -0700)]
[heap] Move CALL_HEAP_FUNCTION macro into factory.cc file.
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/
1372063002
Cr-Commit-Position: refs/heads/master@{#30985}
hpayer [Mon, 28 Sep 2015 18:07:09 +0000 (11:07 -0700)]
[heap] Remove retry space from AllocateRaw.
BUG=
Review URL: https://codereview.chromium.org/
1370123002
Cr-Commit-Position: refs/heads/master@{#30984}
oth [Mon, 28 Sep 2015 18:05:56 +0000 (11:05 -0700)]
[Interpreter] Add interpreter support for compare ops and ToBoolean.
The comparison operators and ToBoolean are implemented by calling into
the runtime. There are new runtime methods are prefixed with Interpreter
to make use case clear.
BUG=v8:4280
LOG=N
Review URL: https://codereview.chromium.org/
1369123002
Cr-Commit-Position: refs/heads/master@{#30983}
ishell [Mon, 28 Sep 2015 16:40:52 +0000 (09:40 -0700)]
Revert of Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (patchset #3 id:80001 of https://codereview.chromium.org/
1361763004/ )
Reason for revert:
This CL breaks cross-compiling to arm.
Original issue's description:
> Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again.
>
> Without that, it has a few false positives about out-of-bounds array accesses.
> Also makes the clang static-analyzer happy.
>
> Original code review from Sven Panne:
> https://codereview.chromium.org/
790723002/
>
> Committed: https://crrev.com/
0b48b2a8ebfc791a36f4ec1f299f46db76265a3a
> Cr-Commit-Position: refs/heads/master@{#30977}
TBR=jochen@chromium.org,bmeurer@chromium.org,jkummerow@chromium.org,karl@skomski.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
1370203002
Cr-Commit-Position: refs/heads/master@{#30982}
neis [Mon, 28 Sep 2015 15:09:42 +0000 (08:09 -0700)]
Clean up rewriter.
The main changes are:
- Fix treatment of loops, which was incorrect and sometimes resulted in
the wrong completion value.
- Get rid of unnecessary variables.
This is in preparation of implementing ES6 completion semantics.
R=rossberg
BUG=
Review URL: https://codereview.chromium.org/
1362333002
Cr-Commit-Position: refs/heads/master@{#30981}
ishell [Mon, 28 Sep 2015 15:04:11 +0000 (08:04 -0700)]
Add ishell@ and mvstanton@ to full codegen owners list.
NOTRY=true
Review URL: https://codereview.chromium.org/
1371913006
Cr-Commit-Position: refs/heads/master@{#30980}
caitpotter88 [Mon, 28 Sep 2015 14:51:42 +0000 (07:51 -0700)]
[test] Remove FAIL expectation for intl/collator/default-locale on Android and Mac
BUG=v8:2899
LOG=N
R=
Review URL: https://codereview.chromium.org/
1364583004
Cr-Commit-Position: refs/heads/master@{#30979}
ben [Mon, 28 Sep 2015 14:12:35 +0000 (07:12 -0700)]
Fix DCHECK in ScopeInfo::Print().
Review URL: https://codereview.chromium.org/
1369913002
Cr-Commit-Position: refs/heads/master@{#30978}
karl [Mon, 28 Sep 2015 14:02:50 +0000 (07:02 -0700)]
Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again.
Without that, it has a few false positives about out-of-bounds array accesses.
Also makes the clang static-analyzer happy.
Original code review from Sven Panne:
https://codereview.chromium.org/
790723002/
Review URL: https://codereview.chromium.org/
1361763004
Cr-Commit-Position: refs/heads/master@{#30977}
machenbach [Mon, 28 Sep 2015 13:59:38 +0000 (06:59 -0700)]
[test] Remove test262-es6.
This was copied into test262.
BUG=v8:4254
NOTRY=true
LOG=n
Review URL: https://codereview.chromium.org/
1368313002
Cr-Commit-Position: refs/heads/master@{#30976}
jkummerow [Mon, 28 Sep 2015 13:10:13 +0000 (06:10 -0700)]
objects-inl.h: Remove ACCESSORS_TO_SMI macro
Replacing it with SMI_ACCESSORS.
This change makes accesses to Smi fields in objects more regular (the
accessors now always consume/return an int rather than a Smi*), which
avoids a bunch of manual Smi::FromInt() and Smi::value() conversions,
and is a step on the way towards being able to generate objects-inl.h.
Review URL: https://codereview.chromium.org/
1371893002
Cr-Commit-Position: refs/heads/master@{#30975}
ishell [Mon, 28 Sep 2015 13:02:43 +0000 (06:02 -0700)]
Removing the Class/ObjectLiteral::LayoutFeedbackSlots().
Review URL: https://codereview.chromium.org/
1372003002
Cr-Commit-Position: refs/heads/master@{#30974}
mstarzinger [Mon, 28 Sep 2015 12:55:45 +0000 (05:55 -0700)]
[heap] Simplify CALL_HEAP_FUNCTION macro dance.
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/
1371943002
Cr-Commit-Position: refs/heads/master@{#30973}
andybons [Mon, 28 Sep 2015 12:40:25 +0000 (05:40 -0700)]
[Docs] Add wiki content to Markdown docs
NOTE: You will have to land this as I don’t have write perms to this repo.
BUG=none
R=hablich@chromium.org
Review URL: https://codereview.chromium.org/
1347153006
Cr-Commit-Position: refs/heads/master@{#30972}
ishell [Mon, 28 Sep 2015 11:41:40 +0000 (04:41 -0700)]
Refactored interface of FeedbackVectorSpec and friends.
This is a second step towards merging FeedbackVectorSlot and FeedbackVectorICSlot.
Review URL: https://codereview.chromium.org/
1376443002
Cr-Commit-Position: refs/heads/master@{#30971}
neis [Mon, 28 Sep 2015 11:16:55 +0000 (04:16 -0700)]
[es6] Ship rest parameters.
R=rossberg
BUG=
Review URL: https://codereview.chromium.org/
1371963002
Cr-Commit-Position: refs/heads/master@{#30970}