platform/core/appfw/aul-1.git
10 months agoRelease version 0.53.12 37/316137/1 accepted/tizen_7.0_unified tizen_7.0 accepted/tizen/7.0/unified/20240815.165236
Hwankyu Jhun [Wed, 14 Aug 2024 04:13:52 +0000 (13:13 +0900)]
Release version 0.53.12

Changes:
 - Fix thread safe issue

Change-Id: I7ea3d09ca47026a9dc986d7da1aae24d9ada2b33
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
10 months agoFix thread safe issue
Hwankyu Jhun [Wed, 14 Aug 2024 03:11:08 +0000 (12:11 +0900)]
Fix thread safe issue

This patch is to fix the following issue:
+------------------------------------------------------------------------------+
| Thread 18 (LWP 16980):                                                       |
| #8  0xf671776e in g_log (log_domain=<optimized out>, log_level=log           |
|                _level@entry=G_LOG_LEVEL_CRITICAL, format=0xf6755a34          |
|                "Source ID %u was not found when attempting to remove it")    |
|                at ../glib/gmessages.c:1455 --> libglib (rpm)                 |
| #9  0xf6711956 in g_source_remove (tag=33111) at ../glib/gmain.c:2543        |
| #10 0xf5d031fa in (anonymous namespace)::WatchdogContext::Stop               |
|                (this=0xf5d41dd0 <_ZN12_GLOBAL__N_17contextE>) at             |
|                /usr/src/debug/aul-0.53.7-1.arm/src/aul_watchdog.cc:122       |
|                                                                              |
| Thread 1 (LWP 16979):                                                        |
| #0  g_source_destroy_internal (source=0xe923a230, context=0xaca04b88,        |
|                               have_lock=0) at ../glib/gmain.c:1331           |
| #1  0xf671193e in g_source_remove (tag=33111) at ../glib/gmain.c:2541        |
| #2  0xf5d031fa in (anonymous namespace)::WatchdogContext::Stop               |
|          (this=0xf5d41dd0 <_ZN12_GLOBAL__N_17contextE>) at             |
|                /usr/src/debug/aul-0.53.7-1.arm/src/aul_watchdog.cc:122       |
+------------------------------------------------------------------------------+

Locking mutex is added for thread safe.

Change-Id: I404186b4d4bf04e03fd27fe56dd188aa0381d1df
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
12 months agoRelease version 0.53.11 57/312157/1 accepted/tizen/7.0/unified/20240607.172802
Sangyoon Jang [Wed, 5 Jun 2024 01:05:37 +0000 (10:05 +0900)]
Release version 0.53.11

Changes:
 - Add a new key for library resource package

Change-Id: I50ad49673ae2f9b93d8e0db64d108616d2ef1b46
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
12 months agoAdd a new key for library resource package 03/311903/1
Sangyoon Jang [Thu, 30 May 2024 06:00:26 +0000 (15:00 +0900)]
Add a new key for library resource package

Change-Id: I827b32ad4ab83598d0e591f88a78b75bf4ed78bc
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
13 months agoRelease version 0.53.10 08/311008/1 accepted/tizen/7.0/unified/20240513.165733
Hwankyu Jhun [Mon, 13 May 2024 03:25:12 +0000 (12:25 +0900)]
Release version 0.53.10

Changes:
 - Send ping before adding the watchdog timer

Change-Id: I0937cc310f3ac873e6aa899e78442f2f88610a11
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
13 months agoSend ping before adding the watchdog timer
Hwankyu Jhun [Mon, 12 Jun 2023 01:35:56 +0000 (01:35 +0000)]
Send ping before adding the watchdog timer

Before adding the watchdog timer, AUL library sends the ping request to
AMD to notify.

Change-Id: Ieeabfcb88848e428e7b9a94c3f3b66fa93415fbd
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
13 months agoRelease version 0.53.9 52/310052/1 accepted/tizen/7.0/unified/20240425.011912
Hwankyu Jhun [Sun, 21 Apr 2024 22:58:33 +0000 (07:58 +0900)]
Release version 0.53.9

Changes:
 - Add new definitions for NUIGadget

Change-Id: I8a374272ebd555a1d197d6fa76cc136a9b02fdf6
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
16 months agoAdd new definitions for NUIGadget
Hwankyu Jhun [Fri, 19 Jan 2024 03:50:05 +0000 (12:50 +0900)]
Add new definitions for NUIGadget

Adds:
 - AUL_K_MOUNT_GADGET_PKGIDS
 - AUL_K_MOUNT_GADGET_PATHS

Change-Id: I54a8e8b882192faf819a280fe79db88aa9ffc82c
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
16 months agoRelease version 0.53.8 accepted/tizen/7.0/unified/20240118.170612
Hwankyu Jhun [Thu, 18 Jan 2024 00:05:15 +0000 (09:05 +0900)]
Release version 0.53.8

Changes:
 - Remove the logic that checks channel lock during __send_result()
 - Use global mutex variable on __send_result()
 - Fix wrong error handling
 - Add a missing mutex unlock

Change-Id: I8d5015a1fc23e6d80828e3658ebd118f65abe6bf
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
16 months agoAdd a missing mutex unlock
Hwankyu Jhun [Tue, 16 Jan 2024 03:27:04 +0000 (12:27 +0900)]
Add a missing mutex unlock

The recursive mutex must be unlocked before returning the function.

Change-Id: I5bf3e62fa3d7ac6c14cb3f8bb022a68d69fa2a9c
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
16 months agoFix wrong error handling
Hwankyu Jhun [Tue, 16 Jan 2024 02:17:04 +0000 (11:17 +0900)]
Fix wrong error handling

If aul library does not find the client channel, the request must be ignored.

Change-Id: If45da924ad3479d1c02a51c7c48cbd68d689093d
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
16 months agoUse global mutex variable on __send_result()
Changgyu Choi [Mon, 16 Oct 2023 08:30:38 +0000 (17:30 +0900)]
Use global mutex variable on __send_result()

The socket io of aul+ require mutex because read and write can occur at the same time.
This patch uses the global mutex instead of the previously removed channel mutex.

Change-Id: I7189dc4567c2a0150e40877b67f42baf62719b4a
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
16 months agoRemove the logic that checks channel lock during __send_result()
Changgyu Choi [Mon, 16 Oct 2023 07:51:21 +0000 (16:51 +0900)]
Remove the logic that checks channel lock during __send_result()

Client channel can be invalid when calling __send_result() into the main thread.
This patch removes the use of invalid mutex in these cases.

Change-Id: I1635f78431187314003bb8f2e53804d7f9231dd1
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
18 months agoRelease version 0.53.7 55/302155/1 accepted/tizen/7.0/unified/20231204.175241
Hwankyu Jhun [Fri, 1 Dec 2023 07:13:40 +0000 (16:13 +0900)]
Release version 0.53.7

Changes:
 - Modify boot sequence parser

Change-Id: I47b71de0a69eb96031ce1308049ec7d40e8372f6
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
18 months agoModify boot sequence parser
Hwankyu Jhun [Thu, 30 Nov 2023 07:50:36 +0000 (16:50 +0900)]
Modify boot sequence parser

After this patch is applied, the parser does not check on-boot option.
It only checks the boot-sequence exists in the tizen-manifest.xml or not.
The dotnet API version has been integrated into the Tizen API version.

Change-Id: I8eed1c8fa537cc6dad0237cb034c61ed06823309
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
23 months agoRelease version 0.53.6 73/295373/1 accepted/tizen/7.0/unified/20230707.160802
Hwankyu Jhun [Thu, 6 Jul 2023 07:09:59 +0000 (16:09 +0900)]
Release version 0.53.6

Changes:
 - Fix a static analysis issue
 - Fix bugs about boot sequence parser plugin

Change-Id: I9c315a33e48eec6dcbfba17bbe79a37a9e29e5a5
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
23 months agoFix bugs about boot sequence parser plugin
Hwankyu Jhun [Thu, 6 Jul 2023 06:57:18 +0000 (15:57 +0900)]
Fix bugs about boot sequence parser plugin

The condition of if statements are wrong. If the value is not 'true' or 'false',
the parser plugin should set the default value.

Change-Id: I41b44aa90779d4bc74711d955ce9fcdea03264a1
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
23 months agoFix a static analysis issue
Changgyu Choi [Tue, 20 Jun 2023 04:24:48 +0000 (13:24 +0900)]
Fix a static analysis issue

Changes:
 - Adds checking whether root is nullptr or not.

Change-Id: I694e8f0f696e9c4d4097adc876e7f868988458c8
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoRelease version 0.53.5 33/292933/1
Hwankyu Jhun [Wed, 17 May 2023 07:11:45 +0000 (07:11 +0000)]
Release version 0.53.5

Changes:
 - Modify CPU inheritance feature

Change-Id: I3d2cc2f906e318e1d085c115829f46f1513966d5
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoModify CPU inheritance feature
Hwankyu Jhun [Wed, 17 May 2023 00:15:34 +0000 (00:15 +0000)]
Modify CPU inheritance feature

If the request is APP_SEND_LAUNCH_REQUEST or APP_SEND_RESUME_REQUEST,
the cpu inheritance should continue until the result event is received.
This patch separates the cpu inheritance class from the aul sock code.
The class is added to the ErrorInfo to inherit the CPU boosting.

Change-Id: Ife5c6a07957af7c8fbcbda51701b150b656a6c56
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.53.4 30/292830/1 accepted/tizen/7.0/unified/20230517.025711
ilho kim [Mon, 15 May 2023 10:29:33 +0000 (19:29 +0900)]
Release version 0.53.4

Changes:
 - Add APIs for getting path related Resource Control

Change-Id: I07910340a39a0421f4456591793eaab344e007ee
Signed-off-by: ilho kim <ilho159.kim@samsung.com>
2 years agoAdd APIs for getting path related Resource Control 85/292785/1
ilho kim [Tue, 21 Mar 2023 05:35:38 +0000 (14:35 +0900)]
Add APIs for getting path related Resource Control

- add aul_get_app_res_control_allowed_resource_path()
- add aul_get_app_res_control_global_resource_path()

Change-Id: I70ff0a2f98f100ef8198090d4b3ec3f8eb81599f
Signed-off-by: ilho kim <ilho159.kim@samsung.com>
(cherry picked from commit 98ac1743f8f5c99c5ab4c9ff9ddd314ef3a86f2c)

2 years agoRelease version 0.53.3 63/292263/1
Hwankyu Jhun [Tue, 2 May 2023 23:48:30 +0000 (23:48 +0000)]
Release version 0.53.3

Changes:
 - Modify aul_rpc_port_usr_exist() function

Change-Id: I4e5457e6ce4de3cac0a8ab2c625bb57718ed44dd
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoModify aul_rpc_port_usr_exist() function
Hwankyu Jhun [Tue, 2 May 2023 08:07:47 +0000 (08:07 +0000)]
Modify aul_rpc_port_usr_exist() function

To avoid delay issue, the function uses access() function instead of
IPC with AMD.

Change-Id: Ifa096ad1ff66e09d21e4373dd214707681c38a45
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.53.2 72/289572/1 accepted/tizen/7.0/unified/20230417.041002
Hwankyu Jhun [Fri, 10 Mar 2023 01:02:08 +0000 (01:02 +0000)]
Release version 0.53.2

Changes:
 - Modify aul_app_event_destroy() function

Change-Id: Ia22ae6dcd05431ccb3e0bb8c89c0385a3ac2e541
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoModify aul_app_event_destroy() function
Hwankyu Jhun [Thu, 9 Mar 2023 23:12:15 +0000 (23:12 +0000)]
Modify aul_app_event_destroy() function

If the caller thread ID is equal to the caller process ID,
the function releases the handle immediately. If it's not,
the function uses glib idler to avoid thread safe issues.

Change-Id: Id8272fb15be06459bab153932c4e1c0a9115fbf6
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.53.1 81/289481/1
Hwankyu Jhun [Wed, 8 Mar 2023 23:56:01 +0000 (23:56 +0000)]
Release version 0.53.1

Changes:
 - Modify aul_app_com_leave function

Change-Id: Ibb60049354a3e9e2012095289b40282323990c4c
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoModify aul_app_com_leave function
Hwankyu Jhun [Wed, 8 Mar 2023 10:15:22 +0000 (10:15 +0000)]
Modify aul_app_com_leave function

Some program goes to the sleep state immediately after calling
the aul_app_com_leave() function. In this case, the main thread of the
process will be blocked. It causes increasing memory usage.
To avoid the issue, the aul_app_com_leave() function sends the
APP_COM_LEAVE command to the amd to deregister the event.

Change-Id: Ic3d27b8c4151955094887fea59ed25cda08d2faf
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.53.0 51/289151/1
Hwankyu Jhun [Thu, 2 Mar 2023 06:35:57 +0000 (06:35 +0000)]
Release version 0.53.0

Changes:
 - Add get/set window position api

Change-Id: I3b16b3d81227a691fb1ccae6f9d147af6f2b7e6d
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoAdd get/set window position api
SukhyungKang [Tue, 17 Jan 2023 01:27:08 +0000 (10:27 +0900)]
Add get/set window position api

Change-Id: I34623f70a1c92f498b8e5674d074ed90182d409a
Signed-off-by: SukhyungKang <shine.kang@samsung.com>
2 years agoRelease version 0.52.3 44/289144/1 accepted/tizen/7.0/unified/20230327.042616
Hwankyu Jhun [Thu, 2 Mar 2023 04:31:39 +0000 (04:31 +0000)]
Release version 0.52.3

Changes:
 - Fix typo

Change-Id: I9a068067d3f915247ff36466400d186c3e2c0e24
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix typo
Hwankyu Jhun [Thu, 2 Mar 2023 04:25:28 +0000 (04:25 +0000)]
Fix typo

The header guard should be "__AUL_PROC_GROUP_H__".

Change-Id: Ifc8ef3012e8896ade6765b10c60938549d1344e6
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.52.2 38/289138/1
Changgyu Choi [Thu, 2 Mar 2023 03:33:33 +0000 (12:33 +0900)]
Release version 0.52.2

Changes:
 - Fix unittest about APP_COM_LEAVE changes

Change-Id: Ibfd455690c8ceec2d10ca3491d492acea4b921b1
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoFix unittest about APP_COM_LEAVE changes
Changgyu Choi [Thu, 2 Mar 2023 03:27:17 +0000 (12:27 +0900)]
Fix unittest about APP_COM_LEAVE changes

Change-Id: Ia44bcfe4169248a2d58744147de2f148df5f29e0
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoRelease version 0.52.1 34/288934/1
Changgyu Choi [Fri, 24 Feb 2023 12:26:11 +0000 (21:26 +0900)]
Release version 0.52.1

Changes:
 - Change APP_COM_LEAVE request to async

Change-Id: Iaec846d6935b5b28525f5b7c3e783e828bb84c7e
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoChange APP_COM_LEAVE request to async 33/288933/1
Changgyu Choi [Fri, 24 Feb 2023 12:13:41 +0000 (21:13 +0900)]
Change APP_COM_LEAVE request to async

Change-Id: Ide3fa434d17c9f24e16c7ad6d7444752857c8ba0
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoRelease version 0.52.0 55/287655/1 accepted/tizen/7.0/unified/20230203.164116 accepted/tizen/7.0/unified/20230207.015131
Hwankyu Jhun [Thu, 2 Feb 2023 04:01:03 +0000 (04:01 +0000)]
Release version 0.52.0

Changes:
 - Add a new aul key for res-control

Change-Id: I532d53814b513819b9fe8fd2c548f4344eeb1311
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoAdd a new aul key for res-control
Sangyoon Jang [Fri, 18 Nov 2022 07:08:21 +0000 (16:08 +0900)]
Add a new aul key for res-control

This key represents resource packages which will be mounted.

Change-Id: I88458ca382781ddc667d95c4cc275a251271c95d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoRelease version 0.51.4 41/287641/1
Hwankyu Jhun [Thu, 2 Feb 2023 01:32:17 +0000 (01:32 +0000)]
Release version 0.51.4

Changes:
 - Fix static analysis issue

Change-Id: Ie419dde8bc513f24ec9cfa8ef225c332e56ab99f
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix static analysis issue
Hwankyu Jhun [Thu, 2 Feb 2023 01:24:10 +0000 (01:24 +0000)]
Fix static analysis issue

Type:
 - Wrapper object use after free

Change-Id: I59d1606ec71b4329df15ca41f65d3fe68f4d7522
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.51.3 77/287277/1 accepted/tizen/7.0/unified/20230127.052907
Hwankyu Jhun [Thu, 26 Jan 2023 06:53:28 +0000 (06:53 +0000)]
Release version 0.51.3

Changes:
 - Fix double close issue

Change-Id: I0e9db5cf2b8d8f4bb109a8166419d74f2fe6b5dd
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix double close issue
Hwankyu Jhun [Thu, 26 Jan 2023 06:08:56 +0000 (06:08 +0000)]
Fix double close issue

When calling the g_io_channel_unref() function, the socket fd is closed
by the glib. The AUL library has a problem that is a double close issue.
This patch is to fix the issue.

+------------------------------------------------------------------------------+
| [__AUL_WORKER__] close(188)                                                  |
| close backtrace() returned 9 addesses                                        |
| [ 0] close /lib/libinterceptor.so(close+0x4d) [0xb60da72a]                   |
| [ 1] ? /lib/libglib-2.0.so.0(+0x430c00ea) [0xb0a620ea]                       |
| [ 2] g_io_channel_shutdown /lib/libglib-2.0.so.0(g_io_channel_shutdown+0x75) |
|      [0xb0aa49f2]                                                            |
| [ 3] ? /lib/libaul.so.0(+0x43c0df00) [0xae66ff00]                            |
| [ 4] g_list_foreach /lib/libglib-2.0.so.0(g_list_foreach+0x13) [0xb0a99080]  |
| [ 5] g_list_free_full /lib/libglib-2.0.so.0(g_list_free_full+0x9)            |
|      [0xb0a9dc0e]                                                            |
| [ 6] ? /lib/libaul.so.0(+0x43c0e284) [0xae670284]                            |
| [ 7] ? /lib/libglib-2.0.so.0(+0x430dbc42) [0xb0a7dc42]                       |
| [ 8] ? /lib/libpthread.so.0(+0x430174c4) [0xb5d044c4]                        |
+------------------------------------------------------------------------------+
| [__MAIN__] close(188)                                                        |
| close backtrace() returned 13 addesses                                       |
| [ 0] close /lib/libinterceptor.so(close+0x4d) [0xb60da72a]                   |
| [ 1] aul_sock_destroy_server /lib/libaul.so.0(aul_sock_destroy_server+0x2e3) |
|      [0xae67302c]                                                            |
| [ 2] aul_finalize /lib/libaul.so.0(aul_finalize+0x15) [0xae673196]           |
| [ 3] _ZN9tizen_cpp11AppCoreBase11OnTerminateEv                               |
|      /lib/libapp-core-cpp.so.1(_ZN9tizen_cpp11AppCoreBase11OnTerminateEv+0x5)|
| [0xae22d046]                                                           |
| [__MAIN__] EBADF occurs. fd(188)                                             |
+------------------------------------------------------------------------------+

Change-Id: Id465eefae87653d2acb706875732ec176ce95bb1
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.51.2 64/286664/1 accepted/tizen/7.0/unified/20230113.171622
Hwankyu Jhun [Wed, 11 Jan 2023 10:31:42 +0000 (10:31 +0000)]
Release version 0.51.2

Changes:
 - Add appsvc alias feature for tv profile
 - Make a cache for getting appsvc alias appid

Change-Id: I45665f582fe64c6dcfa9f1eb29e7442b9292f0ff
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoMake a cache for getting appsvc alias appid
Hwankyu Jhun [Wed, 11 Jan 2023 09:38:04 +0000 (09:38 +0000)]
Make a cache for getting appsvc alias appid

To reduce the file access, the aul library stores the alias info to the memory.

Change-Id: I34d2b66aafe84723ebb7e63d477127a30ba8b60c
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoAdd appsvc alias feature for tv profile
Hwankyu Jhun [Wed, 11 Jan 2023 09:05:45 +0000 (09:05 +0000)]
Add appsvc alias feature for tv profile

If the profile is tv, the library does not check whether the alias appid
exists or not.

Change-Id: I504d6970a334664633a6aff4dee456cee8691653
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.51.1 33/286633/1
Hwankyu Jhun [Wed, 11 Jan 2023 00:15:50 +0000 (00:15 +0000)]
Release version 0.51.1

Changes:
 - Check process group ID for getting appid and pkgid

Change-Id: Icc7f1910db4aecb53604ad8a3d0bdc2f1459ce86
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoCheck process group ID for getting appid and pkgid
Hwankyu Jhun [Tue, 10 Jan 2023 23:56:50 +0000 (23:56 +0000)]
Check process group ID for getting appid and pkgid

The web engine is running as a child process of the web app.
If the web engine calls AUL APIs, the request is delivered to AMD.
Because, the process ID is not equal to the web app.
After this patch is applied, AUL API checks whether the process group ID
is equal to the process ID or not. Before executing an application,
the child process of the launchpad-process-pool calls the setsid() to
run the process in a new session. In that time, the process group is separated
from the launchpad-process-pool. Checking the process group ID can reduce
the IPC between AMD and the caller process.

Change-Id: I3746046c36328ecacc27c6cda16afbe44c1e1cfd
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.51.0 84/286284/1 accepted/tizen/7.0/unified/20230105.155139 accepted/tizen/unified/20230104.172222
Hwankyu Jhun [Tue, 3 Jan 2023 06:23:20 +0000 (06:23 +0000)]
Release version 0.51.0

Changes:
 - Add new internal functions for candidate processes

Change-Id: Iddf5f004d9c2a8557936918b64c44c3f8e9d49b4
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoAdd new internal functions for candidate processes 70/286270/2
Hwankyu Jhun [Tue, 3 Jan 2023 04:43:25 +0000 (04:43 +0000)]
Add new internal functions for candidate processes

To initialize aul worker thread in the loader process,
the aul_launch_worker_init() is added.

Adds:
 - aul_launch_worker_init()
 - aul_launch_worker_fini()

Change-Id: I6d2707f16f7f82a0a98b79369c37b46909746eff
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.50.8 96/286196/1 accepted/tizen/7.0/unified/20230102.132433 accepted/tizen/unified/20230102.132008
Changgyu Choi [Fri, 30 Dec 2022 04:35:51 +0000 (13:35 +0900)]
Release version 0.50.8

Changes:
 - Refactor app_signal.cc
 - Fix static analysis issues

Change-Id: I5f7da94cc8ad9b30e4924e3bee908eb3ebf62d96
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoFix static analysis issues 79/286179/2
Changgyu Choi [Fri, 30 Dec 2022 01:31:04 +0000 (10:31 +0900)]
Fix static analysis issues

To prevent int to size_t casting, this patch changes vec_max_size type
to size_t.

Change-Id: I3655d6e63c4d8b1daf1a3137923b85fb269e664c
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoRefactor app_signal.cc 93/286093/6
Changgyu Choi [Tue, 27 Dec 2022 11:12:30 +0000 (20:12 +0900)]
Refactor app_signal.cc

This is for the multi threading environment.
If some sub-threads unsubscribe the event, there is room for problems due to race condition.
This patch is changed to maintain the Event object without destruction after creation.

Change-Id: Ieefca296875c14e33d195d2809bc5134485915a5
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoRelease version 0.50.7 96/285896/1 accepted/tizen/7.0/unified/20221223.170219 accepted/tizen/unified/20221227.170631
Changgyu Choi [Thu, 22 Dec 2022 06:27:06 +0000 (15:27 +0900)]
Release version 0.50.7

Changes:
 - Fix library path for aarch64

Change-Id: I9ec7d8cdd734e0bc26d12dbf2384c0bbe8264fd4
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoFix library path for aarch64 84/285884/1
Changgyu Choi [Thu, 22 Dec 2022 05:51:35 +0000 (14:51 +0900)]
Fix library path for aarch64

Change-Id: I3f7f03fc8fb861efab7afdbe02e856962067c8c7
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoRelease version 0.50.6 88/284188/1 accepted/tizen/7.0/unified/20221115.022319 accepted/tizen/unified/20221115.022410
Changgyu Choi [Fri, 11 Nov 2022 07:10:27 +0000 (16:10 +0900)]
Release version 0.50.6

Changes:
 - Add AUL_SVC_RET_ETIMEOUT error

Change-Id: I2e1222ed14ead6e333666103cd9287aea6112077
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoAdd AUL_SVC_RET_ETIMEOUT error 79/284079/2
Changgyu Choi [Wed, 9 Nov 2022 08:46:59 +0000 (17:46 +0900)]
Add AUL_SVC_RET_ETIMEOUT error

Currently, app_control_send_launch_request() has returned REJECTED error
even though timeout.
After applying this patch, app receive APP_CONTROL_ERROR_TIMED_OUT when
app_control_send_launch_request() occurs time out.

Change-Id: I2b32627cd1c6189d97834d926009720b55e49a6c
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoRelease version 0.50.5 99/283999/1 accepted/tizen/7.0/unified/20221109.171217 accepted/tizen/7.0/unified/20221110.061606 accepted/tizen/unified/20221109.171121
Hwankyu Jhun [Tue, 8 Nov 2022 08:21:30 +0000 (08:21 +0000)]
Release version 0.50.5

Changes:
 - Modify sequence number generation

Change-Id: I0c506b25a2b2ffbcfd2295a4ff96507149e8b113
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoModify sequence number generation 95/283995/1
Hwankyu Jhun [Tue, 8 Nov 2022 08:02:08 +0000 (08:02 +0000)]
Modify sequence number generation

To avoid duplication of sequence number, AUL uses uuid to generate.

Change-Id: Ic6072e3aa1efeadc0adfdc948b75f1f236e0c2a0
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.50.4 85/283685/1 accepted/tizen/unified/20221108.163848
Hwankyu Jhun [Wed, 2 Nov 2022 01:54:10 +0000 (01:54 +0000)]
Release version 0.50.4

Changes:
 - Refactor status API
 - Add unit tests for watch control API
 - Add unit tests for launcher service API
 - Refactor watch control API
 - Refactor launcher service API

Change-Id: Ib19ab89b17bed6cc03f6ea4139ef9223d243ad9a
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRefactor launcher service API 61/283661/1
Hwankyu Jhun [Tue, 1 Nov 2022 05:43:42 +0000 (05:43 +0000)]
Refactor launcher service API

The launcher service API is implemented using C++ language.

Change-Id: I153e79142f1cda1f6a4eb145ab2f1b47f4df9e74
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRefactor watch control API 48/283648/2
Hwankyu Jhun [Tue, 1 Nov 2022 02:46:43 +0000 (02:46 +0000)]
Refactor watch control API

The watch control API is refactored using C++ language.

Change-Id: I474c034f4998bfdf8483406ba157d3b97dbb4ade
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoAdd unit tests for launcher service API 43/283643/2
Hwankyu Jhun [Tue, 1 Nov 2022 00:40:11 +0000 (00:40 +0000)]
Add unit tests for launcher service API

To refactor launcher service API, unit tests are added.

Change-Id: I2c1604a60e6bfcb380f6d58b52032d756570f7d1
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoAdd unit tests for watch control API 19/283619/2
Hwankyu Jhun [Mon, 31 Oct 2022 10:32:41 +0000 (10:32 +0000)]
Add unit tests for watch control API

To refactor watch control API, unit tests are added

Change-Id: If1517e2d70e90f65897165430acbcde010e82a08
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRefactor status API 27/283127/3
Hwankyu Jhun [Tue, 18 Oct 2022 10:34:23 +0000 (10:34 +0000)]
Refactor status API

The status API is implmented using C++ language.

Change-Id: Ia1930ea1565b7710e266a224f02826486df54bb6
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.50.3 85/283085/1
Changgyu Choi [Tue, 18 Oct 2022 02:26:07 +0000 (11:26 +0900)]
Release version 0.50.3

Changes:
 - Fix static analysis issues

Change-Id: I50e945c8afd52b439bced253a2627c3267d25d49
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoFix static analysis issues 28/283028/1
Changgyu Choi [Mon, 17 Oct 2022 03:10:10 +0000 (12:10 +0900)]
Fix static analysis issues

Change-Id: Ib109973cdd9d97062c9dd3dce7703a513f78fe87
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoRelease version 0.50.2 42/282542/1 accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/hotfix/20221116.104958 accepted/tizen/unified/20221006.065329 accepted/tizen/unified/20221006.065404 tizen_7.0_m2_release
Hwankyu Jhun [Wed, 5 Oct 2022 08:31:43 +0000 (08:31 +0000)]
Release version 0.50.2

Changes:
 - Consider 64-bit environment

Change-Id: I379d706592f25a80acf00ec33beeab1bb01b1322
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoConsider 64-bit environment 33/282533/1
Hwankyu Jhun [Wed, 5 Oct 2022 06:44:18 +0000 (06:44 +0000)]
Consider 64-bit environment

The kPathLibAulServer should be changed to /usr/lib64/ if the package is
building for aarch64 or x86_64 architecture.

Change-Id: I997fc4bf9b3d3a16cab53eaba302dd85685ad012
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.50.1 19/282119/1 accepted/tizen/unified/20220928.144434
Hwankyu Jhun [Tue, 27 Sep 2022 06:55:05 +0000 (06:55 +0000)]
Release version 0.50.1

Changes:
 - Fix static analysis issue
 - Use modified tizen_base::Parcel
 - Fix static analysis issues

Change-Id: I09d83e4cac3eba3b146a9c73e2b8d2e9e49495b1
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix static analysis issues 07/282107/2
Hwankyu Jhun [Tue, 27 Sep 2022 06:13:25 +0000 (06:13 +0000)]
Fix static analysis issues

The following issues are fixed:
 - ODR_VIOLATION

Change-Id: I21535974477d97dd9c93eb570870557202d8f897
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoUse modified tizen_base::Parcel 50/281950/2
Hwankyu Jhun [Fri, 23 Sep 2022 10:41:39 +0000 (10:41 +0000)]
Use modified tizen_base::Parcel

To improve the performance of the parcel creation, the implementation of
the Parcel is changed. It uses malloc() instead of std::vector.

Requires:
 - https://review.tizen.org/gerrit/#/c/platform/core/base/bundle/+/281779/

Change-Id: I19b804a5be94dd814a83a1067f3924e1085ccece
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix static analysis issue 81/282081/1
Hwankyu Jhun [Tue, 27 Sep 2022 02:08:15 +0000 (02:08 +0000)]
Fix static analysis issue

This patch fixes 'use after free' case. The bundle instance is moved
using std::move().

Change-Id: I3e00efdb42038c1a324e3a687678829e6a5b3eaa
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.50.0 19/280919/1 accepted/tizen/unified/20220908.013408
Changgyu Choi [Wed, 7 Sep 2022 00:27:20 +0000 (09:27 +0900)]
Release version 0.50.0

Changes:
 - Add aul_package_pre_event_send()

Change-Id: I0cb9a95fbd6bc446fc693b670ff4efca3d52fc92
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoAdd aul_package_pre_event_send() 92/280292/8
Changgyu Choi [Fri, 26 Aug 2022 08:18:39 +0000 (17:18 +0900)]
Add aul_package_pre_event_send()

This api send signal to amd before sending pkg event to listeners.
amd should reload appinfo before some apps that is listening pkg event.

Change-Id: I82b4d8f8a8e5d1a93ee8d1e7aa13f81df34a077d
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoRelease version 0.49.8 74/280574/1 accepted/tizen/unified/20220902.020127 submit/tizen/20220901.022344
Hwankyu Jhun [Thu, 1 Sep 2022 01:57:55 +0000 (01:57 +0000)]
Release version 0.49.8

Changes:
 - Check packet header length

Change-Id: Ia193665c94ed60fdc5f041c1277daaeb7280adcc
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoCheck packet header length 69/280569/2
Hwankyu Jhun [Thu, 1 Sep 2022 01:28:50 +0000 (01:28 +0000)]
Check packet header length

To check whether the packet is valid or not, the packet length should be checked.

Change-Id: I64063aa17c61e6fb43f2ad3f544ca79e44dce665
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.49.7 75/280275/1 accepted/tizen/unified/20220830.032659 submit/tizen/20220826.060801
Hwankyu Jhun [Fri, 26 Aug 2022 05:28:25 +0000 (05:28 +0000)]
Release version 0.49.7

Changes:
 - Remove unused API
 - Fix unit tests
 - Add unit tests for status API
 - Refactor app com API
 - Fix metadata-profile.xml

Change-Id: I22484a502f57b4a50ed45fd3a244813759ae2cd7
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix metadata-profile.xml 56/280256/2
Hwankyu Jhun [Fri, 26 Aug 2022 01:32:03 +0000 (01:32 +0000)]
Fix metadata-profile.xml

If the published value is 'Y', it means the metadata is opened in officially.

Change-Id: Iaa9e65081fbd5d958cc4d615d01c43ee85134056
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRefactor app com API 79/280179/1
Hwankyu Jhun [Thu, 25 Aug 2022 04:01:49 +0000 (04:01 +0000)]
Refactor app com API

To refactor app com API, unit tests are added.
The app com API is refactored using the AppRequest class.

Change-Id: Ieeafb5f9aeb461dfc38ca06decc943a2c01ce9dc
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoAdd unit tests for status API 26/280126/3
Hwankyu Jhun [Wed, 24 Aug 2022 07:13:11 +0000 (07:13 +0000)]
Add unit tests for status API

To refactor status API, unit tests are added.

Change-Id: I874f9ebc719b11feb30a679076bae59b7dec0bb7
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix unit tests 58/280058/2
Hwankyu Jhun [Tue, 23 Aug 2022 05:25:00 +0000 (05:25 +0000)]
Fix unit tests

The socket option check and the bundle data check are added.

Change-Id: If8a758b4e741a65660e8b267855b4150445a4d43
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRemove unused API 70/280070/1
Hwankyu Jhun [Tue, 23 Aug 2022 06:44:07 +0000 (06:44 +0000)]
Remove unused API

The aul_running_list_update() function is removed. It's not used.

Change-Id: I00c2ef15e3b9028c3bf115b416a6427001bb9557
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.49.6 43/280043/1 accepted/tizen/unified/20220826.001808 submit/tizen/20220823.004739 submit/tizen/20220824.234308
Hwankyu Jhun [Tue, 23 Aug 2022 00:45:14 +0000 (00:45 +0000)]
Release version 0.49.6

Changes:
 - Fix a bug of refactoring complication
 - Fix wrong implementation of pkginfo API

Change-Id: I98955701fd21a02ef614eae8d022c02c1a6fc977
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix wrong implementation of pkginfo API 85/279985/5
Hwankyu Jhun [Mon, 22 Aug 2022 04:07:25 +0000 (04:07 +0000)]
Fix wrong implementation of pkginfo API

The socket option of some requests have to be AUL_SOCK_NONE and AUL_SOCK_BUNDLE.
The application ID that is set to the bundle will be removed while creating
the AppRequest instance. To set the application ID to the bundle properly, we
should use the AppRequest::SetAppId() method.

Change-Id: I43cadc2aa633b8afa55375d2461e69c98467c525
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix a bug of refactoring complication 87/279987/2
Hwankyu Jhun [Mon, 22 Aug 2022 05:11:25 +0000 (05:11 +0000)]
Fix a bug of refactoring complication

The function returns AUL_R_OK when the function call is successful.
The daemon sends the process ID if the request is successful.

Change-Id: If3f167bb9150e03af6fe7c967988e8a6c3b6f561
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.49.5 84/279884/1 accepted/tizen/unified/20220821.211113 submit/tizen/20220819.013532 submit/tizen/20220819.071124
Hwankyu Jhun [Fri, 19 Aug 2022 01:28:37 +0000 (01:28 +0000)]
Release version 0.49.5

Changes:
 - Fix double close issue

Change-Id: I56a7f4a5eedc8e959085896d286c8909e888fcb4
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix double close issue 81/279881/1
Hwankyu Jhun [Fri, 19 Aug 2022 00:48:12 +0000 (00:48 +0000)]
Fix double close issue

When calling g_io_channel_shutdown(), the file descriptor is closed.
Calling the close in the __destroy_client_channel() is not needed.

Change-Id: I443253f29c000adcdae87f74c415b00de75223af
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.49.4 78/279878/1 submit/tizen/20220819.000528
Hwankyu Jhun [Thu, 18 Aug 2022 23:47:16 +0000 (23:47 +0000)]
Release version 0.49.4

Changes:
 - Refactor App Group API

Change-Id: Id1fcdf19161efe25006c373874068d2ba9336058
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRefactor App Group API 32/279632/3
Hwankyu Jhun [Fri, 12 Aug 2022 10:45:39 +0000 (19:45 +0900)]
Refactor App Group API

The app group API is implemented using C++ language.

Change-Id: I8047911920e0c6d3b70582621e2f85abef278c6b
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoRelease version 0.49.3 20/279620/1 accepted/tizen/unified/20220817.153847 submit/tizen/20220812.091125 submit/tizen/20220815.221956
Changgyu Choi [Fri, 12 Aug 2022 09:10:04 +0000 (18:10 +0900)]
Release version 0.49.3

Changes:
 - Fix coding style
 - Add unit tests for App group API
 - Fix wrong exception handling
 - Fix static analysis issues
 - Fix fd leak
 - Restore to remove virtual keywords

Change-Id: I779d9085f5404dff682882836e8d1c82ec9dacb1
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoRestore to remove virtual keywords 17/279617/2
Changgyu Choi [Fri, 12 Aug 2022 08:57:06 +0000 (17:57 +0900)]
Restore to remove virtual keywords

Change-Id: Iaaf70682e8f0ff0ab4659d49ecd0d9ed5494616a
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoFix fd leak 04/279604/2
Hwankyu Jhun [Fri, 12 Aug 2022 06:57:04 +0000 (15:57 +0900)]
Fix fd leak

When IO error occurs, AUL has to close the file descriptor and release
the io job resource of aul worker.

Change-Id: Ic612531f3a2fa53efa9fe55556b770369731769c
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix static analysis issues 96/279596/4
Changgyu Choi [Fri, 12 Aug 2022 06:05:38 +0000 (15:05 +0900)]
Fix static analysis issues

Changes:
 - Removes unnecessary virtual keywords.
 - Fix to wrong print errno.
 - Fix dereference case before checking nullptr.
 - Fix to use variable after using std::move().
 - Removes unnecessary const keyword.

Change-Id: I72e4076f9f3ca3a5daef8afe484c021008d39d00
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoFix static analysis issues 82/279582/5
Changgyu Choi [Fri, 12 Aug 2022 02:26:29 +0000 (11:26 +0900)]
Fix static analysis issues

Changes:
 - Adds exception handling.

Change-Id: I0e20206337040eba4430afc32bd1ec79ddde3c6a
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoFix wrong exception handling 74/279574/4
Hwankyu Jhun [Fri, 12 Aug 2022 01:04:35 +0000 (10:04 +0900)]
Fix wrong exception handling

If the AppRequest() is not used to send the request, the result value
has to be converted using the aul_error_convert().
While creating the LocalizedInfo instance if the locale is empty, we
throw the exception. The previous implementation, AUL only checks whether
the locale is empty or not.

Change-Id: I6c25e1e9c415d6dc3e3be18862f34c88da2df980
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoAdd unit tests for App group API 49/279549/2
Hwankyu Jhun [Thu, 11 Aug 2022 09:44:30 +0000 (18:44 +0900)]
Add unit tests for App group API

To refactor app group API, unit tests are added.
And, the parameter checks are added.

Change-Id: Id430b4b477096a6d9b6363f5d5d59b5617b0d211
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix coding style 36/279536/2
Changgyu Choi [Thu, 11 Aug 2022 06:15:41 +0000 (15:15 +0900)]
Fix coding style

Changes:
 - Adds missing headers.
 - Fix wrong indents.
 - Adds explicit keyword.

Change-Id: I432ace3e6af683d5546fe41ce88e37e422bbc9a5
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
2 years agoRelease version 0.49.2 32/279532/1 submit/tizen/20220811.052620
Hwankyu Jhun [Thu, 11 Aug 2022 04:42:40 +0000 (13:42 +0900)]
Release version 0.49.2

Changes:
 - Remove unused functions
 - Remove build warning messages
 - Fix Setup() method of unit tests
 - Fix aul_app_event_destroy function

Change-Id: Id9e2203aa266ba6026c63d9db7cf92d0d21b0131
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix aul_app_event_destroy function 28/279528/1
Hwankyu Jhun [Thu, 11 Aug 2022 03:42:32 +0000 (12:42 +0900)]
Fix aul_app_event_destroy function

If the thread releases the handle using aul_app_event_destroy(), the
main thread will have crashed while invoking the app event callback
function.
To make thread safe, the handle will be released using g_idle_add_full().

Change-Id: I69445c555610668a7adad5c25fddccf908dc7a48
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
2 years agoFix Setup() method of unit tests 86/279486/2
Hwankyu Jhun [Wed, 10 Aug 2022 06:48:31 +0000 (15:48 +0900)]
Fix Setup() method of unit tests

Calling EXPECT_CALL() of the send() is not needed.
The default behavior of the send() is defined in the constructor of
the SocketMock class.
This patch removes it from the Setup() method.

Change-Id: I9064e8d59d6a73e05c9c54bdaad41ecaeb3e73f7
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>