Youngjae Cho [Tue, 19 Jul 2022 00:53:11 +0000 (09:53 +0900)]
init_db: exclude hal-release information from database
For fota, platform-release information is only required. However the
current system-info have two kinds of release information, platform
and hal, and the hal-release information overwrites the platform-release
information. Therefore, do not include hal-release information into
system-info database so that there is only platform-release information
in the database.
Change-Id: I5fc381a3de5d2f13095645d880730531de56d1f0
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
(cherry picked from commit
0e51498af3301231c7b59aa5c563582a8f9ba4fa)
Hyotaek Shim [Wed, 13 Apr 2022 05:47:46 +0000 (14:47 +0900)]
Remove dependency to libsyscommon and add .gitignore
Change-Id: I7be05f4c6b225786fa9d66f9cbd5fa5c8b4a2bcf
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
(cherry picked from commit
680135fc0775f8111c853f6c25b1cbedd2c1a08c)
Youngjae Cho [Thu, 3 Feb 2022 08:58:57 +0000 (17:58 +0900)]
Fix typo
Change-Id: Ie18506860de0ac81c5066cdbf300a5cd48f9eb21
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
(cherry picked from commit
914739641f99063652bd306fcd3b3d76a2824588)
Youngjae Cho [Wed, 26 Jan 2022 05:45:08 +0000 (21:45 -0800)]
Change gcov object install path
Change-Id: I42bcdea47e21803dd822b826e2f68971f4c3aefe
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
(cherry picked from commit
d18ed572fba2c35f0c052f6868038a482601b40c)
Youngjae Cho [Mon, 13 Dec 2021 04:26:21 +0000 (13:26 +0900)]
Complete bool string when joining it
Change-Id: I203742d0bbcaa734871ea045a1b26e3c82f6a81c
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
(cherry picked from commit
b300cfff4c5633377c1b19324d63958f200fac39)
Hyotaek Shim [Fri, 10 Dec 2021 10:47:52 +0000 (19:47 +0900)]
Fix ASAN issue
stack-buffer-overflow on address 0xbed7cb70 at pc 0xb6a2c22b bp 0xbed7c90c sp 0xbed7c4d8
READ of size 29 at 0xbed7cb70 thread T0
#0 0xb6a2c228 in strdup (/usr/lib/libasan.so+0x35228)
#1 0xb4da64d8 (/lib/libcapi-system-info.so.0+0x24d8)
#2 0xb4da66fe (/lib/libcapi-system-info.so.0+0x26fe)
#3 0xb65a096a (/lib/libcapi-system-device.so.0+0x496a)
#4 0xb6f601b8 in call_init /usr/src/debug/glibc-2.30-2.9.arm/elf/dl-init.c:72
#5 0xbed7cfb4 ([stack]+0x20fb4)
Address 0xbed7cb70 is located in stack of thread T0 at offset 80 in frame
#0 0xb4da6664 (/lib/libcapi-system-info.so.0+0x2664)
This frame has 2 object(s):
[48, 52) 'valp' (line 271)
[64, 80) 'val' (line 270) <== Memory access at offset 80 overflows this variable
HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
(longjmp and C++ exceptions *are* supported)
Change-Id: I122980ff762983bc9646afd84d9e659766edf9a9
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
(cherry picked from commit
95b106c07f4e8a8478895f22031bb757940bf5f3)
Youngjae Cho [Fri, 3 Sep 2021 07:55:54 +0000 (16:55 +0900)]
tool: fix --set description to clarify bool value
Change-Id: I3d7c2c3745447ea242ec70e8a3bf5744d238d958
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
(cherry picked from commit
487d94a21bf2f44ef55812728c2de82eab005fef)
Youngjae Cho [Thu, 12 Aug 2021 02:06:58 +0000 (19:06 -0700)]
Suppress ENOENT as database might not exist
Change-Id: Idd24ccbc799bf42723801c2bd760990f18c6350c
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Yunmi Ha [Wed, 11 Aug 2021 07:37:23 +0000 (16:37 +0900)]
Fix gbs build home creation with incorrect permissions
A gcda file is created when binary system_info_init_db is executed.
At this time, the home directory is not created yet,
so the home directory is created and the gcda file is created under it.
But home directory with wrong permissions due to umask set to 0222 in the binary
So, when build with gcov, set the home directory to the correct permissions
Change-Id: Id7bac84bbfcd284e55f294ecc41ec826e904616c
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Youngjae Cho [Tue, 3 Aug 2021 06:25:14 +0000 (15:25 +0900)]
tool: make result be aligned
Change-Id: Ic56d0f96b1337b00987e04c3092e7d4ad96fd2e6
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Mon, 2 Aug 2021 08:51:59 +0000 (17:51 +0900)]
tool: allow prefix "http://" for get/set/clear key
Change-Id: Ie4c504706d1de818dbf1b84878cb57e95009ea0f
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Mon, 26 Jul 2021 08:54:07 +0000 (17:54 +0900)]
test: remove api test
This is replaced by system-info-tool
Change-Id: I9230cf8a3afadb42b8d81a4e6cf2e58a4a6fbc25
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Fri, 23 Jul 2021 06:06:46 +0000 (15:06 +0900)]
tool: add command line tool for managing system-info
USAGE
system-into-tool [OPTION]
OPTION
-l|--list-all List all system-info database entries
-g|--get KEY [-v|--verbose] Get value of feature KEY
If -v option is given, shows result in detail
ex) system-info-tool -g tizen.org/feature/display
system-info-tool -g tizen.org/system/manufacturer -v
-s|--set KEY TYPE VALUE Add or update user-defined KEY
Available TYPE: bool, int, double, string
ex) system-info-tool -a tizen.org/feature/display bool 1
system-info-tool -a tizen.org/system/manufacturer string Tizen
-c|--clear KEY Clear user-defined KEY. This cannot clear read-only system key
-C|--clear-all Clear all user-defined keys
-h|--help Show this help
Change-Id: Id2f72ee242e12d90edc82797a21fdb8b097e2bc6
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Mon, 19 Jul 2021 02:42:51 +0000 (19:42 -0700)]
Fix to search RO database if RW database is not found
Change-Id: I2931e3929e75c0fa8e911fc9dd679e51a13e9b4d
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 1 Jul 2021 05:31:49 +0000 (14:31 +0900)]
Remove tab indentation
Change-Id: I0165e72ae40f5d81c27ce39ec7ce8b697a310257
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Wed, 30 Jun 2021 05:05:37 +0000 (14:05 +0900)]
Fix hal dbpath
Change-Id: I29b62955b6bf5928cf16a47b6d7079c8ef9655de
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 24 Jun 2021 07:37:39 +0000 (16:37 +0900)]
Fix boolean join considering language property
Boolean value is a string of length LANG_MAX. Each character in the
value denotes viability of feature for a specific language. Therefore
for joining boolean value, compare each character one by one.
Change-Id: Ib9f0256073b731b853b4b3ff6555fbe42507c48d
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Tue, 22 Jun 2021 07:25:03 +0000 (16:25 +0900)]
Make filepath for release info configurable
system_info_init_db now receives new argument -r(--release) in addition
to -i(--input) and -o(--output). It designates release information file
path which was fixed to /etc/info.ini.
For example, in mic %post script
#) system_info_init_db --input=/hal/etc/config/model-config.xml
--release=/hal/etc/hal-info.ini
--output=/hal/system_info_db
will creates system info database in /hal/system_info_db from
system configuration file(model-config.xml) and system release
file(hal-info.ini).
Change-Id: I1d18b32cb214f4bc44c94414d3944a0299b5af3d
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Wed, 23 Jun 2021 08:39:15 +0000 (17:39 +0900)]
Support database search for HAL system-info
In addition to platform system-info database(/etc/system_info_db),
system-info of HAL(/hal/system_info_db) can be searched for a requested
key.
If a key exists only in one database, use it.
If a key exists in both of the databases,
- if value of key is type of bool, the two value are ANDed.
- if value of key is type of other than bool, the value of HAL is
used.
Change-Id: If36a4b7a4143107ec550bb1311dafb470f492167
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Jongmin Lee [Thu, 18 Mar 2021 11:01:06 +0000 (20:01 +0900)]
test : update CMakeFile.txt
pkgconfig does not provide CXXFlags, and it causes build errors in some environments
Change-Id: I698cfeb7af211a1a87bfa063131b78b87f16dcc6
Kichan Kwon [Tue, 15 Dec 2020 07:39:08 +0000 (16:39 +0900)]
test : fix minor issues
- Set the initial value
- Use "free" for the memory allocated by "malloc"
Change-Id: I76d716f74942f6c2c2480ee50aa48596dbdba02d
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kwon [Thu, 5 Nov 2020 05:32:17 +0000 (05:32 +0000)]
Merge "Add Requires=local-fs.target dependency to tizenid.service" into tizen
INSUN PYO [Thu, 8 Oct 2020 08:49:09 +0000 (17:49 +0900)]
Add Requires=local-fs.target dependency to tizenid.service
In emergency mode, local-fs.target always fails.
So, you have to check if local-fs.target is successful.
Change-Id: Ic353d30a7ed7c058d0e05f890c96274d539d48b8
Kichan Kwon [Wed, 5 Aug 2020 03:13:34 +0000 (12:13 +0900)]
test : test custom feature
Change-Id: Ic7ee68772d6185602c95fab1824b7b8455566087
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 14 Jul 2020 01:55:24 +0000 (10:55 +0900)]
test : separate RW DB test to verify
- system-info stores a key/value pair in the hashtable
when it reads from DB
- So, we can't test same key twice
- Instead, we will test RO/RW DB with different argument
- 'o' option : test RO DB
- 'w' option : test RW DB
Change-Id: I721b5d9b1b97fb9de54b0a6efd1a92a90b31ec79
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 13 Jul 2020 07:27:24 +0000 (16:27 +0900)]
test : test runtime property
Change-Id: Id44f7917aa7e546071afd43d300dbb8e769326c0
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 13 Jul 2020 03:15:36 +0000 (12:15 +0900)]
test : compare values with template function
- To remove duplicated source code
Change-Id: Ifb7c1df91228a07cecedbc066c6d9414c8052db5
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 13 Jul 2020 01:11:51 +0000 (10:11 +0900)]
test : apply CPP style log
Change-Id: I6b009479663a9ba89909e3092bd28f5898615623
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 7 Jul 2020 10:20:51 +0000 (19:20 +0900)]
test : add system_info_init_db_test
Change-Id: I8f02ab2d6df029e50309ca1a10d3cb3e690d8be9
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 7 Jul 2020 02:50:27 +0000 (11:50 +0900)]
Integrate system-info-testplugin with system-info-test
- src/test -> test/api
- src/testplugin -> test/plugin
Change-Id: I315479656b8cf2a32394fd35380f2fcb1cbc9a51
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 12 Aug 2020 09:11:03 +0000 (18:11 +0900)]
Set the plugin directory factoring in architecture
- armv7l : /usr/lib
- aarch64 : /usr/lib64
Change-Id: I07804cb9dd9e996710a5d11f84772d4bc2fa9432
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 22 Jun 2020 03:30:38 +0000 (12:30 +0900)]
Prevent buffer overflow on reading value
Change-Id: I4a6d5abce72c4f2165a0d190068ef75157cf4c35
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Thu, 18 Jun 2020 06:47:20 +0000 (15:47 +0900)]
Integrate files into N files to reduce total file size
- Although the size of value is small, each key file takes a file block
- Block size is 4kB
- 270 model-config keys takes 1.5MB
- To reduce file size, store many keys into the same file
- To find file name, use hash function
- In current, store 10 files
Change-Id: I7140e732d7dde1e6c6ad65b28f5f7a064502d9f5
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 16 Jun 2020 04:51:02 +0000 (13:51 +0900)]
Check the type by special function for conditions
- In current, only tizenid use it
Change-Id: I3c985a7d848f40fcacbfd5c5846c7dd082478188
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 15 Jun 2020 05:14:47 +0000 (14:14 +0900)]
Read value from per-key file
Change-Id: I0cb6e0607961fe7660b8234f5ae32f90e5294530
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Wiktor Gerstenstein [Wed, 22 Jan 2020 14:39:38 +0000 (15:39 +0100)]
change version to 0.5.2
Change-Id: If7ee54ab008c66b7e195c97a665be5e9c0073e9b
Wiktor Gerstenstein [Wed, 22 Jan 2020 14:39:38 +0000 (15:39 +0100)]
add multi-plugin functionality
Change-Id: Iacef58acb8b2e9dae93a7f2bd63813c82a1ce992
Wiktor Gerstenstein [Wed, 22 Jan 2020 14:35:22 +0000 (15:35 +0100)]
bugfix: fix type mismatch for custom key
Change-Id: Iacef58acb8b2e9dae93a7f2bd63813c82a1ce993
Karol Lewandowski [Fri, 3 Jan 2020 11:02:33 +0000 (12:02 +0100)]
Fix: Do not use source argument length in strncpy()
This fixes issue found by gcc 9.x, where strncpy's length
argument was based on source argument length. This commit
fixes possible bufer overflow.
Change-Id: I933e999d4919e1dbce2834138a612c9f97f916a4
Kunhoon Baik [Thu, 26 Dec 2019 09:37:42 +0000 (18:37 +0900)]
Explict type cast according to iniparser 4.1 API change
From iniparser 4.1, iniparser_getstring retrun "const char*" instead of "char *"
To support the new API, explict type cast was added.
Although system_info_db_init requires "const char*", original codes was kept to minimize modification.
Change-Id: I3c0ee077500160b38a80c0257ba1b77585a81187
Kichan Kwon [Fri, 6 Dec 2019 08:12:37 +0000 (17:12 +0900)]
Update guide URL
Change-Id: I82fe9e57f395e00e979d25b76e70a15c41653a01
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 9 Jul 2019 08:47:00 +0000 (17:47 +0900)]
Rename gcov package
Change-Id: I596e69f5d457254ea1b58f6afa6ecbfeab25464a
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Fri, 28 Jun 2019 01:01:21 +0000 (10:01 +0900)]
Make gcov package
- To make, use "gcov" build option
Change-Id: Ic6cf306d62d48f187c97c8c327059755ff4c2d31
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Thu, 11 Apr 2019 05:18:06 +0000 (14:18 +0900)]
Create system-info-test
- Input key information, then prints value
Change-Id: I0dac252d8fb3d518508113978def523d4987cca1
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 25 Mar 2019 06:51:33 +0000 (15:51 +0900)]
Write debug log when the key isn't stored in DB
- The keys supported by system-info plugin aren't stored in the DB
- In this case, system-info always write error log though
it returns right value (with ERROR_NONE)
- To prevent misunderstanding, change the log level
- In real failure case, you can check the "Invalid key" log
Change-Id: Ia78cb2e87c5ee06cf20f3718694d262c7df6da90
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
INSUN PYO [Wed, 30 Jan 2019 07:21:35 +0000 (16:21 +0900)]
tizenid.service: Add RemainAfterExit=yes
tizenid.service should be run only once at boot time.
Change-Id: I9390f63fedf25624bab3ad3090ce2362cd6b7dbd
Kichan Kwon [Mon, 30 Jul 2018 08:03:04 +0000 (17:03 +0900)]
Add LCOV comment for not used function
- destroy_key_value is called when hashtable is removed
- However, there is no scenario that this hashtable is removed
Change-Id: I7356d46b9bf84e083e8cf371854b4b5a54afa2f4
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 15 May 2018 08:12:34 +0000 (17:12 +0900)]
release : 0.5.1
Change-Id: Iab7ad9b9bc5651330329c901b0a831b8bdc5bc83
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 15 May 2018 08:07:09 +0000 (17:07 +0900)]
Remove deprecated notice file
- format_uuid_v3orv5 is deprecated since Tizen 3.0
Change-Id: I40489026c193543e32553fb23109bfa3975e7d77
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 15 May 2018 08:05:28 +0000 (17:05 +0900)]
Make some macros consistent
- Related with model-config and DB
Change-Id: I12b8b9629d7993a7d11a55bfcbd21342c278d570
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 15 May 2018 07:38:53 +0000 (16:38 +0900)]
Merge remote-tracking branch 'origin/tizen_4.0' into tizen
Change-Id: I9c6e9bfaca6cc3ac897e8210e8926abc8f9e3809
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Donghwan Jeong [Thu, 5 Apr 2018 08:27:39 +0000 (17:27 +0900)]
Fix model_config directory discretionary access control
Basically, directory DAC should be haven execute option.
So model_config directory will have it.
Change-Id: Iab3ff32c19f4b4015aebbf1546cd2b99bb40cb67
Signed-off-by: Donghwan Jeong <dh.jeong@samsung.com>
Donghwan Jeong [Mon, 12 Feb 2018 05:31:41 +0000 (14:31 +0900)]
init_db: add system_info_db parameter for make new db by another path
It will be supported that the content can be chagned in system info at run-time.
So, system_info_db can make new system-info-db file by another path.
system_info_init_db -i --input=PATH Make System info db by the PATH
ex) system_info_init_db -i /etc/config/model-config.xml
The new db file will be saved to '/opt/system/model_conf/system_info_db' path
Change-Id: I2ddde7e313ff5cc547b3592109fe1cf29ddbdd7b
Signed-off-by: Donghwan Jeong <dh.jeong@samsung.com>
Kichan Kwon [Thu, 4 Jan 2018 07:54:19 +0000 (16:54 +0900)]
Write RUNTIME_TYPE log with debug level
- If app launcher doesn't set RUNTIME_TYPE, this log will be written
whenever system-info API is called for getting boolean value
- For developer to give control, modify this log's level
Change-Id: I2d393efaf73d0c7243cc321753825a684c00231e
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 6 Nov 2017 01:46:34 +0000 (10:46 +0900)]
Merge remote-tracking branch 'origin/tizen_4.0' into tizen
Change-Id: I75d6c2cf7a89051293838f20e440a0049790975d
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Fri, 1 Sep 2017 07:20:32 +0000 (16:20 +0900)]
Fix memory issue about the value read by GDBM
- Limit duplicated size
- Free after using
Change-Id: I530683f386bb64d402c8277824051c91aa003330
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 26 Sep 2017 06:39:23 +0000 (15:39 +0900)]
Fix memory issues
- Prevent accessing out of array
- Free before exit
Change-Id: Ifbe15353753438efb1b0f79951121d717cd57038
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Fri, 1 Sep 2017 07:20:32 +0000 (16:20 +0900)]
Fix memory issue about the value read by GDBM
- Limit duplicated size
- Free after using
Change-Id: I530683f386bb64d402c8277824051c91aa003330
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Thu, 31 Aug 2017 01:32:07 +0000 (10:32 +0900)]
init_db : allocate one more byte to boolean value
- For null character, write (len + 1) bytes to the DB
- However, only len bytes are allocated for boolean value
- To prevent buffer over-read, give a spare byte
Change-Id: I5582e0ac5c1d5837ce9ac1b295762814011133f0
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 14 Aug 2017 10:10:41 +0000 (19:10 +0900)]
Remove build option related with upgrade script
Change-Id: Ie1e01c0bb0ab7354c9dc32fee4f5a6a5e1b3a218
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Thu, 10 Aug 2017 06:14:54 +0000 (15:14 +0900)]
script : remove upgrade script
- No more support 2.4 -> 3.0 upgrade
Change-Id: Ifb2024a432fa5593f27d7d154f5ba4bcb5300cef
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Thu, 10 Aug 2017 01:54:56 +0000 (10:54 +0900)]
update_db : remove system_info_update_db
- It is for emulator to chroot before system_info_init_db
- But, with using busybox, we can use chroot in the initramfs
- To apply with emulator, the prerun patch should be applied first
- https://review.tizen.org/gerrit/#/c/143420/
Change-Id: I49f12420005ef8860fbb65efb45c57179eadfc0d
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 2 Aug 2017 09:53:00 +0000 (09:53 +0000)]
Merge "Use memcpy to prevent buffer over-reading by snprintf" into tizen
Kichan Kwon [Wed, 2 Aug 2017 01:15:09 +0000 (10:15 +0900)]
Use memcpy to prevent buffer over-reading by snprintf
- snprintf calculates return value by checking the length of format string
- Therefore, if format string is non-terminated, snprintf can over-read
- To prevent, use memcpy and write null character
Change-Id: I9ba837d8e22313be6e34ba39e4ccaf7743166d89
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Sunmin Lee [Wed, 2 Aug 2017 05:04:25 +0000 (14:04 +0900)]
Make version information for update at imaging
make_info_file.sh constructs platform info file during imaging.
Platform update needs formatted version information which also
could be constructed at imaging time.
Change-Id: Ibee71bef3a5811fc725d1648ea69b88be384a8bd
Signed-off-by: Sunmin Lee <sunm.lee@samsung.com>
Kunhoon Baik [Sat, 22 Jul 2017 01:20:01 +0000 (10:20 +0900)]
Enhancement system-init-db for updating specific lang feature
Now, system init db tool can update bool value for specific runtime.
The feature will be updated according to following command.
Whole runtime feature update : -k KEY -t bool -v VALUE
C# runtime feature update : -k KEY -t bool -v VALUE -l csapi
C runtime feature update : -k KEY -t bool -v VALUE -l capi
Web runtime feature update : -k KEY -t bool -v VALUE -l webapi
Change-Id: Iad562a040778b4b1b76492ad6f06e6043edee234
Kichan Kwon [Wed, 19 Jul 2017 07:49:38 +0000 (16:49 +0900)]
init_db : update boolean to modified value
- The lang option of update is removed because of the lack of default value
Change-Id: I8568e369a4ddd140b070256c1a4d199090cd58aa
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 5 Jul 2017 12:21:45 +0000 (21:21 +0900)]
init_db : write boolean to 'T' or 'F' instead of 0x1 or 0x0
- To prevent misunderstanding false as the end of string
- In addition, we can get the readbility
Change-Id: If94ec9337f4360f696c242664e5d32401da5f934
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 5 Jul 2017 02:25:10 +0000 (11:25 +0900)]
Version up
Change-Id: I45c65e0d5645a881dfa009eda96fbde83614129c
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kunhoon Baik [Mon, 3 Jul 2017 23:33:26 +0000 (08:33 +0900)]
Fix a bug of buffer-size using when checking tizen-id validation
It should be ID_LEN(28)+4 because 32 byte is maximum.
Change-Id: I0a877b9b01c7fa1184308598f0ce21c03f1707d9
Kichan Kwon [Thu, 1 Jun 2017 02:44:48 +0000 (11:44 +0900)]
Generate tizenID with libuuid instead of openssl
- To detach openssl
Change-Id: I55a6cbbd686857a94d0ff7cb9806759db4c40f03
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Fri, 9 Jun 2017 08:03:20 +0000 (17:03 +0900)]
Support language runtime property for boolean feature
- Some keys are needed to have different value depend on runtime
- To support different value, model-config will have runtime property
- e.g. < ... capi="on" webapi="off" csapi="on">VALUE</key>
- init_db stores the value for all runtimes with default value
- Before system-info reads key, it check RUNTIME_TYPE
- If RUNTIME_TYPE is invalid or NULL, return default value
Change-Id: I247245270ddf58ae2da5254a23b0fa2188e77899
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Denis Khalikov [Tue, 20 Jun 2017 11:19:18 +0000 (14:19 +0300)]
Switch off UBSan for update_db
Change-Id: I6ffd4ce833bd72c1ee66cdc77f8139b63ce618a0
Signed-off-by: Denis Khalikov <d.khalikov@partner.samsung.com>
Slava Barinov [Fri, 16 Sep 2016 14:24:28 +0000 (17:24 +0300)]
Switch off ASan for update_db
Sanitized binary cannot be built with '-static' since Address Sanitizer intercepts function calls from libraries.
Thus, system-info is built in both Address Sanitizer On environment and Address Sanitizer Off environment. Then, system-info-update-db built without sanitized build option is installed.
Change-Id: I16a09d0555252cac0d717068560d99f06d0c12d3
Signed-off-by: Slava Barinov <v.barinov@samsung.com>
Kichan Kwon [Mon, 22 May 2017 09:21:46 +0000 (18:21 +0900)]
Correct broken link
Change-Id: I6fc657e9a22bd9d2e4f9aa35933de3b697536aeb
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 19 Apr 2017 12:03:04 +0000 (21:03 +0900)]
Fix invalid type specifier
Change-Id: I5ef279c47e01468417c347faf19573dc27bee1ad
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 19 Apr 2017 02:17:30 +0000 (11:17 +0900)]
update_db : do chdir after chroot
- To prevent from accessing outside of chroot directory
Change-Id: Ia951443f9a0f4da12596640361288519b94a38c6
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Youngjae Shin [Wed, 12 Apr 2017 07:36:37 +0000 (16:36 +0900)]
remove the dependency of model-config
It will be handled by ks file.
Change-Id: I0f3bdbf34e0734725621dd614aa3ab439d6221d5
Youngjae Shin [Wed, 12 Apr 2017 02:22:56 +0000 (11:22 +0900)]
add Recommends for model-config
Change-Id: Iae9ab03093e7e248901bfb81111f59e5f3749223
Youngjae Shin [Wed, 12 Apr 2017 01:29:25 +0000 (10:29 +0900)]
revise packaging for unified build
Change-Id: Idcc56926fbbb07840d25da2117f49eb42d293517
Kichan Kwon [Mon, 10 Apr 2017 05:12:19 +0000 (14:12 +0900)]
Fix spec file and add manifest file for extension-emulator
Change-Id: I01f72716a252b840e81a7266c64ccfc18524f1ab
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 5 Apr 2017 11:34:10 +0000 (20:34 +0900)]
Add LCOV comment for not supported API
Change-Id: Ieda1db7075020d61bd6cb7d11c57263ad318cc90
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
hk57.kim [Thu, 30 Mar 2017 07:15:39 +0000 (16:15 +0900)]
[Tizen] Remove emulator build dependencies
- This is for Tizen 4.0.
- Added backward-compatibility that does not deteriorate 4.0 Configurability
- When you SR this, you need to create JIRA-TRE issue of:
: add capi-system-info-extension-emulator for all(common/mobile/wearable/ivi/tv) emulator
(It's add, not replace.)
Change-Id: I8fcbd4760846ba03d9ea2adfbbb6117ab73e714e
Signed-off-by: hk57.kim <hk57.kim@samsung.com>
[Fix build error]
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 3 Apr 2017 04:58:32 +0000 (13:58 +0900)]
Modify uid/gid of tizenid
- system_share will be deprecated
Change-Id: I92e20ba86c81b08358fee1829c6ceed2f43c2ca0
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
taeyoung [Sat, 4 Mar 2017 06:45:06 +0000 (15:45 +0900)]
Merge branch 'tizen_3.0' into tizen
Signed-off-by: taeyoung <ty317.kim@samsung.com>
Change-Id: I3a8911f1c70b5657555513c669151d0aa0d9c76c
taeyoung [Sat, 4 Mar 2017 06:38:15 +0000 (15:38 +0900)]
pc: add prefix for the pc file
Pc file uses PREFIX macro, but there was no place to define the macro.
Now, The macro is defined in the CMakeLists.txt file.
Change-Id: I3ea9ca72bf6a4db4cd1e36f573600b38c5ff13bc
Signed-off-by: taeyoung <ty317.kim@samsung.com>
taeyoung [Fri, 3 Mar 2017 00:55:47 +0000 (09:55 +0900)]
Merge branch 'tizen_3.0' into tizen
Signed-off-by: taeyoung <ty317.kim@samsung.com>
Change-Id: Ie52144c8631d9885deea1ce7a6cafa0e32bc2d0b
taeyoung [Tue, 21 Feb 2017 05:04:26 +0000 (14:04 +0900)]
pc: add prefix information
prefix information is not the necessary information.
But the information is used in other place, and thus
the information is added.
Change-Id: I1bf5556eda7b3aae6fdda25d4ed419229193f5a8
Signed-off-by: taeyoung <ty317.kim@samsung.com>
Kichan Kwon [Thu, 16 Feb 2017 07:49:48 +0000 (16:49 +0900)]
Proofread header file
Change-Id: Ia4e206d3ea8d0364d09d3c37ed1d411b91c23bfc
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
pr.jung [Wed, 1 Feb 2017 09:02:00 +0000 (18:02 +0900)]
Merge remote-tracking branch 'origin/tizen_3.0' into tizen
Change-Id: Iaca788a3fa7b68277ed05242875982fec2f23618
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Wed, 1 Feb 2017 09:01:15 +0000 (01:01 -0800)]
Merge "Fix for memory leak" into tizen_3.0
pr.jung [Wed, 1 Feb 2017 08:37:56 +0000 (17:37 +0900)]
Fix for memory leak
- gdbm_fetch returns a d_data and the actual value is in d_data.dptr
- Memory allocated to d_data.dptr needs to be freed
Change-Id: I774f2b16bbfbeb1cc500976aa266143aa56d5dbb
Signed-off-by: pr.jung <pr.jung@samsung.com>
taeyoung [Tue, 24 Jan 2017 06:11:55 +0000 (15:11 +0900)]
model-config: add dependency for the model-config.xml
During image creation, model-config.xml file needs
to be installed before system-info. Thus the dependency
is added.
Change-Id: I31d91c375e9a6d39854fdea3fdc8eefa87f7f073
Signed-off-by: taeyoung <ty317.kim@samsung.com>
taeyoung [Tue, 24 Jan 2017 06:11:55 +0000 (15:11 +0900)]
model-config: add dependency for the model-config.xml
During image creation, model-config.xml file needs
to be installed before system-info. Thus the dependency
is added.
Change-Id: Ie6e6bfa28bde987d99d76ef5553dc3367f92a7f2
Signed-off-by: taeyoung <ty317.kim@samsung.com>
Sunmin Lee [Wed, 11 Jan 2017 02:41:19 +0000 (11:41 +0900)]
Upgrade: Do not use systemctl
The system offline update is going to be done without
basic.target. However, systemctl command requires basic.target
internally. So, replace it with a command.
Change-Id: I84fecf4ad727a82506cd4eab9ce091fa29b35d03
Signed-off-by: Sunmin Lee <sunm.lee@samsung.com>
taeyoung [Thu, 5 Jan 2017 07:21:46 +0000 (16:21 +0900)]
Merge branch 'tizen_3.0' into tizen
Signed-off-by: taeyoung <ty317.kim@samsung.com>
Change-Id: Ie795c139475762d0157437f30a2f57210b37b427
taeyoung [Thu, 5 Jan 2017 07:18:27 +0000 (16:18 +0900)]
db: create db in the post script
Previously, the db was created after installing all packages.
However, several packages want to use the system information
during installation. Thus the db is created once in the post
script, and db is updated after build information is created.
Change-Id: Ia4d71ac1696c5c7ed9ca6728baf8eb6b504d19e3
Signed-off-by: taeyoung <ty317.kim@samsung.com>
taeyoung [Thu, 29 Dec 2016 01:52:59 +0000 (10:52 +0900)]
Merge branch 'tizen_3.0' into tizen
Signed-off-by: taeyoung <ty317.kim@samsung.com>
Change-Id: Ie81c175e7575f6bd278693d23c48ed8067e6b12a
Sunmin Lee [Fri, 2 Dec 2016 08:54:50 +0000 (17:54 +0900)]
Upgrade: set RW update script number
+ revert patch using binary instead of systemctl
Change-Id: I728645cb1a8d15b96dadf68942935b4925e5d454
taeyoung [Tue, 22 Nov 2016 05:57:22 +0000 (14:57 +0900)]
upgrade: remove systemctl command from upgrade script
- During upgrade, systemctl cannot be used. Thus tizen_id
needs to be called directly.
Change-Id: Ia1f8d4018ad16248858da22ce0c8621bbe396901
Signed-off-by: taeyoung <ty317.kim@samsung.com>