Jung Jihoon [Wed, 10 Jul 2019 07:52:39 +0000 (16:52 +0900)]
Fix Side effect from "Fix Coverity issues"
Change-Id: I67e9aade4eb955cd081dffad8ca996619684269f
Signed-off-by: Jung Jihoon <jh8801.jung@samsung.com>
Jung Jihoon [Tue, 9 Jul 2019 12:24:30 +0000 (21:24 +0900)]
Fix Coverity issues
- Logically dead code: 1051469
- Dereference null return value : 1051467
- Unchecked return value : 1051464
- resource leak: 1051461 1043634 1043622 1043615 1043603 1043597
- no effect: 1043629 1043627 1043625 1043618
- Uninitialized scalar variable: 1043605 1051462
Change-Id: I558827611b721d92fbcbbc2811b5b9501a41ceed
Signed-off-by: Jung Jihoon <jh8801.jung@samsung.com>
Jung Jihoon [Tue, 9 Jul 2019 04:19:02 +0000 (13:19 +0900)]
make a gcov package for measuring coverage easier
Change-Id: I548f4dd7fa6d2b1e81b9b17d803991902468f752
Signed-off-by: Jung Jihoon <jh8801.jung@samsung.com>
saerome kim [Fri, 10 May 2019 05:43:23 +0000 (14:43 +0900)]
Fixed svace issues
- 372991: fixed memory leak issue.
- 372995: change a vulnerable function (strerror) to strerror_r.
Change-Id: I2d5e6b815149b30afe0511b831c8d2325abb21b1
Signed-off-by: saerome kim <saerome.kim@samsung.com>
Jihoon Jung [Tue, 26 Feb 2019 04:48:46 +0000 (13:48 +0900)]
Added 'End-point' functionality.
- Request remote apps to open end-point.
- Once end-point created, client app can send binary data through the
end-point.
Change-Id: I77f5eb7b9e772b27b0008a77e35de100f410bc40
saerome.kim [Thu, 31 Jan 2019 10:48:03 +0000 (19:48 +0900)]
Build configuration cleaned up
Change-Id: I7de6a5281ec6ef7dc03be1fc01d03f0a1202a908
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Thu, 31 Jan 2019 09:00:20 +0000 (18:00 +0900)]
Fixed build error for 64 bit architecture
Added a licence file
added target library symbolic link
Change-Id: I77888d97de83b84156881bb3c267bfecd56033a3
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Jihoon Jung [Tue, 16 Oct 2018 04:47:49 +0000 (13:47 +0900)]
Fix svace issue
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Change-Id: I6c2249a42a4ee8613e2cdcee04ed6e88068cf077
Jihoon Jung [Thu, 4 Oct 2018 07:53:42 +0000 (16:53 +0900)]
apply indentation
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Jihoon Jung [Fri, 7 Sep 2018 06:29:14 +0000 (15:29 +0900)]
Add preconditions
Change-Id: Ic8765b2eaaddf6cd3f0176259f3d9acaa7defa0b
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Jihoon Jung [Wed, 29 Aug 2018 06:35:28 +0000 (15:35 +0900)]
Add set preconfigured pin
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Change-Id: I8f82a7844ccbad378cb056fd5d7e82e8401683d9
Abhishek Sansanwal [Mon, 27 Aug 2018 06:18:28 +0000 (11:48 +0530)]
Return fail if found invited device list or channel list empty
Signed-off-by: Abhishek Sansanwal <abhishek.s94@samsung.com>
Change-Id: I6fb7f21406e5d548b39d1de8e2ec053eae189f13
Jihoon Jung [Thu, 23 Aug 2018 07:17:29 +0000 (16:17 +0900)]
Add precondition
Change-Id: Ic81973c496b5ee830f2139ba49f9e1706bdbc8b9
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Jihoon Jung [Thu, 9 Aug 2018 08:33:20 +0000 (17:33 +0900)]
Add invited / ejected cb api
Change-Id: Ic01335aea4b08a3aca4056d170810082e2f46196
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Jihoon Jung [Wed, 8 Aug 2018 10:08:08 +0000 (19:08 +0900)]
Add send response API
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Change-Id: I619577c74ea68871f075b9fbe34a966d470d89f6
saerome.kim [Wed, 1 Aug 2018 05:44:44 +0000 (14:44 +0900)]
Fixed typo
mdg-test app. is using the previous name, So we change the name of
mdg-test app.
Change-Id: I0b30cc2994b2e9965d8fb08e05757354db019890
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Jihoon Jung [Wed, 1 Aug 2018 04:01:09 +0000 (13:01 +0900)]
Remove address information
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Change-Id: I5193b2350c820e270c8036629908a2e2929645d7
Jihoon Jung [Thu, 26 Jul 2018 09:19:47 +0000 (18:19 +0900)]
Add send file implmentation
Change-Id: Id9e379896ef3ae2f73f915eab87d213d5931288e
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Jihoon Jung [Wed, 25 Jul 2018 08:32:27 +0000 (17:32 +0900)]
Add foreach device in group API
Change-Id: I5b2410743cf26697528ea4711994b1428d3baed3
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Jihoon Jung [Tue, 24 Jul 2018 09:15:18 +0000 (18:15 +0900)]
Add handle in invite callback
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Change-Id: Idef956d4043c452fa90e4c6338ef1e79c159b6a5
Jihoon Jung [Tue, 24 Jul 2018 06:24:18 +0000 (15:24 +0900)]
Add proper device parameter when device eject
Change-Id: Ibf62dd96c37f90623bbe13c20de48f0870682806
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Jihoon Jung [Thu, 19 Jul 2018 06:40:29 +0000 (15:40 +0900)]
Add file transfer impl (Not reliable)
Change-Id: Ieb7fa7dfd51925d0c66291688ca70fe41ba746f7
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Jihoon Jung [Tue, 3 Jul 2018 06:30:07 +0000 (15:30 +0900)]
Apply coding rule
Change-Id: I128899b0591188f63a8169d3a019a53a3173f431
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Jihoon Jung [Fri, 29 Jun 2018 08:00:55 +0000 (17:00 +0900)]
Add mdg send data using channel id
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Jihoon Jung [Thu, 28 Jun 2018 10:34:12 +0000 (19:34 +0900)]
Add req channel list
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Jihoon Jung [Thu, 28 Jun 2018 09:11:01 +0000 (18:11 +0900)]
Add sender implementation
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Jihoon Jung [Tue, 26 Jun 2018 11:08:53 +0000 (20:08 +0900)]
Change mdg framework
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
saerome.kim [Wed, 9 May 2018 11:13:36 +0000 (20:13 +0900)]
Make 0 length group name not to be made.
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 9 May 2018 09:25:09 +0000 (18:25 +0900)]
Fixed svace issues.
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Saurav Babu [Mon, 7 May 2018 09:06:55 +0000 (14:36 +0530)]
Implemented mdg_group_delete to delete local groups
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
saerome.kim [Fri, 4 May 2018 05:25:31 +0000 (14:25 +0900)]
Seperate the daemon package
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Mon, 30 Apr 2018 10:55:41 +0000 (19:55 +0900)]
test: fixed accumulated group resource when we calld 'find group' more
than one.
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Fri, 27 Apr 2018 02:28:42 +0000 (11:28 +0900)]
Add a routine to check if it is stored in the DB before the invite /
eject execution.
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Jihoon Jung [Thu, 26 Apr 2018 07:43:02 +0000 (16:43 +0900)]
Add mdgd_check_device_exist impl
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
saerome.kim [Thu, 26 Apr 2018 06:10:22 +0000 (15:10 +0900)]
mdg-manager: translate IoTivity error message for CAPI
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Jihoon Jung [Thu, 26 Apr 2018 05:21:00 +0000 (14:21 +0900)]
Add daemon recovery when daemon is reboot impl
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
saerome.kim [Thu, 26 Apr 2018 04:26:55 +0000 (13:26 +0900)]
mdg-manager: remove routine that returns unknown_error when coundn't
find any device.
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 25 Apr 2018 12:27:40 +0000 (21:27 +0900)]
added error handling routine.
- added printing error message
- added recovery logic when mot-agent dies
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 25 Apr 2018 11:20:57 +0000 (20:20 +0900)]
unified the seperated error code into one
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 25 Apr 2018 07:51:56 +0000 (16:51 +0900)]
mot-agent: fixed crash issue due to emitting signal during worker thread
operation.
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Tue, 24 Apr 2018 08:20:56 +0000 (17:20 +0900)]
Fixed svace issues
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Tue, 24 Apr 2018 06:24:24 +0000 (15:24 +0900)]
Fixed problem that not to find peers in the network
Unless applying this patch, it is not impossible to find peers in the
network due to the wrong comparison method.
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Mon, 23 Apr 2018 11:48:34 +0000 (20:48 +0900)]
Change prefix from 'companion' to 'mdg'
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Saurav Babu [Fri, 20 Apr 2018 06:03:16 +0000 (11:33 +0530)]
capi: Register device monitor result callback
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Fri, 20 Apr 2018 04:52:02 +0000 (10:22 +0530)]
demo: Added test code for device monitoring
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Fri, 20 Apr 2018 04:50:34 +0000 (10:20 +0530)]
capi: Added new CAPI to start/stop device monitor
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Fri, 20 Apr 2018 04:49:04 +0000 (10:19 +0530)]
comp-manager: Add dbus method to start/stop device monitor
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Thu, 19 Apr 2018 09:21:32 +0000 (14:51 +0530)]
comp-manager: Monitor Invited device
This patch adds new method to start monitoring invited device and sends
signal when device state changes
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Jihoon Jung [Thu, 19 Apr 2018 08:17:42 +0000 (17:17 +0900)]
Add Peer Description discovery implemntation
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Saurav Babu [Wed, 18 Apr 2018 14:02:05 +0000 (19:32 +0530)]
comp-manager: Send KeepAlive message after device invite is done
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Fri, 13 Apr 2018 11:05:38 +0000 (16:35 +0530)]
comp-manager: Fixed glib warnings and memory corruptions
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Thu, 12 Apr 2018 11:42:17 +0000 (17:12 +0530)]
Fixed memory leaks
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Thu, 12 Apr 2018 10:49:09 +0000 (16:19 +0530)]
comp-manager: Don't update device ip pointer
strtok updates the pointer which is passed so use a copy to pass to
strtok
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
saerome.kim [Wed, 11 Apr 2018 12:39:09 +0000 (21:39 +0900)]
comp-manager: make comp_is_local_ip() function uses both IPv6 and IPv6 when comparing.
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 11 Apr 2018 12:11:37 +0000 (21:11 +0900)]
d2d-manager: remove unnecessary timer callback which causes mot-agent crash
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 11 Apr 2018 11:35:17 +0000 (20:35 +0900)]
Fixed a bug that wrong IP information is used in comp_compare_ip_and_ifname()
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 11 Apr 2018 10:56:36 +0000 (19:56 +0900)]
Modified to distinguish local and remote devices using IP information
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Saurav Babu [Wed, 11 Apr 2018 09:23:25 +0000 (14:53 +0530)]
demo: Send/Receive buffered data
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Wed, 11 Apr 2018 09:22:18 +0000 (14:52 +0530)]
capi: Send data as array of bytes instead of string
Application might be sending buffered data so this patch sends data as
array of bytes instead of string
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Wed, 11 Apr 2018 09:19:01 +0000 (14:49 +0530)]
comp-manger: Send/Receive buffered data instead of string
Application can send buffered data with length, sending it as string
incomplete data would be received. This patch sends data as string after
encoding it to Base64 and on receiver side decodes it before providing
data to upper layer
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Wed, 11 Apr 2018 09:17:43 +0000 (14:47 +0530)]
Enable Base64 encoding support
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Tue, 10 Apr 2018 12:39:27 +0000 (18:09 +0530)]
capi: Fixed random crashes due to device_type initialized with 0
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
saerome.kim [Tue, 10 Apr 2018 04:58:33 +0000 (13:58 +0900)]
capi: change APIs relevant devices
-companion_device_get_my_uuid -> copanion_device_information_get_my_uuid
-companion_device_get_my_device -> companion_device_informaion_get_my_device
-change device_type from char* to enumeration value
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Saurav Babu [Fri, 6 Apr 2018 07:27:07 +0000 (12:57 +0530)]
demo: Receive requester device id in receive_request_result
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Fri, 6 Apr 2018 07:26:25 +0000 (12:56 +0530)]
capi: Add requester device id in companion_request_result_cb
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Fri, 6 Apr 2018 07:22:04 +0000 (12:52 +0530)]
comp-manager: Add requester uuid when sending data to remote device
This patch also notifies requester uuid to upper layer in request
result notification
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Thu, 5 Apr 2018 14:22:30 +0000 (19:52 +0530)]
demo: Fixed issue with incorrect comparision of command in receive_request_result
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Thu, 5 Apr 2018 14:21:35 +0000 (19:51 +0530)]
demo: Register callback to receive request result
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Thu, 5 Apr 2018 12:13:17 +0000 (17:43 +0530)]
capi: Add ref count in comp-manager when initializing app
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Thu, 5 Apr 2018 12:10:24 +0000 (17:40 +0530)]
comp-manager: Add new method to store ref count of applications
When application deinitializes then it disables companion-manager, but
there could be a possibility that multiple application would have
initialized and when one application is deinitialized then companion
manager is killed which results in abrupt behavior for other
applications
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Wed, 4 Apr 2018 11:52:38 +0000 (17:22 +0530)]
comp-manager: Send command directly without discovering resource
This patch sends command directly without discovering if resource is
already discovered
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
saerome.kim [Tue, 3 Apr 2018 11:50:33 +0000 (20:50 +0900)]
capi: Change callback function called after request functions
saerome.kim [Mon, 2 Apr 2018 13:03:10 +0000 (22:03 +0900)]
capi: change API names to make doxygen doc.
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Jihoon Jung [Mon, 2 Apr 2018 05:33:03 +0000 (14:33 +0900)]
Add db implementation
Signed-off-by: Jihoon Jung <jh8801.jung@samsung.com>
Saurav Babu [Mon, 2 Apr 2018 03:44:50 +0000 (09:14 +0530)]
Fixed coding style related issues
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
saerome.kim [Fri, 30 Mar 2018 05:05:52 +0000 (14:05 +0900)]
comp-manager: add OCPlatform infomation
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Fri, 30 Mar 2018 04:08:45 +0000 (13:08 +0900)]
capi: add privilege comments
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Saurav Babu [Thu, 29 Mar 2018 10:53:19 +0000 (16:23 +0530)]
comp-manager: Notify send data result to application
This patch also fixes memory leaks
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Thu, 29 Mar 2018 10:47:04 +0000 (16:17 +0530)]
comp-manager: Send data directly to host without discovery
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Thu, 29 Mar 2018 10:35:26 +0000 (16:05 +0530)]
capi: Store secure port number of devices
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Thu, 29 Mar 2018 10:27:48 +0000 (15:57 +0530)]
comp-manager: Fixed compile time error
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
saerome.kim [Thu, 29 Mar 2018 06:32:39 +0000 (15:32 +0900)]
d2d-manager: fix doxgen warnings and errors
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Thu, 29 Mar 2018 02:26:19 +0000 (11:26 +0900)]
d2d-manager: add doc.h and change of copyright enforcement year
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 28 Mar 2018 12:59:10 +0000 (21:59 +0900)]
d2d-manager: remove unnecessary files
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 28 Mar 2018 10:17:10 +0000 (19:17 +0900)]
capi: disable feature check routine temporally.
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 28 Mar 2018 08:18:49 +0000 (17:18 +0900)]
capi: add feature check routine
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Wed, 28 Mar 2018 05:29:00 +0000 (14:29 +0900)]
capi: seperate a file related dbus
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Saurav Babu [Tue, 27 Mar 2018 09:05:48 +0000 (14:35 +0530)]
comp-manager: Send NULL terminated string as data
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
saerome.kim [Mon, 26 Mar 2018 12:31:05 +0000 (21:31 +0900)]
d2d-manager: make capi can support multi-clients.
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Mayank Haarit [Mon, 26 Mar 2018 11:34:14 +0000 (17:04 +0530)]
Removed compilation error
Changed e.reason() -> e.what()
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
saerome.kim [Mon, 26 Mar 2018 05:11:42 +0000 (14:11 +0900)]
d2d-manager: Modify API header files align with ACR rules
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Mon, 26 Mar 2018 02:34:10 +0000 (11:34 +0900)]
d2d-manager: fix Tizen coding rules
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Fri, 23 Mar 2018 11:29:16 +0000 (20:29 +0900)]
d2d-manager: initial documentation
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Saurav Babu [Fri, 23 Mar 2018 11:18:47 +0000 (16:48 +0530)]
comp-manager: Fixed issue in sending response of Post Request
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Fri, 23 Mar 2018 10:25:20 +0000 (15:55 +0530)]
comp-manager: Code cleanup after replacing iotcon with IoTivity C++ Stack
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Fri, 23 Mar 2018 03:35:11 +0000 (09:05 +0530)]
comp-manager: Handle Post request from client using IoTivity C++ Stack
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
Saurav Babu [Thu, 22 Mar 2018 10:12:33 +0000 (15:42 +0530)]
comp-manager: Added Send Data with Post method using IoTivity C++ stack
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
saerome.kim [Thu, 22 Mar 2018 08:54:35 +0000 (17:54 +0900)]
companion-manager: fix crash issue
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
saerome.kim [Thu, 22 Mar 2018 08:44:11 +0000 (17:44 +0900)]
d2d-manager: fix svace issue
- memory leak and etc.
Signed-off-by: saerome.kim <saerome.kim@samsung.com>
Saurav Babu [Wed, 21 Mar 2018 15:14:57 +0000 (20:44 +0530)]
comp-manager: Code cleanup when adding new resource
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>