platform/core/dotnet/diagnostics.git
5 years ago[Tizen] fix gbs build for v3.0.0 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix accepted/tizen/5.5/unified/20191031.032611 accepted/tizen/5.5/unified/mobile/hotfix/20201027.083746 accepted/tizen/unified/20191016.000355 submit/tizen/20191015.063341 submit/tizen_5.5/20191031.000003 submit/tizen_5.5/20191031.000011 submit/tizen_5.5/20191031.000013 submit/tizen_5.5_mobile_hotfix/20201026.185103 tizen_5.5.m2_release
Konstantin Baladurin [Fri, 4 Oct 2019 18:08:20 +0000 (21:08 +0300)]
[Tizen] fix gbs build for v3.0.0

5 years ago[Tizen] Add CoreCLR and CoreFX packages to lists of required
Gleb Balykov [Mon, 19 Aug 2019 14:38:55 +0000 (17:38 +0300)]
[Tizen] Add CoreCLR and CoreFX packages to lists of required

5 years ago[Tizen] Update libopenssl-64bit to libopenssl11-64bit
Hyungju Lee [Mon, 26 Aug 2019 10:33:18 +0000 (19:33 +0900)]
[Tizen] Update libopenssl-64bit to libopenssl11-64bit

5 years ago[Tizen] Do not copy CoreFX dlls to artifacts
Gleb Balykov [Thu, 15 Aug 2019 10:02:25 +0000 (13:02 +0300)]
[Tizen] Do not copy CoreFX dlls to artifacts

5 years ago[Tizen] Add gbs support
Gleb Balykov [Mon, 5 Aug 2019 13:26:44 +0000 (16:26 +0300)]
[Tizen] Add gbs support

5 years ago[Tizen] Add prebuilt libicu-57.1 libraries
Gleb Balykov [Mon, 5 Aug 2019 13:03:14 +0000 (16:03 +0300)]
[Tizen] Add prebuilt libicu-57.1 libraries

5 years ago[Tizen] Add build tools v3.0.0
Konstantin Baladurin [Wed, 25 Sep 2019 19:34:39 +0000 (22:34 +0300)]
[Tizen] Add build tools v3.0.0

5 years agoVerbose logging for symbol publish (#491)
Mike McLaughlin [Sat, 21 Sep 2019 00:30:16 +0000 (17:30 -0700)]
Verbose logging for symbol publish (#491)

Change to stable version (no preview tag)

Fix product version string and update docs

Remove source link disabling

5 years agoFix a timeout exception causing unhandled exception crash (#492) (#494)
Sung Yoon Whang [Sat, 21 Sep 2019 00:29:30 +0000 (17:29 -0700)]
Fix a timeout exception causing unhandled exception crash (#492) (#494)

* Fix a timeout exception causing unhandled exception crash

* Fix the same issue on Unix too

* Move the exception handling to StopMonitor to distinguish actually incompatible runtimes from early exits

* fix build error

5 years agoMerge pull request #487 from mikem8361/release/3.0
Mike McLaughlin [Wed, 18 Sep 2019 02:07:50 +0000 (19:07 -0700)]
Merge pull request #487 from mikem8361/release/3.0

Fix publish build leg

5 years agoFix publish build leg
Mike McLaughlin [Wed, 18 Sep 2019 02:06:42 +0000 (19:06 -0700)]
Fix publish build leg

5 years agoMerge pull request #486 from mikem8361/release/3.0
Mike McLaughlin [Wed, 18 Sep 2019 00:27:36 +0000 (17:27 -0700)]
Merge pull request #486 from mikem8361/release/3.0

Snapshot RC1

5 years agoChange version to rc1
Mike McLaughlin [Wed, 18 Sep 2019 00:20:04 +0000 (17:20 -0700)]
Change version to rc1

5 years agoMerge branch 'master' into release/3.0
Mike McLaughlin [Wed, 18 Sep 2019 00:19:06 +0000 (17:19 -0700)]
Merge branch 'master' into release/3.0

5 years agoPublish SOS symbols (#482)
Mike McLaughlin [Tue, 17 Sep 2019 01:33:41 +0000 (18:33 -0700)]
Publish SOS symbols (#482)

Publish SOS symbols

Issue: https://github.com/dotnet/diagnostics/issues/481

5 years agoShow warning when providers are specified via GUID (#476)
Sung Yoon Whang [Sat, 14 Sep 2019 05:12:26 +0000 (22:12 -0700)]
Show warning when providers are specified via GUID (#476)

* Show warning when providers are specified via GUID

* Lets not throw useless exceptions

* Fix typo

5 years agoVarious fixes and update cdb (#477)
Mike McLaughlin [Sat, 14 Sep 2019 04:08:15 +0000 (21:08 -0700)]
Various fixes and update cdb (#477)

Various fixes

Change cdb version in config

Fix symbol not found problem caused by directory symstore not setting the stream position to 0.

5 years agodotnet-trace CLI changes (#473)
Sung Yoon Whang [Fri, 13 Sep 2019 05:32:12 +0000 (22:32 -0700)]
dotnet-trace CLI changes (#473)

* Fix dotnet-trace CLI according to the newest spec changes

* Add some configuration strings to help users understand where providers came from

* Some typos

* More UI changes suggested from PR

* Some strange Console bug causing issues... Clear the console before printing anything to make it work better

* remove provider/profile string from enabledBy column

5 years agoFix dumpmd/ip2md commands for < 3.x runtimes (#462)
Mike McLaughlin [Thu, 12 Sep 2019 07:34:56 +0000 (00:34 -0700)]
Fix dumpmd/ip2md commands for < 3.x runtimes (#462)

Fix dumpmd/ip2md commands for < 3.x runtimes

Implement GetEEVersion for xplat using the embedded "@(#)Version" string.

Enabled/add the "eeversion" command for xplat.

Added LLDBService2::GetModuleVersion to get the version string via the "sccid" symbol. Fallback
to using search the data sections to the version string.

Added same to SOSHost so eeversion works in dotnet-dump.

Fixed initializing g_moduleInfo for Linux. It is used by dumpmt. Added new LLDBService2::GetModuleInfo api to do this.

Added "dumparray" alias to lldb command aliases.

Add testing for the eeversion command.

Fixed desktop SOS tests. The recent change adding the MAJOR_RUNTIME_VERSION_X SOS runner
define silently broke the "desktop" SOS. Made the SOS runner more robust to these silent
failures.

5 years agoMerge pull request #466 from noahfalk/dotnet-trace-profile-update
Noah Falk [Thu, 12 Sep 2019 00:20:10 +0000 (17:20 -0700)]
Merge pull request #466 from noahfalk/dotnet-trace-profile-update

Improve dotnet-trace profile CLI syntax

5 years agoMake gc/gc-collect profiles available (#441)
Sung Yoon Whang [Wed, 11 Sep 2019 22:35:05 +0000 (15:35 -0700)]
Make gc/gc-collect profiles available (#441)

* Make gc/gc-collect profiles available

* Add a new gc-verbose profile, rename existing gc profile to gc-with-heapsurvival, remove sampleprofiler from gc-collect

* gc-verbose only needs stack at gc events -- disabling sampleprofiler for this profile

* Remove gc-with-heapsurvival, update description for gc-verbose

5 years agoFix nullref caused in System.CommandLine by having a default value of null for durati...
John Salem [Tue, 10 Sep 2019 23:46:18 +0000 (16:46 -0700)]
Fix nullref caused in System.CommandLine by having a default value of null for duration (#468)

5 years agoImprove dotnet-trace profile CLI syntax
noahfalk [Tue, 10 Sep 2019 02:10:47 +0000 (19:10 -0700)]
Improve dotnet-trace profile CLI syntax

1) Rename 'runtime-basic' -> 'cpu-sampling' to better align with what we are going to tell users to use it for. Technically you can do other things with it too, but I think we should favor names that describe what it is usually used for vs. being generic to cover less common possibilities.

2) Eliminated the 'none' option. We got feedback this option was confusing and hard to discover. The original goal was that final providers = --profile config + --providers config. Since --profile defaulted to cpu sampling you needed a way to disable that part of it, the 'none' profile. The new approach is to only provide a default profile when both --profile and --providers haven't been specified. I am also suggesting some help and command-line output spew to make it obvious why the default profile kicked in.

3) Updating the GC profile names based on work Sung is doing.

5 years agoAdd hidden duration option to dotnet-trace (#453)
John Salem [Fri, 6 Sep 2019 17:49:45 +0000 (10:49 -0700)]
Add hidden duration option to dotnet-trace (#453)

* Add duration option to dotnet-trace

* Use TimeSpan instead of int
* change to just re-use the MRE

* Fix duration option name

5 years agoMake a different option to change the default format for convert command (#455)
Sung Yoon Whang [Thu, 5 Sep 2019 23:12:33 +0000 (16:12 -0700)]
Make a different option to change the default format for convert command (#455)

* Make a different option to change the default format for convert command

* Make --format a required option for convert command, Write on console instead of throwing an ArgumentException:

5 years agoMerge pull request #461 from mikem8361/release/3.0
Mike McLaughlin [Thu, 5 Sep 2019 17:20:52 +0000 (10:20 -0700)]
Merge pull request #461 from mikem8361/release/3.0

Update docs to Preview 9 version

5 years agoMerge branch 'master' into release/3.0
Mike McLaughlin [Thu, 5 Sep 2019 17:18:27 +0000 (10:18 -0700)]
Merge branch 'master' into release/3.0

5 years agoUpdate docs to Preview 9 version (#460)
Mike McLaughlin [Thu, 5 Sep 2019 17:16:18 +0000 (10:16 -0700)]
Update docs to Preview 9 version (#460)

5 years agoMerge pull request #458 from mikem8361/release/3.0
Mike McLaughlin [Thu, 5 Sep 2019 00:34:42 +0000 (17:34 -0700)]
Merge pull request #458 from mikem8361/release/3.0

Preview 9 snapshot

5 years agoMerge branch 'master' into release/3.0
Mike McLaughlin [Wed, 4 Sep 2019 23:48:01 +0000 (16:48 -0700)]
Merge branch 'master' into release/3.0

5 years agoFix memory leak (#457)
Andrew Au [Tue, 3 Sep 2019 20:46:21 +0000 (13:46 -0700)]
Fix memory leak (#457)

5 years agoAdd architecture option dotnet-sos (#450)
Mike McLaughlin [Tue, 27 Aug 2019 01:12:24 +0000 (18:12 -0700)]
Add architecture option dotnet-sos (#450)

Add architecture option dotnet-sos

Issue: https://github.com/dotnet/diagnostics/issues/406

Add --diag option to dotnet-dump collect to help diagnose issues like https://github.com/dotnet/diagnostics/issues/449 and others.

Update FAQ.

5 years agoFix issue #280: statics not displayed correctly in DumpObj command (#446)
Mike McLaughlin [Sat, 24 Aug 2019 18:43:35 +0000 (11:43 -0700)]
Fix issue #280: statics not displayed correctly in DumpObj command (#446)

Fix issue #280: statics not displayed correctly in DumpObj command

On .NET Core, dwModuleDomainID is the address of the DomainLocalModule so use the DacpDomainLocalModuleData.Request to get the module info for statics.

Restored the DisplayFields/DisplaySgaredStatic/DisplayThreadStatic code from 2.1 SOS. It was changed in 3.0 when the appdomains changed. Need to be both backward and forward compatible.

Add tests for !do static fields

Add dumparray command to dotnet-dump. Issue: https://github.com/dotnet/diagnostics/issues/445.

5 years agoImprove output formatting and fix bugs in dotnet-counters (#443)
Hans Olav Norheim [Fri, 23 Aug 2019 22:36:31 +0000 (15:36 -0700)]
Improve output formatting and fix bugs in dotnet-counters (#443)

This change improves output formatting in dotnet-counters by:
- Right aligning counter values.
- Decimal numbers are aligned on the decimal separator.
- Introducing thousand separators.

It fixes the following bug:
- If monitoring multiple providers (for example System.Runtime and a user-defined one), the provider and counter names get mixed up in the output.

I simplified the logic in ConsoleWriter.cs a great deal with these changes, so it has 63 fewer lines than before now.

5 years agoMerge pull request #437 from davmason/rejit_sos
David Mason [Fri, 23 Aug 2019 22:19:59 +0000 (15:19 -0700)]
Merge pull request #437 from davmason/rejit_sos

Add ReJIT information to !DumpMD

5 years agoMerge pull request #442 from mikem8361/dirsearch
Mike McLaughlin [Thu, 22 Aug 2019 22:02:37 +0000 (15:02 -0700)]
Merge pull request #442 from mikem8361/dirsearch

 Add directory symbol search and document IDL/prebuilt files update

5 years agoAdd directory symbol search
Mike McLaughlin [Wed, 21 Aug 2019 21:49:56 +0000 (14:49 -0700)]
Add directory symbol search

Adds a setsymbolserver option (-directory) to add directories to the symbol search path.

Cleaned up how the symbol code added the "default" symbol cache. It is done when the server URI is added if a cache path wasn't specified.

Ignore adding duplicate server URI's and search directories. Ignore adding the same cache directory twice in a row.

Add -sympath option to setsymbolserver and lldb "sympath" command alias for devs that want to use the Window symbol path syntax.

Change to Preview9 prerelease label.

Issues:

https://github.com/dotnet/diagnostics/issues/422
https://github.com/dotnet/diagnostics/issues/420

5 years agoVarious document updates
Mike McLaughlin [Wed, 21 Aug 2019 21:49:18 +0000 (14:49 -0700)]
Various document updates

5 years agoSync the IDL and prebuilt files with coreclr
Mike McLaughlin [Wed, 21 Aug 2019 21:47:28 +0000 (14:47 -0700)]
Sync the IDL and prebuilt files with coreclr

5 years agoWhitespace changes
David Mason [Wed, 21 Aug 2019 11:13:23 +0000 (04:13 -0700)]
Whitespace changes

5 years agobug fixes
David Mason [Wed, 21 Aug 2019 11:03:33 +0000 (04:03 -0700)]
bug fixes

5 years agoRemove double escape in provider filter strings (#431)
John Salem [Tue, 20 Aug 2019 16:47:02 +0000 (09:47 -0700)]
Remove double escape in provider filter strings (#431)

* unescape filter strings since they are coming in double escaped, e.g., \\r\\n instead of \r\n

* add note to documentation about correct usage of filter string

5 years agoAdd Windows PE reading to dotnet-dump (#435)
Mike McLaughlin [Tue, 20 Aug 2019 03:49:45 +0000 (20:49 -0700)]
Add Windows PE reading to dotnet-dump (#435)

Add Windows PE reading to dotnet-dump

Finds or downloads the native modules like coreclr.dll or managed
assemblies into the virtual address space of the core dump. Emulates
what the Windows debugger do for minidumps.

Added "logging" command that enables/disables internal logging

5 years agoAdd guid definition
David Mason [Sat, 17 Aug 2019 22:53:16 +0000 (15:53 -0700)]
Add guid definition

5 years agoHopefully fix xplat build
David Mason [Sat, 17 Aug 2019 22:22:27 +0000 (15:22 -0700)]
Hopefully fix xplat build

5 years agoBug fixes
David Mason [Sat, 17 Aug 2019 22:00:46 +0000 (15:00 -0700)]
Bug fixes

5 years agoWIP additional commands
David Mason [Sat, 17 Aug 2019 20:36:17 +0000 (13:36 -0700)]
WIP additional commands

5 years agoWIP
David Mason [Sat, 17 Aug 2019 09:57:37 +0000 (02:57 -0700)]
WIP

5 years agoWIP
David Mason [Sat, 17 Aug 2019 09:14:53 +0000 (02:14 -0700)]
WIP

5 years agoMerge branch 'rejit_sos' of https://github.com/davmason/diagnostics into rejit_sos
David Mason [Sat, 17 Aug 2019 08:24:14 +0000 (01:24 -0700)]
Merge branch 'rejit_sos' of https://github.com/davmason/diagnostics into rejit_sos

5 years agoWIP
David Mason [Sat, 17 Aug 2019 08:22:38 +0000 (01:22 -0700)]
WIP

5 years agoFix IncrementingCounter payload generation (#433)
Sung Yoon Whang [Fri, 16 Aug 2019 20:16:17 +0000 (13:16 -0700)]
Fix IncrementingCounter payload generation (#433)

* Fix IncrementingCounter payload generation

* code review

5 years agoMerge remote-tracking branch 'upstream/release/3.0' into release/3.0
Mike McLaughlin [Tue, 13 Aug 2019 05:40:48 +0000 (22:40 -0700)]
Merge remote-tracking branch 'upstream/release/3.0' into release/3.0

5 years agoUpdate tool version 3.0.0-preview8.19412.1 (#425) (#426)
Mike McLaughlin [Tue, 13 Aug 2019 05:40:09 +0000 (22:40 -0700)]
Update tool version 3.0.0-preview8.19412.1 (#425) (#426)

5 years agoMerge branch 'master' into release/3.0
Mike McLaughlin [Tue, 13 Aug 2019 05:38:11 +0000 (22:38 -0700)]
Merge branch 'master' into release/3.0

5 years agoUpdate tool version 3.0.0-preview8.19412.1 (#425)
Mike McLaughlin [Tue, 13 Aug 2019 05:37:15 +0000 (22:37 -0700)]
Update tool version 3.0.0-preview8.19412.1 (#425)

5 years agoMerge pull request #424 from mikem8361/release/3.0
Mike McLaughlin [Tue, 13 Aug 2019 03:45:48 +0000 (20:45 -0700)]
Merge pull request #424 from mikem8361/release/3.0

Preview 8 snapshot

5 years agoMerge branch 'master' into release/3.0
Mike McLaughlin [Tue, 13 Aug 2019 00:01:07 +0000 (17:01 -0700)]
Merge branch 'master' into release/3.0

5 years agoAdd instructions about how to collect counter data via dotnet-trace (#419)
Sung Yoon Whang [Thu, 8 Aug 2019 20:46:12 +0000 (13:46 -0700)]
Add instructions about how to collect counter data via dotnet-trace (#419)

* Add instructions about how to collect counter data via dotnet-trace

* change wording

5 years agoRemoving Provider GUID references from EventPipe related files. (#416)
José Rivero [Tue, 6 Aug 2019 18:40:01 +0000 (11:40 -0700)]
Removing Provider GUID references from EventPipe related files. (#416)

5 years agoUpdate TraceEvent version (#415)
José Rivero [Mon, 5 Aug 2019 17:27:59 +0000 (10:27 -0700)]
Update TraceEvent version (#415)

5 years agoAdd arm/arm64 support to dotnet-dump (#411)
Mike McLaughlin [Tue, 30 Jul 2019 17:03:16 +0000 (10:03 -0700)]
Add arm/arm64 support to dotnet-dump (#411)

Add arm/arm64 support

Using new CLRMD version 1.1.37504

Add Microsoft.Diagnostics.DebugServices project containing the
new RegisterService and what's left of the AnalyzeContext.

Add ServiceProvider and refactor adding/creating the services.

Made OutputVaList global so we don't allocate 8K every line of output

Fixed that the "mask" (determines if error/normal/warning) is pasted on
to the debugger in OutputVaList.

Removed the formatting/buffer allocating in the OutputVaList in lldb services

Always use C++ runtime to format output now.

SOS_PTR keeps the architecture pointer size (size_t).

On x86, dotnet-dump had problems with %p formatting because the
C++ runtime was used and the pointer was converted to 64 bit by
the SOS_PTR macro.

Add arm64 registers to lldb service GetContextFromFrame

Enable tests on arm.

Added IConsoleService and removed the dependencies on System.CommandLine
from SOS.Hosting and MS.D.DebugServices.

IConsole is no longer exposed as a service.

5 years agoAdd ASP.NET Counter to known list of counters (#410)
Sung Yoon Whang [Sun, 28 Jul 2019 06:01:09 +0000 (23:01 -0700)]
Add ASP.NET Counter to known list of counters (#410)

5 years ago!u -il prototype (Part 1) (#409)
Andrew Au [Fri, 26 Jul 2019 23:29:56 +0000 (16:29 -0700)]
!u -il prototype (Part 1) (#409)

5 years agoUpdate readme.md with link to its GitHub release page (#408)
Christoph Bergmeister [MVP] [Fri, 26 Jul 2019 17:41:03 +0000 (18:41 +0100)]
Update readme.md with link to its GitHub release page (#408)

5 years agoEnable disasm mixed gc info (#403)
Bruce Forstall [Thu, 18 Jul 2019 19:04:49 +0000 (12:04 -0700)]
Enable disasm mixed gc info (#403)

* Enable gcinfo mixed in disassembly on non-Windows platforms

Rewrite the "u -gcinfo" code to not require Windows fibers,
and enable it for non-Windows platforms.

Also,
1. Enable "u -gcinfo" for ARM.
2. Fix minor issues with EHinfo/GCinfo to ensure end-of-function info is displayed

5 years agoMerge pull request #402 from mikem8361/release/3.0
Mike McLaughlin [Wed, 17 Jul 2019 19:48:23 +0000 (12:48 -0700)]
Merge pull request #402 from mikem8361/release/3.0

Update documents to preview 7 version

5 years agoMerge branch 'master' into release/3.0
Mike McLaughlin [Wed, 17 Jul 2019 19:46:08 +0000 (12:46 -0700)]
Merge branch 'master' into release/3.0

5 years agoUpdate documents to preview 7 version (#401)
Mike McLaughlin [Wed, 17 Jul 2019 19:44:58 +0000 (12:44 -0700)]
Update documents to preview 7 version (#401)

5 years agoMerge pull request #397 from mikem8361/release/3.0
Mike McLaughlin [Tue, 16 Jul 2019 03:00:45 +0000 (20:00 -0700)]
Merge pull request #397 from mikem8361/release/3.0

Preview 7 snapshot

5 years agoMerge branch 'master' into release/3.0
Mike McLaughlin [Tue, 16 Jul 2019 01:01:33 +0000 (18:01 -0700)]
Merge branch 'master' into release/3.0

5 years agoRollback arcade version update (#396)
Mike McLaughlin [Tue, 16 Jul 2019 00:42:39 +0000 (17:42 -0700)]
Rollback arcade version update (#396)

5 years agoAdd RundownEnabled field to EventPipe IPC protocol (#375)
Sung Yoon Whang [Tue, 16 Jul 2019 00:14:06 +0000 (17:14 -0700)]
Add RundownEnabled field to EventPipe IPC protocol (#375)

* Add requestRundown field to EventPipe IPC protocol

* doc change

* removing accidental .nettrace commit

* Add a new command with an option to specify rundown

* doc changes

* Make the tool compatible with previous versions of tools

* comment typo

* dont rename the existing struct to keep backward compat

* Make dotnet-counters backward compatible

* parse HR code runtime returns and throw/catch appropriate exception

* remove debug print

5 years ago Add SOS nuget package for Windows debugger team (#392)
Mike McLaughlin [Mon, 15 Jul 2019 17:22:58 +0000 (10:22 -0700)]
 Add SOS nuget package for Windows debugger team  (#392)

Add SOS nuget package for Windows debugger team

Generate extension gallery zip in new SOS.Package project. Remove
the create-gallery-zip.ps1 script and build def step.

Some misc engineering cleanup.

Upgrade arcade (1.0.0-beta.19358.1) and sdk (3.0.100-preview6-012264) versions.

Remove SOS.NETCore explicit VersionPrefix

CR

5 years agoFix broken link to Getting lldb
Steve MacLean [Thu, 11 Jul 2019 16:36:28 +0000 (12:36 -0400)]
Fix broken link to Getting lldb

5 years agoFix Debian lldb instructions
Steve MacLean [Thu, 11 Jul 2019 16:30:57 +0000 (12:30 -0400)]
Fix Debian lldb instructions

5 years agoFix issue 387 (#391)
Sung Yoon Whang [Thu, 11 Jul 2019 04:11:55 +0000 (21:11 -0700)]
Fix issue 387 (#391)

* Fix some issue in counters

* fix accidental bug

5 years agoAlign counter values (#379)
Marisa You [Wed, 10 Jul 2019 22:14:59 +0000 (15:14 -0700)]
Align counter values (#379)

* Left-align counter values

* Add comments

* Adjusted value alignment to accommodate longer counter names

* Fixed comments

* Added comment

5 years agoAdd known issues to dotnet-trace instructions
Noah Falk [Wed, 10 Jul 2019 06:06:56 +0000 (23:06 -0700)]
Add known issues to dotnet-trace instructions

5 years agoUpdate CLRMD to version 1.1.35902 (#388)
Mike McLaughlin [Tue, 9 Jul 2019 19:22:23 +0000 (12:22 -0700)]
Update CLRMD to version 1.1.35902 (#388)

5 years agoChange SOS and diagnostic tool versioning (#384)
Mike McLaughlin [Mon, 8 Jul 2019 23:21:30 +0000 (16:21 -0700)]
Change SOS and diagnostic tool versioning (#384)

Change the major/minor/patch to 3.0.0 to match our runtime.

Changed the extension gallery zip file and version to the file version
generated by Arcade.

5 years agoAdd Microsoft.DiaSymReader.Native to SOS package (#383)
Mike McLaughlin [Mon, 8 Jul 2019 21:46:00 +0000 (14:46 -0700)]
Add Microsoft.DiaSymReader.Native to SOS package (#383)

Add Microsoft.DiaSymReader.Native to SOS package

We no longer search for the diasymreader in the runtime host
directory, DAC path, etc. because for WER/Watson/!analyze needs
to work without assuming there is a .NET Core runtime to host
on the machine.

Update to version 1.1.35504 of clrmd. Fixes issues https://github.com/dotnet/diagnostics/issues/360
and "System.DllNotFoundException: Unable to load shared library 'libdl.so'..." failure.

Cleanup symbinder instance and module

5 years agoFix missing metadata problems (#370)
Mike McLaughlin [Tue, 2 Jul 2019 22:59:05 +0000 (15:59 -0700)]
Fix missing metadata problems (#370)

Fix missing metadata problems

The previous fix forced the metadata to always go through
the metadata locator callback interface. This fix the problem
when the metadata in the core dump isn't complete, but broke
getting metadata for user/app assemblies that only exist in
the core dump.

Needed to "fallback" to reading the core dump memory for the
metadata when the assembly can't be found or downloaded.

Cleaned up building the module list.

Add PublishPackages variable

5 years agoIf file exists, then overwrite it. (#374)
José Rivero [Mon, 1 Jul 2019 18:36:57 +0000 (11:36 -0700)]
If file exists, then overwrite it. (#374)

5 years agoAdd nettrace to gitignore (#373)
José Rivero [Sun, 30 Jun 2019 23:08:20 +0000 (16:08 -0700)]
Add nettrace to gitignore (#373)

5 years agoFor sos.u on a code address, pass in the code address to retrieve information about...
Koundinya Veluri [Sun, 30 Jun 2019 18:23:29 +0000 (11:23 -0700)]
For sos.u on a code address, pass in the code address to retrieve information about that code version (#369)

- In particular for the pointer to saved original code when using GCStress, which is specific to the code version
- Part of https://github.com/dotnet/coreclr/pull/25261
- Part of fix for https://github.com/dotnet/coreclr/issues/17646

5 years agoAvoid unnecessary allocation & better error message on file exists error (#371)
Sung Yoon Whang [Sun, 30 Jun 2019 04:51:05 +0000 (21:51 -0700)]
Avoid unnecessary allocation & better error message on file exists error (#371)

5 years agoUsing CancellationToken in dotnet-trace (#367)
Andrew Au [Sat, 29 Jun 2019 01:47:37 +0000 (18:47 -0700)]
Using CancellationToken in dotnet-trace (#367)

5 years agoRename Microsoft.Diagnostics.TestHelpers (#366)
Mike McLaughlin [Thu, 27 Jun 2019 19:59:46 +0000 (12:59 -0700)]
Rename Microsoft.Diagnostics.TestHelpers (#366)

5 years agodotnet-monitor: Use CommandHandler CancellationToken for SIGINT detection (#365)
Tom Deseyn [Thu, 27 Jun 2019 17:07:50 +0000 (19:07 +0200)]
dotnet-monitor: Use CommandHandler CancellationToken for SIGINT detection (#365)

5 years agoAdd _EFN_GetManagedThread for !analyze (#363)
Mike McLaughlin [Thu, 27 Jun 2019 04:44:30 +0000 (21:44 -0700)]
Add _EFN_GetManagedThread for !analyze (#363)

* Add _EFN_GetManagedThread for !analyze

Instead of reading "gCurrentThreadInfo.m_pThread" in the runtime.

* CR feedback

5 years agoAdd Ctrl-C handler for dotnet-counters (#364)
Sung Yoon Whang [Thu, 27 Jun 2019 04:36:46 +0000 (21:36 -0700)]
Add Ctrl-C handler for dotnet-counters (#364)

5 years agoCR feedback
Mike McLaughlin [Thu, 27 Jun 2019 00:46:50 +0000 (17:46 -0700)]
CR feedback

5 years agoAdd _EFN_GetManagedThread for !analyze
Mike McLaughlin [Wed, 26 Jun 2019 00:23:51 +0000 (17:23 -0700)]
Add _EFN_GetManagedThread for !analyze

Instead of reading "gCurrentThreadInfo.m_pThread" in the runtime.

5 years agoRemove OutputPath from EventPipe Collect command and update docs to reflect change...
John Salem [Tue, 25 Jun 2019 19:39:24 +0000 (12:39 -0700)]
Remove OutputPath from EventPipe Collect command and update docs to reflect change (#362)

5 years agoStandardize license header for all C# files (#361)
Andrew Au [Mon, 24 Jun 2019 19:14:41 +0000 (12:14 -0700)]
Standardize license header for all C# files (#361)

5 years agoStandardize on spelling (Diagnostic -> Diagnostics) - rename files (#358)
Andrew Au [Sat, 22 Jun 2019 06:01:50 +0000 (23:01 -0700)]
Standardize on spelling (Diagnostic -> Diagnostics) - rename files (#358)

5 years agoImplement SOS Hosting for Windows (dotnet-dump) (#352)
Mike McLaughlin [Sat, 22 Jun 2019 02:31:43 +0000 (19:31 -0700)]
Implement SOS Hosting for Windows (dotnet-dump) (#352)

* Implement SOS Hosting for Windows (dotnet-dump)

Defined all the dbgeng delegates needed to implement the subset of the
IDebugClient and related interfaces to host SOS on Windows. Also modified
various parts of the native SOS to be able to be hosted.

Changed the Ext* and DML* output functions to formatted the output before
sending it to IDebugControl::OutputVaList. There is no way to create a
cdecl reverse pinvoke. The "args" OutputVaList is ignored when hosted.

Changed from IDebugAdvanced3 to IDebugAdvanced.

Cleanup (remove globals, etc.) exts.cpp DebugExtensionNotify code to make sure
none of the globals initialized by the original code are used because these
DebugExtensionInitialize, DebugExtensionNotify and DebugExtensionUninitialize
are only called when sos is running under cdb/windbg.

Simplified ProvideLibraryInternal (used by clrstack -i only) to work on a hosted
sos. It originally was using dbgeng functions that can't be supported.

Added 2.1 version of DumpTieredNativeCodeAddressInfo (not used yet).

Enable dotnet-dump testing on Windows.

Delete useless createdump commmand.

Remove spurious error message in GetCoreClrDirectory.

Update to latest symstore: 1.0.0-dev-64131-02.

Update dummy native projects to 2019.

5 years agoStandardize on spelling (Diagnostic -> Diagnostics) (#357)
Andrew Au [Fri, 21 Jun 2019 23:45:07 +0000 (16:45 -0700)]
Standardize on spelling (Diagnostic -> Diagnostics) (#357)

5 years agoMerge pull request #353 from noahfalk/nettrace
Noah Falk [Fri, 21 Jun 2019 22:27:42 +0000 (15:27 -0700)]
Merge pull request #353 from noahfalk/nettrace

Update tools to use the newer NetTrace EventPipe format