Bowon Ryu [Tue, 22 Aug 2017 07:13:16 +0000 (16:13 +0900)]
docs: fix wrong descrpition in elm_progressbar API reference doxygen.
unit format default is NULL in Tizen.
so delete the description.
Change-Id: Ie308f428f69a5432e64092e6f7c9f8b22d154495
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Woochan Lee [Fri, 18 Aug 2017 07:02:49 +0000 (16:02 +0900)]
Datetime: Prevent null pointer reference.
When _elm_datetime_items_get() calling with only time format after datetime creation.
The location has been swapped. so some of sorted_field index address gets a invalid
address. then it makes a crash.
@tizen_fix
Change-Id: I8e073237793d6af46a726be6cd51827f14c15661
Taehyub Kim [Fri, 18 Aug 2017 05:21:33 +0000 (14:21 +0900)]
add @endif tag for elm_win_window_id_get documentation
Change-Id: Iaf28c7250a457f12ff3fe58a9cc0ca694e6ad22b
Taehyub Kim [Fri, 18 Aug 2017 03:17:01 +0000 (12:17 +0900)]
make elm_win_window_get API public
Change-Id: Ie051cc269d79294eb693804aed6765844b1403ab
SangHyeon Jade Lee [Thu, 17 Aug 2017 06:14:46 +0000 (15:14 +0900)]
genlist: process item block positioning before relative item deleted
Change-Id: Iac552c946bd37e0abf551c1c74a6a08a3c6a5acc
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
Daekwang Ryu [Wed, 16 Aug 2017 02:47:23 +0000 (11:47 +0900)]
glview: fix a condition that is identical to previous
Change-Id: Ib41f90c406d83ce10851441280e3c2652e701ea4
Wonki Kim [Thu, 17 Aug 2017 01:49:40 +0000 (10:49 +0900)]
elm_conform: Prevent infinite trial of connection to the indicator
Even if there isn't a indicator at all,
the conformant tries to connect to the indicator server INFINITELY.
Therefore that makes wasting of computing power.
This patch prevents the trials to save computing power.
@tizen_fix
Change-Id: I2ec5034bae969f13f49babbf3900aaa74390a471
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Wed, 16 Aug 2017 11:52:26 +0000 (20:52 +0900)]
Fix 'scrollto animator' reaching destination
Scrollto animator could never reach destination if animator is generated
while animator is running because animation duration is fixed.
This patch reduces animation duration on the above situation.
@tizen_fix
Change-Id: Id4b3588814c038750e40edefb18a46607db694ec
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Jaehyun Cho [Fri, 11 Aug 2017 07:06:48 +0000 (16:06 +0900)]
elc_naviframe: set focus to new view immediately only for item push
Set focus to new item view immediately when new item is pushed to show
keypad fast. Otherwise, focus of new item view is set late and keypad is
shown late.
Setting focus to item view immediately is applied to item push only.
Because if this concept is applied to item pop, then the following focus
issue happens.
Reproduction path of the item pop focus issue
1. Naviframe first item view consists of two objects.
Focus is in the second object of the first item view.
2. Naviframe push happens. (now two item views)
3. Popup appears and it gets the focus.
4. Popup button click pops the second naviframe item.
5. Focus goes to the naviframe and focus_next happens.
6. Focus is set to the first object of the first item view.
(not to the second object of the first item view)
Change-Id: I1940831dbd9ce0cf8efcd6b2172203fa1ee277fc
Sungtaek Hong [Fri, 11 Aug 2017 02:59:34 +0000 (11:59 +0900)]
Cast to double before division during region/coord calculation.
int var devided by int is cast to double after devision.
This might cause wrong calculation result.
Change-Id: I32128f81cbfa78b1e42b3c03fa18e664e31732ef
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
Wonki Kim [Fri, 11 Aug 2017 05:15:41 +0000 (14:15 +0900)]
Revert "interface_scrollable: Fix not hold the flag on mouse down"
This reverts commit
440af9fe33efbdeae3087d7cf343603fcd814438.
Change-Id: Ibe1a3c190d60dcd5324c4c8c8c477f95dc8e5a80
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Jaeun Choi [Tue, 8 Aug 2017 07:48:58 +0000 (16:48 +0900)]
test_gesture_layer3: fix typo
this typo was detected by SVACE
Change-Id: I3e32a058a0ddf7f4f22bac1106dc05698ff185a6
origin: upstream (
52368bf463c2b5ea7b69e15a7e34b1ea13258ca1)
Jaeun Choi [Tue, 8 Aug 2017 06:43:15 +0000 (15:43 +0900)]
test_gesture_layer: fix typo
this typo was detected by SVACE
Change-Id: I6b005aede302598dfe1f4af7fb38199dc4371b12
origin: upstream (
a9fdcc4cc2f5567fbc05ae418c4e3a4d13286f45)
Jaeun Choi [Wed, 9 Aug 2017 07:16:35 +0000 (16:16 +0900)]
elm_color_class: add null checking after memory allocation
origin: upstream (
15bbf4712ee1e9356fa975de6f2861bc5ce3076a)
Change-Id: Id9b82282635f8b722f6d282f3d0e84ee98aafdb0
Jaeun Choi [Wed, 9 Aug 2017 07:21:03 +0000 (16:21 +0900)]
elm_dbus_menu: add null checking after memory allocation
Change-Id: I43d0a47eb8d382007b6a9ed1d877415ad37ed52d
origin: upstream (
0927221c1a0e26b7fe006eb3110ca2bffd671b89)
Jaeun Choi [Wed, 9 Aug 2017 07:28:42 +0000 (16:28 +0900)]
elm_gesture_layer: add null checking after memory allocation
Change-Id: Ib504732e21203c414bb1e58936788e84da23cba9
origin: upstream (
41ea255002d93d285da331e2452488c8f6088f1f)
Jaeun Choi [Wed, 9 Aug 2017 07:32:36 +0000 (16:32 +0900)]
elm_gesture_layer_extra_gestures: add null checking after memory allocation
Change-Id: Ifc32e16b0489685d154b35c2d3f7a4cd71409e14
origin: upstream (
db33efb79238f5843251795ff193773bd36c83b1)
Jaeun Choi [Wed, 9 Aug 2017 07:36:13 +0000 (16:36 +0900)]
elm_prefs_data: add null checking after memory allocation
Change-Id: Ia14b6585a030fe598a9e09dc16ddc27dd1d789df
origin: upstream (
38abae53c0a5aca320984475c82fc6f6f5ae048b)
Jaeun Choi [Wed, 9 Aug 2017 07:39:54 +0000 (16:39 +0900)]
test_gesture_layer: add null checking after memory allocation
Change-Id: Id45ecd0d3ebc4d49cab51f36f319feb813d2d828
origin: upstream (
6641c07262085faf062679a21659ff7b45b05a67)
Jaeun Choi [Wed, 9 Aug 2017 07:43:27 +0000 (16:43 +0900)]
test_gesture_layer2: add null checking after memory allocation
Change-Id: Ic733f8e173d1a0ca4c90479961b05fb27f8b3b4b
origin: upstream (
530455fcee4767ce17ba56200b13dc688b64857a)
Jaeun Choi [Wed, 9 Aug 2017 07:49:15 +0000 (16:49 +0900)]
test_gesture_layer3: add null checking after memory allocation
Change-Id: I0d189511e9c65496d23a7799631f37513f16c690
origin: upstream (
c311dc638b8358f27664fba3985d9212748cf92a)
smohanty [Fri, 11 Aug 2017 00:14:08 +0000 (09:14 +0900)]
tizen_vector: Fixed the integer division issue.
Change-Id: Ib17b7a440cdc5807059774ddd0031e17b42be400
SangHyeon Jade Lee [Thu, 10 Aug 2017 07:37:04 +0000 (16:37 +0900)]
genlist : fix re-calculate on language changed
Change-Id: I3a599c45228e652624d38fa8f73db45de084c35e
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
Jaehyun Cho [Wed, 9 Aug 2017 13:37:26 +0000 (22:37 +0900)]
elc_naviframe: Use tizen_effect_cancel from naviframe_effect module
Use tizen_effect_cancel API from naviframe_effect module to cancel push
effect when a newly pushed item is deleted before the push effect is
started.
Change-Id: Ia3d89bda1b4f128a80c1cf78e3ac33e34c564dc2
Jaehyun Cho [Wed, 9 Aug 2017 14:32:35 +0000 (23:32 +0900)]
elc_naviframe: Fix to handle item deletion right after item push
If an item is deleted right after the item is newly pushed, the push
transition should not happen for both the new item and the current item.
Change-Id: Iba5b9547aae8b3916e76d9e7af3e9250229c563b
SangHyeon Jade Lee [Wed, 2 Aug 2017 10:31:10 +0000 (19:31 +0900)]
gengrid: fix wrong access info returns in access info set
Change-Id: I66478fee1468c1f57cddbf7ba9fd8c98344de161
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
SangHyeon Jade Lee [Wed, 2 Aug 2017 10:50:20 +0000 (19:50 +0900)]
gengrid: fix integer division type casting warning
Change-Id: I1c7db5310a4edb16f4fda13e2ce19c71e8389741
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
JunsuChoi [Tue, 8 Aug 2017 01:17:39 +0000 (10:17 +0900)]
Add null check for svace issues
Add null check because alloc function could return null
Change-Id: Ife8a3cc2cf48ba176e7e94c50c7d78bb2329fc6b
woochan lee [Mon, 7 Aug 2017 11:29:03 +0000 (11:29 +0000)]
Revert "Fix Svace issuese."
This reverts commit
621f22ab071e439c69907b4c818d2cbacf5b845b.
Change-Id: Ib856a08d49734e68704e02a61729dff8bc2338b4
woochan lee [Mon, 7 Aug 2017 11:28:48 +0000 (11:28 +0000)]
Revert "Fix Svace issue."
This reverts commit
7883b1a651b9417e68df248ace56ce9fdab77a9a.
Change-Id: I894925b109b1834a907caa8aa256be560dd2f1ac
Woochan Lee [Mon, 7 Aug 2017 08:31:04 +0000 (17:31 +0900)]
Fix Svace issue.
Change-Id: I5559eabddbb9bb3034ba9eea8fec1aadb2f6d3d8
Woochan Lee [Mon, 7 Aug 2017 08:07:00 +0000 (17:07 +0900)]
Fix Svace issuese.
Change-Id: I9a2f66edbe51908735315fbf859dc1a0d7641252
Woochan Lee [Mon, 7 Aug 2017 07:42:35 +0000 (16:42 +0900)]
Datetime: Apply UI Mirroring for Tizen 3.0
The datetime is not including UI Mirroring feature.
Change-Id: Iacdf0bf589e328a7ef3902555e92d11f505492ff
Youngbok Shin [Fri, 4 Aug 2017 02:59:29 +0000 (11:59 +0900)]
label: set duration/speed for text marquee using internal functions
@tizen_feature
Change-Id: I3746364acd1818a9f0766ce18e029c8a3f70dc0d
Shinwoo Kim [Thu, 3 Aug 2017 06:46:25 +0000 (15:46 +0900)]
atspi: do not accept invisible object
Issue:
If an object is child of scrollable parent, then the object is accepted even
though the object is invisible.
Solution:
Do not accept invisible object.
Change-Id: I0492eb9f5f265211521f066acd6f56d9c24356c0
Shinwoo Kim [Thu, 3 Aug 2017 06:24:31 +0000 (15:24 +0900)]
atspi: enhance elm_atspi_gesture_cb_set document
Change-Id: I887c08230b1de0404357d1b3717f4b3e14c08365
Shinwoo Kim [Wed, 2 Aug 2017 12:15:56 +0000 (21:15 +0900)]
atspi: handle "gesture_required" attribute
The elementary sends the "detail2" information highlight based on the attribute
"gesture_required" when an object grabs.
If an object has attribute key "gesture_required", and "scroll" for its value,
then the "detail2" is 1. Otherwise, the "detail2" is 0.
The screen-reader AT client calls "ObjectNeedsScrollGesture" method of
e-mod-tizen-screen-reader window manager module with object geometry value,
if the "detail2" is 1. Otherwise, the object geometry value is not used.
The e-mod-tizen-screen-reader window manager module will send mouse event
based on the object geometry.
Application side could use this feature setting attribute as below:
- elm_atspi_accessible_attribute_append(btn, "gesture_required", "scroll");
This patch set depends on:
https://review.tizen.org/gerrit/#/c/142108/ (screen-reader)
https://review.tizen.org/gerrit/#/c/142107/ (e-mod-tizen-screen-reader)
Change-Id: I0b731ce947be569b2d782fdc21f18c79ffebf70e
Youngbok Shin [Fri, 4 Aug 2017 02:45:14 +0000 (11:45 +0900)]
cursor: remove a warning message from a unused static variable
@tizen_fix
Change-Id: Icfcaf6e0c92aa259afae816313eb29550456d9f8
(cherry picked from commit
8187228fbf2d278779c09366bc12939e563224c8)
Youngbok Shin [Thu, 3 Aug 2017 07:39:18 +0000 (16:39 +0900)]
entry: remove a warning message caused by unused parameter for cbhm
@tizen_fix
Change-Id: Ib1f61049b4c7fc075ac9764642eca0a9e7cb358e
(cherry picked from commit
2d18f914a1731a051e1818b1b890f6500a6878c4)
Youngbok Shin [Wed, 2 Aug 2017 10:57:05 +0000 (19:57 +0900)]
entry: remove unused label for goto
@tizen_fix
Change-Id: I7ea5763432b9118eb7e33f20419be2e25ccf7a9f
(cherry picked from commit
4efc635dc647d5e43a9e0170f41502a23438aeb5)
Shinwoo Kim [Wed, 2 Aug 2017 06:51:25 +0000 (15:51 +0900)]
atspi: suppress warning message
The following is warning message.
In function '_elm_genlist_elm_widget_screen_reader':
warning: declaration of 'l' shadows a previous local [-Wshadow]
Eina_List *l;
^
note: shadowed declaration is here
Eina_List *l;
Change-Id: I8af5c5e4a49219bebccd2a51ddc0ddfc853f447f
Shinwoo Kim [Tue, 1 Aug 2017 10:22:03 +0000 (19:22 +0900)]
atspi: access overrides Accessible.state_set.get
The elm_access a widget makes primitive object accessible. If a primitive
object is not visible, then the elm_access should NOT have state VISIBLE and
SHOWING. From now the elm_access is checking visibility of primitive object.
Change-Id: I27c2f29d3346e03329784872281e4734ec753160
Wonki Kim [Wed, 2 Aug 2017 08:10:49 +0000 (17:10 +0900)]
interface_scrollable: Modify to cast values between double and int explicitly
this commit modify code to cast double and int variables explicitly
Change-Id: I6dc51d60ade454c773308eb778a74c8117ac8fd9
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Wonki Kim [Wed, 2 Aug 2017 08:09:14 +0000 (17:09 +0900)]
elm_config: Fix potentional error
Change-Id: I6f3a7e1035f7c329f8ee347b4235cbbcfa30400f
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Jiyoun Park [Wed, 2 Aug 2017 07:48:27 +0000 (16:48 +0900)]
efl_ui_win: add error hanling code for malloc fail
Change-Id: I57db76192233afcc95df22bef8eff824611228d7
Jiyoun Park [Mon, 31 Jul 2017 06:21:21 +0000 (15:21 +0900)]
elm_win: add ELM_WIN_SOCKET_IMAGE type check
elm_win_socket_listen api only work for ELM_WIN_SOCKET_IMAGE type window.
So it is better to add type check code.
Change-Id: Ic5f0c97767a957493bda70eddf96765c0723e58a
Shinwoo Kim [Mon, 24 Jul 2017 10:11:48 +0000 (19:11 +0900)]
atspi: grab highlight using unrealized item
The looping naviation could make the first(or last) item grab highlight.
But the _elm_widget_item_elm_interface_atspi_component_highlight_grab returns
without setting highlight if sd->view is NULL that means the item is NOT
realized in case of genlist.
So the _elm_genlist_item_elm_interface_atspi_component_highlight_grab BRINGs
the first(or last) item IN first before grabbing highlight.
Change-Id: Id36716d1e2d6249532d67dede9357e152b3d3107
JunsuChoi [Mon, 24 Jul 2017 07:00:18 +0000 (16:00 +0900)]
atspi: Remove build warning
Remove null initialization becuase of
variable ss(Elm_Atspi_State_Set) is not pointer
Change-Id: I5f57e5d25c035dae841cd1258cb172ee7ee4a6a3
Hosang Kim [Mon, 24 Jul 2017 05:35:13 +0000 (14:35 +0900)]
slider: changed negative zero to zero
When slider value is between 0.0 and -0.5, -0 is printed.
Change-Id: I7381dabc0749555b77be53e67c74e646c17840c1
SangHyeon Lee [Tue, 18 Jul 2017 07:30:26 +0000 (16:30 +0900)]
genlist : fix wrong item referencing in pos adjust
Change-Id: Ie055661c4f20308511f7c39c92e2dee36bbcdb15
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
Shinwoo Kim [Wed, 19 Jul 2017 23:50:54 +0000 (08:50 +0900)]
atspi: fix mobile doxygen category issue
Accessibility ┬ Access
├ Atspi Accessible
├ Atspi Bridge
└ Atspi Component
The Access, Atspi Bridge, and Atspi Component did not have contents.
Change-Id: I4d0c1b7a25705217deb35fe7d9363035fc7708f5
Wonki Kim [Wed, 19 Jul 2017 06:13:28 +0000 (15:13 +0900)]
interface_scrollable: fix build fail on interface_scrollable
typo error
Change-Id: I4d9e786a71ff7bc765ff08e1c5266fb6801455b0
Shinwoo Kim [Tue, 18 Jul 2017 06:18:04 +0000 (15:18 +0900)]
atspi: Expose API for Wearable only
Change-Id: Ib58b7e43992bed68796338815eb537fd42b423db
Wonki Kim [Tue, 18 Jul 2017 11:15:21 +0000 (20:15 +0900)]
interface_scrollable: Add "content,resize" callback to keep backward compat
There was a "content,resize" callback before tizen 3.0.
Even if it was a tizen only code block, there could be a backward compat issue
without the callback.
This commit emits the callback after whole procedure for content resizing.finished.
@tizen_feature
Change-Id: I0eccf8ebc8c704e1403056c0078bd6625d612265
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Shinwoo Kim [Tue, 11 Jul 2017 11:30:16 +0000 (20:30 +0900)]
atspi: use last appended relation information
So far, the screen reader has used the first relation information.
So application should remove appended relation information, before appending
relation information newly. This is hard to use in some point of view.
The application used *append API as *set API.
So using last appended relation information makes more sense.
Change-Id: Id7c3e7dc02acc0a883eb7e55b3892461aee259a3
JunsuChoi [Tue, 4 Jul 2017 01:36:39 +0000 (10:36 +0900)]
change markup text to utf8 when called accessible_name_get function
Change-Id: If56425bb5ab316e029d38024bcd7bfd5811fb8e6
Shinwoo Kim [Tue, 11 Jul 2017 10:16:39 +0000 (19:16 +0900)]
atspi: enhance finding the first,last obj
There are two kind of first(or last) object.
(1) The first object in viewport of its scrollable parent.
(2) The first object in accessibilty tree regardless of scrollable parent.
Looping navigation should use the first object of type (2)
Other cases should use the first object of type (1)
If view is changed, then there is no highlight. In this case the first object
of type (1) should be used. For example, if view is changed to 1 depth from
2 depth, then the highlight should use the first object of type (1).
If the following is 1 depth view after 2 depth view disapears, then there is
not currently highlighted object. In this case the item 4 should grab highlight
for next object, and the item 6 should grab highlight for the previous object.
+--------+
| item 4 |
|--------|
| item 5 |
|--------|
| item 6 |
+--------+
Change-Id: I72cd6b993a9dadbef5807fdf9d4674db8e8579b6
Shinwoo Kim [Fri, 7 Jul 2017 02:44:14 +0000 (11:44 +0900)]
atspi: consider scrollable parent for "GetNeighbor"
To determine the next object,
find top scrollable parent of next object excluding scrollable parents of start
object, and check if the next object exists inside of the top scrollable parent
viewport.
If there is not top scrollable parent, then use the next object.
(layout)
|
|----------|----------|
| | |
(btn1) (scroller) (btn3)
|
|
|----------|----------|
| | |
(btn2) (genlist) (toolbar)
[case: top scrollable parent is scroller]
If current highlighted(start) object is btn1, and the 10th genlist item shows
just under the btn1 (i.e. btn2, and 1st ~ 9th items are scrolled out),
then the next object should be the 10th item.
[case: top scrollable parent is NULL]
After the 10th genlist item grabs highlight, the previous object should be the
9th genlist item, not the btn1. In this case scrollable paretns of start object
are scroller, and genlist. the next object has same scrollable parents. So the
top scrollable parent is NULL.
If the 10th genlist item is the next object of btn1, then the btn1 object could
be the previous object of 10th genlist. But this patch set make the 9th genlist
item previous. This behavior is quite dependent on UX definition.
Change-Id: I8ded2d533f0b77202be25713eafca652e1886bcb
Shinwoo Kim [Wed, 5 Jul 2017 08:10:47 +0000 (17:10 +0900)]
atspi: fix integer underflow issue
Change-Id: I99a498b901c0980d62e5c8abaf42687fb54ac335
Shinwoo Kim [Fri, 30 Jun 2017 09:15:29 +0000 (18:15 +0900)]
atspi: fix bug of finding the last object
The last object can be found only if all_children_visited is false.
The start is same with root, when looking for the last object.
The first object can be found already, even though the start is same with root.
Because the forwarding navigation can visit its children.
Change-Id: I763994505d5b2b21ee8aa459b39c08512a34a279
Shinwoo Kim [Fri, 30 Jun 2017 02:35:51 +0000 (11:35 +0900)]
atspi: suppress runtime error, build warning
[runtime error]
(1) elm_atspi_bridge.c:2787 _bridge_path_from_object() safety check failed: eo == NULL
(2) elm_atspi_bridge.c:6184 _bridge_object_register() Unable to register class w/o Elm_Interface_Atspi_Accessible!
(3) lib/eo/eo.c:697 _eo_call_resolve() in elm_widget.eo.c:169: func 'elm_obj_widget_access_highlight_in_theme_get' (288) could not be resolved for class 'Edje_Object'
- Note: The access_highlight_in_theme (3) should handle non Elm_LAYOUT_CLASS.
Or the access_highlight_in_theme should be removed. If the screen-reader
shows highlight, then the access_highlight_in_theme doesn't make sense.
[build warning]
(1) warning: passing argument 2 of '_object_get_bus_name_and_path' discards 'const' qualifier from pointer target type
(2) warning: passing argument 3 of '_object_get_bus_name_and_path' from incompatible pointer type
Change-Id: I4a690afdbf90f2bf72b497d0c3916c7fc83ddb74
Shinwoo Kim [Thu, 29 Jun 2017 07:31:44 +0000 (16:31 +0900)]
atspi: check accessible parent for can_highlight
If an object is Elm_Widget and accessible child of Elm_Widget_Item, then
can_child of this object does not check value of the Elm_Widget_Item.
Because the _elm_widget_item_highlightable has used elm_widget_parent_get.
It doesn't return Elm_Widget_Item. It returns parent object of Elm_Widget_Item.
So _elm_widget_item_highlightable should have to use accessible parent.
Change-Id: Iecbc162fc676efeb6e3162418ac3eb34b761195d
JunsuChoi [Wed, 14 Jun 2017 06:07:34 +0000 (15:07 +0900)]
atspi: moved highlight when object is out of screen
when highlighted object is out of screen or scroll view
, elementary send 'object:move-outed' signal to screen-reader
need this commit:
screen-reader - https://review.tizen.org/gerrit/#/c/133970/
at-spi2-core - https://review.tizen.org/gerrit/#/c/133972/
Change-Id: I32571343548031e2c2befd1c0828de031bace1f0
jiin.moon [Wed, 31 May 2017 10:01:03 +0000 (19:01 +0900)]
elm_image: Fix previous image visible issue
Summary: Previous image still visible when elm_image_file_set has wrong file path.
Test Plan: self
Reviewers: jpeg, jypark, singh.amitesh
Reviewed By: singh.amitesh
Subscribers: singh.amitesh, minkyu, cedric
Differential Revision: https://phab.enlightenment.org/D4888
Change-Id: If8393e3851ea7cec1673540d7798eba1850cc75d
Jean-Philippe Andre [Thu, 20 Apr 2017 09:29:26 +0000 (18:29 +0900)]
elm_image: Fix file_set when preload is disabled
If we disable preload, then the second file set on an elm_image
object would not trigger a deletion of the first image. As a
consequence, both images would be visible... really bad if there's
alpha or different dimensions!
Thanks Anand Kumar for the report!
@fix
Change-Id: If708c2d6bbc432585ba4493d6068467ab1a6086b
Daniel Zaoui [Mon, 21 Nov 2016 09:52:27 +0000 (11:52 +0200)]
efl_ui_image: fix removal of the internal evas image
During the replacement of the image with the new preloaded one,
the previous image is deleted but not removed from the list of
children of the icon (efl_ui_image), leading to Eo errors when
walking over the icon children.
@fix
Change-Id: Ic5e606bf2b485051e419b1ea0ba263cd5c7808f9
Shinwoo Kim [Mon, 26 Jun 2017 06:25:06 +0000 (15:25 +0900)]
atspi: find the first, last obj using "GetNeighbor"
The reducing IPC task overlooked functionality to get the first, last object.
This commit is related to the following commit.
[screen-reader]
commit
72e3396fac3a377f49422af454875a0e4c9a58bc
Add loop navigation feature.
Screen reader gives FOCUS_CHAIN_END_NOTIFICATION_EVENT notification if there is
no more object in its direction. If user gives next(or prev) gesture in same
direction one more time, then the first(or last) object will grab highlight.
Change-Id: I0e68c84a595396cbf7d0d2ae4d93fca4c425f0ea
Shinwoo Kim [Wed, 21 Jun 2017 02:39:18 +0000 (11:39 +0900)]
atspi: handle atspi proxy connection at runtime
The following cases make atspi proxy work incorrectly.
[case 1]
1. screen reader on, then a11y order would be
A1(embedding, deputy) - B1(embedded) - B2(embedded) - A2(embedding)
2. make A2 grab highlight
3. go previous, then A1 grabs highlight.
but expected result is that the B2 grabs highlight
[case 2]
1. screen reader on, then a11y order would be
A1(embedding, deputy) - B1(embedded) - B2(embedded) - A2(embedding)
2. make A1 grab highlight
3. go next, then B1 grabs highlight.
This means that the proxy connection is made properly.
4. screen reader off
5. screen reader on, then a11y order is
A1(embedding, deputy) - A2(embedding)
but the following is expected result as step 1
A1(embedding, deputy) - B1(embedded) - B2(embedded) - A2(embedding)
So far the pory connects if elm_interface_atspi_children_get is called.
So there is no chance to make connection for the [case 1].
When atspi is disabled, then all atspi related interface is closed.
But the proxy related resources are not removed.
If atspi is enabled again, then newly created interface is used on new BUS.
And the proxy related resources are reused.
So the [case 2] happens.
This patch set depends on screen-connector to use "widget,create" signal to
connect proxy on elementary side. This should be removed, and we have to
provide proper API to be used on screen-connector side to connect proxy.
Change-Id: I86f610504848db816e6db355316f8da06db513df
Shinwoo Kim [Thu, 15 Jun 2017 12:16:35 +0000 (21:16 +0900)]
atspi: "GetNeighbor" is using deputy object
A01 object is deputy object, and exists in embedding process.
A02, A03 object exist in embedding process.
B01, B02 objects exist in embedded process.
The “GetNeighbor” method should return A02 object as “next” object of B02,
and return B02 object as “prev” object of A02.
The “next” object of A01 is B01.
The “prev” object of B01 is A01.
This is default implementation.
The following is default order: A01 - B01 - B02 - A02 - A03
But more important thing is that the embedding process could use
ELM_ATSPI_RELATION_FLOWS_TO/FROM for each objects A01, A02, and A03.
So there are some cases should be considered.
(1) If A01 is ELM_ATSPI_RELATION_FLOWS_FROM object of A03, then the
“GetNeighbor” should find B02 first when it navigates backward from A03.
(2) If A03 is ELM_ATSPI_RELATION_FLOWS_TO object of A01, then the
“GetNeighbor” should find A03 first when it navigates backward from B02.
(3) Even though the A01 has ELM_ATSPI_RELATION_FLOWS_TO relation information,
the “GetNeighbor” should find B01 first. Because the
ELM_ATSPI_RELATION_FLOWS_TO object is used when “GetNeighbor” finds
next object of B02.
Change-Id: Id9ec5762fb5abe94f942bf3823c69729e6389702
Shinwoo Kim [Tue, 13 Jun 2017 09:18:03 +0000 (18:18 +0900)]
atspi: Make socket listen if atspi is enabled
The socket proxy try to listen if the atspi is not enabled.
So it elm_atspi_bridge_utils_proxy_listen returns with out creating socket
interface(_socket_ifc_create) because it checks return value of
_elm_atspi_bridge_get which is used in _elm_atspi_enabled also.
Change-Id: Ie7a929d53ca9cc90e089f6a167b0480fc041c5af
Shinwoo Kim [Wed, 14 Jun 2017 02:30:58 +0000 (11:30 +0900)]
atspi: "GetNavigableAtPoint" sends deputy object
The deputy means embedding side object works for embedded object.
If there is no object at point on embedded side, then the deputy object should
have highlight.
So far the deputy object is elm_access, and the elm_access takes highlight.
So there is no chance to have highlight on embedded side.
Change-Id: Id3fd144f74784f2630215c401b93c56a87f388e3
Shinwoo Kim [Fri, 26 May 2017 13:05:11 +0000 (22:05 +0900)]
atspi: add "GetReadingMaterial" interface method
The atspi_accessible_get_reading_material of at-spi2-core calls this method to
get reading material to be used screen-reader side. This is for reducing IPC.
It seems that the number of IPC is changed from 30 to 1.
Related patch set:
https://review.tizen.org/gerrit/#/c/131358/ (at-spi2-core)
https://review.tizen.org/gerrit/#/c/131359/ (this one, elementary)
https://review.tizen.org/gerrit/#/c/131511/ (at-spi2-atk)
https://review.tizen.org/gerrit/#/c/131714/ (screen-reader)
@tizen_only
Change-Id: Ib17d34fd8af7b5856908692c617938116d02305e
Shinwoo Kim [Fri, 19 May 2017 10:29:06 +0000 (19:29 +0900)]
atspi: Reduce action related IPC
If there are more than 10 actions on an object, then more than 10 IPC occurs for
calling reading information related action such as ReadingStopped which is called
whenever an object has highlight.
Change-Id: I884a183ec52fa30a7173a19794ab6628f0f87207
Shinwoo Kim [Wed, 28 Jun 2017 00:04:07 +0000 (09:04 +0900)]
atspi: make popup label accessible
The application could customize default behavior of popup label.
There was no way to get the popup label so far.
Change-Id: I2b0477556a155574a151b063172bdb71cf72122e
Shinwoo Kim [Thu, 8 Jun 2017 11:33:55 +0000 (20:33 +0900)]
widget: initialize local variable
Uninitialized data is read from local variable 'ow', and 'oh'
Change-Id: Ib042ba64a88d82fa883f08c08851ee44c0a9a2da
Hosang Kim [Fri, 23 Jun 2017 10:27:08 +0000 (19:27 +0900)]
conformant: Added "virtualkeypad,size,changed" smart callback.
When the virtualkeypad size is changed, applications get the notice.
Applications can do internal object calculation according to the exact
virtualkeypad size.
Change-Id: Ic1e551a885c0d371f33295b2db993c97a46160c6
SangHyeon Lee [Wed, 21 Jun 2017 07:20:50 +0000 (16:20 +0900)]
genlist: add null check in filter item internal for prevent svace issue
Change-Id: I73f6f2f320665a63e8430eafdedbb63b40510841
SangHyeon Lee [Thu, 22 Jun 2017 06:43:35 +0000 (15:43 +0900)]
genlist: fix clip set api calls in genlist when clipees are less than 2
Change-Id: If3183bf9437523f2bb0c4eaeb6c23dd43c70fb68
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
JunsuChoi [Wed, 7 Jun 2017 07:56:31 +0000 (16:56 +0900)]
atspi: Fix object is completely on screen function
is_complete variable has been modified to function correctly.
Change-Id: I2ed25f96ed51baac0873d82e985ccf445a4f6482
Radoslaw Cybulski [Wed, 8 Mar 2017 14:41:34 +0000 (15:41 +0100)]
Add navigation helper functions for screen-reader and friends (part 2)
Change-Id: Idb6c1c3f33d377922b6813c2e03a4883c8ea34f3
Radoslaw Cybulski [Fri, 3 Mar 2017 15:29:55 +0000 (16:29 +0100)]
Add navigation helper functions for screen-reader and friends
This patch adds GetNavigableAtPoint accessibility interface - the function finds accessibility object at given coordinates.
This massively (10-15 times) reduce amount of IPC calls (and time spent) in typical screen-reader scenario.
Change-Id: Iff5820e280bef64414d0f07e9e2d5927a29bae4d
Jaeun Choi [Tue, 13 Jun 2017 10:33:09 +0000 (19:33 +0900)]
panel: add "elm,state,hold", "elm,state,unhold" signals
these signals were added in Tizen 2.3 as Tizen only code
and removed after merging upstream code into Tizen 2.4.
need to add the signals for compatibility.
Change-Id: I7b5400cd2d7046bb987f9d6c504bdf93c6c7c9fc
Shinwoo Kim [Tue, 13 Jun 2017 01:42:25 +0000 (10:42 +0900)]
atspi: ctxpopup item uses parent name first
The ctxpopup does not use parent name such as elm_widget_item, and
elm_interface_atspi_accessible_name. So the elm_atspi_accessible_name_set does
not work.
Change-Id: I5f4c1d4ba9849c5e36d8471715a24298a683052b
Shinwoo Kim [Mon, 5 Jun 2017 10:36:19 +0000 (19:36 +0900)]
atspi: fix compare func to find object at point
The compare function(_sort_by_repeat_events) does not change if two objects
repeat event(repeat_events: 1) even though the second object is registered to
elm_access. In this case the object could be demoted in the list, and it is not
possilbe to find the object by screen reader.
The following is the problem case:
[Before Sorting]
1. Object A (repeat_events: 1)
2. Object B (repeat_events: 1, is registred to elm_access)
3. Object C (repeat_events: 1)
4. Object D (repeat_events: 0)
5. Object E (repeat_events: 0)
[After Sorting] D - E - A - B -C
Change-Id: I5c566252507d8d6c5aac5759588cdd9e1468cd3e
Shinwoo Kim [Tue, 30 May 2017 08:05:53 +0000 (17:05 +0900)]
atspi: do operation if its object is available
Operation 1. activate
An object under the naviframe item is accessible even though new naviframe item
is pushed on it. In this case, it is possilbe to do action of the object.
So this patch set is checking SHOWING state before doing action.
Operation 2. selection
It was possible to (de)select even though its one of perent freezes events.
It is impossilbe to (de)select using touch event if freeze_events set to 1.
So it should work same using atspi interface.
Change-Id: I59d69cd117252ef7364fd80536ce6b153c0ce920
Sungtaek Hong [Fri, 9 Jun 2017 08:39:48 +0000 (17:39 +0900)]
elm_map: fix wrong return type
@tizen_fix
Change-Id: I5243b928b738724ce31347e7d6b515451d24b2e8
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
Wonki Kim [Thu, 8 Jun 2017 04:40:23 +0000 (13:40 +0900)]
scroller: Initialize member variables which are used for unstable situation
This commit inits member vars to set proper position
when scroller initialy comes out.
Change-Id: I3b5490cbcc38fe77e549d152a7e4c666b6c4a518
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Jeeyong Um [Fri, 9 Jun 2017 05:15:25 +0000 (14:15 +0900)]
map: Fix broken link to openstreetmap.org
Signed-Off-By: Jeeyong Um <jc9.um@samsung.com>
Change-Id: Ia5607006b9bebfe05c47f10157b92a48abfc0f08
SangHyeon Lee [Fri, 9 Jun 2017 02:36:00 +0000 (11:36 +0900)]
genlist: fix build error by wrong merged patches
Change-Id: I7eeca7f7a17077e311267457ee948185da973d04
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
JunsuChoi [Thu, 8 Jun 2017 03:15:49 +0000 (12:15 +0900)]
Revert "[Scroller] Filp to cords for RTL mode in wanted_region_set"
This reverts commit
e718c067da2478193b81a347ac36cd2b04371060.
Change-Id: I9eeda933036ff07e47c64a43fe1421f5265fc2c2
SangHyeon Lee [Tue, 23 May 2017 06:10:43 +0000 (15:10 +0900)]
genlist: fix genlist item prepend to below the group parent
Change-Id: I62a08d5730882e0490a3060735afeaffec6284ef
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
(cherry picked from commit
68b28227e4ce83559484bff87005b5a11272884b)
JunsuChoi [Wed, 7 Jun 2017 04:53:40 +0000 (13:53 +0900)]
[Scroller] Filp to cords for RTL mode in wanted_region_set
In RTL mode, wanted_regison_set does not change coordinates
So add code like opensource.
Change-Id: Ib332b982c2994b0995b02bc2431fcd984610e089
(cherry picked from commit
f9d1f7303e4774124098193247838b70387b1dbd)
JinYong Park [Fri, 2 Jun 2017 08:29:58 +0000 (17:29 +0900)]
popup: fix object_mirrored_set didn't work
Using config_mirrored_set was working good at popup widget,
but object_mirrored_set didn't.
The mirrored value of notify, main layout, scroller, action area layout should be changed following popup.
@fix
https://phab.enlightenment.org/D4900
Change-Id: I5096e14c86ae313e10f2547e43b6e81de97690c3
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
Paweł Stawicki [Fri, 12 May 2017 11:37:11 +0000 (13:37 +0200)]
atspi: connect to at-spi dbus based on org.a11y.Status.IsEnabled property
Change-Id: Ic7a95172cd0da5e5285df195a4f31f9aaf98eade
Paweł Stawicki [Fri, 12 May 2017 11:37:11 +0000 (13:37 +0200)]
atspi: send window activated event to at_spi2 only once per session
Change-Id: Ibae523e85c8fa2cdf3d9d8145e99274f1b318db1
Shinwoo Kim [Thu, 25 May 2017 09:23:39 +0000 (18:23 +0900)]
atspi: do not demote an object that repeats event.
If an object is registered to elm_access, then do not demote its order even
though the object repeats event(repeat_events: 1) when _sort_by_repeat_events
function sorts object order.
User could add a rectangle to give accessibility. If the rectangle does not
repeat events, then it would be a problem when screen reader is off.
Change-Id: I3c154c96a290abb30f96564a9cee47ce237c5fe7
Taehyub Kim [Tue, 30 May 2017 06:36:24 +0000 (15:36 +0900)]
elm_photocam: fix wrong initial value for zoom mode
Change-Id: I4ee4be57645af30c4418fb8528bb767bf2211a71
Jeeyong Um [Tue, 23 May 2017 06:25:36 +0000 (15:25 +0900)]
doc: Add missing "Elm_" prefix to doxygen group name
Signed-Off-By: Jeeyong Um <jc9.um@samsung.com>
Change-Id: I85ded32ebf97cd02ce2d85a104dccc9c4b395daa
Jaeun Choi [Fri, 19 May 2017 08:59:44 +0000 (17:59 +0900)]
elm_panel: use widget data for getting geometry
_elm_panel_evas_object_smart_resize() ends up calling
_elm_panel_elm_layout_sizing_eval() to adjust the layout
according to the updated width and height.
however, evas_object_geometry_get() doesn't return the updated values.
in fact, it is not necessary to call any API since the values are
stored as widget data in _elm_widget_evas_object_smart_resize().
Change-Id: I68467ec07700ee4dea99d36ee10c433608d5f555
JEONGHYUN YUN [Thu, 16 Mar 2017 08:38:18 +0000 (17:38 +0900)]
elm_panel: set hidden property when panel is close/open
Summary:
elm_panel has a property named hidden which stores open/close status.
This is updated when:
1.bring_in animation is done(anim_stop_cb).
2.mouse_up on panel.
3.API is called. (elm_panel_toggle, elm_panel_hidden_set)
In case 3, API changes hidden, and starts bring_in animation which will call anim_stop_cb() which will update hidden again.
If bring_in animation is canceled (eg: sizing_eval), anim_stop_cb will be called and calculate hidden status
which will not guarantee updated hidden state by APIs.
Test Plan:
1.Call any APIs which will call elm_layout_sizing_eval(panel) right after calling elm_panel_toggle()/elm_panel_hidden_set().
2.Delete content of panel during "toggled" cb.
Reviewers: jpeg, eunue, cedric
Differential Revision: https://phab.enlightenment.org/D4704
@tizen_fix
Change-Id: I8e0a97910de8bbc0920dd0260e3b81bc1793827e
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>