platform/upstream/connman.git
4 years agoAdd support of EAP on Ethernet. 99/232199/10
Nishant Chaprana [Wed, 29 Apr 2020 04:29:30 +0000 (09:59 +0530)]
Add support of EAP on Ethernet.

Change-Id: I373ab90bbb699be56d9e416346a51b0795ed1e8b
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
4 years agoChange string comparison function for null string 34/231934/2 accepted/tizen/unified/20200429.032949 submit/tizen/20200427.022040 submit/tizen/20200427.073208 submit/tizen/20200428.140958
hyunuk.tak [Mon, 27 Apr 2020 01:51:49 +0000 (10:51 +0900)]
Change string comparison function for null string

1. Modify to g_strcmp0 from g_str_equal
2. Add nobacktrace option to service of tv
3. Add INS options to main configuration of tv

Change-Id: I6fa271b3b522ae5c1495714f089c69c1602a3faf
Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
4 years agoCheck enable arg for INS 40/231440/1 submit/tizen/20200422.050142 submit/tizen/20200423.044725
hyunuk.tak [Wed, 22 Apr 2020 04:04:13 +0000 (13:04 +0900)]
Check enable arg for INS

Change-Id: I4c8df2dd519da9bef7c763f65b1bd3c60540825a
Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
4 years agoVerify INS functions using connmanctl 10/231110/4 submit/tizen/20200422.012623
hyunuk.tak [Fri, 17 Apr 2020 08:32:01 +0000 (17:32 +0900)]
Verify INS functions using connmanctl

Change-Id: I498fac295defe24eab8e3d23c6e0864bfda8fd86
Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
4 years agoAdd intelligent Network Selection 75/229975/9 accepted/tizen/unified/20200417.152700 submit/tizen/20200417.010643
hyunuk.tak [Tue, 7 Apr 2020 03:57:45 +0000 (12:57 +0900)]
Add intelligent Network Selection

Change-Id: I049207e7d662f657ca21a4046be953f8f33bbd10
Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
4 years agoFix a problem where the full scan is executed twice in succession 71/226071/1 submit/tizen/20200306.121455
Jaehyun Kim [Wed, 26 Feb 2020 11:03:16 +0000 (20:03 +0900)]
Fix a problem where the full scan is executed twice in succession

Change-Id: I1f8a7ee437a6803e6857a3f1d95a964f999218f9
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoiptables: Fix memory leak 99/225099/1 accepted/tizen/unified/20200227.121046 submit/tizen/20200220.041614 submit/tizen/20200227.012332
Jaehyun Kim [Mon, 17 Feb 2020 09:22:30 +0000 (18:22 +0900)]
iptables: Fix memory leak

Change-Id: I2f5dd43703af7583d18a7be8fc10ae0e99d402d5
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agogsupplicant: Fix memory leak 71/224271/1 accepted/tizen/unified/20200213.121529 submit/tizen/20200212.122721
Jaehyun Kim [Fri, 7 Feb 2020 09:18:41 +0000 (18:18 +0900)]
gsupplicant: Fix memory leak

Change-Id: I6c8b8e67dc8fc32f744e2cf715ea383745ec0a93
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoRemove useless code 69/224269/1
Jaehyun Kim [Fri, 7 Feb 2020 08:58:36 +0000 (17:58 +0900)]
Remove useless code

Change-Id: I84e0cf1eee2ab86360adf2920dac1181e91b88b5
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoUpdate time when Auto Time Update event is received. 66/223166/1
Niraj Kumar Goit [Thu, 23 Jan 2020 13:58:27 +0000 (19:28 +0530)]
Update time when Auto Time Update event is received.

When Auto Time Update event is received, update the
system time although default service is not changed.

Change-Id: I205dab72879cf54e0aa31cecd0826d9c8b63736c
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
4 years agoFix to handle scan events initiated by wpa_supplicant 82/218982/3 accepted/tizen/unified/20191205.091332 submit/tizen/20191204.124930 submit/tizen/20200203.052118
Jaehyun Kim [Fri, 29 Nov 2019 08:11:46 +0000 (17:11 +0900)]
Fix to handle scan events initiated by wpa_supplicant

Change-Id: I2c247dd447a569642f19ff984fb9b318cceb676c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
4 years agoMerge "wifi: Fix derefrencing of NULL pointer" into tizen accepted/tizen/unified/20191129.033505 submit/tizen/20191128.114002
Jaehyun Kim [Thu, 28 Nov 2019 11:37:25 +0000 (11:37 +0000)]
Merge "wifi: Fix derefrencing of NULL pointer" into tizen

4 years agoMerge "Remove TIZEN_EXT for patch accepted by upstream community." into tizen
Jaehyun Kim [Thu, 28 Nov 2019 11:36:54 +0000 (11:36 +0000)]
Merge "Remove TIZEN_EXT for patch accepted by upstream community." into tizen

4 years agowifi: Fix derefrencing of NULL pointer 92/218392/2
Jaehyun Kim [Fri, 22 Nov 2019 02:18:11 +0000 (11:18 +0900)]
wifi: Fix derefrencing of NULL pointer

In some cases wifi->autoscan is NULL which leads to crash

Change-Id: I44d6005bcc1972aaa8f347529d7f8ac6ad22b8e3
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoMerge "[connman] Manage the MAX saved wireless profiles." into tizen accepted/tizen/unified/20191108.065921 submit/tizen/20191106.105409
Jaehyun Kim [Wed, 6 Nov 2019 10:52:07 +0000 (10:52 +0000)]
Merge "[connman] Manage the MAX saved wireless profiles." into tizen

5 years agoRemove TIZEN_EXT for patch accepted by upstream community. 37/216837/1
Nishant Chaprana [Mon, 4 Nov 2019 02:06:02 +0000 (07:36 +0530)]
Remove TIZEN_EXT for patch accepted by upstream community.

link: https://git.kernel.org/pub/scm/network/connman/connman.git/commit/?id=2974287df58bb8b018c7fe6e83d4c5bac5411a47
Change-Id: I5f51ef0348af7a5a72f799c7e2e3646c5a680536
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoFix Tizen alarm dbus interface parameter 67/216367/2 accepted/tizen_5.5_unified accepted/tizen_5.5_unified_mobile_hotfix accepted/tizen_5.5_unified_wearable_hotfix tizen_5.5_mobile_hotfix tizen_5.5_tv tizen_5.5_wearable_hotfix accepted/tizen/5.5/unified/20191031.010036 accepted/tizen/5.5/unified/mobile/hotfix/20201027.062320 accepted/tizen/5.5/unified/wearable/hotfix/20201027.102538 accepted/tizen/unified/20191024.044128 submit/tizen/20191024.043646 submit/tizen_5.5/20191031.000006 submit/tizen_5.5_mobile_hotfix/20201026.185106 submit/tizen_5.5_wearable_hotfix/20201026.184306 tizen_5.5.m2_release
Semun Lee [Thu, 24 Oct 2019 04:15:58 +0000 (13:15 +0900)]
Fix Tizen alarm dbus interface parameter

alarm uses time values as 64bit integer

Change-Id: Ifc000094da6f3e5d78ea60c144b681284e06cf69
Signed-off-by: Semun Lee <semun.lee@samsung.com>
5 years ago[connman] Manage the MAX saved wireless profiles. 75/215775/1
Niraj Kumar Goit [Tue, 15 Oct 2019 13:55:40 +0000 (19:25 +0530)]
[connman] Manage the MAX saved wireless profiles.

If the number of saved profiles exceed 200, remove the
oldest profile in the list.

Change-Id: I492cb3b5480104a59dcb58499da3bc05be3ebd05
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoMerge "Use system hostname first" into tizen accepted/tizen/unified/20191022.150300 submit/tizen/20191014.125724 submit/tizen/20191016.060650 submit/tizen/20191017.072410 submit/tizen/20191021.013541 submit/tizen/20191022.003657
Jaehyun Kim [Mon, 14 Oct 2019 12:54:50 +0000 (12:54 +0000)]
Merge "Use system hostname first" into tizen

5 years agoMerge "Try to auto-connect with favorite service before full channel scan" into tizen
Jaehyun Kim [Mon, 14 Oct 2019 12:53:54 +0000 (12:53 +0000)]
Merge "Try to auto-connect with favorite service before full channel scan" into tizen

5 years agoUse system hostname first 16/215716/2
Jaehyun Kim [Mon, 14 Oct 2019 12:13:51 +0000 (21:13 +0900)]
Use system hostname first

Change-Id: If1a518bda6824919e46eca5d051bb27058fb385c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoTry to auto-connect with favorite service before full channel scan 99/215599/1
hyunuk.tak [Fri, 11 Oct 2019 08:26:34 +0000 (17:26 +0900)]
Try to auto-connect with favorite service before full channel scan

Change-Id: Ia8027c0acf87c3bf2268fa0fc81fa15f8994241c
Signed-off-by: hyunuk.tak <hyunuk.tak@samsung.com>
5 years agoExtract strength as int32 in SignalPoll method_call's reply 84/215584/1 submit/tizen/20191011.090452
Nishant Chaprana [Fri, 11 Oct 2019 06:30:56 +0000 (12:00 +0530)]
Extract strength as int32 in SignalPoll method_call's reply

WPA Supplicant sends "rssi" as int32 in SignalPoll's method_call reply.
So strength should be int32 instead of unsigned char variable.

========================
method call time=1570774928.393859 sender=:1.24 -> destination=fi.w1.wpa_supplicant1 serial=364 path=/fi/w1/wpa_supplicant1/Interfaces/0; interface=fi.w1.wpa_supplicant1.Interface; member=SignalPoll
method return time=1570774928.395629 sender=:1.47 -> destination=:1.24 serial=327 reply_serial=364
   variant       array [
         dict entry(
            string "rssi"
            variant                int32 -60
         )
         dict entry(
            string "linkspeed"
            variant                int32 24
         )
         dict entry(
            string "noise"
            variant                int32 9999
         )
         dict entry(
            string "frequency"
            variant                uint32 2452
         )
      ]
========================

Change-Id: I23d873bf0c5560cbfaee9ef9bd78fe134f4dba93
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoMerge "Change g_waring to g_message" into tizen accepted/tizen/unified/20191011.015521 submit/tizen/20191008.031603 submit/tizen/20191008.104158 submit/tizen/20191010.075458
Jaehyun Kim [Tue, 8 Oct 2019 01:51:45 +0000 (01:51 +0000)]
Merge "Change g_waring to g_message" into tizen

5 years agoMerge "Remove unwanted NULL check for service in append_properties()" into tizen
Jaehyun Kim [Tue, 8 Oct 2019 01:22:58 +0000 (01:22 +0000)]
Merge "Remove unwanted NULL check for service in append_properties()" into tizen

5 years agoMerge "[Fix] Dereference after free in sta_remove_callback()" into tizen
Jaehyun Kim [Tue, 8 Oct 2019 00:43:00 +0000 (00:43 +0000)]
Merge "[Fix] Dereference after free in sta_remove_callback()" into tizen

5 years agoAdded an option in main.conf to set global DNS. 12/214912/2
Niraj Kumar Goit [Fri, 27 Sep 2019 10:35:24 +0000 (16:05 +0530)]
Added an option in main.conf to set global DNS.

Change-Id: I52f95964f82a88389e98592c64bf4820c1da5887
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoChange g_waring to g_message 39/215339/1
INSUN PYO [Mon, 7 Oct 2019 06:43:53 +0000 (15:43 +0900)]
Change g_waring to g_message

0  0xb6ac8dc4 in raise () from /lib/libc.so.6
1  0xb6d7d774 in g_logv () from /lib/libglib-2.0.so.0
2  0xb6d7d824 in g_log () from /lib/libglib-2.0.so.0
3  0xb6e9cb86 in interface_create_result (error=0xb6ef739c "net.connman.Error.OperationAborted", iter=0x0, user_data=0xb7378bd0) at gsupplicant/supplicant.c:4875
4  0xb6ea3796 in supplicant_dbus_method_call_cancel_all (caller=caller@entry=0x0) at gsupplicant/dbus.c:451
5  0xb6ea20c2 in g_supplicant_interface_cancel (interface=0x0) at gsupplicant/supplicant.c:4581
6  0xb6e9a61c in wifi_remove (device=0xb7377e80) at plugins/wifi.c:1611
7  0xb6eb0f06 in remove_device (device=device@entry=0xb7377e80) at src/device.c:326
8  0xb6eb15a8 in connman_device_unregister (device=device@entry=0xb7377e80) at src/device.c:1013
9  0xb6ec93d4 in detect_dellink (type=<optimized out>, index=8, flags=<optimized out>, change=<optimized out>) at src/detect.c:105
10 0xb6ed386c in process_dellink (bytes=452, msg=<optimized out>, change=4294967295, flags=36866, index=8, type=1) at src/rtnl.c:626
11 rtnl_dellink (hdr=0xbef16b1c) at src/rtnl.c:1080
12 rtnl_message (len=476, buf=0xbef16b1c) at src/rtnl.c:1557
13 netlink_event (chan=<optimized out>, cond=<optimized out>, data=<optimized out>) at src/rtnl.c:1614
14 0xb6d76654 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
15 0xb6d769e4 in ?? () from /lib/libglib-2.0.so.0
16 0xb6d76d44 in g_main_loop_run () from /lib/libglib-2.0.so.0
17 0xb6eaef6e in main (argc=<optimized out>, argv=<optimized out>) at src/main.c:953

Change-Id: Ic2280d26e288daf031572f868e5e9efa588570f4

5 years agoRemove unwanted NULL check for service in append_properties() 03/214903/2
Nishant Chaprana [Fri, 27 Sep 2019 09:51:16 +0000 (15:21 +0530)]
Remove unwanted NULL check for service in append_properties()

Description: The service will be always allocated when append_properties()
is called, so this NULL check is not required.
This NULL check generates SVACE warning which is actually a FALSE alarm.

Change-Id: I9b3a15529f6614cb375b8fb7ec656a3c44eeb180
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years ago[Fix] Dereference after free in sta_remove_callback() 96/214896/3
Nishant Chaprana [Fri, 27 Sep 2019 09:40:59 +0000 (15:10 +0530)]
[Fix] Dereference after free in sta_remove_callback()

Change-Id: I0e3e98f588ea186c514090a86a1a5a9d78e10420
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoRemove Wi-Fi device reference on wifi_disable when wifi is scanning 28/215028/2 accepted/tizen/unified/20191007.234805 submit/tizen/20191001.114836
Yu [Tue, 1 Oct 2019 05:44:11 +0000 (14:44 +0900)]
Remove Wi-Fi device reference on wifi_disable when wifi is scanning

Description: Sometimes Wi-Fi device reference didn't set to zero
when Wi-Fi is powered off like below.

src/device.c:connman_device_ref_debug() 0xb7fd8ae0 ref 2 by plugins/wifi.c:1434:wifi_probe()
src/device.c:connman_device_ref_debug() 0xb7fd8ae0 ref 3 by plugins/wifi.c:3183:wifi_scan()
src/device.c:connman_device_ref_debug() 0xb7fd8ae0 ref 4 by plugins/wifi.c:2313:start_autoscan()
src/device.c:connman_device_unref_debug() 0xb7fd8ae0 ref 3 by plugins/wifi.c:1500:reset_autoscan()
src/device.c:connman_device_unref_debug() 0xb7fd8ae0 ref 2 by plugins/wifi.c:1606:wifi_remove()
src/device.c:connman_device_unref_debug() 0xb7fd8ae0 ref 1 by src/detect.c:106:detect_dellink()

src/device.c:connman_device_ref_debug() 0xb7fd8ae0 ref 2 by plugins/wifi.c:1434:wifi_probe()
src/device.c:connman_device_ref_debug() 0xb7fcce88 ref 2 by plugins/wifi.c:1434:wifi_probe()
src/device.c:connman_device_unref_debug() 0xb7fcce88 ref 1 by plugins/wifi.c:1606:wifi_remove()
src/device.c:connman_device_unref_debug() 0xb7fcce88 ref 0 by src/detect.c:106:detect_dellink()

Change-Id: I52783152a5dd581d1af072aa5f3a0db92e8d622a
Signed-off-by: Yu jiung <jiung.yu@samsung.com>
5 years agoAdd DPP service based on configuration file 93/213293/9 submit/tizen/20190927.130602
Yu [Wed, 4 Sep 2019 04:43:22 +0000 (13:43 +0900)]
Add DPP service based on configuration file

Description: This is incomplete solution becase there's
no defined way to connect to DPP AP for upstream connman
for current patch

Change-Id: Ia6a3188e2826708c2123d209249d8b59fb5a42dc
Signed-off-by: Yu jiung <jiung.yu@samsung.com>
5 years agoAdded support to enable/disable Auto-IP option. 07/214507/2 accepted/tizen/unified/20190926.065658 submit/tizen/20190924.065941 submit/tizen/20190925.080914
Niraj Kumar Goit [Mon, 23 Sep 2019 10:15:33 +0000 (15:45 +0530)]
Added support to enable/disable Auto-IP option.

Added support to enable/disable Auto-IP option using main.conf

Change-Id: Iea1cae5a28681a90a5f79735c7374791a227feb7
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoFixed dbus rules for connman-vpn-dbus.conf 33/214333/1 accepted/tizen/unified/20190923.110259 submit/tizen/20190923.043320
Nishant Chaprana [Fri, 20 Sep 2019 09:47:57 +0000 (15:17 +0530)]
Fixed dbus rules for connman-vpn-dbus.conf

Change-Id: Iaa437db1f9408f34f4f95ac47bbc2a2da49b2779
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoImported Upstream version 1.37 66/214066/2 submit/tizen/20190920.082459
Nishant Chaprana [Tue, 17 Sep 2019 13:30:55 +0000 (19:00 +0530)]
Imported Upstream version 1.37

Change-Id: Idb47c1ddbedc9f97181b8e9a5eeac04ddd832a2c
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoMerge "Emit Service PropertyChanged when ConnectReason and DisconnectionRequested... accepted/tizen/unified/20190911.111656 submit/tizen/20190910.081214
Jaehyun Kim [Tue, 10 Sep 2019 08:11:13 +0000 (08:11 +0000)]
Merge "Emit Service PropertyChanged when ConnectReason and DisconnectionRequested changes" into tizen

5 years agoMerge "Update RSSI/Strength of connected service using SignalPoll event" into tizen
Jaehyun Kim [Tue, 10 Sep 2019 08:08:14 +0000 (08:08 +0000)]
Merge "Update RSSI/Strength of connected service using SignalPoll event" into tizen

5 years agoEmit Service PropertyChanged when ConnectReason and DisconnectionRequested changes 56/213556/1
Nishant Chaprana [Fri, 6 Sep 2019 15:22:47 +0000 (20:52 +0530)]
Emit Service PropertyChanged when ConnectReason and DisconnectionRequested changes

Description: The properties perform below tasks:-
1. ConnectReason: To identify whether connection was an autoconnection or user initiated.
2. DisconnectionRequested: To identify whether disconnection was user initiated or not.

Change-Id: I2ba4fc4637673571745517cdc33fc3a6d6367953
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoFixed invalid state transitions 60/213360/1 accepted/tizen/unified/20190909.010911 submit/tizen/20190906.055938
Jaehyun Kim [Wed, 4 Sep 2019 11:52:00 +0000 (20:52 +0900)]
Fixed invalid state transitions

Fixed the case where the ConnMan is changed to Idle state without going through Disconnect state in Connected state.
* Disconnect state indicates that it is going to terminate the current connection and will return to the Idle state.

Change-Id: I81becdd043d599df4257d30c94ce2a2038f72b2d
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoUpdate RSSI/Strength of connected service using SignalPoll event 33/205233/3
Nishant Chaprana [Tue, 30 Apr 2019 12:22:29 +0000 (17:52 +0530)]
Update RSSI/Strength of connected service using SignalPoll event

This patch reduced the SignalPoll monitor from 30 second to 10 second frequency.
This patch also extracts already available parameter strength/RSSI in SignalPoll
and update connected service's RSSI/Strength accordingly.

Change-Id: Ie9bbb21bf50ad0b8c72e3ca2fc9f7f6500c77f23
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoSort hidden profiles based on modified time. 58/212758/1
Niraj Kumar Goit [Mon, 26 Aug 2019 12:00:39 +0000 (17:30 +0530)]
Sort hidden profiles based on modified time.

When there are multiple hidden profiles stored in connman, sort
hidden profiles based on modified time (latest on top) and then
send scan request.

Change-Id: Ib27a31db94b4fafe9521414ab19702f08f5df783
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoMerge "Remove DefaultDependencies=no at connman.service" into tizen
Jaehyun Kim [Mon, 19 Aug 2019 06:41:33 +0000 (06:41 +0000)]
Merge "Remove DefaultDependencies=no at connman.service" into tizen

5 years agoRemove duplicate dependency with implicit dependencies at "Type=dbus" 85/211585/2 accepted/tizen/unified/20190818.224606 submit/tizen/20190816.113014
INSUN PYO [Wed, 7 Aug 2019 02:44:29 +0000 (11:44 +0900)]
Remove duplicate dependency with implicit dependencies at "Type=dbus"

Refs: https://www.freedesktop.org/software/systemd/man/systemd.service.html
 - Services with Type=dbus set automatically acquire dependencies of type Requires= and After= on dbus.socket.

Change-Id: Ic6009027222e293f8525a6b4a97512d7580be3f0

5 years agoAdd support to find stored Hidden AP when it's channel is changed 30/211530/1 submit/tizen/20190807.124141
Jaehyun Kim [Tue, 6 Aug 2019 07:40:26 +0000 (16:40 +0900)]
Add support to find stored Hidden AP when it's channel is changed

Change-Id: Ideb03d497be9654f6b03fcd289a0b30aba42b189
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoAdd an option for gateway timeserver handling 57/211257/1 submit/tizen/20190802.071744
Jaehyun Kim [Wed, 31 Jul 2019 13:45:54 +0000 (22:45 +0900)]
Add an option for gateway timeserver handling

Change-Id: I19f09647b7471f146adb95bc7e81fd9ab11f18ac
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoMerge "Add OWE security mode support" into tizen submit/tizen/20190729.091802 submit/tizen/20190731.014248
Jaehyun Kim [Mon, 29 Jul 2019 08:58:04 +0000 (08:58 +0000)]
Merge "Add OWE security mode support" into tizen

5 years agoMerge "Refactoring of scan for stored hidden profiles." into tizen
Jaehyun Kim [Fri, 26 Jul 2019 12:22:49 +0000 (12:22 +0000)]
Merge "Refactoring of scan for stored hidden profiles." into tizen

5 years agoDo not validate the passphrase for the SAE security type when it is encrypted. 79/210879/1 submit/tizen/20190726.063122
Jaehyun Kim [Thu, 25 Jul 2019 12:58:47 +0000 (21:58 +0900)]
Do not validate the passphrase for the SAE security type when it is encrypted.

Change-Id: Ibd82d445a8c0bd80a9b0804dd3d8b639797f8cb2
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoMerge "Added support to get AP hidden status." into tizen
Jaehyun Kim [Thu, 25 Jul 2019 12:34:33 +0000 (12:34 +0000)]
Merge "Added support to get AP hidden status." into tizen

5 years agoMerge "Delete meaningless configuration" into tizen
Jaehyun Kim [Thu, 25 Jul 2019 12:32:22 +0000 (12:32 +0000)]
Merge "Delete meaningless configuration" into tizen

5 years agoAdded support to get AP hidden status. 85/210185/2
Niraj Kumar Goit [Tue, 16 Jul 2019 11:20:22 +0000 (16:50 +0530)]
Added support to get AP hidden status.

Change-Id: Ib8014d9ff53d896a12d0bf985168b7df589d9f22
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoAdd OWE security mode support 10/210810/3
Yu [Thu, 25 Jul 2019 04:24:57 +0000 (13:24 +0900)]
Add OWE security mode support

Change-Id: I03ab90b8ab78e489d1ef70fbec57f10576860a57
Signed-off-by: Yu jiung <jiung.yu@samsung.com>
5 years agoRemove unnecessary setting 55/210655/1
INSUN PYO [Tue, 23 Jul 2019 11:17:53 +0000 (20:17 +0900)]
Remove unnecessary setting

Service and Socket unit has an implicit dependencies.

Refre: https://www.freedesktop.org/software/systemd/man/systemd.socket.html
"Socket units automatically gain a Before= dependency on the service units they activate."

Change-Id: I97710fb27fd3294332283a8bffde0d3765b4428e

5 years agoRemove DefaultDependencies=no at connman.service 18/210218/1
INSUN PYO [Wed, 17 Jul 2019 04:29:12 +0000 (13:29 +0900)]
Remove DefaultDependencies=no at connman.service

net-config.service has "After=net-config.service" dependency.
But net-config.service don't have DefaultDependencies=no.

So "DefaultDependencies=no" does not have any effect on connman.service, but instead it is confusing.

Change-Id: I6a3c78f18c3029314c2a8c0e6b8c72e65c868fe8

5 years agoDelete meaningless configuration 95/209495/2
INSUN PYO [Mon, 8 Jul 2019 10:02:25 +0000 (19:02 +0900)]
Delete meaningless configuration

Change-Id: Ida02a51bc1efe14b8d271e27898b3bd0d105797b

5 years agoImported Upstream version 1.37 02/209302/1 upstream/1.37
Nishant Chaprana [Thu, 4 Jul 2019 12:11:09 +0000 (17:41 +0530)]
Imported Upstream version 1.37

Change-Id: Ib5957e7ee3a9315ee86a331189bc3e9e71751ee8
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoMerge "Change the config value of the "FreeBind=" ("true" -> "yes")" into tizen accepted/tizen/unified/20190628.120630 submit/tizen/20190628.060134
Jaehyun Kim [Fri, 28 Jun 2019 05:59:03 +0000 (05:59 +0000)]
Merge "Change the config value of the "FreeBind=" ("true" -> "yes")" into tizen

5 years agoAppend disconnect reason code in case of invalid key. 99/208599/1
Niraj Kumar Goit [Wed, 26 Jun 2019 08:02:17 +0000 (13:32 +0530)]
Append disconnect reason code in case of invalid key.

Change-Id: Ie95d9be974d685f0601b2a6592c5f2d45e88fdd7
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoChange the config value of the "FreeBind=" ("true" -> "yes") 43/208543/1
INSUN PYO [Wed, 26 Jun 2019 00:54:33 +0000 (09:54 +0900)]
Change the config value of the "FreeBind=" ("true" -> "yes")

Change-Id: I5cbc48dfe7ab4f4402d04fdb5ebba1d220e457a6

5 years agoAdded support of WPA3-SAE security mode. 84/207984/2 accepted/tizen/unified/20190624.075215 submit/tizen/20190621.094817
Niraj Kumar Goit [Thu, 30 May 2019 10:43:20 +0000 (16:13 +0530)]
Added support of WPA3-SAE security mode.

Change-Id: I8612c52dc0cc078459fa19aa8a639597f070b293
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoFixed to prevent bssid corruption 31/207731/2 accepted/tizen/unified/20190617.061745 submit/tizen/20190614.050629
Jaehyun Kim [Tue, 11 Jun 2019 12:55:14 +0000 (21:55 +0900)]
Fixed to prevent bssid corruption

Change-Id: I26b9d81fad917939750b42c893ea5e44824ba270
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoImprove support of Multiple same SSIDs including band steering. 85/206585/3 accepted/tizen/unified/20190611.110358 submit/tizen/20190611.082034
Jaehyun Kim [Tue, 21 May 2019 13:08:20 +0000 (22:08 +0900)]
Improve support of Multiple same SSIDs including band steering.

1. Supports up to 8 BSSIDs per each SSID
2. Attempt to connect only once per each BSSID
3. Sorted by signal strength and try to connect in sorted order
4. Sets the correct frequency for each bssid.

Change-Id: I668fff29f2df99b2e5f637a39b5c70da84f8ee1c
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoAdded support to get maximum scan SSIDs. 83/196183/2
Niraj Kumar Goit [Mon, 24 Dec 2018 12:20:27 +0000 (17:50 +0530)]
Added support to get maximum scan SSIDs.

Added support to get Max number of SSIDs scan supported by wlan chipset.

Change-Id: If4cbc07f6937718fab123600a962179b3adbc081
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoFixed build issue when built with --enable-tizen-ext-wifi-mesh option 53/206653/1 accepted/tizen/unified/20190605.215650 submit/tizen/20190604.083831
Nishant Chaprana [Wed, 22 May 2019 16:48:39 +0000 (22:18 +0530)]
Fixed build issue when built with --enable-tizen-ext-wifi-mesh option

Below error comes when compiled with --enable-tizen-ext-wifi-mesh option:-

[  168s] src/mesh-netlink.c:29:31: fatal error: netlink/genl/genl.h: No such file or directory
[  168s]  #include <netlink/genl/genl.h>
[  168s]                                ^
[  168s] compilation terminated.
[  168s] Makefile:4430: recipe for target 'src/src_connmand-mesh-netlink.o' failed
[  168s] make[1]: *** [src/src_connmand-mesh-netlink.o] Error 1
[  168s] make[1]: *** Waiting for unfinished jobs....
[  168s]   CC       gweb/vpn_connman_vpnd-gionotls.o
[  169s] Makefile:1815: recipe for target 'all' failed
[  169s] make: *** [all] Error 2

Change-Id: Ib62a65cc0dbecca86a6ae9d67bfae880fcb30bbd
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoRefactoring of scan for stored hidden profiles. 87/206387/1
Niraj Kumar Goit [Thu, 16 May 2019 06:04:40 +0000 (11:34 +0530)]
Refactoring of scan for stored hidden profiles.

To improve scan performance, when there are hidden profiles stored
in connman and user request for scan, send ScanDone signal after
scanning maximum scan ssids supported by driver instead of sending signal
after scanning all the stored hidden profiles.
Similarly in next scan request, perform scanning (maximum scan ssids) from
remaining hidden profiles and send ScanDone signal.

Change-Id: I6195668c59b0a75bd0e0097ab6e6b7e3d33aae38
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoUse libnl-3.0 in place of libnl-2.0 44/205244/1 submit/tizen/20190520.082305 submit/tizen/20190520.082357
Nishant Chaprana [Wed, 1 May 2019 05:16:30 +0000 (10:46 +0530)]
Use libnl-3.0 in place of libnl-2.0

Change-Id: Ic654296e6494b587d7aaf1f888715b59ddee1bf4
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
5 years agoAdded support of Multiple same SSIDs including band steering. 24/202524/8 accepted/tizen/unified/20190410.061801 submit/tizen/20190409.131053
Niraj Kumar Goit [Fri, 29 Mar 2019 10:35:49 +0000 (16:05 +0530)]
Added support of Multiple same SSIDs including band steering.

When there are multiple APs with the same SSID and security,
this patch support below features:
1. If AP does not respond to probe request during connection
procedure, connman tries to connect with the next available BSSID
before sending disconnected event to application.

2. If connection with AP is failed during association due to
ASSOC_REJECT, connman tries to connect with the next available BSSID
before sending disconnected event to application.

Change-Id: Ie80939bd013a12b9c88e91a1fd5a05fbb57c1833
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years ago[Upstream]gsupplicant: Switch to different BSSID of same SSID in case of signal bss... 23/202523/1
Niraj Kumar Goit [Fri, 29 Mar 2019 05:24:53 +0000 (10:54 +0530)]
[Upstream]gsupplicant: Switch to different BSSID of same SSID in case of signal bss removed

Teach ConnMan to select the next BSSID when two APs (e.g. 2.4 GHz and
5 GHz) with the same SSID and security configuration are available.

Currently when one AP disappears ConnMan will retry to connect to the
old AP point even though there is another matching BSSID available.

So when wpa_supplicant sends a remove signal we find a matching BSSID
and use it even when it's not from the same AP.
https://git.kernel.org/pub/scm/network/connman/connman.git/commit/?id=c1debcac758ef1f76a788225679003e2e67d9fdf

Change-Id: Ic5ce438addc823ebd0c6bedd2a974f559b33ae25
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
5 years agoRemove the timer for MaxSpeed polling when the interface is removed 83/200083/3 accepted/tizen/unified/20190307.230901 submit/tizen/20190222.021924 submit/tizen/20190226.010652
Jaehyun Kim [Tue, 19 Feb 2019 04:41:22 +0000 (13:41 +0900)]
Remove the timer for MaxSpeed polling when the interface is removed

Change-Id: I1ed15eb5815c4e7e94c2d26a7f6358f15b2b68ef
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoFix the dangling pointer(network) inside autosignalpoll_timeout(). 46/200046/2 accepted/tizen/unified/20190219.154224 submit/tizen/20190218.125443
Lokesh [Mon, 18 Feb 2019 10:03:04 +0000 (15:33 +0530)]
Fix the dangling pointer(network) inside autosignalpoll_timeout().

Change-Id: I47d74342b861db29c2b36094539a84b73dce7e55
Signed-off-by: Lokesh <l.kasana@samsung.com>
5 years agoDisable backtrace option 89/198989/1 accepted/tizen/unified/20190218.064008 submit/tizen/20190201.002733 submit/tizen/20190208.055857 submit/tizen/20190211.022839 submit/tizen/20190215.123149
Jaehyun Kim [Thu, 31 Jan 2019 13:08:15 +0000 (22:08 +0900)]
Disable backtrace option

Change-Id: Ie53230568c290b1449e145e9c77f36cfc1af8a03
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoFixed SVACE issues 53/198453/1 accepted/tizen/unified/20190128.061809 submit/tizen/20190125.015829
Jaehyun Kim [Thu, 24 Jan 2019 13:24:50 +0000 (22:24 +0900)]
Fixed SVACE issues

Change-Id: I84e9c9a7719e017892d4f353cf141901ca94beb8
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoIncrease MAX_LOG_COUNT to 15 83/198183/1 submit/tizen/20190122.080702
Jaehyun Kim [Tue, 22 Jan 2019 06:56:35 +0000 (15:56 +0900)]
Increase MAX_LOG_COUNT to 15

Change-Id: I9558c05c45ec0327e15377efb61f3f19592e75af
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
5 years agoAdd code for handling NULL exception 16/196216/1 accepted/tizen/unified/20181227.102126 submit/tizen/20181227.001142
Seonah Moon [Wed, 26 Dec 2018 08:44:54 +0000 (17:44 +0900)]
Add code for handling NULL exception

Change-Id: I5b3ae0a5305db81aeba848e5d7353ca44522f35c

5 years agoMerge "Copy vsie_list before remove old list" into tizen accepted/tizen/unified/20181219.063352 submit/tizen/20181218.125545
Jaehyun Kim [Tue, 18 Dec 2018 02:26:30 +0000 (02:26 +0000)]
Merge "Copy vsie_list before remove old list" into tizen

5 years agoMerge "[Upstream] Fix return value in error path." into tizen
Jaehyun Kim [Tue, 18 Dec 2018 02:25:30 +0000 (02:25 +0000)]
Merge "[Upstream] Fix return value in error path." into tizen

5 years agoCopy vsie_list before remove old list 19/195719/2
Seonah Moon [Mon, 17 Dec 2018 11:53:34 +0000 (20:53 +0900)]
Copy vsie_list before remove old list

Change-Id: Iec590090bbc87d3a2d573148929681abae5d8c02

5 years agoAdded dbus method to get whether 5Ghz band is supported 85/195385/4 accepted/tizen/unified/20181218.063104 submit/tizen/20181217.121131
Abhishek Sansanwal [Thu, 13 Dec 2018 05:21:58 +0000 (10:51 +0530)]
Added dbus method to get whether 5Ghz band is supported

Change-Id: Ib3b189615648a35aa876eab3e3f61c47ac0c1e68
Signed-off-by: Abhishek Sansanwal <abhishek.s94@samsung.com>
5 years ago[Upstream] Fix return value in error path. 02/195702/2
Niraj Kumar Goit [Wed, 12 Dec 2018 08:48:34 +0000 (14:18 +0530)]
[Upstream] Fix return value in error path.

Returning -1 in a function with bool as return value is the same as
returning true. Change to false to indicate error if inet_aton() fails.

Change-Id: I3dea40bc2506b1a2a0a65e7e838691fc3af957bd
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
6 years agoMerge "Add IEEE 802.11 protocol(b/g/n/a/ac) Modes of APs" into tizen accepted/tizen/unified/20181129.054222 submit/tizen/20181106.114249 submit/tizen/20181120.123835 submit/tizen/20181127.113629
Jaehyun Kim [Tue, 6 Nov 2018 10:38:29 +0000 (10:38 +0000)]
Merge "Add IEEE 802.11 protocol(b/g/n/a/ac) Modes of APs" into tizen

6 years agoMerge "[CONNMAN][Change AP's max speed logic]" into tizen
Jaehyun Kim [Tue, 6 Nov 2018 10:37:10 +0000 (10:37 +0000)]
Merge "[CONNMAN][Change AP's max speed logic]" into tizen

6 years agoAdd IEEE 802.11 protocol(b/g/n/a/ac) Modes of APs 13/189913/9
Milind Murhekar [Fri, 21 Sep 2018 14:06:20 +0000 (19:36 +0530)]
Add IEEE 802.11 protocol(b/g/n/a/ac) Modes of APs

This patch appends the IEEE 802.11b/g/n/a/ac PHY
protocol modes of scanned Access Points
using internal logic.

Following logic is used to determine WLAN HW protocol:-
1) If “Supported rates” is only till 11 Mbps, and frequency is in
2.4GHz band, then protocol is 802.11B.
2) If “Supported rates” is till 54Mbps or “Extended supported rates”
are present, and frequency is in 2.4GHz band, then protocol is 802.11G.
3) If “Supported rates” is only till 54 Mbps, frequency is in 5GHz
band , then protocol is 802.11A.
4) If “HT capabilities” is supported , then protocol is 802.11N.
5) If “HT capabilities” & “VHT” is supported and frequency is in 5 GHz
band, then protocol is 802.11AC.

Change-Id: I1156ef249cf4a8052a883d31da66788c7d2de22f

6 years ago[CONNMAN][Change AP's max speed logic] 63/189563/6
Mayank Haarit [Tue, 18 Sep 2018 14:43:57 +0000 (20:13 +0530)]
[CONNMAN][Change AP's max speed logic]

This patch changes the internal logic of getting
max speed from connected AP.

Change-Id: I7191a09f1d974f1158ce9440cfa6924feca61340
Signed-off-by: Mayank Haarit <mayank.h@samsung.com>
6 years agoAdded support to update EAP manual IP. 61/190161/1 submit/tizen/20181004.140159 submit/tizen/20181005.071134
Niraj Kumar Goit [Thu, 27 Sep 2018 11:48:05 +0000 (17:18 +0530)]
Added support to update EAP manual IP.

Added support to update EAP manual IP setting using
wifi_manager_update_ap()

Change-Id: Ifa331ec3b1e4bd95262f63698d32f65e6128518c
Signed-off-by: Niraj Kumar Goit <niraj.g@samsung.com>
6 years agoFixed null dereferencing 21/189621/1 accepted/tizen/5.0/unified/20181102.025128 accepted/tizen/unified/20180919.142036 submit/tizen/20180919.090201 submit/tizen_5.0/20181101.000006
Jaehyun Kim [Wed, 19 Sep 2018 08:39:04 +0000 (17:39 +0900)]
Fixed null dereferencing

Change-Id: I969a45edc0d4e16d61de0050466cd80c92c7c5e1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoDisable the changed default connection policy 27/189227/1 accepted/tizen/unified/20180917.041307 submit/tizen/20180914.105222
Jaehyun Kim [Fri, 14 Sep 2018 10:36:47 +0000 (19:36 +0900)]
Disable the changed default connection policy

Change-Id: I56071afe5fe303a977b791807089ec8c3786ceef
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoMerge "Online Check: Change default connection policy" into tizen
Jaehyun Kim [Fri, 14 Sep 2018 10:29:50 +0000 (10:29 +0000)]
Merge "Online Check: Change default connection policy" into tizen

6 years agoFixed 'incompatible pointer type' warning 47/189047/1 accepted/tizen/unified/20180914.073119 submit/tizen/20180913.042841
Jaehyun Kim [Thu, 13 Sep 2018 04:08:21 +0000 (13:08 +0900)]
Fixed 'incompatible pointer type' warning

Change-Id: If6a491f11ab73e2039d3194b8a02a24313fa78d7
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoFixed some build warnings 46/189046/1
Jaehyun Kim [Thu, 13 Sep 2018 03:57:48 +0000 (12:57 +0900)]
Fixed some build warnings

Change-Id: I09c0c02541a0f7cb469e009b53d87fccbed742e1
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoModified dbus config file permission 11/188811/1 accepted/tizen/unified/20180911.055444 submit/tizen/20180911.020851
Jaehyun Kim [Mon, 10 Sep 2018 12:39:40 +0000 (21:39 +0900)]
Modified dbus config file permission

Change-Id: I4d1a8560399fcfd726271682f6f26d68b1408bf5
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoMerge "Modified file permission" into tizen submit/tizen/20180904.035932 submit/tizen/20180910.020630
taesub.kim [Tue, 4 Sep 2018 03:57:51 +0000 (03:57 +0000)]
Merge "Modified file permission" into tizen

6 years ago[Wi-Fi Mesh] Added dbus privilege for method calls 34/188134/2 submit/tizen/20180903.045143 submit/tizen/20180904.001520
Nishant Chaprana [Fri, 31 Aug 2018 12:59:58 +0000 (18:29 +0530)]
[Wi-Fi Mesh] Added dbus privilege for method calls

Change-Id: I2f6b6233ac682959abd1221a61aaeffa5bdfdd63
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
6 years agoOnline Check: Change default connection policy 15/188115/2
Saurav Babu [Fri, 31 Aug 2018 09:40:24 +0000 (15:10 +0530)]
Online Check: Change default connection policy

 1. Modified the priority of default connection
 2. Disconnect the cellular when wifi state is online
 3. Added a dbus-api for downgrading the wifi state to ready
 4. Modified the connman_service_get_default_connection()

Change-Id: Ie062d86479a9bc80919ba7d0c168028f61a9c7be
Signed-off-by: Saurav Babu <saurav.babu@samsung.com>
6 years agoModified file permission 46/187746/1
taesub.kim [Tue, 28 Aug 2018 06:42:43 +0000 (15:42 +0900)]
Modified file permission

Change-Id: I519f531250371b30b3bc882046ac9dbc739a7836
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
6 years ago[connman] Added Tizen Wi-Fi Mesh 69/186569/10 submit/tizen/20180824.072908
Nishant Chaprana [Fri, 10 Aug 2018 11:11:37 +0000 (16:41 +0530)]
[connman] Added Tizen Wi-Fi Mesh

Change-Id: Iec2ec99fb7d4fc6d9c0539e5a9e7c903e1969580
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
6 years ago[Fix][icmpv6_recv] No need to free data using xs_cleanup(), data is already freed... 50/186850/1
Nishant Chaprana [Thu, 16 Aug 2018 04:19:38 +0000 (09:49 +0530)]
[Fix][icmpv6_recv] No need to free data using xs_cleanup(), data is already freed in icmpv6_event()

Change-Id: I19b028f5a93f7a4efbcf6e7c92113c363d7bb534
Signed-off-by: Nishant Chaprana <n.chaprana@samsung.com>
6 years agoRemove unnecessary rule in dbus.conf file 76/186076/2
taesub.kim [Tue, 7 Aug 2018 06:14:32 +0000 (15:14 +0900)]
Remove unnecessary rule in dbus.conf file

Change-Id: I89ab130e5451756d9e8df6e576836f036be0b5b4
Signed-off-by: Taesub Kim <taesub.kim@samsung.com>
6 years agoMerge "Fixed the EAP security issue" into tizen accepted/tizen/unified/20180808.063353 submit/tizen/20180807.023922 submit/tizen/20180807.222918
taesub kim [Wed, 1 Aug 2018 21:26:50 +0000 (21:26 +0000)]
Merge "Fixed the EAP security issue" into tizen

6 years agoFixed invalid memory access during connection 20/185320/1 accepted/tizen/unified/20180731.075043 submit/tizen/20180731.042150
Jaehyun Kim [Fri, 27 Jul 2018 12:45:51 +0000 (21:45 +0900)]
Fixed invalid memory access during connection

Change-Id: I10e219cdc4ea66f0e5e3208d1c9e505a63758607
Signed-off-by: Jaehyun Kim <jeik01.kim@samsung.com>
6 years agoFixed the EAP security issue 23/184723/2
Bhaskar Dutta [Fri, 20 Jul 2018 12:10:11 +0000 (17:40 +0530)]
Fixed the EAP security issue

Description :
1. App send anonymous identity and connect with EAP network.
   And connman store it inside corresponding network pointer.
2. Then if user disconnect that connection,forgetAP will be called.
   And connman does not clear last anonymous identity data for that service.
3. Next time when user again connect with same EAP network, but without anonymous identity.
   Then previous anonymous identity will be passwed to WPA suplicant. But blank anonymous identity should be treated.

Change-Id: I267bea4d394390e82351ae997229c69785ea6d6d
Signed-off-by: Bhaskar Dutta <bhaskar.d@samsung.com>