Hwankyu Jhun [Thu, 14 Dec 2023 00:42:59 +0000 (09:42 +0900)]
Reset retrying count while getting kick request
When getting the kick request from the application, amd resets
the retry_count value to 0.
Change-Id: I6d71c09965eb67c30a5d40b293dbf883a3adb233
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Wed, 13 Dec 2023 10:48:00 +0000 (19:48 +0900)]
Release version 1.67.22
Changes:
- Check app status before sending a request
- Fix crash issue
Change-Id: Ie6758076b838c89f18bbbf4c20c001e26da1c126
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Wed, 13 Dec 2023 10:42:05 +0000 (19:42 +0900)]
Fix crash issue
If the byte is empty, calling std::copy() makes a crash issue.
Change-Id: Ia786bb045159a9cf81d45d5d463a5bd4ff58ff86
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Wed, 13 Dec 2023 09:19:42 +0000 (18:19 +0900)]
Check app status before sending a request
Before sending a request(APP_RESUME_BY_PID or APP_PAUSE_BY_PID) to the running
application, amd checks whether the app status is dying or not.
If it's STATUS_DYING, amd does not send the request. In this case, the caller
process will get the error from amd.
Change-Id: I860aee5301688843a03d6cf2f33edd8301bb0fcb
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Wed, 13 Dec 2023 04:46:59 +0000 (13:46 +0900)]
Release version 1.67.21
Changes:
- Adjust coding style
- Fix an incorrect display lock state
Change-Id: I897d37907da9364d499d2b7454c8771b148b4b6b
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Wed, 13 Dec 2023 04:40:53 +0000 (13:40 +0900)]
Fix an incorrect display lock state
When calling Unlock within the timer callback, the timer value was not
initialized to 0. This causes the following issue where the lock remains locked
after being unlocked.
If there is no app using the boot sequence, display lock is not called.
Change-Id: Ia53e4aa5fd5e69f507285895ebd647e732328ee3
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Wed, 13 Dec 2023 04:07:28 +0000 (13:07 +0900)]
Adjust coding style
- Add a space before comparison operator
Change-Id: Ibbd68def6154346e070053c6e25953efacc09143
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Fri, 1 Dec 2023 07:08:47 +0000 (16:08 +0900)]
Release version 1.67.20
Changes:
- Modify boot manager
Change-Id: Icf5b22607b7b0222393fdcc32cb4725f7ff533f0
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Thu, 30 Nov 2023 10:44:55 +0000 (19:44 +0900)]
Modify boot manager
The following changes are made to onboot option of amd:
- Apps with onboot set are launched by the boot manager.
- Only apps with boot-sequence set are managed by the boot sequencer.
- Onboot apps will run as before when a package is installed.
- Apps with boot-sequence set will not run until a reboot occurs even if
the package is installed.
Change-Id: I35589a7195043251efb69157b178139e6d62319b
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Thu, 30 Nov 2023 06:59:00 +0000 (15:59 +0900)]
Release version 1.67.19
Changes:
- Fix a bug about restarting apps
Change-Id: I703dc61c13c29710bc8f01eda657ace71ab03494
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Thu, 30 Nov 2023 04:29:51 +0000 (13:29 +0900)]
Fix a bug about restarting apps
After updating the package, the application was not restarted by amd.
Because, if the application has the on-boot="true" option in
the tizen-manifest.xm, amd does not check whether the application is
able to restart or not.
If the api-version is greater than 7, amd must check whether the application
should be restarted or not.
This patch checks the api version to restart apps.
Change-Id: Ibfe8245782cd5b0d5b6dc3bd7eda3363379c85b7
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Changgyu Choi [Thu, 30 Nov 2023 02:09:51 +0000 (11:09 +0900)]
Release version 1.67.18
Changes:
- Adjust coding style of AppLifecycle
- Fix sort condition
Change-Id: I7ee74de54896f034dc0ca97b1f52146fac626151
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Thu, 30 Nov 2023 01:48:17 +0000 (10:48 +0900)]
Fix sort condition
Change-Id: Ia31f79cf645d9acae6c5f300b45ec8140a1bcd4a
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Hwankyu Jhun [Thu, 23 Nov 2023 07:23:00 +0000 (16:23 +0900)]
Adjust coding style of AppLifecycle
- Changes function names by using capital letters
- Improves readability by complementing log messages.
Change-Id: I290f86f11bcb5d62d7736c3a173b15943fcd7ab2
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Thu, 23 Nov 2023 00:02:57 +0000 (09:02 +0900)]
Release version 1.67.17
Changes:
- Fix duplicate execution problem
Change-Id: Idd86715e65120ca6f21fce561627a91ffc8759ba
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Wed, 22 Nov 2023 23:28:53 +0000 (08:28 +0900)]
Fix duplicate execution problem
When a new app is launched by receiving a request to execute it,
if the onboot feature is activated, the app process is duplicated.
This problem occurs because the CheckStatus() method does not properly handle
the confirmation of pending items.
The problem is fixed by modifying the socket option.
Change-Id: Icc4478766a25fdf34073dd331dc878478c577b58
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Mon, 20 Nov 2023 23:51:55 +0000 (08:51 +0900)]
Release version 1.67.16
Changes:
- Remove sending SIGABRT signal
Change-Id: I0e0df944f39c919b1cf9279454426f6fb80b0e24
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Mon, 20 Nov 2023 23:27:47 +0000 (08:27 +0900)]
Remove sending SIGABRT signal
On certain devices, the app process may be blocked because it
does not receive CPU resource allocation.
We remove the operation of sending SIGABRT from amd
and monitor whether the app calls the app_main function.
Change-Id: Id3d0632919226123c6ff7e98adb239ed3dd73517
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Changgyu Choi [Mon, 20 Nov 2023 03:51:32 +0000 (12:51 +0900)]
Release version 1.67.15
Changes:
- Revert "Remove setting the IsStart flag when receiving a startup signal"
Change-Id: I8439f92e2888301594da855979b313bf3d6cf2ca
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Mon, 20 Nov 2023 01:57:41 +0000 (10:57 +0900)]
Revert "Remove setting the IsStart flag when receiving a startup signal"
This reverts commit
89867461c651321e129d088eae77faaf21fa2b81.
Change-Id: If74f63ef0f1001b4186f49b12eb425227db355a5
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Hwankyu Jhun [Wed, 15 Nov 2023 01:40:44 +0000 (10:40 +0900)]
Release version 1.67.14
Changes:
- Remove setting the IsStart flag when receiving a startup signal
Change-Id: Ia90d620e91050d4ea5f62e0aecd3d478083e317b
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Changgyu Choi [Wed, 8 Nov 2023 07:21:08 +0000 (16:21 +0900)]
Remove setting the IsStart flag when receiving a startup signal
Rarely, after the launchpad sends a startup signal, it may be blocked
for a long time during the app execution process.
In this case, the process remains zombie for a long time.
This patch is for these ceses.
Change-Id: Ic7d884a0a2a785c3a8c5c10c3f17edd7eff746b1
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Hwankyu Jhun [Tue, 14 Nov 2023 00:46:56 +0000 (09:46 +0900)]
Release version 1.67.13
Changes:
- Change the method used in the compare function
- Add missing exception handling
- [Watchdog] Send the watchdog activation signal
Change-Id: I1801166efb6fb7ac883044a8f20dd1f4b773b855
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Changgyu Choi [Mon, 13 Nov 2023 04:12:53 +0000 (13:12 +0900)]
[Watchdog] Send the watchdog activation signal
When the watchdog option is 'enable-by-default', amd sends the watchdog
activation signal to the running application.
Change-Id: I2b99b9b62b593b44bb82a8662c069251ab086f68
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Mon, 13 Nov 2023 06:23:29 +0000 (15:23 +0900)]
Add missing exception handling
Change-Id: I531ecb00027485697953fd52fef23c7240f7e695
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Wed, 8 Nov 2023 05:01:52 +0000 (14:01 +0900)]
Change the method used in the compare function
__compare_app_status_for_sorting() needs only pid count.
This patch changes to get pid count method to _app_group_get_count().
Change-Id: Ibcc1592fb7d8fa01dd6560feb37de010b28a9df8
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Hwankyu Jhun [Wed, 8 Nov 2023 04:19:57 +0000 (13:19 +0900)]
Release version 1.67.12
Changes:
- Terminate sub app
Change-Id: Ia1ed81ac0f2b883e6b9f9d0ce80b96fa6b6d3b2a
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Wed, 8 Nov 2023 01:38:08 +0000 (10:38 +0900)]
Terminate sub app
If the leader process is terminated while executing an application,
amd should terminate the sub application.
And, when the application type is not a component-based application,
the process must be terminated even though the process does not handle
the termination request properly.
Change-Id: If06788d09dc22a6c16437a418ed23d7357da0826
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Changgyu Choi [Mon, 30 Oct 2023 04:28:54 +0000 (13:28 +0900)]
Release version 1.67.11
Changes:
- Modify startup timer
- Refactor amd_api_database
Change-Id: Ia6e2aad5e369d29a49f63e6ec208722650a8984e
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Thu, 19 Oct 2023 08:58:56 +0000 (17:58 +0900)]
Refactor amd_api_database
amd_api_database has been refactored to tizen_base::Database.
Change-Id: I06645732b9492e470dabf189f33f39e634019474
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Hwankyu Jhun [Mon, 30 Oct 2023 03:44:41 +0000 (12:44 +0900)]
Modify startup timer
The interval of the startup timer is changed to 10 seconds.
And, a member variable called delay_count_ is added to check if
the number of times has exceeded 6.
If the count is less than 6, amd prints the error log for debugging.
Change-Id: Iddca7dd9799339345fcf36e8e866207ce78129ba
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Changgyu Choi [Mon, 23 Oct 2023 09:27:34 +0000 (18:27 +0900)]
Release version 1.67.10
Changes:
- Fix restart contition
Change-Id: I1ed9fc9b175c59239d036737dcdb92da175c8859
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Mon, 23 Oct 2023 09:17:21 +0000 (18:17 +0900)]
Fix restart contition
If autorestart option is true, the value is "1".
Change-Id: I83fc46ccf3f4a1d398621ebdc83ac1650f262289
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Hwankyu Jhun [Thu, 19 Oct 2023 02:03:45 +0000 (11:03 +0900)]
Release version 1.67.9
Changes:
- Add MemoryLimit option to service file
- Modify log print
- Flush pending requests after sending sigkill signal
Change-Id: Ib6795faa6bedb01363f67b31f8aa49fb8496ed5d
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Thu, 19 Oct 2023 01:55:59 +0000 (10:55 +0900)]
Flush pending requests after sending sigkill signal
After sending SIGKILL signal to the runnint process, amd handles
pending requests.
Change-Id: Ide20caeaeb859967b988bc23fadd6d08305f5565
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Thu, 19 Oct 2023 01:16:29 +0000 (10:16 +0900)]
Modify log print
This patch changes the log format for printing the process ID information.
Change-Id: I9baccccc859b6e8813e07328ac1697bc88bd76ab
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Changgyu Choi [Tue, 17 Oct 2023 07:31:56 +0000 (16:31 +0900)]
Add MemoryLimit option to service file
This is for memory leak checking.
Change-Id: Iac2b9963ebc0f702615ba35625aa3f9386451c86
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Hwankyu Jhun [Thu, 12 Oct 2023 08:08:24 +0000 (17:08 +0900)]
Release version 1.67.8
Changes:
- Set blocking status when package is installing
Change-Id: If8892423bc132283a0734715153ed84c2e1f3f75
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Thu, 12 Oct 2023 07:18:26 +0000 (16:18 +0900)]
Set blocking status when package is installing
Currently, AMD tries to load the app info if the app info does not exist.
Unfortunately, the app info will be loaded even if the package is installing.
Before finishing the installation, the information is inserted to the database.
This patch is to prevent launching the application when the package is installing.
Change-Id: I63cc27987c49ba9cba350a89f24a1cd6c0f68e36
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Changgyu Choi [Wed, 11 Oct 2023 09:51:42 +0000 (18:51 +0900)]
Release version 1.67.7
Changes:
- Remove unnecessary using idler
- Fix typo
- Modify compilation options
- Add UpdateAppStatusDAO() method
Change-Id: Ie09f3aea64921d43b474cd8bb71e110045bfa8d2
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Wed, 11 Oct 2023 09:31:54 +0000 (18:31 +0900)]
Add UpdateAppStatusDAO() method
To update the starting flag on AppStatusDAO,
this api has been added on AppStatusManager.
Change-Id: I5474ecfb479bd70a50b60cc7ef10ed36e5f148d0
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Hwankyu Jhun [Wed, 11 Oct 2023 07:23:35 +0000 (16:23 +0900)]
Modify compilation options
The following options are added:
- Wl,-z,relro
- fstack-protector-strong
Change-Id: I57a9b91c5e4a8b2fa0c83cea879be50cdec51b26
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Wed, 11 Oct 2023 06:33:50 +0000 (15:33 +0900)]
Fix typo
The value must be "internal".
Change-Id: I2c62b13501e4bfac6efe6684bb7a2484a036efbe
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Tue, 10 Oct 2023 11:57:38 +0000 (20:57 +0900)]
Remove unnecessary using idler
In the cynara module, calling g_idle_add() with the RequestCb() is not
needed. This patch removes that.
Change-Id: Ic1c8ef8a418801cce3dfb1b3731ae430b2c4a475
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Tue, 10 Oct 2023 12:05:34 +0000 (21:05 +0900)]
Release version 1.67.6
Changes:
- Add log print for debugging
Change-Id: Ibdbe4956ecdb4c4aa2b4934144ce0e948a8d69f2
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Tue, 10 Oct 2023 11:54:04 +0000 (20:54 +0900)]
Add log print for debugging
To check idle state, this patch adds a log.
Change-Id: Ic62d25781431f09d77d23e9982261a79af941572
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Tue, 10 Oct 2023 11:15:23 +0000 (20:15 +0900)]
Release version 1.67.5
Changes:
- Boost up cynara thread
Change-Id: I710fe18b65f3138301a03ed7df29ad547b90cdc4
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Tue, 10 Oct 2023 10:25:19 +0000 (19:25 +0900)]
Boost up cynara thread
In some device, the cynara thread is very slow. It makes a launch failure issue.
This patch applies the cpu boost to the cynara thread of amd when amd needs
to check whether the caller has permissions or not.
Change-Id: Ice8632bc530f23259961f1f1d8d78b1c890277f3
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Changgyu Choi [Fri, 6 Oct 2023 07:09:08 +0000 (16:09 +0900)]
Release version 1.67.4
Changes:
- Add exception handling on DBWriter+
- Add calling AppStatusDao::UpdateAppStatus method on Update()
Change-Id: Icc62eadb671cd234f4dc4016a00d76fdcfe2f67d
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Fri, 6 Oct 2023 06:43:57 +0000 (15:43 +0900)]
Add calling AppStatusDao::UpdateAppStatus method on Update()
This is for sync issue of starting flag of a app_status with db.
Change-Id: I8d25c82b35d278cc9dd793abc337e0e5366970a1
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Fri, 6 Oct 2023 04:00:54 +0000 (13:00 +0900)]
Add exception handling on DBWriter+
Exceptions may occur when creating a Cursor object.
This patch handles these exceptions to prevent amd from abnormally terminating.
Change-Id: Ic4c7fe3a6dc0bb9dff38adc8d6c8e41a6f5bdd34
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Wed, 4 Oct 2023 07:11:44 +0000 (16:11 +0900)]
Release version 1.67.3
Changes:
- Send sigabrt when app is not started
Change-Id: I05360dc7cb2616aa23a6904f509930a7ecef8b27
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Wed, 4 Oct 2023 02:10:18 +0000 (11:10 +0900)]
Send sigabrt when app is not started
Change to send SIGABRT instead of SIGKILL for debugging
when app is not started in OnDyingTimeout.
Change-Id: I0213f37cafb256399d3936155dcb17b71e107a58
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Mon, 25 Sep 2023 08:45:53 +0000 (17:45 +0900)]
Release version 1.67.2
Changes:
- Add setting starting to app_status on RegisterPID()
Change-Id: I8b9a53144d593c67ca8500e35c742cfbe0fd611f
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Mon, 25 Sep 2023 05:04:05 +0000 (14:04 +0900)]
Add setting starting to app_status on RegisterPID()
For apps registered through RegisterPID(), initialization is
considered complete and the timer is not registered.
Change-Id: I51bee048931dbdb28fa40b63070b38ae59f12571
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Fri, 22 Sep 2023 00:09:51 +0000 (09:09 +0900)]
Release version 1.67.1
Changes:
- Add app status startup timer
Change-Id: Id8003e420e6ea6e3963552463dd5e74625b743f9
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Thu, 21 Sep 2023 06:37:48 +0000 (15:37 +0900)]
Add app status startup timer
Occasionally, if amd does not receive the app dead signal from launchpad due to a delay in dbus
initialization, amd may have a problem of not recognizing the termination status of an app.
To prevent this situation, this patch registers a timer for the startup signal and recognizes that
the app is dead if the signal is not received within 30 seconds.
Change-Id: I3cd0080dcb7148ac4d904639a1bf60d940448a79
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Hwankyu Jhun [Thu, 14 Sep 2023 05:29:23 +0000 (14:29 +0900)]
Release version 1.67.0
Changes:
- Add ISU package
Change-Id: I9331ce89f5c2c35a636d36cabf6fa6868bb91e16
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Mateusz Moscicki [Fri, 1 Sep 2023 15:51:19 +0000 (17:51 +0200)]
Add ISU package
This commit adds Individual Service Upgrade (ISU) feature to amd
package. When installed it will allow to upgrade this service using ISU
mechanism, without the need to perform full OS Upgrade.
This commits add necessary configuration to create upgrade packages of
needed format. ISU framework itself is maintained and installed
separately.
Change-Id: I62916eb3c0956d5fe65202656fe148db93032cd6
Changgyu Choi [Thu, 14 Sep 2023 05:26:29 +0000 (14:26 +0900)]
Release version 1.66.10
Changes:
- Add sending SIGKILL for termiate request timeouts
Change-Id: I11ff3bffb1fabbb9c8dbfc17f28d6d31793f00a9
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Thu, 14 Sep 2023 04:55:48 +0000 (13:55 +0900)]
Add sending SIGKILL for termiate request timeouts
In order to handle a terminate request timeout,
Send to sigkill signal to target pid.
Change-Id: Icd2b34d305b4da0c8a7fa19c20a92c04912bb83b
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Hwankyu Jhun [Wed, 6 Sep 2023 23:46:29 +0000 (08:46 +0900)]
Release version 1.66.9
Changes:
- Fix segmentation fault
Change-Id: Ifc2792f4e8f2341d9bd9f41a6065325fe188cfb4
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Wed, 6 Sep 2023 23:08:54 +0000 (08:08 +0900)]
Fix segmentation fault
When user log off, amd tries to remove the app status of the list.
In this time, the problem occurs.
Change-Id: I551c472246f88138bf4e8c6bee3372905ff95d00
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Wed, 30 Aug 2023 04:39:01 +0000 (13:39 +0900)]
Release version 1.66.8
Changes:
- Modify setting auto restart handler
Change-Id: I8814989c28d24280d18c6237889e576ae45d6800
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Wed, 30 Aug 2023 03:46:51 +0000 (12:46 +0900)]
Modify setting auto restart handler
After this patch is applied, amd sends the notification message when
the registration or deregistration of setting auto restart is successful.
Change-Id: I71b8c060ae93bcd43216785b1012754674168a46
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Mon, 21 Aug 2023 00:31:14 +0000 (09:31 +0900)]
Release version 1.66.7
Changes:
- Remove timeout setting of applying cpu boosting
Change-Id: Iaa79e67cc97fa19f5da71f03bb8a6d2f80c4cef7
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Fri, 18 Aug 2023 05:01:18 +0000 (14:01 +0900)]
Remove timeout setting of applying cpu boosting
Unfortunately, the plugin module of the resource API does not support
timeout feature properly. According to the guide, if the timeout setting
exists, we must not call the resource_clear_cpu_boosting() function.
This patch changes the timeout argument to -1 from the 5000 (milliseconds).
The RESET_ON_FORK flag is also removed.
Change-Id: I390c5ec3dd6f8ae0d5ac87303e1378ba17411f68
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Changgyu Choi [Thu, 17 Aug 2023 00:59:30 +0000 (09:59 +0900)]
Release version 1.66.6
Changes:
- Fix a static analysis issue
- Remove duplicated Update() calling
Change-Id: Ib0c191f811e0b1d08fb645fc2972ae2d02858252
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Wed, 16 Aug 2023 06:37:50 +0000 (15:37 +0900)]
Remove duplicated Update() calling
_terminate_app_local() is calling Update() method.
This patch removes them.
Change-Id: I08543992cca622c127ed50ab2e7ecce8b2484f37
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Wed, 16 Aug 2023 05:36:27 +0000 (14:36 +0900)]
Fix a static analysis issue
Adds app_status nullptr checking.
Change-Id: I473c9c9a752641410ce21124bc2ec86bda2b8e6a
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Hwankyu Jhun [Fri, 4 Aug 2023 05:34:30 +0000 (14:34 +0900)]
Release version 1.66.5
Changes:
- Modify handling pending requests
Change-Id: I969e122dce529de3bec1663750b1f8e6eb628c66
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Fri, 4 Aug 2023 02:22:33 +0000 (11:22 +0900)]
Modify handling pending requests
The SetTimer() method is added to the Request class. The method sets
a timer using the interval that is calculated with the timeout variable.
And, the log is added for debugging.
Change-Id: Ibb0636f8f3fc174948ae57e9b987c9ad13d4f6e1
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Fri, 4 Aug 2023 00:21:15 +0000 (09:21 +0900)]
Release version 1.66.4
Changes:
- Fix wrong implementation of ClientChannel
Change-Id: Ie356e037f2e84a7b45dcb99832c170dcf006b13c
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Thu, 3 Aug 2023 23:55:13 +0000 (08:55 +0900)]
Fix wrong implementation of ClientChannel
The once_ member variable must be set while calling constructor.
Change-Id: I1207d0b9c87b5e7ac2a0c68671583dc777f75c83
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Thu, 3 Aug 2023 08:07:39 +0000 (17:07 +0900)]
Release version 1.66.3
Changes:
- Fix memory leak
- Fix memory leak
- Modify AMD database API
Change-Id: I90acb561d1c54693dc867a7bf48b03f48f6d54f3
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Thu, 3 Aug 2023 05:32:44 +0000 (14:32 +0900)]
Modify AMD database API
To reduce memory usage, amd opens and closes the database repeatedly
in the loop.
Change-Id: I6db87bbbe38ad7b2b08e237d005bda4b8a4a3ed5
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Thu, 3 Aug 2023 06:47:00 +0000 (15:47 +0900)]
Fix memory leak
This patch fixes the following case:
+------------------------------------------------------------------------------+
25 bytes in 1 blocks are definitely lost in loss record 1,476 of 3,015
==513== at 0x4848A14: malloc (vg_replace_malloc.c:307)
==513== by 0x49C6F77: strdup (strdup.c:42)
==513== by 0x4C46F97: vconf_get_str (vconf.c:1203)
==513== by 0x48EB983: amd::AppStatusManager::InitVconf()
(app_status_manager.cc:901)
==513== by 0x48EBACF: amd::AppStatusManager::Init()::{lambda(void*)#4}::
_FUN(void*) (app_status_manager.cc:1061)
==513== by 0x4B8D247: g_timeout_dispatch (gmain.c:4933)
==513== by 0x4B8C8EB: g_main_dispatch (gmain.c:3381)
==513== by 0x4B8C8EB: g_main_context_dispatch (gmain.c:4099)
==513== by 0x4B8CB6F: g_main_context_iterate.isra.0 (gmain.c:4175)
==513== by 0x4B8CDD7: g_main_loop_run (gmain.c:4373)
==513== by 0x48B7D79: amd_main (amd_main.cc:282)
+------------------------------------------------------------------------------+
Change-Id: Icdb2f3b294e12d794d877f040f768e7991fa0d4e
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Thu, 3 Aug 2023 00:25:19 +0000 (09:25 +0900)]
Fix memory leak
If the callee application does not use tizen main loop function,
the ResultCb instance is not released.
To release the allocated memory properly, this patch adds a new method to
the ClientChannel. When calling the OnTimedOut, amd releases the ResultCb.
Change-Id: Ia29e7ba632296c56ae95d9fd5febc14ecfcd9e22
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Changgyu Choi [Tue, 1 Aug 2023 04:45:44 +0000 (13:45 +0900)]
Release version 1.66.2
Changes:
- Change multiple instance appid aul key
Change-Id: Iaf17e79125ebba0407bfbc4490ffae6bd9c860e5
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Tue, 1 Aug 2023 02:24:02 +0000 (11:24 +0900)]
Change multiple instance appid aul key
AUL_K_ORG_APPID is already used as alias appid.
this patch changes the aul key to AUL_K_MULTIPLE_INSTANCE_APPID.
Requires:
- https://review.tizen.org/gerrit/c/platform/core/appfw/aul-1/+/296550
Change-Id: I20a5a395d7f2b5a66f557bc333e6b06fefdc7909
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Hwankyu Jhun [Mon, 31 Jul 2023 23:40:27 +0000 (08:40 +0900)]
Release version 1.66.1
Changes:
- Modify dying timeout handler
Change-Id: I0c8806677a2cb71944108139c1d97074f0d4b814
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Mon, 31 Jul 2023 22:57:07 +0000 (07:57 +0900)]
Modify dying timeout handler
If the package is uninstalling or there is no appinfo, amd does not send
SIGKILL signal to the running process. It causes the SMACK error.
Change-Id: Ifbccef62c91cfd69047df2872506e25cd06de6a5
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Tue, 25 Jul 2023 01:30:36 +0000 (10:30 +0900)]
Release version 1.66.0
Changes:
- Handle new AUL commands related to proc group
Change-Id: I08ac1a565254659b41588ab958e00a12a608dd5e
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Mon, 24 Jul 2023 09:47:28 +0000 (18:47 +0900)]
Handle new AUL commands related to proc group
The amd-mod-proc-group module handles PROC_GROUP_FOREACH and
PROC_GROUP_GET commands.
Requires:
- https://review.tizen.org/gerrit/#/c/platform/core/appfw/aul-1/+/296246/
Change-Id: I8b87fc67be3e754569a6e68c4887dbaedd82ada6
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Mon, 24 Jul 2023 07:20:42 +0000 (16:20 +0900)]
Release version 1.65.9
Changes:
- Modify amd launchpad implementation
Change-Id: Iaeed59d4c7fc8579399089327cf28897a9a3105a
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Mon, 24 Jul 2023 06:43:31 +0000 (15:43 +0900)]
Modify amd launchpad implementation
To prevent timing issue related to getting app dead signal, this patch
changes the priority of the GIOChannel. Even if the launchpad sends the
result to the amd, amd does not handle it immediately. Sometimes, the
amd handles the dead signal before handling the result of the launch request.
Change-Id: I298c9a6937f386532428ffa73d85aa0569c06bfa
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Tue, 18 Jul 2023 00:32:35 +0000 (09:32 +0900)]
Release version 1.65.8
Changes:
- Modify file monitor initialization of wayland-core
Change-Id: I672a29136638bf097f003039d9cbfad9a53bcf16
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Mon, 17 Jul 2023 22:40:43 +0000 (07:40 +0900)]
Modify file monitor initialization of wayland-core
The inotify event should be added before checking file existence.
If the file has created after checking whether the file exists or not
using access() function, AMD does not know the file creation.
Change-Id: I795b5dc206bb3fae0ebde8056e4df5e6395b34db
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Mon, 3 Jul 2023 08:29:21 +0000 (08:29 +0000)]
Release version 1.65.7
Changes:
- Fixed the build error using gcc 13
Change-Id: Ic55b3864bb399a003bea52c934dbaa81f2b92ec3
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Hwankyu Jhun [Mon, 3 Jul 2023 07:16:21 +0000 (07:16 +0000)]
Fixed the build error using gcc 13
- Change 'requires' variable to 'requires_dep'
- Remove unnecessary std::move call
Change-Id: I0620e9601429c69ee45e55e3c159e1c6f0eec1e0
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
Changgyu Choi [Thu, 29 Jun 2023 01:56:08 +0000 (10:56 +0900)]
Release version 1.65.6
Changes:
- Fix gcov build failure issue
Change-Id: Ib18c3b25e7ae2d720026afa24207a692f61004e0
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Thu, 29 Jun 2023 01:42:24 +0000 (10:42 +0900)]
Fix gcov build failure issue
This patch is for the below issue.
error logs:
[ 86s] /home/abuild/rpmbuild/BUILD/amd-1.65.3/src/lib/amd_launch.cc: In function 'int DispatchAppResult(request_h)':
[ 86s] /home/abuild/rpmbuild/BUILD/amd-1.65.3/src/lib/amd_launch.cc:761:31: error: 'caller_uid' may be used uninitialized in this function [-Werror=maybe-uninitialized]
[ 86s] 761 | ret = aul_sock_send_bundle(caller_pid, caller_uid,
[ 86s] | ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
[ 86s] 762 | req->GetCmd(), b->GetHandle(), AUL_SOCK_NOREPLY);
[ 86s] | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Change-Id: I4323afdc83da200e89cb76f846474c41e105c1cf
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Wed, 28 Jun 2023 04:34:39 +0000 (13:34 +0900)]
Release version 1.65.5
Changes:
- Fix wrong implementation
- Change AppStatus handle name
Change-Id: I8685909555c01feab17bb55f68af707af1334060
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Wed, 28 Jun 2023 03:46:02 +0000 (12:46 +0900)]
Change AppStatus handle name
The name "app" is ambiguous in meaning.
This patch changes the name of the AppStatus handle from "app" to
"app_status".
Change-Id: I078c4c4c6baff74c03967d2fb4578606a8676f8c
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Wed, 28 Jun 2023 00:35:22 +0000 (09:35 +0900)]
Fix wrong implementation
This patch fixes the wrong modification in the previous patch.
Change-Id: Ia1d83ec8246b1edbf3ddcb3cacc588df6a7b02ee
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Tue, 27 Jun 2023 06:27:00 +0000 (15:27 +0900)]
Release version 1.65.4
Changes:
- Reduce amd_app_status C function dependencies
- Fix static analysis issues
Change-Id: I1bad2c36839a44382af02574e6df174f0a345082
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Tue, 27 Jun 2023 05:28:12 +0000 (14:28 +0900)]
Fix static analysis issues
Changes:
- nullptr checks.
- Uses std::move() instead of copy.
- Removes wrong used std::move().
Change-Id: I71f98f104fc2b3f4da6e8cbabe9f4c812822dd8c
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Mon, 26 Jun 2023 09:29:11 +0000 (18:29 +0900)]
Reduce amd_app_status C function dependencies
amd has been refactored to C++.
So using C interface inside amd creates unnecessary overhead.
This patch reduces amd_app_status C function dependencies.
Change-Id: I5b94336e0ec1d762cfd23d8983adf334143a7250
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Mon, 26 Jun 2023 08:13:05 +0000 (17:13 +0900)]
Release version 1.65.3
Changes:
- Reduce amd_request C function dependencies
Change-Id: I44a5ee46d90455dc17135081f38a28e60617dbb6
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
Changgyu Choi [Mon, 26 Jun 2023 01:17:18 +0000 (10:17 +0900)]
Reduce amd_request C function dependencies
amd has been refactored to C++.
So using C interface inside amd creates unnecessary overhead.
This patch reduces amd_request C function dependencies.
Change-Id: Ie63ee96c9c4bd70e4aa377c2c8ed64ae1916fec4
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>