platform/upstream/elementary.git
6 years agoconform: Fix build warning 96/141996/2
Wonki Kim [Wed, 2 Aug 2017 07:22:30 +0000 (16:22 +0900)]
conform: Fix build warning

fix build warning on elm_conform

Change-Id: I61efd9675246a353e0f6fcdc35b8557455b77f74
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agointeface_scrollable: fix build warning 89/141989/2
Wonki Kim [Wed, 2 Aug 2017 07:06:29 +0000 (16:06 +0900)]
inteface_scrollable: fix build warning

fix build warning on interface_scrollable.c

Change-Id: I9f0d190b91bdda35a34b1d5bb9a8ec228ae6eae7
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agotoolbar: fix unused parameters. 69/141969/1
Bowon Ryu [Wed, 2 Aug 2017 06:30:54 +0000 (15:30 +0900)]
toolbar: fix unused parameters.

Change-Id: Iff64a42eb14f5ec25c773daebdeb09a809e4af12
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
6 years agogenlist : fix unused values and parameters 52/141952/2
SangHyeon Jade Lee [Wed, 2 Aug 2017 05:45:19 +0000 (14:45 +0900)]
genlist : fix unused values and parameters

Change-Id: Ic8bb3e04c275032afdfc26fefdae68df1f4a03aa
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agogenlist :fix wrong item paramenter pass on focus_set 31/141931/1
SangHyeon Jade Lee [Wed, 2 Aug 2017 04:46:00 +0000 (13:46 +0900)]
genlist :fix wrong item paramenter pass on focus_set

Change-Id: Ibe4e0e0709020e4d16788094854cb2ccdb187167
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agoscroller: Initialize member variables which are used for unstable situation 78/140978/2
Wonki Kim [Thu, 8 Jun 2017 04:40:23 +0000 (13:40 +0900)]
scroller: Initialize member variables which are used for unstable situation

This commit inits member vars to set proper position
when scroller initialy comes out.

Change-Id: I3b5490cbcc38fe77e549d152a7e4c666b6c4a518
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agomultibuttonentry: Fix item resource clean up logic. 18/141018/1
Woochan Lee [Thu, 27 Jul 2017 13:08:22 +0000 (22:08 +0900)]
multibuttonentry: Fix item resource clean up logic.

Summary:
There are four cases where items are deleted.

1. Select item and push back button.
2. Delete "X" part of item.
3. Calling elm_object_item_del().
4. MBE deleted.

Previous logic is can't support for all cases.

below problems were there.

eina_list_remove() called twice.
list data free twice.

@fix

Test Plan: elementary_test -> multibuttonentry test.

Reviewers: jpeg, cedric

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5030

Change-Id: I523afadb2c767b42ecc253f6b691e4de512c1199

6 years agoatspi: grab highlight using unrealized item 96/140296/2 accepted/tizen/unified/20170728.195337 submit/tizen/20170727.055818
Shinwoo Kim [Mon, 24 Jul 2017 10:11:48 +0000 (19:11 +0900)]
atspi: grab highlight using unrealized item

The looping naviation could make the first(or last) item grab highlight.
But the _elm_widget_item_elm_interface_atspi_component_highlight_grab returns
without setting highlight if sd->view is NULL that means the item is NOT
realized in case of genlist.
So the _elm_genlist_item_elm_interface_atspi_component_highlight_grab BRINGs
the first(or last) item IN first before grabbing highlight.

Change-Id: Id36716d1e2d6249532d67dede9357e152b3d3107

6 years agoatspi: genlist - remove unnecessary lines 47/139847/5
Shinwoo Kim [Thu, 20 Jul 2017 23:46:34 +0000 (08:46 +0900)]
atspi: genlist - remove unnecessary lines

Looping navigation could make first object grab highlight.
If the first object is unrealized genlist item, the genlist item will be
realized. While the first genlist item is realized, genlist calculation logic
makes the first genlist item unhighligted, and gives highlight to next proper
genlist item based on geometry value. See the following backtrace.

※ Backtrace
0  elm_interface_atspi_component_highlight_grab
1  in _item_position
2  in _item_all_position
3  in _item_block_realize
4  in _elm_genlist_pan_evas_object_smart_calculate
5  in evas_obj_smart_calculate
6  in ?? () from target:/lib/libevas.so.1
7  in ?? () from target:/lib/libevas.so.1
8  in ?? () from target:/lib/libevas.so.1
9  in evas_canvas_render_async
10 in evas_render_async
11 in ?? () from target:/lib/ecore_evas/engines/wayland/v-1.16/module.so
12 in ?? () from target:/lib/libecore_evas.so.1
13 in ?? () from target:/lib/libecore.so.1
14 in ?? () from target:/lib/libecore.so.1
15 in ecore_main_loop_begin () from target:/lib/libecore.so.1
16 in elm_run () at elm_main.c:1128
17 in ?? () from target:/usr/lib/libappcore-efl.so.1
18 in appcore_base_init () from target:/lib/libappcore-common.so.1
19 in appcore_ui_base_init () from target:/lib/libappcore-ui.so.1
20 in appcore_efl_base_init () from target:/usr/lib/libappcore-efl.so.1
21 in ?? () from target:/usr/lib/libcapi-appfw-application.so.0
22 in ui_app_main () from target:/usr/lib/libcapi-appfw-application.so.0
23 in main () from target:/usr/apps/org.tizen.watch-setting/bin/watch-setting
24 in _start ()

It seems that this is a mistake of commit migration from Tizen 3.0
to Tizen 4.0. So the lines should be removed.

※ migration commit: d8bdb91a65cb678258ac3704d11610520aa8948d

Change-Id: Ib5a58b8959828ad47867298338a40c76b4417bf7

6 years agogenlist : fix build warnings 14/140314/2
SangHyeon Jade Lee [Mon, 24 Jul 2017 11:30:42 +0000 (20:30 +0900)]
genlist : fix build warnings

Change-Id: I342307152e8eb94517a1d37b5d5ddc8625992262
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
6 years agoelm_plug: remove unused variable 44/140344/1
Thiep Ha [Mon, 24 Jul 2017 22:35:49 +0000 (07:35 +0900)]
elm_plug: remove unused variable

Change-Id: Ifeabbe326dfdd82d1c3a3a12a945666a8e525c07

6 years agocopypaste: remove build warning 05/140305/2
Minchul Lee [Mon, 24 Jul 2017 11:02:22 +0000 (20:02 +0900)]
copypaste: remove build warning

Change-Id: I596f1080cd93d16d9154dcfe5649db9525eb9177
Signed-off-by: Minchul Lee <slotus.lee@samsung.com>
6 years agolabel: fix elm_label_style_user_push to work without default format 17/140117/3
Youngbok Shin [Wed, 19 Jul 2017 10:54:28 +0000 (19:54 +0900)]
label: fix elm_label_style_user_push to work without default format

@tizen_fix

Change-Id: Ie786c075714cbaa26bbf55d669fbd291a8fda960

6 years agopopup: fix build warning 12/140212/2
JinYong Park [Mon, 24 Jul 2017 07:20:55 +0000 (16:20 +0900)]
popup: fix build warning

This warning is not occur in upstream

Change-Id: Iccf8be67a6ae736789352861a5139583f2f062a0
Signed-off-by: JInyong Park <j4939.park@samsung.com>
6 years agoatspi: Remove build warning 00/140200/1
JunsuChoi [Mon, 24 Jul 2017 06:52:05 +0000 (15:52 +0900)]
atspi: Remove build warning

   Remove null initialization becuase of
   variable ss(Elm_Atspi_State_Set) is not pointer

Change-Id: Ic9024047f7946c587fc42c0773bfde3f9710c1ce

6 years agoslider: changed negative zero to zero 71/140171/2
Hosang Kim [Mon, 24 Jul 2017 05:35:13 +0000 (14:35 +0900)]
slider: changed negative zero to zero

When slider value is between 0.0 and -0.5, -0 is printed.

Change-Id: I7381dabc0749555b77be53e67c74e646c17840c1

6 years agomobile_lib/ctxpopup: fix float calculate problem 98/139798/2
JinYong Park [Thu, 20 Jul 2017 11:02:51 +0000 (20:02 +0900)]
mobile_lib/ctxpopup: fix float calculate problem

Change-Id: I37874f6bbc84db5dac172e44bef9f9b5a233ce7a
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
6 years agogenlist : fix wrong item referencing in pos adjust 76/139276/2
SangHyeon Lee [Tue, 18 Jul 2017 07:30:26 +0000 (16:30 +0900)]
genlist : fix wrong item referencing in pos adjust

Change-Id: Ie055661c4f20308511f7c39c92e2dee36bbcdb15
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
6 years agoelm_colorselector : set selected status directly in selected_set function 35/139735/2 accepted/tizen/unified/20170721.201726 submit/tizen/20170721.005824
JEONGHYUN YUN [Thu, 20 Jul 2017 08:17:06 +0000 (17:17 +0900)]
elm_colorselector : set selected status directly in selected_set function

Change-Id: Ibaaf0035f90c5b3b766f2dbc4746bd12fc46661c
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
6 years agoatspi: Expose API 10/139510/2
Shinwoo Kim [Wed, 19 Jul 2017 07:38:42 +0000 (16:38 +0900)]
atspi: Expose API

The following API is exposed on the Mobile profile.
    - elm_object_part_access_register
    - elm_object_part_access_object_get
    - elm_access_object_register
    - elm_access_object_unregister
    - elm_access_object_get
    - elm_atspi_bridge_utils_say
    - elm_atspi_accessible_name_cb_set
    - elm_atspi_accessible_description_cb_set
    - elm_atspi_accessible_attribute_append
    - elm_atspi_accessible_reading_info_type_set
    - elm_atspi_accessible_reading_info_type_get
    - elm_atspi_accessible_gesture_cb_set
    - elm_atspi_accessible_can_highlight_set
    - elm_atspi_accessible_can_highlight_get
    - elm_atspi_component_highlight_grab
    - elm_atspi_component_highlight_clear

Change-Id: I4fbcf06f384bc79581285d8747f409f65bdb7554

6 years agoelm_colorselector : support marking change when color set on ELM_COLORSELECTOR_PALETT... 98/139598/1
JEONGHYUN YUN [Wed, 19 Jul 2017 11:25:43 +0000 (20:25 +0900)]
elm_colorselector : support marking change when color set on ELM_COLORSELECTOR_PALETTE mode only

@tizen_fix

Change-Id: Ibde5ec8668f6dc960035a5deba5ad7d4765daad1
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
6 years agomobile_lib/ctxpopup : enable elm_ctxpopup_item_content_unset 85/139085/3
JEONGHYUN YUN [Mon, 17 Jul 2017 07:57:32 +0000 (16:57 +0900)]
mobile_lib/ctxpopup : enable elm_ctxpopup_item_content_unset

Change-Id: Id61addf2b57db6f3b2f4e2cf921c76b1f35092de
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
6 years agoelm_colorselector: changed item selection procedure to handle by _on_color_selected() 16/139516/2
JEONGHYUN YUN [Wed, 19 Jul 2017 07:42:51 +0000 (16:42 +0900)]
elm_colorselector: changed item selection procedure to handle by _on_color_selected()

Deleted duplicate item selection procedure code
in _elm_color_item_selected_set() and _item_action_activate()

@tizen_fix

Change-Id: I607658ec651f393ca3658c2746c11ecc7a841d41
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
6 years agoelm_ctxpopup: Implemented elm_widget_item_part_content_unset for elm_ctxpopup_item 84/139084/2
JEONGHYUN YUN [Mon, 17 Jul 2017 07:55:15 +0000 (16:55 +0900)]
elm_ctxpopup: Implemented elm_widget_item_part_content_unset for elm_ctxpopup_item

Summary:
ctxpopup item have elm_list item internally.
item_part_content_unset need to pass on content part to elm_list item.

Test Plan:
1. launch elementary_test - ctxpopup
2. click Ctxpopup with part text & content function
3. press "Icon Set" and press "Icon Unset"

Reviewers: jpeg

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5018

Change-Id: I5e9bcb853a040d11e7cac4017a417e2fd7260a79
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
6 years agointerface_scrollable: fix build fail on interface_scrollable 00/139500/1
Wonki Kim [Wed, 19 Jul 2017 06:13:28 +0000 (15:13 +0900)]
interface_scrollable: fix build fail on interface_scrollable

typo error

Change-Id: I4d9e786a71ff7bc765ff08e1c5266fb6801455b0

6 years agointerface_scrollable: Add "content,resize" callback to keep backward compat 43/139343/2
Wonki Kim [Tue, 18 Jul 2017 11:15:21 +0000 (20:15 +0900)]
interface_scrollable: Add "content,resize" callback to keep backward compat

There was a "content,resize" callback before tizen 3.0.
Even if it was a tizen only code block, there could be a backward compat issue
without the callback.

This commit emits the callback after whole procedure for content resizing.finished.

@tizen_feature

Change-Id: I0eccf8ebc8c704e1403056c0078bd6625d612265
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
6 years agogenlist: add select_on_focus_disable condition in left/right key actions 71/137371/3
SangHyeon Lee [Wed, 5 Jul 2017 10:55:38 +0000 (19:55 +0900)]
genlist: add select_on_focus_disable condition in left/right key actions

Change-Id: I85f35bd97ec7f8307e0774d5c06f068efa88c1cb
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
6 years agoFix a wrong group info. 30/139030/2
Myoungwoon Roy, Kim [Mon, 17 Jul 2017 04:17:54 +0000 (13:17 +0900)]
Fix a wrong group info.
Summary:
Fix a wrong group info. and some wrong expressions.

Change-Id: I5eb6da156e388a7ab496c53a566591ddc729528d

6 years agoMake elm_win_window_id_get public 02/138802/2
Myoungwoon Roy, Kim [Fri, 14 Jul 2017 01:01:24 +0000 (10:01 +0900)]
Make elm_win_window_id_get public
Summary:
This API is opened to support quickpanel window features.

Change-Id: I6c01e89421efb85f76d18c16621c53a9770a3afc

6 years agoatspi: use last appended relation information 98/138198/2
Shinwoo Kim [Tue, 11 Jul 2017 11:30:16 +0000 (20:30 +0900)]
atspi: use last appended relation information

So far, the screen reader has used the first relation information.
So application should remove appended relation information, before appending
relation information newly. This is hard to use in some point of view.
The application used *append API as *set API.
So using last appended relation information makes more sense.

Change-Id: Id7c3e7dc02acc0a883eb7e55b3892461aee259a3

6 years agomobile_lib/ctxpopup : fix item part text and icon set logic 27/138527/2
JEONGHYUN YUN [Wed, 12 Jul 2017 11:38:25 +0000 (20:38 +0900)]
mobile_lib/ctxpopup : fix item part text and icon set logic

when icon or text is null, theme will be changed if it needs

Change-Id: I58c0377e0149bdbcd256c55eaf9e7904cf08f186
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
6 years agochange markup text to utf8 when called accessible_name_get function 54/136954/10 accepted/tizen/unified/20170717.170158 submit/tizen/20170713.122748 submit/tizen/20170714.014828
JunsuChoi [Tue, 4 Jul 2017 01:36:39 +0000 (10:36 +0900)]
change markup text to utf8 when called accessible_name_get function

Change-Id: I3a13146ed11287c35d007bfb0d5f712ff40a7fb3

6 years agoelm_ctxpopup: enable ctxpopup item insert before/after for mobile_lib 13/138413/1
JEONGHYUN YUN [Wed, 12 Jul 2017 06:38:44 +0000 (15:38 +0900)]
elm_ctxpopup: enable ctxpopup item insert before/after for mobile_lib

Change-Id: I4f96499e0636e1784b634116e7915df8e33e2a45
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
6 years agoelm_ctxpopup: Add APIs to insert before/after item to a ctxpopup object. 07/138407/1
JEONGHYUN YUN [Wed, 12 Jul 2017 06:04:18 +0000 (15:04 +0900)]
elm_ctxpopup: Add APIs to insert before/after item to a ctxpopup object.

Summary:
There were only 2 APIs (item_append, item_prepend) for ctxpopup item add.
Added more item add APIs (item_insert_before and item_insert_after) for convenience.

Test Plan:
1. launch elementary_test - ctxpopup
2. click Ctxpopup with callback function sample
3. check whether there are 3 items on ctxpopup

Reviewers: jpeg

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D5004

Change-Id: Iaee2310ff78dd727e7edfd420d14913fec02b4cd
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
6 years agomobile_lib/ctxpopup: fix item theme set logic 38/138138/4
JinYong Park [Tue, 11 Jul 2017 07:50:55 +0000 (16:50 +0900)]
mobile_lib/ctxpopup: fix item theme set logic

icon_style must be set when icon and label is null

Change-Id: Ibe352ef81ff80614ab0357d6f37a9c14ec8ccba6
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
6 years agoatspi: enhance finding the first,last obj 78/138178/2
Shinwoo Kim [Tue, 11 Jul 2017 10:39:50 +0000 (19:39 +0900)]
atspi: enhance finding the first,last obj

There are two kind of first(or last) object.
(1) The first object in viewport of its scrollable parent.
(2) The first object in accessibilty tree regardless of scrollable parent.

Looping navigation should use the first object of type (2)
Other cases should use the first object of type (1)

If view is changed, then there is no highlight. In this case the first object
of type (1) should be used. For example, if view is changed to 1 depth from
2 depth, then the highlight should use the first object of type (1).
If the following is 1 depth view after 2 depth view disapears, then there is
not currently highlighted object. In this case the item 4 should grab highlight
for next object, and the item 6 should grab highlight for the previous object.

+--------+
| item 4 |
|--------|
| item 5 |
|--------|
| item 6 |
+--------+

Change-Id: Ie9e2d2c754d991e5dfb2fd32fca6954282b99061

6 years agoatspi: consider scrollable parent for "GetNeighbor" 65/137765/4
Shinwoo Kim [Fri, 7 Jul 2017 02:44:14 +0000 (11:44 +0900)]
atspi: consider scrollable parent for "GetNeighbor"

To determine the next object,
find top scrollable parent of next object excluding scrollable parents of start
object, and check if the next object exists inside of the top scrollable parent
viewport.

If there is not top scrollable parent, then use the next object.

          (layout)
              |
   |----------|----------|
   |          |          |
(btn1)    (scroller)  (btn3)
              |
              |
   |----------|----------|
   |          |          |
(btn2)    (genlist)   (toolbar)

[case: top scrollable parent is scroller]
If current highlighted(start) object is btn1, and the 10th genlist item shows
just under the btn1 (i.e. btn2, and 1st ~ 9th items are scrolled out),
then the next object should be the 10th item.

[case: top scrollable parent is NULL]
After the 10th genlist item grabs highlight, the previous object should be the
9th genlist item, not the btn1. In this case scrollable paretns of start object
are scroller, and genlist. the next object has same scrollable parents. So the
top scrollable parent is NULL.

If the 10th genlist item is the next object of btn1, then the btn1 object could
be the previous object of 10th genlist. But this patch set make the 9th genlist
item previous. This behavior is quite dependent on UX definition.

Change-Id: I8ded2d533f0b77202be25713eafca652e1886bcb

6 years agoentry: pop freezed scroll by longpress_cb from mouse up event before checking type... 36/138136/2
Youngbok Shin [Tue, 11 Jul 2017 07:28:11 +0000 (16:28 +0900)]
entry: pop freezed scroll by longpress_cb from mouse up event before checking type of event

@tizen_fix

Change-Id: I4a6235f565aead6f25b088de2317aa57755e675c

6 years agoctxpopup: fix item style set logic 65/121565/3
JinYong Park [Tue, 28 Mar 2017 08:34:23 +0000 (17:34 +0900)]
ctxpopup: fix item style set logic

label_style_item is wrong style
and comparing order change to same with other comparing logic

Change-Id: Ief9616bd437130f228317ccd93e21d6548057592
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
6 years agopopup: fix sizing eval logic when scrollable set TRUE 21/138121/1
JinYong Park [Tue, 11 Jul 2017 06:46:27 +0000 (15:46 +0900)]
popup: fix sizing eval logic when scrollable set TRUE

When scrollable set TRUE,
scroller must be calculated its size except using item.
If content is removed, scroller doesn't calculate its size, so it has previous size.
So there is a empty space in this case.

@fix

https://phab.enlightenment.org/D5010

Change-Id: Ib930461dc8f6f31a7c08a247d0fc120913ea2fd4
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
6 years agoctxpopup: enable ctxpopup item prepend for mobile_lib 79/138079/1
JEONGHYUN YUN [Tue, 11 Jul 2017 04:39:42 +0000 (13:39 +0900)]
ctxpopup: enable ctxpopup item prepend for mobile_lib

Change-Id: I476ec842631e8e7d34073f97ec18e1b780f1b2ee
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
6 years agopopup: fix wrong signal emit when remove all button 77/137677/1
JinYong Park [Fri, 7 Jul 2017 05:11:26 +0000 (14:11 +0900)]
popup: fix wrong signal emit when remove all button

In visuals_set function,
check action_area is NULL, and signal emit action_area,visible/hidden
So, before call visuals_set, action_area should be deleted.

https://phab.enlightenment.org/D5007

@fix

Change-Id: I7180a759a2ab0db85fc1e55b8280b8b39f4d371a
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
6 years agogenlist: fix dangling item pointer accessing in filter queue idle enterer 72/137372/1 accepted/tizen/unified/20170711.181143 submit/tizen/20170707.071852 submit/tizen/20170711.023244
SangHyeon Lee [Wed, 5 Jul 2017 10:59:57 +0000 (19:59 +0900)]
genlist: fix dangling item pointer accessing in filter queue idle enterer

Change-Id: Iceaf891673f98a9b51088eb7694bd8a1956db1d7
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
6 years agoatspi: fix integer underflow issue 21/137321/1
Shinwoo Kim [Wed, 5 Jul 2017 08:10:47 +0000 (17:10 +0900)]
atspi: fix integer underflow issue

Change-Id: I99a498b901c0980d62e5c8abaf42687fb54ac335

6 years agotoolbar: fix build failure caused by recent changes on Edje 34/137234/1
Youngbok Shin [Wed, 5 Jul 2017 03:55:17 +0000 (12:55 +0900)]
toolbar: fix build failure caused by recent changes on Edje

edje_obj_message_signal_process() changed to recieve a parameter.

@tizen_fix

Change-Id: I336e7d746b866ae081ce25ca6a7de2082ed2a040

6 years agoatspi: fix bug of finding the last object 82/136882/2
Shinwoo Kim [Fri, 30 Jun 2017 09:15:29 +0000 (18:15 +0900)]
atspi: fix bug of finding the last object

The last object can be found only if all_children_visited is false.
The start is same with root, when looking for the last object.

The first object can be found already, even though the start is same with root.
Because the forwarding navigation can visit its children.

Change-Id: I763994505d5b2b21ee8aa459b39c08512a34a279

6 years agoatspi: suppress runtime error, build warning 86/136486/2
Shinwoo Kim [Fri, 30 Jun 2017 02:35:51 +0000 (11:35 +0900)]
atspi: suppress runtime error, build warning

[runtime error]
(1) elm_atspi_bridge.c:2787 _bridge_path_from_object() safety check failed: eo == NULL
(2) elm_atspi_bridge.c:6184 _bridge_object_register() Unable to register class w/o Elm_Interface_Atspi_Accessible!
(3) lib/eo/eo.c:697 _eo_call_resolve() in elm_widget.eo.c:169: func 'elm_obj_widget_access_highlight_in_theme_get' (288) could not be resolved for class 'Edje_Object'

- Note: The access_highlight_in_theme (3) should handle non Elm_LAYOUT_CLASS.
  Or the access_highlight_in_theme should be removed. If the screen-reader
  shows highlight, then the access_highlight_in_theme doesn't make sense.

[build warning]
(1) warning: passing argument 2 of '_object_get_bus_name_and_path' discards 'const' qualifier from pointer target type
(2) warning: passing argument 3 of '_object_get_bus_name_and_path' from incompatible pointer type

Change-Id: I4a690afdbf90f2bf72b497d0c3916c7fc83ddb74

6 years agoatspi: check accessible parent for can_highlight 63/136363/4
Shinwoo Kim [Thu, 29 Jun 2017 07:31:44 +0000 (16:31 +0900)]
atspi: check accessible parent for can_highlight

If an object is Elm_Widget and accessible child of Elm_Widget_Item, then
can_child of this object does not check value of the Elm_Widget_Item.
Because the _elm_widget_item_highlightable has used elm_widget_parent_get.
It doesn't return Elm_Widget_Item. It returns parent object of Elm_Widget_Item.
So _elm_widget_item_highlightable should have to use accessible parent.

Change-Id: Iecbc162fc676efeb6e3162418ac3eb34b761195d

6 years agoelm_spinner: Entry hide when inc/dec button pressed. 23/136723/1
Woochan Lee [Mon, 3 Jul 2017 04:46:23 +0000 (13:46 +0900)]
elm_spinner: Entry hide when inc/dec button pressed.

The entry cursor does not disappear when the user pressed(long press value change case) inc/dec button.

Change-Id: I750dd17aa951b956d46923847c34823a45201153

6 years agoentry: Fix build error due to since_tizen tag 33/136533/2
Jihoon Kim [Fri, 30 Jun 2017 06:24:38 +0000 (15:24 +0900)]
entry: Fix build error due to since_tizen tag

Change-Id: I5c6d38888f06ffd35b042e2d3a4e64d86638b398

6 years agoResize highlight rectangle if target object is clipped 28/136528/1
Shinwoo Kim [Tue, 16 May 2017 08:15:55 +0000 (17:15 +0900)]
Resize highlight rectangle if target object is clipped

Change-Id: I352b123d49626d4254236d7b3ab656b657024927

6 years agoentry: Add prediction hint API 82/135782/2
Jihoon Kim [Mon, 26 Jun 2017 10:59:11 +0000 (19:59 +0900)]
entry: Add prediction hint API

prediction hint can be used to provide an intelligent reply suggestion.

@feature

Change-Id: I9d5f482acd8104d2cadf3b00aa3eb573e2daa49f
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
6 years agoels_tooltip: Remove infinite job calls 11/136411/1
Jaehyun Cho [Thu, 29 Jun 2017 07:12:37 +0000 (16:12 +0900)]
els_tooltip: Remove infinite job calls

Summary:
When tooltip or content size is 0, tooltip reconfigure job is called infinitely.
This patch removes the infinite job calls.

Test Plan:
See following patch, test case "Tooltip" -> "Tooltip with no min size"

Reviewers: zmike

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D4982

Change-Id: I730017aa2b417f96302d81ba7c2eb43ffb4a63f4

6 years agoatspi: moved highlight when object is out of screen 95/135995/4
JunsuChoi [Wed, 14 Jun 2017 06:07:34 +0000 (15:07 +0900)]
atspi: moved highlight when object is out of screen

   when highlighted object is out of screen or scroll view
   , elementary send 'object:move-outed' signal to screen-reader

   need this commit:
   screen-reader - https://review.tizen.org/gerrit/#/c/135993/
   at-spi2-core - https://review.tizen.org/gerrit/#/c/135994/

Change-Id: Id8f6d55569f5213a3bdbf37c836ef0f38090d21a

6 years agoelm_image: Fix previous image visible issue 86/136386/1
jiin.moon [Wed, 31 May 2017 10:01:03 +0000 (19:01 +0900)]
elm_image: Fix previous image visible issue

Summary: Previous image still visible when elm_image_file_set has wrong file path.

Test Plan: self

Reviewers: jpeg, jypark, singh.amitesh

Reviewed By: singh.amitesh

Subscribers: singh.amitesh, minkyu, cedric

Differential Revision: https://phab.enlightenment.org/D4888

Change-Id: If8393e3851ea7cec1673540d7798eba1850cc75d

6 years agoelm_image: Fix file_set when preload is disabled 85/136385/1
Jean-Philippe Andre [Thu, 20 Apr 2017 09:29:26 +0000 (18:29 +0900)]
elm_image: Fix file_set when preload is disabled

If we disable preload, then the second file set on an elm_image
object would not trigger a deletion of the first image. As a
consequence, both images would be visible... really bad if there's
alpha or different dimensions!

Thanks Anand Kumar for the report!

@fix

Change-Id: If708c2d6bbc432585ba4493d6068467ab1a6086b

6 years agoefl_ui_image: fix removal of the internal evas image 84/136384/1
Daniel Zaoui [Mon, 21 Nov 2016 09:52:27 +0000 (11:52 +0200)]
efl_ui_image: fix removal of the internal evas image

During the replacement of the image with the new preloaded one,
the previous image is deleted but not removed from the list of
children of the icon (efl_ui_image), leading to Eo errors when
walking over the icon children.

@fix

Change-Id: Ic5e606bf2b485051e419b1ea0ba263cd5c7808f9

6 years agoFix typo and some wrong expressions 47/136247/9
Myoungwoon Roy, Kim [Thu, 29 Jun 2017 00:46:15 +0000 (09:46 +0900)]
Fix typo and some wrong expressions

Fix typo and some wrong expressions in doc, box, gesture, index, map, and toolbar API reference doxygen.

Change-Id: I5d8bc5d6adc4af08fc62c85a11392c3b257114b6

6 years agoatspi: find the first, last obj using "GetNeighbor" 49/136249/1
Shinwoo Kim [Mon, 26 Jun 2017 06:25:06 +0000 (15:25 +0900)]
atspi: find the first, last obj using "GetNeighbor"

The reducing IPC task overlooked functionality to get the first, last object.
This commit is related to the following commit.

[screen-reader]
commit 72e3396fac3a377f49422af454875a0e4c9a58bc

Add loop navigation feature.

Screen reader gives FOCUS_CHAIN_END_NOTIFICATION_EVENT notification if there is
no more object in its direction. If user gives next(or prev) gesture in same
direction one more time, then the first(or last) object will grab highlight.

Change-Id: I0e68c84a595396cbf7d0d2ae4d93fca4c425f0ea

6 years agoatspi: handle atspi proxy connection at runtime 48/136248/1
Shinwoo Kim [Wed, 21 Jun 2017 02:39:18 +0000 (11:39 +0900)]
atspi: handle atspi proxy connection at runtime

The following cases make atspi proxy work incorrectly.

[case 1]
1. screen reader on, then a11y order would be
   A1(embedding, deputy) - B1(embedded) - B2(embedded) - A2(embedding)
2. make A2 grab highlight
3. go previous, then A1 grabs highlight.
   but expected result is that the B2 grabs highlight

[case 2]
1. screen reader on, then a11y order would be
   A1(embedding, deputy) - B1(embedded) - B2(embedded) - A2(embedding)
2. make A1 grab highlight
3. go next, then B1 grabs highlight.
   This means that the proxy connection is made properly.
4. screen reader off
5. screen reader on, then a11y order is
   A1(embedding, deputy) -  A2(embedding)
   but the following is expected result as step 1
   A1(embedding, deputy) - B1(embedded) - B2(embedded) - A2(embedding)

So far the pory connects if elm_interface_atspi_children_get is called.
So there is no chance to make connection for the [case 1].

When atspi is disabled, then all atspi related interface is closed.
But the proxy related resources are not removed.
If atspi is enabled again, then newly created interface is used on new BUS.
And the proxy related resources are reused.
So the [case 2]  happens.

This patch set depends on screen-connector to use "widget,create" signal to
connect proxy on elementary side. This should be removed, and we have to
provide proper API to be used on screen-connector side to connect proxy.

Change-Id: I86f610504848db816e6db355316f8da06db513df

6 years agoatspi: connect to at-spi dbus based on org.a11y.Status.IsEnabled property 80/132480/2
Paweł Stawicki [Fri, 12 May 2017 11:37:11 +0000 (13:37 +0200)]
atspi: connect to at-spi dbus based on org.a11y.Status.IsEnabled property

Change-Id: I1fcd3d5e98fff8eb601430127bfc6660ef0ae414

6 years agoatspi: send window activated event to at_spi2 only once per session 79/132479/2
Paweł Stawicki [Fri, 12 May 2017 11:37:11 +0000 (13:37 +0200)]
atspi: send window activated event to at_spi2 only once per session

Change-Id: I11847c526879124e2340570291221caed19a9bbe

6 years agoatspi: "GetNeighbor" is using deputy object 31/136231/2
Shinwoo Kim [Thu, 15 Jun 2017 12:16:35 +0000 (21:16 +0900)]
atspi: "GetNeighbor" is using deputy object

A01 object is deputy object, and exists in embedding process.
A02, A03 object exist in embedding process.
B01, B02 objects exist in embedded process.

The “GetNeighbor” method should return A02 object as “next” object of B02,
and return B02 object as “prev” object of A02.
The “next” object of A01 is B01.
The “prev” object of B01 is A01.
This is default implementation.
The following is default order: A01 - B01 - B02 - A02 - A03

But more important thing is that the embedding process could use
ELM_ATSPI_RELATION_FLOWS_TO/FROM for each objects A01, A02, and A03.
So there are some cases should be considered.

(1) If A01 is ELM_ATSPI_RELATION_FLOWS_FROM object of A03, then the
   “GetNeighbor” should find B02 first when it navigates backward from A03.

(2) If A03 is ELM_ATSPI_RELATION_FLOWS_TO object of A01, then the
   “GetNeighbor” should find A03 first when it navigates backward from B02.

(3) Even though the A01 has ELM_ATSPI_RELATION_FLOWS_TO relation information,
   the “GetNeighbor” should find B01 first. Because the
   ELM_ATSPI_RELATION_FLOWS_TO object is used when “GetNeighbor” finds
   next object of B02.

Change-Id: Id9ec5762fb5abe94f942bf3823c69729e6389702

6 years agoatspi: "GetNavigableAtPoint" sends deputy object 30/136230/2
Shinwoo Kim [Wed, 14 Jun 2017 02:30:58 +0000 (11:30 +0900)]
atspi: "GetNavigableAtPoint" sends deputy object

The deputy means embedding side object works for embedded object.
If there is no object at point on embedded side, then the deputy object should
have highlight.

So far the deputy object is elm_access, and the elm_access takes highlight.
So there is no chance to have highlight on embedded side.

Change-Id: Id3fd144f74784f2630215c401b93c56a87f388e3

6 years agoatspi: add "GetReadingMaterial" interface method 29/136229/2
Shinwoo Kim [Fri, 26 May 2017 13:05:11 +0000 (22:05 +0900)]
atspi: add "GetReadingMaterial" interface method

The atspi_accessible_get_reading_material of at-spi2-core calls this method to
get reading material to be used screen-reader side. This is for reducing IPC.
It seems that the number of IPC is changed from 30 to 1.

Related patch set:
https://review.tizen.org/gerrit/#/c/131358/ (at-spi2-core)
https://review.tizen.org/gerrit/#/c/131359/ (this one, elementary)
https://review.tizen.org/gerrit/#/c/131511/ (at-spi2-atk)
https://review.tizen.org/gerrit/#/c/131714/ (screen-reader)

@tizen_only

Change-Id: Ib17d34fd8af7b5856908692c617938116d02305e

6 years agoatspi: Reduce action related IPC 28/136228/2
Shinwoo Kim [Fri, 19 May 2017 10:29:06 +0000 (19:29 +0900)]
atspi: Reduce action related IPC

If there are more than 10 actions on an object, then more than 10 IPC occurs for
calling reading information related action such as ReadingStopped which is called
whenever an object has highlight.

Change-Id: I884a183ec52fa30a7173a19794ab6628f0f87207

6 years agoAdd navigation helper functions for screen-reader and friends (part 2) 50/136150/2
Radoslaw Cybulski [Wed, 8 Mar 2017 14:41:34 +0000 (15:41 +0100)]
Add navigation helper functions for screen-reader and friends (part 2)

Change-Id: Idb6c1c3f33d377922b6813c2e03a4883c8ea34f3

6 years agoAdd navigation helper functions for screen-reader and friends 49/136149/2
Radoslaw Cybulski [Fri, 3 Mar 2017 15:29:55 +0000 (16:29 +0100)]
Add navigation helper functions for screen-reader and friends

This patch adds GetNavigableAtPoint accessibility interface - the function finds accessibility object at given coordinates.
This massively (10-15 times) reduce amount of IPC calls (and time spent) in typical screen-reader scenario.

Change-Id: Iff5820e280bef64414d0f07e9e2d5927a29bae4d

6 years agodocs: Fix typos and some wrong expressions in elm Box API reference doxygen 01/136001/2
Myoungwoon Roy, Kim [Wed, 28 Jun 2017 00:45:31 +0000 (09:45 +0900)]
docs: Fix typos and some wrong expressions in elm Box API reference doxygen

Change-Id: I46db38ac8b6a7121df86c103f61983bb63abccad

6 years agomultibuttonentry: Fix expand state changed callback called many times. 43/136143/1
Woochan Lee [Wed, 28 Jun 2017 08:14:36 +0000 (17:14 +0900)]
multibuttonentry: Fix expand state changed callback called many times.

Summary:
The expand state changed callback has been called when layout property changed and other reason.
Even expand state is not changed.

So we need to check the current view state to call expand changed callback.
(We can't prevent calling the _shrink_mode_set() function. It needs to call the re-arrange internal items.)

Test Plan:
elemenatay_test - multibuttonentry.

Check the shrink, expand state.

Reviewers: jpeg, cedric, woohyun

Reviewed By: jpeg

Subscribers: cedric, jpeg

Differential Revision: https://phab.enlightenment.org/D4970

Change-Id: If95dbdf050968e7419bf21a27f948d0644bd0cb0

6 years agoatspi: Make socket listen if atspi is enabled 70/133770/2
Shinwoo Kim [Tue, 13 Jun 2017 09:18:03 +0000 (18:18 +0900)]
atspi: Make socket listen if atspi is enabled

The socket proxy try to listen if the atspi is not enabled.
So it elm_atspi_bridge_utils_proxy_listen returns with out creating socket
interface(_socket_ifc_create) because it checks return value of
_elm_atspi_bridge_get which is used in _elm_atspi_enabled also.

Change-Id: Ie7a929d53ca9cc90e089f6a167b0480fc041c5af

6 years agoatspi: fix compare func to find object at point 85/133385/2
Shinwoo Kim [Mon, 5 Jun 2017 10:36:19 +0000 (19:36 +0900)]
atspi: fix compare func to find object at point

The compare function(_sort_by_repeat_events) does not change if two objects
repeat event(repeat_events: 1) even though the second object is registered to
elm_access. In this case the object could be demoted in the list, and it is not
possilbe to find the object by screen reader.

The following is the problem case:

[Before Sorting]
1. Object A (repeat_events: 1)
2. Object B (repeat_events: 1, is registred to elm_access)
3. Object C (repeat_events: 1)
4. Object D (repeat_events: 0)
5. Object E (repeat_events: 0)

[After Sorting] D - E - A - B -C

Change-Id: I5c566252507d8d6c5aac5759588cdd9e1468cd3e

6 years agoatspi: do not demote an object that repeats event. 81/131081/3
Shinwoo Kim [Thu, 25 May 2017 09:23:39 +0000 (18:23 +0900)]
atspi: do not demote an object that repeats event.

If an object is registered to elm_access, then do not demote its order even
though the object repeats event(repeat_events: 1) when _sort_by_repeat_events
function sorts object order.

User could add a rectangle to give accessibility. If the rectangle does not
repeat events, then it would be a problem when screen reader is off.

Change-Id: I3c154c96a290abb30f96564a9cee47ce237c5fe7

6 years agoatspi: do operation if its object is available 82/133382/3
Shinwoo Kim [Tue, 30 May 2017 08:05:53 +0000 (17:05 +0900)]
atspi: do operation if its object is available

Operation 1. activate
An object under the naviframe item is accessible even though new naviframe item
is pushed on it. In this case, it is possilbe to do action of the object.
So this patch set is checking SHOWING state before doing action.

Operation 2. selection
It was possible to (de)select even though its one of perent freezes events.
It is impossilbe to (de)select using touch event if freeze_events set to 1.
So it should work same using atspi interface.

TODO: handle non UI action

Change-Id: I59d69cd117252ef7364fd80536ce6b153c0ce920

6 years agoatspi: make popup label accessible 91/135991/2
Shinwoo Kim [Wed, 28 Jun 2017 00:04:07 +0000 (09:04 +0900)]
atspi: make popup label accessible

The application could customize default behavior of popup label.
There was no way to get the popup label so far.

Change-Id: I2b0477556a155574a151b063172bdb71cf72122e

6 years agolabel: fix to merge two DEFAULT tag from format and style user 24/134524/2
Youngbok Shin [Mon, 19 Jun 2017 05:36:36 +0000 (14:36 +0900)]
label: fix to merge two DEFAULT tag from format and style user

@tizen_fix

Change-Id: Ia027324b1fead60788b5073efedd02149f5d7957

6 years agoconformant: Added "virtualkeypad,size,changed" smart callback. 33/135633/2
Hosang Kim [Fri, 23 Jun 2017 10:27:08 +0000 (19:27 +0900)]
conformant: Added "virtualkeypad,size,changed" smart callback.

When the virtualkeypad size is changed, applications get the notice.
Applications can do internal object calculation according to the exact
virtualkeypad size.

Change-Id: Ic1e551a885c0d371f33295b2db993c97a46160c6

6 years agogenlist: fix clip set api calls in genlist when clipees are less than 2 80/135380/2
SangHyeon Lee [Thu, 22 Jun 2017 06:43:35 +0000 (15:43 +0900)]
genlist: fix clip set api calls in genlist when clipees are less than 2

Change-Id: If3183bf9437523f2bb0c4eaeb6c23dd43c70fb68
Signed-off-by: SangHyeon Lee <sh10233.lee@samsung.com>
6 years agogenlist: add null check in filter item internal for prevent svace issue 02/135202/2
SangHyeon Lee [Wed, 21 Jun 2017 07:20:50 +0000 (16:20 +0900)]
genlist: add null check in filter item internal for prevent svace issue

Change-Id: I73f6f2f320665a63e8430eafdedbb63b40510841

6 years agopopup: support multiscale problem on TM2 47/135247/3
JinYong Park [Wed, 21 Jun 2017 10:29:42 +0000 (19:29 +0900)]
popup: support multiscale problem on TM2

Change-Id: I7609002c9f81c2d2f32e79a645934efbecb43b37
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
6 years agoelm_panes: Refactoring of focus_next 61/134261/1 accepted/tizen/unified/20170630.083312 submit/tizen/20170622.051018
Jaehyun Cho [Thu, 15 Jun 2017 12:40:51 +0000 (21:40 +0900)]
elm_panes: Refactoring of focus_next

To handle ELM_FOCUS_UP/DOWN/RIGHT/LEFT in focus_next, refactoring is
done.

Change-Id: I8d3375853ab9f32f956339bdc5085136cdc1e374

6 years agoelm_config: Fix potential sizeof mismatch 06/134006/2 accepted/tizen/unified/20170630.083048 submit/tizen/20170616.085651
Hosang Kim [Wed, 14 Jun 2017 07:54:33 +0000 (16:54 +0900)]
elm_config: Fix potential sizeof mismatch

Change-Id: I8444d95facd3221f90ead810cfce4ad2f03d2075

6 years ago[GLView] Fix the logical error 28/134028/1
Wonsik, Jung [Wed, 14 Jun 2017 08:24:11 +0000 (17:24 +0900)]
[GLView] Fix the logical error

To fix logical error when glview_mode_set works

Change-Id: I5f3d97dd50a0ed76f3e5e567719d8d2a56cf3ab5

6 years agopanel: add "elm,state,hold", "elm,state,unhold" signals 08/133908/2
Jaeun Choi [Tue, 13 Jun 2017 10:33:09 +0000 (19:33 +0900)]
panel: add "elm,state,hold", "elm,state,unhold" signals

these signals were added in Tizen 2.3 as Tizen only code
and removed after merging upstream code into Tizen 2.4.
need to add the signals for compatibility.

Change-Id: I7b5400cd2d7046bb987f9d6c504bdf93c6c7c9fc

6 years agogenlist: Force to calculate before content realization 44/133644/2
Jeeyong Um [Tue, 13 Jun 2017 04:09:32 +0000 (13:09 +0900)]
genlist: Force to calculate before content realization

Signed-Off-By: Jeeyong Um <jc9.um@samsung.com>
Change-Id: Iedb9f6207adbfc80bdb74eecc22775f4debcc4b5

6 years agoelm config: add more NULL check 87/133887/1
Thiep Ha [Wed, 14 Jun 2017 01:40:27 +0000 (10:40 +0900)]
elm config: add more NULL check

Add NULL check when we cannot allocate memory.

Change-Id: I69d549cec3726e6f4e24b47b37c5bc4de0035440

6 years agoatspi: ctxpopup item uses parent name first 61/133561/1
Shinwoo Kim [Tue, 13 Jun 2017 01:42:25 +0000 (10:42 +0900)]
atspi: ctxpopup item uses parent name first

The ctxpopup does not use parent name such as elm_widget_item, and
elm_interface_atspi_accessible_name. So the elm_atspi_accessible_name_set does
not work.

Change-Id: I5f4c1d4ba9849c5e36d8471715a24298a683052b

6 years agoelementary entry: update focus state when editable state is changed 15/133215/3
Youngbok Shin [Fri, 9 Jun 2017 08:16:58 +0000 (17:16 +0900)]
elementary entry: update focus state when editable state is changed

Summary:
To recieve keyboard events, the entry_edje should have Evas focus.
But, if a non editable Entry widget takes focus, it can't recieve
keyboard events even if it becomes editable after taking focus.
So, elm_entry_editable_set() function should update Entry's focus state.
@fix

Test Plan:
The code of elementary_test - entry is modified to test this issue.
Please, check the issue with the following steps.

1. Run "elementary_test entry"
2. Click "Unfocus" button to make entry to "unfocused" state.
3. Click "Edit" button to make entry to non-editable mode.
4. Click "Focus" button to make entry to "focused" state.
5. Click "Edit" button to make entry to editable mode.
6. See a cursor is blinking in entry.
   => But, you can't edit text without this patch.

Reviewers: raster, herdsman, cedric, jpeg, woohyun

Differential Revision: https://phab.enlightenment.org/D4858

Change-Id: Iee51cf29a116aacf7a18d7bf82a2c7bbc58d8696

6 years ago[ATSPI][Popup] "Alert" reading text of popup is inserted when user does not set Acces... 13/133213/1
JunsuChoi [Fri, 9 Jun 2017 08:03:37 +0000 (17:03 +0900)]
[ATSPI][Popup] "Alert" reading text of popup is inserted when user does not set Accessible name.

Change-Id: I58e657a4253fa25ec57f42977088537cd529dfc6

6 years agomap: Fix broken link to openstreetmap.org 56/133156/1
Jeeyong Um [Fri, 9 Jun 2017 05:15:25 +0000 (14:15 +0900)]
map: Fix broken link to openstreetmap.org

Signed-Off-By: Jeeyong Um <jc9.um@samsung.com>
Change-Id: Ia5607006b9bebfe05c47f10157b92a48abfc0f08

6 years agowidget: initialize local variable 58/132958/2 accepted/tizen/unified/20170608.185236 submit/tizen/20170608.120138
Shinwoo Kim [Thu, 8 Jun 2017 11:33:55 +0000 (20:33 +0900)]
widget: initialize local variable

Uninitialized data is read from local variable 'ow', and 'oh'

Change-Id: Ib042ba64a88d82fa883f08c08851ee44c0a9a2da

6 years agoRevert "[Scroller] Filp to cords for RTL mode in wanted_region_set" 36/132836/1
JunsuChoi [Thu, 8 Jun 2017 03:18:20 +0000 (12:18 +0900)]
Revert "[Scroller] Filp to cords for RTL mode in wanted_region_set"

This reverts commit f9d1f7303e4774124098193247838b70387b1dbd.

Change-Id: I98e34223b90b3afe868c9fa2ac77e6c136df2565

6 years ago[ATSPI] Show object highlighted by highlight_grab when object is out of scroll 32/132132/5
JunsuChoi [Thu, 1 Jun 2017 07:24:45 +0000 (16:24 +0900)]
[ATSPI] Show object highlighted by highlight_grab when object is out of scroll

   Show item object of elm_genlist, elm_gengrid, elm_toolbar, elm_list
   and other object( in scroller) when out of scroll view

   This commit has merged several commits applied to tizen_3.0 branch

   89388 [ATSPI] Show the object highlighted by highlight_grab when the object is completely out of the scroll
   d7005 [ATSPI] Modify highlight grab of scrollable widget
   4d34b [ATSPI] Modify highlight region show
   c744f [ATSPI] Add check the object is in the scroller content size
   c03a9 [ATSPI] enhance expose highlight information on atspi

Change-Id: Iaf7d61e7cff1e6e97e88e1117b0d8f00e674bd7e

6 years agopopup: fix object_mirrored_set didn't work 24/132324/2
JinYong Park [Fri, 2 Jun 2017 08:29:58 +0000 (17:29 +0900)]
popup: fix object_mirrored_set didn't work

Using config_mirrored_set was working good at popup widget,
but object_mirrored_set didn't.
The mirrored value of notify, main layout, scroller, action area layout should be changed following popup.

@fix

https://phab.enlightenment.org/D4900

Change-Id: I5096e14c86ae313e10f2547e43b6e81de97690c3
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
6 years ago[Scroller] Filp to cords for RTL mode in wanted_region_set 86/132586/1
JunsuChoi [Wed, 7 Jun 2017 04:53:40 +0000 (13:53 +0900)]
[Scroller] Filp to cords for RTL mode in wanted_region_set

   In RTL mode, wanted_regison_set does not change coordinates
   So add code like opensource.

Change-Id: Ib332b982c2994b0995b02bc2431fcd984610e089

6 years agopopup: fix unintentional object deletion when change scrollable 73/132573/1
JinYong Park [Wed, 7 Jun 2017 03:41:07 +0000 (12:41 +0900)]
popup: fix unintentional object deletion when change scrollable

If popup scrollable change from FALSE to TRUE after content or text is added,
content_area is deleted, so it cause null pointer problem.
main_layout has content_area in its CONTENT_PART, but in scrollable_set API,
tbl set into main_layout's CONTENT_PART, so content_area is deleted.

On the contrary, if scrollable change to FALSE,
content object in content_area is deleted, because tbl set into content_area's CONTENT_PART.

So if some object set into other object,
unset previous object and set it into properly part after that.

A case using item_append should be fixed by other patch.

@fix

https://phab.enlightenment.org/D4894

Change-Id: Ief2d9d0bdb95bdcb3376181d5f7a905c3f3715e0
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
7 years agogenlist: theme_object_set returns enum not bool, so now genlist check enum values 44/132244/1
SangHyeon Lee [Fri, 2 Jun 2017 00:55:04 +0000 (09:55 +0900)]
genlist: theme_object_set returns enum not bool, so now genlist check enum values

Change-Id: If7998e36b8f10937c11e3df21b9d5062a6cb059c

7 years agoconformant: refer to window position when reflecting keyboard size 62/131962/1 accepted/tizen/unified/20170605.150700 submit/tizen/20170602.044537
Hosang Kim [Wed, 5 Apr 2017 04:28:01 +0000 (13:28 +0900)]
conformant: refer to window position when reflecting keyboard size

The vitural keyapd geometry is absolute coordinates value.
But conformant geometry is relative coordinates value.
When calculating overlapping size between keypad and conformant,
there is calculation error. So add window's x, y position for accurate
calculation.

@tizen_fix

Change-Id: Ia6fe558716439e39ccbc4e364fec309f80385f25
(cherry picked from commit ff36b8e6c46817de8ce99ad096bcdf54a66f4146)

7 years agopopup: remove previous object when content set NULL 11/131911/1
JinYong Park [Wed, 31 May 2017 07:40:02 +0000 (16:40 +0900)]
popup: remove previous object when content set NULL

Other widget removes previous object when set content NULL, but popup do nothing.
Of course using content_unset is able to remove previous object,
content_set(NULL) should be availalbe to remove that object for uniformity of the entire widget.

@fix

https://phab.enlightenment.org/D4885

Change-Id: I34d4f2be8ba04ac54c70b1f30d0c4a2478075eff
Signed-off-by: Jinyong Park <j4939.park@samsung.com>
7 years agolayout: add elm_layout_text_valign_set/get APIs 19/115319/8
Youngbok Shin [Fri, 17 Feb 2017 09:21:55 +0000 (18:21 +0900)]
layout: add elm_layout_text_valign_set/get APIs

There is a need of changing vertical align using API from EFL C# dev team.

* dependency warning
  - efl
  edje: add part_text_valign property for internal usage
  https://review.tizen.org/gerrit/#/c/115318/

@tizen_feature

Change-Id: Ied58ddd926f22dc2e043c379ee366487cbf2dca5