platform/upstream/efl.git
4 years agoelc_naviframe: fix double free by _title_content_del in item invalidation 95/247595/1
Jaehyun Cho [Thu, 12 Nov 2020 07:22:05 +0000 (16:22 +0900)]
elc_naviframe: fix double free by _title_content_del in item invalidation

If a box contains a button and box is set to part A and button is set to
part B, then button's _title_content_del is called when box is deleted
in item invalidation and button's pair is deleted again.

To resolve the above double free, item invalidation flag is used not to
call _title_content_del during item invalidation.

Change-Id: I3795e63470259203c3d8ae66613981bb6f8240c0

4 years agoevas vector: Added thorvg path setter. 80/246980/4
Michal Szczecinski [Wed, 4 Nov 2020 19:57:44 +0000 (20:57 +0100)]
evas vector: Added thorvg path setter.

Implementation of thorvg path setter is needed for
render properly edje vector parts.

Change-Id: Ibcbe4488e5ae46557ce1e5a896db4adbc28fa8e7

4 years agoevas vector: Added efl_duplicate api implementation for thorvg shape. 82/246982/3
Michal Szczecinski [Thu, 5 Nov 2020 10:57:53 +0000 (11:57 +0100)]
evas vector: Added efl_duplicate api implementation for thorvg shape.

This implementation is needed to render properly edje vector parts.

Change-Id: Ida8f382eef0227e996eedfc8c4add286fa0bbaee

4 years agoevas vector: Added shape path getter for thorvg. 77/246977/2
Michal Szczecinski [Wed, 4 Nov 2020 16:52:15 +0000 (17:52 +0100)]
evas vector: Added shape path getter for thorvg.

This commit adds implementation of evas_vg_shape_path_get() api for
thorvg shapes. It is needed to render edje vector parts.

Change-Id: I2a14238e9f7c051f62e9b3e592c2e9396550f3ba

4 years agoevas vector: Added path lenght get implementation for thorvg 76/246976/3
Michal Szczecinski [Wed, 4 Nov 2020 15:15:48 +0000 (16:15 +0100)]
evas vector: Added path lenght get implementation for thorvg

This commit is needed to use thorvg to render edje vector parts.

Change-Id: I55f551e4f8865fd8af7f2487dd5897e6f2a1ea7a

4 years agoevas vector: Fixed tvg_paint_set_opacity usage. 75/246975/2
Michal Szczecinski [Thu, 5 Nov 2020 11:51:59 +0000 (12:51 +0100)]
evas vector: Fixed tvg_paint_set_opacity usage.

Commit fixes invalid variable used in tvg_paint_set_opacity method. This
cause issue with invalid opacity value in shapes.

Change-Id: I44cf433e006a19955828c7972b84c935c046309c

4 years agoecore_wl2: expose subsurface interface 44/246044/8 submit/tizen/20201108.215920
Shinwoo Kim [Thu, 22 Oct 2020 11:41:30 +0000 (20:41 +0900)]
ecore_wl2: expose subsurface interface

There is a requirement to change subsurface z-order.
The Player should set display using subsurface instead
of window to show more than two video surfaces.

   - ecore_wl2_subsurface_new
   - ecore_wl2_subsurface_del
   - ecore_wl2_subsurface_sync_set
   - ecore_wl2_subsurface_native_surface_get
   - ecore_wl2_subsurface_place_surface_above
   - ecore_wl2_subsurface_place_surface_below
   - ecore_wl2_subsurface_video_surface_prepare
   - ecore_wl2_subsurface_video_surface_destination_set

Change-Id: Iba9633bad700a621642d0c874c05e24ed0e84d45

4 years agoevas canvas: Fixed svg path command processing. 76/246276/5
Michal Szczecinski [Tue, 27 Oct 2020 07:23:37 +0000 (08:23 +0100)]
evas canvas: Fixed svg path command processing.

Changes:
1. Added _parse_flag optimization
2. Set current control point properly for set type commands in path
parser.

Change-Id: Ic88180832d2a9e46828819561027eb7db56a9c38

4 years agoefl vector: use paint opacity method to toggle visibility. 56/246756/3
Hermet Park [Wed, 4 Nov 2020 02:57:26 +0000 (11:57 +0900)]
efl vector: use paint opacity method to toggle visibility.

This method simplifies efl canvas vg code in thorvg integration.

Change-Id: Ic7424f7b1bf4ac055935dffc6855c3aa7766128d

4 years agoRevert "Revert "evas_textblock: rainbow flag emoji treated as two clusters(update... 07/245507/2
WooHyun Jung [Thu, 8 Oct 2020 03:32:53 +0000 (12:32 +0900)]
Revert "Revert "evas_textblock: rainbow flag emoji treated as two clusters(update unibreak to version 4.2)""

This reverts commit 173b3a108e1b2093ac37650619a61568aaed4e04.
This was reverted because of freezing codes for release.
Now, release work was over. So, I think it's ok to restore this.

Change-Id: I3f0e5021ee1a54cb980927d89959f49af5650183

4 years agoevas_device: remove pointer data when device is removed. 79/246579/1
Hosang Kim [Mon, 2 Nov 2020 06:41:58 +0000 (15:41 +0900)]
evas_device: remove pointer data when device is removed.

revert 9fbce472029e97ed4772f0a70dfd5a24c289ea5c
revert c7092190606f593cd64ca1cccbcb50d7cab3e859
revert d8d3f5ba181dfed758de96f005a471f1aea54631

Change-Id: I41e5430e55a4bdf274fbd58f847437be071bc0a5

4 years agovg_load_svg: Prevent memory overflow for tag_name 62/246562/1
JunsuChoi [Mon, 2 Nov 2020 04:05:44 +0000 (13:05 +0900)]
vg_load_svg: Prevent memory overflow for tag_name

Summary:
When copying tag_name, if length of referenced string is longer
than general case, it is not used as tag_name.

Test Plan: N/A

Reviewers: Hermet, smohanty

Reviewed By: Hermet

Subscribers: kimcinoo, herb, cedric, #committers, #reviewers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12185

Change-Id: I2736b0b3e97b8a1ac0c3da4f18305fa7a3c80f85

4 years agoevas glengine: fix map rendering issue. 12/246512/1 accepted/tizen/unified/20201102.124241 submit/tizen/20201101.231042
Hermet Park [Fri, 30 Oct 2020 09:59:04 +0000 (18:59 +0900)]
evas glengine: fix map rendering issue.

there was a code diff - 36f9f7a3b233807c5c50d0e3e3b92104c4ccbbbb
that occured wrong upstream code merge.

Fix it by resolving code merge based on diff properly.

Change-Id: Ic6ee79dd4f8daf68108922761d46ebd54de074f2

4 years agoelm_spinner: Check new step value to avoid useless item update. 72/246072/1
Woochanlee [Fri, 23 Oct 2020 04:24:43 +0000 (13:24 +0900)]
elm_spinner: Check new step value to avoid useless item update.

@tizen_fix

Change-Id: I47c2d5f3e3861b2335da6690bcbd9d94e54790cf

4 years agoelm_spinner: Genlist item update when user changed spinner value step. 71/246071/2
Woochanlee [Fri, 23 Oct 2020 04:06:10 +0000 (13:06 +0900)]
elm_spinner: Genlist item update when user changed spinner value step.

@tizen_fix

Change-Id: Ib66fb40ff1ed67c00763309fe4db27ba90ebda25

4 years agoevas/canvas/vg: Added integration with thorvg. 25/243325/17
Michal Szczecinski [Fri, 4 Sep 2020 11:28:18 +0000 (13:28 +0200)]
evas/canvas/vg: Added integration with thorvg.

If flag HAVE_THORVG is defined, thorVG lib is used to render vector
graphics. To change flag see meson_options.txt file.

To test this solution newly added examples can be used. You can find
it in src/examples/evas/evas-vg-*

Change-Id: I9765b3fc53cf77b340bd3a75d8029795f2648302

4 years agofix gengrid group index unrealized issue 86/245986/1
SangHyeon Jade Lee [Wed, 21 Oct 2020 07:17:14 +0000 (16:17 +0900)]
fix gengrid group index unrealized issue

gengrid group index need to be unrealized when item is not in the
viewport unlike upstream realized till their group is one the view.

Change-Id: Ie2dbb2f0a58ac563c43cfd0b45bc7b88aefd5ebf

4 years agoevas/textblock: apply style paddings in fit calculation 77/245977/1
Youngbok Shin [Wed, 21 Oct 2020 05:45:05 +0000 (14:45 +0900)]
evas/textblock: apply style paddings in fit calculation

The style paddings should be calculated for fitting text into
the given object's size.

@fix

Change-Id: Id68a23c7ec63e3874ff2ff70fdf838ad2092612e

4 years agoadd example of container transformations 20/245820/4
Piotr Kalota [Fri, 16 Oct 2020 07:09:50 +0000 (09:09 +0200)]
add example of container transformations

Change-Id: I12deb95dc908be8510fe8409e3aee107c6a3c6ec

4 years agovg_load_svg: Implement ClipPath feature 89/245889/1
JunsuChoi [Wed, 14 Oct 2020 10:16:53 +0000 (19:16 +0900)]
vg_load_svg: Implement ClipPath feature

Summary:
Supports case of using style attribute for defined <clipPath> and node.
In SVG, <clipPath> can be used as a "clipPath" attribute or a style "clip-path".
If there is a clip-path node, save it as a composition node and
use composition method(matte_alpha) to compose it.

Below node types support clip-path.
<circle>
<ellipse>
<g>
<path>
<polygon>
<polyline>
<rect>

Test Plan:
Please see attached svg files
{F4026162}

Reviewers: Hermet, smohanty

Reviewed By: Hermet

Subscribers: #reviewers, #committers, cedric, herb, kimcinoo

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12179

Change-Id: I1e02b0405d32ebea4ba9b072586aaad7248ee598

4 years agottrace: disable ttrace logs 01/245801/1 submit/tizen/20201018.221456
Wonki Kim [Fri, 16 Oct 2020 02:12:37 +0000 (11:12 +0900)]
ttrace: disable ttrace logs

there are lots of logs generated caused by ttrace.
and ttrace isn't used often but it's used for performance profiling in some time.
this patch disable ttrace logs for reducing space and time complexity.

Change-Id: I2fa86e3f807ad88d610a5a2bac87fa2ef51d043b

4 years agoevas svg: avoid unnecessary memory clear. 63/245563/2 submit/tizen/20201012.232328
Hermet Park [Mon, 12 Oct 2020 09:37:55 +0000 (18:37 +0900)]
evas svg: avoid unnecessary memory clear.

Change-Id: Ia2155716f2f18c1056852a50d0007b2c3f591f52

4 years agovg_load_svg: Add points copy of missing polygon/polyline 61/245561/1
JunsuChoi [Mon, 12 Oct 2020 09:36:31 +0000 (18:36 +0900)]
vg_load_svg: Add points copy of missing polygon/polyline

Summary:
When using <use> node, do atrribute copy.
At that time, when target(url) is polygon or polyline,
points array is not copied, causing a problem in output.
So, add missing array copy.

Test Plan:
 - Test SVG code

<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px"
viewBox="0 0 64 64" enable-background="new 0 0 64 64" xml:space="preserve">
    <g opacity="0.5">
        <defs>
            <polygon id="test" opacity="0.5" points="41.8,14.5 22.2,14.5 22.2,22.8 41.8,40.7"/>
        </defs>
        <use xlink:href="#test"  overflow="visible"/>
    </g>
</svg>

Reviewers: Hermet, smohanty

Reviewed By: Hermet

Subscribers: #reviewers, #committers, kimcinoo, herb, cedric

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12174

Change-Id: Iecbed3a953d7e7465b54e9c648474ca8f9480e0a

4 years agoevas/font: free fg if fash memory allocation is failed 36/245536/1
Youngbok Shin [Mon, 12 Oct 2020 04:52:11 +0000 (13:52 +0900)]
evas/font: free fg if fash memory allocation is failed

Change-Id: Iad3eec4225f333aad44ba1f6f2c606bb08006b46

4 years agospec: bump version for 1.25.1 release
Jongmin Lee [Sun, 11 Oct 2020 21:30:21 +0000 (06:30 +0900)]
spec: bump version for 1.25.1 release

Change-Id: Ia4296aec78748a9c22aa06a29094404fbc1e5921

4 years agorelease: Update NEWS and bump version for 1.25.1 release
Stefan Schmidt [Thu, 8 Oct 2020 08:41:04 +0000 (10:41 +0200)]
release: Update NEWS and bump version for 1.25.1 release

4 years agoEcore_file: on Windows, fix errno value when dst exists.
Vincent Torri [Tue, 6 Oct 2020 14:09:31 +0000 (15:09 +0100)]
Ecore_file: on Windows, fix errno value when dst exists.

Summary: This also fixes the saving of elementary_config file

Test Plan: execution of elementary_config

Reviewers: jptiz, raster

Reviewed By: raster

Subscribers: johnny1337, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12165

4 years agoedje_entry: fix a potentional error of null deref 08/245308/1
Wonki Kim [Thu, 6 Aug 2020 00:46:24 +0000 (00:46 +0000)]
edje_entry: fix a potentional error of null deref

this is a patch to fix a potentional error by null dereferencing.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D12087

Change-Id: I88bd17cd6721d929356f759b0ef10fc0d4085493

4 years agoRevert "edje_entry: fix a potentional error of null deref" 07/245307/1
Wonki Kim [Wed, 7 Oct 2020 03:11:28 +0000 (12:11 +0900)]
Revert "edje_entry: fix a potentional error of null deref"

This reverts commit 807b0e3135ed5465013911ca8a6904b9d23e2eff.

Change-Id: Ib444d664e8420a29c888f4bafa447e2bb42d7e65

4 years agoedje_entry: fix a potentional error of null deref 01/245301/1
Wonki Kim [Thu, 6 Aug 2020 00:46:24 +0000 (00:46 +0000)]
edje_entry: fix a potentional error of null deref

this is a patch to fix a potentional error by null dereferencing.

Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D12087

Change-Id: If5355e8594532af29c8370144b5e90cb6ddbba71

4 years agoWindows: fix copy'n paste
Vincent Torri [Wed, 30 Sep 2020 12:59:27 +0000 (13:59 +0100)]
Windows: fix copy'n paste

Summary: fix seat id and clean cnp data when needed

Test Plan: Ctrl-c and Ctrl-V (elm-->app, app--> elm elm-->elm)

Reviewers: jptiz, walac, cochisecesar, bu5hm4n, felipealmeida, raster

Reviewed By: felipealmeida, raster

Subscribers: netstar, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12166

4 years agoefreet - windows - still call stat but skip lstat/readlink
Carsten Haitzler (Rasterman) [Tue, 29 Sep 2020 09:30:45 +0000 (10:30 +0100)]
efreet - windows - still call stat but skip lstat/readlink

now stat is filled with data on windows

@fix

4 years agoevas: sw font draw - protect against null pointer access
Youngbok Shin [Thu, 24 Sep 2020 09:12:06 +0000 (09:12 +0000)]
evas: sw font draw - protect against null pointer access

The image data of dst could be null in a rare case.
@fix

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D12163

4 years agoevas/font: fix a memory leak caused by legacy code with wrong migration 60/245260/1
Youngbok Shin [Tue, 6 Oct 2020 06:28:33 +0000 (15:28 +0900)]
evas/font: fix a memory leak caused by legacy code with wrong migration

@tizen_fix

Change-Id: I51d570ddc8e3a545547c00b73ffb86f1ef1f7451

4 years agodocs: Corrects invalid URL for Elementary page 53/245253/1 accepted/tizen/6.0/unified/20201110.230839 accepted/tizen/6.0/unified/hotfix/20201102.235826 accepted/tizen/unified/20201007.020756 submit/tizen/20201006.054255 submit/tizen_6.0/20201029.205501 submit/tizen_6.0/20201110.051438 submit/tizen_6.0_hotfix/20201102.192901 submit/tizen_6.0_hotfix/20201103.115101 tizen_6.0.m2_release
Myoungwoon Roy, Kim [Tue, 6 Oct 2020 05:29:22 +0000 (14:29 +0900)]
docs: Corrects invalid URL for Elementary page

Change-Id: I6d3dd04fe277729aa58cf04a9a6d6260894cc49c

4 years agoelementary image zoomable: fix non supported oversized image. 59/245159/1 accepted/tizen/unified/20201006.044403 submit/tizen/20201005.082948
Hermet Park [Mon, 5 Oct 2020 03:56:03 +0000 (12:56 +0900)]
elementary image zoomable: fix non supported oversized image.

Summary:
if image size is larger than system support, photocam can not show the image.

Not like other types of image, photocam is originally designed for huge-size of image,
this result is not allowed by users, we should avoid the worst case as we can do.

This might not be the best idea, so you can improve it if you have a better solution.

Reviewers: kimcinoo

Reviewed By: kimcinoo

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12164

Change-Id: I6e542227062dae8d42fd870d1e6a69a935df5d12

4 years agodocs: Change non public Tizen Elementary APIs to internal 54/245154/1 accepted/tizen/unified/20201005.101332 submit/tizen/20201005.012108
Myoungwoon Roy, Kim [Mon, 5 Oct 2020 00:03:43 +0000 (09:03 +0900)]
docs: Change non public Tizen Elementary APIs to internal

Change-Id: I19b3afe821c29031a08f473df6f846b7c6a063af

4 years agobuild: addition to abf0e9dffe35da8fa6e20055f53786b2adbec271 accepted/tizen/unified/20200928.072827 submit/tizen/20200927.213403
Marcel Hollerbach [Fri, 25 Sep 2020 12:05:16 +0000 (14:05 +0200)]
build: addition to abf0e9dffe35da8fa6e20055f53786b2adbec271

the fix is also needed in ecore_imf modules.

Thank you Ross!

4 years agoEthumb: reorder _init/shutdown functions, ecore and evas init/shutdown are useless...
Vincent Torri [Fri, 25 Sep 2020 09:30:04 +0000 (10:30 +0100)]
Ethumb: reorder _init/shutdown functions, ecore and evas init/shutdown are useless, as ecore_evas already manages them

Test Plan: compilation

Reviewers: raster

Reviewed By: raster

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12161

4 years agoedje_external_inspector: re-order _init a bit: log after eina, remove ecore_init...
Vincent Torri [Fri, 25 Sep 2020 09:29:54 +0000 (10:29 +0100)]
edje_external_inspector: re-order _init a bit: log after eina, remove ecore_init/shutdown as it is already managed by edje_init/shutdown

Reviewers: raster

Reviewed By: raster

Subscribers: raster, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12160

4 years agobuild: fix dependencies of software engine
Marcel Hollerbach [Thu, 24 Sep 2020 08:28:27 +0000 (10:28 +0200)]
build: fix dependencies of software engine

before the efl-one refactoring ecore_x_deps contained all the
dependencies for x11. After that not anymore, however, we should link
software_x11 to x11 libs directly, which is again happening after this
here.

4 years agoNEWS: fix some typos for 1.25 update
Stefan Schmidt [Wed, 23 Sep 2020 08:15:53 +0000 (10:15 +0200)]
NEWS: fix some typos for 1.25 update

Vicent spotted some typos. Get them fixed here.

4 years agoevas vg: check vg changed 70/244770/1
Shinwoo Kim [Thu, 24 Sep 2020 03:16:49 +0000 (12:16 +0900)]
evas vg: check vg changed

Summary:
It is not able to render even though vg object has a chance to render,
because evas_object_smart_changed_get checks only Evas_Object_Protected_Data,
when Efl_Canvas_Vg_Object_Data.changed is TRUE.

Reviewers: Hermet, jsuya, herb

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12152

Change-Id: Ic318e176e18a97bbb015f2e50008b70ffc565211

4 years agodocs: Changes non public Tizen Elementary APIs to internal 41/244741/1 accepted/tizen/unified/20200928.004556 submit/tizen/20200925.001651
Myoungwoon Roy, Kim [Thu, 24 Sep 2020 01:33:26 +0000 (10:33 +0900)]
docs: Changes non public Tizen Elementary APIs to internal

Change-Id: I29aac5af360035f887406491de850efd50e6c175

4 years agowayland_shm: Check tbm_client validation. 89/244689/1 accepted/tizen/unified/20200924.001846 submit/tizen/20200923.083532
Woochanlee [Wed, 23 Sep 2020 08:05:22 +0000 (17:05 +0900)]
wayland_shm: Check tbm_client validation.

In certain use case, the tbm_client has been deinited when _evas_outbuf_redraws_clear called.
It cause crash.

Change-Id: Ibdc75b3cf66a541e5ac5568e604c54a137f2eb8d

4 years agorelease: Update NEWS and bump version for 1.25.0 release
Stefan Schmidt [Tue, 22 Sep 2020 17:54:20 +0000 (19:54 +0200)]
release: Update NEWS and bump version for 1.25.0 release

4 years agoecore_wl2_window: update window's saved size in xdg_surface_configure callback 00/244600/2
Doyoun Kang [Tue, 22 Sep 2020 08:01:32 +0000 (17:01 +0900)]
ecore_wl2_window: update window's saved size in xdg_surface_configure callback

There was a bug that the window was resized to old size when the window's state changed
to unmaximize and unfullscreen.
This patch updates window's saved size when the window which state is both unmaximize
and unfullscreen.

@tizen_fix

Change-Id: I63decf2113f26f2cfb8378c2a29ff39455ffcf36
Signed-off-by: Doyoun Kang <doyoun.kang@samsung.com>
4 years agoefl_gfx_path: When path end(Z,z), Current point are returned to starting point(M,m) 81/244581/1
JunsuChoi [Tue, 22 Sep 2020 05:52:42 +0000 (14:52 +0900)]
efl_gfx_path: When path end(Z,z), Current point are returned to starting point(M,m)

Summary:
When path ends with 'z' or 'Z' command, if 'm' comes as next command,
the current point is incorrectly referenced.
Since 'Z', 'z' means to close the path,
so, Save point and reuse it when 'M' or 'm' is called.

Test Plan:
[Error Case]
<svg id="Layer_1" data-name="Layer 1" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 64 64">
    <path d="M 52.17,20
             H 11.92
             V 43
             H 52.17
             Z
             m -1.5,21.5
             H 13.42
             v -20
             H 50.67
             Z
" fill="#a8b7c1" stroke="#F00" stroke-width="0.5" />
</svg>

Reviewers: Hermet, smohanty

Reviewed By: Hermet

Subscribers: cedric, herb, kimcinoo, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12158

Change-Id: Ib9104707d3c3297e5cc6a856b3c50c18e288a2d0

4 years agoelm_config: don't prepend /tmp/ to file name
Vincent Torri [Mon, 21 Sep 2020 06:22:40 +0000 (06:22 +0000)]
elm_config: don't prepend /tmp/ to file name

eina_file_mkstemp() already takes care of this.

Differential Revision: https://phab.enlightenment.org/D12155

4 years agoRevert "elm - collection view - check return and fix coverity wanring"
Stefan Schmidt [Mon, 21 Sep 2020 09:06:39 +0000 (11:06 +0200)]
Revert "elm - collection view - check return and fix coverity wanring"

This reverts commit f3fdcf56923c8a2ca126e14d915e6386c7c4ff7e.

This commit leads to ninja test timeout. When returning result here the
future will never fire and we will keep spinning.

4 years agoelm - toiolbar - use correct theme icon for more item
Carsten Haitzler (Rasterman) [Mon, 21 Sep 2020 08:35:06 +0000 (09:35 +0100)]
elm - toiolbar - use correct theme icon for more item

there is a specific thme icon for "more" items when a toolbar
compresses. it literally was not being used. it should use it.
"go-down" that it was using isn't exactly very expressive of what this
item does...

@fix

4 years agoecore - efl thread - dont close invalid < 0 fd's accepted/tizen/unified/20200923.024107 submit/tizen/20200920.213436
Carsten Haitzler (Rasterman) [Sat, 19 Sep 2020 23:06:30 +0000 (00:06 +0100)]
ecore - efl thread - dont close invalid < 0 fd's

fix CID 1396951

4 years agoecore - efl exe - check returns of open and dup2 for stdin etc. fds
Carsten Haitzler (Rasterman) [Sat, 19 Sep 2020 22:59:59 +0000 (23:59 +0100)]
ecore - efl exe - check returns of open and dup2 for stdin etc. fds

check returns - fix CID 1397002

4 years agoeina bench - have default values inside benc dtoa
Carsten Haitzler (Rasterman) [Sat, 19 Sep 2020 22:48:45 +0000 (23:48 +0100)]
eina bench - have default values inside benc dtoa

addess CID 1400856

4 years agoevas test - check return of ftell and malloc and handle properly
Carsten Haitzler (Rasterman) [Sat, 19 Sep 2020 22:43:58 +0000 (23:43 +0100)]
evas test - check return of ftell and malloc and handle properly

fix CID 1400871

4 years agoeina thread - check return of pthread_attr_init
Carsten Haitzler (Rasterman) [Sat, 19 Sep 2020 22:37:22 +0000 (23:37 +0100)]
eina thread - check return of pthread_attr_init

fix CID 1401031

4 years agoemotion - check return of eet data write
Carsten Haitzler (Rasterman) [Sat, 19 Sep 2020 22:34:39 +0000 (23:34 +0100)]
emotion - check return of eet data write

fix CID 1401040

4 years agoethumb - fix idx range check
Carsten Haitzler (Rasterman) [Sat, 19 Sep 2020 22:15:44 +0000 (23:15 +0100)]
ethumb - fix idx range check

fix CID 1402612

4 years agoethumb - fix index range check
Carsten Haitzler (Rasterman) [Sat, 19 Sep 2020 22:13:08 +0000 (23:13 +0100)]
ethumb - fix index range check

fix CID 1402628

4 years agoethumb - fix index range check
Carsten Haitzler (Rasterman) [Sat, 19 Sep 2020 22:11:53 +0000 (23:11 +0100)]
ethumb - fix index range check

fix CID 1402631

4 years agoethumb - check size read
Carsten Haitzler (Rasterman) [Sat, 19 Sep 2020 22:09:05 +0000 (23:09 +0100)]
ethumb - check size read

fix CID 1402633

4 years agoethumb - check inoput index from stdin
Carsten Haitzler (Rasterman) [Sat, 19 Sep 2020 22:03:20 +0000 (23:03 +0100)]
ethumb - check inoput index from stdin

fix CID 1402646

4 years agoevas - psd loader - check read values to try make coverity happy
Carsten Haitzler (Rasterman) [Sat, 19 Sep 2020 21:32:57 +0000 (22:32 +0100)]
evas - psd loader - check read values to try make coverity happy

this is trying to fix CID 1402688, 1402687, 1402682, 1402665. not sure
it will or will not but it does dot i's and cross t's

4 years agoelm - collection view - check return and fix coverity wanring
Carsten Haitzler (Rasterman) [Sat, 19 Sep 2020 19:38:12 +0000 (20:38 +0100)]
elm - collection view - check return and fix coverity wanring

fix CID 1405808

4 years agoecore con url - curl is actually optional and only needs to init on use
Carsten Haitzler (Rasterman) [Mon, 14 Sep 2020 10:09:08 +0000 (11:09 +0100)]
ecore con url - curl is actually optional and only needs to init on use

ecore_con_utl_init is kind of pointless when we can init at the first
use of a url and just have it fail. the problem is anyone initting
ecore_con's url stuff will then pull in curl at that point and not
laer "on first use" which is kind of nw how the dlopen fun was
intended, so push it off until then.

4 years agoelm_config: remove useless init|shutdown of ecore_win32 and eocore_cocoa (done in...
Vincent Torri [Thu, 17 Sep 2020 16:26:59 +0000 (16:26 +0000)]
elm_config: remove useless init|shutdown of ecore_win32 and eocore_cocoa (done in ecore_evas module), and useless wayland variable

ecore_win32 and ecore_cocoa was init. wayland variable was also unused

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D12149

4 years agocall sd_seat_can_tty to determine if ttys should be used, instead of hard-coding...
nerdopolis [Fri, 18 Sep 2020 09:44:23 +0000 (11:44 +0200)]
call sd_seat_can_tty to determine if ttys should be used, instead of hard-coding seat0

Summary: All TTYs are on seat0, but not all seat0s have TTYs

Reviewers: #efl, devilhorns

Reviewed By: #efl, devilhorns

Subscribers: bu5hm4n, stefan_schmidt, raster, cedric, #reviewers, #committers

Tags: #efl

Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D12143

4 years agoelm_slider: add A11Y value interface 78/244178/3
Kamil Konieczny [Tue, 15 Sep 2020 11:45:19 +0000 (13:45 +0200)]
elm_slider: add A11Y value interface

Add A11Y value inteface to slider legacy object.

Change-Id: I457270d0abe185e3c57873a92c2052ceeb0675cf

4 years agoefl_ui_widget, elc 46/244346/3 accepted/tizen/unified/20200923.024030 submit/tizen/20200918.044325
Taehyub Kim [Thu, 17 Sep 2020 11:09:09 +0000 (20:09 +0900)]
efl_ui_widget, elc
_popup : disable auto scroll function for popup scroller

Change-Id: I8873c13f4929787ee4c359c7c82a87f45c2dcd64

4 years agoedje_entry: prevent cursor position change in selection state 06/244306/3
Bowon Ryu [Thu, 17 Sep 2020 06:05:29 +0000 (15:05 +0900)]
edje_entry: prevent cursor position change in selection state

this patch prevents the cursor position from change due to mouse up on selection state

Change-Id: I57458f72aad1e5be0afdde1be7664c2e48004c26
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
4 years agoevas_outbuf: Fix memory leak.
Woochanlee [Thu, 17 Sep 2020 08:23:41 +0000 (17:23 +0900)]
evas_outbuf: Fix memory leak.

Summary: In certain use cases, when image data is created twice, the existing memory pointer is isolated and a memory leak occurs.

Reviewers: raster, Hermet

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Maniphest Tasks: T8813

Differential Revision: https://phab.enlightenment.org/D12148

4 years agoevas_main: Fix memory leak.
Woochanlee [Thu, 17 Sep 2020 08:23:10 +0000 (17:23 +0900)]
evas_main: Fix memory leak.

Summary: If the inlist has only one item when it removed. the data is not freed in descturctor.

Reviewers: Hermet, raster, vtorri

Reviewed By: Hermet

Subscribers: vtorri, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12147

4 years agodocs: Corrects EFL main pages and Changes non public Tizen Elementary APIs to internal 11/244311/2
Myoungwoon Roy, Kim [Thu, 17 Sep 2020 06:39:35 +0000 (15:39 +0900)]
docs: Corrects EFL main pages and Changes non public Tizen Elementary APIs to internal

Change-Id: I8442e25725aa28222bef6f6de75d57dc28ccc2c0

4 years agoevas vg: check object changed as well 2 88/244288/1
Shinwoo Kim [Thu, 17 Sep 2020 01:40:24 +0000 (10:40 +0900)]
evas vg: check object changed as well 2

Summary:
evas cannot render vg object if Efl_Canvas_Vg_Node_Data flag is not
EFL_GFX_CHANGE_FLAG_NONE and Evas_Object_Protected_Data.changed is FALSE,
when vg object marks its node as changed.

Above case could be possible if vg object render_pre is not called, and
only nd->vd->obj->changed is set to false by evas_object_change_reset.

Reviewers: Hermet, jsuya, herb

Reviewed By: Hermet

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12142

Change-Id: I628b3596c282354005ae2a36209460d68bb43c01

4 years agoevas_textblock: prevent textnodes with <ps>/<br> without format node
Ali Alzyod [Mon, 14 Sep 2020 16:30:06 +0000 (16:30 +0000)]
evas_textblock: prevent textnodes with <ps>/<br> without format node

this will prevent textnodes content with <ps> or <br> without format node

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D12145

4 years agoedje_entry: prevent incorrect cursor position during preedit 35/244035/3 accepted/tizen/unified/20200917.030601 submit/tizen/20200916.073812
Bowon Ryu [Mon, 14 Sep 2020 07:51:03 +0000 (16:51 +0900)]
edje_entry: prevent incorrect cursor position during preedit

due to the influence of elm_entry_filter_limit_size,
"cursor_pos" from imf and "end_pos - start_pos" may be different.
in particular, if the preedit string can not be entered at all due to filter,
cursor_pos is larger than 0, so the cursor moves to an unintended position.

This patch avoids the issue by moving the cursor's position to end_pos in this case.

@tizen_fix

Change-Id: Ie7ad48ad02ecbf26a0bedab960cd0bf9042a5995
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
4 years agovg_load_svg: Support dasharray attribute for stroke 44/244144/1
JunsuChoi [Tue, 15 Sep 2020 03:11:49 +0000 (12:11 +0900)]
vg_load_svg: Support dasharray attribute for stroke

Summary:
It supports stroke-dasharray, one of the stroke properties of svg.
https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/stroke-dasharray

Test Plan:
[Test SVG]
<svg viewBox="0 0 30 10" xmlns="http://www.w3.org/2000/svg">
  <!-- No dashes nor gaps -->
  <line x1="0" y1="1" x2="30" y2="1" stroke="black" />

  <!-- Dashes and gaps of the same size -->
  <line x1="0" y1="3" x2="30" y2="3" stroke="black"
          stroke-dasharray="4" />

  <!-- Dashes and gaps of different sizes -->
  <line x1="0" y1="5" x2="30" y2="5" stroke="black"
          stroke-dasharray="4 1" />

  <!-- Dashes and gaps of various sizes with an odd number of values -->
  <line x1="0" y1="7" x2="30" y2="7" stroke="black"
          stroke-dasharray="4 1 2" />

  <!-- Dashes and gaps of various sizes with an even number of values -->
  <line x1="0" y1="9" x2="30" y2="9" stroke="black"
          stroke-dasharray="4 1 2 3" />
</svg>

Reviewers: Hermet, smohanty

Reviewed By: Hermet

Subscribers: kimcinoo, herb, cedric, #committers, #reviewers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12146

Change-Id: I05d6a302b7f9546e68bd393da1890869cf599e6e

4 years agorelease: Update NEWS and bump version for 1.25.0-beta3 release
Stefan Schmidt [Mon, 14 Sep 2020 10:12:31 +0000 (12:12 +0200)]
release: Update NEWS and bump version for 1.25.0-beta3 release

4 years agoelm_dnd: clean up the registered target object when elm_drop_target_del API is called 55/244055/2 accepted/tizen/unified/20200915.014603 submit/tizen/20200914.112517
Taehyub Kim [Mon, 14 Sep 2020 10:48:27 +0000 (19:48 +0900)]
elm_dnd: clean up the registered target object when elm_drop_target_del API is called

@fix

Change-Id: Idbe9d1412093c25e3fa4b20e537d17f70ac5556b

4 years agoEfl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously 41/243941/2
JunsuChoi [Fri, 11 Sep 2020 08:02:23 +0000 (17:02 +0900)]
Efl.Canvas.Vg: When VG container has transparency, ector buffer created synchronously

Summary:
If the container has transparency, it internally alpha blends with ector buffer.
So ector buffer must be created synchronously.

Test Plan: N/A

Reviewers: Hermet, smohanty

Reviewed By: Hermet

Subscribers: #reviewers, #committers, cedric, herb, kimcinoo

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12140

Change-Id: I00c8560e9fb8f021cba219dd8105dda90dc8deed

4 years agoui_widget: restore hide callback for sub-object 37/243937/1 accepted/tizen/unified/20200914.131356 submit/tizen/20200913.215058
Yeongjong Lee [Fri, 11 Sep 2020 08:21:19 +0000 (17:21 +0900)]
ui_widget: restore hide callback for sub-object

In commit 8d47ced0497c7d24203a16c5011c57928822024e, hide callback to restore
focus was removed. this patch restores the hide callback to fix focus issue
when hiding a focused widgets.

@tizen_fix

Change-Id: I07cd3bcc329316a03a6e418141c11403a7d49d0d

4 years agovg_load_svg: Add Mask, ClipPath nodees as dummy. 27/243927/1
JunsuChoi [Fri, 11 Sep 2020 02:49:09 +0000 (11:49 +0900)]
vg_load_svg: Add Mask, ClipPath nodees as dummy.

Summary:
Mask and clippath TAG are not supported yet.
If this TAG is used, the Child TAG declared with this TAG may cause problems.
To prevent that, declare them as Unknown types until they are supported. (display=none)

Test Plan: N/A

Reviewers: Hermet, smohanty

Reviewed By: Hermet

Subscribers: cedric, herb, #reviewers, kimcinoo, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12139

Change-Id: I007c4538d9b2ab92b6b58e954215c63a23541d18

4 years agovg_load_svg: Fix missing loader.gradients update 26/243926/1
JunsuChoi [Fri, 11 Sep 2020 02:48:30 +0000 (11:48 +0900)]
vg_load_svg: Fix missing loader.gradients update

Summary:
When both <defs> and <svg> gradients are declared,
the update of gradient declared in is omitted.
Therefore, this patch fixes any missing gradient updates.

Test Plan: N/A

Reviewers: Hermet, smohanty

Reviewed By: Hermet

Subscribers: #reviewers, #committers, cedric, herb, kimcinoo

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12138

Change-Id: I82cb746931484041cc0662a5ad770dce1efcc1d2

4 years agoEfl.Canvas.Vg.Object: Fix typo 25/243925/1
JunsuChoi [Fri, 11 Sep 2020 02:46:58 +0000 (11:46 +0900)]
Efl.Canvas.Vg.Object: Fix typo

Summary:
The 3th parameter of ector_buffer_pixels_get is the width.
So chnage px to pw.

Test Plan: N/A

Reviewers: Hermet, smohanty

Reviewed By: Hermet

Subscribers: cedric, herb, #reviewers, kimcinoo, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12141

Change-Id: I05555f5583bb5a8cadc7bff25422af01731befa8

4 years agoelm_spinner: Fix button and entry show/hide transition timing. 09/243909/1 submit/tizen/20200911.065559
Woochanlee [Fri, 11 Sep 2020 06:39:05 +0000 (15:39 +0900)]
elm_spinner: Fix button and entry show/hide transition timing.

If the signal emiited after show/hide API calling,
internal edje calc logic will broken.

@tizen_fix

Change-Id: Ib5fa1a4bfeea0867f27faeddd00f3e0e9ccdbbd3
Signed-off-by: Woochanlee <wc0917.lee@samsung.com>
4 years agodocs: Correct the mismatched group name in Evas.
Myoungwoon Roy, Kim [Mon, 7 Sep 2020 08:49:53 +0000 (08:49 +0000)]
docs: Correct the mismatched group name in Evas.

I had found mismatched group name in Evas and fixed them.

Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D12134

4 years agovg_load_svg: Supports case when only rx or ry is declared
JunsuChoi [Thu, 10 Sep 2020 05:59:29 +0000 (14:59 +0900)]
vg_load_svg: Supports case when only rx or ry is declared

Summary:
In relation to the declaration of rx and ry attribute of rect, the following three cases occur.
rx="10" (or ry="10"
rx="10" ry = "0" (or rx="0" ry = "10")
rx="10" ry = "10"
To cover these case, we check the rx and ry declarations.

Test Plan: N/A

Reviewers: Hermet, smohanty

Subscribers: kimcinoo, herb, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12137

4 years agoevas vg: check object changed as well
Shinwoo Kim [Wed, 9 Sep 2020 11:14:48 +0000 (12:14 +0100)]
evas vg: check object changed as well

Summary:
evas cannot render vg object if Efl_Canvas_Vg_Object_Data.changed is ture
and Evas_Object_Protected_Data.changed is false, when vg object marks itself
as changed.

Above case is possible depending on the draw area which is calculated by
eng_output_redraws_next_update_get. If this function returns NULL,
the vg object render function is not called, and vd->changed remains true.
Only vd->obj->changed is set to false by vas_object_change_reset.

Reviewers: Hermet, jsuya, herb, raster

Reviewed By: raster

Subscribers: raster, cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12136

4 years agoecore_evas_wayland_common: check device class when device is added. 98/243598/2
Hosang Kim [Tue, 8 Sep 2020 10:32:19 +0000 (19:32 +0900)]
ecore_evas_wayland_common: check device class when device is added.

Change-Id: I1d73f9cbf34bb46a01f2428dda4cf9443187c508

4 years agoevas/canvas/vg: Added thorvg initialization. 14/241114/4
Michal Szczecinski [Fri, 7 Aug 2020 07:04:42 +0000 (09:04 +0200)]
evas/canvas/vg: Added thorvg initialization.

Added thorvg initialization in evas_vg_cache. To don't break current
code, added separated functions to render object when thorvg lib is
used.

Change-Id: I2ea361fab9758a170f971dc7a731eded9d45b0e6

4 years agoelm_entry: legacy smart selection[start,cleared] callback fix 62/243562/1
Ali Alzyod [Tue, 8 Sep 2020 06:55:30 +0000 (15:55 +0900)]
elm_entry: legacy smart selection[start,cleared] callback fix

Summary:
due to changes in latest text apis in unified, legacy selection call back [start,clear] does not work anymore,
Now add the support for legacy callback [selection,start   selection,cleared]

Reviewers: woohyun, bowonryu, stefan_schmidt

Reviewed By: bowonryu

Subscribers: cedric, #reviewers, #committers

Tags: #efl

Differential Revision: https://phab.enlightenment.org/D12126

Change-Id: Ib23e07470d3ff28caecc700d26047c3245d28f8a

4 years agoedje: resolve the possible use of uninitialized value 91/243391/2
Jongmin Lee [Mon, 7 Sep 2020 08:31:26 +0000 (17:31 +0900)]
edje: resolve the possible use of uninitialized value

Change-Id: I5243bb5a0a703812f7b4ef02642f6f0f669e7933

4 years agoCreated gradient manipulation example 99/243499/2
Michal Maciola [Mon, 24 Aug 2020 09:30:52 +0000 (11:30 +0200)]
Created gradient manipulation example

Change-Id: I2f58fba0f6260cf57dbcc58aa59ba26a80eb24ce

4 years agorelease: Update NEWS and bump version for 1.25.0-beta2 release
Stefan Schmidt [Mon, 7 Sep 2020 10:54:04 +0000 (12:54 +0200)]
release: Update NEWS and bump version for 1.25.0-beta2 release

4 years agoelm_gesture_layer: fix crash caused by elm_gesture_layer_cb_del in cb
Jaehyun Cho [Mon, 7 Sep 2020 05:35:12 +0000 (14:35 +0900)]
elm_gesture_layer: fix crash caused by elm_gesture_layer_cb_del in cb

elm_gesture_layer_cb_del can be called in Elm_Gesture_Event_Cb cb set by
elm_gesture_layer_cb_set and cb_info of the cb is free in the cb.

This causes crash if cb_info is searched with EINA_INLIST_FOREACH.

4 years agoRevert "atspi: get_at_point and neighbor navigation unified" 19/243319/3
Kamil Konieczny [Fri, 4 Sep 2020 12:31:19 +0000 (14:31 +0200)]
Revert "atspi: get_at_point and neighbor navigation unified"

When there is floating button on screen, it is not available
for atspi highlight on OneFingerSingleTap. Reverting this commit
fixes it.

This reverts commit 98d14ca80d3d5540760ff41d85f2c61e7bd40c6b

Change-Id: If4204374b081e8711e17e37f9f23081c7486e815

4 years agoelm cnp - make matchers const and static too accepted/tizen/unified/20200907.045103 submit/tizen/20200906.212734
Carsten Haitzler (Rasterman) [Sat, 5 Sep 2020 14:03:44 +0000 (15:03 +0100)]
elm cnp - make matchers const and static too

4 years agoelm_cnp: adjust image type to real format
Marcel Hollerbach [Sat, 5 Sep 2020 07:07:12 +0000 (09:07 +0200)]
elm_cnp: adjust image type to real format

we should never say that we have image/png etc. if we do not have the
respective format. Otherwise we are just confusing the other client.

With this you can copy things from elm to thunderbird / libreoffice
writer / firefox / telegram / chromium.

Please note if you test this: Start *a new xorg session* it was
discovered that xorg clients tent to be totally confused if there was a
protocol error before, or some wrong mime type was delivered before,
thunderbird even likes to crash if this is not done.

This should at some point be extended to more image types.

4 years agoecore_evas_x: reply in *any* way with XdndStatus
Marcel Hollerbach [Fri, 4 Sep 2020 16:22:49 +0000 (18:22 +0200)]
ecore_evas_x: reply in *any* way with XdndStatus

otherwise Xorg stops sometimes to continue sending callbacks to us.
Which results in a broken state maschine.

4 years agoecore x - fix typo in internal backdoor api to get vsync debug
Carsten Haitzler (Rasterman) [Fri, 4 Sep 2020 13:39:15 +0000 (14:39 +0100)]
ecore x - fix typo in internal backdoor api to get vsync debug