Yeongjong Lee [Wed, 18 Sep 2019 04:05:28 +0000 (13:05 +0900)]
efl_ui_layout: call group_calculate in sizing_eval
`efl_canvas_group_calculate` should be called in _elm_layout_sizing_eval, not in
`_elm_layout_efl_canvas_group_change`.
@tizen_fix
ref
74a63bdc3900523e6648e3e8915c4577d7145e33
Change-Id: I33adf51258c15a0f2050cd9c82a1547d8a3e6ac5
Cedric Bail [Fri, 13 Sep 2019 17:43:42 +0000 (10:43 -0700)]
elementary: properly shutdown and cleanup Efl.Ui.Position_Manager.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9946
Cedric Bail [Sun, 15 Sep 2019 05:22:27 +0000 (22:22 -0700)]
elementary: fix double eina_value_free in Efl.Ui.Homogeneous_Model.property.set
Model do not own the Eina_Value when it is set on them. They can make a copy of it,
but shouldn't free it.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9945
Cedric Bail [Mon, 16 Sep 2019 05:37:59 +0000 (22:37 -0700)]
ecore: remove unused variable after code migration. Fix warning.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D9944
Cedric Bail [Sun, 15 Sep 2019 02:13:04 +0000 (19:13 -0700)]
eina: prevent leak of Eina_Value internal allocation.
eina_value_copy assume the given Eina_Value as target is not initialized
when it copy the source in it. In eina_value_reference_copy we were initialising
before calling eina_value_copy which would then override and leak the internal
pointer no fault of the users.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9943
Cedric Bail [Sat, 14 Sep 2019 17:52:37 +0000 (10:52 -0700)]
eina: turn on Eina_Mempool tests for OneBig too.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9940
Cedric Bail [Sat, 14 Sep 2019 17:49:28 +0000 (10:49 -0700)]
eina: fix free support in eina OneBig mempool.
We use an Eina_Trash to store freed pointer, which require the item size
to be at least the size of a pointer. There wasn't any test suite enable
for OneBig mempool and we never used free on a small item size...
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9939
Cedric Bail [Sat, 14 Sep 2019 17:16:56 +0000 (10:16 -0700)]
eina: fix eina_mempool_from to not report pointer that have never been allocated as allocated.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9938
Marcel Hollerbach [Tue, 17 Sep 2019 13:51:19 +0000 (15:51 +0200)]
efl_ui_widget_part_bg: improve docs
Reviewers: segfaultxavi, zmike
Reviewed By: segfaultxavi
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9990
Marcel Hollerbach [Tue, 17 Sep 2019 12:16:14 +0000 (14:16 +0200)]
efl_ui_image: implement missing API
the API calls have not been implemented, this revision implements these
APIs as redirects to the image if those are a edje object.
Normally this should be a calling the legacy edje API. However, this is
here really hard as imitating the correct callback behaviour is hard.
And the correct behaviour with the eina value type is also just leading
to copying the implementation from edje. So in order to keep the amount
of code low here, this just uses the efl-api to redirect the requests.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D9989
Chris Michael [Tue, 17 Sep 2019 13:35:43 +0000 (09:35 -0400)]
tests/ecore_wl2: Fix resource leak
Small patch to fix resource leak pointed out by Coverity
Fixes Coverity CID1403883
Chris Michael [Tue, 17 Sep 2019 13:23:46 +0000 (09:23 -0400)]
efl_ui_caching_factory: Fix resource leaks
Small patch to fix resource leaks pointed out by Coverity
Fixes Coverity CID1404762
Chris Michael [Tue, 17 Sep 2019 13:21:15 +0000 (09:21 -0400)]
efl_ui_widget_factory: Fix resource leaks
Small patch to fix resource leaks pointed out by Coverity
Fixes Coverity CID1404766
JunsuChoi [Tue, 17 Sep 2019 12:18:47 +0000 (21:18 +0900)]
evas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue
Summary:
Crash depending on LOCALE when using strtod.
So change to eina_convert_strtod_c which is made to prevent strtod problem.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9988
Change-Id: I83d92054db29758ecaca9b08bfca700500857798
Daniel Kolesa [Tue, 17 Sep 2019 11:48:15 +0000 (13:48 +0200)]
eolian: skip funcs from beta-classes when unimplemented-checking
Marcel Hollerbach [Tue, 17 Sep 2019 08:56:42 +0000 (10:56 +0200)]
efl_ui_multi_selectable: remove SINGLE_ALWAYS
this should get a better solution later on. There is also no real usage
for that.
ref T7922
Reviewed-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Differential Revision: https://phab.enlightenment.org/D9985
Daniel Kolesa [Tue, 17 Sep 2019 10:36:13 +0000 (12:36 +0200)]
eolian: enable unimplemented function errors for stable API
Carsten Haitzler (Rasterman) [Tue, 17 Sep 2019 10:30:17 +0000 (11:30 +0100)]
evas - in case handle scope data being null
apbbb saw something that had this scope return null ... so handel -
but it shouldn't get this far... can't figure out why though.
Marcel Hollerbach [Tue, 17 Sep 2019 10:26:01 +0000 (12:26 +0200)]
efl_ui_table: protect again negative tests
Summary:
these tests are checking for errors, which is fine, we should expect a
error here
Depends on D9983
Reviewers: SanghyeonLee, cedric, zmike, segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9984
Marcel Hollerbach [Tue, 17 Sep 2019 10:25:59 +0000 (12:25 +0200)]
efl_ui_box: make this test expect the errors it is triggering
Summary:
there are checks for testing that something is not possible, which is
fine. However, the errors should be expected
Reviewers: SanghyeonLee, cedric, zmike, segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9983
Xavi Artigas [Tue, 17 Sep 2019 10:02:19 +0000 (12:02 +0200)]
mono-docs: Allow embedding examples in XML format
XML examples must provide their own <example> and <code> tags, and these
tags MUST be escaped: \< \> \" etc.
This is more inconvenient, but it allows adding explanatory text outside
the <code> and inside the <example>.
Examples are first looked for in XML format, and if not found, in CS format.
Hermet Park [Tue, 17 Sep 2019 03:01:25 +0000 (12:01 +0900)]
ector: refer exact stride size for jumping buffer lines.
Actual buffer and used width size could be different,
stride must be referred.
Change-Id: I06d8cf5c0b84a266c8c4260804da6a2b979e98ea
JunsuChoi [Tue, 17 Sep 2019 12:18:47 +0000 (21:18 +0900)]
evas_vg_load_svg: Change strtod to eina_convert_strtod_c for locale issue
Summary:
Crash depending on LOCALE when using strtod.
So change to eina_convert_strtod_c which is made to prevent strtod problem.
Test Plan: N/A
Reviewers: Hermet, smohanty, kimcinoo
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9988
Change-Id: If02ab894a40da21ba372ed033d155718b1834d78
jeon [Mon, 16 Sep 2019 10:45:13 +0000 (19:45 +0900)]
ecore_evas: fix invalid function usage
- _ecore_evas_mouse_move_with_multi_ifo_process is a
(Ecore_Event_Mouse_With_Multi_Cb) type function
Change-Id: I45852a92c5be74b4b9c36831bc4880a11207a209
Hermet Park [Tue, 17 Sep 2019 03:01:25 +0000 (12:01 +0900)]
ector: refer exact stride size for jumping buffer lines.
Actual buffer and used width size could be different,
stride must be referred.
Change-Id: I37d476223fe63aebda063d60ad05f7cba73f2cb0
Jongmin Lee [Mon, 16 Sep 2019 21:18:22 +0000 (06:18 +0900)]
efl.ui.scrollable: fix event name for scrollable
@tizen_fix
Change-Id: I829c20c5fbc42424c3c2307ea425e8bb169cfee1
Mike Blumenkrantz [Mon, 16 Sep 2019 18:19:43 +0000 (14:19 -0400)]
Revert "cxx: Fix some warnings from -Wextra"
This reverts commit
bdb8505f3b7318b024530d1f9559c91978a3b421.
more review pending on this
Lauro Moura [Mon, 16 Sep 2019 16:41:37 +0000 (12:41 -0400)]
cxx: Fix some warnings from -Wextra
Summary:
- As we don't have C++17's [[fallthrough]], rely on GCC'd detection
of fallthrough comments.
See https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
- Add some missing copy assignment operators as reported by
-Wdeprecated-copy
- Cast a Eina_Bool/bool narrowing conversion
Reviewers: zmike, brunobelo, felipealmeida
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9934
Xavi Artigas [Mon, 16 Sep 2019 16:10:09 +0000 (18:10 +0200)]
efl_ui_format: fix some more harmless Coverity warnings
1403023 Unchecked return value
1403024 Unchecked return value
1403026 Unchecked return value
If the eina value conversion fails the default value (0) will be used, which is already a good default.
ERRs have been added so the developer has a hint of what is happening.
Marcel Hollerbach [Mon, 16 Sep 2019 15:49:43 +0000 (17:49 +0200)]
efl_ui_focus_manager_calc: fix resource leaks
this fixes CIDs 1396965 & 1396984
Xavi Artigas [Mon, 16 Sep 2019 15:44:56 +0000 (17:44 +0200)]
docs: Update Efl.Ui.Box_Stack docs
Marcel Hollerbach [Mon, 16 Sep 2019 15:19:49 +0000 (17:19 +0200)]
efl_ui_*: fix dereferencing of possible NULL values
this fixes CID 1404763 & 1404751 & 1403904
Xavi Artigas [Mon, 16 Sep 2019 14:53:16 +0000 (16:53 +0200)]
docs: Clarify event emission in Image.Gfx.Image_Load_Controller
And minor formatting.
Xavi Artigas [Mon, 16 Sep 2019 14:01:31 +0000 (10:01 -0400)]
elm/datepicker, timepicker: Fix uninitialized vars
Summary:
Should fix all timepicker and datepicker uninitializer variable usage detected by Coverity:
1396954 Uninitialized scalar variable: efl_ui_timepicker.c
1396978 Uninitialized scalar variable: efl_ui_timepicker.c
1397006 Uninitialized scalar variable: efl_ui_timepicker.c
1396979 Uninitialized scalar variable: efl_ui_datepicker.c
1404748 Uninitialized scalar variable: efl_ui_datepicker.c
1404757 Uninitialized scalar variable: efl_ui_datepicker.c
Test Plan: Everything builds and passes tests. Coverity should complain less.
Reviewers: stefan_schmidt, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9967
Wonki Kim [Mon, 16 Sep 2019 13:57:36 +0000 (09:57 -0400)]
elm_config: fix a missing of free after using
Summary: safed_bindings will leak by going out the function without freeing.
Reviewers: bu5hm4n, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9966
Daniel Kolesa [Mon, 16 Sep 2019 13:27:04 +0000 (15:27 +0200)]
eolian: drop @ctor_param and the associated APIs
This has been unused for a while, and has been just lingering
around the code, so drop it so it doesn't make it into a release.
Stefan Schmidt [Mon, 16 Sep 2019 11:48:37 +0000 (13:48 +0200)]
release: Update NEWS and bump version for 1.23.0-beta2 release
Marcel Hollerbach [Mon, 16 Sep 2019 10:56:36 +0000 (12:56 +0200)]
efl_ui_slider: improve docs
Summary: Depends on D9964
Reviewers: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9965
Marcel Hollerbach [Mon, 16 Sep 2019 10:56:35 +0000 (12:56 +0200)]
efl_ui_check: improve docs
Summary: Depends on D9963
Reviewers: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9964
Marcel Hollerbach [Mon, 16 Sep 2019 10:56:27 +0000 (12:56 +0200)]
efl_ui_button: improve docs
Reviewers: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9963
Xavi Artigas [Mon, 16 Sep 2019 10:37:59 +0000 (12:37 +0200)]
efl_ui_widget: remove misleading comments
Summary:
We settled for the focus_allow name.
The other APIs are not internal, they are protected, and this is
noted, no need to say that again.
Additionally it is not helpfull to have commented out c_prefix
definitions.
Depends on D9936
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9937
Marcel Hollerbach [Mon, 16 Sep 2019 10:28:33 +0000 (12:28 +0200)]
efl_ui_widget: remove wrong docs
Summary:
this is not true anymore, this has been reverted due to how legacy
works. *yey*
Depends on D9935
Reviewers: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9936
Marcel Hollerbach [Mon, 16 Sep 2019 10:22:28 +0000 (12:22 +0200)]
efl_ui_widget: improve docs
Reviewers: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9935
Xavi Artigas [Mon, 16 Sep 2019 10:13:45 +0000 (12:13 +0200)]
docs: Update docs for Efl.Pack_Layout
Hosang Kim [Mon, 16 Sep 2019 09:50:12 +0000 (11:50 +0200)]
efl.ui.scrollable: fix event name for scrollable
Summary:
Event name is applied in the past tense.
Meaning of 'stop' is 'stop it early', so I changed it to 'finish'
Test Plan: elementary_test -> efl.ui.scroller
Reviewers: segfaultxavi, woohyun
Reviewed By: segfaultxavi
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9859
Stefan Schmidt [Mon, 16 Sep 2019 07:42:03 +0000 (09:42 +0200)]
eina: fix spelling in new eina_file_statgen API
Introduced in
9b294d6284f the new eina_file_statgen_* API has a typo in
its disable function. Fixing this before it gets out into a release.
Thanks goes to the https://abi-laboratory.pro service for offering their
great API/ABI reports to the open source communities to help finding such
things!
Differential Revision: https://phab.enlightenment.org/D9962
Stefan Schmidt [Mon, 16 Sep 2019 09:09:02 +0000 (11:09 +0200)]
ci: travis: let Coverity scan run be executed every night until release
Normally we only have this running on Saturday, which is fine for the
normal development cycle. Being close to a release now I would like to
get result updates every day. This will be switched back to weekly after
the 1.23 release.
Mike Blumenkrantz [Mon, 16 Sep 2019 09:08:23 +0000 (11:08 +0200)]
efl/image: Efl.Gfx.Border_Fill_Mode -> Efl.Gfx.Center_Fill_Mode
Summary:
rename this to match its function
ref T7926, T7875
Depends on D9932
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7926, T7875
Differential Revision: https://phab.enlightenment.org/D9933
Xavi Artigas [Mon, 16 Sep 2019 09:06:02 +0000 (11:06 +0200)]
efl/image: Efl.Gfx.Image_Scale_Type -> Efl.Gfx.Image_Scale_Method
ref T7927, T7875
Depends on D9931
Mike Blumenkrantz [Mon, 16 Sep 2019 09:01:01 +0000 (11:01 +0200)]
efl/image: add size event info for image,resized event
Summary:
this saves a manual lookup
ref T7875
Depends on D9930
Reviewers: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7875
Differential Revision: https://phab.enlightenment.org/D9931
Mike Blumenkrantz [Mon, 16 Sep 2019 08:58:24 +0000 (10:58 +0200)]
efl/image: image,resize -> image,resized
Summary:
events should always be past tense verbs
ref T7875
Depends on D9929
Reviewers: segfaultxavi
Subscribers: kimcinoo, cedric, #reviewers, #committers
Tags: #efl_api
Maniphest Tasks: T7875
Differential Revision: https://phab.enlightenment.org/D9930
Mike Blumenkrantz [Mon, 16 Sep 2019 08:42:27 +0000 (10:42 +0200)]
efl/image: improve docs
Summary:
this adds more docs for the overall interface as well as improvements to
existing docs
ref T7717
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl_docs
Maniphest Tasks: T7717
Differential Revision: https://phab.enlightenment.org/D9929
Carsten Haitzler (Rasterman) [Mon, 16 Sep 2019 00:47:05 +0000 (01:47 +0100)]
evas - rsvg loader - comment out deprecated func from rsvg we don't need
it seesm we don't need this. unref should shut down the rsvg obj
anyway, and rsvg_handle_close() has been deprecated since 2.46
Carsten Haitzler (Rasterman) [Mon, 16 Sep 2019 00:26:16 +0000 (01:26 +0100)]
edje - physics - remove warning of unused arg if physics disabled
simple warning removal. no core changes.
Yeongjong Lee [Mon, 16 Sep 2019 06:04:57 +0000 (15:04 +0900)]
efl_access_text: enable EFL_BETA_API_SUPPORT define to use beta apis
since
4c531e262a440b79fc8e210d945bb8e7614aec2f,
Efl.Access.Text_Attribute and Efl.Access.Text_Range struct marked @beta.
EFL_BETA_API_SUPPORT is needed to use `Efl_Access_Text_Attribute`,
`Efl_Access_Text_Attribute` struct.
@tizen_fix
Change-Id: I0d49a63f7b76199c7e1b714252895fc1ec0310b1
Hermet Park [Wed, 11 Sep 2019 04:12:08 +0000 (13:12 +0900)]
ector: removed cairo backend.
For reducing maintainability burden,
We drop supporting cairo backend.
The default backend is to software implementation from now.
It's well maintained so far and works good.x
Change-Id: Ia512df505f91e7918878afd690da178632308fc4
Hermet Park [Wed, 11 Sep 2019 03:00:28 +0000 (12:00 +0900)]
ector: don't alloc memory if the size is 0.
Change-Id: I3c55022dfeca81fb328cbdcdc20d080922617e59
Hermet Park [Wed, 11 Sep 2019 02:59:21 +0000 (11:59 +0900)]
ector: code refactoring.
more neat and clean code, no logical changes.
Change-Id: I0bfcb2c8cb6ad0a76fc9f186b83152dbb98472e7
Yeongjong Lee [Mon, 16 Sep 2019 01:13:54 +0000 (10:13 +0900)]
bump up to 1.23.0
Change-Id: I95b8525f42d1ed7ee31a92fe5c59ecfc05a29733
Yeongjong Lee [Mon, 16 Sep 2019 01:00:25 +0000 (10:00 +0900)]
efl_ui_widget: fix eo build error of tizen only type
@tizen_fix
Change-Id: I29d3e140df8cd6715ef94d9eea37d75bf3cf8dc6
Yeongjong Lee [Sun, 15 Sep 2019 23:40:21 +0000 (08:40 +0900)]
efl_ui_win: remove needless legacy keyword
@tizen_fix
Change-Id: If70d22b1d6622a3fdbdb8aed83e87fcf0404e0f4
Lauro Moura [Fri, 13 Sep 2019 22:22:39 +0000 (19:22 -0300)]
csharp: Fix Hash.DelByValue
Summary:
The C function `eina_hash_del_by_data` requires the same value that was
passed to the `add` function. As C# hashes store stuff through pointers
due to marshalling, this makes it hard to pass the same pointer for it.
So this functionality is implemented at C# level instead of relying on
the native function directly.
Fixes T8198
Thanks to @brunobelo and @singh.amitesh for the test case.
Reviewers: singh.amitesh, felipealmeida, brunobelo
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, #committers, singh.amitesh, brunobelo
Tags: #efl
Maniphest Tasks: T8198
Differential Revision: https://phab.enlightenment.org/D9853
Mike Blumenkrantz [Fri, 13 Sep 2019 18:13:33 +0000 (14:13 -0400)]
tests/edje: handle file modifications properly on windows
Summary: we don't have access to utimensat and I'm too busy to figure out why
Reviewers: vtorri, bu5hm4n, devilhorns
Reviewed By: vtorri
Subscribers: cedric, #reviewers, #committers
Tags: #efl_build
Differential Revision: https://phab.enlightenment.org/D9914
Mike Blumenkrantz [Fri, 13 Sep 2019 16:49:03 +0000 (18:49 +0200)]
efl_ui/scrollable_content: be more explicit about scrollable_content_get()
Summary:
always return NULL when an internal text object exists to avoid exposing
internal objects; this is an abstraction mechanism which should not be
extended or relied upon
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9910
Myoungwoon Roy, Kim [Fri, 13 Sep 2019 12:04:46 +0000 (14:04 +0200)]
doc: improve single line descriptions
Summary: this patch improves single line descriptions described on T7717
Reviewers: woohyun, Hermet, myoungwoon, cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9795
Xavi Artigas [Fri, 13 Sep 2019 15:57:37 +0000 (17:57 +0200)]
docs: nicer formatting for Efl.Pack_Linear
Boris Faure [Fri, 13 Sep 2019 15:26:19 +0000 (11:26 -0400)]
meson.build: allow to disable tiff evas loader
Summary:
@fix
eina benchmarks: ssize_t is defined in <sys/types.h>
Reviewers: #reviewers, bu5hm4n, zmike, stefan_schmidt
Reviewed By: zmike
Subscribers: vtorri, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9927
Daniel Kolesa [Fri, 13 Sep 2019 14:56:43 +0000 (16:56 +0200)]
eolian: support complex monospace syntax $[...]
This is to allow monospace bits with periods, commas and other
non-alphabetical characters. Newlines are not supported (they end
the block) and escapes are supported (for ]).
Fixes T8213.
Marcel Hollerbach [Fri, 13 Sep 2019 14:14:37 +0000 (10:14 -0400)]
efl_ui_slider: correct to a multiple of step when drag is finished
Summary:
this is needed in order to support the value to be a multiple of the
step when drag has finished. The normal changed event is still emitted
with non-multiple of step, but the steady event only contains the
correct values now.
ref T8187
Reviewers: zmike, segfaultxavi, woohyun
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8187
Differential Revision: https://phab.enlightenment.org/D9928
Xavi Artigas [Fri, 13 Sep 2019 12:26:21 +0000 (14:26 +0200)]
eolian_gen: add missing param doc for event raising
Xavi Artigas [Fri, 13 Sep 2019 10:41:16 +0000 (12:41 +0200)]
eolian: Remove the EOLIAN_PROPERTY_DOC_WARN envvar
This test is now always enabled, so ALL properties should have property-level
documentation. Setter and getter docs are optional.
Xavi Artigas [Fri, 13 Sep 2019 10:25:49 +0000 (12:25 +0200)]
docs: Move property docs to property level instead of set/get
Eolian @properties should be documented at the property level, and
documentation at the setter or getter level should be left to setter-
or getter-specific comments. There is usually no need at all to have
setter- or getter- specific comments.
Also, a property is not a method so descriptions should match that.
This patch removes lots of duplicated text, and will allow enabling
by default the eolian check that ensures that properties have proper
property-level docs.
No functional changes.
Vincent Torri [Thu, 12 Sep 2019 18:46:06 +0000 (14:46 -0400)]
efl_app_test_promise: fix warning (no returned value)
Test Plan: compilation
Reviewers: cedric, zmike, raster
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9926
Vincent Torri [Thu, 12 Sep 2019 18:45:58 +0000 (14:45 -0400)]
eio: fix warning
Test Plan: compillation
Reviewers: raster, cedric, zmike
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9925
Marcel Hollerbach [Thu, 12 Sep 2019 18:45:47 +0000 (14:45 -0400)]
meson: make sure evas buffer engine is built before edje_cc
Summary:
ensure that the evas buffer engine is available.
fix T8220
Reviewers: zmike
Reviewed By: zmike
Subscribers: zmike, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8220
Differential Revision: https://phab.enlightenment.org/D9918
Vincent Torri [Thu, 12 Sep 2019 14:01:33 +0000 (10:01 -0400)]
Evil: fix mmap() and define HAVE_MMAP
Summary: add size of file mapping to fix invalid parameter
Test Plan: compilation (edje succeeds) and elm_test
Reviewers: zmike, cedric, raster
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9913
Marcel Hollerbach [Thu, 12 Sep 2019 11:29:12 +0000 (13:29 +0200)]
efl_ui_calendar_item: document this class a little bit more
Summary: Depends on D9923
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9924
Marcel Hollerbach [Thu, 12 Sep 2019 11:26:39 +0000 (13:26 +0200)]
efl_ui_image: insert @ to link docs proberly
Summary: Depends on D9922
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9923
Marcel Hollerbach [Thu, 12 Sep 2019 11:26:33 +0000 (13:26 +0200)]
efl_gfx_path: insert @ to link docs proberly
Summary: Depends on D9921
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9922
Marcel Hollerbach [Thu, 12 Sep 2019 11:26:28 +0000 (13:26 +0200)]
efl_ui_scrollable: insert @ to link docs proberly
Summary: Depends on D9920
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9921
Marcel Hollerbach [Thu, 12 Sep 2019 11:26:24 +0000 (13:26 +0200)]
efl_object: insert @ to link docs proberly
Summary: Depends on D9919
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9920
Marcel Hollerbach [Thu, 12 Sep 2019 11:26:20 +0000 (13:26 +0200)]
efl_part: insert @ to link docs proberly
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9919
Mike Blumenkrantz [Thu, 12 Sep 2019 09:00:03 +0000 (11:00 +0200)]
efl/arrangement: improve docs
Summary:
this adds full docs for the class and properties
ref T7717
ref T7864
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7864, T7717
Differential Revision: https://phab.enlightenment.org/D9912
Mike Blumenkrantz [Thu, 12 Sep 2019 08:55:15 +0000 (10:55 +0200)]
efl/hint: fix hint_align docs
Summary:
the docs should not assume that the current language is LTR and should
instead specify that the horizontal direction depends on the language
reading direction
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9911
WooHyun Jung [Thu, 12 Sep 2019 08:24:51 +0000 (10:24 +0200)]
efl_ui_timepicker/datepicker : change event name properly
Summary:
This changes the event name from "changed" to "date(or time),changed"
@ref T7869 T7901
Reviewers: segfaultxavi, zmike, bu5hm4n
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7901, T7869
Differential Revision: https://phab.enlightenment.org/D9905
Bruno da Silva Belo [Thu, 12 Sep 2019 02:17:39 +0000 (23:17 -0300)]
csharp: Minor change to D9692
Summary: Changing Evt to Event from some files that it wasn't catch on D9692
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, felipealmeida, #reviewers, lauromoura, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9904
Bruno da Silva Belo [Wed, 11 Sep 2019 20:21:02 +0000 (17:21 -0300)]
csharp: Registering events when using Components.Basic.
Summary:
With `Components.Basic`, it isn't registering events,
while `Components.Ui` do with `elm_init`
Fixes T7770
Thanks @lauromoura
Test Plan: Look T7770
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, brunobelo, felipealmeida, #reviewers, lauromoura, #committers
Tags: #efl
Maniphest Tasks: T7770
Differential Revision: https://phab.enlightenment.org/D9909
Jaehyun Cho [Wed, 11 Sep 2019 14:46:51 +0000 (11:46 -0300)]
eolian_mono: fix documentation warning by using "<" and ">"
Summary:
If type A: list<B>; is written in eo, then documentation warning
occurs because list<B> is written in the documentation without string
conversion.
To fix the warning, "<" and ">" are converted into "<" and ">".
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9891
Marcel Hollerbach [Wed, 11 Sep 2019 17:38:48 +0000 (13:38 -0400)]
efl_ui_collection: fix the insertion of the first element with pack_at
Summary:
before pack_at with no element failed because the list element has been
NULL.
This fixes the insertion, the codepath also works without the error.
Depends on D9871
Reviewers: zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9890
Mike Blumenkrantz [Wed, 11 Sep 2019 17:38:41 +0000 (13:38 -0400)]
efl_ui/scrollable_content: handle null cases for scrollable_*_get
Summary: these are valid calls and should be handled correctly
Reviewers: cedric
Reviewed By: cedric
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9880
Mike Blumenkrantz [Wed, 11 Sep 2019 17:38:35 +0000 (13:38 -0400)]
tests/edje: reduce chances of cascading test failures in non-forked mode
Summary:
move evas_free() into the global shutdown fixture to ensure that edje_shutdown
actually does call internal shutdown methods since evas_free() will not be
reached if it is at the end of a failing test
Depends on D9878
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9879
Mike Blumenkrantz [Wed, 11 Sep 2019 17:38:28 +0000 (13:38 -0400)]
tests/edje: add comprehensive edje reloading test
Summary:
this verifies:
* successfully loading a file
* emission of "load" signal when performing a file load
* swallowing an object
* no-op of file load operation on same file if mtime is unchanged
* successfully reloading the same file if the mtime has changed
* preserving user-defined data across file reloads
Depends on D9877
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9878
Mike Blumenkrantz [Wed, 11 Sep 2019 17:38:21 +0000 (13:38 -0400)]
efl: check file's mtime in efl.file::file_set to determine if file is the same
Summary:
historically, if the mtime of an edj file changes after being loaded,
the edje file should be reloaded. this needs to occur in a single call
with the previous user definitions intact, so verify that the mtime is
the same in efl.file::file_set when using the same file name
@fix
Reviewers: cedric
Reviewed By: cedric
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9877
Marcel Hollerbach [Wed, 11 Sep 2019 17:38:20 +0000 (13:38 -0400)]
introduce test file for Efl.Ui.Group_Item
Summary:
this tests that the tree structure which is defined by the group and
child item hirachy is correctly transformed into a linear list.
This also checks that the bug from the revision before is not happening.
Depends on D9890
Reviewers: segfaultxavi, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9872
Marcel Hollerbach [Wed, 11 Sep 2019 17:38:13 +0000 (13:38 -0400)]
efl_ui_group_item: fix insertion of item at the end
Summary:
in this case here, eina list count already returns the count *including*
the subobject, the case in pack_at below (where also +1 is added) is
different to that, as count is the value *before* the list add.
Depends on D9870
Reviewers: segfaultxavi, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9871
Marcel Hollerbach [Wed, 11 Sep 2019 17:38:07 +0000 (13:38 -0400)]
efl_ui_test_list_collection: add test for item placement
Summary:
this test checks if the placement of the items is correct with and
without scrolling, with and without groups.
Depends on D9869
Reviewers: segfaultxavi, zmike, cedric
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9870
ali [Wed, 11 Sep 2019 15:07:51 +0000 (11:07 -0400)]
evas_textblock: fix warning
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9903
Marcel Hollerbach [Wed, 4 Sep 2019 19:18:18 +0000 (21:18 +0200)]
evas_callbacks: make the callback protection a little bit safer
the problem here is that we might subscribe to an event before
evas_object_callbacks_init has happened. This sounds like something
which might not happen. However, with the interfaces project this
definitly will start to happen because someone will some day overwrite
the evas object and do something before the constructor, which will not
raise a error or something but will simply just not work.
With this commit we are not listening to the event callbacks via event
emission but rather via inheritance. With this there is no "earlier than
we listend" point, and the issue in the task is solved by itself.
fix T8202
Reviewed-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Differential Revision: https://phab.enlightenment.org/D9841
Hermet Park [Wed, 11 Sep 2019 06:12:35 +0000 (15:12 +0900)]
evas vg: optimize memory in layer blending.
Same method to
321035d1e7d58fb9165b7ee55c1962d39c859caa
By far, with previous memory optimization,
The memory usage is reduced to half of composition buffer size.
Hermet Park [Wed, 11 Sep 2019 05:27:47 +0000 (14:27 +0900)]
canvas vg: optimize memory usage in composition.
Ector buffer allocates memory in default,
We don't need to allocate buffer memory additionally to handle over outside.
We can map/unmap ector buffer for reusing this.