kim hosang [Mon, 22 Oct 2018 09:47:55 +0000 (09:47 +0000)]
Revert "copypaste: set the parent of copypaste popup to window"
This reverts commit
903b4221ee44a4f80a90b69952d399c97e66aba4.
Change-Id: I97e416b6c3d44982dd588a6feb91922746c33b9d
Yeongjong Lee [Thu, 25 Oct 2018 05:48:01 +0000 (14:48 +0900)]
elm_conformant: fix migration side effect
Some apps can't show indicator regardless of indicator mode.
This patch fixes that bug.
test case:
1)
win = elm_win_add();
elm_win_indicator_mode_set(win, ELM_WIN_INDICATOR_SHOW);
elm_win_indicator_opacity_set(win, ELM_WIN_INDICATOR_OPAQUE);
conf = elm_conformant_add(win);
2)
win = elm_win_add();
conf = elm_conformant_add(win);
elm_win_indicator_mode_set(win, ELM_WIN_INDICATOR_SHOW);
elm_win_indicator_opacity_set(win, ELM_WIN_INDICATOR_OPAQUE);
Change-Id: Ieb83b089fa9d809ac66cbab87830a6c5031cc2b1
Hermet Park [Thu, 25 Oct 2018 05:50:37 +0000 (14:50 +0900)]
elementary transit: allow duration change on animatining.
Summary:
Previously, it didn't allow to change duration because of implementation limit.
This time, it turns out it doesn't need to limit the behavior.
More capacity is better for various scenarioes.
Reviewers: #committers, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7205
Change-Id: I2b151cbf7582d9200941166e56a19a3b5ce67a46
Yeongjong Lee [Thu, 25 Oct 2018 05:37:10 +0000 (14:37 +0900)]
elm_conformant: fix wrong variable assignment
Summary:
event.object is always NULL. it may cause unexpected behavior.
event.object should be assinged after sd->win is assinged.
Reviewers: akanad, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7208
Change-Id: I4f56591a0ae404d41a7f5d89da0aba6f65051b0b
Lukasz Wlazly [Wed, 24 Oct 2018 11:37:15 +0000 (13:37 +0200)]
Add missing object registration at "Parent" property
Change-Id: I485e5c587d487c5dc0fd856917f9c72b93e1f3df
Yeongjong Lee [Wed, 24 Oct 2018 12:30:25 +0000 (21:30 +0900)]
elm_popup: fix mistypo for proper popup size calculation in landscape mode.
Change-Id: Ic086415ba6b85488f903991faaf38581c83402bd
Lukasz Oleksak [Wed, 24 Oct 2018 11:50:48 +0000 (13:50 +0200)]
Fixes appending of default label object for popup
Change-Id: I1b1553d56c847063da5ddcf9b5f11ae9a1aaf862
SangHyeon Lee [Wed, 24 Oct 2018 11:29:43 +0000 (11:29 +0000)]
Revert "genlist: fix translataion issue"
This reverts commit
6fdcd3f58045278e25c7334714eddd2e481eee64.
Change-Id: I9d163c81edacccc88d6565fd84b7341a33031b2a
Youngbok Shin [Wed, 24 Oct 2018 09:24:57 +0000 (18:24 +0900)]
genlist: fix translataion issue
It adds missing implementation of translataion update.
@fix
Change-Id: Iea0eceeb12fa75709944c015f85fdc9472bcc5cf
Radoslaw Cybulski [Mon, 22 Oct 2018 08:57:07 +0000 (10:57 +0200)]
Fix parent-children incosistencies in atspi tree
Fixes incosistencies (where obj A was child of object B, but object B's
parent was different, than A) in atspi tree. Now atspi parent is
retrieved by calling efl_access_object_access_parent_set.
Change-Id: I3e20af88bd7f066f3f9faa5185e4028d0e5e05db
Hermet Park [Wed, 24 Oct 2018 07:19:49 +0000 (16:19 +0900)]
evas vg: fix invalid vg caching usage.
reset cache if vg root node is reset by manually.
Change-Id: I881b1433c294775af805cbff3560ffda0f69fe36
Lukasz Wlazly [Mon, 22 Oct 2018 08:58:09 +0000 (10:58 +0200)]
Fix for navigation problems related with relations
This patch fixes backward navigation by blocking processing
of relations before finding predecessor in canonical order.
Change-Id: I2b5cd71a8f54f408a10779dedf5b936fff0e7d76
Hermet Park [Tue, 23 Oct 2018 11:43:17 +0000 (20:43 +0900)]
elementary transit: add a convenient API.
Summary:
elm_transit_current_repeat_times_get() returns
current repeating count of transition.
@feature
Reviewers: #committers, devilhorns
Reviewed By: #committers, devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7200
Change-Id: Ie037be2597d16ad0228562b5659420224be65f57
Hermet Park [Tue, 23 Oct 2018 05:49:46 +0000 (14:49 +0900)]
evas image: fix non-rendered preload image.
Summary:
This is one more corner-case issue that I found,
When second image doesn't use preload (but still share the resource)
canvas engine triggers cancellation for first image preload function.
Unluckly, preload thread is cancelled on the intermediate rendering,
First image is not going to rendered, even image turn it changed states.
Because end of that frame, canvas reset/flushed all active objects.
Here changes to retain the changes status to redraw it in the next frame.
Test Plan:
img1 = image_add;
image_file_set(img1, "test.jpg");
image_preload(img1, true);
show(img);
img2 = image_add;
image_file_set(img2, "test.jpg"); //same resource
image_preload(img2, false);
show(img2);
img1 is invisible.
Reviewers: #committers
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7157
Change-Id: I3bdaee67d55424dc6385faa355d295f0c444e25a
Sunghyun kim [Thu, 12 Jul 2018 10:43:48 +0000 (19:43 +0900)]
evas : use PIO for paletted png
Change-Id: I2dcad49f639e8154b85abb1001808fd73564a202
Jaeun Choi [Thu, 10 May 2018 09:23:58 +0000 (18:23 +0900)]
png: prototype colormap load
Change-Id: I8588e855a00b54ac3766c97fdc4565f47b104b65
Hermet Park [Mon, 22 Oct 2018 08:08:02 +0000 (17:08 +0900)]
evas vg: updated doc.
fix typo and elaborate contents.
Change-Id: I755791178e16f8553af56bc49400493a29576f82
Taehyub Kim [Fri, 19 Oct 2018 10:05:18 +0000 (19:05 +0900)]
copypaste: set the parent of copypaste popup to window
Change-Id: I78b5ed279c1bb965119dd47b147085decefb9bdf
Radoslaw Cybulski [Tue, 16 Oct 2018 10:12:46 +0000 (12:12 +0200)]
Fix for missing embedded elements in atspi tree
Removed overload of getter of parent property. That overload could
return null, which broke object's construction and caused proxy not to
work anymore.
Change-Id: Ic2868f7d8e8dad09c5949a204c8874ea6d4aa815
Radoslaw Cybulski [Tue, 16 Oct 2018 10:15:03 +0000 (12:15 +0200)]
Fix for missing elements in atspi tree
Removed invalid if clause, which were the cause of unnecesary removing
part of items in the tree. Now every object is guaranteed to exists in
at most exactly one subobjs list, thus if is redundant.
Change-Id: I8253d1bd54be479b9776e753097df685fe30544d
Hermet Park [Wed, 17 Oct 2018 11:52:16 +0000 (20:52 +0900)]
evas vg: flush cache key properly.
When vg resource or size is changed,
it needs to flush cache key and redraw.
Change-Id: I4ddc80e550f541c445c09de27bf452a5dc30a941
Radoslaw Cybulski [Wed, 17 Oct 2018 10:50:25 +0000 (12:50 +0200)]
Fix for missing HIGHLIGHTED flag in accessibility mode on list items
Change-Id: Iff3a65d464bd452418699d8c77ca50067eabdcb4
Hermet Park [Wed, 17 Oct 2018 05:08:32 +0000 (14:08 +0900)]
evas vg: fix memory leak at gradient.
Summary:
free memory properly when object is deleted.
@fix
Reviewers: #committers, devilhorns
Reviewed By: #committers, devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7165
Change-Id: I8b811cfcc8a737ea8bae17cdf82099743123a444
Wonki Kim [Wed, 17 Oct 2018 00:21:19 +0000 (09:21 +0900)]
ecore_wl2: Fix a memory leaking case
Summary:
there is a memory leaking in some case.
this patch fixes it.
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7167
Change-Id: I5d87918fc2e58d0aa94f6b3ddf9d64e6b6416f90
Hosang Kim [Tue, 16 Oct 2018 12:47:24 +0000 (21:47 +0900)]
evas_events: fix wrong condition
Summary:
change OR condition to AND condition.
mouse_grabbed should be bigger than zero to
enter inside.
Change-Id: I3e38c24cf73eab41a82d584a41fb35225101213a
Taehyub Kim [Tue, 16 Oct 2018 02:27:54 +0000 (11:27 +0900)]
Revert "Temp: Remove Tizen Only Size Calculation Code in Elm_Label for Efl Sharp Popup Demo"
This reverts commit
0ff0d06ab44d6c5fdc173cb06cda3590a08b051c.
Change-Id: I4d7370e8c99da3c729009c1a7af170fca9a3d92f
Hermet Park [Tue, 16 Oct 2018 06:07:36 +0000 (15:07 +0900)]
devas vg: return default root node if possible.
Summary:
It could return NULL root node
while user expect a valid root node in default
as It did before.
This is a regresion bug from long ago.
@fix
Reviewers: #committers
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7162
Change-Id: I20f116f64f3ddbb73754e22173193d3040726a46
Hermet Park [Wed, 10 Oct 2018 05:19:18 +0000 (14:19 +0900)]
evas vector: fix typo.
Change-Id: I6f106ec042af4372b970c241415d874ac4d0328e
Hermet Park [Thu, 11 Oct 2018 04:46:36 +0000 (13:46 +0900)]
evas: remove redundant internal functions.
Summary:
Since efl object is introduced, magic check is no more used.
Plus, remove redundant object functions interfaces
- type_id,
- visual_id,
- store
- unstore
Reviewers: #committers, bu5hm4n
Reviewed By: #committers, bu5hm4n
Subscribers: bu5hm4n, raster, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7153
Change-Id: I42f15ae8209f7cf3b2670bb6c300bac267334eb2
Hermet Park [Thu, 11 Oct 2018 04:54:40 +0000 (13:54 +0900)]
evas cache: clear up caching locking and reference count.
Summary:
On reviewing, found out some logical problems in evas cache.
ref-drop pair doesn't make sense, proper locking for cache image neither.
Reviewers: raster, #reviewers
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7129
Change-Id: I9337cdb34fa06539a3f8e515a0b4652e10a75381
Hermet Park [Fri, 12 Oct 2018 05:27:35 +0000 (14:27 +0900)]
evas image: fix preloading compatibility broken.
Well... Logically, we don't need to request preload again,
If image is loaded already. But somewhow it broke the enlightenment pager
and I need to revert the previous behavior here.
Whatever image is loaded or not, here image requests preload again,
unless it is already on preloading.
This was introduced by
babacf41b7269a257065a41a2a4ec7763bada25f.
This fixes enlightenment pager bg non visible issue.
Change-Id: I7933f1463038afbbb0990f742baab5f972de17aa
Hermet Park [Tue, 16 Oct 2018 03:24:01 +0000 (12:24 +0900)]
evas vg: fix memory leak.
Summary:
eina array must be flushed when object is deleted.
@fix
Reviewers: #committers, devilhorns
Reviewed By: #committers, devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7160
Change-Id: I16ac0bedcf8d947af4999713e8363060b9447c79
Hermet Park [Mon, 15 Oct 2018 08:24:06 +0000 (17:24 +0900)]
evas vg: fix memory leak.
Here cached vg tree is not released properly.
Remove it before allocate another one.
Change-Id: Id823db19ae68cb77e02ce7a9ef50ed5c550b0ec5
Hermet Park [Wed, 10 Oct 2018 12:18:01 +0000 (21:18 +0900)]
evas vg: don't overfull cache size.
Vg Animation requests a lot of frame surfaces.
On animatation, Previously cache key is not correct,
all vg frames would cached even repeated.
By storing cache key, we do hit cache properly
And let LRU Cache mechanism work over LRU_CACHE_LIMIT.
Change-Id: I066e33597c258109579bd9604c542c6941d2749c
Juyeon Lee [Fri, 12 Oct 2018 10:16:16 +0000 (19:16 +0900)]
ecore_wl2: fix build break
Change-Id: Ie83fa6abf34b189eb3ddd0391bf93720c4bfc974
Taehyub Kim [Fri, 21 Sep 2018 07:49:10 +0000 (16:49 +0900)]
Temp: Remove Tizen Only Size Calculation Code in Elm_Label for Efl Sharp Popup Demo
Change-Id: I67d03decf20f8add4268c6b0af3ea39f580ed7ed
Juyeon Lee [Fri, 12 Oct 2018 04:07:42 +0000 (13:07 +0900)]
ecore_wl2_window: add null check condition
Change-Id: Ied0e34f8382228fd2c3493b864cec834f666ee2e
Juyeon Lee [Thu, 11 Oct 2018 12:54:56 +0000 (21:54 +0900)]
eocre_wl2_window: destroy zxdg_surface and xdg_surface after Null buffer commit
@tizen_only
Change-Id: Idcb317bd6735e802cf3240482cebc0b61396b8cf
Youngbok Shin [Tue, 2 Oct 2018 06:07:32 +0000 (15:07 +0900)]
evas filter: remove critical messages from Evas Filter
When you run filter examples with enabling GL engine support,
you can see critical messages which say don't use efl_unref for buffer object.
So, efl_unref has to be replaced with efl_del.
@tizen_fix
Change-Id: I487ec3591f9655d71263d7d6325c364da5719304
JunsuChoi [Thu, 11 Oct 2018 11:30:25 +0000 (20:30 +0900)]
efl_ui_win: Move force resize code on first draw
Summary:
In D6165, there was a modification that forced resize_job
to be called using sd-> deferred_resize_job.
Even if we set true in sd-> deferred_resize_job,
it will be changed to false by calling other function to be called.
(sd->deferred_resize_job = EINA_TRUE; ->
_elm_win_resize_objects_eval ->
_elm_win_resize_job ->
sd->deferred_resize_job = EINA_FALSE;)
Eventually _elm_win_frame_obj_update is not called.
There is a case where _elm_win_frame_obj_update can not called in tizen.
For this reason, make sure to call resize_job when first drawing based on D6165.
Test Plan: N/A
Reviewers: eagleeye, zmike, woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7156
Change-Id: Ib91d8c73d5dd0a106b77ce1fb5494b60a9fdb8e4
WooHyun Jung [Thu, 11 Oct 2018 10:42:57 +0000 (19:42 +0900)]
efl_ui_progressbar: avoid meaningless theme_apply
Change-Id: I0c94f69701e271f67b1126bd2ff8e9a072038cc1
Signed-off-by: WooHyun Jung <wh0705.jung@samsung.com>
Youngbok Shin [Thu, 11 Oct 2018 09:36:13 +0000 (18:36 +0900)]
evas engine: add a missing change from EvasGL Render Thread patch
It fixes an issue: Evas Filter with SW backend didn't work at all.
@tizen_fix
Change-Id: Ib3063f0b7dc082d35ac51ed4cfbfec0221cad796
Hosang Kim [Thu, 11 Oct 2018 07:49:18 +0000 (16:49 +0900)]
ecore_wl2: fix build break
when i tested this commit i had wayland turned off. Sorry for the
noise.
Change-Id: I25e3a3557c700a7b6d60803bb79d8bd0b290599c
Juyeon Lee [Thu, 11 Oct 2018 06:33:52 +0000 (15:33 +0900)]
eocre_wl2_window: unset zxdg_surface and xdg_surface when hide
if a client is hide and render while hide, using wl_surface_commit
than, display server would regard the wl_buffer attach and wl_surface commit
show request. and map a window on screen.
to prevent this behavior, destory xdg_surface while implicit hide request
as a result, display server would not map those windows(hide but rendering in bg)
@tizen_only
Change-Id: Icccf0f6010d960538137aef6cd29c1cab940d231
Hosang Kim [Wed, 10 Oct 2018 10:35:08 +0000 (19:35 +0900)]
ecore_wl2: fix coverity issue. (Resource Leak)
Summary: Module is not freed when eina_module_load is failed.
Reviewers: Hermet, marcelhollerbach, bu5hm4n
Reviewed By: bu5hm4n
Subscribers: bu5hm4n, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7152
Change-Id: Ic03e20955d2b196dbcf8ac68603f08bd1a7d10bb
Bowon Ryu [Wed, 10 Oct 2018 09:05:18 +0000 (18:05 +0900)]
efl_ui_tab_pager: modified test for regression test
Summary: Fixed randomly generated tab items to be generated sequentially in test code.
Test Plan: elementary_test -to efl.ui.tab_pager
Reviewers: Jaehyun_Cho, jsuya
Reviewed By: jsuya
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7154
Change-Id: Ic0f72f95f7590e5f5aadc1938ac049230f725d8d
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Hosang Kim [Wed, 10 Oct 2018 07:12:01 +0000 (16:12 +0900)]
elm_interface_scrollable: set to NULL when ecore job is finished.
In ecore_job callbak, job pointer should set to NULL.
@fix @tizen_only
Change-Id: Id5b0b838ac12d8c66df5aedfe745dc505b6976bf
Jiyoun Park [Mon, 8 Oct 2018 10:45:38 +0000 (19:45 +0900)]
ecore_evas_extn: seperate event queue for tizen_embedded_compositor_get_socket
sometimes, ecore_evas_extn can not get the proper socket event even though wayland server sends socket event.
so add seperate queue for extn socket event.
Change-Id: Ic07560cbb27ba80365b072e62da41487ae881186
SangHyeon Jade Lee [Mon, 8 Oct 2018 09:54:12 +0000 (18:54 +0900)]
genlist: increase genlist width min size from zero
genlist pan width mininum size was decrease from large number 999999 before,
but it may not give proper size when the first item block calculation is
not called before _calc() function is called.
also, it cannot cover largest item size case, cause it choose smallest
item width size for min width.
genlist width min must be lagest item's width, to show whole item in
scrolling pan, so increase 0 to bigger is proper than decrease lager
one.
@tizen_fix
Change-Id: I27d2175ce85da6ce20229fef07dc1180176f7845
Youngbok Shin [Mon, 8 Oct 2018 06:48:27 +0000 (15:48 +0900)]
edje: Update original position for text which running marquee
It fixes text's wrong position issue when a marquee ends.
@tizen_fix
Change-Id: I1238be9666ea47574f95f7897e3decbf41a54e54
JunsuChoi [Fri, 5 Oct 2018 07:56:09 +0000 (16:56 +0900)]
elm_genlist: prevent null pointer access
Summary: it->item->block can be null. so add null check.
Test Plan: elementary_test -to "genlist show/bring"
Reviewers: SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7146
Change-Id: Idca2dd57900380b9952558926ed66c02701b7b39
JunsuChoi [Thu, 4 Oct 2018 12:27:29 +0000 (21:27 +0900)]
ecore_con_legacy: fix coverity issues (use after free)
Summary:
for hard failures (highly unlikely), the handle would be deleted and the next use would crash.
Test Plan: N/A
Reviewers: Jaehyun_Cho, zmike, cedric, bu5hm4n
Subscribers: bu5hm4n, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7139
Change-Id: I9de4952abadfad4f92ee2a5e316c0146d2cfd8c7
WooHyun Jung [Sat, 6 Oct 2018 07:42:45 +0000 (16:42 +0900)]
evas_events : last_mouse needs to be used even pdata is founded
In some cases, unexpected pdata is founded and all the logics in
evas_events are conflicted becuase of failure in pdata matching.
For example, mouse_down and mouse_up use the same ev->device, but
mouse_move uses the different one.
This only can be happened in Tizen, so just keep it as Tizen Only
Fix.
@hosang will improve this patch to keep the last_mouse not per evas
but per seat.
@tizen_fix
Change-Id: Ic80a36b4c8c1a3431f97099f397d5da6f84e7324
Hosang Kim [Fri, 5 Oct 2018 11:01:18 +0000 (20:01 +0900)]
efl_ui_clock: Prevent NULL pointer reference.
When _elm_datetime_items_get() calling with only time format after
datetime creation.
The location has been swapped. so some of sorted_field index address
gets a invalid
address. then it makes a crash.
@tizen_fix
Change-Id: I34856201bc9ed5a4adc2c6aeb2693a294e7b4430
Joogab Yun [Fri, 5 Oct 2018 07:06:18 +0000 (16:06 +0900)]
evas : bug fixed about missing gl_context
Change-Id: I03fe2aa347aa741e0b90003917a4f0c9e91a7e6a
Jaeun Choi [Fri, 5 Oct 2018 06:38:28 +0000 (15:38 +0900)]
edje: fix null pointer access bug
Change-Id: Ifac6693f2ae5d27fa99c28d901a28196ae59bc9f
Taehyub Kim [Thu, 4 Oct 2018 12:47:11 +0000 (21:47 +0900)]
efl_selection_manager: skip other process's send event
Change-Id: I0d187f4893beca1c1af431fe2dc3ed71bd7940a8
Jaehyun Cho [Thu, 4 Oct 2018 07:50:21 +0000 (16:50 +0900)]
elm_theme: fix return value when default style fallback is done
To keep backward compatibility, EFL_UI_THEME_APPLY_DEFAULT is returned
instead of EFL_UI_THEME_APPLY_SUCCESS if style is not found in theme and
default style fallback is done instead.
This patch fixes
7353fc1cb85e08eb6e884ed8bbf9a009226069b6
@fix
Change-Id: I012a310c9c98b0c15e667fe9846e62b4c480b305
Youngbok Shin [Thu, 4 Oct 2018 09:58:04 +0000 (18:58 +0900)]
eina debug: fix a double unlock issue
Summary:
It was caught by Covertity.
This patch will remove a potential double unlock issue.
@fix
Test Plan: N/A
Reviewers: zmike, raster, cedric, Hermet, eagleeye
Reviewed By: eagleeye
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7137
Change-Id: I290009b92ed961d662c6d1549de92644647f4dee
Youngbok Shin [Thu, 4 Oct 2018 09:53:36 +0000 (18:53 +0900)]
elementary entry: apply scale to all edje objects
Summary:
When an entry is scrollable, its resize object is scr_edje.
So, to apply scale properly, elm_entry needs to apply scale
to its entry_edje, too.
@fix
Test Plan: Apply scale to scrollable entry
Reviewers: herdsman, woohyun, cedric, eagleeye
Reviewed By: eagleeye
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7140
Change-Id: I09f546a70ed306a5a08ec37728478729a3c2d793
Bowon Ryu [Tue, 2 Oct 2018 10:24:28 +0000 (19:24 +0900)]
efl_page_transition_scroll: fix warning the dereference before null check
Summary: if target is null, then terminate the function because it is not intended.
Test Plan: N/A
Reviewers: eunue
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7127
Change-Id: Ia7f78e5a8a5e246623afee94231cc128df88d965
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Jiyoun Park [Tue, 2 Oct 2018 09:53:16 +0000 (18:53 +0900)]
ecore_evas_extn: check error case if bind result is null
Change-Id: I3b75aa56aa8bb405f5234fc52327d720e7f91f41
Hosang Kim [Mon, 1 Oct 2018 11:29:26 +0000 (20:29 +0900)]
slider: add "slider,drag,start/stop" smart callbacks.
These callbacks are missing, when we merge codes.
Change-Id: Ie6b2f40cf47dd887b0fdb049af8e3dad7852a6e2
Hermet Park [Mon, 1 Oct 2018 12:06:36 +0000 (21:06 +0900)]
evas gl: fix invalid image size.
Summary:
When we reset of texture for a valid object,
this object cache size become -1 x -1 with null texture.
Later, we reset a new texture of the object,
Its texture size could be -1 x -1.
That brings to incorrect result drawing.
Can't see any points of using cache size there.
This bug was introduced by
9e01cf2698d5b24f440d696fd57d469cdc5a6b5f
@fix
Reviewers: #committers, raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7077
Change-Id: I210e31954ce347efa96197370dc63fc51a149f02
Jaeun Choi [Fri, 28 Sep 2018 14:43:34 +0000 (23:43 +0900)]
evas_textblock_hyphenation: remove incorrect expression
dict->cset is an array, not a pointer, thus is never NULL.
this was discovered by coverity.
upstream patch: https://phab.enlightenment.org/D7121
Change-Id: I0c1ebe264d1d2ecfb2197ccb7e4f57cbf12736de
Hosang Kim [Mon, 1 Oct 2018 04:02:42 +0000 (13:02 +0900)]
efl_ui_image: remove ecore job temporarily.
When we use ecore_job, it increases usage of graphic memory.
Until find a real cause, remove ecore job teomporarily.
@tizen_only
Change-Id: I26143d628e060d70b7e785b003b76e4f15ac2915
Jiyoun Park [Mon, 1 Oct 2018 01:05:34 +0000 (10:05 +0900)]
ecore_wl2_window: fix migration side effect
Before code: if ((win->surface) && (win->display->wl.efl_aux_hints))
Wrong code: if ((!win->surface) && (!win->display->wl.efl_aux_hints))
Modified code:if ((!win->surface) || (!win->display->wl.efl_aux_hints))
Change-Id: I7fe97cd9eded322d2238452bf7fb5520ba712814
Yeongjong Lee [Mon, 1 Oct 2018 02:11:57 +0000 (11:11 +0900)]
efl_selection: add return value check for fwrite
Summary: found by coverity
Reviewers: raster, Hermet
Subscribers: Hermet, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7109
Hosang Kim [Fri, 28 Sep 2018 11:53:31 +0000 (20:53 +0900)]
eldbus: remove unreachable code.
Coverity doesn't like this unreachable code.
https://phab.enlightenment.org/D7120
@fix
Change-Id: I87eec8aede73d34bf3a107c003cb6d739dd52852
Hermet Park [Fri, 28 Sep 2018 11:35:19 +0000 (20:35 +0900)]
evas vg: +legacy api
evas_object_vg_file_set()
Change-Id: Ief22caae2551969a7716f8497d1f1ef5ee40e5ec
Hermet Park [Fri, 28 Sep 2018 10:49:46 +0000 (19:49 +0900)]
evas vg: add two legacy apis.
evas_object_vg_animated_frame_duration_get()
evas_object_vg_animated_frame_get()
Change-Id: I57d9b01a927076d077d4af8e8e78d462d535a94e
Youngbok Shin [Fri, 28 Sep 2018 10:01:27 +0000 (19:01 +0900)]
elementary bg: revert scale disable patch to support bg_option functions
It was applied to fix scale policy issue.
The patch was disabling scale by elm_objeect_scale_set with 0.0~#.
But, it also disabled image scale feature which is used for bg_option functions.
So, it has to be reverted and revised for elm_object_scale_set() problem.
@tizen_fix
Change-Id: I6eb44d0a8eb1c1cd35b067ffa6745dc99df8cfab
Jiyoun Park [Fri, 28 Sep 2018 09:07:01 +0000 (18:07 +0900)]
evas_object_textblock: fix warning the dereference before null check
Change-Id: I1e473357002b8b012d42c961de8861a51351f27e
Carsten Haitzler (Rasterman) [Sat, 17 Feb 2018 09:00:19 +0000 (18:00 +0900)]
elm entry - dont seg if the obj has been deleted by callback time
i spotted a segv with elm entry + efm ... sd was NULl because obj was
seemingly not valid at that point, so fix and check the smart data
returns before moving on.
Change-Id: Id8e52679c1e6ba0dd7ed0d6651a42fb68de2b1ca
Yeongjong Lee [Fri, 28 Sep 2018 07:13:39 +0000 (16:13 +0900)]
edje: call recalc in part_text_get if there is no available text data
Summary:
If edje_text_get is called before any edje_text_set function call, it return
null, because rp->typedata.text->text is only set by edje_text_set function.
If there is no available text data, find it from rp(edc).
ref
7bbf18a950c027a365fea1b88e8dc3f16bb81abe
Test Plan: make check
Reviewers: zmike, id213sin, herdsman
Reviewed By: id213sin
Subscribers: Hermet, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6961
Change-Id: Ife4c30a23b90c0b41dbf2da2240c922cb8ae4cf2
Hosang Kim [Fri, 28 Sep 2018 06:39:18 +0000 (15:39 +0900)]
elm_interface_scrollable: fix using wrong variable.
vy isn't initialized when p >1.0 or p<0.
https://phab.enlightenment.org/D7114
@fix
Change-Id: If294ef7b96a18863490b1ae703ce42ad716e9ca1
Youngbok Shin [Fri, 28 Sep 2018 06:31:50 +0000 (15:31 +0900)]
edje vector: fix wrong implementations from the Edje json support patch
Change-Id: Ic359f3cd2aa07269331bb37d60aa5f4fb4e9bc7b
Yeongjong Lee [Thu, 27 Sep 2018 00:30:59 +0000 (09:30 +0900)]
ecore_audio_obj_out_tizen: check efl_key_data_get return
Found by coverity
Change-Id: I1301d9481d9ef3c7cef49b7ac0b59f85ec7ed136
JunsuChoi [Thu, 27 Sep 2018 09:22:22 +0000 (11:22 +0200)]
ecore_con: Add docs for ecore_con legacy functions
Summary:
Find docs of missing legacy functions
from 9c33623(ecore: add ecore_con_url_ssl_ca_set.),
40edc9c(ecore: add ecore_con_url_ssl_verify_peer_set patch by Raoul Hecky.)
and add them.
Test Plan: make doc
Reviewers: cedric, Hermet, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7117
JunsuChoi [Thu, 27 Sep 2018 09:12:46 +0000 (11:12 +0200)]
ecore_timer: Add docs for ecore_timer legacy functions
Summary:
Find docs of missing legacy functions
from 47cdbe3 and add them.
Test Plan: make doc
Reviewers: cedric, Hermet, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7118
Jaehyun Cho [Fri, 21 Sep 2018 12:30:50 +0000 (12:30 +0000)]
efl_vg: calculate center point with double type
Although the center point is double type, the calculation is integer type.
To calculate center point correctly, calculate with double type.
Differential Revision: https://phab.enlightenment.org/D7097
Alastair Poole [Mon, 24 Sep 2018 10:26:23 +0000 (10:26 +0000)]
efreet_menu: remove unused and unreachable code.
Coverity doesn't like this unreachable code. This purges
efreet_menu of all unused code for the deprecated and
non-working menu_async methods. The warnings remain
at compile time and run time.
Differential Revision: https://phab.enlightenment.org/D7101
Yeongjong Lee [Thu, 27 Sep 2018 07:33:37 +0000 (07:33 +0000)]
efl_ui_stack: Partially Revert "efl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value"
This partially reverts commit
820dcb9cd975e93271977246aaf1b1a707435851.
top_cd can be NULL when cd->stack is NULL.
Thanks to bu5hm4n for reporting.
Differential Revision: https://phab.enlightenment.org/D7116
Yeongjong Lee [Thu, 27 Sep 2018 05:10:31 +0000 (14:10 +0900)]
eina_value: return null when eina_value_pget failed
Summary:
Add return value check.
found by coverity.
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7107
Yeongjong Lee [Thu, 27 Sep 2018 05:08:39 +0000 (14:08 +0900)]
elm_genlist: prevent null pointer access
Summary: found by coverity
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7108
Yeongjong Lee [Thu, 27 Sep 2018 04:58:08 +0000 (13:58 +0900)]
efl_exe: check fcntl return
Summary: Found by coverity
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7110
Yeongjong Lee [Thu, 27 Sep 2018 04:57:33 +0000 (13:57 +0900)]
efl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value
Summary:
Becase EINA_INLIST_CONTAINER_GET always return true, it doesn't need to check
whether return value is null.
Reviewers: Jaehyun_Cho, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7112
Yeongjong Lee [Thu, 27 Sep 2018 04:55:20 +0000 (13:55 +0900)]
efl_ui_list: fix wrong variable usage
Reviewers: SanghyeonLee, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7113
Lauro Moura [Wed, 26 Sep 2018 15:01:49 +0000 (12:01 -0300)]
efl-csharp: Fix event struct marshalling.
Summary:
The efl.Event struct has a class field that gets generated normally but
can be problematic when marshalling the struct back from C to C#. The
compilation works fine but when C# runtime tries to marshall the C data
(e.g. accessing the Event.Info field), it becomes erratic, either
complaining about missing references to object or even segfault.
This commit changes the event handling code to use the
"Event_StructInternal" struct as is already done when receiving structs
from C code.
In order to work with other assemblies, the _StructInternal fields were
made publit too.
Fixes the events tests and the text editor app.
Test Plan: make check and run the text editor app in examples repo.
Reviewers: segfaultxavi, vitor.sousa
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7106
Xavi Artigas [Wed, 26 Sep 2018 07:21:26 +0000 (09:21 +0200)]
docs: Fix Efl.Ui.Focus.Object.Focus() docs
Summary:
The same description was used for both the Setter and the Getter, which makes
no sense.
Reviewers: zmike, bu5hm4n, bryceharrington, devilhorns
Reviewed By: bu5hm4n, devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7071
Youngbok Shin [Mon, 24 Sep 2018 10:17:26 +0000 (11:17 +0100)]
elementary_test: use snprintf to prevent memory overflow in test_efl_ui_text
Summary: To prevent memory overflow, use snprintf instead of sprintf.
Test Plan: N/A
Reviewers: raster, cedric, zmike, Hermet, netstar
Reviewed By: netstar
Subscribers: netstar, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7095
Bryce Harrington [Fri, 21 Sep 2018 18:34:28 +0000 (14:34 -0400)]
eina: Improve doxygen formatting for eina_debug.h
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7098
Carsten Haitzler (Rasterman) [Fri, 21 Sep 2018 12:39:45 +0000 (13:39 +0100)]
examples - fix avahi examples to compile
add links to avahi system client libs.
JunsuChoi [Fri, 21 Sep 2018 11:05:44 +0000 (20:05 +0900)]
Colorselector : Add docs of elm_colorselector_palette_item_* APIs
Summary:
Add documentation for these APIs
elm_colorselector_palette_item_color_get
elm_colorselector_palette_item_color_set
elm_colorselector_palette_item_selected_get
elm_colorselector_palette_item_selected_set
Test Plan: make doc
Reviewers: cedric, Hermet, zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7091
JunsuChoi [Fri, 21 Sep 2018 11:03:18 +0000 (20:03 +0900)]
Docs: Fix incorrectly information for elm_config_softcursor_mode_set
Summary: N/A
Test Plan: make doc
Reviewers: cedric, Hermet, zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7094
JunsuChoi [Fri, 21 Sep 2018 11:02:33 +0000 (20:02 +0900)]
Docs: Add a group of APIs for which group is not declared in elm_config
Summary:
Longpress
elm_config_longpress_timeout_get
elm_config_longpress_timeout_set
SotfCursor
elm_config_softcursor_mode_set
elm_config_softcursor_mode_get
Tooltips (Add in Elm_Tooltips)
elm_config_tooltip_delay_get
elm_config_tooltip_delay_set
Test Plan: make doc
Reviewers: cedric, Hermet, zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7093
Hermet Park [Fri, 21 Sep 2018 08:59:30 +0000 (17:59 +0900)]
edje: add missing eina_deprecated to apis.
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7090
Hermet Park [Fri, 21 Sep 2018 08:55:14 +0000 (17:55 +0900)]
Edje: update doc.
Summary: fix and add missing doxygen conent.
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7088
Taehyub Kim [Fri, 21 Sep 2018 09:04:49 +0000 (18:04 +0900)]
elm_entry: update documentation for elm_entnry_textonly_mode_set/get
Summary: update documentation
Reviewers: Jaehyun_Cho, raster
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7089
Bowon Ryu [Fri, 21 Sep 2018 08:25:56 +0000 (17:25 +0900)]
docs: correct group name of segmentcontrol for API docs.
Summary:
correct group name of segmentcontrol for API docs consistency.
Elm_SegmentControl -> Elm_Segment_Control
Test Plan: N/A
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7087