Piotr Kosko [Tue, 2 Oct 2018 12:11:27 +0000 (14:11 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Iaff2d9c208f5291dfac1eacb23070b8c4f3f10f2
Piotr Kosko [Tue, 2 Oct 2018 12:08:07 +0000 (14:08 +0200)]
[version] 2.27
Change-Id: I7aa0f9e1384347db1d0b045ef46542fcd5e8c7a2
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 2 Oct 2018 11:25:19 +0000 (13:25 +0200)]
[Archive][Exif] Added missing error checking
[Verification] Code compiles without errors.
Change-Id: I588a1d08f4dea4a19038653b2889a1daa5b45673
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 20 Sep 2018 07:20:56 +0000 (09:20 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I8dd955cb6c74b1323acfb5c8839733517c70e053
Piotr Kosko [Thu, 20 Sep 2018 07:01:37 +0000 (09:01 +0200)]
[version] 2.26
Change-Id: Ibb8feb4665aee4761dc2592147bdd41743bed13d
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 20 Sep 2018 06:40:06 +0000 (08:40 +0200)]
[Bluetooth] Fixing the memory releasing issue
[Verification] Code compiles without errors.
TCT passrate 100%.
Change-Id: I4a7b516635b7d2a3bfc96359fa4d51543b0eb4e0
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Pawel Kaczmarczyk [Mon, 27 Aug 2018 08:03:57 +0000 (10:03 +0200)]
[Alarm] Fix printing deprecation warnings on TV profile
AlarmAbsolute(date, period) constructor is not marked
as deprecated on TV profile.
[Verification]
Tested in chrome console
Change-Id: I1b3de7ad9d38c4bf4f8e55f8e8309e86b106e2f1
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Piotr Kosko [Thu, 16 Aug 2018 08:43:39 +0000 (10:43 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ic220dd064ebbb7187462bf78fde154cea2a19b66
Piotr Kosko [Thu, 16 Aug 2018 08:42:15 +0000 (10:42 +0200)]
[version] 2.25
Change-Id: If58254886f7fa6188e597e4d20dcb30f0ef60234
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Pawel Kaczmarczyk [Thu, 9 Aug 2018 08:40:58 +0000 (10:40 +0200)]
[HAM][Notification][Alarm] Add missing deprecation warnings since Tizen 4.0
[Verification]
tct-humanactivitymonitor-tizen-tests auto 100%
tct-notification-tizen-tests auto 100%
tct-alarm-tizen-tests auto 100%
Change-Id: I8d0de96c0d6a2ca8a009a25a7c1373dc4064ec36
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Pawel Kaczmarczyk [Wed, 8 Aug 2018 12:32:16 +0000 (14:32 +0200)]
[SystemInfo][Bluetooth][Push] Add misssing deprecation warnings since Tizen 3.0
[Verification]
Code compiles
tct-systeminfo-tizen-tests passrate 100%
Change-Id: I41db5325ac94ca042069551a41161e5b968e51d3
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Pawel Kaczmarczyk [Wed, 18 Jul 2018 13:45:45 +0000 (15:45 +0200)]
[HAM] Fix throwing exceptions for getHumanActivityData
[Bug] getHumanActivityData method accepts only 'PEDOMETER'
and 'HRM' values of HumanActivityType enum as type
parameter. Any other value should cause NotSupportedError,
but implementation leaded to UnknownError instead.
[Verification] AutoTCT 100% passrate
Change-Id: Id5145d76f8957527e28f42c9b1c3141b11b8e5ca
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Pawel Kaczmarczyk [Thu, 26 Jul 2018 07:05:03 +0000 (09:05 +0200)]
[NFC] Minor fixes
[Bugs]
1. In special cases records objects were created as empty
2. If NFCPeerDetectCallback or NFCTagDetectCallback did
not have defined function to call on action an TypeError
would be thrown.
[Verification] tct-nfc-tizen-tests passrate 100%
Change-Id: I32d6cbdc05c491f42100580a1cfe021c4c877bfc
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Lukasz Bardeli [Thu, 12 Jul 2018 08:08:07 +0000 (10:08 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ib0a0675b868f145f94825b3b209ed779e648df73
Lukasz Bardeli [Thu, 12 Jul 2018 05:38:20 +0000 (07:38 +0200)]
[version] 2.24
Change-Id: I612a9ec9977025efbbb35fa2c58e4c3ec8226b79
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Pawel Kaczmarczyk [Tue, 10 Jul 2018 13:35:36 +0000 (15:35 +0200)]
[HRM] Fix for resetting pedometer data after calling start
[Bug] Pedometer properties were not reset
back to zero after calling start again.
[Verification] Auto TCT passrate 100%
Manual (wearable and mobile emulators) 100%
Change-Id: I4b961a5c05224accb7ff482c570b3dd3aa352bb4
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Szymon Jastrzebski [Wed, 27 Jun 2018 10:21:48 +0000 (12:21 +0200)]
[MediaController] Replacing old functions with new equivalent
The part of Native API has been removed and needs to be replaced with new
one.
Related to Native ACR-1235
[Verification] Code successfully built. MC TCT M&A 100%
Change-Id: Iad47da5f58bd99a3505248b9f9a25e45cb7048db
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Arkadiusz Pietraszek [Mon, 4 Jun 2018 09:55:34 +0000 (11:55 +0200)]
[Mediacontroller] Added flags for setting shuffle and repeat modes
shuffle_mode_ and repeat_mode_ initial values are not determined.
Added flags enables to determine if it was already set.
Without it following TCT cases failed regardles of initial value:
MediaControllerPlaybackInfoChangeCallback_onrepeatmodechanged
MediaControllerPlaybackInfoChangeCallback_onshufflemodechanged
when run second time on target device.
First run might result in success as well as in block.
Verification: TCT pass rate: 100%
Change-Id: I71ef1a8ab4f7c86bb6f9adc9b05fc6f192bd0d96
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Szymon Jastrzebski [Thu, 21 Dec 2017 06:32:11 +0000 (07:32 +0100)]
[MediaController] Fix for bug onChange events
In server side, all onchange*request events should be fired only after
requesting server state change from client side.
Clients should receive on*changed events only after server state change.
[Verification] TCT passed 100%
Change-Id: I85e5eda12acf6de74bc653a9ccc8a283862eeb16
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Wed, 13 Dec 2017 09:31:43 +0000 (10:31 +0100)]
[MediaController] Refactoring internal implementation into dedicated CAPI
[Verification] TCT pass rates: 100% A 100% M
Change-Id: Id01a8988a122d0055f662eabe066a4b3f35bb48b
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Fri, 18 May 2018 12:05:34 +0000 (14:05 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Conflicts:
src/humanactivitymonitor/humanactivitymonitor_manager.cc
Change-Id: I782f99a7d436a786ee41d6fb0e37f4404e401813
Piotr Kosko [Fri, 18 May 2018 11:44:31 +0000 (13:44 +0200)]
[version] 2.23
Change-Id: I7634bdecaab795b4f9db8b76ecc92a8ee00da755
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Rafal Walczyna [Wed, 16 May 2018 12:29:03 +0000 (14:29 +0200)]
[humanactivitymonitor] Fixing rRinterval value in heartRate data
rRinterval was always 0. This value is now available, but measurement
is not present in unified builds. It was tested on R765 and R600 with
solis binaries and it worked fine.
[verification] AutoTCT - 100% pass
Change-Id: I3c181c53e0832f429774f86277bcaeda4708c0b7
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Rafal Walczyna [Wed, 16 May 2018 12:29:03 +0000 (14:29 +0200)]
[humanactivitymonitor] Fixing rRinterval value in heartRate data
rRinterval was always 0. This value is now available, but measurement
is not present in unified builds. It was tested on R765 and R600 with
solis binaries and it worked fine.
[verification] AutoTCT - 100% pass
Change-Id: I3c181c53e0832f429774f86277bcaeda4708c0b7
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Lukasz Bardeli [Thu, 10 May 2018 06:43:35 +0000 (08:43 +0200)]
[Iotcon] Prevent iotcon from call timeout after found resource
In ResourceFoundCallback after some resource was found, timeout will
never be called.
[Verification] Code compiles without error. TCT tests passrate 100%
Change-Id: I96ca592eb94e14c374b6eab99ca1956108f37154
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Thu, 10 May 2018 06:43:35 +0000 (08:43 +0200)]
[Iotcon] Prevent iotcon from call timeout after found resource
In ResourceFoundCallback after some resource was found, timeout will
never be called.
[Verification] Code compiles without error. TCT tests passrate 100%
Change-Id: I96ca592eb94e14c374b6eab99ca1956108f37154
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Piotr Kosko [Tue, 8 May 2018 07:16:04 +0000 (09:16 +0200)]
[version] 2.23
Change-Id: I2721525833d99e46d09ffa8d34ad7b3f7c2eecf2
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 8 May 2018 05:53:49 +0000 (07:53 +0200)]
[Filesystem][Alarm] Fix coverity/SVACE issues
[Bug] Fixed Coverity issues: 119865, 119863.
Fixed SVACE issue: 345864
Issues were related to not reachable code (invalid returned value was checked)
in Alarm module and not checking returned values in Filesystem module.
SVACE issue 345864 is related to the same problem as Coverity 119863.
[Verification] Code compiles without errors.
TCT passrate for Alarm and Filesystem - 100%.
Change-Id: I315d0aed94f8efef13d37a73b313ef455fb3b00e
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 25 Apr 2018 10:47:11 +0000 (12:47 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ib7b5158b9a129d63575e2f0b5eac142343d76e0b
Piotr Kosko [Wed, 25 Apr 2018 10:42:27 +0000 (12:42 +0200)]
[version] 2.22
Change-Id: I75c3fdd794b62946720fc5cb537c437ab33843bd
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 24 Apr 2018 10:40:19 +0000 (12:40 +0200)]
[Filesystem] Fixing file filter
[Bug]
1. FileFilter name was not matching '%' wildcard on the beginning of filename
2. wildcard escaping need to be done by using '\\%' not '\%' - proper comment
added in code to ease future investigations.
[Verification] Code compiles successfully.
TCT passrate is 100%.
Below code:
var filter = "piotr\\%kosko%";
function onsuccess(files) {
console.log("There are " + files.length + " in the selected folder");
for (var i =0; i < files.length; ++i) { console.log(files[i].name) }
}
function onerror(error) {
console.log("The error " + error.message +
" occurred when listing the files in the selected folder");
}
tizen.filesystem.resolve("documents", function(dir) {
dir.listFiles(onsuccess, onerror, {name: filter});
}, function(e) { console.log("Error " + e.message);}, "r");
for filter "piotr\\%kosko%" filters file:
piotr%koskoTest
for filter "%kosko%" filter files:
piotrkoskoTest
piotrkosko
piotrTestkoskoTest
kosko
piotr%koskoTest
piotr%kosko
Change-Id: If7e6c3c3ad97a3d01a800916ba73c5f7749ae0cb
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Rafal Walczyna [Mon, 23 Apr 2018 12:14:56 +0000 (14:14 +0200)]
[common] Coverity issues fix
[Feature] Fixed coverity issues with below ids:
112270, 112248, 112261, 112244, 110974, 106503, 110555,
105980, 110371, 108240, 105141, 110066, 109641, 109341,
109028, 108310, 106161, 105761, 105746, 108409, 108493,
106299, 106009, 105130, 105410
[Verification] 100% passrate for modules:
alarm, bluetooth, contact, content, email, filesystem,
humanactivitymonitor, mms, sms, voice-control
Change-Id: Ic32295ee12e9a8830d2e071e003a0045d0c5355e
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Szymon Jastrzebski [Thu, 1 Mar 2018 11:40:18 +0000 (12:40 +0100)]
[Power] Fix for casting void* into int
This bug caused to fail building on 64-bits architecture.
[Verification] Power M&A TCT 100% (TM1).
The code is build-able for 64-bits arch.
Change-Id: I3600a753956f448ca0938655cf1873e9ba057754
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Wed, 18 Apr 2018 08:49:16 +0000 (10:49 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Conflicts:
src/application/application_manager.cc
src/power/power.gyp
Change-Id: Ib9baaf8221cc99b01cfe8343b0e36a197c669941
Piotr Kosko [Wed, 18 Apr 2018 08:28:21 +0000 (10:28 +0200)]
[version] 2.21
Change-Id: Id7ba90815fd7970998c28343c0b1e5cce6fac32f
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 18 Apr 2018 06:51:51 +0000 (06:51 +0000)]
Merge "[IoTcon] Fix query creation for requests" into tizen_3.0
Rafal Walczyna [Tue, 17 Apr 2018 12:39:23 +0000 (14:39 +0200)]
[IoTcon] Fix query creation for requests
[Bug] query was not created properly when there was no
resource interface set
[Verification] 100% passrate on TM1
Change-Id: Iea1db9418fe10e9fad56a9bb7de1c34c95cbc5dd
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Wed, 18 Apr 2018 06:11:18 +0000 (08:11 +0200)]
[Spec] Fixing build dependency
[Verification] Code compiles without errors.
Change-Id: I7bc3f9c4ed440ab00822366c49843228be626b62
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 18 Apr 2018 06:05:48 +0000 (08:05 +0200)]
[Spec] Fixing build dependency
[Verification] Code compiles without errors.
Change-Id: I7bc3f9c4ed440ab00822366c49843228be626b62
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 17 Apr 2018 12:56:43 +0000 (12:56 +0000)]
Merge "[Power] Prevent override of power level locked with Web API" into tizen_3.0
Piotr Kosko [Tue, 17 Apr 2018 12:54:29 +0000 (12:54 +0000)]
Merge "[Power] Refactoring module" into tizen_3.0
Piotr Kosko [Tue, 17 Apr 2018 11:13:37 +0000 (11:13 +0000)]
Merge "[Application] Add removing event_handler in destructor." into tizen_4.0
Lukasz Bardeli [Tue, 17 Apr 2018 09:07:51 +0000 (11:07 +0200)]
[Application] Add removing event_handler in destructor.
Removing all event_handler from events while closing application.
Without removing event_handler it is possible that native api will call
event with destroyed data. This fix is to prevent such situation
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I94d1fbb85ad47ca6dbcba6c56cd043521952860e
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Tue, 17 Apr 2018 08:45:24 +0000 (10:45 +0200)]
[Application] Add removing event_handler in destructor.
Removing all event_handler from events while closing application.
Without removing event_handler it is possible that native api will call
event with destroyed data. This fix is to prevent such situation
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I94d1fbb85ad47ca6dbcba6c56cd043521952860e
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Pawel Wasowski [Wed, 4 Apr 2018 16:33:30 +0000 (18:33 +0200)]
[Power] Prevent override of power level locked with Web API
Chromium used to override power level locked by Web API with its own
settings. The level set by Web API was not restored.
From now on, Chromium will not override power level lock, after receiving
"__DisableChromiumInternalPowerLock" message from the Web API
and will be able to control the locked power level,
after receiving "__EnableChromiumInternalPowerLock" message.
Change-Id: Ia14f873766e26bd02ae7eecb182c69e0b6af00e8
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Szymon Jastrzebski [Tue, 10 Oct 2017 06:56:25 +0000 (08:56 +0200)]
[Power] Refactoring module
Previous implementation depended partly on Deviced functions through the
dbus interface. Currently, the implementation uses only DeviceD Native API
(except the ReleaseBrightness and SetBrightness methods).
TheReleaseBrightness is still not wrapped into the Native C DeviceD API).
[Verification] TCT pass: A/M - 100%.
Change-Id: I03124c0d332bf03cd5481ac2b38c9e5c9a534063
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Mon, 16 Apr 2018 07:57:46 +0000 (07:57 +0000)]
Merge "[Power] Prevent override of power level locked with Web API" into tizen_4.0
Piotr Kosko [Mon, 16 Apr 2018 07:43:11 +0000 (07:43 +0000)]
Merge "[Power] Refactoring module" into tizen_4.0
Piotr Kosko [Fri, 6 Apr 2018 09:04:22 +0000 (11:04 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Conflicts:
src/download/download_instance.cc
src/download/download_instance.h
Change-Id: Idd927480881807d231e7edf17319e092e8ded81c
Piotr Kosko [Fri, 6 Apr 2018 07:29:15 +0000 (09:29 +0200)]
[version] 2.20
Change-Id: I8c11218bf7cb61b4dcc530a205e7a4bfc1d94be9
Rafal Walczyna [Fri, 6 Apr 2018 07:19:43 +0000 (09:19 +0200)]
[Messaging] Fixed permissions of temporary file used for messaging
File created by mkstemp() gives permissions only for user,
that's why msg-service could not read from file and body of message was empty.
[Verification] 100% passrate on TM1
Change-Id: I290277294459ca96392b9a97adccded1664a426d
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Pawel Wasowski [Wed, 4 Apr 2018 16:33:30 +0000 (18:33 +0200)]
[Power] Prevent override of power level locked with Web API
Chromium used to override power level locked by Web API with its own
settings. The level set by Web API was not restored.
From now on, Chromium will not override power level lock, after receiving
"__DisableChromiumInternalPowerLock" message from the Web API
and will be able to control the locked power level,
after receiving "__EnableChromiumInternalPowerLock" message.
Change-Id: Ia14f873766e26bd02ae7eecb182c69e0b6af00e8
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Szymon Jastrzebski [Tue, 10 Oct 2017 06:56:25 +0000 (08:56 +0200)]
[Power] Refactoring module
Previous implementation depended partly on Deviced functions through the
dbus interface. Currently, the implementation uses only DeviceD Native API
(except the ReleaseBrightness and SetBrightness methods).
TheReleaseBrightness is still not wrapped into the Native C DeviceD API).
[Verification] TCT pass: A/M - 100%.
Change-Id: I03124c0d332bf03cd5481ac2b38c9e5c9a534063
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Tue, 3 Apr 2018 08:12:44 +0000 (10:12 +0200)]
[Download] Fixed unexpected result of fixing coverity issues
[Bug] When running on TV device, checking status of cellular network
returned not supported error, the checking status of cellular needed
to be moved into correct section instead of running this code in common
code part.
[Verification] TCT result - 100%
Change-Id: I6cb171034588b2616222bde4101a278c491fdc52
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 3 Apr 2018 08:12:44 +0000 (10:12 +0200)]
[Download] Fixed unexpected result of fixing coverity issues
[Bug] When running on TV device, checking status of cellular network
returned not supported error, the checking status of cellular needed
to be moved into correct section instead of running this code in common
code part.
[Verification] TCT result - 100%
Change-Id: I6cb171034588b2616222bde4101a278c491fdc52
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 28 Mar 2018 11:34:42 +0000 (11:34 +0000)]
Merge "[datacontrol] Fixing coverity issues" into tizen_4.0
Rafal Walczyna [Wed, 28 Mar 2018 11:24:48 +0000 (13:24 +0200)]
[datacontrol] Fixing coverity issues
[Feature] Fixed coverity ids:
109463, 108734
[Verification] 100% passrate on TCT datacontrol tests
Change-Id: I5e563fbd58c814d8d7ca1eefde465303f263c2f3
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Wed, 28 Mar 2018 11:20:31 +0000 (13:20 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Conflicts:
src/download/download_instance.cc
Change-Id: Ib5546e2489ffdd603e5889e895707b0800209174
Piotr Kosko [Wed, 28 Mar 2018 11:06:10 +0000 (13:06 +0200)]
[version] 2.19
Change-Id: Ic8848b54eda46b98bd609e0d4254548a8c5beb04
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 28 Mar 2018 11:00:13 +0000 (11:00 +0000)]
Merge "[common] Coverity issues fix" into tizen_3.0
Piotr Kosko [Tue, 27 Mar 2018 12:59:02 +0000 (14:59 +0200)]
[common] Coverity issues fix
[Feature] Fixed coverity issues with below ids:
110914, 110006, 108656, 107626, 107387,
107077, 106006, 108993, 108297, 106912
Additionally fixed potential crash in download API -
in case of native function failure, the "success" response
is not trying to be build.
[Verification] 100% passrate for modules:
application, bluetooth, download, exif, filesystem, messaging-*
Change-Id: I8d9482501a7375962408186feaa5ecd1f0826b1d
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Rafal Walczyna [Tue, 27 Mar 2018 11:55:44 +0000 (13:55 +0200)]
[common] Fixing coverity issues
Issues: 110672, 108789, 108137, 107617,
106435, 112265, 112254, 107669, 105923
[Verification] 100% passrate in:
bookmark, calendar, contact, content, datacontrol,
filesystem, keymanager
Change-Id: Id667a94fe653f831a8cfdd70813c8ace91e1cf5d
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Lukasz Wojciechowski [Sat, 10 Mar 2018 02:25:34 +0000 (03:25 +0100)]
[Push] Prefix string type with namespace std
The patch fixes build break in Tizen:4.0:Unified.
The string type without std::string is not recognized by compiler.
Change-Id: I048bad0a1d71cb841965a84b2d11d2afb9c19eea
Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
(cherry picked from commit
a2c7a32a5fbc41e6bf20c891797c786e946628c9)
Lukasz Wojciechowski [Sat, 10 Mar 2018 02:25:34 +0000 (03:25 +0100)]
[Push] Prefix string type with namespace std
The patch fixes build break in Tizen:4.0:Unified.
The string type without std::string is not recognized by compiler.
Change-Id: I048bad0a1d71cb841965a84b2d11d2afb9c19eea
Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
Piotr Kosko [Fri, 23 Mar 2018 11:12:17 +0000 (12:12 +0100)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I08833f4e4e820cafcdf5cbb6a291f4c7d78bf05d
Piotr Kosko [Fri, 23 Mar 2018 11:10:31 +0000 (12:10 +0100)]
[version] 2.18
Change-Id: I171c24fc4170a519fef7fde45b4e223843cf33c0
Piotr Kosko [Fri, 23 Mar 2018 11:05:34 +0000 (11:05 +0000)]
Merge "[NFC] Fix isActivatedHandlerFunctions return values" into tizen_3.0
Rafal Walczyna [Fri, 23 Mar 2018 10:05:05 +0000 (11:05 +0100)]
[NFC] Fix isActivatedHandlerFunctions return values
Functions IsActivatedHandlerForCategory and IsActivatedHandlerForAID
always return false. After fix they work properly.
TCT tests needs fixing, after fix there will be 100% passrate.
Tested on TW1 tizen3.0
Change-Id: I9a4833d4073e512e9414e63325515ebfa8d6b8a4
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Pawel Kaczmarczyk [Mon, 19 Mar 2018 14:45:33 +0000 (15:45 +0100)]
[Systeminfo] Fix for incorrect USB storage capacity
USB_DEVICE has not been reporting correct capacity values
on TV profile. It was caused by different way of handling
reading storage properties.
[Fix]
Each storage type is treated in the same way when
getting information about storage's space.
[Verification] Tested in Chromium cosole
tct-systeminfo-tizen-tests passrate: 100%
tct-filesystem-tizen-tests passrate: 100%
Change-Id: I1d2a8a40a2cac18d5961a301bdd3e586cc3eedad
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Rafal Walczyna [Mon, 26 Feb 2018 11:11:58 +0000 (12:11 +0100)]
[NFC] Fix setPreferredApp()
It was unable to use when there was only one app
or app was already set as preferred. Added checking for
already activated app.
[Verification] 100% passrate (auto + manual)_on solis TW2
Change-Id: Ie85d1c09692bebdca7afe5278f63db9071d1adf5
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Mon, 26 Feb 2018 09:42:08 +0000 (10:42 +0100)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I402b1950719d6b614070be9b7cf2228339e3f70f
Piotr Kosko [Mon, 26 Feb 2018 09:33:00 +0000 (10:33 +0100)]
[version] 2.17
Change-Id: I3bf56e2b79bff86daefb7b9c3c8d53b41d5ac22c
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Fri, 23 Feb 2018 13:50:55 +0000 (13:50 +0000)]
Merge "[NFC] Fix memory management problems" into tizen_3.0
Pawel Wasowski [Mon, 12 Feb 2018 11:14:15 +0000 (12:14 +0100)]
[NFC] Fix memory management problems
This commit prevents crashes, fixing 2 memory management problems:
1. user_data passed to nfc_tag_transceive was deleted twice
2. buffer argument of tagTransceiveCb was deleted inside the function;
according to Native NFC API reference: "buffer will be automatically
destroyed when the callback function returns. (Do not release buffer.)"
[Verification] NFCTag.transceive() function was tested in Chrome
DevTools console and worked fine.
Change-Id: I509c368d817b6663373ba0614af73402f8ad47a6
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Szymon Jastrzebski [Thu, 22 Feb 2018 11:55:36 +0000 (12:55 +0100)]
[NFC] Fix for casting signed value to unsigned int
SVACE ID #310366
[Verification] TW2 NFC M&A TCT pass rate 100%.
Change-Id: Id329ba99d1ae62c6380c672dc3a06d2cd581011b
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Michal Bistyga [Thu, 8 Feb 2018 12:41:42 +0000 (13:41 +0100)]
[Calendar] Fixing multiple bugs in calendar API
3 bugs has been fixed:
1) User couldn't add new calendar to database
1a) Resolved by sending new object, no calendar through JSON
2) Calendar object was not updated with id got from native layer
2a) Resolved by returning id to js layer and...
2b) Changing setting its as result.id, not just a result
3) Every event has been set to calendar with id 0
3a) Resolved by utilizing not used calendarId attribute
[Verification]
verified in chrome console
tct-tests 100% passrate
Change-Id: I5edcf33d8dd753fc044d2b61677439145f4a73d1
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Rafal Walczyna [Tue, 20 Feb 2018 11:37:53 +0000 (12:37 +0100)]
[VoiceControl] Fixing bug with releasing listeners
Listeners was not removed after calling release() function
[verification] 100% passrate (auto and manual) on TM1
Change-Id: Ie241a7df83a72d0756f51d61b507f60d8b7c5f0f
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Fri, 9 Feb 2018 08:52:54 +0000 (08:52 +0000)]
Merge "[Filesystem] Fix return on error in FileWriteString and FileWriteBytes" into tizen_3.0
Jakub Skowron [Wed, 7 Feb 2018 14:02:53 +0000 (15:02 +0100)]
[Filesystem] Fix return on error in FileWriteString and FileWriteBytes
Change-Id: I0377b1a7eaa60a1b5d50c759005d2c6063400332
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Piotr Kosko [Tue, 6 Feb 2018 08:36:56 +0000 (09:36 +0100)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Iaa5ae2327a66726af1922e072dd6b39fc76de3d7
Piotr Kosko [Mon, 5 Feb 2018 12:48:16 +0000 (13:48 +0100)]
[SecureElement][NFC][Messageport] Fixing casting problems
[Bug] Casting double -> char should not be done directly.
[Verification] Passing values greater than 127 to API makes that
values are correctly translated.
TCT passrate 100%.
Change-Id: I786392fd3be2e7d0eb5211e224a25c8078f383e9
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Mon, 5 Feb 2018 06:57:27 +0000 (07:57 +0100)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I341501004603b29f58f41320ab1093f09f039af6
Piotr Kosko [Mon, 5 Feb 2018 06:49:29 +0000 (07:49 +0100)]
[version] 2.16
Change-Id: I7316b54e3c6ab3fe41b5e2e1ac6e4b1a9e7dfa35
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Mon, 5 Feb 2018 06:10:16 +0000 (06:10 +0000)]
Merge "[Bluetooth] Fixing undefined behaviour during cast" into tizen_3.0
Michal Bistyga [Fri, 2 Feb 2018 15:09:33 +0000 (16:09 +0100)]
[NFC] Fixing undefined behaviour during static_cast to unsigned char
Validation:
Automatic tests 100% pass rate
TODO manual tests
Change-Id: I9c15efc77c82f0f7e4019913b2bd02d0f8047bb1
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Michal Bistyga [Fri, 2 Feb 2018 11:37:08 +0000 (12:37 +0100)]
[Bluetooth] Fixing undefined behaviour during cast
Char is unsigned by default on ARM architecture. static_cast from double to unsigned char is undefined behaviour and complier overwritten any negative value with 0.
[Validation]
tests 100% pass rate
Change-Id: Iec39a3c17b18ec7aa4f020fe5de709d66fa426fd
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Piotr Kosko [Fri, 26 Jan 2018 10:10:36 +0000 (11:10 +0100)]
Merge branch 'tizen_3.0' into tizen_4.0
Conflicts:
src/download/download_instance.cc
Change-Id: I58ad10dac86b0a93074499fc839b30dd365b0f59
Piotr Kosko [Fri, 26 Jan 2018 10:04:18 +0000 (11:04 +0100)]
[version] 2.15
- version increased
- fixed minor style issue
Change-Id: I70a371ce7e6834bf73c413e19de37111168c9147
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Lukasz Bardeli [Fri, 26 Jan 2018 09:37:21 +0000 (10:37 +0100)]
[Download] refactoring module
Remove setMessageListener from download_api.js and start using from utils_api.js
Remove method declarations from .cc file getDownloadRequest and setListener
Variable name changes
Delete element from callbacks after finished, cancel or failed download
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: Idcca394f4ec6bda7ea3097248a9c900b2a542f7a
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Piotr Kosko [Fri, 26 Jan 2018 09:01:47 +0000 (09:01 +0000)]
Merge "[Utils] Fix Long conversion (allow hex string value)" into tizen_3.0
Jakub Skowron [Wed, 17 Jan 2018 13:27:09 +0000 (14:27 +0100)]
[Utils] Fix Long conversion (allow hex string value)
Until now string "0x15" would be converted 0. This change affects
all numeric conversions which use _toLong.
According to https://www.w3.org/TR/WebIDL-1/#es-long value
should be initialized by ToNumber, which is defined in
https://tc39.github.io/ecma262/#sec-tonumber-applied-to-the-string-type
and allows value to be in form of HexIntegerLiteral.
Change-Id: Ib719ce8fd5beccc5947b761dc905c49ac0469490
Jakub Skowron [Tue, 23 Jan 2018 12:19:10 +0000 (13:19 +0100)]
[Filesystem] Add support for ISO-8859-1
Latin-1 encoding in FileReadString and FileWriteString
Change-Id: I2cd7942481619989891c3019d3f7d4325b962892
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Piotr Kosko [Fri, 26 Jan 2018 06:21:20 +0000 (06:21 +0000)]
Merge "[Filesystem] Remove special case for zero in readBytes/writeBytes" into tizen_4.0
Piotr Kosko [Fri, 26 Jan 2018 06:18:08 +0000 (06:18 +0000)]
Merge "[Download] Fix preventing crash. Prevent call callback twice" into tizen_4.0
Lukasz Bardeli [Thu, 25 Jan 2018 10:53:43 +0000 (11:53 +0100)]
[Download] Fix preventing crash. Prevent call callback twice
Add condition to prevent call some callback twice and modify body of methods
OnFinished, OnCanceled and OnFailed to prevent crash.
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I7d194b4d762a52f0281e22555bfd54caa3cb4579
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Thu, 25 Jan 2018 10:53:43 +0000 (11:53 +0100)]
[Download] Fix preventing crash. Prevent call callback twice
Add condition to prevent call some callback twice and modify body of methods
OnFinished, OnCanceled and OnFailed to prevent crash.
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I7d194b4d762a52f0281e22555bfd54caa3cb4579
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Piotr Kosko [Thu, 25 Jan 2018 10:15:55 +0000 (10:15 +0000)]
Merge "[Common] Improve performance of picojson::serialize_str" into tizen_4.0
Rafal Walczyna [Thu, 25 Jan 2018 09:01:43 +0000 (10:01 +0100)]
[humanactivitymonitor] Fix crash when WRIST_UP event was called
[Verification] Tested with custom app - event fires properly
Auto test on TW2 - 100% passrate
Change-Id: I762a2a0950c4b17333f78b11eb320680f8ec1128
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Jakub Skowron [Wed, 24 Jan 2018 08:44:34 +0000 (09:44 +0100)]
[Filesystem] Remove special case for zero in readBytes/writeBytes
Null character in Unicode sequence is correctly interpreted
by picojson and crosswalk, so remove mapping 0 to 0x100.
Change-Id: I61988a1089ecdab006ce5cc2492960d526fb9455
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Jakub Skowron [Fri, 19 Jan 2018 11:00:53 +0000 (12:00 +0100)]
[Common] Remove unused member and parameters from ScopeLogger
Change-Id: I1ce2a5747c31e7a751f75005b0574e983e860fb1
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>