Sangchul Lee [Wed, 24 Jul 2024 10:17:06 +0000 (19:17 +0900)]
webrtc_internal: Add 'ssrc' outparam to webrtc_media_source_add_transceiver_encoding()
[Version] 1.1.17
[Issue Type] API
Change-Id: I5b2be20c9e2c635edc9612fe64671c22f68eb73d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 16 Jul 2024 08:45:44 +0000 (17:45 +0900)]
webrtc_source_mediapacket: Revise the timing of invoking the nego. needed cb
Previously, in case of h264 format, pushing a h264 buffer is required to
invoke webrtcbin's negotiation needed callback. With setting the particular
property of rtph264pay, it'll be invoked before pushing the first buffer.
[Version] 1.1.16
[Issue Type] Improvement
Change-Id: I9fb47ded651886a9a3dfb23b68b57b787830ca2f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 15 Jul 2024 09:37:22 +0000 (18:37 +0900)]
webrtc_internal: Revise webrtc_media_source_set[get]_payload_type()
Logic has been improved for multiple codecs of null source.
Now, payload type can be set to each codec of the null source.
[Version] 1.1.15
[Issue Type] Improvement
Change-Id: I5864d7f9bfd5e937e407f7b24d0950958bc6a826
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 12 Jul 2024 06:21:35 +0000 (15:21 +0900)]
test: Add VP8 format for webrtc_media_packet_source_set_format() test
[Version] 1.1.14
[Issue Type] Test application
Change-Id: I46e45afdc389c5e13d2a3a4c4c12f8cc971ad89d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 12 Jul 2024 06:15:49 +0000 (15:15 +0900)]
webrtc_source_mediapacket: Set picture-id-mode in case of VP8 payloader
It is applied similarly with the commit below.
:
17e92a5dcf40ad3a82cde8fa3c1cb41652f2ccb3
_update_payloader_vp8_picture_id_mode() is extracted from the
previous codes.
[Version] 1.1.13
[Issue Type] Improvement
Change-Id: I6e390f72f0664ee709d14f9db2843d41b33b6542
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 10 Jul 2024 07:07:55 +0000 (16:07 +0900)]
Remove unnecessary braces
[Version] 1.1.12
[Issue Type] Convention
Change-Id: Ia2a925d7101da5ddf5349ca707bd99a1a2d4fe91
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 4 Jul 2024 08:15:51 +0000 (17:15 +0900)]
test: Add test case for webrtc_null_source_set_media_type()
[Version] 1.1.11
[Issue Type] Test application
Change-Id: I2cb459eadb42073d83d8cbc74a30a0f8f2207d79
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 4 Jul 2024 08:15:37 +0000 (17:15 +0900)]
webrtc_internal: Add webrtc_null_source_set_media_type()
If this function is called to the particular null source(recvonly),
then all of available codecs which defined in ini file are set to
the transceiver. Therefore offer or answer description will represents
various codec information via rtpmap attributes.
[Version] 1.1.10
[Issue Type] Internal API
Change-Id: Ifba9314b2eb769ae67a5dbdd8d9aab402ce28257
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 9 Jul 2024 07:26:54 +0000 (16:26 +0900)]
fixup! webrtc_internal: Revise parameter of webrtc_media_source_set[get]_payload_type()
A compile error on 64-bit has been fixed.
Change-Id: I23615ded2b4d3d1319f18b63a20ec6586a84e517
Sangchul Lee [Fri, 5 Jul 2024 23:56:20 +0000 (08:56 +0900)]
webrtc_internal: Revise parameter of webrtc_media_source_set[get]_payload_type()
webrtc_test has been fixed to comply with the changes.
[Version] 1.1.9
[Issue Type] Internal API
Change-Id: I530e8210aa838e6dd4651cf0dc0b5a5631117ff1
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 4 Jul 2024 08:44:48 +0000 (17:44 +0900)]
Apply more macro to exclude lines from coverage measurement
[Version] 1.1.8
[Issue Type] Coverage
Change-Id: I938ec05d398ae463edfe668413c82ef87b2f5ac7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 16 Jan 2024 00:32:54 +0000 (09:32 +0900)]
webrtc_transceiver: Add more information about H264
ST signaling server requires this for NEST doorbell. So it is added.
Plus, ortc of mediasoup requires these fields as well.
[Version] 1.1.7
[Issue Type] Improvement
Change-Id: I9a40779f5fb70f534b62a7dd37f2261ea9a76b17
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 1 Jul 2024 02:45:05 +0000 (11:45 +0900)]
test: Add test case for webrtc_set_bundle_policy_max_compat()
[Version] 1.1.6
[Issue Type] Test application
Change-Id: I7c87d359b8882558c706cf4fe9d01056892e7bdd
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 1 Jul 2024 02:37:16 +0000 (11:37 +0900)]
webrtc_internal: Add webrtc_set_bundle_policy_max_compat()
[Version] 1.1.5
[Issue Type] Internal API
Change-Id: I22f27c83598b34eb51d46675493ba807dbf39799
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 27 May 2024 06:40:10 +0000 (15:40 +0900)]
webrtc_source_private: Set picture-id-mode in case of VP8 payloader
7-bit picture id has been set to vp8 payloader.
It has also been verified with Chrome browser.
[Version] 1.1.4
[Issue Type] Compatibility
Change-Id: Ib05694631fbb1424ba0c21194f103e94b9484f24
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 12 Apr 2024 23:48:58 +0000 (08:48 +0900)]
webrtc_source: Make sure to get ssrc before returning webrtc_start_media_source()
It is modified to return the function after invoking
__webrtcbin_on_negotiation_needed_cb() to get ssrc properly when
the following funcion is called - webrtc_create_offer().
[Version] 1.1.3
[Issue Type] Bug fix
Change-Id: Ic1b7abc76a2fb932978f17ea9af1392628937361
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 13 Jun 2024 05:33:48 +0000 (14:33 +0900)]
webrtc_display: Destroy tbm bo list when bo size has been changed
It is related to dynamic resolution change in case of EVAS rendering.
It has fixed the crash due to the invalid bo size when facing this case.
[Version] 1.1.2
[Issue Type] Bug fix
Change-Id: Idd0ef5467acf39ca667c5a6b41505858e12f06d2
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 11 Apr 2024 08:51:19 +0000 (17:51 +0900)]
test: Add menu for webrtc_start_media_source()
[Version] 1.1.1
[Issue Type] Test application
Change-Id: Ia6b07b0affa309e732d9b86fb8a989465ffcbb7d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 29 Mar 2024 07:20:44 +0000 (16:20 +0900)]
Add webrtc_start_media_source() function
This function will be used after adding a media source during state
of #WEBRTC_STATE_NEGOTIATING or #WEBRTC_STATE_PLAYING.
It has been added for re-negotiation scenario.
[Version] 1.1.0
[Issue Type] API
Change-Id: I0985473ce0c37767c8734072104f9b34132475a5
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 29 Mar 2024 05:43:34 +0000 (14:43 +0900)]
webrtc_internal: Fix not to manage pt values in case of webrtc_media_source_set_payload_type()
If this function is used to set a payload type value, the value of
the parameter can be used even if it is already assigned by other one.
[Version] 1.0.5
[Issue Type] Improvement
Change-Id: I143beac2ef5737bec77c68c9d789f3ee905ca5a7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 5 Jun 2024 03:12:49 +0000 (12:12 +0900)]
Change state constraint on webrtc_foreach_stats()
It has been changed to allow WEBRTC_STATE_NEGOTIATING state
to get some stats information in this state later.
[Version] 1.0.4
[Issue Type] Release state constraint
Change-Id: Iafc094f695badd4d5c823d70b59cbf400c33cc1e
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 3 Apr 2024 02:01:33 +0000 (11:01 +0900)]
Remove state constraint on functions for configuration
Functions below are revised.
: webrtc_set_stun_server()
: webrtc_add_turn_server()
: webrtc_set_bundle_policy()
: webrtc_set_ice_transport_policy()
[Version] 1.0.3
[Issue Type] Release state constraint
Change-Id: I8235391d57ec42d2886aeba2fcbdc511f7a7628d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 28 Mar 2024 08:18:34 +0000 (17:18 +0900)]
Remove state constraint on webrtc_create_data_channel()
[Version] 1.0.2
[Issue Type] Release state constraint
Change-Id: I438efbfa0225d16736cd6801d16d51f50efffe87
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 28 Mar 2024 02:34:30 +0000 (11:34 +0900)]
Remove state constraint on functions for media source
It allows for easing the state constraints for below functions.
: webrtc_add_media_source()
: webrtc_remove_media_source()
: webrtc_media_source_set_transceiver_direction()
: webrtc_media_source_set_transceiver_codec()
: webrtc_mic_source_set_sound_stream_info()
: webrtc_camera_source_set_device_id()
: webrtc_media_packet_source_set_format()
: webrtc_file_source_set_path()
Below are internal functions.
: webrtc_add_media_source_internal()
: webrtc_media_source_set_payload_type()
[Version] 1.0.1
[Issue Type] Release state constraints
Change-Id: Idbad43285d35ccf3842e91ce31683ff748864a62
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 28 Oct 2022 05:14:36 +0000 (14:14 +0900)]
Change state constraint on functions for negotiation
It allows for easing the state constraints for below functions.
: webrtc_create_offer[_async]()
: webrtc_create_answer[_async]()
: webrtc_set_local_description()
: webrtc_set_remote_description()
[Version] 1.0.0
[Issue Type] Release state constraints
Change-Id: Ia7a7db4a7ac4648e4fd7cb1bf46ff079710b727b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 19 Mar 2024 01:44:54 +0000 (10:44 +0900)]
test: Add menu for setting transceiver receiving data drop
Two items have been added as below.
srd. Set transceiver recv drop
grd. Get transceiver recv drop
[Version] 0.4.55
[Issue Type] Test application
Change-Id: I1f42282761c8a786ec26a3fa7b62062584a2911b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
e895b88fff02c8355943d13ba4c17eae6f11e18d)
Sangchul Lee [Mon, 18 Mar 2024 08:36:29 +0000 (17:36 +0900)]
webrtc_internal: Add functions to set/get drop receiving data
Funtions are added as below.
: webrtc_media_source_set_transceiver_recv_drop()
: webrtc_media_source_get_transceiver_recv_drop()
Receiving packets from a remote peer are related to a specific transceiver
which was created by media source in this API.
To drop receiving packets without decoding, these new functions are
added.
[Version] 0.4.54
[Issue Type] Internal API
Change-Id: I414bea2fda91a08170928452ecc457f5d29b3962
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
b7686cd3ed6228aa6d7783e7d63f58b81cd3c438)
Sangchul Lee [Mon, 18 Mar 2024 06:15:46 +0000 (15:15 +0900)]
webrtc_private: Add probe callback to the newly added source pad of webrtcbin
_add_probe_to_pad_for_render() and _remove_probe_to_pad_for_render() are moved
from webrtc_source_loopback.c.
It has been fixed to use gst_object_ref() before assigning it to slot's variable.
This probe callback will be used to decide to render the RTP data or not.
[Version] 0.4.53
[Issue Type] Improvement
Change-Id: I9b539c842e754e4d6d93cc9f95f28f1b79184f00
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
ba84ea6e3b92131c67206f7545f328c8915d9066)
Sangchul Lee [Sat, 9 Mar 2024 05:26:37 +0000 (14:26 +0900)]
webrtc_private: Ensure signaling state change before returning of _webrtcbin_set_session_description()
Though posting to invoke the signaling state changed callback in idle
still exists, now it is possible to call webrtc_create_answer() without
checking the signaling state changed callback right after calling
webrtc_set_remote_description().
[Version] 0.4.52
[Issue Type] Improvement
Change-Id: If03504c56ec44654f729ec5ea4c2cd96f4c3547f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
d50e506fdff1700698991d00373b57eb30b56f88)
Sangchul Lee [Thu, 7 Mar 2024 07:46:20 +0000 (16:46 +0900)]
webrtc_transceiver: Revise the postfix number of mid
Considering the postfix value of gstreamer element name accumulates
even if the handle is destroyed and re-created in the same process,
it has been revised.
[Version] 0.4.51
[Issue Type] Bug fix
Change-Id: Ia513a40637230fcf158f7f8a8e584af104c9bd6e
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
fdca0f93759f51cd204f3ac73aaf49b1d18a7776)
Sangchul Lee [Thu, 7 Mar 2024 03:13:24 +0000 (12:13 +0900)]
test: Add menu for getting transceiver mid
[Version] 0.4.50
[Issue Type] Test application
Change-Id: I66e0c8824a0f7522cfeaaa5c6418988a584356e5
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
9ca9c8cb3b25b708f6876ce7e5d9239d18913827)
Sangchul Lee [Tue, 5 Mar 2024 08:26:53 +0000 (17:26 +0900)]
webrtc_internal: Add function to create session description from sdp string
webrtc_util_create_description() has been added.
[Version] 0.4.49
[Issue Type] Internal API
Change-Id: I3718e504f37c165a9bc5d39c83ec976f2a111bde
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
63a0c7ac8e865bdcbf2affc68dd9bb50e0788685)
Sangchul Lee [Mon, 4 Mar 2024 07:06:35 +0000 (16:06 +0900)]
Revise to check the return value of json_parser_new()
Error log for this situation is also added.
[Version] 0.4.48
[Issue Type] Improvement
Change-Id: I6035f5dd3ce04029b39f601a298c942ec97b62f4
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
d4070245a3b7d0563dee0349f8d6e7da4c30e5fb)
Sangchul Lee [Thu, 29 Feb 2024 07:29:56 +0000 (16:29 +0900)]
webrtc_internal: Add function to strip session description
webrtc_util_strip_description() has been added to only get the
string member of sdp object in the original description.
[Version] 0.4.47
[Issue Type] Internal API
Change-Id: Ib8c81c26a4924680c8d042fd73027badb7c7c201
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
77b8fceb46bfdf0d9062f5d29869297adabf8ee7)
Sangchul Lee [Thu, 29 Feb 2024 02:40:47 +0000 (11:40 +0900)]
webrtc_internal: Add webrtc_start_sync() function
The main difference with webrtc_start() is that this returns
after changing state to WEBRTC_STATE_NEGOTIATING without
invoking state changed callback.
[Version] 0.4.46
[Issue Type] Internal API
Change-Id: Ia4d295de5ec861a7b7d20deed35c6c764a0e01d7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
ef0c8ad1e94441a702d67dc1671191b6f7e9fc8a)
Sangchul Lee [Wed, 21 Feb 2024 06:19:22 +0000 (15:19 +0900)]
webrtc_internal: Add function to get transceiver mid
webrtc_media_source_get_transceiver_mid() has been added.
[Version] 0.4.45
[Issue Type] Internal API
Change-Id: Ia69250ac27b46c68e01bbae125ebbbd103d874da
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
de4b925b47d7bea80afa945778e463965a95e32f)
Sangchul Lee [Wed, 21 Feb 2024 04:23:08 +0000 (13:23 +0900)]
webrtc_internal: Add function to get media type by source id
webrtc_media_source_get_type() has been added.
[Version] 0.4.44
[Issue Type] Internal API
Change-Id: I8659fcb85957ae353cf3e774d34477f8ebea7388
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 7 Feb 2024 07:31:43 +0000 (16:31 +0900)]
webrtc_internal: Add functions to get local/remote description
Functions have been added as below.
- webrtc_get_local_description()
- webrtc_get_remote_description()
[Version] 0.4.43
[Issue Type] Internal API
Change-Id: Ifb481b4b005a40145e959d31e3d2ccc3bb6c23f1
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 17 Jan 2024 08:11:17 +0000 (17:11 +0900)]
test: Add menu for activating transceiver encoding
[Version] 0.4.42
[Issue Type] Test application
Change-Id: If83d2eac958ba87d8a24d53862297c224e7ee734
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 17 Jan 2024 07:49:01 +0000 (16:49 +0900)]
webrtc_internal: Add API to active transceiver encoding option
webrtc_media_source_active_transceiver_encoding() has been added.
This function is to activate or deactivate each rid based stream.
[Version] 0.4.41
[Issue Type] Internal API
Change-Id: I65b4edcb7b171ad7c17b97153047888039a54e9f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 10 Jan 2024 05:40:12 +0000 (14:40 +0900)]
webrtc_transceiver: Apply simulcast info to null source type
In case of answerer, null source type(recvonly) is used to select
codec information for receiving suggested streams from offer description.
If the offer description suggests RID based simulcast, this patch enables
to choose some of RIDs in the answer description to receive them.
[Version] 0.4.40
[Issue Type] New feature
Change-Id: Ifb036274f2e7c94c5be94d3f782e0edc16b1ab5a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 9 Jan 2024 03:31:07 +0000 (12:31 +0900)]
test: Add menu for adding/removing transceiver encoding
[Version] 0.4.39
[Issue Type] Test application
Change-Id: I3a89ca3ae6828f063ab564bd8a3931879e572fdb
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 20 Dec 2023 00:36:04 +0000 (09:36 +0900)]
webrtc_internal: Add APIs to add/remove transceiver encoding option
Two functions are added.
: webrtc_media_source_add_transceiver_encoding()
: webrtc_media_source_remove_transceiver_encoding()
Multiple source bin for rid-based simulcast could be added to
a particular media source. Each source bin has its own encoding
option and a rtp payloader with a specific ssrc.
RTP header extensions are also added according to definitions
from gstreamer.
[Version] 0.4.38
[Issue Type] Internal API
Change-Id: Iebc1fd223d81b04a7eb47a7a5d7181277737f7ad
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 17 Jan 2024 06:57:51 +0000 (15:57 +0900)]
webrtc_sink_dump: Check return value of g_strdup_printf()
[Version] 0.4.37
[Issue Type] Svace defect (DEREF_OF_NULL.RET.ALLOC)
Change-Id: I30166ee0e3661a9e3aab51cf9f845471ff1d15a4
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 12 Jan 2024 00:22:27 +0000 (09:22 +0900)]
Apply ASSERT() to the result of g_hash_table_insert()
[Version] 0.4.36
[Issue Type] Refactoring
Change-Id: Ia298d0697c6cc06c2417d686ebccc1b497b0d5fa
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 11 Jan 2024 07:37:40 +0000 (16:37 +0900)]
webrtc_tbm/stats: Introduce ASSERT() macro function
Note that this assertion would be helpful not only during early
of the development phase to check unexpected wrong codes but
also during the runtime with being attributed to the compiler
optimizations.
Enough awareness of parameters whether if they are inevitable
or not would be prerequisite before applying it.
[Version] 0.4.35
[Issue Type] Debug
Change-Id: I29834774100c613a0f2154b589b8142342be40d8
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 11 Jan 2024 07:19:49 +0000 (16:19 +0900)]
test: Add missing lock
[Version] 0.4.34
[Issue Type] Coverity defect (MISSING_LOCK)
Change-Id: Id969572e1896b660b620216ecb376a43d4a891fd
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 11 Jan 2024 02:58:49 +0000 (11:58 +0900)]
webrtc_internal: Set payloader type only if it is not occupied
Codes for occupying and releasing payload type have been added in
webrtc_media_source_set_payload_type().
Checking the media_type parameter of webrtc_media_source_get_payload_type()
has been added to fix coverity defect.
[Version] 0.4.33
[Issue Type] Improvement
Change-Id: I9eaf492456d24977d300d0682bcbbf60acd0f9ef
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 10 Jan 2024 08:13:25 +0000 (17:13 +0900)]
webrtc_transceiver: Fix unwanted payload type number order
This patch fixes the issue where there is another media source added
before the null source, the payload type number gets reversed because
the payload type number of the null source type was obtained when calling
webrtc_media_source_set_transceiver_codec() whereas other source type
get it when calling webrtc_start().
[Version] 0.4.32
[Issue Type] Bug fix
Change-Id: Ib438dc280c843ddf8652d114a4ced23319f73b71
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 9 Jan 2024 03:57:39 +0000 (12:57 +0900)]
webrtc_transceiver: Get mid from transceiver name
This mid value will be set later to rtp header extension
for simulcast preparation.
[Version] 0.4.31
[Issue Type] Improvement
Change-Id: Ie85ddca278eb6a179e1753e5618f010a140ef8e2
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 4 Jan 2024 03:27:02 +0000 (12:27 +0900)]
Adjust order of returning error values
The order of errors for particular functions were not in compliance with
the following sequence.
- NOT_SUPPORTED > PERMISSION_DENIED > INVALID_PARAMETER
[Version] 0.4.30
[Issue Type] Improvement
Change-Id: I816ce028bc31abb601871538ea57db96f1ee4110
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 3 Jan 2024 03:02:18 +0000 (12:02 +0900)]
Add locking mutex for state
[Version] 0.4.29
[Issue Type] Coverity defect (MISSING_LOCK)
Change-Id: If29613750c55c1179a3393de65f52866be4997b8
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 27 Dec 2023 08:09:24 +0000 (17:09 +0900)]
Add new param of postfix number to CREATE_ELEMENT_FROM_REGISTRY macro function
-1 value will affect nothing.
Otherwise, the element name will be followed by the postfix number.
[Version] 0.4.28
[Issue Type] Improvement
Change-Id: I1529255b78b153deb61cd0f755f32cf7871fe9f9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 27 Dec 2023 00:47:36 +0000 (09:47 +0900)]
webrtc_source: Expand parameter to set ssrc later when making a rtp caps
If set it 0, it'll be set to a random number inside of gst plugin as it is.
[Version] 0.4.27
[Issue Type] Improvement
Change-Id: I2259ac28270709480c967fe1e40e3ef9551517dc
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 1 Dec 2023 02:57:35 +0000 (11:57 +0900)]
webrtc_test: Add support to show multiple video tracks from one remote peer
Test condition:
1. peer to peer test (not using room menu)
2. display type is EVAS
3. it should not exceed more than 3 remote video tracks.
[Version] 0.4.26
[Issue Type] Testsuite
Change-Id: Idd081077d97a6bab538d49a0f5a3c282079224b9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
e3dd9012c7ec6781b59b989fc3616819df17c3e0)
Sangchul Lee [Wed, 29 Nov 2023 03:46:19 +0000 (12:46 +0900)]
webrtc_internal: Fix doxygen
Missing @internal tag is added.
An error type that does not occur is removed from the description.
@Remarks for releasing handle are added.
Mis-typed function name is fixed.
[Version] 0.4.25
[Issue Type] Doxygen
Change-Id: I045d70214b458d67cab8aee8d926e38cec68ba84
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 23 Nov 2023 01:56:42 +0000 (10:56 +0900)]
Remove meaningless parameter checks
The first parameter of callbacks from gstreamer would be always not null.
Once webrtc handle has been created, there's no possibility that
'gst.webrtcbin' or 'gst.source_slots' is null.
A typo is also fixed.
[Version] 0.4.24
[Issue Type] Clean up
Change-Id: I03fc688b1b694c86c77d958fe4729734b799b897
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 20 Nov 2023 08:48:38 +0000 (17:48 +0900)]
webrtc_internal: Add webrtc_set_display_qos()
[Version] 0.4.23
[Issue Type] Internal API
Change-Id: I2a644795109b9534fc1ad65499c3ffb62c7ea3ec
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 20 Nov 2023 03:45:30 +0000 (12:45 +0900)]
webrtc_display: Fix errors when setting EVAS display mode/visible
These are fixed by using checking display type that shows
whether if the mm_display_interface_set_display_mainloop_sync()
is performed or not.
[Version] 0.4.22
[Issue Type] Bug fix
Change-Id: I070318bb73be96abd07da3d0ec419c0703c83109
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 10 Oct 2023 08:18:29 +0000 (17:18 +0900)]
Fix SVACE defect (DEREF_OF_NULL.RET.STAT)
[Version] 0.4.21
[Issue Type] SVACE (VD)
Change-Id: Ie0d31d03e2d63100b22f7a37bedaead826d7fede
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 21 Aug 2023 10:21:11 +0000 (19:21 +0900)]
test: Use g_file_set_contents() to dump file
[Version] 0.4.20
[Issue Type] Refactoring
Change-Id: I00411336b80159693394c23089f6bfeab74a8fba
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 18 Aug 2023 01:23:41 +0000 (10:23 +0900)]
webrtc_internal: Revise @since_tizen 7.5 to 8.0
[Version] 0.4.19
[Issue Type] Doxygen
Change-Id: Iba1131b33364afd3277c7297a38336d8777d09e5
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 8 Aug 2023 06:47:44 +0000 (15:47 +0900)]
Fix SVACE defect (DEREF_OF_NULL.EX)
[Version] 0.4.18
[Issue Type] SVACE (VD)
Change-Id: I3af6a032af8ce2a0d7ed91c6529d74511c8c562b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 7 Aug 2023 05:50:21 +0000 (14:50 +0900)]
Fix SVACE defects (SIGN_EXTENSION)
[Version] 0.4.17
[Issue Type] SVACE
Change-Id: Ie8e5b4dadf738d4a17323e29ac0712fb6fd6ce4f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jaechul Lee [Mon, 24 Jul 2023 06:07:03 +0000 (15:07 +0900)]
webrtc_private: Change to use effect_method API
AEC APIs in sound-manager have been changed.
[Version] 0.4.16
[Issue Type] Feature
Change-Id: Idd9a9988b80aa47e72639e14724d40ce0a4406b7
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Sangchul Lee [Fri, 7 Jul 2023 10:19:10 +0000 (19:19 +0900)]
Apply display feature
Some functions are not supported on the binary for the headed device.
Without this feature, these will return NOT SUPPORTED error.
[Version] 0.4.15
[Issue Type] Feature
Change-Id: I8344c964244f79f78e8864c1f18ae815d903a9f6
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 5 Jul 2023 09:16:13 +0000 (18:16 +0900)]
Export webrtc_set[get]_audio_mute() API to public header
[Issue Type] API
Change-Id: I64ac88a28c153ddc15661ca4f71ea596a3b48f0c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
wchang kim [Fri, 30 Jun 2023 01:16:21 +0000 (10:16 +0900)]
Fixed the build error using gcc 13
Change-Id: I18c2d92099b8b5762cec3cf03af717e5c9d7ef31
Jaechul Lee [Fri, 16 Jun 2023 07:00:04 +0000 (16:00 +0900)]
webrtc_private: Fix build break
PA_PROP_MEDIA_ECHO_CANCEL_METHOD was removed in pulseaudio proplist.h.
So, new property named 'PA_PROP_MEDIA_PREPROCESSOR_METHOD' should be
used.
[Version] 0.4.14
[Issue Type] Build break
Change-Id: Ia6a5d0d221dd360aa73c5fc6ed4f4d36b8315c41
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Sangchul Lee [Wed, 7 Jun 2023 06:15:17 +0000 (15:15 +0900)]
Change tizen version 7.5 to 8.0
It is related to ACR-1750.
[Version] 0.4.13
[Issue Type] Doxygen
Change-Id: I47c1cbd0e2ca9c0bc8db710db8f44e542fe57746
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 17 May 2023 00:20:36 +0000 (09:20 +0900)]
webrtc_private: Ensure to invoke error callback in main thread
[Version] 0.4.12
[Issue Type] Improvement
Change-Id: I3410d3baf9d113fd4936be6d5a93ce33839dc3e2
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 3 May 2023 10:21:20 +0000 (19:21 +0900)]
webrtc_source_camera: Support tizencamerasrc element
[Version] 0.4.11
[Issue Type] Improvement
Change-Id: Id01e931221c709a48af2e4ab02c1fbc826f24d6d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 17 Apr 2023 02:44:59 +0000 (11:44 +0900)]
Apply new TIZEN_FEATURE_SIGNALING definition
[Version] 0.4.10
[Issue Type] Feature
Change-Id: Ic5d5e7be966883af356734cd627be3fabccd23b3
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 14 Apr 2023 05:59:12 +0000 (14:59 +0900)]
Change the application of macro for coverage measurement exclusion
[Version] 0.4.9
[Issue Type] Line coverage
Change-Id: Iadbf2acef199da87181ee0a51a76cfd0194e2e82
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 11 Apr 2023 06:03:38 +0000 (15:03 +0900)]
Apply new TIZEN_FEATURE_SNAPSHOT definition
[Version] 0.4.8
[Issue Type] Feature
Change-Id: Ic5c67f3066c5157f76303bd17e8c3fe1fb46ba3f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 11 Apr 2023 05:24:04 +0000 (14:24 +0900)]
Apply new TIZEN_FEATURE_DNS definition
[Version] 0.4.7
[Issue Type] Feature
Change-Id: I63e85cddacd1cd56dc47cb6c73fa162a623dc07e
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 14 Mar 2023 07:36:22 +0000 (16:36 +0900)]
webrtc_internal: Add webrtc_set_display_surface_id()
[Version] 0.4.6
[Issue Type] API
Change-Id: I8678951f128dcb448645e1032838c4392f9e2a20
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 22 Mar 2023 07:07:15 +0000 (16:07 +0900)]
webrtc_test_espp: Remove unnecessary function call
Codes to call esplusplayer_activate() are removed.
Some variable names are changed.
[Version] 0.4.5
[Issue Type] Improvement
Change-Id: Id3d7f1c841b4e155a2a0cfa0e18033fc3c8d2bec
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 21 Mar 2023 08:59:08 +0000 (17:59 +0900)]
webrtc_sink: Set channels or rate to media format even if only one has a valid value
More logs are added.
[Version] 0.4.4
[Issue Type] Improvement
Change-Id: I34d985ee78051dc82ff517920739b037c97714e8
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Sat, 11 Mar 2023 07:04:34 +0000 (16:04 +0900)]
webrtc_sink: Save mute value and apply it when audiosink is created
[Version] 0.4.3
[Issue Type] Improvement
Change-Id: Icb5181afd2c759756187cd2a68ce4fa315c84c15
Sangchul Lee [Wed, 8 Mar 2023 02:08:49 +0000 (11:08 +0900)]
Add new error type - WEBRTC_ERROR_NETWORK_RESOURCE_FAILED
[Version] 0.4.2
[Issue type] API
Change-Id: I640059cf94bac87fba28ef4e5ff37cadc6f86680
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 3 Feb 2023 11:24:21 +0000 (20:24 +0900)]
Add new stats types
new enums are added as below.
for webrtc_stats_type_e
: WEBRTC_STATS_TYPE_CANDIDATE_PAIR
: WEBRTC_STATS_TYPE_LOCAL_CANDIDATE
: WEBRTC_STATS_TYPE_REMOTE_CANDIDATE
for webrtc_stats_prop_e
: WEBRTC_STATS_PROP_KIND
: WEBRTC_STATS_PROP_ADDRESS
: WEBRTC_STATS_PROP_PORT
: WEBRTC_STATS_PROP_CANDIDATE_TYPE
: WEBRTC_STATS_PROP_PRIORITY
: WEBRTC_STATS_PROP_PROTOCOL
: WEBRTC_STATS_PROP_RELAY_PROTOCOL
: WEBRTC_STATS_PROP_URL
: WEBRTC_STATS_PROP_LOCAL_CANDIDATE_ID
: WEBRTC_STATS_PROP_REMOTE_CANDIDATE_ID
Some enum values are changed.
Some definitions are deprecated.
[Version] 0.4.1
[Issue type] New feature
Change-Id: I021af299a1b3ddb048f29a3888b5dc86d8191ab8
Sangchul Lee [Thu, 2 Mar 2023 02:15:05 +0000 (11:15 +0900)]
Use g_autoptr for JsonParser variable
[Version] 0.3.289
[Issue type] Refactoring
Change-Id: Iaf7fac85e87150abdfae106827fb84b7c41d001e
Sangchul Lee [Thu, 16 Feb 2023 07:32:34 +0000 (16:32 +0900)]
webrtc_private: Print debug message in GstMessage object
[Version] 0.3.288
[Issue type] Logs
Change-Id: Ied0efd7e522cddbf3b1f291aec24b78deb91ace7
Sangchul Lee [Mon, 13 Feb 2023 23:30:46 +0000 (08:30 +0900)]
Use GST_TIME_FORMAT for buffer timestamps
[Version] 0.3.287
[Issue type] Logs
Change-Id: Ibc961bf988aa9225b5f4f4d1d7df2a381fbc459c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 10 Jan 2023 09:12:41 +0000 (18:12 +0900)]
webrtc_stats: Dump stats result into the file
The JSON data of stats result will be written into
/tmp/webrtc-stats-[pid]-[handle address].dump
if 'stats log period' field in the ini file is set to some values.
[Version] 0.3.286
[Issue type] New feature
Change-Id: If66b7936166fdb9412f748f38a5374fd472df677
Seungbae Shin [Thu, 2 Feb 2023 05:14:18 +0000 (14:14 +0900)]
webrtc_stats: propagate the user cb return using the return of gst_structure_foreach()
[Version] 0.3.285
[Issue type] Refactoring
Change-Id: If7e8dabfc8fb87f4a93259b81a37f47f3b01608b
Sangchul Lee [Tue, 7 Feb 2023 01:29:56 +0000 (10:29 +0900)]
webrtc_dns: Check error of getifaddrs()
[Version] 0.3.284
[Issue type] Coverity defect (CHECKED_RETURN)
Change-Id: I8cfa281059b5b8efc5b2f6660bd89bcb475bfef2
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 1 Feb 2023 08:51:01 +0000 (17:51 +0900)]
webrtc_stats: Add null check code before calling gst_structure_foreach()
It is to avoid printing warning message from a console.
[Version] 0.3.283
[Issue type] Improvement
Change-Id: I52f0c9ad3f7c218b5af9d70706625a1e7848fcbb
Sangchul Lee [Fri, 13 Jan 2023 03:39:00 +0000 (12:39 +0900)]
webrtc_stats: Fix memory leak
[Version] 0.3.282
[Issue type] Resource leak
Change-Id: Ia4d3a70b80a4eb69b0052dc36f9875b8598dd5d9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 12 Jan 2023 06:09:53 +0000 (15:09 +0900)]
webrtc_dns: Use version 4 UUID as a unique hostname
It is mentioned in 3.1.1. of the link below.
: https://www.ietf.org/archive/id/draft-ietf-mmusic-mdns-ice-candidates-03.html
[Version] 0.3.281
[Issue type] Improvement
Change-Id: Ia4665c17fd812fb61d0e5f8c33c3ef7ecc97955a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 9 Jan 2023 05:01:35 +0000 (14:01 +0900)]
webrtc: Add missing codes for updating transceiver
The same codes from webrtc_create_offer[answer]() are added
to webrtc_create_offer[answer]_async().
[Version] 0.3.280
[Issue type] Bug fix
Change-Id: I582139cff77237ec9237a6473cdd7efd347a3b47
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 4 Jan 2023 05:09:55 +0000 (14:09 +0900)]
webrtc_dns: Consider more IP address ranges as private IP
Address ranges below are considered as private IP.
Class A: 10.0.0.0 - 10.255.255.255
Class B: 172.16.0.0 - 172.31.255.255
[Version] 0.3.279
[Issue type] Improvement
Change-Id: Ib65e55aed1a7524cd77d41c1376a3452cb5946b7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 27 Dec 2022 08:25:30 +0000 (17:25 +0900)]
webrtc_private: Replace private IP with hostname in local ICE candidate
[Version] 0.3.278
[Issue type] New feature
Change-Id: I351db37c3a1fafec9b63bb10840b145f8eb0fa53
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 27 Dec 2022 08:01:55 +0000 (17:01 +0900)]
webrtc_ini: Add new item to enable to conceal private IP address
Default value is false. If 'conceal private ip' in ini file is
set to yes, then hostname for the private IP address will be used
in each local ICE candidate.
e.g)
[general]
conceal private ip = yes
[Version] 0.3.277
[Issue type] New feature
Change-Id: Ida5eb1db00d40661cb32c6501515874a85246328
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 23 Dec 2022 06:31:10 +0000 (15:31 +0900)]
webrtc_dns: Add support for registering DNS service
This patch uses dns_sd.h of mdnsresponder to register DNS service
and to publish hostname for private IP address.
[Version] 0.3.276
[Issue type] New feature
Change-Id: I9a9d64c367b2a49f2fe6e2ca7d1cd3ceca91770d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 28 Dec 2022 05:26:20 +0000 (14:26 +0900)]
webrtc_sink_snapshot: Create queue before creating convert thread
Sometimes the new thread tries to access queue not created yet which causes
a crash. It is fixed to create queue first and then create thread as well as
check if the result of pop operation is NULL.
[Version] 0.3.275
[Issue Type] Crash
Change-Id: Icefd4d6d9b38141384fbc70b3a7097a6f674fd4d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 19 Dec 2022 03:03:27 +0000 (12:03 +0900)]
webrtc_sink_snapshot: Remove switch-case
Instead, bit-wise check is used whether to encode data or not.
Some functions to convert type are added.
[Version] 0.3.274
[Issue Type] Refactoring
Change-Id: Ib05495d97ef390429440a3c0e049e5018868758c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 12 Dec 2022 03:01:35 +0000 (12:01 +0900)]
webrtc_test: Add menu to take snapshot
[Version] 0.3.273
[Issue Type] Add
Change-Id: I2d869ff6e7db5dd3e367b4a24fd31321a2dc51d5
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
dd6a0fcb0483d6c380c16aab597d5b88d6d8a9f0)
Sangchul Lee [Thu, 8 Dec 2022 07:35:41 +0000 (16:35 +0900)]
webrtc_internal: Add webrtc_take_snapshot() API
[Version] 0.3.272
[Issue Type] Internal API
Change-Id: I9750f05f7a64d414b9280644ebb6c84afb071417
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>