Michal Bloch [Wed, 5 Oct 2016 15:39:38 +0000 (17:39 +0200)]
Fix code issues found by cppcheck.
Change-Id: I79547320b0bb566efba904163094861d7514e83d
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 23 Sep 2016 13:35:16 +0000 (15:35 +0200)]
Add unit tests.
Change-Id: Ic1c02937f6cf6577ce63aa5961f76a5b54f0af99
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 30 Sep 2016 14:23:58 +0000 (16:23 +0200)]
pipe: Only take up file descriptors when needed
Change-Id: I7ade660e8e2273654ed8b782f42870824b33256e
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 30 Sep 2016 14:18:43 +0000 (16:18 +0200)]
pipe: Fix multithreaded pipe file descriptor reacquisition
Change-Id: I6d64a9f9adea2334dcaa67cbe2e6c6d98cb58b45
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Thu, 29 Sep 2016 19:28:28 +0000 (21:28 +0200)]
Ensure dlog is started before regular Tizen services wanting to use it
Change-Id: I9b80c2ae97b428be3309fbc30eb000d7f8716fa9
Michal Bloch [Thu, 29 Sep 2016 15:58:52 +0000 (17:58 +0200)]
Prevent segmentation faults and memory leaks
Change-Id: I51125aa059f028280f21cde2e72053f81ecfdbb6
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Thu, 29 Sep 2016 18:45:09 +0000 (20:45 +0200)]
Fix libdlog initialization with multiple threads
The backup null log handler is now set only on initialisation failure
instead of always being set at the beginning and overridden later.
The initialisation check does not care which particular handler is installed,
so threads which attempted to write a log while another thread was carrying out
initialisation could be directed to the null handler.
Change-Id: I3aaf6dcad8f72611e413969d48f0f68d44a7c308
Karol Lewandowski [Thu, 29 Sep 2016 19:32:07 +0000 (21:32 +0200)]
pipe: Also reconnect when last write was for bad fd
Change-Id: Iaf7f2fe44383a0395fd7199564aa3a28cf44298d
Karol Lewandowski [Fri, 30 Sep 2016 10:49:16 +0000 (12:49 +0200)]
pipe: Fix recvmsg() error handling
This fixes problem with recvmsg() error return code 0 being returned
as proper fd id (0, stdin).
Change-Id: Ia9be0b0b5d12ab202ea52c4153b749e1305a83c4
Karol Lewandowski [Thu, 29 Sep 2016 16:33:16 +0000 (18:33 +0200)]
pipe: Ensure pipe fd is opened in blocking mode
We need to either use blocking fd for write pipes or
handle EAGAIN errors explicitly. First solution is
more effective.
(NOTE: Reader sockets should use non-blocking fds
as readers - dlogutil - to not stall the daemon.)
Change-Id: I5a1043676bb963c7ecb722914d1933839d857093
Karol Lewandowski [Thu, 29 Sep 2016 16:30:31 +0000 (18:30 +0200)]
pipe: Fix fd leaks during connect
Change-Id: Idfb4c68852456a6011194c7d0c9d23874bf202bf
Kichan Kwon [Wed, 28 Sep 2016 06:58:23 +0000 (15:58 +0900)]
Revert removed declaration
- In some environment, dlog-internal.h is excluded
- Therefore, dlog.h have not to rely on the declaration of dlog-internal.h
Change-Id: I4726bfe02b42ce389c37c15604a0d3371acafed4
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Fri, 23 Sep 2016 09:08:28 +0000 (18:08 +0900)]
Add dependency to each sub-packages
Change-Id: I86fd90e857bdd4804c74850bf5a6f1ed2757f69c
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Thu, 22 Sep 2016 05:06:38 +0000 (14:06 +0900)]
Version up
Change-Id: I94f9a1fdd0df006216900efd4fcc337cad0c23c2
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kwon [Thu, 22 Sep 2016 05:00:16 +0000 (22:00 -0700)]
Merge "Fix a typo" into tizen
Kwon [Thu, 22 Sep 2016 05:00:10 +0000 (22:00 -0700)]
Merge "KMSG handling more robust." into tizen
Michal Bloch [Mon, 12 Sep 2016 09:12:38 +0000 (11:12 +0200)]
Cleanup unused code
Change-Id: Ie48b77b751be1f06b297ccecf89e73287a1e1488
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
[Rebase]
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 12 Sep 2016 07:42:40 +0000 (16:42 +0900)]
library integration : build all backends at one time
- Backend is selected by installing dlogbackend-BACKEND
- If any dlogbackend-BACKEND isn't installed, pipe backend is selected
Change-Id: I44a4bfc146de0a042c16bea2d6ede3a249075908
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 12 Sep 2016 05:54:54 +0000 (14:54 +0900)]
library integration : remove backend dependent macro
- To use dlog with all backends by building only one time, backend dependent macro should be removed
- Instead, we will find backend information in the conf file
Change-Id: Ie3d918deac3d3179a33a8c7d5a8e00360e271b5d
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 21 Sep 2016 01:02:40 +0000 (10:02 +0900)]
Fix minor issues
- Use thread-safe function
- Guarantee inserting null character
- Don't write exceed value to char variable
Change-Id: I61a1e91f0bfbb70a77f06d8ab18e656c83fd2f74
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Michal Bloch [Wed, 21 Sep 2016 13:28:30 +0000 (15:28 +0200)]
Fix a typo
Prevents grep attempt ruination
Change-Id: I3e036d6d0820a8be56e2f07a804c50e7c18138ea
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Tue, 20 Sep 2016 14:58:56 +0000 (16:58 +0200)]
Logger : set right permission to socket and log files
Change-Id: Ia5793ab0ce1e15da0d16c0685258f965a64e87a2
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
[Split logger configuration & file parsing]
Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
[Bug fix]
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 19 Sep 2016 02:39:35 +0000 (11:39 +0900)]
Set debugmode by checking debugmode file
- If debugmode is enabled, fatal log can be written
- Else, process writing fatal log is aborted
Change-Id: I4c4928f9ff3041ba103908179c563a172f3a737f
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Michal Bloch [Fri, 16 Sep 2016 15:55:21 +0000 (17:55 +0200)]
KMSG handling more robust.
* the parser handles malformed logs
* util no longer discards parser result
Change-Id: I2e706b970b88717265f552703b0774a2e276519a
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 16 Sep 2016 13:14:31 +0000 (15:14 +0200)]
Fix KMSG EPIPE handling
KMSG devices return EPIPE when the cyclic buffer rotates.
Change-Id: Idb27bccaee8bb14959e52fefaa70cf076c137bf8
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Kwon [Mon, 12 Sep 2016 07:54:16 +0000 (00:54 -0700)]
Merge "Update dlogutil help" into tizen
Michal Bloch [Mon, 12 Sep 2016 07:31:16 +0000 (09:31 +0200)]
Update dlogutil help
Change-Id: I1ae4b52246b3f64fe88438c8262f25fcf15efa09
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Kichan Kwon [Thu, 8 Sep 2016 07:27:07 +0000 (16:27 +0900)]
Fix minor issues
- Check too long path
- Close file at appropriate time
Change-Id: Ica9949b6d5ee678115c132d0e115cf93d24bb319
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Michal Bloch [Mon, 29 Aug 2016 14:42:53 +0000 (16:42 +0200)]
Logger packaging: dlogutil -> libdlog
KMSG logging is a core feature and is provided by the daemon.
Change-Id: I437f7fb6a3f8745379709d91da44163c8794cd73
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Michal Bloch [Mon, 29 Aug 2016 14:36:43 +0000 (16:36 +0200)]
Remove "_pipe" from universal files
Change-Id: Id331da1ec84c943e31e3d0106dbf14acc2473c1e
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 8 Sep 2016 18:00:30 +0000 (20:00 +0200)]
Fix passive log rotation for non-pipe backends
Change-Id: I6c816ffcce8067f467d409c770a3d8b8482d6821
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 29 Aug 2016 12:57:04 +0000 (14:57 +0200)]
Unify dlogutil
Change-Id: I87511d0dd4567fd373eeb15e3233ca96bc29f5ff
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 7 Sep 2016 18:31:07 +0000 (20:31 +0200)]
Reinstate udev rules
Change-Id: I17d1246afb00a08b83c9feae76fa888b22815dfa
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 7 Sep 2016 08:22:30 +0000 (17:22 +0900)]
Create upgrade script (2.4 -> 3.0)
Change-Id: Id2653f462a208e9d7c7931f6faf55951d42b81c0
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Michal Bloch [Thu, 25 Aug 2016 16:44:45 +0000 (18:44 +0200)]
Pipe util accepts many -b parameters
- To explore multiple buffers
- To seek out log messages
- To boldly do what old util has already done before
Change-Id: Ic35c4284848eeeb2bde0d29ea66a7a52e82faa58
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 23 Aug 2016 14:05:48 +0000 (16:05 +0200)]
Documentation.
Change-Id: Ifd945ead493a5999b837756a3fe62de599262ded
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 19 Aug 2016 10:50:31 +0000 (12:50 +0200)]
All backends use new logger and handle /dev/kmsg
* old daemon did not support /dev/kmsg logging, the new one does.
Now all backends (not only pipe) use this functionality.
* makes maintenance easier as there are no longer two separate daemons.
This simplifies both code and packaging.
Change-Id: I90cd3f22b2d055cbe0e92291ca8b1992133a0939
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 18 Aug 2016 13:45:47 +0000 (15:45 +0200)]
Refactor: KMSG now uses the same internal format
This massively simplifies code because there are no longer two
structures with differing layout but same name, which then allows
to unify a lot of duplicated functions which did the same thing
over different structures.
Change-Id: I585e6535ef15b53625d17fff581a41b434c558af
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 30 Aug 2016 12:57:57 +0000 (14:57 +0200)]
Logger: minor code fixes
Change-Id: I48f29b1e935c0dacb82e60afb22fb1158bc21485
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 29 Aug 2016 14:25:55 +0000 (16:25 +0200)]
Config: fix typos
Change-Id: I3ff436b7593b9c895925c48bd40a33352a5fcc94
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 24 Aug 2016 12:46:02 +0000 (14:46 +0200)]
Fix a memleak
Change-Id: Idba70819901ebfe5ce9076bf5afd2965ce891bc6
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 22 Aug 2016 12:03:57 +0000 (14:03 +0200)]
Pipe: fix typos in logger
Change-Id: I57701b6cf5386fbda2f2c0ecc258cb76e250a635
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Kichan Kwon [Sat, 20 Aug 2016 07:55:27 +0000 (16:55 +0900)]
Remove journal backend
- It is substituted to pipe backend
Change-Id: Ica8025cfe5c0a4734782a1dad5a56f2efb2ba646
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Michal Bloch [Fri, 19 Aug 2016 12:57:54 +0000 (14:57 +0200)]
Pipe devkmsg file: set standard format
Change-Id: I130235cd6ba78dce943d4f0c817415888e3b17c9
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 19 Aug 2016 12:31:26 +0000 (14:31 +0200)]
dloginit: fix output config
dloginit is supposed to write the real sizes of created buffers
to the config, but it sometimes used to write nulls even on success.
Change-Id: I02d521e43b165bb83fe4e5106ab5244eb1b211d6
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 19 Aug 2016 10:13:23 +0000 (12:13 +0200)]
Fix minor config issue
Paths to all buffers need to be defined even if they are not used.
Change-Id: I8b6c34c14417eb41fb7dd4d47ea1e2282fb3a5f7
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 19 Aug 2016 09:12:05 +0000 (11:12 +0200)]
Pipe: fix minor issues
* use thread-safe functions
(the daemon is single-threaded, this is mostly for code checking tools)
* prevent mis-expressed starvation
* fix a slight error in dlogutil format expectation
* add a label for a conditionally compiled legacy block
Change-Id: Ic243bafe243194b95de27fa78a469e1fbb356d74
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 18 Aug 2016 19:44:17 +0000 (21:44 +0200)]
Pipe: add /dev/kmsg support.
* add a -k parameter to dlog_logger configuration which enables /dev/kmsg reading.
* the -b parameter accepts "kmsg" now.
* the framework is easy to extend for the devices used by other backends
(i.e. /dev/kmsg## and /dev/log_*) in the future.
Change-Id: I2d17bcbb0a6455320869c19f1f3885d6baa63fe1
Signed-off-by: Kazimierz Krosman <k.krosman@samsung.com>
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 16 Aug 2016 16:21:07 +0000 (18:21 +0200)]
Pipe: Fix invalid rights
Change-Id: I81885a7cdf66f9cbab24469e2d78840666d723a9
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 16 Aug 2016 16:20:26 +0000 (18:20 +0200)]
Pipe: Fix rare flushing of seldomly used buffers
For any given buffer, if all other buffers combined receive messages more often than the time threshold (-t parameter),
the remaining buffer will only flush when the data threshold (-b parameter) is met regardless of time.
Both conditions are supposed to trigger a flush.
Change-Id: I522d2f09e788f9eb731f9e5e1039dcc1a0e64aac
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Kichan Kwon [Thu, 4 Aug 2016 08:17:41 +0000 (17:17 +0900)]
shared : remove timezone in the kerneltime format
Change-Id: I21bb01cf0ce46bc5dcbf066df5996d22c952134b
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kunhoon Baik [Wed, 10 Aug 2016 13:45:38 +0000 (22:45 +0900)]
Size tunning of dlog logger
At Tizen 2.3.1, dlog logger's size of each buffer was under 1M.
At Tizen 3.0, the dlog logger size may be shrinked to 2.3.1 after stablization completion.
(2.3.1 -> System : 512K, Radio : 256K, Main/App : 512K)
This is first trial of reducing log size at Tizen 3.0.
Change-Id: I019e8c650b27d7f97e57bf53f0e0a9f5537d7e5e
Kunhoon Baik [Sat, 6 Aug 2016 02:08:17 +0000 (11:08 +0900)]
Hawkp is not used as Tizen reference board any more
Change-Id: I125f48856c9e5681324929c6cee23ef3758f8be9
Kichan Kwon [Wed, 3 Aug 2016 05:05:31 +0000 (14:05 +0900)]
Set default backend to pipe backend and remove switch about journal backend
Change-Id: Ia0e900023999d036f5b7359b3c60bedb31e1ce41
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 3 Aug 2016 05:00:16 +0000 (14:00 +0900)]
dlogutil : set the default format of pipe backend with others
Change-Id: I80570fc030003074d47683316c3e9b272690cd40
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Michal Bloch [Wed, 20 Jul 2016 13:50:43 +0000 (15:50 +0200)]
KMSG: conform to the new format
- To use escape sequence at dlog, log format stored in the kernel buffer is modified
- Notice : to apply this patch, you MUST use kernel with applied patch "kmsg: allow binary characters"
Change-Id: Ic73e6da895404a7b5bcf520bf13737f10bcfc939
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Karol Lewandowski [Fri, 22 Jul 2016 12:56:02 +0000 (05:56 -0700)]
Merge "Apply Tizen Coding Rule" into tizen
Karol Lewandowski [Fri, 22 Jul 2016 12:55:36 +0000 (05:55 -0700)]
Merge "Pipe: safety against minor errors." into tizen
Karol Lewandowski [Fri, 22 Jul 2016 12:51:31 +0000 (05:51 -0700)]
Merge "Pipe: util with --dumpfile exits on invalid file" into tizen
Karol Lewandowski [Fri, 22 Jul 2016 12:48:04 +0000 (05:48 -0700)]
Merge "Pipe-backend: do not perform doomed writes" into tizen
Michal Bloch [Thu, 21 Jul 2016 17:19:58 +0000 (19:19 +0200)]
Apply Tizen Coding Rule
Change-Id: I68ab663b9a6756db15204f0c68b788c2fecab540
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 21 Jul 2016 16:29:38 +0000 (18:29 +0200)]
Pipe: safety against minor errors.
Change-Id: Ic273a498f9f292af2080c44a4ba481e53d9dac69
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 21 Jul 2016 16:05:05 +0000 (18:05 +0200)]
Pipe: util with --dumpfile exits on invalid file
Change-Id: I1aa5bb627413e837904b87b5f3a988d06a4a343d
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 21 Jul 2016 13:28:39 +0000 (15:28 +0200)]
Pipe-backend: do not perform doomed writes
If a write is doomed to fail (i.e. when there is no connection to pipe
and the the attempt to reestablish the connection did not succeed either),
do not perform the write.
Change-Id: Ia6525875f34d4efdbe4a596556f3f9675de60cd2
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Fri, 22 Jul 2016 12:28:13 +0000 (05:28 -0700)]
Merge "Pipe backend: bulk writing to file" into tizen
Karol Lewandowski [Fri, 22 Jul 2016 12:27:10 +0000 (05:27 -0700)]
Merge "Pipe: improve scheduling" into tizen
Yunjin Lee [Wed, 20 Jul 2016 11:21:22 +0000 (20:21 +0900)]
Set SmackProcessLabel to System
Change-Id: I5aa9926c8833b6b51b62322a4c88b1b1970b8996
Signed-off-by: Yunjin Lee <yunjin-.lee@samsung.com>
Kichan Kwon [Fri, 15 Jul 2016 06:26:46 +0000 (15:26 +0900)]
dlog_logger : dump apps buffer when the backend is kmsg
Change-Id: Ib7a83241e7a72b2bc527f52801a8bae0698d18f4
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kazimierz Krosman [Tue, 12 Jul 2016 11:46:31 +0000 (13:46 +0200)]
Pipe backend: bulk writing to file
This patch introduce bulk writes to file. Instead of calling write()
for each log, dlog_logger prepares memory blob with logs and then
makes write operation to file.
Change-Id: I4664e547571383b360ad9ad56756517be959eab5
Michal Bloch [Fri, 8 Jul 2016 14:20:47 +0000 (16:20 +0200)]
Pipe: improve scheduling
This patch improves scheduling by modifying -t parameter logic.
In this version dlog_logger dumps buffered logs to file after
[t] seconds of not receiving new logs. Logs can be also dumped
by [b] parameter.
Change-Id: Ib48fd437eceb1e06720f4296806c0688f306c620
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Kichan Kwon [Wed, 13 Jul 2016 07:53:10 +0000 (16:53 +0900)]
Apply Tizen coding rule
Change-Id: I1997e9d87fbb870e4b666f1f52756d585d6f5fc2
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Michal Bloch [Tue, 5 Jul 2016 15:06:53 +0000 (17:06 +0200)]
Pipe-backend: change dlogutil handling of raw files
* no longer handled through stdin. This is due to
the fact that crash-worker redirects core dumps
to util's input and touching them corrupts them
* now accepts a "--dumpfile" parameter, which can
parse a raw file and dump its contents.
Change-Id: I0e73a57194e7fc0137d678bee271ddcbdfd9473b
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 5 Jul 2016 15:04:52 +0000 (17:04 +0200)]
Pipe improvements:
* add safety against malicious programs who could
forge an invalid log or access a buffer they are
not eligible to access.
* fix logger not noticing when a connected util
gets killed through external means.
* fix an issue with file flags.
* fix util dump mode being lagged.
Change-Id: I5fda36d7cb74eef51a905e91ded7f60fac6d0fdd
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 4 Jul 2016 15:38:37 +0000 (17:38 +0200)]
Fix kmsg logger issue
Change-Id: Iac4dc9b7d9a34b7a08cb1dfc3aad72b1954329bb
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kunhoon Baik [Sat, 2 Jul 2016 05:17:58 +0000 (14:17 +0900)]
Remove Unused TC Code
TODO : iUTC should be created
Change-Id: Ied40c5f8e6bbf6d1656730b739d1242e52786377
Kichan Kwon [Wed, 29 Jun 2016 05:07:03 +0000 (14:07 +0900)]
Apply Tizen coding rule
Change-Id: I4ae4f6019a9afbc4658bafe19f2ecc7770d09721
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Michal Bloch [Tue, 14 Jun 2016 15:58:43 +0000 (17:58 +0200)]
Improvements to Pipe backend:
* each buffer now has its own socket, this way
they can have separate level of access.
* dlogutil now sorts logs received from daemon.
This is to guarantee time sequence.
* daemon output is now binary, which both
increases performance and gives the user more
control (for example, over output formatting).
* improve logger security. Clogged pipes cannot
freeze the daemon.
* fix some cases of logs being dropped.
* performance tests now have better coverage.
* dlogctrl now provides documentation for config values.
Change-Id: I2718281828459045235360287471352662497757
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Kichan Kwon [Fri, 17 Jun 2016 09:23:11 +0000 (18:23 +0900)]
dlogutil : add "-x" option when the backend is kmsg or logger.
- "-x" : don't print logs written before last printed log
Change-Id: I7f1e33c24aa555c64503b1f5bbc9382e668de353
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Sunmin Lee [Fri, 17 Jun 2016 02:28:26 +0000 (11:28 +0900)]
Fix potential defects of source code
Fix potential defects as below:
logger/logger.c: substitute 'sprintf' with 'snprintf'
shared/logconfig.c: close file pointer in all exit cases
Change-Id: I6cea5719a134e699de765705a4ead38192344d3c
Signed-off-by: Sunmin Lee <sunm.lee@samsung.com>
Kichan Kwon [Thu, 16 Jun 2016 08:40:46 +0000 (17:40 +0900)]
dlogutil : apply Tizen coding rule
Change-Id: Ic26f25baa1ad91244fb735750c3f2802452ff6e8
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Thu, 16 Jun 2016 08:00:25 +0000 (17:00 +0900)]
Add lcov comments for coverage measurement
Change-Id: I870fece8561aaa1db0b02cbf830fbe3987849d98
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Fri, 10 Jun 2016 03:15:58 +0000 (12:15 +0900)]
dlogutil : add "-d" option when the backend is journal
- "-d" : print log and exit (non-blocking)
- "-v" is ignored because of crash-worker issue
Change-Id: I81ae7854b1f9bbbc5e107a198f880b2ef577103f
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Fri, 10 Jun 2016 02:47:37 +0000 (11:47 +0900)]
Modify license notice file
Change-Id: I7f8878eaba45e9c950b826f7afc4a0162f3f24b9
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Michal Bloch [Mon, 6 Jun 2016 15:01:28 +0000 (17:01 +0200)]
Account for a minor KMSG/AndroidLogger difference.
Change-Id: I41003da02d59305cde44a1ad41c912c50d8a2eec
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 2 Jun 2016 14:48:19 +0000 (16:48 +0200)]
dlog_logger: move to libdlog package for pipe.
In the pipe backend, dlog_logger is the crucial
component which is needed for the library to be
able to log. Thus it needs to live in the package
alongside the library.
Change-Id: I3141592653589793238462643383279502884197
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Mon, 30 May 2016 15:15:00 +0000 (17:15 +0200)]
configure: Allow exactly one backend to be selected
Change-Id: Iae4e84b2a7b66727725f3ec11c7db07cb98f5371
Karol Lewandowski [Mon, 30 May 2016 15:14:24 +0000 (17:14 +0200)]
configure: automatically define backend-specific constants
This commit moves previously explicitly specified DLOG_BACKEND_*
defines to be defined automatically by configure.
Change-Id: I1ed16036bd2214be75db6fdf3c5d12951e7d12e4
Michal Bloch [Mon, 30 May 2016 15:13:27 +0000 (17:13 +0200)]
Add tests.
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Change-Id: Ideadbeef6003f7cfc29cf00d6f1ac007a76aa7b3
Kazimierz Krosman [Mon, 30 May 2016 15:05:54 +0000 (17:05 +0200)]
Add a pipe-based userspace logging backend.
Change-Id: I1dca48f71ecf637c71f651f511ceca8d99ca16d1
Signed-off-by: Kazimierz Krosman <k.krosman@samsung.com>
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 30 May 2016 15:02:12 +0000 (17:02 +0200)]
Refactor configuration files.
There is now a single config file containing everything,
instead of spreading the values over multiple files
and hardcoded definitions.
Change-Id: I0173cf5c41688ccfdfaeeff529394908470a7003
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Signed-off-by: Kazimierz Krosman <k.krosman@samsung.com>
Michal Bloch [Mon, 30 May 2016 14:47:28 +0000 (16:47 +0200)]
Refactor: split logutil and libdlog backend handling into separate files.
Change-Id: I511c42eea8e0f624402ff0d456e9ee41317bb3cc
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Signed-off-by: Kazimierz Krosman <k.krosman@samsung.com>
Kichan Kwon [Fri, 27 May 2016 07:23:45 +0000 (16:23 +0900)]
shared : set consistent dlogutil format
- TIME PRIORITY TAG PID TID MESSAGE
- If both pid and tid are printed, print 'P' and 'T' to identify these
Change-Id: I59e694feedc8af386440ac00268174fbde994993
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Fri, 27 May 2016 07:07:52 +0000 (16:07 +0900)]
shared : change dlogutil format "dump" to "kerneltime"
- "dump" is exactly overlapped with "threadtime"
- "kerneltime" prints tv_sec
Change-Id: Id1491c98c7f0f88400911e41a08e05f37b254e4a
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 25 May 2016 06:56:49 +0000 (15:56 +0900)]
libdlog : extend maximum log size when the backend is journal
- logger and kmsg are already extended
Change-Id: Ia43ea428fbff3d35e478dc39bca1639182b4349a
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 25 May 2016 06:22:03 +0000 (15:22 +0900)]
libdlog : fix error when the backend is journal
Change-Id: I162da9e3d691da37ae73625b123d1e10c1297ce9
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kazimierz Krosman [Tue, 24 May 2016 16:19:09 +0000 (18:19 +0200)]
dlog_logger: prevent multiple statting.
Previously, dlog_logger would stat /etc/localtime each time
it wanted to get the timestamp. Now it will only do so once,
increasing performance.
Change-Id: I001b106f35ce1c87c00c514e28301329d784ed7c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Signed-off-by: Kazimierz Krosman <k.krosman@samsung.com>
Kazimierz Krosman [Tue, 24 May 2016 16:18:33 +0000 (18:18 +0200)]
Build process: reduce journal backend redundancy.
Only link journal libraries when actually using that backend.
Do not use the rules file when using that backend.
change-Id: Ibacabaca31657f39e82fc97379d42f66ae904c7c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Signed-off-by: Kazimierz Krosman <k.krosman@samsung.com>
Kichan Kwon [Tue, 24 May 2016 12:03:59 +0000 (05:03 -0700)]
Merge " Define -1 in the log_id_t" into tizen
Kichan Kwon [Tue, 24 May 2016 11:28:47 +0000 (20:28 +0900)]
Define -1 in the log_id_t
- log_id_t is enum type which -1 isn't defined
- So, if (id < 0) returns false though id is -1
Change-Id: I28bad625b00269e0f3256517b449c7a50efe8a38
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 26 Apr 2016 04:16:12 +0000 (13:16 +0900)]
Apply Tizen coding rule
Change-Id: I5fa659ddb9902e72321f2841cb753c7e171cd7b5
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
projects / platform / core / system / dlog.git / log