platform/core/appfw/app-installers.git
6 years agoFix crash during mount update recovery 87/167987/2
Sangyoon Jang [Tue, 23 Jan 2018 08:21:33 +0000 (17:21 +0900)]
Fix crash during mount update recovery

Change-Id: I51a51404c022f64c965dd98b97c67ce918044fe0
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoRefine sending pkgmgr signal for recovery 32/167932/4
Sangyoon Jang [Mon, 22 Jan 2018 06:30:48 +0000 (15:30 +0900)]
Refine sending pkgmgr signal for recovery

Set request type differently to each recovery mode.
Recovery for install will emit uninstall signal, and recovery for
update(RecoveryUpdate) will emit upgrade signal.

Change-Id: I619e041e9541ef00d84bdbe1150aa4265e60e67a
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoRevert "Fix to send different signal based on recovery info" 38/167938/1
Sangyoon Jang [Tue, 23 Jan 2018 05:18:25 +0000 (14:18 +0900)]
Revert "Fix to send different signal based on recovery info"

This reverts commit c9c50607c02b66ae82dd120374f68e8a77813328.

Change-Id: I92028da9cc1888087288c75031fa1ef1602d6c29

6 years agoFix StepRecoverGlobalAppSymlinks 13/167913/1
Sangyoon Jang [Tue, 23 Jan 2018 04:00:05 +0000 (13:00 +0900)]
Fix StepRecoverGlobalAppSymlinks

Use common methods instead of using existing step.
Existing steps should not be affected by recovery mode as possible.

Change-Id: Idbc438f82be89d3f490b482aac0d8b97eea70b51
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoFix StepParsePreload 12/167912/1
Sangyoon Jang [Tue, 23 Jan 2018 04:06:17 +0000 (13:06 +0900)]
Fix StepParsePreload

Remove a unnecessary condition.

Change-Id: Ia7043e5d1ae0db82acd477c12e9145b9ef4624a9
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoRelease version 1.25.0 83/167683/1 accepted/tizen/unified/20180123.061147 submit/tizen/20180119.081808
Junghyun Yeon [Fri, 19 Jan 2018 07:49:10 +0000 (16:49 +0900)]
Release version 1.25.0

Changes:
 - Refactoring ValidatePackage() functions parameter
 - Refactoring Run()
 - Add initdb options and constraints
 - Set nodisplay attribute of widget application as manifest value
 - Send error signal properly when installation failed
 - Add recovery mode for ReadonlyUpdateInstall
 - Fix StepRecoverSignature
 - Fix StepRecoverApplication
 - Fix removing globalapp symlinks
 - Add StepRecoverPrivilegeCompatibility
 - Add values to backend inherits capabilities.
 - Fix to send different signal based on recovery info

Change-Id: If074291216e4363bf83b1bbb7f8130b10e86ab5a
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoFix to send different signal based on recovery info 79/167679/1
Junghyun Yeon [Fri, 19 Jan 2018 04:48:00 +0000 (13:48 +0900)]
Fix to send different signal based on recovery info

- Previous implementation send only "install" signal as value
  when Recovery being performed.
- Installer will send proper signal based on recovery information
  with this changes.

Change-Id: Ia88d72a96af00e562384c38b177ac92b073ac842
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoAdd values to backend inherits capabilities. 99/167599/1
Junghyun Yeon [Thu, 18 Jan 2018 12:14:52 +0000 (21:14 +0900)]
Add values to backend inherits capabilities.

Change-Id: Ifd8a2d7fa216d845eb60450185bc57e5cd8ada5b
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoAdd StepRecoverPrivilegeCompatibility 11/167411/1
Sangyoon Jang [Wed, 17 Jan 2018 11:48:39 +0000 (20:48 +0900)]
Add StepRecoverPrivilegeCompatibility

Change-Id: Iaa05857f2e92867202e3ffc371316edf655c0a4b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoFix removing globalapp symlinks 81/167381/1
Sangyoon Jang [Wed, 17 Jan 2018 08:52:49 +0000 (17:52 +0900)]
Fix removing globalapp symlinks

Do not return error when original package directory doesn't exist.
In some case(such as recovery mode), original package directory may not
exist.

Change-Id: I48f7c79b684871c204418592e8461f2f1aa4d979
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoFix StepRecoverApplication 23/167323/2
Sangyoon Jang [Wed, 17 Jan 2018 05:38:59 +0000 (14:38 +0900)]
Fix StepRecoverApplication

When recover updated preloaded package, some attributes should be set
properly.

Change-Id: Id189bb3a238036cae812d8ba9cc933cbb8a021af
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoFix StepRecoverSignature 79/167179/1
Sangyoon Jang [Tue, 16 Jan 2018 05:28:15 +0000 (14:28 +0900)]
Fix StepRecoverSignature

The privilege level should be initialized before calling
ValidateSignatures() to set privilege level properly.

Change-Id: Ica5fbf136a001f965d045f0e17edbaa1cb45d6a7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoAdd recovery mode for ReadonlyUpdateInstall 44/158844/6
Sangyoon Jang [Fri, 3 Nov 2017 10:11:10 +0000 (19:11 +0900)]
Add recovery mode for ReadonlyUpdateInstall

Change-Id: I0d672be7831354a5e76d63e67b9220cfd40763ce
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoSend error signal properly when installation failed 19/166019/2
Sangyoon Jang [Fri, 5 Jan 2018 07:51:10 +0000 (16:51 +0900)]
Send error signal properly when installation failed

'status' which is result of each step should not be overwritten by undo
and clean operation.

Change-Id: Ia39713c5f480645536f4e6dfd187bbf05b0905e7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoSet nodisplay attribute of widget application as manifest value 25/163125/5
Sangyoon Jang [Thu, 7 Dec 2017 09:06:05 +0000 (18:06 +0900)]
Set nodisplay attribute of widget application as manifest value

Change-Id: Ia6cd396e78b73da510a3e1eab80b96f55b59909d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoAdd initdb options and constraints 21/164421/9
Junghyun Yeon [Tue, 19 Dec 2017 05:12:42 +0000 (14:12 +0900)]
Add initdb options and constraints

- "--rw" will only handle RW packages.
- "--keep-db" will preserve existing databases.
- Add constraints for some conflicting options.

Change-Id: If3db2636bc5cca49d3e1396d345a79fe2fefdf17
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRefactoring Run() 45/133845/10
Piotr Ganicz [Tue, 21 Mar 2017 13:00:44 +0000 (14:00 +0100)]
Refactoring Run()

Function Run is too long and it is know code smell.
This patch reduces the size of the function introducting
two new functions and removes code duplication.

Change-Id: Ica13ffef0b807e6a066f288e2ed2b9e996289c10

6 years agoRefactoring ValidatePackage() functions parameter 39/159539/5
Damian Pietruchowski [Thu, 9 Nov 2017 12:38:59 +0000 (13:38 +0100)]
Refactoring ValidatePackage() functions parameter

Tpk package has different binary name than appid.
So we need to pass appid and exec name to ValidatePackage()
functions.

Submit with:
- https://review.tizen.org/gerrit/#/c/159540/
- https://review.tizen.org/gerrit/#/c/159542/

Change-Id: I265482ac53bcfaabb1668865ced60acfc7a5b661
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoRelease version 1.24.2 67/164967/1 accepted/tizen/unified/20171228.065036 submit/tizen/20171222.073841
Junghyun Yeon [Fri, 22 Dec 2017 06:11:09 +0000 (15:11 +0900)]
Release version 1.24.2

Changes:
 - Fix minor errors in StepCreateRecoveryFile
 - Refactor and reduce unnecessary code
 - Fix step name of StepCreateRecoveryFile
 - Fix sending signal of ReadonlyUpdateInstall mode

Change-Id: I47c557364a9b515ad43393c2d12cabfd1a8d496b
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoFix sending signal of ReadonlyUpdateInstall mode 40/164840/1
Sangyoon Jang [Thu, 21 Dec 2017 07:10:33 +0000 (16:10 +0900)]
Fix sending signal of ReadonlyUpdateInstall mode

The pkgid should be set as real pkgid, not the name of package file.

Change-Id: Ifb202588e2711cb860eddce7da22485864e55f6e
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoFix step name of StepCreateRecoveryFile 38/164838/1
Sangyoon Jang [Thu, 21 Dec 2017 07:09:51 +0000 (16:09 +0900)]
Fix step name of StepCreateRecoveryFile

Change-Id: Ieb48f72b0b358783d4b287f908b075f1da00989e
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoRefactor and reduce unnecessary code 32/134632/33
Damian Pietruchowski [Mon, 19 Jun 2017 14:45:10 +0000 (16:45 +0200)]
Refactor and reduce unnecessary code

Change-Id: I09bedb005965173688050ce7d46471928ce2084c
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoFix minor errors in StepCreateRecoveryFile 02/163302/1
Junghyun Yeon [Fri, 8 Dec 2017 09:44:55 +0000 (18:44 +0900)]
Fix minor errors in StepCreateRecoveryFile

Change-Id: I4b4b4415714e16a6a2e8b27da66b410fe8f220b3
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRelease version 1.24.1 81/163281/1 accepted/tizen/unified/20171211.061325 submit/tizen/20171208.083756 submit/tizen/20171211.020230
Sangyoon Jang [Fri, 8 Dec 2017 08:23:27 +0000 (17:23 +0900)]
Release version 1.24.1

Changes:
 - Use PkgQueryInterface in StepCheckRemovable
 - Move create recovery file to new step
 - Integrate recovery file creation and first write procedure
 - Remove flag from plugins
 - Fix plugin smoketest failure

Change-Id: I2265b632669addc732e54160eca8baf1006034a4
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoFix plugin smoketest failure 13/162713/2
Sangyoon Jang [Tue, 5 Dec 2017 05:12:48 +0000 (14:12 +0900)]
Fix plugin smoketest failure

Now category plugin parser runs when name matched exactly.

Change-Id: I65a9bf003cf5972df17da37a6b0085815f9a66b2
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoRemove flag from plugins 66/162166/6
Junghyun Yeon [Wed, 29 Nov 2017 09:56:32 +0000 (18:56 +0900)]
Remove flag from plugins

- Flag in plugin list used to identify uniqueness of each plugins
  but name could be identifier of uniqueness.

Change-Id: I77e5701f99622fadb6000f05d1375fd8810a4674
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoIntegrate recovery file creation and first write procedure 04/162304/1
Junghyun Yeon [Thu, 30 Nov 2017 07:27:39 +0000 (16:27 +0900)]
Integrate recovery file creation and first write procedure

- Recovery file creation process is separated with
  file creation and type write processes.
- Integrate those two processes into one.

Change-Id: I9c5e0b192c8f35d7a612e58417bed1d9468bfd87
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoMove create recovery file to new step 06/154906/10
Damian Pietruchowski [Wed, 11 Oct 2017 11:11:16 +0000 (13:11 +0200)]
Move create recovery file to new step

Submit together:
- https://review.tizen.org/gerrit/#/c/154907/
- https://review.tizen.org/gerrit/#/c/154908/

Change-Id: Ia0cc4e85c200cf35ece43dae7e802a0c04d50507
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoUse PkgQueryInterface in StepCheckRemovable 12/151312/6
Damian Pietruchowski [Wed, 20 Sep 2017 11:13:33 +0000 (13:13 +0200)]
Use PkgQueryInterface in StepCheckRemovable

Change-Id: I07b37dcb2509e833b4b43a448b19c91ee1a074f8
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoRelease version 1.24.0 80/161780/1 accepted/tizen/unified/20171128.150345 submit/tizen/20171127.102301
Junghyun Yeon [Mon, 27 Nov 2017 10:09:40 +0000 (19:09 +0900)]
Release version 1.24.0

Changes:
 - Add error getter to PkgQueryInterface
 - Change code to store api_version of application
 - Refactor functions creating/opening a recovery file
 - Replace pkg_path with GetPkgPath() method in InstallerContext
 - AppInstaller logic export
 - Security registration refactoring
 - Remove checking existance of shared/data directory
 - Fix coding style - security_registration.cc

Change-Id: I610a25fa715fca4050f2f7c085ac8b891a44cbb5
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoFix coding style - security_registration.cc 02/161502/1
Damian Pietruchowski [Thu, 23 Nov 2017 16:13:03 +0000 (17:13 +0100)]
Fix coding style - security_registration.cc

Change-Id: I20734177ebad610e3f5ce823ba2d082bf794fbae
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoRemove checking existance of shared/data directory 09/160309/2
Junghyun Yeon [Wed, 15 Nov 2017 09:07:11 +0000 (18:07 +0900)]
Remove checking existance of shared/data directory

- Security context should be updated even if shared/data is existed.

Change-Id: I3e18ff55fa72523063b7283fb611c8fe7ce0665f
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoSecurity registration refactoring 06/140006/15
Damian Pietruchowski [Fri, 21 Jul 2017 09:01:38 +0000 (11:01 +0200)]
Security registration refactoring

SecurityContextRequest class to resources management.

Change-Id: I40b4f9120f3b54e6ca47434b9dd009914af33fbd
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoAppInstaller logic export 98/93998/15
Piotr Ganicz [Mon, 24 Oct 2016 14:04:29 +0000 (16:04 +0200)]
AppInstaller logic export

This commit gather the logic of choosing proper steps sequence
to app-installer repository. All backends have to prepare their
own sequences for each pkgmgr request. The default implementation
of such methods is provided and there is no need for overriding
each function in backends.

    Submit together:
     - https://review.tizen.org/gerrit/#/c/93999/
     - https://review.tizen.org/gerrit/#/c/94000/

Change-Id: Ice10a836c28786f92f6fdd8bc0d23a6c7febce19
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoReplace pkg_path with GetPkgPath() method in InstallerContext 96/154196/11
Damian Pietruchowski [Mon, 9 Oct 2017 09:38:01 +0000 (11:38 +0200)]
Replace pkg_path with GetPkgPath() method in InstallerContext

pkg_path is always equal to root_application_path + pkgid.
Storing this information in separate variable is problematic,
because it requires to remember to update pkg_path after
root_application_path or pkgid is changed.

Submit with:
- https://review.tizen.org/gerrit/#/c/160353/
- https://review.tizen.org/gerrit/#/c/154904/

Change-Id: I8cc45cd003a642225be88669360b540186f8c678
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoRefactor functions creating/opening a recovery file 79/159379/5
Sangyoon Jang [Wed, 8 Nov 2017 10:55:44 +0000 (19:55 +0900)]
Refactor functions creating/opening a recovery file

Change-Id: Id7d5668aa99c264958ad46ddfd70384a0be0602a
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoChange code to store api_version of application 61/159061/6
Junghyun Yeon [Tue, 7 Nov 2017 00:40:02 +0000 (09:40 +0900)]
Change code to store api_version of application

- Tpk and wgt pkg could have different api version in hybrid pkg.
- Previous code passes wgt's hybrid pkg so it could be issue
  if api version of tpk is different with wgt's.
- Change logic to store api version at application structure
  in parsing time and deliver it to security manager.

Change-Id: Ibe78bad3b4b87b20714097252a57c3aedbc8ee16
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoAdd error getter to PkgQueryInterface 11/151311/5
Damian Pietruchowski [Wed, 20 Sep 2017 11:12:44 +0000 (13:12 +0200)]
Add error getter to PkgQueryInterface

Required by: https://review.tizen.org/gerrit/#/c/151312/

Change-Id: I7bccdbaff658ac59f3c332352aab3b0bf6cc8357
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoRelease version 1.23.1 14/159414/3 accepted/tizen/unified/20171109.124921 submit/tizen/20171109.041728
Seungha Son [Wed, 8 Nov 2017 23:52:59 +0000 (08:52 +0900)]
Release version 1.23.1

Changes:
 - Fix wrong IsPackageInstalled() logic
 - Clean up files at extended storage when install failed

Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: I700af1b35816fa36cb33638e62b4adbb51a89580

6 years agoClean up files at extended storage when install failed 57/157757/4
Sangyoon Jang [Thu, 26 Oct 2017 03:36:36 +0000 (12:36 +0900)]
Clean up files at extended storage when install failed

Change-Id: I458c83f1683ffc07e5a8a7cf8e204a7be95c1806
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoFix wrong IsPackageInstalled() logic 89/159389/1
Seungha Son [Wed, 8 Nov 2017 12:24:21 +0000 (21:24 +0900)]
Fix wrong IsPackageInstalled() logic

Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: I63d0f8a956bda8b9974dcfa0a2231a69fa05654c

6 years agoRelease version 1.23.0 77/159077/3 submit/tizen/20171107.031828 submit/tizen/20171108.023404
Junghyun Yeon [Tue, 7 Nov 2017 01:53:13 +0000 (10:53 +0900)]
Release version 1.23.0

Changes:
 - Add new lib with common smoke utils for tests
 - Check author signature using public key
 - Fix coding rule
 - Add sdk directory backup
 - Fix coding rule and supress build warning
 - Change security code routine for performance
 - Return error code when the recovery file is unknown type
 - Fix build error
 - Disable copy PkgQueryInterface
 - Fix description
 - Fix wrong log
 - Separate IsPackageInstalled()

Change-Id: Ia1a5ab813f1d5683ad5ec8398dfd7236bbf4a7fb
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoSeparate IsPackageInstalled() 43/157443/8
Seungha Son [Tue, 24 Oct 2017 11:36:20 +0000 (20:36 +0900)]
Separate IsPackageInstalled()

Separate the method of checking whether it is installed only and how to
check whether the installed or not as ReqeustMode.

related patch : https://review.tizen.org/gerrit/#/c/158632/

Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: I62f7e7c6c30cda101cc0856fc057431552837dfb

6 years agoFix wrong log 33/158933/1
Seungha Son [Mon, 6 Nov 2017 04:40:08 +0000 (13:40 +0900)]
Fix wrong log

Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: I02074f0b94158d171926bf8e3d160d27d05b811d

6 years agoFix description 90/158790/2
Seungha Son [Fri, 3 Nov 2017 05:25:57 +0000 (14:25 +0900)]
Fix description

Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: I204507e8d78a8fc3fbe7f3986db58aa8eecd45b8

6 years agoDisable copy PkgQueryInterface 91/150191/6
Damian Pietruchowski [Thu, 14 Sep 2017 15:02:37 +0000 (17:02 +0200)]
Disable copy PkgQueryInterface

Only one object should own specific pkgmgrinfo_pkginfo_h handle.
So copy constructor and copy assignment operator should be deleted.

Change-Id: Ib40189336c837e48292f7990e3f76655e3237321
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoFix build error 85/158585/2
Junghyun Yeon [Thu, 2 Nov 2017 02:46:36 +0000 (11:46 +0900)]
Fix build error

Add static casting to remove build error

Change-Id: I74bf8378f611f2c79b94af260b481146f1916e77
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoReturn error code when the recovery file is unknown type 46/158446/4
Sangyoon Jang [Wed, 1 Nov 2017 04:58:43 +0000 (13:58 +0900)]
Return error code when the recovery file is unknown type

Change-Id: If712388b238ee15c8ce562885c84ad23829d2d75
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoChange security code routine for performance 52/154752/7
Junghyun Yeon [Wed, 11 Oct 2017 08:41:42 +0000 (17:41 +0900)]
Change security code routine for performance

- Security-manager APIs for Security registration/unregistration logic
  has changed to send all appid at once for performance.
- So, change app-installer logic for it.

Change-Id: Ic8a9d2b98426652fec657497391458ba760d1729
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoFix coding rule and supress build warning 99/157099/5
Junghyun Yeon [Mon, 23 Oct 2017 10:07:35 +0000 (19:07 +0900)]
Fix coding rule and supress build warning

Change-Id: I8ca81a25867bea6d5a7955bf3e470412f349bd8b
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoAdd sdk directory backup 34/158034/3
kniedzielew [Fri, 27 Oct 2017 10:34:37 +0000 (12:34 +0200)]
Add sdk directory backup

This solution is needed in order to provide SetUp
and TearDown for RDSMode and avoid modification of
"/home/owner/share/tmp/sdk_tools" during testing.

Change-Id: I871ab59c55a9eafaadf382d3e3f2f88eef3f5840
Signed-off-by: kniedzielew <k.niedzielew@samsung.com>
6 years agoFix coding rule 37/157937/1
Seungha Son [Fri, 27 Oct 2017 02:28:07 +0000 (11:28 +0900)]
Fix coding rule

Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: Ib92564d998cd7ffc08e7f8c2d538775ea6441c4e

6 years agoCheck author signature using public key 38/157538/6
Sangyoon Jang [Wed, 25 Oct 2017 03:44:45 +0000 (12:44 +0900)]
Check author signature using public key

The certificate string value(in base64 format) will be changed when the
certificate is renewed. To verify whether two author of certificate
is same, using public key of certificate is correct instead of
entire certificate string value.

Change-Id: I99bcfce48a77b4dbf65df9d3274945db9ef27635
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoAdd new lib with common smoke utils for tests 36/149136/7
Damian Pietruchowski [Mon, 21 Aug 2017 09:27:35 +0000 (11:27 +0200)]
Add new lib with common smoke utils for tests

Wgt-backend and tpk-backend have common util functions for smoke tests.
They should be exported to lib in app-installers.

Submit together:
- https://review.tizen.org/gerrit/#/c/149137/
- https://review.tizen.org/gerrit/#/c/149601/

Change-Id: Ifef1e9f38790133c7337650c8641e0cd0bab57f1
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoRelease version 1.22.8 91/156891/1 accepted/tizen/4.0/unified/20171021.044940 accepted/tizen/unified/20171023.152039 submit/tizen/20171020.110656 submit/tizen_4.0/20171020.110530 tizen_4.0.m2_release
Sangyoon Jang [Fri, 20 Oct 2017 11:03:23 +0000 (20:03 +0900)]
Release version 1.22.8

Changes:
 - Change directory path for unpacking package

Change-Id: Ibf3d312e45a267a16ff6dd7dda15c1855b8c21cc
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoChange directory path for unpacking package 86/156886/2
Sangyoon Jang [Fri, 20 Oct 2017 10:47:54 +0000 (19:47 +0900)]
Change directory path for unpacking package

$TZ_SYS_SHARE(/opt/share/) may not have enough space.
Use /opt/usr/share/package-unpacked instead.

Change-Id: If08299d5263b35a415a92ade0824e9ca5a85094b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoRelease version 1.22.7 52/156852/1 accepted/tizen/4.0/unified/20171020.092832 submit/tizen/20171020.073206 submit/tizen_4.0/20171020.073230
Sangyoon Jang [Fri, 20 Oct 2017 07:30:55 +0000 (16:30 +0900)]
Release version 1.22.7

Changes:
 - Use TZ_SYS_EXTENDEDSD_APP TZ_USER_EXTENDEDSD_APP for extended app path
 - Install at internal storage when extended storage is not available
 - Set install location to internal when external storage is not available
 - Fix issue while converting public key

Change-Id: I32596eed405bcd743505b9fbaf13d4e30657796d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoFix issue while converting public key 70/156770/5
Junghyun Yeon [Fri, 20 Oct 2017 01:36:49 +0000 (10:36 +0900)]
Fix issue while converting public key

- PublicKey is retrieved as unsigned character and some of its value
  is missed during converting into const char due to some hexdata such as 0x00.
- It would cause security issue such as one application could access
  shared/trusted of other non-trusted application.
- Fix codes to convert unsigned character value properly.

Change-Id: Iaca2f7c0fa60677d7aa5852725bb5b120ed54a09
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoSet install location to internal when external storage is not available 94/156694/1
Sangyoon Jang [Thu, 19 Oct 2017 12:09:14 +0000 (21:09 +0900)]
Set install location to internal when external storage is not available

Change-Id: If10270f36776d1151c99e0ff87bff217f776175f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoInstall at internal storage when extended storage is not available 28/156628/2
Sangyoon Jang [Thu, 19 Oct 2017 07:28:07 +0000 (16:28 +0900)]
Install at internal storage when extended storage is not available

Change-Id: I37175df644fef97b859107002938d2fd7ba3342d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoUse TZ_SYS_EXTENDEDSD_APP TZ_USER_EXTENDEDSD_APP for extended app path 58/156558/1
Sangyoon Jang [Thu, 19 Oct 2017 02:14:09 +0000 (11:14 +0900)]
Use TZ_SYS_EXTENDEDSD_APP TZ_USER_EXTENDEDSD_APP for extended app path

Change-Id: I1fb562650f2f887719bf32d6cea0ed7e68902724
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoRelease version 1.22.6 04/156104/1 accepted/tizen/4.0/unified/20171018.060922 accepted/tizen/unified/20171018.062513 submit/tizen/20171017.074628 submit/tizen_4.0/20171017.080654
Junghyun Yeon [Tue, 17 Oct 2017 06:54:28 +0000 (15:54 +0900)]
Release version 1.22.6

Changes:
 - Fix test ManifestDirectInstallMode failure
 - Fix reinstall
 - Use TZ_SYS_EXTENDEDSD for extended storage path
 - Change path for unpacking package
 - Change bahavior of trust anchor

Change-Id: I6e7a11abe67489d70a0056e906ad728c70a86a81
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoChange bahavior of trust anchor 36/149836/14
Junghyun Yeon [Wed, 13 Sep 2017 07:55:40 +0000 (16:55 +0900)]
Change bahavior of trust anchor

- Trust-anchor certificate file directory has fixed.
- Make symbolic link when given pkg type is wgt or hybrid.
- When updating wgt/hybrid pkg, previous symlink will be removed.
- Register and update trust anchor have integrated.

Related changes:
[pkgmgr-info] : https://review.tizen.org/gerrit/149784
[wgt-backend] : https://review.tizen.org/gerrit/149978
[tpk-manifest-handlers] : https://review.tizen.org/gerrit/150060
[wgt-manifest-handlers] : https://review.tizen.org/gerrit/150136

Change-Id: Ibdfc760bcb15da324e7237b8b0a5a9103effc129
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoChange path for unpacking package 15/155715/2
Sangyoon Jang [Mon, 16 Oct 2017 03:17:25 +0000 (12:17 +0900)]
Change path for unpacking package

Current path for unpacking has "User::Home" label because of transmute
option. During installation time, other(application) can be access
this unpacked dir because the smack label is readable.

Change-Id: I291c429c8d7172e3caddb43273a51f4b1059548e
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoUse TZ_SYS_EXTENDEDSD for extended storage path 41/155641/2
Sangyoon Jang [Mon, 16 Oct 2017 01:57:32 +0000 (10:57 +0900)]
Use TZ_SYS_EXTENDEDSD for extended storage path

Change-Id: Iad1ebaea52e9f11ca3cce79af22048b9efffa58d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoFix reinstall 90/155390/3
Junghyun Yeon [Fri, 13 Oct 2017 05:33:32 +0000 (14:33 +0900)]
Fix reinstall

- SDK deploys rds files into different location due to permission issue
  so change rds path realted with it.

Change-Id: I7dcab005cfa710630bb4f416fa792da330d5e8fa
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoFix test ManifestDirectInstallMode failure 34/146434/11
kniedzielew [Mon, 28 Aug 2017 14:00:19 +0000 (16:00 +0200)]
Fix test ManifestDirectInstallMode failure

Failure message returned by test ManifestDirectInstallMode
in wgt-backend smoke_test was:
"unknown file: Failure
C++ exception with description "boost::filesystem::status:...
... Permission denied: "smokewgt40"" thrown in the test body."

Function GetPkgIdFromPath throws exception
when arg is not a file path but package ID.
To avoid exception throw we check file existence
prior the excecution of GetPkgIdFromPath.

Now test passes with no failure.

Change-Id: I95f276e148071c47dac9fd131f4d37430548ba12
Signed-off-by: kniedzielew <k.niedzielew@samsung.com>
6 years agoRelease version 1.22.5 50/154950/1 accepted/tizen/4.0/unified/20171012.074543 accepted/tizen/unified/20171012.075127 submit/tizen/20171011.123741 submit/tizen_4.0/20171011.124331 tizen_4.0.IoT.p1_release
Junghyun Yeon [Wed, 11 Oct 2017 12:30:34 +0000 (21:30 +0900)]
Release version 1.22.5

Changes:
 - Fix side-effect on StepCheckForceClean

Change-Id: Ie151852d07fea3ecab6b8ed76da94bf4e72c650d
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoFix side-effect on StepCheckForceClean 43/154843/1
Junghyun Yeon [Wed, 11 Oct 2017 09:47:54 +0000 (18:47 +0900)]
Fix side-effect on StepCheckForceClean

- IsPackageInstalled is not working properly on StepCheckForceClean.
  So, deliver parameter when calling to fix it.

Change-Id: I6c646cdb8e5bcbf769d9f01001ba3610bdcaeef8
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRelease version 1.22.4 66/153166/1 accepted/tizen/4.0/unified/20170929.080006 accepted/tizen/unified/20170929.081459 submit/tizen/20170928.055049 submit/tizen_4.0/20170928.055126 submit/tizen_4.0/20170928.143447
Seungha Son [Thu, 28 Sep 2017 04:46:31 +0000 (13:46 +0900)]
Release version 1.22.4

Changes:
 - Add step for privacy privilege

Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: Ia4f426cdf84876b75041f6ce87d300cfee789227

6 years agoAdd step for privacy privilege 03/146903/19
Seungha Son [Thu, 31 Aug 2017 05:51:09 +0000 (14:51 +0900)]
Add step for privacy privilege

Related changes:
 tpk-backend : https://review.tizen.org/gerrit/#/c/147031/
 wgt-backend : https://review.tizen.org/gerrit/#/c/147038/

Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: I22094e3a2956987f775e79ffa60c254eaaf0e6ee

6 years agoRelease version 1.22.3 38/152438/1 accepted/tizen/4.0/unified/20170927.181735 accepted/tizen/unified/20170927.063515 submit/tizen/20170926.073829 submit/tizen_4.0/20170926.120510
Junghyun Yeon [Tue, 26 Sep 2017 06:53:10 +0000 (15:53 +0900)]
Release version 1.22.3

Changes:
 - Fix memory leak

Change-Id: I0130869cdd63d7917d0e9236637aaf944fe58f92
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoFix memory leak 66/151666/1
Junghyun Yeon [Thu, 21 Sep 2017 11:24:03 +0000 (20:24 +0900)]
Fix memory leak

- Newly allocated manifest variable is not assigned at installer context
  at that time and it will be leaked if any of function calls in
  FillManifestX has failed.

Change-Id: I33c4525d37a2f9a3a19074288246ce6e06af749a
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRelease version 1.22.2 60/151660/1 accepted/tizen/4.0/unified/20170922.064731 accepted/tizen/unified/20170922.065608 submit/tizen/20170921.110034 submit/tizen_4.0/20170921.110057
Sangyoon Jang [Thu, 21 Sep 2017 10:53:10 +0000 (19:53 +0900)]
Release version 1.22.2

Changes:
 - Fix static analysis issue
 - Do not retry gum API when offline mode

Change-Id: Ide18be170da1e37525653f8d9eb5adb0ef5e845b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoDo not retry gum API when offline mode 45/151645/2
Sangyoon Jang [Thu, 21 Sep 2017 10:20:21 +0000 (19:20 +0900)]
Do not retry gum API when offline mode

The retry logic is useful when dbus method call failed by timing issue,
but when offline mode, gum API doesn't use dbus.

Change-Id: Iaf2dda0f8b94740bdc034d88ff445a8c4ecc1a99
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoFix static analysis issue 22/149422/3
Junghyun Yeon [Tue, 12 Sep 2017 08:11:11 +0000 (17:11 +0900)]
Fix static analysis issue

- Check returned variable whether value is null or not.

Change-Id: Ibdbce0375e5cde22e221990d49d42ddb634eb41d
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRelease version 1.22.1 75/148575/1 accepted/tizen/4.0/unified/20170913.153046 accepted/tizen/unified/20170911.155839 submit/tizen/20170908.075925 submit/tizen_4.0/20170912.012133
Junghyun Yeon [Fri, 8 Sep 2017 06:50:59 +0000 (15:50 +0900)]
Release version 1.22.1

Changes:
 - Add method to get privilege level from file
 - Set installed storage and external image path when ManifestDirectInstall
 - Adjust coding rule

Change-Id: Ia24ad1ef9d374c04759c9ccbf7c0a94a034eca41
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoAdjust coding rule 50/148150/2
Seungha Son [Thu, 7 Sep 2017 02:43:35 +0000 (11:43 +0900)]
Adjust coding rule

Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: I15c79936ecdb097fc4e0b53ef52aacde63e17ee7

6 years agoSet installed storage and external image path when ManifestDirectInstall 06/147206/5
Sangyoon Jang [Fri, 1 Sep 2017 10:40:23 +0000 (19:40 +0900)]
Set installed storage and external image path when ManifestDirectInstall

Requires:
 - https://review.tizen.org/gerrit/145167

Change-Id: I3bdeb3c825ef6a0fcb3cc8eb967871dbbd0dc364
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoAdd method to get privilege level from file 16/146416/6
Junghyun Yeon [Mon, 28 Aug 2017 10:56:42 +0000 (19:56 +0900)]
Add method to get privilege level from file

- Signature1 of package has been erased after installation in earlier tizen.
- But signature is needed during migration to latest platform version
  to determine privilege level and to be stored at cert db for trusted operations.
- So, add some codes to get dist root cert value from file which is made by
  migration script.
- But backend still need to assume privilege level for preload RPM packages.

Change-Id: Idf2fa96fb6c4fbf3e598df48e7d93bf367228628
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRelease version 1.22.0 79/146479/1 accepted/tizen/4.0/unified/20170904.234813 accepted/tizen/unified/20170830.161035 submit/tizen/20170829.115218 submit/tizen_4.0/20170901.004643
Sangyoon Jang [Tue, 29 Aug 2017 04:54:06 +0000 (13:54 +0900)]
Release version 1.22.0

Changes:
 - Perform code style checking fixes
 - Skip security path register when ReadonlyUpdateUninstall
 - Set package-recovery process label at systemd service file
 - Support installing package at extended storage
 - Fix wrong path for extended storage
 - AppQueryInterface logic export
 - Adapter interface for external PkgMgr module
 - Remove unnecessary query in AppQueryInterface::IsPkgInstalled()

Change-Id: I9efa0b9ddef62fc689b3b37c3970ecd1ff5508a8
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoRemove unnecessary query in AppQueryInterface::IsPkgInstalled() 26/133526/8
Damian Pietruchowski [Mon, 12 Jun 2017 14:12:29 +0000 (16:12 +0200)]
Remove unnecessary query in AppQueryInterface::IsPkgInstalled()

One of the ci::QueryIsPackageInstalled() calling is unnecessary.

Change-Id: I4c0fa68a1856543dc5e09d6777be97a9fad172f1
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoAdapter interface for external PkgMgr module 98/138998/14
Damian Pietruchowski [Fri, 14 Jul 2017 15:56:52 +0000 (17:56 +0200)]
Adapter interface for external PkgMgr module

PkgQueryInterface class for pkginfo queries instead of functions.
Advantage of this solution is that pkgmgrinfo_pkginfo_get_usr_pkginfo()
is called only once in constructor and handle is freed in destructor.

Submit together:
- https://review.tizen.org/gerrit/#/c/139347/
- https://review.tizen.org/gerrit/#/c/139346/

Change-Id: I820a92eedcbe90d058c1d61f49a595e0444d1fea
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoAppQueryInterface logic export 18/133518/13
Damian Pietruchowski [Mon, 12 Jun 2017 13:56:50 +0000 (15:56 +0200)]
AppQueryInterface logic export

IsPkgInstalled() and GetPkgId() have the same implementation for
wgt-backend and tpk-backend, so only GetPkgIdFromPath() should
be overrided in each backends.

Submit together:
- https://review.tizen.org/gerrit/#/c/133520/
- https://review.tizen.org/gerrit/#/c/133519/

Change-Id: I2b8edb1989ed5cf9fa9e4109292365a4721988f6
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoFix wrong path for extended storage 57/145157/1
Sangyoon Jang [Mon, 21 Aug 2017 11:21:38 +0000 (20:21 +0900)]
Fix wrong path for extended storage

Change-Id: I3cbf51a4bb8dc804c1d9b04b37f25f7ec7577f7b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoSupport installing package at extended storage 83/144683/3
Sangyoon Jang [Thu, 17 Aug 2017 11:25:05 +0000 (20:25 +0900)]
Support installing package at extended storage

Change-Id: If8b798161d0b837d1d0c02c1ad88e9a35a215c5f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoSet package-recovery process label at systemd service file 44/144944/2
Sangyoon Jang [Fri, 18 Aug 2017 09:19:48 +0000 (18:19 +0900)]
Set package-recovery process label at systemd service file

Change-Id: I4490f336e5b2f2e8fa37eaf47d15d4bfb0a1481e
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoSkip security path register when ReadonlyUpdateUninstall 80/144880/2
Sangyoon Jang [Fri, 18 Aug 2017 07:38:11 +0000 (16:38 +0900)]
Skip security path register when ReadonlyUpdateUninstall

Change-Id: I14ec76de118c53005b32d4e4c1aaf8b2dbfa9def
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoPerform code style checking fixes 86/143786/2
Bartlomiej Kunikowski [Fri, 11 Aug 2017 08:42:09 +0000 (10:42 +0200)]
Perform code style checking fixes

Change-Id: I72e8d7149aa46e028851f77f04c1b8b301bb675d

6 years agoRelease version 1.21.1 46/143746/1 accepted/tizen/4.0/unified/20170828.223739 accepted/tizen/unified/20170816.160016 submit/tizen/20170811.063725 submit/tizen_4.0/20170828.100002
Seungha Son [Fri, 11 Aug 2017 06:32:48 +0000 (15:32 +0900)]
Release version 1.21.1

Changes:
 - Fix bug on StepDeltaPatch step
 - Remove backup dir for shared/res feature of web app
 - Unnecessary uses of strcmp() in StepParsePreload
 - Fix uninstalling package installed at extended storage
 - Fix wrong reference in PrepareAppDefinedPrivilegeData
 - Fix SetPackageDirectoryOwnerAndPermissions
 - Add exception handler
 - Add OOM exception handler

Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: Ia074cc40e09cafc7f6b0b8a7968cb922451ee6b9

6 years agoAdd OOM exception handler 48/142448/12
Seungha Son [Fri, 4 Aug 2017 01:16:49 +0000 (10:16 +0900)]
Add OOM exception handler

Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: Ib23567136a901d8a9a833b23db3292abeaef2177

6 years agoAdd exception handler 54/143554/2
Seungha Son [Thu, 10 Aug 2017 09:53:36 +0000 (18:53 +0900)]
Add exception handler

Signed-off-by: Seungha Son <seungha.son@samsung.com>
Change-Id: I4efd0db6fe47e21da0cd84380a974bb247f5a3be

6 years agoFix SetPackageDirectoryOwnerAndPermissions 56/143056/4
Sangyoon Jang [Tue, 8 Aug 2017 09:05:44 +0000 (18:05 +0900)]
Fix SetPackageDirectoryOwnerAndPermissions

Skip when path is symlink.

Change-Id: Id133bb82a196c276340bb9588f633988ca1aa95d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoFix wrong reference in PrepareAppDefinedPrivilegeData 43/143443/1
jongmyeongko [Thu, 10 Aug 2017 02:46:49 +0000 (11:46 +0900)]
Fix wrong reference in PrepareAppDefinedPrivilegeData

Change-Id: I5af7fbbb8ac32c8e3f3d19eaf255006664fc6edc
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
6 years agoFix uninstalling package installed at extended storage 44/142344/5
Sangyoon Jang [Thu, 3 Aug 2017 11:59:18 +0000 (20:59 +0900)]
Fix uninstalling package installed at extended storage

Change-Id: Id4ed544792f34a1e6803f03bab4e24ab7c5f75ee
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
6 years agoUnnecessary uses of strcmp() in StepParsePreload 11/137411/7
Damian Pietruchowski [Wed, 5 Jul 2017 16:10:24 +0000 (18:10 +0200)]
Unnecessary uses of strcmp() in StepParsePreload

Change-Id: Ia2d6b3ff6d4fe6a3b14f9f1136b9914d6c1b6bb6
Signed-off-by: Damian Pietruchowski <d.pietruchow@samsung.com>
6 years agoRemove backup dir for shared/res feature of web app 33/139133/6
jongmyeongko [Mon, 17 Jul 2017 04:56:42 +0000 (13:56 +0900)]
Remove backup dir for shared/res feature of web app

This step is called at the recovery request.

Change-Id: I211d17f59d92f989862ef1affd090197aa72d03e
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
6 years agoFix bug on StepDeltaPatch step 38/142738/4
jongmyeongko [Mon, 7 Aug 2017 07:04:10 +0000 (16:04 +0900)]
Fix bug on StepDeltaPatch step

invalid condition-check

Change-Id: I193b2e0a216b8b38b7cb60efa2fd4be426a3c7d8
Signed-off-by: jongmyeongko <jongmyeong.ko@samsung.com>
6 years agoRelease version 1.21.0 80/142480/1 accepted/tizen/unified/20170807.150536 submit/tizen/20170804.060432
Junghyun Yeon [Fri, 4 Aug 2017 05:35:54 +0000 (14:35 +0900)]
Release version 1.21.0

Changes:
 - Implement trust anchor feature
 - Fix capability of pkgdir-tool
 - Implement extended storage feature

Change-Id: I7285301dc4b506575818192b4ee46c6d60e1963d
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoImplement extended storage feature 93/136993/21
Sangyoon Jang [Thu, 29 Jun 2017 06:27:54 +0000 (15:27 +0900)]
Implement extended storage feature

Change-Id: Ifd2a5c6f94c959a0b3bbbff55b52aa5b9d892f29
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>