Suyeon Hwang [Tue, 7 Feb 2023 08:21:58 +0000 (17:21 +0900)]
Set service state by engine launching status
- Issue:
If the client is out of service by service reset, client can not get
proper service state.
- Solution:
By the on-demand reprepare logic, the clients subscribing service state
changed event can not get service state until that the client invokes
the API. However, if the client invokes the API depending on service
state, the client may not call the API, so it can be out of service
permanently.
To solve this problem, this patch adds logic for checking engine
launching status. Through this patch, the client library can check
whether the engine is launched or not. When the engine is launched, the
client library notifies the service state changed event to the client
app can run the code which depends on the service state.
Change-Id: If4e3310054143732f5705ed4acfae42762fa21b1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 6 Mar 2023 05:02:27 +0000 (05:02 +0000)]
Merge changes Ied3e8043,I465c4e34 into tizen
* changes:
Reprepare instantly for the client speicifed by server
Update UID of instant reprepare client
Suyeon Hwang [Thu, 16 Feb 2023 08:53:17 +0000 (17:53 +0900)]
Add feature checking logic for engine API
- Issue:
Most of the engine API did not return 'not supported error' when the
device does not support the TTS feature.
- Solution:
This patch adds feature checking logic to the beginning of each API
implementation. Through this change, each API will properly check the
required feature and return error. And this behavior is matched to the
description of each API.
Change-Id: I744cb3bbeb6670f3fdfedc1ecd3f9d710f822be2
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 7 Feb 2023 06:07:42 +0000 (15:07 +0900)]
Reprepare instantly for the client speicifed by server
- Requirement:
In order to start engine quickly, one of the clients needs to reprepare
instantly.
- Contents:
This patch adds new logic for repreparing. Through this patch, one of
clients which is specified by the server library will reprepare instantly
when the service is out. This specified client will help quick tts engine
launch.
Change-Id: Ied3e804378c835ea2e744bb948462337802ebc39
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 2 Feb 2023 08:10:38 +0000 (17:10 +0900)]
Update UID of instant reprepare client
- Requirement:
In order to start engine quickly, one of the clients needs to reprepare
instantly.
- Contents:
To make one of the clients reprepare instantly, this patch adds new
logic into the engine library. Through this patch, the engine library
will update the UID of the clieant which needs to reprepare instantly.
This UID update will occur when the connection of the service is changed.
Change-Id: I465c4e3444fbd177feb3bdabdb20338bbab5daf1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 20 Feb 2023 02:13:24 +0000 (11:13 +0900)]
Destroy tts handle always on the main thread
- Issue:
In C# application, the garbage colletor can destroy tts handle on a sub
thread, and this behavior can make thread safety issues.
- Solution:
The C# garbage collector can release the instance on a sub thread, so
this can make race condition issues. To prevent this kind of issues,
this patch adds a new logic to tts_destroy() function. Through this
change, the handle destruction logic of tts_destroy() will always be
run on a main thread. This change will prevent race condition issues
because the logic insures that every handle destructions are run on a
main thread and they are not destroyed at the same time.
Change-Id: I90c248a4975410d4211dea93f24ea43e7c00ecb1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 13 Jan 2023 08:19:26 +0000 (17:19 +0900)]
Try to prepare when the API is invoked on service out
- Requirement:
To reduce the resource for repreparing, clients need to reprepare when
the API is invoked.
- Contents:
This patch changes the logic about service reset and repreparing.
Through this patch, all clients just set service out flag when the
service reset occurs. Plus, each clients will try to reprepare when the
API is invoked by the app. In previous code, all clients tried to
reprepare at the same time when the service reset occurs. However, this
behavior needed to too much resource for repreparing in short time. This
patch intends to decrease the resource requirements for repreparing by
spreading the reprepare requests.
Change-Id: I4fd7b8905975692efba973a7e6c2423d604b4624
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 29 Dec 2022 11:10:41 +0000 (20:10 +0900)]
Store current service state from engine library
- Requirement:
Client library needs to get current service state when preparing is
succeeded.
- Contents:
This patch makes client library store the service state in client
structure when preparing is succeeded. If the client listen the service
state changed event, client has to maintain the current service state
even if the service is out. To do this, each client structure has to
store the current service state.
Through this patch, client structure can maintain the latest service
state at preparing success.
Change-Id: If2ea7b9ebc627363f0b16c51a918d2910a4bcd26
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 29 Dec 2022 09:04:34 +0000 (18:04 +0900)]
Send service state when preparing is succeeded
- Requirement:
Client library needs to get current service state when preparing is
succeeded.
- Contents:
This patch makes engine library send service state to client library.
To implement on-demand repreparing, client library needs to maintain
current service state. Through this patch, client library can get
service state in preparing protocol.
Change-Id: I7d8b7fb261401abcb230610aac0fd645bab015a1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 29 Dec 2022 08:01:33 +0000 (17:01 +0900)]
Add new IPC parameter for sending service state
- Requirement:
Client library needs to get current service state when preparing is
succeeded.
- Contents:
This patch changes the IPC interface parameter for service state. The
client library needs to service state information for enhancing
repreparing logic. Through this patch, client application can receive
service state information when preparing is succeeded.
Change-Id: I62eeab554074455d09ac1c28b369dde83318f399
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 26 Jan 2023 07:52:09 +0000 (16:52 +0900)]
Destroy RPC handle in ecore idler
- Issue:
Invoking tts_unprepare() in event callbacks is allowed and this may
cause segmentation fault by destroying RPC handle in the callback which
is invoked by RPC message.
- Solution:
The app can call tts_unprepare() in the callback. However, this
invocation may cause segmentation fault by destroying the RPC handle in
the callback of the RPC handle itself.
To solve this issue, this patch fixes the RPC handle destruction logic.
Through this patch, the client lib will destroy the handle in ecore idler
callback. This behavior can avoid wrong handle destruction.
Change-Id: I01a2ae528be8f0fa8683c608b3786b5db282d0e1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
(cherry picked from commit
96dd49ebd12b1c1853071cfe5e570e183c6133ee)
Suyeon Hwang [Thu, 26 Jan 2023 07:50:38 +0000 (07:50 +0000)]
Merge changes I0ab5030b,Ieed4a8fe into tizen
* changes:
Fix coding convention about member variables and static functions
Merge branch 'tizen_7.0' into tizen
wn.jang [Thu, 19 Jan 2023 06:04:15 +0000 (15:04 +0900)]
Extend time delay every 5 failures
Cause:
In case of robot image, pkgmgr_client_new() function always returns fail.
So it cause a lot of error message and it makes a huge log file over 1GB.
Solution:
Time delay is extended every 5 failures.
This patch makes only 92 errors in 1 day, and only 110 error messages in 10 days.
Change-Id: Ibd5e5844a543adc6831d5ce76858254505dcba3d
Suyeon Hwang [Thu, 19 Jan 2023 06:01:08 +0000 (15:01 +0900)]
Fix coding convention about member variables and static functions
- Issue:
Using two underscores(__) as name of variables or functions is
reserved by C and CPP compilers, so it may occur name colision.
- Solution:
Previously, most of the code followed old tizen coding convention.
However, in case of name, the convention conflicts with C and CPP
standard, because two underscore is already reserved as an identifier by
C and CPP standard. Thus, using two underscores may cause some problems.
To resolve this collision, this patch fixes the name of member variables
and static functions to match C and CPP standard. Through this patch,
CPP files in the project do not use two underscore as name of variables
and functions anymore.
Change-Id: I0ab5030b018d0d28c9cf2927ddbdf8711ecb788b
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 19 Jan 2023 06:23:12 +0000 (15:23 +0900)]
Merge branch 'tizen_7.0' into tizen
Change-Id: Ieed4a8fe9cd58f50ad26c227baf743119902ecc8
Suyeon Hwang [Tue, 10 Jan 2023 09:38:53 +0000 (18:38 +0900)]
Update version (1.70.17)
Change-Id: Ia967177c08ae60c7f59f41646da37316985f5aa3
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 10 Jan 2023 05:23:20 +0000 (14:23 +0900)]
Check and try to recreate the handle if the handle is invalid
- Issue:
Sometimes, the handle creation for audio framework is failed, but the
stt framework try to use this invalid handle.
- Solution:
The AudioStream class did not set nullptr to audio handles. Because of
this behavior, if the handle was not created from the audio framework,
the AudioStream class tried to use garbage pointer as audio handle. This
caused some crashes. To solve this issue, this patch makes the
AudioStream class initialize the audio handle as nullptr. And also, this
patch adds new code for re-creating audio handles of AudioStream and
BackgroundVolume class. This new code is going to be invoked when some
audio handles are not valid.
Change-Id: I7c98473bf9ced056e4a6dfd579455e94db0b9993
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 6 Jan 2023 01:21:38 +0000 (10:21 +0900)]
Update version (1.70.16)
Change-Id: I584b5a4484a89bba86ad3b8bafbb054d4b0b8cdf
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 3 Jan 2023 03:33:06 +0000 (12:33 +0900)]
Fix rpc port creation timing
- Issue:
Even if the tidl connection is out, client lib may ignore connect
request.
And also, the tidl can not re-connect synchronously right after the tidl
is disconnected.
- Solution:
TIDL connect request is up to connected flag variable in tidl info
structure. However, the connected flag is only set by connected,
rejected, and disconnected event callback. And also, tidl can not
re-connect synchronously right after the disconnect() of tidl is invoked.
So, current client lib can not connect to stub in some specific
situation.
To solve this issue, this patch changes the rpc port creation timing.
Through this patch, tts_tidl module always reset the rpc port when the
io error occurs. And also, tts_tidl module can assure the connection by
creating new rpc port when the client want to prepare.
Change-Id: I8cfc143aebb331389d1fb205b7526b43f0301fee
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 12 Dec 2022 11:09:41 +0000 (20:09 +0900)]
Merge branch 'tizen' into tizen_7.0
Change-Id: I9cb1e0ee0851c6cbdeade7f9ce67487f0cc55d89
Wonnam Jang [Fri, 9 Dec 2022 09:37:47 +0000 (09:37 +0000)]
Merge "Add codes in client side to set/unset callback for retrieving sythesized pcm data" into tizen
Suyeon Hwang [Thu, 8 Dec 2022 05:59:56 +0000 (14:59 +0900)]
Update version (1.70.15)
Change-Id: I3924400bb6249e2d9f5d8a21546c92e71953baaa
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 8 Dec 2022 02:02:12 +0000 (11:02 +0900)]
Try to reprepare when IPC I/O error occurs
- Issue:
TTS API will be failed when the engine is terminated after the client
library already sends request.
- Solution:
Current client library does not handle the network connection failed
situation because almost those situations are covered by reprepare
logic. However, if the engine is terminated without handling client IPC
message, client library should returns error.
Thus, this patch adds new retry logic when network error occurs. Through
this logic, some of the issue case will be covered. However, if engine
has critical issue, then this logic also can cover those situations.
Change-Id: I07075e0139d058f9f9bc84026a00309bf1815066
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
wn.jang [Thu, 1 Dec 2022 07:48:34 +0000 (16:48 +0900)]
Add codes in client side to set/unset callback for retrieving sythesized pcm data
Change-Id: I938872f2546f8462eb8ffd10fc40b522909ee16c
Suyeon Hwang [Tue, 22 Nov 2022 04:47:47 +0000 (13:47 +0900)]
Update version (1.70.14)
Change-Id: I3035a53632eb0a2803efee077faff67e62a72a6e
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 22 Nov 2022 01:12:38 +0000 (10:12 +0900)]
Add TC for checking prepare
- Contents:
This patch adds new TC for check whether tts_prepare() properly succeed
after tts_unprepare().
Change-Id: I3766898d06f33c18a07c80a201e125de94789325
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 21 Nov 2022 10:37:27 +0000 (19:37 +0900)]
Assure that client always registers the callback in sync prepare
- Issue:
Sometimes, the message receive callback registration is skipped even if
the connection is normal.
- Solution:
The client lib always checks the 'register_callback_invoked' flag, but
this flag may not be set properly some cases even if client tries to
prepare synchronously. Thus, this patch removes the flag checking code
from synchronous prepare logic. The synchronous prepare should insure
the invocation of all protocol, so through this patch, the all step of
preparation will be invoked.
Change-Id: If89f4065f139ec032bedddebf6a9927c74f100e7
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 17 Nov 2022 01:08:32 +0000 (10:08 +0900)]
Update version (1.70.13)
Change-Id: Ic76ca3b081b7a38de6b3d0912b3cbea1997cfa71
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 16 Nov 2022 11:11:19 +0000 (20:11 +0900)]
Add mutex for set repeat text
- Issue:
Sometimes, invalid access occurs if app tries to add text in multi
thread enviroment.
- Solution:
App can add text frequently. And also, app can add text in multi thread
enviroment. However, the text_repeat property of client is not safe in
multi thread enviroment. Thus, this patch adds mutex lock for protect
text_repeat from race condition. Through this patch, app can be add text
safely in multi thread.
Change-Id: Iffcce54fcbc34436bf9f4d7ec7aadf571f05889b
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 8 Nov 2022 10:53:30 +0000 (19:53 +0900)]
Merge branch 'tizen' into tizen_7.0
Change-Id: I5a6cc17069ed5460946025805f916770ac0ff6a1
Suyeon Hwang [Mon, 7 Nov 2022 04:47:24 +0000 (13:47 +0900)]
Remove logs making delay of IPC
- Issue:
Sometimes, the IPC request from client is delayed.
- Solution:
By the priority of the process, app manager APIs can be delayed. Thus,
this patch removes some logs that needs to invoke app manager APIs.
Through this patch, the IPC requests will be invoked directly without
any delay.
Change-Id: I19feed1a444364da4f54a729b72ab562a5ea2865
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 7 Nov 2022 04:55:38 +0000 (13:55 +0900)]
Update version (1.70.12)
Change-Id: I6a125484a513bce5e8555ec85b69b46dd90d7668
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 7 Nov 2022 04:47:24 +0000 (13:47 +0900)]
Remove logs making delay of IPC
- Issue:
Sometimes, the IPC request from client is delayed.
- Solution:
By the priority of the process, app manager APIs can be delayed. Thus,
this patch removes some logs that needs to invoke app manager APIs.
Through this patch, the IPC requests will be invoked directly without
any delay.
Change-Id: I19feed1a444364da4f54a729b72ab562a5ea2865
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 2 Sep 2022 05:05:40 +0000 (14:05 +0900)]
Delete timer handle for service state changed notification
- Issue:
The timer handle for service state changed notification is not deleted
if ttsd_finalize() is invoked before that the timer is handled.
- Solution:
This patch makes ttsd_finalize() delete the timer handle. And also, the
memory which stores the state change information should be deleted with
deleting the timer, because the memory is allocated for this timer
behavior.
Change-Id: I7a429c8ab5fb89237ba38c2b1c44c9d606ef01dd
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 2 Sep 2022 02:11:14 +0000 (11:11 +0900)]
Send callback message to clients which set callback
- Requirements:
Server wants to send required IPC message when service state is changed.
- Solution:
Through previous commit, callback registration information was added.
Using this new information, server can decide whether the client require
to receive service state changed event. This patch adds checker for
deciding whether client regists callback.
Change-Id: I3ea1cc9e61626f393dc49a9bceff6c4b05a4a77c
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 1 Sep 2022 11:25:30 +0000 (20:25 +0900)]
Add callback set information into prepare interface
- Requirement:
Server wants to information about whether the client set the service
state changed callback.
- Solution:
Service state is frequently changed, so IPC for notification of service
state change is invoked so many times for all client. However, most of
the client did not register the callback, so many resource can be
wasted by this unvaluable invocation. To reduce wasted resources, this
patch adds callback registration information into IPC interface.
Through this new information server can send valid notification without
waste.
Change-Id: I8a70b694854eefa9c1f2e58726cb6f4c54ba2f65
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 2 Nov 2022 06:59:36 +0000 (15:59 +0900)]
Clean up unnecessary header files
Change-Id: If88d1be2aef5989c2e5859750f9a97e2a273fae5
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 14 Oct 2022 02:58:40 +0000 (11:58 +0900)]
Fix static anlysis issues
- Contents:
This patch includes these changes:
- Remove equality check of floating point values.
- Remove TOC-TOU problem.
- Make blocks for code in switch-case statements.
- Remove arguments from void parameter function.
Change-Id: I119d15f3a600a9cf51e5b9150a69530f782cd04b
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
sooyeon [Fri, 28 Oct 2022 01:44:09 +0000 (10:44 +0900)]
Change sound_server_ready to focus_server_ready
Change-Id: I120f3efc7514c71ee294e8267a6b1c683bc13850
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Fri, 28 Oct 2022 01:44:09 +0000 (10:44 +0900)]
Change sound_server_ready to focus_server_ready
Change-Id: I120f3efc7514c71ee294e8267a6b1c683bc13850
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
Jihoon Kim [Tue, 18 Oct 2022 06:39:37 +0000 (06:39 +0000)]
Merge changes I439a2879,Iaef6463d into tizen
* changes:
Remove trailing whitespaces
Fix typo issue in tts_setting document
Jihoon Kim [Tue, 18 Oct 2022 06:31:22 +0000 (15:31 +0900)]
Remove trailing whitespaces
Change-Id: I439a2879de0c3f4dde3f21b47483798d0fa52cb4
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Tue, 18 Oct 2022 06:21:13 +0000 (15:21 +0900)]
Fix typo issue in tts_setting document
Change-Id: Iaef6463d77ebe7a742c9e7cd3c4ffd1a148f4413
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Suyeon Hwang [Thu, 13 Oct 2022 09:27:16 +0000 (18:27 +0900)]
Update version (1.70.12)
Change-Id: I0cf661a275ac86b49f0cbd6240fff581a17d694f
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 13 Oct 2022 07:45:49 +0000 (16:45 +0900)]
Set engine id from vconf value when default config is set
- Issue:
When default configuration is loaded, invalid engine id can be set.
- Solution:
Default configuration stores fixed engine id, so the engine id can be
not installed in the image. Thus, this patch changes the logic for
loading default configuration. Through this patch, vconf value is used
default engine id when default configuration is loaded.
Change-Id: Ifa37d1eceb5df126b69ac7455aea0dc0e12005fa
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
sooyeon [Wed, 5 Oct 2022 05:40:36 +0000 (14:40 +0900)]
Rollback of changing engine-info directories and file mod
Change-Id: If455a705207a310818345fa121d159b907998d62
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
wn.jang [Thu, 22 Sep 2022 05:40:11 +0000 (14:40 +0900)]
Update version (1.70.11)
Change-Id: Ib203747a3b2b43bd1acd8efefcc1d9be5a2997be
wn.jang [Thu, 22 Sep 2022 05:09:54 +0000 (14:09 +0900)]
Check whether pointer is NULL or not, before use
Change-Id: I498b36afbee0247b6c5add8ca7b976df2211ed1a
Wonnam Jang [Wed, 21 Sep 2022 10:53:29 +0000 (10:53 +0000)]
Merge "Fix defect that is detected by static analysis tool" into tizen
wn.jang [Wed, 21 Sep 2022 10:36:35 +0000 (19:36 +0900)]
Fix defect that is detected by static analysis tool
Cause: When calloc returns NULL, dereferencing a pointer might be nullptr data.
Solution: Check whether calloc is succeeded or not.
Change-Id: I72aa53d041d9cd5d358907f6d2f7ebcb140ab601
sooyeon [Wed, 21 Sep 2022 06:28:52 +0000 (15:28 +0900)]
Update version (1.70.10)
Change-Id: Ib63dd440e20150cb584935382fcd9aa967630b22
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Wed, 21 Sep 2022 05:52:13 +0000 (14:52 +0900)]
Change engine-info directory and Change file mod
Change-Id: Ie643075c6b2fd41044473ceab5f40e82b31e7446
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
Sooyeon Kim [Mon, 19 Sep 2022 07:44:49 +0000 (07:44 +0000)]
Merge "Add dbus allow own for root users in dbus policy" into tizen
Sooyeon Kim [Mon, 19 Sep 2022 05:05:55 +0000 (05:05 +0000)]
Merge "Change directories of tts-config file and engine-info file" into tizen
Suyeon Hwang [Thu, 1 Sep 2022 05:02:14 +0000 (14:02 +0900)]
Save configuratio change before auto language setting
- Issue:
Setting API did not save the change of auto voice enabling
configuration.
- Solution:
The configuration is stored in memory by tts_parser_set_config_info() and
stored in configuration file by other functions from tts_parser module.
However, in current logic for change auto voice configuration,
tts_config_mgr_set_auto_voice() function tries to store configuration
file without storing memory when the auto voice is true. This may cause
the situation that the memory and file are not matched.
So this patch makes the function store the configuration in memory
first.
Change-Id: I9602bcc9cbc3aad0e56fad068e159b144b0d1ab9
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
sooyeon [Fri, 26 Aug 2022 02:39:43 +0000 (11:39 +0900)]
Change directories of tts-config file and engine-info file
- Issue: In case of root daemon, it cannot access tts-config file and engine-info file,
because they are installed in user directories respectively.
- Solution: We move tts-config file and engine-info file to global user data (/opt/usr/data)
to make both root daemon and users access the files.
Change-Id: I7379846bbf54539eb3d81b3bb91e32b8103f94e5
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
Sooyeon Kim [Wed, 24 Aug 2022 01:36:37 +0000 (01:36 +0000)]
Merge "Add logs to check whether TTS engine is launched or not" into tizen
Suyeon Hwang [Tue, 23 Aug 2022 07:02:56 +0000 (16:02 +0900)]
Update version (1.70.9)
Change-Id: I597731fe31f1778c17b8ac184497986a40dc656d
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 12 Aug 2022 02:52:09 +0000 (11:52 +0900)]
Add unit tests for new API about service state
This patch adds new unit tests based on gTest. Through this patch, you
can tests the behavior of new APIs.
Change-Id: I587f1d4a47ca467f6b7258e8729c34c22dcebbef
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 23 Aug 2022 07:00:55 +0000 (07:00 +0000)]
Merge changes Ia966b28c,Ic20dce88,I10407b1e,I3fe6a38f into tizen
* changes:
Implement service state changed event transfering
Implement getter for service state
Add interfaces for transfering service state
Add new class for managing state of server
Suyeon Hwang [Tue, 23 Aug 2022 02:30:17 +0000 (11:30 +0900)]
Add new flag variable for checking state
- Issue:
The engine did not call ttse_main(), but the engine library works like
that ttse_main() was already invoked.
- Solution:
The APIs provided by engine library checks g_is_terminate flag variable
for checking whether ttse_main() is invoked or not. However,
g_is_terminate variable is for checking whether ttse_terminate() is
invoked not for checking ttse_main() invocation. So even if the engine
does not call ttse_main(), the library could not know that ttse_main()
was not invoked yet. Thus, this patch adds new flag variable for
ttse_main() invocation.
Change-Id: I82e1df3abe2f685b19a6cd5a85c84c21d28d9624
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
sooyeon [Fri, 18 Mar 2022 17:03:51 +0000 (02:03 +0900)]
Add logs to check whether TTS engine is launched or not
Change-Id: I880fdb546a440334b0295d8ba80585e38d748a6b
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
(cherry picked from commit
8925dec19a67413070834ee9655bdc77633253bf)
Suyeon Hwang [Thu, 11 Aug 2022 10:35:43 +0000 (19:35 +0900)]
Implement service state changed event transfering
This patch implements service state changed event. Through this patch,
the client receives service state change information from server.
Change-Id: Ia966b28cc76c39ba0a535e1fd98edfcf04e3ceea
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 11 Aug 2022 06:35:07 +0000 (15:35 +0900)]
Implement getter for service state
This patch implements the business logic for service state getter
functions. For thses, this patch uses interfaces introduced previous
commit.
Change-Id: Ic20dce885dbfde86fd9911dcb971d65c8d66629b
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 11 Aug 2022 06:04:07 +0000 (15:04 +0900)]
Add interfaces for transfering service state
- Requirement:
The client and server needs interface for requesting and transfering
service state, respectively.
- Solution:
This patch adds new interfaces for requesting and transfering service
state. These new interfaces includes both Dbus and TIDL.
Change-Id: I10407b1e7c0bed1cb377c83d27c29db09882fefd
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 10 Aug 2022 12:11:22 +0000 (21:11 +0900)]
Add new class for managing state of server
- Requirement:
The TTS engine library needs to manage its state.
- Solution:
This patch adds new class StateManager which helps to manage state of
TTS service. Through this new class, the TTS engine library can easily
change the state and notify it.
Change-Id: I3fe6a38fcd9f55f8027b8ed1cdec8ca453cbe9a8
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 19 Aug 2022 01:31:15 +0000 (10:31 +0900)]
Add missed error description
Change-Id: I8ca103f942fed8a63864caa7fb71db486b1387c5
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 18 Aug 2022 08:31:08 +0000 (08:31 +0000)]
Merge "Add new APIs about service state information" into tizen
Suyeon Hwang [Thu, 18 Aug 2022 05:25:23 +0000 (14:25 +0900)]
Add not supported error description and checker logic
- Issue:
New APIs are related with the TTS feature, but there is no information
about the feature in description of APIs.
- Solution:
This patch adds description for feature not supported error. And also,
this patch implements feature checker logic. Through this patch, the
APIs will not working if the feature is not enabled and return not
supported error.
Change-Id: I4c92376db2f98562c8792bc9446cb7a77d8a4626
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 10 Aug 2022 09:38:37 +0000 (18:38 +0900)]
Add new APIs about service state information
- Requirement:
An application needs state of TTS service in order to check whether the
TTS service is able to handle the request of the application.
- Solution:
This patch adds new APIs for checking state of TTS service. Through
these new APIs, applications which use TTS can check the state of TTS
service and handle the TTS request according to the state of TTS
service.
Change-Id: I7fbbf3f9e316b91468423c26c38452383498cf34
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 17 Aug 2022 04:42:53 +0000 (13:42 +0900)]
Update version (1.70.8)
Change-Id: I89e6a033e5a697b5c673012afffe46f828e7f496
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 1 Aug 2022 08:35:07 +0000 (17:35 +0900)]
Implement behavior of new APIs
This patch is for implementing new APIs introduced from previous commit.
Change-Id: Iaa157ffd229bf39f2a20754dfb641ea943c2e532
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 28 Jul 2022 11:44:59 +0000 (20:44 +0900)]
Add new class for managing activated mode
- Requirement:
TTS server should manage current activated mode information. This
information for the service engine application to help decide behavior
of the application.
- Solution:
In order to store and manage currently activated mode information, this
patch adds new class. This new class only manages the currently
activated mode information, and other modules can get this information
through the methods of this class.
Change-Id: I13d47ebcf3b28c18583ac3dbe14302af0438bf94
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 1 Aug 2022 07:42:25 +0000 (16:42 +0900)]
Add new APIs about activated mode information
- Requirement:
Engine application needs mode information that is currently activated by
connected clients.
- Solution:
This patch adds new APIs about mode informatino that is currently
activated by connected clients. These new APIs sends activated mode
information through a getter or registered callback function.
Change-Id: Ie2a2c4c49be23d05195519c34dbc6d98c61e0bad
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
sooyeon [Fri, 5 Aug 2022 09:11:33 +0000 (18:11 +0900)]
Add dbus allow own for root users in dbus policy
Change-Id: I18ba4dbbfcee2e34efb6d8cc313584f453222b43
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
Suyeon Hwang [Mon, 1 Aug 2022 05:27:54 +0000 (14:27 +0900)]
Load engine when the first client is connected
- Issue:
Engine loads model when the engine is initializing, so engine always has
to load model, even if engine application does not need to load model in
some case.
- Solution:
To solve this problem, first, we need to change the timing for loading
engine. This is because engine has no information about clients when
engine is initialzing. Without any clients information, engine can not
decide whether the engine needs to load model or not.
This patch changes the timing for loading engine to when the first client
information is received. Through this patch, engine already has client
information when engine has to decide model loading.
Change-Id: Idfb67c1209dd17da2a1298ff5b82e4fec2cde18e
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Wonnam Jang [Tue, 2 Aug 2022 08:47:08 +0000 (08:47 +0000)]
Merge "Reduce log while waiting for comming synthesized pcm data" into tizen
wn.jang [Tue, 2 Aug 2022 08:30:40 +0000 (17:30 +0900)]
Reduce log while waiting for comming synthesized pcm data
Change-Id: If6b76a759512d133f5a780b43af63c830428b968
Suyeon Hwang [Fri, 29 Jul 2022 05:30:32 +0000 (14:30 +0900)]
Remove functions related with setting mode
- Issue:
Client mode information is already set in ttsd_server_initialize().
- Solution:
This patch removes functions that are releated with setting mode. These
functions are not neccessary anymore because mode information is already
set on ttsd_server_initialize().
Change-Id: Ic5f08edd9c98c4e5c34fd3d724de778f57e7991d
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 28 Jul 2022 12:00:05 +0000 (21:00 +0900)]
Merge setters and creater function about client
- Requirement:
Server want to store client mode and IPC method information when prepare
request from client is comming.
- Solution:
It is already possible to store client mode information using setter
functions. However, the mode and IPC method information will be decided
before that client requests prepare. So, using one function to store
these properties are more simple and comportable.
Thus, this patch adds new parameter into ttsd_server_initialize() and
ttsd_data_new_client(). Through this patch, the server can store client
mode and IPC method information during ttsd_data_new_client() invocation.
Change-Id: Ic9f3052a14d4133c6088088e36a827d261091ce1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 2 Aug 2022 04:28:41 +0000 (04:28 +0000)]
Merge "Fix IPC interface for preparing protocol" into tizen
Suyeon Hwang [Fri, 29 Jul 2022 03:21:29 +0000 (12:21 +0900)]
Fix IPC interface for preparing protocol
- Requirement:
Client want to send mode information to server with hello message.
- Solution:
Actually, mode information is already set before calling tts_prepare()
function, so client should be able to send mode information within hello
message. However, current code sends mode information through another
IPC method.
This patch changes the hello message interface between server and
client. Through this patch, client can send mode information with hello
message at once.
Change-Id: Ie4c622b48507935d2ba35980fc2b44c4854bdeb8
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Wonnam Jang [Tue, 2 Aug 2022 01:27:38 +0000 (01:27 +0000)]
Merge "Add error type for converting string" into tizen
Suyeon Hwang [Mon, 1 Aug 2022 07:13:48 +0000 (16:13 +0900)]
Send 'NULL' string if there is no private data
- Issue:
When server sends null pointer through TIDL parameter, client may
receive unhanlded error.
- Solution:
This is because null pointer can occur invalid access on TIDL logic. To
prevent this situation, this patch sends 'NULL' string instead of null
pointer. Through this change, client always can access valid memory
pointer.
Change-Id: I2685ca0a836c360b3a784da804bbabfabb7df783
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 28 Jul 2022 07:52:38 +0000 (16:52 +0900)]
Fix tidl error handling code
- Issue:
TIDL functions always return -1 even if those are failed by various
reasons.
- Solution:
The code generated by tidlc uses 'set_last_result()' and 'get_last_result()'
function for handling exception. Thus, the caller of those code should
check the error code of 'get_last_result()' first. However, current code
only check return value of each functions.
This patch adds logic for check the error from 'get_last_result()'.
Through this change, framework can handle error from tidl code properly.
Change-Id: Ic075a95ebb64074797633f5973c8c4d5fe8d07e0
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 15 Jul 2022 04:17:07 +0000 (13:17 +0900)]
Refactor feature check and handle creation code
Change-Id: Idc6d9c6de4ff23d30646a3797c615e75e54af411
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 13 Jul 2022 10:38:18 +0000 (19:38 +0900)]
Use condition check macro for line coverage
- Issue:
It is tough to cover error handling code through unit test.
- Solution:
Actually, all conditional statement for checking error is invoked, but
the problem is that the code for when error occurs is not invoked. some
error handling codes are covered, but others are not covered only
through unit tests. So this patch changes conditional check code to
macro version. It still works as same as before, but the code is
compressed into one line, so all line is covered.
Change-Id: I268908220eb27258d19661b9907e83bffea008da
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 13 Jul 2022 07:47:21 +0000 (16:47 +0900)]
Fix unit functions that are not invoked
- Issue:
Some internal functions are not invoked from business logic.
- Solution:
Some functions are predefined for future needs, but they are note called
yet. So, these functions decrease the line coverage. To solve this issue,
this patch removes those dead functions.
And also, this patch invokes a dead function. This function has purpose
and code that needs to invoke this function, but current code does not
use it. Through this patch, this function is invoked and covered by test
case.
Change-Id: I33b882525e99ca251644aedbe7b18cf938dc17ff
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 13 Jul 2022 07:24:34 +0000 (16:24 +0900)]
Exclude un-testable codes from line coverage analysis
- Issue:
Some codes can not be tested in automatic test enviroment. Those code
are effected by the behavior of engine or configuration.
- Solution:
This patch excludes some codes that are not tested by automatic test
enviroment from line coverage analysis. To excludes those codes, this
patch adds special comments that indicate that codes are excluded from
line coverage analysis.
Change-Id: I6201bbd7b341dcede7400565a6b106f5d1228cd6
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 13 Jul 2022 06:28:41 +0000 (15:28 +0900)]
Add test cases for uncovered APIs
- Issue:
Some APIs are not checked by line coverage analysis.
- Solution:
This patch adds new test cases for uncovered APIs. Through this change,
uncovered APIs are now checked in line coverage analysis.
Change-Id: Iab6cded7402a461c3da42bac0d41e5327d6a0904
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
wn.jang [Wed, 27 Jul 2022 04:55:49 +0000 (13:55 +0900)]
Add error type for converting string
Change-Id: I9b336cfe47b9dcf0f33cd7e886195cbea09220fa
Suyeon Hwang [Tue, 12 Jul 2022 11:25:39 +0000 (20:25 +0900)]
Exclude un-testable files and fix test launch option
- Issue:
Line coverage result by automatic checker is not good.
- Solution:
This patch excludes some files that are not target for testing user APIs. This
repository is for TTS framework code, so there are code for not only client but
also server and settings. Those code are not invoked or refered when the test
case of user APIs run, so we exclude those files from line coverage checking
through this patch.
And also, this patch adds launch option for testing. This is because for
checking the test result using journal log.
Change-Id: I23efa18a51a01040b29e9283f82cf27fe016c72f
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
ulgal-park [Mon, 25 Jul 2022 08:48:57 +0000 (17:48 +0900)]
Add metadata key
Change-Id: I637be805d6fd917c045b444b135545d06273caf8
Suyeon Hwang [Thu, 7 Jul 2022 05:59:58 +0000 (14:59 +0900)]
Make variables shared between threads atomic
- Issue:
Some variables that are shared between threads are defined with 'volatile'
keyword for preventing race condition. However 'volatile' can not assure
preventing race condition.
- Solution:
'volatile' just prevents compiler optimization, not prevent race
condition between threads. To assure thread safety, we should use atomic
variable.
This patch fixes the definition of those variable into atomic variables.
Through this patch, each variables will be created as atomic variables
and these atomic varaibles can prevent race condition during multi
threads enviroment.
Change-Id: I71f254a62d7ac848fedeffc91c40e4271f7af25d
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
wn.jang [Sun, 24 Jul 2022 23:03:12 +0000 (08:03 +0900)]
Update version to 1.70.7
Change-Id: I94519ffd8013d740112746098880e1669f7e178e
Suyeon Hwang [Wed, 13 Jul 2022 02:20:01 +0000 (11:20 +0900)]
Add static keyword into global variables
- Issue:
Some global variables can be accessed by other files, because those are
not hided from others. It can allow malicious access.
- Solution:
This patch adds static keyword into global variables that are used only
in the file.
Change-Id: I85a0563027fc94dcd9d31eb508b37f237678b0e0
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 13 Jul 2022 01:54:52 +0000 (10:54 +0900)]
Exclude code of unittests from SAM analysis
- Issue:
When we get SAM score using automation enviroment, the DC score is
effected by unittest code.
- Solution:
This patch excludes files for test code from SAM analysis. Through this
change, the SAM score is calculated only refering implementation.
Change-Id: I9dd67868727db0c257c9d83896441dc42337a018
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 5 Jul 2022 11:51:29 +0000 (20:51 +0900)]
Extract common code as functions for reducing duplicated code
Change-Id: I5de2dbe0c6e240ce364c4447c87bca048c59e6cc
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 5 Jul 2022 01:29:01 +0000 (10:29 +0900)]
Refactor unit test code for removing duplicated code
- Issue:
There are too many test case for testing scenarios, and some of test
case have similar or same testing scenarios. And these scenarios make
duplicated code.
- Solution:
For removing common and duplicated code for each test case, this patch
creates new test suites classes. Through these new classes, each test
case can remove common setUp and tearDown codes.
Change-Id: Id74508b7ef3732748799d9f2878598de3e5dead0
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 4 Jul 2022 11:01:45 +0000 (20:01 +0900)]
Extract unit functions for reducing duplicated code
- Issue:
To get some dynamic values, there are too many duplicated code used.
- Solution:
This patch extracts duplicated codes and creates new functions using the
codes. Using these new functions, we can remove duplicated codes from
the file.
Change-Id: I926f105e5ed124b10ddc55eecc7844aa83c08033
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>