Michal Bloch [Fri, 27 Oct 2017 15:54:34 +0000 (17:54 +0200)]
Extract log pushing out of the main loop.
Change-Id: Ic9ebb1eee62f08e612ca9b3f70288784e193ad9c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Fri, 27 Oct 2017 12:02:35 +0000 (12:02 +0000)]
Merge changes I99afed7f,Ib0dacc9f into tizen
* changes:
Fix string null termination.
Replace a magic constant.
Karol Lewandowski [Fri, 27 Oct 2017 12:01:54 +0000 (12:01 +0000)]
Merge "logger: type correctness" into tizen
Karol Lewandowski [Fri, 27 Oct 2017 12:01:36 +0000 (12:01 +0000)]
Merge "Fix a documentation generation warning" into tizen
INSUN PYO [Fri, 27 Oct 2017 04:58:14 +0000 (13:58 +0900)]
Coverity fixes.
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I2db14f6046ad3d65bab4a720b19e0577e1e02aed
Michal Bloch [Wed, 13 Sep 2017 11:59:29 +0000 (13:59 +0200)]
logger: type correctness
Reduce the amount of implicit type conversions for better type safety.
Change-Id: I534cdf16ddef6bf3b8e0b4a4a5d69814dcee9350
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 24 Oct 2017 10:16:47 +0000 (12:16 +0200)]
Fix string null termination.
Change-Id: I99afed7f160f4839dd790ea2f989bb491e84223f
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 25 Oct 2017 13:20:10 +0000 (15:20 +0200)]
Replace a magic constant.
Change-Id: Ib0dacc9f113b34298785d6fee1c1db3fb2ef50d8
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 24 Oct 2017 11:17:24 +0000 (13:17 +0200)]
Fix a documentation generation warning
Fixes "end of file while inside a group", accidentally
introduced in
0746fc5da519e290b67e96f75fc4c315fc44bd98
Change-Id: I00321fcff21b0dc24cbf48ef4c9546453269ec45
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Tue, 24 Oct 2017 10:23:43 +0000 (10:23 +0000)]
Merge "logger: simplify signal handling" into tizen
Karol Lewandowski [Tue, 24 Oct 2017 10:19:56 +0000 (10:19 +0000)]
Merge changes I6a86ce01,I03d9457d,I35d21d71,I39a487e8,I0e5cf156 into tizen
* changes:
util: dynamic growth for the sorting container
util: use dynamic containers for log source lists
shared: expand the list interface
util: change enabled buffer list to bitflags
util: extract functions out of the main loop
sanghyeok.oh [Mon, 16 Oct 2017 07:59:56 +0000 (16:59 +0900)]
Coverity fix
Change-Id: I872bc5ad2e838a72d5a6de7b68ea664c3d4d7410
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Michal Bloch [Thu, 28 Sep 2017 15:30:43 +0000 (17:30 +0200)]
Remove `atoi_check_numeric` in favour of `sscanf`
Let's not reinvent the wheel.
Change-Id: I75874d1c6c9cc0054def2e85525a28fbd2c227e8
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
INSUN PYO [Tue, 10 Oct 2017 08:26:54 +0000 (17:26 +0900)]
Coverity fix
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Ie31a0b06a8afb94c46ca59fdb75b0beef7241176
Michal Bloch [Thu, 14 Sep 2017 11:22:21 +0000 (13:22 +0200)]
util: dynamic growth for the sorting container
* the sorting container now grows as needed
* size parameters now set initial size
Change-Id: I6a86ce01702fe11186fd6b77559e38d50ef327ea
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 29 Sep 2017 10:46:18 +0000 (12:46 +0200)]
util: use dynamic containers for log source lists
Fixes a crash when >16 --dumpfile passed.
Change-Id: I03d9457d66efbceb26fe2e1fb1809458d19f5693
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 15 Sep 2017 13:20:24 +0000 (15:20 +0200)]
shared: expand the list interface
* list_clear
* list_at
* list_next
Change-Id: I35d21d71e3af007222bee859d482265eb93726c3
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 27 Sep 2017 16:42:05 +0000 (18:42 +0200)]
util: change enabled buffer list to bitflags
Fixes a crash when >16 -b options are specified.
Change-Id: I39a487e80d25127515b98a39bfaa20a0f0d88310
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 26 Sep 2017 13:38:03 +0000 (15:38 +0200)]
util: extract functions out of the main loop
Change-Id: I0e5cf15678b8886cbec7a65fbf3bbb0c64301d42
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 22 Sep 2017 15:26:11 +0000 (17:26 +0200)]
Fix SVACE issues.
Change-Id: I0499a41c47fb89b333f2642b31c21272e9f4e993
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 26 Sep 2017 15:55:34 +0000 (17:55 +0200)]
logger: simplify signal handling
Change-Id: Ide15ed5fc9c652a86b60b234f4dc16ea8ef12fa0
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Tue, 19 Sep 2017 10:21:59 +0000 (10:21 +0000)]
Merge "shared: fix android logger entry parsing" into tizen
Michal Bloch [Wed, 13 Sep 2017 15:12:05 +0000 (17:12 +0200)]
util: extract fdi_free
Change-Id: Ie936b495e501684a33428d5a8194c0332dfbd887
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 15 Sep 2017 12:54:44 +0000 (14:54 +0200)]
shared: fix android logger entry parsing
Also fixes max payload size on pipe backend being 16 bytes lower than supposed to.
Change-Id: I6a3b429b3603102bfd87c96b0a0bcad4b86e1a21
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Fri, 15 Sep 2017 10:21:12 +0000 (10:21 +0000)]
Merge "util: disallow -b and --dumpfile together" into tizen
Michal Bloch [Thu, 17 Aug 2017 10:27:43 +0000 (12:27 +0200)]
logger: reader keeps buffer by ptr instead of id
Change-Id: I074c4cfe12f5cdd208e4bb635ddbb5faed78295d
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 7 Sep 2017 16:37:02 +0000 (18:37 +0200)]
util: disallow -b and --dumpfile together
No known valid use case.
Removal allows code simplification.
Change-Id: I86be0c3c7edb5a643690eec1e9e154eda078c9d6
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Fri, 8 Sep 2017 15:03:06 +0000 (15:03 +0000)]
Merge "dlog_test: Drop bashisms" into tizen
Youngjae Shin [Fri, 8 Sep 2017 05:57:32 +0000 (14:57 +0900)]
remove build warning
Change-Id: I6ee67ce1bf32aff1c26b4e043173cfd0712f8849
Karol Lewandowski [Thu, 7 Sep 2017 16:32:15 +0000 (16:32 +0000)]
Merge "dlogctrl: drop" into tizen
Karol Lewandowski [Thu, 7 Sep 2017 16:31:21 +0000 (16:31 +0000)]
Merge changes Ie62eadbc,I62184bdf into tizen
* changes:
logger: improve poor variable naming
logger: remove g_file_buffer
Karol Lewandowski [Thu, 7 Sep 2017 16:27:44 +0000 (16:27 +0000)]
Merge "shared: make headers C++ friendly" into tizen
Karol Lewandowski [Fri, 25 Aug 2017 11:11:52 +0000 (13:11 +0200)]
dlog_test: Drop bashisms
Change-Id: I6bca400bc4be272265d0e54756f5526945021fa3
Michal Bloch [Mon, 4 Sep 2017 15:08:47 +0000 (17:08 +0200)]
dlogctrl: drop
dlogctrl was used to edit main dlog config file. This functionality
was superseded by "Extensible config" (
1554eb9f3), which allows adding
configuration snippets to configuration directory (by default it is at
/etc/dlog.conf.d, additionally controlled by DLOG_CONFIG_PATH env var).
Change-Id: I061c73064a6192cedcdc171ec45528cebbe94a96
Michal Bloch [Wed, 6 Sep 2017 14:47:06 +0000 (16:47 +0200)]
logger: improve poor variable naming
"Buffer" used to be used for two different things.
Change-Id: Ie62eadbc81d2334934d6531c0a5b51e2423d8052
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 21 Aug 2017 17:29:49 +0000 (19:29 +0200)]
shared: make headers C++ friendly
Change-Id: I93578a9cd54fdf97e3faf7de40c5c5c4da9d2881
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 6 Sep 2017 10:50:56 +0000 (12:50 +0200)]
logger: remove g_file_buffer
There is no evidence this buffering was ever needed.
We can also use fwrite instead should the need arise.
Change-Id: I62184bdf1a7a4529b48a8ee40a1e9c17a202332e
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Wed, 6 Sep 2017 10:31:28 +0000 (12:31 +0200)]
logger: Fix -h option handling
Commit
a7f94864f ("[4.0] logger: Major initialization refactor") broken
-h option handling.
This commit restores original behaviour - -h makes server exit after
printing help screen.
Change-Id: If5084bece8eb4e2a182ffaaf7d09a2073576d5eb
Karol Lewandowski [Tue, 5 Sep 2017 21:52:43 +0000 (21:52 +0000)]
Merge "Revert "Add Android logger backend configuration file."" into tizen
Karol Lewandowski [Tue, 5 Sep 2017 16:31:52 +0000 (16:31 +0000)]
Merge changes I387ff0bf,I7c687a7b,I0688f428,I58dc8880,I8278bca1 into tizen
* changes:
logger: introduce buffering defaults
logger: decouple epoll and buffering timeouts
logger: make byte-based buffering per-reader
logger: add reader helper functions
logger: refactor circular buffer helpers
Michal Bloch [Thu, 17 Aug 2017 11:46:54 +0000 (13:46 +0200)]
logger: introduce buffering defaults
Change-Id: I387ff0bf745325a946260e12628effb8906fbf0f
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 17 Aug 2017 14:56:06 +0000 (16:56 +0200)]
logger: decouple epoll and buffering timeouts
Change-Id: I7c687a7bf7246f5301ad245471b4545c787ca8f5
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 17 Aug 2017 14:56:06 +0000 (16:56 +0200)]
logger: make byte-based buffering per-reader
Change-Id: I0688f428adeb5a40c225237585feef4ee7683573
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 17 Aug 2017 15:07:33 +0000 (17:07 +0200)]
logger: add reader helper functions
Change-Id: I58dc8880cb8d2aae575a80bddd83cdf94ac41c26
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 17 Aug 2017 15:06:46 +0000 (17:06 +0200)]
logger: refactor circular buffer helpers
* make data types unsigned when conceptually appropriate
* extract circular distance calculation (for use in further changes)
Change-Id: I8278bca1cc06c4bc9fb3efb9b37a50bf86205593
Karol Lewandowski [Tue, 29 Aug 2017 15:31:29 +0000 (17:31 +0200)]
logutil: pipe: Raise sorting buffer sizes
To sort messages in order sort buffer size must be >= size of sorted
log messages.
This commit raises the defaults and limits to ensure that sort buffer
is big enough.
Change-Id: I596133cb8aa5a442b074d340464293b4a1400f6b
Karol Lewandowski [Fri, 25 Aug 2017 10:59:46 +0000 (12:59 +0200)]
Revert "Add Android logger backend configuration file."
This reverts commit
1d2ee4c83384c11bba81044b8722d8f3a41b6d4b.
Originally it meant to support RPi3-specific kernel logger
configuration change, but it was not accepted in the kernel
itself.
Change-Id: I3da8cc3ec43fc8bfafb81c514fda340a44e6553b
Karol Lewandowski [Fri, 25 Aug 2017 12:31:45 +0000 (12:31 +0000)]
Merge "logutil: move a generic function to logcommon" into tizen
Michal Bloch [Fri, 18 Aug 2017 15:42:17 +0000 (17:42 +0200)]
logutil: move a generic function to logcommon
Change-Id: I85de720e8784a4a8650e7b597e5877dfdebacc09
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 21 Aug 2017 13:44:19 +0000 (15:44 +0200)]
logger: remove nonexistent `-k` option
Change-Id: I9d34270419b3de01d4575fe4b48fab5b3a74c757
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Yunmi Ha [Fri, 18 Aug 2017 08:11:17 +0000 (17:11 +0900)]
Modify 3.0 to 4.0 upgrade script
Change-Id: I13d8b9002b453630df16c89a4b2da71f1bf0de44
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Karol Lewandowski [Fri, 18 Aug 2017 09:01:15 +0000 (09:01 +0000)]
Merge "Fix: logutil: pipe: Do not depend on snprintf() return value for calculations" into tizen
Karol Lewandowski [Thu, 17 Aug 2017 12:51:04 +0000 (12:51 +0000)]
Merge "logutil: pipe: Do not send rotation parameters" into tizen
Karol Lewandowski [Thu, 17 Aug 2017 12:50:36 +0000 (12:50 +0000)]
Merge "logutil: pipe: Do not send buffer name directly" into tizen
Karol Lewandowski [Thu, 17 Aug 2017 08:13:31 +0000 (10:13 +0200)]
Fix: logutil: pipe: Do not depend on snprintf() return value for calculations
snprintf() can return numers of characters that "would have been
written if buffer would be large enough", not actual characters
written.
This commits reworks logger request command construction to
avoid snprintf().
Problem pointed out by 김원영 <won0.kim@samsung.com> (thank you!)
Change-Id: I664cc0ce779eaff3c004e47fd5102b0576295630
Karol Lewandowski [Wed, 16 Aug 2017 14:41:57 +0000 (14:41 +0000)]
Merge "logger: handle logs of odd length correctly" into tizen
Karol Lewandowski [Wed, 16 Aug 2017 13:54:38 +0000 (15:54 +0200)]
logutil: pipe: Do not send rotation parameters
These parameters are interpreted locally by dlogutil and must not
be transferred to the server.
Change-Id: Iafed8915c16afb05d721a139f8e7baaf86a70128
Michal Bloch [Wed, 16 Aug 2017 12:08:19 +0000 (14:08 +0200)]
logger: handle logs of odd length correctly
If there was only one byte left before the buffer wraps around,
the length field, which consists of 2 bytes, would end up torn apart,
yielding garbage on naive read attempts.
While libdlog did ensure to write only even-length logs, this could
not be relied upon when not using it: this includes kmsg and, potentially,
malicious users.
Change-Id: I7ec3777d650ec2642812b27e87de5e16e0dd72fc
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Wed, 16 Aug 2017 10:55:38 +0000 (12:55 +0200)]
logutil: pipe: Do not send buffer name directly
For pipe backend, in order to get logs from particular buffer
we need to connect to appropriate socket. Sending buffer name
over wire is unnecessary and potentially dangerous.
Change-Id: Ibe18292b627bfbec277dd0dbf378ce054e0c9f54
Karol Lewandowski [Wed, 16 Aug 2017 10:42:13 +0000 (12:42 +0200)]
logutil: pipe: Rework logutil request
This commit introduces iovec+writev() usage to construct logutil
request instead of malloc. This allows us to simplify error handling
a bit.
Additionally, fix dlog_control_msg payload length calculation -
it needs to have at most MAX_LOGGER_REQUEST_LEN (including
terminating null byte).
Change-Id: Ib9ab85355a6760a26a9250b20f4ea0dc1b1b2532
Karol Lewandowski [Wed, 16 Aug 2017 10:36:24 +0000 (12:36 +0200)]
logutil: pipe: Simplify clear command
Change-Id: I0c14ec2e05d62e8d197f37dd655a5892b32bb0ba
Karol Lewandowski [Tue, 8 Aug 2017 15:58:45 +0000 (17:58 +0200)]
logutil: Move sorting vector initialization out of main
Change-Id: Id1cb99838dc24ccdb04a3e7dc00508b4f883d7fe
Michal Bloch [Fri, 4 Aug 2017 14:45:36 +0000 (16:45 +0200)]
Refactor libdlog initialisation
Change-Id: Ifda65c610c5496fa270a826eac3dc2cc8217dd57
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Thu, 10 Aug 2017 12:09:14 +0000 (14:09 +0200)]
logger: Print warning when dlogutil config line did not come with -f (required)
Change-Id: I8d317c258950fc5e3ec3adcf0372ef49fe90d4ee
Michal Bloch [Fri, 11 Aug 2017 12:42:13 +0000 (14:42 +0200)]
logconfig: fix config entry duplication
snprintf returns the number of written chars WITHOUT the null terminator,
even though it accepts the size WITH it.
This meant that even though the overwrite was successful,
the modification check always failed, leading the config
to think there was no existing entry and add another one.
Change-Id: Ic7e10e24258e0d54dc08f2c280f1f298569a282d
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Tue, 8 Aug 2017 15:53:58 +0000 (17:53 +0200)]
logutil: Be explicit about invalid option handling
Change-Id: If7b5c4710622c9912adbd7fb7e3edb4445077124
Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
Karol Lewandowski [Thu, 10 Aug 2017 13:05:36 +0000 (15:05 +0200)]
logger: Simplify getopt() handling in server
Change-Id: I5c6e6f47a0b8ed9df599cdeb52e1ea6651f40716
Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
Karol Lewandowski [Thu, 10 Aug 2017 13:03:00 +0000 (15:03 +0200)]
Introduce rotation parameter defaults for both server and util
* file size (-r): 1 MB
* file count (-n): 3
Change-Id: I8be4ad5dcab0a04b1ba92b6f7072e8b4c2ba0783
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
Karol Lewandowski [Thu, 10 Aug 2017 11:50:05 +0000 (13:50 +0200)]
common: Add stringify macro
Change-Id: I3164fcaaba493eca62f5c095be0a845933150fac
Karol Lewandowski [Thu, 10 Aug 2017 13:01:07 +0000 (15:01 +0200)]
Unify logfile handling (including rotation) across util & server
Change-Id: I63cd978a022789267a8081166ebdad508ead8273
Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
Karol Lewandowski [Wed, 9 Aug 2017 14:25:26 +0000 (16:25 +0200)]
Fix: Do not write binary header to otherwise plaintext "syslog" file
Change-Id: If8e202af7d79a6fa2ba33e0510a1ebcbab2ae1e8
Karol Lewandowski [Mon, 7 Aug 2017 10:09:47 +0000 (12:09 +0200)]
logutil: Drop unneeded filename check
Any error will be properly handled by open() call in next statement anyway.
Change-Id: Ic92433adbaad9065bf6db2759b32f055c23179c5
Karol Lewandowski [Mon, 7 Aug 2017 16:44:59 +0000 (18:44 +0200)]
logutil: Avoid redundant config free
Config is always freed due to usage of gcc's function descructors:
__attribute__ ((cleanup(log_config_free))) struct log_config conf;
Change-Id: Idfd3f9a402ca2698aed715f5ea25d99e36c438e0
Karol Lewandowski [Mon, 7 Aug 2017 09:25:00 +0000 (11:25 +0200)]
logutil: Drop invalid buffer names early
Change-Id: Id54fa50a99fb8623ad841d947da43704bb2e3b76
Karol Lewandowski [Wed, 9 Aug 2017 12:08:27 +0000 (14:08 +0200)]
logutil: Drop unneeded getopt() sanity checking
getopt() internally checks if argument was specified.
This commit removes duplicate checking.
Change-Id: I53ce56756bfffa96fc82761679d29c1d9639a553
Karol Lewandowski [Wed, 9 Aug 2017 12:05:46 +0000 (14:05 +0200)]
common: Introduce atoi_check_numeric()
Change-Id: I47cdb91f9b8e803b592f2e5ed0298e4ba21b020b
Karol Lewandowski [Fri, 4 Aug 2017 14:52:20 +0000 (16:52 +0200)]
logutil: Drop redundant select()
select() was needed when dlogutil read files from stdin, however
this was disabled long time ago in
744f33dd2 ("Pipe-backend: change
dlogutil handling of raw files").
Change-Id: Ic6133240d2ea6079f3a475a170637abf31f3078d
Michal Bloch [Wed, 2 Aug 2017 11:32:50 +0000 (13:32 +0200)]
Fix libdlog limiter
Change-Id: Id6b986092de98c6e4241c9b99a36539f41929456
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 28 Jul 2017 11:57:07 +0000 (13:57 +0200)]
Allow disabling sorting through `-u 0`
Change-Id: I56520ea70e03aebc736cf971ef50bfec6d1a4c5b
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 31 Jul 2017 09:30:05 +0000 (11:30 +0200)]
Refactor the sorting vector structure
* move global parameters into the structure
* use standard names: begin, end, size
Change-Id: I009ea2336b95fd053a82017130bf334806dbf2a5
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Fri, 4 Aug 2017 09:17:17 +0000 (09:17 +0000)]
Merge "Add Android logger backend configuration file." into tizen
Karol Lewandowski [Thu, 3 Aug 2017 11:54:30 +0000 (11:54 +0000)]
Merge "svace: fix logical error" into tizen
Michal Bloch [Fri, 28 Jul 2017 11:53:01 +0000 (13:53 +0200)]
Fix sorting timeout reverting to default value
After the first force-flush, the timeout would always revert
to the default value (1000ms) regardless of what the config said.
Change-Id: Ia39414a0192c259760d8fa87a7dc7ce0f3f91f87
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 28 Jul 2017 11:45:27 +0000 (13:45 +0200)]
Refactor sort parameter handling
* use `log_config_get_int` instead of manual parsing
* move in front of the `getopt` loop for override priority
Change-Id: I426be11b053f815a601930974dbb74988d27cb35
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
sanghyeok.oh [Wed, 2 Aug 2017 06:20:27 +0000 (15:20 +0900)]
svace: fix logical error
Change-Id: I91094f33007d939440e9b886828167cc47809735
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
scott park [Thu, 22 Jun 2017 03:51:37 +0000 (12:51 +0900)]
Add Android logger backend configuration file.
Change-Id: Ic01023d1bd1550a4f1ab7d74c9d9f5dc63014271
Signed-off-by: Scott Park <scott.park@dignsys.com>
Michal Bloch [Mon, 24 Jul 2017 08:16:20 +0000 (10:16 +0200)]
dlogutil --dumpfile: print error reason on failure
Change-Id: I999971b0bcbe23b160d158230de143f092a1e7dd
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 27 Jul 2017 10:44:50 +0000 (12:44 +0200)]
dlog binary file header format: standarize
Made sure both dlogutil and dlog_logger use the same format of this file.
Change-Id: Idd27f733454ba48a38c62927704ee64cf78c64a9
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 24 Jul 2017 08:12:07 +0000 (10:12 +0200)]
Exit dlogutil on any --dumpfile failure
Change-Id: I046871b0bcbe23b160d158230de143f092a1e7dd
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 24 Jul 2017 13:30:40 +0000 (15:30 +0200)]
dlogutil: free resources on exit
Change-Id: I9756272b5614e352dc611ae362022c2bab5f3aee
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 12 Jul 2017 13:55:12 +0000 (15:55 +0200)]
Util flushing fix
When the sorting buffer is empty, only flush as many logs as needed
to make room for incoming ones. Previously the entire buffer would be
flushed, which was both a performance problem (the program would hang
and not read data while flushing) and a reduction of sort quality (as
recent logs were flushed as well).
Change-Id: I1b10c7286ab28e70438b82d60d69fad6c4f38df3
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Rafal Pietruch [Thu, 27 Jul 2017 14:44:18 +0000 (14:44 +0000)]
Merge "Refactor vector operations into functions" into tizen
Rafal Pietruch [Thu, 27 Jul 2017 14:43:36 +0000 (14:43 +0000)]
Merge "dlogutil: refactor some globals into locals" into tizen
Michal Bloch [Wed, 26 Jul 2017 11:15:44 +0000 (13:15 +0200)]
Refactor vector operations into functions
Change-Id: I604bfdda6a8eeaf60dd5e0f58dfd01f86a77790b
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 25 Jul 2017 12:19:45 +0000 (14:19 +0200)]
dlogutil: refactor some globals into locals
Change-Id: Ida805b499e63c65d01c34fc338d73b60e2a4936a
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Thu, 20 Jul 2017 12:46:31 +0000 (12:46 +0000)]
Merge "Fixes to binary log files" into tizen
Michal Bloch [Fri, 14 Jul 2017 12:21:51 +0000 (14:21 +0200)]
Fixes to binary log files
* fixed missing header in some circumstances
* dlogutil no longer hangs whe reading those
* made sure both the daemon and dlogutil use the same magic check constant
Change-Id: If4ae5e5fb255d6cab681a5e7785106925f19045c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Fri, 14 Jul 2017 10:42:10 +0000 (12:42 +0200)]
Use internal version of sd-daemon and drop libsystemd dependency
Needed due to external request for systemd to be able to log directly to dlog.
This change avoids creation of cyclic dependency that would be created in
that case.
Change-Id: I9c779f263e92f4f84b825d20e263296400fcbf05
Karol Lewandowski [Fri, 14 Jul 2017 10:36:34 +0000 (12:36 +0200)]
Import sd-daemon from systemd
This commit import sd-daemon.[ch] directly from systemd,
commit
09812eb764b440651f3ff4cb5d37bd343f800560.
Change-Id: I9e4ea41da2218ba9ba8b02dceac41ed3ad3dda20
Rafal Pietruch [Tue, 4 Jul 2017 10:32:30 +0000 (10:32 +0000)]
Merge "send/recv pipe fd refactored" into tizen
projects / platform / core / system / dlog.git / log