Taehyub Kim [Mon, 7 Oct 2019 12:18:55 +0000 (21:18 +0900)]
elc_popup: modified theme set logic correctly when button is removed
Change-Id: Iae86c4d72425e33e1b32946d219de600bae6d86e
WooHyun Jung [Mon, 7 Oct 2019 07:15:45 +0000 (16:15 +0900)]
edje_util: restore tizen only APIs to legacy edje_util
Several tizen only APIs should not be opened with new efl interface.
This patch restores them to the original location(i.e edje_util).
Plus, Edje_Cursor is also restored back to Edje_Common.h
@tizen_fix
Change-Id: I3a2b0a96256bfe73e81cb482a9591529af95d5a2
Shinwoo Kim [Fri, 4 Oct 2019 01:42:38 +0000 (10:42 +0900)]
ecore_evas: handle async render for output transform
The commit e50628d "ecore_evas: support output transform" did not take care of
async render. So following issue occured.
[Issue]
At _evas_outbuf_idle_flush which could be called by,
_ecore_evas_wl_common_rotate_update -> _rotation_do -> evas_engine_info_set
-> efl_canvas_output_engine_info_set -> eng_output_update
-> eng_output_resize -> _evas_outbuf_reconfigure -> _evas_outbuf_idle_flush
if Outbuf->priv.onebuf is not NULL, we drop RGBA_Image->cache_entry.
But this means that there is a draw command in evas_thread_cmd queue.
So it could be possible a thread could access RGBA_Image->image.data after it
is set to NULL by _evas_outbuf_idle_flush which is calling
_evas_cache_image_entry_delete -> _evas_common_rgba_image_surface_delete
[Solution]
This patch makes _ecore_evas_wl_common_rotate_update wait for the end of
queued draw command running on a thread before calling _rotation_do.
*tizen_fix
Change-Id: Ia7d5eea2bfae9e64443f2b093e3613cf492e743f
Wonki Kim [Fri, 4 Oct 2019 02:23:35 +0000 (11:23 +0900)]
eina: turn magic check on for eina_list
after disabling eina_magic_check,
a issue that is hard to tracable comes.
this patch re-enables eina_magic check temporally until the issue gets fixed
Change-Id: I7a280d48b68f4c5d8e22cb63fca76cf165ee2439
Jongmin Lee [Sun, 6 Oct 2019 21:32:13 +0000 (06:32 +0900)]
build - remove evas-modules option
@tizen_fix
Change-Id: I534de0cb67f6add0159c4ffee1049d44f5f7f8ff
Carsten Haitzler (Rasterman) [Sat, 5 Oct 2019 19:00:38 +0000 (20:00 +0100)]
build - efl run in tree - make exception for image loaders/savers
due to meson's insistence on naming even moudles libmodule.so, and our
complexity of build as in the previous commits ... have a special case
for in tree module loading for these.
Carsten Haitzler (Rasterman) [Sat, 5 Oct 2019 17:35:00 +0000 (18:35 +0100)]
build - images loaders and saver modules need to link to evas
if your platform is picky enough it won't want to leave unresolved
symbols (which wshould be resovled at runtime from the host lib) so we
need to link these modules to evas. the problem is due to the
complicated build of some modules being static and some shared, evas
is declared with evas_goal and this has to be declared after static
modules are declared but since i was declaring static and shared at
the same time from a table this breaks. so i have to move all the
static and shared module stuff into evas_goal into 2 phases. one phase
for the static and one for the shared after evas is delcared so evas
as a target exists to link to.
Carsten Haitzler (Rasterman) [Sat, 5 Oct 2019 12:14:39 +0000 (13:14 +0100)]
build - bring back loaders and savers as modules and/or static
so the evas modules able to be static or not was a bit pointless as it
could inline all evas modules (or none) not just the most common or
not, but ecore evas modules were still modules, so it really wasn't
being useful.
image loaders ans savers omn the other hand were *ALL* being
statically built in without exception. this was kind of a regression
in the build system in the move to meson. some were static due to
micro optimizations and performance inlining the most common to save a
little extra loading + linking + page fragmentation for loaders you
are likely to need in most cases as well as save the drity pages from
linking in their dependencies (libgif, libtiff, libwebp and all their
dependencies too etc. etc.). this now brings back the ability to
decide which are static and which are shared modules (not exposed to
the user as options for meson - fixed in meson.build files which i
think is good enough given the purpose of this).
Dave Andreoli [Sat, 5 Oct 2019 10:20:44 +0000 (12:20 +0200)]
Pyolian gendoc: the last hidden bits of documentation ref tokens
Now links works also inside documentation text \o/
Dave Andreoli [Sat, 5 Oct 2019 08:30:34 +0000 (10:30 +0200)]
Pyolian gendoc: highlight classes in beta state
Dave Andreoli [Sat, 5 Oct 2019 07:32:35 +0000 (09:32 +0200)]
Pyolian gendoc: more links to types
need to fix links to Eina types and basic types
Lauro Moura [Thu, 3 Oct 2019 23:52:25 +0000 (20:52 -0300)]
csharp: Move locks inside AddRemove native handlers
Summary:
Instead of using a lock block in every method definition, we just need
them inside the actual methods adding/removing the handlers.
Kudos to @herb for the suggestion.
Reviewers: felipealmeida, herb, brunobelo
Reviewed By: brunobelo
Subscribers: cedric, #reviewers, herb, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9758
Carsten Haitzler (Rasterman) [Fri, 4 Oct 2019 12:16:02 +0000 (13:16 +0100)]
build - remove evas-modules option as its rather pointless
evas-modules affects evas engine modules if they are static or shared,
but ecore evas modules are still modules... so all in all this doesnt
help much as it still requires modules to be separate from the shared
libs, thus disallowing for statically linking efl into an app anyway
etc. etc. etc. ... so less options to deal with, less complexity.
better.
Stefan Schmidt [Wed, 2 Oct 2019 14:25:03 +0000 (16:25 +0200)]
efl_ui_video: bring back Elm_video doxygen group for docs
This group got lost at some point and resulted in broken link in our
doxygen documentation.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10273
Stefan Schmidt [Wed, 2 Oct 2019 12:56:22 +0000 (14:56 +0200)]
docs: fix elementary group name in docs
Use aliase for group name for a better look.
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D10271
Bruno da Silva Belo [Fri, 4 Oct 2019 06:46:29 +0000 (08:46 +0200)]
csharp: Standardizing doc tag.
Reviewers: felipealmeida, brunobelo, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10280
JunsuChoi [Fri, 4 Oct 2019 01:05:45 +0000 (10:05 +0900)]
efl_ui_animation_view : Put @beta on Efl.Ui.Animation_View_State
Summary: Efl.Ui.Animation_View class still in beta state.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10268
Dave Andreoli [Thu, 3 Oct 2019 20:40:16 +0000 (22:40 +0200)]
Pyolian gendoc: make links to functions actually work
Dave Andreoli [Thu, 3 Oct 2019 18:18:54 +0000 (20:18 +0200)]
Pyolian gendoc: unbreak after recent eolian changes
shiny new generated documentation can be seen at:
www.gurumeditation.it/dokuwiki_efl/
Mike Blumenkrantz [Thu, 3 Oct 2019 12:01:35 +0000 (14:01 +0200)]
doc: improve colorselector preview
Summary:
this has always been broken, it was just never noticed because colorselector
was broken
@fix
ref T8304
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8304
Differential Revision: https://phab.enlightenment.org/D10278
Cedric BAIL [Thu, 3 Oct 2019 02:28:38 +0000 (23:28 -0300)]
elementary: always use a font that matches our expectation for our test instead of the system one.
Summary:
Our tests do rely on the font to have certain characteristic so that they have the value and the
item size being calculated is the one we expect. As it is quite hard to support an infinite number
of font with random size, it is easier to embed one we can rely on for our test. I have copied Vera
from Expedite and changed evas global font path to look for it first. After this patch, even with an
incompatible font in the system, it does still pass all tests. This add around 400KB of data to our
git, but is necessary for a reliable tests suite.
@fix
T8277
Reviewers: lauromoura, zmike, bu5hm4n
Reviewed By: zmike
Subscribers: #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8277
Differential Revision: https://phab.enlightenment.org/D10276
Marcel Hollerbach [Wed, 2 Oct 2019 17:03:58 +0000 (19:03 +0200)]
meson: pass correct PACKAGE_DATA_DIR
Summary:
PACKAGE_DATA_DIR was set to the build dir instead to the elementary
specific data dir.
ref T8304
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8304
Differential Revision: https://phab.enlightenment.org/D10275
Mike Blumenkrantz [Wed, 2 Oct 2019 15:52:41 +0000 (17:52 +0200)]
efl_ui/bg: unset finger_size multiplier during construction
Summary:
this is not a clickable widget, so it shouldn't use finger size
ref T8304
@fix
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8304
Differential Revision: https://phab.enlightenment.org/D10274
Marcel Hollerbach [Wed, 2 Oct 2019 15:05:36 +0000 (17:05 +0200)]
elm: add basics test to create a destroy *every* widget with errors
Summary:
this simply creates packs, resizes, and destroys every single widget
that we have in legacy elm.
This i made to ensure that there are no mistakes in the construction
chain. Additionally, a second test case checks that creation with none
elm parents is erroring but not failing, this seems weird, but we have
provided that in the past, so we should continue providing this.
Reviewers: zmike, segfaultxavi
Reviewed By: zmike, segfaultxavi
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10088
Xavi Artigas [Wed, 2 Oct 2019 14:37:33 +0000 (16:37 +0200)]
evas: silence compiler warning in textblock
Uninitialized variable.
Mike Blumenkrantz [Wed, 2 Oct 2019 10:13:10 +0000 (12:13 +0200)]
edje/edit: add api for checking 'required' property of parts
Summary: this is useful for verifying api compliance
Reviewers: cedric
Reviewed By: cedric
Subscribers: segfaultxavi, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10055
Yeongjong Lee [Wed, 2 Oct 2019 10:04:12 +0000 (12:04 +0200)]
efl_gfx_arrangement: change content_padding param type and remove scalable
Summary:
This change `content_padding` parameter type to int from double for consistency
of size properties.
`scalable` should be handled in more common size API.
Co-authored-by: Mike Blumenkrantz <zmike@samsung.com>
ref T7864
Test Plan: ninja test
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T7864
Differential Revision: https://phab.enlightenment.org/D10154
Bruno da Silva Belo [Wed, 2 Oct 2019 10:01:25 +0000 (12:01 +0200)]
csharp: More updated docs to 1.23.
Summary: eina_config and eina_common updated to 1.23.
Reviewers: lauromoura, felipealmeida, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10263
Xavi Artigas [Wed, 2 Oct 2019 09:31:19 +0000 (11:31 +0200)]
docs: Fix problems with monospaced text
Eolian recently added support for $[...] which allows highlighting
more than one word in monospaced text.
Stefan Schmidt [Wed, 2 Oct 2019 08:18:16 +0000 (10:18 +0200)]
docs: enable compression for tar file and avoid file name clash
Summary:
While the target name implies a compression we only ever put this all
into a tar archive so far. Using xz compression as we do with our source
archives.
Also adjust the file naming to avoid clashing with the source tarballs.
We used -doc with autotools before, so this is really more of a catchup.
Reviewers: bu5hm4n, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: ProhtMeyhet, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10266
Felipe Magno de Almeida [Wed, 2 Oct 2019 07:55:24 +0000 (09:55 +0200)]
elementary: Add documentatio to efl_ui_layout_factory.eo
Summary:
Documentation was very sparse and actually empty in some places. Add proper documentation
Related to T7717
Reviewers: woohyun, cedric, SanghyeonLee, lauromoura, brunobelo, myoungwoon, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: segfaultxavi, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10267
JunsuChoi [Wed, 2 Oct 2019 05:32:33 +0000 (14:32 +0900)]
elementary_test: Add the value provider test for animation_view
Summary:
Add an Value Provider item to test vector animation on elementary_test.
This test is to apply Efl.Gfx.Vg.Value_Provider to the loaded efl_ui_animation object.
If Evas Vg Json(Lottie) Loader is not supported,
use the vector class to output the svg file.
Depends on D9874
Depends on D9897
Test Plan: elementary_test -> Value Provider
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #committers, #reviewers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10015
Change-Id: I37d6cd8ce54d413bdbee5146f0b391a61c0c476b
JunsuChoi [Wed, 2 Oct 2019 05:30:06 +0000 (14:30 +0900)]
vg_common_json: Override value_provider list
Summary:
If value_provider is applied to Efl.Ui.Animation_View, it is passed as vector object.
The passed value_provider list passes to Vg_File_Data.
If there is a value_Provider list in Vg_File_Data,
it apply the property to Lottie_Animation using lottie_animation_property_override api.
Depends on D9874
Test Plan:
...
Eo *vp = efl_add(EFL_GFX_VG_VALUE_PROVIDER_CLASS, p);
efl_gfx_vg_value_provider_keypath_set(vp, "**");
efl_gfx_vg_value_provider_fill_color_set(vp, 100, 0 ,0 ,255);
efl_ui_animation_view_value_provider_override(anim_view, vp);
vp = efl_add(EFL_GFX_VG_VALUE_PROVIDER_CLASS, p);
efl_gfx_vg_value_provider_keypath_set(vp, "**");
efl_gfx_vg_value_provider_stroke_width_set(vp, 50.0);
efl_gfx_vg_value_provider_stroke_color_set(vp, 0, 255, 0, 100);
efl_ui_animation_view_value_provider_override(anim_view, vp);
...
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9897
JunsuChoi [Wed, 2 Oct 2019 04:21:35 +0000 (13:21 +0900)]
Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View
Summary:
Efl.Gfx.Vg.Value_Provider is an object for integrating and managing the properties of vector objects.
These values are dependent on the keypath.
Keypath is the target a specific content or a set of contents that will be updated.
It can include the specific name of the contents, wildcard(*) or Globstar(**).
The valueProvider is borrowed from another library that uses a vector object of type json, such as Efl.Ui.Animation_View
(https://github.com/airbnb/lottie-ios/blob/
5fc0e59e0cb85d3586b1d0d1cf4a2c9669b91d15/lottie-swift/src/Public/iOS/AnimatedControl.swift#L50)
This feature should be used with some patches that apply to the vg json loader and Efl.Canvas.Vg.Object.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9874
Hermet Park [Wed, 2 Oct 2019 02:43:32 +0000 (11:43 +0900)]
Revert "evas map: diable high quality texture mapping feature."
This reverts commit
37870505157d252c057de3910e854ac5650865d6.
This patch should go on.
JunsuChoi [Wed, 2 Oct 2019 05:32:33 +0000 (14:32 +0900)]
elementary_test: Add the value provider test for animation_view
Summary:
Add an Value Provider item to test vector animation on elementary_test.
This test is to apply Efl.Gfx.Vg.Value_Provider to the loaded efl_ui_animation object.
If Evas Vg Json(Lottie) Loader is not supported,
use the vector class to output the svg file.
Depends on D9874
Depends on D9897
Test Plan: elementary_test -> Value Provider
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #committers, #reviewers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10015
Change-Id: Ide01f099e395eed3e9c6445681b327eaa69f1115
JunsuChoi [Wed, 2 Oct 2019 05:30:06 +0000 (14:30 +0900)]
vg_common_json: Override value_provider list
Summary:
If value_provider is applied to Efl.Ui.Animation_View, it is passed as vector object.
The passed value_provider list passes to Vg_File_Data.
If there is a value_Provider list in Vg_File_Data,
it apply the property to Lottie_Animation using lottie_animation_property_override api.
Depends on D9874
Test Plan:
...
Eo *vp = efl_add(EFL_GFX_VG_VALUE_PROVIDER_CLASS, p);
efl_gfx_vg_value_provider_keypath_set(vp, "**");
efl_gfx_vg_value_provider_fill_color_set(vp, 100, 0 ,0 ,255);
efl_ui_animation_view_value_provider_override(anim_view, vp);
vp = efl_add(EFL_GFX_VG_VALUE_PROVIDER_CLASS, p);
efl_gfx_vg_value_provider_keypath_set(vp, "**");
efl_gfx_vg_value_provider_stroke_width_set(vp, 50.0);
efl_gfx_vg_value_provider_stroke_color_set(vp, 0, 255, 0, 100);
efl_ui_animation_view_value_provider_override(anim_view, vp);
...
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9897
Change-Id: I1c9a257e86e54dc5fc5df5d0ced7a826e492cbaa
JunsuChoi [Wed, 2 Oct 2019 04:21:35 +0000 (13:21 +0900)]
Efl.Gfx.Vg.Value_Provider: Introduce property change feature of Efl.Ui.Animation_View
Summary:
Efl.Gfx.Vg.Value_Provider is an object for integrating and managing the properties of vector objects.
These values are dependent on the keypath.
Keypath is the target a specific content or a set of contents that will be updated.
It can include the specific name of the contents, wildcard(*) or Globstar(**).
The valueProvider is borrowed from another library that uses a vector object of type json, such as Efl.Ui.Animation_View
(https://github.com/airbnb/lottie-ios/blob/
5fc0e59e0cb85d3586b1d0d1cf4a2c9669b91d15/lottie-swift/src/Public/iOS/AnimatedControl.swift#L50)
This feature should be used with some patches that apply to the vg json loader and Efl.Canvas.Vg.Object.
Test Plan: N/A
Reviewers: Hermet, kimcinoo, smohanty
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9874
Change-Id: I2c8423fefecd12da81066943aeba4d7dc883e80f
Hosang Kim [Wed, 2 Oct 2019 04:58:59 +0000 (13:58 +0900)]
elm_conformant: delete ELM_LAYOUT_MIXIN
Once the min size grows, it can't shrink even if recalcuate it.
@tizen_only
Change-Id: Ia865ba248cf7211ebd4d1e1ab0bcabd8b9ac1008
Jongmin Lee [Tue, 1 Oct 2019 21:21:24 +0000 (06:21 +0900)]
build: resolve migration error
Change-Id: Id79c174dea98628d90fec779ecf50a479eeb83c1
Stefan Schmidt [Tue, 1 Oct 2019 15:24:26 +0000 (17:24 +0200)]
build: switch back to plain mode, release is over
Another forgotten detail. Need to switch back to plain mode now that we
are out of freeze again.
Stefan Schmidt [Tue, 1 Oct 2019 14:22:28 +0000 (16:22 +0200)]
NEWS: cleanup file which had an additional copy of news for 1.22
At some point during the 1.22 release we messed this file up and had an
additional summary of fixes and features. While looking over the file I
also fixed two other small style problems.
Marcel Hollerbach [Tue, 1 Oct 2019 12:57:04 +0000 (09:57 -0300)]
meson: support mono bindings building without cxx
Summary:
the mono bindings do depend partitially on the cxx bindings, eina_cxx
and eolian_cxx are needed, nothing more. With this commit you can build
mono without cxx.
fixes T8292
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8292
Differential Revision: https://phab.enlightenment.org/D10264
Stefan Schmidt [Tue, 1 Oct 2019 10:13:56 +0000 (12:13 +0200)]
build: open up development again
Freeze is over, you are free to go wild. :-)
Stefan Schmidt [Tue, 1 Oct 2019 09:41:41 +0000 (11:41 +0200)]
release: Update NEWS and bump version for 1.23.0 release
Marcel Hollerbach [Tue, 1 Oct 2019 09:27:58 +0000 (11:27 +0200)]
docs: do not crash gengrid widget preview
item class is not initialized to 0. This can crash gengrid later on.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10261
Felipe Magno de Almeida [Tue, 1 Oct 2019 03:06:13 +0000 (00:06 -0300)]
csharp: Load library in permanent way for static members and not rely on leaks
Summary:
The LoadFunctionPointer relied on leaks of NativeModules by not
disposing them. Instead do direct loading without instantiating
unnecessary objects.
Reviewers: lauromoura, woohyun, brunobelo
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10258
Lauro Moura [Tue, 1 Oct 2019 03:03:42 +0000 (00:03 -0300)]
csharp: Add missing since docs to a bunch of classes.
Summary:
Proper documentation will come in later commits.
ref T8293
Reviewers: woohyun, felipealmeida, segfaultxavi, brunobelo
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10260
Bruno da Silva Belo [Tue, 1 Oct 2019 02:23:33 +0000 (23:23 -0300)]
csharp: add since 1.23 to eina_accessor.
Summary: updating to since 1.23.
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10257
Bruno da Silva Belo [Tue, 1 Oct 2019 02:14:46 +0000 (23:14 -0300)]
mono_docs:adding and updating eina_binbuf.cs.
Summary: Generating docs and setting to 1.23.
Reviewers: lauromoura, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10252
Bruno da Silva Belo [Tue, 1 Oct 2019 02:13:07 +0000 (23:13 -0300)]
mono-docs: adding and updating docs for eina_array.
Summary: Generating docs and setting to 1.23 for eina_array.cs
Reviewers: lauromoura, felipealmeida
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10251
Lauro Moura [Tue, 1 Oct 2019 02:10:40 +0000 (23:10 -0300)]
csharp: Document Eina.List
Summary:
Also added Since 1.23 info
Depends on D10253o
ref T8293
Test Plan: Check docs
Reviewers: segfaultxavi, brunobelo, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10254
Lauro Moura [Tue, 1 Oct 2019 02:08:44 +0000 (23:08 -0300)]
csharp: Allow improved cbs in eina comparators
Summary:
Instead of receiving a callback that compares two intptrs (which is
still used internally), expose a more C#-friendly delegate which is
wrapped into the native one.
Test Plan: run test suite
Reviewers: felipealmeida, segfaultxavi, brunobelo
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10253
Lauro Moura [Tue, 1 Oct 2019 02:05:36 +0000 (23:05 -0300)]
csharp: Document Eina.Log
Summary: ref T8293
Reviewers: brunobelo, segfaultxavi, felipealmeida
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10255
Lauro Moura [Tue, 1 Oct 2019 02:03:51 +0000 (23:03 -0300)]
csharp: Add since to Eina.Promise
Summary: ref T8293
Reviewers: segfaultxavi, felipealmeida, brunobelo
Reviewed By: felipealmeida
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8293
Differential Revision: https://phab.enlightenment.org/D10256
Jaehyun Cho [Tue, 19 Jun 2018 06:41:49 +0000 (15:41 +0900)]
elm_slider: do not clip indicator to slider
By calling evas_object_smart_member_add(), indicator is clipped to slider.
To keep backward compatibility, indicator should not be clipped to slider.
Change-Id: I625413f65641afa0a415776402749f88d7b88338
Wonki Kim [Tue, 1 Oct 2019 09:35:44 +0000 (18:35 +0900)]
ecore: fix improper usage of sizeof keyword
sizeof operator is applied to the address of a variable.
this patch removes & operater.
Change-Id: I46772c52bf916cd4c007fcd81af4cd91f223d158
Jongmin Lee [Mon, 30 Sep 2019 23:48:56 +0000 (08:48 +0900)]
build: resolve migration build error
Change-Id: I0be6fbd7a8d9169271e9631f9ae93676657090a8
Carsten Haitzler (Rasterman) [Mon, 30 Sep 2019 21:06:07 +0000 (22:06 +0100)]
evas - gl_drm - handle modifiers for drm formats
this was/is breaking e on rpi4 as modifiers are used to pass tiling
info it seems. we had no support thus leaving garbage in buffers. this
fixes that.
Daniel Kolesa [Mon, 30 Sep 2019 17:45:45 +0000 (19:45 +0200)]
efl: add code to enforce presence of @since tags
This is not yet enabled because there's too many instances where
this is broken.
Ref T7704
Xavi Artigas [Mon, 30 Sep 2019 17:48:19 +0000 (19:48 +0200)]
Revert "eolian: disallow missing docs for stable API where necessary"
I'm afraid but this breaks the mono bindings too close to a release.
This also fixes the missing docs errors by adding a lot of inconsistent
placeholder text ("No description supplied.", "TBD") which will make
finding them later on more complicated.
I was the one that asked for this feature but it is not critical at this
point, so I suggest we explore some refinements (like T8291) before landing
this patch in its current state.
This reverts commit
2946cb3c325f27d77354ac1b83b614e3a1d9e1d5.
Daniel Kolesa [Mon, 30 Sep 2019 15:01:31 +0000 (17:01 +0200)]
eolian: disallow missing docs for stable API where necessary
The things that require docs include classes, variables, typedecls,
events and methods/properties. Implements, params, returns, parts
and struct/enum fields don't require them.
Empty/whitespace only string does not count as documentation.
Xavi Artigas [Mon, 30 Sep 2019 16:05:07 +0000 (18:05 +0200)]
mono-docs: Formatting of @since tags
Use a line break <br/> now that we can properly escape these things.
Previously we appended (Since EFL X.XX) which didn't look very nice.
Marcel Hollerbach [Mon, 30 Sep 2019 15:03:01 +0000 (17:03 +0200)]
efl_canvas_animation_player: improve docs
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10250
Lauro Moura [Mon, 30 Sep 2019 13:38:55 +0000 (15:38 +0200)]
eolian-cxx: Release iterators
Summary:
When the iterators advanced, the CXX wrappers null'd them but did not
call eina_value_free.
ref T8280
Reviewers: q66, brunobelo, felipealmeida
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8280
Differential Revision: https://phab.enlightenment.org/D10238
Lauro Moura [Mon, 30 Sep 2019 13:38:34 +0000 (15:38 +0200)]
bindings: Fix disposal of eolian state
Summary:
It was actually leaking before. Let's use some RAII classes that were
already there.
ref T8280
Reviewers: q66, felipealmeida, brunobelo
Reviewed By: q66
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8280
Differential Revision: https://phab.enlightenment.org/D10237
Xavi Artigas [Mon, 30 Sep 2019 13:26:17 +0000 (10:26 -0300)]
mono-docs: Add some missing docs for workaround.cs
Test Plan: Only docs changed.
Reviewers: lauromoura
Reviewed By: lauromoura
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10249
Jaehyun Cho [Mon, 30 Sep 2019 11:21:41 +0000 (07:21 -0400)]
theme: remove duplicated version 119
Summary: Since the current version is 123, duplicated version 119 is removed.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10248
Daniel Kolesa [Mon, 30 Sep 2019 09:28:32 +0000 (11:28 +0200)]
eolian: fix potential ABI violation in expr serialization
While this may seem safe, and likely is on any 64-bit system,
it may not be entirely well defined. And in this case we should
not have to worry about copying.
Maybe fixes T8276...
Mike Blumenkrantz [Thu, 26 Sep 2019 18:10:39 +0000 (14:10 -0400)]
tests/position_manager: initialize variable in declaration
CID 1404756, 1404747
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10202
Marcel Hollerbach [Fri, 27 Sep 2019 14:33:35 +0000 (16:33 +0200)]
elm_code_widget: when the position is updated, set new geom to cursor
in order to do that, we need to ensure that the internal box is
calculated, otherwise the position is still not updated correctly.
This fixes wrong cursor positions in edi.
fixes T8214
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10225
Marcel Hollerbach [Fri, 27 Sep 2019 14:32:25 +0000 (16:32 +0200)]
elm_code_widget: initialize these vars correctly
otherwise we are setting a cursor from time to time at a uninitialized
position. Which causes disappeared cursors
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10224
Mike Blumenkrantz [Tue, 10 Sep 2019 17:31:13 +0000 (13:31 -0400)]
Revert "eo beta - mark task, io classes as beta because they are..."
This reverts commit
5455a2dcf7ded4e0fe91c0a6b734998278de8fe8.
these classes were explicitly stabilized for 1.22
see T7599, T7600, T7601
Reviewed-by: Cedric BAIL <cedric.bail@free.fr>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D9901
Bruno da Silva Belo [Thu, 26 Sep 2019 21:49:00 +0000 (21:49 +0000)]
Updating README for clang requirements.
OpenMP needs to be installed in system to sucessfully compile with
clang, needs libomp, while gcc use his version, libgomp.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10213
Marcel Hollerbach [Fri, 27 Sep 2019 14:31:47 +0000 (16:31 +0200)]
test_code: do not create a background by hand
the background here was wrong, it hasnt resizable hints, which means
that the whole object cannot be resized.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10223
Mike Blumenkrantz [Fri, 27 Sep 2019 15:08:05 +0000 (11:08 -0400)]
efl_ui: remove legacy component includes, include Efl_Layout.h and Efl_Canvas.h
this header shouldn't include any legacy headers whatsoever
fix T8274
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10236
Mike Blumenkrantz [Fri, 27 Sep 2019 15:07:17 +0000 (11:07 -0400)]
efl_ui: remove efl_ui_text headers from Efl_Ui.h for now
these require legacy types and headers, which should not be brought into
this header
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10235
Mike Blumenkrantz [Fri, 27 Sep 2019 17:46:08 +0000 (13:46 -0400)]
benchmark/collection: add Elementary.h
this uses legacy api
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10234
Mike Blumenkrantz [Fri, 27 Sep 2019 15:06:21 +0000 (11:06 -0400)]
tests/spin_button: include Elementary.h since this uses legacy api
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10233
Mike Blumenkrantz [Fri, 27 Sep 2019 15:06:05 +0000 (11:06 -0400)]
tests/spec: use eo types here since this isn't supposed to use legacy
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10232
Mike Blumenkrantz [Fri, 27 Sep 2019 15:05:24 +0000 (11:05 -0400)]
efl_ui: explicitly include eo headers for a couple types
the general headers here pull in legacy headers, which is bad
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10231
Mike Blumenkrantz [Fri, 27 Sep 2019 15:04:38 +0000 (11:04 -0400)]
elm_test/radio: use eo type here
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10230
Mike Blumenkrantz [Fri, 27 Sep 2019 14:27:05 +0000 (10:27 -0400)]
edje: add Efl_Layout.h for eo-based layout headers
this includes all related headers
ref T8274
Additional Authors: Lauro Moura <lauromoura@expertisesolutions.com.br>
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10228
Mike Blumenkrantz [Fri, 27 Sep 2019 14:26:27 +0000 (10:26 -0400)]
edje: rename edje_types.eot to efl_canvas_types.eot and move include
this has no relation to legacy and should not be included in legacy headers
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10227
Mike Blumenkrantz [Fri, 27 Sep 2019 14:06:30 +0000 (10:06 -0400)]
efl/canvas: add Efl_Canvas.h
this includes all the efl.canvas headers and adds some compilation tests
for the header to the unit test suite
ref T8274
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10226
Hermet Park [Mon, 30 Sep 2019 07:53:29 +0000 (16:53 +0900)]
evas map: diable high quality texture mapping feature.
This is a little bit buggy, need to make it stablize further.
Temporarily diable this for 1.23 release.
Jaehyun Cho [Mon, 30 Sep 2019 07:19:31 +0000 (07:19 +0000)]
theme: port to efl.ui.clickable and use macro for anchor style
This patch applies the following commits to anchor style.
bb1388798b1afaced65484cedf385a93f6b1bb6a
122ca2fa2f9290729e10715253e45f0ad343e09a
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10247
Jaehyun Cho [Mon, 30 Sep 2019 06:51:31 +0000 (15:51 +0900)]
eolian_mono: support beta for enum if mono-beta is enabled
Summary: this generates beta enum with `-Dmono-beta=true`.
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=true
Reviewers: lauromoura, YOhoho
Reviewed By: YOhoho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10246
Yeongjong Lee [Mon, 30 Sep 2019 04:52:45 +0000 (13:52 +0900)]
eolian_mono: Respect beta for enum
Summary: this prevent generating beta enum with `-Dmono-beta=false`.
Test Plan: meson setup -Dbindings=mono,cxx -Dmono-beta=false
Reviewers: lauromoura, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10245
Hosang Kim [Mon, 8 Jul 2019 11:53:28 +0000 (20:53 +0900)]
evas_event: fix proxy event is not passed through
Change-Id: I1e56af96688a9f9f05b703f21d8f8353174cfbce
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Jongmin Lee [Sun, 29 Sep 2019 21:49:05 +0000 (06:49 +0900)]
build: resolve build error during migration
Change-Id: I9b5d04334b51653fa691ee6f8733484d79c46b66
Dave Andreoli [Sun, 29 Sep 2019 09:29:38 +0000 (11:29 +0200)]
Pyolian: implemented eolian Error object
Dave Andreoli [Sun, 29 Sep 2019 08:19:11 +0000 (10:19 +0200)]
Pyolian: reformat code to make pycharm happy
and fix some typos in the code
Marcel Hollerbach [Sat, 28 Sep 2019 16:02:56 +0000 (18:02 +0200)]
elm_*: make scrolling correct again
in revision D9859 the scroll events have been renamed. However this also
renamed the legacy widgets, which also renamed the evas smart events,
which is a bug. With this commit we are back to plain old
evas_smart_callback_call calls, as these just take the string, and do
not need the bypassing through the eo events.
This fixes:
- elm_test gengrid,toolbar,panel (the events are now shown correctly
again)
- scrolling in elm_code_widget
- elm_map in a touchscreen
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D10240
Mike Blumenkrantz [Fri, 27 Sep 2019 18:34:32 +0000 (14:34 -0400)]
elm_test: undef logging macros before redefining them in header
Summary: Depends on D10228
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10229
Bruno da Silva Belo [Fri, 27 Sep 2019 15:07:37 +0000 (15:07 +0000)]
efl_ui_suite: Some pointers were being delete.
`efl_ui_smart_transition_lifetime` test causes segfault
when compile with `clang`.
Fixes half of T8277
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D10221
Xavi Artigas [Fri, 27 Sep 2019 12:42:27 +0000 (08:42 -0400)]
themes: Rename "dragable" to "draggable"
Summary:
"Dragable" is a misspelling:
https://en.wiktionary.org/wiki/dragable
We have it EVERYWHERE in EFL, even with jokes:
./src/lib/efl/interfaces/efl_ui_drag.eo:1
This patch only fixes the theme API so it does not get carved in stone for this release.
Depends on D10217
Test Plan: No functional changes.
Reviewers: zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10218
Jaehyun Cho [Fri, 27 Sep 2019 12:40:35 +0000 (08:40 -0400)]
theme: replace hbar and vbar to horizontal_bar and vertical_bar
Summary:
To make clear the meaning, hbar and vbar are replaced to horizontal_bar
and vertical_bar.
Reviewers: zmike, woohyun, segfaultxavi
Reviewed By: zmike, segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10217
Shinwoo Kim [Fri, 27 Sep 2019 06:30:36 +0000 (15:30 +0900)]
evas filter: Implement grayscale filter in pure GL
Summary:
Initial version implementing grayscale filter in pure GL.
This patch needs a logt of love as 5bce712 did.
Grasyscale formula:
https://www.tutorialspoint.com/dip/grayscale_to_rgb_conversion.htm
Test Plan:
1. Create filter_example with following .
efl_gfx_filter_program_set(image, "grayscale ()", "grayscale");
2. Run.
ELM_ACCEL=gl ./filter_example
Reviewers: Hermet, jsuya
Subscribers: ali.alzyod, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D9858
Cedric Bail [Fri, 27 Sep 2019 05:19:38 +0000 (14:19 +0900)]
evas: fix memory leak with Efl.Canvas.Vg
Summary:
It is not correct to change the parent and hope that refcount will work
for you. The parent chain is a decision made by the user, not something
a widget can touch. Only ref count are to be used when given an outside
object. As things where not triggering destruction, there was also no
point where the image buffer would be getting to zero and be freed. This
commit also fix this.
Reviewers: Hermet, zmike
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D10169