Shinwoo Kim [Fri, 10 Apr 2020 12:45:22 +0000 (08:45 -0400)]
evas: fix dereference after null check
Summary:
Static analysis tool reports passing a null pointer 'im->gc' to
_evas_gl_image_cache_add which directly dereferences it, so lets
be sure that 'im->gc' is valid before passing it to cache_add
Reviewers: Hermet, jsuya, herb, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11676
Change-Id: I19652a95320216c141a7b7acd64e1de5403107cc
Carsten Haitzler (Rasterman) [Sun, 12 Apr 2020 18:20:13 +0000 (19:20 +0100)]
fix buid on bsd
Carsten Haitzler (Rasterman) [Sun, 12 Apr 2020 17:30:36 +0000 (18:30 +0100)]
ecore con - clean up file lock andunlock on failed bind
didnt do this if bind failed... so do it now.
Carsten Haitzler (Rasterman) [Sun, 12 Apr 2020 12:21:56 +0000 (13:21 +0100)]
ecore-evas - x dnd/cnp - handle null data content and not segv
Shinwoo Kim [Fri, 10 Apr 2020 12:45:22 +0000 (08:45 -0400)]
evas: fix dereference after null check
Summary:
Static analysis tool reports passing a null pointer 'im->gc' to
_evas_gl_image_cache_add which directly dereferences it, so lets
be sure that 'im->gc' is valid before passing it to cache_add
Reviewers: Hermet, jsuya, herb, zmike
Reviewed By: zmike
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11676
Carsten Haitzler (Rasterman) [Thu, 9 Apr 2020 23:15:30 +0000 (01:15 +0200)]
efreetd - ensure on bsd where connects succed despite daemon being gone
just get it to work... getting unamused with this.
Carsten Haitzler (Rasterman) [Thu, 9 Apr 2020 19:45:57 +0000 (20:45 +0100)]
efreet - try less chaotic efreetd restart and delay 0.5-1.0 rand sec
try work on T8490
Alastair Poole [Thu, 9 Apr 2020 10:44:27 +0000 (11:44 +0100)]
tests: popup
I missed this warning on this machine apologies for the
unnecessary noise.
Alastair Poole [Thu, 9 Apr 2020 10:41:05 +0000 (11:41 +0100)]
tests: Add case to match ephoto behaviour.
Taehyub Kim [Thu, 9 Apr 2020 05:25:19 +0000 (14:25 +0900)]
popup: add safe code for notify position
when calculating scroller size, notify position y value is used.
If parent position of notify is changed, the position of notify should be recalculated
for calculating correct scroller size.
Change-Id: I58a4f51ab39ab13844a0354cff761b8dc237ffc4
Bartlomiej Grzelewski [Wed, 8 Apr 2020 14:54:50 +0000 (16:54 +0200)]
flipselector: returns invalid widget
Widget returned by flip selector does not contains
x,y coordinates.
Change-Id: Id9df8a683909403d3a8d7e02afb90f4ce8971038
Yeongjong Lee [Wed, 8 Apr 2020 10:53:17 +0000 (10:53 +0000)]
elm_dnd: null check for safety
Also, it needs to keep backward compatibility.
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11666
Stefan Schmidt [Wed, 8 Apr 2020 09:48:46 +0000 (11:48 +0200)]
release: Update NEWS and bump version for 1.24.0-beta1 release
Hermet Park [Tue, 7 Apr 2020 12:40:04 +0000 (21:40 +0900)]
wayland: don't resize the window if the size is zero at rotation.
Acoording to tizen wl specification,
client should resize the window at rotation only if the size is larger than zero.
Previously, partial window rotation was broken due to wrong understanding.
Change-Id: I269efd2bcfbbd198bdc5a5aa3d3355394a56304f
Godly Thekkethottiyil Alias [Tue, 7 Apr 2020 10:12:37 +0000 (15:42 +0530)]
[Genlist] Allow bottom margin to take size as per last item height in item align enabled case
Change-Id: I6fcc26556170fdfa4c25a119cd0b77fe2592583d
Signed-off-by: Godly Thekkethottiyil Alias <godly.talias@samsung.com>
HyukSoon Choi [Fri, 3 Apr 2020 00:48:40 +0000 (09:48 +0900)]
spinner - add some signal for haptic, changing value
Change-Id: I5509d2035dff6f228d675c496ac343da77dc5bc2
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
Shilpa Singh [Tue, 7 Apr 2020 11:23:46 +0000 (20:23 +0900)]
elm_entry, accessibility: Send utf8 text instead of markup to ATSPI client
Summary:
Markup text cannot be read as per expectation by a text to speech engine, hence send text
in UTF8 format
Test Plan: Test the text returned by connecting to object:text-changed:insert and object:text-changed:delete events in ATSPI-clients
Reviewers: kimcinoo
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11660
Marcel Hollerbach [Mon, 6 Apr 2020 10:37:40 +0000 (12:37 +0200)]
efl_ui_dnd: cleanup when backend failed to create dnd op
this is needed to not have a dead window on the screen.
Differential Revision: https://phab.enlightenment.org/D11654
Marcel Hollerbach [Mon, 6 Apr 2020 10:35:44 +0000 (12:35 +0200)]
ecore_evas_cocoa: be aware of NULL data
this will now result in the promise beeing rejected.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11653
Marcel Hollerbach [Mon, 6 Apr 2020 10:21:17 +0000 (12:21 +0200)]
meson: do no build upower on macos
this is just causing errors and nothing usefull, upower is not available
on macos.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11652
Marcel Hollerbach [Mon, 6 Apr 2020 09:50:34 +0000 (11:50 +0200)]
meson: build modules on macos as .so
this is needed in order to support ecore-evas loading of .so modules
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11651
Marcel Hollerbach [Mon, 6 Apr 2020 09:41:28 +0000 (11:41 +0200)]
meson: support unified suffixes for modules
A long story in a few words: sometimes on macos modules will be compiled
into .dylib, sometimes, into .so suffix. We did not set the suffix
everywhere in our meson build instructions, hence our suffixes have been
differently, which resulted in random load fails on different maschines.
With this commit, we ensure that we suffix all modules the same way.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11650
Mike Blumenkrantz [Mon, 6 Apr 2020 21:24:07 +0000 (17:24 -0400)]
ci: force system zlib on osx
osx doesn't ship a pkgconfig file for its own zlib, so now we're shipping
a pkgconfig file for their zlib to avoid future issues
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11661
Marcel Hollerbach [Mon, 6 Apr 2020 14:16:30 +0000 (16:16 +0200)]
evas: prepare for cur beeing NULL
debug name could be called during any time, even before the constructor,
of this super class is hit. So cur can be NULL here.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11659
Jaehyun Cho [Tue, 7 Apr 2020 05:05:50 +0000 (14:05 +0900)]
elementary: add @ingroup to open the APIs publicly
To open the following APIs publicly, the APIs are added to @ingroup.
- elm_object_scroll_back_to_top_enabled_set
- elm_object_scroll_back_to_top_enabled_get
- elm_object_scroll_back_to_top_cb_set
- elm_naviframe_item_push_from
@tizen_only
Change-Id: I58a615380dc110578df44ec3a191b1cafbd84e79
Myoungwoon Roy, Kim [Tue, 7 Apr 2020 05:04:45 +0000 (14:04 +0900)]
elm_win: ingroup new public elm_win_aux_msg... APIs
Change-Id: Idd4d9b991a199cd65fbb75ec675563892f3801dc
Marcel Hollerbach [Mon, 6 Apr 2020 23:44:17 +0000 (08:44 +0900)]
eo: only prepare a empty node
Summary:
do not take over complete vtables.
This might fix wrong vtable settings when a type is not in the
inheritance of another type, but the function is implemented.
Reviewers: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11657
Change-Id: I03c24758082cd28171979a035e3d75bfa106a954
Carsten Haitzler (Rasterman) [Mon, 6 Apr 2020 18:33:30 +0000 (19:33 +0100)]
elm icon/image efl ui image - respect aspect hints at all if set
these did not even look at aspect hints when calculating sizing. that
means any attempt to set them would lead to... nothing useful. this
handles horiz/vert/both cases (as best as is possible).
@fix
This reverts previous commit and fixes it in the box layout to respect
aspect in elm boxes. note - this probably needs doing in other
containers too like table...
Revert "elm icon/image efl ui image - respect aspect hints at all if set"
Carsten Haitzler (Rasterman) [Mon, 6 Apr 2020 11:38:33 +0000 (12:38 +0100)]
elm icon/image efl ui image - respect aspect hints at all if set
these did not even look at aspect hints when calculating sizing. that
means any attempt to set them would lead to... nothing useful. this
handles horiz/vert/both cases (as best as is possible).
@fix
Ali [Fri, 3 Apr 2020 16:11:24 +0000 (16:11 +0000)]
efl.ui.textbox: add test case for copy/paste results
since paste is now working when called from user source code, this test case can be added
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11625
Marcel Hollerbach [Mon, 6 Apr 2020 05:46:48 +0000 (07:46 +0200)]
build: add version to exactness libs
this patch was submitted through the bugtracker by Andrew Brouwers.
Thank you!
fixes T8644
Wonki Kim [Tue, 17 Mar 2020 04:51:02 +0000 (04:51 +0000)]
emile: fix a potentional resource leaking.
'ctx' can be leaked in some case.
this pathc fixes it.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11368
Marcel Hollerbach [Fri, 3 Apr 2020 15:20:34 +0000 (17:20 +0200)]
ecore_evas: fix leaks in macos and win32
memory is duplicated in eina_content_new.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11641
Hermet Park [Mon, 6 Apr 2020 08:21:17 +0000 (17:21 +0900)]
ui textpath: removed unused var.
Change-Id: Ib9efde3fbb0da2764a96b30fa3a4424113c4a761
Hermet Park [Mon, 6 Apr 2020 08:14:40 +0000 (17:14 +0900)]
ui textpath: update map before rendering begins.
previously, textpath delays the map calculation to avoid duplicated jobs.
some cases, this job could be delayed to the next frame that occured a
wrong frame result.
This render_pre event gurantees the textpath to update frames exactly.
@fix
Change-Id: I62f61a41991c20299e75df09e014b7357df47233
Junkyeong Kim [Tue, 24 Mar 2020 08:03:29 +0000 (17:03 +0900)]
ecore_buffer: deprecate unused API and structure
Change-Id: I6425deb0097efb96f2c6f4e9018ff55db3f67fe7
Signed-off-by: Junkyeong Kim <jk0430.kim@samsung.com>
Mike Blumenkrantz [Tue, 31 Mar 2020 16:58:47 +0000 (12:58 -0400)]
tests/hover: add behavior tests for elm_hover
verify geometry and smart callback triggering
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11632
Mike Blumenkrantz [Tue, 31 Mar 2020 16:58:09 +0000 (12:58 -0400)]
tests/layout: add explicit test for freeze and thaw no-op correctness
this shouldn't trigger any canvas changes since nothing is happening
during the freeze
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11631
Mike Blumenkrantz [Tue, 31 Mar 2020 16:57:28 +0000 (12:57 -0400)]
tests/elm: add wrapper for forcing manual render in tests
this can be useful when a test needs to immediately verify whether a render
is occurring
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11630
Mike Blumenkrantz [Tue, 31 Mar 2020 16:53:10 +0000 (12:53 -0400)]
tests/elm: add helper macros for asserting size and position of objects
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11629
Mike Blumenkrantz [Tue, 31 Mar 2020 16:40:25 +0000 (12:40 -0400)]
efl_ui/layout: correctly batch object changed state when using freeze/thaw
previously this would always queue a recalc when calling thaw even if the
object hadn't changed
also mimic edje internal behavior with unsetting 'frozen' during force calc
for possible future handling even though it has no effect presently
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11628
Marcel Hollerbach [Tue, 24 Mar 2020 19:10:39 +0000 (20:10 +0100)]
eo: use eina_prefetch
we should prefetch the func pointer here.
Later on we are accessing the func pointer in a streak, after that, we
do not use it anymore.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11593
Marcel Hollerbach [Mon, 30 Mar 2020 09:03:00 +0000 (11:03 +0200)]
Replace strncmp code
the structure "!strcmp(X, "foo", strlen("foo"))" is equal to
"eina_has_prefix(X, "foo")", and the later is nicer to read, hence this
replaces it.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11620
Mike Blumenkrantz [Fri, 20 Mar 2020 15:27:42 +0000 (11:27 -0400)]
evas/text: remove paragraph_direction inherit during render
this is unnecessary:
* for the text object itself, the value is correctly set whenever the
paragraph_direction property is changed
* for inheritance, smart object already implements propagation which triggers
on member add or property change
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11549
Mike Blumenkrantz [Thu, 26 Mar 2020 14:46:20 +0000 (10:46 -0400)]
ecore-evas/cocoa: fix cnp leak
this pointer needs to be freed if it's being copied
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11604
Ali [Fri, 27 Mar 2020 06:07:16 +0000 (06:07 +0000)]
elm_entry: using keycode for main keyboard shortcuts
Previously we use key strings to detect keyboard shortcuts (for example copy/paste/select_all, .. etc)
Now we will use key code alongside with these key strings (I do not remove the key string, because I am afraid something depends on them because some methods do not send keycode with keys)
This issue can be easily detected when the keyboard layout is not a Latin language, for example Hitting "C" will produce key string depends on related language not letter C, but Keycodes remain the same regardless of keyboard layout.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11606
Alastair Poole [Fri, 3 Apr 2020 10:38:48 +0000 (11:38 +0100)]
code: Silence compiler warnings.
ProhtMeyhet [Fri, 6 Mar 2020 21:21:58 +0000 (21:21 +0000)]
edje_legacy: Remove EINA_UNUSED when obj is actually used
This removes EINA_UNUSED when obj is actually used
like in a call ed = _edje_fetch(obj);
Please note the macro GET_REAL_PART_ON_FAIL_RETURN
also uses obj.
No functional changes, just cleanup.
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11471
Vincent Torri [Tue, 24 Mar 2020 14:05:19 +0000 (14:05 +0000)]
free memory in clipboard notify event and fix clipboard clear event
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11564
Jongmin Lee [Fri, 3 Apr 2020 02:08:01 +0000 (11:08 +0900)]
build: resolve migration build error (bump version for 1.24)
Change-Id: I5a03078bb805032cc5920416ef2724e3291dfbc0
Seungwan Woo [Wed, 26 Feb 2020 06:00:57 +0000 (15:00 +0900)]
elementary - get/set resources for extension theme to load bundle of Elm_Color_Overlay / Elm_Font_Overlay
Change-Id: If248a48a03a9dd559475a82a8d55d5b7e4b41076
Signed-off-by: Seungwan Woo <s-w.woo@samsung.com>
HyukSoon Choi [Tue, 31 Mar 2020 04:57:31 +0000 (13:57 +0900)]
Add debug information to ecore_event
- add debug information which for analyzing of many issues related to touch event.
Sometimes we need more information regarding touch events of ecore layer.
(ex. position, timestamp, etc)
Change-Id: I76ee7f9faf6027c914237355be4f3c2eaaf74dcb
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
Hosang Kim [Tue, 31 Mar 2020 07:09:35 +0000 (16:09 +0900)]
evas_object_main: skip processing when there is no pointer data.
@tizen_only
Change-Id: Ide0f64bda6f2d11e50b51c9d764eafec9213c71e
Godly T.Alias [Fri, 27 Mar 2020 09:06:07 +0000 (14:36 +0530)]
Back to top feature Contribution.
Change-Id: I06224bed8b8fb7cb9354d619a1338ee1802e9cbe
Signed-off-by: Suresh Kumar <suresh.ku1@samsung.com>
Subodh Kumar [Wed, 22 Jan 2020 13:30:58 +0000 (19:00 +0530)]
[text marquee] Fix text marquee with textblock fit.
test plan: Please test with fit option and marquee enabled.
@tizen_fix
Change-Id: I51b00c0297283706bfc172b4884cf6e20ccd4305
SangHyeon Jade Lee [Wed, 25 Mar 2020 09:15:01 +0000 (18:15 +0900)]
genlist : clean del_fx items on item clear
del_fx items are already invalidated,
so sd->items walking is broken as efl_del won't able to call
item_free().
so clean del_fx items before sd->items walking.
Change-Id: I1b61f96d58b59a698a08bc0a5ebbd72cbd59df9d
SangHyeon Jade Lee [Mon, 23 Mar 2020 11:15:12 +0000 (20:15 +0900)]
genlist : freeze the event before select item
this is revert patch of commented freeze_events on genlist.
Change-Id: I7e6d2021c2eb37bbc3aa06feb53190c3b3ddede2
SangHyeon Jade Lee [Mon, 23 Mar 2020 10:55:33 +0000 (19:55 +0900)]
scroll_interface : change animator object as pan to prventing event freezer
Change-Id: I574d1afd2797d5213ff5c7d201dacc3c91df7746
SangHyeon Jade Lee [Fri, 20 Mar 2020 08:22:20 +0000 (17:22 +0900)]
genlist : do not calc deferring on scroll in center align mode
Change-Id: Ie98ce347c436b6f08fb5578043a3463affe504d3
Yukti Pandey [Mon, 16 Mar 2020 10:59:27 +0000 (16:29 +0530)]
[efl] Update 'gototop' to 'backtotop'
Updated all gototop code with backtotop
Change-Id: Ife763dd93719771fad66b9b316c019f464759590
Signed-off-by: Yukti Pandey <yukti.pandey@samsung.com>
Hosang Kim [Thu, 12 Mar 2020 08:43:35 +0000 (17:43 +0900)]
Remove remarks flag of elm_win_aux_msg APIs
- elm_win_aux_msg_key_get
- elm_win_aux_msg_val_get
- elm_win_aux_msg_options_get
@tizen_only
Change-Id: Ic9624dde297385c7a0c28ca62ca8b02f3d5e0286
Hosang Kim [Tue, 10 Mar 2020 04:59:45 +0000 (13:59 +0900)]
ecore/evas: fix indentations and comments
Change-Id: I05ea238884266f79fbb28ec8cf34390cecf9e013
Hosang Kim [Mon, 9 Mar 2020 08:06:02 +0000 (17:06 +0900)]
ecore/evas: add brief docs for enum.
Change-Id: I82565c0e749da4467b1d861e94b74338ec25af82
SangHyeon Jade Lee [Fri, 6 Mar 2020 05:54:59 +0000 (14:54 +0900)]
elm_gen : Remove unnecessary inehitance of WIDGET_ITEM_STATIC_FOCUS
Elm_Widget_Item_Static_Focus Class is for supporing item focus of
Elm_Gen_Item, in new focus manager system.
As this class add/del realized/unrealized callbacks for every each
items, if genlist/gengrid have more than 10000 items, performance
of adding/deleting item is getting severely increased.
In legacy focus system, we do not need this class anymore,
so get rid of it in class definitions.
Change-Id: I1666fec95c297b88a70fa0646df36ece6e01fac0
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Hosang Kim [Thu, 5 Mar 2020 11:07:56 +0000 (20:07 +0900)]
ecore_evas: fix class name of ecore device.
Change-Id: I3671126ca4470e15ee9e4c215131219cd3054d21
kim hosang [Tue, 31 Mar 2020 10:50:16 +0000 (10:50 +0000)]
Revert "win/widget: free array when object is deleted."
This reverts commit
c0ef877a9c6d0628e6934e5dcc5b09e3021ee02b.
Change-Id: I01308360805237d9f61025a15e642f5f7ddb387d
Hosang Kim [Tue, 31 Mar 2020 06:43:24 +0000 (15:43 +0900)]
win/widget: free array when object is deleted.
It makes a memory leak.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11522
Change-Id: I7dfaf2e70017382f9e905e4f77488fd283b10a7e
Xavi Artigas [Wed, 1 Apr 2020 07:50:27 +0000 (09:50 +0200)]
doxygen docs: some fixes in Evas_Legacy.h
This brings into the docs hundreds of methods!
due to the ingroup->defgroup mistake, they were out of any scope
and therefore they were silently ignored by doxygen.
Also, document lots of missing "obj" parameters. Not strictly necessary, but
this further reduces the number of doxygen warnings.
Xavi Artigas [Fri, 27 Mar 2020 14:29:56 +0000 (15:29 +0100)]
doxygen docs: Add _Eina_Version struct docs
Xavi Artigas [Fri, 27 Mar 2020 12:49:07 +0000 (13:49 +0100)]
comments: Typos in Efl_Config.h
Xavi Artigas [Wed, 1 Apr 2020 16:40:40 +0000 (18:40 +0200)]
exactness docs: Add docs, fix docs, remove docs
Summary:
The Exactness tool needed usage instructions... and quite some more
fixes. There was copypasta all around.
Depends on D11634
Test Plan: Build and Enjoy
Reviewers: bu5hm4n, stefan_schmidt
Reviewed By: stefan_schmidt
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11637
Stefan Schmidt [Wed, 1 Apr 2020 13:03:05 +0000 (15:03 +0200)]
ci: travis: switch exactness testing to normal test file
Since the changes from Marcel to run exactness as LD_PRELOADed library
we can switch back to the normal test.txt file and names.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11636
Marcel Hollerbach [Wed, 1 Apr 2020 12:04:19 +0000 (14:04 +0200)]
exactness: protect against forked calls
there came up a issue, where a excatness spawned processes were bringing
up a efreetd instance, when the efreetd instance turned off itself, the
files for exactness were written again, which is wrong. This ensures
that forked instances do not take any actions.
Differential Revision: https://phab.enlightenment.org/D11634
Stefan Schmidt [Wed, 1 Apr 2020 10:51:51 +0000 (12:51 +0200)]
release: Update NEWS and bump version for 1.24.0-alpha1 release
kim hosang [Tue, 31 Mar 2020 10:50:16 +0000 (10:50 +0000)]
Revert "win/widget: free array when object is deleted."
This reverts commit
c0ef877a9c6d0628e6934e5dcc5b09e3021ee02b.
Change-Id: I01308360805237d9f61025a15e642f5f7ddb387d
Marcel Hollerbach [Tue, 31 Mar 2020 08:07:29 +0000 (10:07 +0200)]
exactness: error when _src_unit is NULL
if _src_unit is NULL, the write here would delete the actions, with this
commit we ensure that this is printing an error.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11627
Marcel Hollerbach [Mon, 30 Mar 2020 14:49:05 +0000 (16:49 +0200)]
exactness: equip with ERR and CRIT
before a few commits, we had the situation that errors were overseen
because the log was simply so big, that errors did not get shown
properly.
With this commit, exactness will simply abort if there is a real issue
in the code.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11624
Marcel Hollerbach [Fri, 27 Mar 2020 17:43:42 +0000 (18:43 +0100)]
exactness: correctly call mkdir
we should not error when mkdir returns < 0. EEXIST should not result in
the return here.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11618
Marcel Hollerbach [Fri, 27 Mar 2020 17:11:07 +0000 (18:11 +0100)]
exactness: do not efl_del the evas
there is no need to do that, more than that. This is super dangerous,
the display and connection ptr of x are passed from ecore_evas to evas,
if you delete evas before ecore_evas, the later ecore_evas deletion will
destroy the x connection which calls some functions in evas, which is
already freed, which leads to a crash.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11617
Marcel Hollerbach [Fri, 27 Mar 2020 15:54:09 +0000 (16:54 +0100)]
exactness_play: introduce runner script
this is just a little python script, so you can lunch exactness_play
without the need of handdefining LD_PRELOAD
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11616
Marcel Hollerbach [Fri, 27 Mar 2020 14:44:33 +0000 (15:44 +0100)]
exactness_play: transform to LD_PRELOAD library
this can now be loaded as LD_PRELOAD library
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11615
Marcel Hollerbach [Fri, 27 Mar 2020 14:08:46 +0000 (15:08 +0100)]
exactness_player: refactor main method
this refactors everything that is not argc argv related out of the main
method. For later usage
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11614
Marcel Hollerbach [Fri, 27 Mar 2020 13:03:07 +0000 (14:03 +0100)]
exactness: remove code for compiling
this seems to be made for compiling binaries before testing. That sounds
like a good idea, however, implementing a full buildtool in exactness is
a bit hard. Hence, using meson for that would be better.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11613
Marcel Hollerbach [Fri, 27 Mar 2020 10:25:22 +0000 (11:25 +0100)]
exactness_record: introduce runner script
this is just a little python script, so you can lunch exactness_record
without the need of handdefining LD_PRELOAD
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11611
Marcel Hollerbach [Fri, 27 Mar 2020 08:14:45 +0000 (09:14 +0100)]
exactness_recorder: move to preload
this is now not a binary anymore, that dlopen's a binary, it is now a
library, that can be loaded using LD_PRELOAD. EXACTNESS_DEST is used for
the path of the .exu file. EXACTNESS_FONTS_DIR is used to get the fonts
directory
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11610
Marcel Hollerbach [Thu, 26 Mar 2020 15:41:21 +0000 (16:41 +0100)]
exactness_recorder: refactor main method
all calls taht are not related to env var checking, are moved out of the
main method. That is in preparation for later refactorings.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11623
Shinwoo Kim [Mon, 30 Mar 2020 05:19:19 +0000 (05:19 +0000)]
elm_atspi_bridge: initialize variables
The efl_access_text_attribute_get is resolved by elm_entry.
Please refer to _elm_entry_efl_access_text_attribute_get first.
Uninitialized variables are used for its parameters, and it is able to
return before setting these variables.
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11619
Change-Id: I14ef91d723a4bf0326c6e90e45226109857268c6
Bartlomiej Grzelewski [Fri, 27 Mar 2020 11:33:06 +0000 (11:33 +0000)]
elm_atspi_bridge: fix bugs reported by coverity
Prevent usage of uninitilized values.
CID: 1421995, 1421997, 1422001
Signed-off-by: Bartlomiej Grzelewski <b.grzelewski@samsung.com>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11612
Change-Id: Iaf4b2df1826a31f6d2c022f00e76e2db01732c81
Bartlomiej Grzelewski [Fri, 27 Mar 2020 11:24:42 +0000 (11:24 +0000)]
elm_atspi_bridge: fix bugs reported by coverity
Make sure we free allocated resources in the error path.
Prevent usage of uninitilized value.
Signed-off-by: Bartlomiej Grzelewski <b.grzelewski@samsung.com>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11607
Change-Id: I1d86a397a9d983d8b733615ffeaf318d4f0c9437
Prasoon Singh [Fri, 27 Mar 2020 13:28:02 +0000 (18:58 +0530)]
[access] Add missing widget name setter
Implementation file has _efl_ui_widget_efl_access_object_i18n_name_set
but same is missing from eo file. Due to which issue in access
name set/get API.
Change-Id: Iff96512d3b985bda06afe0ea65d99784eda559e9
Signed-off-by: Prasoon Singh <prasoon.16@samsung.com>
Wonki Kim [Mon, 30 Mar 2020 09:38:24 +0000 (18:38 +0900)]
scroller: fix a focus logic to move next/prior.
efl_ui_scrollable interface doesn't have a getter related with page number
this patch fixes a focus logic to move next/prior by pan size.
Change-Id: I0ad41886a1157e00a460c85705571de164b4510b
Christopher Michael [Mon, 30 Mar 2020 18:34:41 +0000 (14:34 -0400)]
ecore_evas_wayland: Do not pass negative parameter to close function
Coverity reports that 'fd' here is negative, and close() cannot accept
a negative parameter, so add a check to make sure 'fd' is not negative
before passing to close function.
Fixes CID1420318
Christopher Michael [Mon, 30 Mar 2020 18:33:23 +0000 (14:33 -0400)]
ecore_evas_wayland: Declare variables at top of function
Marcel Hollerbach [Mon, 30 Mar 2020 14:22:37 +0000 (16:22 +0200)]
efl_ui_textbox: pass in correct seat
0 was the wrong seat, and only worked on a small amount of systems
fixes T8639
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11622
Hermet Park [Mon, 30 Mar 2020 12:30:08 +0000 (21:30 +0900)]
canvas vg: null initialization for safety.
Marcel Hollerbach [Thu, 26 Mar 2020 15:44:55 +0000 (16:44 +0100)]
exactness_recorder: cleanup code a bit
_test_name was not used globally, so lets move it to the used scope.
Verbose is not used at all either.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11609
Woochanlee [Thu, 26 Mar 2020 03:44:15 +0000 (12:44 +0900)]
ecore_wl2: Introduce ecore_wl2_window_pointer/keyboard get APIs.
To support multi seat, It should be able to get the input connected to the focused window.
Change-Id: I45a1c3a049fd46a97471bc8485599f8f28c75f59
Shinwoo Kim [Fri, 27 Mar 2020 01:48:49 +0000 (10:48 +0900)]
elm_atspi_bridge: add missing line
This patch adds missing line of
https://review.tizen.org/gerrit/#/c/platform/upstream/elementary/+/153836/
Especially,
this patch makes atspi_bridge send a signal for INPUT_METHOD_WINDOW.
Without this patch, the virtual keyboard does not work correctly
for accessibility.
@tizen_fix
Change-Id: I95d5a478c629de904e38bc2ff01d6d055de8a0ca
Woochanlee [Wed, 25 Mar 2020 08:55:04 +0000 (17:55 +0900)]
ecore_wl2: Support keygrab privilge to make it public.
Among the keygrab APIs, other modes except TOPMOST can only call processes with platform level privilege.
These APIs will be used by 3rd-party without privilege inevitably.(TOPMOST mode only.)
@tizen_only
Change-Id: I556169a5bd74898e186596fefc4548064365a544
Stefan Schmidt [Fri, 27 Mar 2020 08:54:43 +0000 (09:54 +0100)]
ci: enable ecore_con IPv6 tests
We have them behind an env variable as this is system specific. Enable
them on CI to fully test these paths as well.
While this works out of the box for the native build on Travis it fails
for our docker builds, as the dockerd does not have ipv6 enabled by
default. Only enable for Codecov for now.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11608