sunghyun kim [Fri, 23 Sep 2016 02:30:39 +0000 (11:30 +0900)]
evas-gl-core: fix dereferenced bug
Change-Id: I18ce3d5b3cb928b174b00b3a36be6c2286c4503a
sunghyun kim [Fri, 23 Sep 2016 02:15:02 +0000 (11:15 +0900)]
ecore_evas_wayland_common: fix dereferenced bug
Change-Id: Iceb797cb05bbcf58ca8426d5bada6c8b1ef0d345
Jee-Yong Um [Fri, 5 Feb 2016 07:30:31 +0000 (08:30 +0100)]
edje_cc: allow omitting "name" keyword in color_classes.color_class block
Summary:
This allows developer to omit "name" keyword in color_classes.color_class
block in EDC.
Reviewers: cedric, jpeg
Reviewed By: jpeg
Differential Revision: https://phab.enlightenment.org/D3598
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Change-Id: Idfb304a31db9028c279a40c7e3bdb6e6e7b2ffd4
Jee-Yong Um [Wed, 21 Sep 2016 12:20:14 +0000 (21:20 +0900)]
mark deprecated APIs with EINA_DEPRECATED
Signed-Off-By: Jee-Yong Um <jc9.um@samsung.com>
Change-Id: I75343add0f3d243c708e3689f0b15cd6576f467b
Youngbok Shin [Tue, 20 Sep 2016 10:47:55 +0000 (19:47 +0900)]
edje: Add fade_ellipsis feature to TEXTBLOCK, TEXT part
@tizen_feature
Change-Id: I391a1fe98ac3c4cac9d6c0a50e3c87ce21172f51
Hosang Kim [Thu, 22 Sep 2016 03:48:35 +0000 (12:48 +0900)]
ecore_wl_input: fix checking keyboard modifier flag.
when 'caps lock' is locking, ecore_wl_input does not send this
information.
Change-Id: Ibfe2d9982cc74e98600a22975eba1a6ab5eafc79
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Hermet Park [Wed, 21 Sep 2016 07:55:47 +0000 (16:55 +0900)]
evas software engine: ++safey code
Change-Id: I430cc0c065579a21349c87c64d499c08f5f5ad47
Hermet Park [Wed, 21 Sep 2016 07:24:59 +0000 (16:24 +0900)]
commit
c998fd5ee7e90f1861aba6d4a44d8c0b5387bb61
Author: Hermet Park <hermet@hermet.pe.kr>
Date: Wed Sep 21 16:24:42 2016 +0900
evas software_engine: ++safety code.
Change-Id: Ia698352af4947d37901faea10151e6e65a19518c
Hermet Park [Wed, 21 Sep 2016 06:38:54 +0000 (15:38 +0900)]
edje edje_cc_handlers: use strncpy() instead of strcpy()
strncpy is better for security.
Change-Id: I9b03ba0c4076704e9d9c92033b530e30d5fbb20e
Hermet Park [Wed, 21 Sep 2016 06:21:06 +0000 (15:21 +0900)]
commit
6de3b2c5d36993cf3dbe94e8fbefd04043f91740
Author: Hermet Park <hermet@hermet.pe.kr>
Date: Wed Sep 21 15:19:19 2016 +0900
edje edje_cc_out: use strncpy().
This change is not much meaningful but avoids an annoying coverity detection.
Change-Id: I40651f0140f6ff3de0b3e987ac3fd2b5540d4dea
Hermet Park [Wed, 21 Sep 2016 06:04:39 +0000 (15:04 +0900)]
commit
06bd8dcf330fe31891475c92aa340d4886f47e2b
Author: Hermet Park <hermet@hermet.pe.kr>
Date: Wed Sep 21 15:03:11 2016 +0900
edje edje_embryo: use strncpy().
This change is not meaningful but avoids an annoying coverity detection.
Change-Id: Ia5932564987b4c424794820de4347ae799bb450a
Hermet Park [Wed, 21 Sep 2016 05:58:22 +0000 (14:58 +0900)]
edje edje_cc: use sizeof() instead of constant.
This change is more maintaintable code.
Change-Id: Iac57cff75d6428dbe27ba74146dac811dfea62a7
Hermet Park [Wed, 21 Sep 2016 04:32:45 +0000 (13:32 +0900)]
commit
ab1a72f5e7df6fe0adef54bdcddd9867a2ebe3a6
Author: Hermet Park <hermet@hermet.pe.kr>
Date: Wed Sep 21 13:30:44 2016 +0900
edje/edje_cc: use strncpy() instead of strcpy().
strncpy() is better for security.
Also, this change avoids annoying coverity detection.
Change-Id: I7e525c0e0d5fcd1411f7079bef1ee7a4fe770728
Hermet Park [Wed, 21 Sep 2016 04:18:19 +0000 (13:18 +0900)]
commit
ff7511ae123bbaaefcd716edc2aabf57a9139da8
Author: Hermet Park <hermet@hermet.pe.kr>
Date: Wed Sep 21 13:16:36 2016 +0900
evas engine: correct null check
check null first, before access it.
Change-Id: I48cd4b2b18e8fd81d73410f603091ea90f4c7d9d
Jee-Yong Um [Wed, 21 Sep 2016 04:23:57 +0000 (13:23 +0900)]
edje_cc: duplicate string for script when inheriting edje group
Signed-Off-By: Jee-Yong Um <jc9.um@samsung.com>
Change-Id: I0657f35ede5d46dc286f5ae27f6316e34a6893c6
jiin.moon [Wed, 21 Sep 2016 02:58:46 +0000 (11:58 +0900)]
eet: sync _evas_canvas3d_eet_file_free with upstream
Previous api can make a crash issue becasue of wrong access.
Change-Id: I4cb01c275e0ed1c3bd66ba5f860470c8e1b18b69
jiin.moon [Tue, 20 Sep 2016 11:59:44 +0000 (20:59 +0900)]
eet: Fix memory leak
If eet_mesh/eet_header is not NULL,
this address should be freed by _evas_canvas3d_eet_file_free api
@tizen_fix
Change-Id: I65ae0125cba7faab9429c961be2468d86425b31a
jiin.moon [Tue, 20 Sep 2016 11:27:25 +0000 (20:27 +0900)]
evas: Fix wrong access issue
If bidi_props is NULL, do not access this point.
@tizen_fix
Change-Id: I8ded9b3c5baec1be2c9ce1a9feb28f780fee41df
Jaehyun Cho [Wed, 21 Sep 2016 00:43:57 +0000 (09:43 +0900)]
edje_edit: Remove unnecessary TIZEN_ONLY comment.
The commit
630d5e2b5b01b5772dd9b429cbc7e90e8491072f has been applied to
upstream. So the unnecessary TIZEN_ONLY comment is removed.
Change-Id: I3d9d4f4dfee354ecfa64034f9c5c21f64a8c20d0
WooHyun Jung [Wed, 21 Sep 2016 00:40:31 +0000 (09:40 +0900)]
Revert "edje: Add fade_ellipsis feature to TEXTBLOCK, TEXT part"
This reverts commit
a43683f915bad09c0de3ab6c4748d91b3b491d18.
Change-Id: I745b653a3d4279aeeb1234243262c461aba37676
Signed-off-by: WooHyun Jung <wh0705.jung@samsung.com>
Ji-Youn Park [Tue, 20 Sep 2016 09:42:51 +0000 (18:12 +0830)]
eldbus: fix null value usage
opensource-commit
13bd4242eca76560fbefd690934bc63a5fbd28c3
Author: Ji-Youn Park <jy0703.park@samsung.com>
Date: Tue Sep 20 18:10:32 2016 +0830
Change-Id: I78bfd1aab568bba1449bb418fa64e2c2c4a0e927
Ji-Youn Park [Tue, 20 Sep 2016 07:46:59 +0000 (16:16 +0830)]
ecore_con_local: fix memory leak.
after socket function call, close file descriptor.
opensource_commit
0a39fae0a2c27ec48b39caca3b00dc54bdffaa32
Author: Ji-Youn Park <jy0703.park@samsung.com>
Date: Tue Sep 20 16:14:04 2016 +0830
Change-Id: I2be352b2b5080164e3895c08c177fc46354d7de8
Artem Popov [Tue, 20 Sep 2016 16:52:23 +0000 (19:52 +0300)]
ecore_file: Fix improper way of comparing in ecore_file_path_dir_exists @fix
Summary: There is wrong comparing while using strcmp function. Should be inverted.
Reviewers: cedric, raster, NikaWhite
Reviewed By: NikaWhite
Subscribers: cedric, NikaWhite, jpeg
Differential Revision: https://phab.enlightenment.org/D4291
Change-Id: Icc5c17e6fd60b9137086fd93412c76e5a97a1f55
Signed-off-by: Mykyta Biliavskyi <m.biliavskyi@samsung.com>
Vitalii Vorobiov [Mon, 19 Sep 2016 15:09:13 +0000 (18:09 +0300)]
edje_edit: make tweens able to work with image sets
it's important because some tweens of loaded edje group might use image sets
instead of images, so now making edje_edit API to work with them correctly
@fix
Change-Id: I636d8a58279b0ec3e6dc50df3e9f0fc42e5cae26
Signed-off-by: Mykyta Biliavskyi <m.biliavskyi@samsung.com>
JunsuChoi [Tue, 20 Sep 2016 14:34:17 +0000 (23:34 +0900)]
edje_edit : add null check and close eet
Change-Id: I9292bfc0e830f84a0828b1ec6352701f52d6c8f5
JunsuChoi [Tue, 20 Sep 2016 14:23:29 +0000 (23:23 +0900)]
edje_decc: modified fclose location
modified fclose location. because of file pointer can become NULL.
Change-Id: I6aa5a2dff76a80a6a39b49f3c74adf6aae636828
Sungtaek Hong [Tue, 20 Sep 2016 08:49:16 +0000 (17:49 +0900)]
ecore_evas: fix void returns from non-void value
@tizen_fix
Change-Id: I0a2215eb815135b9f364e430f31a85113de623fd
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
Sungtaek Hong [Tue, 20 Sep 2016 08:13:32 +0000 (17:13 +0900)]
eet: suppport ETC1+Alpha properly
@tizen_fix
Change-Id: I49b7a7f9be062f5a70f94cac808999eaf812bb5d
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
Sungtaek Hong [Tue, 20 Sep 2016 06:27:47 +0000 (15:27 +0900)]
ecore_evas: remove unreachable code
@tizen_fix
Change-Id: I85ab36a533b4cf80227a3a333ab1e45db103261e
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
Sungtaek Hong [Tue, 20 Sep 2016 06:03:18 +0000 (15:03 +0900)]
evas: remove unnecessary check for unreachable case
@tizen_fix
Change-Id: I5a081cbe0be599a9abe0127bbb3fa5c4d23d25eb
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
Sungtaek Hong [Tue, 20 Sep 2016 05:17:24 +0000 (14:17 +0900)]
evas_scale: remove unnecessary check for clip coords.
@tizen_fix
Change-Id: I32c0e96fc5f80ea9509af1474d9413a615391e57
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
Youngbok Shin [Tue, 20 Sep 2016 06:02:03 +0000 (15:02 +0900)]
evas textblock: remove NULL checking after dereferencing
Summary:
c->paragraphs couldn't be NULL if it is created by
_layout_paragraph_new() well. So, NULL checking should be
moved to after _layout_paragraph_new().
Test Plan: N/A
Reviewers: raster, cedric, tasn, herdsman
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D4300
Change-Id: Ia30c6b431af394f4ea398dfa60cbed3be4e8f65b
Signed-off-by: Youngbok Shin <youngb.shin@samsung.com>
Youngbok Shin [Tue, 20 Sep 2016 10:47:55 +0000 (19:47 +0900)]
edje: Add fade_ellipsis feature to TEXTBLOCK, TEXT part
@tizen_feature
Change-Id: I6d70eece9fd4a1194d3140eb527a8811cba76a2b
Duna Oh [Tue, 20 Sep 2016 08:52:14 +0000 (17:52 +0900)]
ecore_drm: fix crash if string is null
Change-Id: Ief8df0e6af31592746a93c54d404adaf6d71be9d
Signed-off-by: Duna Oh <duna.oh@samsung.com>
Joogab Yun [Tue, 20 Sep 2016 02:11:42 +0000 (11:11 +0900)]
gl_common: call evas_gl_common_texture_free() before dropping image
cache texture_free() accesses struct members which can be freed if image
cache entry reaches zero references
from
437ba4c46d0c161bd11c6f6d42adbff872a8540a in opensource
@fix
==30989== Invalid read of size 1
==30989== at 0x23BA2934: evas_gl_common_texture_free (evas_gl_texture.c:1506)
==30989== by 0x23BA9117: evas_gl_common_image_free (evas_gl_image.c:724)
==30989== by 0x23B80DA1: eng_image_data_put (evas_engine.c:988)
==30989== by 0x872681A: _evas_image_data_set (evas_object_image.c:1264)
==30989== by 0x87360B5: evas_obj_image_data_set (evas_image.eo.c:236)
==30989== by 0x8736B43: evas_object_image_data_set (evas_image.eo.c:741)
==30989== by 0x4820A4: e_comp_object_render (e_comp_object.c:3746)
==30989== by 0x477B92: _e_comp_object_pixels_get (e_comp_object.c:909)
==30989== by 0x872CF52: evas_process_dirty_pixels (evas_object_image.c:3154)
==30989== by 0x872DD16: _evas_image_render (evas_object_image.c:3389)
==30989== by 0x872DB01: evas_object_image_render (evas_object_image.c:3351)
==30989== by 0x879C524: evas_render_mapped (evas_render.c:1802)
==30989== by 0x879E82A: evas_render_updates_internal_loop (evas_render.c:2380)
==30989== by 0x87A005D: evas_render_updates_internal (evas_render.c:2770)
==30989== by 0x87A140D: evas_render_updates_internal_wait (evas_render.c:3122)
==30989== by 0x87A1502: _evas_canvas_render_updates (evas_render.c:3144)
==30989== by 0x871ED0D: evas_canvas_render_updates (evas_canvas.eo.c:354)
==30989== by 0x8720C5F: evas_render_updates (evas_canvas.eo.c:1089)
==30989== by 0x22F65C35: _ecore_evas_drm_render (ecore_evas_drm.c:1072)
==30989== by 0x7416F7B: _ecore_evas_idle_enter (ecore_evas.c:172)
==30989== by 0xDDE3577: _ecore_call_task_cb (ecore_private.h:282)
==30989== by 0xDDE3A5E: _ecore_idle_enterer_call (ecore_idle_enterer.c:174)
==30989== by 0xDDE836B: _ecore_main_loop_iterate_internal (ecore_main.c:2261)
==30989== by 0xDDE67B8: ecore_main_loop_begin (ecore_main.c:1284)
==30989== by 0x4407B6: main (e_main.c:1087)
==30989== Address 0x23a9e1d2 is 338 bytes inside a block of size 552 free'd
==30989== at 0x4C29E00: free (vg_replace_malloc.c:530)
==30989== by 0x882B2E2: _evas_common_rgba_image_delete (evas_image_main.c:343)
==30989== by 0x87B1E17: _evas_cache_image_entry_delete (evas_cache_image.c:205)
==30989== by 0x87B3C52: evas_cache_image_drop (evas_cache_image.c:950)
==30989== by 0x23BA90F5: evas_gl_common_image_free (evas_gl_image.c:722)
==30989== by 0x23B80DA1: eng_image_data_put (evas_engine.c:988)
==30989== by 0x872681A: _evas_image_data_set (evas_object_image.c:1264)
==30989== by 0x87360B5: evas_obj_image_data_set (evas_image.eo.c:236)
==30989== by 0x8736B43: evas_object_image_data_set (evas_image.eo.c:741)
==30989== by 0x4820A4: e_comp_object_render (e_comp_object.c:3746)
==30989== by 0x477B92: _e_comp_object_pixels_get (e_comp_object.c:909)
==30989== by 0x872CF52: evas_process_dirty_pixels (evas_object_image.c:3154)
==30989== by 0x872DD16: _evas_image_render (evas_object_image.c:3389)
==30989== by 0x872DB01: evas_object_image_render (evas_object_image.c:3351)
==30989== by 0x879C524: evas_render_mapped (evas_render.c:1802)
==30989== by 0x879E82A: evas_render_updates_internal_loop (evas_render.c:2380)
==30989== by 0x87A005D: evas_render_updates_internal (evas_render.c:2770)
==30989== by 0x87A140D: evas_render_updates_internal_wait (evas_render.c:3122)
==30989== by 0x87A1502: _evas_canvas_render_updates (evas_render.c:3144)
==30989== by 0x871ED0D: evas_canvas_render_updates (evas_canvas.eo.c:354)
==30989== by 0x8720C5F: evas_render_updates (evas_canvas.eo.c:1089)
==30989== by 0x22F65C35: _ecore_evas_drm_render (ecore_evas_drm.c:1072)
==30989== by 0x7416F7B: _ecore_evas_idle_enter (ecore_evas.c:172)
==30989== by 0xDDE3577: _ecore_call_task_cb (ecore_private.h:282)
==30989== by 0xDDE3A5E: _ecore_idle_enterer_call (ecore_idle_enterer.c:174)
==30989== by 0xDDE836B: _ecore_main_loop_iterate_internal (ecore_main.c:2261)
==30989== by 0xDDE67B8: ecore_main_loop_begin (ecore_main.c:1284)
==30989== by 0x4407B6: main (e_main.c:1087)
==30989== Block was alloc'd at
==30989== at 0x4C2AA98: calloc (vg_replace_malloc.c:711)
==30989== by 0x882B0A0: _evas_common_rgba_image_new (evas_image_main.c:295)
==30989== by 0x87B1F1B: _evas_cache_image_entry_new (evas_cache_image.c:253)
==30989== by 0x87B4170: evas_cache_image_data (evas_cache_image.c:1079)
==30989== by 0x23BA7EDE: evas_gl_common_image_new_from_data (evas_gl_image.c:333)
==30989== by 0x23B7F972: eng_image_new_from_data (evas_engine.c:531)
==30989== by 0x23B80D81: eng_image_data_put (evas_engine.c:984)
==30989== by 0x872681A: _evas_image_data_set (evas_object_image.c:1264)
==30989== by 0x87360B5: evas_obj_image_data_set (evas_image.eo.c:236)
==30989== by 0x8736B43: evas_object_image_data_set (evas_image.eo.c:741)
==30989== by 0x4820A4: e_comp_object_render (e_comp_object.c:3746)
==30989== by 0x477B92: _e_comp_object_pixels_get (e_comp_object.c:909)
==30989== by 0x872CF52: evas_process_dirty_pixels (evas_object_image.c:3154)
==30989== by 0x872DD16: _evas_image_render (evas_object_image.c:3389)
==30989== by 0x872DB01: evas_object_image_render (evas_object_image.c:3351)
==30989== by 0x879C524: evas_render_mapped (evas_render.c:1802)
==30989== by 0x879E82A: evas_render_updates_internal_loop (evas_render.c:2380)
==30989== by 0x87A005D: evas_render_updates_internal (evas_render.c:2770)
==30989== by 0x87A140D: evas_render_updates_internal_wait (evas_render.c:3122)
==30989== by 0x87A1502: _evas_canvas_render_updates (evas_render.c:3144)
==30989== by 0x871ED0D: evas_canvas_render_updates (evas_canvas.eo.c:354)
==30989== by 0x8720C5F: evas_render_updates (evas_canvas.eo.c:1089)
==30989== by 0x22F65C35: _ecore_evas_drm_render (ecore_evas_drm.c:1072)
==30989== by 0x7416F7B: _ecore_evas_idle_enter (ecore_evas.c:172)
==30989== by 0xDDE3577: _ecore_call_task_cb (ecore_private.h:282)
==30989== by 0xDDE3A5E: _ecore_idle_enterer_call (ecore_idle_enterer.c:174)
==30989== by 0xDDE836B: _ecore_main_loop_iterate_internal (ecore_main.c:2261)
==30989== by 0xDDE67B8: ecore_main_loop_begin (ecore_main.c:1284)
==30989== by 0x4407B6: main (e_main.c:1087)
==30989==
==30989== Invalid write of size 1
==30989== at 0x23BA293E: evas_gl_common_texture_free (evas_gl_texture.c:1506)
==30989== by 0x23BA9117: evas_gl_common_image_free (evas_gl_image.c:724)
==30989== by 0x23B80DA1: eng_image_data_put (evas_engine.c:988)
==30989== by 0x872681A: _evas_image_data_set (evas_object_image.c:1264)
==30989== by 0x87360B5: evas_obj_image_data_set (evas_image.eo.c:236)
==30989== by 0x8736B43: evas_object_image_data_set (evas_image.eo.c:741)
==30989== by 0x4820A4: e_comp_object_render (e_comp_object.c:3746)
==30989== by 0x477B92: _e_comp_object_pixels_get (e_comp_object.c:909)
==30989== by 0x872CF52: evas_process_dirty_pixels (evas_object_image.c:3154)
==30989== by 0x872DD16: _evas_image_render (evas_object_image.c:3389)
==30989== by 0x872DB01: evas_object_image_render (evas_object_image.c:3351)
==30989== by 0x879C524: evas_render_mapped (evas_render.c:1802)
==30989== by 0x879E82A: evas_render_updates_internal_loop (evas_render.c:2380)
==30989== by 0x87A005D: evas_render_updates_internal (evas_render.c:2770)
==30989== by 0x87A140D: evas_render_updates_internal_wait (evas_render.c:3122)
==30989== by 0x87A1502: _evas_canvas_render_updates (evas_render.c:3144)
==30989== by 0x871ED0D: evas_canvas_render_updates (evas_canvas.eo.c:354)
==30989== by 0x8720C5F: evas_render_updates (evas_canvas.eo.c:1089)
==30989== by 0x22F65C35: _ecore_evas_drm_render (ecore_evas_drm.c:1072)
==30989== by 0x7416F7B: _ecore_evas_idle_enter (ecore_evas.c:172)
==30989== by 0xDDE3577: _ecore_call_task_cb (ecore_private.h:282)
==30989== by 0xDDE3A5E: _ecore_idle_enterer_call (ecore_idle_enterer.c:174)
==30989== by 0xDDE836B: _ecore_main_loop_iterate_internal (ecore_main.c:2261)
==30989== by 0xDDE67B8: ecore_main_loop_begin (ecore_main.c:1284)
==30989== by 0x4407B6: main (e_main.c:1087)
==30989== Address 0x23a9e1d2 is 338 bytes inside a block of size 552 free'd
==30989== at 0x4C29E00: free (vg_replace_malloc.c:530)
==30989== by 0x882B2E2: _evas_common_rgba_image_delete (evas_image_main.c:343)
==30989== by 0x87B1E17: _evas_cache_image_entry_delete (evas_cache_image.c:205)
==30989== by 0x87B3C52: evas_cache_image_drop (evas_cache_image.c:950)
==30989== by 0x23BA90F5: evas_gl_common_image_free (evas_gl_image.c:722)
==30989== by 0x23B80DA1: eng_image_data_put (evas_engine.c:988)
==30989== by 0x872681A: _evas_image_data_set (evas_object_image.c:1264)
==30989== by 0x87360B5: evas_obj_image_data_set (evas_image.eo.c:236)
==30989== by 0x8736B43: evas_object_image_data_set (evas_image.eo.c:741)
==30989== by 0x4820A4: e_comp_object_render (e_comp_object.c:3746)
==30989== by 0x477B92: _e_comp_object_pixels_get (e_comp_object.c:909)
==30989== by 0x872CF52: evas_process_dirty_pixels (evas_object_image.c:3154)
==30989== by 0x872DD16: _evas_image_render (evas_object_image.c:3389)
==30989== by 0x872DB01: evas_object_image_render (evas_object_image.c:3351)
==30989== by 0x879C524: evas_render_mapped (evas_render.c:1802)
==30989== by 0x879E82A: evas_render_updates_internal_loop (evas_render.c:2380)
==30989== by 0x87A005D: evas_render_updates_internal (evas_render.c:2770)
==30989== by 0x87A140D: evas_render_updates_internal_wait (evas_render.c:3122)
==30989== by 0x87A1502: _evas_canvas_render_updates (evas_render.c:3144)
==30989== by 0x871ED0D: evas_canvas_render_updates (evas_canvas.eo.c:354)
==30989== by 0x8720C5F: evas_render_updates (evas_canvas.eo.c:1089)
==30989== by 0x22F65C35: _ecore_evas_drm_render (ecore_evas_drm.c:1072)
==30989== by 0x7416F7B: _ecore_evas_idle_enter (ecore_evas.c:172)
==30989== by 0xDDE3577: _ecore_call_task_cb (ecore_private.h:282)
==30989== by 0xDDE3A5E: _ecore_idle_enterer_call (ecore_idle_enterer.c:174)
==30989== by 0xDDE836B: _ecore_main_loop_iterate_internal (ecore_main.c:2261)
==30989== by 0xDDE67B8: ecore_main_loop_begin (ecore_main.c:1284)
==30989== by 0x4407B6: main (e_main.c:1087)
==30989== Block was alloc'd at
==30989== at 0x4C2AA98: calloc (vg_replace_malloc.c:711)
==30989== by 0x882B0A0: _evas_common_rgba_image_new (evas_image_main.c:295)
==30989== by 0x87B1F1B: _evas_cache_image_entry_new (evas_cache_image.c:253)
==30989== by 0x87B4170: evas_cache_image_data (evas_cache_image.c:1079)
==30989== by 0x23BA7EDE: evas_gl_common_image_new_from_data (evas_gl_image.c:333)
==30989== by 0x23B7F972: eng_image_new_from_data (evas_engine.c:531)
==30989== by 0x23B80D81: eng_image_data_put (evas_engine.c:984)
==30989== by 0x872681A: _evas_image_data_set (evas_object_image.c:1264)
==30989== by 0x87360B5: evas_obj_image_data_set (evas_image.eo.c:236)
==30989== by 0x8736B43: evas_object_image_data_set (evas_image.eo.c:741)
==30989== by 0x4820A4: e_comp_object_render (e_comp_object.c:3746)
==30989== by 0x477B92: _e_comp_object_pixels_get (e_comp_object.c:909)
==30989== by 0x872CF52: evas_process_dirty_pixels (evas_object_image.c:3154)
==30989== by 0x872DD16: _evas_image_render (evas_object_image.c:3389)
==30989== by 0x872DB01: evas_object_image_render (evas_object_image.c:3351)
==30989== by 0x879C524: evas_render_mapped (evas_render.c:1802)
==30989== by 0x879E82A: evas_render_updates_internal_loop (evas_render.c:2380)
==30989== by 0x87A005D: evas_render_updates_internal (evas_render.c:2770)
==30989== by 0x87A140D: evas_render_updates_internal_wait (evas_render.c:3122)
==30989== by 0x87A1502: _evas_canvas_render_updates (evas_render.c:3144)
==30989== by 0x871ED0D: evas_canvas_render_updates (evas_canvas.eo.c:354)
==30989== by 0x8720C5F: evas_render_updates (evas_canvas.eo.c:1089)
==30989== by 0x22F65C35: _ecore_evas_drm_render (ecore_evas_drm.c:1072)
==30989== by 0x7416F7B: _ecore_evas_idle_enter (ecore_evas.c:172)
==30989== by 0xDDE3577: _ecore_call_task_cb (ecore_private.h:282)
==30989== by 0xDDE3A5E: _ecore_idle_enterer_call (ecore_idle_enterer.c:174)
==30989== by 0xDDE836B: _ecore_main_loop_iterate_internal (ecore_main.c:2261)
==30989== by 0xDDE67B8: ecore_main_loop_begin (ecore_main.c:1284)
==30989== by 0x4407B6: main (e_main.c:1087)
Change-Id: I5faae68f4d043c257c0fe56047c6329c5299440c
JEONGHYUN YUN [Tue, 20 Sep 2016 06:49:28 +0000 (15:49 +0900)]
embryo : Prevent buffer overflow in embryo_cc_sc2
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
Change-Id: I2ae18f89f0406979749c2dde4fd5299c5662ecc3
Youngbok Shin [Mon, 19 Sep 2016 10:17:01 +0000 (19:17 +0900)]
ecore_evas_wayland: Add NULL checking before using surface
@tizen_fix
Change-Id: I7fabb0bf19f9fb8854d053770b569d4bafaccfd2
Ji-Youn Park [Tue, 20 Sep 2016 05:14:59 +0000 (13:44 +0830)]
ecore_evas_wayland_common: pointer ee can be null.(svace:24115)
Pointer 'ee' which was dereferenced at ecore_evas_wayland_common.c:1472
is compared to NULL value at ecore_evas_wayland_common.c:1475.
Change-Id: I70b7708ef8f4e31429ce4bfaae999214e7a7b36c
Ji-Youn Park [Tue, 20 Sep 2016 04:42:40 +0000 (13:12 +0830)]
ecore_evas_wayland_common: fix dereferenced bug
Pointer 'ee' which was dereferenced at ecore_evas_wayland_common.c:687 is compared to NULL value at ecore_evas_wayland_common.c:693.
Change-Id: If9bb60cc57106b3b284b2448cdbf402dbd929910
JEONGHYUN YUN [Tue, 20 Sep 2016 04:05:22 +0000 (13:05 +0900)]
embryo_cc_sc1 : Prevent string overflow
Signed-off-by: JEONGHYUN YUN <jh0506.yun@samsung.com>
Change-Id: I28fadd87d0157ded8c6e958274eb0fe798b4112a
WooHyun Jung [Tue, 20 Sep 2016 02:18:52 +0000 (11:18 +0900)]
eldbus: null checking before using the pointer
Change-Id: Ic9ff43257bf21cc7bcb880e0dc05dc7f39ce5950
Signed-off-by: WooHyun Jung <wh0705.jung@samsung.com>
Woochan Lee [Tue, 20 Sep 2016 01:27:13 +0000 (10:27 +0900)]
Prevent Null pointer reference.
WGID: 83722
Change-Id: I01f1ccfcf7d860e9c06abf9e2e14d996ea24e772
Jaehyun Cho [Mon, 19 Sep 2016 10:46:27 +0000 (19:46 +0900)]
edje_svg_loader: Initialize char array.
Initialize char array before calling strcmp().
Change-Id: I3590760e611ca8af1e821d745c62cb90ab01c6e6
Ji-Youn Park [Mon, 19 Sep 2016 08:42:58 +0000 (17:12 +0830)]
evas_object_image: fix alpha_set bug.
if image object's first alpha value is false, evas_object_image_alpha_set function did not work.
opaque_valid is always 1 even though has_alpha value changed.
opensoure_commit
fc0c0a6e0b967fb283f121ee38d396e848e4f73e
Author: Ji-Youn Park <jy0703.park@samsung.com>
Date: Mon Sep 19 17:02:40 2016 +0830
Change-Id: I2c032ec0135bdca7d4a607c9b2a531c799ddf42c
Jee-Yong Um [Wed, 7 Sep 2016 12:45:38 +0000 (21:45 +0900)]
edje_cc: remove after programs lookup when removing program
Signed-Off-By: Jee-Yong Um <jc9.um@samsung.com>
Change-Id: I2c5b474519e8baa3fd32c6ec9a91a802046b567b
Jee-Yong Um [Tue, 10 May 2016 22:46:55 +0000 (15:46 -0700)]
edje_cc: cleanup queued jobs for removed program
Summary:
When a new edje program is created, some jobs like lookup part
(Part_Lookup) or compiling embryo script (Code_Program) are queued.
If program is removed, queued jobs should be removed also.
Reviewers: jpeg, cedric
Reviewed By: cedric
Differential Revision: https://phab.enlightenment.org/D3900
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Change-Id: I349090630706e5e4c3cb43feb251b776e2f9c19a
Hermet Park [Mon, 12 Sep 2016 08:10:25 +0000 (17:10 +0900)]
commit
e8fcc41e40dee07d062bff51636e464ff9d98215
Author: Hermet Park <hermet@hermet.pe.kr>
Date: Mon Sep 12 16:50:00 2016 +0900
evas map: fix the rendering problem.
I got an issue report about map rendering.
After investigated, I found that was introduced by data overflow.
For fast computation, evas map uses integer data type rather than float,
that gives up some range of data size.
So, if vertex range is a little large but still reasonable,
polygon won'be properly displayed due to the integer overflow.
We can fix this by changing FPc data type to 64 bits (ie, long long)
But I didn't do yet though I can simply fix this costlessly.
By the way, my test case map points are below.
0: -1715, -5499
1: -83, -1011
2: 1957, 5721
3: 325, 1233
and gl result is perfect but sw is totally broken.
@fix
Change-Id: I04c1f61556c67553486588cc7a59c83b96371cd8
Youngbok Shin [Wed, 7 Sep 2016 10:53:12 +0000 (19:53 +0900)]
edje: Apply color_class to TEXTBLOCK part's style
Summary:
Applying color_class to TEXTBLOCK part's description will
change every color of textblock.
(Base text color, tag's color, colored emoticon's color and etc)
So, if we want to control only base text color using color_class,
color_class should modify color from textblock's style. Just like
text_class in textblock's style.
Test Plan:
1. Run elementary_test -to "entry"
2. Modify color fields and click "Apply" button.
3. See how entry's color is changed.
Reviewers: raster, cedric, tasn, herdsman, woohyun
Subscribers: akanad, z-wony, Blackmole, jpeg
Differential Revision: https://phab.enlightenment.org/D4283
@tizen_fix
Change-Id: I495d9ebb2d6ca603a3a3bf871466336d7a8cb1f3
JengHyun Kang [Fri, 9 Sep 2016 02:10:14 +0000 (11:10 +0900)]
ecore_wayland: Always send move event when touch down event is occurred.
Change-Id: Ice1680c03d84762928f91afc3d0f801a61ac04a7
Jaehyun Cho [Tue, 13 Sep 2016 08:49:36 +0000 (17:49 +0900)]
edje: Fix memory overflow on svg loader.
Initialize temporary index not to cause memory overflow on svg loader.
Change-Id: Ib95740c27b09d1cb480eb94609d9d5cab7a0db4f
Mykyta Biliavskyi [Sun, 11 Sep 2016 17:15:50 +0000 (20:15 +0300)]
Ecore_con_ssl: fix return value of ecore_con_ssl_client_upgrade.
In case when _ecore_con_ssl_client_init_(gnutls/openssl) finished
successful a enum ECORE_CON_SSL_ERROR_NONE value (0) returned. Function
ecore_con_ssl_client_upgrade return Eina_Bool and in case of success
EINA_FALSE was returned.
@fix
Change-Id: I2d01fff438d9f27793d39410ffaf0b522312a46d
Signed-off-by: Mykyta Biliavskyi <m.biliavskyi@samsung.com>
Cedric BAIL [Mon, 12 Sep 2016 18:19:10 +0000 (11:19 -0700)]
eio: properly track destruction of all Eet eio request.
@fix T4550
Change-Id: Ic18a46f1c0decf5d4ab41e4cebba28fa714ec0cc
Signed-off-by: Mykyta Biliavskyi <m.biliavskyi@samsung.com>
Jean-Philippe Andre [Wed, 17 Aug 2016 07:45:16 +0000 (16:45 +0900)]
evas: Fix region test in jpeg load with region + zoom
The previous commit exposed an issue with the region test
does not take into account the scale down factor.
Not a @fix in itself, as it depends on the previous patch.
Change-Id: Ifb13aa0985989b240e8006b55ae92d616d929cb5
jiin.moon [Fri, 19 Aug 2016 03:09:31 +0000 (12:09 +0900)]
emile: fix jpeg loader broken with orientation
Summary:
After applying a patch regarding region, side-effect detected.
Fixes T4390
Test Plan: make check
Reviewers: jpeg, cedric, jypark
Maniphest Tasks: T4390
Differential Revision: https://phab.enlightenment.org/D4245
Change-Id: I00f25d621d983eac2fc206c53ae5eda6ad046bed
jiin.moon [Fri, 19 Aug 2016 05:16:39 +0000 (14:16 +0900)]
evas: Fix an issue with 4bit RLE image
Without this patch, BMP loader can't region decode with 4bit RLE image
Change-Id: Ib16f5c6aba4a8d537b1fc7bde744df426f3daf47
Signed-off-by: jiin.moon <jiin.moon@samsung.com>
Jean-Philippe Andre [Wed, 17 Aug 2016 08:21:33 +0000 (17:21 +0900)]
evas: Fix BMP load with region set and scale down
This fixes usage of photocam on large BMP images.
Follows previous commits by @jiin.moon.
Change-Id: I34cb2801518e582f24b98a2a4da397b6d629e757
jiin.moon [Wed, 17 Aug 2016 07:06:05 +0000 (16:06 +0900)]
evas: Support region_set for BMP image
Summary:
1) BMP loader support region decoding.
@feature
2) Fix an issue what BMP loader can't decode an 16bit image with bit field
@fix
Test Plan: attached sample codes
Reviewers: cedric, jpeg, jypark
Differential Revision: https://phab.enlightenment.org/D4228
Change-Id: I228c52c00bd5e4bb51aab3796a9eead2f9b3bcfe
Jean-Philippe Andre [Wed, 17 Aug 2016 07:45:16 +0000 (16:45 +0900)]
evas: Fix region test in jpeg load with region + zoom
The previous commit exposed an issue with the region test
does not take into account the scale down factor.
Not a @fix in itself, as it depends on the previous patch.
Change-Id: I0fd33338496b0ce36e8ecbc4ba86dd2b619ab280
jiin.moon [Sat, 30 Jul 2016 02:10:28 +0000 (11:10 +0900)]
PNG loader support region_set when decoding
Summary:
PNG loader support region_set when decoding
@feature
Reviewers: cedric, jpeg, jypark, raster
Subscribers: raster
Differential Revision: https://phab.enlightenment.org/D4165
Change-Id: Idc4c6dae1e3e5235d631832a47ad768dc715599c
jiin.moon [Wed, 17 Aug 2016 07:39:13 +0000 (16:39 +0900)]
emile: region_set does not working in jpeg loader if scale_down has set
Summary:
If both region and scale_down has set, ERR would be returned by loader of jpeg.
@fix
Test Plan: sample code
Reviewers: raster, jypark, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D4200
Change-Id: Ie4df52f8858c014b5a243c79dbb5110d11d717be
Chris Michael [Tue, 29 Sep 2015 16:02:15 +0000 (12:02 -0400)]
ecore-wl2: Add API function to set a dnd selection
Change-Id: I4ccc0400197222dcfcc52e460ac87930fe6bbf8d
Signed-off-by: Chris Michael <cp.michael@samsung.com>
WooHyun Jung [Mon, 12 Sep 2016 01:09:32 +0000 (10:09 +0900)]
embryo_cc: fix memory overflow in str
After for-loop i can have value 11. So the str should be longer than 11.
@fix
Change-Id: I63649dc018d08ca1d7a61baaebd8fa098b43dbdd
Signed-off-by: WooHyun Jung <wh0705.jung@samsung.com>
Jee-Yong Um [Thu, 1 Sep 2016 11:08:55 +0000 (20:08 +0900)]
edje_cc: add lookup for inherited after program
Summary:
"after" program inherited from inherit_only group does not have original
program lookup, but _edje_program_copy() doesn't consider this case.
When it fails to copy program lookup, new program lookup should be appeded.
@fix
Test Plan: make attached program and run
Reviewers: cedric, jpeg, Hermet
Reviewed By: Hermet
Subscribers: taxi2se
Differential Revision: https://phab.enlightenment.org/D4253
Change-Id: I0abc4ad89688e408d2e56d202dba90a6f2cee570
Ji-Youn Park [Thu, 8 Sep 2016 08:06:34 +0000 (16:36 +0830)]
evas_tbmbuf: hotfix to update full area when start time
Change-Id: Ie1bdfa25291804569a4785bb7b456c32bb089ac9
Ji-Youn Park [Thu, 8 Sep 2016 02:46:23 +0000 (11:16 +0830)]
evas_render: fix clipping the whole area in each rendering.
evas_render should not be going and doing evas_object_clip_set () at all.
The framespace clip should be enforced at RENDER time.
Change-Id: I94d2f006ce23ce15523627e31308280a3a10782f
opensource: commit
7ce79be1a1748c32c4d0e58358ce2242902cf89b
Author: Ji-Youn Park <jy0703.park@samsung.com>
Date: Thu Sep 8 09:56:30 2016 +0830
Cedric BAIL [Thu, 21 Jul 2016 18:17:30 +0000 (11:17 -0700)]
edje: allow inheritance from an aliased group.
Change-Id: I004227be5443dbf2e6e79bc9410b76be5d725c57
Jee-Yong Um [Tue, 31 May 2016 23:46:36 +0000 (16:46 -0700)]
edje_cc: fix SIGNAL_EMIT action inheritance error
Summary:
When edje group inherits edje program whose action type is SIGNAL_EMIT
with target, unnecessary parse error occurs.
Reviewers: raster, cedric
Reviewed By: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D3982
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Change-Id: I657da960e1d8ccd69dcf758a8dad39698cdcc2f0
Jee-Yong Um [Fri, 15 Apr 2016 18:14:31 +0000 (11:14 -0700)]
edje_cc: delete anonymous lookup during program removal
Summary:
program_remove attribute allows to remove program inherited from
parent group, but if its action is EDJE_ACTION_TYPE_SCRIPT,
anonymous lookup also should be deleted.
@fix
Reviewers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D3875
Signed-off-by: Cedric Bail <cedric@osg.samsung.com>
Change-Id: Id96e26e525d58efbbb3d4563335fc8adbcfca88a
Jee-Yong Um [Tue, 29 Mar 2016 08:35:04 +0000 (17:35 +0900)]
edje_cc: fix parsing error when some keywords are used as part name
Summary:
Some keywords cause parsing error when they are used as part name.
For example,
group { "some_group";
parts {
box { "box";
}
}
}
The part name "box" should be processed by wildcard handler,
but this is pushed into stack. (collections.group.parts.part.box ...)
This patch pushes token into stack only when it doesn't have quotes.
@fix
Reviewers: cedric, raster, jpeg
Reviewed By: jpeg
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D3841
Change-Id: I9efad97139ccab6361c5d420b274f86be67b5e74
Jee-Yong Um [Wed, 7 Sep 2016 08:13:24 +0000 (17:13 +0900)]
edje_cc: fix inheriting script from other group
Summary:
If a group inherits from the other, group script block is copied
only when there are program script blocks in parent group.
This patch makes edje_cc always copies group script block,
but allows to override group script block in child group.
The content of reverted D3799 is included. That reveals this inconsistency.
Reviewers: cedric
Subscribers: Jaehyun_Cho, woohyun, jpeg
Differential Revision: https://phab.enlightenment.org/D3802
Change-Id: I047fda5a8b40d41a4262a8d499e117e08bfa2d94
Hermet Park [Tue, 6 Sep 2016 07:56:25 +0000 (16:56 +0900)]
evas canvas: fix a wrong condition check in smart changed.
There were 2 wrong conditions.
1. visible check.
Smart changed can be skipped only if previous/current visibility are false.
2. clipper.
Actually, it needed to check previous/current clippers but previously,
it checked only previous clippers.
@fix
Change-Id: Ie6907e23ab3032176687eb57c37d0be79def62f0
Jaehwan Kim [Wed, 7 Sep 2016 05:01:51 +0000 (14:01 +0900)]
edje: add missed break in the switch construction.
Conflicts:
src/bin/edje/edje_cc_handlers.c
Change-Id: I9524be15484f74a4f80905edde7686879ae46949
Sung-Jin Park [Tue, 6 Sep 2016 01:42:45 +0000 (10:42 +0900)]
ecore-drm : add ECORE_DRM_SKIP_LAUNCHER_CONNECT environment variable
Add an environment variable to skip to connect to drm launcher.
Except the desktop environment, it's not necessary to connect to drm launcher.
If necessary, we can control whether to connect to drm launcher with this environment.
Change-Id: I628f7fa5771bc72af03c4ea1564a762bcfe0a2f7
Signed-off-by: Sung-Jin Park <sj76.park@samsung.com>
Youngbok Shin [Mon, 11 Jul 2016 04:13:38 +0000 (13:13 +0900)]
edje: update a style when a style is added as class's member
Summary:
If there is no member styles when a text_class is updated,
newly added styles can't be updated.
So, newly added styles as member of text_class should be updated.
@fix
Test Plan:
Test case is included.
1. Run "elementary_test -to "font overlay""
2. Press Next button. Check the font size.
3. Press Prev button.
4. Put font_size as 50
5. Click Apply button.
6. Press Next button. Check the font size is not changed.
Reviewers: cedric, tasn, herdsman, raster
Subscribers: jpeg, z-wony, Blackmole
Differential Revision: https://phab.enlightenment.org/D4125
Change-Id: I9a791300dcd8dbe2f7ea154a79a6852766484c8f
Signed-off-by: Youngbok Shin <youngb.shin@samsung.com>
Youngbok Shin [Mon, 5 Sep 2016 04:41:09 +0000 (13:41 +0900)]
Revert "edje: update a style when a style is added as class's member"
This reverts commit
09e0273e27403d178c3e7cbcef7efeaec44c2af8.
Change-Id: I8b0d6efe673409943dd79ba206a125467034d5d8
Signed-off-by: Youngbok Shin <youngb.shin@samsung.com>
Subhransu Mohanty [Tue, 6 Sep 2016 04:29:43 +0000 (13:29 +0900)]
svg: ported svg change from opensource
Change-Id: I74f048e42bac243b7da99f805800556b17b5923d
Mike Blumenkrantz [Wed, 11 May 2016 17:29:51 +0000 (13:29 -0400)]
ecore-evas: call application-set focus functions if no engine functions exist
in the case where an engine has no real concept of focus (eg. drm), no engine
functions will be implemented, resulting in calls to focus_set having no effect.
this leads to elm/applications being unable to receive the callbacks they expect
when calls to the overall api are made, resulting in focus being broken
probably this should also be done for the rest of the api functions too
@fix
Change-Id: Ie3dfa6518d9b7375a65a9ff1c963715ecaff47ab
Signed-off-by: Mykyta Biliavskyi <m.biliavskyi@samsung.com>
Minchul Lee [Fri, 2 Sep 2016 03:49:37 +0000 (12:49 +0900)]
ecore_wl: modify the length of read buffer
Change-Id: I8955f50f840799da8e1075207a590783454405d9
Jaehyun Cho [Fri, 2 Sep 2016 05:23:52 +0000 (14:23 +0900)]
spec: Set build option --with-tests=none
Change build option from --with-tests=regular to --with-tests=none
because test build is not needed.
Change-Id: Ic47f488fed68eb80556cca9b661199d164ab14b3
Joogab Yun [Fri, 26 Aug 2016 06:09:12 +0000 (15:09 +0900)]
[evas gl] does not use frame callback on gl backend
because evas wait so long for frame callback after
eglSwapBuffers.
This cause the performance decline.
but It is still necessary in the sw backend for render sync
so, I modified only gl backend
Change-Id: I4c5d4d1f169e936a7ef0901d54d3782ba1f7c624
Jean Guyomarc'h [Fri, 16 Oct 2015 08:19:57 +0000 (10:19 +0200)]
ecore_cocoa: fix live resize of windows
This was a tricky little bastard!
When a window is live resized, the NSWindow which is the target of
the live resize will wait for a kevent from the window manager,
until live resizing is done. So... live resizing is synchronous
and blocks the main thread... hence ecore_main_loop.
- When live resize starts, the Ecore_Timer which polls NSRunLoop
is paused.
- When the window is resized, the ecore_main_loop is run manually
with ecore_main_loop_iterate() to process Ecore events (mostly
Ecore_Evas)
- When live resize finished, the Ecore_Timer which polls NSRunLoop
is resumed.
@fix
Change-Id: I926f619cb0cb14533d968456db6861db759331df
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Fri, 16 Oct 2015 07:53:26 +0000 (09:53 +0200)]
ecore_cocoa_app: don't override init
Change-Id: I321f90cd04dc415c53d60f236e8bf5c032ac4c81
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Thu, 15 Oct 2015 12:06:13 +0000 (14:06 +0200)]
ecore_cocoa: don't make ecore_cocoa_feed_events() a public API
Change-Id: Ia1403f5cc1535274e5c62359b3a99f147d41608b
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Thu, 15 Oct 2015 12:02:44 +0000 (14:02 +0200)]
ecore_cocoa: NSApp must be configured in the App wrapper
Change-Id: Ib5c424605eae8a593dd683b290889a80b8620d0b
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Thu, 15 Oct 2015 11:58:52 +0000 (13:58 +0200)]
ecore_cocoa_window: cosmetic changes
Change-Id: Ib127722cfbb906808f5617a2ac6e4bc65f5af875
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Thu, 15 Oct 2015 09:45:41 +0000 (11:45 +0200)]
ecore_cocoa: don't export Ecore_Cocoa_Keys.h
Change-Id: Id477644a9b469c6b70b7c280bc891112e47d2b57
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Thu, 15 Oct 2015 09:13:53 +0000 (11:13 +0200)]
ecore_cocoa: factorize code
Change-Id: I254bce4a7f8e5fd5ac0ad01bcc9d7ae98a8420ee
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Thu, 15 Oct 2015 08:47:42 +0000 (10:47 +0200)]
evas_gl_cocoa: make sure focus is always unlocked after locking it
Change-Id: Ib14f1af3a4c78e5b51aef5d5231d283cab476005
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Thu, 15 Oct 2015 08:41:38 +0000 (10:41 +0200)]
ecore_cocoa_cnp: make API thread-safe
Change-Id: I58c20669c215f4f232dffc4b969a2ad9cae26e9e
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Thu, 15 Oct 2015 08:38:53 +0000 (10:38 +0200)]
ecore_cocoa_cnp: clear the clipboard only if writable
Change-Id: I7abeced6cde6290b6b1540a2cf0ba2410e64a7a1
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Wed, 14 Oct 2015 11:39:39 +0000 (13:39 +0200)]
ecore_cocoa: NSEvent modifiers are of type NSUInteger
Change-Id: Ib78d894e8442453583d0aebd4b01fe3fb39f3506
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Wed, 14 Oct 2015 11:26:16 +0000 (13:26 +0200)]
ecore_evas_cocoa: factorize code
Change-Id: I12b7f57df00d9f0800e7a40a3c3a9e032b3f91de
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Wed, 14 Oct 2015 08:27:05 +0000 (10:27 +0200)]
ecore_cocoa: report error when [super init] fails
Change-Id: If0a27b021fa15c550eaa81cc0cfa6dd661d6c0fd
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Wed, 14 Oct 2015 07:44:15 +0000 (09:44 +0200)]
ecore_evas_cocoa: remove dead code
Change-Id: Ie99a982a8c5c71bbe1e10779cb4a43638d22a0f5
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Wed, 14 Oct 2015 07:41:08 +0000 (09:41 +0200)]
ecore_cocoa: remove EINA_UNUSED because parameter is used
Change-Id: I3b30d5f7868a034ed61e3f98eb1f5e56cc556278
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Wed, 14 Oct 2015 07:40:07 +0000 (09:40 +0200)]
ecore_cocoa: remove debug log
Change-Id: I215a3fab2b009212ef5a1ca3463862b4e25de533
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Wed, 14 Oct 2015 07:32:20 +0000 (09:32 +0200)]
ecore_cocoa: reindent file
Change-Id: Ib5cf1cc177c5d8256985c4078585f3e57ee4c7dc
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Wed, 14 Oct 2015 07:31:45 +0000 (09:31 +0200)]
ecore_cocoa: add more safety checks
Change-Id: Icb68f05cb56bd91e37fdbddcf477fe54149bf91d
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Wed, 14 Oct 2015 07:18:06 +0000 (09:18 +0200)]
ecore_cocoa: remove EINA_UNUSED because parameter is actually used
Change-Id: Ib2d092cce23f90ec6a6e92ba741993014a55fe57
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Jean Guyomarc'h [Wed, 14 Oct 2015 07:08:38 +0000 (09:08 +0200)]
ecore_cocoa: prevent Ecore_Cocoa_Window to be re-defined
Change-Id: I40f88728e0a22d75a189b36e17eb2f6127ca59c3
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>