JunsuChoi [Fri, 5 Oct 2018 07:56:09 +0000 (16:56 +0900)]
elm_genlist: prevent null pointer access
Summary: it->item->block can be null. so add null check.
Test Plan: elementary_test -to "genlist show/bring"
Reviewers: SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7146
Change-Id: Idca2dd57900380b9952558926ed66c02701b7b39
JunsuChoi [Thu, 4 Oct 2018 12:27:29 +0000 (21:27 +0900)]
ecore_con_legacy: fix coverity issues (use after free)
Summary:
for hard failures (highly unlikely), the handle would be deleted and the next use would crash.
Test Plan: N/A
Reviewers: Jaehyun_Cho, zmike, cedric, bu5hm4n
Subscribers: bu5hm4n, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7139
Change-Id: I9de4952abadfad4f92ee2a5e316c0146d2cfd8c7
WooHyun Jung [Sat, 6 Oct 2018 07:42:45 +0000 (16:42 +0900)]
evas_events : last_mouse needs to be used even pdata is founded
In some cases, unexpected pdata is founded and all the logics in
evas_events are conflicted becuase of failure in pdata matching.
For example, mouse_down and mouse_up use the same ev->device, but
mouse_move uses the different one.
This only can be happened in Tizen, so just keep it as Tizen Only
Fix.
@hosang will improve this patch to keep the last_mouse not per evas
but per seat.
@tizen_fix
Change-Id: Ic80a36b4c8c1a3431f97099f397d5da6f84e7324
Hosang Kim [Fri, 5 Oct 2018 11:01:18 +0000 (20:01 +0900)]
efl_ui_clock: Prevent NULL pointer reference.
When _elm_datetime_items_get() calling with only time format after
datetime creation.
The location has been swapped. so some of sorted_field index address
gets a invalid
address. then it makes a crash.
@tizen_fix
Change-Id: I34856201bc9ed5a4adc2c6aeb2693a294e7b4430
Joogab Yun [Fri, 5 Oct 2018 07:06:18 +0000 (16:06 +0900)]
evas : bug fixed about missing gl_context
Change-Id: I03fe2aa347aa741e0b90003917a4f0c9e91a7e6a
Jaeun Choi [Fri, 5 Oct 2018 06:38:28 +0000 (15:38 +0900)]
edje: fix null pointer access bug
Change-Id: Ifac6693f2ae5d27fa99c28d901a28196ae59bc9f
Taehyub Kim [Thu, 4 Oct 2018 12:47:11 +0000 (21:47 +0900)]
efl_selection_manager: skip other process's send event
Change-Id: I0d187f4893beca1c1af431fe2dc3ed71bd7940a8
Jaehyun Cho [Thu, 4 Oct 2018 07:50:21 +0000 (16:50 +0900)]
elm_theme: fix return value when default style fallback is done
To keep backward compatibility, EFL_UI_THEME_APPLY_DEFAULT is returned
instead of EFL_UI_THEME_APPLY_SUCCESS if style is not found in theme and
default style fallback is done instead.
This patch fixes
7353fc1cb85e08eb6e884ed8bbf9a009226069b6
@fix
Change-Id: I012a310c9c98b0c15e667fe9846e62b4c480b305
Youngbok Shin [Thu, 4 Oct 2018 09:58:04 +0000 (18:58 +0900)]
eina debug: fix a double unlock issue
Summary:
It was caught by Covertity.
This patch will remove a potential double unlock issue.
@fix
Test Plan: N/A
Reviewers: zmike, raster, cedric, Hermet, eagleeye
Reviewed By: eagleeye
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7137
Change-Id: I290009b92ed961d662c6d1549de92644647f4dee
Youngbok Shin [Thu, 4 Oct 2018 09:53:36 +0000 (18:53 +0900)]
elementary entry: apply scale to all edje objects
Summary:
When an entry is scrollable, its resize object is scr_edje.
So, to apply scale properly, elm_entry needs to apply scale
to its entry_edje, too.
@fix
Test Plan: Apply scale to scrollable entry
Reviewers: herdsman, woohyun, cedric, eagleeye
Reviewed By: eagleeye
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7140
Change-Id: I09f546a70ed306a5a08ec37728478729a3c2d793
Bowon Ryu [Tue, 2 Oct 2018 10:24:28 +0000 (19:24 +0900)]
efl_page_transition_scroll: fix warning the dereference before null check
Summary: if target is null, then terminate the function because it is not intended.
Test Plan: N/A
Reviewers: eunue
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7127
Change-Id: Ia7f78e5a8a5e246623afee94231cc128df88d965
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Jiyoun Park [Tue, 2 Oct 2018 09:53:16 +0000 (18:53 +0900)]
ecore_evas_extn: check error case if bind result is null
Change-Id: I3b75aa56aa8bb405f5234fc52327d720e7f91f41
Hosang Kim [Mon, 1 Oct 2018 11:29:26 +0000 (20:29 +0900)]
slider: add "slider,drag,start/stop" smart callbacks.
These callbacks are missing, when we merge codes.
Change-Id: Ie6b2f40cf47dd887b0fdb049af8e3dad7852a6e2
Hermet Park [Mon, 1 Oct 2018 12:06:36 +0000 (21:06 +0900)]
evas gl: fix invalid image size.
Summary:
When we reset of texture for a valid object,
this object cache size become -1 x -1 with null texture.
Later, we reset a new texture of the object,
Its texture size could be -1 x -1.
That brings to incorrect result drawing.
Can't see any points of using cache size there.
This bug was introduced by
9e01cf2698d5b24f440d696fd57d469cdc5a6b5f
@fix
Reviewers: #committers, raster
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7077
Change-Id: I210e31954ce347efa96197370dc63fc51a149f02
Jaeun Choi [Fri, 28 Sep 2018 14:43:34 +0000 (23:43 +0900)]
evas_textblock_hyphenation: remove incorrect expression
dict->cset is an array, not a pointer, thus is never NULL.
this was discovered by coverity.
upstream patch: https://phab.enlightenment.org/D7121
Change-Id: I0c1ebe264d1d2ecfb2197ccb7e4f57cbf12736de
Hosang Kim [Mon, 1 Oct 2018 04:02:42 +0000 (13:02 +0900)]
efl_ui_image: remove ecore job temporarily.
When we use ecore_job, it increases usage of graphic memory.
Until find a real cause, remove ecore job teomporarily.
@tizen_only
Change-Id: I26143d628e060d70b7e785b003b76e4f15ac2915
Jiyoun Park [Mon, 1 Oct 2018 01:05:34 +0000 (10:05 +0900)]
ecore_wl2_window: fix migration side effect
Before code: if ((win->surface) && (win->display->wl.efl_aux_hints))
Wrong code: if ((!win->surface) && (!win->display->wl.efl_aux_hints))
Modified code:if ((!win->surface) || (!win->display->wl.efl_aux_hints))
Change-Id: I7fe97cd9eded322d2238452bf7fb5520ba712814
Yeongjong Lee [Mon, 1 Oct 2018 02:11:57 +0000 (11:11 +0900)]
efl_selection: add return value check for fwrite
Summary: found by coverity
Reviewers: raster, Hermet
Subscribers: Hermet, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7109
Hosang Kim [Fri, 28 Sep 2018 11:53:31 +0000 (20:53 +0900)]
eldbus: remove unreachable code.
Coverity doesn't like this unreachable code.
https://phab.enlightenment.org/D7120
@fix
Change-Id: I87eec8aede73d34bf3a107c003cb6d739dd52852
Hermet Park [Fri, 28 Sep 2018 11:35:19 +0000 (20:35 +0900)]
evas vg: +legacy api
evas_object_vg_file_set()
Change-Id: Ief22caae2551969a7716f8497d1f1ef5ee40e5ec
Hermet Park [Fri, 28 Sep 2018 10:49:46 +0000 (19:49 +0900)]
evas vg: add two legacy apis.
evas_object_vg_animated_frame_duration_get()
evas_object_vg_animated_frame_get()
Change-Id: I57d9b01a927076d077d4af8e8e78d462d535a94e
Youngbok Shin [Fri, 28 Sep 2018 10:01:27 +0000 (19:01 +0900)]
elementary bg: revert scale disable patch to support bg_option functions
It was applied to fix scale policy issue.
The patch was disabling scale by elm_objeect_scale_set with 0.0~#.
But, it also disabled image scale feature which is used for bg_option functions.
So, it has to be reverted and revised for elm_object_scale_set() problem.
@tizen_fix
Change-Id: I6eb44d0a8eb1c1cd35b067ffa6745dc99df8cfab
Jiyoun Park [Fri, 28 Sep 2018 09:07:01 +0000 (18:07 +0900)]
evas_object_textblock: fix warning the dereference before null check
Change-Id: I1e473357002b8b012d42c961de8861a51351f27e
Carsten Haitzler (Rasterman) [Sat, 17 Feb 2018 09:00:19 +0000 (18:00 +0900)]
elm entry - dont seg if the obj has been deleted by callback time
i spotted a segv with elm entry + efm ... sd was NULl because obj was
seemingly not valid at that point, so fix and check the smart data
returns before moving on.
Change-Id: Id8e52679c1e6ba0dd7ed0d6651a42fb68de2b1ca
Yeongjong Lee [Fri, 28 Sep 2018 07:13:39 +0000 (16:13 +0900)]
edje: call recalc in part_text_get if there is no available text data
Summary:
If edje_text_get is called before any edje_text_set function call, it return
null, because rp->typedata.text->text is only set by edje_text_set function.
If there is no available text data, find it from rp(edc).
ref
7bbf18a950c027a365fea1b88e8dc3f16bb81abe
Test Plan: make check
Reviewers: zmike, id213sin, herdsman
Reviewed By: id213sin
Subscribers: Hermet, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6961
Change-Id: Ife4c30a23b90c0b41dbf2da2240c922cb8ae4cf2
Hosang Kim [Fri, 28 Sep 2018 06:39:18 +0000 (15:39 +0900)]
elm_interface_scrollable: fix using wrong variable.
vy isn't initialized when p >1.0 or p<0.
https://phab.enlightenment.org/D7114
@fix
Change-Id: If294ef7b96a18863490b1ae703ce42ad716e9ca1
Youngbok Shin [Fri, 28 Sep 2018 06:31:50 +0000 (15:31 +0900)]
edje vector: fix wrong implementations from the Edje json support patch
Change-Id: Ic359f3cd2aa07269331bb37d60aa5f4fb4e9bc7b
Yeongjong Lee [Thu, 27 Sep 2018 00:30:59 +0000 (09:30 +0900)]
ecore_audio_obj_out_tizen: check efl_key_data_get return
Found by coverity
Change-Id: I1301d9481d9ef3c7cef49b7ac0b59f85ec7ed136
JunsuChoi [Thu, 27 Sep 2018 09:22:22 +0000 (11:22 +0200)]
ecore_con: Add docs for ecore_con legacy functions
Summary:
Find docs of missing legacy functions
from 9c33623(ecore: add ecore_con_url_ssl_ca_set.),
40edc9c(ecore: add ecore_con_url_ssl_verify_peer_set patch by Raoul Hecky.)
and add them.
Test Plan: make doc
Reviewers: cedric, Hermet, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7117
JunsuChoi [Thu, 27 Sep 2018 09:12:46 +0000 (11:12 +0200)]
ecore_timer: Add docs for ecore_timer legacy functions
Summary:
Find docs of missing legacy functions
from 47cdbe3 and add them.
Test Plan: make doc
Reviewers: cedric, Hermet, segfaultxavi
Reviewed By: segfaultxavi
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7118
Jaehyun Cho [Fri, 21 Sep 2018 12:30:50 +0000 (12:30 +0000)]
efl_vg: calculate center point with double type
Although the center point is double type, the calculation is integer type.
To calculate center point correctly, calculate with double type.
Differential Revision: https://phab.enlightenment.org/D7097
Alastair Poole [Mon, 24 Sep 2018 10:26:23 +0000 (10:26 +0000)]
efreet_menu: remove unused and unreachable code.
Coverity doesn't like this unreachable code. This purges
efreet_menu of all unused code for the deprecated and
non-working menu_async methods. The warnings remain
at compile time and run time.
Differential Revision: https://phab.enlightenment.org/D7101
Yeongjong Lee [Thu, 27 Sep 2018 07:33:37 +0000 (07:33 +0000)]
efl_ui_stack: Partially Revert "efl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value"
This partially reverts commit
820dcb9cd975e93271977246aaf1b1a707435851.
top_cd can be NULL when cd->stack is NULL.
Thanks to bu5hm4n for reporting.
Differential Revision: https://phab.enlightenment.org/D7116
Yeongjong Lee [Thu, 27 Sep 2018 05:10:31 +0000 (14:10 +0900)]
eina_value: return null when eina_value_pget failed
Summary:
Add return value check.
found by coverity.
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7107
Yeongjong Lee [Thu, 27 Sep 2018 05:08:39 +0000 (14:08 +0900)]
elm_genlist: prevent null pointer access
Summary: found by coverity
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7108
Yeongjong Lee [Thu, 27 Sep 2018 04:58:08 +0000 (13:58 +0900)]
efl_exe: check fcntl return
Summary: Found by coverity
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7110
Yeongjong Lee [Thu, 27 Sep 2018 04:57:33 +0000 (13:57 +0900)]
efl_ui_stack: remove unnecessary condition of EINA_INLIST_CONTAINER_GET return value
Summary:
Becase EINA_INLIST_CONTAINER_GET always return true, it doesn't need to check
whether return value is null.
Reviewers: Jaehyun_Cho, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7112
Yeongjong Lee [Thu, 27 Sep 2018 04:55:20 +0000 (13:55 +0900)]
efl_ui_list: fix wrong variable usage
Reviewers: SanghyeonLee, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7113
Lauro Moura [Wed, 26 Sep 2018 15:01:49 +0000 (12:01 -0300)]
efl-csharp: Fix event struct marshalling.
Summary:
The efl.Event struct has a class field that gets generated normally but
can be problematic when marshalling the struct back from C to C#. The
compilation works fine but when C# runtime tries to marshall the C data
(e.g. accessing the Event.Info field), it becomes erratic, either
complaining about missing references to object or even segfault.
This commit changes the event handling code to use the
"Event_StructInternal" struct as is already done when receiving structs
from C code.
In order to work with other assemblies, the _StructInternal fields were
made publit too.
Fixes the events tests and the text editor app.
Test Plan: make check and run the text editor app in examples repo.
Reviewers: segfaultxavi, vitor.sousa
Reviewed By: vitor.sousa
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7106
Xavi Artigas [Wed, 26 Sep 2018 07:21:26 +0000 (09:21 +0200)]
docs: Fix Efl.Ui.Focus.Object.Focus() docs
Summary:
The same description was used for both the Setter and the Getter, which makes
no sense.
Reviewers: zmike, bu5hm4n, bryceharrington, devilhorns
Reviewed By: bu5hm4n, devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7071
Youngbok Shin [Mon, 24 Sep 2018 10:17:26 +0000 (11:17 +0100)]
elementary_test: use snprintf to prevent memory overflow in test_efl_ui_text
Summary: To prevent memory overflow, use snprintf instead of sprintf.
Test Plan: N/A
Reviewers: raster, cedric, zmike, Hermet, netstar
Reviewed By: netstar
Subscribers: netstar, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7095
Bryce Harrington [Fri, 21 Sep 2018 18:34:28 +0000 (14:34 -0400)]
eina: Improve doxygen formatting for eina_debug.h
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7098
Carsten Haitzler (Rasterman) [Fri, 21 Sep 2018 12:39:45 +0000 (13:39 +0100)]
examples - fix avahi examples to compile
add links to avahi system client libs.
JunsuChoi [Fri, 21 Sep 2018 11:05:44 +0000 (20:05 +0900)]
Colorselector : Add docs of elm_colorselector_palette_item_* APIs
Summary:
Add documentation for these APIs
elm_colorselector_palette_item_color_get
elm_colorselector_palette_item_color_set
elm_colorselector_palette_item_selected_get
elm_colorselector_palette_item_selected_set
Test Plan: make doc
Reviewers: cedric, Hermet, zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7091
JunsuChoi [Fri, 21 Sep 2018 11:03:18 +0000 (20:03 +0900)]
Docs: Fix incorrectly information for elm_config_softcursor_mode_set
Summary: N/A
Test Plan: make doc
Reviewers: cedric, Hermet, zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7094
JunsuChoi [Fri, 21 Sep 2018 11:02:33 +0000 (20:02 +0900)]
Docs: Add a group of APIs for which group is not declared in elm_config
Summary:
Longpress
elm_config_longpress_timeout_get
elm_config_longpress_timeout_set
SotfCursor
elm_config_softcursor_mode_set
elm_config_softcursor_mode_get
Tooltips (Add in Elm_Tooltips)
elm_config_tooltip_delay_get
elm_config_tooltip_delay_set
Test Plan: make doc
Reviewers: cedric, Hermet, zmike, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7093
Hermet Park [Fri, 21 Sep 2018 08:59:30 +0000 (17:59 +0900)]
edje: add missing eina_deprecated to apis.
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7090
Hermet Park [Fri, 21 Sep 2018 08:55:14 +0000 (17:55 +0900)]
Edje: update doc.
Summary: fix and add missing doxygen conent.
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7088
Taehyub Kim [Fri, 21 Sep 2018 09:04:49 +0000 (18:04 +0900)]
elm_entry: update documentation for elm_entnry_textonly_mode_set/get
Summary: update documentation
Reviewers: Jaehyun_Cho, raster
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7089
Bowon Ryu [Fri, 21 Sep 2018 08:25:56 +0000 (17:25 +0900)]
docs: correct group name of segmentcontrol for API docs.
Summary:
correct group name of segmentcontrol for API docs consistency.
Elm_SegmentControl -> Elm_Segment_Control
Test Plan: N/A
Reviewers: Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7087
Hermet Park [Fri, 21 Sep 2018 07:56:05 +0000 (16:56 +0900)]
edje example: fix svg data.
Summary:
these svg data format didn't have the standard.
Specify 0 ~ 100 in % unit i.e. 50%
Otherwise, 0 ~ 1 in normalized value. i.e. 0.5
Reviewers: #committers
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7054
Bryce Harrington [Fri, 21 Sep 2018 07:55:36 +0000 (16:55 +0900)]
eina: Grammar improvements
Reviewers: segfaultxavi
Reviewed By: segfaultxavi
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7058
Youngbok Shin [Fri, 21 Sep 2018 07:50:30 +0000 (16:50 +0900)]
elementary: fix memory leak from Efl.Ui.Layout.Object
Summary:
The 'data' could not be added to hash in a condition.
It has to be free'd before ending the function.
@fix
Test Plan: N/A
Reviewers: cedric, raster, Hermet, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7083
Youngbok Shin [Fri, 21 Sep 2018 07:32:07 +0000 (16:32 +0900)]
evas cache: add more null check for cache
Summary:
The 'cache' pointer is checked against null but then
dereferenced anyway. It needs to add null checking conditions.
Test Plan: N/A
Reviewers: raster, cedric, Hermet, zmike
Reviewed By: Hermet
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7084
Marcel Hollerbach [Wed, 12 Sep 2018 19:16:39 +0000 (21:16 +0200)]
evas_object_callbacks: do not error on NULL on del
it does not really matter if a obj is NULL or not when deleting a callback.
The result might be NULL anyways when the callback is not found.
Additionally, this is very verbose, and leads to the fact that most of
the time normal calls to evas_object_event_callback_del* should be if
(!obj) evas_object_event_callback_del* which is annoying and wastefull.
Differential Revision: https://phab.enlightenment.org/D7028
Youngbok Shin [Fri, 21 Sep 2018 07:23:36 +0000 (07:23 +0000)]
elementary: remove meaningless memory allocation and leaking
'evt_data' was allocated. Actually, it was not used in anywhere in its function.
@fix
Differential Revision: https://phab.enlightenment.org/D7086
Taehyub Kim [Fri, 21 Sep 2018 06:05:58 +0000 (15:05 +0900)]
eina_vpath: fix the memory leak
Summary:
fix the memory leak
@fix
Reviewers: Jaehyun_Cho, bu5hm4n
Reviewed By: Jaehyun_Cho
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7081
Taehyub Kim [Fri, 21 Sep 2018 05:46:50 +0000 (14:46 +0900)]
ecore_main: fix the invalid return value
Summary:
fix the invalid return value
@fix
Reviewers: Jaehyun_Cho, raster, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7080
Bryce Harrington [Tue, 18 Sep 2018 23:41:52 +0000 (08:41 +0900)]
eina: Improve explanation of read-only binbuf's
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7057
Bryce Harrington [Tue, 18 Sep 2018 23:38:32 +0000 (08:38 +0900)]
eina: Refer to sin/cos as sine/cosine instead of sinus/cosinus
Summary:
Sinus and cosinus are just the Latin words for sine and cosine, but we
should use the English versions to avoid any possible confusion.
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7059
Bryce Harrington [Tue, 18 Sep 2018 23:37:39 +0000 (08:37 +0900)]
eina promise: Fix example error message in docs
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7060
Bryce Harrington [Tue, 18 Sep 2018 23:35:02 +0000 (08:35 +0900)]
eina cow: Cleanup doxygen syntax
Summary:
The "be careful" advice seems a bit odd in api docs, better to just flag
them with doxygen @note's.
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7061
Derek Foreman [Tue, 18 Sep 2018 14:43:22 +0000 (09:43 -0500)]
emotion: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7051
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7052
Derek Foreman [Tue, 18 Sep 2018 14:43:17 +0000 (09:43 -0500)]
efl_canvas_animation_player: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7050
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7051
Derek Foreman [Tue, 18 Sep 2018 14:43:14 +0000 (09:43 -0500)]
emotion: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7049
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7050
Derek Foreman [Tue, 18 Sep 2018 14:43:09 +0000 (09:43 -0500)]
elu_ews_wm: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7048
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7049
Derek Foreman [Tue, 18 Sep 2018 14:43:05 +0000 (09:43 -0500)]
elm_transit: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7047
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7048
Derek Foreman [Tue, 18 Sep 2018 14:43:02 +0000 (09:43 -0500)]
elm_genlist: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7046
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7047
Derek Foreman [Tue, 18 Sep 2018 14:42:58 +0000 (09:42 -0500)]
elm_gengrid: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7045
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7046
Derek Foreman [Tue, 18 Sep 2018 14:42:54 +0000 (09:42 -0500)]
elm_box: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7044
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7045
Derek Foreman [Tue, 18 Sep 2018 14:42:50 +0000 (09:42 -0500)]
elm_actionslider: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7043
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7044
Derek Foreman [Tue, 18 Sep 2018 14:42:46 +0000 (09:42 -0500)]
efl_ui_flip: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7042
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7043
Derek Foreman [Tue, 18 Sep 2018 14:42:42 +0000 (09:42 -0500)]
selection_manager: Convert to new animators
Summary:
Use more efficient animator mechanism.
Depends on D7041
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7042
Derek Foreman [Tue, 18 Sep 2018 14:42:38 +0000 (09:42 -0500)]
ecore: Add new way to register animators
Summary:
We have back-ends that can generate their own tick sources, but
ecore_animator_add()/ecore_animator_timeline_add() gives no indication
which backend the animator is running on. This means that all animators
have to cause all currently in use backends to tick.
For example, if under wayland 4 application windows are open, all 4
windows will create ticks when any animator is present.
These new animator APIs that take an evas object allow us to figure out
out the backend and only cause the appropriate one to tick.
Depends on D7040
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: devilhorns, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7041
Derek Foreman [Tue, 18 Sep 2018 14:42:34 +0000 (09:42 -0500)]
ecore_anim: Move struct Ecore_Animator to private header
Summary:
We're going to use this in ecore_evas shortly.
Depends on D7039
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7040
Derek Foreman [Tue, 18 Sep 2018 14:42:29 +0000 (09:42 -0500)]
ecore_evas: Refactor out ticking start/stop as functions
Summary:
These are the refcounted ticky guts of the signal add/del catchers, we'll
need to use these to start/stop from other call chains in the near
future.
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7039
Woochanlee [Thu, 27 Sep 2018 10:35:55 +0000 (19:35 +0900)]
efl_ui_clock: Support legacy part name for tizen_only code.
Change-Id: I2ea63abf10edc693ee9b0eb683b9ac5e6381bb38
Hermet Park [Thu, 27 Sep 2018 09:35:19 +0000 (18:35 +0900)]
evas/vg: add legacy api - evas_object_vg_mmap_set()
Change-Id: Iaacf5db82da7332e3717cb9eaf08b8a76d61d5b1
Wonki Kim [Thu, 27 Sep 2018 05:23:51 +0000 (14:23 +0900)]
evas: Modify configure to branch by architectures for neon
Summary:
neon code is only needed to be included for the arm architecture.
so that this code modify automake configure files to support it.
Reviewers: Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7096
Change-Id: I70920f8cbabefc1e27deb4c9521d43d07974e404
Hermet Park [Wed, 12 Sep 2018 04:35:42 +0000 (13:35 +0900)]
evas neon: fix build break.
there is a grammatic error, just fix it.
Change-Id: I45593866e40e75d0f1da4b4b1ff6d17572f28715
Hermet Park [Thu, 27 Sep 2018 05:38:27 +0000 (14:38 +0900)]
Revert "Revert "evas: replace a current copy color function for neon""
This reverts commit
733774ed22e446096492b09f13637bd3daadf482.
Fix build break by
2e8f00c1ff0addfe32cfef329e808e8ef41c7a6f
Change-Id: I65b47d0bd8ba66049105e8b4015d6e41032d0424
Hermet Park [Thu, 27 Sep 2018 05:37:21 +0000 (14:37 +0900)]
Revert " evas_op_copy: disable neon in _op_copy_c_dp_neon"
This reverts commit
0d7891289fc8afe35af6e98bba117358eb8ad8ad.
Apply pixman-neon-copy implementation.
Change-Id: I1abd9bf6365f54d2bf533275c1cc4b2b2ac62e1b
JunsuChoi [Thu, 27 Sep 2018 02:14:39 +0000 (11:14 +0900)]
eo: Add null check
Summary:
This commit add null check on _efl_object_invalidate
In EO_OBJ_POINTER, if obj_id is null, obj can also be null.
Test Plan: N/A
Reviewers: cedric, zmike
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7068
Change-Id: I59fa9c6be5ea1502b6e783636c6456cbfe3a063b
JunsuChoi [Thu, 27 Sep 2018 02:13:36 +0000 (11:13 +0900)]
efl_ui_focus_manager: Add null check
Summary:
This commit add null check on _next and _request_subchild function.
The value 'node' is can be null.
Test Plan: N/A
Reviewers: bu5hm4n, YOhoho, Hermet
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7069
Change-Id: I9c12ebc17bd2e959a4fc388ad761ee7d171581fd
JunsuChoi [Thu, 27 Sep 2018 02:11:56 +0000 (11:11 +0900)]
efl_ui_list: Add return value check
Summary:
efl_ui_layout_object_theme_set without checking return value.
so add return value check and log message.
Test Plan: N/A
Reviewers: SanghyeonLee, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Subscribers: Hermet, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7070
Change-Id: I9b2a28f390ce6886384c8f0e3ae007fcf4d4f1a6
JunsuChoi [Thu, 27 Sep 2018 02:10:25 +0000 (11:10 +0900)]
ctxpopup: Add return value check
Summary:
Using elm_widget_theme_object_set without checking return value.
so add return value check and log message
Test Plan: N/A
Reviewers: herb, cedric, Hermet
Reviewed By: Hermet
Subscribers: Hermet, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7072
Change-Id: I372f7ad1ea1989b34243b034f5209711e2b48c23
Jaehyun Cho [Thu, 26 Jul 2018 03:01:42 +0000 (12:01 +0900)]
evas_events: Use ecore mouse device instead of default mouse device
In Tizen, ecore uses mouse device handle corresponding to actual mouse
device.
However, evas uses both ecore mouse device handles and default mouse
handle at the same time.
This causes that "mouse_in" state is not preserved.
Consequently, mouse in/out callback is not called correctly.
To resolve above issue, evas stores the last activated ecore mouse
device handle to "last_mouse" variable.
This patch should be applied with
00004cb2e36842c41b866027ae7f486c6a9ad204
Change-Id: I5da9da5662c55af0df191c9a876487831f5f33d9
Signed-off-by: Jaehyun Cho <jae_hyun.cho@samsung.com>
Jaehyun Cho [Fri, 21 Sep 2018 09:40:05 +0000 (18:40 +0900)]
efl_ui_list: Return function if data get is failed
Summary: Check data and return function if data get is failed.
Reviewers: SanghyeonLee
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7092
Change-Id: I37a3789d21c715dc3a64151daafa707808484f10
Shinwoo Kim [Fri, 21 Sep 2018 03:11:24 +0000 (03:11 +0000)]
eina_vpath_vdg: free locally allocated memory before return
The eina_vpath_resolve could allocate memory and return it.
But the eina_xdg_env_init does not release it.
*Detected by static analysis with the Coverity
Differential Revision: https://phab.enlightenment.org/D7066
Change-Id: Ic243f70632dd731cf1cab426d1abfe013afa362b
Shinwoo Kim [Fri, 21 Sep 2018 07:46:03 +0000 (16:46 +0900)]
evas_object_smart: fix dereference of null
Summary:
The cso could b NULL so we need to check if the cso is NULL or not before
dereferencing it.
Reviewers: jpeg, Hermet, jypark
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7075
Change-Id: Ic3b28206a263f4a145a0cd00b315652f00144407
Taehyub Kim [Fri, 21 Sep 2018 06:05:49 +0000 (15:05 +0900)]
Efl.Ui.Popup.Alert: add icon parameter for icon button of popup
Summary: add icon parameter for icon button of popup
Test Plan:
1. run elementry_test
2. run Efl.Ui.Popup.Alert sample
3. call set button function of popup and pass the icon by parameter
4. see the result of the popup
Reviewers: Jaehyun_Cho, jpeg, raster, cedric, woohyun
Reviewed By: Jaehyun_Cho
Subscribers: #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7079
Change-Id: Ida7570b8089fe6138a06f850b3cdb7d03ba9e09f
Youngbok Shin [Fri, 21 Sep 2018 08:32:01 +0000 (17:32 +0900)]
evas-wayland-shm: add a missing code caused by upstream migration
@tizen_fix
Change-Id: I9788ac96a85195dabc66552fa34a58a1c60c22e7
Wonki Kim [Fri, 21 Sep 2018 06:32:40 +0000 (15:32 +0900)]
elm_atspi_bride: Add missing changes from cherry-picking
tizen patch
51f850df676956d4085002afb401d2c649ffb93f was cherry-picked from
upstream patch
804fc1667ac72338e3691447e149e54261a9ffe6.
however some changes were not cherry-picked by mistake.
this patch appends the missing changes.
Change-Id: I03323992f8b429f97fce16e512e801cce0057b1d
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Jaehyun Cho [Wed, 19 Sep 2018 12:01:55 +0000 (21:01 +0900)]
els_tooltip: Fix to show correct arrow type
Summary:
Current calculation for arrow type is not based on mouse position.
Consequently, tooltip arrow type is incorrect when tooltip shows on
mouse position with ELM_TOOLTIP_ORIENT_NONE.
Test Plan:
1. Execute "Tooltip" in elementary_test
2. Hover mouse on any button and move mouse
Reviewers: Hermet, raster, woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D7074
Change-Id: I60920f4c5320cb649a8ef19359bca77ad2e7d315
Radoslaw Cybulski [Mon, 20 Aug 2018 13:38:39 +0000 (15:38 +0200)]
fix for wrong object passed to _elm_widget_accessibility_highlight_grabbing_set
Turning screen-reader on on setting app and flicking right until
reaching "device" item would crash setting due to invalid object
passed to _elm_widget_accessibility_highlight_grabbing_set function.
Change-Id: I055afee745ff782b870c5663fc124059df3db2f7
Taehyub Kim [Fri, 21 Sep 2018 04:26:26 +0000 (13:26 +0900)]
elc_multibuttonentry: fix the invalid return value
Change-Id: I9bab03d012bb391cc4114c3c8dbd4763ccde6179
SangHyeon Jade Lee [Fri, 21 Sep 2018 05:43:27 +0000 (14:43 +0900)]
evas_filter: fix wrong merge commit in evas filter
Change-Id: I8b8a44ab11b0c473aaee98b5e167e02b51f42999
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
Joogab Yun [Fri, 21 Sep 2018 02:58:13 +0000 (11:58 +0900)]
ecore_evas_wayland_common : remove duplicate engine_info_set
We calculate the rotation value at the end of _rotation_do () and then we do the engine_info_set.
So we do not need engine_info_set here.
Myfiles -> search -> keybord -> input text -> look at the mangifier
-> rotate 90 or 270 -> input text -> rotate 0 -> input text -> look at
the mangifier -> issue
Change-Id: I6d729815f6749937693ed7934b08019b5a98c2cb
Youngbok Shin [Thu, 20 Sep 2018 04:32:59 +0000 (13:32 +0900)]
eina: add the last fallback runtime directory as /tmp
When XDG_RUNTIME_DIR environment value is empty,
Eina Vpath tries to use fallback runtime dir by calling _fallback_runtime_dir with "home".
But, that "home" path is not allowed for using runtime dir in Tizen.
So, we are going to add one more fallback directory as "/tmp" which is allowed in Tizen.
@tizen_fix
Change-Id: Ib57e2976d919bfe2a9a4babaa3e8c4626aaa2f8f
Jiyoun Park [Thu, 20 Sep 2018 05:48:09 +0000 (14:48 +0900)]
evas_op_copy: disable neon in _op_copy_c_dp_neon
crash occured in _op_copy_c_dp_neon function's neon code.
so disable neon code in that function until find the root cause.
Change-Id: Ic70585922c839d4dfae31cc5ffbfa5a4e8cf01b6