platform/core/appfw/tizen-theme-manager.git
3 years agoFix static analysis issues 71/240971/3
Sangyoon Jang [Thu, 13 Aug 2020 08:33:25 +0000 (17:33 +0900)]
Fix static analysis issues

Change-Id: I54da333cc4fcf38b94e39dfb3dace49890a24076
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoMerge "Add -fPIC option" into tizen
Sangyoon Jang [Wed, 12 Aug 2020 06:34:54 +0000 (06:34 +0000)]
Merge "Add -fPIC option" into tizen

3 years agoFix coding rule 59/240759/2
Junghyun Yeon [Tue, 11 Aug 2020 07:00:04 +0000 (16:00 +0900)]
Fix coding rule

Change-Id: I1ef58c53c3e1a57ec8496ca9f8fcecbf754577c1
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
3 years agoImprove coverage 91/240591/3
Inkyun Kil [Mon, 10 Aug 2020 01:00:49 +0000 (10:00 +0900)]
Improve coverage

- Add unittest for get_path_array

Change-Id: I6fab8943fbfd8201a3467d66a5fb9d3b02e95908
Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
3 years agoMerge "Fix unittests" into tizen
Junghoon Park [Tue, 11 Aug 2020 02:07:08 +0000 (02:07 +0000)]
Merge "Fix unittests" into tizen

3 years agoFix unittests 16/240716/1
Junghoon Park [Tue, 11 Aug 2020 01:48:13 +0000 (10:48 +0900)]
Fix unittests

- Fix static analysis issue
- Fix wrong implementation

Change-Id: I12b023e5637328822022286f4e3746de0dd03ebf
Signed-off-by: Junghoon Park <jh9216.park@samsung.com>
3 years agoRemove stdout log 94/240494/2
Inkyun Kil [Fri, 7 Aug 2020 01:41:17 +0000 (10:41 +0900)]
Remove stdout log

Change-Id: I7ced935d6d0cf4d07b2c494237d4ce36af48547f
Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
3 years agoAdd -fPIC option 23/240623/1
Sangyoon Jang [Mon, 10 Aug 2020 07:12:52 +0000 (16:12 +0900)]
Add -fPIC option

Change-Id: Ia9b72df3cfcb4b3296a8d7bf9eed7ace5392b965
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoAdd some log when install, update, uninstall theme 60/240460/1
Sangyoon Jang [Thu, 6 Aug 2020 10:28:33 +0000 (19:28 +0900)]
Add some log when install, update, uninstall theme

Change-Id: I10bccb53e86bdb46a362210e88e755670f8c9631
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoSet timeout of dbus method call 59/240459/2
Sangyoon Jang [Thu, 6 Aug 2020 08:29:00 +0000 (17:29 +0900)]
Set timeout of dbus method call

Change-Id: I6b295d6ce80330db778aeceecfbb03025a50c4a7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoRelease version 0.0.2 84/240084/1 accepted/tizen/unified/20200803.122237 submit/tizen/20200803.072542
Junghyun Yeon [Mon, 3 Aug 2020 07:15:25 +0000 (16:15 +0900)]
Release version 0.0.2

Changes:
 - Improve coverage for theme_info
 - Fix the constants of bundle key
 - Fix RequestBroker
 - Redesign theme event callback
 - Improve coverage for theme_info_loader
 - Fix RequestBroker::RegisterRequestFilter()
 - Fix RequestBroker
 - Fix ThemeInfoLoader::AddEvent
 - Fix registering request handler
 - Send signal when current theme changed
 - Add default theme feature
 - Remove unused parameter
 - Load default theme when creating proxy object
 - Store theme info as a raw bundle at db
 - Implement default theme overlay
 - Fix SelectionRequestHandler
 - Add DbManager::SelectCurrent() method
 - Fix to lazy load of default and current theme info
 - Set the default theme as current theme when the current theme uninstalled
 - Check the bundle is valid before create ThemeInfo object
 - Fix theme_setting table
 - Fix sqlite_connection.h, sqlite_statement.h
 - Implement auto_set feature
 - Fix doxygen of theme.h
 - Parse all json's values
 - Upgrade unit tests
 - Change type for theme_loader_event_handler
 - Add APIs getting path value
 - Merge "Add APIs getting path value" into tizen
 - Fix static analysis issues
 - Fix theme parser test
 - Implement auto_file_key feature
 - Change the key that ThemeParser parses to start with '/'
 - Add some error handlings
 - Fix unit test failure
 - Add rpm packages for capi library
 - Fix auto file key generation

Change-Id: I290ed0434a36c7c981d252f4229723d73dba4de8
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
3 years agoFix auto file key generation 96/239896/4
Sangyoon Jang [Thu, 30 Jul 2020 10:19:46 +0000 (19:19 +0900)]
Fix auto file key generation

Iterates shared/res directory and find all resource files to add
auto-generated file key.

Change-Id: Iaacc4cafc3dab37a44a6856e7786667024cba038
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoAdd rpm packages for capi library 92/239492/7
Sangyoon Jang [Mon, 27 Jul 2020 06:02:35 +0000 (15:02 +0900)]
Add rpm packages for capi library

Change-Id: Ie4c25ca22706651badb47632dcc129ec0d945963
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix unit test failure 41/239941/1
Junghyun Yeon [Thu, 30 Jul 2020 11:17:35 +0000 (20:17 +0900)]
Fix unit test failure

Add mock and make bundle not empty to pass unit test

Change-Id: I4e97f9f5c6a5305627dbb9866705723260257df7
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
3 years agoAdd some error handlings 42/239542/2
Sangyoon Jang [Mon, 27 Jul 2020 11:34:05 +0000 (20:34 +0900)]
Add some error handlings

Change-Id: I498accc877b3fcf272fcb994b7b82b9dd3552cd0
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoChange the key that ThemeParser parses to start with '/' 63/238463/2
Ilho Kim [Tue, 14 Jul 2020 06:05:38 +0000 (15:05 +0900)]
Change the key that ThemeParser parses to start with '/'

Change-Id: Iad13a2f0ca0f2c4075b10baca3485acb7a4a2ea4
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
3 years agoImplement auto_file_key feature 61/237661/8
Sangyoon Jang [Thu, 2 Jul 2020 08:25:13 +0000 (17:25 +0900)]
Implement auto_file_key feature

Change-Id: I5bb4ba4c4e704af4f4476c07a69f7825c8f28d0d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix theme parser test 55/238455/2
Sangyoon Jang [Tue, 14 Jul 2020 05:44:03 +0000 (14:44 +0900)]
Fix theme parser test

A package can have one theme.

Change-Id: I230585495f396d40e82d1fe2aec2b25d14626415
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix static analysis issues 27/238427/2
Junghyun Yeon [Tue, 14 Jul 2020 01:52:56 +0000 (10:52 +0900)]
Fix static analysis issues

Change-Id: I901039455cd6477afca8363835e2b1f175b533da
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
3 years agoMerge "Add APIs getting path value" into tizen
Sangyoon Jang [Mon, 13 Jul 2020 08:29:43 +0000 (08:29 +0000)]
Merge "Add APIs getting path value" into tizen

3 years agoAdd APIs getting path value 45/235945/12
Sangyoon Jang [Thu, 11 Jun 2020 07:33:13 +0000 (16:33 +0900)]
Add APIs getting path value

Client will use theme_get_path()/theme_get_path_array() instead of
theme_get_string()/theme_get_string_array() to getting path such as
image file path.

Change-Id: I089e554d5cbf5661acf75cfb232ea8a183f70c0f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoChange type for theme_loader_event_handler 34/237734/2
Inkyun Kil [Fri, 3 Jul 2020 05:59:41 +0000 (14:59 +0900)]
Change type for theme_loader_event_handler

Change-Id: I86946394350dc7690d209b442f8113625d9922b0
Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
3 years agoUpgrade unit tests 63/237863/3
Junghyun Yeon [Mon, 6 Jul 2020 07:26:41 +0000 (16:26 +0900)]
Upgrade unit tests

- Add some negative testcases for coverage.
- Fix testcase to use right API.

Change-Id: I1b02069eea1cb1cf4c1675926018322ed33d4253
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
3 years agoParse all json's values 20/237520/8
Ilho Kim [Wed, 1 Jul 2020 01:20:53 +0000 (10:20 +0900)]
Parse all json's values

{
  "A" : {
    "A" : "a",
    "B" : [
      "a",
      "b",
      "c"
    ],
    "C" : [
      {
        "D" : "d"
      },
      {
        "E" : "e"
      }
    ]
  }
}

Above json file is parsed and saved to bundle like that
Key Value
"A/A" "a"
"A/B" {"a", "b", "c"}
"A/C/0/D"       "d"
"A/C/1/E"       "e"

Change-Id: Ica907252ba3397898b1e22a9ec8afbe92b81cf05
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
3 years agoFix doxygen of theme.h 67/237667/1
Sangyoon Jang [Thu, 2 Jul 2020 08:34:01 +0000 (17:34 +0900)]
Fix doxygen of theme.h

Change-Id: I32e96a7cf483b10c31b0e779067305c2f3a2a2a1
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoImplement auto_set feature 57/237557/2
Sangyoon Jang [Wed, 1 Jul 2020 08:01:36 +0000 (17:01 +0900)]
Implement auto_set feature

When a theme package set auto_set in metadata, theme manager will set
that theme automatically after installation.
auto_set will only work when the package is signed as platform privilege level.

Change-Id: I1cc6aad1fc627d97798e97037b260ae10635ba2e
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix sqlite_connection.h, sqlite_statement.h 82/237582/1
Sangyoon Jang [Wed, 1 Jul 2020 11:12:10 +0000 (20:12 +0900)]
Fix sqlite_connection.h, sqlite_statement.h

Remove unused header, friend class, add explicit keyword at constructor.

Change-Id: I8979902b2275a7de9882468613da30caf255f38e
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix theme_setting table 71/237571/1
Sangyoon Jang [Wed, 1 Jul 2020 10:00:06 +0000 (19:00 +0900)]
Fix theme_setting table

Make current as a foreign key.

Change-Id: I1856dcba990eca2afc41f3ff6441a6aa2ce93f44
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoCheck the bundle is valid before create ThemeInfo object 63/237563/1
Sangyoon Jang [Wed, 1 Jul 2020 08:55:35 +0000 (17:55 +0900)]
Check the bundle is valid before create ThemeInfo object

Change-Id: I5297ba0a4102496d5a881af34169bc46a512c4a0
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoSet the default theme as current theme when the current theme uninstalled 60/237560/1
Sangyoon Jang [Wed, 1 Jul 2020 08:41:07 +0000 (17:41 +0900)]
Set the default theme as current theme when the current theme uninstalled

Change-Id: I9c644a059ff5b4d11b17fddf8eb7f693406bbec5
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix to lazy load of default and current theme info 32/237432/1
Sangyoon Jang [Tue, 30 Jun 2020 11:27:51 +0000 (20:27 +0900)]
Fix to lazy load of default and current theme info

Change-Id: I5ec43ab17a7d06568e5dc1d9bc24e84c8364a28f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoAdd DbManager::SelectCurrent() method 31/237431/3
Sangyoon Jang [Tue, 30 Jun 2020 11:14:34 +0000 (20:14 +0900)]
Add DbManager::SelectCurrent() method

Change-Id: Ic61c7eaf6690f2897654bb2fab6254d423edfc18
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix SelectionRequestHandler 30/237430/1
Sangyoon Jang [Tue, 30 Jun 2020 11:13:30 +0000 (20:13 +0900)]
Fix SelectionRequestHandler

When requested GET_ID command with empty id, return current theme info.

Change-Id: If479951e604f73ec5a2fc4c18d5e91cc881f9c9d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoImplement default theme overlay 58/237358/2
Sangyoon Jang [Mon, 29 Jun 2020 11:04:08 +0000 (20:04 +0900)]
Implement default theme overlay

When getting theme info, overlay upon default theme info.

Change-Id: I2899023bcd8e9331882a678a822954597d9fa6a8
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoStore theme info as a raw bundle at db 56/237356/1
Sangyoon Jang [Mon, 29 Jun 2020 10:46:33 +0000 (19:46 +0900)]
Store theme info as a raw bundle at db

Change-Id: I39a8eeb4d5ef48ea84f69fe58f0af94de08cefe9
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoLoad default theme when creating proxy object 50/237350/1
Sangyoon Jang [Mon, 29 Jun 2020 08:14:59 +0000 (17:14 +0900)]
Load default theme when creating proxy object

Change-Id: If0b1fd022ed6b3fa72c354c972ed288cd6b2ad2f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoRemove unused parameter 34/237334/1
Sangyoon Jang [Mon, 29 Jun 2020 07:48:55 +0000 (16:48 +0900)]
Remove unused parameter

Remove unused parameter of DbManager::Insert, DbManager::Update.

Change-Id: Ib218d5ad36e0f047530a525f29d142b987553047
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoAdd default theme feature 36/237236/4
Sangyoon Jang [Fri, 26 Jun 2020 07:06:37 +0000 (16:06 +0900)]
Add default theme feature

Change-Id: Ib1c2efe434283ab2f28883e0f1b2756399b1e93b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoSend signal when current theme changed 68/237168/5
Sangyoon Jang [Thu, 25 Jun 2020 11:26:48 +0000 (20:26 +0900)]
Send signal when current theme changed

Send serialized theme which is changed theme when current theme changed.
Add test for theme changed event.

Change-Id: I5bb068445cad8cfb7f7fd7fe8bf488aebd9af43a
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix registering request handler 62/237262/1
Sangyoon Jang [Fri, 26 Jun 2020 09:37:09 +0000 (18:37 +0900)]
Fix registering request handler

Change-Id: I4c50f6374d1dcde2e105ac7369777e477b796978
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix ThemeInfoLoader::AddEvent 66/237166/2
Sangyoon Jang [Thu, 25 Jun 2020 11:13:21 +0000 (20:13 +0900)]
Fix ThemeInfoLoader::AddEvent

Subscribe for listening dbus signal.

Change-Id: I32c6344640c9c7a135021e1ae66709c471db245c
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix RequestBroker 65/237165/2
Sangyoon Jang [Thu, 25 Jun 2020 11:05:42 +0000 (20:05 +0900)]
Fix RequestBroker

Check if already subscribed when subscribed.
Add Unsubscribe method.

Change-Id: Ia0674b35eefb79e060f684f74d7a15177d77ea41
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix RequestBroker::RegisterRequestFilter() 64/237164/2
Sangyoon Jang [Thu, 25 Jun 2020 06:15:49 +0000 (15:15 +0900)]
Fix RequestBroker::RegisterRequestFilter()

Use shared_ptr.

Change-Id: Ia99af79fcaf151ac6a82fc7e944faae6bbbd52a3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoImprove coverage for theme_info_loader 12/237012/3
Inkyun Kil [Wed, 24 Jun 2020 05:03:00 +0000 (14:03 +0900)]
Improve coverage for theme_info_loader

Change-Id: I689413e5992a733e0d0a9ffdb5648e01fa5ab67b
Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
3 years agoRedesign theme event callback 01/237001/3
Sangyoon Jang [Wed, 24 Jun 2020 04:28:35 +0000 (13:28 +0900)]
Redesign theme event callback

Remove unloaded callback, rename loaded callback to changed callback.
When current theme changed, the changed callback will be invoked.

Change-Id: Ib528b63bdcae7a161e6bb9ef36130fe9f5d22605
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix RequestBroker 08/236908/4
Sangyoon Jang [Tue, 23 Jun 2020 08:04:27 +0000 (17:04 +0900)]
Fix RequestBroker

Use non-static method, using lambda for c callback.

Change-Id: I91d5efc48fd9674e79e854752caabfc0d608bff0
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix the constants of bundle key 77/236877/3
Sangyoon Jang [Tue, 23 Jun 2020 05:13:16 +0000 (14:13 +0900)]
Fix the constants of bundle key

We don't need to add command at bundle, because it is already passed by
dbus message.
Use constants as extern, instead of macro.

Change-Id: I7a4534af84c7ec244f7749c824b4c3599a1674f7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoImprove coverage for theme_info 99/236899/2
Inkyun Kil [Tue, 23 Jun 2020 07:31:55 +0000 (16:31 +0900)]
Improve coverage for theme_info

Change-Id: Ice576c3ee77052af4a4b0e02751cd31e2becb797
Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
3 years agoAdd unit test for RequestBroker 97/235897/8 accepted/tizen/unified/20200618.130042 submit/tizen/20200618.082339
Ilho Kim [Wed, 10 Jun 2020 01:57:09 +0000 (10:57 +0900)]
Add unit test for RequestBroker

Change-Id: I75cbcf4d1571697519aa331b7581875f8092fb2a
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
3 years agoInclude theme_error.h at theme.h 72/236472/1
Sangyoon Jang [Wed, 17 Jun 2020 08:19:48 +0000 (17:19 +0900)]
Include theme_error.h at theme.h

Change-Id: Ib4bc53f14b2faa4da38dff3137483fbaa09a2cbc
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix native API header 71/236471/1
Sangyoon Jang [Wed, 17 Jun 2020 08:13:25 +0000 (17:13 +0900)]
Fix native API header

Fix errors from native API header rule checker.

Change-Id: I9a5dcc3d40b19932cc2379daa9e8ae0151417019
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoSeparate library for API 41/236341/6
Sangyoon Jang [Tue, 16 Jun 2020 09:36:51 +0000 (18:36 +0900)]
Separate library for API

A new lib file libcapi-appfw-tizen-theme.so is separated from
libtizen-theme.so.
Install header files for API.

Change-Id: Idc9846ea604dcbb8e7f74ae1e4aa0b4dd911f500
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoUnify the argument of dbus method caller and receiver 06/235706/7
Ilho Kim [Tue, 9 Jun 2020 05:23:02 +0000 (14:23 +0900)]
Unify the argument of dbus method caller and receiver

Change-Id: I073bdbe25b8f66eb3646535689fdc54de7e1df34
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
3 years agoAdd theme_loader_set_current API 28/235428/5
Junghyun Yeon [Thu, 4 Jun 2020 11:00:43 +0000 (20:00 +0900)]
Add theme_loader_set_current API

Change-Id: I1c8c8fdde27c41054bf4a27e4eaa1864f930b4be
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
3 years agoRestart theme-provider when install rpm package 29/236429/2
Sangyoon Jang [Wed, 17 Jun 2020 05:07:58 +0000 (14:07 +0900)]
Restart theme-provider when install rpm package

Change-Id: Ia789236f131f8058b7fc8ed2e79d072fa1bd7a1b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix theme_loader_query_id 28/236428/2
Sangyoon Jang [Wed, 17 Jun 2020 05:07:08 +0000 (14:07 +0900)]
Fix theme_loader_query_id

Change-Id: Iff5b625e89fc51b7fb7284ceefca43cf4f676d6e
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoAdd GET_IDS request filter 27/236427/1
Sangyoon Jang [Wed, 17 Jun 2020 05:06:12 +0000 (14:06 +0900)]
Add GET_IDS request filter

Change-Id: I65e2db3338b94448f9a48887cd5bd0e66ce85cda
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoAdd/Remove unit tests 27/235427/6
Junghyun Yeon [Thu, 4 Jun 2020 10:48:26 +0000 (19:48 +0900)]
Add/Remove unit tests

theme_ APIs and theme_loader_ APIs are wrapper of
ThemeInfo ThemeInfoLoader classes.
Making unit tests for all of these are unnecessary.

Change-Id: I5058287ff247df5af86fceb7b2ccb9d7482a4a84
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
3 years agoRefactor theme plugin 08/236308/2
Sangyoon Jang [Tue, 16 Jun 2020 06:44:45 +0000 (15:44 +0900)]
Refactor theme plugin

Remove duplicated code.

Change-Id: I8c2dc9464f27d5adeda9aa6d3c28d3e8ed84b94e
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoCheck the parsed theme is valid or not 93/236193/1
Sangyoon Jang [Mon, 15 Jun 2020 11:17:45 +0000 (20:17 +0900)]
Check the parsed theme is valid or not

Change-Id: I03b047f7abd1bd5fcf452bd6c106feb6f70faaa5
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoAdd ThemeInfo::IsValid() method 92/236192/1
Sangyoon Jang [Mon, 15 Jun 2020 11:17:04 +0000 (20:17 +0900)]
Add ThemeInfo::IsValid() method

Change-Id: I8ead841269506cc970cfc73224af856d0abdb2a2
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix return type of ThemeParser::Commit() 90/236190/1
Sangyoon Jang [Mon, 15 Jun 2020 11:12:09 +0000 (20:12 +0900)]
Fix return type of ThemeParser::Commit()

Change-Id: Ic5a0f3969e53ed786a45855edfa42b10a230a077
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoFix systemd and DBus configuaration, fix bus name 21/236121/5
Sangyoon Jang [Mon, 15 Jun 2020 05:42:44 +0000 (14:42 +0900)]
Fix systemd and DBus configuaration, fix bus name

The systemd service file and dbus configuration will be installed by rpm
packaging. And the bus name is changed, following DBus naming convention.

Change-Id: I388adccd490d369782bc087623bb4b36c6a31def
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoAdd uid attribute of ThemeInfo 58/235958/2
Sangyoon Jang [Thu, 11 Jun 2020 09:52:22 +0000 (18:52 +0900)]
Add uid attribute of ThemeInfo

Change-Id: I2cbc7fac05bcb6915f9fc629703530e85be86e3a
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoReplace fff with gmock 97/234997/13
Sangyoon Jang [Mon, 1 Jun 2020 11:07:40 +0000 (20:07 +0900)]
Replace fff with gmock

Change-Id: I6b103e4235428e73de888e5c0a93a0f1abcbcb83
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoAdd pkgid attribute of ThemeInfo 60/235860/2
Sangyoon Jang [Wed, 10 Jun 2020 09:59:18 +0000 (18:59 +0900)]
Add pkgid attribute of ThemeInfo

Change-Id: If3501476cd98f0fd8efafd3039479faf92825415
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
3 years agoImplements OnRequest for theme_info_loader 83/234583/12
Inkyun Kil [Wed, 27 May 2020 07:02:50 +0000 (16:02 +0900)]
Implements OnRequest for theme_info_loader

Change-Id: I91ce70a80273bdb67ee1400df7e9ff1274d4b54e
Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
3 years agoUpdate ThemeInfo Class 78/235078/2
Inkyun Kil [Tue, 2 Jun 2020 05:09:56 +0000 (14:09 +0900)]
Update ThemeInfo Class

Change-Id: I783a0b8f554d1ca8db77d1f19bc64dd2fb523411
Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
4 years agoFix coding style 54/235254/2
Sangyoon Jang [Wed, 3 Jun 2020 06:14:00 +0000 (15:14 +0900)]
Fix coding style

Change-Id: Iab844f1eabd63d8ccca897d48aa43c5ef72aacf2
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoFix to daemon running always 52/235252/3
Sangyoon Jang [Wed, 3 Jun 2020 05:11:22 +0000 (14:11 +0900)]
Fix to daemon running always

Change-Id: Idd4189591571a4d2762835a7198835cf952165e8
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoFix theme plugin for vitalness 55/235155/2
Junghyun Yeon [Tue, 2 Jun 2020 08:10:50 +0000 (17:10 +0900)]
Fix theme plugin for vitalness

theme plugin will return negative integer when it fails to do something.

Change-Id: Icb693b23b55c3f60dbe85e34de630bb01598a2de
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
4 years agoFix plugin to identify theme json file 84/235184/3
Junghyun Yeon [Tue, 2 Jun 2020 11:07:14 +0000 (20:07 +0900)]
Fix plugin to identify theme json file

Manifest only contains filename. Absolute path will be
detemined during install so Plugin should construct absolute filepath itself.

Change-Id: I8227fdaaa5ab10dcd63ea5827f9591e9056a3bad
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
4 years agoFix wrong error logs 82/235182/1
Sangyoon Jang [Tue, 2 Jun 2020 10:46:20 +0000 (19:46 +0900)]
Fix wrong error logs

Change-Id: I7c7f566ac3d9c43f932148f8aa7e1e32c8970e8b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoFix error when copying gcno files 81/235181/1
Sangyoon Jang [Tue, 2 Jun 2020 10:43:47 +0000 (19:43 +0900)]
Fix error when copying gcno files

Change-Id: I2f62434fd3807c20b06e55be5e593759a625b883
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoAdd negative testcases for theme_ APIs 40/234940/1
Junghyun Yeon [Mon, 1 Jun 2020 02:36:35 +0000 (11:36 +0900)]
Add negative testcases for theme_ APIs

These testcases will check invalid parameter cases.

Change-Id: I0ee3b04601717f4f8786faa635412c4da5388e4d
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
4 years agoFix ThemeInfoBuilder 11/234711/2
Sangyoon Jang [Thu, 28 May 2020 06:32:57 +0000 (15:32 +0900)]
Fix ThemeInfoBuilder

Fix ThemeInfobuilder for extendability.
Put parsed data into a bundle, and build ThemeInfo using bundle.

Change-Id: Ia7055e6587640c5cc68087ce25937b18bad66602
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoMove unit_tests directoy to test directory 54/234754/1
Sangyoon Jang [Thu, 28 May 2020 07:39:10 +0000 (16:39 +0900)]
Move unit_tests directoy to test directory

Change-Id: I74a0110b76d1231ed1be7ed468da289fc5b66b64
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoRemove INCLUDE_DIRECTORIES from CMakeLists.txt 53/234753/1
Sangyoon Jang [Thu, 28 May 2020 07:41:03 +0000 (16:41 +0900)]
Remove INCLUDE_DIRECTORIES from CMakeLists.txt

Use TARGET_INCLUDE_DIRECTORIES instead.

Change-Id: I757165ccfea1937266a8f573057c6e184204860b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoFix rpmlint warnings 85/234685/1
Sangyoon Jang [Thu, 28 May 2020 04:33:04 +0000 (13:33 +0900)]
Fix rpmlint warnings

Change-Id: Ie665bcea9a7a060db2dce0cf19e7ac63e9a37a9a
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoRemove unused sqlite functions 28/234628/1
Sangyoon Jang [Wed, 27 May 2020 11:38:56 +0000 (20:38 +0900)]
Remove unused sqlite functions

Change-Id: Id410f29556192f1f84dc0cf835e2dc39c9945176
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoImplement GET_IDS command 24/234624/1
Sangyoon Jang [Wed, 27 May 2020 11:29:39 +0000 (20:29 +0900)]
Implement GET_IDS command

Change-Id: I4a5f5bc6f429f508ba40bcc93f948cb8120b3106
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoFix coding rule 40/234540/5
Junghyun Yeon [Wed, 27 May 2020 06:18:21 +0000 (15:18 +0900)]
Fix coding rule

Change-Id: I9b40e5f5c5e8c4e1086c8a2ae1d08c3fd9f27d0b
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
4 years agoAdd unit tests for Theme getter APIs 38/234538/4
Junghyun Yeon [Wed, 27 May 2020 06:05:45 +0000 (15:05 +0900)]
Add unit tests for Theme getter APIs

Change-Id: Ibc35dd8d55279b621155e374ae95c29cc168890e
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
4 years agoAdd parser-plugin info file for theme 95/234595/1
Sangyoon Jang [Wed, 27 May 2020 08:48:02 +0000 (17:48 +0900)]
Add parser-plugin info file for theme

Change-Id: I74e21678c2fb0a74078377cbbfc82795d57c8935
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoFix spec file to exclude debug files from non-debug pkg 81/234581/1
Sangyoon Jang [Wed, 27 May 2020 07:30:48 +0000 (16:30 +0900)]
Fix spec file to exclude debug files from non-debug pkg

Change-Id: I80515253bd5c5b45bac62eb30d555fc1a3fefa3e
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoRemove caps in service file 80/234580/1
Sangyoon Jang [Wed, 27 May 2020 06:43:25 +0000 (15:43 +0900)]
Remove caps in service file

Change-Id: Iaa18646e3c1e5cf6f36e52aa43cd561c7bab8cc8
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoAdd tests for RequestHandlers 48/234448/2
Sangyoon Jang [Tue, 26 May 2020 10:04:55 +0000 (19:04 +0900)]
Add tests for RequestHandlers

Change-Id: I1b6908796bf8061453120684564d711545dc1a46
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoAdd description into CAPIs 23/234323/1
Junghyun Yeon [Mon, 25 May 2020 11:14:48 +0000 (20:14 +0900)]
Add description into CAPIs

Change-Id: I8ea6edec564a8a289c6c1120466c2509f65b0ae9
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
4 years agoImplement theme manager service
Ilho Kim [Tue, 19 May 2020 06:12:10 +0000 (15:12 +0900)]
Implement theme manager service

Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoAdd EmitSignal for send event signal
Ilho Kim [Thu, 21 May 2020 02:06:35 +0000 (11:06 +0900)]
Add EmitSignal for send event signal

Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoAdd Command output argument to dbus method
Ilho Kim [Wed, 20 May 2020 07:27:42 +0000 (16:27 +0900)]
Add Command output argument to dbus method

Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoUpdate Unittest
Inkyun Kil [Wed, 20 May 2020 08:19:58 +0000 (17:19 +0900)]
Update Unittest

- Adds 'FFF' for making fake function
- Adds unittest for theme_info_loader

Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>
4 years agoUse make_unique to initialize unique_ptr
Sangyoon Jang [Wed, 20 May 2020 07:29:06 +0000 (16:29 +0900)]
Use make_unique to initialize unique_ptr

Change-Id: I78a398b30b4d683935c8701f70004f57a0907052
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoFix build error
Ilho Kim [Wed, 20 May 2020 07:08:00 +0000 (16:08 +0900)]
Fix build error

Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoSet CMAKE_VERBOSE_MAKEFILE=OFF as default
Sangyoon Jang [Wed, 20 May 2020 07:02:10 +0000 (16:02 +0900)]
Set CMAKE_VERBOSE_MAKEFILE=OFF as default

To set verbose makefile on, define "verbose_make" when gbs build.
 $ gbs build --define "verbose_make 1"

Change-Id: I64c19e2ae2d63ff375801fd44b4806eba8e3c908
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
4 years agoImplement SendDataAsync function
Ilho Kim [Wed, 20 May 2020 06:57:55 +0000 (15:57 +0900)]
Implement SendDataAsync function

Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoAdd Subscribe function to RequestBroker for client
Ilho Kim [Wed, 20 May 2020 04:24:20 +0000 (13:24 +0900)]
Add Subscribe function to RequestBroker for client

This function for listening the theme event signal

Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoAdd Request filter's is_oneway_ member variable
Ilho Kim [Tue, 19 May 2020 23:30:15 +0000 (08:30 +0900)]
Add Request filter's is_oneway_ member variable

Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoFix dbus arguments
Ilho Kim [Tue, 19 May 2020 04:25:04 +0000 (13:25 +0900)]
Fix dbus arguments

Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
4 years agoImplements theme_info_loader
Inkyun Kil [Tue, 19 May 2020 02:28:43 +0000 (11:28 +0900)]
Implements theme_info_loader

Signed-off-by: Inkyun Kil <inkyun.kil@samsung.com>