Hyuk Lee [Wed, 28 Mar 2018 02:38:21 +0000 (11:38 +0900)]
Add the delay report property
Change-Id: I3abe8e8b71bb39027c2f0c29e326fc8acc3b6cdb
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Amit Purwar [Wed, 4 Apr 2018 12:07:48 +0000 (17:37 +0530)]
Fix A2DP Sink device disconnect after pause and play
Change-Id: I35ced6cb1ef63f430c2120e3edc680e767929ea0
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
Pyun DoHyun [Thu, 29 Mar 2018 05:07:20 +0000 (05:07 +0000)]
Merge "Enable check-TESTS using %check section in bluez" into tizen
Atul Rai [Wed, 28 Mar 2018 10:58:55 +0000 (16:28 +0530)]
Enable check-TESTS using %check section in bluez
This patch enables check-TESTS (unit test case execution) for bluez at
build time using %check section in bluez.spec. This patch,
- Modifies unit/test-gobex.c, unit/test-gatt.c, unit/test-hog.c and
unit/test-gattrib.c to handle Tizen specific changes in BlueZ.
- Disables crypto test cases (unit/test-crypto) as QEMU (v2.7.0) in
Tizen does not support AF_ALG socket option for cypher algorithms.
Change-Id: I5a49ac00a26fe5c1baf92b02915cf1bcfa30f68b
Signed-off-by: Atul Rai <a.rai@samsung.com>
Abhishek Chandra [Tue, 27 Mar 2018 09:32:51 +0000 (15:02 +0530)]
[BlueZ] BlueZ Upgrade changes missed for OOB(out of band)
merged to fix TCT failures.
Change-Id: I6c8e71823a8d3f7254318d3f7759c334b6eb9a4d
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
Hyuk Lee [Mon, 26 Mar 2018 01:40:57 +0000 (10:40 +0900)]
Add the bluetooth.service file to wearable profile
Change-Id: Ia04887e12d41ff49ef7dac3147df166f96e79efc
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Avichal Agarwal [Thu, 22 Mar 2018 07:56:31 +0000 (13:26 +0530)]
Coverity Fix :CID 28838 :. leaked_storage: Variable uuid
going out of scope leaks the storage it points to
Change-Id: I948df8fae62bf440ac4d50a9a7cfa9cc95bdcec3
Pyun DoHyun [Tue, 20 Mar 2018 23:36:49 +0000 (23:36 +0000)]
Merge "Add lower bound check for manufacturer_data_len (Fix WGID: 311536)" into tizen
Atul Rai [Tue, 20 Mar 2018 10:17:05 +0000 (15:47 +0530)]
Add lower bound check for manufacturer_data_len (Fix WGID: 311536)
Change-Id: I2da413abe09c2ad1f3c98a9b69f561090ebcbfbc
Signed-off-by: Atul Rai <a.rai@samsung.com>
Hyuk Lee [Tue, 20 Mar 2018 04:58:21 +0000 (13:58 +0900)]
Fix the coverity issue
Change-Id: I984810e507f435e45108c0816d169e8447336716
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Atul Rai [Wed, 14 Mar 2018 11:50:29 +0000 (17:20 +0530)]
Fixed removal of LE devices on stopping LE scan
Issue: LE connect fail with error "Device path not found".
Cause: Device flags are incorrectly updated to 0 on receiving
scan_response data. Later on stopping LE scan, the LE device
is considered non-connectable based on device flag which was
incorrectly updated to 0 during scan_response event and the
device is removed immediately. This causes LE connect to fail
with error "device path not found".
Solution: This patch fixes the issue by checking adv pkt type
before updating the device flag on device found event.
Change-Id: Id86b024dfc6c980780aef6cdda8e6dcc6b150b80
Signed-off-by: Atul Rai <a.rai@samsung.com>
Atul Rai [Wed, 14 Mar 2018 11:47:50 +0000 (17:17 +0530)]
Fixed "stop LE scan" fail issue
Change-Id: I86b977bbdc3b110eb21db025cf72ffe22f89aad9
Signed-off-by: Atul Rai <a.rai@samsung.com>
Atul Rai [Wed, 14 Mar 2018 11:45:09 +0000 (17:15 +0530)]
Fix bluetoothd crash on stopping device discovery
Change-Id: Ic95272adc88d83af0aa98e3f7290d9f3dd15dd86
Signed-off-by: Atul Rai <a.rai@samsung.com>
Anupam Roy [Mon, 19 Mar 2018 08:26:31 +0000 (13:56 +0530)]
[BlueZ upgrade 5.43 to 5.48] Patch 2/2
Change-Id: I26e0fde334c2eac84d3f19370cab6dfbed073d2f
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
Anupam Roy [Mon, 19 Mar 2018 08:24:55 +0000 (13:54 +0530)]
[BlueZ upgrade 5.43 to 5.48] Patch 1/2
Change-Id: I8aaefc910e3840ce89648032ac1911fd23e764bc
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
Atul Rai [Fri, 23 Feb 2018 07:22:15 +0000 (12:52 +0530)]
Fix A2DP reconnection issue
AVDTP session is not released even after session ref count reached 0 and
hence media audio (A2DP) reconnection failed. This patch fixes this issue
by releasing AVDTP sesson when session ref count reaches 0.
Issue reproduce Condition:
1/ Connection Call Audio & Media Audio
2/ Disconnect Media Audio
3/ Try to Reconnect media audio
Connection failed (Connection Timed Out).
Change-Id: I6210f2b9d01b91df10913a200d131d10aaad167d
Signed-off-by: Atul Rai <a.rai@samsung.com>
Hyuk Lee [Mon, 12 Feb 2018 01:10:01 +0000 (10:10 +0900)]
Modify the UID/GID to network_fw
Change-Id: Ie523965c1ef3fcc54c321dbccce3811ed6f2fa31
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
DoHyun Pyun [Wed, 24 Jan 2018 02:07:51 +0000 (11:07 +0900)]
Disable %check section
Change-Id: I95339a9d3d85e34f831f7e684d0f0c7972527beb
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Tue, 19 Dec 2017 04:57:34 +0000 (13:57 +0900)]
Fix the crash connected as AVRCP target role
Change-Id: I03b64d72243fdfdf4e7adb45fe5e7dc56dca8fea
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Tue, 19 Dec 2017 00:38:37 +0000 (09:38 +0900)]
Fix the crash issue in the a2dp select role function
Change-Id: I328a9e72358672ec1ade61e19ebd459568132785
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Mon, 18 Dec 2017 01:33:17 +0000 (10:33 +0900)]
Add AVRCP control volume up / down method
Change-Id: I5ea7237aaed1e27bd9e0b8e555177b6ec84f0dd1
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Nagaraj D R [Thu, 7 Dec 2017 12:40:43 +0000 (18:10 +0530)]
Keep Tizen specific code under flag
bluez upgradation will be difficult if
tizen specific code is not under a flag
Change-Id: I6e6b16a5ad9a9829de5c8d54059d8168b343b289
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Seungyoun Ju [Thu, 7 Dec 2017 08:39:57 +0000 (17:39 +0900)]
Remove unnecessary logs
[Problem] There are unnecessary logs
[Cause & Measure] Remove the logs
[Checking Method] journalctrl -f | grep bluetooth
Change-Id: Ia0c392db29522c9fed0df505194fd10e73931b8b
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Seungyoun Ju [Thu, 7 Dec 2017 08:18:38 +0000 (17:18 +0900)]
shared/gatt-client: Fix discovering included svcs using invalid range
[Problem] It discovers included services using invalid handle range 0 ~ 0.
It causes ATT error response and GATT connection is failed.
[Cause & Measure] When any service is removed over the previous connection,
pending_svcs queue is not empty because it is used to identify
disappeared services. So we need to check more if there are any services
to be discovered or not.
This patch checks the service range and if there is no service
to be discovered, stop the discovery.
[Checking Method] Connect to iOS -> Turn off and on iOS's Bluetooth
Change-Id: I312cba9a53c55ce266d98196e3ba81b236d885e9
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Luiz Augusto von Dentz [Tue, 30 May 2017 11:40:56 +0000 (14:40 +0300)]
shared/gatt-client: Fix removing services with no attributes
This patch comes from below commit of upstream.
commit
d6c07ecf22ba60d6dd1b7302281eb32e1f278ca7
Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Date: Tue May 30 14:40:56 2017 +0300
shared/gatt-client: Fix removing services with no attributes
If a service has no attributes, like IPSS, just mark it as active and
skip doing any attribute discover.
Change-Id: I08eac1787f95fd091470496764bf8cf9924c0520
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Luiz Augusto von Dentz [Wed, 24 May 2017 10:22:01 +0000 (13:22 +0300)]
shared/gatt-client: Fix not removing services that had disappeared
[Problem] There are duplicated services in gatt client database.
[Cause & Measure] When GATT service discovery happens and there are no
services in the middle of discovery range, the services in that range
are not removed. This causes a local application recognize that the
services exist. But those are actually removed in remote side so
the local application malfunction happens.
[Checking Method] Connect device to iOS. It happens rarely but it makes
the issue happen with below procedures.
1. Connect two bluez devices via BLE
2. Make pair
3. Register any service in one side (A)
4. Disconnect BLE
5. Unregister the service and register it again on side A
6. Make a connection again
7. Check the side A's services on side B
This patch comes from below commit of upstream.
commit
6b34bdd967a639c2d219b5d83f0a20637c56e68e
Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Date: Wed May 24 13:22:01 2017 +0300
If a service cannot be found in the middle of the database the current
logic don't clear its range leaving it still active which cause upper
layer to believe its attributes are still available.
In order to fix the code now loads existing services into the pending
list and remove the services left at the end of the discovery:
src/device.c:gatt_debug() Primary services found: 2
src/device.c:gatt_debug() start: 0x0001, end: 0x0005, uuid:
00001800-0000-1000-8000-
00805f9b34fb
src/device.c:gatt_debug() start: 0x0100, end: 0x0104, uuid:
0000180a-0000-1000-8000-
00805f9b34fb
src/device.c:gatt_debug() Secondary service discovery failed. ATT ECODE: 0x0a
src/device.c:gatt_debug() Characteristics found: 2
src/device.c:gatt_debug() start: 0x0101, end: 0x0102, value: 0x0102, props: 0x02, uuid:
00002a24-0000-1
src/device.c:gatt_debug() start: 0x0103, end: 0x0104, value: 0x0104, props: 0x02, uuid:
00002a29-0000-1
src/device.c:gatt_debug() service disappeared: start 0x0006 end 0x000a
src/device.c:gatt_service_removed() start: 0x0006, end: 0x000a
Change-Id: I8ef0b3c3feaadaa61d280f494532ab26ceecec2e
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Andy Duan [Thu, 20 Jul 2017 13:14:59 +0000 (16:14 +0300)]
hciattach: fix the delay timer for bcm43xx firmware download
From the log in .bcm43xx_load_firmware():
/* Wait 50ms to let the firmware placed in download mode */
nanosleep(&tm_mode, NULL);
But timespec tm_mode is real is 50us. Correct the delayed timer count.
[lhs: Cherry-Picked from
git://git.kernel.org/pub/scm/bluetooth/bluez.git
commit
76255f732d68aef2b90d36d9c7be51a9e1739ce7]
Change-Id: I52dfa83c0f7e0cdf17fa24ade36fc88716f56b05
Signed-off-by: Hackseung Lee <lhs@dignsys.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
injun.yang [Mon, 20 Nov 2017 04:20:27 +0000 (13:20 +0900)]
Change the property of IAS characteristic
[Problem] Write property is not permitted on IAS
[Cause & Measure] Change the property as per IAS specification.
Write -> WriteWithoutResponse property
Change-Id: I22687ea06359035913de687a7f474be5f1a57125
Signed-off-by: Injun Yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Seungyoun Ju [Fri, 17 Nov 2017 02:24:46 +0000 (11:24 +0900)]
btmon : SDP continuation list is not reset after use
[Problem] After receiving attribute response which has continuation
part more than 7 times, btmon doesn't print the decoded result.
[Cause & Measure] After combining attributes response, cont_list[x].cont is not
reset.
Change-Id: If6087288d10e446e9491e62eb2dd3250822e4311
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Seungyoun Ju [Tue, 14 Nov 2017 06:15:00 +0000 (15:15 +0900)]
Fix btmon crash
[Problem] btmon crash happens
[Cause & Measure] When SDP continuation is handled, other variable's
value is overwritten because invalid array index is used for memcpy's
src.
[Checking Method] Run btmon -> Connect Android phone to KITT ->
Terminate btmon. In this procedure, btmon crash happens randomly.
When issue happens, irk_list's value is corrupted by invalid memcpy.
This causes crash when it accesses to irk_list.
1: irk_list = (struct queue *) 0xb7cda0a0
(gdb)
499 memcpy(cont_list[i].cont, data + bytes, data[bytes] + 1);
1: irk_list = (struct queue *) 0xb7cda0a0
(gdb)
0xb6f5f1a8 in memcpy@plt ()
1: irk_list = (struct queue *) 0xb7cda0a0
(gdb)
Single stepping until exit from function memcpy@plt,
which has no line number information.
memcpy () at ../sysdeps/arm/memcpy.S:63
...
1: irk_list = (struct queue *) 0xb7000002
(gdb)
search_attr_rsp (frame=0xbeadd3f8, tid=0xb6fcd760 <tid_list>) at monitor/sdp.c:669
669 clear_tid(tid);
1: irk_list = (struct queue *) 0xb7000002
(gdb) p cont_list
$5 = {{channel = 0, cont = '\000' <repeats 16 times>, data = 0xb7cda3a0, size = 656}, {channel = 0, cont = '\000' <repeats 16 times>, data = 0x0, size = 0}, {channel = 0,
cont = '\000' <repeats 16 times>, data = 0x0, size = 0}, {channel = 0, cont = '\000' <repeats 16 times>, data = 0x0, size = 0}, {channel = 0, cont = '\000' <repeats 16 times>,
data = 0x0, size = 0}, {channel = 0, cont = '\000' <repeats 16 times>, data = 0x0, size = 0}, {channel = 0, cont = '\000' <repeats 16 times>, data = 0x0, size = 0}, {channel = 0,
cont = '\000' <repeats 16 times>, data = 0x0, size = 0}}
Change-Id: I3608d1b9cf14bbfc87d17fbad6a443bdcbdf87af
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
injun.yang [Mon, 13 Nov 2017 07:03:30 +0000 (16:03 +0900)]
Fix : GATT connection event is not delivered to bt-frwk
[Model] All
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A
[Problem] After BLE connection established, GATT connection event
is not delivered to bt-frwk side.
[Cause & Measure] Before emit signal, AP move to sleep status.
Reduce timeout interval
[Checking Method] GATT connection
[Team] Basic Connection
[Developer] Injun Yang
[Solution company] Samsung
[Change Type] Specification change
Change-Id: Ic3478333845ec0994a9424d40b8cfb9fd5fe0c1d
Signed-off-by: Injun Yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Deokhyun Kim [Tue, 7 Nov 2017 09:45:54 +0000 (18:45 +0900)]
Return already_connected msg when service is already connected
Change-Id: I754540f397b47d6c4e4e27f985d43d85a51b9e12
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Deokhyun Kim [Fri, 13 Oct 2017 05:35:45 +0000 (14:35 +0900)]
Remove Keyboard consumer page of HID.
- Some Windows PCs disconnect HID channel right after connected.
It assuems that some PCs can NOT parse consumer descriptor.
Change-Id: I79dc006d9cd663414970aa5bf4e61ef65af07479
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
injun.yang [Fri, 13 Oct 2017 00:24:41 +0000 (09:24 +0900)]
Set env PATH for security
Change-Id: I7bd64c78648615a70ef7e69c63abd23de1ef18fb
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Signed-off-by: injun.yang <injun.yang@samsung.com>
Atul Rai [Mon, 25 Sep 2017 10:48:50 +0000 (16:18 +0530)]
Fix bluetoothd crash in discover_services_reply()
This patch fixes bluetoothd crash in discover_services_reply while
handling sdp browse results if results contains invalid utf8
charactors.
Crash call stack is given below for reference:
0 0xb6ab8094 in raise () from /lib/libc.so.6
1 0xb6ab93f0 in abort () from /lib/libc.so.6
2 0xb6d30250 in ?? () from /lib/libdbus-1.so.3
3 0xb6d29754 in _dbus_warn_check_failed () from /lib/libdbus-1.so.3
4 0xb6d1f8a4 in dbus_message_iter_append_basic () from /lib/libdbus-1.so.3
5 0xb6eccc60 in iter_append_record () at src/device.c:3285
6 discover_services_reply () at src/device.c:3338
7 0xb6ed303c in search_cb () at src/device.c:6657
8 browse_cb () at src/device.c:6695
9 0xb6eae54a in search_completed_cb () at src/sdp-client.c:205
10 0xb6edf77a in sdp_process () at lib/sdp.c:4354
...
Change-Id: Id11dff0f2304f7e3dc6cd645b3418382744b1759
Signed-off-by: Atul Rai <a.rai@samsung.com>
DoHyun Pyun [Fri, 22 Sep 2017 05:07:05 +0000 (14:07 +0900)]
Fix the arch64 build error
Change-Id: If6ef35e7811c2f6067f96439e517f3d18294a094
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Thu, 21 Sep 2017 06:30:38 +0000 (15:30 +0900)]
Add the Werror build option
Change-Id: I0f0bfb0c30832828602a67767145a5913c15215b
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Thu, 21 Sep 2017 05:25:57 +0000 (14:25 +0900)]
Fix the build warning error in tizen patch codes
Change-Id: Ie37a309958c86ad6cf7c1ec9366d866f59abdd5b
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Deokhyun Kim [Thu, 14 Sep 2017 07:42:26 +0000 (16:42 +0900)]
Fix Mouse descriptor for HID
Change-Id: I3bc251349c8a32625fae1069d4135418f68bb779
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Luiz Augusto von Dentz [Wed, 13 Sep 2017 07:01:40 +0000 (10:01 +0300)]
sdp: Fix Out-of-bounds heap read in service_search_attr_req function
Check if there is enough data to continue otherwise return an error.
(CVE-2017-1000250)
Change-Id: I45d44d1bad703fa22af0f1d13cf710686ad64aae
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Sunmin Lee [Wed, 6 Sep 2017 08:27:55 +0000 (17:27 +0900)]
Remove update script for unsupported version
RW update script for Tizen 2.4 (to 3.0) is not necessary in Tizen 4.0.
(Tizen 4.0 does not support upgrade from Tizen 2.4)
Remove this file in terms of clearing the redundancy.
Change-Id: Id6ec06f667dc82f538b2cfea2c99b4e11be250ea
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Wed, 6 Sep 2017 02:20:40 +0000 (11:20 +0900)]
Apply tizen 3.0 based product patchsets
-------------------------------------------------------
commit
c396c5b362f3c376c1afb390c23476ae9f482697
Author: Biman Paul <biman.paul@samsung.com>
Date: Fri Aug 4 19:59:40 2017 +0530
Use Trusted Profiles instead of Restricted Profiles
-------------------------------------------------------
Change-Id: I5b38f1a17762d17391cda458fa9ae2204dd25b03
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Tue, 29 Aug 2017 07:44:28 +0000 (16:44 +0900)]
Enable the tds plugin
Change-Id: I461bc84d5e4ef1608ba5e7d098e33b0f65d49d90
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Pyun DoHyun [Tue, 29 Aug 2017 00:02:14 +0000 (00:02 +0000)]
Merge "[TDS Plugin] Use .accept and .disconnect" into tizen
Hyuk Lee [Mon, 28 Aug 2017 12:01:42 +0000 (21:01 +0900)]
Remove .swp file
Change-Id: Iee53a86179d3815c11c930daa4f4cc03ccbe9291
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Anupam Roy [Mon, 28 Aug 2017 09:15:44 +0000 (14:45 +0530)]
[TDS Plugin] Use .accept and .disconnect
Remove the dependency of btd_device_attio function
and use .accept and .disconnect instead
Change-Id: I2ba3abad89df4b68e13742ce76fa405dd376e106
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
h.sandeep [Wed, 23 Aug 2017 10:18:49 +0000 (15:48 +0530)]
use .accept and .disconnect
Remove the dependency of btd_device_attio function
and use .accept and .disconnect instead
Change-Id: I0ddfaed823e7061a0171dde28c0e87d785677f70
Signed-off-by: h.sandeep <h.sandeep@samsung.com>
DoHyun Pyun [Mon, 21 Aug 2017 03:49:31 +0000 (12:49 +0900)]
Enable the proximity plugin
Change-Id: Ie0c4daa06bdf0296a4bb09f13e365600df5b3bbc
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Hyuk Lee [Tue, 22 Aug 2017 05:55:48 +0000 (14:55 +0900)]
Update the RW upgrade script
Change-Id: I276ad53083661c4b00f837b9fc4ad8dc08588b27
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
DoHyun Pyun [Fri, 11 Aug 2017 03:02:16 +0000 (12:02 +0900)]
Don't install obex.service file in the target image
obexd process is launching as dbus auto-activation.
So don't need to install the systemd's service file.
Change-Id: I36059dad412eda7fb97635dee54cf827de59a8c5
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Thu, 3 Aug 2017 05:07:53 +0000 (14:07 +0900)]
Apply tizen 3.0 based product patchsets
-------------------------------------------------
commit
8b87ae42ba818a0a469f51a45a5a9838e9894a4d
Author: Anurag Biradar <biradar.a@samsung.com>
Date: Mon Apr 10 19:51:01 2017 +0530
-------------------------------------------------
Change-Id: I067d5801f179cfdec856c90757b1a680f7d47150
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Gowtham Anandha Babu [Wed, 2 Aug 2017 07:18:53 +0000 (12:48 +0530)]
[GATT-Server] Add offset for Read/Write operations
Change-Id: I37e668499ea2b9b79d3fd10c055444353165f1dd
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
Hyuk Lee [Thu, 27 Jul 2017 11:27:21 +0000 (20:27 +0900)]
Select the preferred codec
Change-Id: Ic7e99cfcd0ecd19e996341ae793c7c66cd71dd54
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Gowtham Anandha Babu [Wed, 26 Jul 2017 07:17:56 +0000 (12:47 +0530)]
[OTP] Seperate out OTP application ecode
Change-Id: I65aa94f2c1e8e495e2754faa97c74acfa275e617
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
injun.yang [Tue, 25 Jul 2017 14:36:47 +0000 (20:06 +0530)]
[GATT Server] Delivery the specific error code to central device
[Problem] Unalbe to pass application error code to central device
[Cause & Measure] Pass the specific error code to central device
[Checking Method] Reponse with the specific error to central device
Change-Id: Icb9eb38e0f7759d5aeb898eef92d1327233e9a48
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
DoHyun Pyun [Mon, 24 Jul 2017 08:00:55 +0000 (17:00 +0900)]
Clean up the previous build result for re-configuration
Change-Id: I113814cd46c1249e93594d110d135da3b451d6ec
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Mon, 24 Jul 2017 02:31:55 +0000 (11:31 +0900)]
Add the bluez extension packages for BREDR / LE only mode
Without extension package bluetoothd will be installed for normal
mode. So there is no side effect to the original image.
Change-Id: I2e649c8e170248506dfd0b9547ffe3f6b658bb76
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Gowtham Anandha Babu [Tue, 18 Jul 2017 13:25:08 +0000 (18:55 +0530)]
[GATT Client] Deliver ATT error code to higher layer
[Problem] ATT error code is not passed to application.
[Cause & Measure] GATT application need to know ATT
error code to handling error case. Specially application
error code defined by a higher layer specification.
[Checking Method] GATT error handling
Change-Id: I6b8b689866f630fd40acbc822ca215807534ee60
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
DoHyun Pyun [Tue, 18 Jul 2017 02:36:02 +0000 (02:36 +0000)]
Merge "Modify the generated file permission to 0644" into tizen
DoHyun Pyun [Mon, 17 Jul 2017 06:11:14 +0000 (15:11 +0900)]
Modify the generated file permission to 0644
Tizen will handle the access permission to the file
using group and privilege.
Change-Id: I7ea181fa92cff5d0489503eed62f9ed593ffd1b6
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Gowtham Anandha Babu [Fri, 14 Jul 2017 12:05:00 +0000 (17:35 +0530)]
[OTP] Handle CCC Improperly Configured ATT ecode
Change-Id: Ic3519eade6c8108d7ee28dcb6a557a1db60113ea
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
DoHyun Pyun [Thu, 13 Jul 2017 02:41:43 +0000 (11:41 +0900)]
Remove libbluetooth-extension-TM1 package
This patchset handles TM1 extension functionality such as
QoS control at the runtime. So don't need to use other package.
Change-Id: I9f2b4a3006046a6f05c0ec662e9ce146d5db6abd
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Hyuk Lee [Mon, 3 Jul 2017 06:28:17 +0000 (15:28 +0900)]
Add the AVRCP SetAbsoluteVolume handler
Change-Id: I5d8d770c3c155bfb3b7e2369afe4d9fe14b9e68e
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Hackseung [Thu, 22 Jun 2017 07:47:11 +0000 (16:47 +0900)]
The BCM43438 on the Rpi3 needs a delay after firmware download.
Followed the Tizen's coding style.
Thanks for reminder.
Change-Id: If89df08fbd5d1fe0744e7d6b2eb0b4f63e799212
Gowtham Anandha Babu [Wed, 14 Jun 2017 12:11:54 +0000 (17:41 +0530)]
Fix dbus error in GATT read/write request
The below error is captured on bt-frwk.
Error : GDBus.Error:org.bluez.Error.Failed: Error return with body of type '(sy)':
Bluez sends the reply in (sy). But what we want is only att_ecode.
After fix, the application will get the proper att_ecode for
GATT read/write request.
Change-Id: Ib6abf0acd44fa70740913308b2d9748e34f39fab
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
Hyuk Lee [Wed, 14 Jun 2017 08:41:25 +0000 (17:41 +0900)]
Add the EV_ABS key for AVRCP
Change-Id: Iad4cb4f268f6044efa4b983ab9df68f7cc27354c
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
DoHyun Pyun [Tue, 30 May 2017 05:18:36 +0000 (14:18 +0900)]
Modify the uid and gid of obexd to network_fw
The uid of tizen's bt-service will be changed to network_fw from owner.
'network_fw' is a no app user, so it can't use the session bus connection.
Because of this, tizen obexd's dbus connection also change to system bus.
Change-Id: I73f66e8a451a2b3b62c9f03a8468b824813d8767
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Gowtham Anandha Babu [Mon, 29 May 2017 13:19:21 +0000 (18:49 +0530)]
[OTP] Fix sending OtcDisconnected signal
Change-Id: Ia68dbecf8ca0acf9422a5b5d6b7318b8fa864f0b
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
Pyun DoHyun [Mon, 29 May 2017 03:45:59 +0000 (03:45 +0000)]
Merge "[OTP] Add support for Object Transfer Channel" into tizen
h.sandeep [Wed, 24 May 2017 22:35:39 +0000 (04:05 +0530)]
[Gatt-Client]: Fix Notification callback issue.
This patch fixes the notification callback issue
when gatt client clone logic is used.
Change-Id: I2f15256ab27dd401d93bdb49ae16199fed00bff5
Signed-off-by: h.sandeep <h.sandeep@samsung.com>
Gowtham Anandha Babu [Wed, 24 May 2017 08:04:58 +0000 (13:34 +0530)]
[OTP] Add support for Object Transfer Channel
Expose below DBus APIs:
* ConnectOtc - bt_io_connect()
* DisconnectOtc - shutdown()
* ListenOtc - bt_io_listen()
Change-Id: Ifa4379508e0d35500b141b597f30a9429d2e695a
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
h.sandeep [Tue, 23 May 2017 17:03:21 +0000 (22:33 +0530)]
GATT-Clinet: Fix the Write and read dbus reply parameter mismatch.
This patch fixes the dbus reply parameter mismatch issue, in the
case where the att request reply is success.
Change-Id: I8abc38f55ce94cb0fc1621912ac8a3ac293aff18
Signed-off-by: h.sandeep <h.sandeep@samsung.com>
Hyuk Lee [Tue, 23 May 2017 07:05:04 +0000 (16:05 +0900)]
Modify the service file
Change-Id: If124243661007327256587fce820a39d74457f95
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
DoHyun Pyun [Tue, 23 May 2017 01:31:39 +0000 (10:31 +0900)]
Fix Web TCT issue for GATT client write callback
Change-Id: Ib02828785381e9f72598c8b1bdcc77a16faed13b
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Thu, 13 Apr 2017 04:09:48 +0000 (13:09 +0900)]
Add the dbus interface for LE OOB pairing
To use LE OOB pairing, we should assign BD address type in kernel MGMT.
This patchset adds BD address type in the remote oob data setting dbus API.
Change-Id: Ie1c47e43ce8dab9878977aea450b5c2d2e1a5401
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Gowtham Anandha Babu [Tue, 28 Mar 2017 12:39:09 +0000 (18:09 +0530)]
[Bluetooth][OTP] Handle OTP specific ATT error codes
Refer OTS specification, section 1.10 Application
Error Codes.
Change-Id: Id91b4788ccd9ac22885412e4808040e4c1ab343c
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
DoHyun Pyun [Tue, 4 Apr 2017 09:27:54 +0000 (18:27 +0900)]
Fix the svace issue (146010)
Change-Id: I1dc1a50946b1734d80c267e4901a6f72ee4b01c4
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
h.sandeep [Thu, 2 Feb 2017 11:19:57 +0000 (16:49 +0530)]
Bluez 5.43 Upgrade: Apply Tizen patches
Change-Id: I5d5a9d9e2e7811af3dd3878b4f740e1f1a019d51
Signed-off-by: h.sandeep <h.sandeep@samsung.com>
h.sandeep [Tue, 31 Jan 2017 11:09:02 +0000 (16:39 +0530)]
Bluez 5.43 Upgrade: Fix build errors
Change-Id: Ibfdf9a50a642c6917d7f0db4ff3f2f0104c3b811
Signed-off-by: h.sandeep <h.sandeep@samsung.com>
h.sandeep [Tue, 28 Mar 2017 10:53:30 +0000 (16:23 +0530)]
Bluez Upgrade: Add Bluez 5.43 open source code.
Change-Id: Ife8b8b7b7163ca2d6c521cdb7f99c2ae90b14ba0
Signed-off-by: h.sandeep <h.sandeep@samsung.com>
h.sandeep [Fri, 24 Mar 2017 10:42:18 +0000 (16:12 +0530)]
GATT-Client: Fix Primary list overwrite issue.
This patch fixes the primary list getting overwrite while
registering the gatt services in client role of bluez code
when the gatt plugins are enabled.
This isuue was leading to CAPI layer failure to fetch the
primary service after connection.
Change-Id: Ib8bceab634c23520828d10010641647243a6aac5
Signed-off-by: h.sandeep <h.sandeep@samsung.com>
Lee Hyuk [Wed, 22 Mar 2017 06:37:38 +0000 (15:37 +0900)]
Add the Auto Connection mode for headless device
Change-Id: I08207bba60628d92d63a424cb3e1302d11182f67
Signed-off-by: Lee Hyuk <hyuk0512.lee@samsung.com>
Seungyoun Ju [Tue, 13 Sep 2016 13:00:59 +0000 (22:00 +0900)]
Support old storage format
[Model] COMMON
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A
[Problem] Old storage has BR/EDR/LE information in one RPA directory. So
dbus object path is made as RPA. If we pass IDA when upper layer
requests, it cannot be used because there is no matched dbus object
path.
[Cause & Measure] Current storage policy separates BR/EDR and LE
information to each addresses. So both dbus object paths are created. So
in this case, IDA should be passed to upper layer. But in case of old
version's paired device, RPA should be passed to upper layer.
[Checking Method] The device which has old storage (e.g. R730 VP1) makes
pairing with iOS -> FOTA to new storage (e.g. VP2)
[Team] Basic connection
[Developer] Seungyoun Ju
[Solution company] Samsung
[Change Type] Specification change
Change-Id: I3dd1a1afad93a38ee2b3bfd2bb6cc371cc066dc2
Seungyoun Ju [Wed, 8 Mar 2017 08:09:12 +0000 (17:09 +0900)]
Apply rotated file writing to hcidump
[Model] COMMON
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A
[Problem] Change was missing. Without this option, hci logging file
could be increased infinitely.
[Cause & Measure] Apply change
[Checking Method] hcidump -c 2 -s 10 -w hci_log.cfa
[Team] Basic connection
[Developer] Seungyoun Ju
[Solution company] Samsung
[Change Type] Specification change
Change-Id: I24bade6d0893c399ae10d7efa9ca3bb42a3a3b70
Seungyoun Ju [Wed, 8 Mar 2017 07:28:52 +0000 (16:28 +0900)]
Fix btsnoop crash when handling btmon
[Model] Solis
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A
[Problem] btsnoop is crashed since new kernel is introduced because it
brings new opcode.
[Cause & Measure] it should be skipped properly to make compatible btnsoop.
[Checking Method] Build and verification on target
[Team] System Connectivity
[Developer] Chanyeol Park
[Solution company] Samsung
[Change Type] Specification change
Change-Id: I245dbb1bedbab99e5a5e05289b42353ba76195b6
Deokhyun Kim [Thu, 9 Mar 2017 06:27:13 +0000 (15:27 +0900)]
Ignore probe_service even if the service is already added.
Cause : Issue happened when,
0. Gear doesn't have pairing information about remote device.
1. Remote device initiates HFP connection to Gear
2. Paired
3. Gear's Reverse service discovery timer (1s) is expired before HFP
connection request comes. So device_browse_sdp() is called and
service resolving is almost done.
4. HFP connection request comes. So HFP service has been probed here
5. SDP is done. Because there is HFP in profiles_added, HFP service
probe happens once more. This causes the issue. Normally,
duplication checking is done in update_record() by SDP logic.
But In the issue case, SDP happens first and there is no logic
to check duplication in incoming connection case (ext_confirm ->
create_conn -> btd_device_add_uuid). Measure : Ignore probe_service
even if the service is already added.
Change-Id: I68fbbe3bf510c1e7668cf12f0477cc4385ea710c
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Lee Hyuk [Fri, 3 Mar 2017 02:14:23 +0000 (11:14 +0900)]
Add the A2DP runtime role change API
Change-Id: Iae6501fa86ef18e2bb69c0f9b54ab26084d8d46f
Signed-off-by: Lee Hyuk <hyuk0512.lee@samsung.com>
DoHyun Pyun [Thu, 23 Feb 2017 04:29:20 +0000 (13:29 +0900)]
Modify the comparing statement for storing local irk
store_local_irk function's return type is bool. It can't return the
negative value. So the error logic will not work.
Change-Id: Idbf919de8db1ed56054a6d6fbe862d3315364c37
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Seungyoun Ju [Fri, 10 Feb 2017 08:42:11 +0000 (17:42 +0900)]
Keep local IRK in permanent storage
[Model] COMMON
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A
[Problem] When local IRK is changed, iOS rejects re-pairing request (iOS issue).
This issue happens in below scenario.
1. Pair with iOS
2. Factory-reset DUT
3. Try to pair with iOS again without unpairing on iOS
4. iOS sends SMP pairing error with "Unspecified reason". So until user
unpairs DUT on iOS, re-pairing is not possible.
And when local IRK is not distributed at BLE pairing with some android
devices, those devices cannot connect to DUT again via BLE (Android issue).
1. Pair with Galaxy A5 2016 / Note 4 via BLE
2. Disconnect
3. Try to connect again via BLE
4. A5 2016 / Note 4 try to connect to DUT using 00:00:00:00:00:00
address. So it is failed.
To solve these issues, DUT distributes a IRK. And after resetting DUT,
retain the IRK.
[Cause & Measure] Compatibility issues with other OS's.
[Checking Method]
===
1. Pair with iOS
2. Factory-reset DUT
3. Try to pair with iOS again without unpairing on iOS
4. iOS sends SMP pairing error with "Unspecified reason". So until user
unpairs DUT on iOS, re-pairing is not possible.
===
1. Pair with Galaxy A5 2016 / Note 4 via BLE
2. Disconnect
3. Try to connect again via BLE
4. A5 2016 / Note 4 try to connect to DUT using 00:00:00:00:00:00
===
[Team] Basic connection
[Developer] Seungyoun Ju
[Solution company] Samsung
[Change Type] Specification change
Change-Id: Ib8d2d2746d27583aa1ed36be785f0df44a95918e
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Injun Yang [Mon, 13 Feb 2017 02:51:18 +0000 (11:51 +0900)]
Set the adv flag as per address type
[Model] All
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] Internal
[Occurence Version] N/A
[Problem] Regardless of address type, set adv flag as BLE only
[Cause & Measure] Set the adv flag as per address type
[Checking Method] Scan adv
[Team] Basic Connection
[Developer] Injun Yang
[Solution company] Samsung
[Change Type] Specification change
Change-Id: I865c4461a0ec79667da4b195a0b9d85cbb69aed5
Signed-off-by: Injun Yang <injun.yang@samsung.com>
Injun Yang [Fri, 10 Feb 2017 01:44:44 +0000 (10:44 +0900)]
Update white list properly
[Model] SM-R360
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] Internal
[Occurence Version] N/A
[Problem] Unable BLE auto connection with remote device
[Cause & Measure] Address type is wrong of white list.
Set address type properly
[Checking Method] BLE auto connection with remote device
[Team] Basic Connection
[Developer] Injun Yang
[Solution company] Samsung
[Change Type] Specification change
Change-Id: I6ebb875bd9b552c4183296c3f1a88b98ad3f8948
Signed-off-by: Injun Yang <injun.yang@samsung.com>
DoHyun Pyun [Thu, 9 Feb 2017 04:46:09 +0000 (13:46 +0900)]
Remove capi-system-info package dependency
Bluez is GPL license code, so we can't use the tizen specific library
in the bluetoothd process. This patchset gets the profile information
from model config file directly.
Change-Id: I0541943b7bc30bd90b5c829b232ef58e5b2d2386
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Wed, 8 Feb 2017 05:10:37 +0000 (14:10 +0900)]
Fix the svace issue (WGID: 168473)
This patchset prevents the memory leak in the gatt operation.
Change-Id: I94b0c6b1cd9fa8eebdaf7d7155a4d4a32f4aaf61
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
Injun Yang [Wed, 8 Feb 2017 01:14:43 +0000 (10:14 +0900)]
Fix: Crash occured when HID deactived
[Model] All
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] Internal
[Occurence Version] N/A
[Problem] When HID deactived, crash occured
[Cause & Measure] Access the invalid memory
[Checking Method] Check the validation of variable.
[Team] Basic Connection
[Developer] Injun Yang
[Solution company] Samsung
[Change Type] Specification change
Change-Id: Ifd88e39c98cccb29f3b4eaad23b1fa53b669da47
Signed-off-by: Injun Yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
DoHyun Pyun [Tue, 7 Feb 2017 01:23:58 +0000 (10:23 +0900)]
Merge latest tizen_3.0 bug fix codes
----------------------------------------------------
commit
385eeab470fd6a0f79a001095df02d6948135ad8
Author: Anupam Roy <anupam.r@samsung.com>
Date: Fri Jan 6 18:06:38 2017 +0530
----------------------------------------------------
Change-Id: I38052f22d141bf780dab8f7258abd5fa740a64b9
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
hk57.kim [Mon, 16 Jan 2017 06:00:36 +0000 (15:00 +0900)]
[4.0] Remove Repository Dependency
- This is for Tizen 4.0
- We are going to unify repositories as well as build projects.
- When you SR this, you need to create JIRA-TRE issue of:
: add mobileap-agent-extension-TM1 for TM1 (mobile)
Change-Id: I3fcb866035ea2a5a02d28d0574858d1d5e746aeb
Signed-off-by: hk57.kim <hk57.kim@samsung.com>
Seungyoun Ju [Fri, 2 Dec 2016 05:40:41 +0000 (14:40 +0900)]
GATT Server : Provide a response necessity
[Model] COMMON
[BinType] AP
[Customer] OPEN
[Issue#] N/A
[Request] Internal
[Occurrence Version] N/A
[Problem] Applications couldn't know whether this write request require a
response or not
[Cause & Measure] There was no information about a response necessity.
And reply required dbus call is always used unnecessarily. This patch
provides a reponse necessity to above layer and uses no reply dbus call
for Write Without Response command.
[Checking Method] Add some writable characteristics to GATT Server ->
Send some Write Without Reponse or Write Reqest from a remote device
[Team] Basic connection
[Developer] Seungyoun Ju
[Solution company] Samsung
[Change Type] Specification change
Change-Id: I2da48f92537ac337940d9e763b4d866f2b963fef
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
MyungJoo Ham [Tue, 29 Nov 2016 08:22:50 +0000 (17:22 +0900)]
Remove Profile Build Dependency: do it at runtime
- This is for Tizen 4.0.
: Tizen 4.0 Configurability and Build Blocks require
to remove all profile-depending build options in spec files.
(No More profile macros)
: It is recommended to distinguish features/profiles at runtime.
unless it incurs too much overhead, which requires you to
create multiple binaries and subpackages.
: Options not distinguished at runtime:
TM1
(Product only) Wearable.
For non-production, the profile==wearable is not required.
- When you send SR of this commit, you need to create
JIRA-TRE issue of:
. Add bluez-profile_mobile for mobile profile if it has bluez
. Add bluez-profile_wearable for wearble profile if it has bluez
. Add bluez-profile_tv for tv profile if it has bluez
. Add bluez-profile_ivi for ivi profile if it has bluez
. Add bluez-profile_common for common profile if it has bluez
Change-Id: Ia4cf6c31f574dd3c0323e5695e09b46b4472352d
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Deokhyun Kim [Thu, 1 Dec 2016 11:07:16 +0000 (20:07 +0900)]
Call adapter_start on idle after adapter_register is completed.
adapter_register is NOT completed yet, but tries to emit a signal in
adapter_start. Modified to call adapter_start on idle after adapter_register
is completed.
Change-Id: I51a99954e330b40c244794b6d000698e4636cedf
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Deokhyun Kim [Wed, 30 Nov 2016 05:33:00 +0000 (14:33 +0900)]
Check NULL for dev->disconnect
[Problem] bluez crashes when disconnecting hid fails
[Cause & Measure] dev->disconnect is already unrefed but tries again with NULL
[Checking Method] Launch VR Controller App wihtout GearVR
Change-Id: Iee9cd0d6793fac6c2c4f7ec54040293321383e7a
Signed-off-by: Injun Yang <injun.yang@samsung.com>