Sangchul Lee [Thu, 11 Jan 2024 07:37:40 +0000 (16:37 +0900)]
webrtc_tbm/stats: Introduce ASSERT() macro function
Note that this assertion would be helpful not only during early
of the development phase to check unexpected wrong codes but
also during the runtime with being attributed to the compiler
optimizations.
Enough awareness of parameters whether if they are inevitable
or not would be prerequisite before applying it.
[Version] 0.4.35
[Issue Type] Debug
Change-Id: I29834774100c613a0f2154b589b8142342be40d8
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 11 Jan 2024 07:19:49 +0000 (16:19 +0900)]
test: Add missing lock
[Version] 0.4.34
[Issue Type] Coverity defect (MISSING_LOCK)
Change-Id: Id969572e1896b660b620216ecb376a43d4a891fd
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 11 Jan 2024 02:58:49 +0000 (11:58 +0900)]
webrtc_internal: Set payloader type only if it is not occupied
Codes for occupying and releasing payload type have been added in
webrtc_media_source_set_payload_type().
Checking the media_type parameter of webrtc_media_source_get_payload_type()
has been added to fix coverity defect.
[Version] 0.4.33
[Issue Type] Improvement
Change-Id: I9eaf492456d24977d300d0682bcbbf60acd0f9ef
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 10 Jan 2024 08:13:25 +0000 (17:13 +0900)]
webrtc_transceiver: Fix unwanted payload type number order
This patch fixes the issue where there is another media source added
before the null source, the payload type number gets reversed because
the payload type number of the null source type was obtained when calling
webrtc_media_source_set_transceiver_codec() whereas other source type
get it when calling webrtc_start().
[Version] 0.4.32
[Issue Type] Bug fix
Change-Id: Ib438dc280c843ddf8652d114a4ced23319f73b71
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 9 Jan 2024 03:57:39 +0000 (12:57 +0900)]
webrtc_transceiver: Get mid from transceiver name
This mid value will be set later to rtp header extension
for simulcast preparation.
[Version] 0.4.31
[Issue Type] Improvement
Change-Id: Ie85ddca278eb6a179e1753e5618f010a140ef8e2
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 4 Jan 2024 03:27:02 +0000 (12:27 +0900)]
Adjust order of returning error values
The order of errors for particular functions were not in compliance with
the following sequence.
- NOT_SUPPORTED > PERMISSION_DENIED > INVALID_PARAMETER
[Version] 0.4.30
[Issue Type] Improvement
Change-Id: I816ce028bc31abb601871538ea57db96f1ee4110
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 3 Jan 2024 03:02:18 +0000 (12:02 +0900)]
Add locking mutex for state
[Version] 0.4.29
[Issue Type] Coverity defect (MISSING_LOCK)
Change-Id: If29613750c55c1179a3393de65f52866be4997b8
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 27 Dec 2023 08:09:24 +0000 (17:09 +0900)]
Add new param of postfix number to CREATE_ELEMENT_FROM_REGISTRY macro function
-1 value will affect nothing.
Otherwise, the element name will be followed by the postfix number.
[Version] 0.4.28
[Issue Type] Improvement
Change-Id: I1529255b78b153deb61cd0f755f32cf7871fe9f9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 27 Dec 2023 00:47:36 +0000 (09:47 +0900)]
webrtc_source: Expand parameter to set ssrc later when making a rtp caps
If set it 0, it'll be set to a random number inside of gst plugin as it is.
[Version] 0.4.27
[Issue Type] Improvement
Change-Id: I2259ac28270709480c967fe1e40e3ef9551517dc
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 1 Dec 2023 02:57:35 +0000 (11:57 +0900)]
webrtc_test: Add support to show multiple video tracks from one remote peer
Test condition:
1. peer to peer test (not using room menu)
2. display type is EVAS
3. it should not exceed more than 3 remote video tracks.
[Version] 0.4.26
[Issue Type] Testsuite
Change-Id: Idd081077d97a6bab538d49a0f5a3c282079224b9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
e3dd9012c7ec6781b59b989fc3616819df17c3e0)
Sangchul Lee [Wed, 29 Nov 2023 03:46:19 +0000 (12:46 +0900)]
webrtc_internal: Fix doxygen
Missing @internal tag is added.
An error type that does not occur is removed from the description.
@Remarks for releasing handle are added.
Mis-typed function name is fixed.
[Version] 0.4.25
[Issue Type] Doxygen
Change-Id: I045d70214b458d67cab8aee8d926e38cec68ba84
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 23 Nov 2023 01:56:42 +0000 (10:56 +0900)]
Remove meaningless parameter checks
The first parameter of callbacks from gstreamer would be always not null.
Once webrtc handle has been created, there's no possibility that
'gst.webrtcbin' or 'gst.source_slots' is null.
A typo is also fixed.
[Version] 0.4.24
[Issue Type] Clean up
Change-Id: I03fc688b1b694c86c77d958fe4729734b799b897
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 20 Nov 2023 08:48:38 +0000 (17:48 +0900)]
webrtc_internal: Add webrtc_set_display_qos()
[Version] 0.4.23
[Issue Type] Internal API
Change-Id: I2a644795109b9534fc1ad65499c3ffb62c7ea3ec
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 20 Nov 2023 03:45:30 +0000 (12:45 +0900)]
webrtc_display: Fix errors when setting EVAS display mode/visible
These are fixed by using checking display type that shows
whether if the mm_display_interface_set_display_mainloop_sync()
is performed or not.
[Version] 0.4.22
[Issue Type] Bug fix
Change-Id: I070318bb73be96abd07da3d0ec419c0703c83109
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 10 Oct 2023 08:18:29 +0000 (17:18 +0900)]
Fix SVACE defect (DEREF_OF_NULL.RET.STAT)
[Version] 0.4.21
[Issue Type] SVACE (VD)
Change-Id: Ie0d31d03e2d63100b22f7a37bedaead826d7fede
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 21 Aug 2023 10:21:11 +0000 (19:21 +0900)]
test: Use g_file_set_contents() to dump file
[Version] 0.4.20
[Issue Type] Refactoring
Change-Id: I00411336b80159693394c23089f6bfeab74a8fba
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 18 Aug 2023 01:23:41 +0000 (10:23 +0900)]
webrtc_internal: Revise @since_tizen 7.5 to 8.0
[Version] 0.4.19
[Issue Type] Doxygen
Change-Id: Iba1131b33364afd3277c7297a38336d8777d09e5
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 8 Aug 2023 06:47:44 +0000 (15:47 +0900)]
Fix SVACE defect (DEREF_OF_NULL.EX)
[Version] 0.4.18
[Issue Type] SVACE (VD)
Change-Id: I3af6a032af8ce2a0d7ed91c6529d74511c8c562b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 7 Aug 2023 05:50:21 +0000 (14:50 +0900)]
Fix SVACE defects (SIGN_EXTENSION)
[Version] 0.4.17
[Issue Type] SVACE
Change-Id: Ie8e5b4dadf738d4a17323e29ac0712fb6fd6ce4f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Jaechul Lee [Mon, 24 Jul 2023 06:07:03 +0000 (15:07 +0900)]
webrtc_private: Change to use effect_method API
AEC APIs in sound-manager have been changed.
[Version] 0.4.16
[Issue Type] Feature
Change-Id: Idd9a9988b80aa47e72639e14724d40ce0a4406b7
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Sangchul Lee [Fri, 7 Jul 2023 10:19:10 +0000 (19:19 +0900)]
Apply display feature
Some functions are not supported on the binary for the headed device.
Without this feature, these will return NOT SUPPORTED error.
[Version] 0.4.15
[Issue Type] Feature
Change-Id: I8344c964244f79f78e8864c1f18ae815d903a9f6
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 5 Jul 2023 09:16:13 +0000 (18:16 +0900)]
Export webrtc_set[get]_audio_mute() API to public header
[Issue Type] API
Change-Id: I64ac88a28c153ddc15661ca4f71ea596a3b48f0c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
wchang kim [Fri, 30 Jun 2023 01:16:21 +0000 (10:16 +0900)]
Fixed the build error using gcc 13
Change-Id: I18c2d92099b8b5762cec3cf03af717e5c9d7ef31
Jaechul Lee [Fri, 16 Jun 2023 07:00:04 +0000 (16:00 +0900)]
webrtc_private: Fix build break
PA_PROP_MEDIA_ECHO_CANCEL_METHOD was removed in pulseaudio proplist.h.
So, new property named 'PA_PROP_MEDIA_PREPROCESSOR_METHOD' should be
used.
[Version] 0.4.14
[Issue Type] Build break
Change-Id: Ia6a5d0d221dd360aa73c5fc6ed4f4d36b8315c41
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
Sangchul Lee [Wed, 7 Jun 2023 06:15:17 +0000 (15:15 +0900)]
Change tizen version 7.5 to 8.0
It is related to ACR-1750.
[Version] 0.4.13
[Issue Type] Doxygen
Change-Id: I47c1cbd0e2ca9c0bc8db710db8f44e542fe57746
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 17 May 2023 00:20:36 +0000 (09:20 +0900)]
webrtc_private: Ensure to invoke error callback in main thread
[Version] 0.4.12
[Issue Type] Improvement
Change-Id: I3410d3baf9d113fd4936be6d5a93ce33839dc3e2
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 3 May 2023 10:21:20 +0000 (19:21 +0900)]
webrtc_source_camera: Support tizencamerasrc element
[Version] 0.4.11
[Issue Type] Improvement
Change-Id: Id01e931221c709a48af2e4ab02c1fbc826f24d6d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 17 Apr 2023 02:44:59 +0000 (11:44 +0900)]
Apply new TIZEN_FEATURE_SIGNALING definition
[Version] 0.4.10
[Issue Type] Feature
Change-Id: Ic5d5e7be966883af356734cd627be3fabccd23b3
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 14 Apr 2023 05:59:12 +0000 (14:59 +0900)]
Change the application of macro for coverage measurement exclusion
[Version] 0.4.9
[Issue Type] Line coverage
Change-Id: Iadbf2acef199da87181ee0a51a76cfd0194e2e82
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 11 Apr 2023 06:03:38 +0000 (15:03 +0900)]
Apply new TIZEN_FEATURE_SNAPSHOT definition
[Version] 0.4.8
[Issue Type] Feature
Change-Id: Ic5c67f3066c5157f76303bd17e8c3fe1fb46ba3f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 11 Apr 2023 05:24:04 +0000 (14:24 +0900)]
Apply new TIZEN_FEATURE_DNS definition
[Version] 0.4.7
[Issue Type] Feature
Change-Id: I63e85cddacd1cd56dc47cb6c73fa162a623dc07e
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 14 Mar 2023 07:36:22 +0000 (16:36 +0900)]
webrtc_internal: Add webrtc_set_display_surface_id()
[Version] 0.4.6
[Issue Type] API
Change-Id: I8678951f128dcb448645e1032838c4392f9e2a20
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 22 Mar 2023 07:07:15 +0000 (16:07 +0900)]
webrtc_test_espp: Remove unnecessary function call
Codes to call esplusplayer_activate() are removed.
Some variable names are changed.
[Version] 0.4.5
[Issue Type] Improvement
Change-Id: Id3d7f1c841b4e155a2a0cfa0e18033fc3c8d2bec
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 21 Mar 2023 08:59:08 +0000 (17:59 +0900)]
webrtc_sink: Set channels or rate to media format even if only one has a valid value
More logs are added.
[Version] 0.4.4
[Issue Type] Improvement
Change-Id: I34d985ee78051dc82ff517920739b037c97714e8
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Sat, 11 Mar 2023 07:04:34 +0000 (16:04 +0900)]
webrtc_sink: Save mute value and apply it when audiosink is created
[Version] 0.4.3
[Issue Type] Improvement
Change-Id: Icb5181afd2c759756187cd2a68ce4fa315c84c15
Sangchul Lee [Wed, 8 Mar 2023 02:08:49 +0000 (11:08 +0900)]
Add new error type - WEBRTC_ERROR_NETWORK_RESOURCE_FAILED
[Version] 0.4.2
[Issue type] API
Change-Id: I640059cf94bac87fba28ef4e5ff37cadc6f86680
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 3 Feb 2023 11:24:21 +0000 (20:24 +0900)]
Add new stats types
new enums are added as below.
for webrtc_stats_type_e
: WEBRTC_STATS_TYPE_CANDIDATE_PAIR
: WEBRTC_STATS_TYPE_LOCAL_CANDIDATE
: WEBRTC_STATS_TYPE_REMOTE_CANDIDATE
for webrtc_stats_prop_e
: WEBRTC_STATS_PROP_KIND
: WEBRTC_STATS_PROP_ADDRESS
: WEBRTC_STATS_PROP_PORT
: WEBRTC_STATS_PROP_CANDIDATE_TYPE
: WEBRTC_STATS_PROP_PRIORITY
: WEBRTC_STATS_PROP_PROTOCOL
: WEBRTC_STATS_PROP_RELAY_PROTOCOL
: WEBRTC_STATS_PROP_URL
: WEBRTC_STATS_PROP_LOCAL_CANDIDATE_ID
: WEBRTC_STATS_PROP_REMOTE_CANDIDATE_ID
Some enum values are changed.
Some definitions are deprecated.
[Version] 0.4.1
[Issue type] New feature
Change-Id: I021af299a1b3ddb048f29a3888b5dc86d8191ab8
Sangchul Lee [Thu, 2 Mar 2023 02:15:05 +0000 (11:15 +0900)]
Use g_autoptr for JsonParser variable
[Version] 0.3.289
[Issue type] Refactoring
Change-Id: Iaf7fac85e87150abdfae106827fb84b7c41d001e
Sangchul Lee [Thu, 16 Feb 2023 07:32:34 +0000 (16:32 +0900)]
webrtc_private: Print debug message in GstMessage object
[Version] 0.3.288
[Issue type] Logs
Change-Id: Ied0efd7e522cddbf3b1f291aec24b78deb91ace7
Sangchul Lee [Mon, 13 Feb 2023 23:30:46 +0000 (08:30 +0900)]
Use GST_TIME_FORMAT for buffer timestamps
[Version] 0.3.287
[Issue type] Logs
Change-Id: Ibc961bf988aa9225b5f4f4d1d7df2a381fbc459c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 10 Jan 2023 09:12:41 +0000 (18:12 +0900)]
webrtc_stats: Dump stats result into the file
The JSON data of stats result will be written into
/tmp/webrtc-stats-[pid]-[handle address].dump
if 'stats log period' field in the ini file is set to some values.
[Version] 0.3.286
[Issue type] New feature
Change-Id: If66b7936166fdb9412f748f38a5374fd472df677
Seungbae Shin [Thu, 2 Feb 2023 05:14:18 +0000 (14:14 +0900)]
webrtc_stats: propagate the user cb return using the return of gst_structure_foreach()
[Version] 0.3.285
[Issue type] Refactoring
Change-Id: If7e8dabfc8fb87f4a93259b81a37f47f3b01608b
Sangchul Lee [Tue, 7 Feb 2023 01:29:56 +0000 (10:29 +0900)]
webrtc_dns: Check error of getifaddrs()
[Version] 0.3.284
[Issue type] Coverity defect (CHECKED_RETURN)
Change-Id: I8cfa281059b5b8efc5b2f6660bd89bcb475bfef2
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 1 Feb 2023 08:51:01 +0000 (17:51 +0900)]
webrtc_stats: Add null check code before calling gst_structure_foreach()
It is to avoid printing warning message from a console.
[Version] 0.3.283
[Issue type] Improvement
Change-Id: I52f0c9ad3f7c218b5af9d70706625a1e7848fcbb
Sangchul Lee [Fri, 13 Jan 2023 03:39:00 +0000 (12:39 +0900)]
webrtc_stats: Fix memory leak
[Version] 0.3.282
[Issue type] Resource leak
Change-Id: Ia4d3a70b80a4eb69b0052dc36f9875b8598dd5d9
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 12 Jan 2023 06:09:53 +0000 (15:09 +0900)]
webrtc_dns: Use version 4 UUID as a unique hostname
It is mentioned in 3.1.1. of the link below.
: https://www.ietf.org/archive/id/draft-ietf-mmusic-mdns-ice-candidates-03.html
[Version] 0.3.281
[Issue type] Improvement
Change-Id: Ia4665c17fd812fb61d0e5f8c33c3ef7ecc97955a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 9 Jan 2023 05:01:35 +0000 (14:01 +0900)]
webrtc: Add missing codes for updating transceiver
The same codes from webrtc_create_offer[answer]() are added
to webrtc_create_offer[answer]_async().
[Version] 0.3.280
[Issue type] Bug fix
Change-Id: I582139cff77237ec9237a6473cdd7efd347a3b47
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 4 Jan 2023 05:09:55 +0000 (14:09 +0900)]
webrtc_dns: Consider more IP address ranges as private IP
Address ranges below are considered as private IP.
Class A: 10.0.0.0 - 10.255.255.255
Class B: 172.16.0.0 - 172.31.255.255
[Version] 0.3.279
[Issue type] Improvement
Change-Id: Ib65e55aed1a7524cd77d41c1376a3452cb5946b7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 27 Dec 2022 08:25:30 +0000 (17:25 +0900)]
webrtc_private: Replace private IP with hostname in local ICE candidate
[Version] 0.3.278
[Issue type] New feature
Change-Id: I351db37c3a1fafec9b63bb10840b145f8eb0fa53
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 27 Dec 2022 08:01:55 +0000 (17:01 +0900)]
webrtc_ini: Add new item to enable to conceal private IP address
Default value is false. If 'conceal private ip' in ini file is
set to yes, then hostname for the private IP address will be used
in each local ICE candidate.
e.g)
[general]
conceal private ip = yes
[Version] 0.3.277
[Issue type] New feature
Change-Id: Ida5eb1db00d40661cb32c6501515874a85246328
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 23 Dec 2022 06:31:10 +0000 (15:31 +0900)]
webrtc_dns: Add support for registering DNS service
This patch uses dns_sd.h of mdnsresponder to register DNS service
and to publish hostname for private IP address.
[Version] 0.3.276
[Issue type] New feature
Change-Id: I9a9d64c367b2a49f2fe6e2ca7d1cd3ceca91770d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 28 Dec 2022 05:26:20 +0000 (14:26 +0900)]
webrtc_sink_snapshot: Create queue before creating convert thread
Sometimes the new thread tries to access queue not created yet which causes
a crash. It is fixed to create queue first and then create thread as well as
check if the result of pop operation is NULL.
[Version] 0.3.275
[Issue Type] Crash
Change-Id: Icefd4d6d9b38141384fbc70b3a7097a6f674fd4d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 19 Dec 2022 03:03:27 +0000 (12:03 +0900)]
webrtc_sink_snapshot: Remove switch-case
Instead, bit-wise check is used whether to encode data or not.
Some functions to convert type are added.
[Version] 0.3.274
[Issue Type] Refactoring
Change-Id: Ib05495d97ef390429440a3c0e049e5018868758c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 12 Dec 2022 03:01:35 +0000 (12:01 +0900)]
webrtc_test: Add menu to take snapshot
[Version] 0.3.273
[Issue Type] Add
Change-Id: I2d869ff6e7db5dd3e367b4a24fd31321a2dc51d5
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
(cherry picked from commit
dd6a0fcb0483d6c380c16aab597d5b88d6d8a9f0)
Sangchul Lee [Thu, 8 Dec 2022 07:35:41 +0000 (16:35 +0900)]
webrtc_internal: Add webrtc_take_snapshot() API
[Version] 0.3.272
[Issue Type] Internal API
Change-Id: I9750f05f7a64d414b9280644ebb6c84afb071417
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 8 Dec 2022 01:51:10 +0000 (10:51 +0900)]
webrtc_sink_snapshot: Support PNG format
[Version] 0.3.271
[Issue Type] Add
Change-Id: I663ea2cf682492929745e3b9022ec86c9e5c4051
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 6 Dec 2022 10:34:14 +0000 (19:34 +0900)]
webrtc_sink_snapshot: Support JPEG format
Location of locking mutex is moved to guard variables properly.
[Version] 0.3.270
[Issue Type] Add
Change-Id: Iad94e4309c72e6c603d7249ad3460a18feeae9cc
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 6 Dec 2022 06:54:28 +0000 (15:54 +0900)]
webrtc_sink_snapshot: Adopt a thread for converting video format
[Version] 0.3.269
[Issue Type] Improvement
Change-Id: If60e49be6aa87f0011fd3ab4ae10bb10a03a150c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 2 Dec 2022 00:04:09 +0000 (09:04 +0900)]
webrtc_sink_snapshot: Add support for capture video frame
A video frame of receiving video stream can be captured by this new
functionality.
As of now, it only supports
1. to capture the decoded video frame and convert it only to RGB24 format.
2. to save dump file only with a macro definition.
These could be expanded to get improved and have more functionalities
next time.
1. support a user callback.
2. support various output formats.
3. adopt a dedicated thread for converting format.
[Version] 0.3.268
[Issue Type] New feature
Change-Id: I662f41ef639182b78f2ffc95d7e036625cbe5c53
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 4 Oct 2022 06:45:37 +0000 (15:45 +0900)]
webrtc_test: Add menu for new internal APIs tests
1. set/get audio track mute
2. get video track resolution
[Version] 0.3.267
[Issue Type] Add
Change-Id: I953ee0f0b3b1d982c393ada0bd4058228d981307
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 25 Nov 2022 03:02:55 +0000 (12:02 +0900)]
webrtc_internal: Add webrtc_get_video_resolution() API
Missing preconditions are added to doxygen of some functions.
[Version] 0.3.266
[Issue Type] Internal API
Change-Id: I3ccfbf39e122a753023dafe16e5a13f36513a039
Sangchul Lee [Wed, 23 Nov 2022 07:17:50 +0000 (16:17 +0900)]
webrtc_sink: Update received video frame resolution
[Version] 0.3.265
[Issue Type] New feature
Change-Id: I3ec24e1a964e884d51263cb9e3966db7374eee0a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 10 Nov 2022 03:19:50 +0000 (12:19 +0900)]
test: CMakeLists: Apply variable for ui dependencies
[Version] 0.3.264
[Issue Type] Refactoring
Change-Id: Ia6e36badf26b128be9c67580eb6eba99aba75f8c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 25 Oct 2022 06:12:00 +0000 (15:12 +0900)]
Check if handle is destroying before posting idle-callbacks
Sometimes, deadlock happens in C# TCT because of a sequence below.
- webrtc handle seems to be destroyed before negotiation
callbacks have not been processed in the main thread posted
by g_idle_add_full().
It is checked that state and error callbacks have no chance
to get this situation.
[Version] 0.3.263
[Issue Type] Improvement
Change-Id: Ia7359bb45aaa1095dd77ee673c5b3b72056da62b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 30 Sep 2022 07:51:39 +0000 (16:51 +0900)]
webrtc_internal: Add functions for audio track mute
It's cherry-picked from tizen_6.5 branch.
[Version] 0.3.262
[Issue Type] Internal API
Change-Id: Ia942f612e126c7a5a2bc6b44dcd52bd41be7816a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 8 Nov 2022 03:18:16 +0000 (12:18 +0900)]
webrtc_private: Generate dot file when an error callback is invoked
[Version] 0.3.261
[Issue Type] Debug
Change-Id: I279ac95a82ee5bdea1e2c83ae31f6e59e0c9a8ae
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 24 Oct 2022 02:47:18 +0000 (11:47 +0900)]
Fix SVACE defect (SEC_INVALID_ASSIGNMENT_WITH_UNSIGNED_VALUES)
[Version] 0.3.260
[Issue Type] Svace
Change-Id: Idfcfeeda1487ac0eb2cf3b71db0c7316052842d4
Sangchul Lee [Thu, 20 Oct 2022 04:08:08 +0000 (13:08 +0900)]
webrtc_sink: Change location of invoking _apply_display()
It is moved to outside of webrtc_set_display() which previously
locks a mutex.
[Version] 0.3.259
[Issue Type] Improvement
Change-Id: I252300784648941c136cd2b517d2fa81b51d9d8d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 7 Oct 2022 00:56:10 +0000 (09:56 +0900)]
webrtc_ini: Add new item for video h/w encoder caps extension
e.g.)
[source camera]
video hw encoder element = v4l2h264enc
; comma separated list of 'field-name=value' that will be set to the capsfilter
video hw encoder caps ext = profile=constrained-baseline,level=3
Some video hardware encoder could require specific fields for
its caps. For example, level, profile, and so on.
A capsfilter for encoder is added.
[Version] 0.3.258
[Issue Type] Improvement
Change-Id: I2433db5f11b33712e2b720956a57f7bf340fc0b1
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Wed, 12 Oct 2022 04:17:23 +0000 (13:17 +0900)]
webrtc_doc: Add '#' to stats enum
[Version] 0.3.257
[Issue Type] Documentation
Change-Id: I2f13e939588f937d0308617e8c2756d0a4b5268f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 7 Oct 2022 00:53:37 +0000 (09:53 +0900)]
webrtc_private: Move _gst_set_element_properties() to _source_private.c
[Version] 0.3.256
[Issue Type] Refactoring
Change-Id: I2ce2ade6789480d6b9485815d89d56734b6bd165
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 30 Sep 2022 03:29:45 +0000 (12:29 +0900)]
Update doxygen and log regarding ICE candidate message
[Version] 0.3.255
[Issue Type] Doxygen / Log
Change-Id: If8b59c0d09500f3b6e981c8a0c92c3540347f8db
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
hj kim [Tue, 27 Sep 2022 06:08:55 +0000 (15:08 +0900)]
remove raw_format from source structure
Change to get raw_format from ini only when it is needed.
[Version] 0.3.254
[Issue Type] API
Change-Id: I9aba23be4a85964a9a6ffc6dc840e3003823f7b4
hj kim [Mon, 26 Sep 2022 06:03:51 +0000 (15:03 +0900)]
webrtc.h: Update webrtc_screen_source_set_crop() API description
[Version] 0.3.253
[Issue Type] API
Change-Id: I5d1cc4c6727eabd7facacaf3c4c3838056d9be44
hj kim [Mon, 26 Sep 2022 05:40:23 +0000 (14:40 +0900)]
Make a function to set origin video source resolution
[Version] 0.3.252
[Issue Type] Refactoring
Change-Id: Ifc3a95a78c3265d34f6cb9b825ee6bc76a8ad0e5
hj kim [Fri, 23 Sep 2022 07:20:08 +0000 (16:20 +0900)]
webrtc_source_screen: move resolution setting code for screen source to webrtc_source_screen.c
setting the default video resolution to screen resolution is only required for screen source.
[Version] 0.3.251
[Issue Type] Refactoring
Change-Id: I25dbf22a6d8a8469705e6fee7c69bbd1369b2a32
hj kim [Fri, 23 Sep 2022 06:59:28 +0000 (15:59 +0900)]
webrtc_source_screen: move screen source related code to webrtc_source_screen.c
[Version] 0.3.250
[Issue Type] Refactoring
Change-Id: Ib1f9d05448de4e0f26a705195323125fd4bd9cd6
Sangchul Lee [Mon, 26 Sep 2022 03:24:35 +0000 (12:24 +0900)]
webrtc_display: Return NULL in case of mm_display_interface_init() failure
[Version] 0.3.249
[Issue Type] Bug fix
Change-Id: I389a9a8e99e5ebfd2544a641a1b30f61c8bd155f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
hj kim [Thu, 22 Sep 2022 23:52:35 +0000 (08:52 +0900)]
webrtc_source_private: Reduce code complexity
[Version] 0.3.248
[Issue Type] Refactoring
Change-Id: Iecdd0ed61d19c2899085614e96a9a71204ad54dd
hj kim [Thu, 1 Sep 2022 06:37:22 +0000 (15:37 +0900)]
Make internal APIs for crop screen source public
Below functions are moved and have platform privilege.
- webrtc_screen_source_set_crop()
- webrtc_screen_source_unset_crop()
[Version] 0.3.247
[Issue Type] API
Change-Id: Iad8d3b9842db4c033052e62596c5a79610de22b1
hj kim [Wed, 21 Sep 2022 02:28:28 +0000 (11:28 +0900)]
add videorate to support dynamic framerate change
It doesn't support increasing framerate.
[Version] 0.3.246
[Issue Type] Improvement
Change-Id: Iea5ce0881ae55e1d881d847b88ff41dcede75a6f
Sangchul Lee [Wed, 21 Sep 2022 08:38:00 +0000 (17:38 +0900)]
Apply restriction for use of WEBRTC_MEDIA_SOURCE_TYPE_SCREEN
Locations of macro to exclude lines from coverage measurement
are also modified.
[Version] 0.3.245
[Issue Type] API
Change-Id: Ibbe0bf8a32f2c61b3734690cbe9068809d88349d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
hj kim [Wed, 21 Sep 2022 05:25:00 +0000 (14:25 +0900)]
webrtc_source_screen: sensor API dependency change
[Version] 0.3.244
[Issue Type] package change
Change-Id: I8df9aad81f4d28b86a2503f3a7261f5b44389395
Sangchul Lee [Tue, 20 Sep 2022 04:23:14 +0000 (13:23 +0900)]
webrtc_source_camera: Add CAMERA_DEVICE_TYPE_DUMMY for videotestsrc element
A tizen emulator uses 'videotestsrc' element as a camera source.
Now, we use 'pattern' property for device id in this case.
This fixes UTC failures - set/get camera device id.
[Version] 0.3.243
[Issue Type] Bug fix / UTC failure
Change-Id: I36ca271ebb5543fdb88cc197b7cd3fc05936f59a
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Fri, 16 Sep 2022 13:14:24 +0000 (22:14 +0900)]
webrtc_transceiver: Add encoding-params(2) to caps in case of OPUS codec
It represents channels.
In case of gst to gst, it worked fine without it. But in case of gst
to web, it does not work(web API failure).
It is also mandatory according to RFC7587, so it is added.
These codes are related to OPUS media of 'recvonly' in offer description.
[Version] 0.3.242
[Issue Type] Improvement / Compatibility
Change-Id: I57596fbb5b9b7c99efe856e5127de36d89ef6d88
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Mon, 19 Sep 2022 02:43:01 +0000 (11:43 +0900)]
webrtc_transceiver: Fix to add missing payload type of an offer description
When transceiver direction was set to 'recvonly', a particular transceiver
was added with a preference caps without payload type. When trying to
create an offer description, the payload type must be added to the caps
regardless its source type.
[Version] 0.3.241
[Issue Type] Bug fix
Change-Id: I924b297a3a23522ca7466c45eb0d65de1972d82c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 15 Sep 2022 02:11:28 +0000 (11:11 +0900)]
Add more macro to exclude lines from coverage measurement
[Version] 0.3.240
[Issue Type] Line coverage
Change-Id: I0a9b3a680c19674e8cf33a7e03447cae4879186c
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
hj kim [Wed, 14 Sep 2022 05:55:02 +0000 (14:55 +0900)]
webrtc_private: Move some structures to the proper source file
[Version] 0.3.239
[Issue Type] Refactoring
Change-Id: Id3bfa94408aeaad06a19159dfdb33f2b06f04d53
Sangchul Lee [Wed, 14 Sep 2022 03:04:03 +0000 (12:04 +0900)]
webrtc_test_validate: Add 'channel-mapping-family' value to appsrc caps for OPUS codec
It fixes not-negotiated issue on appsrc.
[Version] 0.3.238
[Issue Type] Bug fix
Change-Id: I2e256e7d7abff69e1e1bec6c1c2da025b5923af0
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Tue, 13 Sep 2022 07:12:25 +0000 (16:12 +0900)]
webrtc_internal: Revise webrtc_media_source_set_payload_type() for media packet source
This function should affect media packet source. It is fixed.
[Version] 0.3.237
[Issue Type] Bug fix
Change-Id: I12b49da60526d2ba93cef07e1ceea9b4e887df33
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 8 Sep 2022 07:30:04 +0000 (16:30 +0900)]
webrtc_source_screen: Use mm_display_interface_get_screen_size() instead of elm_win_screen_size_get()
This will remove the dependency of elementary lib.
[Version] 0.3.236
[Issue Type] Dependency
Change-Id: I0ee14f4c100edf1c4b5aec02732768eb82acbf54
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
hj kim [Mon, 5 Sep 2022 03:53:29 +0000 (12:53 +0900)]
webrtc_source_file: move file source related code to webrtc_source_file.c
[Version] 0.3.235
[Issue Type] Refactoring
Change-Id: I2df68784dcb962533faa95c3661a99f12aec9f0a
hj kim [Mon, 5 Sep 2022 03:27:58 +0000 (12:27 +0900)]
webrtc_source_private: Add function to release request pad
_release_request_pad()
[Version] 0.3.234
[Issue Type] Refactoring
Change-Id: Id6837eb82fae01c28a02c14f71c1e3fa47427488
hj kim [Mon, 5 Sep 2022 02:41:48 +0000 (11:41 +0900)]
webrtc_source_loopback: Add some functions to update loopback
Below functions added.
-_set_need_decoding_for_loopback()
-_destroy_looopback_render_pipeline()
[Version] 0.3.233
[Issue Type] Refactoring
Change-Id: I94b7ac49fb9be0d830e701d6000bbbbe1eeafbb1
Sangchul Lee [Mon, 5 Sep 2022 07:47:47 +0000 (16:47 +0900)]
webrtc_source_screen: Check return values and release resource of sensor API
[Version] 0.3.232
[Issue Type] Coverity defect(CHECKED_RETURN) & bug fix
Change-Id: Ic5f90f54c1bd070101da6e1433d186d5444dd305
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
hj kim [Mon, 5 Sep 2022 01:10:19 +0000 (10:10 +0900)]
Add webrtc_source_loopback and move related codes to it
[Version] 0.3.231
[Issue Type] Refactoring
Change-Id: I7c402b2db477f87436dd6e6f0d463a06419e3cd0
Sangchul Lee [Mon, 5 Sep 2022 03:33:12 +0000 (12:33 +0900)]
CMakefile: Exclude capi-system-sensor dependency when using TIZEN_TV
sensor-internal.h could not be found with tv build.
(it is found by QB.)
[Version] 0.3.230
[Issue Type] Build dependency
Change-Id: I56c0eb28b251d3de9a701f31d326a42dd4d8d6ca
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
hj kim [Fri, 2 Sep 2022 06:38:46 +0000 (15:38 +0900)]
Move some APIs to proper source file and make them static
[Version] 0.3.229
[Issue Type] Refactoring
Change-Id: I377c6c12b46d0d4ec80aa77be773efb19309c155
Sangchul Lee [Thu, 1 Sep 2022 07:37:42 +0000 (16:37 +0900)]
Add webrtc_transceiver.c and related codes are moved into it
[Version] 0.3.228
[Issue Type] Refactoring
Change-Id: Ic010a677849bc9253e3fcb0459af2a8dcf1eb9d5
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
Sangchul Lee [Thu, 1 Sep 2022 05:42:09 +0000 (14:42 +0900)]
webrtc_test_espp: Revise logic to submit audio/video packets properly
Following steps below are required for espp.
1. activate both stream types
2. invoke prepare async
3. after receiving ready to prepare callback for each stream type
4. submit packets for each stream type
5. finally, start espp handle when prepare async done callback is invoked
[Version] 0.3.227
[Issue Type] Bug fix
Change-Id: I3a72b9ab9088e5a0241b4da49b6dfe3ecb1319c1
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>