platform/core/api/media-controller.git
3 years agoAdd new key for the bundle of playlist 63/257063/2
jiyong.min [Mon, 19 Apr 2021 06:13:33 +0000 (15:13 +0900)]
Add new key for the bundle of playlist

[Problem]
 Playlist is sorted by item index. Playlist should not be sorted.
[Cause]
 The bundle is parcelable data, the data is sorted by a key.
 And playlist use the item index as the key of bundle.
 Therefore playlist is sorted by the item index.
[Solution]
 Add new dummy key. So it is no longer sorted by item index.

Change-Id: I0cce605dcecdfff9f76a5a51b04e2fff8386ca22

3 years agoRelease version 0.2.24 53/255653/6 accepted/tizen/unified/20210324.124253 submit/tizen/20210324.015805
jiyong.min [Mon, 22 Mar 2021 06:40:53 +0000 (15:40 +0900)]
Release version 0.2.24

Change-Id: I6f8ce3bc3de37beea8d879ba990a40d43f2e5ce2

3 years agoAdd retry logic when the database locked 52/255652/7
jiyong.min [Mon, 22 Mar 2021 06:35:08 +0000 (15:35 +0900)]
Add retry logic when the database locked

Change-Id: I3f8f6cb05f6f0b53758836aa6ed522b1fafa54bc

3 years agoChange systemd-devel package name 52/252852/1 accepted/tizen/unified/20210209.124430 submit/tizen/20210208.015104
INSUN PYO [Wed, 3 Feb 2021 00:58:30 +0000 (09:58 +0900)]
Change systemd-devel package name

Change-Id: Ic198c4446203cca6d386f972139085f3ab877798

3 years agoUpdate test codes 39/249839/3 accepted/tizen/unified/20201224.151547 submit/tizen/20201218.042524
hj kim [Thu, 17 Dec 2020 05:08:20 +0000 (14:08 +0900)]
Update test codes

Destroy client when quit the program

Change-Id: I60c18d185ca7b5e5b9accca09ff82851f6983a12

3 years agoAdd new msg to check service launch status 91/249591/8
hj kim [Tue, 15 Dec 2020 07:42:16 +0000 (16:42 +0900)]
Add new msg to check service launch status

Change-Id: I9c7148c34e90e5537913b0507e849eaa30d3e2b4

3 years agoUpdate code to reduce complexity 81/249581/3
hj kim [Tue, 15 Dec 2020 06:45:35 +0000 (15:45 +0900)]
Update code to reduce complexity

Change-Id: I7f2327939287fced4d0b2da1dba6d17d8fd7ebee

3 years agoFix wrong messages 68/249568/3
hj kim [Tue, 15 Dec 2020 05:18:31 +0000 (14:18 +0900)]
Fix wrong messages

Change-Id: I9cdcf62e7eee1844edf0da0fed5ca34db7a2769f

4 years agoReduce DB locking time 99/245199/15 accepted/tizen_6.0_unified_hotfix tizen_6.0_hotfix accepted/tizen/6.0/unified/20201030.122552 accepted/tizen/6.0/unified/hotfix/20201103.004858 accepted/tizen/6.0/unified/hotfix/20201103.052243 accepted/tizen/unified/20201009.090838 submit/tizen/20201008.053624 submit/tizen_6.0/20201029.205102 submit/tizen_6.0_hotfix/20201102.192502 submit/tizen_6.0_hotfix/20201103.114802 tizen_6.0.m2_release
hj kim [Mon, 5 Oct 2020 09:08:56 +0000 (18:08 +0900)]
Reduce DB locking time

foreach functions invoke callback while reading DB. It means that the DB is locked.
But sometimes applications do unexpected things in callback and it could cause a long DB lock and
prevent other apps from accessing the DB.
Therefore, saving items to the internal list and unlock the DB quickly.

Change-Id: Ideb57e53a77fa3ace74cec512ca4f3adcf149549

4 years agoFix document issue 28/245328/1
hj kim [Wed, 7 Oct 2020 06:57:43 +0000 (15:57 +0900)]
Fix document issue

Change-Id: Id86ea1d723f5cabb9cbe9483adda148af2e37b5d

4 years agoImprove __mc_service_process() 03/245303/5
hj kim [Wed, 7 Oct 2020 02:12:45 +0000 (11:12 +0900)]
Improve __mc_service_process()

Change-Id: I911f68d4782eab29ec4088d709dcdfc34422f69e

4 years agoReinforce message for debugging 10/245310/2
hj kim [Wed, 7 Oct 2020 03:56:00 +0000 (12:56 +0900)]
Reinforce message for debugging

Change-Id: I3f72dba1c9392a0e5f1545cb2bd2f371dc2e1c0c

4 years agoBug fix of sending wrong message 69/245269/5
hj kim [Tue, 6 Oct 2020 08:14:57 +0000 (17:14 +0900)]
Bug fix of sending wrong message

and change variable from int to unsigned int.
because g_queue_get_length() returns unsigned int.

Change-Id: Iecf364312b725e89ab405ca7e0ad504f09dafab4

4 years agoremove from the connection list when fail to DB updating 57/245157/6
hj kim [Mon, 5 Oct 2020 02:53:29 +0000 (11:53 +0900)]
remove from the connection list when fail to DB updating

Change-Id: I0ebc9bc99b281e084186f8bea0218f19ee73eb2b

4 years agoUse proper variable name 62/245262/4
hj kim [Tue, 6 Oct 2020 06:43:46 +0000 (15:43 +0900)]
Use proper variable name

Change-Id: I8554da73108c1b37afd2ce4b72c3124479e4ecc0

4 years agoImprove __mc_service_remove_connection() 55/245255/4
hj kim [Tue, 6 Oct 2020 05:54:50 +0000 (14:54 +0900)]
Improve __mc_service_remove_connection()

Change-Id: I65f5117b11532ed10acc51ac9a911c559145315a

4 years agoUpdate log level to get log for product 22/244922/7
hj kim [Mon, 28 Sep 2020 01:24:31 +0000 (10:24 +0900)]
Update log level to get log for product

Change-Id: I9cd72229a715f872af7090b71d6a08a04aeb9a05

4 years agofix memory leak for playlist_name 33/244833/1 accepted/tizen/unified/20200925.140231 submit/tizen/20200924.055537
jiyong.min [Thu, 24 Sep 2020 22:26:23 +0000 (07:26 +0900)]
fix memory leak for playlist_name

Change-Id: If662b1a103947c0138b6b515f4d5bf381b239b6a

4 years agoFix resource leak 32/244132/3 accepted/tizen/unified/20200917.055750 submit/tizen/20200916.012329 submit/tizen/20200917.004955
hj kim [Tue, 15 Sep 2020 07:48:44 +0000 (16:48 +0900)]
Fix resource leak

Change-Id: I0bfc4257fa11566103d0b4d8068ee986779f2890

4 years agoFix doxygen error 66/242066/2 accepted/tizen/unified/20200826.133143 submit/tizen/20200820.234531
hj kim [Mon, 24 Aug 2020 02:37:35 +0000 (11:37 +0900)]
Fix doxygen error

Change-Id: Id7c8cec3f416a9a73193b2f62ac10ebca9620cdf

4 years agoModify to prevent reuse of values from released handles 22/241322/3 accepted/tizen/unified/20200820.133526 submit/tizen/20200820.043357
jiyong.min [Wed, 19 Aug 2020 06:44:20 +0000 (15:44 +0900)]
Modify to prevent reuse of values from released handles

Change-Id: I38d37136f45e50d7c5557dea55d097a1d67ad91e

4 years agoMerge "Fix typo" into tizen accepted/tizen/unified/20200729.165651 submit/tizen/20200728.044745
Jiyong Min [Tue, 28 Jul 2020 04:47:49 +0000 (04:47 +0000)]
Merge "Fix typo" into tizen

4 years agoFix typo 77/239577/2
jiyong.min [Tue, 28 Jul 2020 01:39:05 +0000 (10:39 +0900)]
Fix typo

Change-Id: I00a62ecbe966cfcabafcb4f8b36cb15230318439

4 years agoAdd static keyword and apply tizen coding rule 42/239242/3
hj kim [Thu, 23 Jul 2020 05:01:47 +0000 (14:01 +0900)]
Add static keyword and apply tizen coding rule

Change-Id: Idd2c7aea4fe8d0ebe5b03d153a214efef4135c74

4 years agoRelease version 0.2.18 03/239103/3 accepted/tizen/unified/20200723.161255 submit/tizen/20200722.020114
jiyong.min [Wed, 22 Jul 2020 00:36:53 +0000 (09:36 +0900)]
Release version 0.2.18

Change-Id: I8d672125d14401c28fbaf70a5f08ac292d03c85e

4 years agoFix double free if goto ERROR 02/239102/3
jiyong.min [Wed, 22 Jul 2020 00:22:48 +0000 (09:22 +0900)]
Fix double free if goto ERROR

Change-Id: I6dec59425e7b3851c989112970fb83a30b90b74a

4 years agoFix double free in loop 01/239101/3
jiyong.min [Wed, 22 Jul 2020 00:16:49 +0000 (09:16 +0900)]
Fix double free in loop

Change-Id: I30a6a9f06458c1c08c11d60ec2897dbfe0f6f798

4 years agoFix 'sql_str' memory leak if 'handle' is null or 'sql_str' is empty string 96/239096/3
jiyong.min [Tue, 21 Jul 2020 23:23:40 +0000 (08:23 +0900)]
Fix 'sql_str' memory leak if 'handle' is null or 'sql_str' is empty string

Change-Id: I00febeb6285b7b37c6ae3dbb991f75dcb05d7dd3

4 years agoFix memory leak if 'latest_server_name' is empty string. 95/239095/3
jiyong.min [Tue, 21 Jul 2020 23:05:17 +0000 (08:05 +0900)]
Fix memory leak if 'latest_server_name' is empty string.

Change-Id: I9f3af6da75af0d5c77efe2c3c7d7cd0e41aada74

4 years agoFix incorrect return value 94/239094/1
jiyong.min [Tue, 21 Jul 2020 23:02:20 +0000 (08:02 +0900)]
Fix incorrect return value

Change-Id: I42af141f7f28fe201a544bb5545168310f46b8c3

4 years agoFix bug that API return invalid parameter for added enum 61/238761/1 accepted/tizen/unified/20200722.144620 submit/tizen/20200721.000647
jiyong.min [Fri, 17 Jul 2020 06:01:55 +0000 (15:01 +0900)]
Fix bug that API return invalid parameter for added enum

Change-Id: I9268809c25ad1de446988705f1b0c15713580aab

4 years agoFix wrong debug message 43/237743/1 accepted/tizen/unified/20200709.164618 submit/tizen/20200709.014949
hj kim [Fri, 3 Jul 2020 07:27:40 +0000 (16:27 +0900)]
Fix wrong debug message

Change-Id: I8191d32383bd99c3df17483b7998ff33680a39e1

4 years agoFix integer overflow for 'mc_result_code_e' 09/237709/2 submit/tizen/20200702.014328 submit/tizen/20200703.072353
jiyong.min [Fri, 3 Jul 2020 00:45:25 +0000 (09:45 +0900)]
Fix integer overflow for 'mc_result_code_e'

  - 'mc_result_code_e' enum is used as INT parameter in previous functions.
    Because 0xFFFFFFFF make integer overflow, result_code can be tainted value.
    So it is changed to INT_MAX value.

Change-Id: Ifd8b27ceed31dd55e3e106f1d7a78587354149e5

4 years agoAdded checking valid display mode 44/236844/5 accepted/tizen/unified/20200624.130217 submit/tizen/20200623.070108
jiyong.min [Fri, 19 Jun 2020 02:42:18 +0000 (11:42 +0900)]
Added checking valid display mode

Change-Id: I82e2f5688ae7ff54aade4047a19cb49ce93e569a

4 years agoFix typo 62/236862/2
hj kim [Tue, 23 Jun 2020 02:26:39 +0000 (11:26 +0900)]
Fix typo

Change-Id: I6e938c1866a4a09a7d3654c236e80e6ddb7fc5fe

4 years agoadd user_data_free_func for 'g_dbus_connection_signal_subscribe' 56/236556/2
jiyong.min [Thu, 18 Jun 2020 05:36:44 +0000 (14:36 +0900)]
add user_data_free_func for 'g_dbus_connection_signal_subscribe'

  - user_data 'listener' is potentially used in a different thread after user_data has been released
    in another thread.
    so, user_data should be passed to user_data_free_func of 'g_dbus_connection_signal_subscribe'.

Change-Id: I0f7dfc9f338857b6dc0691fc0cd08d0ffa0917fe

4 years agoRelease version 0.2.16 52/236552/1 accepted/tizen/unified/20200619.004556 submit/tizen/20200618.061012
jiyong.min [Thu, 18 Jun 2020 05:35:36 +0000 (14:35 +0900)]
Release version 0.2.16

Change-Id: I26e44e22c7974c217145408ab131af9fd4864f9e

4 years ago[ACR-1561] Add new result code and playback states 52/234352/22
jiyong.min [Mon, 25 May 2020 05:40:07 +0000 (14:40 +0900)]
[ACR-1561] Add new result code and playback states

Change-Id: I793466c7ea94a6d719fdf8a4ff38329c6d1ad9ef

4 years agoRelease version 0.2.15 83/235383/2 accepted/tizen/unified/20200608.144732 submit/tizen/20200608.024241
jiyong.min [Thu, 4 Jun 2020 06:56:26 +0000 (15:56 +0900)]
Release version 0.2.15

Change-Id: I85fdf4b4c2188b290fce9165ed2ca0ebc62cb423

4 years agoChanges dbus user_data from the listener list to a listener 82/235382/2
jiyong.min [Thu, 4 Jun 2020 06:49:12 +0000 (15:49 +0900)]
Changes dbus user_data from the listener list to a listener

  - We can specify listener for the dbus signal.
    So it is not neccesary to send whole listener list.

Change-Id: Ia27233c64a897f88933ed2cbb4d97bef6fc81c1e

4 years agoCode cleanup for replacing client handle with receiver 81/235381/2
jiyong.min [Thu, 4 Jun 2020 06:17:28 +0000 (15:17 +0900)]
Code cleanup for replacing client handle with receiver

Change-Id: I52c5cc26eda57cad43f0ef37106c5eece1e79cfe

4 years agoCode cleanup for function to check parameter validity 80/235380/2
jiyong.min [Thu, 4 Jun 2020 04:45:13 +0000 (13:45 +0900)]
Code cleanup for function to check parameter validity

Change-Id: Ib6e5a83009c6763ec44abc048031cbd9144e51a1

4 years agoMerge "Revert "Revert "Fix to return ERROR_NONE and NULL for value when metadata...
Jiyong Min [Mon, 18 May 2020 05:12:47 +0000 (05:12 +0000)]
Merge "Revert "Revert "Fix to return ERROR_NONE and NULL for value when metadata doesn't exist""" into tizen

4 years agoMerge "Revert "Revert "Remove out of memory related code by using glib""" into tizen
Jiyong Min [Mon, 18 May 2020 05:12:42 +0000 (05:12 +0000)]
Merge "Revert "Revert "Remove out of memory related code by using glib""" into tizen

4 years agoRevert "Revert "Fix to return ERROR_NONE and NULL for value when metadata doesn't... 21/233621/1
Jiyong Min [Sun, 17 May 2020 22:24:06 +0000 (22:24 +0000)]
Revert "Revert "Fix to return ERROR_NONE and NULL for value when metadata doesn't exist""

This reverts commit 27d487e9fa8ac3033bcdae34dacdf615a0b8ee57.

Change-Id: I43f6a1e248468c8c30bc8ab4814ccd910b969775

4 years agoRevert "Revert "Remove out of memory related code by using glib"" 20/233620/1
Jiyong Min [Sun, 17 May 2020 22:23:59 +0000 (22:23 +0000)]
Revert "Revert "Remove out of memory related code by using glib""

This reverts commit a54b7e64cc068eafb74493d69119f0ff4dd297c9.

Change-Id: I3b0a9a58471d5c5ab2f46310a950c6d1d31b6563

4 years agoRevert "Fix to return ERROR_NONE and NULL for value when metadata doesn't exist" 07/233407/1 submit/tizen/20200514.115625
Jiyong Min [Thu, 14 May 2020 10:09:31 +0000 (10:09 +0000)]
Revert "Fix to return ERROR_NONE and NULL for value when metadata doesn't exist"

This reverts commit 547866cf02c13ce2e436513dd6fdb62e31fb0e0a.

Change-Id: I2dc463bcd1442740e4735b9f208a5ac66a0ba0bb

4 years agoRevert "Remove out of memory related code by using glib" 03/233403/3
Jiyong Min [Thu, 14 May 2020 09:22:35 +0000 (09:22 +0000)]
Revert "Remove out of memory related code by using glib"

This reverts commit 39b40dbe44d4fd7c1605a78eed918a06abd6eba5.

Change-Id: Ie1fa86f1387cf0f7e5decf340d02dab2cab6dc16

4 years agoRemove unnecessary duplicated code 14/233314/5 accepted/tizen/unified/20200514.050650 submit/tizen/20200513.233945
hj kim [Wed, 13 May 2020 22:58:39 +0000 (07:58 +0900)]
Remove unnecessary duplicated code

when application is deleted from app_list table, it will trigger to server_info and latest_meta table.
if app is not latest, info for that app will be deleted from server_info and latest_meta table.
in mc_db_remove_application(), app_list table is updated by calling __mc_db_delete_from_list() and do __mc_db_deactivate_server().
but __mc_db_deactivate_server() try to remove application info from the server_info table again.

Change-Id: Id4e82f0db44de7b785f25a5d7c30cfce75c791a2

4 years agoFix to return ERROR_NONE and NULL for value when metadata doesn't exist 67/233267/3
hj kim [Wed, 13 May 2020 09:18:26 +0000 (18:18 +0900)]
Fix to return ERROR_NONE and NULL for value when metadata doesn't exist

description for mc_client_get_server_metadata()
"If there is no metadata, return value of the @a metadata is NULL."

Change-Id: I81363d998becd47e7a9c3affc06108f81445405b

4 years agoFix typo 54/232854/1 accepted/tizen/unified/20200511.214629 submit/tizen/20200508.074554
jiyong.min [Fri, 8 May 2020 04:09:41 +0000 (13:09 +0900)]
Fix typo

Change-Id: I0ca79d1de21c808610432d9758f7764b1afa09b7

4 years agoRemove out of memory related code by using glib 90/230790/6
jiyong.min [Tue, 14 Apr 2020 07:19:16 +0000 (16:19 +0900)]
Remove out of memory related code by using glib

Change-Id: I42dbbb3e49d0e80b65cb1cfae98a7b76b7812cc7

4 years agoRemove null check for nullable function 89/230789/3
jiyong.min [Mon, 6 Apr 2020 04:03:04 +0000 (13:03 +0900)]
Remove null check for nullable function

Change-Id: If724198ed0343a528ce749c88042a8e147ec3918

4 years agoRemove unused code 73/229573/2 accepted/tizen/unified/20200403.153137 submit/tizen/20200402.224031
jiyong.min [Thu, 26 Mar 2020 04:16:02 +0000 (13:16 +0900)]
Remove unused code

Change-Id: Iae56504825e2142a6ed2fc4e563150d78d20fb62

4 years agoRename and relocate the functions for dbus & socket IPC 69/227269/3 accepted/tizen/unified/20200315.214713 submit/tizen/20200313.030919
jiyong.min [Wed, 11 Mar 2020 04:50:47 +0000 (13:50 +0900)]
Rename and relocate the functions for dbus & socket IPC

  - dbus IPC functions
    all functions except socket IPC functions

  - socket IPC functions
    __make_service_connection
    _mc_ipc_send_message_to_server
    _mc_ipc_service_connection

Change-Id: I7cf1ccb706fa1151a0da963ca338304ff3935451

4 years agoRemove redundant static function 64/227264/2
jiyong.min [Wed, 11 Mar 2020 04:32:25 +0000 (13:32 +0900)]
Remove redundant static function

Change-Id: I952404ccd78ba7eca9c1aae678f9b25c795b6bd2

4 years agoRemove unnecessary allocation 63/227263/1
jiyong.min [Wed, 11 Mar 2020 04:29:45 +0000 (13:29 +0900)]
Remove unnecessary allocation

  - The 'playback' is allocated by _mc_db_get_playback_info() function,
    so it is redundant allocation before calling the function.

Change-Id: I0a6d90db3b85e0b2d841c7cc368bb6cbc74d3b8c

4 years agoRemove unnecessary variables at dbus listener 46/227146/2 accepted/tizen/unified/20200312.234432 submit/tizen/20200310.225736
jiyong.min [Tue, 10 Mar 2020 04:30:54 +0000 (13:30 +0900)]
Remove unnecessary variables at dbus listener

Change-Id: I0116e1d67200f0e6ece96ca5744534120cfbea47

4 years agoUnify duplicated code regarding error handling 04/226604/3
jiyong.min [Wed, 4 Mar 2020 06:07:53 +0000 (15:07 +0900)]
Unify duplicated code regarding error handling

Change-Id: I85036d0b31671f60345a361df9b3af8efa153711

4 years agoFix resource leak for 'query_list' and retrieve 'sql_str_free' function 50/226550/9
jiyong.min [Tue, 3 Mar 2020 05:42:19 +0000 (14:42 +0900)]
Fix resource leak for 'query_list' and retrieve 'sql_str_free' function

Change-Id: I247fdeaa76fcbc1aa83c2b85be9da3402e31570c

4 years agoSeperate parsing and updating database to reduce CC(cyclomatic complexity) 49/226549/5
jiyong.min [Tue, 3 Mar 2020 04:00:31 +0000 (13:00 +0900)]
Seperate parsing and updating database to reduce CC(cyclomatic complexity)

Change-Id: I5087a4bd1970e9f013b2609dd27c1fd544f4ac93

4 years agoSeperate 'params' variable from parsing and updating database 48/226548/4
jiyong.min [Tue, 3 Mar 2020 03:25:31 +0000 (12:25 +0900)]
Seperate 'params' variable from parsing and updating database

Change-Id: I99023a723c8c56aaa9f9d9295d5fce2fca7d065b

4 years agoRemove duplicated conditions 47/226547/4
jiyong.min [Tue, 3 Mar 2020 02:47:01 +0000 (11:47 +0900)]
Remove duplicated conditions

Change-Id: Ia9b557deef1bbc418d16a97e69e63977dbbf243b

4 years agoReplace 'g_main_is_running' to 'g_main_loop_is_running' for glib update 12/224512/1 accepted/tizen/unified/20200224.081349 submit/tizen/20200203.160801 submit/tizen/20200217.011016
jiyong.min [Tue, 11 Feb 2020 06:54:17 +0000 (15:54 +0900)]
Replace 'g_main_is_running' to 'g_main_loop_is_running' for glib update

Change-Id: Icfd3a29e7110cc46bfb8dfbdf496fe4e09482cc3

4 years agoFix coverity issue 93/222793/2 submit/tizen/20200122.012604
jiyong.min [Mon, 20 Jan 2020 05:34:34 +0000 (14:34 +0900)]
Fix coverity issue

  - Use after free (USE_AFTER_FREE)
  Returns after free '_dst'

  - Use macro(g_list_next) and add to check return value in loop

Change-Id: Ie08c5fd02a4ad3c80d7d2c054c2ac34cccb3777a

4 years agoChange select query of __mc_db_get_record due to wrong result 21/222521/1 accepted/tizen/unified/20200117.120814 submit/tizen/20200116.004203
jiyong.min [Thu, 16 Jan 2020 00:38:19 +0000 (09:38 +0900)]
Change select query of __mc_db_get_record due to wrong result

Change-Id: I82faa60ab52ec8757a92bd7989a1bbc7a80f9578

4 years agoFix build error 70/222470/1 submit/tizen/20200115.071738
hj kim [Wed, 15 Jan 2020 07:27:07 +0000 (16:27 +0900)]
Fix build error

Change-Id: I5935f6d070d757baae0ca4b912125c35ebe9c18b

4 years agoVersion up 60/222460/1
hj kim [Wed, 15 Jan 2020 07:02:54 +0000 (16:02 +0900)]
Version up

Change-Id: I6e9740c833bb3ed436e0a035da3f01ded5e2649b

4 years agoApply Tizen naming convetion for protected(global) functions in internal header 46/222346/2
hj kim [Tue, 14 Jan 2020 01:38:41 +0000 (10:38 +0900)]
Apply Tizen naming convetion for protected(global) functions in internal header

Change-Id: I37dcb730361428ff787b3b36bd2fbdc97b35a2b0

4 years agoMerge "unify duplicated code regarding g_dbus_connection_emit_signal" into tizen
hj kim [Wed, 15 Jan 2020 06:26:52 +0000 (06:26 +0000)]
Merge "unify duplicated code regarding g_dbus_connection_emit_signal" into tizen

4 years agounify duplicated code regarding g_dbus_connection_emit_signal 40/222340/5
hj kim [Tue, 14 Jan 2020 00:54:48 +0000 (09:54 +0900)]
unify duplicated code regarding g_dbus_connection_emit_signal

Change-Id: I36635dc166f5de31b5b282d45bad31e1f1ce3b1e

4 years agoupdating duplicated code regarding getting value from db 38/222338/12
hj kim [Tue, 14 Jan 2020 00:22:22 +0000 (09:22 +0900)]
updating duplicated code regarding getting value from db

Change-Id: Iafd589a36cbfed804c4bb2eb114223097cb76fd5

4 years agoRemove duplicated codes 37/222337/6
hj kim [Mon, 13 Jan 2020 23:54:13 +0000 (08:54 +0900)]
Remove duplicated codes

Change-Id: I1b1feb67b594544f09a725f4d3248d2c651b4b8b

4 years agounify duplicated code regarding command_available 42/222342/3
hj kim [Tue, 14 Jan 2020 01:09:59 +0000 (10:09 +0900)]
unify duplicated code regarding command_available

Change-Id: I60137f3cd1efc81f8614a8c2d5913f97fc285cf9

4 years agoRemove useless parameter checking code 39/222339/6
hj kim [Tue, 14 Jan 2020 00:43:01 +0000 (09:43 +0900)]
Remove useless parameter checking code

Change-Id: I3901fb99a19be0489743d52eeedd33cbc67b4362

4 years agoApply Tizen naming convetion for protected(global) functions in internal header 93/222293/3
hj kim [Mon, 13 Jan 2020 08:43:24 +0000 (17:43 +0900)]
Apply Tizen naming convetion for protected(global) functions in internal header

Change-Id: I1b2d3c26a58f2a82c924f5569938b133cf3eaf52

4 years agoRemove duplicated code and redundant parameter 89/222289/6
hj kim [Mon, 13 Jan 2020 08:15:24 +0000 (17:15 +0900)]
Remove duplicated code and redundant parameter

Change-Id: I8abe4d8d6eb0f59b6887393126d640bb034bdf24

4 years agoFix wrong return value 21/222121/3 accepted/tizen/unified/20200113.130611 submit/tizen/20200110.063905
jiyong.min [Fri, 10 Jan 2020 02:10:14 +0000 (11:10 +0900)]
Fix wrong return value

Change-Id: I6a4935cb30decc1638162cb2ce86cf0926332455

4 years agoApply Tizen naming convention for internal functions. 90/221990/3 submit/tizen/20200109.233217
hj kim [Thu, 9 Jan 2020 01:41:49 +0000 (10:41 +0900)]
Apply Tizen naming convention for internal functions.

Change-Id: I6dc03a36252d181e96f3774368732f79dda9aa27

4 years agoFix to use valid GList in app_dead handler 62/221862/4 submit/tizen/20200109.082013
jiyong.min [Mon, 6 Jan 2020 01:52:45 +0000 (10:52 +0900)]
Fix to use valid GList in app_dead handler

Change-Id: I752ce18675b1f671e21c323b57a5600e6ea40505

4 years agoFix crash while playlist is updated 72/221272/1 accepted/tizen/unified/20200105.221159 submit/tizen/20191230.234237 submit/tizen/20200102.043859
jiyong.min [Mon, 30 Dec 2019 23:38:28 +0000 (08:38 +0900)]
Fix crash while playlist is updated

Change-Id: I16a71c09a3e867a95cdf5b3498ed9487ee4c4c59

4 years agoCode refactoring for using GList 88/218788/10 accepted/tizen/unified/20191227.142816 submit/tizen/20191226.093041
jiyong.min [Thu, 28 Nov 2019 06:10:50 +0000 (15:10 +0900)]
Code refactoring for using GList

 - The loop to find listener over the GList are replaced to 'g_list_find_custom()'.

 - The 'g_list_length()' is not fast because GList does not keep track of the number of items.
   To reduce the 'g_list_length()' call, using index for a loop over the list are replaced
   to using iterator.

   To visit all elements in the list, use a loop over the list:
   GList *l;
   for (l = list; l != NULL; l = l->next)
   {
      // do something with l->data
   }

   reference: https://developer.gnome.org/glib/stable/glib-Doubly-Linked-Lists.html

Change-Id: Ic916d5ef9157b3c7574631b975351507f860fcb5

4 years agoAdd coverage exception macros 56/220956/3
jiyong.min [Mon, 16 Dec 2019 05:15:35 +0000 (14:15 +0900)]
Add coverage exception macros

Change-Id: Idc1fd2c8b4352451b78400b93ee35c1829bcaf23

4 years agoFix build error due to toolchain upgrade (gcc6->gcc9) 57/220957/6
jiyong.min [Thu, 26 Dec 2019 05:23:16 +0000 (14:23 +0900)]
Fix build error due to toolchain upgrade (gcc6->gcc9)

  error: cast between incompatible function types
  error: '%s' directive argument is null [-Werror=format-overflow=]

Change-Id: I3f8186e0cd44c8e166728e119793ac1eacc95b81

5 years agoRelocate ability initialization from library to daemon 80/215380/6 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix accepted/tizen/5.5/unified/20191031.031433 accepted/tizen/5.5/unified/mobile/hotfix/20201027.065838 accepted/tizen/unified/20191018.060328 submit/tizen/20191016.081926 submit/tizen_5.5/20191031.000002 submit/tizen_5.5_mobile_hotfix/20201026.185102 tizen_5.5.m2_release
jiyong.min [Mon, 7 Oct 2019 08:04:09 +0000 (17:04 +0900)]
Relocate ability initialization from library to daemon

 - To reduce socket communication

Change-Id: Ice9a2d6212eeb63dfd3f6e7b7b5cb9a34151ffa9

5 years agoMerge "Remove unused retval" into tizen
Jiyong Min [Mon, 7 Oct 2019 03:23:35 +0000 (03:23 +0000)]
Merge "Remove unused retval" into tizen

5 years agoChange code not to send msg when media controller server set default values while... 83/215183/2 accepted/tizen/unified/20191007.234835 submit/tizen/20191007.022545
hj kim [Wed, 2 Oct 2019 08:04:25 +0000 (17:04 +0900)]
Change code not to send msg when media controller server set default values while launching

Change-Id: Ifce00a85e7abd2651e4f668b0e4a7351dc4db5ed

5 years agoRemove unused retval 04/215304/1
jiyong.min [Mon, 7 Oct 2019 01:55:10 +0000 (10:55 +0900)]
Remove unused retval

Change-Id: I5880aeaaf0fb8cda36492272eb2aa5acbfdd00b4

5 years agoBug fix of test code 72/215172/1
hj kim [Wed, 2 Oct 2019 07:08:39 +0000 (16:08 +0900)]
Bug fix of test code

Change-Id: I8e1c3a0335140923c7259047477e351e448d1d11

5 years agoAdd recovery logics for removed tables 36/214736/3 accepted/tizen/unified/20190927.064533 submit/tizen/20190927.014403
jiyong.min [Thu, 26 Sep 2019 02:14:55 +0000 (11:14 +0900)]
Add recovery logics for removed tables

Change-Id: If904c7dc7869962ec7ba8c1ea4433e07d7090c47

5 years ago[ACR-1444]Add functions for subtitle, display mode, display rotation, 360 mode 67/210767/36 accepted/tizen/unified/20190918.102311 submit/tizen/20190918.021208
hj kim [Wed, 24 Jul 2019 08:41:57 +0000 (17:41 +0900)]
[ACR-1444]Add functions for subtitle, display mode, display rotation, 360 mode

Change-Id: I9fd94669658a0de717445f7571003f46f79f96c6

5 years agoImprove '__mc_client_unregister_filter_listener' function to fix issue 97/213397/5 accepted/tizen/unified/20190909.010902 submit/tizen/20190905.232826
jiyong.min [Thu, 5 Sep 2019 02:22:42 +0000 (11:22 +0900)]
Improve '__mc_client_unregister_filter_listener' function to fix issue

 - Issue
  After filter_listener were unregistered, listener callback was still invoked.
 - Cause
  When all filters were unregistered, filter_interface should be unregistered, but normal_interface was used.
 - Solution
  When filter is unregistered, it is changed to use 'mc_ipc_unregister_filter_listener'.
  After that, unregistering filter will use filter_interface(interface + server_name).

Change-Id: I356c1c0d96fd3297e6f3f61e3b906980d3e2f2ef

5 years agoUpdate code to remove SAM violation (GV, PP) 45/212845/2 accepted/tizen/unified/20190901.225905 submit/tizen/20190828.013758 submit/tizen/20190830.003130
hj kim [Tue, 27 Aug 2019 08:40:15 +0000 (17:40 +0900)]
Update code to remove SAM violation (GV, PP)

Change-Id: I11345dc1eb6433c91ade42b28321d7354e236bc0

5 years agoDelete meaningless configuration 80/212780/1 accepted/tizen/unified/20190828.011023 submit/tizen/20190827.051104
INSUN PYO [Tue, 27 Aug 2019 01:13:53 +0000 (10:13 +0900)]
Delete meaningless configuration

If the socket and service prefix names are the same, then Sockets(in .service) and Service(in .socket) are not needed.
Specifying Sokcets and Service is needed for certain functions, so using it without reason confuses the developer.

Change-Id: I6bf969f4a4abc2e59a6885a852bb1909ad861e77
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
5 years agoChange mc_client_get_ability_support() to mc_client_get_server_ability_support() 64/212064/1 accepted/tizen/unified/20190816.112315 submit/tizen/20190815.231259
hj kim [Wed, 14 Aug 2019 01:48:34 +0000 (10:48 +0900)]
Change mc_client_get_ability_support() to mc_client_get_server_ability_support()

Change-Id: Ifce4e6ec68fcdc4b7a648afc8a4c3b5f366d5f3b

5 years agoRemove check EACCESS and Fix log position to avoid errno change. (errno can be change... 45/211945/7
hj kim [Mon, 12 Aug 2019 10:32:53 +0000 (19:32 +0900)]
Remove check EACCESS and Fix log position to avoid errno change. (errno can be changed when using dlog)

The media-controller daemon can return EACCESS to the client when the daemon creates a commication socket temporarily.
For this reason, if client get EACCESSn, client must retry the connection.

Change-Id: If7753f8a2590365f4edba2ba6d4183207d0ddf0e

5 years ago[ACR-1428] Add functions for ability 50/210450/27 accepted/tizen/unified/20190813.082345 submit/tizen/20190813.013835
hj kim [Fri, 19 Jul 2019 07:08:33 +0000 (16:08 +0900)]
[ACR-1428] Add functions for ability

Change-Id: Ice6c525465f6e741ceb483a39f9c78585c4d3903

5 years agoRemove duplicate codes for releasing listener 62/211662/4
jiyong.min [Thu, 8 Aug 2019 01:52:15 +0000 (10:52 +0900)]
Remove duplicate codes for releasing listener

Change-Id: Ib25f7e12c768a9655d7c44b7abbdf9b3429ee1d4

5 years agoAdd to restart service when ondemand is not enabled. 23/211523/2 accepted/tizen/unified/20190806.220533 submit/tizen/20190806.073859
jiyong.min [Tue, 6 Aug 2019 07:06:28 +0000 (16:06 +0900)]
Add to restart service when ondemand is not enabled.

Change-Id: I24340e840cfff21d68a14792d177b29c64207c00

5 years agoModify the condition expression 75/211275/4 accepted/tizen/unified/20190806.072202 submit/tizen/20190805.053702
Minje Ahn [Thu, 1 Aug 2019 04:00:01 +0000 (13:00 +0900)]
Modify the condition expression

Change-Id: Ie18f8fa16d6ed2ea7399d49c3af97c89979ee243
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>