platform/upstream/gstreamer.git
2 years agowebrtcbin: Avoid access of freed memory 62/281362/1 accepted/tizen/unified/20220920.160548
Sangchul Lee [Wed, 20 Apr 2022 15:38:37 +0000 (00:38 +0900)]
webrtcbin: Avoid access of freed memory

Change-Id: I3489f2f718bdcd298ffc90c62a7352544293a70c
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2256>

2 years agowebrtc/datachannel: Change initial data channel state to CONNECTING 61/281361/1
Sangchul Lee [Fri, 1 Apr 2022 13:52:18 +0000 (22:52 +0900)]
webrtc/datachannel: Change initial data channel state to CONNECTING

It complies with http://w3c.github.io/webrtc-pc/#dom-rtcdatachannelstate.

Change-Id: I3cc114f435a6b6dde87e6a94b83e7419fa32e09b
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2099>

2 years agosrt: add recv and peer latency property 19/280319/1
Eunhye Choi [Fri, 26 Aug 2022 11:20:12 +0000 (20:20 +0900)]
srt: add recv and peer latency property

Change-Id: I2b47605c206e1a00e28429d79c699f4d87beeb3b

2 years agortsp-server: add mtpr media factory 90/280290/5 accepted/tizen/unified/20220829.062541 submit/tizen/20220826.112841
Eunhye Choi [Fri, 26 Aug 2022 08:15:46 +0000 (17:15 +0900)]
rtsp-server: add mtpr media factory

- support setting custom element

Change-Id: I3cc3b0c3d9f245658c697a26acb1f63649905ee4

2 years agobad:srtsrc: add "keep-listening" property to avoid EOS on disconnect 85/280285/1
Stéphane Cerveau [Wed, 19 May 2021 14:03:22 +0000 (16:03 +0200)]
bad:srtsrc: add "keep-listening" property to avoid EOS on disconnect

The property 'keep-listening' avoids EOS
when the remote client disconnects.

It can be useful to a keep a pipeline alive
when the srt connection drops remotely.

Change-Id: I5dbdc4858ea4bf944dcae021709a0b45fcbe00a8
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/967>

2 years agobad:srtsrc: remove dead code 84/280284/1
Stéphane Cerveau [Wed, 19 May 2021 14:00:13 +0000 (16:00 +0200)]
bad:srtsrc: remove dead code

Remove code useless since
132e3a1af9deb1d2cdf84d22b954967207bcc03a

Change-Id: I56f6412982cb1b7f3c07336c4f18fb379566bdde
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/967>

2 years agogst-plugins-good: Split package for cairo to remove cairo dependency in headless... 11/280111/1 accepted/tizen/unified/20220825.053116 submit/tizen/20220824.084449
Haesu Gwon [Wed, 24 Aug 2022 05:10:41 +0000 (14:10 +0900)]
gst-plugins-good: Split package for cairo to remove cairo dependency in headless profile

[Version] 1.20.0-33
[Issue Type] Improvement

Change-Id: Ia6f86fb7723d7e5f55c30ed811edeecb05aed38e

2 years agov4l2videodec: safely retrun from video_dec_loop with stream unlock 29/279729/1 accepted/tizen/unified/20220819.122509 submit/tizen/20220817.065352
Hou Qi [Tue, 15 Mar 2022 01:49:59 +0000 (09:49 +0800)]
v4l2videodec: safely retrun from video_dec_loop with stream unlock

This is to avoid decoder hang when doing trick play between
different resolutions.

Change-Id: I5731d6f7f587955fd4c5ffd07e1bc57404f10b23
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1960>

2 years agobad:srt: enable srt plugin 07/279207/3 accepted/tizen/unified/20220809.213747 submit/tizen/20220808.070032
Eunhye Choi [Wed, 3 Aug 2022 10:40:07 +0000 (19:40 +0900)]
bad:srt: enable srt plugin

- enable srt and rist plugin except tv product

Change-Id: I06a87e6e3db9485701b8225517762d97c69436aa

2 years agospec: disable introspection option 10/274110/9
Eunhye Choi [Thu, 21 Apr 2022 11:08:52 +0000 (20:08 +0900)]
spec: disable introspection option

- add introspection option and disable it as default

Change-Id: I9561c16cd40360ea718d32a43124aa1cce976c5d

2 years agonice: Update plugin of libnice 0.1.19 00/277700/1 accepted/tizen/unified/20220715.141357 submit/tizen/20220714.013603
Sangchul Lee [Tue, 12 Jul 2022 07:52:16 +0000 (16:52 +0900)]
nice: Update plugin of libnice 0.1.19

Change-Id: Icb1ebb213cf87d81f62ee55fa2137242849bec39
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agowebrtcbin: Do not decrease max_sink_pad_serial when releasing pad 48/277148/1 accepted/tizen/unified/20220708.132924 submit/tizen/20220704.000817 submit/tizen/20220707.012634
Sangchul Lee [Fri, 1 Jul 2022 05:51:59 +0000 (14:51 +0900)]
webrtcbin: Do not decrease max_sink_pad_serial when releasing pad

If requesting a sink pad after releasing one, there is a chance to
give the same pad name which have been already used.

Change-Id: I03d7b555ff4427f8efcb9ae7f76b444bb745e915
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agoRevert "webrtcdatachannel: Emit 'on-close' signal when calling 'close' action signal" 49/276949/1
Sangchul Lee [Tue, 28 Jun 2022 08:14:13 +0000 (17:14 +0900)]
Revert "webrtcdatachannel: Emit 'on-close' signal when calling 'close' action signal"

This reverts commit a6cf067742c1206c073b5e0fe26386a09fda8769.

This patch fixed the issue that only occurred between gst to web API(chromium).
But it ignores a procedure of closing data channel specified in spec.
So, it is reverted.

Change-Id: I69d057af4d22a02a1d25cae358df43d5dc588df3

2 years agospec: Sort options and libraries in ascending order 35/276335/2 accepted/tizen/unified/20220620.030238 submit/tizen/20220616.022003
Gilbok Lee [Wed, 15 Jun 2022 02:23:07 +0000 (11:23 +0900)]
spec: Sort options and libraries in ascending order

Change-Id: I532cf2fecb3b6bb9148b8aa8cd4f0f111e67f55b

2 years agobad:rist: Add rist plugins 01/276201/1
Gilbok Lee [Mon, 13 Jun 2022 02:12:52 +0000 (11:12 +0900)]
bad:rist: Add rist plugins

Change-Id: I87f57b3b8575b5f4e8e6f94cdb5b4eee9385a127

2 years agobase:tizenmemory: Remove GST_MEMORY_FLAG_NO_SHARE 11/276011/1 accepted/tizen/unified/20220610.134723 submit/tizen/20220609.013954
Jeongmo Yang [Wed, 8 Jun 2022 11:14:37 +0000 (20:14 +0900)]
base:tizenmemory: Remove GST_MEMORY_FLAG_NO_SHARE

- It can cause memory copy when it's pushed to source plugin like appsrc.

[Version] 1.20.0-29
[Issue Type] Improvement

Change-Id: I23b9bd8921a223219dbae103ebcc72ae3d28475b
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agogst-rtsp-server: Add build option 63/275863/1 accepted/tizen/unified/20220608.140019 submit/tizen/20220607.095434
Hyunsoo Park [Fri, 3 Jun 2022 07:38:59 +0000 (16:38 +0900)]
gst-rtsp-server: Add build option

[Version] 1.20.0-28
[Issue Type] Add option

 - Add tv profile option for branching TV dependent logic.

Change-Id: I9843cca6765b08ce405e9b3d757c4d8a15c5ad8b
Signed-off-by: Hyunsoo Park <hance.park@samsung.com>
2 years agortsp-media.c: Sets c_mashaller to generic 09/275809/3
Hyunsoo Park [Thu, 2 Jun 2022 05:25:09 +0000 (14:25 +0900)]
rtsp-media.c: Sets c_mashaller to generic

[Version] 1.20.0-27
[Issue Type] bug fix

If c_marshaller is NULL,
g_cclosure_marshal_generic() will be used as the marshaller for this signal by default

Change-Id: Ib4f6b85c2dbcc62d2783fcee4c253674581e52f4
Signed-off-by: Hyunsoo Park <hance.park@samsung.com>
2 years agortsp-client: block 'gst_rtsp_media_get_rates' in tv profile 08/275808/6 accepted/tizen/unified/20220603.141238 submit/tizen/20220602.083311
Hyunsoo Park [Thu, 2 Jun 2022 05:20:52 +0000 (14:20 +0900)]
rtsp-client: block 'gst_rtsp_media_get_rates' in tv profile

[Version] 1.20.0-26
[Issue Type] Product issue

'gst_rtsp_media_get_rates' checks GET_EVENT_SEGMENT.
But VD plugins doesn't send GET_EVENT_SEGMENT before data flow.

It is temporary solution, after VD plugins resolve this issue,
this define would be removed.

Change-Id: Ic2d1e6a5f5742d61c2aa404492e17aad704d629a
Signed-off-by: Hyunsoo Park <hance.park@samsung.com>
2 years agoaudiotestsrc: Fix crash in gst_audio_test_src_fill() 11/275511/6 accepted/tizen/unified/20220530.140619 submit/tizen/20220527.013222
Gilbok Lee [Thu, 26 May 2022 02:17:51 +0000 (11:17 +0900)]
audiotestsrc: Fix crash in gst_audio_test_src_fill()

- src->process is changed to NULL,
  during gst_audio_test_src_fill operation

Change-Id: I8e0943a48b1071f13243fac67945322f8fc90571

2 years agoavenc_aac: Increase avenc_aac rank 72/275572/1
Haesu Gwon [Thu, 26 May 2022 09:23:28 +0000 (18:23 +0900)]
avenc_aac: Increase avenc_aac rank

- Support ges mp4 encoding

[Version] 1.20.0-24
[Issue Type] Improvement

Change-Id: Ia9648339f5c8823359c931ec4c99494b20d367e4

2 years agoges: Add new features for textoverlay outline and shadow 67/275467/2
Haesu Gwon [Wed, 25 May 2022 08:37:53 +0000 (17:37 +0900)]
ges: Add new features for textoverlay outline and shadow

[Version] 1.20.0-23
[Issue Type] New feature

Change-Id: I7ff059402e286b980e4ce83a181b32a4fa1c0672

2 years agoomxdecoder: Fix crash and blocking issue 27/274827/3 accepted/tizen/unified/20220512.144515 submit/tizen/20220512.075702
Jeongmo Yang [Tue, 10 May 2022 06:38:14 +0000 (15:38 +0900)]
omxdecoder: Fix crash and blocking issue

- Set proper foreign memory mode
- Set valid video info when start decoding
- Set valid pointer for tbm surface
- Remove duplicated release code for tbm surface
- Exclude upstream code to set omx buffer flag

[Version] 1.20.0-22
[Issue Type] Bug fix

Change-Id: I48bb2a68d7ba52c8bf37688b64a127d59c679462
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agobuild: fix build error 68/274368/1
Eunhye Choi [Wed, 27 Apr 2022 06:28:34 +0000 (15:28 +0900)]
build: fix build error

- add missing appostrophe

Change-Id: I9d272b4e4f85104f8f7fc169e01a0c11972d40cb

2 years agoAdd the necessary cflags in gstreamer-1.0 pkgconfig 48/274348/2
Gilbok Lee [Wed, 27 Apr 2022 01:56:40 +0000 (10:56 +0900)]
Add the necessary cflags in gstreamer-1.0 pkgconfig

- missing related definition of tv-profile on gstreamer-1.0 pkgconfig

[Version] 1.20.0-20
[Issue Type] Fix bugs

Change-Id: I2423ea108b4c6b2b06a253db1387cf064ffd1752

2 years agofix up! base:tizenmemory: Add new function to create GstTizenMemory with tbm bo 15/274215/1 accepted/tizen/unified/20220426.021349 submit/tizen/20220422.064402
Jeongmo Yang [Mon, 25 Apr 2022 02:43:21 +0000 (11:43 +0900)]
fix up! base:tizenmemory: Add new function to create GstTizenMemory with tbm bo

[Version] 1.20.0-20
[Issue Type] Bug fix

Change-Id: I89526c7782fd2dde82bb18a3d30101926f811866
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agowebrtcbin: Fix pointer dereference before null check 36/274136/4 submit/tizen/20220425.020050
Sangchul Lee [Fri, 22 Apr 2022 02:51:07 +0000 (11:51 +0900)]
webrtcbin: Fix pointer dereference before null check

Unnecessary null check is also removed.
Typo of definition is fixed.
meson.build for bad plugin is revised to enable required
definition.

[Version] 1.20.0-19
[Issue Type] Coverity defects fix

Change-Id: Icfac5230bb9dddc7dc4d0572f10dd0bc306b20cc
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agoges: Disable video hw decoder 87/274087/7
Haesu Gwon [Thu, 21 Apr 2022 06:24:01 +0000 (15:24 +0900)]
ges: Disable video hw decoder

[Version] 1.20.0-18
[Issue Type] Bug fix

Change-Id: Icec0a3da207b8644a9f54c3ecdb2f8c03f9d051e

2 years agotsdemux: unlock mutex on -1 start_offfset 00/274100/1
Stéphane Cerveau [Mon, 14 Feb 2022 11:57:44 +0000 (12:57 +0100)]
tsdemux: unlock mutex on -1 start_offfset

Closing #1013

Change-Id: I3c7f046a533d48f5200e3c3762c2ea536378649c
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1718>

2 years agoh264decoder: Fix invalid memory access 99/274099/1
Seungha Yang [Fri, 11 Mar 2022 10:32:59 +0000 (19:32 +0900)]
h264decoder: Fix invalid memory access

gst_h264_dpb_needs_bump() can be called with null picture
in case of live

Change-Id: I451e3602e11ad584dbd4640ff90f0e2a939e7037
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1929>

2 years agospec: add libsoup as requires for good plugin 82/274082/3
Eunhye Choi [Thu, 21 Apr 2022 05:26:24 +0000 (14:26 +0900)]
spec: add libsoup as requires for good plugin

- libsoup is not installed on 7.0 headless
- add libsoup pkg dependency to enable souphttpsrc
  in good plugin

Change-Id: I85e805e56b8dddd7352c88db275615098f1d84f3

2 years agowebrtcbin: Avoid access of freed memory 45/274045/2
Sangchul Lee [Wed, 20 Apr 2022 08:48:01 +0000 (17:48 +0900)]
webrtcbin: Avoid access of freed memory

[Version] 1.20.0-17
[Issue Type] Coverity defects fix

Change-Id: Ib6a92a06db1af09f33d879a196739d6b65f09885
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agogood:v4l2h264enc: Add new feature for v4l2h264enc and disable it 53/273753/3 submit/tizen/20220415.001132
Jeongmo Yang [Wed, 13 Apr 2022 08:32:33 +0000 (17:32 +0900)]
good:v4l2h264enc: Add new feature for v4l2h264enc and disable it

[Version] 1.20.0-16
[Issue Type] New feature

Change-Id: Ie45e133815607e8f8d24d950b5d853aed8e7a892
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agowebrtcdatachannel: Emit 'on-close' signal when calling 'close' action signal 92/273692/2
Sangchul Lee [Tue, 12 Apr 2022 07:15:15 +0000 (16:15 +0900)]
webrtcdatachannel: Emit 'on-close' signal when calling 'close' action signal

Previously, peer_closed variable set in _on_sctp_stream_reset() was a condition
to trigger the 'on-close' signal. To emit the 'on-close' signal also when after
calling 'close' action, the condition is removed.

[Version] 1.20.0-15
[Issue Type] Improvement

Change-Id: Ia592f005031490119996ed38ecdada703cf11cc0
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agofixup! webrtc: Fix to have valid values of RTCPeerConnectionStats 49/273649/2
Sangchul Lee [Thu, 7 Apr 2022 16:35:21 +0000 (01:35 +0900)]
fixup! webrtc: Fix to have valid values of RTCPeerConnectionStats

Change-Id: Iff88f892279ae622e1407f620abdef69c7932950

2 years agobase:tizenmemory: Add new function to create GstTizenMemory with tbm bo 98/273098/9
Jeongmo Yang [Fri, 25 Mar 2022 09:14:42 +0000 (18:14 +0900)]
base:tizenmemory: Add new function to create GstTizenMemory with tbm bo

[Version] 1.20.0-14
[Issue Type] New feature

Change-Id: I3443ba9cc0ee904420e0b79509d8d846101ac9d4
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agowebrtc: Fix to have valid values of RTCPeerConnectionStats 71/273471/1
Sangchul Lee [Tue, 5 Apr 2022 11:46:50 +0000 (20:46 +0900)]
webrtc: Fix to have valid values of RTCPeerConnectionStats

Valid values corresponding to 'dataChannelsOpened' and 'dataChannelsClosed'
of https://w3c.github.io/webrtc-stats/#pcstats-dict* can now be obtained.

[Version] 1.20.0-13
[Issue Type] Improvement

Change-Id: Ib67095ceab32fe1e24c50722eecabca5158c1811
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agohlsdemux: after update playlist, setup streams if current variant changes 38/273438/3 submit/tizen/20220406.053411
Gilbok Lee [Wed, 6 Apr 2022 00:15:03 +0000 (09:15 +0900)]
hlsdemux: after update playlist, setup streams if current variant changes

- If the playlist update fails, the main playlist is downloaded newly
  At this time, a new playlist is created and the previous playlist isn't updated.

[Version] 1.20.0-12
[Issue Type] Bug fix

Change-Id: If7313c529b411d9f6c86019e3e24c6f4f475dda7

2 years agowebrtcstats: Unify 'packets-lost' data type to int64 86/273286/2
Sangchul Lee [Mon, 28 Mar 2022 12:25:50 +0000 (21:25 +0900)]
webrtcstats: Unify 'packets-lost' data type to int64

Previously, 'packets-lost' member of RTCReceivedRtpStreamStats had
a value of G_TYPE_INT from rtpsource or a value of G_TYPE_UINT64
from rtpjitterbuffer.
Because of the negative value of estimated amount of packets lost
in rtpsource as well as the description in
https://www.w3.org/TR/webrtc-stats/#dom-rtcreceivedrtpstreamstats
it is fixed to set this value with G_TYPE_INT64.

Change-Id: Ife744ab6d039fda1647c893089d1cacbc04a508a
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2049>

2 years agowebrtc/datachannel: fix use-after-free in sctp state notification 85/273285/2
Matthew Waters [Fri, 26 Nov 2021 11:11:06 +0000 (22:11 +1100)]
webrtc/datachannel: fix use-after-free in sctp state notification

g_signal_disconnect*() doesn't stop any existing callbacks from running
which means that if the notify::state callback is in progress in one
thread and the data channel object is finalize()ed in another thread,
then there could be a use-after-free trying lock the data channel
object.

We can't reasonably use a GWeakRef as we don't have a 'parent' object to
free the GWeakRef after the data channel is finalized.  This is also
complicated by the fact that the application can hold a reference to the
data channel object that would live beyond the lifetime of webrtcbin
itself.

We solve this by implementing a ghetto weak-ref solution internally with
a list of outstanding data channels.

Change-Id: Id901ca1cbd3edf1a9b9337a65b414d91c803cc3c
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1664>

2 years agowebrtcbin: Update documentation of 'get-stats' action signal 73/273073/1
Sangchul Lee [Mon, 21 Mar 2022 15:30:28 +0000 (00:30 +0900)]
webrtcbin: Update documentation of 'get-stats' action signal

Some stats fields are updated according to the current implementation.

Change-Id: Id45e1984fa07c056dc26f01276ec38b84bc61cca
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2005>

2 years agowebrtcbin: Check data channel transport for notifying 'ice-gathering-state' 72/273072/1
Sangchul Lee [Thu, 10 Mar 2022 10:22:52 +0000 (19:22 +0900)]
webrtcbin: Check data channel transport for notifying 'ice-gathering-state'

Previously, it did not care about data channel's. It is fixed by adding
some conditions.

Change-Id: Ie388e25f40a43dcbd39ec2c477022f8984f04e98
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1957>

2 years agogood:v4l2videodec: Fix DRC issue 30/272930/1 submit/tizen/20220329.001259
Jeongmo Yang [Mon, 28 Mar 2022 06:15:55 +0000 (15:15 +0900)]
good:v4l2videodec: Fix DRC issue

[Version] 1.20.0-11
[Issue Type] Bug fix

Change-Id: I75a392a7c3ae5ac6bd366924d73a670270f268d2
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agov4l2videodec : enable resolution change 28/272928/1
Ming Qian [Tue, 19 Oct 2021 08:10:06 +0000 (16:10 +0800)]
v4l2videodec : enable resolution change

The dynamic resolution changes when
the sequence starts when the decoder detects a coded frame with one or
more of the following parameters different from those previously
established (and reflected by corresponding queries):
1.coded resolution (OUTPUT width and height),
2.visible resolution (selection rectangles),
3.the minimum number of buffers needed for decoding,
4.bit-depth of the bitstream has been changed.

Although gstreamer parser has parsed the stream resolution.
but there are some case that we need to handle resolution change event.
1. bit-depth is different from the negotiated format.
2. the capture buffer count can meet the demand
3. there are some hardware limitations that the decoded resolution may
be larger than the display size. For example, the stream size is
1920x1080, but some vpu may decode it to 1920x1088.

Change-Id: I99c7e973c197490b462b5d3100b413007fc19c39
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1381>

2 years agov4l2videodec : refactor the setup process of capture 27/272927/1
Ming Qian [Tue, 26 Oct 2021 02:03:42 +0000 (10:03 +0800)]
v4l2videodec : refactor the setup process of capture

v4l2videodec do some refactoring so that it can support
dynamic resolution change event.

1.wrap the setup process of capture as a function,
as decoder need setup the capture again when
dynamic resolution change event is received.

2.move the function "remove_padding"

Change-Id: I31fc55b5247e80f4ee7692cf925ca4f06fac2d3b
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1381>

2 years agoFix build error in tv profile 44/272444/3 accepted/tizen/unified/20220323.062839 submit/tizen/20220318.052318
Gilbok Lee [Thu, 17 Mar 2022 00:35:28 +0000 (09:35 +0900)]
Fix build error in tv profile

- Add the necessary cflags in pkgconfig
- Add missed build define

[Version] 1.20.0-10
[Issue Type] Bug fix

Change-Id: Id86be2511a21c711e55ca2636d12625871b24d4a

2 years agowebrtcbin: Check data channel transport for notifying 'ice-gathering-state' 64/272164/10 accepted/tizen/unified/20220318.020352 submit/tizen/20220317.011210
Sangchul Lee [Thu, 10 Mar 2022 08:17:53 +0000 (17:17 +0900)]
webrtcbin: Check data channel transport for notifying 'ice-gathering-state'

Previously, it did not care about data channel's. It is fixed by adding
some conditions.

[Version] 1.20.0-9
[Issue Type] Bug fix

Change-Id: If1fd8047c1a944ccbe65c13b1cda7c0e34a7bec7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agogood:v4l2: Add new feature to disable colorimetry 96/272296/3
Jeongmo Yang [Mon, 14 Mar 2022 07:25:42 +0000 (16:25 +0900)]
good:v4l2: Add new feature to disable colorimetry

- V4L2 driver on RPI4 does not support some colorimetry,
  it causes video playing failure with some contents.

[Version] 1.20.0-8
[Issue Type] New feature

Change-Id: I87026e658b44784cbcc427551275aa03f03012c1
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agospec: apply tv profile requirement 10/272210/4
Eunhye Choi [Fri, 11 Mar 2022 07:26:45 +0000 (16:26 +0900)]
spec: apply tv profile requirement

Change-Id: Ia8b7a5869182bce4cbdd24c6fa96702bf5da556d

2 years agogood:v4l2: Add new property for TBM dump 80/272180/5
Jeongmo Yang [Thu, 10 Mar 2022 12:45:51 +0000 (21:45 +0900)]
good:v4l2: Add new property for TBM dump

[Version] 1.20.0-6
[Issue Type] New feature

Change-Id: Ia1233939ad58a9797840760cf2c35d4fa728f97c
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agofix up! good:v4l2bufferpool: Fix crash when v4l2h264dec is stopped 21/271521/2 accepted/tizen/unified/20220223.132507 submit/tizen/20220222.233730
Jeongmo Yang [Tue, 22 Feb 2022 09:49:55 +0000 (18:49 +0900)]
fix up! good:v4l2bufferpool: Fix crash when v4l2h264dec is stopped

- Add new parameter to check whether it's locked or not.

[Version] 1.20.0-5
[Issue Type] Bug fix

Change-Id: I5fabc83d3100b7ae3b46f48743a212311895f5b4
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agomeson: apply latest build script 27/271427/2 submit/tizen/20220222.093450
Eunhye Choi [Mon, 21 Feb 2022 06:18:12 +0000 (15:18 +0900)]
meson: apply latest build script

- revert 5b8d85d2d7268312a7e6ba40d08d53a0ffd7f209
- meson version have to be over 0.59.x

Change-Id: I9466034180183e7b1ee99e44ab6cca27f78e0815

2 years agofixup! gst-plugins-bad: Rename some definitions for TIZEN 33/271433/1 accepted/tizen/unified/20220222.132931 submit/tizen/20220221.101104
Sangchul Lee [Mon, 21 Feb 2022 07:28:40 +0000 (16:28 +0900)]
fixup! gst-plugins-bad: Rename some definitions for TIZEN

[Version] 1.20.0-3
[Issue Type] Typo

Change-Id: I9a336c1f21322c503e4702f443013ac7ef1a77e3

2 years agortpvp8depay: Fix crash when sending new custom event 31/271431/2
Sangchul Lee [Mon, 21 Feb 2022 06:50:50 +0000 (15:50 +0900)]
rtpvp8depay: Fix crash when sending new custom event

This patch fixes a seg.fault with warnings as below.

GLib-GObject-WARNING **: 13:56:46.770: ../gobject/gtype.c:4330: type id '0' is invalid
GLib-GObject-WARNING **: 13:56:46.772: can't peek value table for type '<invalid>' which is not currently referenced

[Version] 1.20.0-2
[Issue Type] Crash

Change-Id: If33c7c63e6ef14f9f5bcfaea8d0e650311ff1f16
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agoMerge "meson: Apply ASLR on Executable" into tizen
eunhae choi [Mon, 21 Feb 2022 03:45:34 +0000 (03:45 +0000)]
Merge "meson: Apply ASLR on Executable" into tizen

2 years agogood:v4l2bufferpool: Fix crash when v4l2h264dec is stopped 98/271398/1 accepted/tizen/unified/20220220.211441 submit/tizen/20220219.173827
Jeongmo Yang [Sat, 19 Feb 2022 14:52:58 +0000 (23:52 +0900)]
good:v4l2bufferpool: Fix crash when v4l2h264dec is stopped

- When gst_v4l2_buffer_pool_streamoff() is called, mutex for pool is locked
  and wait for buffer if there is a buffer which is not queued(=released) yet.
  But the mutex is also used when buffer is going to queue,
  so it cause deadlock and crash finally.
- This issue is occurred since below patch.
  commit id: ca61a76987e566555a2f7bc0f4c1bcf3a8ad6dcd
  v4l2: Fix threading issues in orphaning mechanism

[Version] 1.20.0-1
[Issue Type] Deadlock and crash

Change-Id: I980dc29156a40102206038e58f762ae7f2314e11
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agomeson: Apply ASLR on Executable 82/271382/1
Eunhye Choi [Fri, 18 Feb 2022 11:17:18 +0000 (20:17 +0900)]
meson: Apply ASLR on Executable

Change-Id: I87f1c357ac0f925e2b9cf2794b14f8d7673dd9e2

2 years agospec: fix emul build error 56/271156/2 accepted/tizen/unified/20220217.153506 submit/tizen/20220216.051033
Eunhye Choi [Wed, 16 Feb 2022 06:25:16 +0000 (15:25 +0900)]
spec: fix emul build error

- exclude omx build in case of ix86, x86_64

Change-Id: I3bbc650746a12b0dcd2459107af52f4c8b9790f3

2 years agogood:qtmux: Enable TIZEN_FEATURE_GST_MUX_ENHANCEMENT and fix build error 50/271150/1
Jeongmo Yang [Tue, 15 Feb 2022 12:46:35 +0000 (21:46 +0900)]
good:qtmux: Enable TIZEN_FEATURE_GST_MUX_ENHANCEMENT and fix build error

Change-Id: I88f573164982d78487b9975966eadb2fb40424a2
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
(cherry picked from commit b250b4bd1668640981b26df9cfd5d03a8ff16c32)

2 years agoMerge branch 'tizen_gst_1.20.0' into tizen 00/271100/1
Gilbok Lee [Tue, 15 Feb 2022 08:45:42 +0000 (17:45 +0900)]
Merge branch 'tizen_gst_1.20.0' into tizen

Change-Id: I0593f0ccef22bc03857264fc421ad17fca21778c

2 years agobuild: downgrade of meson 91/271091/3
Eunhye Choi [Tue, 15 Feb 2022 07:56:34 +0000 (16:56 +0900)]
build: downgrade of meson

- downgrade of meson temporarily for SR verification.
- this will be reverted as soon as meson 0.60.3 is applied
  at tizen_base.

Change-Id: I458e1907c36011c45efc6cf9a49292eac281fabd

2 years agogood:v4l2videodecoder: Fix video decoding failure 86/271086/2
Jeongmo Yang [Tue, 15 Feb 2022 07:15:24 +0000 (16:15 +0900)]
good:v4l2videodecoder: Fix video decoding failure

1. not-negotiation
 : Skip adding color space for output.
2. buffer drop
 : Set missed timestamp.

Change-Id: I54058c9e917a3e6b6dbf5efbc03461782aee68e4
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agospec: remove release macro 33/271033/1
Eunhye Choi [Mon, 14 Feb 2022 11:04:18 +0000 (20:04 +0900)]
spec: remove release macro

- spec :
  remove release macro which is not supported on Quick Build system
- core :
  disable deprecated declaration temporarily to avoid build error
  of related modules

Change-Id: Ib527e9aaf98d3c4c0d933eca30b77e4f70af6416

2 years agoUse gst_branch define in spec 42/270942/3
Gilbok Lee [Fri, 11 Feb 2022 08:59:10 +0000 (17:59 +0900)]
Use gst_branch define in spec

- Use _lib_gstreamer_dir define in spec

Change-Id: I34ece90b32f3ccd07e210b13b95b7cfa23596e79

2 years agogstreamer: enable check 34/270934/1
Gilbok Lee [Fri, 11 Feb 2022 08:13:43 +0000 (17:13 +0900)]
gstreamer: enable check

Change-Id: Ia0f9d56d52c2bd73ef950b55db8d851c81f7d58f

2 years agoFix incorrect define 97/270897/2
Gilbok Lee [Fri, 11 Feb 2022 01:55:22 +0000 (10:55 +0900)]
Fix incorrect define

Change-Id: I3ea1d50c627203ff94cf0aead09ee3b1e300f21e

2 years agoMerge "nice: Add gstreamer plugins from libnice (0.1.17)" into tizen_gst_1.20.0
Sangchul Lee [Thu, 10 Feb 2022 10:20:56 +0000 (10:20 +0000)]
Merge "nice: Add gstreamer plugins from libnice (0.1.17)" into tizen_gst_1.20.0

2 years agoMerge "spec: Fix to have valid release version when building each plugin" into tizen_...
Gilbok Lee [Thu, 10 Feb 2022 08:26:03 +0000 (08:26 +0000)]
Merge "spec: Fix to have valid release version when building each plugin" into tizen_gst_1.20.0

2 years agovideo-format: TV profile format(STV0 and STV1) location rearrangement 60/270860/1
Hyunil [Thu, 10 Feb 2022 07:38:18 +0000 (16:38 +0900)]
video-format: TV profile format(STV0 and STV1) location rearrangement

Change-Id: Ie0fc546358688dd119025271f09990b68018b6c6
Signed-off-by: Hyunil <hyunil46.park@samsung.com>
2 years agonice: Add gstreamer plugins from libnice (0.1.17) 47/270847/3
Sangchul Lee [Thu, 10 Feb 2022 05:29:21 +0000 (14:29 +0900)]
nice: Add gstreamer plugins from libnice (0.1.17)

Change-Id: I30b4590d3e767ccff11a385ebfa5597935bc0db8
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agospec: Fix to have valid release version when building each plugin 17/270817/1
Sangchul Lee [Wed, 9 Feb 2022 09:36:59 +0000 (18:36 +0900)]
spec: Fix to have valid release version when building each plugin

Change-Id: I1f428505d85428385e7cef721c0499306cb0a804
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agospec: add release def for each plugin 49/270649/2
Eunhye Choi [Mon, 7 Feb 2022 16:54:30 +0000 (01:54 +0900)]
spec: add release def for each plugin

- add release define for each plugin
- use tar.gz to reduce archive time during build

Change-Id: I1d9cb584f73c79c3486c4ebbdf8a28f3374e3ae9

2 years agoMerge branch 'tizen_gst_1.19.3' into tizen_gst_1.20.0 96/270596/4
Gilbok Lee [Mon, 7 Feb 2022 01:09:35 +0000 (10:09 +0900)]
Merge branch 'tizen_gst_1.19.3' into tizen_gst_1.20.0

Change-Id: I4a331bbd883e5f078684fd02948d8d6e9b78eed0

2 years agogst-plugins-base: Add camera control interface 33/270533/1
Gilbok Lee [Fri, 4 Feb 2022 08:07:41 +0000 (17:07 +0900)]
gst-plugins-base: Add camera control interface

Change-Id: Iad5a2993728df0d79fbdfc8a50ca4630e1d4044e

2 years agogst-plugins-base : Add missing definition for pkg-config 31/270531/1
Gilbok Lee [Fri, 4 Feb 2022 07:34:03 +0000 (16:34 +0900)]
gst-plugins-base : Add missing definition for pkg-config

Change-Id: Ia99e541c280e81e400b39b17d5cc0dd46d90e8dc

2 years agoChange auto features to 'disabled' 30/270530/3
Gilbok Lee [Fri, 4 Feb 2022 07:11:07 +0000 (16:11 +0900)]
Change auto features to 'disabled'

Change-Id: Ifff14cae99c0718f2e615253c10ba3e5b0712fbb

2 years agoRelease 1.20.0 1.20.0
Tim-Philipp Müller [Thu, 3 Feb 2022 19:53:25 +0000 (19:53 +0000)]
Release 1.20.0

2 years agoUpdate ChangeLogs for 1.20.0
Tim-Philipp Müller [Thu, 3 Feb 2022 19:53:18 +0000 (19:53 +0000)]
Update ChangeLogs for 1.20.0

2 years agovideo: fix up GstVideoOrientationMethod type registration
Tim-Philipp Müller [Thu, 3 Feb 2022 18:18:03 +0000 (18:18 +0000)]
video: fix up GstVideoOrientationMethod type registration

... in order to make older g-i happy (~1.60) which doesn't like
freeform descriptions in the value_name field. Which in turn
then makes hotdoc happy instead of erroring out when we bump
the symbol index version.

We usually only (ab)use the name field for description strings
for private plugin enums, not for public API visible to bindings.

This lets glib-mkenum generate the _get_type() function for the
enum again, which in turn will generate the expected value names
to match the enums.

We might be able to add this back later once we can upgrade the
g-i version requirement (and the documentation job image).

This reverts most of commit b0aab48cdcf0a454d14aeb4d907209d8ee3f1add

2 years agortsp-server: includes GObject-introspection 03/270503/4
Hyunsoo Park [Thu, 3 Feb 2022 14:27:16 +0000 (23:27 +0900)]
rtsp-server: includes GObject-introspection

Change-Id: Ia3a93b0edb37f8b04ecbc4fba58f74642c47f3cd
Signed-off-by: Hyunsoo Park <hance.park@samsung.com>
2 years agortsp-server: remove files of no use 75/270475/3
Hyunsoo Park [Thu, 3 Feb 2022 07:05:45 +0000 (16:05 +0900)]
rtsp-server: remove files of no use

'*-ext' files are inherited for tizen extension.
And these have been used internally, but no longer used.

Change-Id: Icb49a56b4f26ee008d84a43b1ae8cc0839d7a5fb
Signed-off-by: Hyunsoo Park <hance.park@samsung.com>
2 years agoregistry/macos: retrieve plugins relative to location of libgstreamer.dylib
Matthew Waters [Wed, 2 Feb 2022 07:06:49 +0000 (18:06 +1100)]
registry/macos: retrieve plugins relative to location of libgstreamer.dylib

Provides a relocatable directory structure for running GStreamer
applications as used in GStreamer.framework.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1627>

2 years agogst-plugins-base: Add missing definition for gstreamer-video-1.0 pkg-config 50/270450/1
Sangchul Lee [Thu, 3 Feb 2022 02:19:11 +0000 (11:19 +0900)]
gst-plugins-base: Add missing definition for gstreamer-video-1.0 pkg-config

It is fixed to use tizen functions in videooverlay.h.

Change-Id: I132d9d04be952aa815e4c4d8702611def87374ac
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agodashsink: doc cleanup
Stéphane Cerveau [Wed, 2 Feb 2022 08:58:15 +0000 (09:58 +0100)]
dashsink: doc cleanup

Remove max-files mention in the command line test
Fix some typos
Use mpegtsdemux instead of tsdemux in the pipeline description

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1624>

2 years agoIncl resample in CustomData, tutorial 3
Alistair Martin [Tue, 1 Feb 2022 14:51:23 +0000 (14:51 +0000)]
Incl resample in CustomData, tutorial 3

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1619>

2 years agotagdemux: Fix crash when presented with malformed files
Jeremy Cline [Sun, 21 Nov 2021 22:52:48 +0000 (17:52 -0500)]
tagdemux: Fix crash when presented with malformed files

There's a race condition in gsttagdemux.c between typefinding and the
end-of-stream event. If TYPE_FIND_MAX_SIZE is exceeded,
demux->priv->collect is set to NULL and an error is returned. However,
the end-of-stream event causes one last attempt at typefinding to occur.

This leads to gst_tag_demux_trim_buffer() being called with the NULL
demux->priv->collect buffer which it attempts to dereference, resulting
in a segfault.

The malicious MP3 can be created by:

printf "\x49\x44\x33\x04\x00\x00\x00\x00\x00\x00%s", \
    "$(dd if=/dev/urandom bs=1K count=200)" > malicious.mp3

This creates a valid ID3 header which gets us as far as typefinding. The
crash can then be reproduced with the following pipeline:

gst-launch-1.0 -e filesrc location=malicious.mp3 ! queue ! decodebin ! audioconvert ! vorbisenc ! oggmux ! filesink location=malicious.ogg

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/967

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1620>

2 years agonvdecoder: Fix for display resolution setup
Seungha Yang [Mon, 31 Jan 2022 15:18:44 +0000 (00:18 +0900)]
nvdecoder: Fix for display resolution setup

Display resolution should be cropped rect, not coded resolution.
Otherwise decoded output from NVDEC might be wrong.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1617>

2 years agoapplemedia: Disable 64RGBALE support on older macOS
Nirbheek Chauhan [Mon, 31 Jan 2022 21:30:41 +0000 (03:00 +0530)]
applemedia: Disable 64RGBALE support on older macOS

The kCVPixelFormatType_64RGBALE enum is only available on macOS Big
Sur (11.3) and newer. We also cannot use that while configuring the
encoder or decoder on older macOS.

Define the symbol unconditionally, but only use it when we're running
on Big Sur with __builtin_available().

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1613>

2 years agoapplemedia: Remove some unnecessary variables
Nirbheek Chauhan [Mon, 31 Jan 2022 21:34:32 +0000 (03:04 +0530)]
applemedia: Remove some unnecessary variables

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1613>

2 years agodocs: gst-libav: update cache and symbol index for FFmpeg 4.4
Mathieu Duponchelle [Fri, 28 Jan 2022 18:58:55 +0000 (19:58 +0100)]
docs: gst-libav: update cache and symbol index for FFmpeg 4.4

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1597>

2 years agodocs: Add objc and objcpp files to hotdoc gst_c_sources
Nirbheek Chauhan [Mon, 31 Jan 2022 23:37:04 +0000 (05:07 +0530)]
docs: Add objc and objcpp files to hotdoc gst_c_sources

Hotdoc should be able to extract and parse comments out of these. Just
need to be careful to only add the glob in directories that actually
contain *.m (objc) and *.mm (objcpp) files.

Also fix some doc comments and remove redundant ones.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1614>

2 years agovaapi: Disable Wayland if no libdrm
Víctor Manuel Jáquez Leal [Sun, 30 Jan 2022 08:38:48 +0000 (09:38 +0100)]
vaapi: Disable Wayland if no libdrm

Platform wise, is not possible, as far as I known, to have Wayland
without kernel's DRM. Though, it's possible to configure
gstreamer-vaapi without DRM but Wayland support, with the enhanced
handling of dmabuf in vaapisink for Wayland, vaapisink will always
fail. Given both issues, configuration with no DRM but Wayland, makes
things more complex, and a simpler approach is to refuse that
configuration.

This patch disables Wayland support if there isn't DRM support. Also,
it disables the display test for Wayland, relying only on DRM and
X11.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1606>

2 years agovaapi: libs: video-format: Check if formats map is not NULL.
Víctor Manuel Jáquez Leal [Sun, 30 Jan 2022 06:10:09 +0000 (07:10 +0100)]
vaapi: libs: video-format: Check if formats map is not NULL.

Formats map is instantiated at the end of the display
instantiation. The problem is the Wayland display which looks for a
format in a callback, before the map is populated.

If user compiles gstreamer-vaapi with DRM support, the map is
populated with a DRM display at GStreamer plugin registration. But if
not, or a VA driver is not available, the plugin will try with a
Wayland driver, which cause the NULL de-reference.

Nevertheless, in the case of no DRM support, and if the Wayland
display doesn't get a reply from the format conversion is not a
problem.

So the solution is the trivial one, check if the format map is already
populated before de-reference it.

Fixes: #977
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1606>

2 years agogstreamer-full: warn if version-script not available
Stéphane Cerveau [Tue, 19 Oct 2021 10:32:32 +0000 (12:32 +0200)]
gstreamer-full: warn if version-script not available

Instead of error out, warn user that the platform does not support
the version script.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1191>

2 years agowpe: Support wpe-webkit-1.1
Jan Alexander Steffens (heftig) [Fri, 14 Jan 2022 10:26:42 +0000 (11:26 +0100)]
wpe: Support wpe-webkit-1.1

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1522>

2 years agowpe: Install WebExtension in pkglibdir
Philippe Normand [Sat, 29 Jan 2022 10:24:36 +0000 (10:24 +0000)]
wpe: Install WebExtension in pkglibdir

The uninstalled WebExtension takes precedence over the installed one, so that
audio support works in local developer builds as well.

Fixes #975

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1602>

2 years agodocs: Rename "OS X" to "macOS" in some documentation
Nirbheek Chauhan [Sun, 30 Jan 2022 13:36:29 +0000 (19:06 +0530)]
docs: Rename "OS X" to "macOS" in some documentation

No one uses the term "Mac OS X" anymore, it's "macOS". "OS X" is even
worse, because people will usually start the search with "mac".

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1607>

2 years agoosxaudio: Document GstOsxAudioElement interface
Nirbheek Chauhan [Sat, 29 Jan 2022 22:26:14 +0000 (03:56 +0530)]
osxaudio: Document GstOsxAudioElement interface

This is listed as a public interface implemented by osxaudio, so we
need to mark it as a plugin API so that it's listed in the
documentation correctly.

This is an ancient symbol, so add it to the symbol index too.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1601>

2 years agoapplemedia: Document vtenc / vtdec elements
Nirbheek Chauhan [Fri, 28 Jan 2022 17:45:28 +0000 (23:15 +0530)]
applemedia: Document vtenc / vtdec elements

Also preserve-alpha property should only be exposed on the
vtenc_prores element since h264 does not support transparency.

Fixes https://gitlab.freedesktop.org/gstreamer/gst-docs/-/issues/94

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1601>

2 years agodocs: Update symbol index with old macOS plugin symbols
Nirbheek Chauhan [Fri, 28 Jan 2022 17:07:38 +0000 (22:37 +0530)]
docs: Update symbol index with old macOS plugin symbols

These symbols from macOS plugins osxaudio, osxvideo, and applemedia
have been present for a very long time but were never documented.

This allows us to document these, and also add Since: markers for new
features (symbols) there were added in 1.20

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1601>