Szymon Jastrzebski [Tue, 10 Oct 2017 06:56:25 +0000 (08:56 +0200)]
[Power] Refactoring module
Previous implementation depended partly on Deviced functions through the
dbus interface. Currently, the implementation uses only DeviceD Native API
(except the ReleaseBrightness and SetBrightness methods).
TheReleaseBrightness is still not wrapped into the Native C DeviceD API).
[Verification] TCT pass: A/M - 100%.
Change-Id: I03124c0d332bf03cd5481ac2b38c9e5c9a534063
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Fri, 6 Apr 2018 07:29:15 +0000 (09:29 +0200)]
[version] 2.20
Change-Id: I8c11218bf7cb61b4dcc530a205e7a4bfc1d94be9
Rafal Walczyna [Fri, 6 Apr 2018 07:19:43 +0000 (09:19 +0200)]
[Messaging] Fixed permissions of temporary file used for messaging
File created by mkstemp() gives permissions only for user,
that's why msg-service could not read from file and body of message was empty.
[Verification] 100% passrate on TM1
Change-Id: I290277294459ca96392b9a97adccded1664a426d
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Tue, 3 Apr 2018 08:12:44 +0000 (10:12 +0200)]
[Download] Fixed unexpected result of fixing coverity issues
[Bug] When running on TV device, checking status of cellular network
returned not supported error, the checking status of cellular needed
to be moved into correct section instead of running this code in common
code part.
[Verification] TCT result - 100%
Change-Id: I6cb171034588b2616222bde4101a278c491fdc52
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 28 Mar 2018 11:06:10 +0000 (13:06 +0200)]
[version] 2.19
Change-Id: Ic8848b54eda46b98bd609e0d4254548a8c5beb04
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 28 Mar 2018 11:00:13 +0000 (11:00 +0000)]
Merge "[common] Coverity issues fix" into tizen_3.0
Piotr Kosko [Tue, 27 Mar 2018 12:59:02 +0000 (14:59 +0200)]
[common] Coverity issues fix
[Feature] Fixed coverity issues with below ids:
110914, 110006, 108656, 107626, 107387,
107077, 106006, 108993, 108297, 106912
Additionally fixed potential crash in download API -
in case of native function failure, the "success" response
is not trying to be build.
[Verification] 100% passrate for modules:
application, bluetooth, download, exif, filesystem, messaging-*
Change-Id: I8d9482501a7375962408186feaa5ecd1f0826b1d
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Rafal Walczyna [Tue, 27 Mar 2018 11:55:44 +0000 (13:55 +0200)]
[common] Fixing coverity issues
Issues: 110672, 108789, 108137, 107617,
106435, 112265, 112254, 107669, 105923
[Verification] 100% passrate in:
bookmark, calendar, contact, content, datacontrol,
filesystem, keymanager
Change-Id: Id667a94fe653f831a8cfdd70813c8ace91e1cf5d
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Lukasz Wojciechowski [Sat, 10 Mar 2018 02:25:34 +0000 (03:25 +0100)]
[Push] Prefix string type with namespace std
The patch fixes build break in Tizen:4.0:Unified.
The string type without std::string is not recognized by compiler.
Change-Id: I048bad0a1d71cb841965a84b2d11d2afb9c19eea
Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
(cherry picked from commit
a2c7a32a5fbc41e6bf20c891797c786e946628c9)
Piotr Kosko [Fri, 23 Mar 2018 11:10:31 +0000 (12:10 +0100)]
[version] 2.18
Change-Id: I171c24fc4170a519fef7fde45b4e223843cf33c0
Piotr Kosko [Fri, 23 Mar 2018 11:05:34 +0000 (11:05 +0000)]
Merge "[NFC] Fix isActivatedHandlerFunctions return values" into tizen_3.0
Rafal Walczyna [Fri, 23 Mar 2018 10:05:05 +0000 (11:05 +0100)]
[NFC] Fix isActivatedHandlerFunctions return values
Functions IsActivatedHandlerForCategory and IsActivatedHandlerForAID
always return false. After fix they work properly.
TCT tests needs fixing, after fix there will be 100% passrate.
Tested on TW1 tizen3.0
Change-Id: I9a4833d4073e512e9414e63325515ebfa8d6b8a4
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Pawel Kaczmarczyk [Mon, 19 Mar 2018 14:45:33 +0000 (15:45 +0100)]
[Systeminfo] Fix for incorrect USB storage capacity
USB_DEVICE has not been reporting correct capacity values
on TV profile. It was caused by different way of handling
reading storage properties.
[Fix]
Each storage type is treated in the same way when
getting information about storage's space.
[Verification] Tested in Chromium cosole
tct-systeminfo-tizen-tests passrate: 100%
tct-filesystem-tizen-tests passrate: 100%
Change-Id: I1d2a8a40a2cac18d5961a301bdd3e586cc3eedad
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Piotr Kosko [Mon, 26 Feb 2018 09:33:00 +0000 (10:33 +0100)]
[version] 2.17
Change-Id: I3bf56e2b79bff86daefb7b9c3c8d53b41d5ac22c
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Fri, 23 Feb 2018 13:50:55 +0000 (13:50 +0000)]
Merge "[NFC] Fix memory management problems" into tizen_3.0
Pawel Wasowski [Mon, 12 Feb 2018 11:14:15 +0000 (12:14 +0100)]
[NFC] Fix memory management problems
This commit prevents crashes, fixing 2 memory management problems:
1. user_data passed to nfc_tag_transceive was deleted twice
2. buffer argument of tagTransceiveCb was deleted inside the function;
according to Native NFC API reference: "buffer will be automatically
destroyed when the callback function returns. (Do not release buffer.)"
[Verification] NFCTag.transceive() function was tested in Chrome
DevTools console and worked fine.
Change-Id: I509c368d817b6663373ba0614af73402f8ad47a6
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Michal Bistyga [Thu, 8 Feb 2018 12:41:42 +0000 (13:41 +0100)]
[Calendar] Fixing multiple bugs in calendar API
3 bugs has been fixed:
1) User couldn't add new calendar to database
1a) Resolved by sending new object, no calendar through JSON
2) Calendar object was not updated with id got from native layer
2a) Resolved by returning id to js layer and...
2b) Changing setting its as result.id, not just a result
3) Every event has been set to calendar with id 0
3a) Resolved by utilizing not used calendarId attribute
[Verification]
verified in chrome console
tct-tests 100% passrate
Change-Id: I5edcf33d8dd753fc044d2b61677439145f4a73d1
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Piotr Kosko [Fri, 9 Feb 2018 08:52:54 +0000 (08:52 +0000)]
Merge "[Filesystem] Fix return on error in FileWriteString and FileWriteBytes" into tizen_3.0
Jakub Skowron [Wed, 7 Feb 2018 14:02:53 +0000 (15:02 +0100)]
[Filesystem] Fix return on error in FileWriteString and FileWriteBytes
Change-Id: I0377b1a7eaa60a1b5d50c759005d2c6063400332
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Piotr Kosko [Mon, 5 Feb 2018 12:48:16 +0000 (13:48 +0100)]
[SecureElement][NFC][Messageport] Fixing casting problems
[Bug] Casting double -> char should not be done directly.
[Verification] Passing values greater than 127 to API makes that
values are correctly translated.
TCT passrate 100%.
Change-Id: I786392fd3be2e7d0eb5211e224a25c8078f383e9
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Mon, 5 Feb 2018 06:49:29 +0000 (07:49 +0100)]
[version] 2.16
Change-Id: I7316b54e3c6ab3fe41b5e2e1ac6e4b1a9e7dfa35
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Mon, 5 Feb 2018 06:10:16 +0000 (06:10 +0000)]
Merge "[Bluetooth] Fixing undefined behaviour during cast" into tizen_3.0
Michal Bistyga [Fri, 2 Feb 2018 15:09:33 +0000 (16:09 +0100)]
[NFC] Fixing undefined behaviour during static_cast to unsigned char
Validation:
Automatic tests 100% pass rate
TODO manual tests
Change-Id: I9c15efc77c82f0f7e4019913b2bd02d0f8047bb1
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Michal Bistyga [Fri, 2 Feb 2018 11:37:08 +0000 (12:37 +0100)]
[Bluetooth] Fixing undefined behaviour during cast
Char is unsigned by default on ARM architecture. static_cast from double to unsigned char is undefined behaviour and complier overwritten any negative value with 0.
[Validation]
tests 100% pass rate
Change-Id: Iec39a3c17b18ec7aa4f020fe5de709d66fa426fd
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Piotr Kosko [Fri, 26 Jan 2018 10:04:18 +0000 (11:04 +0100)]
[version] 2.15
- version increased
- fixed minor style issue
Change-Id: I70a371ce7e6834bf73c413e19de37111168c9147
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Fri, 26 Jan 2018 09:01:47 +0000 (09:01 +0000)]
Merge "[Utils] Fix Long conversion (allow hex string value)" into tizen_3.0
Jakub Skowron [Wed, 17 Jan 2018 13:27:09 +0000 (14:27 +0100)]
[Utils] Fix Long conversion (allow hex string value)
Until now string "0x15" would be converted 0. This change affects
all numeric conversions which use _toLong.
According to https://www.w3.org/TR/WebIDL-1/#es-long value
should be initialized by ToNumber, which is defined in
https://tc39.github.io/ecma262/#sec-tonumber-applied-to-the-string-type
and allows value to be in form of HexIntegerLiteral.
Change-Id: Ib719ce8fd5beccc5947b761dc905c49ac0469490
Lukasz Bardeli [Thu, 25 Jan 2018 10:53:43 +0000 (11:53 +0100)]
[Download] Fix preventing crash. Prevent call callback twice
Add condition to prevent call some callback twice and modify body of methods
OnFinished, OnCanceled and OnFailed to prevent crash.
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I7d194b4d762a52f0281e22555bfd54caa3cb4579
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Rafal Walczyna [Thu, 25 Jan 2018 09:01:43 +0000 (10:01 +0100)]
[humanactivitymonitor] Fix crash when WRIST_UP event was called
[Verification] Tested with custom app - event fires properly
Auto test on TW2 - 100% passrate
Change-Id: I762a2a0950c4b17333f78b11eb320680f8ec1128
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Thu, 18 Jan 2018 12:32:21 +0000 (13:32 +0100)]
[version] 2.14
Change-Id: I7b9924c14471bce00e2e5eaf607080c869ad92b1
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 18 Jan 2018 11:45:51 +0000 (11:45 +0000)]
Merge "[Filesystem] Remove unused Base64 and UTF-8 functions" into tizen_3.0
Piotr Kosko [Thu, 18 Jan 2018 11:45:14 +0000 (11:45 +0000)]
Merge "[Filesystem] Speed up conversion to octet in writeBytes" into tizen_3.0
Piotr Kosko [Thu, 18 Jan 2018 11:44:56 +0000 (11:44 +0000)]
Merge "[Filesystem] Write file performace improvement (binary data through UTF-8)" into tizen_3.0
Piotr Kosko [Thu, 18 Jan 2018 11:44:07 +0000 (11:44 +0000)]
Merge "[Filesystem] Read file performace improvement (binary data through UTF-8)" into tizen_3.0
Jakub Skowron [Wed, 17 Jan 2018 16:04:49 +0000 (17:04 +0100)]
[Filesystem] Remove unused Base64 and UTF-8 functions
removed: encodeString, decode, decodeString, getCodePoint,
_utf8_encode, _utf8_decode
Change-Id: I269cd71eb252e2f6ea9b266a50acde3f769db50e
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Jakub Skowron [Wed, 17 Jan 2018 14:43:31 +0000 (15:43 +0100)]
[Filesystem] Speed up conversion to octet in writeBytes
Do not use validateArgs to validate each value in array
Change-Id: I9ac59f59187c7f57a0213778d0f2552cb9de4538
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Jakub Skowron [Wed, 17 Jan 2018 12:46:16 +0000 (13:46 +0100)]
[Filesystem] Write file performace improvement (binary data through UTF-8)
Improve performance of write, writeBytes, writeBase64 by
pushing binary data through UTF-8 null-terminated string.
Byte 0x00 is encoded as U+0100.
Removed class FilesystemFile.
[Verification] TCT pass rate is 100%
tct-filesystem-tizen-tests
Change-Id: Iee5983a429ed484eb0fd6a6d35ea794d292de8de
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Jakub Skowron [Wed, 10 Jan 2018 06:54:35 +0000 (07:54 +0100)]
[Filesystem] Read file performace improvement (binary data through UTF-8)
Improve performance of readBytes, readBase64 by pushing binary data
through UTF-8 null-terminated string.
Byte 0x00 is encoded as U+0100.
Removed not used functions in FilesystemFile. Improved performance of
readAsText.
[Verification] TCT pass rate is 100%
tct-filesystem-tizen-tests
Change-Id: I41fe2f9c7855721b38ad4bbf268e8eb7851b10eb
Signed-off-by: Jakub Skowron <j.skowron@samsung.com>
Rafal Walczyna [Wed, 17 Jan 2018 13:43:45 +0000 (14:43 +0100)]
[humanactivitymonitor] Fix timestamp in HumanActivityRecognitionData
[Verification] auto and manual tests which use this data pass
Change-Id: I8f174925147c561cfcf22590cc5d4b5abbbba506
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
(cherry picked from commit
f3123977c14bad5410ee36b520f07c4061d4fc3a)
Piotr Kosko [Tue, 16 Jan 2018 09:38:34 +0000 (10:38 +0100)]
[version] 2.13
Code format was also fixed
Change-Id: Iae0d214d3caeeb67cdbfe1938718863d70a15789
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 11 Jan 2018 08:23:10 +0000 (08:23 +0000)]
Merge "[NFC] Fix for passing wrong values to APDU response" into tizen_3.0
Arkadiusz Pietraszek [Mon, 8 Jan 2018 15:23:33 +0000 (16:23 +0100)]
[Filesystem] Fix to commit
ce958812096 to read 64 Kb and greater files
Commit
ce958812096 has introduced error in which only first 64 Kb of
text file was read.
[Verification] TCT pass rate is 100%
Automated tests has been run:
tct-archive-tizen-tests
tct-systeminfo-tizen-tests
tct-content-tizen-tests
tct-filesystem-tizen-tests
Change-Id: I266c839e78af9420bdad328e8fa4332bdc16b8a4
Pawel Kaczmarczyk [Mon, 8 Jan 2018 11:19:26 +0000 (12:19 +0100)]
[NFC] Fix for passing wrong values to APDU response
Issue: http://suprem.sec.samsung.net/jira/browse/XWALK-1747
Bug: Wrong type of data in array.
Verification: NFC auto tct passrate 100% (emulator wearable)
Change-Id: I5824e51ce677d6c1c7de006ad10b509b84f00a6a
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@partner.samsung.com>
Arkadiusz Pietraszek [Thu, 4 Jan 2018 12:01:16 +0000 (13:01 +0100)]
[Filesystem] Quick fix to speed up, by not encoding strings
FileStream.write and FilesStream.read API methods has been speed up by
removing encoding and decoding operations when passing string data
through XWalk
[Verification] TCT pass rate is 100%
Automated tests has been run:
tct-archive-tizen-tests
tct-systeminfo-tizen-tests
tct-content-tizen-tests
tct-filesystem-tizen-tests
FilesystemInstance::FileRead method was unused and because of that has
been removed.
Change-Id: Ifa48e73f8b795969b584c362de3744fe774e9501
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Piotr Kosko [Fri, 8 Dec 2017 07:09:12 +0000 (16:09 +0900)]
[version] 2.12
Change-Id: I55a1a98894acfed37f0524afdb3844684d1fbc3b
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Lukasz Bardeli [Thu, 7 Dec 2017 12:09:10 +0000 (13:09 +0100)]
[Iotcon] fix for crash while finding resource
Fix for crash when ResourceFoundCallback is called first time with TIMEOUT
and second time with proper value. Now data is deleted 10 seconds after
time when device stopped finding resources
[Verification] Code compiles without error. TCT tests 100% passrate
Change-Id: I3320a70dabddbbb1b5ff8fcc0161dbe1ffc23b95
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Piotr Kosko [Wed, 6 Dec 2017 11:53:38 +0000 (12:53 +0100)]
[version] 2.11
Change-Id: Ice6548513ef6a67b213c1c33ae92f7f6c3e601c0
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 6 Dec 2017 11:39:32 +0000 (11:39 +0000)]
Merge "[Bluetooth] Fix bug with ConnectStateChangeListener" into tizen_3.0
Michal Bistyga [Mon, 27 Nov 2017 13:20:25 +0000 (14:20 +0100)]
[Bluetooth] Fix bug with ConnectStateChangeListener
ConnectStateChangeListener's onConnected callback has been called even when connection failed.
[Verification] 1) automatic bluetooth tests have pass rate 100%
2) All manual tests related to add*/removeConnectStateChangeListener functions passed.
Change-Id: Ic765cc6710c64f82132c96f4b76edcd62bc69305
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Lukasz Bardeli [Wed, 6 Dec 2017 09:25:21 +0000 (09:25 +0000)]
Merge "[Application] Killing and launching moved to main thread" into tizen_3.0
Piotr Kosko [Wed, 6 Dec 2017 09:08:32 +0000 (09:08 +0000)]
Merge "[Package] Fix SVACE issue - memory leak" into tizen_3.0
Piotr Kosko [Wed, 6 Dec 2017 08:57:40 +0000 (09:57 +0100)]
[Package] Fix SVACE issue - memory leak
[Fix] pkg_info is now destroyed properly
[Verification] TCT auto and manual 100% passrate
Change-Id: I2918fd9eeb85d1ca983f0770af6371f0a1f8a16b
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Rafal Walczyna [Tue, 5 Dec 2017 12:39:17 +0000 (13:39 +0100)]
[Application] Killing and launching moved to main thread
Because of the fact that appfw APIs are not thread safe
some functions need to be called from main thread
[Verification] 100% passrate on TM1:
tct-appcontrol-tizen-tests
tct-application-tizen-tests
Change-Id: I092cc84e2ac244cfd6439566c3c65a5e2652813c
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Lukasz Bardeli [Mon, 4 Dec 2017 14:49:52 +0000 (15:49 +0100)]
[Iotcon] Fix preventing crash.
Fix with adding id to vector to hold information about possible remote resources.
If id is present in vector then map with remote resources is checked if
pointer exist. If not then callback is ignored
[Verification] Tested in chrome console. TCT auto tests 100%
Change-Id: I2032e0c8c93846ef84ac871944bbf326b8eafac7
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Piotr Kosko [Fri, 1 Dec 2017 11:29:00 +0000 (12:29 +0100)]
[version] 2.10
Change-Id: I8bb24470539accbf96eb383ebe4ae521b11f3908
Pawel Kaczmarczyk [Thu, 30 Nov 2017 14:03:33 +0000 (15:03 +0100)]
[Messaging] Fix problem with adding drafts
[Bug] Managers were created in wrong order.
MessagingManager calls registerStatusCallback on
ShortMsgManager, so ShortMsgManager has to be
created before.
[Verification] 100% passrate (with re-run)
tct-messaging-email-tizen-tests
tct-messaging-sms-tizen-tests
tct-messaging-mms-tizen-tests
change-Id: Ia4e4b1771f40e60a4f5ef4fcd6f3c5f420637546
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@partner.samsung.com>
Piotr Kosko [Wed, 22 Nov 2017 13:48:04 +0000 (14:48 +0100)]
[version] 2.09
Change-Id: I53fba98b16652feeabc5285b0bfba978767c2350
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Pawel Kaczmarczyk [Mon, 20 Nov 2017 10:39:32 +0000 (11:39 +0100)]
[Messaging] Refactor singleton managers into instance's fields
to prevent crash
Callback could be called even after MessagingInstance
object was destroyed.
[Verification] Passrate didn't change
Change-Id: I3ac0db270f9f7a07613a9bd53e18f3b954952944
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@partner.samsung.com>
Piotr Kosko [Fri, 17 Nov 2017 10:14:10 +0000 (11:14 +0100)]
[version] 2.08
Change-Id: Ic0dd5f3b4fb5f004f3b3f7d993bbae2761f84392
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Rafal Walczyna [Mon, 23 Oct 2017 13:19:47 +0000 (15:19 +0200)]
[humanactivitymonitor] Fix generating query for recording
[Verification] 100% passrate on TW1
Before fix function readRecorderData() returned only one value,
now it returns multiple values - as expected
Change-Id: I2d0de2633e2e7fd55aa6f04aadad4a0fb3569d4a
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Wed, 8 Nov 2017 07:20:25 +0000 (08:20 +0100)]
[version] 2.07
Change-Id: Ia8d9706056bab38aabd9d5cda41980b8bd527b33
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 8 Nov 2017 07:10:25 +0000 (07:10 +0000)]
Merge "[Documentation] Add license information for tools in doc" into tizen_3.0
Jakub Skowron [Tue, 7 Nov 2017 17:28:52 +0000 (18:28 +0100)]
[Documentation] Add license information for tools in doc
Some parts of automatically generated documentation was missing
license information.
Change-Id: I1df6f3145050800d5fbd6babcc5234bd76128d6b
Jakub Skowron [Mon, 6 Nov 2017 13:36:22 +0000 (14:36 +0100)]
[Documentation] Remove unnecessary file logo.png
This is a logo for documentation generator. Not used in documentation
Change-Id: I508793c952bd35ede3ec95b31e6876f942f2dab5
Piotr Kosko [Tue, 7 Nov 2017 07:16:29 +0000 (07:16 +0000)]
Merge "[Exif] remove unnecessary semicolon" into tizen_3.0
Lukasz Bardeli [Tue, 7 Nov 2017 07:14:13 +0000 (08:14 +0100)]
[Exif] remove unnecessary semicolon
Change-Id: If8ad91e6faf4be242067278b611d260b5d967e84
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Piotr Kosko [Mon, 6 Nov 2017 09:02:08 +0000 (09:02 +0000)]
Merge "[version] 2.06" into tizen_3.0
Piotr Kosko [Mon, 6 Nov 2017 09:01:24 +0000 (10:01 +0100)]
[version] 2.06
Change-Id: I6076c3c5b8269e4c27b7cdcb1f4437f36e5821a5
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Mon, 6 Nov 2017 07:53:22 +0000 (07:53 +0000)]
Merge "[Tools] Added scripts for code style validation and auto fixing" into tizen_3.0
Piotr Kosko [Fri, 3 Nov 2017 11:24:16 +0000 (11:24 +0000)]
Merge "[Logger] Removing warning from code analysis" into tizen_3.0
Michal Bistyga [Thu, 2 Nov 2017 13:59:11 +0000 (14:59 +0100)]
[Logger] Removing warning from code analysis
[Verification] Code compiles, random packages pass their tests
Change-Id: Ibfa0053c23faa5b4b6a1e49da633289719af1bd7
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Piotr Kosko [Fri, 3 Nov 2017 10:33:47 +0000 (10:33 +0000)]
Merge "[Content] Crash in CreateThumbnail fixed" into tizen_3.0
Rafal Walczyna [Thu, 2 Nov 2017 14:08:00 +0000 (15:08 +0100)]
[Content] Crash in CreateThumbnail fixed
[verification] 100% passrate on TM1 target and emulator
Change-Id: Ia2f8fe4ab6996ba872573235cfccc600282cc8f0
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Pawel Kaczmarczyk [Tue, 31 Oct 2017 12:53:47 +0000 (13:53 +0100)]
[Callhistory] Fix for find method
[Bug] LoadPhoneNumbers must be called before FindThread.
Because of critical section of LoadPhoneNumbers lasts for
whole scope, so they can be called sequentially.
[Verification] Passrate 100%
Change-Id: I8207f488f0f4926d70d2289d42b1a46d2b98ee75
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@partner.samsung.com>
Szymon Jastrzebski [Mon, 18 Sep 2017 09:30:34 +0000 (11:30 +0200)]
[PROJECT] Refactoring entering logs into ScopeLogger
Removing logs in trivial function and adding when they are missed will be part of another commit
PS2 Rebase
PS3 Change some left Loggers
PS4 After using clang
PS5 Utilizing changes in ScopeLogger
PS6 Cleaning up
PS8 Adding missing logs - not formatted
PS9 Clang
PS10 Rebase
[Verification] Code compiles
10 random packages has 100% passrate:
alarm, systemsetting, systeminfo, security, content, filesystem, iotcon,
push, capability, privillege
Change-Id: I7972fee44dd13277d9ef7693433aad7b0321dd68
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Piotr Kosko [Mon, 9 Oct 2017 11:57:35 +0000 (13:57 +0200)]
[Tools] Added scripts for code style validation and auto fixing
[Feature] Added below scripts:
- tools/codestyle/code_formatter.sh - common formatter for both C and JS
(changes files)
- tools/codestyle/code_validation.sh - common validator for both C and JS
(does not change files)
- tools/codestyle/c++_clang_formatter.sh - for auto formating C++ files
- tools/codestyle/js_clang_formatter.sh - for auto formating JS files
- tools/codestyle/cpplint_tizen_160919.py and tools/codestyle/cpplint_tizen_dir.sh
scripts for C++ code style validation, provided by HQ
- tools/codestyle/eslint_config_mandatory_length90.js - coding rules for
JS sources validation - provided by HQ
- code_format and code_validate - links to scripts for easier access
[Help] You can check usage for code_format and code_validate using '-h' option
[Verification] Checked manually. Analysis seem to be done properly.
Since now, we should reformat new code using:
./code_format -c <path/to/changed/module>
and validate:
./code_validate -c <path/to/changed/module>
Using scripts for JS sources is not recommended for now.
Change-Id: I4af01a1f23c93547cd140ba7e5fed6294726c161
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 4 Oct 2017 07:45:45 +0000 (09:45 +0200)]
[Sensor] Fixed some bugs
[Bug]
- listener interval in case of multiple setListener calls was not updated
- start/stop/setListener/unsetListener was not protected against multithread access
- different behaviour in below scenarios:
a.> HRMrawsensor = tizen.sensorservice.getDefaultSensor("HRM_RAW");
> HRMrawsensor.stop()
undefined /// nothing happen
b.> HRMrawsensor = tizen.sensorservice.getDefaultSensor("HRM_RAW");
> HRMrawsensor.start(function(s){console.log(s)}, function(s){console.log(s)})
WebAPIException {code: 9, name: "NotSupportedError", message: "None HRM LED sensor is supported."}
> HRMrawsensor.stop()
Uncaught WebAPIException {code: 9, name: "NotSupportedError", message: "None HRM LED sensor is supported."}
[Verification] Manual and Auto TCT passed 100% (s.jastrzebsk)
Change-Id: I4862823f84fc386d05eabfeb3dabb7345e9c592c
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Wed, 18 Oct 2017 11:27:07 +0000 (13:27 +0200)]
[version] 2.05
Change-Id: I26e4d40ed0d09cbcf4c55f1c0e19082d3c6c6262
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Lukasz Bardeli [Tue, 17 Oct 2017 09:38:26 +0000 (11:38 +0200)]
[Iotcon] fix to prevent crash.
Store data in vector and check in every call
RemoteResourceResponseCallback if wasn't free earlier.
[Verification] Code compiles without errors. TCT passrate 100%
Change-Id: Ia3feb69460de99a0ad70915ae4b7098980fecb91
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Piotr Kosko [Wed, 11 Oct 2017 09:43:14 +0000 (11:43 +0200)]
[version] 2.04
Change-Id: Ica388eef8319574e89f2c0c7f586d8a1f7ef0f98
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 3 Oct 2017 06:29:50 +0000 (08:29 +0200)]
[Download] Added information about HTTP status in error message
[Feature] Error message of onfailed callback of start method, return only
Unknown error. Now information about HTTP status was added into message.
[Verification] Checked in chrome console.
TCT passrate - 100%.
Change-Id: I157053d10a1e770c070b55465f1a7351c0c80cce
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 11 Oct 2017 09:41:37 +0000 (11:41 +0200)]
Revert "[version] 2.04"
This reverts commit
89b277b80e408f1527ce145e9cb79a4a128f6b5f.
Change-Id: I9aac524a3b19a54c92a30436a77f4ed5dcff0d26
Piotr Kosko [Wed, 11 Oct 2017 09:27:55 +0000 (11:27 +0200)]
[version] 2.04
Change-Id: Ieae2c1837b41a866fa3288270b674305b643a9c7
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 11 Oct 2017 09:21:48 +0000 (11:21 +0200)]
Revert "[Iotcon] Prevent posible crash."
This reverts commit
7d553b6906feb5205c93da6e3ed0428a3d2c1edd.
Change-Id: I42eec0d4ce0f24dea8895aed3a8bbda4ca1d6426
Piotr Kosko [Thu, 5 Oct 2017 09:53:02 +0000 (09:53 +0000)]
Merge "[Iotcon] Prevent posible crash." into tizen_3.0
Lukasz Bardeli [Thu, 5 Oct 2017 09:12:24 +0000 (11:12 +0200)]
[Iotcon] Prevent posible crash.
[Feature] If Timeout was returned then it is possible to call
RemoteResourceResponseCallback again.
In this case data is deleted, but not set to null.
Call data->fun causes crash.
[Verification] Code compiles without error. Auto tests 100% passrate.
Change-Id: I07a3d1e38c933506620184f811b571d60e4b59fd
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Michal Bistyga [Wed, 4 Oct 2017 11:01:35 +0000 (13:01 +0200)]
[Common] Upgrading ScopeLogger
Changes:
- Extra argument to entering logs is not written at the end of scope
Change-Id: Id8824d5a91df54c9cb97f02b501e0da8f49852a2
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Piotr Kosko [Wed, 27 Sep 2017 10:56:29 +0000 (12:56 +0200)]
[version] 2.03
Change-Id: I940a2aa78782ddcba3c5031442d8821f9c932c8a
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Szymon Jastrzebski [Mon, 25 Sep 2017 09:28:02 +0000 (11:28 +0200)]
[Convergence] Removing Convergence API
segwon.han has requested to remove Convergence API.
Code compiles.
Change-Id: I89ab9f753de111277e444ca1b659ce301a13ae1a
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Mon, 25 Sep 2017 12:54:56 +0000 (14:54 +0200)]
[PROJECT][C++] Reformatting the whole project
The refactoring was requested by yj99.shin.
With this change, the cpplint does not find any more errors.
The change has been applied to C++ files only.
[Verification] Code compiles.
Change-Id: I03534fa2140a98b78099c78a1a915f9917c3927d
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Mon, 25 Sep 2017 12:14:23 +0000 (14:14 +0200)]
[Utils] Fixing typo
Change-Id: I853c37c6f0ba6039ed1bce64b61bab86f0aa962e
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Thu, 21 Sep 2017 10:13:10 +0000 (12:13 +0200)]
[Sensor] fixing listener behaviours
[Bug] Listeners are not called in deterministic way,
several "api calls order" issues are fixed.
[Verification] Code compiles properly
TCT passrate 100% - auto & manual
Web widget service tests of sensor - 119 pass - 100% passrate
Change-Id: I720e23e0f23a9a849fb2d507e8721f196578ac48
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 20 Sep 2017 07:40:40 +0000 (07:40 +0000)]
Merge "[Download] Checking if device is connected before" into tizen_3.0
Piotr Kosko [Wed, 20 Sep 2017 05:07:18 +0000 (07:07 +0200)]
[version] 2.02
Change-Id: I80ac163b28617a3aa31400acd7042f57fdc06af2
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Michal Bistyga [Fri, 15 Sep 2017 09:46:00 +0000 (11:46 +0200)]
[Download] Checking if device is connected before
When wi-fi has been disconnected, plugins would throw not intuitive error description.
It was especially important on XU3, where short disconnect occurs more often.
[Verification] 100% TCT pass rate on TM1
Change-Id: I22712dd8e815ac810b8fec5549c370e91498ed85
Signed-off-by: Michal Bistyga <m.bistyga@samsung.com>
Piotr Kosko [Tue, 19 Sep 2017 11:42:31 +0000 (11:42 +0000)]
Merge "[Sensor] Not using ECMAScript6 code" into tizen_3.0
Piotr Kosko [Tue, 19 Sep 2017 11:06:47 +0000 (13:06 +0200)]
[Sensor] Not using ECMAScript6 code
[Bug] Web Widget Engine does not support ECMAScript6,
so it is needed to workaround internal code which used it.
[Verification] Code compiles without errors.
TCT passrate of sensors is 100%.
Some Web Widget tests passed without error.
Change-Id: I2110b35ce0ed9a4a8e3660b9c77b2a687585063f
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Szymon Jastrzebski [Tue, 19 Sep 2017 11:03:20 +0000 (13:03 +0200)]
[MediaController] Fixing typo
Change-Id: Iff3d210bafb9bbf98c44511910c38f6ffc0c266d
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Tue, 19 Sep 2017 08:18:10 +0000 (10:18 +0200)]
[MediaControler] Adding missing enum mapping
Native API uses MC_SERVER_STATE_NONE, which must be mapped to 'INACTIVE'
Web API enum. The 'NONE' state is the default state for native MC server.
[Verification] Code compiles, MC TCT passed 100%.
Change-Id: Ida2acbad265dfa7b9a91d79e64e90bccb6632e56
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Fri, 15 Sep 2017 09:41:15 +0000 (11:41 +0200)]
[NBS] Removing unnecessary code
[Verification] Code compiles. TCT NBS 100%
Change-Id: Ibeb40bcf0f22f6765ca4e92464dc57373d07fbb4
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>