Bowon Ryu [Mon, 18 Jun 2018 11:29:57 +0000 (20:29 +0900)]
elm_toolbar: fix icon sizing issue
icon size * scale - this causes the issue.
this is not wrong,
but Tizen UX did not consider scale to icon size.
so, this is removed for compatibility.
@tizen_fix
Change-Id: Ib71ec1998767988bc7ad39299c3282132f8a0fd5
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Jaehyun Cho [Tue, 19 Jun 2018 06:41:49 +0000 (15:41 +0900)]
elm_slider: do not clip indicator to slider
By calling evas_object_smart_member_add(), indicator is clipped to slider.
To keep backward compatibility, indicator should not be clipped to slider.
Change-Id: I2028b5edb8b6ce911d83771480ad18f9bf803a41
Mike Blumenkrantz [Wed, 7 Feb 2018 16:50:57 +0000 (11:50 -0500)]
ecore: fix event flushing to not erase+leak events
stealing the message data here prevents events which aren't being flushed from
ever being usable again and is unnecessary since the free callback will be
automatically called during the destructor
ref
5dd52fd09b7d79c70b3134423a87aa6400a2d994
Change-Id: I981b597e42e47c5d94e6d009e241da4d7aec09d3
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
Derek Foreman [Mon, 18 Jun 2018 20:12:41 +0000 (15:12 -0500)]
evas_cpu: Avoid SIGILL in evas startup on x86
Summary:
To determine if a system supports SIMD instructions, the cpuid facility
should be used. However, for 15+ years EFL has been trapping SIGILL,
then attempting to execute these intstructions.
Continuing after SIGILL is explicitly undefined behaviour and can never
safely be relied upon - it is possible the CPU will respond to the
unknown instruction in an upredictable way and the program will not
continue correctly. Even if it hasn't caused problems before, there's
no reason to believe a processor released in the future won't behave
differently.
Lately we've had a couple of bug tickets where SIGILL appears to cause
problems at a system level as well, but there seems little point in
chasing those problems down as we shouldn't even be doing this in the
first place.
ref T6711
ref T6989
We still rely on SIGILL in a few configurations where eina_cpu doesn't
know how to query features properly (powerpc, sparc, and non linux
ARM configurations). Hopefully someone with expertise on those
platforms can follow up and we can remove this entirely.
Note: MMX2 appears to not really be a thing, and is instead provided by
both 3DNow! and SSE. We already conflate it with SSE in other parts of
evas, so I've just used SSE here to test for its presence.
Depends on D6313
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T6989, T6711
Differential Revision: https://phab.enlightenment.org/D6314
Derek Foreman [Mon, 18 Jun 2018 20:12:36 +0000 (15:12 -0500)]
evas_cpu: Refactor checks that use eina_cpu_features_get
Summary: Minor code simplification.
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6313
Felipe Magno de Almeida [Mon, 18 Jun 2018 17:49:43 +0000 (14:49 -0300)]
eo: Fix internal reference count wrongly 0 when constructor returns a different object
The class's Eo constructor can return a different object, which makes
the efl_add return that object instead. However, a bug was not
initializing the internal reference count when a different object was
returned.
Marcel Hollerbach [Mon, 18 Jun 2018 13:54:26 +0000 (15:54 +0200)]
Revert "eina debug - fix segv if an app is compiled with -pg for profiling"
This reverts commit
8343de6ce3163f27257d386fb212d1eacf78ba7d.
This borke mac os build, CI is spamming on irc channels and addtional
tests are failing. I would give this back to the drawingboard.
ref T7029
Differential Revision: https://phab.enlightenment.org/D6310
Marcel Hollerbach [Mon, 18 Jun 2018 10:45:12 +0000 (12:45 +0200)]
ecore_con: fix possible segfault
with -O3 i get a segfault in this test. (with gcc and clang)
It looks like the compilers are doing constant folding because we
declared the struct as constant, however, due to using the address of
the fild the keyword const is simply not true, thus we are getting a
segfault because the address returned by &desc is not correct anymore,
due to the fact the constants are rolled out.
Differential Revision: https://phab.enlightenment.org/D6309
Mike Blumenkrantz [Tue, 12 Jun 2018 23:20:21 +0000 (19:20 -0400)]
tests: wrap critical errors to disable aborting in eo tests
ref T7002
Differential Revision: https://phab.enlightenment.org/D6271
Mike Blumenkrantz [Tue, 12 Jun 2018 22:37:15 +0000 (18:37 -0400)]
tests: disable eo test timeouts when not forked
this makes debugging much easier
Differential Revision: https://phab.enlightenment.org/D6270
Mike Blumenkrantz [Tue, 12 Jun 2018 20:57:48 +0000 (16:57 -0400)]
tests: add macros to selectively disable aborting on critical log messages
in many cases, a test will intentionally trigger an error to verify that it
is handled correctly. when the test is manually run with EINA_LOG_ABORT set,
this may cause the test to abort, preventing further debugging. by wrapping
intentional cases where critical errors are triggered, debugging tests
becomes easier
ref T7002
Differential Revision: https://phab.enlightenment.org/D6269
Carsten Haitzler (Rasterman) [Mon, 18 Jun 2018 03:05:03 +0000 (12:05 +0900)]
emotion - emotion_test - dont limit fps to 30 as this doesn't help tests
so i noticed it was jerky... to move/resize the video obj. it's
because it set fps to 30... well that was silly. didn't help chasing a
ghost, so remove this to avoid chasing hosts.
Carsten Haitzler (Rasterman) [Mon, 18 Jun 2018 02:51:21 +0000 (11:51 +0900)]
eina debug - fix segv if an app is compiled with -pg for profiling
gprof uses SIGPROF ... and this causes all sorts of bad things with
the eina debug profiling too. so - use SIGRT instead ... fixes T7028
Jihoon Kim [Sun, 17 Jun 2018 23:45:29 +0000 (08:45 +0900)]
ecore_imf: Remove security_code in autofill type
Change-Id: Ice2c20358f37ecd047b6012b8a9a619b37e211df
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Sun, 17 Jun 2018 23:45:29 +0000 (08:45 +0900)]
ecore_imf: Remove security_code in autofill type
Change-Id: I7221d1bbe311da5523151c889e71585785eead26
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jaehyun Cho [Mon, 18 Jun 2018 08:48:47 +0000 (17:48 +0900)]
elm_slider: keep backward compatibility of Tizen 3.0
This commit sets indicator hidden by default for backward compatibility.
This commit restores overwritten code of
6dae707407894f16a9bd87b62cbc087695f0e868
Change-Id: I6df50a8bdfa82c442c6e6d61c319c9a512c14d66
Juyeon Lee [Fri, 15 Jun 2018 06:39:20 +0000 (15:39 +0900)]
Revert "eocre_wl2_window: unset zxdg_surface zxdg_toplevel when hide"
This reverts commit
520034511855d67b5da9d5e63b179788d581f784.
Change-Id: I94564c39f5e8c50dcd32365fdd06fe0b33d468f6
Zbigniew Kempczyński [Sun, 17 Jun 2018 06:52:48 +0000 (15:52 +0900)]
ecore - handle G_IO_ERR conditions for net sockets
Glib integration with using of select() syscall doesn't properly
propagates G_IO_ERR condition for network sockets. Problem relies in
_ecore_glib_context_poll_to() where rewriting filedescriptor events to
GPollFD structures reside.
This fixes T5725
@fix
Daniel Zaoui [Sat, 16 Jun 2018 20:14:47 +0000 (23:14 +0300)]
efl_debugd: don't force unlinking UNIX socket before binding
If two daemons are launched one after the other, we would like the
second one to exit directly. The problem is that if the UNIX socket is
unlinked before the binding, the second daemon will succeed to create this
socket, stoling it from the first daemon, and exit because the network
socket is not bindable.
It results in the first daemon to continue running and accepting
connections from the debuggers (network connection) but ignoring the
applications connection (local UNIX connection).
Mike Blumenkrantz [Fri, 15 Jun 2018 20:34:50 +0000 (16:34 -0400)]
tests: disable toggling clouseau_enabled option in elm tests
Summary:
this option triggers codepaths which require and interface with an
external project not in the EFL tree, so it should not be tested in
the efl tree
also depending on the version of clouseau used, this causes the test
suite to fail 100% of the time
fix T6985
ref T7023
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6985, T7023
Differential Revision: https://phab.enlightenment.org/D6295
Mike Blumenkrantz [Fri, 15 Jun 2018 20:34:39 +0000 (16:34 -0400)]
eet: handle decode failures as errors in variant decoding
Summary:
all other null returns of _eet_data_descriptor_decode() are treated as
fatal errors when decoding, and failure to do so in this case guarantees
errors later due to incomplete decoding
@fix
ref T5379
Depends on D6293
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T5379
Differential Revision: https://phab.enlightenment.org/D6294
Mike Blumenkrantz [Fri, 15 Jun 2018 20:34:32 +0000 (16:34 -0400)]
eet: print errors any time an error occurs while decoding
Summary:
catching these errors was super annoying since the codebase is mostly
comprised of goto statements, so this should make future debugging easier
Depends on D6292
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6293
Mike Blumenkrantz [Fri, 15 Jun 2018 20:34:00 +0000 (16:34 -0400)]
eet: add #if 0 around macro which will cause compile errors if used
Summary:
this macro wraps a function which is also inside an #if 0 block,
so it's best not to leave it where someone might try to use it
no functional changes
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6292
Mike Blumenkrantz [Fri, 15 Jun 2018 19:38:49 +0000 (15:38 -0400)]
eina_lock: remove safety checks for main thread
Summary:
these effectively prevent locks from being used to synchronize operations
between (non-main) threads, which restricts their usefulness and also
prevents our own unit tests from passing
fix T7004
Depends on D6267
Reviewers: devilhorns, ManMower
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7004, T1984
Differential Revision: https://phab.enlightenment.org/D6285
Mike Blumenkrantz [Fri, 15 Jun 2018 19:38:33 +0000 (15:38 -0400)]
eina: disable abort on shutdown when triggered by system monitoring thread
Summary:
this lock/thread never gets destroyed, so it should not trigger failure cases
when that is always the case
@fix
Depends on D6266
Reviewers: stefan_schmidt, ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6267
Mike Blumenkrantz [Fri, 15 Jun 2018 19:38:20 +0000 (15:38 -0400)]
eina_lock: remove locks from eina tracking list on free while thread debugging
Summary:
this prevents invalid memory access during subsequent inlist operations
@fix
sq
Depends on D6265
Reviewers: stefan_schmidt, ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6266
Mike Blumenkrantz [Fri, 15 Jun 2018 19:37:56 +0000 (15:37 -0400)]
eina_lock: modify mutex debugging to ignore recursive locks
Summary:
recursive locks are locked multiple times in the same thread, leading to
failure with the tracking infrastructure which was written prior to
the addition of recursive locks and assumed that locks would only be
taken exactly once
given that this debug info is meant to handle non-recursive locks,
it makes little sense to include them in the handling
@fix
Depends on D6264
Reviewers: stefan_schmidt, ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6265
Derek Foreman [Fri, 15 Jun 2018 18:18:56 +0000 (13:18 -0500)]
ecore_wl2: purge surface buffers in semi_free
Summary:
This fixes a session recovery bug with software render.
An attempt to re-use a buffer in a new wayland connection resulted
in another disconnect and broken rendering.
Depends on D6281
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6282
Derek Foreman [Fri, 15 Jun 2018 18:18:52 +0000 (13:18 -0500)]
ecore_wl2: Add purge to ecore_wl2_window_surface_flush
Summary:
It's convenient to be able to pass this through this api too.
@betabreak
Depends on D6280
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6281
Derek Foreman [Fri, 15 Jun 2018 18:18:39 +0000 (13:18 -0500)]
ecore_wl2: Handle purging flush in dmabuf module
Summary:
Allow destroying all buffers, even attached ones, in the dmabuf surface
module.
Depends on D6279
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6280
Derek Foreman [Fri, 15 Jun 2018 18:18:30 +0000 (13:18 -0500)]
ecore_wl2: Add a purge option to surface flush
Summary:
We need to be able to forcibly destroy all surface buffers to make
session recovery work safely for software rendering.
@betabreak
Depends on D6278
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6279
Derek Foreman [Fri, 15 Jun 2018 18:18:15 +0000 (13:18 -0500)]
ecore_wl2: Set the parent window's surface to NULL on surface destroy
Summary:
Prevents potential use after free.
Depends on D6277
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6278
Mike Blumenkrantz [Fri, 15 Jun 2018 17:27:19 +0000 (12:27 -0500)]
edje_cc: temporarily disable aborting compile when namespace validation fails
Summary:
there are far too many issues here for me to fix them all, the authors of
these failures should be responsible for helping to clean this up
revert this patch once all issues are resolved
ref T6966
Depends on D6042
Reviewers: cedric, Hermet, stephenmhouston, devilhorns
Reviewed By: stephenmhouston
Subscribers: #committers
Tags: #efl
Maniphest Tasks: T6966
Differential Revision: https://phab.enlightenment.org/D6215
Mike Blumenkrantz [Fri, 15 Jun 2018 17:27:01 +0000 (12:27 -0500)]
build: enable namespace verification for default theme
Summary:
this will trigger a build failure if someone modifies the theme in such
a way that namespacing is not used correctly, saving some time when
reviewing larger patches which have many theme changes
ref T6911
Depends on D6036
Reviewers: cedric
Reviewed By: cedric
Subscribers: #committers
Tags: #efl
Maniphest Tasks: T6911
Differential Revision: https://phab.enlightenment.org/D6042
Mike Blumenkrantz [Fri, 15 Jun 2018 17:26:44 +0000 (12:26 -0500)]
edje_cc: add option for verifying namespace usage
Summary:
when -N is passed, parts and program signals will be checked for
traditional namespacing based on the group name, causing compile failure
if inconsistency is detected
@feature
ref T6911
Reviewers: cedric, devilhorns
Reviewed By: cedric
Subscribers: #committers
Tags: #efl
Maniphest Tasks: T6911
Differential Revision: https://phab.enlightenment.org/D6036
Mike Blumenkrantz [Fri, 15 Jun 2018 15:39:53 +0000 (11:39 -0400)]
eina_cow: rework debug profile safety checks for recursive writes
Summary:
recursive writes are not inherently bad, so long as the pointer is
consistently re-set (handled automatically by macros), and they are nearly
unavoidable in some places such as eo/evas internals
issues may arise in a specific corner case of recursive writes when a pointer
has been hashed for garbage collection, so adjust the checks to watch for this
specific case instead of crashing on every case
fix T7005
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7005
Differential Revision: https://phab.enlightenment.org/D6284
Mike Blumenkrantz [Fri, 15 Jun 2018 15:22:37 +0000 (11:22 -0400)]
Revert "evas: handle event COW modification when COW is already active"
Summary:
This reverts commit
cd6b890c7322ec67d3c41281bda3b22d4a481775.
this resolves complaints from a safety check in the debug profile,
but it seems more likely that the safety check is bogus and should be
removed rather than making this code more complex
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6283
Mike Blumenkrantz [Fri, 15 Jun 2018 15:21:43 +0000 (11:21 -0400)]
eina_lock: do not set PTHREAD_MUTEX_ERRORCHECK on recursive locks
Summary:
a mutex can only have one type, so setting this type onto a recursive mutex
will unset the recursive attribute and cause deadlocks
ref T1984
@fix
Reviewers: stefan_schmidt, ManMower, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T1984
Differential Revision: https://phab.enlightenment.org/D6264
Alastair Poole [Fri, 15 Jun 2018 09:42:54 +0000 (10:42 +0100)]
efreet: make efreet_menu_async_get() deprecated.
Marking deprecated. Func will warn and instantly return on
call.
Daniel Zaoui [Fri, 15 Jun 2018 07:10:38 +0000 (10:10 +0300)]
Clouseau: use the config flag only for the old Clouseau
Lukasz Stanislawski [Wed, 6 Jun 2018 09:37:26 +0000 (11:37 +0200)]
elm: remove access_type set API
The api was initially designed to skip objects in accessibility
hierarchy, however it was later replaced with usage of
REDUNDANT_OBJECT role on accessibility object.
Remove this api as it is unused, it obfuscates code even more
and may cause other problems.
Change-Id: I3202ee73ccf545e79d509d3b00569db896d4f975
Jiyoun Park [Thu, 14 Jun 2018 17:47:05 +0000 (02:47 +0900)]
ecore_wl2: change not to render after hide.
show->hide-> configure_cb state case, efl client deals the code like show state.
but efl client already changed into invisible state.
so menual_render_set cdoe should not run.
we will change manual render set code to draw_block code.
Change-Id: Id83a995567dc4c4da7a54366bf6ece97e16d2429
Signed-off-by: Jiyoun Park <jy0703.park@samsung.com>
Juyeon Lee [Tue, 12 Jun 2018 09:53:06 +0000 (18:53 +0900)]
eocre_wl2_window: unset zxdg_surface zxdg_toplevel when hide
ecore_wl2_window_show creates shell surface and its role
eocre_wl2_window_hide destroys them in pair
so, display server know explicit show /hide condition
as a result server would not map a client which attach buffer in background
if client destroyed its shell surface.
@tizen_fix
Change-Id: Idd5a671b69497936c59455b46eaeb1131565b784
Marcel Hollerbach [Thu, 14 Jun 2018 19:23:28 +0000 (14:23 -0500)]
evas: make objects again delete correctly
Summary:
what here was done was fundamentally wrong, deleting the pd->object
field of a evas object after a efl_del / evas_object_del is completly
wrong. evas object lifetimes are controller with eo_manual_free, this
means, they are still alive, even after you called evas_object_del on
them. removing pd->object results in eo_menual_free calls to NULL
objects and leaking the object carrying the private data. Overall,
breaking this pd->object field and unsetting it is a very bad idea, as
its the only way that evas cleansup the object correctly.
This brings down the number of ui related leaked objects on shutdowns to
0. (YEY :))
This also fixes weird error messages on app shutdown.
fixes T6964
Reviewers: devilhorns, zmike
Reviewed By: zmike
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T6964
Differential Revision: https://phab.enlightenment.org/D6290
Alastair Poole [Thu, 14 Jun 2018 18:00:22 +0000 (19:00 +0100)]
efreet: mark efreet_menu_async_parse() deprecated.
Marking deprecated, with warnning and instant return.
Disabling test code also (for now). Awaiting a fresh
implementation.
@fix T585
Hermet Park [Thu, 14 Jun 2018 16:00:53 +0000 (01:00 +0900)]
evas vg: prevent a corner-case crash.
tbh, current vg interfaces a little bit bad... here is one scenario to this
stupid case.
efl_parent_set() and evas_object_vg_root_node_set() both do re-parent
job. They could be conflicted if user calls both apis in either way.
efl_parent_set(root_node, NULL); but Vg Object still keeps the root node
which is just a dangling pointer that occurs a crash while rendering.
Xavi Artigas [Thu, 14 Jun 2018 15:29:37 +0000 (11:29 -0400)]
eina: Turn stringshare printfs into EINA_LOG_DBG
Summary:
eina_share_common contained extremely verbose printfs which rendered
the debug profile (./configure --with-profile=debug) almost unusable.
They have been turned into EINA_LOG_DBG in the eina_stringshare log domain
(when related to stringshares) and without domain when related to other
eina_share facilities.
Also, cleaned up some printfs which have been commented out for 8 years.
Fixes T7006
Test Plan:
The printfs are regular eina logs and can be filtered out by regular means.
The debug profile output is far more usable now.
Reviewers: zmike, devilhorns
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7006
Differential Revision: https://phab.enlightenment.org/D6288
Hermet Park [Thu, 14 Jun 2018 14:28:48 +0000 (23:28 +0900)]
evas vg: code refactoring.
No logic changes.
I know this is not a good case in alpha freeze.
but code was too dirty, need more polishing.
Alastair Poole [Thu, 14 Jun 2018 13:22:09 +0000 (14:22 +0100)]
examples: fix build on FreeBSD.
Missing header for AF_INET/6. Another small
difference between BSD and Linux et al.
Hermet Park [Thu, 14 Jun 2018 13:08:14 +0000 (22:08 +0900)]
evas vg: fix another memory leak
@fix
JunsuChoi [Thu, 14 Jun 2018 12:55:50 +0000 (08:55 -0400)]
elm_datetime, efl_ui_clock : Add check 'legacy widget' for layout signal emission
Summary:
08a11d, Signal name is changed to efl ui signal name
legacy widget should use elm
This commit resolves T6928
#efl, #regression
Test Plan: elementary_test -to datetime
Reviewers: JackDanielZ, Jaehyun_Cho, Hermet, YOhoho, devilhorns, zmike
Reviewed By: zmike
Subscribers: YOhoho, cedric, Hermet, Jaehyun_Cho, #committers, JackDanielZ, zmike
Tags: #efl
Maniphest Tasks: T6928
Differential Revision: https://phab.enlightenment.org/D6289
Hermet Park [Thu, 14 Jun 2018 11:30:28 +0000 (20:30 +0900)]
evas example: removed unnecessary calls for vg shapes.
Hermet Park [Thu, 14 Jun 2018 11:23:51 +0000 (20:23 +0900)]
efl interface: remove weired implementation.
This color interpolation should not a part of efl_gfx_shape.
Color should be interpolated by Vg.Node which implements Efl.Gfx.Color.
Hermet Park [Thu, 14 Jun 2018 10:51:13 +0000 (19:51 +0900)]
evas vg: fix broken morphing(interpolation)
efl_gfx_path itself took care of efl_gfx_shape data but its heirarchy was
conceptually wrong. Even efl_gfx_shape is mixing the efl_gfx_path...
Damend design...
Some of derived classes of efl_gfx_path (i.e. Vg.Node and Vg.Container) are
none of the Path acutally. They are just mixing Path's interpolation interface.
So, Here patch changes VG.Node to stop calling the super's interpolate method
and Vg.Shape to call both super -gfx_shape and vg_node- interpolate method.
@fix T6996
Jongmin Lee [Fri, 15 Jun 2018 02:04:25 +0000 (11:04 +0900)]
Revert "elm_entry: add elm_entry_prediction_hint_hash_set/del API"
This reverts commit
432f5de7d3537b9a17806124b4bf76c1754f29c7.
Lukasz Wlazly [Tue, 12 Jun 2018 13:14:13 +0000 (15:14 +0200)]
Remove highlight after disabling screen-reader
Change-Id: I0363ee5c64682d8b6ca6994f74a5dfdaf4c4fd97
Jaehyun Cho [Mon, 11 Jun 2018 11:11:42 +0000 (20:11 +0900)]
elm_spinner: Fix typo
Change-Id: Ife0fd94116220b0f91e64d6ba23e9f42a024c00b
Lukasz Wlazly [Thu, 7 Jun 2018 09:55:47 +0000 (11:55 +0200)]
[a11y] Add null check before calling highlight_hide
While navigating through homescreen segfaults appeared.
Change-Id: I7d1cb807e4e02781501c00a3a644cc8a64cd84fe
Wonsik Jung [Fri, 8 Jun 2018 05:55:17 +0000 (14:55 +0900)]
[EvasGL] fix the crash issue about egl_fence_sync
fix the crash issue about evas gl and egl_fence_sync
After upgrading efl 1.20, native_bind_cb function interface was changed.
To support, native struct has outbuf.
Change-Id: I2ffc10671d716ee478f0589bd2309efb62aed913
Sunghyun kim [Thu, 7 Jun 2018 10:29:27 +0000 (19:29 +0900)]
evasgl: add EVAS_GL_EGL_SYNC_ON feature
Change-Id: Ie852064783b295a1a8ea5d4b3752f61784328f81
Signed-off-by: Sunghyun kim <scholb.kim@samsung.com>
Shinwoo Kim [Wed, 30 May 2018 06:29:38 +0000 (15:29 +0900)]
efl_ui_win: keep default geometry compatibility
The efl_ui_win default geometry had been 0,0,1,1 till Tizen 4.0.
The efl_ui_win needs to keep backward compatibility of default geometry.
Because the MM API, player_set_display returns if the window size is 0x0.
So mycontents-video-player-tv could not play video file.
@tizen_only
Change-Id: I531b9950f2d52fab18464812701d3a5b2b3e5c35
Jihoon Kim [Wed, 23 May 2018 02:56:35 +0000 (11:56 +0900)]
elm_entry: add elm_entry_prediction_hint_hash_set/del API
elm_entry_prediction_hint_hash_set API sets the prediction hint data at the specified key, and
elm_entry_prediction_hint_hash_del API is for deleting the prediction hint data identified by a key.
@feature
Change-Id: I613d1a923f96ce261a7b809b749a97e68acc94ff
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Joogab Yun [Fri, 11 May 2018 09:20:08 +0000 (18:20 +0900)]
evas : Modified tbm_queue to use one per surface.
Change-Id: I7b148980a61ce1c06b3aea1a2626315270f0aa9c
Joogab Yun [Thu, 17 May 2018 02:14:37 +0000 (11:14 +0900)]
evas : fixed bug for EVAS_NATIVE_SURFACE_TBM
[NativeTBMSurface] Seperated by colorspace.
To create RGBA_Image for NativeTBMSurface, the related code is
seperated by tbm format.
So, Getting format internal function is added and seperated the
code.
[NativeTBMSurface] Add _evas_native_tbm_init/shutdown
Add _evas_native_tbm_inti/shutdown to evas_native_tbm.c
In addition, one more patch is added to fix stride mismatch
and allocate image data for converting from yuv to rgb.
This patchset are oriented by JP's and Minkyung patch
---------------------------------------------------------------------------------
Author: Jean-Philippe Andre <jp.andre@samsung.com> 2016-03-09
16:18:34
Committer: Jean-Philippe Andre <jp.andre@samsung.com> 2016-03-15
11:11:59
Evas engines: Add internal functions for native images
----------------------------------------------------------------------------------
Author: Minkyoung Kim <mer.kim@samsung.com> 2016-03-31 15:55:15
Committer: Jean-Philippe Andre <jp.andre@samsung.com> 2016-04-01
12:09:06
evas : remove native.func.data variable and data argument of
native calblacks.
Change-Id: I9517c4c802f1fbb9799eb920a33359dcfacea7ec
Joogab Yun [Mon, 4 Jun 2018 04:44:16 +0000 (13:44 +0900)]
evas : add ecore_evas_tbm_surface_get and ecore_evas_tbm_stride_get api for ecore_evas_tbm
Change-Id: Ifac62b4b20a5804d147a53731f06931be3891b0b
Daekwang Ryu [Fri, 11 May 2018 09:51:59 +0000 (18:51 +0900)]
evas_gl: remove GL_VERSION wrapper
because some drivers return a context of later version not specified version.
Change-Id: I4fc4567ccdefd63f422812d1f7461d13e1e547b3
Doyoun Kang [Mon, 14 May 2018 07:22:46 +0000 (16:22 +0900)]
ecore_wl2: fix bug for sending configure event by client
The position(x,y) value of Ecore_Wl2_Event_Window_Configure event was wrong
while sending ECORE_WL2_EVENT_WINDOW_CONFIGURE event in _ecore_wl2_window_configure_send_by_client.
@tizen_fix
Change-Id: Ic377fd8846b42b07faa63d0cda0f285033570fbd
Doyoun Kang [Mon, 14 May 2018 07:17:43 +0000 (16:17 +0900)]
ecore_evas: support to rotate window which does not have shell surface
There was a bug that the window which doesn't create shell surface such as ime keyboard didn't rotate.
This patch fixes it.
@tizen_fix
Change-Id: I7f7304ae07f43e071ab8427ca606fecedf4fb846
Xavi Artigas [Wed, 13 Jun 2018 17:42:59 +0000 (13:42 -0400)]
evas: Remove unnecessary rotation when saving
Summary:
At some point this code stopped being necessary. The image data is already
rotated and width and height match it, so no need to rotate it again
(which produced warnings and incorrect behaviour)
Fixes T5841
Test Plan: This fixed examples/evas_images{2,4,5} which were failing before.
Reviewers: bu5hm4n, zmike, devilhorns
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T5841
Differential Revision: https://phab.enlightenment.org/D6259
Chris Michael [Wed, 13 Jun 2018 15:37:40 +0000 (11:37 -0400)]
elementary: Add missing EINA_UNUSED for unused function parameter
Mike Blumenkrantz [Wed, 13 Jun 2018 15:33:21 +0000 (11:33 -0400)]
evas: handle event COW modification when COW is already active
Summary:
enabling write on a COW which is already writing is a user error,
which can occur during object invalidate due to reuse of a helper function.
by adding an extra param containing the COW data, this scenario can be avoided
fix T7005
Reviewers: bu5hm4n, segfaultxavi, devilhorns
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7005
Differential Revision: https://phab.enlightenment.org/D6273
Mike Blumenkrantz [Wed, 13 Jun 2018 14:09:43 +0000 (10:09 -0400)]
eina_barrier: handle PTHREAD_BARRIER_SERIAL_THREAD return from barrier_wait
Summary:
this is a valid return code which indicates success and is passed randomly to
one of the callers
@fix
Depends on D6267
Reviewers: stefan_schmidt, ManMower, devilhorns
Reviewed By: devilhorns
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6268
Mike Blumenkrantz [Wed, 13 Jun 2018 14:09:32 +0000 (10:09 -0400)]
eo: call efl_object_class_get() during efl_object_init()
Summary:
ensure that this is always called for the first time from the
main thread to avoid triggering asserts during shutdown
ref T7003
Reviewers: bu5hm4n, devilhorns
Reviewed By: bu5hm4n
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T7003
Differential Revision: https://phab.enlightenment.org/D6272
Lauro Moura [Wed, 13 Jun 2018 14:09:16 +0000 (10:09 -0400)]
evil: Fix test compilation.
Summary:
A variable was mistakenly removed in a previous commit. (It was used
in places other than the check that was removed).
Reviewers: devilhorns, zmike, vtorri
Reviewed By: zmike, vtorri
Subscribers: cedric, #committers
Tags: #efl, #windows
Differential Revision: https://phab.enlightenment.org/D6262
Mike Blumenkrantz [Tue, 12 Jun 2018 17:57:01 +0000 (13:57 -0400)]
tests: make ecore timeout special casing dependent on check version
Summary:
tcase_name() was added in 0.11.0 (2016), which is still not widely enough
distributed to rely upon without version checks
Reviewers: stefan_schmidt, ManMower, devilhorns
Reviewed By: ManMower
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6260
Mike Blumenkrantz [Tue, 12 Jun 2018 14:52:12 +0000 (10:52 -0400)]
tests: add timeout to fixture for ecore tests
Summary:
this is mainly to handle the case of ecore-file, which fetches external
resources during the test and requires an active network connection which
may fail to resolve/connect/download during the test. if this particular test
fails then it is almost certainly a network issue
a future patch should implement some form of http server to remove the
dependency on external network resources
also probably all test suites should have timeout timers just in case
fix T6950
Depends on D6205
Reviewers: stefan_schmidt, cedric
Reviewed By: cedric
Subscribers: cedric, #committers
Tags: #efl
Maniphest Tasks: T6950
Differential Revision: https://phab.enlightenment.org/D6206
Mike Blumenkrantz [Tue, 12 Jun 2018 14:52:12 +0000 (10:52 -0400)]
tests: improve ecore timer test code
Summary:
a stack variable was incorrectly used here, along with some lazy timing
calcs which did not accurately measure the time for each timer iteration,
resulting in a test which intermittently failed in some cases
fix T6878
Reviewers: stefan_schmidt, bu5hm4n, ManMower
Reviewed By: ManMower
Subscribers: ManMower, cedric, #committers
Tags: #efl
Maniphest Tasks: T6878
Differential Revision: https://phab.enlightenment.org/D6256
Xavi Artigas [Tue, 12 Jun 2018 14:51:53 +0000 (10:51 -0400)]
evas: Fix small string leak
Summary:
sscanf("%ms", &encoding) allocates memory which must be freed.
It is done in the general case, but not if the image data map fails and the
code jumps to the no_pixels: label.
Reviewers: zmike, bu5hm4n
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6258
Alastair Poole [Tue, 12 Jun 2018 14:19:12 +0000 (15:19 +0100)]
ecore_evas: fix crash on free of smart data.
pd is NULL here, adds a check before attempt
to read from pd.
@fix T6974
Hermet Park [Tue, 12 Jun 2018 09:59:37 +0000 (18:59 +0900)]
evas vg: clean up all the duplicated children by container properly.
So, here is the first-aid, but the last patch for recovering basic vector
rendering. All vg nodes duplicated by container would be constructed without
a parent, they need to get unref() by container when container is freed.
Here code takes deal with it on the invalidation time.
Marcel Hollerbach [Tue, 12 Jun 2018 08:56:43 +0000 (10:56 +0200)]
elm_gen****: ensure the correct parent is set
fixes T6474
Marcel Hollerbach [Tue, 12 Jun 2018 08:40:38 +0000 (10:40 +0200)]
efl_ui_focus_parent_provider_gen: do not accidently flatten the widgets
in the provider we accidently flattend out the widget history by
returning the wrong parent. However, this flattening code was required
for the element focus code of the two generic widgets, so the item is
found for every widget, in every subtree.
Jaehyun Cho [Tue, 12 Jun 2018 06:40:54 +0000 (15:40 +0900)]
elm_genlist: remove duplicated smart callback description
This commit applies some missing changes of
4b4e830a64d210936e7bab231f5b196eb6bb0821.
Change-Id: I82fc818df497b5c819ecc4b7593334f06c05b7f7
Wonki Kim [Thu, 17 May 2018 03:51:44 +0000 (12:51 +0900)]
packaging: replace a symbol link of efl.manifest with the file itself
a symbol link of efl.manifest makes a problem sometimes.
this commit replaces it with the file itself.
Change-Id: I7486f1f9415a3aa5693e9acf01341f60a70e8deb
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
subhransu mohanty [Fri, 4 May 2018 01:41:35 +0000 (10:41 +0900)]
edje_cc: Fix coverity issue of acessing invalid memory.
Details: As token pointer is assined with the tmp pointer we don't need to free the tmp anymore.
Change-Id: Ib315b28ab0a776fe36971df1d2bb4d6bc35d9f15
Bowon Ryu [Wed, 9 May 2018 04:23:20 +0000 (13:23 +0900)]
edje_util: fix typo
Change-Id: I19c6698d21a0eac44c85768ed16b3d2ca846a7e0
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Hermet Park [Tue, 12 Jun 2018 02:27:51 +0000 (11:27 +0900)]
evas vg: get rid of memory leak.
alloc mem only if it didn't alloc'd yet.
@fix
Youngbok Shin [Mon, 11 Jun 2018 13:19:38 +0000 (16:19 +0300)]
edje: fix an issue "description.text.text" is not shown
Summary:
"description.text.text" is not shown after applying a patch for
supporting text translation of Textblock part.
@fix T6997
Test Plan:
- Try to show a TEXTBLOCK part which has built-in text.
ex)
textblock {
scale;
desc { "default";
text {
style: "my_style";
text: "You can't see this text without this patch";
}
}
}
Reviewers: Hermet, subodh6129, herdsman
Subscribers: cedric, #committers, zmike
Tags: #efl
Maniphest Tasks: T6997
Differential Revision: https://phab.enlightenment.org/D6257
Hermet Park [Mon, 11 Jun 2018 11:06:19 +0000 (20:06 +0900)]
evas vg: fix wrong obj deletion.
Cached roots are constructed out of canvas.
Means, they have no parents, generated efl_add_ref()
which requests to call efl_unref() instead of explicit deletion.
Daniel Kolesa [Mon, 11 Jun 2018 11:07:23 +0000 (13:07 +0200)]
eolian: silence a potentially uninitialized warning
Compiler thinks mname might be used uninitialized, which is never
the case, because cl only exists if mname has been set. It still
creates an annoying warning though, so fix that.
Hermet Park [Mon, 11 Jun 2018 07:23:28 +0000 (16:23 +0900)]
evas vg: fix broken vg rendering.
This fixes vg to connect node tree properly on copying nodes.
Vector rendering was broken when vg cache tries to reconstruct the scene-graph
tree on copying from the original cached one. Exactly, nodes lost parents on
copying. Here it fixes the lost links of the scene-graph tree.
@fix T6993
Marcel Hollerbach [Sun, 10 Jun 2018 14:30:07 +0000 (16:30 +0200)]
edje: fix edje_part_helpers refcounting
Summary:
the reference from efl_reuse was forgotten & the parent relation was not
correctlty setted, which led to the fact that NOREF was never emitted.
This caused that thte object never really was destructed probebly, and
thus the del_interceptor_cb was not executed, and the object simply
leaked.
The test checks that those properties are correctly set, additionally a
error is printed in the efl code when a part has not the expected
reference properties. This also enforces errors when users are doing
wrong things with objects returned by efl_part.
Reviewers: ManMower, zmike
Reviewed By: zmike
Subscribers: cedric, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6254
Larry Lira [Thu, 7 Jun 2018 21:50:48 +0000 (18:50 -0300)]
examples: fix efl_model parent loop add
Larry Lira [Thu, 7 Jun 2018 21:44:37 +0000 (18:44 -0300)]
elm: fix efl_model property_get and children_slice_get in views
Larry Lira [Thu, 7 Jun 2018 21:41:48 +0000 (18:41 -0300)]
Eio: fix eio_model children_slice_get all
JunsuChoi [Thu, 7 Jun 2018 14:49:42 +0000 (10:49 -0400)]
ecore_con : Fix that null pointer access for segmentation fault
Summary:
"cl->svr" was to be null on line 281.
This problem occurred from
384f30c8ecc9.
Replacing "cl->svr" with "svr" corrects the error
while preserving the changes in
384f30c8ecc9.
Test Plan: N/A
Reviewers: #committers, cedric, Hermet, zmike
Subscribers: bowonryu, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6255
Change-Id: Idaf69e4ee4be9cd4a87476a8db7d76b04f677c5f
Hermet Park [Thu, 7 Jun 2018 10:34:46 +0000 (19:34 +0900)]
edje: fix a regression error by
7fb47fc064b8f429242b4d5cdf57071475087821.
That shouldn't be touched, just confused by its name.
Hermet Park [Thu, 7 Jun 2018 10:14:30 +0000 (19:14 +0900)]
canvas vg: move a comment to right place.
no any logic changes.
Hermet Park [Thu, 7 Jun 2018 08:53:12 +0000 (17:53 +0900)]
edje: code refactoring for readibility.
collection.part is too ambigious, since group has parts as well.
Normally we regard it as "name" (of group) instead of part.
Mike Blumenkrantz [Thu, 7 Jun 2018 08:29:46 +0000 (17:29 +0900)]
edje_cc: fixup edje_collections_lookup hash ids during collection pruning
Summary:
unused groups are pruned during this stage of edje_cc, and it becomes
necessary to update the values in this hash in order to maintain the
key:value pairing between the Edje_Part_Collection_Directory_Entry and
its corresponding Edje_Part_Collection so that lookups return consistent
results after pruning has completed
@fix
Reviewers: cedric, Hermet
Reviewed By: Hermet
Subscribers: Hermet, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D6041