platform/core/connectivity/bluetooth-frwk.git
6 years agoDisable auto enable logic by bt-core 61/180161/1
DoHyun Pyun [Fri, 25 May 2018 06:56:41 +0000 (15:56 +0900)]
Disable auto enable logic by bt-core

Change-Id: Ia2ca1578bd189b8590ac6c17958810f927c8d00b
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix prevent issue 00/180000/1 accepted/tizen/unified/20180524.060223 accepted/tizen/unified/20180527.044852 submit/tizen/20180524.052210 submit/tizen/20180525.015431
Wootak Jung [Thu, 24 May 2018 04:45:09 +0000 (13:45 +0900)]
Fix prevent issue

Change-Id: I7a2f9f1bf6b19a70e40cbf80d624d55d7eab77e5

6 years agoFix prevent issues 94/179994/1
Wootak Jung [Thu, 24 May 2018 03:38:12 +0000 (12:38 +0900)]
Fix prevent issues

Change-Id: Iadec24b45ee77613553e75ef89103dd135046362

6 years agoRemove unused mashal codes 81/179981/1
DoHyun Pyun [Thu, 24 May 2018 00:04:37 +0000 (09:04 +0900)]
Remove unused mashal codes

Change-Id: If6f1199ea369bfcd6f715eb0fb21831bd3a98ff5
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoSet the smack label as '_' of the library 57/179957/1
DoHyun Pyun [Wed, 23 May 2018 12:05:17 +0000 (21:05 +0900)]
Set the smack label as '_' of the library

Change-Id: If19a9a1607739fe78a8d9f33a368d0ed84a4b39c
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix the write request functionality from GATT client 56/179956/1
DoHyun Pyun [Wed, 23 May 2018 12:04:33 +0000 (21:04 +0900)]
Fix the write request functionality from GATT client

Change-Id: I8c18e0de026ed5bde935fd8978f22daec771cc28
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agogatt client adaptation feature changes on HAL 00/179400/4
Amit Purwar [Thu, 17 May 2018 14:13:41 +0000 (19:43 +0530)]
gatt client adaptation feature changes on HAL

Change-Id: Idef21c381035f119072575ff28ebd4b07c37c780
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
6 years agogatt client adaptation feature changes bt-api bt-service OAL 01/179401/5
Amit Purwar [Thu, 17 May 2018 14:17:51 +0000 (19:47 +0530)]
gatt client adaptation feature changes bt-api bt-service OAL

Change-Id: If19155c4dc6aaa6367094a02a346d949d29be183
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
6 years agoFix wrong expression in dbus policy 43/179643/1
Wootak Jung [Mon, 21 May 2018 01:23:06 +0000 (10:23 +0900)]
Fix wrong expression in dbus policy

Change-Id: Ibc5d72822c721a0ffe4536e3eb8624ccaa9d60d9

6 years agoAllow the dbus method call for bluetooth.admin privilege app 43/179343/1 accepted/tizen/unified/20180518.060634 submit/tizen/20180517.230415
DoHyun Pyun [Thu, 17 May 2018 07:34:15 +0000 (16:34 +0900)]
Allow the dbus method call for bluetooth.admin privilege app

BT system popup will call dbus method directly to confirm the pairing.
So we should allow the method from app user if it has the privilege

Change-Id: I0cafcebad827cb5fd516ed4a1e5b2d5015281d65
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix TCT fail issue on ARTIK530 18/179218/2 accepted/tizen/unified/20180517.062349 submit/tizen/20180517.000204
DoHyun Pyun [Wed, 16 May 2018 09:13:37 +0000 (18:13 +0900)]
Fix TCT fail issue on ARTIK530

ARTIK530's BT kernel is not ported yet. Because of this,
LE scan operation is not working physically. This patchset
is for the exception case.

Change-Id: I03b6e2a312d4b493c2bd2d00f957df9324941286
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoAdjust the timing to load BT driver 60/179160/1 accepted/tizen/unified/20180517.062311 submit/tizen/20180516.064227
DoHyun Pyun [Wed, 16 May 2018 06:40:31 +0000 (15:40 +0900)]
Adjust the timing to load BT driver

Change-Id: Ieba46283aec98db78f35e8f2dc39c0b2ee66a380
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoAdd the allow and deny own dbus policy 75/178375/1
DoHyun Pyun [Thu, 10 May 2018 00:50:29 +0000 (09:50 +0900)]
Add the allow and deny own dbus policy

Change-Id: Ib5af0b85404d031b087d97e4353e881868343e38
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoAdd bt-driver-insmod.service trigger logic 72/178372/1 accepted/tizen/unified/20180510.070900 submit/tizen/20180510.004118
Wootak Jung [Thu, 10 May 2018 00:31:02 +0000 (09:31 +0900)]
Add bt-driver-insmod.service trigger logic

Change-Id: I0e4b4b994d7a0c74440d495c70d7f96ee914bb68

6 years agoFix privilege violation 59/178059/2
Wootak Jung [Tue, 8 May 2018 04:32:32 +0000 (13:32 +0900)]
Fix privilege violation

Need default deny policy for internal interface

Change-Id: If7ecc83424efb736f6d30a0ac43a0a510bf51437

6 years agoModify the dbus policy for user session 28/177728/3
DoHyun Pyun [Thu, 3 May 2018 06:50:51 +0000 (15:50 +0900)]
Modify the dbus policy for user session

Change-Id: I26e95019d71e78f70e7cccd3f57d92d26f487438
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix the svace issue 47/177147/2 accepted/tizen/unified/20180427.062420 submit/tizen/20180426.103200
Hyuk Lee [Thu, 26 Apr 2018 01:18:34 +0000 (10:18 +0900)]
Fix the svace issue

Change-Id: I196e12ddc9ad87007464221d21b7888b69e41180
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
6 years agoAdd disconnect logic when dpm policy is updated 14/176914/2
Wootak Jung [Fri, 20 Apr 2018 01:16:23 +0000 (10:16 +0900)]
Add disconnect logic when dpm policy is updated

Change-Id: I9aaaf07e823c7a123478e7221fabe27be61797d5

6 years agoFix the crash issue in OAL event loop 72/176572/3 accepted/tizen/unified/20180423.062836 submit/tizen/20180423.011216
Hyuk Lee [Fri, 20 Apr 2018 05:05:48 +0000 (14:05 +0900)]
Fix the crash issue in OAL event loop

Change-Id: Id955d5e63429139ba2c7a869347956311c27b3d1
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
6 years agoFix bt_core dbus policy issue 12/176312/2
Wootak Jung [Wed, 18 Apr 2018 09:03:50 +0000 (18:03 +0900)]
Fix bt_core dbus policy issue

Change-Id: I34c3863ecba512615267ed46a07135429b21ed67

6 years agoMerge "Add default deny policy in conf files" into tizen
Pyun DoHyun [Wed, 18 Apr 2018 06:16:45 +0000 (06:16 +0000)]
Merge "Add default deny policy in conf files" into tizen

6 years agoAdd default deny policy in conf files 51/176151/4
Wootak Jung [Tue, 17 Apr 2018 06:57:35 +0000 (15:57 +0900)]
Add default deny policy in conf files

Remove at_console policy

Change-Id: I31a6089386e9bf9d095fa9390215a746aac4e263

6 years agoRemove the package dependency for pkgmgr and dbus-glib-1 64/176264/2 submit/tag/20180416.022000
DoHyun Pyun [Wed, 18 Apr 2018 02:28:55 +0000 (11:28 +0900)]
Remove the package dependency for pkgmgr and dbus-glib-1

Change-Id: I3b2e8a621594cae48db31bfcd69074dc02463646
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoMerge "Add the AVRCP delay changed callback" into tizen
Pyun DoHyun [Wed, 18 Apr 2018 00:38:39 +0000 (00:38 +0000)]
Merge "Add the AVRCP delay changed callback" into tizen

6 years agoFix privilege check logic 39/176139/1
Wootak Jung [Tue, 17 Apr 2018 05:06:46 +0000 (14:06 +0900)]
Fix privilege check logic

BT_CHECK_PRIVILEGE is required in 1st param to check privilege

Change-Id: Iff6760952080e8a05479169ca13b6ed2f6acab8d

6 years agoAdd the rfkill udev rule file 43/175643/2
Hyuk Lee [Wed, 11 Apr 2018 08:28:16 +0000 (17:28 +0900)]
Add the rfkill udev rule file

Change-Id: I8e7af48093446359d684eb1743f140688abfd8b2
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
6 years agoMerge "Add the media transport interface to adaptation code" into tizen
Pyun DoHyun [Mon, 9 Apr 2018 05:21:06 +0000 (05:21 +0000)]
Merge "Add the media transport interface to adaptation code" into tizen

6 years agoAdd the media transport interface to adaptation code 00/174100/6
Hyuk Lee [Wed, 28 Mar 2018 05:56:49 +0000 (14:56 +0900)]
Add the media transport interface to adaptation code

Change-Id: I6cfd4c4b10a87894b4326c331f32a845a239a845
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
6 years agoRemove unnecessary dpm policy check logic 03/175103/2 accepted/tizen/unified/20180409.060335 submit/tizen/20180409.022828
Wootak Jung [Mon, 9 Apr 2018 01:09:10 +0000 (10:09 +0900)]
Remove unnecessary dpm policy check logic

dpm policy was already done during rfcomm connection.
no need to check dpm policy in socket writing

Change-Id: I5412d2b4c273a0627911cf52beeb0ded44587a87

6 years agoAdd the AVRCP delay changed callback 47/174547/1
Hyuk Lee [Tue, 3 Apr 2018 02:22:51 +0000 (11:22 +0900)]
Add the AVRCP delay changed callback

Change-Id: Ieaf16bba7a03aeb8c8984f1a5fab8cada3b9a5eb
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
6 years agoMerge "Svace fix: WGID-319844 'characteristic.handle' doubble free" into tizen accepted/tizen/unified/20180323.062146 accepted/tizen/unified/20180403.182512 submit/tizen/20180322.235038 submit/tizen/20180401.231313
Pyun DoHyun [Thu, 22 Mar 2018 23:49:12 +0000 (23:49 +0000)]
Merge "Svace fix: WGID-319844 'characteristic.handle'  doubble free" into tizen

6 years agoMerge "Svace fix WGID:324430 :statement in the source code might be unreachable durin...
Pyun DoHyun [Thu, 22 Mar 2018 23:48:59 +0000 (23:48 +0000)]
Merge "Svace fix WGID:324430 :statement in the source code might be unreachable during program execution" into tizen

6 years agoSVACE : WGID 324403 33/173533/2
Anupam Roy [Thu, 22 Mar 2018 07:01:02 +0000 (12:31 +0530)]
SVACE : WGID 324403

Change-Id: I38c66e9e23546005c7ff42f73b51f3a588232cdb
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
6 years ago[Bluetooth-frwk] SVACE issue fixed for WGID:324402 22/173522/1
Abhishek Chandra [Thu, 22 Mar 2018 06:35:27 +0000 (12:05 +0530)]
[Bluetooth-frwk] SVACE issue fixed for WGID:324402

Change-Id: Ib5aab65c6ae272f03da5d66ebdc5f1ca89c6e02f
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
6 years agoSvace fix: WGID-319844 'characteristic.handle' doubble free 21/173521/1
Avichal Agarwal [Thu, 22 Mar 2018 06:27:49 +0000 (11:57 +0530)]
Svace fix: WGID-319844 'characteristic.handle'  doubble free

Change-Id: I50c493329672477239fc029ce68c1c8ef7271477

6 years agoSvace fix WGID:324430 :statement in the source code might be unreachable 20/173520/1
Avichal Agarwal [Thu, 22 Mar 2018 06:25:18 +0000 (11:55 +0530)]
Svace fix WGID:324430 :statement in the source code might be unreachable
during program execution

Change-Id: Ic75be3839330c649e47fcd17ab16f468be68cc07

6 years agosvace fixes done 97/173397/2 accepted/tizen/unified/20180322.145115 submit/tizen/20180322.062553
Amit Purwar [Wed, 21 Mar 2018 07:31:13 +0000 (13:01 +0530)]
svace fixes done

Change-Id: I2acea06b83ab5ebb9c3dbd200108f3704520d2c9
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
6 years agoInitialize VCONFKEY_BT_DEVICE to NONE when bt is enabled/disabled 46/172946/1
Wootak Jung [Mon, 19 Mar 2018 05:14:53 +0000 (14:14 +0900)]
Initialize VCONFKEY_BT_DEVICE to NONE when bt is enabled/disabled

Change-Id: I44692c267963ddf68e5549d842f6b823eb9bccf6

6 years agoFix NULL dereference issue 13/172413/2
Wootak Jung [Wed, 14 Mar 2018 00:48:43 +0000 (09:48 +0900)]
Fix NULL dereference issue

Change-Id: I2c2ec27c180425cbe7727bf85813dd6f3af73092

6 years agoAdd the rfkill control to bluetooth stack up 85/172185/1 accepted/tizen/unified/20180314.141409 submit/tizen/20180314.004906
Hyuk Lee [Mon, 12 Mar 2018 10:42:43 +0000 (19:42 +0900)]
Add the rfkill control to bluetooth stack up

Change-Id: I1c1ef5f085517b363e7f67fc6a42c48094699407
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
6 years agoAdd the service file for bt-core 65/170565/1 accepted/tizen/unified/20180226.142340 submit/tizen/20180221.011521 submit/tizen/20180226.020205
Hyuk Lee [Wed, 21 Feb 2018 00:20:48 +0000 (09:20 +0900)]
Add the service file for bt-core

Change-Id: I8d7af5e04ad558579a6b434bf7c8d68fccda584f
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
6 years agoModify the bt-core's UID/GID to network_fw 58/169858/2 submit/tizen/20180219.022158
Hyuk Lee [Mon, 12 Feb 2018 01:16:00 +0000 (10:16 +0900)]
Modify the bt-core's UID/GID to network_fw

Change-Id: I1bff9d8ebff0c3479c4c113ccdfe1ae29fba991d
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
6 years ago[Bluetooth-OAL] Jira issue : TFIVE-26 45/169545/1 submit/tizen/20180208.004203
Abhishek Chandra [Wed, 7 Feb 2018 09:02:55 +0000 (14:32 +0530)]
[Bluetooth-OAL] Jira issue : TFIVE-26
LIB path not defined for 64bit architecture .
Added changes in the spec file and
defined path for lib64 .

Change-Id: I42f4f5721b0b6a66aa061742b2ed8a1540c98181
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
6 years ago[Bluetooth-Frwk] CSharp TCT Fixes over Latest Tizen branch 33/168733/1 accepted/tizen/unified/20180131.060535 submit/tizen/20180131.012600
Abhishek Chandra [Tue, 30 Jan 2018 10:39:37 +0000 (16:09 +0530)]
[Bluetooth-Frwk] CSharp TCT Fixes over Latest Tizen branch

Change-Id: I6a25081323c1293a7f4373ad419e2053ac38817d
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
6 years ago[Bluetooth-Frwk] TCT Fixes over Latest Tizen branch 25/168225/6
Abhishek Chandra [Thu, 25 Jan 2018 05:47:04 +0000 (11:17 +0530)]
[Bluetooth-Frwk] TCT Fixes over Latest Tizen branch

Fixed issues in the TCT failures on Tizen branch
Fixed SVACE warnings and errors
Change-Id: Iab509cabfe0472954119a31bb0bfc88a8e8a1395
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
6 years agoFix the build error in x86_64 00/166600/1 submit/tizen/20180111.051222
DoHyun Pyun [Thu, 11 Jan 2018 05:06:58 +0000 (14:06 +0900)]
Fix the build error in x86_64

Change-Id: Ia732f932ed1c0d4c6e595b1cc80eeea1b8487806
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoresolved the code rule warnings 31/166231/1 submit/tizen/20180110.041217
Amit Purwar [Wed, 3 Jan 2018 10:59:53 +0000 (16:29 +0530)]
resolved the code rule warnings

Change-Id: I14806911d8adbf1b5fadb98bb89c6b2f6d955514
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix SVACE issues in Tizen New BT Architecture 30/166230/1
Atul Rai [Thu, 28 Dec 2017 09:42:07 +0000 (15:12 +0530)]
Fix SVACE issues in Tizen New BT Architecture

Change-Id: I93a762e037e6c4a5b814c8d064cd586259ccc44a
Signed-off-by: Atul Rai <a.rai@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoMerge tizen_next codes into tizen branch 32/164032/1
DoHyun Pyun [Wed, 6 Dec 2017 04:15:44 +0000 (13:15 +0900)]
Merge tizen_next codes into tizen branch

---------------------------------------------------
commit bdd924ebbd4727e0a02323d00e3f53e714dd3b46
Author: DoHyun Pyun <dh79.pyun@samsung.com>
Date:   Mon Dec 4 16:03:43 2017 +0900

    Apply latest changes in tizen branch
---------------------------------------------------

Change-Id: I8dc8758f06c4c7690afe6beba54adb3baf729890
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix : Visibility timer is not cancelled when PSCAN off 25/162525/1 accepted/tizen/unified/20171207.070143 submit/tizen/20171206.015028
Seungyoun Ju [Wed, 29 Nov 2017 09:02:07 +0000 (18:02 +0900)]
Fix : Visibility timer is not cancelled when PSCAN off

[Problem] Visibility timer is not stopped when connectable mode is
 turned off.
[Cause & Measure] There is no logic to cancel timer. So this patch adds
 the cancel logic.
[Checking Method] Turn on limited discoverable mode -> Turn off
 connectable mode -> Check discoverable timeout event

Change-Id: Icc800e9704f8c9cdb09338f2d1e5504d5c60f64d
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoAdd the interface to start / stop visibility timer 24/162524/1
Seungyoun Ju [Wed, 29 Nov 2017 09:00:10 +0000 (18:00 +0900)]
Add the interface to start / stop visibility timer

[Problem] Visibility timer is not stopped when connectable mode is
 turned off.
[Cause & Measure] This patch adds the interface to control visibility
 timer in event handler module.
[Checking Method] Turn on limited discoverable mode -> Turn off
 connectable mode -> Check discoverable timeout event

Change-Id: I528b4093427bbda9e9fac4e4ce1b72b1ffb41873
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix : logic error in MDM visibility policy 23/162523/1
Seungyoun Ju [Wed, 29 Nov 2017 08:47:15 +0000 (17:47 +0900)]
Fix : logic error in MDM visibility policy

[Problem] There are some logic error regarding Discoverable property
 changed event.
1. When limited discoverable mode is not allowed and general
discoverable is set, general discoverable is requested again.
2. When limited discoverable mode and discoverable mode are both not
allowed, it tries to set general discoverable mode.
3. DiscoverableTimeout property is not updated.
[Cause & Measure] 1. Check current discoverable mode and only if it is
in limited discoverable mode and limited discoverable mode is not
allowed, set to general discoverable mode.
2. After handling discoverable mode policy, don't check limited
discoverable mode policy.
3. Use proper type to set DiscoverableTimeout property.
[Checking Method] Code review

Change-Id: I8e3d9a6a56769c21faa2ef1361623ff0cfd22a8b
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix mem leak. 22/162522/1
Deokhyun Kim [Tue, 7 Nov 2017 09:52:16 +0000 (18:52 +0900)]
Fix mem leak.

Change-Id: Iaa6f68f1e773ea543d45d9b3695e569552e0399a
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoProceed HID connection procedure when it's already connected. 21/162521/1
Deokhyun Kim [Tue, 7 Nov 2017 09:49:21 +0000 (18:49 +0900)]
Proceed HID connection procedure when it's already connected.

  - Application can use fd of HID channel even though it's already connected.

Change-Id: I15421dfd0378735cd15d7dae66a24d064341f3bc
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoCleanup HID device codes. 20/162520/1
Deokhyun Kim [Wed, 25 Oct 2017 01:38:27 +0000 (10:38 +0900)]
Cleanup HID device codes.

Change-Id: I699a10bf46bbc8a4af43f1fb587c0771c26a0261
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoFix memory leak 19/162519/1
Sangki Park [Wed, 18 Oct 2017 10:46:22 +0000 (19:46 +0900)]
Fix memory leak

[Problem] Fix memory leak
[Checking Method] Turn BT on -> off

Change-Id: I0fae995235f649d66e73cd248559999de9232ebf
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
6 years agoRevert "Use FindDevice to get device object path" partially 18/162518/1
Seungyoun Ju [Fri, 20 Oct 2017 11:49:36 +0000 (20:49 +0900)]
Revert "Use FindDevice to get device object path" partially

This partially reverts commit 30314c18fea269785f2c25d6f7dcd765008ad7a7

[Problem] Application couldn't make BREDR connection when remote device
 supports BREDR and LE both.
[Cause & Measure] Wrong device object path is used for BREDR connection.
 When a remote device supports BREDR/LE, bluez has two
 device object which has same bdaddr but different bdaddr_type. In this
 case, FindDevice call returns the first searched device's object path.
 To solve this issue, instead of FindDevice call,
 object path should be constructed from address.

Change-Id: If5fb0041906ec7564cc30d88be16479c3078c85e
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoFix memory leak in __bt_get_device_info_in_message 37/157837/1
Atul Rai [Thu, 26 Oct 2017 11:12:33 +0000 (16:42 +0530)]
Fix memory leak in __bt_get_device_info_in_message

Change-Id: I6a356c490510cb3ec4a8c541aed2cacb121a7a61
Signed-off-by: Atul Rai <a.rai@samsung.com>
7 years agoFix TBT socket client fail issue 75/157075/1
DoHyun Pyun [Mon, 23 Oct 2017 08:35:13 +0000 (17:35 +0900)]
Fix TBT socket client fail issue

Adjust the location to free the variable. We should free the value
after using it.

Change-Id: I7a7ccfb79023dbff16734b1098dbe478df8e6090
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoFix bt-service crash issue. 50/156650/1
Deokhyun Kim [Thu, 19 Oct 2017 08:25:18 +0000 (17:25 +0900)]
Fix bt-service crash issue.

 - le_adv_slot is accessed in __bt_hold_current_advertising_timeout_cb()
   after it's freed.

Change-Id: I105617fcd42d65e5de80400564e20e7859f82d12
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoEnhance debug message 06/156406/1
injun.yang [Tue, 17 Oct 2017 06:34:36 +0000 (15:34 +0900)]
Enhance debug message

When service added from remote device,
get uuid information and display it

Change-Id: I659fe1df18c36c1a15cbd25650b26fcb7c42706f
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agofix unable to pair with headset having pin '1234' 04/155104/1
Biman Paul [Wed, 11 Oct 2017 09:12:13 +0000 (18:12 +0900)]
fix unable to pair with headset having pin '1234'

[Problem] unable to pair with headset having pin '1234'
[Cause & Measure] For headset, usually default pin is
'0000' and request is Pairing pin is send as '0000'. But
when pin is not '0000' first attempt fails and remote
device BD address is blacklisted(saved in a file) and for
all future requests blacklisted devices are checked and
pin popup is shown.
But here bt-service is unable to write to blacklist file.
Measure:
1. Allow write mode for blacklist file.
2. Give appropriate smack label.

[Checking Method] Use Mecapp:
1. Set COD such as Mecapp is recognised as Headset.
2. Initiate a pairing request to Mecapp.
3. Give pin 1234 or anything other than '0000' in mecapp.

Change-Id: I1aa0e66625601965c889005fbe23813f3ed2903b
Signed-off-by: injun.yang<injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoAdd uuid information 41/154741/1
injun.yang [Wed, 11 Oct 2017 06:15:47 +0000 (15:15 +0900)]
Add uuid information

Change-Id: I12ec33b7284f5c5a5a337ac1981f38e354fc0f64
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoFix memory leak 93/153593/1 accepted/tizen/unified/20171010.063742 submit/tizen/20171010.004335
Seungyoun Ju [Fri, 22 Sep 2017 02:07:31 +0000 (11:07 +0900)]
Fix memory leak

[Problem] There are some memory leak in code
[Cause & Measure] Fix memory leak

324 bytes in 18 blocks are definitely lost in loss record 1,471 of 1,512
at 0x48458E8: malloc (vg_replace_malloc.c:299)
by 0x4B9E271: g_variant_get (gvariant.c:5368)
by 0x12DAC5: _bt_get_remote_device_info_by_object_path (bt-service-device.c:516)
by 0x11A295: __bt_device_property_changed_event (bt-service-event-receiver.c:1076)
by 0x11A295: _bt_handle_property_changed_event (bt-service-event-receiver.c:1403)
by 0x11D235: __bt_manager_event_filter (bt-service-event-receiver.c:2885)

504 bytes in 72 blocks are definitely lost in loss record 1,479 of 1,512
at 0x48458E8: malloc (vg_replace_malloc.c:299)
by 0x4B9E271: g_variant_get (gvariant.c:5368)
by 0x12579D: __bt_get_bonded_device_info (bt-service-adapter.c:374)
by 0x12579D: _bt_get_bonded_device_info (bt-service-adapter.c:3153)
by 0x143815: __bt_bluez_request (bt-request-handler.c:880)
by 0x147439: __bt_service_method (bt-request-handler.c:275)

648 bytes in 36 blocks are definitely lost in loss record 1,486 of 1,512
at 0x48458E8: malloc (vg_replace_malloc.c:299)
by 0x4B9E271: g_variant_get (gvariant.c:5368)
by 0x13402F: _bt_get_device_ida (bt-service-device.c:3563)
by 0x1449ED: __bt_bluez_request (bt-request-handler.c:1792)
by 0x147439: __bt_service_method (bt-request-handler.c:275)

1,008 bytes in 36 blocks are definitely lost in loss record 1,490 of 1,512
at 0x48458E8: malloc (vg_replace_malloc.c:299)
by 0x4B79E89: g_malloc (gmem.c:97)
by 0x4B89755: g_slice_alloc (gslice.c:1007)
by 0x4B5664B: g_array_sized_new (garray.c:193)
by 0x147191: __bt_service_method (bt-request-handler.c:220)

21,852 bytes in 1,214 blocks are definitely lost in loss record 1,509 of 1,512
at 0x48458E8: malloc (vg_replace_malloc.c:299)
by 0x4B9E271: g_variant_get (gvariant.c:5368)
by 0x11B96D: _bt_handle_device_event (bt-service-event-receiver.c:2200)
by 0x11D8B1: __bt_manager_event_filter (bt-service-event-receiver.c:2897)

22,662 (432 direct, 22,230 indirect) bytes in 18 blocks are definitely lost in loss record 1,511 of 1,512
at 0x48458E8: malloc (vg_replace_malloc.c:299)
by 0x4B9E271: g_variant_get (gvariant.c:5368)
by 0x11D17D: __bt_manager_event_filter (bt-service-event-receiver.c:2679)

Change-Id: Ib00c46ac04eff5d62b94bbf31876bd06dac6aa2a
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
7 years agoFix : Some properties of adapter couldn't be handled 92/153592/1
Seungyoun Ju [Wed, 20 Sep 2017 05:01:52 +0000 (14:01 +0900)]
Fix : Some properties of adapter couldn't be handled

[Problem] Some property changed events for adapter object couldn't be handled
[Cause & Measure] It returns in the iterate loop

Change-Id: I17395d7cea094cac324fec110add10ae8c13cc8b
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
7 years agoFix : Multiple advertising feature was not working 91/153591/1
Seungyoun Ju [Wed, 20 Sep 2017 03:58:03 +0000 (12:58 +0900)]
Fix : Multiple advertising feature was not working

[Problem] Multiple advertising feature was not working
[Cause & Measure] Advertising slot was not initialized because BT
 chipset supported slot count is over the defined maximum. Platform can
 support the large number of slots if BT chipset can. So we don't need
 to define maximum value of slots. This patch removes the maximum value
 of slots.
[Checking Method] Turn on Bluetooth and check advertising slot's
 initialization.

bt-service-event-receiver.c: __bt_adapter_property_changed_event(847) > name = adv_inst_max
bt-service-event-receiver.c: __bt_adapter_property_changed_event(849) > Value = 17
bt-service-adapter-le.c: _bt_update_le_feature_support(134) > (slot_num > BT_ADV_MULTI_MAX) return
bt-service-event-receiver.c: __bt_adapter_property_changed_event(851) > Fail to update LE feature info

Change-Id: I93e020908636627c9cf0b6ac1377e71126717dd0
Signed-off-by: Seungyoun Ju <sy39.ju@samsung.com>
7 years agoAdded NULL pointer guard check before 41/151341/4
Abhishek Chandra [Wed, 20 Sep 2017 12:29:23 +0000 (17:59 +0530)]
Added NULL pointer guard check before
g_ascii_strcasecmp.

Change-Id: Iec3f82a5b6d9dec394b4cdcfd34e09693efec36e
Signed-off-by: Abhishek Chandra <abhishek.ch@samsung.com>
7 years agoFix the svace issue - memory leak 92/151192/1
DoHyun Pyun [Wed, 20 Sep 2017 07:32:27 +0000 (16:32 +0900)]
Fix the svace issue - memory leak

Change-Id: Ia9c24145cf0cedd82622e6eeab599ec46c5ecb37
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoUse FindDevice to get device object path 69/150569/1
Biman Paul [Thu, 7 Sep 2017 11:18:39 +0000 (16:48 +0530)]
Use FindDevice to get device object path

[Problem] Reduce dbus overhead to get device object path.
[Cause & Measure] GetManagedObjects returns exhaustive
list of iterfaces and their properties recursively which
is redundant.
Measure: Use FindDevice method to get device object path.
[Checking Method] NA

Change-Id: I394bc2fc7ef003d837c34d9953d783f412cd1b8b
Signed-off-by: injun.yang <injun.yang@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoSVACE Fixes 39/149539/1
Anupam Roy [Tue, 12 Sep 2017 11:22:02 +0000 (16:52 +0530)]
SVACE Fixes

ID's: 228340, 252922, 252923
      252928, 258235, 258245
      260752, 271421, 271423

Change-Id: Iccfe27233877e14d04beea2c24cfe07786fb74b8
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
7 years agoFix SVace issue. 99/149499/1
Deokhyun Kim [Tue, 12 Sep 2017 06:53:46 +0000 (15:53 +0900)]
Fix SVace issue.

Change-Id: I7e7db0bf260d0ebc2f0139eb35c34734603a7ab8
Signed-off-by: Deokhyun Kim <dukan.kim@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoFix tizen coding style errors and warnings 24/149324/2 accepted/tizen/unified/20170915.185019 submit/tizen/20170912.093658
DoHyun Pyun [Tue, 12 Sep 2017 05:48:25 +0000 (14:48 +0900)]
Fix tizen coding style errors and warnings

Change-Id: I686a9b692ae77ff858be3d6237eb0f0fd5a6aadf
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoApply tizen 3.0 based product patchsets 22/147922/1 accepted/tizen/unified/20170908.061947 submit/tizen/20170906.230917
DoHyun Pyun [Wed, 6 Sep 2017 05:20:48 +0000 (14:20 +0900)]
Apply tizen 3.0 based product patchsets

--------------------------------------------------
commit 0aa1d3f208f07e30fda9f16ee0b7325faf772939
Author: Deokhyun Kim <dukan.kim@samsung.com>
Date:   Fri Sep 1 10:16:27 2017 +0900

    Fix mem leak.
--------------------------------------------------

Change-Id: I506e75e67664f2d5941bc8e3302d3a15dc22ca82
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years ago[TDS] Modify ReadValue and WriteValue API's 93/146393/3 accepted/tizen/4.0/unified/20170905.175107 accepted/tizen/unified/20170830.160938 submit/tizen/20170829.085542 submit/tizen_4.0/20170905.000523
Anupam Roy [Mon, 28 Aug 2017 09:17:42 +0000 (14:47 +0530)]
[TDS] Modify ReadValue and WriteValue API's

GATT ReadValue and WriteValue API's are
modified by Bluez upstream while moving the
GATT DBUS API's from EXPERIMENTAL to STABLE.

Accordingly, TDS Seeker API's are modified in
this patch to match latest ReadValue and
WriteValue API's.

Change-Id: I94316fe1212f38bcafad0345669182b248f8a44a
Signed-off-by: Anupam Roy <anupam.r@samsung.com>
7 years agoFix the crash in the fail case 54/144854/4
DoHyun Pyun [Fri, 18 Aug 2017 07:01:34 +0000 (16:01 +0900)]
Fix the crash in the fail case

Change-Id: Ie2119a33789874a63f71a9178ab1e2344a2205de
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoChange the dbus call method for 'unregister application' 86/144786/2 accepted/tizen/4.0/unified/20170828.223235 accepted/tizen/unified/20170822.113001 submit/tizen/20170818.052446 submit/tizen_4.0/20170828.100003
DoHyun Pyun [Fri, 18 Aug 2017 02:36:29 +0000 (11:36 +0900)]
Change the dbus call method for 'unregister application'

The previous async calling method occurs the crash when TC calls
'gatt deinit' function frequently. Even if bluez provides
the dbus method as async, we can call it using dbus sync call.
It will reduce some timing issue.

Change-Id: Iaa9cb17016180b09291ec7620f1cacb2609a29d3
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoModify the privilege check of passkey confirmation 03/144503/1 submit/tizen/20170817.054358
Hyuk Lee [Thu, 17 Aug 2017 05:03:15 +0000 (14:03 +0900)]
Modify the privilege check of passkey confirmation

Change-Id: Ic4f4749d3f4a9c7896f89ce4e38c489788b5ee95
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
7 years agoAdd missed patchset 75/144275/1
injun.yang [Wed, 16 Aug 2017 06:20:49 +0000 (15:20 +0900)]
Add missed patchset

Some code missed from below commit

commit 6ef7f5f7ca21435c3c0b0b50c6dedfe6a807f655
Author: Seungyoun Ju <sy39.ju@samsung.com>
Date:   Thu Jun 22 15:21:01 2017 +0900

Refactoring GATT client service changed logic

Change-Id: Ib63bfd076514de95df3d6a72fee2da76a57663a1
Signed-off-by: injun.yang <injun.yang@samsung.com>
7 years agoDebug message cleanup 49/144249/1
injun.yang [Wed, 16 Aug 2017 05:16:51 +0000 (14:16 +0900)]
Debug message cleanup

Change-Id: Iec220a08090d40b40cd58a1e7bea7d242940e8da
Signed-off-by: injun.yang <injun.yang@samsung.com>
7 years agoAdd SmackProcessLabel option in systemd service files 73/143673/1 accepted/tizen/unified/20170814.060137 submit/tizen/20170811.080019
DoHyun Pyun [Fri, 11 Aug 2017 02:36:43 +0000 (11:36 +0900)]
Add SmackProcessLabel option in systemd service files

Change-Id: Ia16b28474228a6135b299e65797c19a09aed3a25
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoAdd the PIE option for the excutable binary 93/143193/1 accepted/tizen/unified/20170811.021137 submit/tizen/20170809.230017
DoHyun Pyun [Wed, 9 Aug 2017 04:16:41 +0000 (13:16 +0900)]
Add the PIE option for the excutable binary

Change-Id: Ia2a6bb65e6da5b2b7a083bd29acbe4eb671b071c
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoMerge "Handle the privilege permission error for agent methods" into tizen
DoHyun Pyun [Tue, 8 Aug 2017 23:35:39 +0000 (23:35 +0000)]
Merge "Handle the privilege permission error for agent methods" into tizen

7 years agoApply Tizen3.0 Gatt client product patch 86/142986/1 accepted/tizen/unified/20170809.135141 submit/tizen/20170808.231821
h.sandeep [Tue, 8 Aug 2017 06:27:22 +0000 (11:57 +0530)]
Apply Tizen3.0 Gatt client product patch

=================================================
 commit 19bdcca142a1369080998e61c552d422c5dca302
 Author: Seungyoun Ju <sy39.ju@samsung.com>
 Date:   Thu Apr 20 21:36:37 2017 +0900
     Fix : Simultaneous GATT client requests are failed
=================================================

Change-Id: Iefb332ae6adc881e4c20fd7bd93ae26e3ee7bda9
Signed-off-by: h.sandeep <h.sandeep@samsung.com>
7 years agoHandle the privilege permission error for agent methods 55/142955/3
DoHyun Pyun [Tue, 8 Aug 2017 04:44:22 +0000 (13:44 +0900)]
Handle the privilege permission error for agent methods

Change-Id: I267ed55df361f145bf0d7e4e6d2bf9dcbcf7defa
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoApply tizen 3.0 based product patchsets 13/142513/3 accepted/tizen/unified/20170808.171414 submit/tizen/20170808.020532
DoHyun Pyun [Fri, 4 Aug 2017 06:38:13 +0000 (15:38 +0900)]
Apply tizen 3.0 based product patchsets

--------------------------------------------------
commit a049ded240d77ce4c14bda87796c4d3b06764270
Author: Sreeraj Mohan Kottapuzhackal <sreeraj.mk@samsung.com>
Date:   Mon Jul 24 13:16:05 2017 +0530

    Fix for crash while pairing device
--------------------------------------------------

Change-Id: I2206a657cddc27f8bca3d9ce7fffff4bf81be953
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years ago[OTP] Handle GattConnected event 01/142101/3
Gowtham Anandha Babu [Wed, 2 Aug 2017 12:06:21 +0000 (17:36 +0530)]
[OTP] Handle GattConnected event

Change-Id: I3002836c52408c0e8c9697adcb6cc247e209ded9
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
7 years ago[OTP] Fix OACP Create procedure 32/141632/1
Gowtham Anandha Babu [Tue, 1 Aug 2017 07:23:45 +0000 (12:53 +0530)]
[OTP] Fix OACP Create procedure

Change-Id: Ifa72fc6e7cf23b8533587ed1cce38e5cefcf9f4e
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
7 years ago[GATT] Fix ATT application ecode 22/140722/2
Gowtham Anandha Babu [Wed, 26 Jul 2017 06:58:56 +0000 (12:28 +0530)]
[GATT] Fix ATT application ecode

1) Add error codes defined in Common Profile and
Service Error Code descriptions (see Supplement to the
Bluetooth Core Specification, sections 1.2 and 2).

2) Seperate out OTP specific application ecode.

Change-Id: I666707b76f5252a7662ff8ffc295660678d964e3
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
7 years ago[GATT Server] Delivery the specific error code to central device 15/140615/2 accepted/tizen/4.0/unified/20170816.011228 accepted/tizen/4.0/unified/20170816.014632 accepted/tizen/unified/20170727.190506 submit/tizen/20170725.234514 submit/tizen_4.0/20170811.094300 submit/tizen_4.0/20170814.115522 submit/tizen_4.0_unified/20170814.115522
injun.yang [Tue, 25 Jul 2017 14:54:13 +0000 (20:24 +0530)]
[GATT Server] Delivery the specific error code to central device

[Problem] Unalbe to pass application error code to central device
[Cause & Measure] Pass the specific error code to central device
[Checking Method] Reponse with the specific error to central device

Change-Id: I72fdfdef011f7f357e95eb4932e703e0cae08480
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
7 years agoFix static analysis tool warnings 16/140016/2 submit/tizen/20170724.081454 submit/tizen/20170725.090318
Atul Rai [Fri, 21 Jul 2017 10:31:18 +0000 (16:01 +0530)]
Fix static analysis tool warnings

Change-Id: I1b1dcc4a27366352fadd7370bb8a14f173e37938
Signed-off-by: Atul Rai <a.rai@samsung.com>
7 years agoadded the failure condition for realloc 20/140020/2
Amit Purwar [Fri, 21 Jul 2017 10:49:15 +0000 (16:19 +0530)]
added the failure condition for realloc
removed the print after return

Change-Id: I1dfb2bf75f36c9c1b71651c480c5eaa1a7a01d04
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
7 years agofixed the GDbusProxy in GATT: register, unregister and service callabck 24/139924/1
Amit Purwar [Fri, 21 Jul 2017 05:04:24 +0000 (10:34 +0530)]
fixed the GDbusProxy in GATT: register, unregister and service callabck

Change-Id: I807f9a4a25e544a6f7630ca23b9737f017c3bb73
Signed-off-by: Amit Purwar <amit.purwar@samsung.com>
7 years agoMerge "[GATT Client] Delivery ATT error code to higher layer" into tizen accepted/tizen/unified/20170721.201846 submit/tizen/20170721.013619
Pyun DoHyun [Fri, 21 Jul 2017 01:35:19 +0000 (01:35 +0000)]
Merge "[GATT Client] Delivery ATT error code to higher layer" into tizen

7 years ago[GATT Client] Delivery ATT error code to higher layer 77/139377/4
Gowtham Anandha Babu [Tue, 18 Jul 2017 13:34:07 +0000 (19:04 +0530)]
[GATT Client] Delivery ATT error code to higher layer

[Problem] ATT error code is not passed to application.

[Cause & Measure] GATT application need to know ATT
error code to handling error case. Specially application
error code defined by a higher layer specification.

[Checking Method] GATT error handling

Change-Id: I37747073962baa2b1098eb801ce033fb0b0c4c85
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
7 years agoAdd missed code for the discovery state logic 11/139311/1 accepted/tizen/unified/20170721.024454 submit/tizen/20170719.005005
DoHyun Pyun [Tue, 18 Jul 2017 09:56:03 +0000 (18:56 +0900)]
Add missed code for the discovery state logic

Change-Id: I23773d65601d4e7ee013ff2233c0e839f993bfa1
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years agoMerge "Modify the device discovery status" into tizen accepted/tizen/unified/20170718.174144 submit/tizen/20170717.090652
Pyun DoHyun [Tue, 18 Jul 2017 05:35:34 +0000 (05:35 +0000)]
Merge "Modify the device discovery status" into tizen

7 years agoModify the device discovery status 20/139120/2
Hyuk Lee [Mon, 17 Jul 2017 10:28:30 +0000 (19:28 +0900)]
Modify the device discovery status

Change-Id: Ic877d145691f2cc16e4a35818e3cd7c5628ea359
Signed-off-by: Hyuk Lee <hyuk0512.lee@samsung.com>
Signed-off-by: DoHyun Pyun <dh79.pyun@samsung.com>
7 years ago[OTP] Fix OACP Create request 85/138785/2
Gowtham Anandha Babu [Thu, 13 Jul 2017 15:22:50 +0000 (20:52 +0530)]
[OTP] Fix OACP Create request

1) Changed Object type UUID implementation
   to support all types(16/32/128 bits) of UUIDs.
2) Fixed Object Metadata Write logic,
   so that changes reflect in object list.
3) Modified OACP Create logic to align with PTS.

Change-Id: If652a0a32be6334c30d4302ad4caa9fb5a7cf92f
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
7 years ago[OTP] Fix PTS fail cases 81/138781/1
Gowtham Anandha Babu [Thu, 13 Jul 2017 15:16:06 +0000 (20:46 +0530)]
[OTP] Fix PTS fail cases

Change-Id: Ib26a7e7465c49da3d9570f602c05799020171e8f
Signed-off-by: Gowtham Anandha Babu <gowtham.ab@samsung.com>
7 years agoMerge "[OTP] Fix object type uuid format" into tizen accepted/tizen/unified/20170711.180534 submit/tizen/20170710.052629
Pyun DoHyun [Mon, 10 Jul 2017 00:50:38 +0000 (00:50 +0000)]
Merge "[OTP] Fix object type uuid format" into tizen