Youngbok Shin [Fri, 27 Oct 2017 11:48:25 +0000 (20:48 +0900)]
elementary index: fix wrong reference in its header document
Summary:
elm_index.h uses legacy keyword for ref tag.
The patch update each keywords for widgets.
And colon ":" character should be seperated from reference keyword.
It will remove doxygen warning messages from elm_index.h file.
Test Plan: N/A
Reviewers: cedric, raster, jpeg
Differential Revision: https://phab.enlightenment.org/D5387
Change-Id: I9623cac2f1a5e9f312df004ef96e61ff9a0d5f3b
Jaeun Choi [Mon, 30 Oct 2017 01:34:21 +0000 (10:34 +0900)]
doc: fixed warnings caused by "@ref Scroller"
Change-Id: I2058381f8292215c927d63ac44550928899fe572
JinYong Park [Fri, 27 Oct 2017 02:49:28 +0000 (11:49 +0900)]
elm_entry: add missing parameter description (upstream merged)
Summary : Add missing parameter description to remove doxygen warning
Test Plan : API Doxygen Revision
https://phab.enlightenment.org/D5389
Change-Id: Ie95de1c8a9dcb74a42c726a0c184e0aee3fbc520
Signed-off-by: JinYong Park <j4939.park@samsung.com>
JinYong Park [Fri, 27 Oct 2017 02:47:11 +0000 (11:47 +0900)]
elm_config: add missing parameter description (upstream merged)
Summary : Add missing parameter description to remove doxygen warning
Test Plan : API Doxygen Revision
https://phab.enlightenment.org/D5390
Change-Id: I018b91808e4b90a86f2e0d879f827b1ed31a193a
Signed-off-by: JinYong Park <j4939.park@samsung.com>
JinYong Park [Fri, 27 Oct 2017 02:43:48 +0000 (11:43 +0900)]
elm_box: add missing parameter description (upstream merged)
Summary : Add missing parameter description to remove doxygen warning
Test Plan : API Doxygen Revision
https://phab.enlightenment.org/D5391
Change-Id: I0cbe075630d978859245984ee8e4440b31d115e5
Signed-off-by: JinYong Park <j4939.park@samsung.com>
JinYong Park [Thu, 26 Oct 2017 08:35:41 +0000 (17:35 +0900)]
add doxygen description from upstream
Change-Id: I7b9bc81bb9f71973046b2e358cc520fa69c85305
Signed-off-by: JinYong Park <j4939.park@samsung.com>
JinYong Park [Thu, 26 Oct 2017 08:42:18 +0000 (17:42 +0900)]
elm_bg_legacy: add missing parameter description
Summary : Add missing parameter description to remove doxygen warning
Test Plan : API Doxygen Revision
https://phab.enlightenment.org/D5388
Change-Id: Ic73b7983a8d22f261f8182edfc4d82ab7da7697b
Signed-off-by: JinYong Park <j4939.park@samsung.com>
JinYong Park [Thu, 26 Oct 2017 05:42:51 +0000 (14:42 +0900)]
Add return type description (from opensource)
Change-Id: I61e5e2167d744852c05ecf6cfac5dc2acff993e5
Signed-off-by: JinYong Park <j4939.park@samsung.com>
JinYong Park [Thu, 26 Oct 2017 04:55:17 +0000 (13:55 +0900)]
[elm_deprecated] add param, return type description
Change-Id: Iadfb4dc387f54955e983101681322ebb72f58fd5
Signed-off-by: JinYong Park <j4939.park@samsung.com>
Shinwoo Kim [Mon, 23 Oct 2017 08:53:39 +0000 (17:53 +0900)]
Enhacne documentation
- elm_win.eo
Change-Id: Idd209c7f17ea5e5be362be5a92c18c7fc2487a62
Thiep Ha [Tue, 24 Oct 2017 06:22:28 +0000 (15:22 +0900)]
doc: fix textwidth parameter
Change-Id: I6e645c1fd7fca043c79ac9ffee8a51749163e787
Thiep Ha [Tue, 24 Oct 2017 06:13:07 +0000 (15:13 +0900)]
doc: add missing parameters and fix references for some elm widgets
Change-Id: Iced4250100d557e0fd180f554683558f3c8e93dc
Woochan Lee [Tue, 24 Oct 2017 07:31:08 +0000 (16:31 +0900)]
Fix documentation warning.
@tizen_fix
Change-Id: I4ad34b704f64e3382ca6d52852715c5a16f1c844
Jeonghyun Yun [Mon, 23 Oct 2017 11:44:18 +0000 (20:44 +0900)]
elm_url: matched between url and proxy environment
@tizen_fix
Change-Id: Ic46db15739a1c86d39b223aa47cf114d52419f3e
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
Shinwoo Kim [Fri, 20 Oct 2017 05:51:28 +0000 (14:51 +0900)]
atspi: fix name, description callback issue
The accessible name, description callback did not work for the naviframe item.
Because the naviframe item has used VIEW object for its accessible object.
If user calls elm_atspi_accessible_name_cb_set(naviframe_item, cb, data),
then the callback cb should set to VIEW object, not naviframe item, because
atspi_accessible_name_get is using the VIEW object.
Change-Id: I8b0d25d36b8e66a45a3757efa900ff9082d6fbf3
Shilpa Singh [Wed, 18 Oct 2017 13:31:04 +0000 (19:01 +0530)]
[Accessibility]: Access frame going behind popup issue fix when popup is created in transition,finished callback.
Change-Id: I4e4bdf9c7ce6bd9528311319119c5f8c9e287d17
JunsuChoi [Fri, 20 Oct 2017 05:28:18 +0000 (14:28 +0900)]
atspi : Do not send signal, if current object and highlight object are same
Change-Id: I3ef37909e674496be0b96beee33a5b5b75c1abac
Shinwoo Kim [Fri, 20 Oct 2017 01:12:19 +0000 (10:12 +0900)]
atspi: fix translation domain for naviframe item
The naviframe item have used its VIEW object for accessible name and
description. But the naviframe item did not care about the translation
domain. So there was a translation problem.
Change-Id: I3163f4b078a62c82686806f265487c9a3082abc9
Jeonghyun Yun [Wed, 18 Oct 2017 22:48:46 +0000 (07:48 +0900)]
elm_scroller: fix scrolling with key move
Use content_region_show instead of content_pos_set in _key_action_move
Summary:
When user keep pressing key down or else on scroller content, scroller
animation is lagging because of elm_interface_scrollable_content_pos_set
by step_x or step_y value. When focus moved to next object by press key
down or else, content_pos_set by ecore_animator continuously. In this
time, content_pos_set in _key_action_move by step_x or step_y value
caused animation lagging problem. I fixed to use content_region_show
instead of content_pos_set in _key_action_move for remove exist
animator.
Test Plan:
1. elementary_test -> Scroller3
2. Press 3 times "Append 10 Items in 3s" button
3. focus to Item1 and keep pressing key_down
Reviewers: jpeg, woohyun
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5278
Change-Id: Ia112e52594ad1189fe767bcc7bb0c37a82bcc3e6
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
JunsuChoi [Fri, 13 Oct 2017 03:13:31 +0000 (12:13 +0900)]
atspi : Change default label append of popup from show_finish_cb to on_show
show_finish_cb is called after animation of popup has finished.
default label time limit for screen-readers is 0.3 seconds.
Default label does not work if animation does not finish in 0.3 seconds
So change it so that it can be processed by smart show.
Change-Id: I8df4833662d7252ded0ab2912e337d59d2f45ad3
Shinwoo Kim [Tue, 17 Oct 2017 02:23:21 +0000 (11:23 +0900)]
Enhance documentation
- elm_entry.eo
- elm_flip.h
- elm_flipselector.h
- elm_config.h
- elm_focus.h
- elm_gen.h
- elm_object.h
- elm_genlist.eo
- elm_genlist.h
- elm_grid.eo
- elm_icon.h
- elm_image.h
- elm_image_legacy.h
- elm_index.h
Change-Id: Ic82c977595f8819f53552b38174815e06268952b
Sungtaek Hong [Wed, 5 Apr 2017 06:43:33 +0000 (15:43 +0900)]
elm_map: fix copyright scalability issue
- Since copyright may have long text, the text cannot be shown properly
in low resolution.
@tizen_fix
Change-Id: I063b386bf4ec2c4b8a1f29d7d3cbff6abed9802e
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
Shinwoo Kim [Mon, 16 Oct 2017 06:58:56 +0000 (15:58 +0900)]
atspi: not use destructed eo object
It is possible to access destructed eo object using ATSPI interface.
The following sequence is possilbe, because AT-client such as screen-reader
does not know whether a widget object deleted or not.
1. _elm_radio_evas_object_smart_del
2. _elm_radio_elm_interface_atspi_accessible_state_set_get
So before using eo interface, we have to check if the eo object is vlid or
not using eo_destructed_is.
Change-Id: I7ffaf7bd905dcc2ef5770d9c1cef9de52ec77322
Wonki Kim [Tue, 10 Oct 2017 07:56:44 +0000 (16:56 +0900)]
elm_box: fix a potential null pointer dereferencing in elm_box
Summary:
if 'evas_object_smart_data_get' return null somehow,
logic that dereference the smart data pointer will cause problems.
This patch prevent a potential bug in advance.
Reviewers: jpeg, woohyun, cedric
Differential Revision: https://phab.enlightenment.org/D5290
Change-Id: I3bb685468cc3bdf44bddff1c51988f8ab37e7627
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Youngbok Shin [Tue, 17 Oct 2017 04:02:43 +0000 (13:02 +0900)]
examples: remove doxygen warning messages
It only remove warning messages which don't need example files.
Change-Id: Ia152012a0a197d7cc0472fefddeeccc090300f0f
Myoungwoon Roy, Kim [Wed, 11 Oct 2017 05:40:10 +0000 (14:40 +0900)]
Remove @ref for Start
Change-Id: I88ca7a1f5888c6090ecaf9d49ed7277595dcae74
Woochan Lee [Tue, 10 Oct 2017 10:57:59 +0000 (19:57 +0900)]
Spinner: Fix can't input number in case of min value is bigger than 1.
Min Max validate logic has been changed to support decimal point counting.
It makes this side effect.
Change-Id: Iede1a1ee48b60680387a770eaecd68a499d9eed4
JunsuChoi [Wed, 11 Oct 2017 03:12:45 +0000 (12:12 +0900)]
atspi : During the highlight grab, out signal is not sent.
There is an action that takes time to complete
the highlight grab, such as scroll bring in.
So the highlight box can be outside the screen.
After the highlight grab process is completed,
will check the highlight box status.
Change-Id: I7c6b92aebf2ab0f04ec833aa701e9705208d9671
JunsuChoi [Wed, 11 Oct 2017 13:09:14 +0000 (22:09 +0900)]
atspi : Do not center align when genlist item is highlighted in wearable profile
Change-Id: Ie6f5d80b5dc100ba1fc7af84607cefa3bb15939b
JunsuChoi [Wed, 13 Sep 2017 03:04:42 +0000 (12:04 +0900)]
atspi : Add check for chain end object with attribute
When searching for a neighbor object,
check whether there is an "relation_chain_end" attribute.
If it does, it returns the current object.
Change-Id: If84cd1fd0176e16b7a5ac79f60411491cc15c952
JunsuChoi [Fri, 29 Sep 2017 04:10:39 +0000 (13:10 +0900)]
atspi : Remove role check when getting an accessible object to a point.
Change-Id: Iae21fb219f39cb6b0acd088d50ae3ef5fe143869
JunsuChoi [Fri, 29 Sep 2017 11:55:32 +0000 (20:55 +0900)]
atspi: Improves how to find the can_highlight of the widget.
Returns EINA_FALSE if any of parents is EINA_FALSE
when determining can_highlight.
To determine can_highlight for the parent of an object,
we try to find the parent of the parent again.
As it repeats, it traverses as much as depth size factorial (d!)
However, if any of the parent of the object has can_highlight of the widget data is EINA_FALSE,
it is eventually EINA_FALSE
Change-Id: I0b6d2907aaf4c4778519dd56232d126249fe636f
Jeonghyun Yun [Wed, 11 Oct 2017 01:45:57 +0000 (10:45 +0900)]
elm_image: stop preloading before intenal_file_set as it may hit to-be-freed memory
Change-Id: I8df88ac5736058983a5c3db1addd573402b214bc
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
JunsuChoi [Fri, 29 Sep 2017 07:35:41 +0000 (16:35 +0900)]
add return check for eldbus
Change-Id: I366df41ee38dc29ab5a9448e378e4a2064bac7cd
Shinwoo Kim [Mon, 25 Sep 2017 13:57:02 +0000 (22:57 +0900)]
atspi: use detail value of window activated signal
The detail value of window activated signal is using for following cases
(1) support "default_label" attribute of window
(2) notify existing keyboard window.
The keyboard window would exist always, once it shows.
So if screen-reader turns off, and turn on again, there was no ATSPI signal.
We are using 'activate' signal for this case to get the reference of
keyboard window. And we are using detail value to reduce a call of IPC.
Change-Id: I11db347b89f283ad2ab7fd5378ca123948dbbaf5
Shinwoo Kim [Sat, 23 Sep 2017 13:34:52 +0000 (22:34 +0900)]
atspi: win overrides atspi component get interface
(1) The efl_ui_win overrides _elm_interface_atspi_component_extents_get to give
correct value if screen_coord is EINA_FALSE which means relative position.
The efl_ui_win has given its object geometry value + ecore evas geometry value.
The object geometry value was equal to the ecore evas geometry value, so the
relative position was not correct(twice of ecore evas geometry value).
(2) Allow ELM_ROLE_INPUT_METHOD_WINDOW to send signal
Change-Id: I1b6832e960b3123d2a817d6253313447bc31af08
Shinwoo Kim [Wed, 27 Sep 2017 09:30:06 +0000 (18:30 +0900)]
atspi: make datetime itself unacceptable object
This depends on UI definition. The datetime itself does not have highlight.
Only each part objects such as inc/dec button, year, month, and day in it.
Change-Id: I6a14dec2a24ee280ad19fa885acec0992acc9400
Shinwoo Kim [Wed, 20 Sep 2017 04:14:27 +0000 (13:14 +0900)]
atspi: fix infinite loop issue
It is possilbe to get a target object as a return value of get_object_at_point.
In this case _elm_widget_elm_interface_atspi_component_accessible_at_point_get
works again with the target which is same with root object.
[Enhanced]
- We do not have to go parent if the bottom up logic meets root object.
- Visiblity of panel is always true. So we are checking its SHOWING state.
If the panel is not SHOWING, remove it from valid children list.
Change-Id: I2edeefdc9a0c5955f1c28926321b74424c71bc40
Shinwoo Kim [Fri, 29 Sep 2017 05:28:21 +0000 (14:28 +0900)]
atspi: set elm_access layer to MAX
Set access object layer to max, because the highlight frame could be covered
by other object which has higher layer.
Change-Id: I16e54469f0c749fb2caab6da9ea68b8dc97d9b02
Shinwoo Kim [Thu, 28 Sep 2017 11:46:44 +0000 (20:46 +0900)]
elementary: atspi - fix dbus abort
This patch set fix following abort occured on dbus side.
(gdb) bt
0 __GI_raise (sig=sig@entry=6)
1 __GI_abort ()
2 _dbus_abort ()
3 _dbus_warn_check_failed
4 dbus_message_iter_append_basic
5 append_basic
6 eldbus_message_iter_basic_append
7 _bridge_signal_send
8 _text_text_removed_send
9 _bridge_accessible_event_dispatch
10 _elm_interface_atspi_accessible_event_emit
11 elm_interface_atspi_accessible_event_emit
12 _entry_changed_user_signal_cb
(gdb) f 12
(gdb) p *$1
$2 = {change = {insert = {content = 0x0, pos = 0, plain_length = 1},
del = {content = 0x0, start = 0, end = 1}},
insert = 0 '\000', merge = 0 '\000'}
The following patch set would fix the root cause of this problem.
https://phab.enlightenment.org/D5240
Change-Id: Ifea8c2fead631f06b7d54ce9a6517f795b3cbf06
Shinwoo Kim [Sat, 23 Sep 2017 08:42:55 +0000 (17:42 +0900)]
atspi: block event which is not interested in
The following ATSPI dbus signal is not interested in.
Moreover the following ATSPI dbus signal occurs a lot at init time.
This could cause a performance issue.
- 'ChildrenChanged' with added child
- 'ChildrenChanged' with deleted child
- 'AddAccessible'
- 'RemoveAccessible'
Change-Id: Iebfb4ef75b5f32bf025e275dd9b548bd3581b2de
Shinwoo Kim [Thu, 21 Sep 2017 07:40:49 +0000 (16:40 +0900)]
atspi: support "default_label" attribute of window
Wearable profile application does not want to use default label functionality
because it is hard to meet application UI definition.
So if the window has attribute "default_label" key, and its "disabled" value,
then screen-reader does not read out default label, and does not clear
currently highlight object.
Application should append attribute as below.
elm_atspi_accessible_attribute_append(window, "default_label", "disabled");
This patch set works with following patch set.
https://review.tizen.org/gerrit/151570 (screen-reader)
Change-Id: I354c6ecf30db3a0011658d69577ad384fcb900db
Shinwoo Kim [Tue, 19 Sep 2017 11:28:12 +0000 (20:28 +0900)]
atspi: Handle default label object on toolkit side
There are unexpected difficult cases to make default label work correctly.
The following would be the case.
(top of accessible tree) - (bottom side)
PageTab1 - Panel1 - PageTab2 - Panel2 - PageTab3 - Panel3(currently showing)
Application could make as below:
PageTab1 - Panel1 - PageTab3 - Panel3 - PageTab2 - Panel2(currently showing)
or following tree would normally be possilbe:
PageTab1 - Panel1 - PageTab2 - Panel2(currently showing)
There are much of complicated case over there.
So we are handling the default label object stack on toolkit(Elementary) side.
Please refer to following patch set:
https://review.tizen.org/gerrit/#/c/151025/ (at-spi2-core)
https://review.tizen.org/gerrit/#/c/151030/ (screen-reader)
Change-Id: I0834f9d0625f4e787d6315ce4858bdec4a67ab18
Shinwoo Kim [Fri, 15 Sep 2017 10:14:19 +0000 (19:14 +0900)]
atspi: clear current highlighted object
The _elm_win_screen_reader does not clear current highlighted object when the
screen reader is disabled. It tried to clear window highlight even though the
window does not have highlight.
Change-Id: Icc5de54361852c0210c0640f2801483f6a2c6468
Shinwoo Kim [Sat, 16 Sep 2017 08:09:33 +0000 (17:09 +0900)]
atspi: enhance line related to highlight frame
1. Before elm_widget_theme_object_set for a11y highlight frame was called in
_elm_win_accessibility_highlight_show which is called in highlighted object
move, resize callback.
2. Before evas_object_smart_changed was not called even though a11y highlight
frame is added as a smart member of highlighted object.
※ Refer to commit: c3b5da9 (atspi: make highlight frame be a smart member)
Change-Id: I1f5dc367d2fc5565d61ae12d44fb1e8a49eeb979
Youngbok Shin [Thu, 28 Sep 2017 10:41:56 +0000 (19:41 +0900)]
elementary: fix memory leaks when using elm_prefs
"regex" is heap-allocated and is not handled by regfree().
We must explicitely call free() after a regfree() to remove
the regex_t from memory.
Change-Id: Ib278f4bd49b6246b7d6eaf7f646dd1c36aca4419
Author: Jean Guyomarc'h <jean@guyomarch.bzh>
Date: Fri Aug 12 16:36:12 2016 +0200
Youngbok Shin [Thu, 28 Sep 2017 10:13:05 +0000 (19:13 +0900)]
entry: fix memory leak issue for atspi
@tizne_fix
Change-Id: Ib7820537a74b504939c78848b03cf5f644e49970
Woochan Lee [Thu, 28 Sep 2017 07:47:06 +0000 (16:47 +0900)]
elm_win: prevent Null pointer ref.
_elm_config could be null. in case launch the app using app_launch command in shell.
@tizen_fix
Change-Id: I27006548a32c56fffd6ff9aea98941b5e6036593
Hosang Kim [Thu, 28 Sep 2017 07:05:21 +0000 (16:05 +0900)]
elm_need_efret() - improve error handling according to coverity
fix CID 1360466, CID 1353589
we don't actually chekc if efreet inits right with elm_need_efreet()
as we just assume it inits (And there pretty much is no case where it
will not), but make coverity happy and check.
@fix
Change-Id: Ieb37ab35a6ebc3a7e30b9fd5be6bb0e5b06aa64f
Hosang Kim [Thu, 28 Sep 2017 06:40:44 +0000 (15:40 +0900)]
elm dbus menu - handle return value of eldbus_message_iter_arguments_get
handle possible error return of eldbus_message_iter_arguments_get()
according to coverity CID 1353591. this should fix that.
Change-Id: I213f644c6450e550f5a26fd9a0c11a707d71f94a
Taehyub Kim [Thu, 28 Sep 2017 06:02:45 +0000 (15:02 +0900)]
elm_config: add since_tizen tags for language auto mirrored functions
Change-Id: I855d620001346327358fffaa25f8073611b2fe5e
Taehyub Kim [Thu, 28 Sep 2017 05:56:20 +0000 (14:56 +0900)]
elm_interface_atspi_accessible: modified since_tizen tags for relationships clear
Change-Id: I772ca0b888cba32ed9d1b99ccddad6c9cc12ca1a
JunsuChoi [Mon, 25 Sep 2017 09:58:23 +0000 (18:58 +0900)]
add color for build message(error:red, warning:ylw)
Change-Id: I6fe5cf69b56d99085fa2b8655e96e0c8121cd8ef
jiin.moon [Wed, 20 Sep 2017 10:18:07 +0000 (19:18 +0900)]
elm image: Fix async open to avoid multiple mmap
From
cb3b4cc8d7794bea575a85325c8a58f25f0507b2 Mon Sep 17 00:00:00 2001
From: Jean-Philippe Andre <jp.andre@samsung.com>
Date: Fri, 15 Sep 2017 14:39:14 +0900
Subject: [PATCH] elm image: Fix async open to avoid multiple mmap
Reported by @jiin.moon:
In case of async_open for an elm_image, we try and open a file in a
thread, then map it and populate a bit, as this may take some time
(blocking I/O). This creates a mmap with eina_file_map_new. But later
evas image loaders will (usually) try and map the entire file with
eina_file_map_all() which creates another mmap. Since the size is
different (32Kb first then all) the returned map might be different
(it's up to the kernel to decide at this point).
So, in order to avoid having multiple maps on the same file, and try to
reduce the peak memory usage, we should prefer using the same map all
the time, i.e. the global one returned by eina_file_map_all().
This patch relies on the previous patch in eina_file which fixes
eina_file_map_populate() for the global map.
@fix
Change-Id: If27d42b89269493ac2425737198338689687459d
Wonki Kim [Mon, 11 Sep 2017 04:12:57 +0000 (13:12 +0900)]
interface_scrollable: Cast result of divide explicitly
cast from double to int explicitly to remove smell of code
Change-Id: Ic02d3c24f212be1d71ecb5a8b0e923795e8296d3
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
SangHyeon Jade Lee [Thu, 21 Sep 2017 10:52:33 +0000 (19:52 +0900)]
genlist & gengrid : fix build warnings
Change-Id: Ia356f41294f8e0bb84446699a7de87757d1b23b3
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
Jeonghyun Yun [Wed, 20 Sep 2017 01:02:56 +0000 (10:02 +0900)]
els_tooltip: Fix to use some functions before tooltip_test_set or tooltip_content_cb_set
Summary:
If user call tooltip_orient_set or tooltip_style_set or tooltip_window_mode_set
before tooltip_test_set or tooltip_content_cb_set, those functions doesn't work.
Because elm_tooltip will be created when tooltip_content_cb_set is called.
I fixed logic to use some functions before tooltip_test_set or tooltip_content_cb_set.
Test Plan: elementary_test -> Popups -> Tooltip
Reviewers: jpeg, Jaehyun
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5183
Change-Id: Ia058679cd1645a12e048d8c5b0db0566f2742fca
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
Doyoun Kang [Fri, 15 Sep 2017 00:30:21 +0000 (09:30 +0900)]
elm_conform: consider window's geometry while reflecting keyboard conformant geometry
There was a bug that the partial window was resized when the keyboard was shown on landscape mode.
So, we add code to consider window's geometry while calculating conformant's geometry.
Change-Id: Iaa895335ddbc78697044f6712e7477317f4d3758
Shinwoo Kim [Wed, 13 Sep 2017 12:34:44 +0000 (21:34 +0900)]
atspi: enhance _accessible_at_point_get
The _elm_widget_elm_interface_atspi_component_accessible_at_point_get is
seaching accessible object from bottom of tree.
If elm_popup, or elm_panel comes as a root object, then
the _elm_widget_elm_interface_atspi_component_accessible_at_point_get does not
search from bottom of tree.
To make seach logic consistent, we are using bottom-up approach first for both
elm_popup and elm_panel from this patch.
Change-Id: I2a31725e8ff69455b836d6f888e0b42695ad2af5
Doyoun Kang [Tue, 12 Sep 2017 12:20:17 +0000 (21:20 +0900)]
elm_win: do deferred resize job first before calling rotation change callback
there was a bug that the elm_win didn't resize when an user called evas_object_resize
with previous width and height in "wm,rotation,changed" smart callback function.
Change-Id: I8ac58abbb51e4e4135ff742c1c8a77e0c246ac7d
Shinwoo Kim [Tue, 12 Sep 2017 05:44:39 +0000 (14:44 +0900)]
atspi: enhance _accessible_at_point_top_down_get
If there is only one valid child at point, then return it.
The evas_tree_objects_at_xy_get could not find proper object,
if application does not have well aligned objects.
This could be a role of application, but this patch set could solve somehow.
Change-Id: I6326a23b88904f6003a99e8b17885452890c7222
SangHyeon Jade Lee [Mon, 28 Aug 2017 10:55:05 +0000 (19:55 +0900)]
genlist: re-focus on genlist in item focus set when sub-object was focused
Change-Id: I6de90b593dc0e251bc401bdd245dcfb507a90a98
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
Shinwoo Kim [Mon, 11 Sep 2017 05:33:41 +0000 (14:33 +0900)]
atspi: enhance po file to translate "Alert"
There was no information to translate "Alert".
Change-Id: I339548b707d2d34df77dcc36774d0a4665854e63
Shinwoo Kim [Mon, 11 Sep 2017 05:29:46 +0000 (14:29 +0900)]
atspi: follow edje_entry logic to send anchor name
The edje_entry has logic remove unnecessary character.
The elm_entry is following the logic to give correct information.
Change-Id: I55114193d9b23117ddc8b9863c2b14741f42a215
Shinwoo Kim [Sun, 10 Sep 2017 00:50:21 +0000 (09:50 +0900)]
atspi: emit signal after atspi bridge is connected
This patch set emitting popup SHOWING signal, and window ACTIVE signal after
the atspi bridge is connectted.
The SHOWING signal of popup does not work properly, if the popup shows before
the atspi bridge is not connected. In this case, the screen-reader cannot read
popup information. So the SHOWING signal should be emitted after the connection
is established.
The ACTIVE signal does not work properly in the following case.
There are two windows show in one process at the same time. In this case,
the ACTIVE signal was not emitted because window_activated_broadcast_needed is
set to EINA_FALSE. This would be a bug.
Change-Id: Ieb1883c94c2570fdb92b9770a1c20e7d95c27a60
JunsuChoi [Fri, 8 Sep 2017 09:13:05 +0000 (18:13 +0900)]
atspi : Fix "bring_in" of the genlist item in wearable profile
Change-Id: I440fa9e8583e6b8d0089c64c7d15bce717155ec1
SangHyeon Jade Lee [Mon, 21 Aug 2017 09:48:19 +0000 (18:48 +0900)]
genlist: initialize process size when item is loaded
Change-Id: I6d983a56fae403444ffe55a68e276a5e4e42355e
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
Jaehyun Cho [Wed, 6 Sep 2017 11:04:41 +0000 (20:04 +0900)]
naviframe: Fix to finish transition for newly pushed item
Suppose naviframe top item is "A" and a new item "B" is newly pushed.
In this case, if "A" is deleted by elm_object_item_del() before
transition for "B" is started, then signal for "B" is also not sent and
"B" does not become visible.
The above issue happened if the transition effect was implemented by
using deferred signals (i.e. "pushed,deferred" and "popped,deferred").
To resolve the above issue, the signal only for the deleted item is not
sent.
Suppose naviframe top item is "A" and a new item "B" is newly pushed.
In this case, if "B" is deleted by elm_object_item_del() before
transition for "B" is started, then signal for "A" is still sent and "A"
becomes invisible.
To resolve the above issue, if the deleted item is the top item and it
is in the middle of item push, then all the signals related to the
deleted item are not sent.
Change-Id: I33c9f5039a8d3a3e5c60259a14edae395503ddd8
Shinwoo Kim [Fri, 8 Sep 2017 07:46:32 +0000 (16:46 +0900)]
atspi: remove unacceptable leaf node
An object could have children which have same position.
In this case, if first child of this object is not acceptable leaf node, then
there is no chance to find second child object.
Change-Id: If6887dc04bce4590ab4123cb79914172b5a4ca48
Jaeun Choi [Fri, 8 Sep 2017 07:15:41 +0000 (16:15 +0900)]
elm_color_class: add missing return value
Change-Id: I76e3bf28d2269c68a88fa02118a554d1a7b727ec
Shinwoo Kim [Fri, 8 Sep 2017 02:30:30 +0000 (11:30 +0900)]
atspi: expose API
elm_atspi_accessible_relationships_clear
Change-Id: I297d379744f8df17d833d3b4172a0f70aba4e655
Shinwoo Kim [Wed, 6 Sep 2017 11:09:26 +0000 (20:09 +0900)]
atspi: remove memory leak
The _elm_util_mkup_to_text gives alloacated plain text.
This plain text should be freed.
Change-Id: I4fe6443a2be78a80b00e79925b9ac968e489df76
Shinwoo Kim [Tue, 5 Sep 2017 13:42:50 +0000 (22:42 +0900)]
atspi: use entry text and parent accessible name
(1) The entry is using entry text for its accessible name.
(2) It is possible to overwrite default accessible name of entry by using
parent accessible name.
Change-Id: I29cdfe0fd6c517d9611ad46996eebe40c7be27e9
Shinwoo Kim [Tue, 5 Sep 2017 11:53:29 +0000 (20:53 +0900)]
atspi: find valid child of list item
This patch set is solving following case.
If genlist item uses evas_object_image_source_set to show item itself, then
evas_tree_objects_at_xy_get does not return below objects of image source.
So content objects of genlist item could not become cadicdates for
elm_interface_atspi_component_accessible_at_point_get.
@tizen_fix
Change-Id: I44e52b48054cf80fd102131c7f199a6b62a0464d
Jaeun Choi [Tue, 5 Sep 2017 07:14:37 +0000 (16:14 +0900)]
elm_panel: set content as a sub object of panel object
since sd->bx is not an elm object, it is excluded from parent-child tree.
in case of a non-scrollable panel, the content needs to be attached to the tree
as a child of panel object directly.
Change-Id: I32b65fc2e2b213e510c3060ac877a4361653191a
origin: upstream (
61381f6e3584118a70565eea79c355dd049b9e28)
Shinwoo Kim [Tue, 5 Sep 2017 02:13:28 +0000 (11:13 +0900)]
atspi: use elm_entry to call smart callback
This patch set is using elm_entry to call "anchor,clicked" smart callback.
The elm_access for anchor has been used so far, so the "anchor,clicked" smart
callback did not work.
Change-Id: If09400e78a9fc488e307fd46e67b39bf6beeca19
JunsuChoi [Wed, 9 Aug 2017 07:41:47 +0000 (16:41 +0900)]
[atspi][panel] Adds accessibility support for the panel widget.
Panel handles similar popups.
When open or close it sends signal to screen-reader.
Change-Id: Id4eade0d7989b17f3444ff794e812597859340dd
JunsuChoi [Thu, 31 Aug 2017 05:56:37 +0000 (14:56 +0900)]
[ATSPI] Add to find genlist item using proxy image
In a wearable profile, genlist displays the item using a proxy image.
When a screen-reader finds an object in the top_down, it can not find the item.
because, found item is proxy image.
So, using evas_object_image_source_get and gets item view object from proxy image.
Change-Id: Ifbd278c30380d72c08ff5b86c9f12680bb0b7974
Shinwoo Kim [Fri, 1 Sep 2017 07:35:55 +0000 (16:35 +0900)]
atspi: make highlight frame be a smart member
Make highlight frame object be a smart member of target object.
There are two cases covered by this commit.
1. ctxpopup of copy & paste module.
The ctxpopup item has higher object layer than highlight frame object.
In this case, the highlight frame is covered by the ctxpopup item.
2. genlist item proxy object.
The genlist item shows its proxy object(handled by evas_object_image_source*).
In this case, the highlight frame has improper position, and size.
Change-Id: I2b6470a8a695ea3739ddf80832e837dbd2c0d1f8
Jaehyun Cho [Thu, 31 Aug 2017 07:21:08 +0000 (16:21 +0900)]
naviframe: Fix to load default style if the given style does not exist
Naviframe item theme name is combined with item style name and widget
style name.
Therefore, if the item theme name is not found, then "item/basic" item
style name should be loaded as a default item style name.
Change-Id: I16d788ef41f2bd9668b50adf59175802dd715872
Myoungwoon Roy, Kim [Thu, 24 Aug 2017 04:57:05 +0000 (13:57 +0900)]
docs: Add information about texture size limitations
Summary: I had added some information about texture size limitations to Elm image API reference.
Test Plan: Doxygen Revision
Reviewers: raster, cedric, stefan, jpeg, Jaehyun_Cho
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D5106
Change-Id: I5372b83b4e9e736813a679da5c885a95b273a0f8
Woochan Lee [Thu, 24 Aug 2017 04:27:47 +0000 (13:27 +0900)]
elm_spinner: Maintainance API internal logic.
Change fmt value in the API can break compatibility.
Change-Id: I94e2c9832f907c714653a43aa63cc9ac6c2584eb
Woochan Lee [Wed, 23 Aug 2017 11:40:25 +0000 (20:40 +0900)]
elm_spinner: Support min,max filter for float format case.
Summary: The previous min, max filter doesn't support float format case.
Test Plan: elementary_test -> spinner.
Reviewers: jpeg, cedric, woohyun, myoungwoon
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5016
Change-Id: I60f97c1e8e27f9c3d09f85a5a4e0ccbb347d28e2
Woochan Lee [Wed, 23 Aug 2017 10:52:14 +0000 (19:52 +0900)]
elm_datetime: Add 'O' character to ignore POSIX alternative format in format.
Summary:
_parse_format() function filtering "_/-/0/^/*" to filter POSIX alternatvie/extension formats,
But the Datetime do not appear in some locale(fa_IR, lzh_TW, my_MM, or_IN) with 'O'.
+ improve code. (not compare with all of the characters. instead of that using strchr)
https://lh.2xlibre.net/values/d_t_fmt/
@fix
Test Plan: Set locale as fa_IR and create DateTime. and see fields, not appears.
Reviewers: jpeg, cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5020
Change-Id: I5c64f301324834b771c452c9cf39da6faa782274
Woochan Lee [Wed, 23 Aug 2017 11:02:38 +0000 (20:02 +0900)]
elm_datetime: Parses the format recursively.
Summary:
Some of locale formats convert as extension format.
For example,
uk_UA d_t_fmt is "%a, %d-%b-%Y %X %z".
The %X will convert as %T.
The %T format has to convert one more time to convert as %H:%M:%S.
ref : https://lh.2xlibre.net/locale/uk_UA/
We need to parse the format recursively to support that kind of case.
@fix
Test Plan:
Change the locale as uk_UA.
Run elementary_test -> datetime
See the time field is not appear.
Reviewers: jpeg, cedric
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5021
Change-Id: Ie088a4558d3688542e9bcf43dacd1a9a339b433e
JinYong Park [Wed, 23 Aug 2017 05:54:59 +0000 (14:54 +0900)]
test_check: fix build warning
In state_changed_cb2 callback function, obj is used. so it should not be EINA_UNUSED
https://phab.enlightenment.org/D5122
Change-Id: Ib6509a3bb895278aee03985f759a606b5adce31f
Signed-off-by: JinYong Park <j4939.park@samsung.com>
JinYong Park [Fri, 11 Aug 2017 04:51:26 +0000 (13:51 +0900)]
layout: call size calculating after text_set(NULL)
Summary
When text set NULL, size is not changed even text is removed.
So, fix that case logic
1. send text,hidden signal
2. remove text
3. call sizing eval to resize layout
Test Plan
1. run elementary_test -to check
2. change value last check object
3. compare before and after
https://phab.enlightenment.org/D5086
Change-Id: Ibe7450d3e8390a3f4bbb158f2d591236fc6de448
Signed-off-by: JinYong Park <j4939.park@samsung.com>
Bowon Ryu [Tue, 22 Aug 2017 07:08:01 +0000 (16:08 +0900)]
docs: fix wrong descrpition in elm_progressbar API reference doxygen.
unit format default is NULL in Tizen.
so delete the description.
Change-Id: Ib2e7e9ed84fcd16bd88d8da64480800fcc685c4e
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Jaeun Choi [Fri, 6 Jan 2017 05:02:20 +0000 (14:02 +0900)]
elm_image: make "elm_image" visible in smart_show func regardless of preloading status
even though sd->img should be hidden while preloading,
the elm_image object itself need to be marked as visible
so related jobs can be done on elm_widget level.
Change-Id: I67e236df6d41e83bd7e9135e6005c05ea7a50728
Woochan Lee [Fri, 18 Aug 2017 07:02:49 +0000 (16:02 +0900)]
Datetime: Prevent null pointer reference.
When _elm_datetime_items_get() calling with only time format after datetime creation.
The location has been swapped. so some of sorted_field index address gets a invalid
address. then it makes a crash.
@tizen_fix
Change-Id: I8e073237793d6af46a726be6cd51827f14c15661
JinYong Park [Tue, 1 Aug 2017 07:27:18 +0000 (16:27 +0900)]
notify: fix show animation signal emit logic
Change-Id: Ia805528acfb3378af3cff68c249c1c86b8f55393
Signed-off-by: JinYong Park <j4939.park@samsung.com>
SangHyeon Jade Lee [Thu, 17 Aug 2017 06:14:46 +0000 (15:14 +0900)]
genlist: process item block positioning before relative item deleted
Change-Id: Iac552c946bd37e0abf551c1c74a6a08a3c6a5acc
Signed-off-by: SangHyeon Jade Lee <dltkdgus1764@gmail.com>
Jaehyun Cho [Fri, 11 Aug 2017 07:06:48 +0000 (16:06 +0900)]
elc_naviframe: set focus to new view immediately only for item push
Set focus to new item view immediately when new item is pushed to show
keypad fast. Otherwise, focus of new item view is set late and keypad is
shown late.
Setting focus to item view immediately is applied to item push only.
Because if this concept is applied to item pop, then the following focus
issue happens.
Reproduction path of the item pop focus issue
1. Naviframe first item view consists of two objects.
Focus is in the second object of the first item view.
2. Naviframe push happens. (now two item views)
3. Popup appears and it gets the focus.
4. Popup button click pops the second naviframe item.
5. Focus goes to the naviframe and focus_next happens.
6. Focus is set to the first object of the first item view.
(not to the second object of the first item view)
Change-Id: I1940831dbd9ce0cf8efcd6b2172203fa1ee277fc
Sungtaek Hong [Fri, 11 Aug 2017 02:59:34 +0000 (11:59 +0900)]
Cast to double before division during region/coord calculation.
int var devided by int is cast to double after devision.
This might cause wrong calculation result.
Change-Id: I32128f81cbfa78b1e42b3c03fa18e664e31732ef
Signed-off-by: Sungtaek Hong <sth253.hong@samsung.com>
Jeonghyun Yun [Fri, 11 Aug 2017 04:48:06 +0000 (13:48 +0900)]
elm_scroller: focus_direction should not be called when scroller focusable and no focusable child
Summary:
when scroller can have focus and scroller's child can't have focus,
there is a problem that scroller is always selected to next focus object.
In this case, it should not enter into _elm_scroller_elm_widget_focus_direction()
Reviewers: woohyun
Reviewed By: woohyun
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5085
Change-Id: I235dbd87e28118295ef4150817deddec50c84fbe
Signed-off-by: Jeonghyun Yun <jh0506.yun@samsung.com>
Wonki Kim [Fri, 11 Aug 2017 05:16:48 +0000 (14:16 +0900)]
Revert "interface_scrollable: Fix not hold the flag on mouse down"
This reverts commit
012537f1e5cb2355940c7cf15c75027e3fbc6c2c.
Change-Id: I86e61f88c2cea008383ecb6fcd395c11a52c6b62
Signed-off-by: Wonki Kim <wonki_.kim@samsung.com>
Jaeun Choi [Tue, 8 Aug 2017 07:48:58 +0000 (16:48 +0900)]
test_gesture_layer3: fix typo
this typo was detected by SVACE
Change-Id: I3e32a058a0ddf7f4f22bac1106dc05698ff185a6
origin: upstream (
52368bf463c2b5ea7b69e15a7e34b1ea13258ca1)
Jaeun Choi [Tue, 8 Aug 2017 06:43:15 +0000 (15:43 +0900)]
test_gesture_layer: fix typo
this typo was detected by SVACE
Change-Id: I6b005aede302598dfe1f4af7fb38199dc4371b12
origin: upstream (
a9fdcc4cc2f5567fbc05ae418c4e3a4d13286f45)
Jaeun Choi [Wed, 9 Aug 2017 07:16:35 +0000 (16:16 +0900)]
elm_color_class: add null checking after memory allocation
origin: upstream (
15bbf4712ee1e9356fa975de6f2861bc5ce3076a)
Change-Id: Id9b82282635f8b722f6d282f3d0e84ee98aafdb0
Jaeun Choi [Wed, 9 Aug 2017 07:21:03 +0000 (16:21 +0900)]
elm_dbus_menu: add null checking after memory allocation
Change-Id: I43d0a47eb8d382007b6a9ed1d877415ad37ed52d
origin: upstream (
0927221c1a0e26b7fe006eb3110ca2bffd671b89)