platform/core/security/webauthn.git
7 months agoRefine QRCallback logic of request on server side 57/308057/2
Yonggoo Kang [Fri, 15 Mar 2024 11:25:21 +0000 (20:25 +0900)]
Refine QRCallback logic of request on server side

- Prevent to access to nullptr
- Remove unnecessary exception types
- Remove duplicated code block
- Move the result log from GetUserData() to outside

Change-Id: If654b9bd568cf088df94ec55f51489ef579be381

7 months agoFix minor 47/307947/3
Yonggoo Kang [Thu, 14 Mar 2024 12:00:20 +0000 (21:00 +0900)]
Fix minor

- Fix typo
- Add a missing header
- Remove unnecessary newlines

Change-Id: Id9b5f287a4dbdca9b997fcfb6241a07b783772fd

7 months agoRemove repeated condition 46/307946/3
Yonggoo Kang [Thu, 14 Mar 2024 11:57:38 +0000 (20:57 +0900)]
Remove repeated condition

Change-Id: I93fe37003d075fa04fb4d90f1dbf1a8fdc7de1bb

7 months agoCheck user_data first and remove unnecessary logic of tail 45/307945/3
Yonggoo Kang [Thu, 14 Mar 2024 11:52:55 +0000 (20:52 +0900)]
Check user_data first and remove unnecessary logic of tail

Change-Id: I2a2b17ef2174c9077f8db34f8835dc01c3fe805b

7 months agoEnable gcov 12/307912/3
Yonggoo Kang [Thu, 14 Mar 2024 07:03:40 +0000 (16:03 +0900)]
Enable gcov

 - Add settings
 - Change filename tests/main.cpp to unittests.cpp to distinguish it from server/main.cpp

Change-Id: I60a32e2eb1a347987bfde1e2a5aacd151dac3a7e

7 months agoAdd const to data buffers and strings in data types 32/307832/1
Krzysztof Malysa [Wed, 13 Mar 2024 11:36:07 +0000 (12:36 +0100)]
Add const to data buffers and strings in data types

Specifically:
- change char* to const char* in input data
- change wauthn_buffer_s to wauthn_const_buffer_s in input data

This prevents the need to use const_cast while creating the input data.

Change-Id: I3d6c06848010b8d962eb7a337a3b3a1d27601e16

8 months agoAdd a build option to check shadow declaration 48/307448/2 accepted/tizen/unified/20240312.132025 accepted/tizen/unified/x/20240313.092053 accepted/tizen/unified/x/20240314.073506
Yonggoo Kang [Fri, 8 Mar 2024 09:45:28 +0000 (18:45 +0900)]
Add a build option to check shadow declaration

Change-Id: I0bf6839b3a82749a89e83e5efa536773cbb04737

8 months agoPrevent COPY_INSTEAD_OF_MOVE 22/307322/1
Yonggoo Kang [Thu, 7 Mar 2024 07:41:21 +0000 (16:41 +0900)]
Prevent COPY_INSTEAD_OF_MOVE

Change-Id: I95bd05dc4c1362f6d7f4c64a002e9de93353f1bb

8 months agoRemove unnecessary dynamic_cast 05/307305/1
Yonggoo Kang [Thu, 7 Mar 2024 04:23:30 +0000 (13:23 +0900)]
Remove unnecessary dynamic_cast

Change-Id: Icf65af5556e5d5749553d45845794167db607b40

8 months agoModify expectation flow for unsigned char pointer test 02/307302/2
Yonggoo Kang [Thu, 7 Mar 2024 03:27:32 +0000 (12:27 +0900)]
Modify expectation flow for unsigned char pointer test

Change-Id: I61f11b8991cbfe931f0b2205d297ab29578cedab

8 months agoPrevent integer overflow 99/307299/1
Yonggoo Kang [Thu, 7 Mar 2024 03:02:23 +0000 (12:02 +0900)]
Prevent integer overflow

Change-Id: Ieb82a6d5f789dde5b658fa2e4f1eab2c79de6390

8 months agoRemove trailing whitespace 96/307296/2
Yonggoo Kang [Thu, 7 Mar 2024 02:22:16 +0000 (11:22 +0900)]
Remove trailing whitespace

Change-Id: Icbfa6f1b3101adf88b59277f32e2ea41d49336f8

8 months agoInit variables and split multiple serializaion test by parameter type 77/307277/2
Yonggoo Kang [Wed, 6 Mar 2024 13:48:25 +0000 (22:48 +0900)]
Init variables and split multiple serializaion test by parameter type

Change-Id: I5bda599854d7cf74a6c73cb581fbf7fdf7ca6d23

8 months agoRemove deadcode and add initial value 76/307276/1
Yonggoo Kang [Wed, 6 Mar 2024 12:44:19 +0000 (21:44 +0900)]
Remove deadcode and add initial value

Change-Id: I0ae36b8249ff0e9ba91fb43509684533835061a6

8 months agoRemove unused fd_set 61/307261/1
Yonggoo Kang [Wed, 6 Mar 2024 10:35:58 +0000 (19:35 +0900)]
Remove unused fd_set

Change-Id: Ibe5262d0d4bcaf4d65d0f6744a0254d1b7d684bd

8 months agoReplace pointer to smart pointer for RAII 58/307258/2
Yonggoo Kang [Wed, 6 Mar 2024 10:13:55 +0000 (19:13 +0900)]
Replace pointer to smart pointer for RAII

Change-Id: I1f987e62ff3b6284151aeec562c41d743610f267

8 months agoPrevent INTEGER_OVERFLOW 46/307246/2
Yonggoo Kang [Wed, 6 Mar 2024 09:17:50 +0000 (18:17 +0900)]
Prevent INTEGER_OVERFLOW

Change-Id: I6ec53dfec59ab3bef8bcc457ca29cf7a15389751

8 months agoPrevent access to null pointer 39/307239/2
Yonggoo Kang [Wed, 6 Mar 2024 08:24:11 +0000 (17:24 +0900)]
Prevent access to null pointer

Change-Id: I3bf17ed4cabbe008a6fe43ffdd2d325d447fab0a

8 months agoRemove unused dependencies of test package 38/307238/1
Dongsun Lee [Wed, 6 Mar 2024 08:12:32 +0000 (17:12 +0900)]
Remove unused dependencies of test package

Change-Id: I82803195cd3f1292720f17ff1c07513392c132f2

8 months agoInitialize class members and move a debug log 20/307220/6
Yonggoo Kang [Wed, 6 Mar 2024 06:00:59 +0000 (15:00 +0900)]
Initialize class members and move a debug log

Change-Id: I7e282eee3d2207a38c41a151e349c72209859141

8 months agoRemove unused tests 47/307047/1 accepted/tizen/unified/20240306.174145 accepted/tizen/unified/toolchain/20240311.064833 accepted/tizen/unified/x/20240308.033444
Dongsun Lee [Mon, 4 Mar 2024 07:14:04 +0000 (16:14 +0900)]
Remove unused tests

Change-Id: Id9109f626fbeb57efecd4685282054f6e3393ee5

8 months agoAdd exception for failed to connect to socket 58/306758/3
Yonggoo Kang [Tue, 27 Feb 2024 06:09:12 +0000 (15:09 +0900)]
Add exception for failed to connect to socket

Change-Id: I068c6d19a3a713943687a53fae15e5dd21152d36

8 months agoImplement on-demand socket activation 57/306757/2
Yonggoo Kang [Tue, 27 Feb 2024 06:08:44 +0000 (15:08 +0900)]
Implement on-demand socket activation

Change-Id: Ibedf871acbb60df9e0007af148e98e43c74fada5

8 months agoFix path of socket 56/306756/1
Yonggoo Kang [Tue, 27 Feb 2024 06:07:46 +0000 (15:07 +0900)]
Fix path of socket

Change-Id: I5d4770d3790bd33b2e6a915bd8e4173f225d9f82

8 months agoAdd default value and error type for timeout 73/306273/1
Yonggoo Kang [Mon, 19 Feb 2024 09:04:05 +0000 (18:04 +0900)]
Add default value and error type for timeout

Change-Id: I267d77778d3d4fbce977a6f37e7c8fc64694e990

8 months agoChange memory space from heap to stack for use instance variables 44/306244/1 accepted/tizen/unified/20240220.115627 accepted/tizen/unified/20240220.144631 accepted/tizen/unified/x/20240221.033404
Yonggoo Kang [Mon, 19 Feb 2024 06:28:12 +0000 (15:28 +0900)]
Change memory space from heap to stack for use instance variables

Change-Id: Iedd600a4cb57cf365b5391504b7c26a88eab85e7

9 months agoReuse some code blocks using typename <RequestX> (#48)
강용구/Security&Privacy팀(SR)/삼성전자 [Tue, 6 Feb 2024 04:33:11 +0000 (13:33 +0900)]
Reuse some code blocks using typename <RequestX> (#48)

* Add Request classes
* Reuse code block using typename <RequestX>
* Change to snake case in server-side
* Remove unused lines
* Change local variables to lower camel case
* Add ClientRequest classes
* Apply typename for reuse some code blocks in client-side
* add explicit to prevent converting constructor operation

9 months agoImplement Dynamic Library Loader and Link Hybrid Plugin (#47)
강용구/Security&Privacy팀(SR)/삼성전자 [Thu, 1 Feb 2024 02:08:57 +0000 (11:08 +0900)]
Implement Dynamic Library Loader and Link Hybrid Plugin (#47)

* Fix Path of SO file
* Add Dynamic Library Loader
* Link Hybrid Plugin using DLLoader
* Modify API test code for call the QR Callback
* Minor fix thr cancel API and remove unused test code

9 months agoFix typo (#46)
강용구/Security&Privacy팀(SR)/삼성전자 [Tue, 23 Jan 2024 00:01:18 +0000 (09:01 +0900)]
Fix typo (#46)

* Fix typo
* Remove end space of line

9 months agoAdd description for transports
Dongsun Lee [Mon, 22 Jan 2024 04:56:38 +0000 (13:56 +0900)]
Add description for transports

9 months agochange enums to uppercase
Dongsun Lee [Mon, 22 Jan 2024 04:27:30 +0000 (13:27 +0900)]
change enums to uppercase

9 months agoUse different namespace for TestData
Dongsun Lee [Mon, 22 Jan 2024 04:21:57 +0000 (13:21 +0900)]
Use different namespace for TestData

9 months agoAdjust to (de)serialization implementation (#42)
강용구/Security&Privacy팀(SR)/삼성전자 [Mon, 22 Jan 2024 01:54:40 +0000 (10:54 +0900)]
Adjust to (de)serialization implementation  (#42)

* Add a recv(T&&) function
* Adjust to (de)serialization implementation
* Modify simple test code for API test
* Remove unnecessary comment
* Add pass logic when a recv is failed
* Add util functions for handle excetpion and check parameter
* Add and move Exception classes into the exception header
* Add exception logic
* Modify simple test code
* Check parameters by workers in server-side
* Remove qrcode_callback if the linked_data exists
* Add pass logic on recv(T&) when a recv is failed
* Check and handle exception case in qrcode_callback

9 months agoAdd @see descriptions (#43)
강용구/Security&Privacy팀(SR)/삼성전자 [Wed, 17 Jan 2024 06:18:40 +0000 (15:18 +0900)]
Add @see descriptions (#43)

* Fix type of transports data
* Revoke type change and Add description

9 months agoAdd more defense logic for exceptional cases
Dongsun Lee [Mon, 15 Jan 2024 04:35:28 +0000 (13:35 +0900)]
Add more defense logic for exceptional cases

9 months agoImplements message serialization
Dongsun Lee [Wed, 3 Jan 2024 09:18:26 +0000 (18:18 +0900)]
Implements message serialization

9 months agoRemove unused origin from header
Dongsun Lee [Tue, 16 Jan 2024 06:20:01 +0000 (15:20 +0900)]
Remove unused origin from header

9 months agoFix TYPO in header(attestion->attestation)
Dongsun Lee [Tue, 16 Jan 2024 06:04:24 +0000 (15:04 +0900)]
Fix TYPO in header(attestion->attestation)

9 months agochange type of port from int to unsigned short
Dongsun Lee [Mon, 15 Jan 2024 04:43:54 +0000 (13:43 +0900)]
change type of port from int to unsigned short

9 months agoMove free into caller's block
Yonggoo Kang [Fri, 12 Jan 2024 03:26:19 +0000 (12:26 +0900)]
Move free into caller's block

9 months agoMark points will be changed
Yonggoo Kang [Fri, 12 Jan 2024 03:08:46 +0000 (12:08 +0900)]
Mark points will be changed

9 months agoMark points will be changed
Yonggoo Kang [Fri, 12 Jan 2024 02:58:12 +0000 (11:58 +0900)]
Mark points will be changed

9 months agoAdd simple test logic
Yonggoo Kang [Fri, 12 Jan 2024 02:57:23 +0000 (11:57 +0900)]
Add simple test logic

9 months agoLink pthread in test module
Yonggoo Kang [Fri, 12 Jan 2024 02:57:05 +0000 (11:57 +0900)]
Link pthread in test module

9 months agoFix name of member variables (#36)
강용구/Security&Privacy팀(SR)/삼성전자 [Thu, 11 Jan 2024 02:53:14 +0000 (11:53 +0900)]
Fix name of member variables (#36)

9 months agoRemove unnecessary shared ptr (#37)
강용구/Security&Privacy팀(SR)/삼성전자 [Thu, 11 Jan 2024 02:53:04 +0000 (11:53 +0900)]
Remove unnecessary shared ptr (#37)

9 months agoModify server's worker logic (#35)
강용구/Security&Privacy팀(SR)/삼성전자 [Wed, 10 Jan 2024 04:48:52 +0000 (13:48 +0900)]
Modify server's worker logic (#35)

* Modify service interface and Add descriptions
* Minor fix
* Remove unused logic

10 months agoBusy and Cancel logics (#33)
강용구/Security&Privacy팀(SR)/삼성전자 [Tue, 9 Jan 2024 08:02:13 +0000 (17:02 +0900)]
Busy and Cancel logics (#33)

10 months agofix a variable name in header file(transports->descriptors)
Dongsun Lee [Tue, 9 Jan 2024 07:46:01 +0000 (16:46 +0900)]
fix a variable name in header file(transports->descriptors)

10 months agoAdd thread logic for callbacks (#32)
강용구/Security&Privacy팀(SR)/삼성전자 [Fri, 5 Jan 2024 07:35:46 +0000 (16:35 +0900)]
Add thread logic for callbacks (#32)

* Add functions and Minor fix
* Add callbacks in creating thread at client-side
* Add callbacks in creating thread at server-side
* Remove service-thread
* Modify SocketManager for remove service-thread

10 months agoDefines WEBAUTHN_HYBRID_PLUGIN_SO_PATH in rpm macro file
Dongsun Lee [Thu, 4 Jan 2024 00:05:57 +0000 (09:05 +0900)]
Defines WEBAUTHN_HYBRID_PLUGIN_SO_PATH in rpm macro file

10 months agoChange callback definitions to function pointer
Dongsun Lee [Wed, 3 Jan 2024 04:47:37 +0000 (13:47 +0900)]
Change callback definitions to function pointer

10 months agoMake HAL API void
Krzysztof Jackiewicz [Mon, 11 Dec 2023 10:19:53 +0000 (11:19 +0100)]
Make HAL API void

All the errors will be returned via callbacks.

11 months agoRemove cancellation id from CAPI (#27)
강용구/Security Assurance Lab(SR)/삼성전자 [Thu, 7 Dec 2023 01:40:17 +0000 (10:40 +0900)]
Remove cancellation id from CAPI (#27)

* Remove cancellation id from CAPI and modify testcode
* Minor fix in serialization for long type
* Fix description

11 months agoAdd result param into response callback (#26)
강용구/Security Assurance Lab(SR)/삼성전자 [Tue, 5 Dec 2023 07:52:41 +0000 (16:52 +0900)]
Add result param into response callback (#26)

* Add result into response callback
* Minor fix on doc
* Drop "NONE" from name of cancelled

11 months agoRemoves Cancellation ID from HAL API
Dongsun Lee [Thu, 30 Nov 2023 01:25:39 +0000 (10:25 +0900)]
Removes Cancellation ID from HAL API

11 months agoFew API fixes
Krzysztof Jackiewicz [Tue, 28 Nov 2023 11:38:29 +0000 (12:38 +0100)]
Few API fixes

* Move include directives outside of 'extern "C"' blocks. Each header
  should decide how to handle it.
* Adjust API function definitions to declarations.
* Remove duplicated wauthn_error_to_string declaration.

11 months agoadd user_data parameter to callback functions
Dongsun Lee [Tue, 28 Nov 2023 06:00:58 +0000 (15:00 +0900)]
add user_data parameter to callback functions

11 months agoFix mismatch api (#23)
강용구/Security Assurance Lab(SR)/삼성전자 [Wed, 29 Nov 2023 05:45:35 +0000 (14:45 +0900)]
Fix mismatch api (#23)

11 months agoInit webauthn service (#20)
강용구/Security Assurance Lab(SR)/삼성전자 [Tue, 28 Nov 2023 06:39:42 +0000 (15:39 +0900)]
Init webauthn service (#20)

* Modify compiler to c++17
* Add build requires
* Add error types
* Remove duplicated variable
* Add include path for client
* Add data serialization
* Add webauthn service protocols
* Add to handle error with error number
* Add message buffer class
* Add utils
* Add free deleter
* Add Connection module
* Minor fix
* Modify CMakefiles for common lib
* Implement WebAuthn service
* Add an error type
* Add util functions
* Add request class for client
* Add protocols
* Add test code to check socket communication
* Minor fix
* Remove unused class and types
* Split connect, send, recv in client
* Minor fix (const, explicit)
* Remove Priority
* Minor fix
* Minor fix
* Minor fix
* Remove unnecesary log
* Remove unnecessary log
* Simplify creating socket service
* Remove unused code
* Split write, close in server
* Modify server main
* Remove unused code
* Add description for socket related errors.
* Match function parameters
* Remove new keyword
* Distinguish message size and payload on recv()
* Minor fix
* Avoid overwrite to buffer until previous write is sent
* Replace unique_ptr to make_unique
* Add file-locking module for server
* Add source files to build
* Check the thread is joinable
* Handle SIGTERM and Avoid "double free or corruption"
* Minor fix
* Merge exception handler for WA:Exception

11 months agochange cancellation_id to be generated in server
Dongsun Lee [Mon, 27 Nov 2023 00:38:45 +0000 (09:38 +0900)]
change cancellation_id to be generated in server

11 months agoElaborate the API description of wauthn_cb_display_qrcode
Dongsun Lee [Fri, 17 Nov 2023 05:08:47 +0000 (14:08 +0900)]
Elaborate the API description of wauthn_cb_display_qrcode

11 months agoAdd exception module (#18)
강용구/Security Assurance Lab(SR)/삼성전자 [Thu, 16 Nov 2023 09:53:13 +0000 (18:53 +0900)]
Add exception module (#18)

* Add exception module
* Change visibility hidden to default
* Add simple exception test

11 months agoAdd log module (#17)
강용구/Security Assurance Lab(SR)/삼성전자 [Thu, 16 Nov 2023 04:30:48 +0000 (13:30 +0900)]
Add log module (#17)

* Add log module
* Change log module in the client
* Change log module in the server
* Init testcode of client for check logging
* Add macro for naming log tag
* Modify macro name for distinguish with the client APIs

11 months agoFix to webauthn service setting (#15)
강용구/Security Assurance Lab(SR)/삼성전자 [Wed, 15 Nov 2023 09:52:34 +0000 (18:52 +0900)]
Fix to webauthn service setting (#15)

* Fix minor error for webauthn-server service

* Match API params

* Test call common lib on server

* Make consistency for naming in spec

* Modify smack label to SMACK_DOMAIN

11 months agoRemove wrong error code from appctrl_error_to_string()
Dongsun Lee [Wed, 15 Nov 2023 05:05:35 +0000 (14:05 +0900)]
Remove wrong error code from appctrl_error_to_string()

11 months agofix bug in manifest setting
Dongsun Lee [Wed, 15 Nov 2023 04:11:17 +0000 (13:11 +0900)]
fix bug in manifest setting

11 months agoAdd default visibility to APIs
Dongsun Lee [Wed, 15 Nov 2023 00:46:23 +0000 (09:46 +0900)]
Add default visibility to APIs

11 months agofix TYPO & add wauthn_error_to_string to header
Dongsun Lee [Tue, 14 Nov 2023 06:01:07 +0000 (15:01 +0900)]
fix TYPO & add wauthn_error_to_string to header

12 months agoAdd TCs for basic BLE operations
Dongsun Lee [Mon, 30 Oct 2023 00:47:20 +0000 (09:47 +0900)]
Add TCs for basic BLE operations

12 months agoSplit webauthn-types.h from webauthn.h
Dongsun Lee [Fri, 3 Nov 2023 01:11:00 +0000 (10:11 +0900)]
Split webauthn-types.h from webauthn.h

12 months agoAdd HAL APIs
Dongsun Lee [Mon, 30 Oct 2023 01:24:13 +0000 (10:24 +0900)]
Add HAL APIs

12 months agoadd webauthn APIs
이동선/Security Assurance Lab(SR)/삼성전자 [Wed, 11 Oct 2023 05:17:03 +0000 (14:17 +0900)]
add webauthn APIs

14 months agoAdd basic files for gbs build
Dongsun Lee [Tue, 5 Sep 2023 07:25:39 +0000 (16:25 +0900)]
Add basic files for gbs build

14 months agoinitial commit
Dongsun Lee [Mon, 4 Sep 2023 07:08:06 +0000 (16:08 +0900)]
initial commit