Ji-hoon Lee [Mon, 5 Dec 2022 10:39:51 +0000 (19:39 +0900)]
Remove unnecessary pid<->appid conversion logic
Change-Id: If0439c8fae6c8ba65d8249eef9dbe4a9ac7d13d7
Ji-hoon Lee [Wed, 30 Nov 2022 09:05:43 +0000 (18:05 +0900)]
Reduce blocking time when streaming audio data
When the CPU is busy handling many tasks, there are times
that the streaming thread gets blocked while calling some
undelying platform API functions. To avoid this problem,
applied several methods for reducing the blocking time
and added log messages for displaying time information.
List of methods used for reducing the blocking time:
1. Cache appid / pid information that is acquired by
calling AUL API functions, since they sometimes
do not return immediately and take a while to complete.
2. Instead of passing a pointer to the shared audio data
into the message transmission module while holding the
lock to protect the shared audio data, make a copy of
audio data and release the lock immediately so that
the copy of audio data can be used without the risk of
race condition. This is because sometimes the message
transmission also takes a bit of time to complete, and
the other threads waiting for the lock cannot proceed
in such cases.
Change-Id: I6c6959fadddbc557dbb77849fa25ce4949155f4b
Ji-hoon Lee [Wed, 30 Nov 2022 06:46:51 +0000 (15:46 +0900)]
Prevent restarting service when conversation session exists
Change-Id: I79771d40e67e2bda2efdd6a50474ef500fd5230c
Ji-hoon Lee [Mon, 24 Oct 2022 02:31:38 +0000 (11:31 +0900)]
Skip application running check when acquiring PID or AppID
Since the application running check is already performed
when wakeup event gets processed, there is no need to
check the running status every time PID or AppID is acquired.
Change-Id: If93f64f67cfde458123fca6c16f18713fd5118e8
Ji-hoon Lee [Thu, 29 Sep 2022 11:33:06 +0000 (20:33 +0900)]
Register package manager event handler before loading wakeup engines
If the wakeup engine app gets installed while
multi-assistant-service is being launched and also
is trying to load wakeup engines, the newly installed
wakeup engine will not be loaded since at the time of
launching the installation was not completed,
and the installation completion event would not be
received also, since the package manager event handler
might not be registered yet.
So if we register package manager event handler first
and then load wakeup engines, even if the wakeup engine
currently being installed fails to be loaded, the
installation completion event is guaranteed to be received
by the package manager event handler, making sure that
the multi-assistant-service would restart for re-loading.
Change-Id: I1e8f57d6a08c9290a0ae11422d1404188c97c3df
InHong Han [Thu, 29 Sep 2022 03:12:24 +0000 (12:12 +0900)]
Bump version to 0.3.37
Change-Id: I5660de15f66039d338edee05bafbd9d05fe3ec01
InHong Han [Thu, 29 Sep 2022 00:59:16 +0000 (09:59 +0900)]
Modified not to restart the daemon repeatedly
Change-Id: I4fd0822ac19d5cd010a39afe79410e13f4162805
InHong Han [Thu, 22 Sep 2022 07:40:19 +0000 (16:40 +0900)]
Change log level for debugging
Change-Id: I3050e5e4e9febd52d2adf131566cb3e90a9438af
InHong Han [Mon, 8 Aug 2022 04:54:32 +0000 (13:54 +0900)]
Fix issue detected by static analysis tool
Change-Id: I3d296586e161a2a024b301c1ef21e2f406799109
InHong Han [Mon, 25 Jul 2022 06:27:30 +0000 (15:27 +0900)]
Bump version to 0.3.36
Change-Id: Id0a6a7523197ff665329ab7e5e988c91d6bb1dd7
InHong Han [Mon, 25 Jul 2022 05:29:28 +0000 (14:29 +0900)]
Fix issue detected by static analysis tool
Change-Id: I573bfa8478cad77c9f38f4eaa00304ea2d854bfa
InHong Han [Mon, 25 Jul 2022 04:57:54 +0000 (04:57 +0000)]
Merge changes I0271d097,If55e1690 into tizen
* changes:
Bump version to 0.3.35
Modified not to load wakeup engine with wake_word_detection turned off
InHong Han [Thu, 21 Jul 2022 02:32:35 +0000 (11:32 +0900)]
Bump version to 0.3.35
Change-Id: I0271d097f9b17f03899bc7189a41207a065b9fba
InHong Han [Wed, 20 Jul 2022 09:58:46 +0000 (18:58 +0900)]
Modified not to load wakeup engine with wake_word_detection turned off
Change-Id: If55e1690071f43540e008bead090a6ecb3dc206b
Jihoon Kim [Sun, 24 Jul 2022 08:01:18 +0000 (17:01 +0900)]
Fix issue detected by static analysis tool
Change-Id: Iba3c2542af7a18ccf2b765a2cc2847c2b5d50219
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
InHong Han [Wed, 13 Jul 2022 08:04:03 +0000 (17:04 +0900)]
Send voice key support mode after changing default assistant
Change-Id: I718cab051170ae75d4ffc49de8675cbb3be969c5
InHong Han [Mon, 11 Jul 2022 10:06:37 +0000 (19:06 +0900)]
Bump version to 0.3.34
Change-Id: I41e15c0c78de3b8942a946b0868673a51c35fa5f
InHong Han [Mon, 4 Jul 2022 07:36:43 +0000 (16:36 +0900)]
Modified to load only required wakeup engines
Change-Id: I5088222fbe6217cf8381de5280f552efe3889599
Ji-hoon Lee [Thu, 23 Jun 2022 06:20:45 +0000 (15:20 +0900)]
Support checking recording_by_voice_key state for TTT
Change-Id: Ie91e1ece1e9eeb459b1ec18d3d22703bddbc1240
InHong Han [Tue, 21 Jun 2022 05:31:52 +0000 (14:31 +0900)]
Bump version to 0.3.33
Change-Id: I4c1061b997357760dea6fc78e3cc77a5a748832a
InHong Han [Tue, 21 Jun 2022 05:30:20 +0000 (14:30 +0900)]
Add missing wakeup_info assignment
Change-Id: Ib192e1c2ade1e922c19f5e5c6ee85431738be3e9
Ji-hoon Lee [Fri, 17 Jun 2022 04:22:46 +0000 (13:22 +0900)]
Bump version to 0.3.32
Change-Id: Ia95d45786550312020aefe738eb5e5df04b4bdf3
Ji-hoon Lee [Tue, 14 Jun 2022 12:26:38 +0000 (21:26 +0900)]
Make default wakeup policy to choose the first wakeup event
Change-Id: I9c7ca76a001983198d6ffbb458911e28aceffac3
InHong Han [Fri, 13 May 2022 09:21:08 +0000 (18:21 +0900)]
Add the new API for sending wakeup_word
Change-Id: Idfac593bbc829a25036fa9093bb219e157cf1d2d
Ji-hoon Lee [Thu, 9 Jun 2022 09:05:22 +0000 (18:05 +0900)]
Preserve wakeup manager state on proactive default assistant change
Change-Id: I772c2000e4201a7798226faeb70279fd36aca92e
Jihoon Kim [Fri, 20 May 2022 11:05:24 +0000 (20:05 +0900)]
Remove media-audio-io and appcore-agent dependency
Change-Id: If9ce14cfe817d90778e2e8c97bfe6dea9b1ca53a
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Fri, 20 May 2022 10:47:45 +0000 (19:47 +0900)]
Remove app manager and network connection dependency
Change-Id: I056f3a8ba87fb63cf1344c27a26319deaf6ec5ab
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Jihoon Kim [Fri, 20 May 2022 09:51:33 +0000 (18:51 +0900)]
Remove unused dependency
Change-Id: I493439e0bd4617fc0f98c1e5f03970d3bcb9e56d
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
Ji-hoon Lee [Thu, 26 May 2022 09:07:52 +0000 (18:07 +0900)]
Merge branch 'tizen_6.5' into tizen
Change-Id: I7d5d642fe7609f656a7e0214ad3136f18a3535bc
Ji-hoon Lee [Thu, 26 May 2022 08:37:06 +0000 (17:37 +0900)]
Bump version to 0.3.31
Change-Id: Ibcf463383e6c15c3cc9ee4ee2a4d9abdb90b8b33
Ji-hoon Lee [Thu, 26 May 2022 08:36:47 +0000 (17:36 +0900)]
Add logs for checking if audio fetching is being retried properly
Change-Id: I1cae28820288888d3bba0a75b6e5706244ea7d09
Ji-hoon Lee [Thu, 19 May 2022 07:14:03 +0000 (16:14 +0900)]
Separate config setter and value change handler
Change-Id: Ia659b1cc4a56eca2a4293493c6ce5c3e21b0e565
Ji-hoon Lee [Tue, 10 May 2022 05:59:05 +0000 (14:59 +0900)]
Update default assistant appid on wakeup event
Change-Id: I04e3059320e4a9f8e6d4c8902219297d47239a97
Ji-hoon Lee [Tue, 10 May 2022 01:48:56 +0000 (10:48 +0900)]
Bump version to 0.3.30
Change-Id: I47826ad2f0aa95d062c40d89cc7f0ce3bbd4b526
Ji-hoon Lee [Tue, 10 May 2022 01:48:49 +0000 (10:48 +0900)]
Fix defects detected by static analysis tool
Change-Id: I34bf30e5c04dc391d185b8f3a8042ebf0530531a
Ji-hoon Lee [Mon, 9 May 2022 11:45:12 +0000 (20:45 +0900)]
Validate sender information for every request from client
Change-Id: I3d3b51e8b70dec4f8a25eb2827c5f647f6cca273
Ji-hoon Lee [Fri, 8 Apr 2022 03:04:32 +0000 (12:04 +0900)]
Bump version to 0.3.29
Change-Id: I697921c3ed2f1169c640d9bd0ae2a7e0ea869fb9
Ji-hoon Lee [Fri, 8 Apr 2022 03:03:58 +0000 (12:03 +0900)]
Add metadata profile for providing metadata information
Change-Id: I51a2c31f29c032d68ea7830d7e348b29bd0e6457
Ji-hoon Lee [Wed, 16 Mar 2022 04:41:20 +0000 (13:41 +0900)]
Call stop_recording on stop streaming request in UTTERANCE mode
Change-Id: Iea8789ee57a7cb6d64b1e8a47a5735f104e19155
Ji-hoon Lee [Wed, 13 Apr 2022 06:00:53 +0000 (06:00 +0000)]
Merge "Ignore voice key press event during follow-up speech session" into tizen_6.5
Ji-hoon Lee [Wed, 13 Apr 2022 05:56:10 +0000 (14:56 +0900)]
Merge branch 'tizen_6.5' into tizen
Change-Id: Icf05bbf20fbf9826582438208ea0c35ffe2957cc
Ji-hoon Lee [Wed, 13 Apr 2022 05:53:02 +0000 (14:53 +0900)]
Ignore voice key press event during follow-up speech session
Change-Id: Ia48da94500eb9e084fe17431e0b54fe43b9f89f7
Ji-hoon Lee [Tue, 8 Mar 2022 09:21:58 +0000 (18:21 +0900)]
Add engine load failure log messages to the ERROR group
Change-Id: I341411c17a6c8511501d240039438df2a41faf31
Ji-hoon Lee [Fri, 18 Feb 2022 02:34:31 +0000 (11:34 +0900)]
Merge branch 'tizen_6.5' into tizen
Change-Id: Ifa3a76349c061f47bd67cd733400db6d36a52015
Ji-hoon Lee [Fri, 18 Feb 2022 02:34:15 +0000 (11:34 +0900)]
Bump version to 0.3.28
Change-Id: I0769d4d1a80e5527c5c342dc7551ad0d5537e55b
Ji-hoon Lee [Fri, 18 Feb 2022 02:29:58 +0000 (11:29 +0900)]
Change default streaming timeout value to 15 seconds
Change-Id: Id5de962d01300918ef7032b1e365053eb5f27c0c
Ji-hoon Lee [Fri, 26 Nov 2021 03:27:16 +0000 (12:27 +0900)]
Print memory usage
Change-Id: I95f908f82e9d8a33b24a8710be109d99bfa6c976
Ji-hoon Lee [Fri, 10 Dec 2021 07:42:09 +0000 (16:42 +0900)]
Merge branch 'tizen_6.5' into tizen
Change-Id: Idd9643d757bdd1ac297bd1492ecd63cdc5fcb599
Ji-hoon Lee [Fri, 10 Dec 2021 07:10:27 +0000 (16:10 +0900)]
Bump version to 0.3.27
Change-Id: I2dad772ca17773518574818eafb4a96d3b7dd54e
Ji-hoon Lee [Fri, 10 Dec 2021 06:49:57 +0000 (15:49 +0900)]
Handle default assistant change event in UTTERANCE state
Previously, if default assistant gets changed in
UTTERANCE state, the state doesn't get reset.
Modified to generate recognition result ERROR
event in this case.
Change-Id: Ie9a58cdf8220d5f4d92ac19e79394b7e5145470c
Ji-hoon Lee [Wed, 17 Nov 2021 05:49:51 +0000 (14:49 +0900)]
Merge branch 'tizen_6.5' into tizen
Change-Id: Id5816241a659f19ba8862c94f7a672975fd7f1ca
Ji-hoon Lee [Wed, 17 Nov 2021 05:48:44 +0000 (14:48 +0900)]
Fix build error in 64bit profile
Change-Id: Iaf71b5f63c361b1942fc9b418720b9fa47aa354d
Ji-hoon Lee [Wed, 17 Nov 2021 04:17:12 +0000 (13:17 +0900)]
Merge branch 'tizen' into tizen_6.5
Change-Id: I3aace61b867207bd99cd70cd4cb21670babd2080
Ji-hoon Lee [Wed, 10 Nov 2021 14:59:06 +0000 (23:59 +0900)]
Add audio data transmission mileage in thread safe way
Change-Id: I6de9199e4c70ec3f04682a52add02a2164e2eb5c
Ji-hoon Lee [Wed, 10 Nov 2021 12:45:45 +0000 (21:45 +0900)]
Execute background volume control command in a separate thread
Change-Id: I1f07ef289514850cc179eb7cd2ff8c16b2918b31
Ji-hoon Lee [Wed, 10 Nov 2021 12:44:52 +0000 (21:44 +0900)]
Add audio data mileage and long-running dbus events in logs
Change-Id: Iba38154d8bf3d3bdcf59658679c8b6108a1bc789
Ji-hoon Lee [Wed, 10 Nov 2021 05:40:47 +0000 (14:40 +0900)]
Bump version to 0.3.26
Change-Id: I26f1ec4f35754a8ed757609f556c26fdf94a6710
wn.jang [Tue, 9 Nov 2021 02:02:05 +0000 (11:02 +0900)]
Change localtime to localtime_r for thread safety
Change-Id: I809c8460625f2a10641252b6f0f43ec3853e12e6
Ji-hoon Lee [Fri, 5 Nov 2021 06:57:16 +0000 (15:57 +0900)]
Bump version to 0.3.25
Change-Id: I33c503dd82c26130c77ea8613b1f713c29ab5138
Ji-hoon Lee [Fri, 5 Nov 2021 06:51:38 +0000 (15:51 +0900)]
Add lock to avoid race condition and add more log messages
Change-Id: I52f7022d9e9ec2df82b09f45e32a7fd8b63aa041
Ji-hoon Lee [Fri, 29 Oct 2021 05:35:37 +0000 (14:35 +0900)]
Add more log messages to the ERROR level group
Change-Id: Ic0cffc1ce5f0a422a8947cd50944bbfc40e90526
Ji-hoon Lee [Thu, 28 Oct 2021 11:19:11 +0000 (20:19 +0900)]
Send voice key status after recording control
Change-Id: I0df6b18411a218ec5eb271fc6dba6858276db74b
Ji-hoon Lee [Thu, 28 Oct 2021 08:07:48 +0000 (17:07 +0900)]
Bump version to 0.3.24
Change-Id: I2bfd26b2f4636651ad802374d13d96ff0879b898
Ji-hoon Lee [Thu, 28 Oct 2021 07:53:22 +0000 (16:53 +0900)]
Restore background volume if last requester gets deactivated
Change-Id: I8e70185d093741ff87a7084a915d65453c385f0d
Ji-hoon Lee [Thu, 21 Oct 2021 12:11:06 +0000 (21:11 +0900)]
Bump version to 0.3.23
Change-Id: I8517a5b7bb727d671fbdb9c0879977e53ea25f4d
Ji-hoon Lee [Thu, 21 Oct 2021 11:08:55 +0000 (20:08 +0900)]
Add retry logic in case open_connection fails
Change-Id: I24abf21cafcadb752f40fc4945114b3bbb2dbbe1
Ji-hoon Lee [Wed, 29 Sep 2021 09:17:29 +0000 (18:17 +0900)]
Fix memory leak issue found while running tests
Change-Id: Id4509ed014382aab7938d06ce7920fb9478f8ccf
Ji-hoon Lee [Mon, 27 Sep 2021 09:41:08 +0000 (18:41 +0900)]
Bump version to 0.3.22
Change-Id: Ibc1d76df5a8adb85f1bf0f5fbcee1806f5d7ca96
Ji-hoon Lee [Mon, 27 Sep 2021 09:15:11 +0000 (18:15 +0900)]
Retry at most 3 times if aul_app_get_appid_bypid() fails
If AMD and Launchpad is busy processing other tasks,
it might not respond to aul_app_get_appid_bypid() request
in its timeout limit, which is 5 seconds.
For this reason, after discussing with AppFW team,
we decided to add a retry logic at most 3 times if
the given function unexpectedly fails.
[==========] Running 4 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 4 tests from DefaultFixture
[ RUN ] DefaultFixture.HardcodedAppIDReturnedForHardcodedPID
[ OK ] DefaultFixture.HardcodedAppIDReturnedForHardcodedPID (0 ms)
[ RUN ] DefaultFixture.AppIDNotFoundForNonExistingPID
[ OK ] DefaultFixture.AppIDNotFoundForNonExistingPID (0 ms)
[ RUN ] DefaultFixture.RetriesForAtLeastThreeTimes
[ OK ] DefaultFixture.RetriesForAtLeastThreeTimes (0 ms)
[ RUN ] DefaultFixture.RetriesNoMoreThanThreeTimes
[ OK ] DefaultFixture.RetriesNoMoreThanThreeTimes (0 ms)
[----------] 4 tests from DefaultFixture (0 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test suite ran. (0 ms total)
[ PASSED ] 4 tests.
Change-Id: I49d42e6d664cf1bead1a00fb088ac0c8c2933514
Ji-hoon Lee [Fri, 24 Sep 2021 10:36:13 +0000 (19:36 +0900)]
Add more tests for verifying the behavior of CAudioManager class
Previously, only a single test was available for CAudioManager class,
which definitely is not an adequate number to verify its behavior.
For this reason, added more tests to verify the current implementation
of CAudioManager class and also to guarantee the future modification
will not cause any unexpected results.
[==========] Running 11 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 11 tests from DefaultFixture
[ RUN ] DefaultFixture.StreamsAllDataFed
[ OK ] DefaultFixture.StreamsAllDataFed (1 ms)
[ RUN ] DefaultFixture.StreamsAllDataFedAfterClear
[ OK ] DefaultFixture.StreamsAllDataFedAfterClear (0 ms)
[ RUN ] DefaultFixture.OnRecordingAudioDataCallbackProperlyCalled
[ OK ] DefaultFixture.OnRecordingAudioDataCallbackProperlyCalled (1 ms)
[ RUN ] DefaultFixture.OnRecordingAudioDataCallbackProperlyCalledAfterFinalizing
[ OK ] DefaultFixture.OnRecordingAudioDataCallbackProperlyCalledAfterFinalizing (0 ms)
[ RUN ] DefaultFixture.RecordingStartsWhenRequestedWithSoundFocus
[ OK ] DefaultFixture.RecordingStartsWhenRequestedWithSoundFocus (0 ms)
[ RUN ] DefaultFixture.RecordingDoesNotStartWhenRequestedWithSoundFocus
[ OK ] DefaultFixture.RecordingDoesNotStartWhenRequestedWithSoundFocus (0 ms)
[ RUN ] DefaultFixture.RecordingStopsWhenRequested
[ OK ] DefaultFixture.RecordingStopsWhenRequested (0 ms)
[ RUN ] DefaultFixture.RecordingStopsWhenSoundFocusLost
[ OK ] DefaultFixture.RecordingStopsWhenSoundFocusLost (0 ms)
[ RUN ] DefaultFixture.RecordingStartsWhenSoundFocusAcquiredAgain
[ OK ] DefaultFixture.RecordingStartsWhenSoundFocusAcquiredAgain (0 ms)
[ RUN ] DefaultFixture.RecordingStartsWhenSoundFocusAcquiredLater
[ OK ] DefaultFixture.RecordingStartsWhenSoundFocusAcquiredLater (0 ms)
[ RUN ] DefaultFixture.RecordingDoesNotStartWhenSoundFocusAcquiredAgainIfStopped
[ OK ] DefaultFixture.RecordingDoesNotStartWhenSoundFocusAcquiredAgainIfStopped (0 ms)
[----------] 11 tests from DefaultFixture (2 ms total)
[----------] Global test environment tear-down
[==========] 11 tests from 1 test suite ran. (2 ms total)
[ PASSED ] 11 tests.
Change-Id: I50939d259e0b4f1072c6f7e1e2948ea1856eae38
Ji-hoon Lee [Fri, 24 Sep 2021 07:59:40 +0000 (16:59 +0900)]
Add tests for verifying the behavior of CWakeupManager
To make sure the modification made to CWakeupManager
would not cause any unexpected side-effect especially
on the observer modules, added tests for checking the
behavioral correctness of each operations.
[==========] Running 10 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 10 tests from DefaultFixture
[ RUN ] DefaultFixture.SettingValueObserverCalledWhenLanguageChanges
[ OK ] DefaultFixture.SettingValueObserverCalledWhenLanguageChanges (2 ms)
[ RUN ] DefaultFixture.SettingValueObserverCalledWhenAssistantAdded
[ OK ] DefaultFixture.SettingValueObserverCalledWhenAssistantAdded (2 ms)
[ RUN ] DefaultFixture.SettingValueObserverCalledWhenAssistantDeleted
[ OK ] DefaultFixture.SettingValueObserverCalledWhenAssistantDeleted (2 ms)
[ RUN ] DefaultFixture.WakeupEventNotTriggeredWhenInactiveMode
[ OK ] DefaultFixture.WakeupEventNotTriggeredWhenInactiveMode (1 ms)
[ RUN ] DefaultFixture.WakeupEventTriggeredWhenVoiceKeyGetsPressed
[ OK ] DefaultFixture.WakeupEventTriggeredWhenVoiceKeyGetsPressed (1 ms)
[ RUN ] DefaultFixture.AudioDataReceivedWhenVoiceKeyGetsPressed
[ OK ] DefaultFixture.AudioDataReceivedWhenVoiceKeyGetsPressed (12 ms)
[ RUN ] DefaultFixture.FinishAudioDataReceivedWhenStoppedBeforeReleasingWithInterval
[ OK ] DefaultFixture.FinishAudioDataReceivedWhenStoppedBeforeReleasingWithInterval (604 ms)
[ RUN ] DefaultFixture.FinishAudioDataReceivedWhenStoppedBeforeReleasingWithoutInterval
[ OK ] DefaultFixture.FinishAudioDataReceivedWhenStoppedBeforeReleasingWithoutInterval (303 ms)
[ RUN ] DefaultFixture.FinishAudioDataReceivedOnResultBeforeReleasingWithInterval
[ OK ] DefaultFixture.FinishAudioDataReceivedOnResultBeforeReleasingWithInterval (607 ms)
[ RUN ] DefaultFixture.FinishAudioDataReceivedOnResultBeforeReleasingWithoutInterval
[ OK ] DefaultFixture.FinishAudioDataReceivedOnResultBeforeReleasingWithoutInterval (303 ms)
[----------] 10 tests from DefaultFixture (1837 ms total)
[----------] Global test environment tear-down
[==========] 10 tests from 1 test suite ran. (1837 ms total)
[ PASSED ] 10 tests.
Change-Id: I95054494410f2583874e94cd48277cc205dc1353
Ji-hoon Lee [Tue, 7 Sep 2021 05:59:37 +0000 (14:59 +0900)]
Bump version to 0.3.21
Change-Id: I6865542b46dafda9670e8f6fd73ea3c52b9a56dc
Ji-hoon Lee [Mon, 6 Sep 2021 12:00:04 +0000 (21:00 +0900)]
Make string members of wakeup event struct to be deep copied
This fixes the problem found when running the previously added test.
[ RUN ] DefaultFixture.WakeupEventInfoPreservedForStringLiterals
[ OK ] DefaultFixture.WakeupEventInfoPreservedForStringLiterals (2 ms)
[ RUN ] DefaultFixture.WakeupEventInfoPreservedForDynamicallyAllocatedStrings
[ OK ] DefaultFixture.WakeupEventInfoPreservedForDynamicallyAllocatedStrings (0 ms)
[----------] 2 tests from DefaultFixture (2 ms total)
Change-Id: I24fecd9a78767beda7fafce67f69fae6d53ebf1d
Ji-hoon Lee [Mon, 6 Sep 2021 12:04:50 +0000 (21:04 +0900)]
Add tests for wakeup-policy-default
These new tests shows that the existing WakeupPolicyDefault
store the string values using shallow copy method and thus
accessing the string value on timer expired event might cause
unexpected behavior.
[ RUN ] DefaultFixture.WakeupEventInfoPreservedForStringLiterals
[ OK ] DefaultFixture.WakeupEventInfoPreservedForStringLiterals (1 ms)
[ RUN ] DefaultFixture.WakeupEventInfoPreservedForDynamicallyAllocatedStrings
/home/abuild/ttpo/tests/test_main.cpp:128: Failure
Expected equality of these values:
mWakeupAppID.compare(appid)
Which is: -5
0
[ FAILED ] DefaultFixture.WakeupEventInfoPreservedForDynamicallyAllocatedStrings (1 ms)
Change-Id: I3fe82b3269cff96e74de1bbf86e0c2a9ffba2fc2
Ji-hoon Lee [Mon, 6 Sep 2021 10:25:24 +0000 (19:25 +0900)]
Fix build error in test code caused by a base type change
Change-Id: Icabc735fba71657d871baaf5049cf3e063f1c33d
Ji-hoon Lee [Fri, 13 Aug 2021 07:21:35 +0000 (16:21 +0900)]
Bump version to 0.3.20
Change-Id: I8a37b70f83315e382db4b7c35c8e19cffd8dfbf4
Ji-hoon Lee [Fri, 13 Aug 2021 07:17:20 +0000 (16:17 +0900)]
Fix defects detected by static analysis tool
Change-Id: I4a6ca3464e5a9c9c54b034fe7fa7f8a3577a7493
Ji-hoon Lee [Wed, 11 Aug 2021 06:20:50 +0000 (15:20 +0900)]
Fix defects detected by static analysis tool
Change-Id: I31b8d14b703b4e86693fe5dbbcae98f004380848
Ji-hoon Lee [Tue, 10 Aug 2021 05:40:42 +0000 (14:40 +0900)]
Bump version to 0.3.19
Change-Id: I757f7140a29a080b71470c32087d187d5024ca0a
Ji-hoon Lee [Tue, 10 Aug 2021 05:26:04 +0000 (14:26 +0900)]
Revert "Revert "Use trusted message port for secure audio transmission""
This reverts commit
46fe031f38df204e591eaddb99e22d93d1d3964d.
Change-Id: I360abb42e85a73fd8bc13ac5108c323115a262fb
Ji-hoon Lee [Tue, 10 Aug 2021 05:25:55 +0000 (14:25 +0900)]
Merge branch 'tizen_6.0' into tizen
Change-Id: I51d38a7e2b5dd59d359cb7fd1dc99fbbc6d5aa0d
Ji-hoon Lee [Mon, 9 Aug 2021 04:58:24 +0000 (13:58 +0900)]
Bump version to 0.3.18
Change-Id: I5007c7ba46627ea43fdcf205530dfb6fc9179c26
Ji-hoon Lee [Mon, 9 Aug 2021 04:57:27 +0000 (13:57 +0900)]
Fix crash when specified wakeup engine does not exist
Change-Id: I6e26ba9dc10031c45886491e9e1235602ebfca0b
Ji-hoon Lee [Tue, 3 Aug 2021 11:30:55 +0000 (20:30 +0900)]
Fix build break in 64bit profile
Change-Id: I2e525632de5565d824ac7c6e19002f78054f2715
Ji-hoon Lee [Tue, 3 Aug 2021 07:11:25 +0000 (16:11 +0900)]
Bump version to 0.3.17
Change-Id: I2af56339b0b723a74af66ec4e1b57a361c4acfad
Ji-hoon Lee [Mon, 2 Aug 2021 13:33:16 +0000 (22:33 +0900)]
Fix log not printed bug and add more log messages
Change-Id: I922eeb94469d52a8b47882a3f51412687e6877e2
Ji-hoon Lee [Tue, 27 Jul 2021 05:27:43 +0000 (14:27 +0900)]
Prevent buffer overflow in case the audio data size is too large
Change-Id: Ibfe33f6baec68667fe5f82371d5374a9889b36e1
Ji-hoon Lee [Fri, 23 Jul 2021 03:18:21 +0000 (12:18 +0900)]
Add minimum flush time constraint
Change-Id: If353d23ae3995f7e9e945053da82debc4b6672fe
Ji-hoon Lee [Thu, 29 Apr 2021 08:19:04 +0000 (17:19 +0900)]
Support multiple wakeup engines for single assistant
Change-Id: I417c1692707274eb2a727151f446fa6f170475e7
Ji-hoon Lee [Tue, 24 May 2016 23:09:33 +0000 (08:09 +0900)]
Fix errors found while adding tests for CPackageUpdateMonitor
While adding new tests for CPackageUpdateMonitor,
unexpected errors were found and fixed the main cause
that the 'ret' variable was used for both application
filter result and the function invocation result.
Since all the errors found while adding new tests are fixed,
the existing package related code is now replaced with the
CPackageUpdateMonitor class implementation.
Change-Id: Ia3af5644ac41aaae26248456103d042a76031fe2
Ji-hoon Lee [Fri, 25 Jun 2021 10:48:34 +0000 (19:48 +0900)]
Extract package update monitor class and add test cases
Since the Package Update Monitor feature can be isolated
in a separate class, first copied the existing code
into a new class and added tests for verifying the
behavior of the new class.
While extracting, it was required to extract client info
struct into a new class also to avoid circular dependency.
At the moment, the newly extracted CClientInfo is not
well-organized, merely a struct revealing internal member
variable. This should be refactored in the future also.
Change-Id: I179540b5ba2890d40d4e1440a8e88861863dc416
Ji-hoon Lee [Tue, 8 Jun 2021 07:45:51 +0000 (16:45 +0900)]
Fix build break
Change-Id: Ie8824f8d6377d8299bcd7319e1d568833884b226
Ji-hoon Lee [Wed, 26 May 2021 12:53:39 +0000 (21:53 +0900)]
Access audio buffer mutually exclusive using state variable
The previous implementation replies on the thread's
joinable value, which is not set back to false
if the thread exits but no join() gets called.
For this reason, use a dedicated state variable
instead of joinable state, which correctly reflects
the active state of the streaming thread.
Change-Id: I1596a4649109011f8acb412896bfe9fdbefb7e05
wn.jang [Fri, 21 May 2021 02:05:26 +0000 (11:05 +0900)]
Fix bug detected from static analysis tool
Change-Id: I044c80d5d5f291adaed1b49d21a06da621907341
Ji-hoon Lee [Tue, 11 May 2021 07:42:21 +0000 (16:42 +0900)]
Disable popping from audio buffer when streaming is activated
Streaming thread reads content of audio buffer, so when the
streaming thread is joinable, modifying the buffer itself
can invalidate iterators associated with the buffer container,
which might cause an undefined behavior. For this reason,
limiting the maximum size of the buffer by popping from it
should be disabled when streaming thread is joinable.
Change-Id: I7cea5460cda6abdbee770c6b2818861a35f0080b
Ji-hoon Lee [Wed, 21 Apr 2021 11:39:20 +0000 (20:39 +0900)]
Bump version to 0.3.18
Change-Id: I4b4c94013988f12449e48df5fd689e471238e392
Ji-hoon Lee [Thu, 18 Feb 2021 02:25:21 +0000 (11:25 +0900)]
Add display privilege
Change-Id: I3704b99abb51bab2c658316785a74e42439ae5d8
Ji-hoon Lee [Mon, 29 Mar 2021 02:02:10 +0000 (11:02 +0900)]
Fix defects detected by static analysis tool
Change-Id: I63d6070426e1782484ba683979e16e3eff4d06fe
Ji-hoon Lee [Thu, 18 Feb 2021 02:25:21 +0000 (11:25 +0900)]
Add display privilege
Change-Id: I3704b99abb51bab2c658316785a74e42439ae5d8
Ji-hoon Lee [Wed, 3 Feb 2021 08:28:22 +0000 (17:28 +0900)]
Bump version to 0.3.17
Change-Id: Ie431ca79ce640d483822e5693fb5b876d4928dc8