ANZ1217 [Tue, 7 Jan 2025 08:41:24 +0000 (17:41 +0900)]
Update emoji variation sequences to Version 16.0
Change-Id: I86f91ac9fb539187e148580232cc25bab8f2c459
Eunki Hong [Thu, 2 Jan 2025 15:01:56 +0000 (00:01 +0900)]
Print infomation if we create eglSurface from Native if need
Change-Id: I8c45c8e228b8ba9afdf3e4606a012309081db8a4
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Youngsun Suh [Mon, 23 Dec 2024 02:20:05 +0000 (11:20 +0900)]
a11y refactor: Remove mKnownObjects
mKnownObjects is redundant as we already store accessbles in a map in bridge-impl.
Removig the data and update the path calculation logic.wq
Change-Id: I40899257ab293f2afe0bcdf9c3a7791dbc4e88bc
Eunki, Hong [Mon, 30 Dec 2024 11:14:10 +0000 (20:14 +0900)]
Do not call RequestUpdateOnce, instead Deiconify
We can only assume that Deiconify signal can assume that window is valid.
Other API is just kind of request to window server, so we could not send
rendering forcibly.
Change-Id: I6d6b9348d4661efb241cb6aa24209346d908f5de
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Tue, 24 Dec 2024 11:27:50 +0000 (20:27 +0900)]
Skip Rendering if native texture not prepared
We should not render the program if texture was not prepared.
Also, if CreateResource failed, mEglImageExtensions might be nullptr.
So we need to make a nullptr check if CreateResource failed, and try to
call other API, like PrepareTexture().
Change-Id: Ic22ba6500faec496f94e6cc2f0cfdcd502bf3999
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Youngsun Suh [Mon, 23 Dec 2024 00:23:29 +0000 (00:23 +0000)]
Merge "Add DumpTree api" into devel/master
David Steele [Fri, 20 Dec 2024 15:49:36 +0000 (15:49 +0000)]
Merge "DALi Version 2.4.0" into devel/master
Adeel Kazmi [Fri, 20 Dec 2024 11:36:49 +0000 (11:36 +0000)]
DALi Version 2.4.0
Change-Id: I9a8de8ca55a3702fae786ddbe1f1d947db8c20d6
Eunki, Hong [Wed, 18 Dec 2024 08:38:12 +0000 (17:38 +0900)]
Support CURLOPT_MAXREDIRS as environment + Print downloaded buffer if image load failed
Let we add environment value to control CURLOPT_MAXREDIRS.
Sometimes the redirection count 5 might too small to some applications.
Let we allow to them use more deep depth.
+
Sometimes, we failed to get valid image buffer from given url.
To check whether that url download real-image or not,
let we print prefix of buffers.
Change-Id: I5053ff539da684357d0c5e73d7d57c36423aa976
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Wed, 18 Dec 2024 17:26:41 +0000 (17:26 +0000)]
Fixed both the GLES & VK builds for LibUV-X11 & GLIB profiles
Change-Id: I5bab5c28a90f4c34aff9f143d758403ea07ec99c
Adeel Kazmi [Wed, 18 Dec 2024 15:40:19 +0000 (15:40 +0000)]
Merge "Allow Capture files to be built for Vulkan too" into devel/master
Eunki Hong [Wed, 18 Dec 2024 00:41:43 +0000 (00:41 +0000)]
Merge changes Ia50a8092,Ieb8d5c62 into devel/master
* changes:
Call glFlush after create sync
(TV only) Create NativeTexture sync after eglSwapBuffer
Adeel Kazmi [Tue, 17 Dec 2024 15:21:57 +0000 (15:21 +0000)]
Allow Capture files to be built for Vulkan too
- Added a check when creating Capture to only work with the GLES backend for now
- Only reason Capture taken out was because of NativeImage which is compiled in for
Vulkan, just not implemented yet.
Change-Id: Id471d44030ae9115e194deecd4ab6cf17f5eda08
Adeel Kazmi [Mon, 16 Dec 2024 12:07:37 +0000 (12:07 +0000)]
(GlWindowRenderThread) Cast to void* so that it works on Ubuntu
Change-Id: I07833987c8962aa035e9b4fc0a19db6ae7701dae
Eunki, Hong [Mon, 16 Dec 2024 07:53:33 +0000 (16:53 +0900)]
Call glFlush after create sync
It was mendentary job after call glFlush, or similar job between
create sync, and wait.
Let we call glFlush directly after create sync object.
Change-Id: Ia50a80929b6e6d33bfc299993f6513074460cfe1
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Fri, 13 Dec 2024 03:21:23 +0000 (12:21 +0900)]
(TV only) Create NativeTexture sync after eglSwapBuffer
Since eglCreateSyncKHR try to allocate full buffer scene at GPU side,
it will increase GPU memory.
It might not a common sense but, let we make eglCreateSyncKHR called
after eglSwapBuffer or glFlush called.
Additionary, let we call glFlush after create sync object.
Since we cannot assume that eglSwapBuffer will be called after now.
Note : This logic only be used for TV profile.
Is it required for common platform?
Change-Id: Ieb8d5c62e9e86fc95c3cc79310e26bcaeea2eb25
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Mon, 16 Dec 2024 08:36:15 +0000 (08:36 +0000)]
(Tizen Wayland) Further separate out vulkan & gles implementation
Change-Id: I100ad6e06fd62fc4a210d0ce5a13c29b326bab21
Adeel Kazmi [Mon, 16 Dec 2024 09:15:05 +0000 (09:15 +0000)]
Merge "Remove unused Pre-Tizen5 Options" into devel/master
Youngsun Suh [Mon, 11 Nov 2024 01:30:42 +0000 (10:30 +0900)]
Add DumpTree api
Change-Id: I997178022d5ad97a632aed580fb01704ca1665d8
Eunki Hong [Sat, 14 Dec 2024 05:59:55 +0000 (14:59 +0900)]
Print error logs before execute callback
Since we throw assert at callback if FD_ERROR occured,
we should print error logs before execute callback.
Change-Id: I8f498b020e0f9da505b6ca8847c953b0d2e7d280
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Fri, 13 Dec 2024 20:01:54 +0000 (20:01 +0000)]
Remove unused Pre-Tizen5 Options
Change-Id: I36f3d81fb3177a4a57da21766695a24bac8c9d27
Adeel Kazmi [Fri, 13 Dec 2024 18:48:48 +0000 (18:48 +0000)]
Fix build break with TV profile with Vulkan Build
Change-Id: I39eaa488ce6d65faf8a0aeb8c23fd03965346599
Adeel Kazmi [Fri, 13 Dec 2024 18:32:20 +0000 (18:32 +0000)]
Merge "Separate out EGL & VULKAN functionality in different files" into devel/master
Adeel Kazmi [Wed, 11 Dec 2024 15:18:42 +0000 (15:18 +0000)]
Separate out EGL & VULKAN functionality in different files
Change-Id: I52911ebd15e2e9be0b0f4d1fbc6df020041150ce
Adam Bialogonski [Fri, 13 Dec 2024 12:34:31 +0000 (12:34 +0000)]
Swapchain improvement
In some cases, usually during startup, we acquire a swapchain image but never consume it because there is no render pass started. This leaves acquire image semaphores in the signaled state and breaks synchronization when same image is about to be acquire frames later (depends on driver, it may be ignored or it may lead to deadlock).
Since we assume that only one render pass starts for each surface we acquire the image only when such render pass starts (so we have something to render). This also removes "default" AcquireNextFramebuffer() function in the controller which assumes we have a single window only.
The infinite acquire timeout has been replaced with arbitrary
1000000000 value which makes sure we won't get into the deadlock state (vkAcquireNextImageKHR() will return timeout error) but should be enough to acquire next image.
The assert that used to crash the demos happens only on return of error code (timeout and not_ready aren't errors).
Change-Id: Idd872c8fcde80ecb1f5c71fd587564e210ea3a9d
David Steele [Fri, 13 Dec 2024 09:52:46 +0000 (09:52 +0000)]
Merge "DALi Version 2.3.54" into devel/master
Adam Bialogonski [Fri, 13 Dec 2024 08:09:13 +0000 (08:09 +0000)]
DALi Version 2.3.54
Change-Id: Ibf7dfa0476a13efdd9d3841674e0ab7099fa08ca
Eunki Hong [Fri, 13 Dec 2024 02:12:34 +0000 (02:12 +0000)]
Merge "Add debug log if eventfd trigger, or triggered" into devel/master
Eunki Hong [Fri, 13 Dec 2024 02:12:28 +0000 (02:12 +0000)]
Merge "Let TV profile print debug level logs as INFO level also" into devel/master
Eunki Hong [Fri, 13 Dec 2024 02:12:22 +0000 (02:12 +0000)]
Merge "Print log for application and tizen frameworks" into devel/master
Eunki Hong [Thu, 12 Dec 2024 12:19:13 +0000 (12:19 +0000)]
Merge "Fix build error for tbm_dummy_display() getter" into devel/master
Adeel Kazmi [Thu, 12 Dec 2024 10:23:51 +0000 (10:23 +0000)]
Merge "Moved program resource hints to Controller" into devel/master
Eunki, Hong [Thu, 12 Dec 2024 10:07:52 +0000 (19:07 +0900)]
Fix build error for tbm_dummy_display() getter
Change-Id: Ief713838b516be4ff0fda18a9ab8297973b52d33
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Thu, 12 Dec 2024 09:06:03 +0000 (18:06 +0900)]
Add debug log if eventfd trigger, or triggered
Change-Id: If2933b1bbae34b30cabac2e9849b9bbcf12c2bf5
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Thu, 12 Dec 2024 08:23:35 +0000 (17:23 +0900)]
Let TV profile print debug level logs as INFO level also
Change-Id: I46750e96ade246bf9c080ae9986cfb8e8cd52f1e
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Thu, 12 Dec 2024 01:55:57 +0000 (10:55 +0900)]
Print log for application and tizen frameworks
Change-Id: I9835e2b5d2d6e67dd5becd15d517fcd3eefcef72
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Fri, 6 Dec 2024 05:19:17 +0000 (14:19 +0900)]
Block some codes by macro what tizen_8.0 not supported
Let we make dali codes compiled by tizen_8.0 repo
Change-Id: I93527b0dada9fbe11f74a37f62d9c6325d925964
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
David Steele [Tue, 10 Dec 2024 14:33:11 +0000 (14:33 +0000)]
Moved program resource hints to Controller
Moved the program resource binding hints from CommandBuffer::Begin()
info struct to Egl/Vulkan Controller::SetResourceBindingHints().
This is now per scene, rather than per command buffer, as we want to
split up the scene into offscreen cmd buffers & onscreen cmd buffer.
At the moment, this is used in Vulkan to allocate descriptor pools.
Change-Id: I61bdc4840a800b52863bd676a1244b290192ccc8
Signed-off-by: David Steele <david.steele@samsung.com>
Eunki Hong [Tue, 10 Dec 2024 05:46:08 +0000 (05:46 +0000)]
Merge "Remove null-terminate character as size of shader code" into devel/master
Eunki Hong [Tue, 10 Dec 2024 05:45:56 +0000 (05:45 +0000)]
Merge "Make NativeDisplay keep as global static value" into devel/master
Eunki, Hong [Wed, 4 Dec 2024 07:22:08 +0000 (16:22 +0900)]
Ensure to destroy eglSyncObject at the same context of creation
To make ensure the eglSyncObject destroy at the same context of write,
let we collect discarded objects per each GLES::Context, and release them
when the context be current, after PostRender().
Furthermore, Let we destroy the sync objects before
content be destroyed.
And also, let we make TextureDependency use SyncObjectId
instead of AgingSyncObject* directly.
So, we don't need to notify context invalidated to
TextureDependency class. If some sync object deleted due to
context destruction, SyncObjectId will return nullptr from
SyncPool. So we only need to notify pool only.
Change-Id: I8fed7d3fecad7f9e11d4db686ae2271106f588d3
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Thu, 5 Dec 2024 00:35:47 +0000 (09:35 +0900)]
Remove null-terminate character as size of shader code
Follow by glShaderSource spec, we should not include null-terminate
character as size value.
Change-Id: I6773cd5f9c65c456c9aa44bafb3bedf44769386d
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 4 Dec 2024 23:56:57 +0000 (08:56 +0900)]
Make NativeDisplay keep as global static value
Let we keep native display as static variable.
So it will return same pointer even if we Terminate & Restart
OffscreenWindow
More detail, Follow by eglSpec, eglGetDipslay() creates new EGLDisplay per each input paramater,
and never be deleted until process terminated. But we can re-create DisplayConnecter multiple times
when we are using OffscreenApplication.
So, we need to keep dummy NativeDisplay pointer to avoid creating multiple EGLDisplay creation leak.
Change-Id: I5d5ff5638c3da0d9a3c94a22b27e35d07b09bb45
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Richard Huang [Fri, 6 Dec 2024 11:48:20 +0000 (11:48 +0000)]
DALi Version 2.3.53
Change-Id: I8b0cace5af57938d0f488d0072e94e2e488fd3d8
Adeel Kazmi [Thu, 5 Dec 2024 11:17:31 +0000 (11:17 +0000)]
Merge "DALi dynamic depth-stencil states for API 1.2" into devel/master
Adam Bialogonski [Tue, 3 Dec 2024 13:28:56 +0000 (13:28 +0000)]
DALi dynamic depth-stencil states for API 1.2
Change-Id: Ibbf5459bd8e529d95f0f2a944a5ee485a0d334b7
Youngsun Suh [Wed, 4 Dec 2024 08:03:21 +0000 (17:03 +0900)]
Make sure Emit* is only enabled for ActorAccessible
Change-Id: Ia6b3525f9a93aa1d7e4a5361890ee7e62ea1bb11
Eunki Hong [Wed, 4 Dec 2024 06:06:20 +0000 (06:06 +0000)]
Merge "Do not append \0 if we already add \0" into devel/master
Eunki, Hong [Wed, 4 Dec 2024 05:01:46 +0000 (14:01 +0900)]
Do not append \0 if we already add \0
Tizen emulator driver don't support string with end by \0\0.
Let we avoid this case.
Change-Id: Ie5285c3917ba6ef71dcb108f7c2d29f1b18e4d62
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 4 Dec 2024 02:46:50 +0000 (11:46 +0900)]
Free sync object immediately if current context is same as created context
Until now, we usually destroy sync object at surfaceless context
at the end of rendering.
But it might have some context switching overhead occured for some driver.
To avoid it, let we try to free sync object if read context is
same as write context, and it is already synced.
Change-Id: Ibec3cb40379ad341ff757362ee6cb529806153a3
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Seungho Baek [Fri, 15 Nov 2024 06:55:04 +0000 (15:55 +0900)]
Keep rendered buffer in framebuffer
Change-Id: I20d7bdb2541a41eae1a440e25ad96c88e216923d
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
Adeel Kazmi [Wed, 16 Oct 2024 21:21:44 +0000 (22:21 +0100)]
Add function & environment option to choose graphics backend
Change-Id: If40ae6f65fcc52a4e08f06dfecfd60413ca40421
David Steele [Fri, 29 Nov 2024 14:14:18 +0000 (14:14 +0000)]
DALi Version 2.3.52
Change-Id: I67da105affdfa18d29602a975b9c5e8981a361c3
Eunki Hong [Thu, 28 Nov 2024 12:49:03 +0000 (21:49 +0900)]
Fix gcc-14 compile error : gles-texture-dependency-checker.h
Change-Id: Ifd57c3ded4b5deed50be63bb5d0265d005c4bff0
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
joogab yun [Wed, 27 Nov 2024 04:25:44 +0000 (04:25 +0000)]
Merge "Add KeyEventMonitorSignal" into devel/master
joogab.yun [Tue, 26 Nov 2024 06:34:02 +0000 (15:34 +0900)]
Add KeyEventMonitorSignal
Change-Id: If898a915deeb74a827ea868d3eca91ddc57144a3
Jaehyun Cho [Tue, 26 Nov 2024 03:38:53 +0000 (03:38 +0000)]
Merge "Fix eldbus methods creating MessagePtr to deallocate Eldbus_Message" into devel/master
Hosang Kim [Fri, 14 Jun 2024 07:38:05 +0000 (16:38 +0900)]
[Tizen] Fix memory leak of A11y
Fix issue where StringStorage is not cleared when A11y is forced down
Change-Id: Ic999a473850ee1c0f1f60e4343b4ca37e81fbcb5
Eunki Hong [Tue, 26 Nov 2024 01:18:44 +0000 (01:18 +0000)]
Merge "Use Dali::Integration::TimeChecker feature instead duplicate macro (phase 2)" into devel/master
Eunki Hong [Tue, 26 Nov 2024 01:18:04 +0000 (01:18 +0000)]
Merge "Use Dali::Integration::TimeChecker feature instead duplicate macro (phase 1)" into devel/master
Eunki Hong [Tue, 26 Nov 2024 01:17:55 +0000 (01:17 +0000)]
Merge changes I5068bdac,I45974dc1 into devel/master
* changes:
Let we add self-depenedency check for native texture
Print log for extension and sync case + Use OrderedSet for EglSyncObject
Eunki Hong [Mon, 25 Nov 2024 14:43:34 +0000 (14:43 +0000)]
Merge "Print some logs for initialize UpdateRenderThread + Revert TV profile trace block" into devel/master
Eunki Hong [Mon, 25 Nov 2024 14:43:08 +0000 (14:43 +0000)]
Merge "(CanvasRenderer) Let we use CanvasRenderer use queue size 2 as default + Cancel old buffer if dequeue failed" into devel/master
Jeongmin Lee [Mon, 25 Nov 2024 12:10:15 +0000 (12:10 +0000)]
Merge "Fix ecore_device_class_get(address out of buffer)" into devel/master
Eunki, Hong [Mon, 25 Nov 2024 11:02:57 +0000 (20:02 +0900)]
Use Dali::Integration::TimeChecker feature instead duplicate macro (phase 2)
Let we use Dali::Integration::TimeChecker feature for ecore wl2
Change-Id: Id10a8fc627be9ab23c06b3ff7042a2e759f0b6ee
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Thu, 14 Nov 2024 01:59:53 +0000 (10:59 +0900)]
Let we add self-depenedency check for native texture
Since GPU don't assume that NativeImage read done after eglSwapBuffer,
We should add syncFence manually, and check whether previous tbm render done.
But synce eglCreateSync spend a lots of time, we should create only 1 time per
each frame.
TODO : We don't need to client-wait for non-acquried case. But it need to open
new API for NativeImageInterface. So let we implement it later.
Change-Id: I5068bdac203850b241d330e01f23abb312b1da16
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 13 Nov 2024 07:42:44 +0000 (16:42 +0900)]
Print log for extension and sync case + Use OrderedSet for EglSyncObject
Let we also check extension API using duration check if environment enabled.
+
Do not spend time to erase SyncObject finding.
It will spend time without no reason.
Change-Id: I45974dc12031298959619bc5bda96b39264de11b
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Thu, 21 Nov 2024 11:35:33 +0000 (20:35 +0900)]
Use Dali::Integration::TimeChecker feature instead duplicate macro (phase 1)
Let we use Dali::Integration::TimeChecker feature for gles
Change-Id: I13f6f7f9015e38a4df9dc29333c91e459935449d
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Fri, 22 Nov 2024 04:36:12 +0000 (13:36 +0900)]
Print some logs for initialize UpdateRenderThread + Revert TV profile trace block
Change-Id: Ic6f3f82598afd9d4690a48e040f5592c6ce113ff
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 20 Nov 2024 05:38:27 +0000 (14:38 +0900)]
(CanvasRenderer) Let we use CanvasRenderer use queue size 2 as default + Cancel old buffer if dequeue failed
Since we don't have good timing to free-release remained buffer,
let we just use tbm_surface_queue_h has 2
+
Let we ignore latest queued image if dequeue failed.
In this case, we can ensure that success queued buffer is always
latest buffer now.
Change-Id: I8e49b6d56fc3b6b60cdae9647b998c7baea52dec
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
jmm [Wed, 20 Nov 2024 11:15:07 +0000 (20:15 +0900)]
Fix ecore_device_class_get(address out of buffer)
Change-Id: I135ae8d0e01e38ba0657382f0040d755dab463ba
David Steele [Fri, 22 Nov 2024 16:04:37 +0000 (16:04 +0000)]
Merge "DALi Version 2.3.51" into devel/master
Adeel Kazmi [Fri, 22 Nov 2024 16:03:04 +0000 (16:03 +0000)]
DALi Version 2.3.51
Change-Id: Ic03990fe054b43633bb70df3aa61f8f3c1826921
Adeel Kazmi [Fri, 22 Nov 2024 11:51:21 +0000 (11:51 +0000)]
Merge "Shader Parser and SPIRV generator changes" into devel/master
Jaehyun Cho [Thu, 21 Nov 2024 06:25:02 +0000 (15:25 +0900)]
Fix eldbus methods creating MessagePtr to deallocate Eldbus_Message
When MessagePtr is created, Eldbus_Message is also created internally.
Therefore, when MessagePtr is destructed, the Eldbus_Message should be
deallocated as well to prevent memory leak.
So some methods creating MessagePtr are fixed to call
eldbus_message_unref for Eldbus_Message when MessagePtr is destructed.
To avoid double deallocation by calling eldbus_message_unref twice,
eldbus_connection_send_impl is fixed to release its MessagePtr argument.
Change-Id: I7f21a0f62ca54d1838e0742cad6331d4668e0aba
David Steele [Thu, 21 Nov 2024 16:24:16 +0000 (16:24 +0000)]
Merge "Skip GPU that doesn't support Vulkan 1.3 or above" into devel/master
David Steele [Thu, 21 Nov 2024 16:22:50 +0000 (16:22 +0000)]
Merge "Ensured clear color vector is the right size" into devel/master
Richard Huang [Thu, 21 Nov 2024 14:32:00 +0000 (14:32 +0000)]
Skip GPU that doesn't support Vulkan 1.3 or above
Change-Id: I61964212e086c848160be3e477444a36ca42a808
Eunki Hong [Thu, 21 Nov 2024 01:17:46 +0000 (10:17 +0900)]
Make ShaderPreCompiler as DALI_ADAPTOR_API
ShaderPreCompiler defined at dali-adaptor now.
Let we make matched keyword.
Change-Id: Ied0be58321f69da459e80f87a8dd0052e8ffd14b
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
David Steele [Wed, 20 Nov 2024 17:15:02 +0000 (17:15 +0000)]
Merge "Merged descriptor sets for shared UBOs" into devel/master
Adeel Kazmi [Wed, 20 Nov 2024 16:02:15 +0000 (16:02 +0000)]
Merge "Vulkan Tizen Build" into devel/master
Adeel Kazmi [Thu, 10 Oct 2024 16:05:22 +0000 (17:05 +0100)]
Vulkan Tizen Build
Change-Id: Ia119b4914d1f958a6e9ab726dd96934f7f3bb93d
Adam Bialogonski [Tue, 19 Nov 2024 15:35:12 +0000 (15:35 +0000)]
Shader Parser and SPIRV generator changes
- Assigning locations to in/out between stages when type is larger than 4 floats (mat2, mat3, mat4)
Example:
Vertex shader:
out (location=0) highp mat3 vMatrix;
out (location=3) highp float vNumber; // Location must be 3 not 1!
Fragment shader:
in (location=0) highp mat3 vMatrix;
in (location=3) highp float vNumber; // Location must be 3 not 1!
This patch doesn't deal with arrays and doesn't deal with input attributes in
vertex shader. It only resolves problem of default PBR shader.
- SPIRVGenerator::Generate() sates 'valid' flag correctly now (false on error)
Change-Id: I19ee9ac639baf30ef988a43c06ad6295f042c424
Eunki, Hong [Wed, 20 Nov 2024 02:26:44 +0000 (11:26 +0900)]
(ShaderParser) Fix coverity issue : don't copy std::string
Change-Id: Ib5784503a1a6520f5bce43659ce91728e0dc784c
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Mon, 18 Nov 2024 07:57:49 +0000 (16:57 +0900)]
Let we get ArrayElementStride by GL_UNIFORM_ARRAY_STRIDE
Since GL_UNIFORM_BLOCK_DATA_SIZE is implement-dependent value,
we'd better use more belief result from GetActiveUniformsiv with GL_UNIFORM_ARRAY_STRIDE
Change-Id: I1838babf21d8819a797f6b0f010c734dc71b9b5e
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Mon, 18 Nov 2024 02:27:39 +0000 (11:27 +0900)]
(ShaderParser) Fix compile error for #extension
There was compile error when #extension used before som other codes.
To avoid this kind of issue,
let we collect all extension prefix codes, and then define it after
version directly.
Relative logs :
623.248 E/DALI (P 854, T 6612): gles-graphics-shader.cpp: Compile(120) > Code: #version 320 es
623.248 E/DALI (P 854, T 6612): #ifdef GL_KHR_blend_equation_advanced
623.248 E/DALI (P 854, T 6612): #extension GL_KHR_blend_equation_advanced : enable
623.248 E/DALI (P 854, T 6612): #endif
623.248 E/DALI (P 854, T 6612): #if defined(GL_KHR_blend_equation_advanced) || __VERSION__>=320
623.248 E/DALI (P 854, T 6612): layout(blend_support_all_equations) out;
623.248 E/DALI (P 854, T 6612): #endif
623.248 E/DALI (P 854, T 6612): //@name image-visual-shader.frag
623.248 E/DALI (P 854, T 6612): #define TEXTURE texture
623.248 E/DALI (P 854, T 6612): #define TEXTURE_CUBE texture
623.248 E/DALI (P 854, T 6612): #define TEXTURE_LOD textureLod
623.248 E/DALI (P 854, T 6612): #define TEXTURE_CUBE_LOD textureLod
623.248 E/DALI (P 854, T 6612): #define textureCube texture
623.248 E/DALI (P 854, T 6612): #define texture2D texture
623.248 E/DALI (P 854, T 6612): #define texture2DLod textureLod
623.248 E/DALI (P 854, T 6612): #define textureCubeLod textureLod
623.248 E/DALI (P 854, T 6612):
623.248 E/DALI (P 854, T 6612): //@version 100
623.248 E/DALI (P 854, T 6612): #extension GL_OES_EGL_image_external_essl3:require
623.248 E/DALI (P 854, T 6612):
623.248 E/DALI (P 854, T 6612): in mediump vec2 vTexCoord;
623.248 E/DALI (P 854, T 6612): #if defined(IS_REQUIRED_DEBUG_VISUAL_SHADER) || defined(IS_REQUIRED_ROUNDED_CORNER) || defined(IS_REQUIRED_BORDERLINE)
623.248 E/DALI (P 854, T 6612): in highp vec2 vPosition;
623.248 E/DALI (P 854, T 6612): flat in highp vec2 vRectSize;
623.248 E/DALI (P 854, T 6612): flat in highp vec2 vOptRectSize;
623.248 E/DALI (P 854, T 6612): flat in highp float vAliasMargin;
623.248 E/DALI (P 854, T 6612): #ifdef IS_REQUIRED_ROUNDED_CORNER
623.248 E/DALI (P 854, T 6612): flat in highp vec4 vCornerRadius;
623.248 E/DALI (P 854, T 6612): #endif
623.248 E/DALI (P 854, T 6612): #endif
623.248 E/DALI (P 854, T 6612): #ifdef IS_REQUIRED_DEBUG_VISUAL_SH
623.248 E/DALI (P 854, T 6612): gles-graphics-shader.cpp: Compile(121) > glCompileShader() failed:
623.248 E/DALI (P 854, T 6612): 0:19: P0001: Extension directive must occur before any non-preprocessor tokens
Change-Id: Iac53008ae6d76acaee266f14db0526b54b0c4abd
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Sun, 17 Nov 2024 15:55:56 +0000 (00:55 +0900)]
(ShaderParser) Optimize TokenizeLine function
1. regex is slow. Let we tokenize without regex.
2. Let we use std::string_view for GetToken() instead of string-creation.
After this patch, preprocess color-visual shader spend time reduced 95%
8.000 ms --> 0.372 ms (release mode)
Change-Id: I0c447b240e6d8315888cb1c611472c406af94822
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Tue, 19 Nov 2024 01:41:51 +0000 (01:41 +0000)]
Merge changes I179cfcd6,I6c702db7,I6994521e,I424c7a02 into devel/master
* changes:
Print some log after preprocess finished
Fix pre-compile works well after Preprocess.
Make preprocessed shader include null-terminate keyword
(ShaderPaser) Make flat qualifier define write ordering
Wonsik Jung [Mon, 18 Nov 2024 04:49:54 +0000 (04:49 +0000)]
Merge "Fix the memory leak of input panel wayland resource." into devel/master
Wonsik Jung [Mon, 18 Nov 2024 02:28:34 +0000 (11:28 +0900)]
Fix the memory leak of input panel wayland resource.
Fix the memory leak of wayland resource when input panel is used.
It is for tizen wayland backend.
Change-Id: I7e9bfc18e41dbf2dba9a6fa0a6b73b3ce30960e4
Eunki Hong [Sun, 17 Nov 2024 13:03:17 +0000 (22:03 +0900)]
Print some log after preprocess finished
Let we print that preprocess finished to check the duration of preprocess
Change-Id: I179cfcd6094008565985c0c03011e8550890a17e
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Sat, 16 Nov 2024 04:48:58 +0000 (13:48 +0900)]
Fix pre-compile works well after Preprocess.
Since we don't insert the version of shader for pre-compile case,
Preprocess result of precompiled shader is not avalid.
To fix this issue, we should attach the version of shader.
For now, most of shaders in dali-toolkit use 100 version.
So let we use it forcibly.
TODO : We need to consider that Open ShaderData API,
to avoid duplicate implementation.
For now, just keep these duplicated logic.
Change-Id: I6c702db72289f28655c5b6c349565d3cc5db71c4
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Sat, 16 Nov 2024 04:18:33 +0000 (13:18 +0900)]
Make preprocessed shader include null-terminate keyword
It will fix some kind of glCompileShader failed case.
ERROR: DALI: gles-graphics-shader.cpp: Compile(121) > glCompileShader() failed:
0:16(9): error: syntax error, unexpected NEW_IDENTIFIER
Change-Id: I6994521e29bb564bb457a4ab96791f8d55ba777b
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Sat, 16 Nov 2024 04:12:26 +0000 (13:12 +0900)]
(ShaderPaser) Make flat qualifier define write ordering
Since flat keyword should be exist earlier than in / out keyword,
let we change the parsing method, and ensure
FLAT keyword works well.
Appendix:
Flat keyword spec for gles : https://docs.nvidia.com/drive/drive-os-5.2.0.0L/drive-os/DRIVE_OS_Linux_SDK_Development_Guide/baggage/GLSL_ES_Specification_3.20.withchanges.pdf
SPIRV don't use flat keyword at vertex shader (reddit search result) : https://www.reddit.com/r/vulkan/comments/yizy4i/whats_the_best_way_to_pass_an_index_from_a_vertex/?rdt=64516
Change-Id: I424c7a02618fa0e8bcb97d6f4d1d0e17391035b8
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Wonsik Jung [Fri, 15 Nov 2024 09:49:25 +0000 (09:49 +0000)]
Merge "Fix the leak of wayland resource." into devel/master
Adeel Kazmi [Fri, 15 Nov 2024 08:12:51 +0000 (08:12 +0000)]
Merge "DALi Version 2.3.50" into devel/master
Wonsik Jung [Fri, 15 Nov 2024 07:44:55 +0000 (16:44 +0900)]
Fix the leak of wayland resource.
Fix the leak of wayland resource in tizen backend.
The related wayland resource is tizen_display_policy, tizen_policy and wl_registry.
It should be free before wl_event_queue is free.
Change-Id: I20bd835169154457c7f00f3d85bf4d7635fb639d
Adam Bialogonski [Fri, 15 Nov 2024 07:18:49 +0000 (07:18 +0000)]
DALi Version 2.3.50
Change-Id: I9b404d4c5b883dedb6499ac173ff6e8a3fc1c9de
Eunki Hong [Thu, 14 Nov 2024 14:06:49 +0000 (23:06 +0900)]
Fix compile error with thorvg by gcc-14
Change-Id: Id319e7223147d51798e1a4f19752a8a4f363a7e9
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
kim hosang [Thu, 14 Nov 2024 03:46:27 +0000 (03:46 +0000)]
Merge "[AT-SPI] Add offset to GetNodeInfo API." into devel/master