platform/core/appfw/app-installers.git
5 years agoChange database removal logic 54/207554/7
Junghyun Yeon [Fri, 7 Jun 2019 04:15:10 +0000 (13:15 +0900)]
Change database removal logic

Journaling mode has changed to WAL so removing logic should be changed.

Related changes:
[pkgmgr-info] : https://review.tizen.org/gerrit/c/platform/core/appfw/pkgmgr-info/+/207513

Change-Id: If5515815c9a1a71f7d7cd83f8526431462d4aafc
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoFix coding style 30/209730/1
Sangyoon Jang [Wed, 10 Jul 2019 08:41:09 +0000 (17:41 +0900)]
Fix coding style

Add some missing #include statement.

Change-Id: I1c953c954878e8dfa96b88c34d9d244686159456
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoSynchronize save, delete signature 68/207768/7
Ilho Kim [Wed, 12 Jun 2019 07:18:13 +0000 (16:18 +0900)]
Synchronize save, delete signature

To prepare for sudden power loss,
write the signature infomation to the physical disk
and then synchronously delete the unpacked signature file using fsync()

Change-Id: I2a23f518cc7e71634ad93e00b594505223caee4c
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix creating storage directories 09/208709/1
Sangyoon Jang [Thu, 27 Jun 2019 08:06:42 +0000 (17:06 +0900)]
Fix creating storage directories

Now creating storage directories is performed after security registration,
installer should label those storage directories explicitly.

Change-Id: I587dc84d3fd4d5df80da22a6d1cfba788afef755
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRefactor StepCreateStorageDirectories 04/208704/3
Sangyoon Jang [Thu, 27 Jun 2019 07:24:10 +0000 (16:24 +0900)]
Refactor StepCreateStorageDirectories

Remove duplicated code. Remove unused variables. Improve readability.

Change-Id: I495e03b7a192d725a8058313418863d735c013f7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoChange log directory's file atrributes 87/208487/3
Ilho Kim [Tue, 25 Jun 2019 05:42:06 +0000 (14:42 +0900)]
Change log directory's file atrributes

Change-Id: I22ae9470d6275059a752cdea0c2dc682eea1fde1
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix StepCheckInstallable 91/208291/6
Sangyoon Jang [Fri, 21 Jun 2019 07:09:04 +0000 (16:09 +0900)]
Fix StepCheckInstallable

Check required version of dependent packages.

Change-Id: Ia804ac9a47f0466dac747194814c322fa8d87064
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoCombine StorageDirectories Steps 75/206075/23
Ilho Kim [Tue, 14 May 2019 01:48:01 +0000 (10:48 +0900)]
Combine StorageDirectories Steps

Combined step :
 - StepCreateStorageDirectories and StepCreatePerUserStorageDirectories
 - StepUpdateStorageDirectories and StepUpdatePerUserStorageDirectories
 - StepRecoverStorageDirectories and StepRecoverPerUserStorageDirectories

Related changes
    [app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/206075/
    [tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/206194/
    [wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/206193/

Change-Id: I7ebc32c5cb9b66a1dd007a064785d940e6de6f68
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRelease version 1.30.3 50/208550/1 accepted/tizen/unified/20190626.064934 submit/tizen/20190626.013636
Ilho Kim [Wed, 26 Jun 2019 01:50:07 +0000 (10:50 +0900)]
Release version 1.30.3

Changes:
 - Remove unused variable
 - Fix namespace of StepCreateRecoveryFile
 - Fix StepParsePreload
 - Fix error logging when adding/removing/replacing step
 - Add PkgQueryInterface::Version() for getting version of package
 - Change log directory
 - Improve StepCopyBackup
 - Move the plugin info(prefer_dotnet_aot) of dotnet

Change-Id: Idc94a60427026ed2a5e6c6fbf086628b560e8300
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoMove the plugin info(prefer_dotnet_aot) of dotnet 07/207107/4
j-h.choi [Thu, 30 May 2019 05:26:40 +0000 (14:26 +0900)]
Move the plugin info(prefer_dotnet_aot) of dotnet

Dependency : https://github.sec.samsung.net/dotnet/dotnet-launcher/pull/58

Change-Id: I8e1b5c937d8202f580b817b9f4bcb01cdb29cd52

5 years agoImprove StepCopyBackup 25/208025/5
Junghyun Yeon [Mon, 17 Jun 2019 07:28:16 +0000 (16:28 +0900)]
Improve StepCopyBackup

Replace copy operation to move improves performance.

Change-Id: I623059a21e311420942ab860b3b151c95d371562
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoChange log directory 39/208039/4
Junghyun Yeon [Mon, 17 Jun 2019 12:18:27 +0000 (21:18 +0900)]
Change log directory

Log collecting module doesn't have enough permission to copy
file owned by root

Change-Id: Ibd5dc0ecdc7ff290954e1ffb77d761228406b12d
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoAdd PkgQueryInterface::Version() for getting version of package 93/208293/1
Sangyoon Jang [Fri, 21 Jun 2019 07:24:43 +0000 (16:24 +0900)]
Add PkgQueryInterface::Version() for getting version of package

Change-Id: Ic0e9e03862bd0a6d41d0b12c0642e81f8868fd3f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix error logging when adding/removing/replacing step 10/207710/6
Sangyoon Jang [Tue, 11 Jun 2019 08:41:27 +0000 (17:41 +0900)]
Fix error logging when adding/removing/replacing step

HandleStepError is for sending signal when the step returns fail.

Change-Id: I4ba079aee5a399e11079950954c30e42583f3371
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix StepParsePreload 91/208091/2
Sangyoon Jang [Tue, 18 Jun 2019 07:04:50 +0000 (16:04 +0900)]
Fix StepParsePreload

Allow handle readonly package when ReadonlyUpdateUninstall mode.
ReadonlyUpdateUninstall mode makes the package as readonly package back.

Change-Id: I0a0fc007e73b3497b125833c7904192c3024aec3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix namespace of StepCreateRecoveryFile 59/206959/7
Sangyoon Jang [Wed, 29 May 2019 10:05:16 +0000 (19:05 +0900)]
Fix namespace of StepCreateRecoveryFile

This step should be included at "recovery" namespace.

Change-Id: Id12a75327641b3d75bdb35b5d132d3e9c436b54f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRemove unused variable 50/207350/1
Junghyun Yeon [Mon, 3 Jun 2019 12:45:28 +0000 (21:45 +0900)]
Remove unused variable

Change-Id: Id75cf5859fa788bfa312e6fb13174ade6066c6a3
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRelease version 1.30.2 57/207257/1 accepted/tizen/unified/20190604.081847 submit/tizen/20190531.072406 submit/tizen/20190603.050018
Ilho Kim [Fri, 31 May 2019 07:09:36 +0000 (16:09 +0900)]
Release version 1.30.2

Changes:
 - Combine Signature Steps
 - Set external image path at pkgmgr registration
 - Parse api-version of application if exist
 - Add PackageAttributes structure at smoke utils
 - Fix plugin_xml_parser
 - Delete unused header files
 - Refactor PluginsXmlParser::NextChildElement()
 - Fix checking return code app2sd API
 - Fix coding style
 - Fix app2ext_dynamic_service
 - Fix plugin manager
 - Standardize use of STEP_NAME()
 - Fix memory leak in using "g_object_get()"
 - Combine Plugin Steps
 - Fix static anylysis issue
 - Allow copy constructor and assign operator of PkgQueryInterface
 - Remove gumd security user

Change-Id: I5d5d4699f244f5c53431a097f4f92be5f771f711
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoRemove gumd security user 58/206958/4
INSUN PYO [Wed, 29 May 2019 09:58:56 +0000 (18:58 +0900)]
Remove gumd security user

Container feature is removed, so we don't need to handle gumd security user.
Security user is only used by container.

Change-Id: Ie76630476235056033e8062747611f27dfa2f0e2

5 years agoAllow copy constructor and assign operator of PkgQueryInterface 94/207094/2
Sangyoon Jang [Thu, 30 May 2019 02:56:17 +0000 (11:56 +0900)]
Allow copy constructor and assign operator of PkgQueryInterface

PkgQueryInterface was changed to using shared ptr of PkgHandle object
which has actual query data.

Change-Id: Iffec5a63de2236cc62cbcc8a6bba743962ad9583
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix static anylysis issue 42/206842/2
Junghyun Yeon [Tue, 28 May 2019 04:41:57 +0000 (13:41 +0900)]
Fix static anylysis issue

Change-Id: I0394b2007b64291e87e560ef5affdcda3cb3b3ca
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoCombine Plugin Steps 52/204652/9
Ilho Kim [Thu, 25 Apr 2019 08:21:34 +0000 (17:21 +0900)]
Combine Plugin Steps

StepRunParserPlugin combines below steps
 - StepRegisterPluginInfo
 - StepUpdatePluginInfo
 - StepUnregisterPluginInfo

Related changes
    [app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/204652/
    [tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/204757/
    [wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/205385/

Change-Id: If090bb5855145077599c877d80335df1636d8e34
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix memory leak in using "g_object_get()" 32/206132/3
Ilho Kim [Tue, 14 May 2019 12:17:52 +0000 (21:17 +0900)]
Fix memory leak in using "g_object_get()"

Change-Id: I0e8263fee35852376992f856449d54691c74d133
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoStandardize use of STEP_NAME() 75/206275/2
Ilho Kim [Thu, 16 May 2019 02:55:56 +0000 (11:55 +0900)]
Standardize use of STEP_NAME()

In case class name is StepExampleClass, Pass "ExampleClass" to STEP_NAME()

Change-Id: I9aba996dc34109f391dc08f2f998b62417d956b2
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix plugin manager 67/205167/8
Sangyoon Jang [Tue, 30 Apr 2019 01:54:25 +0000 (10:54 +0900)]
Fix plugin manager

Fix crash when manifest is not provided.

Change-Id: I1f1c50856f3553c2a2f6d218a8af2ec2dbfd5b95
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix app2ext_dynamic_service 36/205736/4
Ilho Kim [Thu, 9 May 2019 01:54:49 +0000 (10:54 +0900)]
Fix app2ext_dynamic_service

Disable external pkg function was misused

Change-Id: I8a468ce9eb78f7b16890b5b7506e05a82d710505
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix coding style 30/205530/3
Junghyun Yeon [Tue, 7 May 2019 08:03:05 +0000 (17:03 +0900)]
Fix coding style

Change to use pointer when pass error_message as parameter.

Change-Id: I46d1b1704ca870a281136345a37a2a2eac1c2bd8
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoFix checking return code app2sd API 06/205606/4
Sangyoon Jang [Wed, 8 May 2019 04:38:12 +0000 (13:38 +0900)]
Fix checking return code app2sd API

It may return positive return value in case of error.

Change-Id: Ic40cd8241d3fb1dd4deba3f67ac94343b16065c8
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRefactor PluginsXmlParser::NextChildElement() 35/205635/2
Sangyoon Jang [Wed, 8 May 2019 06:03:54 +0000 (15:03 +0900)]
Refactor PluginsXmlParser::NextChildElement()

Call xmlTextReaderRead() until reaching child element.

Change-Id: I523187efb4402b81e703b6ff065ef50165b486e2
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoDelete unused header files 35/205735/1
Ilho Kim [Thu, 9 May 2019 01:51:30 +0000 (10:51 +0900)]
Delete unused header files

Change-Id: Ifca102788294950da05e397b2f89f766c9676772
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix plugin_xml_parser 07/205607/2
Ilho Kim [Wed, 8 May 2019 04:32:11 +0000 (13:32 +0900)]
Fix plugin_xml_parser

If xml file have comment line at root tag's depth, parsing is stopped

Change-Id: I04be43a4fdbeeda77937fb1d2996178561fea31b
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoAdd PackageAttributes structure at smoke utils 12/203612/5
Sangyoon Jang [Tue, 16 Apr 2019 07:53:07 +0000 (16:53 +0900)]
Add PackageAttributes structure at smoke utils

This structure can be used comparing package attributes such as
system, readonly, update, etc.
Some test cases of smoke-tests such as ReadonlyUpdateUninstall can
do additional validation using this structure.

Change-Id: I62579fb27e51d23cb8667fa4b8b85478af91af47
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoParse api-version of application if exist 97/199997/9
Sangyoon Jang [Mon, 18 Feb 2019 05:49:52 +0000 (14:49 +0900)]
Parse api-version of application if exist

Change-Id: I52dfe3477cd951b9f2b098486f3fbaa7dcd601f3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoMerge "Combine Signature Steps" into tizen
ilho kim [Fri, 3 May 2019 07:30:58 +0000 (07:30 +0000)]
Merge "Combine Signature Steps" into tizen

5 years agoSet external image path at pkgmgr registration 93/204793/2
Sangyoon Jang [Fri, 26 Apr 2019 08:45:04 +0000 (17:45 +0900)]
Set external image path at pkgmgr registration

security-manager needs package information when getting privilege type,
but when installing package at external storage, the external image path is
set at clean() phase. So security-manager cannot get package information.

Change-Id: I8a2810da4cc417c0bc656f25e4a0d679c791833d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoCombine Signature Steps 40/203140/16
ilho [Thu, 4 Apr 2019 04:28:04 +0000 (13:28 +0900)]
Combine Signature Steps

StepCheckSignature and StepSaveSignature are combined

Related changes
    [app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/203140/
    [tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/203141/
    [wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/203513/

Change-Id: I71de6ef5e9cdffc88f9f4f25f130e1f1c6b84714
Signed-off-by: ilho <ilho159.kim@samsung.com>
5 years agoRelease version 1.30.1 06/205306/1 accepted/tizen/unified/20190502.112933 submit/tizen/20190502.061205
Ilho Kim [Thu, 2 May 2019 07:06:19 +0000 (16:06 +0900)]
Release version 1.30.1

Changes:
 - Fix removed plugin feature
 - Delete unused plugin from plugins_list
 - Delete downloadable_font plugin from plugin_list

Change-Id: Id60fd9fdddb96e8394ffe861382d96b3112b7c56
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoDelete downloadable_font plugin from plugin_list 05/205305/2
Ilho Kim [Thu, 2 May 2019 07:01:56 +0000 (16:01 +0900)]
Delete downloadable_font plugin from plugin_list

Change-Id: I6978bfbdd6bc92d064dde9d4e909ee51686b9e90
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoDelete unused plugin from plugins_list 56/205256/1
Ilho Kim [Wed, 1 May 2019 23:36:59 +0000 (08:36 +0900)]
Delete unused plugin from plugins_list

Change-Id: I8d8a7201aea3b64b1757cbb28976623c7a90a787
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
5 years agoFix removed plugin feature 18/204718/1
Junghyun Yeon [Fri, 26 Apr 2019 02:41:08 +0000 (11:41 +0900)]
Fix removed plugin feature

- Getting index from tuple was wrong.

Change-Id: I879e03437a9a3f4843710d699af6369e0778d32d
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRelease version 1.30.0 16/203816/1 accepted/tizen/unified/20190419.110513 submit/tizen/20190418.021839 submit/tizen/20190418.055722
Sangyoon Jang [Thu, 18 Apr 2019 02:16:31 +0000 (11:16 +0900)]
Release version 1.30.0

Changes:
 - Add explicit linker flag for boost-system at pc file
 - Initialize steps at Run()

Change-Id: I58d7f71d948fda8a6b90b08a0b67d631003ad442
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoInitialize steps at Run() 60/203760/4
Sangyoon Jang [Wed, 17 Apr 2019 11:38:17 +0000 (20:38 +0900)]
Initialize steps at Run()

Now installer backends does not need to call Init() itself.

Change-Id: I9ccba5900998a5615b5d0d4a781c16c7cf32a43b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoAdd explicit linker flag for boost-system at pc file 59/203759/2
Sangyoon Jang [Wed, 17 Apr 2019 11:37:13 +0000 (20:37 +0900)]
Add explicit linker flag for boost-system at pc file

Some installer backend may not use boost library.

Change-Id: I50fca7703f65dcae2469c66ad0bdadb2bf6c80c3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRelease version 1.29.2 30/203630/1 accepted/tizen/unified/20190417.132332 submit/tizen/20190416.100651 submit/tizen/20190416.233814
Junghyun Yeon [Tue, 16 Apr 2019 08:55:25 +0000 (17:55 +0900)]
Release version 1.29.2

Changes:
 - Adjust parsing component-based application
 - Remove package-recovery-helper service
 - Recycle pkgmgrinfo query result

Change-Id: I3de09922b7c28e257fd8c429f41c15cdcf89998a
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRecycle pkgmgrinfo query result 23/202723/5
Sangyoon Jang [Wed, 3 Apr 2019 07:44:54 +0000 (16:44 +0900)]
Recycle pkgmgrinfo query result

Change-Id: I720974e6697f3d9c0a79f02706f4dfbe661736ea
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRemove package-recovery-helper service 01/202801/6
Sangyoon Jang [Thu, 4 Apr 2019 06:12:34 +0000 (15:12 +0900)]
Remove package-recovery-helper service

Now package-recovery service handles all recovery process directly.

Change-Id: Ic599c965c832538b4bf28d212f955e8a92b29736
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoAdjust parsing component-based application 38/203138/1
Hwankyu Jhun [Wed, 10 Apr 2019 06:25:01 +0000 (15:25 +0900)]
Adjust parsing component-based application

FillComponentInfo step is removed.
FillAppControl, FillDataControl, FillMetadata, FillCategories and
FillSplashScreen are added.

Change-Id: I3c47918f04def3015f20df800005d88850cb8198
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
5 years agoRelease version 1.29.1 26/202726/1 accepted/tizen/unified/20190404.022016 submit/tizen/20190403.083158
Sangyoon Jang [Wed, 3 Apr 2019 08:28:51 +0000 (17:28 +0900)]
Release version 1.29.1

Changes:
 - Change log level of printing parsed pkgid
 - Revert "Reduce db connection while installer backend is running"

Change-Id: I3a07b53ccf360c8e7ce1c514c05fa700c1257df6
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRevert "Reduce db connection while installer backend is running" 22/202722/1
Sangyoon Jang [Tue, 2 Apr 2019 07:47:04 +0000 (16:47 +0900)]
Revert "Reduce db connection while installer backend is running"

This reverts commit 5c30ad9f49cabedf7baa01dd5b23af22d669c230.

Change-Id: I8302871edf14c3968bdde0fc2b82b26bcb79354b

5 years agoChange log level of printing parsed pkgid 19/202519/1
Sangyoon Jang [Fri, 29 Mar 2019 08:46:37 +0000 (17:46 +0900)]
Change log level of printing parsed pkgid

Changed to INFO from DEBUG.

Change-Id: I087ba05e3e6359637ff1f85f697458c113d5106d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRelease version 1.29.0 67/202467/1 submit/tizen/20190329.023054 submit/tizen/20190401.061033
Sangyoon Jang [Fri, 29 Mar 2019 02:09:35 +0000 (11:09 +0900)]
Release version 1.29.0

Changes:
 - Reduce db connection while installer backend is running
 - Fix recovery helper
 - Merge "Reduce db connection while installer backend is running" into tizen
 - Fix build error
 - Fix exception case of plugin info callback
 - Fix coding style checker error
 - Add RemoveStep
 - Write log to file when installation process failed

Change-Id: Ifb0394b02ef504463038112588edb0d7e2330cda
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoWrite log to file when installation process failed 72/202272/6
Sangyoon Jang [Tue, 26 Mar 2019 12:05:32 +0000 (21:05 +0900)]
Write log to file when installation process failed

When installation process failed, installer will write entire log at
"/var/log/app-installers.log". (except DEBUG level log)

Change-Id: I1d7aee6be3f67d16ff2749405bf28fc14e076cfe
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoAdd RemoveStep 89/202089/2
Junghyun Yeon [Fri, 22 Mar 2019 11:04:20 +0000 (20:04 +0900)]
Add RemoveStep

RemoveStep() will be used to remove certain step already added at step list.

Change-Id: I0c8d132323a23cd95a5fa67559cb225a3406d9c4
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoFix coding style checker error 13/202313/2
Sangyoon Jang [Wed, 27 Mar 2019 05:12:05 +0000 (14:12 +0900)]
Fix coding style checker error

Change-Id: Id1542aa29cf21c90b7146a8e5773f99453d93277
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix exception case of plugin info callback 12/202312/1
Sangyoon Jang [Wed, 27 Mar 2019 05:00:28 +0000 (14:00 +0900)]
Fix exception case of plugin info callback

The appid can be null.

Change-Id: Id6d409936e33df7b7aa6505f2eb9b616b243d02b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix build error 11/202311/1
Sangyoon Jang [Wed, 27 Mar 2019 04:58:09 +0000 (13:58 +0900)]
Fix build error

Fix wrong merged code.

Change-Id: I544c52b5f802823e75aaf9ca40056f071e90a908
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoMerge "Reduce db connection while installer backend is running" into tizen
Junghyun Yeon [Fri, 22 Mar 2019 10:30:10 +0000 (10:30 +0000)]
Merge "Reduce db connection while installer backend is running" into tizen

5 years agoFix recovery helper 46/202046/1
Sangyoon Jang [Fri, 5 Jan 2018 04:39:57 +0000 (13:39 +0900)]
Fix recovery helper

We don't need to check if the file is directory or not.

Change-Id: I5d43a0c6e8af10b61c3985ac72a86d5eea4c2ab4
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
(cherry picked from commit 3f040e9398d74cef639154e24493e74bf7c2dacd)

5 years agoReduce db connection while installer backend is running 38/200938/7
Junghyun Yeon [Wed, 6 Mar 2019 08:48:16 +0000 (17:48 +0900)]
Reduce db connection while installer backend is running

- Db connection during installation cause delay
  when some hard scenarios.

Change-Id: Id313d669d029e98d1e3540c808ccaa75b391df50
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRelease version 1.28.1 64/201964/1 accepted/tizen/unified/20190322.075512 submit/tizen/20190321.084911
Sangyoon Jang [Thu, 21 Mar 2019 08:43:18 +0000 (17:43 +0900)]
Release version 1.28.1

Changes:
 - Fix a bug when recover preload-rw update
 - Fix crash issue
 - Adjust to change of pkgmgrinfo_pkg_dependency_list_cb

Change-Id: I364c4b40948425fdcd7a33194b8e56ad9234bea3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoAdjust to change of pkgmgrinfo_pkg_dependency_list_cb 68/201368/4
Sangyoon Jang [Wed, 13 Mar 2019 07:40:21 +0000 (16:40 +0900)]
Adjust to change of pkgmgrinfo_pkg_dependency_list_cb

Requires:
 - https://review.tizen.org/gerrit/c/platform/core/appfw/pkgmgr-info/+/201198

Change-Id: I20f0257cf7825306b5c96919db87a8ff32643df0
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix crash issue 95/201695/1
Hwankyu Jhun [Tue, 19 Mar 2019 02:31:49 +0000 (11:31 +0900)]
Fix crash issue

Before calling FillExtraInfo(), FillComponentBasedApplicationInfo()
should be called.

Change-Id: Icd436417f8e05618b16f243a6cf61607251054ef
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
5 years agoFix a bug when recover preload-rw update 96/201596/2
Sangyoon Jang [Mon, 18 Mar 2019 06:08:53 +0000 (15:08 +0900)]
Fix a bug when recover preload-rw update

The preload-rw package should not be a system package.

Change-Id: Iba5d917105fbdbfc699cd9a55403097638446aa3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoMerge "Release version 1.28.0" into tizen accepted/tizen/unified/20190318.150652 submit/tizen/20190315.084013
Junghyun Yeon [Fri, 15 Mar 2019 08:38:36 +0000 (08:38 +0000)]
Merge "Release version 1.28.0" into tizen

5 years agoProvide methods for adding or replacing steps 89/201189/3
Junghoon Park [Mon, 11 Mar 2019 07:56:39 +0000 (16:56 +0900)]
Provide methods for adding or replacing steps

Change-Id: I0845a49e34dc3816d826502b55203dbd930ba744
Signed-off-by: Junghoon Park <jh9216.park@samsung.com>
5 years agoRelease version 1.28.0 94/201494/1
Hwankyu Jhun [Fri, 15 Mar 2019 03:05:00 +0000 (12:05 +0900)]
Release version 1.28.0

Changes:
 - Fix StepKillApps
 - Use lambda expressions for simple callback function
 - Implement package dependency feature
 - Add string into include list
 - Remove using assert() in ExternalStorage
 - Add GetRequestTypeString() to print request type
 - Change visibility of steps to protected
 - Print request type at StepConfigure
 - Remove routine for checking name duplication on installer plugin
 - Fix bug of debug mode installation of hybrid package
 - Implement execution of removed plugin feature
 - Parse new elements for component-based application

Change-Id: Ic3e0ab612712535f43a5efd1f51da35b3a8850d5
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
5 years agoParse new elements for component-based application 91/200691/8
Hwankyu Jhun [Thu, 28 Feb 2019 07:42:46 +0000 (16:42 +0900)]
Parse new elements for component-based application

Requires:
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/pkgmgr-info/+/200568/
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-manifest-handlers/+/200669/
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/200691/
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/amd/+/200773/

Change-Id: Ia2a277fd0eaff0c8ad761294b4f45bf29c8e99a4
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
5 years agoImplement execution of removed plugin feature 44/195744/24
Junghyun Yeon [Fri, 14 Dec 2018 08:46:03 +0000 (17:46 +0900)]
Implement execution of removed plugin feature

Related changes:
[pkgmgr-info] : https://review.tizen.org/gerrit/#/c/platform/core/appfw/pkgmgr-info/+/195920/

Change-Id: Ief580418d693f98458334c7ac2a353964e9dd6ed
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoFix bug of debug mode installation of hybrid package 97/200897/3
Sangyoon Jang [Tue, 5 Mar 2019 11:53:12 +0000 (20:53 +0900)]
Fix bug of debug mode installation of hybrid package

The appdebugging privilege should be added for all applications
included in hybrid package.

Change-Id: Id0bced11063f7fb8c66b4a10ac696c5832f0acc7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRemove routine for checking name duplication on installer plugin 92/200492/2
Junghyun Yeon [Tue, 26 Feb 2019 02:02:49 +0000 (11:02 +0900)]
Remove routine for checking name duplication on installer plugin

Change-Id: Id53963dd55141ab87adb64d6f96db1187c4588f9
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoPrint request type at StepConfigure 48/200548/2
Sangyoon Jang [Tue, 26 Feb 2019 10:10:32 +0000 (19:10 +0900)]
Print request type at StepConfigure

Change-Id: I9361120c285cca5f7174a7aed731affd37fcb915
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoChange visibility of steps to protected 21/200321/2
Sangyoon Jang [Thu, 21 Feb 2019 11:12:22 +0000 (20:12 +0900)]
Change visibility of steps to protected

For extensibility, change visibility to protected.

Change-Id: I2338d6a9fc280d37f60e355d6a38f4690a1a0038
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoAdd GetRequestTypeString() to print request type 36/200236/1
Sangyoon Jang [Wed, 20 Feb 2019 10:52:11 +0000 (19:52 +0900)]
Add GetRequestTypeString() to print request type

Change-Id: Icb089a5eb63ef05fcd4e543f3a78995804528675
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRemove using assert() in ExternalStorage 31/200231/1
Sangyoon Jang [Wed, 20 Feb 2019 10:10:06 +0000 (19:10 +0900)]
Remove using assert() in ExternalStorage

Just return error instead of assert.

Change-Id: I0804ec330aa8d7b0d2ea57440b49ff5bae650a79
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoAdd string into include list 19/200019/1
Junghyun Yeon [Mon, 18 Feb 2019 07:09:58 +0000 (16:09 +0900)]
Add string into include list

- Add string into include list for coding style

Change-Id: I17f1e9e1116e8ffde48855c9a120e9318dceb275
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoImplement package dependency feature 33/197433/8
Sangyoon Jang [Thu, 10 Jan 2019 10:35:56 +0000 (19:35 +0900)]
Implement package dependency feature

Requires:
 - https://review.tizen.org/gerrit/c/platform/core/appfw/tpk-manifest-handlers/+/195441
 - https://review.tizen.org/gerrit/c/platform/core/appfw/pkgmgr-info/+/197434

Change-Id: Ib48f15bfaa127b1a924cc6ebd1ad3ebb3b5ca3d1
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoUse lambda expressions for simple callback function 60/198860/2
Sangyoon Jang [Wed, 30 Jan 2019 10:39:54 +0000 (19:39 +0900)]
Use lambda expressions for simple callback function

Change-Id: I9295e905617326be56620909f01e6bfa54c03fd7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoFix StepKillApps
Hwankyu Jhun [Tue, 15 Jan 2019 23:04:56 +0000 (08:04 +0900)]
Fix StepKillApps

This patch adds to check the elapsed time. After sending the terminate request,
we have to wait at least 5 seconds. According to Tizen policy,
the running application should be terminated within 5 seconds.
If the elapsed time exceeds 5 seconds, we send the kill request
to Application Manager to terminate the application forcedly.

Change-Id: Ic504f0899cfa55a13ff1eb2b8f6eee87ae9ec1ab
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
5 years agoRelease version 1.27.0 accepted/tizen/unified/20190117.151835 accepted/tizen/unified/20190128.061307 submit/tizen/20190116.050016 submit/tizen/20190116.052201 submit/tizen/20190117.001629 submit/tizen/20190121.002257
Hwankyu Jhun [Mon, 14 Jan 2019 02:17:02 +0000 (11:17 +0900)]
Release version 1.27.0

Changes:
 - Modify multiple LoadPlugins function call
 - Apply coding rules
 - Fix plugin smoketest failure
 - Support failure of plugin can cause install failure
 - Adjust log level
 - Fix build warning
 - Add attribute 'id' on app-control element
 - Merge "Add attribute 'id' on app-control element" into tizen
 - Fix some coding style
 - Fix log message

Change-Id: I0a8f40938eeab20ecf95b52b271528f2b3c68772
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
5 years agoFix log message 64/197064/2
ilho [Wed, 9 Jan 2019 07:21:47 +0000 (16:21 +0900)]
Fix log message

Change-Id: Ic187cb18478b7acfa5057c874d562ea9513b41b4
Signed-off-by: ilho <ilho159.kim@samsung.com>
5 years agoFix some coding style 01/197401/1
Sangyoon Jang [Fri, 11 Jan 2019 04:57:28 +0000 (13:57 +0900)]
Fix some coding style

Change-Id: I9b171ad8ed0d3307db2d0d942e6606f0a6350bad
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoMerge "Add attribute 'id' on app-control element" into tizen
HwanKyu Jhun [Thu, 10 Jan 2019 11:51:03 +0000 (11:51 +0000)]
Merge "Add attribute 'id' on app-control element" into tizen

5 years agoAdd attribute 'id' on app-control element 89/196889/1
Hwankyu Jhun [Mon, 7 Jan 2019 09:44:17 +0000 (18:44 +0900)]
Add attribute 'id' on app-control element

Change-Id: Ia575a9baf211f3f2d9734e6a53364ee901248477
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
5 years agoFix build warning 66/196866/2
ilho [Mon, 7 Jan 2019 05:22:18 +0000 (14:22 +0900)]
Fix build warning

Change-Id: I5d2bda3a27039917edcfb682db140ebd9e4317c9
Signed-off-by: ilho <ilho159.kim@samsung.com>
5 years agoAdjust log level 62/196862/1
Junghyun Yeon [Mon, 7 Jan 2019 02:39:40 +0000 (11:39 +0900)]
Adjust log level

Change-Id: I60c3f17a101492f152f7078e3142c24ae7a496a4
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoSupport failure of plugin can cause install failure 28/194628/16
ilho [Thu, 6 Dec 2018 10:45:18 +0000 (19:45 +0900)]
Support failure of plugin can cause install failure

the code see plugin_list file like :
type="type";name="name";path="path";vitalness="true"|"false"

if vitalness is "true" that plugin's failure cause install's failure

if not plugin's failure has no effect on the installation

Change-Id: Ia435c928d50e44cfdc3fe7da2faa86ea70442a3e
Signed-off-by: ilho <ilho159.kim@samsung.com>
5 years agoFix plugin smoketest failure 05/195805/3
ilho [Tue, 18 Dec 2018 07:38:52 +0000 (16:38 +0900)]
Fix plugin smoketest failure

smoke test failed because testcase has a dependency on the plugin list files
and fix that dependency

Change-Id: I03c3c7d282a98cec10b0eda3981816f8c8a599a2
Signed-off-by: ilho <ilho159.kim@samsung.com>
5 years agoApply coding rules 86/194986/1
ilho [Mon, 10 Dec 2018 05:22:47 +0000 (14:22 +0900)]
Apply coding rules

Change-Id: I397d258aca69fb861fee63fee38f3019a60bdf42
Signed-off-by: ilho <ilho159.kim@samsung.com>
5 years agoModify multiple LoadPlugins function call 16/193616/7
ilho [Thu, 22 Nov 2018 08:10:56 +0000 (17:10 +0900)]
Modify multiple LoadPlugins function call

Reduce process, undo, clean function's multiple LoadPlugins function call

Change-Id: I791be7ed53cd0feeccf6d9343373264d724674f9
Signed-off-by: ilho <ilho159.kim@samsung.com>
5 years agoRelease version 1.26.9 54/194354/1 accepted/tizen/unified/20181204.063711 submit/tizen/20181203.104606 submit/tizen/20181204.004649
Semun Lee [Mon, 3 Dec 2018 10:45:06 +0000 (19:45 +0900)]
Release version 1.26.9

Changes:
 - Fix dotnet app install failure in image creation stage

Change-Id: Iced241e4a37692db7fec4246fc1f0cffb3765916
Signed-off-by: Semun Lee <semun.lee@samsung.com>
5 years agoFix dotnet app install failure in image creation stage 46/194346/1
Sangyoon Jang [Mon, 3 Dec 2018 08:57:34 +0000 (17:57 +0900)]
Fix dotnet app install failure in image creation stage

During image creation stage, vconf API does not work.

Change-Id: Ie57b403463fe6e43c9095c0e55291f4eed247b27
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoRelease version 1.26.8 15/194315/1 submit/tizen/20181203.060015
Sangyoon Jang [Mon, 3 Dec 2018 04:34:10 +0000 (13:34 +0900)]
Release version 1.26.8

Changes:
 - Enable "keep-rwdata" flag for all uninstallation requests
 - Unmount only mount-update recover
 - Compare dotnet API level when installing dotnet app
 - Search all tags for plugin parser

Change-Id: I9c6c9a3f20598704a238596a3039cdc5b238f549
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoSearch all tags for plugin parser 27/193427/2
Sangyoon Jang [Tue, 20 Nov 2018 09:44:19 +0000 (18:44 +0900)]
Search all tags for plugin parser

Change-Id: I0c4dde36b67a3ac876db9805a150a60ab559e9f7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoCompare dotnet API level when installing dotnet app 76/193776/7
Sangyoon Jang [Mon, 26 Nov 2018 08:25:02 +0000 (17:25 +0900)]
Compare dotnet API level when installing dotnet app

dotnet API level is not same with tizen platform version, but there
is only one attribute for representing this feature. So if there is
dotnet app, check dotnet API level instead of tizen API version.

Change-Id: Ib732637f9d7558e4cd87c7d6605695094d787f2c
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
5 years agoUnmount only mount-update recover 44/193144/3
Junghyun Yeon [Thu, 15 Nov 2018 07:19:15 +0000 (16:19 +0900)]
Unmount only mount-update recover

Change-Id: I6cd8835fba89d82a5ac2edb703ab246f223256a3
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoEnable "keep-rwdata" flag for all uninstallation requests 46/190746/1
Junghyun Yeon [Fri, 5 Oct 2018 05:22:37 +0000 (14:22 +0900)]
Enable "keep-rwdata" flag for all uninstallation requests

Change-Id: I99f924632fff0badfa2cec75029ecb6237e09ddb
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRelease version 1.26.7 67/186767/1 accepted/tizen/5.0/unified/20181102.013452 accepted/tizen/unified/20180816.062942 submit/tizen/20180814.083738 submit/tizen_5.0/20181101.000002
Junghyun Yeon [Tue, 14 Aug 2018 07:40:24 +0000 (16:40 +0900)]
Release version 1.26.7

Changes:
 - Remove recovery file before write new one
 - Remove unnecessary function
 - Add StepRecoverTrustAnchor

Change-Id: I14c8e516ddca3dfae78f0fb1fc9eca242b3dd1ad
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoAdd StepRecoverTrustAnchor 22/186122/3
Junghyun Yeon [Tue, 7 Aug 2018 10:32:46 +0000 (19:32 +0900)]
Add StepRecoverTrustAnchor

- Add new step to handle some exceptional cases.

Change-Id: Idcee8bde65327738e0ad8efbe20c35f11364bac3
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
5 years agoRemove unnecessary function 62/186562/1
Junghyun Yeon [Fri, 10 Aug 2018 10:06:02 +0000 (19:06 +0900)]
Remove unnecessary function

Change-Id: I867b512c5a093710c46e80f43165bd47243b2aa0
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
6 years agoRemove recovery file before write new one 67/186067/1
Junghyun Yeon [Tue, 7 Aug 2018 05:46:38 +0000 (14:46 +0900)]
Remove recovery file before write new one

Change-Id: I3aa2819670d4e0fdb5de9793458352f77af213e7
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>