Karol Lewandowski [Fri, 28 Oct 2016 14:05:03 +0000 (16:05 +0200)]
[4.0] logger: Major initialization refactor
* redesign data structures to better reflect
their relationships and make them easier to
initialise properly
* shuffle around and split up the functions so
that they are more concise and conceptually pure
* improve error handling and cleanup routines
in case initialisation fails
* introduce standardized return codes
Change-Id: Icafebabec813c5d793d169878f81c18ff85b749e
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Mon, 31 Oct 2016 13:00:28 +0000 (14:00 +0100)]
[4.0] logger: Extract password/group db manipulation to separate function
Change-Id: I843711edff4e6eb0ff0dfa233e1b08727b245396
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Fri, 28 Oct 2016 13:28:57 +0000 (15:28 +0200)]
[4.0] logger: Always use internal helper functions to manage epoll fds
Change-Id: Ib80d7ea8a331c1b90ee12e67d73f170f0083ef15
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Kichan Kwon [Thu, 16 Mar 2017 06:57:33 +0000 (15:57 +0900)]
Merge branch 'tizen_3.0' into tizen
Change-Id: Idbc92058d4601d903f1b9d7959d37156fa95b3b7
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Thu, 9 Mar 2017 01:39:40 +0000 (10:39 +0900)]
logprint : introduce "rwtime" log format
- To compare time, all logs use receive time
- However, somebody want to check the original time of kernel logs
- Format : RECV_TIME [ORIG_TIME] PRIO/TAG(PID, TID): MSG
Change-Id: I75124561acaba3ee0747fc131830efd9ff8044fc
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Michal Bloch [Tue, 7 Mar 2017 16:42:03 +0000 (17:42 +0100)]
Update configs to recv timestamps
Change-Id: I547667a63668456af76404282a63e3004295602c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 6 Mar 2017 18:02:02 +0000 (19:02 +0100)]
Reception timestamps
* collect realtime + monotonic timestamps on reception
* new format, "recv_realtime": shows realtime reception timestamp
* dlogutil now sorts by monotonic reception timestamp
Change-Id: I53d2787562d6cc580941b8bf64032dd153f147c4
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Rafal Pietruch [Thu, 23 Feb 2017 16:00:48 +0000 (17:00 +0100)]
unhandled read() error bugfix
fix answers foolowing bug report:
repeated lines with the exact same timestamp/message
exactly (100, 300 or 900 times)
Change-Id: I2edc6c80c2023a3f80b5b99d4e1caede047669fc
Kichan Kwon [Tue, 21 Feb 2017 05:38:33 +0000 (14:38 +0900)]
dlogutil : block to use "-n" or "-r" without "-f" option
- "-n" and "-r" options are related with logged file enabled by "-f"
Change-Id: I4a18cbe7b5326a19f1ce5e91eb0830ec658ca067
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 21 Feb 2017 04:50:57 +0000 (13:50 +0900)]
libdlog : fix invalid log_fds access
- If all log device paths are given and failed to get main fd,
libdlog will try to access log_fds[LOG_ID_MAX]
- No more access log_fds[LOG_ID_MAX]
Change-Id: I97197a5efeecae9713f6564f10327a262b255de2
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 13 Feb 2017 08:41:06 +0000 (17:41 +0900)]
Free config data and close fd before terminated
Change-Id: Ib448c1901a4bff6c960bf1a8c26de7a4a350f39c
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 14 Feb 2017 05:27:42 +0000 (14:27 +0900)]
logger : fix '-s' option is not applied
Change-Id: If94afefd0661df937bc9623f3f447d536e524ea2
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kwon [Tue, 14 Feb 2017 05:19:42 +0000 (21:19 -0800)]
Revert "Fix passive logging issues"
This reverts commit
e5c03b719438501f9ccca890092b961e73ac164e.
New patch with fixing bug will be uploaded
Change-Id: I1d7e18dda7bcd3bc6bf9b19c1d30a0b3579a3858
Michal Bloch [Wed, 8 Feb 2017 15:22:45 +0000 (16:22 +0100)]
Fix passive logging issues
* the -s parameter now works
* filtering actually works
Change-Id: I9c6552b8b8fb7cbaca6afe3bcccf0553b81eb1fe
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Kichan Kwon [Fri, 13 Jan 2017 01:58:40 +0000 (10:58 +0900)]
Merge branch 'tizen_3.0' into tizen
Change-Id: I2c91566ccbcca384f4d2d88e6ef7daacaffedad7
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Michal Bloch [Thu, 12 Jan 2017 14:49:10 +0000 (15:49 +0100)]
Fix epoll_ctl erroring out
Do not call epoll_ctl on FDs representing actual files,
which causes the call to error out with EPERM.
This use of this mechanism was twofold; first, pipes
need to actually be added to epoll (to see if they're
full). The second use was to discover whether a descriptor
represents a file. This information is known a priori,
which removes the need to make calls doomed to fail.
Change-Id: Ic11c211ee88e70899998e794847b79afc0a90d9a
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Kichan Kwon [Fri, 6 Jan 2017 07:49:45 +0000 (16:49 +0900)]
Proofread header file
Change-Id: I79da2d948c9932f40a6b599bc38aed0e5867c84e
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 2 Jan 2017 04:51:28 +0000 (13:51 +0900)]
Check dump file size during initialization
- Until now, dump file is rotated after writing rotate_size_kbytes
- If writing less than rotate_size_kbytes and rebooting are repeated,
dump file size can be infinitely increased
- To prevent this, large dump file should be rotated before logging
- Meanwhile, size conversion macro is defined
Change-Id: Id506421799076075e7307c262242835e4bd6d6ea
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Fri, 30 Dec 2016 07:20:18 +0000 (16:20 +0900)]
Merge branch 'tizen_3.0' into tizen
Change-Id: Ifa9654ff3a252b02de4b289ea5301acb18550a95
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 20 Dec 2016 02:44:28 +0000 (11:44 +0900)]
logger : prevent out of range
Change-Id: Id1ba27bd54df2e7975e617fac4c704fc3268e817
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Thu, 8 Dec 2016 12:15:51 +0000 (21:15 +0900)]
logger : fix about filtering
- TAG:PRIO filter will be applied
Change-Id: I96894696eb870ef7a25e78638d58e6c296c6dfb7
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 6 Dec 2016 06:23:13 +0000 (15:23 +0900)]
logger : fix invalid checking
- Return value is changed at the
3e8ab4998beddd0cf61486bb2c3f06ff9f646579
- Therefore, condition statement should be changed
Change-Id: I676823462a0b4b981d103ca42139a2e27eba35e4
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 30 Nov 2016 02:16:06 +0000 (11:16 +0900)]
dlogutil : do not sort when it prints logs about only one buffer or tag
- Each dlog buffer is FIFO queue, so dlogutil don't have to sort in this case
- Also, we can assume that logs having same tag are stored in the same buffer
Change-Id: I0db5bc6162903749007f514f9d06c16967bee696
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Mon, 28 Nov 2016 01:51:55 +0000 (10:51 +0900)]
Fix minor issues.
- Remove unreachable code
- Add error check code
- No more ignore conf value about buffer size
Change-Id: Icb9cd08edf827625ae0a67130bab094571a2241d
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Sunmin Lee [Fri, 2 Dec 2016 08:08:05 +0000 (17:08 +0900)]
Upgrade: adjust upgrade script number
Change-Id: I425c22266e8b3c5e030600c49a5f10f7e03837b7
Karol Lewandowski [Fri, 25 Nov 2016 15:30:19 +0000 (07:30 -0800)]
Merge "logger: Simplify binary log file header writing" into tizen_3.0
Karol Lewandowski [Fri, 25 Nov 2016 15:29:14 +0000 (07:29 -0800)]
Merge changes I274d815f,I4c831e85,I997c4d72,I02ebfd88 into tizen_3.0
* changes:
logger: Avoid returning EBADF in normal operation
More useful return values for shared functions
Catch allocation failures
logger: refactor writer servicing
Karol Lewandowski [Fri, 25 Nov 2016 15:27:55 +0000 (07:27 -0800)]
Merge "logger: fix closing fd 0" into tizen_3.0
Karol Lewandowski [Fri, 25 Nov 2016 15:21:39 +0000 (07:21 -0800)]
Merge "logger: fix socket owner change" into tizen_3.0
Karol Lewandowski [Fri, 28 Oct 2016 13:14:01 +0000 (15:14 +0200)]
logger: Simplify binary log file header writing
Additionally, add return code as writing may fail
and handle the return code in invoking functions.
Change-Id: I7c1434fe87b6f6a50ea986307e935efd87775796
Karol Lewandowski [Fri, 28 Oct 2016 14:07:23 +0000 (16:07 +0200)]
logger: Avoid returning EBADF in normal operation
EBADF has been used only to signal that file should be removed from
the list - this commit makes this explicit.
Change-Id: I274d815fd95ab43aa13f14d36286d17672e42e83
Michal Bloch [Fri, 28 Oct 2016 21:01:47 +0000 (23:01 +0200)]
More useful return values for shared functions
Now returning 0/-errno instead of 1/0
Change-Id: I4c831e85c8ec7e93f183f6990839afdb63ce0a63
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 3 Nov 2016 16:30:09 +0000 (17:30 +0100)]
logger: fix closing fd 0
An unused fd whose value was always 0 was wrongly closed.
Change-Id: I8a70c0a447abd83f091993113354095ffd6446c1
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 14 Nov 2016 11:51:52 +0000 (12:51 +0100)]
logger: fix socket owner change
Change-Id: I742f332bcec3d01fefd2cae3f12d4f7f85878422
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 26 Oct 2016 15:38:09 +0000 (17:38 +0200)]
Catch allocation failures
Change-Id: I997c4d72f3ba413246085b60e49ffeaac1753d7b
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Thu, 27 Oct 2016 18:06:19 +0000 (20:06 +0200)]
logger: refactor writer servicing
* inflict consistent return values - all writer-related functions now
return 0 on success and negative errno code on failure.
Change-Id: I02ebfd88fd044ee083675ba9ed88c403530ca786
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Sunmin Lee [Thu, 24 Nov 2016 13:56:47 +0000 (22:56 +0900)]
Upgrade: adjust script number
Change-Id: Ia90b97ff80de5989fc9017cd72836c5902aef1b0
Signed-off-by: Sunmin Lee <sunm.lee@samsung.com>
Sunmin Lee [Thu, 24 Nov 2016 13:52:35 +0000 (05:52 -0800)]
Revert "Upgrade: adjust script number"
This reverts commit
25acf3aa801bcb858517aea3194cf7aa9c547adf.
Change-Id: Id799dab1c07023e8298ec45037851f2c07a992e0
Sunmin Lee [Thu, 24 Nov 2016 13:41:15 +0000 (22:41 +0900)]
Upgrade: adjust script number
dlog upgrade should be done before 300.pkgmgr.patch.sh
Change-Id: Ib1e69cf18858a1c29f6e925e9785212fb30a3d86
Signed-off-by: Sunmin Lee <sunm.lee@samsung.com>
Kichan Kwon [Wed, 23 Nov 2016 08:39:25 +0000 (17:39 +0900)]
dlogutil : add "-u" option for setting sorting buffer size
- dlogutil -u SIZE
- If "-u" option isn't used, set to the value of conf file
Change-Id: I629c02914d87107a98cac4a83d04560a6a6a0c6f
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 23 Nov 2016 05:23:05 +0000 (14:23 +0900)]
dlogutil : fix memory leak
- When dlogutil filters specific logs, not printed logs haven't be freed
Change-Id: Ib04b3052d02b03b5816660463c70686a5d082143
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Jiwon Kim [Tue, 15 Nov 2016 13:30:19 +0000 (22:30 +0900)]
libdlog : set initalize value to write function pointer
- If log_config_read() is failed (e.g. If '/opt' is unmounted),
dlog_print function refer to null
- Therefore, it need to set to fallback function
Change-Id: I1002c795a12de062121f656a32414a739b994692
Signed-off-by: Jiwon Kim <jiwon177.kim@samsung.com>
[Remove comment violating Tizen coding rule]
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Sunmin Lee [Thu, 17 Nov 2016 10:48:37 +0000 (19:48 +0900)]
Fix vulnerability: NULL check
Null checking for the returned value
Change-Id: Ia459629462b9f0e6cf8501f67f973a92c60b3caa
Sunmin Lee [Mon, 14 Nov 2016 02:31:29 +0000 (11:31 +0900)]
Fix vulnerability: log_config_set()
This patch forces null termination of e->value string.
Change-Id: I32fba2f23ef2a1b4c725585e2835d2a5530f2d27
Kunhoon Baik [Sun, 13 Nov 2016 06:14:54 +0000 (15:14 +0900)]
Merge branch 'tizen' into tizen_3.0
Change-Id: Iaabf10b234499155e98ab354b4c2084afc3e93fd
Kichan Kwon [Fri, 4 Nov 2016 09:39:49 +0000 (18:39 +0900)]
libdlog : control platform debug log by modifying conf file
- If debugmode is set to 0, libdlog doesn't write platform debug log
- Debugmode doesn't impact on Public API (dlog_(v)print)
- Normal user can't modify it
Change-Id: Ib1a278412baaa5a2ff64612b786a59adffb7c849
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Fri, 11 Nov 2016 05:52:13 +0000 (14:52 +0900)]
dlogutil : print logs when sorting buffer is full
- When specific app prints huge logs without a break, dlogutil also wait endlessly
- Therefore, we have to empty buffer when it is full
- Meanwhile, if you feel that time to fill buffer is too long, you may reduce buffer size
- However, there is a trade-off about sorting buffer size
- Having larger buffer guarantees sorting quality
- Having smaller buffer prints logs fast
- Therefore, we may give user a choice
Change-Id: I23b4ed2582125a430b7e93229f059b9715e23d96
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Thu, 3 Nov 2016 06:07:45 +0000 (15:07 +0900)]
Merge branch 'tizen' into tizen_3.0
Change-Id: I98d5ebe3e300b509efe05bf78edb567b047dad55
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Thu, 3 Nov 2016 06:07:27 +0000 (15:07 +0900)]
Release up
Change-Id: I2b1e73073cb787f0fd82e991eadc41e6eac490b2
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Michal Bloch [Wed, 19 Oct 2016 16:12:14 +0000 (18:12 +0200)]
Tests: add a unit test for pipe message creation.
Change-Id: Ic95a7abea1d9933a42605c8f192d2093deb8b80c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 24 Oct 2016 19:54:13 +0000 (21:54 +0200)]
Pipe: move validity check to the dedicated area
Ideally, this series of checks (null message, total length, priority bounds)
would be a separate function shared by all back-ends. This will be done in a
further commit.
Change-Id: I853c64a32e3ba5e6a72b28b5075f4fca39d6a15f
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Wed, 19 Oct 2016 15:40:33 +0000 (17:40 +0200)]
Check our privilege.
Make sure the privilege reset succeeds.
Change-Id: Ic88703c2ac8d69eb1a173526c60363ba319820c6
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Thu, 27 Oct 2016 14:43:57 +0000 (07:43 -0700)]
Merge "Set proper executable bits" into tizen
Michal Bloch [Mon, 24 Oct 2016 20:08:17 +0000 (22:08 +0200)]
Set proper executable bits
* add to scripts/dlog_upgrade.sh
* remove from plaintext files; this includes source code,
configuration, header, image, manifest, service, and other
miscellaneous (eg. license) files (specifically, all files
touched by this commit except scripts/dlog_upgrade.sh)
Change-Id: Icc1496147c5e78347dff8af5eade3c6cfe13bffd
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Kichan Kwon [Wed, 19 Oct 2016 13:07:21 +0000 (22:07 +0900)]
dlogutil : print logs stored for long time
- If any logs don't be written, some logs stored most currently can't be printed
- When remainder logs haven't printed for long time,
it will be printed without written time
Change-Id: Id51f0a2a078e74f1f568d863b8abd78711d781d5
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 19 Oct 2016 10:42:52 +0000 (19:42 +0900)]
dlogutil : modify timeout when dlogutil decides to terminate
- When "-d" or "-t" option is applied, dlogutil is terminated
after printing remainder in the buffer.
- However, if the time interval with current log and last log
is less than timeout, current log can't be printed.
- Therefore, timeout should be zero after decision.
- In addition, to prevent the situation that dlogutil can't decide
because of continuous logs, waiting timeout also be decreased.
Change-Id: Ia29d083c402263163573c58f33ce976a665e1070
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kunhoon Baik [Mon, 17 Oct 2016 08:51:54 +0000 (17:51 +0900)]
Disable to log to console & stdout for syslog
Change-Id: I7ff528856ee35e4f8883edbd18f592038dfc9085
Kichan Kwon [Mon, 17 Oct 2016 15:37:05 +0000 (00:37 +0900)]
dlogutil : check elapsed time by comparing both ends
- Pipe backend uses clock_gettime and Logger backend uses current_kernel_time
- Because dlogutil uses clock_gettime, it can't check elapsed time at the Logger backend
- Therefore, for portability, dlogutil doesn't record current time
- To prevent underflow, use long variables
Change-Id: I32a11e8518526e24953a5dcd414b8c634ad3d778
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Karol Lewandowski [Mon, 17 Oct 2016 14:00:20 +0000 (07:00 -0700)]
Merge changes Ib648c1bf,Idb9716c8 into tizen
* changes:
dlog_logger: Drop redundant User/Group settings
dloginit: Execute dloginit service with all filesystems mounted
Karol Lewandowski [Mon, 17 Oct 2016 13:59:22 +0000 (06:59 -0700)]
Merge "Micro-optimisation" into tizen
Karol Lewandowski [Mon, 17 Oct 2016 13:56:01 +0000 (06:56 -0700)]
Merge "Fix device file path" into tizen
Michal Bloch [Fri, 14 Oct 2016 16:31:27 +0000 (18:31 +0200)]
Fix a deadlock
Change-Id: I606ebf58c071be4974be58933799d1aadc214342
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Kichan Kwon [Fri, 14 Oct 2016 06:21:30 +0000 (15:21 +0900)]
Fix device file path
Change-Id: If1dd8abde1bb68f63b04e2fc19ec6be9a529432f
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Karol Lewandowski [Wed, 12 Oct 2016 11:12:27 +0000 (13:12 +0200)]
dlog_logger: Drop redundant User/Group settings
User and Group default to root for system services.
Additionally, reformat note about TZ variable setting.
Change-Id: Ib648c1bf47169c3da5476e4612e11b5d8826ded3
Karol Lewandowski [Wed, 12 Oct 2016 11:08:15 +0000 (13:08 +0200)]
dloginit: Execute dloginit service with all filesystems mounted
dloginit needs access to /opt/etc/dlog.conf for it to read
administrator-provided config correctly.
Change-Id: Idb9716c80786a721b54bf5f67a7cc38065feeb59
Michal Bloch [Wed, 12 Oct 2016 14:44:55 +0000 (16:44 +0200)]
Micro-optimisation
Change-Id: I790920282f4d6b4857d3a5b0535e5a9c202c8a70
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 10 Oct 2016 16:56:03 +0000 (18:56 +0200)]
Report meddling with libdlog internal state
Change-Id: Ife49638d2f0f7fdca69b015d51ed8c30e3a32834
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 10 Oct 2016 16:36:17 +0000 (18:36 +0200)]
Extract message creation to a separate function
Change-Id: I03a99b40599164f7eb595e0824e02551c17e7462
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Thu, 13 Oct 2016 09:56:43 +0000 (02:56 -0700)]
Merge "Fix code issues found by cppcheck." into tizen
Karol Lewandowski [Thu, 13 Oct 2016 09:53:34 +0000 (02:53 -0700)]
Merge "Add unit tests." into tizen
Karol Lewandowski [Wed, 12 Oct 2016 09:45:56 +0000 (02:45 -0700)]
Merge topic 'dlog-pipe-fix' into tizen
* changes:
pipe: Only take up file descriptors when needed
pipe: Fix multithreaded pipe file descriptor reacquisition
Ensure dlog is started before regular Tizen services wanting to use it
Prevent segmentation faults and memory leaks
Fix libdlog initialization with multiple threads
Michal Bloch [Wed, 5 Oct 2016 15:39:38 +0000 (17:39 +0200)]
Fix code issues found by cppcheck.
Change-Id: I79547320b0bb566efba904163094861d7514e83d
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 23 Sep 2016 13:35:16 +0000 (15:35 +0200)]
Add unit tests.
Change-Id: Ic1c02937f6cf6577ce63aa5961f76a5b54f0af99
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 30 Sep 2016 14:23:58 +0000 (16:23 +0200)]
pipe: Only take up file descriptors when needed
Change-Id: I7ade660e8e2273654ed8b782f42870824b33256e
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 30 Sep 2016 14:18:43 +0000 (16:18 +0200)]
pipe: Fix multithreaded pipe file descriptor reacquisition
Change-Id: I6d64a9f9adea2334dcaa67cbe2e6c6d98cb58b45
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Thu, 29 Sep 2016 19:28:28 +0000 (21:28 +0200)]
Ensure dlog is started before regular Tizen services wanting to use it
Change-Id: I9b80c2ae97b428be3309fbc30eb000d7f8716fa9
Michal Bloch [Thu, 29 Sep 2016 15:58:52 +0000 (17:58 +0200)]
Prevent segmentation faults and memory leaks
Change-Id: I51125aa059f028280f21cde2e72053f81ecfdbb6
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Kichan Kwon [Tue, 11 Oct 2016 11:37:27 +0000 (20:37 +0900)]
Update release number
Change-Id: Ib6768d7516b56a717577846ec493dce855a9fbb7
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 11 Oct 2016 11:32:40 +0000 (04:32 -0700)]
Merge "dlogutil : fix that some logs overtake previous logs having same time" into tizen
Kichan Kwon [Mon, 10 Oct 2016 12:38:30 +0000 (21:38 +0900)]
dlogutil : fix that some logs overtake previous logs having same time
- Two logs can be written at the same time (having same sec and nsec)
- In this case, the log written afterward should be located backwardly
Change-Id: Id6d36d91606cfa5c2621a8d591303e7d4d0d45a7
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Karol Lewandowski [Tue, 11 Oct 2016 10:42:55 +0000 (03:42 -0700)]
Merge "pipe: Also reconnect when last write was for bad fd" into tizen
Karol Lewandowski [Thu, 29 Sep 2016 18:45:09 +0000 (20:45 +0200)]
Fix libdlog initialization with multiple threads
The backup null log handler is now set only on initialisation failure
instead of always being set at the beginning and overridden later.
The initialisation check does not care which particular handler is installed,
so threads which attempted to write a log while another thread was carrying out
initialisation could be directed to the null handler.
Change-Id: I3aaf6dcad8f72611e413969d48f0f68d44a7c308
Karol Lewandowski [Thu, 29 Sep 2016 19:32:07 +0000 (21:32 +0200)]
pipe: Also reconnect when last write was for bad fd
Change-Id: Iaf7f2fe44383a0395fd7199564aa3a28cf44298d
Kichan Kwon [Thu, 6 Oct 2016 08:37:27 +0000 (17:37 +0900)]
Version up
Change-Id: Id13303c2ea8149a0441b317eab16d0890f42ff70
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Thu, 6 Oct 2016 08:34:31 +0000 (01:34 -0700)]
Merge "dlogutil : sort logs regardless of backend" into tizen
Kichan Kwon [Wed, 28 Sep 2016 02:19:28 +0000 (11:19 +0900)]
dlogutil : sort logs regardless of backend
Change-Id: Idef92cb357a863b763162fd51d08ecbe241fba3b
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Tue, 4 Oct 2016 01:44:37 +0000 (10:44 +0900)]
Add path variable in the script file.
- For security issue
Change-Id: I958ceeae59b681b501cab420eb99e88b24cc60bd
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Karol Lewandowski [Mon, 3 Oct 2016 16:00:48 +0000 (09:00 -0700)]
Merge "pipe: Fix recvmsg() error handling" into tizen
Karol Lewandowski [Mon, 3 Oct 2016 15:59:53 +0000 (08:59 -0700)]
Merge "pipe: Ensure pipe fd is opened in blocking mode" into tizen
Karol Lewandowski [Mon, 3 Oct 2016 15:59:02 +0000 (08:59 -0700)]
Merge "pipe: Fix fd leaks during connect" into tizen
Karol Lewandowski [Fri, 30 Sep 2016 10:49:16 +0000 (12:49 +0200)]
pipe: Fix recvmsg() error handling
This fixes problem with recvmsg() error return code 0 being returned
as proper fd id (0, stdin).
Change-Id: Ia9be0b0b5d12ab202ea52c4153b749e1305a83c4
Karol Lewandowski [Thu, 29 Sep 2016 16:33:16 +0000 (18:33 +0200)]
pipe: Ensure pipe fd is opened in blocking mode
We need to either use blocking fd for write pipes or
handle EAGAIN errors explicitly. First solution is
more effective.
(NOTE: Reader sockets should use non-blocking fds
as readers - dlogutil - to not stall the daemon.)
Change-Id: I5a1043676bb963c7ecb722914d1933839d857093
Karol Lewandowski [Thu, 29 Sep 2016 16:30:31 +0000 (18:30 +0200)]
pipe: Fix fd leaks during connect
Change-Id: Idfb4c68852456a6011194c7d0c9d23874bf202bf
Kichan Kwon [Thu, 29 Sep 2016 08:15:58 +0000 (17:15 +0900)]
Use right variable
- Use unsigned char for storing only positive
- Only compare with not null string
Change-Id: I59b6ab8ef139d88969f6bbdf2905eec878b510ae
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kwon [Thu, 29 Sep 2016 08:11:51 +0000 (01:11 -0700)]
Revert "Modify variable type"
This reverts commit
e793a48a6386c590dac6c541413603fa97835f45.
Change-Id: Ie2ae3e54a8aabbb0392c634678486fe23f571621
Kichan Kwon [Thu, 29 Sep 2016 05:25:04 +0000 (14:25 +0900)]
Modify variable type
Change-Id: I36969df3d8a51fc8fc2ca560f3acc21c8d69e4cc
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Wed, 28 Sep 2016 06:58:23 +0000 (15:58 +0900)]
Revert removed declaration
- In some environment, dlog-internal.h is excluded
- Therefore, dlog.h have not to rely on the declaration of dlog-internal.h
Change-Id: I4726bfe02b42ce389c37c15604a0d3371acafed4
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Fri, 23 Sep 2016 09:08:28 +0000 (18:08 +0900)]
Add dependency to each sub-packages
Change-Id: I86fd90e857bdd4804c74850bf5a6f1ed2757f69c
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kichan Kwon [Thu, 22 Sep 2016 05:06:38 +0000 (14:06 +0900)]
Version up
Change-Id: I94f9a1fdd0df006216900efd4fcc337cad0c23c2
Signed-off-by: Kichan Kwon <k_c.kwon@samsung.com>
Kwon [Thu, 22 Sep 2016 05:00:16 +0000 (22:00 -0700)]
Merge "Fix a typo" into tizen