review.tizen.org Git - platform/core/api/webapi-plugins.git/log

[common] Simplify instance methods registration (3)

+ Macros REGISTER_(A)SYNC have been replaced with new macro
REGISTER_METHOD, which takes only the method name.
The string parameter is now created from the method name.

+ Fixed SVACE detected missing break at the end of the case
in iotcon_instance.cc:1317

+ removed declaration-only method from NFCInstance class.

[Verification]
+ tct-iotcon-tizen-tests 100% pass rate (mobile)
+ tct-keymanager-tizen-tests 100% pass rate (mobile)
+ tct-mediakey-tizen-tests 100% pass rate (mobile)
+ tct-messageport-tizen-tests 100% pass rate (mobile)
+ tct-networkbearerselection-tizen-tests (mobile)

+ tct-messaging-tizen-tests (mobile SMS auto)
+ tct-nfc-tizen-tests (mobile, auto) 98% pass rate
3 tests failed: NFCAdapter_setPreferredApp
Even without this change.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I3f6c6fadd8e5fe78f64a728c4de5fa11dc1191d0

[datacontrol][common] Simplify instance methods registration (2)

Macros REGISTER_(A)SYNC have been replaced with new macro
REGISTER_METHOD, which takes only the method name.
The string parameter is now created from the method name.

[Verification] + tct-datacontrol-tizen-tests 100% pass rate.
+ tct-download-tizen-tests 100% pass rate.
+ tct-exif-tizen-tests 100% pass rate.
+ tct-feedback-tizen-tests 100% pass rate.
+ tct-filesystem-tizen-tests 100% pass rate.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Idb2ce6c9aa15743822aed405a3be5d2156102d60

Merge "[tools] Rewritten mergejs.py and generate_api.py scripts." into tizen

[common] Simplify instance methods registration.

Macros REGISTER_(A)SYNC have been replaced with new macro
REGISTER_METHOD, which takes only the method name.
The string parameter is now created from the method name.

[Verification] + tct-mediacontroller-tizen-tests 100% pass rate.
+ tct-account-tizen-tests 100% pass rate.
+ tct-alarm-tizen-tests 100% pass rate.
+ tct-application-tizen-tests 100% pass rate (requires screen always on).
+ tct-archive-tizen-tests 100% pass rate.
+ tct-badge-tizen-tests 100% pass rate.
+ tct-bluetooth-tizen-tests 100% pass rate.
+ tct-bookmark-tizen-tests 100% pass rate.
+ tct-calendar-tizen-tests 100% pass rate.
+ tct-callhistory-tizen-tests 100% pass rate.
+ tct-contact-tizen-tests 100% pass rate.
+ tct-content-tizen-tests 100% pass rate.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I9be38c2946b2ebb8ea5d1bfbb99ab16a637a3977

[Spec] Fixed build fail for non arm and i586 architectures

Related projects:
github.sec.samsung.net:tizen/webapi-plugins-teec.git
review.tizen.org:29418/platform/core/api/cordova-plugins
fails during the build in case of architectures: x86_64,aarch64,x86_64

[verification] With this fix, related projects are buildable for 64-bit
architectures

Change-Id: I36759e460cb68dc94da0c6843f2995c33795ba03

[tools] Rewritten mergejs.py and generate_api.py scripts.

+ tools/generate_api.py has been rewritten to be more readable.
+ tools/mergejs.py has been rewritten to work more like C++ include directive,\
to be more of a in-place copy-paste mechanism.

Previously the only way to use //=require() was to create a file in which no code
other than the require() directives was allowed to be. If there was some code it
was removed during the preprocessing phase. After this change it is possible to
mix code and require() commands in the same file.

[Verification] I've tested this change by running TCTs for all modules that use require() directive
(all modules with js/ subdir).

tct-filesystem-tizen-tests 100% pass
tct-calendar-tizen-tests 100% pass
tct-contact-tizen-tests 100% pass
tct-content-tizen-tests 100% pass

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I71436797b78a1746b9ea105bc466a75d42d26ddb

Merge branch 'tizen_5.0' into tizen

Change-Id: I2d06bd464e969ded8967bfbdc3b3df8646384ad0

Merge branch 'tizen_4.0' into tizen_5.0

Change-Id: I486c2595028dc8e9cf7555aa13ae114fe8af7be3

Merge branch 'tizen_3.0' into tizen_4.0

Change-Id: I99c57c205dd95970412c98430b9998c773a94917

[version] 2.36

Change-Id: I99c7c0258b677468f6a163e03a7807411dbbde56

[Bluetooth] Fixed issues related to BLE

[Bug/Fix]
  1. Prevent possible crash in case of invalid data passed from native
  2. Prevent type mismatch exception in JS in case of LE devices advertising
     serviceData.

[Verification] tct passrate 100%
  Checked in chrome console and le device with serviceData.

Change-Id: Iecc9929a77a1acfd1b33eb325ea287011b9a6096

[messaging] Fix bugs occurring when filtering by strings or value ranges

The following bugs have been fixed:
- daylight saving time was not taken into account when filtering by
timestamp attribute with AttributeRangeFilter
- AttributeRangeFilter did not work with null/undefined range limits
- isBetweenTimeRange did not work properly with lower limit close to the
minimal value of time_t type variables
- filter with an empty string matchValue never matched other strings

[Verification] Subtestcases from TCT tests added in
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/199159/
that used to fail due to the described bugs now pass.

tct-messaging-sms-tizen-tests pass rate: 100%

This commit has already been reviewed:
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/200662/
Change-Id of the original change was:
Ia6c2074408e8f4fadd10605d6986b5a2d2d4c93b

Change-Id: I6d28a8d153a34cf54084dae5585cbd7d0e771e4a
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>

Merge "[messaging][bugfix] Don't convert filter's matchValue to String" into tizen

[messaging][bugfix] Don't convert filter's matchValue to String

Due to a conversion of matchValue to String, filters with boolean
matchValues did not match objects.

[Verification] All subtest cases, dealing with boolean attributes,
introduced in TCT in commit
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/199159/
passed.

This commit has already been reviewed:
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/200661/
Change-Id of the original change was:
I72fc83328e92529455460469c5dbc1aadc6ce07e

Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Change-Id: Ia8d769b1a9694defdcb403761cff9c2565f5f52b

Merge "[mediacontroller][fix] fix small issues" into tizen

[mediacontroller][fix] fix small issues

issues:
- startup state of server's repeat state was REPEAT_OFF,
  should be REPEAT_ALL
- if client sent request to change attribute to
  currently set value, callback was not invoked. Now
  it is fixed.
- add repeatState to playbackInfo returned by
  playbackInfo getter

[Verification]
tct-mediacontroller-tizen-tests 100% PASS

Change-Id: Iebdbf2ca3af1d395c2ba10753e0ef7efcdc11953
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>

[mediacontroller][5.5] fix method to update playback item

[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-240

[description]
removed checking if playlist exists on device, because
some 3rd party application can get the playlist
from the 3rd party server(such as cloud) directly and we
don't have any information about its name and index

[verification]
MediaControllerServer_updatePlaybackItem_invalid.html - only
this testcase fails (from tct-mediacontroller-tizen-tests).
It needs to be changed/removed

Change-Id: I7809b662a2eb9b99af3690892133e85ed9b41865
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>

[mediacontroller] Autoformatting changes in mediacontroller.

Autoformatting of changes in mediacontroller.

Change-Id: I8e576444123cdc98766c41ae014073964757fc0e
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>

[mediacontroller] SendEvent() js tests fixed + code autoformat.

+ Executed ./code_format script on mediacontroller source code.
+ Fixed invalid tests for MediaControllerClientInfo::sendEvent() method.
+ Fixed minor issues from earlier reviews.
+ initialized all JsonCallbacks to nullptr in constructors of MediaControllerClient/Server

[Verification] tests from test_custom_event.js 100% pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I9514897908e8221ed6f1c8eb1c1ed0083bad0996

[version] 2.53

Change-Id: I91b439ad78c3c11da5ed5622ce55d0e84a3253fb

[utils][mediacontroller] SendEvent() method implementation.

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209

SendEvent()
SendReply()

[Verification] TCT: mediacontroller and deprecated API 100% pass.
New features tested in chrome console.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: If2230979c33f253fbd80171937ac64a8d90d4215

[mediacontroller] Add UnsetCustomEventListener() method.

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209

MediaControllerClient::UnsetCustomEventListener() method implementation.

[Verification] Will be done later with SendEvent().

Change-Id: I7c92243b0abe211dfa11735a11dc29b1fa0496dd
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>

[mediacontroller] Add MediaControllerClient::SetCustomEventListener()

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209

MediaControllerClient::SetCustomEventListener() method implementation.

[Verification] Will be verified later with SendEvent().

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Id30be750edc940e331053c353dc0944ef7d2f18a

[mediacontroller] Add MediaControllerClientInfo interface.

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209

+ MediaControllerClientInfo:
+ attribute name: string

MediaControllerServer:
+ getAllClientsInfo()

[Verification] Unit tests for MediaControllerClientInfo pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I321865c99059a21b02f6bdf9f48f9f001fbf2642

[mediacontroller][ut] Custom events tests.

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209

Tests for custom events feature of media controller.

[Verification] none.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5069f64fc9ff6514ebe830eec30c1777b99bdffe

[version] 2.52

Change-Id: Ic95f124aaf9c015dc6f17d528d88ab32d2ea14b6
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>

[mediacontroller][fix] fix metadata issue

Problem was connected to PlaybackInfo.metadata.
It was throwing an error while null value was set as encoded attributes
like resolution, episode and season. Now it is fixed by checking if
value is null before decoding it.

[Verification]
tested manually on chrome console
tct-deprecatedapi-tizen-tests 100% PASS
tct-mediacontroller-tizen-tests 100% PASS

Change-Id: Ibc0f44591b75dd53348ff1db2900e3da581534a0
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>

Merge "[fix][mediacontroller] fix error with new metadata features" into tizen

[fix][mediacontroller] fix error with new metadata features

Change-Id: I957a41a84d1a8382c060ea615485c0c0f4d18602
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>

Merge "[mediacontroller] add api for new metadata features" into tizen

[mediacontroller] add api for new metadata features

[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-238

[Verification]
tested manually on chrome console
tct-mediacontroller-tizen-tests 100% PASS

Change-Id: I459724bfa88ab9a37a97be55eda0bd2e01e83add
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>

Merge changes I5e7e74fa,Icc3aa5bb into tizen

* changes:
[mediacontroller] Check for errors added.
[mediacontroller] Magic strings to constants.

[mediacontroller] Check for errors added.

+ Result of native call to SendCommand was not checked for failure.
This commit adds this validation.

+ Added return after error occured in AddPlaybackInfoChangeList().

[Verification] All tests pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5e7e74faa1c8902f35e45278c7c05778094867c4

[mediacontroller] Magic strings to constants.

Keys of args passed from JS to instance methods were used
as inline strings, rather than constants.

[Verification] MediaController TCT tests 20190920 100% pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Icc3aa5bb5bd947cf6bb680d15f4edc077901361b

Merge branch 'tizen_5.0' into tizen

Change-Id: I02a3c6d93c0924a0cf313110a3f79c4b67a7def8

Merge branch 'tizen_4.0' into tizen_5.0

Change-Id: I6307aead894899f049bacde9cb8af54febe91251

Merge branch 'tizen_3.0' into tizen_4.0

Change-Id: Iea1a8a0914572301a28c53d54bf64c795237ce44

[version] 2.35

Change-Id: Ifc5a4e534e395579031af9d3d115389b7545ab77

[Filesystem] Source code auto-formatting

Used: ./code_format src/ -c -js

Change-Id: I1a27efa220445342ec42ef5327d06ac7bdd40ca9
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>

[Archive] Fix for retrieving virtual roots

Current implmentation gets only internal virtual roots. This change adds
getting external roots as well.

[Verification] TCT Archive passed with 100% p.r.

Change-Id: Ia961dd276901ed31d42b22d93148d51066276163
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>

[Filesystem] List of virtual roots for resolve function fixed.

Current implementation of virtual roots list did not include internal0 or
external memory i.e. SDCard or USBDrive. It results in not working resolve()
function, when location to resolve was on external memory.

Verification: TCT - 100 % pass.

Change-Id: I11c2537a7f5643f8c9ccfe2f45be9f3bce3edf00
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>

[mediacontroller][fix] fixed error with subscribe method

before that commit, if subscribed method was executed
on already subscribed server then unknown error was thrown
Now it is fixed.

[verification]
tested manually on chrome console

Change-Id: I7d5fe3d0d09eb95d6542ebfb2e163ca32c5d01a0
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>

[version] 2.50

Change-Id: I397c4edbc48cebaf72582a9a60d547256bcd6d6d

[mediacontroller] Add display rotation abilities

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-234

[Verification]
tested manually on chrome console

Change-Id: I226a84bcb17757e900bfce64058180dec812af95
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>

[mediacontroller] Add display mode abilities

[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-233

[Verification]
tct-mediacontroller-tizen-tests 100% PASS
tested manually on chrome console

Change-Id: I816d97c38f0ce4fe2f894da1672b748a491cc913
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>

[Mediacontroller] added display rotation feature

[Verification] Code compiles without errors.
Basic test in chrome console works properly.

/// 1. adding command listener
var mcServer = tizen.mediacontroller.createServer();
mcServer.updatePlaybackState("PLAY");
var changeListener = function(clientName, rotation)
{
  console.log("Display rotation change requested to: " + rotation + " by " + clientName);
  return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"message": "Success"}), 0);
};
watcherId = mcServer.displayRotation.addChangeRequestListener(changeListener);

/// 2. checking NotSupportedError when sending without enabled ability
var mcClient = tizen.mediacontroller.getClient();
var mcServerInfo = mcClient.getLatestServerInfo()
var rotation = "ROTATION_180";
mcServerInfo.displayRotation.sendRequest(rotation,
    function(data, code)
    {
      console.log(
          "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
    });

/// 3. register listener for mode changes (client side)
watcherId = mcServerInfo.displayRotation.addDisplayRotationChangeListener(function(rotation)
{
  console.log(mcServerInfo.name + " server display rotation changed to " + rotation);
});

/// 4. change the value of mode 360 (should trigger listener from point 3)
mcServer.displayRotation.displayRotation = "ROTATION_180"

/// 5. enable ability of server
// TODO: mcServer.abilities.displayRotation = "?"

/// sendRequest again (should trigger listener from point 1)
mcServerInfo.displayRotation.sendRequest(rotation,
  function(data, code)
  {
    console.log(
        "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
  });

Change-Id: I9c497dbaaf5e7f491c2d57c568e52581c980951d
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>

[Mediacontroller] added display mode feature

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-231

[Verification] Code compiles without errors.
Basic test in chrome console works properly.

/// 1. adding command listener
var mcServer = tizen.mediacontroller.createServer();
mcServer.updatePlaybackState("PLAY");
var changeListener = function(type, clientName)
{
    console.log("Display mode change requested to: " + type + " by " + clientName);
    return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"message": "Not allowed"}), 13);
};
watcherId = mcServer.displayMode.addChangeRequestListener(changeListener);

/// 2. checking NotSupportedError when sending without enabled ability
var mcClient = tizen.mediacontroller.getClient();
var mcServerInfo = mcClient.getLatestServerInfo()
var type = "ORIGIN_SIZE";
mcServerInfo.displayMode.sendRequest(type,
    function(data, code)
    {
      console.log(
          "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
    },
    function(e)
    {
      console.log("Error executing command: " + e.message);
    });

/// 3. register listener for mode changes (client side)
watcherId = mcServerInfo.displayMode.addModeChangeListener(function(type)
{
  console.log(mcServerInfo.name + " server display mode changed to " + type);
});

/// 4. change the value of display mode (should trigger listener from point 3)
mcServer.displayMode.type = "FULL_SCREEN"

/// 4. enable ability of server
// TODO support: mcServer.abilities.displayMode.originSize = "YES"

/// sendRequest again (should trigger listener from point 1)
mcServerInfo.displayMode.sendRequest(type,
    function(data, code)
    {
      console.log(
          "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
    },
    function(e)
    {
      console.log("Error executing command: " + e.message);
    });

Change-Id: Icbc98513372d8da8e111a44d873c6559dede89e9

[Mediacontroller] added subtitles feature and related ability

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-230

[Verification] Code compiles without errors.
Basic test in chrome console works properly.

/// 1. adding command listener
var mcServer = tizen.mediacontroller.createServer();
mcServer.updatePlaybackState("PLAY");
var changeListener = function(enabled, clientName)
{
    console.log("Subtitles mode change requested to: " + enabled + " by " + clientName);
    return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"message": "Not allowed"}), 13);
};
watcherId = mcServer.subtitles.addChangeRequestListener(changeListener);

/// 2. checking NotSupportedError when sending without enabled ability
var mcClient = tizen.mediacontroller.getClient();
var mcServerInfo = mcClient.getLatestServerInfo()
var enabled = true;
mcServerInfo.subtitles.sendRequest(enabled,
    function(data, code)
    {
      console.log(
          "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
    });

/// 3. register listener for mode changes (client side)
watcherId = mcServerInfo.subtitles.addModeChangeListener(function(status)
{
  console.log(mcServerInfo.name + " server subtitles mode changed to " + status);
});

/// 4. change the value of subtitles (should trigger listener from point 3)
mcServer.subtitles.enabled = true

/// 5. enable ability of server
mcServer.abilities.subtitles = "YES"

/// sendRequest again (should trigger listener from point 1)
mcServerInfo.subtitles.sendRequest(enabled,
function(data, code)
{
  console.log(
      "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
});

/// 6. register ability change listener and trigger the update
var listener =
{
  onsimpleabilitychanged: function(server, type, ability)
  {
    console.log(type + " ability changed, server name: " + server.name + ", ability: " + ability);
  }
};
mcClient.addAbilityChangeListener(listener);

/// call updates to trigger listener
mcServer.abilities.subtitles = "NO"
mcServer.abilities.subtitles = "NO"
/// Listener should be triggered once

Change-Id: I00ad78a44b696a7d885d13499af77cf762e54c7e

Merge "[Tools] SAM script added" into tizen

Merge "[Mediacontroller] added mode 360 feature" into tizen

[Mediacontroller] added mode 360 feature

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-229

[Verification] Code compiles without errors.
Basic test in chrome console works properly.

/// 1. adding command listener
var mcServer = tizen.mediacontroller.createServer();
mcServer.updatePlaybackState("PLAY");
var changeListener = function(enabled, clientName)
{
    console.log("Spherical mode change requested to: " + enabled + " by " + clientName);
    return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"message": "Not allowed"}), 13);
};
watcherId = mcServer.mode360.addChangeRequestListener(changeListener);

/// 2. checking NotSupportedError when sending without enabled ability
var mcClient = tizen.mediacontroller.getClient();
var mcServerInfo = mcClient.getLatestServerInfo()
var enabled = true;
mcServerInfo.mode360.sendRequest(enabled,
    function(data, code)
    {
      console.log(
          "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
    },
    function(e)
    {
      console.log("Error executing command: " + e.message);
    });

/// 3. register listener for mode changes (client side)
watcherId = mcServerInfo.mode360.addModeChangeListener(function(status)
{
  console.log(mcServerInfo.name + " server spherical mode changed to " + status);
});

/// 4. change the value of mode 360 (should trigger listener from point 3)
mcServer.mode360.enabled = true

/// 5. enable ability of server
mcServer.abilities.mode360 = "YES"

/// sendRequest again (should trigger listener from point 1)
mcServerInfo.mode360.sendRequest(enabled,
    function(data, code)
    {
      console.log(
          "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
    },
    function(e)
    {
      console.log("Error executing command: " + e.message);
    });

/// 6. register ability change listener and trigger the update
var listener =
{
  onsimpleabilitychanged: function(server, type, ability)
  {
    console.log(type + " ability changed, server name: " + server.name + ", ability: " + ability);
  }
};
mcClient.addAbilityChangeListener(listener);

/// call updates to trigger listener
mcServer.abilities.mode360 = "NO"
mcServer.abilities.mode360 = "NO"
/// Listener should be triggered once

Change-Id: I8170d56f6d5b18f053047d48d55e68d3ebbe7719

Merge "[download] Download module exception correction" into tizen

[Mediacontroller] Prepared templates for new features

This commit is prepared as a parent for several features introduced with
related native ACR http://suprem.sec.samsung.net/jira/browse/ACR-1444

Related ACRs:
http://suprem.sec.samsung.net/jira/browse/TWDAPI-229
http://suprem.sec.samsung.net/jira/browse/TWDAPI-230
http://suprem.sec.samsung.net/jira/browse/TWDAPI-231
http://suprem.sec.samsung.net/jira/browse/TWDAPI-232

Change-Id: Id23a4b53a5f9b9232224f942a2bde18940680abf

Merge "[mediacontroller] abilities and subscriptions" into tizen

[mediacontroller] abilities and subscriptions

[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-227

[Verification]
tested manually on chrome console
tct-mediacontroller-tizen-tests 100% PASS

Change-Id: I839c1f825e61caa828ad06d2c6b4a779ee3da320
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>

[build] Fix for incremental build

Some file were created and changed while using incremental build.
This commit makes these files invisible to git status.

Change-Id: Ic10286bc786f35644b4b9736f73ac788200a8c0b
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>

[Tools] SAM script added

Added script for S/W Architecture Maturity checking

Change-Id: I87e1836e77197740935c4252699e3f4aee08f66e
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>

[download] Download module exception correction

NotFoundError and TypeMismatchError exceptions removed from methods:
void cancel(long);
void pause(long);
void resume(long);

Change that enables resuming canceled or failed download job.
abandon() method added, to destroy download job, abandoned download can not be resumed.
ABANDONED state added to differentiate from CANCELED, which can be resumed.

[Verification] Download TCT pass rate is 100%.
New behaviour was tested manually from console.

ACR: http://suprem.sec.samsung.net/jira/browse/TWDAPI-222

Change-Id: I52f5e7fa1875f49354178b8979c92e0d20011bc2
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>

[fix][mediacontroller] add callIfPossible to listeners

This commit adds callIfPossible functions to listeners to
avoid calling not set callbacks.

Change-Id: I91b36177eac0286d644fd298d9ad253e3586badb
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>

[Mediacontroller] Fixed issue with invalid name of enum

[Bug]
1. wrong value of enum NONE instead of NO_CATEGORY
2. invalid parsing of empty keyword, which caused crash

[Verification] Code compiles without errors.
  Tested in chrome console with code:
var server = tizen.mediacontroller.createServer();
function searchRequestListener(clientName, request)
{
  console.log("search command received");
  return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"key": "value"}), 5);
}
server.setSearchRequestListener(searchRequestListener);
server.updatePlaybackState("PLAY");

/* Client-side code */
var client = tizen.mediacontroller.getClient();
var sinfo = client.getLatestServerInfo();

var query = [
  new tizen.mediacontroller.SearchFilter("MUSIC")
];

sinfo.sendSearchRequest(query, function(reply)
{
  console.log("reply status: " + reply.code);
  console.log("reply data: " + reply.data);
});

Change-Id: Ie522f07286bf4604fe43428b716d6d808abbea07

[version] 2.49

Change-Id: I87d61cdefe4c22a85147329cb14e698cee59308e

[formatting] Code auto-formatting.

Executed ./code_format script on the repository to fix invalid formatting.

Change-Id: Ieb8d825c4525dedc740319a3729ffd54280fef71
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>

Merge "[mediacontroller] New implementation for sendCommand()," into tizen

Merge "Use bundle_init_byte_array instead of bundle_add_byte_array" into tizen

Use bundle_init_byte_array instead of bundle_add_byte_array

The bundle_add_byte_array function will be changed.

Requires:
- https://review.tizen.org/gerrit/#/c/platform/core/base/bundle/+/211570/

Change-Id: I1465f336564da1fe3081dc02e09637422849ca7e
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>

[mediacontroller] New implementation for sendCommand(),

http://suprem.sec.samsung.net/jira/browse/TWDAPI-226

+ sendCommand() accepts both object and tizen.Bundle as data argument.
+ Command listener can now return both RequestReply object, tizen.Bundle and object.

[Verification] Tested with custom javascript test cases.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I357e5b398724bdfada48684fb5bbc8f11be52f20

[mediacontroller][common][webapi-plugins.spec][tizen] Implementation for search API.

http://suprem.sec.samsung.net/jira/browse/TWDAPI-208

Implementation for search API.

[Verification] Manual API testing.
tct-mediacontroller-tizen-tests 100% pass
tct-messageport-tizen-tests 100% pass

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I47cb4b3234e212db77ed20c4f899f4b5bed2d662

[tests][mediacontroller] tests for new sendCommand implementation.

This testcases define expected behavior of sendCommand() method
after implementation is changed.

[Verification] Tests are passing with working version of new implementation.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5923e45bb0ddc2013b1fe81951a3966413a3e4b6

[tizen][utils][mediacontroller] Rewrite js tests using mochajs.

JS tests for the implementation of search API.

Tests for mediacontroller search api and tizen.Bundle have
been rewritten using mochajs library.

[Verification] Tests pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I22d5b5bd518b709f8d4aa94149906439390b4e28

[version] 2.48

Change-Id: I7a5c9eb27b5c115f9c5c1b29c9720a9883b26408

[Alarm] Fixed the behaviour change introduced during SVACE issues fixing

[Bug] Issue was introduced in commit 1b4d5c8e8e760140c3e5c93e59ff23bde99f9862
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/207226/

Alarm TCT - 12 fails

[Verification] Alarm TCT after fix - 100% (tizen-unified_20190804.1_mobile-wayland-armv7l-tm1)

Change-Id: I343bf2d20d2f88f6d3ac37eb2631a0db395daecb

Merge "[tests][common][webapi-plugins.spec] Changed common unit tests files structure." into tizen

[tests][common][webapi-plugins.spec] Changed common unit tests files structure.

New structure allows better modularization of unit tests.

[Verification] webapi_common_tests are built successfully and pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Icad5cca7739716bde7c09092f4d1d73fca1972a0

[utils][tests] Add mochajs and chaijs libraries sources.

They can be used to write tests for js code.
It is required to add them to the debugging application.
After you have application with this libraries, you can
than run tests from chrome snippets in remote debugger.

[Verification] I have tested this setup in my test application
and it seems to be working.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ide535ee8ce29b4a735351f2fb9cbde36cc7c935e

Merge "Merge branch 'tizen_5.0' into tizen" into tizen

[common] Fix JsonToBundle implementation.

Broken implemenation has slipped through unspotted.
While testing previous change in JsonToBundle the API
installed on device probably has not been updated.

[Verification] UTs were failing and now they are passing.

Change-Id: I6c871ff03a79417a630da1db50f2f7300fca9ca8
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>

[tizen] Add copy ctor to tizen.Bundle.

This will simplify the implementation of API methods which
need to accept both plain json object and tizen.Bundle.
In example: function sendCommand(..., data) { var d = new tizen.Bundle(data); }
instead of manually having to check if data is a tizen.Bundle or object.

[Verification] Added new test case for this constructor, all existing tests passes.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I4c880dbf8889c88bb20a4029b5cbb8fa2941eb1d

[mediacontroller][common] Support for null values in Json-Bundle conversions.

JsonToBundle and BundleToJson functions didn't support null values. Manually
handling them every time was cumbersome, hence this commit adds support for null values.

[Verification] + bundle c++ unittests 100% pass
+ bundle js tests 100% pass
+ tct-mediacontroller-tizen-tests 20190722 tct package 100% pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I1315899d8ebb66935ea9b10791b5dba82341af45

Merge branch 'tizen_5.0' into tizen

Change-Id: I5d9b8f0a57450b051a5c56bfb1b4c704ac0121a5
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>

[tizen][mediacontroller] Change toJSON implementation to simplify serialization.

Before this commit, in order to send Bundle object to the C++ layer
it was necessary to call Bundle.toString() method, and than picojson::parse()
in C++ to deserialize it. This commit removes the need for both this steps.
They will be done implicitly by the framework.

[Verification] bundle js tests 100% pass rate.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I89b11bc634b56b720dd8a5ecea8537ef1ce51b24

Merge branch 'tizen_4.0' into tizen_5.0

Change-Id: Id7abc98f999b2bfb8dc0b49692f688f1b4c9ee9f

Merge "[Application] Fixed path of getAppSharedURI" into tizen

Merge "[Application] Fixed path of getAppSharedURI" into tizen_5.0

Merge "[Project][code_formatter] Fix JS files formatting error" into tizen

[Application] Fixed path of getAppSharedURI

Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy

New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner  users        4096 Jul 18 13:06 .
drwxr-xr-x 5 owner  users        4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner  system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw         58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner  users        4096 Jul 18 13:06 trusted

Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res

[Verification] Checked manually in chrome console
  TCT Application 100% passrate

Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09

Merge "[Project][Coverity] Some static analysis problems were corrected." into tizen

[Project][code_formatter] Fix JS files formatting error

Due to a bug, js files were not formatting.

Tested manually - js formatting works.

Change-Id: I5a4e2f2dc05241e15c85815f8380563303fa7ed1
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>

[Project][Coverity] Some static analysis problems were corrected.

Those Coverity issues were fixed:
CHECKED_RETURN 835501 - Messageport
CHECKED_RETURN 835504 - Download
CHECKED_RETURN 835505 - Messaging Email
CHECKED_RETURN 835506 - Download
CHECKED_RETURN 1064913 - Common
CHECKED_RETURN 1064914 - Common
CHECKED_RETURN 1064915 - Alarm
CHECKED_RETURN 1074834 - Application
CHECKED_RETURN 1074835 - Application

In Alarm module there is fix of Exception message.
There is also correction of logs in Archive module to bring consistency.
Some files was changed only by cude_format script.

[Verification] Coverity was run, and fixed issues are not on a list anymore.
http://10.113.170.22:8810/download/16062/artifacts/analysis_report_I6ddb03_coverity-2017.07.html
TCT pass rate of changed modules is 100%.

Change-Id: I6ddb030c071166d688a902849c9f979cfbae62d6
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>

[5.5][package] Change deprecated enum to new ones

changed every occurrence of enum values to new ones

native ACR with related changes:
http://suprem.sec.samsung.net/jira/browse/ACR-1419

[Verification]
tct-application-tizen-tests 100% PASS
tct-package-tizen-tests 100% PASS

Change-Id: I2d4898411efeb18a8526f497d4b837b8d2bb2387
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>

Merge remote-tracking branch 'origin/tizen_3.0' into tizen_4.0

[Verification] TCT passrate 100%.

Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Change-Id: Id004158e62f5d0b6f2c09eeee5cf300d461a9d9f

[Project][code_formatter] Fix multiple errors in shell scripts:

- Use null character as path delimiter in git and find commands.
It allows file path to contain newlines and other white space characters.
- Add quotes when needed to prevent globbing and word splitting.
- Simplify logic.

Change-Id: I58de7a3bd1e2e3165ada8b7650b2863e1fc95c15
Signed-off-by: Ernest Borowski <e.borowski@partner.samsung.com>

[version] 2.47

Change-Id: I37a5ea2a5100290b0bed1e7c19baef26e384ea54

[mediacontroller][bundle] fixing custom command

Refactored some functions to use tizen.Bundle
and formated code with format script

Changed implementation of functions:
+ MediaControllerInstance::MediaControllerServerReplyCommand
+ MediaControllerInstance::MediaControllerServerInfoSendCommand

+ MediaControllerServer::OnCommandReceived
+ MediaControllerServer::CommandReply

+ MediaControllerClient::OnCommandReply
+ MediaControllerClient::SendCommand

[Verified]
tct-mediacontroller-tizen-tests - 100% passed
also tested manually on chrome console

Change-Id: I9d072d10a5fc272c54d17731f33ae9b733009412
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>

[tizen] Update bundle js tests after fix.

+ Added tests for regular arrays and Uint8Arrays.
+ Updated toJSON test after method modification.
+ Added tests for toString method.

[Verification] Tests pass for fixed bundle.

Change-Id: Idd9298b311fee56c4387c5f9c9fbd2b4984944b0
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>

[tizen] Fix issue with regular arrays in Bundle.

Bundle now stored byte streams as Uint8Arrays and converts regular arrays with
octet values to Uint8Arrays in Bundle::set() method.

toString() method now prints Uint8Arrays in the same way as regular arrays
using "[1,2,3]" format, instead of the "{0: 0, 1: 1, 2: 2}" format which is the
default behavior of toString() method on typed arrays.

[Verification] Modified tests passed.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I9eeca40d9760413c81888f4980146c8025d227d2

Merge "[tizen] Bundle constructor fix." into tizen

[tizen] Bundle constructor fix.

xwalk.utils.validator replaced with xwalk.utils.type.

[Verification] All tests passed.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I2a7a8d4c1c2fb81ab8750a122596378d3af975f3