Sangyoon Jang [Fri, 22 Nov 2019 10:06:42 +0000 (19:06 +0900)]
Fix StepRecoverChangeOwner
Recover ownership, permission when per user directories updated.
Change-Id: Ic5b52a56b29dddfd6464e99ae48fc05497932a93
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Tue, 10 Dec 2019 07:21:18 +0000 (16:21 +0900)]
Add null checking before setting cleanup flag
Change-Id: Ib80ccd3a48c1d392b11ab081a6050de82fcf6d97
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Ilho Kim [Fri, 13 Dec 2019 01:57:17 +0000 (10:57 +0900)]
Fix static analysis issue
- Fix uninitialized scalar field
Change-Id: I89771d1ea4be2e096932e9826dae4ab3448ff202
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Mon, 2 Dec 2019 08:42:00 +0000 (17:42 +0900)]
Fix FindRecoveryFile
If path is not exist, directory_iterator throw exception
Change-Id: Ic0821c2e4f34f7cb9a71219764d492aeecb1485c
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Junghyun Yeon [Thu, 12 Dec 2019 23:49:32 +0000 (23:49 +0000)]
Merge "Change header path to be included" into tizen
Ilho Kim [Tue, 10 Dec 2019 01:32:18 +0000 (10:32 +0900)]
Change the way to delete "shared/data" directory
If a package being installed has "shared/data" directory and there is some file
remove fail because that directory is not empty
and the way to delete "shared/data" files is chaged from "remove" to "remove all"
Change-Id: I22428504749dbae981c28e612fac84e15ac7a475
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Junghyun Yeon [Fri, 6 Dec 2019 08:26:52 +0000 (17:26 +0900)]
Change header path to be included
Its path has changed
Related changes:
[tpk-manifest-handlers] : https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-manifest-handlers/+/219481/
Change-Id: I3933d2ae6e5c8ea90329752fa3de0054ea862e8a
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Sangyoon Jang [Tue, 19 Nov 2019 04:23:51 +0000 (13:23 +0900)]
Fix StepUpdateStorageDirectories
The step StepUpdateStorageDirectories is for adding / removing
shareddata directory when the package updated with / without privilege
for shareddata. This process can be revoked when the package update is
failed.
Change-Id: Ibef2c65807682bc720f53fe8a3f78d9ca82d3c8c
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Wed, 20 Nov 2019 10:00:51 +0000 (19:00 +0900)]
Add smoke-util functions to check existance of shared/data
Change-Id: I0a8a7bb5cd8a2ff9889948b2d9d12566761c54c1
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Tue, 19 Nov 2019 09:10:04 +0000 (18:10 +0900)]
Fix smoke-test functions for rollback cases
The custom step cannot be added outside of installer, because steps are
initialized when Run() invoked.
(If some step added outside of installer, that step will be executed at
first, ignoring original steps)
This patch defines a new virtual function creating overridden installer
object which is fail at the end of steps or specific stage.
Change-Id: I00eed98d51bb4d083c421baa6a83f4b8ca17e90d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Junghyun Yeon [Mon, 25 Nov 2019 02:11:29 +0000 (11:11 +0900)]
Release version 1.31.0
Changes:
- Fix build warning
- Separate dotnet app existance checking logic
- Make PkgQuery class as inner class of PkgQueryInterface
- Reset data of PkgQuery at beginning of process
- Change shared/data handle logic
Change-Id: I436bd47db2326ef9ba710dc25a8f119ba693719c
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Junghyun Yeon [Fri, 19 Jul 2019 00:47:03 +0000 (09:47 +0900)]
Change shared/data handle logic
- Create shared data directory for each package at
certain directory to prevent creation of N^2 smack labels.
- Create symlink at previous location for backward compatibility.
Change-Id: Ibb52bfef6843e3d38f91eabb418d87b46a4e918b
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Sangyoon Jang [Tue, 19 Nov 2019 06:36:10 +0000 (15:36 +0900)]
Reset data of PkgQuery at beginning of process
The installer process can run multiple instance of same pkgid, so
PkgQuery should be reset.
Change-Id: Ibc2f6369e70831d10439cacbdaccbb9c94601906
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Tue, 19 Nov 2019 04:27:38 +0000 (13:27 +0900)]
Make PkgQuery class as inner class of PkgQueryInterface
PkgQuery class should be accessed by PkgQueryInterface only.
Change-Id: I9752fe4528fb24ff74e24d190d230b799a61fa96
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Junghyun Yeon [Thu, 7 Nov 2019 23:20:30 +0000 (08:20 +0900)]
Separate dotnet app existance checking logic
Separate dotnet app existance checking logic to be inherited.
Change-Id: I126800be19113f883e809533b92e4bb0bebc99b0
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Junghyun Yeon [Mon, 11 Nov 2019 12:53:13 +0000 (21:53 +0900)]
Fix build warning
Change-Id: I87e3be1b7629cd76299afa78e921927ad3e6525b
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Ilho Kim [Tue, 12 Nov 2019 04:27:27 +0000 (13:27 +0900)]
Release version 1.30.14
Changes:
- Block Wrong use of backend when uninstall
- Add condition when checking dotnet version
- Fix installing privileges of hybrid package
- Fix coding rule
- Implement clean operation for recovery
- Fix codes for efficiency
- Make up recovery file for sudden power loss
- Refactor Checking Dependency routine
- Fix step_check_upgradable's dependency check
Change-Id: Ifbc3492f0970128dde2863ca1af101a85a208d47
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Wed, 16 Oct 2019 07:01:05 +0000 (16:01 +0900)]
Fix step_check_upgradable's dependency check
When the package being upgraded has a dependency that was not present before
There is need to check for new dependencies
Change-Id: I948fc4c490fff9d0fc6d6f6cc73d91822c22a5a3
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Mon, 28 Oct 2019 06:45:19 +0000 (15:45 +0900)]
Refactor Checking Dependency routine
Change-Id: Id335b0475d510a3cce7b1c31d8526b9f19704ca3
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Junghyun Yeon [Thu, 31 Oct 2019 11:17:50 +0000 (20:17 +0900)]
Make up recovery file for sudden power loss
- Backup recovery file itself before replace it with new one
- pkg_recovery now determines which recovery file to use :
backed up one and original one.
If both backup and original exists, backup will be removed.
If only backup exists, it renames as original and will be used.
If only original exists, it will be used directly.
Change-Id: I8a11841b36111decbba6c9091f27a05f4debcb9a
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Junghyun Yeon [Tue, 5 Nov 2019 11:52:45 +0000 (20:52 +0900)]
Fix codes for efficiency
- Remove unnecessary privilege checking routine.
- Integrate if statements to remove redundant exit checking routine.
Change-Id: I575e46ae134f1799cd4546491e17f82121c91795
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Junghyun Yeon [Fri, 25 Oct 2019 06:08:31 +0000 (15:08 +0900)]
Implement clean operation for recovery
Installer operates based on files so it could not work properly
when any package file has deleted. Sometimes abnormal termination during
updating package will fail due to loss of backup files, so when installer
pass through some threshold, its recovery operation should be "cleanup",
not revert into previous package.
This implementation sets recovery type as cleanup before removing backup files
and when recovery has invoked due to sudden power loss, cleanup will be performed.
Change-Id: I129003c514abf9b553b9687719ba28549893acb1
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Junghyun Yeon [Tue, 5 Nov 2019 11:39:09 +0000 (20:39 +0900)]
Fix coding rule
Change-Id: I356aad208cf17ff5a44c181317ed4e7958a6685f
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Sangyoon Jang [Tue, 15 Oct 2019 07:03:13 +0000 (16:03 +0900)]
Fix installing privileges of hybrid package
Change-Id: I0b76b92943523a030f6df7e106b36338423737fc
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Junghyun Yeon [Wed, 16 Oct 2019 02:17:47 +0000 (11:17 +0900)]
Add condition when checking dotnet version
Preload-rw package could be dotnet package so
add condition to StepCheckTizenVersion to continue its installation
even if getting dotnet version through vconf has failed.
Change-Id: I6166f9c56eacd15e42f63ef42396303f3e1b4d61
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Ilho Kim [Wed, 2 Oct 2019 09:25:48 +0000 (18:25 +0900)]
Block Wrong use of backend when uninstall
Change-Id: Ib7b62993f3b800765f59a60fc88dbfd73f4fb682
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Fri, 27 Sep 2019 06:58:14 +0000 (15:58 +0900)]
Release version 1.30.13
Changes:
- Fix making xmlDocPtr for tag plugin
Change-Id: Id021fc074420e6821b952e3842b02ba6bfabb80d
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Fri, 27 Sep 2019 02:04:28 +0000 (11:04 +0900)]
Fix making xmlDocPtr for tag plugin
Check all depth's tags and make only necessary information to plugin
Change-Id: I644c045e1d4fef1300b75cb9dd2609db52b01c04
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Fri, 20 Sep 2019 01:38:39 +0000 (10:38 +0900)]
Release version 1.30.12
Changes:
- Refactor creating shared/data directory
- Check config file for disabling legacy shareddata dir support
- Fix mismatching of error code for signal
- Change the start location of package-recovery.service
- Fix RecoverSignature
- Fix coding rule
Change-Id: I5400b3391036d08a0f7e6eed1777d087ef7e101c
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Junghyun Yeon [Wed, 18 Sep 2019 07:15:44 +0000 (16:15 +0900)]
Fix coding rule
Change-Id: I2cdd0155cf93dc2aa7ee04d6ab9840fa14904e9c
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Junghyun Yeon [Thu, 5 Sep 2019 06:23:22 +0000 (15:23 +0900)]
Fix RecoverSignature
- Privilege level should be initialized to untrusted to
get privilege level from signature file if exists.
- Change root path of signature files for wgt packages.
Change-Id: Ie2e1055d6201753f742b54e7398506ad6aa01da3
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
INSUN PYO [Fri, 21 Jun 2019 02:26:38 +0000 (11:26 +0900)]
Change the start location of package-recovery.service
The default.target.wants is not used for this purpose.
So the localtion of package-recovery.service is multi-user.target.wants.
Change-Id: I3c518b04e04c54adc4094b33f0a1170a31968a02
Sangyoon Jang [Thu, 5 Sep 2019 07:52:14 +0000 (16:52 +0900)]
Fix mismatching of error code for signal
Change-Id: I57f3b7555f3f36fd4f9eb47f314cef6fd0480103
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Thu, 5 Sep 2019 07:42:34 +0000 (16:42 +0900)]
Check config file for disabling legacy shareddata dir support
Change-Id: I7072f6983cde10ae8ab226462834cc0272b81239
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Thu, 5 Sep 2019 07:26:17 +0000 (16:26 +0900)]
Refactor creating shared/data directory
Change-Id: I2b849df574fab2c17fb44c482abbd24b278f5f0a
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Ilho Kim [Thu, 5 Sep 2019 07:30:25 +0000 (16:30 +0900)]
Release version 1.30.11
Changes:
- Fix memory leak
- Remove checking cert mismatch from Signature class
- Add FileLogBackend class
- Log installation history
- Change log directory to /var/log/appfw/app-installers
- Fix Uninitialized scalar field
Change-Id: I211342a2838d4d1f3c341c7e82a91dff99513aa8
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Tue, 3 Sep 2019 01:35:58 +0000 (10:35 +0900)]
Fix Uninitialized scalar field
Change-Id: I0eb2a1e0d574b51336b52342e779a2ca453b3ad2
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Sangyoon Jang [Wed, 4 Sep 2019 05:30:14 +0000 (14:30 +0900)]
Change log directory to /var/log/appfw/app-installers
Change-Id: I5bf3246c12f78d0741b12350b9476901711a74a6
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Mon, 2 Sep 2019 10:59:54 +0000 (19:59 +0900)]
Log installation history
Change-Id: I760f67df0fe39f714be4370e95f94e7326f09fc2
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Mon, 2 Sep 2019 10:39:12 +0000 (19:39 +0900)]
Add FileLogBackend class
FileLogBackend is custom logbackend class.
Requires:
- https://review.tizen.org/gerrit/#/c/platform/core/appfw/manifest-parser/+/213188
Change-Id: I48ddcfa63cc0dce04cf81137e1c4a9e4323cb5b6
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Tue, 3 Sep 2019 05:27:53 +0000 (14:27 +0900)]
Remove checking cert mismatch from Signature class
This should be done at StepCheckOldCertificate step.
Change-Id: I9923c55f02f476cee57e90ed91e470bdf318231b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Fri, 30 Aug 2019 05:52:58 +0000 (14:52 +0900)]
Fix memory leak
Change-Id: Iab2eebe7a83897c5be850a7aecaf59327018c31a
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Ilho Kim [Thu, 29 Aug 2019 07:09:50 +0000 (16:09 +0900)]
Release version 1.30.10
Changes:
- Add GetRecoverFileInfo for recovery test
Change-Id: I754666b4d5d0ec1a8a00cbccca1d39e17d0a7256
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Thu, 22 Aug 2019 11:55:47 +0000 (20:55 +0900)]
Add GetRecoverFileInfo for recovery test
Related changes
- https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/212537/
Change-Id: Ia0e60e6285bd2f69f56edb4f77bd4bcfa457bac1
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Sangyoon Jang [Wed, 28 Aug 2019 04:08:51 +0000 (13:08 +0900)]
Release version 1.30.9
Changes:
- Remove requires dependency wait-mount service from package-recovery service
Change-Id: I4ea05ee054e4e73cb7388a5a2b20897cd87b6475
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Mon, 26 Aug 2019 04:50:25 +0000 (13:50 +0900)]
Remove requires dependency wait-mount service from package-recovery service
wait-mount service may not exist at some profile.
Change-Id: Ifb95f3eced133649efb61c1076848474499df416
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Ilho Kim [Thu, 22 Aug 2019 04:26:34 +0000 (13:26 +0900)]
Release version 1.30.8
Changes:
- Add new install option
- Fix manifest install/update
Change-Id: I7ae48377afb67c1129e8df0b68b5068acd3f7159
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Wed, 21 Aug 2019 10:20:12 +0000 (19:20 +0900)]
Fix manifest install/update
- In case of manifest install, remain storage directories
- In case of manifest update in user request mode,
do not needed update storage directory
Change-Id: Ib2a31be2d16bfd146f2e203b636bd283f46ec55a
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Tue, 20 Aug 2019 08:24:26 +0000 (17:24 +0900)]
Add new install option
This option will be used for fast installation without optimization
Related changes
[app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/212328/
[pkgmgr-tool] https://review.tizen.org/gerrit/#/c/platform/core/appfw/pkgmgr-tool/+/212326/
[slp-pkgmgr] https://review.tizen.org/gerrit/#/c/platform/core/appfw/slp-pkgmgr/+/212327/
Change-Id: I5907597dcc3136278b26a7c020f9ef27a27cb1fa
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Tue, 20 Aug 2019 01:36:45 +0000 (10:36 +0900)]
Release version 1.30.7
Changes:
- Parse 'addon' element
- Fix static analysis issue
Change-Id: I79bd27a0ee64f0505b58c329f03437d5b91f632b
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Fri, 9 Aug 2019 04:12:40 +0000 (13:12 +0900)]
Fix static analysis issue
Fix NULL Pointer dereference when memory allocation fails
Change-Id: If23103d7135852ba98cc52173982cdc5bca47ca0
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Junghoon Park [Fri, 19 Jul 2019 01:12:19 +0000 (10:12 +0900)]
Parse 'addon' element
- Requires :
https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-manifest-handlers/+/209520/
https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/209744/
Change-Id: Ia902f8d049c86cce36f418d1a98fa67500e8f618
Signed-off-by: Junghoon Park <jh9216.park@samsung.com>
Ilho Kim [Fri, 9 Aug 2019 08:15:02 +0000 (17:15 +0900)]
Release version 1.30.6
Changes:
- Add function to kill child process used smoke test
- Add dependency for mounting opt/usr
- Skip dependency ckecking when backend has executed as root
Change-Id: I849d670be4d579cc9d13b9057880a917adbcdf74
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Junghyun Yeon [Thu, 8 Aug 2019 08:59:36 +0000 (17:59 +0900)]
Skip dependency ckecking when backend has executed as root
Change-Id: I42a89ac1d5cc17d754c6580b9c650cad18473e01
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Junghoon Park [Wed, 7 Aug 2019 06:55:59 +0000 (15:55 +0900)]
Add dependency for mounting opt/usr
Change-Id: I2a8ea1cd6a4c099d57557044a3a52c3d4b27531b
Signed-off-by: Junghoon Park <jh9216.park@samsung.com>
Ilho Kim [Mon, 8 Jul 2019 07:40:19 +0000 (16:40 +0900)]
Add function to kill child process used smoke test
Change-Id: If096fde0ac13b80d2fef94212ae3c7a4de21b02d
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Junghyun Yeon [Mon, 22 Jul 2019 08:44:20 +0000 (17:44 +0900)]
Release version 1.30.5
Changes:
- Add initialize db function for smoke test
- Revert "Change database removal logic"
- Revert "Add initialize db function for smoke test"
Change-Id: Iea69f19a8302ee65f8d1bebdbae1d0763e000797
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
ilho kim [Mon, 22 Jul 2019 05:34:44 +0000 (05:34 +0000)]
Revert "Add initialize db function for smoke test"
This reverts commit
8d743975f0a0ab068638c37c4e665ca615e4a5da.
Change-Id: Ie447f9f630a323e19e62ae0eaba731e435554cc6
ilho kim [Mon, 22 Jul 2019 05:33:25 +0000 (05:33 +0000)]
Revert "Change database removal logic"
This reverts commit
66f0018a9d36e6f6638f7272d80245c9b5cb5858.
Change-Id: Ifa278212372491fa9f9f565cbf87b3ea2ff9258e
Ilho Kim [Wed, 17 Jul 2019 07:53:37 +0000 (16:53 +0900)]
Add initialize db function for smoke test
After below patch
https://review.tizen.org/gerrit/#/c/platform/core/appfw/pkgmgr-info/+/207513/
The smoke test requires the process of creatring db for testing.
This is because opening the db with the "SQLITE_OPEN_READWRITE" flag doesn't create a db.
Related changes
[tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/210255/
[wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/210254/
Change-Id: I16161eba7b8b649a7e912891def3b81c1dc6dff6
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Fri, 12 Jul 2019 06:34:14 +0000 (15:34 +0900)]
Release version 1.30.4
Changes:
- Combine StorageDirectories Steps
- Fix StepCheckInstallable
- Change log directory's file atrributes
- Refactor StepCreateStorageDirectories
- Fix creating storage directories
- Synchronize save, delete signature
- Fix coding style
- Change database removal logic
Change-Id: I45a6482aa433bdeedb6ad0f145545a513314dd2d
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Junghyun Yeon [Fri, 7 Jun 2019 04:15:10 +0000 (13:15 +0900)]
Change database removal logic
Journaling mode has changed to WAL so removing logic should be changed.
Related changes:
[pkgmgr-info] : https://review.tizen.org/gerrit/c/platform/core/appfw/pkgmgr-info/+/207513
Change-Id: If5515815c9a1a71f7d7cd83f8526431462d4aafc
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Sangyoon Jang [Wed, 10 Jul 2019 08:41:09 +0000 (17:41 +0900)]
Fix coding style
Add some missing #include statement.
Change-Id: I1c953c954878e8dfa96b88c34d9d244686159456
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Ilho Kim [Wed, 12 Jun 2019 07:18:13 +0000 (16:18 +0900)]
Synchronize save, delete signature
To prepare for sudden power loss,
write the signature infomation to the physical disk
and then synchronously delete the unpacked signature file using fsync()
Change-Id: I2a23f518cc7e71634ad93e00b594505223caee4c
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Sangyoon Jang [Thu, 27 Jun 2019 08:06:42 +0000 (17:06 +0900)]
Fix creating storage directories
Now creating storage directories is performed after security registration,
installer should label those storage directories explicitly.
Change-Id: I587dc84d3fd4d5df80da22a6d1cfba788afef755
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Thu, 27 Jun 2019 07:24:10 +0000 (16:24 +0900)]
Refactor StepCreateStorageDirectories
Remove duplicated code. Remove unused variables. Improve readability.
Change-Id: I495e03b7a192d725a8058313418863d735c013f7
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Ilho Kim [Tue, 25 Jun 2019 05:42:06 +0000 (14:42 +0900)]
Change log directory's file atrributes
Change-Id: I22ae9470d6275059a752cdea0c2dc682eea1fde1
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Sangyoon Jang [Fri, 21 Jun 2019 07:09:04 +0000 (16:09 +0900)]
Fix StepCheckInstallable
Check required version of dependent packages.
Change-Id: Ia804ac9a47f0466dac747194814c322fa8d87064
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Ilho Kim [Tue, 14 May 2019 01:48:01 +0000 (10:48 +0900)]
Combine StorageDirectories Steps
Combined step :
- StepCreateStorageDirectories and StepCreatePerUserStorageDirectories
- StepUpdateStorageDirectories and StepUpdatePerUserStorageDirectories
- StepRecoverStorageDirectories and StepRecoverPerUserStorageDirectories
Related changes
[app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/206075/
[tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/206194/
[wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/206193/
Change-Id: I7ebc32c5cb9b66a1dd007a064785d940e6de6f68
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Wed, 26 Jun 2019 01:50:07 +0000 (10:50 +0900)]
Release version 1.30.3
Changes:
- Remove unused variable
- Fix namespace of StepCreateRecoveryFile
- Fix StepParsePreload
- Fix error logging when adding/removing/replacing step
- Add PkgQueryInterface::Version() for getting version of package
- Change log directory
- Improve StepCopyBackup
- Move the plugin info(prefer_dotnet_aot) of dotnet
Change-Id: Idc94a60427026ed2a5e6c6fbf086628b560e8300
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
j-h.choi [Thu, 30 May 2019 05:26:40 +0000 (14:26 +0900)]
Move the plugin info(prefer_dotnet_aot) of dotnet
Dependency : https://github.sec.samsung.net/dotnet/dotnet-launcher/pull/58
Change-Id: I8e1b5c937d8202f580b817b9f4bcb01cdb29cd52
Junghyun Yeon [Mon, 17 Jun 2019 07:28:16 +0000 (16:28 +0900)]
Improve StepCopyBackup
Replace copy operation to move improves performance.
Change-Id: I623059a21e311420942ab860b3b151c95d371562
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Junghyun Yeon [Mon, 17 Jun 2019 12:18:27 +0000 (21:18 +0900)]
Change log directory
Log collecting module doesn't have enough permission to copy
file owned by root
Change-Id: Ibd5dc0ecdc7ff290954e1ffb77d761228406b12d
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Sangyoon Jang [Fri, 21 Jun 2019 07:24:43 +0000 (16:24 +0900)]
Add PkgQueryInterface::Version() for getting version of package
Change-Id: Ic0e9e03862bd0a6d41d0b12c0642e81f8868fd3f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Tue, 11 Jun 2019 08:41:27 +0000 (17:41 +0900)]
Fix error logging when adding/removing/replacing step
HandleStepError is for sending signal when the step returns fail.
Change-Id: I4ba079aee5a399e11079950954c30e42583f3371
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Tue, 18 Jun 2019 07:04:50 +0000 (16:04 +0900)]
Fix StepParsePreload
Allow handle readonly package when ReadonlyUpdateUninstall mode.
ReadonlyUpdateUninstall mode makes the package as readonly package back.
Change-Id: I0a0fc007e73b3497b125833c7904192c3024aec3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Wed, 29 May 2019 10:05:16 +0000 (19:05 +0900)]
Fix namespace of StepCreateRecoveryFile
This step should be included at "recovery" namespace.
Change-Id: Id12a75327641b3d75bdb35b5d132d3e9c436b54f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Junghyun Yeon [Mon, 3 Jun 2019 12:45:28 +0000 (21:45 +0900)]
Remove unused variable
Change-Id: Id75cf5859fa788bfa312e6fb13174ade6066c6a3
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Ilho Kim [Fri, 31 May 2019 07:09:36 +0000 (16:09 +0900)]
Release version 1.30.2
Changes:
- Combine Signature Steps
- Set external image path at pkgmgr registration
- Parse api-version of application if exist
- Add PackageAttributes structure at smoke utils
- Fix plugin_xml_parser
- Delete unused header files
- Refactor PluginsXmlParser::NextChildElement()
- Fix checking return code app2sd API
- Fix coding style
- Fix app2ext_dynamic_service
- Fix plugin manager
- Standardize use of STEP_NAME()
- Fix memory leak in using "g_object_get()"
- Combine Plugin Steps
- Fix static anylysis issue
- Allow copy constructor and assign operator of PkgQueryInterface
- Remove gumd security user
Change-Id: I5d5d4699f244f5c53431a097f4f92be5f771f711
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
INSUN PYO [Wed, 29 May 2019 09:58:56 +0000 (18:58 +0900)]
Remove gumd security user
Container feature is removed, so we don't need to handle gumd security user.
Security user is only used by container.
Change-Id: Ie76630476235056033e8062747611f27dfa2f0e2
Sangyoon Jang [Thu, 30 May 2019 02:56:17 +0000 (11:56 +0900)]
Allow copy constructor and assign operator of PkgQueryInterface
PkgQueryInterface was changed to using shared ptr of PkgHandle object
which has actual query data.
Change-Id: Iffec5a63de2236cc62cbcc8a6bba743962ad9583
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Junghyun Yeon [Tue, 28 May 2019 04:41:57 +0000 (13:41 +0900)]
Fix static anylysis issue
Change-Id: I0394b2007b64291e87e560ef5affdcda3cb3b3ca
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Ilho Kim [Thu, 25 Apr 2019 08:21:34 +0000 (17:21 +0900)]
Combine Plugin Steps
StepRunParserPlugin combines below steps
- StepRegisterPluginInfo
- StepUpdatePluginInfo
- StepUnregisterPluginInfo
Related changes
[app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/204652/
[tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/204757/
[wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/205385/
Change-Id: If090bb5855145077599c877d80335df1636d8e34
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Tue, 14 May 2019 12:17:52 +0000 (21:17 +0900)]
Fix memory leak in using "g_object_get()"
Change-Id: I0e8263fee35852376992f856449d54691c74d133
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Thu, 16 May 2019 02:55:56 +0000 (11:55 +0900)]
Standardize use of STEP_NAME()
In case class name is StepExampleClass, Pass "ExampleClass" to STEP_NAME()
Change-Id: I9aba996dc34109f391dc08f2f998b62417d956b2
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Sangyoon Jang [Tue, 30 Apr 2019 01:54:25 +0000 (10:54 +0900)]
Fix plugin manager
Fix crash when manifest is not provided.
Change-Id: I1f1c50856f3553c2a2f6d218a8af2ec2dbfd5b95
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Ilho Kim [Thu, 9 May 2019 01:54:49 +0000 (10:54 +0900)]
Fix app2ext_dynamic_service
Disable external pkg function was misused
Change-Id: I8a468ce9eb78f7b16890b5b7506e05a82d710505
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Junghyun Yeon [Tue, 7 May 2019 08:03:05 +0000 (17:03 +0900)]
Fix coding style
Change to use pointer when pass error_message as parameter.
Change-Id: I46d1b1704ca870a281136345a37a2a2eac1c2bd8
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
Sangyoon Jang [Wed, 8 May 2019 04:38:12 +0000 (13:38 +0900)]
Fix checking return code app2sd API
It may return positive return value in case of error.
Change-Id: Ic40cd8241d3fb1dd4deba3f67ac94343b16065c8
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Wed, 8 May 2019 06:03:54 +0000 (15:03 +0900)]
Refactor PluginsXmlParser::NextChildElement()
Call xmlTextReaderRead() until reaching child element.
Change-Id: I523187efb4402b81e703b6ff065ef50165b486e2
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Ilho Kim [Thu, 9 May 2019 01:51:30 +0000 (10:51 +0900)]
Delete unused header files
Change-Id: Ifca102788294950da05e397b2f89f766c9676772
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Wed, 8 May 2019 04:32:11 +0000 (13:32 +0900)]
Fix plugin_xml_parser
If xml file have comment line at root tag's depth, parsing is stopped
Change-Id: I04be43a4fdbeeda77937fb1d2996178561fea31b
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Sangyoon Jang [Tue, 16 Apr 2019 07:53:07 +0000 (16:53 +0900)]
Add PackageAttributes structure at smoke utils
This structure can be used comparing package attributes such as
system, readonly, update, etc.
Some test cases of smoke-tests such as ReadonlyUpdateUninstall can
do additional validation using this structure.
Change-Id: I62579fb27e51d23cb8667fa4b8b85478af91af47
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
Sangyoon Jang [Mon, 18 Feb 2019 05:49:52 +0000 (14:49 +0900)]
Parse api-version of application if exist
Change-Id: I52dfe3477cd951b9f2b098486f3fbaa7dcd601f3
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
ilho kim [Fri, 3 May 2019 07:30:58 +0000 (07:30 +0000)]
Merge "Combine Signature Steps" into tizen
Sangyoon Jang [Fri, 26 Apr 2019 08:45:04 +0000 (17:45 +0900)]
Set external image path at pkgmgr registration
security-manager needs package information when getting privilege type,
but when installing package at external storage, the external image path is
set at clean() phase. So security-manager cannot get package information.
Change-Id: I8a2810da4cc417c0bc656f25e4a0d679c791833d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
ilho [Thu, 4 Apr 2019 04:28:04 +0000 (13:28 +0900)]
Combine Signature Steps
StepCheckSignature and StepSaveSignature are combined
Related changes
[app-installers] https://review.tizen.org/gerrit/#/c/platform/core/appfw/app-installers/+/203140/
[tpk-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-backend/+/203141/
[wgt-backend] https://review.tizen.org/gerrit/#/c/platform/core/appfw/wgt-backend/+/203513/
Change-Id: I71de6ef5e9cdffc88f9f4f25f130e1f1c6b84714
Signed-off-by: ilho <ilho159.kim@samsung.com>
Ilho Kim [Thu, 2 May 2019 07:06:19 +0000 (16:06 +0900)]
Release version 1.30.1
Changes:
- Fix removed plugin feature
- Delete unused plugin from plugins_list
- Delete downloadable_font plugin from plugin_list
Change-Id: Id60fd9fdddb96e8394ffe861382d96b3112b7c56
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Thu, 2 May 2019 07:01:56 +0000 (16:01 +0900)]
Delete downloadable_font plugin from plugin_list
Change-Id: I6978bfbdd6bc92d064dde9d4e909ee51686b9e90
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
Ilho Kim [Wed, 1 May 2019 23:36:59 +0000 (08:36 +0900)]
Delete unused plugin from plugins_list
Change-Id: I8d8a7201aea3b64b1757cbb28976623c7a90a787
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>