Michal Michalski [Wed, 31 Jul 2019 11:00:36 +0000 (13:00 +0200)]
[tests][mediacontroller] tests for new sendCommand implementation.
This testcases define expected behavior of sendCommand() method
after implementation is changed.
[Verification] Tests are passing with working version of new implementation.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5923e45bb0ddc2013b1fe81951a3966413a3e4b6
Michal Michalski [Mon, 22 Jul 2019 10:59:36 +0000 (12:59 +0200)]
[tizen][utils][mediacontroller] Rewrite js tests using mochajs.
JS tests for the implementation of search API.
Tests for mediacontroller search api and tizen.Bundle have
been rewritten using mochajs library.
[Verification] Tests pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I22d5b5bd518b709f8d4aa94149906439390b4e28
[version] 2.48
Change-Id: I7a5c9eb27b5c115f9c5c1b29c9720a9883b26408
[Alarm] Fixed the behaviour change introduced during SVACE issues fixing
[Bug] Issue was introduced in commit
1b4d5c8e8e760140c3e5c93e59ff23bde99f9862
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/207226/
Alarm TCT - 12 fails
[Verification] Alarm TCT after fix - 100% (tizen-unified_20190804.1_mobile-wayland-armv7l-tm1)
Change-Id: I343bf2d20d2f88f6d3ac37eb2631a0db395daecb
Piotr Kosko [Thu, 1 Aug 2019 10:03:07 +0000 (10:03 +0000)]
Merge "[tests][common][webapi-plugins.spec] Changed common unit tests files structure." into tizen
Michal Michalski [Tue, 30 Jul 2019 09:30:12 +0000 (11:30 +0200)]
[tests][common][webapi-plugins.spec] Changed common unit tests files structure.
New structure allows better modularization of unit tests.
[Verification] webapi_common_tests are built successfully and pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Icad5cca7739716bde7c09092f4d1d73fca1972a0
Michal Michalski [Wed, 31 Jul 2019 10:56:48 +0000 (12:56 +0200)]
[utils][tests] Add mochajs and chaijs libraries sources.
They can be used to write tests for js code.
It is required to add them to the debugging application.
After you have application with this libraries, you can
than run tests from chrome snippets in remote debugger.
[Verification] I have tested this setup in my test application
and it seems to be working.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ide535ee8ce29b4a735351f2fb9cbde36cc7c935e
Piotr Kosko [Wed, 31 Jul 2019 12:19:36 +0000 (12:19 +0000)]
Merge "Merge branch 'tizen_5.0' into tizen" into tizen
Michal Michalski [Tue, 30 Jul 2019 14:54:12 +0000 (16:54 +0200)]
[common] Fix JsonToBundle implementation.
Broken implemenation has slipped through unspotted.
While testing previous change in JsonToBundle the API
installed on device probably has not been updated.
[Verification] UTs were failing and now they are passing.
Change-Id: I6c871ff03a79417a630da1db50f2f7300fca9ca8
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Tue, 30 Jul 2019 10:08:57 +0000 (12:08 +0200)]
[tizen] Add copy ctor to tizen.Bundle.
This will simplify the implementation of API methods which
need to accept both plain json object and tizen.Bundle.
In example: function sendCommand(..., data) { var d = new tizen.Bundle(data); }
instead of manually having to check if data is a tizen.Bundle or object.
[Verification] Added new test case for this constructor, all existing tests passes.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I4c880dbf8889c88bb20a4029b5cbb8fa2941eb1d
Michal Michalski [Tue, 23 Jul 2019 15:00:26 +0000 (17:00 +0200)]
[mediacontroller][common] Support for null values in Json-Bundle conversions.
JsonToBundle and BundleToJson functions didn't support null values. Manually
handling them every time was cumbersome, hence this commit adds support for null values.
[Verification] + bundle c++ unittests 100% pass
+ bundle js tests 100% pass
+ tct-mediacontroller-tizen-tests
20190722 tct package 100% pass.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I1315899d8ebb66935ea9b10791b5dba82341af45
Arkadiusz Pietraszek [Mon, 29 Jul 2019 08:30:43 +0000 (10:30 +0200)]
Merge branch 'tizen_5.0' into tizen
Change-Id: I5d9b8f0a57450b051a5c56bfb1b4c704ac0121a5
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Michal Michalski [Wed, 24 Jul 2019 08:38:45 +0000 (10:38 +0200)]
[tizen][mediacontroller] Change toJSON implementation to simplify serialization.
Before this commit, in order to send Bundle object to the C++ layer
it was necessary to call Bundle.toString() method, and than picojson::parse()
in C++ to deserialize it. This commit removes the need for both this steps.
They will be done implicitly by the framework.
[Verification] bundle js tests 100% pass rate.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I89b11bc634b56b720dd8a5ecea8537ef1ce51b24
Arkadiusz Pietraszek [Mon, 22 Jul 2019 12:48:41 +0000 (14:48 +0200)]
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: Id7abc98f999b2bfb8dc0b49692f688f1b4c9ee9f
Piotr Kosko [Mon, 22 Jul 2019 12:30:17 +0000 (12:30 +0000)]
Merge "[Application] Fixed path of getAppSharedURI" into tizen
Piotr Kosko [Mon, 22 Jul 2019 12:30:05 +0000 (12:30 +0000)]
Merge "[Application] Fixed path of getAppSharedURI" into tizen_5.0
Piotr Kosko [Mon, 22 Jul 2019 12:27:39 +0000 (12:27 +0000)]
Merge "[Project][code_formatter] Fix JS files formatting error" into tizen
[Application] Fixed path of getAppSharedURI
Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy
New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner users 4096 Jul 18 13:06 .
drwxr-xr-x 5 owner users 4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw 58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner users 4096 Jul 18 13:06 trusted
Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res
[Verification] Checked manually in chrome console
TCT Application 100% passrate
Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09
[Application] Fixed path of getAppSharedURI
Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy
New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner users 4096 Jul 18 13:06 .
drwxr-xr-x 5 owner users 4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw 58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner users 4096 Jul 18 13:06 trusted
Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res
[Verification] Checked manually in chrome console
TCT Application 100% passrate
Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09
[Application] Fixed path of getAppSharedURI
Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy
New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner users 4096 Jul 18 13:06 .
drwxr-xr-x 5 owner users 4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw 58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner users 4096 Jul 18 13:06 trusted
Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res
[Verification] Checked manually in chrome console
TCT Application 100% passrate
Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09
Piotr Kosko [Mon, 22 Jul 2019 11:35:30 +0000 (11:35 +0000)]
Merge "[Project][Coverity] Some static analysis problems were corrected." into tizen
Rafal Walczyna [Mon, 22 Jul 2019 10:55:38 +0000 (12:55 +0200)]
[Project][code_formatter] Fix JS files formatting error
Due to a bug, js files were not formatting.
Tested manually - js formatting works.
Change-Id: I5a4e2f2dc05241e15c85815f8380563303fa7ed1
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Arkadiusz Pietraszek [Thu, 30 May 2019 13:31:03 +0000 (15:31 +0200)]
[Project][Coverity] Some static analysis problems were corrected.
Those Coverity issues were fixed:
CHECKED_RETURN 835501 - Messageport
CHECKED_RETURN 835504 - Download
CHECKED_RETURN 835505 - Messaging Email
CHECKED_RETURN 835506 - Download
CHECKED_RETURN 1064913 - Common
CHECKED_RETURN 1064914 - Common
CHECKED_RETURN 1064915 - Alarm
CHECKED_RETURN 1074834 - Application
CHECKED_RETURN 1074835 - Application
In Alarm module there is fix of Exception message.
There is also correction of logs in Archive module to bring consistency.
Some files was changed only by cude_format script.
[Verification] Coverity was run, and fixed issues are not on a list anymore.
http://10.113.170.22:8810/download/16062/artifacts/analysis_report_I6ddb03_coverity-2017.07.html
TCT pass rate of changed modules is 100%.
Change-Id: I6ddb030c071166d688a902849c9f979cfbae62d6
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Dawid Juszczak [Fri, 19 Jul 2019 09:58:40 +0000 (11:58 +0200)]
[5.5][package] Change deprecated enum to new ones
changed every occurrence of enum values to new ones
native ACR with related changes:
http://suprem.sec.samsung.net/jira/browse/ACR-1419
[Verification]
tct-application-tizen-tests 100% PASS
tct-package-tizen-tests 100% PASS
Change-Id: I2d4898411efeb18a8526f497d4b837b8d2bb2387
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Arkadiusz Pietraszek [Fri, 12 Jul 2019 11:47:35 +0000 (13:47 +0200)]
Merge remote-tracking branch 'origin/tizen_3.0' into tizen_4.0
[Verification] TCT passrate 100%.
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Change-Id: Id004158e62f5d0b6f2c09eeee5cf300d461a9d9f
Ernest Borowski [Wed, 3 Jul 2019 12:30:15 +0000 (14:30 +0200)]
[Project][code_formatter] Fix multiple errors in shell scripts:
- Use null character as path delimiter in git and find commands.
It allows file path to contain newlines and other white space characters.
- Add quotes when needed to prevent globbing and word splitting.
- Simplify logic.
Change-Id: I58de7a3bd1e2e3165ada8b7650b2863e1fc95c15
Signed-off-by: Ernest Borowski <e.borowski@partner.samsung.com>
[version] 2.47
Change-Id: I37a5ea2a5100290b0bed1e7c19baef26e384ea54
Dawid Juszczak [Fri, 12 Jul 2019 13:45:22 +0000 (15:45 +0200)]
[mediacontroller][bundle] fixing custom command
Refactored some functions to use tizen.Bundle
and formated code with format script
Changed implementation of functions:
+ MediaControllerInstance::MediaControllerServerReplyCommand
+ MediaControllerInstance::MediaControllerServerInfoSendCommand
+ MediaControllerServer::OnCommandReceived
+ MediaControllerServer::CommandReply
+ MediaControllerClient::OnCommandReply
+ MediaControllerClient::SendCommand
[Verified]
tct-mediacontroller-tizen-tests - 100% passed
also tested manually on chrome console
Change-Id: I9d072d10a5fc272c54d17731f33ae9b733009412
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Michal Michalski [Mon, 15 Jul 2019 10:02:03 +0000 (12:02 +0200)]
[tizen] Update bundle js tests after fix.
+ Added tests for regular arrays and Uint8Arrays.
+ Updated toJSON test after method modification.
+ Added tests for toString method.
[Verification] Tests pass for fixed bundle.
Change-Id: Idd9298b311fee56c4387c5f9c9fbd2b4984944b0
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Mon, 15 Jul 2019 10:01:08 +0000 (12:01 +0200)]
[tizen] Fix issue with regular arrays in Bundle.
Bundle now stored byte streams as Uint8Arrays and converts regular arrays with
octet values to Uint8Arrays in Bundle::set() method.
toString() method now prints Uint8Arrays in the same way as regular arrays
using "[1,2,3]" format, instead of the "{0: 0, 1: 1, 2: 2}" format which is the
default behavior of toString() method on typed arrays.
[Verification] Modified tests passed.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I9eeca40d9760413c81888f4980146c8025d227d2
Piotr Kosko [Thu, 11 Jul 2019 10:56:15 +0000 (10:56 +0000)]
Merge "[tizen] Bundle constructor fix." into tizen
Michal Michalski [Thu, 11 Jul 2019 10:13:53 +0000 (12:13 +0200)]
[tizen] Bundle constructor fix.
xwalk.utils.validator replaced with xwalk.utils.type.
[Verification] All tests passed.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I2a7a8d4c1c2fb81ab8750a122596378d3af975f3
[version] 2.46
Change-Id: I5347699a9a3eab4210560a5e96ac212886954a53
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
[UT][SPEC] Fixed passing tizen_ut_build defined value
[Bug] Build fails when building different profile than mobile
[Verification] Build successfully for unified build and each profile
Change-Id: I37b2f9e8517e7cd9db7956812c39bb57bdff5a42
Michal Michalski [Thu, 4 Jul 2019 14:16:05 +0000 (16:16 +0200)]
[common][tizen][utils] Common Bundle implementation.
http://suprem.sec.samsung.net/jira/browse/TWDAPI-225
Unified the way native bundle objects are used
by WebAPI plugins.
[Verification] unittests pass rate 100%.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I501880daee29f878e4af9fb9b20e386905fbdc0c
Arkadiusz Pietraszek [Mon, 8 Jul 2019 08:20:14 +0000 (10:20 +0200)]
[Project][Filesystem] Fix needed after code formating of tizen_3.0 branch
Prietter code formatter treated obiect properties named 'null' and 'undefined' as keywords that should not be in apostrophes and removed those apostrophes.
This change has been reverted and //prettier-ignore tags has been added.
Change-Id: I78d502b9f674397f01c959031ad37fa139dd0b16
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Michal Michalski [Fri, 28 Jun 2019 11:23:21 +0000 (13:23 +0200)]
[utils][webapi-plugins.spec][common][tizen-wrt.gyp][tizen] Common bundle tests.
http://suprem.sec.samsung.net/jira/browse/TWDAPI-225
Tests for common Bundle implementation.
[Verification] Pass rate 100%.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ib8ae4415b45f018efc3406c071115782920798f9
[version] 2.45
Change-Id: I6272b2f933c4bd97e2c7963938a6356afb1cc1f3
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.
Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Piotr Kosko [Wed, 3 Jul 2019 09:00:58 +0000 (09:00 +0000)]
Merge "[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener." into tizen_3.0
Rafal Walczyna [Fri, 28 Jun 2019 06:37:13 +0000 (08:37 +0200)]
[MediaController] Fix for custom command without data
If custom command was sent without additional data then
command was not parsed at all.
[Verification] Tested manually
Change-Id: Id35a5852a7fa61aff48fc181926e77ee01f65ff8
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.
[verification] TCT 100% passrate
Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Michal Michalski [Fri, 10 May 2019 10:09:45 +0000 (12:09 +0200)]
[mediacontroller] Declare MediaControllerContentType enum.
Extracted into separate commit from adding ContentType WebAPI
because it is needed by Search API implementation as well.
[Verification] Code compiles. Both ContentType API implementation and Search API
implementation compile as well with this commit as a parent.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I1f140bb8dd608887b90a1d7b5a202c493e5fd3e4
Michal Michalski [Tue, 7 May 2019 08:59:32 +0000 (10:59 +0200)]
[mediacontroller][common] Use PlatformEnum in MediaController.
Refactor enums in MediaController module using PlatformEnum
template class.
[Verification] Code compiles + MC TCT passed.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ie861d1c0aca7651a2f9ce45b966773082abf6045
Michal Michalski [Tue, 7 May 2019 08:36:56 +0000 (10:36 +0200)]
[common] Define PlatformEnum class template.
Will replace current way enums are defined in webapi-plugins.
[Verification] Code compiles.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Id8c53df46ae9039e81d699884494b72c20d5cba8
Michal Michalski [Tue, 16 Apr 2019 10:26:16 +0000 (12:26 +0200)]
[mediacontroller] Fix error handling in ReplyCommand.
MediaControllerServerReplyCommand function did not
handle errors returned by MediaControllerServer::CommandReply()
call. This commit handles those errors.
[Verification]
Code compiles.
Change-Id: Ibc5acacc32ff23a6d8fa7cac096ade0e40e2b697
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Wed, 20 Mar 2019 17:19:15 +0000 (18:19 +0100)]
[mediacontroller] Use request_id for listener matching in SendCommand.
SendCommand method was using watchId to identify CommandReply callback which
should be called. It was passed in bundle object to mc_client_send_custom_cmd
function. Now instead of passing watchId we use already available request_id
to perform the same matching for command reply listeners.
[Verification]
Manual test.
tct-mediacontroller-tizen-tests - pass 100%
Change-Id: I57e90dbe36d7726f2e2f66866b11910d5d1d5d0d
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Lukasz Bardeli [Tue, 12 Mar 2019 12:43:18 +0000 (13:43 +0100)]
[MediaController] Change InvalidState to UnknownError.
[Verification] Code compiles without error.
Change-Id: Ibda8a419257caf071c7ed8e08e5b496b5c0efe2e
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Piotr Kosko [Fri, 28 Jun 2019 10:30:57 +0000 (10:30 +0000)]
Merge "[MediaController] Fix for custom command without data" into tizen
Rafal Walczyna [Fri, 28 Jun 2019 06:37:13 +0000 (08:37 +0200)]
[MediaController] Fix for custom command without data
If custom command was sent without additional data then
command was not parsed at all.
[Verification] Tested manually
Change-Id: Id35a5852a7fa61aff48fc181926e77ee01f65ff8
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.
[verification] TCT 100% passrate
Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.
Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
[version] 2.34
Change-Id: Idd416b0d826a58f7bbc72edb07d4570aa3319212
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
Michal Michalski [Wed, 19 Jun 2019 06:18:38 +0000 (08:18 +0200)]
[common] Handle nullptr output args in platform_enum.
Methods in platform_enum were not handling a nullptr output argument
case. This could lead to dereferencing of nullptr and to a crash.
Now they will return InvalidValuesError.
[Verification] No verification.
Change-Id: I756cf1495369143eaca78d249fd83229383907fc
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Piotr Kosko [Thu, 13 Jun 2019 09:05:01 +0000 (09:05 +0000)]
Merge "[mediacontroller] Get/set server icon API." into tizen
Michal Michalski [Thu, 25 Apr 2019 14:16:37 +0000 (16:16 +0200)]
[mediacontroller] Get/set server icon API.
http://suprem.sec.samsung.net/jira/browse/TWDAPI-221
+ readonly attribute MediaControllerServerInfo::iconURI
+ attribute MediaControllerServer::iconURI
+ MediaControllerServer::updateIconURI()
[Verification] Manual testing.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: If587a5958c74c224699345ef0ab7ff2575dd12ec
[version] 2.44
Change-Id: I413db071eb1dcbe8256d2368e8628b3345e9cf00
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Lukasz Bardeli [Thu, 6 Jun 2019 08:31:07 +0000 (08:31 +0000)]
Merge "[googletest][googlemock] Add googletest sources to the project." into tizen
Michal Michalski [Tue, 21 May 2019 08:52:35 +0000 (10:52 +0200)]
[googletest][googlemock] Add googletest sources to the project.
Binaries available at tizen repository were causing SEGFAULTS
when tests were executed so we decided to build it from more
recent sources. Added googletest license to the rpm package
containing unit tests.
[Verification] SEGFAULT does not occur when sample tests were
executed.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I9d028ca14dfcfa1d134afc7da733a7b4853c95f1
Piotr Kosko [Tue, 28 May 2019 05:19:13 +0000 (05:19 +0000)]
Merge "[SystemInfo] Add SERVICE_COUNTRY property" into tizen
Piotr Kosko [Mon, 27 May 2019 07:45:26 +0000 (07:45 +0000)]
Merge changes Idb5bec64,I1f140bb8 into tizen
* changes:
[mediacontroller] Get/set playback content type.
[mediacontroller] Declare MediaControllerContentType enum.
Piotr Kosko [Wed, 22 May 2019 12:06:07 +0000 (12:06 +0000)]
Merge "[Utils][fix] Privileges check" into tizen
Piotr Kosko [Wed, 22 May 2019 11:59:27 +0000 (11:59 +0000)]
Merge "[common] Native bundle to json converter." into tizen
Pawel Wasowski [Thu, 9 May 2019 11:31:49 +0000 (13:31 +0200)]
[messaging] Fix synchronization issues
Due to the delay between updating email with native C API functions and
updates of the corresponding message/thread records in the mail
database, race conditions occured in the previous implementation,
resulting in inconsitencies between thread_ids in the DB and those of
messages in JS layer. Active waits have been added to mitigate this
problems.
[Verification] tct-tizen-messaging-email pass rate: 100%
Change-Id: Ie0771ffc40e6cdee696756a8e831ae56bbe8f84d
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
(cherry picked from commit
1440977fb5202077c98d86da90ee2046bc213132)
Michal Michalski [Tue, 21 May 2019 13:26:11 +0000 (15:26 +0200)]
[common] Native bundle to json converter.
Function which converts native bundle object into json.
[Verification] Code compiles without error.
Change-Id: I932971d40309017c7ba7be9d677a41147ac5b3c2
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Dawid Juszczak [Mon, 13 May 2019 15:07:34 +0000 (17:07 +0200)]
[Utils][fix] Privileges check
http://suprem.sec.samsung.net/jira/browse/XWALK-1909
Added new function to check if value passed to function
checkPrivilegeAccess is privilege
Also changed value of CONTENT_READ to proper
[verification]
tested on chrome console
Change-Id: I9213055621b4627d56f49c4b12227512c9d0c9d0
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Lukasz Bardeli [Tue, 21 May 2019 06:49:42 +0000 (08:49 +0200)]
[Alarm][DataControl] Change console.log to xwalk.utils.log
[Verification] Code compiles properly.
Change-Id: Icfafa4c2b88d382a050f3b3f8ad9aa8884f5ebdb
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Fri, 17 May 2019 11:34:35 +0000 (13:34 +0200)]
[SystemInfo] Add SERVICE_COUNTRY property
ACR: http://suprem.sec.samsung.net/jira/browse/TWDAPI-223
[Verification] Code compiles without error. Tested in chrome console.
Change-Id: I449c57fdf6ba1ef884f766a397e950a1c0fdb4cd
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Michal Michalski [Thu, 18 Apr 2019 11:43:29 +0000 (13:43 +0200)]
[mediacontroller] Get/set playback content type.
http://suprem.sec.samsung.net/jira/browse/TWDAPI-219
+ enum MediaControllerContentType
+ MediaControllerPlaybackInfo::contentType
+ MediaControllerServer::updateContentType()
[Verification] Manual tests in js console.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Idb5bec64fac631fa92825920a745abfe02861edf
Michal Michalski [Fri, 10 May 2019 10:09:45 +0000 (12:09 +0200)]
[mediacontroller] Declare MediaControllerContentType enum.
Extracted into separate commit from adding ContentType WebAPI
because it is needed by Search API implementation as well.
[Verification] Code compiles. Both ContentType API implementation and Search API
implementation compile as well with this commit as a parent.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I1f140bb8dd608887b90a1d7b5a202c493e5fd3e4
Pawel Wasowski [Thu, 9 May 2019 11:31:49 +0000 (13:31 +0200)]
[messaging] Fix synchronization issues
Due to the delay between updating email with native C API functions and
updates of the corresponding message/thread records in the mail
database, race conditions occured in the previous implementation,
resulting in inconsitencies between thread_ids in the DB and those of
messages in JS layer. Active waits have been added to mitigate this
problems.
[Verification] tct-tizen-messaging-email pass rate: 100%
Change-Id: Ie0771ffc40e6cdee696756a8e831ae56bbe8f84d
Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Rafal Walczyna [Fri, 10 May 2019 08:07:12 +0000 (10:07 +0200)]
[filesystem] Fix svace issue
strerror caused PROC_USE.VULNERABLE SVACE error
Change-Id: I1020097d2f0cace1e585c0bb04f0b9336aad1372
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Michal Michalski [Thu, 9 May 2019 15:04:05 +0000 (17:04 +0200)]
[mediacontroller] Fix sendCommand callbacks.
sendCommand callbacks were not triggered due to problem
with requestId. This commit fixes this bug.
[Verification] MC TCT 100% pass.
Change-Id: Ibb4fbe146dcb8c20d623ac27924377d4097bb67d
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Michal Michalski [Tue, 7 May 2019 08:59:32 +0000 (10:59 +0200)]
[mediacontroller][common] Use PlatformEnum in MediaController.
Refactor enums in MediaController module using PlatformEnum
template class.
[Verification] Code compiles + MC TCT passed.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ie861d1c0aca7651a2f9ce45b966773082abf6045
Michal Michalski [Tue, 7 May 2019 08:36:56 +0000 (10:36 +0200)]
[common] Define PlatformEnum class template.
Will replace current way enums are defined in webapi-plugins.
[Verification] Code compiles.
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Id8c53df46ae9039e81d699884494b72c20d5cba8
[version] 2.33
Change-Id: I2a04c187950845b460b398c9b16ad963c4c2330f
Arkadiusz Pietraszek [Wed, 3 Apr 2019 11:09:04 +0000 (13:09 +0200)]
[Project] JS code formatting
All project *.js files were formatted with eslint tool, to eliminate CodingRule_Auto negative marks.
Additionally Prettier tool was used for unified line breaking rules.
In few cases, the tool did not break line for very long object definitions e.g.
HumanActivityRecorderPressureData.prototype.constructor = HumanActivityRecorderPressureData;
in such cases, line was broken manually and flag // prettier-ignore was added to ignore next node.
Change-Id: I537435c652abad22364421fc4c5ebddd411defbf
Merge branch 'tizen_5.0' into tizen
Change-Id: I80139d08dab29ce640b5fe830bbf22d00d8b773f
Merge branch 'tizen_4.0' into tizen_5.0
Change-Id: Ie11b3d545d450613ecf61ccee824744108218c73
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I0d282d007e89b4c761fa74d9b0737ca35c29ec57
Michal Michalski [Tue, 16 Apr 2019 10:26:16 +0000 (12:26 +0200)]
[mediacontroller] Fix error handling in ReplyCommand.
MediaControllerServerReplyCommand function did not
handle errors returned by MediaControllerServer::CommandReply()
call. This commit handles those errors.
[Verification]
Code compiles.
Change-Id: Ibc5acacc32ff23a6d8fa7cac096ade0e40e2b697
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Piotr Kosko [Thu, 25 Apr 2019 08:36:22 +0000 (08:36 +0000)]
Merge "[fix][Content] readonly atributes since 5.5" into tizen
Piotr Kosko [Thu, 25 Apr 2019 08:33:37 +0000 (08:33 +0000)]
Merge "[MediaController] getItems and getAllPlaylists implemented." into tizen
Piotr Kosko [Thu, 25 Apr 2019 08:33:30 +0000 (08:33 +0000)]
Merge "[MediaController] Add listener playlist updated." into tizen
Piotr Kosko [Thu, 25 Apr 2019 08:33:23 +0000 (08:33 +0000)]
Merge "[MediaController] Adding, updating and sending item." into tizen
Piotr Kosko [Thu, 25 Apr 2019 08:33:17 +0000 (08:33 +0000)]
Merge "[Mediacontroller] Add playlist methods" into tizen
Michal Michalski [Wed, 24 Apr 2019 08:08:05 +0000 (10:08 +0200)]
[filesystem] Fix invalid errno usage.
http://suprem.sec.samsung.net/jira/browse/TFDF-1624
Fix for failing cordova filesystem tests.
Issue occured because errno value was not tested
right away after readdir() system function call
and other library functions were overriding errno.
[Verification] Cordova file tests pass.
Change-Id: If84de57e994b5255b1d51006803254f4fe90811b
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Lukasz Bardeli [Wed, 24 Apr 2019 08:54:56 +0000 (10:54 +0200)]
[MediaController] getItems and getAllPlaylists implemented.
- getItems
- server getAllPlaylists
- client getAllPlaylists
[Verification] Code compiles without error. Tested in chrome console
ACR: TWDAPI-199
Change-Id: Idd6594b76d52eeb6e96574f2fbcd5bf82a2245dc
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Dawid Juszczak [Fri, 19 Apr 2019 08:52:17 +0000 (10:52 +0200)]
[fix][Content] readonly atributes since 5.5
this change prevents user from modify
content.geolocation attributes
[Verification]
- tested on chrome console
Change-Id: Ia5e887d6029124e8eb3c0830391506632db16813
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
[Content] isFavorite added to editableAttributes array
[Bug] Since 2.3 isFavorite is an editableAttribute, which was missing
in editableAttributes array. Now added it there.
[Verification] Code compiles without errors.
Change-Id: Ib5266a66920f0050fd5c25287602514bc4ea3762
Lukasz Bardeli [Thu, 18 Apr 2019 05:46:26 +0000 (07:46 +0200)]
[MediaController] Add listener playlist updated.
Add methods
- addPlaylistUpdatedListener
- removePlaylistUpdatedListener
[Verification] Code compiles without error. Tested in chrome console
ACR: TWDAPI-199
Change-Id: Iec717785c4e12ad464d9a302d1b1ccc98ff16acf
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Dawid Juszczak [Wed, 17 Apr 2019 15:09:15 +0000 (17:09 +0200)]
[fix][content] Deprecate filtering attributes
fixed error with printing deprecation warning
[verification]
builded succesfully
tested on mobile device - everything looks fine
Change-Id: If6bc3cab368696d1a74e35805b78b35572669c2b
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
[version] 2.43
Change-Id: I25d5811f20d31f4034841ed106ab43c249fb0c59
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Piotr Kosko [Wed, 17 Apr 2019 11:53:50 +0000 (11:53 +0000)]
Merge "[Content] Some attributes are readonly since 5.5" into tizen
[Content] Some attributes are readonly since 5.5
[Feature] name, description, rating, geolocation and orientation attributes are
readonly since 5.5.
For backward compatibility, the attributes are allowed for modifications for
apps with required version lower than 5.5
modified editableAttributes member also to remove readonly attributes from this array.
[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-203
[Verification]
TCT passrate 100% when running with 5.0 TCT - backward compatibility.
14 fails on latest TCT, TCT passrate 100% with TCT fixed by TCT team.
Change-Id: I8382372c51105fb7e11c3037d5994e2de76d59fa
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Piotr Kosko [Wed, 17 Apr 2019 10:35:16 +0000 (10:35 +0000)]
Merge "[Project][Codeformat] Added prettier as partial formatter for JS" into tizen_3.0